Hermet Park [Tue, 18 Sep 2018 02:48:13 +0000 (11:48 +0900)]
efl gfx_path: prevent buffer overflow.
Summary:
the counter must be less than 7,
don't allow to over the index.
@fix
Reviewers: #committers
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7053
Change-Id: I35fd1ebf0f1ca0068be306fbe56e72f846eba338
Hermet Park [Mon, 17 Sep 2018 12:42:22 +0000 (21:42 +0900)]
evas vg: don't close file before deleting cache entry.
Since internal eina file could be referred in vg cache,
vg should not close it before deleting cache_entry.
Change-Id: Icc51c609aef5642f834e9a04c427745a1364665b
Bryce Harrington [Fri, 14 Sep 2018 02:50:03 +0000 (11:50 +0900)]
evas vg: Check if could not open file for a vg canvas
eina_file_open() returns NULL under various circumstances such as not
being able to find the file or not having read permission, for example.
Change-Id: Ifcf9f3839fadebe6d2628751a038ac13b6dd1cf5
Bryce Harrington [Fri, 14 Sep 2018 02:47:52 +0000 (11:47 +0900)]
evas vg: Check for OOM when setting root node in a vg canvas
Change-Id: I7597f567be9579adcaedf3db113a66dbd773b211
Bryce Harrington [Fri, 14 Sep 2018 02:45:24 +0000 (11:45 +0900)]
evas vg: Check for OOM in evas_cache_vg_entry_create
Change-Id: I201f5f8fe8c12aa172a979b6f9e8e6cb2cbd78f4
Bryce Harrington [Fri, 14 Sep 2018 02:42:02 +0000 (11:42 +0900)]
evas vg: fix minor typo.
Change-Id: I7e1c7bda6042be42b5cb0c5abb14d685beee8b32
Youngbok Shin [Fri, 14 Sep 2018 05:39:04 +0000 (14:39 +0900)]
edje: add json file support feature
It also starts to support following new edc properties.
1. frame
desc { "default"
vector {
frame: 0.5; // 0.0 ~ 1.0
}
}
2. actions
program { "vector_animation";
// VG_ANIM_PLAY, VG_ANIM_PLAY_BACK, VG_ANIM_LOOP,
// VG_ANIM_STOP, VG_ANIM_PAUSE, VG_ANIM_RESUME
action: VG_ANIM_PLAY;
target: "your_vector_part";
}
Change-Id: If93fdbe68b6af7a2f66e47e3eb8a5bc490e29d23
Juyeon Lee [Fri, 17 Aug 2018 08:06:22 +0000 (17:06 +0900)]
evas_engine: add fn_serial_get to get current serial number
Add to get current serial number from evas engine
@tizen_only
Change-Id: I125159f47a92eacbb96df715527573572c95d7a2
Bowon Ryu [Fri, 14 Sep 2018 04:57:36 +0000 (13:57 +0900)]
Revert "elm_toolbar: fix _item_visiblity"
this commit caused toolbar resizing issue.
This reverts commit
5b90da46b76e0428e1fbbba7a43cdcfde921af75.
Change-Id: Iccb870122bec3952f67f0a8dc7a3ed529d9b32c9
Hermet Park [Wed, 12 Sep 2018 07:23:01 +0000 (16:23 +0900)]
evas json: fix missing ';' - #12
@feature
Change-Id: I0f10a4ed1010a1fa93a9e78daecd450bc0df7e56
Hermet Park [Tue, 11 Sep 2018 11:49:17 +0000 (20:49 +0900)]
evas json: support efl_canvas_vg_file_mmap_set() - #11
example)
...
Eina_File *file = eina_file_virtualize(NULL, data, strlen(data), EINA_TRUE);
eina_file_mmap_set(vg, file, key);
...
eina_file_close(file);
@feature
Change-Id: I4ccfa1dc46f274e0d4838b5dccee58126802743a
Hermet Park [Fri, 7 Sep 2018 11:58:19 +0000 (20:58 +0900)]
evas vg: changed "vg object" to just "vg"
just keep our naming rule along with other primitives.
i.e. efl_canvas_rect, efl_canvas_image, efl_canvas_vg ...
Change-Id: I49c96b4a535cd2fed29a07ec20375a2efd1682af
Hermet Park [Fri, 7 Sep 2018 11:37:26 +0000 (20:37 +0900)]
evas json: revise implementation along with lottie player - #10
lottie-player API has been changed to lottie-animation.
@feature
Change-Id: I7dd04326de713969a2b51b5de0d52e9b243b782f
Hermet Park [Wed, 5 Sep 2018 11:13:08 +0000 (20:13 +0900)]
evas json: fix json loader configuration. - #9
lottie-player detection is not correct.
fix configure to enable/disable it automatically.
@feature
Change-Id: I286341164490b6b89ba0cf7fcd28aba9ba7721bd
Hermet Park [Tue, 4 Sep 2018 05:31:41 +0000 (14:31 +0900)]
evas json: new feature for lottie - #8
add example.
@feature
Change-Id: I71996519e21bb63ce9bdc4b357e98775500b6c4d
Hermet Park [Mon, 3 Sep 2018 12:00:55 +0000 (21:00 +0900)]
evas json: new feature for lottie - #7
Support caching mechanism properly if multiple instances share one resource.
@feature
Change-Id: I3617cf52a51a237c19a424c076d435e01b3e3228
Hermet Park [Fri, 31 Aug 2018 11:20:39 +0000 (20:20 +0900)]
evas json: new feature for lottie - #6
fix a crash case if no file data.
@feature
Change-Id: If3ed044a74fa197337b6ca7c4374f94f050ef91c
Hermet Park [Fri, 31 Aug 2018 11:03:39 +0000 (20:03 +0900)]
evas json: new feature for lottie - #5
fix broken svg/eet compatibility.
@feature
Change-Id: Ifd607b4abe27b402b57bfee2d951735c9e8027f1
Hermet Park [Fri, 31 Aug 2018 06:21:18 +0000 (15:21 +0900)]
evas json: new feature for lottie - #4
vg inherits efl_gfx_image_animation_controller to support animation.
@feature
Change-Id: Ib0b420271d4c5cc22d5f345b7fd5f72a6a44992e
Hermet Park [Fri, 31 Aug 2018 06:05:23 +0000 (15:05 +0900)]
evas vg: code refactoring.
give svg prefix of vg common functions (only for svg functions)
Change-Id: I29627d0ec958362336c909f9e2b1d1d246fcfac2
Hermet Park [Thu, 30 Aug 2018 11:26:41 +0000 (20:26 +0900)]
evas json: new feature for lottie - #3
++implementation to draw first image.
@feature
Change-Id: I8f2fbab042c91b54726b8805f494a4b6264ca42b
Hermet Park [Wed, 29 Aug 2018 12:49:31 +0000 (21:49 +0900)]
evas json: new feature for lottie - #2
1. polish canvas vg/cache infrastructure code.
2. expand loader module interfaces - open/close/data
then reconstruct based on it.
3. fix to close vg cache data properly.
@feature
Change-Id: Ic23926db4b545bbd3fc6ae55dd851c06b8c147b4
Hermet Park [Tue, 21 Aug 2018 10:41:31 +0000 (19:41 +0900)]
evas json: new feature for lottie - #1
set up infrastructure for json loader.
@feature
Change-Id: I1a12ad306da2db9b90150a9df5d9e49b5e0e5f7e
Hermet Park [Thu, 13 Sep 2018 09:59:00 +0000 (18:59 +0900)]
Revert "Revert "Revert "Revert "evas image: fix a bug in image preloading.""""
This reverts commit
d91b043750bc8672cf6b9648cfcdae95c5b54b30.
fixed TC - https://review.tizen.org/gerrit/#/c/189099/
Gwanglim Lee [Thu, 13 Sep 2018 09:24:35 +0000 (18:24 +0900)]
evas canvas: fix null possibility of evas_object_above_get().
fix null object return when trying to get an object
above the current object and a layer with no objects is present.
probably a layer not being cleaned somewhere.
Reviewed By: Hermet
@fix
Change-Id: Iffacaf6f3fd62771d208b611f96ecde77260e498
Shinwoo Kim [Thu, 13 Sep 2018 05:20:32 +0000 (14:20 +0900)]
Revert "evas: fix child position when the container is moved"
This reverts commit
c59a8ddebc6d1d8fd4f6c9855b7c8cb1c50a6c6e.
*Reason: Failed TC
Shinwoo Kim [Thu, 13 Sep 2018 04:59:06 +0000 (13:59 +0900)]
Revert "Revert "Revert "evas image: fix a bug in image preloading."""
This reverts commit
e887948f90b244d3f7c55862c4b56a47e7d83817.
*Reason: There is failed TC.
Jiyoun Park [Tue, 11 Sep 2018 08:25:40 +0000 (17:25 +0900)]
eina_debug: add env to turn off the eina cpu debug
sometimes eina_debug_cpu causes deadlock.
and some app has limitation the number of thread, bug this cpu increase thread number.
so add method to turn on/off eina cpu debug.
Change-Id: I25a0cf61765eaa0deebeabeffa0825116eacf4f4
Juyeon Lee [Mon, 13 Aug 2018 01:45:42 +0000 (10:45 +0900)]
ecore_wl2_display: add tizen_move_resize for client demand move resize
Client window is driven its move,resize by display server using xdg_shell.
btw some tizen application wants to make its position and size while they're shown
server received tz_position, and resized buffer in consequence so far.
but client's position, and buffer delivery does not always come to server at the
same idler loop. In that case, user could see move first, and resize after a sec.
here, added new wl protocol and ecore_wl2_window_sync_geometry_set api to make
move and resize happen at the sametime.
@tizen_only
Change-Id: If4bd8153c0842cce82333d02278e23f6d7e2402c
SangHyeon Jade Lee [Mon, 10 Sep 2018 06:29:11 +0000 (15:29 +0900)]
elm_gengrid: fix item_show / bring_in deferred call.
item_show / bring_in will be deferred, if object is not resized properly.
the deferred call of item_show_region() is on the calc_job(),
after calculating proper object, pan size, but still item is not placed,
so target scrolling position is wrong while item_show_region().
move deferred call to group_calculate() to get correct item position,
after item_place() and group_item_place() were processed.
this is port of upstream patch D7014
Change-Id: I3a2842f75fb4b46a8ea5c5eab7df8cf03e068102
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Myoungwoon Roy, Kim [Tue, 11 Sep 2018 04:14:33 +0000 (13:14 +0900)]
Revert "evas: replace a current copy color function for neon"
This reverts commit
aa2db962b00b68ff6df411a84dfe69c7c5cb00a9.
Marcel Hollerbach [Sat, 8 Sep 2018 12:19:04 +0000 (14:19 +0200)]
efl_ui_focus_util: refactor the util for focusing objects
the previous code had the problem that we moved focus onto logical
objects which were not having any children, thus we saw errors from the
focus manager.
Now we are checking if we are able to deliver focus onto a child of the
passed user.
Differential Revision: https://phab.enlightenment.org/D7009
Jaehyun Cho [Mon, 10 Sep 2018 11:29:24 +0000 (20:29 +0900)]
efl: Remove unnecessary abstract/class inheritance
Summary:
Remove unnecessary abstract and class inheritance from eo file because
those abstracts and classes are duplicate.
e.g. if class B (class A) in B.eo file, then class C (class A, class B) in C.eo file.
Reviewers: woohyun, felipealmeida, Hermet, bu5hm4n
Reviewed By: Hermet, bu5hm4n
Subscribers: bu5hm4n, cedric, segfaultxavi, q66, #reviewers, lauromoura, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6982
Yeongjong Lee [Mon, 10 Sep 2018 11:22:52 +0000 (20:22 +0900)]
elm: add missing efl_ui_popup_part_backwall header
Summary:
efl_ui_popup_part_backwall.eo.h is needed for repeat_events method.
ref
31be3af62d5dfdaa8a468916aa48e3899d6b0217
Test Plan: make
Reviewers: Jaehyun_Cho, Hermet
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7015
Hermet Park [Mon, 10 Sep 2018 08:27:42 +0000 (17:27 +0900)]
Revert "evas vg: changed "vg object" to "vg""
This reverts commit
ec69abed9d63e7876238dffc4b0d3398d1cd1be1.
Ooops, I didn't intended this patch. @#!@#!@#!@#
Hermet Park [Mon, 10 Sep 2018 08:26:12 +0000 (17:26 +0900)]
evas image: remove duplicated EINA_UNUSED specifier.
Hermet Park [Fri, 7 Sep 2018 11:58:19 +0000 (20:58 +0900)]
evas vg: changed "vg object" to "vg"
Summary:
Following our naming rule, rename to like other primitives.
i.e. efl_canvas_rect, efl_canvas_image, efl_canvas_vg ...
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7013
Wonki Kim [Mon, 10 Sep 2018 04:36:09 +0000 (13:36 +0900)]
evas: replace a current copy color function for neon
Summary:
current copy color function has problem sometime on a arm neon environment.
inline asm code makes crashing problem.
so that this patch replace the asm code with a function which is a part of pixman project.
Reviewers: cedric, Hermet
Subscribers: kimcinoo, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6922
Jaehyun Cho [Mon, 10 Sep 2018 04:29:54 +0000 (13:29 +0900)]
efl_ui_popup: Remove inheritance from Efl.Canvas.Object
Summary:
Class Efl.Ui.Popup_Part_Backwall inherits from multiple classes,
class Efl.Ui.Layout.Part and abstract Efl.Canvas.Object.
To remove multiple class inheritance, Efl.Canvas.Object is not
derived and its property, repeat_events, is newly defined in
Efl.Ui.Popup_Part_Backwall.
Test Plan:
1. Execute elementary_test.
2. Select Efl.Ui.Popup.
3. Select "Show Dummy Button".
4. Select "Repeat Event Set".
5. Test if repeat event works.
Reviewers: woohyun, felipealmeida, Hermet, segfaultxavi
Reviewed By: Hermet, segfaultxavi
Subscribers: bu5hm4n, q66, cedric, segfaultxavi, lauromoura, #reviewers, herb, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6984
Alastair Poole [Sun, 9 Sep 2018 20:19:31 +0000 (21:19 +0100)]
elm_code_file: preserve file permissions on save.
Test Plan:
* Run Edi (Python project)
* Edit setup.py
* Run build
* Permissions should be preserved.
* setup.py should build.
Reviewers: ajwillia.ms
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7008
Bryce Harrington [Sat, 8 Sep 2018 11:19:53 +0000 (07:19 -0400)]
eina: Add doxygen in/out tags for remaining APIs
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7007
Hermet Park [Fri, 7 Sep 2018 10:17:35 +0000 (19:17 +0900)]
Revert "Revert "evas image: fix a bug in image preloading.""
This reverts commit
72c84e412b7d497a9110d7feb9b9e916e3535911.
Hosang Kim [Fri, 7 Sep 2018 04:28:52 +0000 (13:28 +0900)]
Revert "evas image: fix a bug in image preloading."
This reverts commit
9440c9aca3b19c7c8a7542d8863358c1957c7c33.
Change-Id: I7590dc65e689ee3de6f539735003cb8d312a4249
Jiyoun Park [Thu, 6 Sep 2018 06:16:36 +0000 (15:16 +0900)]
ecore_wl2: fix crash related with double free
Change-Id: I7f2b7a3710b65b5f64d6c098a6fdc84ee2467e8d
JengHyun Kang [Wed, 5 Sep 2018 09:19:01 +0000 (18:19 +0900)]
evas_events: support single touch's extra axis information
Change-Id: I4c4b433fa8230b13d789223812f7a0fa5d98fbe1
Yeongjong Lee [Fri, 31 Aug 2018 08:45:31 +0000 (17:45 +0900)]
docs: Fix typos in API reference doc and comments.
Reviewers: Hermet, segfaultxavi
Reviewed By: Hermet, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6948
Change-Id: Id5c989a79954f1339cba70f1168cad4ba7e494f7
Yeongjong Lee [Mon, 3 Sep 2018 00:23:30 +0000 (09:23 +0900)]
docs: Fix typos and some wrong expressions in API reference doc.
Change-Id: I3305a4a119b9664f918a04dd3af437bf6bb46d78
Hermet Park [Mon, 3 Sep 2018 06:19:02 +0000 (15:19 +0900)]
evas image: fix a bug in image preloading.
Summary:
Current preloading is too buggy since it's on thread-based.
This is a fundamental improvement to fix a bug.
The critical issue here is,
When preloading img object suddenly cancel its preloading,
the object possibly cannot render image next then because
renderer doesn't have any idea when async cancelling is
finished. Renderer just tries to render regardless of
image loading status, and this could occur no-texture(in gl case)
image object.
So, here improvement is, adding a notification for async cancelled
so that putting img objects to redraw images properly after their preloading is
cancelled.
The best scenario to reproduce this bug is this one.
Evas_Object *img2 = evas_object_image_filled_add(evas);
evas_object_image_file_set(img2, "test.jpg", NULL);
evas_object_image_preload(img2, EINA_FALSE);
evas_object_resize(img2, 200, 200);
evas_object_show(img2);
Evas_Object *img = evas_object_image_filled_add(evas);
evas_object_image_file_set(img, "test.jpg", NULL);
evas_object_image_preload(img, EINA_FALSE);
evas_object_move(img, 200, 200);
evas_object_resize(img, 200, 200);
evas_object_show(img);
evas_object_image_preload(img2, EINA_TRUE);
If you run this on gl backend, occasionally happens rendering fail.
Yet there other bugs on preloading feature....
@fix
Reviewers: #committers, raster
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6919
Signed-Off-By: Hermet Park <chuneon.park@samsung.com>
Change-Id: I078e68cba2a8c0134ae9c6273c7879b166619427
SangHyeon Jade Lee [Thu, 30 Aug 2018 11:21:09 +0000 (20:21 +0900)]
elm_genlist: item scroll show sould be processed after block calculation
This patch is port of upstream patch
6dd149d8fef662a8c938b8335fc311caeef89911
Summary:
there are buggy actions in the item show api,
when the list is launched, scroll to far distance item.
the reason is item_scroll is called before it's block is fully
calculated in calc_job().
the origin patch of cause the issue is
f6b66cc1d3b94bedc25cb10bd5317855954af973
by raster in 28 Nov, 2013
but we already do some extra works in calc_job(),
so the code is not necessarily called in queue_process().
more detail descriptions :
mainly this caused by block width size,
so the normal case block width is zero, and item_scroll() will be dismissed,
and deferred action in calc_job(), but in issue case,
block width is already been set, so it can scroll the item directly though
they aren't properly calculated yet.
most cases block was generated in the same queue processing so width size is
not exist, but in issue cases, they re-using the block which was already been
generated by previous queue processing, so the width size is already exist,
but height is not properly calculated yet.
we could move the block height calculation and min/max calculation
in the queue processing, but I'm afraid to face side effect,
so removing item_scroll() call is best option that I got.
Change-Id: Ib3bfcde0eec23c9e7a8363876d7c2ec0f39fccc0
Hermet Park [Thu, 30 Aug 2018 04:26:06 +0000 (13:26 +0900)]
evas cache: refactor internal logic.
Summary:
Adding cache targets in other modules are inproper.
This can't be managed by cache module inside.
One representive scenario is,
when preload cancel is triggered, preload canceling sequence
can't be performed properly because cache targets implicitly were
increased by backend modules.
And then, Cache itself couldn't get notified it.
see this condition.
if ((!ie->targets) && (ie->preload) && (!ie->flags.pending))
in _evas_cache_image_entry_preload_remove()
Consequently, I move preloaded callbacks to sync with adding cache targets,
not to add by backed engines themselves.
This will bring Cache to manage cache targets properly.
Reviewers: #committers, raster
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6912
Change-Id: I85312f2c16f594260ee3aa7895c283a3de782eb3
Signed-Off-By: Hermet Park <chuneon.park@samsung.com>
Hermet Park [Thu, 30 Aug 2018 04:17:44 +0000 (13:17 +0900)]
evas cache: remove unused custom task in preload.
Summary:
That redundant code just made code complex.
This is one of intermediate patches for preload
Reviewers: raster, #committers
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6907
Change-Id: I684e7dbee8455abeb9c9cc7b15056c7de5cd43b5
Signed-Off-By: Hermet Park <chuneon.park@samsung.com>
Hermet Park [Thu, 30 Aug 2018 04:14:13 +0000 (13:14 +0900)]
evas gl: skip twice texture upload.
Summary:
While debugging a problem,
found a hole that upload texture twice unnecessary.
Here is the scenario.
Set up two objects with same image resource plus both preloading - obj1, obj2;
After image preloading,
_evas_cache_image_async_end() will be triggered.
=> ie->flags.update_data = true;
then first obj1 is gonna drawing,
Since it doesn't have any texture uploaded yet,
it will create a texture and upload texture data as well.
along with below sequence.
=> else if (!im->tex && !ie->load_error)
After it, second obj2 is gonna drawing.
But actually its texture is already readied after obj1,
it doesn't need to upload texture agin.
But still ie->flag.update_data == true, it will do dumbly.
Reviewers: #committers, devilhorns, raster
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6902
Change-Id: I51026f415a54044e9ff2e49d2c050a2727ec9a32
Signed-Off-By: Hermet Park <chuneon.park@samsung.com>
Myoungwoon Roy, Kim [Thu, 30 Aug 2018 05:01:21 +0000 (14:01 +0900)]
docs: Fix typos and some wrong expressions in API reference doc.
Summary: I had fixed some typos and some wrong expressions in API reference doc
Test Plan: N/A
Reviewers: raster, zmike, Hermet, segfaultxavi
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6943
Change-Id: I01474b99fa760c6ee481cdc194c00e5d789e1e7d
seungwan woo [Wed, 29 Aug 2018 01:39:30 +0000 (10:39 +0900)]
Edje_Common.h : tag @since_tizen info
Refs:
9aab04951db1416bb7fde4488f7f058621b7bdad
Change-Id: I78c47e1e02d2a880232e30730f05288ae388c7cc
Signed-off-by: seungwan woo <s-w.woo@samsung.com>
Derek Foreman [Fri, 26 Jan 2018 21:51:44 +0000 (15:51 -0600)]
ecore_wl2: Make session recovery more robust
Clear out the window callback when doing session recovery, and
make sure we have a valid on if we get a double commit.
This should stop a session recovery crash, and fix a small leak per
recovery.
Change-Id: I5208d210f46bf463c32611b0dac7db15227f244f
YeongJong Lee [Fri, 25 May 2018 10:31:29 +0000 (19:31 +0900)]
elm_genlist: remove duplicated condition
see also,
436e07277
Change-Id: I99a3f1ef4ea05a495a46967eb4eb69244245d0e1
Taehyub Kim [Fri, 7 Sep 2018 10:07:53 +0000 (19:07 +0900)]
elm_interface_scrollable: remove unused value
Change-Id: Ia6fbe1844cfef949aece24f06cf8fa9eb04b5031
Taehyub Kim [Fri, 7 Sep 2018 08:43:26 +0000 (17:43 +0900)]
evas: call evas_find before safety check
@fix
Change-Id: I97a313687663d845c6601a7fe43bd086bdc22dc6
Chris Michael [Thu, 6 Sep 2018 13:21:55 +0000 (13:21 +0000)]
elementary: Check for valid focus manager before starting do loop
Apparently there are cases where efl_ui_focus_object_focus_manager_get
can return NULL. In order to trap for this, we can simply modify the
do loop slightly and check for a valid manager before we actually
start looping
Test Case: elementary_test -to "Panel Scrollable" and click Toggle
button
ref T7030
Differential Revision: https://phab.enlightenment.org/D6704
Marcel Hollerbach [Fri, 24 Aug 2018 13:49:07 +0000 (13:49 +0000)]
efl_ui_focus_manager: do not adjust values on a inactive manager
The bug this fixes can be observed when opening elm_test with hoversel.
The problem here is that the focus manager gets operations called on it after it is not active anymore, which lead to the fact that focus was restored on something that was about to be deleted.
Differential Revision: https://phab.enlightenment.org/D6903
Xavi Artigas [Thu, 6 Sep 2018 15:10:51 +0000 (12:10 -0300)]
efl-mono: Make eina_list return the list
Summary:
eina_list_reverse() returns the list, the C# version should do the same.
This fixes the reference/csharp/eina/src/eina_list.cs example.
Fixes T7112
Test Plan: The eina_list.cs example works after this change.
Reviewers: lauromoura, vitor.sousa, felipealmeida
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7112
Differential Revision: https://phab.enlightenment.org/D6995
Alastair Poole [Wed, 5 Sep 2018 20:17:40 +0000 (21:17 +0100)]
elm_code: make the hoversel not focusable.
Summary: Disabling focus prevents incorrect operations.
Test Plan:
With EDI, use mouse (cut/copy/paste).
Due to the focus passing to the hoversel we break focus in the
application when it's lost. By disabling this cut/copy/paste
works as it should. A similar approach was used in elm_entry.
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6986
Lauro Moura [Wed, 5 Sep 2018 17:25:11 +0000 (14:25 -0300)]
efl-csharp: Fix event callback removal.
Summary:
Use the native event loaded from dlsym directly instead of wrapping it
in a Event_Description structure.
Fixes: T7355
Reviewers: felipealmeida, vitor.sousa, segfaultxavi
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl_language_bindings
Differential Revision: https://phab.enlightenment.org/D6981
Lauro Moura [Wed, 5 Sep 2018 17:07:28 +0000 (14:07 -0300)]
efl-csharp: Make sure efl_finalize overrides are callable
Summary:
efl_finalize override is called inside efl_add_end. Previously by this
time the constructor still hadn't saved the C# wrapper handle into the
Eo instance private data, to be recovered in the static delegates that
call the C# overrides.
This commit just changes the order to save the C# handle *before*
calling efl_add_end.
Test Plan: added unit test to be run with make check
Reviewers: felipealmeida, vitor.sousa, Jaehyun_Cho
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6956
Daniel Kolesa [Wed, 5 Sep 2018 11:12:05 +0000 (13:12 +0200)]
elua: make old documentation generator generate instead of failing
While a rewritten template-based doc generator is pending addition
into a separate repository, at least fix this one so that it works
in case we decide to go back to it, because right now it's just
failing because of out of date code.
The fixes here are based on the revamped documentation generator
that will be introduced.
Daniel Kolesa [Wed, 5 Sep 2018 11:09:57 +0000 (13:09 +0200)]
elua: fix outdated code in doc token ref resolution
This function was using outdated enum fields. This was fixed
on my local side but somehow never made it in, so make this code
make sense.
Jaehyun Cho [Wed, 5 Sep 2018 07:54:40 +0000 (16:54 +0900)]
Revert "efl: Remove unnecessary abstract/class inheritance"
This reverts commit
4067fafe07c4d22ac2e2672921c268ae8866029f.
As commented on D6982, the original patch changes the widget's behavior.
e.g. Efl.Ui.Win cannot be called with Efl.Config_Gloabal APIs.
Elm.Combobox cannot provide events of Button and Hover.
Until the above changes are resolved, the original patch is reverted.
Jaehyun Cho [Wed, 5 Sep 2018 05:32:51 +0000 (14:32 +0900)]
efl_ui_popup: Replace class Efl.Ui.Popup_Part with Efl.Ui.Popup_Part_Backwall
Class Efl.Ui.Popup_Part is used only for part "backwall".
Therefore, class Efl.Ui.Popup_Part is replaced with class
Efl.Ui.Popup_Part_Backwall.
Jaehyun Cho [Wed, 5 Sep 2018 06:05:23 +0000 (15:05 +0900)]
efl: Remove unnecessary abstract/class inheritance
Summary:
Remove unnecessary abstract and class inheritance from eo file because
those abstracts and classes are duplicate.
e.g. if class B (class A) in B.eo file, then class C (class A, class B) in C.eo file.
Reviewers: woohyun, felipealmeida, Hermet
Reviewed By: Hermet
Subscribers: cedric, segfaultxavi, q66, #reviewers, lauromoura, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6982
Shinwoo Kim [Tue, 4 Sep 2018 10:54:17 +0000 (11:54 +0100)]
ecore_event: initialize uninitialized variable
Summary:
The following commit (1) made an abort (2)
(1) commit
d1e4c6bab84e55837a70b8883a28e7eb6d49db09
Author: Jean Guyomarc'h <jean@guyomarch.bzh>
Date: Mon Aug 27 12:04:35 2018 +0900
ecore: fix built-in event types generation
(2) abort
/lib/x86_64-linux-gnu/libc.so.6(+0x777e5)
/lib/x86_64-linux-gnu/libc.so.6(+0x8037a)
/lib/x86_64-linux-gnu/libc.so.6(cfree+0x4c)
/home/kimcinoo/install/lib/libecore.so.1(+0x237d7)
/home/kimcinoo/install/lib/libeo.so.1(efl_destructor+0x64)
/home/kimcinoo/install/lib/libeo.so.1(+0x18029)
/home/kimcinoo/install/lib/libeo.so.1(efl_unref+0x44c)
/home/kimcinoo/install/lib/libecore.so.1(+0x201f2)
/home/kimcinoo/install/lib/libecore.so.1(ecore_shutdown+0x145)
/home/kimcinoo/Upstream/efl/src/tests/ecore/.libs/lt-efl_app_suite(+0xb85d)
/home/kimcinoo/install/lib/libcheck.so.0(srunner_run_tagged+0xa13)
/home/kimcinoo/Upstream/efl/src/tests/ecore/.libs/lt-efl_app_suite(+0xead9)
/home/kimcinoo/Upstream/efl/src/tests/ecore/.libs/lt-efl_app_suite(+0x4ade)
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)
/home/kimcinoo/Upstream/efl/src/tests/ecore/.libs/lt-efl_app_suite
And following commit (3) fixed the abort.
(3) commit
3f306491a32a1880bccfe64861b5fec2ba09049b
Author: Yeongjong Lee <cleanlyj@naver.com>
Date: Mon Sep 3 15:55:13 2018 +0000
ecore_event: fix ecore event handler iterator range
The above commit fixed the abort though, we could access uninitialized memory
and make another abort again. This would prevent such unwanted case.
Reviewers: Hermet, YOhoho, bu5hm4n, netstar
Reviewed By: netstar
Subscribers: netstar, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6970
Yeongjong Lee [Tue, 4 Sep 2018 08:40:06 +0000 (17:40 +0900)]
edje_calc: remove unused variable
Summary: those variables should be removed at
05e3e450e5ecb67f80c1be3df8ab7a08e8d33da2
Reviewers: eagleeye
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6968
Shinwoo Kim [Tue, 4 Sep 2018 05:58:10 +0000 (14:58 +0900)]
tests: fix a build error on the 0.12.0 check
Summary:
(1) EFL_START_TEST(TEST_NAME) is defined as follows if you are using
the 0.12.0 check:
START_TEST(TEST_NAME) \
_timing_start();
(2) START_TEST(__testname) is defined as follows
(To make it simple I am using 'blah-blah' here):
static void __testname_fn (blah-blah);\
static const TTest __testname_ttest = { blah-blah };\
static const TTest * __testname = & __testname_ttest;\
static void __testname_fn (blah-blah)
For example we are using as follows in a test case:
EFL_START_TEST(evas_object_smart_paragraph_direction)
{
...
}
EFL_END_TEST
This made a build error.
Test Plan: make check
Reviewers: Hermet, zmike
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6969
Woochanlee [Tue, 4 Sep 2018 00:37:00 +0000 (09:37 +0900)]
Clean up efl_ui_XXX eo files.
Summary:
Delete unnecessary interface references.
Delete unnecessary annotations.
Reviewers: Hermet, Jaehyun_Cho, zmike
Reviewed By: Hermet
Subscribers: segfaultxavi, q66, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6945
Felipe Magno de Almeida [Tue, 4 Sep 2018 00:10:56 +0000 (09:10 +0900)]
eolian-cxx: Fix parallel compilation for eolian_cxx_test_wrapper.cc
Summary: Test wasn't defining its own dependencies explicitly, which caused race conditions.
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6959
Hermet Park [Tue, 4 Sep 2018 00:08:26 +0000 (09:08 +0900)]
evas canvas: fix overflowed function initialization.
Summary:
last function pointer indicates render_pre(),
add one more element is unnecessary.
Reviewers: #committers, netstar
Reviewed By: #committers, netstar
Subscribers: netstar, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6967
Lauro Moura [Mon, 3 Sep 2018 19:19:21 +0000 (16:19 -0300)]
efl-csharp: Use value_new/free for wrapped values
Summary:
Using malloc/free as it was used before would cause double frees and
other issues when mixing with eina_values created from the value
mempool inside Eina.
Fixes T7359
Reviewers: felipealmeida, vitor.sousa, segfaultxavi
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7359
Differential Revision: https://phab.enlightenment.org/D6958
Yeongjong Lee [Mon, 3 Sep 2018 15:55:13 +0000 (15:55 +0000)]
ecore_event: fix ecore event handler iterator range
event handler start at 1 (see _ecore_event_message_handler_type_new and
_ecore_event_message_handler_efl_object_constructor) so that handlers[0] is not
allocated. this patch avoid invalid memory access.
this fixes T7349
Differential Revision: https://phab.enlightenment.org/D6966
Marcel Hollerbach [Mon, 3 Sep 2018 09:54:18 +0000 (11:54 +0200)]
build: add keymapheader to dist tarbal
Differential Revision: https://phab.enlightenment.org/D6962
Hermet Park [Mon, 3 Sep 2018 06:19:02 +0000 (15:19 +0900)]
evas image: fix a bug in image preloading.
Summary:
Current preloading is too buggy since it's on thread-based.
This is a fundamental improvement to fix a bug.
The critical issue here is,
When preloading img object suddenly cancel its preloading,
the object possibly cannot render image next then because
renderer doesn't have any idea when async cancelling is
finished. Renderer just tries to render regardless of
image loading status, and this could occur no-texture(in gl case)
image object.
So, here improvement is, adding a notification for async cancelled
so that putting img objects to redraw images properly after their preloading is
cancelled.
The best scenario to reproduce this bug is this one.
Evas_Object *img2 = evas_object_image_filled_add(evas);
evas_object_image_file_set(img2, "test.jpg", NULL);
evas_object_image_preload(img2, EINA_FALSE);
evas_object_resize(img2, 200, 200);
evas_object_show(img2);
Evas_Object *img = evas_object_image_filled_add(evas);
evas_object_image_file_set(img, "test.jpg", NULL);
evas_object_image_preload(img, EINA_FALSE);
evas_object_move(img, 200, 200);
evas_object_resize(img, 200, 200);
evas_object_show(img);
evas_object_image_preload(img2, EINA_TRUE);
If you run this on gl backend, occasionally happens rendering fail.
Yet there other bugs on preloading feature....
@fix
Reviewers: #committers, raster
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6919
Yeongjong Lee [Mon, 3 Sep 2018 01:55:16 +0000 (10:55 +0900)]
docs: Fix typos in API reference doc
Reviewers: segfaultxavi, kimcinoo
Reviewed By: kimcinoo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6960
Alastair Poole [Fri, 31 Aug 2018 16:41:43 +0000 (17:41 +0100)]
elm_code: fix DEL at end of line.
Summary:
In one case we do not want to move the cursor.
When merging up with DEL the cursor should
remain on the same line.
Test Plan: Cursor at end of line, press delete.
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6957
Yeongjong Lee [Fri, 31 Aug 2018 08:46:25 +0000 (17:46 +0900)]
elm_interface_scrollable: add 1 space after if keyword
Reviewers: Hermet, akanad, SanghyeonLee
Reviewed By: Hermet, SanghyeonLee
Subscribers: SanghyeonLee, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6954
Yeongjong Lee [Fri, 31 Aug 2018 08:45:31 +0000 (17:45 +0900)]
docs: Fix typos in API reference doc and comments.
Reviewers: Hermet, segfaultxavi
Reviewed By: Hermet, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6948
Yeongjong Lee [Fri, 31 Aug 2018 03:31:55 +0000 (12:31 +0900)]
elm_interface_scrollable: fix wrong pointer reference
Reviewers: akanad
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6955
Hermet Park [Fri, 31 Aug 2018 03:14:29 +0000 (12:14 +0900)]
efl: vector is no more beta version.
Yeongjong Lee [Thu, 30 Aug 2018 05:02:34 +0000 (14:02 +0900)]
elm_panel: fix mirrored_set work correctly
Summary:
When elm_panel isn't scrollable, It can't pass `if (!sid->edje_obj) return;` in
_elm_interface_scrollable_efl_ui_base_mirrored_set. so elm_panel's mirrored_set
didn't work. we neet to consider non-scrollable panel.
Test Plan:
1. elementary_test
2. Open 'Panel' and 'Panel Scrollable'
3. Turn on UI-Mirroring on Elementary Tests window.
4. Check that mirror mode works correctly.
Reviewers: Hermet, Jaehyun_Cho
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6944
Myoungwoon Roy, Kim [Thu, 30 Aug 2018 05:01:21 +0000 (14:01 +0900)]
docs: Fix typos and some wrong expressions in API reference doc.
Summary: I had fixed some typos and some wrong expressions in API reference doc
Test Plan: N/A
Reviewers: raster, zmike, Hermet, segfaultxavi
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6943
Chris Michael [Thu, 30 Aug 2018 04:59:53 +0000 (13:59 +0900)]
efl: Remove cserve2 support
Summary:
As cserve2 support has not worked (if ever) in a very long time, and
it's authors are gone, this series of patches removes cserve2 (and
thus cache2) from our codebase to remove cruft and reduce
maintainability of unused code.
ref T7226
Depends on D6941
Reviewers: raster, cedric, zmike, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7226
Differential Revision: https://phab.enlightenment.org/D6942
Chris Michael [Thu, 30 Aug 2018 04:58:46 +0000 (13:58 +0900)]
evas: Remove cache2 support
As cserve2 support has been removed, cache2 can go away also
ref T7226
Depends on D6940
Chris Michael [Thu, 30 Aug 2018 04:53:13 +0000 (13:53 +0900)]
evas: Remove binary cserve2
Summary:
ref T7226
Depends on D6939
Reviewers: raster, cedric, zmike, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7226
Differential Revision: https://phab.enlightenment.org/D6940
Chris Michael [Thu, 30 Aug 2018 04:52:41 +0000 (13:52 +0900)]
efl: Remove cserve2 support from Makefile_Evas.am
Summary:
ref T7226
Depends on D6938
Reviewers: raster, cedric, zmike, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7226
Differential Revision: https://phab.enlightenment.org/D6939
Chris Michael [Thu, 30 Aug 2018 04:51:45 +0000 (13:51 +0900)]
efl: Remove cserve2 from comfigure.ac
Summary:
ref T7226
Depends on D6937
Reviewers: raster, cedric, zmike, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7226
Differential Revision: https://phab.enlightenment.org/D6938
Chris Michael [Thu, 30 Aug 2018 04:49:04 +0000 (13:49 +0900)]
evas-file: Remove cserve2 support
Summary:
ref T7226
Depends on D6935
Reviewers: raster, cedric, zmike, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7226
Differential Revision: https://phab.enlightenment.org/D6937
Chris Michael [Thu, 30 Aug 2018 04:48:38 +0000 (13:48 +0900)]
evas-canvas: Remove cserve2 support
Summary:
ref T7226
Depends on D6933
Reviewers: raster, cedric, zmike, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7226
Differential Revision: https://phab.enlightenment.org/D6934
Chris Michael [Thu, 30 Aug 2018 04:46:41 +0000 (13:46 +0900)]
evas-common: Remove cserve2 support
ref T7226
Depends on D6934
Chris Michael [Thu, 30 Aug 2018 04:45:01 +0000 (13:45 +0900)]
evas-eglfs: Remove cserve2 support
Summary:
ref T7226
Depends on D6932
Reviewers: raster, cedric, zmike, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7226
Differential Revision: https://phab.enlightenment.org/D6933
Chris Michael [Thu, 30 Aug 2018 04:44:30 +0000 (13:44 +0900)]
evas-gl-drm: Remove cserve2 support
Summary:
ref T7226
Depends on D6931
Reviewers: raster, cedric, zmike, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7226
Differential Revision: https://phab.enlightenment.org/D6932
Chris Michael [Thu, 30 Aug 2018 04:43:49 +0000 (13:43 +0900)]
evas-gl-x11: Remove cserve2 support
Summary:
ref T7226
Depends on D6930
Reviewers: raster, cedric, zmike, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7226
Differential Revision: https://phab.enlightenment.org/D6931
Chris Michael [Thu, 30 Aug 2018 04:41:53 +0000 (13:41 +0900)]
evas-software-genereric: Remove cserve2 support
ref T7226
Depends on D6929
Chris Michael [Thu, 30 Aug 2018 04:38:15 +0000 (13:38 +0900)]
evas-gl-common: Remove cserve2 support
ref T7226
Depends on D6927