Woochanlee [Fri, 29 Nov 2019 06:51:41 +0000 (15:51 +0900)]
ecore_audio, ecore_buffer, ecore_wl2 : Fix build warnings.
Change-Id: I907a9b0a626c855129d2c424a34caf9890adf232
Xavi Artigas [Thu, 28 Nov 2019 17:13:47 +0000 (18:13 +0100)]
docs: nitpicking
We should not refer to individual library names anymore. They are all
part of EFL now!
Vincent Torri [Thu, 28 Nov 2019 11:06:24 +0000 (11:06 +0000)]
ecore_win32: fix compose event field
Summary:
compose event field was encoded in UTF-16 and not UTF-8. Also string
event field was not correctly defined and was generating eina error
messages
Test Plan: running a test
Reviewers: raster, cedric, zmike
Reviewed By: raster
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10753
Xavi Artigas [Thu, 28 Nov 2019 10:08:11 +0000 (11:08 +0100)]
Efl.Canvas.Text: Further update docs
Xavi Artigas [Thu, 28 Nov 2019 10:03:55 +0000 (11:03 +0100)]
Efl.Canvas.Text: Update docs
Stefan Schmidt [Thu, 28 Nov 2019 07:52:22 +0000 (08:52 +0100)]
ci: ensure we still test ephysics in all enabled build job
With commit
523a64d2265c13a82ba73022d10919f0e392bab2 we switched the
default for ephysics from true to false. This would result in no CI
coverage if we do not explicitly enable it in this job.
Reviewed-by: Carsten Haitzler (Rasterman) <raster@rasterman.com>
Differential Revision: https://phab.enlightenment.org/D10757
Ali Alzyod [Thu, 28 Nov 2019 07:55:26 +0000 (16:55 +0900)]
Polish text interface methods
Summary:
This patch is set to rename some properties of `Efl.Text_Font` & `Efl.Text_Format` interfaces.
1- efl_text_font_set/get become (efl_text_font_family_set/get, efl_text_font_size_set/get)
2- efl_text_valign/halign become efl_text_vertical/horizontal_align
3- efl_text_halign_auto_type become efl_text_horizontal_align_auto_type
Reviewers: ali.alzyod, woohyun, segfaultxavi, bu5hm4n, zmike, cedric
Reviewed By: woohyun
Subscribers: zmike, #committers, #reviewers, cedric
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10716
abdulleh Ghujeh [Thu, 28 Nov 2019 07:46:30 +0000 (16:46 +0900)]
Efl Canvas Text : Update style parsing code
Summary:
Based on comments in D10607
Update code responsible for parsing "style=" :
-Update string parsing code
-Make the old and new code more readable
-Add tests
Reviewers: segfaultxavi, bu5hm4n, woohyun, ali.alzyod
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10715
Hermet Park [Thu, 28 Nov 2019 06:04:56 +0000 (15:04 +0900)]
vector container: skip only for composition types.
Hermet Park [Thu, 28 Nov 2019 04:38:32 +0000 (13:38 +0900)]
evas vector: make it stable caching logic.
We need a more precise caching mechanism to save memory.
Current root node(key) is limited for caching buffers,
when to share by the multiple animated instances.
This patch is a step for further optmization work,
at the moment we disable the caching buffers for the animated instances.
Change-Id: Ifda143d24bd10bb991a0c15c7d165cb6eef5bf14
abdulleh Ghujeh [Thu, 28 Nov 2019 04:14:15 +0000 (13:14 +0900)]
Efl Canvas Text : Modify Style Property
Summary:
This patch defines the way style property will work at canvas_text object
1- Changing canvas_text style property using Font/Format/Style interfaces or with efl_canvas_text style property are the same.
Example:
```
efl_text_font_set(tb, "Arial", 30);
//is same as
efl_canvas_text_style_set(tb, "font=Arial font_size=30");
//which means calling
char * font;
int size;
int font_size;
efl_text_font_get(tb, &font, &size);
// calling this after any of the top two functions will return same result
```
2- style_get_property
Will return string that contains full details about all the current applied style at canvas_text level.
3- style_set_property
Will only override passed styles and leave everything else as it is
```
efl_canvas_text_style_set(tb, "font=Arial"); // overrider font name to Arial and leave everthing else
efl_canvas_text_style_set(tb, "font_size=30"); // overrider font size to 30 and leave everthing else (font name will stay arial)
```
Reviewers: ali.alzyod, woohyun, tasn, segfaultxavi, bu5hm4n, zmike
Reviewed By: woohyun
Subscribers: zmike, bu5hm4n, segfaultxavi, a.srour, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10607
Carsten Haitzler (Rasterman) [Thu, 28 Nov 2019 00:06:15 +0000 (00:06 +0000)]
edje - fix min size calc after being broken by previous commit
37b55172b0d46d71f772af8fba17e1fb1b7c6c2c breaks min size calc. elm
toolbar was being squashed. e toolbars also were becoming 0 sized.
Just because a swallow does not have content does not mean it does not
affect the minimum size. there still could be a min size set on it
anyway etc. ...
Hermet Park [Thu, 28 Nov 2019 04:38:32 +0000 (13:38 +0900)]
evas vector: make it stable caching logic.
We need a more precise caching mechanism to save memory.
Current root node(key) is limited for caching buffers,
when to share by the multiple animated instances.
This patch is a step for further optmization work,
at the moment we disable the caching buffers for the animated instances.
Change-Id: Ifc17f5ff55d84b1c158f7d1f3b2bf1f2bfacc76c
Jongmin Lee [Wed, 27 Nov 2019 21:37:08 +0000 (06:37 +0900)]
build: turn on glib integration
Change-Id: I854da8b709e9a5bde7a3490cf3b3b96abd5ce751
Carsten Haitzler (Rasterman) [Wed, 27 Nov 2019 17:47:55 +0000 (17:47 +0000)]
build - handle g-main-loop enabled when glib not as an error in meson
also enable glib now in ci
Carsten Haitzler (Rasterman) [Sun, 24 Nov 2019 11:32:34 +0000 (11:32 +0000)]
build - experiment - turn off glib integration by default
i wany to see if this breaks anything for regular efl use on regular
platforms... one way to figure it out is disable it by default and
see...xs
Carsten Haitzler (Rasterman) [Sun, 24 Nov 2019 11:31:07 +0000 (11:31 +0000)]
build - as per edd 2019 - make e physics off by default
Carsten Haitzler (Rasterman) [Wed, 20 Nov 2019 08:43:26 +0000 (08:43 +0000)]
eina - add portable close all fd's we don't need function
close all fd's starting at a given fd and then leving out an exception
list specially passed, if any. useful for fork+exec. this uses it in
efl's fork+exec paths.
@feat
Marcel Hollerbach [Wed, 20 Nov 2019 16:06:58 +0000 (17:06 +0100)]
remove unused code file
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10707
Marcel Hollerbach [Wed, 20 Nov 2019 16:05:10 +0000 (17:05 +0100)]
theme: rename pager to spotlight
that mirrors the name of the widget.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10706
Marcel Hollerbach [Wed, 20 Nov 2019 16:02:37 +0000 (17:02 +0100)]
theme: remove unused parts
they seem totally useless, no idea why they are there.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10705
Marcel Hollerbach [Wed, 20 Nov 2019 15:58:27 +0000 (16:58 +0100)]
efl_ui_spotlight_manager_*: remove size and position events
there is no need to listen to them, they are already listent to by the
container, and new sizes are told via the size property.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10704
Marcel Hollerbach [Wed, 20 Nov 2019 15:54:08 +0000 (16:54 +0100)]
elm_test: make spotlight test check boxes work again
when we refactored check boxes, cases that used unified events on legacy
obejcts broke, which is okay. So the usage needed fixing.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10703
Marcel Hollerbach [Wed, 20 Nov 2019 15:45:45 +0000 (16:45 +0100)]
efl_ui_spotlight_manager: remove the group object
i do not know why its there, it caused a bug in the past (in regards of
clippers and visibility). Now we can get rid of it completly, the state
of it is always compatible to the one of the widget itself, soooo ...
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10702
Marcel Hollerbach [Wed, 20 Nov 2019 15:16:22 +0000 (16:16 +0100)]
efl_ui_spotligt: make it possible to freeze animations
this new API makes it possible to stop animations beeing executed in the
spotlight manager. (The logic in the spotlight managers itself are
already implemented).
The animation will also be frozen during construction time of the
spotlight.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10701
Marcel Hollerbach [Wed, 27 Nov 2019 10:45:46 +0000 (11:45 +0100)]
Revert "gesture_manager: Changed function param to reduce internal function calls."
This has still open review comments, lets solve them, and *then* land
it.
This reverts commit
2f41f867ae992c58690e8fcad60672daa8744708.
Woochanlee [Wed, 27 Nov 2019 14:15:49 +0000 (09:15 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_activated_get function
Summary:
tests/ecore_wl2: Add test for ecore_wl2_window_activated_get function
ref T8016
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8016
Differential Revision: https://phab.enlightenment.org/D10746
Stefan Schmidt [Mon, 19 Aug 2019 12:17:28 +0000 (14:17 +0200)]
ci: travis: add job to build efl and run tests with address sanitizer
A first step to have addrress sanitizer coverage on our EFL build. It
already catched some use after free errors and memory corruptions. Still
we have some limititation how we are running this right now. We
currently ignore some leaks that are exposed durign the normal build
wile haveing the short living runs of edje_cc, elm_prefs_cc, etc.
For now the whole leak detection is disabled on the testsuite as well.
This is still very valuable, especially for all non-leak cases it finds,
thus we are goign to run this on our daily build.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10691
Stefan Schmidt [Wed, 27 Nov 2019 13:17:15 +0000 (08:17 -0500)]
ci: enable mono bindings build in default build
Summary:
We have all the pieces together now to build the mono bindings as well
as run the mono testsuite on nija test.
The docker image was updated to contain the mono-devel package to
provide the needed dependencies.
Depends on D10437
Reviewers: bu5hm4n, zmike, lauromoura
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10749
Hermet Park [Wed, 27 Nov 2019 12:04:43 +0000 (21:04 +0900)]
vector container: skip copying compositions precisely.
+ added some comments for future tasks.
Hermet Park [Wed, 27 Nov 2019 08:51:42 +0000 (17:51 +0900)]
evas json: up-to-date vector-tree logging.
Woochanlee [Wed, 27 Nov 2019 05:24:01 +0000 (14:24 +0900)]
gesture_manager: Changed function param to reduce internal function calls.
Summary:
The filter_event function calling a lot of times when it runs.
This can help performance by reducing the number of calls to the efl_data_scope_get() function.
Reviewers: Hermet, smohanty, bu5hm4n
Reviewed By: Hermet
Subscribers: zmike, bu5hm4n, q66, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10437
Ali Alzyod [Wed, 27 Nov 2019 04:04:31 +0000 (13:04 +0900)]
Efl.Text.Attribute_Factory
Summary:
Implementation of new Efl.Text.Attribute_Factory class which replace the annotation interface.
Currently, we have two public methods:
```
void efl_text_attribute_factory_attribute_insert(const Efl_Text_Cursor *start, const Efl_Text_Cursor *end, const char *format)
unsigned int efl_text_attribute_factory_attribute_clear(const Efl_Text_Cursor *start, const Efl_Text_Cursor *end);
```
Other methods will be internal methods, for the time being, we will redesign internal methods
Reviewers: woohyun, tasn, segfaultxavi, bu5hm4n, zmike
Subscribers: zmike, q66, cedric, segfaultxavi, bu5hm4n, a.srour, #committers, #reviewers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10646
Jaehyun Cho [Wed, 27 Nov 2019 10:50:31 +0000 (19:50 +0900)]
workaround: disable efl_access on csharp
Change-Id: I01c97b045b3bf7991ece00afc049e4dd2b4bf193
Yeongjong Lee [Mon, 28 Oct 2019 01:48:29 +0000 (10:48 +0900)]
mono: disable efl_access on csharp
Change-Id: Iccbb6f3cfd6c8337f76b059cff459617b2f4f700
Yeongjong Lee [Fri, 14 Jun 2019 01:20:54 +0000 (10:20 +0900)]
efl_mono: disable focus manager on csharp
@tizne_fix
Change-Id: Ifc6df8586ff55c88b897843354ef78f411c07baf
Yeongjong Lee [Thu, 1 Nov 2018 02:06:54 +0000 (11:06 +0900)]
elm_focus: implement legay focus for Efl.Ui.Widgets
@tizne_fix
Change-Id: If38a0ccc35e3d7211b52068f20cb7189866f0b5f
Yeongjong Lee [Sun, 27 Oct 2019 23:38:28 +0000 (08:38 +0900)]
Revert "elm_panel: disable efl_ui_focus_layer functions"
This reverts commit
e1b29036cac3d6da98e0cc79c9e9ff8ad8ddce3c.
Change-Id: I489500c1ecbff5eb6aec905427e64bb7054433d9
Yeongjong Lee [Sun, 27 Oct 2019 23:38:08 +0000 (08:38 +0900)]
Revert "Revert "elm_widget: disable focus manager in tizen""
This reverts commit
9bde69ee8e54f3f9ef80ce1e60e13187282654f8.
Change-Id: I06ff90c0c267d2baf533df29c12c9c56745a3afa
Lauro Moura [Tue, 26 Nov 2019 14:56:57 +0000 (11:56 -0300)]
csharp: CA1717 - Add [Flags] for enums
Summary:
Using the naive approach of checking if the name ends with `Flags`.
Ref T8411
Depends on D10708
Reviewers: brunobelo, segfaultxavi, felipealmeida, YOhoho
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8411
Differential Revision: https://phab.enlightenment.org/D10709
Lauro Moura [Tue, 26 Nov 2019 14:56:51 +0000 (11:56 -0300)]
csharp: Iterate more in GC-dependent test
Summary:
The inheritance test depends on the objects being actively destroyed.
Currently this happens in a two step process, where first the C#
object is collected from the GC. As this happens in a separate thread,
we schedule a callback to run in the main loop to actually unref the
EO object.
This commit adds more iterations to make sure the EO of the parent is
unref'd and releases the child.
This should be the last C#-related CI test failure
Ref T8313
Reviewers: stefan_schmidt, brunobelo, felipealmeida
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8313
Differential Revision: https://phab.enlightenment.org/D10612
Lauro Moura [Tue, 26 Nov 2019 14:56:41 +0000 (11:56 -0300)]
pyolian: Add helper functions for simple scripts
Summary:
These two functions encapsulate some code that commonly is repeated
through pyolian scripts.
With these, a minimal example (provided `src/scripts/pyolian` is in
the PYTHONPATH) could be done with:
```
import os
from pyolian import eolian
SCAN_FOLDER = os.path.join(eolian.in_tree_src_dir(), 'src', 'lib')
eolian_db = eolian.parse_folders(SCAN_FOLDER)
for cls in eolian_db.classes:
print(cls)
```
Reviewers: segfaultxavi, DaveMDS, felipealmeida
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers, felipealmeida, brunobelo
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10589
Lauro Moura [Tue, 26 Nov 2019 14:56:31 +0000 (11:56 -0300)]
pyolian: Add a method to get the hierarchy of extensions
Summary:
To be used by the test generator
Depends on D10420
Test Plan: test in the diff
Reviewers: DaveMDS, herb, segfaultxavi, felipealmeida
Reviewed By: felipealmeida
Subscribers: cedric, brunobelo, #reviewers, felipealmeida, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10421
Lauro Moura [Tue, 26 Nov 2019 14:55:01 +0000 (11:55 -0300)]
pyolian: full_inherit must recurse parent too
Test Plan: run tests
Reviewers: segfaultxavi, herb, DaveMDS, felipealmeida
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10420
Lauro Moura [Tue, 26 Nov 2019 14:13:47 +0000 (11:13 -0300)]
csharp: Add more since tags to members
Summary:
- Class constructors and other members
- Aliases fields
ref T8359
Reviewers: felipealmeida, segfaultxavi, brunobelo, woohyun
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8359
Differential Revision: https://phab.enlightenment.org/D10419
Hosang Kim [Fri, 22 Nov 2019 09:16:47 +0000 (09:16 +0000)]
ecore_timer: add NULL checking for timer data.
When timer is not created, a crash occurs.
For example, when user create ecore timer in the pthread..
Of course this is not the correct usage, but printing ERR message is enough.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10714
Yeongjong Lee [Fri, 22 Nov 2019 07:29:27 +0000 (07:29 +0000)]
eo: add missing move tag
`efl_access_action_actions_get`
the list is created by `eina_list_append`
`efl_ui_format_values_set`
the accessor is freed in that function.
`efl_ui_format_values_get`
The accessor is created by `eina_inarray_accessor_new`
`efl_core_command_line_command_access`
The accessor is created by `eina_array_accessor_new`
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10720
Yeongjong Lee [Fri, 22 Nov 2019 06:13:25 +0000 (06:13 +0000)]
eo: add move tag to iterator
It is impossible to reuse iterator after `EINA_ITERATOR_FOREACH`(`eina_iterator_next`).
E.g.
```
eina_init();
eina_file_dir_list("/home/", EINA_FALSE, _print_cb, NULL);
it = eina_file_ls("/home/");
EINA_ITERATOR_FOREACH(it, f_name)
{
printf("%s\n", f_name);
eina_stringshare_del(f_name);
}
EINA_ITERATOR_FOREACH(it, f_name)
{
printf("Again %s\n", f_name);
eina_stringshare_del(f_name);
}
eina_iterator_free(it);
```
`Agian ...` is never printed.
Therefore, iterator always need `@move` tag to avoid unexpected behavior without
any error message.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10719
Woochanlee [Tue, 26 Nov 2019 04:57:16 +0000 (13:57 +0900)]
edje_calc: Creation macro that perform edje calc, regardless of the edje size.
Summary: edje_recalc_do() needs to be executed regardless of the size of edje in order to deliver edje properties for the API that the user calls.
Reviewers: cedric, Hermet, Jaehyun_Cho, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10724
JunsuChoi [Tue, 26 Nov 2019 04:50:00 +0000 (13:50 +0900)]
vg_common_json: Fix a missing of free after using
Summary: iterator itr will leak by going out the function widthout freeing.
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10736
JunsuChoi [Tue, 26 Nov 2019 01:54:37 +0000 (10:54 +0900)]
Efl.Canvas.Image: Add skeleton code Efl.Gfx.Frame_Controller.sector
Summary:
Sector is a property with start, end frame and sector name information
that can be used when playing a specific section.
Sector play is not supported for Efl.Canvas.Image yet.
So we add skeleton code with comments.
This is also for full implements of the Efl.Gfx.Frame_Controller interface.
Test Plan: N/A
Reviewers: Hermet, bu5hm4n
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10718
Woochanlee [Tue, 26 Nov 2019 05:58:26 +0000 (14:58 +0900)]
Revert "elm_multibuttonentry: delete ELM_LAYOUT_MIXIN"
This reverts commit
c046a2ffd4754a84c3eca3c0b60e2c5be12c31e5.
Change-Id: I625bdecbfeab83a6cf0da33402337b33f8babf46
Marcel Hollerbach [Wed, 20 Nov 2019 12:36:02 +0000 (12:36 +0000)]
efl_ui_multi_selectable: clean this up
this commit merges common functions from efl_ui_multi_selectable and
efl_ui_multi_selectable_async. Additionally, the two different aspects
of accessing the elements in a multi_selectable widget (numerical or
object based) are now abstracted into interfaces called range_numeric and
range_object. numeric APIs are also prefixed with id's, so its possible
for one widget to implement both (if there will ever be the demand to do
that in future).
The main reason for this split is:
- there is no good common path between mvvm based multi_selectable and
object based multi_Selectable, so there is no way that both sides would
benefit, without the other one suffering.
- If we find later on the demand to implement both on one widget, we now
can fully do that
- Common API is available for both types, so its less API and less
confusion for the API user.
ref T7871
ref T8265
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10675
Woochanlee [Mon, 25 Nov 2019 10:10:41 +0000 (19:10 +0900)]
theme: Delete max that seems not right.
Summary:
It prevents popup edje resize.
So not we cant see slider indicator.
T8483
before that edje calc in render time.
But now we dont calc for no size edje.
Limit max 0 0 is really looks weird.
Test Plan: elementary_test->slider ->check indicator.
Reviewers: eagleeye, Hermet, cedric, smohanty, Jaehyun_Cho
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8483
Differential Revision: https://phab.enlightenment.org/D10721
JunsuChoi [Mon, 25 Nov 2019 10:04:30 +0000 (19:04 +0900)]
Efl.Canvas.Vg.Container : Initialize mask buffer for SUB, INS composition.
Summary:
If composite method is substract or intersect, buffer needs initialize.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10732
JunsuChoi [Mon, 25 Nov 2019 04:39:01 +0000 (13:39 +0900)]
vector lottie: Set visibility vg node
Summary:
All nodes reset their visibility when they are reused.
Therefore, visibility must be set true if mVisibile is true.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10731
Change-Id: I5531fff3ad43c4529b1070f6af3092ae5952a628
Hermet Park [Mon, 25 Nov 2019 04:26:52 +0000 (13:26 +0900)]
evas vector: initialize data member properly.
user entry root should be initialized to null before accessing it.
in a certain scenario it could occur a crash with an invalid root data.
@fix
Change-Id: Ia2897f7897c131bbd8a9d206d8dd181678d7c460
ali [Fri, 22 Nov 2019 18:32:01 +0000 (15:32 -0300)]
evas_textblock: cursor function null check at start
Reviewers: segfaultxavi, woohyun, lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10727
Lauro Moura [Fri, 22 Nov 2019 15:01:59 +0000 (12:01 -0300)]
csharp: Fix helper function
Summary: Was failing if the suffix were equal to the source string
Reviewers: felipealmeida, segfaultxavi, YOhoho, brunobelo
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10708
Lauro Moura [Fri, 22 Nov 2019 14:43:22 +0000 (15:43 +0100)]
text: Fix struct definition
Summary:
Efl_Text_Cursor_Handle was being declared twice, confusing the C#
generator. This commits updates it to be singly defined in the
text_types eot file.
Reviewers: segfaultxavi, ali.alzyod
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10726
WooHyun Jung [Fri, 22 Nov 2019 11:51:06 +0000 (12:51 +0100)]
efl_ui_internal_text_interactive: fix undefined symbol issue
Summary: This fixes an issue from
d7352f4db41dc8975eaeb3f79dff326338a5a63c.
Reviewers: segfaultxavi, bu5hm4n
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10725
Xavi Artigas [Fri, 22 Nov 2019 11:50:35 +0000 (12:50 +0100)]
Efl.Text.Cursor: Add missing documentation
This was breaking the C# bindings build.
Wonki Kim [Fri, 22 Nov 2019 11:40:17 +0000 (12:40 +0100)]
efl_ui_table: modify comparing logic
Summary:
pad.h/v are integer varaibles, and also parameters h/v are too.
so that it is not needed to compare them like they are floating pointer.
Reviewers: bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10722
Xavi Artigas [Fri, 22 Nov 2019 09:39:33 +0000 (10:39 +0100)]
docs: Remove repeated words
This had already been pointed out in the review.
Hermet Park [Mon, 25 Nov 2019 07:58:19 +0000 (16:58 +0900)]
Revert "wl egl - use platform get display"
This reverts commit
cca636d3da1d67eb8dff50c753a8f7a5371801be.
Tizen doesn't support egl extension apis yet.
Change-Id: Ib253446a9e4b3d57082e4b2211d95e1c6a7fe69e
WooHyun Jung [Mon, 25 Nov 2019 03:03:21 +0000 (12:03 +0900)]
textblock: fixes build error
This patch fixes build errors came from below Cursor patch.
ccc44f88265868e892444ccd88a037cc57fd9c47
Change-Id: I3a504b600c3aaf38fb9214d4d9a366bdd4540447
Ali Alzyod [Fri, 22 Nov 2019 08:35:54 +0000 (17:35 +0900)]
Efl.Text.Cursor
Summary:
Implementation of new cursor text object.
This Patch Contains :
1- Remove Efl.Text.Cursor & Efl.Text_Markup_Interactive interfaces and replace them with one Class Efl.Text.Cursor
=> there are some modifications on cursor methods
2- Update all related classes to use Efl.Text.Cursor object instead of the old interfaces
3- If class uses Efl.Text_Cursor_Cursor (handle), mainly annotation it will stay as it is until we update other annotations into attribute_factory
4- Add main cursor property into efl.text.interactive
5- Add cursor_new method in efl.ui.text (I think we may move it into efl.text.interactive interface)
There still some parts that need discussion: especially cursor movement functionality, I prefer to move function with Enum, instead of special function for each movement.
```
enum @beta Efl.Text.Cursor_Move_Type
{
[[Text cursor movement types]]
char_next, [[Advances to the next character]]
char_prev, [[Advances to the previous character]]
cluster_next, [[Advances to the next grapheme cluster]]
cluster_prev, [[Advances to the previous grapheme cluster]]
paragraph_start, [[Advances to the first character in this paragraph]]
paragraph_end, [[Advances to the last character in this paragraph]]
word_start, [[Advance to current word start]]
word_end, [[Advance to current word end]]
line_start, [[Advance to current line first character]]
line_end, [[Advance to current line last character]]
paragraph_first, [[Advance to current paragraph first character]]
paragraph_last, [[Advance to current paragraph last character]]
paragraph_next, [[Advances to the start of the next text node]]
paragraph_prev [[Advances to the end of the previous text node]]
}
move {
[[Move the cursor]]
params {
@in type: Efl.Text.Cursor_Move_Type; [[The type of movement]]
}
return: bool; [[True if actually moved]]
}
```
or old way:
```
char_next {
[[Advances to the next character]]
// FIXME: Make the number of characters we moved by? Useful for all the other functions
return: bool; [[True if actually moved]]
}
char_prev {
[[Advances to the previous character]]
return: bool; [[True if actually moved]]
}
char_delete {
[[Deletes a single character from position pointed by given cursor.]]
}
cluster_next {
[[Advances to the next grapheme cluster]]
return: bool; [[True if actually moved]]
}
cluster_prev {
[[Advances to the previous grapheme cluster]]
return: bool; [[True if actually moved]]
}
// FIXME: paragraph_end is inconsistent with word_end. The one goes to the last character and the other after the last character.
paragraph_start {
[[Advances to the first character in this paragraph]]
return: bool; [[True if actually moved]]
}
paragraph_end {
[[Advances to the last character in this paragraph]]
return: bool; [[True if actually moved]]
}
word_start {
[[Advance to current word start]]
return: bool; [[True if actually moved]]
}
word_end {
[[Advance to current word end]]
return: bool; [[True if actually moved]]
}
line_start {
[[Advance to current line first character]]
return: bool; [[True if actually moved]]
}
line_end {
[[Advance to current line last character]]
return: bool; [[True if actually moved]]
}
paragraph_first {
[[Advance to current paragraph first character]]
return: bool; [[True if actually moved]]
}
paragraph_last {
[[Advance to current paragraph last character]]
return: bool; [[True if actually moved]]
}
paragraph_next {
[[Advances to the start of the next text node]]
return: bool; [[True if actually moved]]
}
paragraph_prev {
[[Advances to the end of the previous text node]]
return: bool; [[True if actually moved]]
}
```
Reviewers: woohyun, tasn, segfaultxavi
Reviewed By: woohyun
Subscribers: a.srour, bu5hm4n, segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10542
Change-Id: Ief0e4c1bb22e40f44dd17986264ca10ceb69d3a8
WooHyun Jung [Mon, 25 Nov 2019 02:24:26 +0000 (11:24 +0900)]
Revert "Revert "Revert "evas_textblock: content fit feature"""
This reverts commit
0e0c6caf166b76f6b86c70c1bc558cdb48e5c2ea.
Change-Id: Ifac1ffb4f983edd49e743c6967a1fd2b44704618
Hermet Park [Mon, 25 Nov 2019 06:33:11 +0000 (15:33 +0900)]
elementary widget: ++safety
null checking for invalid objects.
Change-Id: I2406f470666d8da24b0c993f7c17dfaad5e6bf9f
JunsuChoi [Mon, 25 Nov 2019 04:39:01 +0000 (13:39 +0900)]
vector lottie: Set visibility vg node
Summary:
All nodes reset their visibility when they are reused.
Therefore, visibility must be set true if mVisibile is true.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10731
Change-Id: I85b0b5f268d32f1e38b358b79686a41631811ba9
Hermet Park [Mon, 25 Nov 2019 04:26:52 +0000 (13:26 +0900)]
evas vector: initialize data member properly.
user entry root should be initialized to null before accessing it.
in a certain scenario it could occur a crash with an invalid root data.
@fix
Change-Id: Ieed18d04c05b86796d16d67cafec91dc2edc5806
Oskar Chodowicz [Wed, 20 Nov 2019 12:00:24 +0000 (13:00 +0100)]
Fix some minor security issues
Change-Id: Ib733f54593666018eefdce3e73295b2cac8658ba
Hermet Park [Thu, 21 Nov 2019 08:37:33 +0000 (17:37 +0900)]
vector lottie: reset vg tree each frames.
Since vector tree nodes are reusing instead of reconstrucion,
We make it sure that dangling nodes invisible by clearing all nodes visibility.
Only valid nodes will be reset to visible while setting up in the progress.
Change-Id: Ifc1dc255f9fcefc6bafbd91149ea809bf9b85bdb
Marcel Hollerbach [Thu, 21 Nov 2019 17:41:08 +0000 (18:41 +0100)]
efl_canvas_object_animation: fix possible invalid pointer
now if one of the event handlers calls animation_stop in a callback to
EFL_CANVAS_OBJECT_ANIMATION_EVENT_ANIMATION_PROGRESS_UPDATED, then
pd->in will be freeed. Which means, in the next event handler the
address taken by &pd->in->progress might be invalid, leading to a crash.
With this commit this is a address on the stack, which should fix this.
Marcel Hollerbach [Thu, 21 Nov 2019 11:22:41 +0000 (12:22 +0100)]
efl_canvas_object_animation: make this all more safe
Summary:
when a callback is called, the in pointer might be free'ed, we should be
more carefull with that.
fix CID1407682
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10713
JunsuChoi [Thu, 21 Nov 2019 10:49:01 +0000 (19:49 +0900)]
elm/hoversel: Recalculate items before box calculate.
Summary:
After the item is packed into the box,
the min of the item can be initialized with content_set working.
content_set calls parent_set and checks the theme when calling parent_set.
At that time, if theme is changed in the parent of layout using hoversel,
call theme_apply(efl_ui_layout) to make min value 0, 0.
This patch can avoid it.
Test Plan: N/A
Reviewers: YOhoho, Hermet, woohyun, zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10712
Change-Id: I7bbd46ef8a63e5486f70f48c111f0693a07cb8b5
Wonki Kim [Thu, 21 Nov 2019 08:43:42 +0000 (17:43 +0900)]
eina_matrix: replace cosf by cos to gain more accuracy
Summary:
cos function is much much more accurate than cosf.
this patch replaces cosf by cos to gain more accuracy.
Reviewers: cedric, jsuya, vtorri
Subscribers: vtorri, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10695
Change-Id: Ifb99e744dd0fead9cda77a1e3697798b824f27eb
Hermet Park [Thu, 21 Nov 2019 08:37:33 +0000 (17:37 +0900)]
vector lottie: reset vg tree each frames.
Since vector tree nodes are reusing instead of reconstrucion,
We make it sure that dangling nodes invisible by clearing all nodes visibility.
Only valid nodes will be reset to visible while setting up in the progress.
Hermet Park [Thu, 21 Nov 2019 08:45:36 +0000 (17:45 +0900)]
Revert "evas animation: removed unnecessray checking."
This reverts commit
959c503a718ed548fa3251fc245bfe9c8c82d521.
Hermet Park [Thu, 21 Nov 2019 08:28:54 +0000 (17:28 +0900)]
vector json: checking valid pointer before accessing it.
Change-Id: I74465ba115411db610b196253ac08454b8f29a2c
Hermet Park [Thu, 21 Nov 2019 08:26:21 +0000 (17:26 +0900)]
evas animation: removed unnecessray checking.
pd->in is already verified earlier.
JunsuChoi [Thu, 21 Nov 2019 10:49:01 +0000 (19:49 +0900)]
elm/hoversel: Recalculate items before box calculate.
Summary:
After the item is packed into the box,
the min of the item can be initialized with content_set working.
content_set calls parent_set and checks the theme when calling parent_set.
At that time, if theme is changed in the parent of layout using hoversel,
call theme_apply(efl_ui_layout) to make min value 0, 0.
This patch can avoid it.
Test Plan: N/A
Reviewers: YOhoho, Hermet, woohyun, zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10712
Change-Id: Ib0237ebdef99a79d7418ecdadd44941ef2e03a48
Hosang Kim [Thu, 21 Nov 2019 09:12:30 +0000 (18:12 +0900)]
wearable: add positioned item get API for wearable support
Change-Id: Id76a721035f2d05913df6e8f83886ba2ccb0f14d
Wonki Kim [Thu, 21 Nov 2019 08:43:42 +0000 (17:43 +0900)]
eina_matrix: replace cosf by cos to gain more accuracy
Summary:
cos function is much much more accurate than cosf.
this patch replaces cosf by cos to gain more accuracy.
Reviewers: cedric, jsuya, vtorri
Subscribers: vtorri, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10695
Change-Id: I6b646b630ce385e6b157838aca7c6a411eb71a30
Hermet Park [Thu, 21 Nov 2019 08:45:36 +0000 (17:45 +0900)]
Revert "evas animation: removed unnecessray checking."
This reverts commit
959c503a718ed548fa3251fc245bfe9c8c82d521.
Change-Id: I27f99c5ab67447365a64c4616727b33cd7b8354e
Hermet Park [Thu, 21 Nov 2019 08:28:54 +0000 (17:28 +0900)]
vector json: checking valid pointer before accessing it.
Change-Id: I97abee823eb3f7290bb60aa3e829f47692145cff
Hermet Park [Thu, 21 Nov 2019 08:26:21 +0000 (17:26 +0900)]
evas animation: removed unnecessray checking.
pd->in is already verified earlier.
Change-Id: I34752c4461345a2391de9bbf5a1f18c08d10990d
SangHyeon Jade Lee [Wed, 20 Nov 2019 04:41:57 +0000 (13:41 +0900)]
wearable : add item classes for wearable support
Change-Id: I60a9ba8b5bcea2545ad82f87f595eaa441eeb597
SangHyeon Jade Lee [Tue, 19 Nov 2019 08:21:15 +0000 (17:21 +0900)]
efl_ui: apply circle position manager for wearable
Change-Id: If187b2276d7f0b746be2d49a823d12aeb9e5099b
Jaehyun Cho [Thu, 21 Nov 2019 06:41:18 +0000 (15:41 +0900)]
edje: fix to remove Efl.Canvas.Animation_Player
Since json support in edc is TIZEN_ONLY feature, the logic of json
support in edc is fixed to remove Efl.Canvas.Animation_Player.
@tizen_only
Change-Id: Idf738bd7bde153361c4a99abd823354c68f9023a
Jaehyun Cho [Thu, 21 Nov 2019 06:30:21 +0000 (15:30 +0900)]
efl_canvas_object_animation: check if animation stops during animation
It is checked if animation stopped in the animation_progress,updated
callback by user.
Bruno da Silva Belo [Wed, 20 Nov 2019 22:07:21 +0000 (19:07 -0300)]
csharp: Components enum are flags now.
Reviewers: lauromoura, felipealmeida, YOhoho
Reviewed By: lauromoura
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8411
Differential Revision: https://phab.enlightenment.org/D10541
Bruno da Silva Belo [Wed, 20 Nov 2019 21:37:48 +0000 (18:37 -0300)]
csharp: Hiding p-invokes.
Summary: ref T8406
Reviewers: lauromoura, felipealmeida, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8406
Differential Revision: https://phab.enlightenment.org/D10651
Lauro Moura [Wed, 20 Nov 2019 21:34:08 +0000 (18:34 -0300)]
csharp: CA1307 Add CultureInfo to generated code.
Summary:
For the struct fields with strings when implementing `GetHashCode`.
Ref T8405
Reviewers: brunobelo, felipealmeida, YOhoho
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8405
Differential Revision: https://phab.enlightenment.org/D10696
Bruno da Silva Belo [Wed, 20 Nov 2019 19:57:14 +0000 (16:57 -0300)]
csharp: Specifying StringComparison.
Summary: ref T8405
Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi
Reviewed By: lauromoura
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8405
Differential Revision: https://phab.enlightenment.org/D10650
Stefan Schmidt [Wed, 20 Nov 2019 08:57:05 +0000 (09:57 +0100)]
tooling: add configuration file for lgtm.com service
It seems they run this on many Github projects automatically now:
https://lgtm.com/projects/g/Enlightenment/efl
From my playing around it had 970 "recommendations" to fix our FIXME
tags. Filtering out this noise by using this config file to exclude the
query.
It also seems to pick up the python scripts as Python2 and has wrong
reporting due to this as well.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10699
Stefan Schmidt [Wed, 20 Nov 2019 08:08:54 +0000 (09:08 +0100)]
ecore_input_evas: fix ouble use of include guard define
We used the ecore_input define here in ecore_evas_input. Use a unique
name for this file.
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl/
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10698
Marcel Hollerbach [Sun, 17 Nov 2019 11:09:23 +0000 (12:09 +0100)]
eo: there is no need to count callbacks here
we are going to add this description anyways, no need to count here
again. I think this is not really making anything really faster, its
more keeping things consistance.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10689
Marcel Hollerbach [Thu, 14 Nov 2019 11:54:31 +0000 (12:54 +0100)]
remove efl_canvas_animation_player
this now all migrated to Efl.Canvas.Object.Animation
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10667
Marcel Hollerbach [Mon, 18 Nov 2019 02:44:15 +0000 (11:44 +0900)]
evas: migrate the vg json example
Summary:
i was not able to run the example before this commit, nor after this
commit. However, i had to migrate this, as i want to remove the player
object.
Depends on D10637
Reviewers: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10666