JunsuChoi [Thu, 27 Sep 2018 02:10:25 +0000 (11:10 +0900)]
ctxpopup: Add return value check
Summary:
Using elm_widget_theme_object_set without checking return value.
so add return value check and log message
Test Plan: N/A
Reviewers: herb, cedric, Hermet
Reviewed By: Hermet
Subscribers: Hermet, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7072
Change-Id: I372f7ad1ea1989b34243b034f5209711e2b48c23
Jaehyun Cho [Thu, 26 Jul 2018 03:01:42 +0000 (12:01 +0900)]
evas_events: Use ecore mouse device instead of default mouse device
In Tizen, ecore uses mouse device handle corresponding to actual mouse
device.
However, evas uses both ecore mouse device handles and default mouse
handle at the same time.
This causes that "mouse_in" state is not preserved.
Consequently, mouse in/out callback is not called correctly.
To resolve above issue, evas stores the last activated ecore mouse
device handle to "last_mouse" variable.
This patch should be applied with
00004cb2e36842c41b866027ae7f486c6a9ad204
Change-Id: I5da9da5662c55af0df191c9a876487831f5f33d9
Signed-off-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Jaehyun Cho [Fri, 21 Sep 2018 09:40:05 +0000 (18:40 +0900)]
efl_ui_list: Return function if data get is failed
Summary: Check data and return function if data get is failed.
Reviewers: SanghyeonLee
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7092
Change-Id: I37a3789d21c715dc3a64151daafa707808484f10
Shinwoo Kim [Fri, 21 Sep 2018 03:11:24 +0000 (03:11 +0000)]
eina_vpath_vdg: free locally allocated memory before return
The eina_vpath_resolve could allocate memory and return it.
But the eina_xdg_env_init does not release it.
*Detected by static analysis with the Coverity
Differential Revision: https://phab.enlightenment.org/D7066
Change-Id: Ic243f70632dd731cf1cab426d1abfe013afa362b
Shinwoo Kim [Fri, 21 Sep 2018 07:46:03 +0000 (16:46 +0900)]
evas_object_smart: fix dereference of null
Summary:
The cso could b NULL so we need to check if the cso is NULL or not before
dereferencing it.
Reviewers: jpeg, Hermet, jypark
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7075
Change-Id: Ic3b28206a263f4a145a0cd00b315652f00144407
Taehyub Kim [Fri, 21 Sep 2018 06:05:49 +0000 (15:05 +0900)]
Efl.Ui.Popup.Alert: add icon parameter for icon button of popup
Summary: add icon parameter for icon button of popup
Test Plan:
1. run elementry_test
2. run Efl.Ui.Popup.Alert sample
3. call set button function of popup and pass the icon by parameter
4. see the result of the popup
Reviewers: Jaehyun_Cho, jpeg, raster, cedric, woohyun
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7079
Change-Id: Ida7570b8089fe6138a06f850b3cdb7d03ba9e09f
Youngbok Shin [Fri, 21 Sep 2018 08:32:01 +0000 (17:32 +0900)]
evas-wayland-shm: add a missing code caused by upstream migration
@tizen_fix
Change-Id: I9788ac96a85195dabc66552fa34a58a1c60c22e7
Wonki Kim [Fri, 21 Sep 2018 06:32:40 +0000 (15:32 +0900)]
elm_atspi_bride: Add missing changes from cherry-picking
tizen patch
51f850df676956d4085002afb401d2c649ffb93f was cherry-picked from
upstream patch
804fc1667ac72338e3691447e149e54261a9ffe6.
however some changes were not cherry-picked by mistake.
this patch appends the missing changes.
Change-Id: I03323992f8b429f97fce16e512e801cce0057b1d
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Jaehyun Cho [Wed, 19 Sep 2018 12:01:55 +0000 (21:01 +0900)]
els_tooltip: Fix to show correct arrow type
Summary:
Current calculation for arrow type is not based on mouse position.
Consequently, tooltip arrow type is incorrect when tooltip shows on
mouse position with ELM_TOOLTIP_ORIENT_NONE.
Test Plan:
1. Execute "Tooltip" in elementary_test
2. Hover mouse on any button and move mouse
Reviewers: Hermet, raster, woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7074
Change-Id: I60920f4c5320cb649a8ef19359bca77ad2e7d315
Radoslaw Cybulski [Mon, 20 Aug 2018 13:38:39 +0000 (15:38 +0200)]
fix for wrong object passed to _elm_widget_accessibility_highlight_grabbing_set
Turning screen-reader on on setting app and flicking right until
reaching "device" item would crash setting due to invalid object
passed to _elm_widget_accessibility_highlight_grabbing_set function.
Change-Id: I055afee745ff782b870c5663fc124059df3db2f7
Taehyub Kim [Fri, 21 Sep 2018 04:26:26 +0000 (13:26 +0900)]
elc_multibuttonentry: fix the invalid return value
Change-Id: I9bab03d012bb391cc4114c3c8dbd4763ccde6179
SangHyeon Jade Lee [Fri, 21 Sep 2018 05:43:27 +0000 (14:43 +0900)]
evas_filter: fix wrong merge commit in evas filter
Change-Id: I8b8a44ab11b0c473aaee98b5e167e02b51f42999
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Joogab Yun [Fri, 21 Sep 2018 02:58:13 +0000 (11:58 +0900)]
ecore_evas_wayland_common : remove duplicate engine_info_set
We calculate the rotation value at the end of _rotation_do () and then we do the engine_info_set.
So we do not need engine_info_set here.
Myfiles -> search -> keybord -> input text -> look at the mangifier
-> rotate 90 or 270 -> input text -> rotate 0 -> input text -> look at
the mangifier -> issue
Change-Id: I6d729815f6749937693ed7934b08019b5a98c2cb
Youngbok Shin [Thu, 20 Sep 2018 04:32:59 +0000 (13:32 +0900)]
eina: add the last fallback runtime directory as /tmp
When XDG_RUNTIME_DIR environment value is empty,
Eina Vpath tries to use fallback runtime dir by calling _fallback_runtime_dir with "home".
But, that "home" path is not allowed for using runtime dir in Tizen.
So, we are going to add one more fallback directory as "/tmp" which is allowed in Tizen.
@tizen_fix
Change-Id: Ib57e2976d919bfe2a9a4babaa3e8c4626aaa2f8f
Jiyoun Park [Thu, 20 Sep 2018 05:48:09 +0000 (14:48 +0900)]
evas_op_copy: disable neon in _op_copy_c_dp_neon
crash occured in _op_copy_c_dp_neon function's neon code.
so disable neon code in that function until find the root cause.
Change-Id: Ic70585922c839d4dfae31cc5ffbfa5a4e8cf01b6
JunsuChoi [Wed, 19 Sep 2018 11:05:39 +0000 (20:05 +0900)]
ecore_wl2: Add return value check for coverity issue
Using wl_display_dispatch_pending without checking return value.
so add return value check and log message.
Change-Id: Ifa21cad0b0b64ff836215a0e56449c2ef07d6c2b
JunsuChoi [Wed, 19 Sep 2018 10:42:15 +0000 (19:42 +0900)]
ctxpopup: Add return value check for elm_layout_theme_set
Using elm_layout_theme_set without checking return value.
so add return value check and log message.
Change-Id: I849f04464df71b6e5bbd0a677b9f0031a70aaac6
JunsuChoi [Wed, 19 Sep 2018 08:10:32 +0000 (17:10 +0900)]
efl_ui_tab_pager : Fix type mismatch for calloc
Summary:
Fix type mismatch.
The return value of function 'calloc' is cast to type 'App_Data *',
which doesn't match the sizeof expression 'sizeof (ad)' passed as its 2nd argument 'sizeof (ad)'.
The size of the result is 8 bytes, value of the sizeof expression is 4.
Test Plan: N/A
Reviewers: bowonryu, SanghyeonLee
Reviewed By: bowonryu, SanghyeonLee
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7067
Change-Id: I2bd5cc58056c97c288e1bfbab93705568ba2b5f4
Woochanlee [Wed, 19 Sep 2018 04:47:26 +0000 (13:47 +0900)]
ecore_wl2_window: Fix incorrectly implemented null check.
https://phab.enlightenment.org/D7065
Change-Id: I5b97ce038dccaa9d20637802b30fb03686415c25
Taehyub Kim [Wed, 19 Sep 2018 04:40:13 +0000 (13:40 +0900)]
elm_genlist: add internal keyword for making private rootstrap
- To make private rootstrap, @internal keyword is needed.
Change-Id: I7b68ab0558658c38dd1ee5cf6d7a4370aef5594d
Shinwoo Kim [Tue, 18 Sep 2018 10:57:00 +0000 (19:57 +0900)]
ecore_wl2_window: make TIZEN aux_hint interface work
Upstream changed its condition before using aux_hint interface.
The tizen aux_hint interface did not work because of this.
The win->display->wl.efl_aux_hints is NULL on the tizen (downstream).
So there is not a logic change.
*tizen_fix
Change-Id: I767bca40e8605d7dfc46d550f93a349eeb846402
Hermet Park [Tue, 18 Sep 2018 11:59:52 +0000 (20:59 +0900)]
evas vg: fix non rendering issue of vg direct commands.
That's my critical mistake that
I supposed vg is only available at file input.
Change-Id: I9f112cc4e4b6d6058320214855b97716eef9d6bf
Hermet Park [Wed, 19 Sep 2018 02:10:30 +0000 (11:10 +0900)]
evas vg: add 2 more legacy apis.
evas_object_vg_animated_frame_count_get()
evas_object_vg_animated_frame_set()
@feature
Change-Id: I3081551f6da06cdaaecf20471296f58d5412781c
SangHyeon Jade Lee [Mon, 17 Sep 2018 10:54:41 +0000 (19:54 +0900)]
genlist: fix item show/bring in coordinate calculation with zero-sized pan.
item show and bring can be processed with zero-sized pan.
item's coordinate will be calculated with this zero-sized pan,
so target position of scroll region bring in is not proper.
it occurs wrong result of SCROLLTO_MIDDLE and SCROLLTO_BOTTOM cases.
now we check pan size, and if less than 1, deferred call.
this is port of upstream patch D7037
Change-Id: Ie5d5ecd039d835caefa47c272547506946e91a37
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
SangHyeon Jade Lee [Mon, 17 Sep 2018 10:48:12 +0000 (19:48 +0900)]
genlist: missing scrollto_bottom condition in item_scroll is fixed.
ELM_GENLIST_ITEM_SCROLLTO_BOTTOM condition is considered in coordinate_calc,
but not considered in item_scroll which calls deferred for item calculation.
so put the proper condition for ELM_GENLIST_ITEM_SCROLLTO_BOTTOM in item scroll.
this is port of upstream patch D7035
Change-Id: I2b5606c9eee9a7dac31d5aa75598ac0a52f66387
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Youngbok Shin [Tue, 18 Sep 2018 09:01:48 +0000 (18:01 +0900)]
Revert "elm_genlist: add internal keyword for making private rootstrap"
This reverts commit
c898de4c3ad10564599f38ba8bd6e8320ac404bb.
It is reverted to fix build failure.
Change-Id: Ic57982ab987665e965f0c649b103db8fc8bec34e
Youngbok Shin [Tue, 18 Sep 2018 08:41:41 +0000 (17:41 +0900)]
edje: Remove hack code
Summary:
special calculation for textblock is for fit calculation.
This is obvious from code that fit is being calculated
before text is actually been set to textblock.
I am not sure whether this is intentional or mistake
but it make sense to calculate fit after text is being
set so that formatted and native calculation can be proper.
@fix
Test Plan: NA
Reviewers: cedric, zmike, herdsman, devilhorns
Subscribers: stefan_schmidt, #reviewers, #committers, shilpasingh
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6045
Change-Id: Ib3d2256f11027690e756dce438ebc68deeaa02f0
Mike Blumenkrantz [Tue, 28 Aug 2018 18:09:05 +0000 (14:09 -0400)]
ci: run tests up to 5 times before failing
when travis is throttling resourcse more than usual (resources are
dynamically allocated since we are not using a paid service), it
can be the case that tests fail even more than usual.
this number may need to be increased further if 5 does not provide enough
reliability
Differential Revision: https://phab.enlightenment.org/D6920
Marcel Hollerbach [Wed, 1 Aug 2018 14:41:45 +0000 (16:41 +0200)]
elm-containers: use alive api
check if the object is in its correct lifetime before performing
operations
Differential Revision: https://phab.enlightenment.org/D6724
Marcel Hollerbach [Wed, 1 Aug 2018 14:41:14 +0000 (16:41 +0200)]
eo: add funktion for alive checks
The function simply checks if the object is finalized and not
started to be invalidated or invalidated.
Differential Revision: https://phab.enlightenment.org/D6723
Mike Blumenkrantz [Wed, 25 Jul 2018 15:41:39 +0000 (11:41 -0400)]
build: make configure not error if cxx compiler is not found when not needed
a cxx compiler is not required unless physics, poppler, or ddraw support are
enabled, so don't fail configure unless one of those cases is true
ref T2838
Differential Revision: https://phab.enlightenment.org/D6683
Mike Blumenkrantz [Wed, 25 Jul 2018 15:44:21 +0000 (11:44 -0400)]
build: break out ddraw and cocoa static engine builds into utility libraries
these engines include c++ and objc files, meaning the final evas library will
use cxx/objc compilers for linking--even if they are not enabled--as long as
they are added to libevas.la in any condition
by compiling them into separate libraries and linking those into libevas.la,
cc can be used for linking in all cases
fix T2838
Differential Revision: https://phab.enlightenment.org/D6682
Mike Blumenkrantz [Fri, 14 Sep 2018 08:49:45 +0000 (10:49 +0200)]
ci: silence libtool
attempt to disable some libtool warnings throughout the build
https://phab.enlightenment.org/D6661
[Hand edited to get it applied. Stefan]
Yeongjong Lee [Tue, 11 Sep 2018 07:37:56 +0000 (07:37 +0000)]
spinner_example: add focused, unfocused callback to test focus signal
add focused, unfocused callback for test
Differential Revision: https://phab.enlightenment.org/D7019
Marcel Hollerbach [Mon, 13 Aug 2018 13:47:18 +0000 (15:47 +0200)]
ethumb: fix module loading when running in tree
Differential Revision: https://phab.enlightenment.org/D6820
Yeongjong Lee [Tue, 11 Sep 2018 07:22:06 +0000 (07:22 +0000)]
test_gengrid: add focused, unfocused callback to test focus signal
add focused, unfocused callback for test
Differential Revision: https://phab.enlightenment.org/D7018
Mike Blumenkrantz [Mon, 6 Aug 2018 18:14:02 +0000 (14:14 -0400)]
tests/elm: use custom tick source for animator events
ensure that animator ticks are occurring at the same time as render
dumping in order to further speed up tests
Differential Revision: https://phab.enlightenment.org/D6766
Alastair Poole [Wed, 12 Sep 2018 19:18:03 +0000 (19:18 +0000)]
evas_events: NULL check before evas_event_freezes_through.
In some cases focused_obj can be NULL. Add a check before
calling evas_event_freezes_through. Was causing a SEGV
in some situations. Avoiding a crash here is good
but we also need to warn for future debugging to
be more useful.
Differential Revision: https://phab.enlightenment.org/D7027
Alastair Poole [Wed, 12 Sep 2018 19:01:57 +0000 (20:01 +0100)]
efl_ui_focus_manager_calc: invalidate obj on delete.
Summary:
In some situations focus is being set to a deleted object.
Use EFL_EVENT_INVALIDATE on object deletion not
EFL_EVENT_DEL. This prevents the object to be again selected for restoring focus when a redirect is deleted.
This fixes SEGV with some widgets including popup tests.
Test Plan:
* elementary_test -to popup
* popup-center-text + 3 button (check add, remove buttons).
* Close popup, enter text (reopen popup and repeat).
* Crash should be avoided.
Reviewers: bu5hm4n, zmike
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7026
Marcel Hollerbach [Wed, 12 Sep 2018 12:39:14 +0000 (08:39 -0400)]
ecore_wl2: add support for intree loading of the module
Summary: the module was not loaded when we were running intree.
Reviewers: ManMower, devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7023
Derek Foreman [Tue, 11 Sep 2018 16:22:06 +0000 (12:22 -0400)]
wayland_egl: Fix drop shadows on radeon
Summary:
We're doing this all wrong.
We've asking for "at least 1 bit" of A, R, G, B color depth.
ARGB2101010 fits that nicely, so mesa on radeon gives it to us.
This only fixes the drop shadows though, it's entirely possible that
a fullscreen window without alpha would get ARGB2101010 instead of
XRGB8888, so this code probably needs a rethink for multiple engines.
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7022
Lauro Moura [Tue, 11 Sep 2018 14:31:51 +0000 (11:31 -0300)]
efl-csharp: Add copy constructor for eina.Value.
Summary: This will allow deep copying the given value from C#.
Reviewers: felipealmeida, vitor.sousa, segfaultxavi
Reviewed By: vitor.sousa, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7017
Alastair Poole [Tue, 11 Sep 2018 11:22:34 +0000 (12:22 +0100)]
elm_code: Make sure we handle python3 mime type.
Summary:
Let's not miss python3 mimetype when setting up
syntax highlighting.
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7000
Derek Foreman [Mon, 10 Sep 2018 15:34:30 +0000 (10:34 -0500)]
ecore_wl2: Move surface module file to modules directory
It is now similar to how other modules are handled.
Differential Revision: https://phab.enlightenment.org/D7016
Signed-off-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Taehyub Kim [Tue, 18 Sep 2018 07:10:05 +0000 (16:10 +0900)]
elm_access: add internal keyword for making private rootstrap
- To make private rootstrap, @internal keyword is needed.
Change-Id: I34fa6fecb9b48732f5f22a845e5497cf9680cc8e
Taehyub Kim [Tue, 18 Sep 2018 07:06:24 +0000 (16:06 +0900)]
elm_genlist: add internal keyword for making private rootstrap
- To make private rootstrap, @internal keyword is needed.
Change-Id: I3d8d655960dbb8e487bf597e6d70c7b3c20715f6
JengHyun Kang [Mon, 17 Sep 2018 10:58:58 +0000 (19:58 +0900)]
ecore/evas_device: update device info if subclas is changed
Change-Id: I25412cb72df663aab605b41e21b5fb29c5480acd
Hosang Kim [Tue, 18 Sep 2018 05:00:17 +0000 (14:00 +0900)]
slider: fix memory leak
@fix
Change-Id: I9960cd0c59c3bd1d733e7dd12021b2b3cabd8861
Hosang Kim [Mon, 17 Sep 2018 07:20:38 +0000 (16:20 +0900)]
ecore_con_local: change location for socket.
In Tizen, the security does not allow 1 application to create
socket and other applications to connect to that socket.
All sockets should be created by system daemon or service.
Therefore, we request the E compositor to create sockets for us.
Besides, this patches also change the location of sockets to
avoid smack errors.
@tizen_only
Change-Id: I9ceda7bbd5cb7b06331bb2ced6342f646a2f44fb
Hermet Park [Tue, 18 Sep 2018 02:48:13 +0000 (11:48 +0900)]
efl gfx_path: prevent buffer overflow.
Summary:
the counter must be less than 7,
don't allow to over the index.
@fix
Reviewers: #committers
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7053
Change-Id: I35fd1ebf0f1ca0068be306fbe56e72f846eba338
Hermet Park [Mon, 17 Sep 2018 12:42:22 +0000 (21:42 +0900)]
evas vg: don't close file before deleting cache entry.
Since internal eina file could be referred in vg cache,
vg should not close it before deleting cache_entry.
Change-Id: Icc51c609aef5642f834e9a04c427745a1364665b
Bryce Harrington [Fri, 14 Sep 2018 02:50:03 +0000 (11:50 +0900)]
evas vg: Check if could not open file for a vg canvas
eina_file_open() returns NULL under various circumstances such as not
being able to find the file or not having read permission, for example.
Change-Id: Ifcf9f3839fadebe6d2628751a038ac13b6dd1cf5
Bryce Harrington [Fri, 14 Sep 2018 02:47:52 +0000 (11:47 +0900)]
evas vg: Check for OOM when setting root node in a vg canvas
Change-Id: I7597f567be9579adcaedf3db113a66dbd773b211
Bryce Harrington [Fri, 14 Sep 2018 02:45:24 +0000 (11:45 +0900)]
evas vg: Check for OOM in evas_cache_vg_entry_create
Change-Id: I201f5f8fe8c12aa172a979b6f9e8e6cb2cbd78f4
Bryce Harrington [Fri, 14 Sep 2018 02:42:02 +0000 (11:42 +0900)]
evas vg: fix minor typo.
Change-Id: I7e1c7bda6042be42b5cb0c5abb14d685beee8b32
Youngbok Shin [Fri, 14 Sep 2018 05:39:04 +0000 (14:39 +0900)]
edje: add json file support feature
It also starts to support following new edc properties.
1. frame
desc { "default"
vector {
frame: 0.5; // 0.0 ~ 1.0
}
}
2. actions
program { "vector_animation";
// VG_ANIM_PLAY, VG_ANIM_PLAY_BACK, VG_ANIM_LOOP,
// VG_ANIM_STOP, VG_ANIM_PAUSE, VG_ANIM_RESUME
action: VG_ANIM_PLAY;
target: "your_vector_part";
}
Change-Id: If93fdbe68b6af7a2f66e47e3eb8a5bc490e29d23
Juyeon Lee [Fri, 17 Aug 2018 08:06:22 +0000 (17:06 +0900)]
evas_engine: add fn_serial_get to get current serial number
Add to get current serial number from evas engine
@tizen_only
Change-Id: I125159f47a92eacbb96df715527573572c95d7a2
Bowon Ryu [Fri, 14 Sep 2018 04:57:36 +0000 (13:57 +0900)]
Revert "elm_toolbar: fix _item_visiblity"
this commit caused toolbar resizing issue.
This reverts commit
5b90da46b76e0428e1fbbba7a43cdcfde921af75.
Change-Id: Iccb870122bec3952f67f0a8dc7a3ed529d9b32c9
Hermet Park [Wed, 12 Sep 2018 07:23:01 +0000 (16:23 +0900)]
evas json: fix missing ';' - #12
@feature
Change-Id: I0f10a4ed1010a1fa93a9e78daecd450bc0df7e56
Hermet Park [Tue, 11 Sep 2018 11:49:17 +0000 (20:49 +0900)]
evas json: support efl_canvas_vg_file_mmap_set() - #11
example)
...
Eina_File *file = eina_file_virtualize(NULL, data, strlen(data), EINA_TRUE);
eina_file_mmap_set(vg, file, key);
...
eina_file_close(file);
@feature
Change-Id: I4ccfa1dc46f274e0d4838b5dccee58126802743a
Hermet Park [Fri, 7 Sep 2018 11:58:19 +0000 (20:58 +0900)]
evas vg: changed "vg object" to just "vg"
just keep our naming rule along with other primitives.
i.e. efl_canvas_rect, efl_canvas_image, efl_canvas_vg ...
Change-Id: I49c96b4a535cd2fed29a07ec20375a2efd1682af
Hermet Park [Fri, 7 Sep 2018 11:37:26 +0000 (20:37 +0900)]
evas json: revise implementation along with lottie player - #10
lottie-player API has been changed to lottie-animation.
@feature
Change-Id: I7dd04326de713969a2b51b5de0d52e9b243b782f
Hermet Park [Wed, 5 Sep 2018 11:13:08 +0000 (20:13 +0900)]
evas json: fix json loader configuration. - #9
lottie-player detection is not correct.
fix configure to enable/disable it automatically.
@feature
Change-Id: I286341164490b6b89ba0cf7fcd28aba9ba7721bd
Hermet Park [Tue, 4 Sep 2018 05:31:41 +0000 (14:31 +0900)]
evas json: new feature for lottie - #8
add example.
@feature
Change-Id: I71996519e21bb63ce9bdc4b357e98775500b6c4d
Hermet Park [Mon, 3 Sep 2018 12:00:55 +0000 (21:00 +0900)]
evas json: new feature for lottie - #7
Support caching mechanism properly if multiple instances share one resource.
@feature
Change-Id: I3617cf52a51a237c19a424c076d435e01b3e3228
Hermet Park [Fri, 31 Aug 2018 11:20:39 +0000 (20:20 +0900)]
evas json: new feature for lottie - #6
fix a crash case if no file data.
@feature
Change-Id: If3ed044a74fa197337b6ca7c4374f94f050ef91c
Hermet Park [Fri, 31 Aug 2018 11:03:39 +0000 (20:03 +0900)]
evas json: new feature for lottie - #5
fix broken svg/eet compatibility.
@feature
Change-Id: Ifd607b4abe27b402b57bfee2d951735c9e8027f1
Hermet Park [Fri, 31 Aug 2018 06:21:18 +0000 (15:21 +0900)]
evas json: new feature for lottie - #4
vg inherits efl_gfx_image_animation_controller to support animation.
@feature
Change-Id: Ib0b420271d4c5cc22d5f345b7fd5f72a6a44992e
Hermet Park [Fri, 31 Aug 2018 06:05:23 +0000 (15:05 +0900)]
evas vg: code refactoring.
give svg prefix of vg common functions (only for svg functions)
Change-Id: I29627d0ec958362336c909f9e2b1d1d246fcfac2
Hermet Park [Thu, 30 Aug 2018 11:26:41 +0000 (20:26 +0900)]
evas json: new feature for lottie - #3
++implementation to draw first image.
@feature
Change-Id: I8f2fbab042c91b54726b8805f494a4b6264ca42b
Hermet Park [Wed, 29 Aug 2018 12:49:31 +0000 (21:49 +0900)]
evas json: new feature for lottie - #2
1. polish canvas vg/cache infrastructure code.
2. expand loader module interfaces - open/close/data
then reconstruct based on it.
3. fix to close vg cache data properly.
@feature
Change-Id: Ic23926db4b545bbd3fc6ae55dd851c06b8c147b4
Hermet Park [Tue, 21 Aug 2018 10:41:31 +0000 (19:41 +0900)]
evas json: new feature for lottie - #1
set up infrastructure for json loader.
@feature
Change-Id: I1a12ad306da2db9b90150a9df5d9e49b5e0e5f7e
Hermet Park [Thu, 13 Sep 2018 09:59:00 +0000 (18:59 +0900)]
Revert "Revert "Revert "Revert "evas image: fix a bug in image preloading.""""
This reverts commit
d91b043750bc8672cf6b9648cfcdae95c5b54b30.
fixed TC - https://review.tizen.org/gerrit/#/c/189099/
Gwanglim Lee [Thu, 13 Sep 2018 09:24:35 +0000 (18:24 +0900)]
evas canvas: fix null possibility of evas_object_above_get().
fix null object return when trying to get an object
above the current object and a layer with no objects is present.
probably a layer not being cleaned somewhere.
Reviewed By: Hermet
@fix
Change-Id: Iffacaf6f3fd62771d208b611f96ecde77260e498
Shinwoo Kim [Thu, 13 Sep 2018 05:20:32 +0000 (14:20 +0900)]
Revert "evas: fix child position when the container is moved"
This reverts commit
c59a8ddebc6d1d8fd4f6c9855b7c8cb1c50a6c6e.
*Reason: Failed TC
Shinwoo Kim [Thu, 13 Sep 2018 04:59:06 +0000 (13:59 +0900)]
Revert "Revert "Revert "evas image: fix a bug in image preloading."""
This reverts commit
e887948f90b244d3f7c55862c4b56a47e7d83817.
*Reason: There is failed TC.
Jiyoun Park [Tue, 11 Sep 2018 08:25:40 +0000 (17:25 +0900)]
eina_debug: add env to turn off the eina cpu debug
sometimes eina_debug_cpu causes deadlock.
and some app has limitation the number of thread, bug this cpu increase thread number.
so add method to turn on/off eina cpu debug.
Change-Id: I25a0cf61765eaa0deebeabeffa0825116eacf4f4
Juyeon Lee [Mon, 13 Aug 2018 01:45:42 +0000 (10:45 +0900)]
ecore_wl2_display: add tizen_move_resize for client demand move resize
Client window is driven its move,resize by display server using xdg_shell.
btw some tizen application wants to make its position and size while they're shown
server received tz_position, and resized buffer in consequence so far.
but client's position, and buffer delivery does not always come to server at the
same idler loop. In that case, user could see move first, and resize after a sec.
here, added new wl protocol and ecore_wl2_window_sync_geometry_set api to make
move and resize happen at the sametime.
@tizen_only
Change-Id: If4bd8153c0842cce82333d02278e23f6d7e2402c
SangHyeon Jade Lee [Mon, 10 Sep 2018 06:29:11 +0000 (15:29 +0900)]
elm_gengrid: fix item_show / bring_in deferred call.
item_show / bring_in will be deferred, if object is not resized properly.
the deferred call of item_show_region() is on the calc_job(),
after calculating proper object, pan size, but still item is not placed,
so target scrolling position is wrong while item_show_region().
move deferred call to group_calculate() to get correct item position,
after item_place() and group_item_place() were processed.
this is port of upstream patch D7014
Change-Id: I3a2842f75fb4b46a8ea5c5eab7df8cf03e068102
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Myoungwoon Roy, Kim [Tue, 11 Sep 2018 04:14:33 +0000 (13:14 +0900)]
Revert "evas: replace a current copy color function for neon"
This reverts commit
aa2db962b00b68ff6df411a84dfe69c7c5cb00a9.
Marcel Hollerbach [Sat, 8 Sep 2018 12:19:04 +0000 (14:19 +0200)]
efl_ui_focus_util: refactor the util for focusing objects
the previous code had the problem that we moved focus onto logical
objects which were not having any children, thus we saw errors from the
focus manager.
Now we are checking if we are able to deliver focus onto a child of the
passed user.
Differential Revision: https://phab.enlightenment.org/D7009
Jaehyun Cho [Mon, 10 Sep 2018 11:29:24 +0000 (20:29 +0900)]
efl: Remove unnecessary abstract/class inheritance
Summary:
Remove unnecessary abstract and class inheritance from eo file because
those abstracts and classes are duplicate.
e.g. if class B (class A) in B.eo file, then class C (class A, class B) in C.eo file.
Reviewers: woohyun, felipealmeida, Hermet, bu5hm4n
Reviewed By: Hermet, bu5hm4n
Subscribers: bu5hm4n, cedric, segfaultxavi, q66, #reviewers, lauromoura, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6982
Yeongjong Lee [Mon, 10 Sep 2018 11:22:52 +0000 (20:22 +0900)]
elm: add missing efl_ui_popup_part_backwall header
Summary:
efl_ui_popup_part_backwall.eo.h is needed for repeat_events method.
ref
31be3af62d5dfdaa8a468916aa48e3899d6b0217
Test Plan: make
Reviewers: Jaehyun_Cho, Hermet
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7015
Hermet Park [Mon, 10 Sep 2018 08:27:42 +0000 (17:27 +0900)]
Revert "evas vg: changed "vg object" to "vg""
This reverts commit
ec69abed9d63e7876238dffc4b0d3398d1cd1be1.
Ooops, I didn't intended this patch. @#!@#!@#!@#
Hermet Park [Mon, 10 Sep 2018 08:26:12 +0000 (17:26 +0900)]
evas image: remove duplicated EINA_UNUSED specifier.
Hermet Park [Fri, 7 Sep 2018 11:58:19 +0000 (20:58 +0900)]
evas vg: changed "vg object" to "vg"
Summary:
Following our naming rule, rename to like other primitives.
i.e. efl_canvas_rect, efl_canvas_image, efl_canvas_vg ...
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7013
Wonki Kim [Mon, 10 Sep 2018 04:36:09 +0000 (13:36 +0900)]
evas: replace a current copy color function for neon
Summary:
current copy color function has problem sometime on a arm neon environment.
inline asm code makes crashing problem.
so that this patch replace the asm code with a function which is a part of pixman project.
Reviewers: cedric, Hermet
Subscribers: kimcinoo, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6922
Jaehyun Cho [Mon, 10 Sep 2018 04:29:54 +0000 (13:29 +0900)]
efl_ui_popup: Remove inheritance from Efl.Canvas.Object
Summary:
Class Efl.Ui.Popup_Part_Backwall inherits from multiple classes,
class Efl.Ui.Layout.Part and abstract Efl.Canvas.Object.
To remove multiple class inheritance, Efl.Canvas.Object is not
derived and its property, repeat_events, is newly defined in
Efl.Ui.Popup_Part_Backwall.
Test Plan:
1. Execute elementary_test.
2. Select Efl.Ui.Popup.
3. Select "Show Dummy Button".
4. Select "Repeat Event Set".
5. Test if repeat event works.
Reviewers: woohyun, felipealmeida, Hermet, segfaultxavi
Reviewed By: Hermet, segfaultxavi
Subscribers: bu5hm4n, q66, cedric, segfaultxavi, lauromoura, #reviewers, herb, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6984
Alastair Poole [Sun, 9 Sep 2018 20:19:31 +0000 (21:19 +0100)]
elm_code_file: preserve file permissions on save.
Test Plan:
* Run Edi (Python project)
* Edit setup.py
* Run build
* Permissions should be preserved.
* setup.py should build.
Reviewers: ajwillia.ms
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7008
Bryce Harrington [Sat, 8 Sep 2018 11:19:53 +0000 (07:19 -0400)]
eina: Add doxygen in/out tags for remaining APIs
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7007
Hermet Park [Fri, 7 Sep 2018 10:17:35 +0000 (19:17 +0900)]
Revert "Revert "evas image: fix a bug in image preloading.""
This reverts commit
72c84e412b7d497a9110d7feb9b9e916e3535911.
Hosang Kim [Fri, 7 Sep 2018 04:28:52 +0000 (13:28 +0900)]
Revert "evas image: fix a bug in image preloading."
This reverts commit
9440c9aca3b19c7c8a7542d8863358c1957c7c33.
Change-Id: I7590dc65e689ee3de6f539735003cb8d312a4249
Jiyoun Park [Thu, 6 Sep 2018 06:16:36 +0000 (15:16 +0900)]
ecore_wl2: fix crash related with double free
Change-Id: I7f2b7a3710b65b5f64d6c098a6fdc84ee2467e8d
JengHyun Kang [Wed, 5 Sep 2018 09:19:01 +0000 (18:19 +0900)]
evas_events: support single touch's extra axis information
Change-Id: I4c4b433fa8230b13d789223812f7a0fa5d98fbe1
Yeongjong Lee [Fri, 31 Aug 2018 08:45:31 +0000 (17:45 +0900)]
docs: Fix typos in API reference doc and comments.
Reviewers: Hermet, segfaultxavi
Reviewed By: Hermet, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6948
Change-Id: Id5c989a79954f1339cba70f1168cad4ba7e494f7
Yeongjong Lee [Mon, 3 Sep 2018 00:23:30 +0000 (09:23 +0900)]
docs: Fix typos and some wrong expressions in API reference doc.
Change-Id: I3305a4a119b9664f918a04dd3af437bf6bb46d78
Hermet Park [Mon, 3 Sep 2018 06:19:02 +0000 (15:19 +0900)]
evas image: fix a bug in image preloading.
Summary:
Current preloading is too buggy since it's on thread-based.
This is a fundamental improvement to fix a bug.
The critical issue here is,
When preloading img object suddenly cancel its preloading,
the object possibly cannot render image next then because
renderer doesn't have any idea when async cancelling is
finished. Renderer just tries to render regardless of
image loading status, and this could occur no-texture(in gl case)
image object.
So, here improvement is, adding a notification for async cancelled
so that putting img objects to redraw images properly after their preloading is
cancelled.
The best scenario to reproduce this bug is this one.
Evas_Object *img2 = evas_object_image_filled_add(evas);
evas_object_image_file_set(img2, "test.jpg", NULL);
evas_object_image_preload(img2, EINA_FALSE);
evas_object_resize(img2, 200, 200);
evas_object_show(img2);
Evas_Object *img = evas_object_image_filled_add(evas);
evas_object_image_file_set(img, "test.jpg", NULL);
evas_object_image_preload(img, EINA_FALSE);
evas_object_move(img, 200, 200);
evas_object_resize(img, 200, 200);
evas_object_show(img);
evas_object_image_preload(img2, EINA_TRUE);
If you run this on gl backend, occasionally happens rendering fail.
Yet there other bugs on preloading feature....
@fix
Reviewers: #committers, raster
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6919
Signed-Off-By: Hermet Park <chuneon.park@samsung.com>
Change-Id: I078e68cba2a8c0134ae9c6273c7879b166619427
SangHyeon Jade Lee [Thu, 30 Aug 2018 11:21:09 +0000 (20:21 +0900)]
elm_genlist: item scroll show sould be processed after block calculation
This patch is port of upstream patch
6dd149d8fef662a8c938b8335fc311caeef89911
Summary:
there are buggy actions in the item show api,
when the list is launched, scroll to far distance item.
the reason is item_scroll is called before it's block is fully
calculated in calc_job().
the origin patch of cause the issue is
f6b66cc1d3b94bedc25cb10bd5317855954af973
by raster in 28 Nov, 2013
but we already do some extra works in calc_job(),
so the code is not necessarily called in queue_process().
more detail descriptions :
mainly this caused by block width size,
so the normal case block width is zero, and item_scroll() will be dismissed,
and deferred action in calc_job(), but in issue case,
block width is already been set, so it can scroll the item directly though
they aren't properly calculated yet.
most cases block was generated in the same queue processing so width size is
not exist, but in issue cases, they re-using the block which was already been
generated by previous queue processing, so the width size is already exist,
but height is not properly calculated yet.
we could move the block height calculation and min/max calculation
in the queue processing, but I'm afraid to face side effect,
so removing item_scroll() call is best option that I got.
Change-Id: Ib3bfcde0eec23c9e7a8363876d7c2ec0f39fccc0
Hermet Park [Thu, 30 Aug 2018 04:26:06 +0000 (13:26 +0900)]
evas cache: refactor internal logic.
Summary:
Adding cache targets in other modules are inproper.
This can't be managed by cache module inside.
One representive scenario is,
when preload cancel is triggered, preload canceling sequence
can't be performed properly because cache targets implicitly were
increased by backend modules.
And then, Cache itself couldn't get notified it.
see this condition.
if ((!ie->targets) && (ie->preload) && (!ie->flags.pending))
in _evas_cache_image_entry_preload_remove()
Consequently, I move preloaded callbacks to sync with adding cache targets,
not to add by backed engines themselves.
This will bring Cache to manage cache targets properly.
Reviewers: #committers, raster
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6912
Change-Id: I85312f2c16f594260ee3aa7895c283a3de782eb3
Signed-Off-By: Hermet Park <chuneon.park@samsung.com>
Hermet Park [Thu, 30 Aug 2018 04:17:44 +0000 (13:17 +0900)]
evas cache: remove unused custom task in preload.
Summary:
That redundant code just made code complex.
This is one of intermediate patches for preload
Reviewers: raster, #committers
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6907
Change-Id: I684e7dbee8455abeb9c9cc7b15056c7de5cd43b5
Signed-Off-By: Hermet Park <chuneon.park@samsung.com>