Vyacheslav Cherkashin [Thu, 5 Nov 2015 17:01:12 +0000 (20:01 +0300)]
[IMPROVE] use ktd in preload
Remove dependent on task_data
Change-Id: Ib41f74a302a9bcc59e783374a2eaaf1142bc6627
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Anatolii Nikulin [Thu, 29 Oct 2015 08:59:22 +0000 (11:59 +0300)]
[IMPROVE] use list for saving target binary
Dynamically changed array is more difficult to implement
and may cause memory errors.
Using the list instead of an array is preferable.
Change-Id: I20b5ce6be161db9b83a89080ff8dc75e99970651
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
(cherry picked from commit
c10e49a445762009aaed62d834d5f96ea6236973)
Vyacheslav Cherkashin [Thu, 29 Oct 2015 13:02:39 +0000 (16:02 +0300)]
Revert "[IMPROVE] ARM: workaround for already running"
This reverts commit
3001e19e1ef5c4545623ec12a04fed64cba90ba2.
Conflicts:
us_manager/helper.c
us_manager/pf/pf_group.c
us_manager/pf/pf_group.h
Change-Id: I1b13b41c68fe61daabc7d7bc9f13c03ff797f270
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Alexander Aksenov [Fri, 30 Oct 2015 09:05:07 +0000 (12:05 +0300)]
[FIX] WSP: double free
Issue:
Freeing pointer to the memory that was already freed.
Solution:
Set pointer to NULL after free. kfree(NULL) is safe according
to standart.
Change-Id: I5fd0ceee1078a71d17a44aacb1319b116f5d5c9d
Signed-off-by: Alexander Aksenov <a.aksenov@samsung.com>
Alexander Aksenov [Fri, 30 Oct 2015 09:37:27 +0000 (12:37 +0300)]
[FIX] Kprobe: add include to swap_ktd
Issue:
swap ksyms is used in kprobe, but necessary include is lost
Solution:
Add inlcude
Change-Id: Ib3d4fb1a1e95063f724a1bc45e26c63a53d313d0
Signed-off-by: Alexander Aksenov <a.aksenov@samsung.com>
Vyacheslav Cherkashin [Wed, 28 Oct 2015 15:11:02 +0000 (18:11 +0300)]
[FEATURE] already running
use taskctx_run() for installing uprobes to already running processes
Change-Id: I00ce9f057cb2b39175d4d757ccad8112c6cd657e
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Tue, 22 Apr 2014 19:14:30 +0000 (23:14 +0400)]
[FEATURE] task context for KS
Create functionality for execution function in context either
thread context (only for US threads).
Send fake signal to the thread and catch signal handler.
It make possible to execute function in thread context.
Change-Id: I9eb48dad7dae4658f4452c2c74da7e156bb6d80c
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Hyeongsik Min [Thu, 29 Oct 2015 04:48:05 +0000 (13:48 +0900)]
[FIX] Preload: fix slup corruption issue
target_binaries_slots is already updated in
__alloc_target_binaries_no_lock()
Change-Id: Icb8cf149359425ee93bd45c525e036d247b2b752
Signed-off-by: Hyeongsik Min <hyeongsik.min@samsung.com>
Alexander Aksenov [Tue, 29 Sep 2015 14:39:11 +0000 (17:39 +0300)]
[IMPROVE] WSP: pass data via debugfs
Webapp path and ewebkit path were hardcoded, now
they are written in wsp debug by manager.
Change-Id: Ia16de26c1db89f791108a44639b9f79ae3dbdca1
Signed-off-by: Alexander Aksenov <a.aksenov@samsung.com>
Vyacheslav Cherkashin [Wed, 7 Oct 2015 14:05:20 +0000 (17:05 +0300)]
[FEATURE] ktask_data implement
Change-Id: I3508a7875d6da6e8e422d6462eaa47bb1385daf1
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Tue, 13 Oct 2015 15:06:33 +0000 (18:06 +0300)]
[IMPROVE] coordination of the use of the stack
Change-Id: Ib3b0b126ccb651b6cbaab99be0ccb50a9f79d100
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Thu, 8 Oct 2015 13:38:44 +0000 (16:38 +0300)]
[FEATURE] swap_td_raw implement
Change-Id: I96939a7710d3ddac969b26c50b0fd507f5b54b47
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Anatolii Nikulin [Wed, 21 Oct 2015 13:06:59 +0000 (16:06 +0300)]
Merge branch 'tizen_2.4' into tizen_2.4_dev
Change-Id: I9ca9dd85e7c85433c9f4f121f2ef68952cc722ab
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Anatolii Nikulin [Wed, 21 Oct 2015 07:46:38 +0000 (10:46 +0300)]
[FIX] check probe for uncreated process
Change-Id: I3129b03ab50d8034239cac40a13bf09f5d9718c1
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Anatolii Nikulin [Tue, 18 Aug 2015 13:03:43 +0000 (16:03 +0300)]
[FIX] remove unnessary function uprobe_prepare_singlestep()
Change-Id: Ie9cac13905c4e4c040fa6880e316d3cb1617bc83
Anatolii Nikulin [Thu, 20 Aug 2015 12:05:49 +0000 (15:05 +0300)]
[REFACTOR] add support for manipulating probes depend on probe info
Change-Id: I966f8703051d3f8853fd05e3a68a5049b1a2fe07
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Anatolii Nikulin [Tue, 28 Jul 2015 11:52:32 +0000 (14:52 +0300)]
[FIX] memleak with cdev_alloc()
Change-Id: I23b815dae1bb57b6da4c37bde02c32c63949012b
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Anatolii Nikulin [Fri, 24 Jul 2015 08:08:51 +0000 (11:08 +0300)]
[REFACTOR] Change probe info implementation
Change-Id: I5731ba88680de367f045b6072edf34ccaf41272c
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Vyacheslav Cherkashin [Fri, 9 Oct 2015 11:57:46 +0000 (14:57 +0300)]
[FIX] probe_info struct size value setting during creation
Change-Id: If26e8fffa85b0b90386e5a5246b6c3e31a851966
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Alexander Aksenov [Thu, 8 Oct 2015 19:13:08 +0000 (22:13 +0300)]
[FIX] Us_manager: memory access on unregister
Previously put_user() lead to a deadlock in kernel
Change-Id: I8f1497225ea76e771003f9f16a18a1efa41235e4
Signed-off-by: Alexander Aksenov <a.aksenov@samsung.com>
Vyacheslav Cherkashin [Thu, 1 Oct 2015 13:04:12 +0000 (16:04 +0300)]
[FIX] disarm uretprobe from child process
get_user can be used only if task->mm == current->mm
So for other case let call *_proc_vm_atomic()
Change-Id: I227da7e2ccfcb70fb3dd27b54f5ec4ad1056296e
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Anatolii Nikulin [Wed, 30 Sep 2015 07:50:42 +0000 (10:50 +0300)]
[FIX] remove unnessary spin_lock_irqsave/spin_unlock_irqrestore
Change-Id: If99a0ee36b5033d1e552441ff731da2870ff1ca8
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Anatolii Nikulin [Tue, 29 Sep 2015 13:31:10 +0000 (16:31 +0300)]
[FIX] fix spin lockup
Do not use lock while disarming current proccess
Change-Id: I7d234c5f0d2f5ea28edf8dd17aba315d3271ed58
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Anatolii Nikulin [Tue, 29 Sep 2015 13:23:05 +0000 (16:23 +0300)]
[FIX] error handling for copy from user
swap_msg_flush() should not call if strncpy_from_user() return error
Change-Id: I778abaca7078b4594a3bc1364ed3ef181c174648
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Vyacheslav Cherkashin [Sat, 26 Sep 2015 16:55:32 +0000 (19:55 +0300)]
[FIX] WSP: change path of web aux process
Change-Id: Ief160a9bc4ee5410e29a202e081cc86d24714ca1
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Thu, 24 Sep 2015 18:47:57 +0000 (21:47 +0300)]
[FIX] use d_path between path_get()/path_put()
Change-Id: I608bca68742aacdba4456f772cb2e006fc65b72c
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Thu, 24 Sep 2015 18:45:25 +0000 (21:45 +0300)]
[FIX] add proc_probes_list usage synchronization
Change-Id: I0422bbc212db8f63d7ee61ec703b5fc104af0b24
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Thu, 24 Sep 2015 18:35:09 +0000 (21:35 +0300)]
[IMPROVE] call uprobe handler from specific context (for ARM)
Uprobe handler will be called from context specified by atomic_ctx.
Change-Id: I325e6f1c96c8e009c39bfe9ba926683db7cb0ffa
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Thu, 24 Sep 2015 18:17:04 +0000 (21:17 +0300)]
[FIX] check return of set_kjump_cb() for error
Correctly process set_kjump_cb() errors.
Change-Id: I8d486e2e62f61cdd94d4aebe0eadaa9a20eabc78
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Thu, 24 Sep 2015 18:10:47 +0000 (21:10 +0300)]
[REFACTOR] remove unnecessary warning
this waning is redundand
Change-Id: Ia86d62c4ffa9dc7e4e97cc8f8f680fdc28364bf2
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Thu, 24 Sep 2015 18:01:00 +0000 (21:01 +0300)]
[FIX] kprobe and kretprobe disarming synchronization
Guarantee that other CPUs not handle breakpoints right now.
Change-Id: Ida84022387285ab71938f5f679d47a8a45a62d01
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Thu, 24 Sep 2015 15:33:49 +0000 (18:33 +0300)]
[FIX] uprobe: memory access to US for x86
Change-Id: Ib24db9b392855a82ace15dfe282119c1047e4470
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Thu, 24 Sep 2015 09:59:39 +0000 (12:59 +0300)]
[FIX] task_data: sync register/unregister probes
Change-Id: I2056a4895f21c3a319e6ce3b4710f5ae5bd47845
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Anatolii Nikulin [Thu, 17 Sep 2015 20:43:22 +0000 (23:43 +0300)]
[FIX] do not call dlopen in libpthread and libsmack
Change-Id: I4e739c2c9224e7e65dd2d7af4d4429868e941efb
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Vyacheslav Cherkashin [Wed, 23 Sep 2015 14:09:15 +0000 (17:09 +0300)]
Revert "[STYLE] Fix mr_pre_handler"
This reverts commit
f9b31b54d415a5c6eb930fce04695dbdefbfce9b.
Change-Id: I8a4ffeaa7fa0e06cfbaf68b29c3e91d3f880c9b9
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Dmitry Kovalenko [Mon, 14 Sep 2015 14:27:45 +0000 (17:27 +0300)]
[STYLE] Fix __do_usm_stop
Change-Id: I4f080d3b239b2107dba1cf9bf426cdb1767a808c
Dmitry Kovalenko [Mon, 14 Sep 2015 14:27:09 +0000 (17:27 +0300)]
[STYLE] Fix mr_pre_handler
Change-Id: I13ea53ea42082d1cfc9e4201b6731b6672bb2b32
Dmitry Kovalenko [Mon, 14 Sep 2015 12:31:40 +0000 (15:31 +0300)]
[STYLE] Fix preload_threads_get_drop
Change-Id: If63f4874ff48ebe1f57221667a194d70c1a6bf15
Vitaliy Cherepanov [Mon, 21 Sep 2015 17:59:01 +0000 (20:59 +0300)]
[FIX] kernel panic on second DA start
Change-Id: Iee25a61f60450256c1908446e1a9ca3318639b4e
Signed-off-by: Vitaliy Cherepanov <v.cherepanov@samsung.com>
Alexander Aksenov [Wed, 9 Sep 2015 09:09:21 +0000 (12:09 +0300)]
[FIX] Task_data: helper probe reg/unreg
Remove probe's register/unregister away from stop_machine()
Change-Id: Ieb76276bed0546f9e1bd6067aa5bc3171d7d9241
Signed-off-by: Alexander Aksenov <a.aksenov@samsung.com>
Alexander Aksenov [Tue, 8 Sep 2015 16:10:02 +0000 (19:10 +0300)]
[FIX] Preload: sync in atomic
Mutex replaced with spinlock, cause they are used in
handlers (executed in atomic context)
Change-Id: I736f0ae284cc75f8197b8dabc2f837313c8b5553
Signed-off-by: Alexander Aksenov <a.aksenov@samsung.com>
Alexander Aksenov [Tue, 8 Sep 2015 11:29:16 +0000 (14:29 +0300)]
[FIX] Preload: memory allocation in atomic
kmalloc(..., GFP_KERNEL) -> kmalloc(..., GFP_ATOMIC)
cause executed in handlers
Change-Id: If89c5807d96fee9137fb8b0919b7ed4428772ab6
Signed-off-by: Alexander Aksenov <a.aksenov@samsung.com>
Alexander Aksenov [Tue, 8 Sep 2015 11:28:16 +0000 (14:28 +0300)]
[FIX] Preload: context fix
Removed redundant access_ok(), copy_from_user() replaced
with read_proc_vm_atomic().
It is done to prevent sleeping in atomic context.
Change-Id: Ib260e0f89b5a0a034c8e591361d4ab1d2ffa4b95
Signed-off-by: Alexander Aksenov <a.aksenov@samsung.com>
Alexander Aksenov [Tue, 8 Sep 2015 10:28:58 +0000 (13:28 +0300)]
[FIX] US Manager: kmalloc GFP flag
In pfg_create()
create_img_proc()
create_img_file()
create_img_ip()
kmalloc(..., GFP_KERNEL) -> kmalloc(..., GFP_ATOMIC)
cause called only spinlocks.
Change-Id: I0a8b4a5c132b9c76e54515ec75f80c807b2128ad
Signed-off-by: Alexander Aksenov <a.aksenov@samsung.com>
Anatolii Nikulin [Wed, 2 Sep 2015 08:48:27 +0000 (11:48 +0300)]
[FIX] Define breakpoint instruction size for ARM/Thumb modes
Change-Id: If3fe4f15c4b6c60efe4dd12767498785c2637cf9
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Vyacheslav Cherkashin [Wed, 2 Sep 2015 07:19:14 +0000 (10:19 +0300)]
[FIX] Acquire/release reference to the task in sspt_proc
It prevents invalid pointer dereference if the task has already
been terminated.
Change-Id: I8525d16d81a177d13c5a88f507e070214db81fc7
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Wed, 2 Sep 2015 07:01:00 +0000 (10:01 +0300)]
[FIX] Synchronize completion of US profiling
Wait until all the instrumented tasks are cleaned-up
Change-Id: I39a287ab028e6ff99acdb7937d552f69e8e10a88
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Tue, 1 Sep 2015 15:52:45 +0000 (18:52 +0300)]
[FIX] Take mmap_sem on urp disarming in mm_release
Change-Id: I565d7f3d611f4173fd751014bd7519ccf7fc6218
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Sun, 30 Aug 2015 13:21:52 +0000 (16:21 +0300)]
[FIX] Move urp disarming from atomic context on mm_release
Change-Id: Ia8ff37235b5dfe4d43f8d1578459bb4df444468b
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Sun, 30 Aug 2015 13:14:14 +0000 (16:14 +0300)]
[IMPROVE] Do not call cb_clean_child on non instrumented process
Change-Id: I86767ac7dbb62e537e82ffa0062d1472c792887d
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Fri, 28 Aug 2015 13:30:47 +0000 (16:30 +0300)]
[FIX] Remove masking oops_in_progress
Change-Id: Ida57330dde3e3601a7992cff63e7b8cd55735855
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Fri, 28 Aug 2015 11:14:15 +0000 (14:14 +0300)]
[FIX] preload library
when libdl will be mapped
Change-Id: I2156e3ba5b64e0ad4761aca95616f093d9815ef2
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Fri, 28 Aug 2015 11:10:13 +0000 (14:10 +0300)]
[FIX] mmap allocation atribute
PROT_WRITE atribute is needed for writing into allocated memory
Change-Id: I6beb96bae7c331024b99fb2675bcde4430e1f9f0
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Mon, 27 Jul 2015 16:26:40 +0000 (19:26 +0300)]
[FIX] Preload: dentry balance counter
Use atomic_t instead of int to avoid race conditions
Change-Id: Ie32d46a8c822ef8ef6110832c0fcc14ea1594e9c
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Wed, 26 Aug 2015 17:36:17 +0000 (20:36 +0300)]
[FIX] Add chunk_init result checking
Change-Id: Id5534256ac7d492151e51c41d623338032d4fbfb
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Wed, 26 Aug 2015 17:18:25 +0000 (20:18 +0300)]
[FIX] Add default case in swap_put_uarg switch(...) {}
Change-Id: I4f2b1e8467b5681654642fba5bc1b0b89cf1c748
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Wed, 26 Aug 2015 12:36:01 +0000 (15:36 +0300)]
[FIX] Use GFP_ATOMIC flag for pl_struct allocation
GFP_KERNEL causes problems since the structure is allocated
in atomic context.
Change-Id: Ie98b644587385f7d7898fbf6ae68cdbc2256d2e4
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Wed, 26 Aug 2015 12:31:38 +0000 (15:31 +0300)]
[FIX] sspt_filter handling
- Add rwlock to avoid race conditions (i.e. img copied to sspt
multiple times)
- Use GFP_ATOMIC for sspt_filter allocation (done in atomic context)
Change-Id: I0809a8eb16555e2882d900cab8c544a32bdc16b1
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vasiliy Ulyanov [Wed, 26 Aug 2015 12:11:50 +0000 (15:11 +0300)]
[FIX] stop message handling in us_manager
stop_machine is now used only to acquire references to all the
instrumented tasks. In such way we assure that they are not going
to be dropped during SWAP cleanup code execution.
Also a special callback STOP_CB_TD was added for task_data since it
may need to cleanup in stop_machine.
Change-Id: I4ea67092e1f0a006c908392e41ae511b9fff5b6d
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vasiliy Ulyanov [Wed, 26 Aug 2015 11:32:29 +0000 (14:32 +0300)]
[FIX] Use stop_machine to disarm kretprobe_instance
Change-Id: Id1fb5f1ad1a13dc76b465bb08d42f55a4886b713
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Wed, 26 Aug 2015 11:19:55 +0000 (14:19 +0300)]
[FIX] Move call_mm_release invocation out of atomic context
Change-Id: I2f3016c08a6e8c027681beb9c629e27b4f688b4f
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Wed, 26 Aug 2015 10:55:30 +0000 (13:55 +0300)]
[FIX] Allocate uretprobe_instance with correct gfp flag
Need to be GFP_ATOMIC
Change-Id: I0b98334c699ac0e509eea479cab6c8c28c9a1b96
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vasiliy Ulyanov [Wed, 26 Aug 2015 09:15:21 +0000 (12:15 +0300)]
[FIX] Workaround to skip page faults from Preload
Attempts to read userspace stuff from probe handlers (e.g. like we
do in Preload) may lead to crashes.
Change-Id: I00009bb9dc19ba003740d078b9a36dee2f75c3f5
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vasiliy Ulyanov [Wed, 26 Aug 2015 08:48:46 +0000 (11:48 +0300)]
[IMPROVE] Implement kretprobe skipping
If entry_handler returns a non-zero value we will not install
probe on the return address.
Change-Id: Iee2ef0ffadb85d7661b4d46ae30d88cef2d7bc0f
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Wed, 26 Aug 2015 08:07:44 +0000 (11:07 +0300)]
[FIX] Check for atomic context in swap_handle_mm_fault
Now we return an error instead of generating page fault in
atomic context.
Change-Id: I1d4654142c4f22da500c2d3981509f631cb95fd5
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Mon, 24 Aug 2015 16:00:20 +0000 (19:00 +0300)]
[FIX] Flush kretprobe instances after last put_task
Remove rp_inst from kretprobe_inst_table when task has died
Change-Id: I97e8b7209e22f70c5c8ff3afc55704aa3ddfa87e
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Sat, 22 Aug 2015 18:51:10 +0000 (21:51 +0300)]
[FIX] Add reference counting to sspt_proc
To avoid usage after deletion bugs.
Change-Id: Ie2fae9eac15d3d6cd94613c10fa2b5a878045325
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Sat, 22 Aug 2015 16:39:37 +0000 (19:39 +0300)]
[FIX] Skip fixup do_page_fault for ARM
Change-Id: Iaf68e2554881e3cbd952a6267fb4e2f130211d2c
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Sat, 22 Aug 2015 11:44:19 +0000 (14:44 +0300)]
[FIX] Preload: use get_user to obtain current linker state
Change-Id: I90bd7d09c6106a3324fa810d5cdc344a122a49c7
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Thu, 20 Aug 2015 21:37:24 +0000 (00:37 +0300)]
[FIX] Call call_mm_release using kjump
Needed to move the call out of atomic context.
Change-Id: I3688814f09fa5be082fc3e5a203241b1c1eb77e0
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Thu, 20 Aug 2015 21:29:35 +0000 (00:29 +0300)]
[FIX] Avoid non-boot CPUs disabling on stop
On some targets disabling non-boot CPUs may lead to errors in
kernel (i.e. crashes).
Change-Id: I09de281b9f47e40e136a9e30b77db36d95278d52
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Thu, 20 Aug 2015 16:44:27 +0000 (19:44 +0300)]
[FIX] Add spinlock for proc_list in pf_group
Change-Id: Iaaafc4dd4665dbc1e06c280cdc6e7036122f8678
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Wed, 19 Aug 2015 09:09:34 +0000 (12:09 +0300)]
[FIX] Use GFP_ATOMIC flag in retprobe_copy
Change-Id: I6e728b57b4e185b9312d2833e84a1abe5e86bffc
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Tue, 18 Aug 2015 09:32:24 +0000 (12:32 +0300)]
[FIX] probes disarming in fork'ed process
Disarming is now moved out of atomic context.
Change-Id: I723b11e25dc377a7caea5efb54ed42b34db68868
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Mon, 10 Aug 2015 17:10:02 +0000 (20:10 +0300)]
[FIX] uprobe trampoline copying (ARM only)
Copying to userspace needs to be done in non atomic context.
Change-Id: Id2baca9a667bd3c7d53f0b3fb8f391522aca5315
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Mon, 27 Jul 2015 14:44:20 +0000 (17:44 +0300)]
[FIX] preload: move swap_do_mmap out of atomic context
For page mapping we should acquire memory lock. It is not possible atomic context.
move swap_do_mmap to safe place when mm->mmap_sem is locked.
Change-Id: I02847628d800a162f3395a6d73c9cd07240344e0
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Anatolii Nikulin [Thu, 27 Aug 2015 06:55:50 +0000 (09:55 +0300)]
[FIX] prevent issues
fix 4 issues from prevent:
NULL_RETURNS
CONSTANT_EXPRESSION_RESULT
NO_EFFECT
Change-Id: I1385346d039a354a862e516e3b48c841502bf630
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Anatolii Nikulin [Tue, 25 Aug 2015 12:52:36 +0000 (15:52 +0300)]
[FIX] prevent issues
fix 42 issues from prevent:
NULL_RETURNS
UNINIT
REVERSE_INULL
RESOURCE_LEAK
MISSING_BREAK
DEADCODE
DC.SECURE_CODING_SPRINTF
FORWARD_NULL
DC.SECURE_CODING_STRCPY
OVERFLOW_BEFORE_WIDEN
BAD_SIZEOF
Change-Id: I1e7bc4b6e73e8262ee6fa23238d86a62510cb4e5
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Anatolii Nikulin [Thu, 16 Jul 2015 13:19:08 +0000 (16:19 +0300)]
[FIX] us_manager: memleak when deleting instrumentation pointer
Change-Id: I0d69b22ad28f2e1e69f2bfba6c483ee1378df27e
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Anatolii Nikulin [Fri, 26 Jun 2015 09:41:37 +0000 (12:41 +0300)]
[REFACTOR] Rename arch specific structures
Change-Id: I8258a3bab52f849968f4d9f08ff03fe044c711c8
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Anatolii Nikulin [Wed, 24 Jun 2015 13:10:05 +0000 (16:10 +0300)]
[REFACTOR] Replace kprobe_opcode_t -> uprobe_opcode_t
Change-Id: I3a883fda7d0b26c4b3d91d8174aebaa09ea012f4
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Anatolii Nikulin [Mon, 22 Jun 2015 12:45:02 +0000 (15:45 +0300)]
[REFACTOR] remove kprobe from uprobe
Change-Id: I378b0d6af97b3bd342b7708ffad2122d7e54073c
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Anatolii Nikulin [Fri, 7 Aug 2015 07:57:43 +0000 (10:57 +0300)]
Merge branch 'tizen_2.4' into tizen_2.4_dev
Change-Id: Ic0d2379401909588b5498a6c7f3115af4d1529fc
Signed-off-by: Anatolii Nikulin <nikulin.a@samsung.com>
Alexander Aksenov [Thu, 6 Aug 2015 13:31:57 +0000 (16:31 +0300)]
[FIX] Preload: probes in newly created threads
Previously the second exit from pthread_create (exit in new thread)
was not handled correctly and this lead to messages missing.
Fixed "process data not found" case - now it doesn't lead to drop.
Change-Id: I9c6470758b759ae430b23e0aedb93fc525cea395
Signed-off-by: Alexander Aksenov <a.aksenov@samsung.com>
Vyacheslav Cherkashin [Tue, 4 Aug 2015 08:21:50 +0000 (11:21 +0300)]
[FIX] build for ARM
Change-Id: I550b3492b4f3ab404a2a64b35bdbb6751bbaaba1
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vitaliy Cherepanov [Fri, 31 Jul 2015 09:22:52 +0000 (12:22 +0300)]
[LICENSE] change to GPL-2.0+
Change-Id: Ie7acc73cb741192e1a5d6decaa2a66f44bd91062
Signed-off-by: Vitaliy Cherepanov <v.cherepanov@samsung.com>
Vyacheslav Cherkashin [Fri, 24 Jul 2015 14:03:25 +0000 (17:03 +0300)]
[FIX] memory leak in wsp
Change-Id: Ia5d3a3e4b1831b4aa12d9a665f2adcf70a489d48
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Mon, 27 Jul 2015 10:46:20 +0000 (13:46 +0300)]
[FIX] memory leak in nsp
Change-Id: I34d5b3f7f92739bb92acd6706991cbe28549d4f7
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vasiliy Ulyanov [Fri, 24 Jul 2015 17:45:54 +0000 (20:45 +0300)]
[FIX] Erroneous files struct put
There is no need to make a put_files_struct in case when
get_files_struct returns NULL.
Change-Id: Ia87af58150e96f07f3a5f7e2bd2ee3a9a185d210
Signed-off-by: Vasiliy Ulyanov <v.ulyanov@samsung.com>
Vyacheslav Cherkashin [Thu, 23 Jul 2015 12:17:43 +0000 (15:17 +0300)]
[FIX] remove modules striping from build.sh
Change-Id: I4565984dbc4d3cba11cc312ea32a92a8028f7907
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Thu, 23 Jul 2015 10:11:43 +0000 (13:11 +0300)]
[FIX] wrong unregister
pin_register() was used in nsp_data_uninst() for p_do_app.
change it to pin_unregister()
Change-Id: I56cd3819a7388907b2743e51320d8637bcb23f85
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Wed, 22 Jul 2015 15:29:59 +0000 (18:29 +0300)]
[FIX] usage of kfree'd memory
pfg_item_free(item) tries to access item->pfg so
put_pf_group(item->pfg) should be executed after pfg_item_free.
Change-Id: I28c0059a6c99c284a4e6ef6b0f2fc4a76860166a
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Wed, 22 Jul 2015 15:28:33 +0000 (18:28 +0300)]
[FIX] Use proper structure in FILE_PROBE_INITIALIZER
Wrong structure used during initialization leads to allocation
of less memory than will actually be used.
Change file_private by flock_private.
Change-Id: I2d9951ff11066c13f838c8d7c04b176bbed6d7b5
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Tue, 21 Jul 2015 18:31:31 +0000 (21:31 +0300)]
[FIX] types of wsi function addresses
inspserver_addr, willexecute_addr, didexecute_addr should have
u64 type intead of unsigned long
Change-Id: I0e5692056835b41f59650a77e9ab76796f80a2b4
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vitaliy Cherepanov [Tue, 21 Jul 2015 14:45:09 +0000 (17:45 +0300)]
[FIX] Preload: use caller address from userspace
This is a workaround for Tizen OpenGL probes. We cannot obtain the
expected caller address (i.e. the address in the target binary) from
kernel handlers because GL functions are actually called through
third-party libraries. To handle this situation we now pass the proper
address from userspace handlers.
Change-Id: Ibaa2190aed0c1587fa121feb13536b8ff267e680
Signed-off-by: Vitaliy Cherepanov <v.cherepanov@samsung.com>
Vasiliy Ulyanov [Tue, 21 Jul 2015 11:54:46 +0000 (14:54 +0300)]
[FIX] Preload: use task data for storing slots
Probe slots need to be organized like a per-thread stack in order
to perform function entry/exit checks properly. The former single-list
implementation does not work as expected.
Change-Id: I16152ffb91ab0c5670c750e7cea6b566f59f9724
Signed-off-by: Vasiliy Ulyanov <v.ulyanov@samsung.com>
Vasiliy Ulyanov [Mon, 20 Jul 2015 10:12:30 +0000 (13:12 +0300)]
[FIX] Init/uninit task_data at start/stop
task_data uses kernel probes to track all tasks, hence
it is not correct to initialize it at module load time.
Change-Id: Ibb23d055cc9d0ae2703db8b09fb4d27e6d91e2c8
Signed-off-by: Vasiliy Ulyanov <v.ulyanov@samsung.com>
Vyacheslav Cherkashin [Mon, 20 Jul 2015 11:49:43 +0000 (14:49 +0300)]
[FIX] call vmalloc with zero argument
Change-Id: I02e8cbd9b5ccebeced90d8067a1b3f7cd8cd3083
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Vyacheslav Cherkashin [Sat, 18 Jul 2015 21:07:20 +0000 (00:07 +0300)]
[FIX] slot_table items insertion/deletion
- Probe instances are added to the table only once (x86).
- Fixed an issue when a freed probe instance was not removed
from the table.
- Added rw locking to avoid possible race conditions.
Change-Id: I72eae168b991e041a6a2f751dd7e45c379690052
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Signed-off-by: Vasiliy Ulyanov <v.ulyanov@samsung.com>
Vyacheslav Cherkashin [Sat, 18 Jul 2015 20:42:41 +0000 (23:42 +0300)]
[FIX] replace kmalloc/kfree with vmalloc/vfree
Large memory chunks are better alloccated with vmalloc.
Change-Id: I51828e04269012f06c4198612a8299093af655bd
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Signed-off-by: Vasiliy Ulyanov <v.ulyanov@samsung.com>
projects / kernel / swap-modules.git / log