DongHyun Song [Mon, 19 Feb 2024 06:40:34 +0000 (15:40 +0900)]
[WRTjs][VD] Reduce IS_TIZEN_TV compile flag #3
Remove IS_TIZEN_TV for code readability.
Change-Id: I0cd3ebef4b9ed9bb0465de96d64d3af09bec49d6
Signed-off-by: DongHyun Song <dh81.song@samsung.com>
DongHyun Song [Mon, 19 Feb 2024 06:34:08 +0000 (15:34 +0900)]
[WRTjs][VD] Reduce IS_TIZEN_TV compile flag #2
Add BlockNavigation API to remove IS_TIZEN_TV for code readability.
Change-Id: I1134508597a4dbd99b3424fd551cb14d7d871a74
Signed-off-by: DongHyun Song <dh81.song@samsung.com>
Manjeet [Wed, 21 Feb 2024 10:40:05 +0000 (16:10 +0530)]
fixup! [M120 Migration] Enable snapshot feature for EFL port
This commit adds sample code to test sync screenshot API in ubrowser.
Reference:
https://review.tizen.org/gerrit/298956
Change-Id: I9781243ac601361437d6330035f93a2d53aa9776
Signed-off-by: Manjeet <manjeet.1@partner.samsung.com>
Sun-woo Nam [Sun, 23 Apr 2023 09:12:41 +0000 (17:12 +0800)]
[M120 Migration] Apply opacity/filter/border-radius for video hole.
1. Pass video hole flag to DirectRenderer
2. Disable blend for border-radius case
3. Disable blend and use Black Quad with opacity to simulate
opacity effect.
4. Update render target id for filter effect node
If parent node set filter:brightness, chromium will
create a kFilter effect node. This effect node will create a
contribute render surface which will cover on video. So we need to
update it's render target, let it to render on the same surface with
video hole rectangle.
5. Implement opacity css
Update video layer's target render surface to it's parent target
In some special case, like disney+, Hoichoi.tv opacity animation
will cause opacity abnormal. opacity is 1.0f, but create render surface.
Reference:
https://review.tizen.org/gerrit/#/c/291821/
https://review.tizen.org/gerrit/#/c/292417/
https://review.tizen.org/gerrit/#/c/297840/
https://review.tizen.org/gerrit/#/c/302794/
Change-Id: I6b07af528bb5e912fabec2a7c8a831adb96fbec9
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
Manjeet [Tue, 20 Feb 2024 19:51:43 +0000 (01:21 +0530)]
[M120 Migration] Set IO|GPU thread type with higher priorites
This patch sets IO and InProcGPU thread types to higher priorites
kCompositing and kDisplayCritical respectively, like ANDROID,
to improve rendering performance.
Reference:
https://review.tizen.org/gerrit/290935/
Change-Id: Ib6de5c7a19feeb21e794889692439004ab39ff8a
Signed-off-by: Manjeet <manjeet.1@partner.samsung.com>
yh106.jung [Tue, 20 Feb 2024 23:46:48 +0000 (15:46 -0800)]
Remove conditional statements for M/W profile
Since 8.0, Tizen supports a single set native of APIs.
So, this patch removes conditional statements for Mobile/Wearable
profile from ewk headers.
Change-Id: Id1e419e6fcf81cf0da5aa9c3d874f151b718d396
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
Gajendra N [Wed, 21 Feb 2024 04:15:05 +0000 (09:45 +0530)]
Fix desktop build error on Ubuntu 22.04
Error:
Package 'atspi-2' requires 'glib-2.0 >= 2.62.0' but version of glib-2.0 is 2.40.2
Could not run pkg-config.
System's atspi-2 package version is newer on Ubuntu 22.04 which is not compatible
with the older glib version listed in jhbuild. Since atk is not needed for desktop
build, place the related pkg-configs under is_tizen guard.
Change-Id: I77c8d686af36e6fcbf1e555d109b6a1473e1752d
Signed-off-by: Gajendra N <gajendra.n@samsung.com>
chiragmaheshwari [Mon, 19 Feb 2024 07:25:15 +0000 (12:55 +0530)]
[M120 Migration][PERF]Setting low-end device memory threshold as was in M94
Chromium checks whether current device is low-end device in
`SysInfo::IsLowEndDevice`. Main test is based on how much RAM is
installed on the device. Between M94 and M108 this threshold has been
raised from 512MiB to 2GiB. As most of Tizen TV devices has less then
2GiB RAM available, this causes that these devices are considered
low-end ones.
This causes that `--optimize-for-size` flag is passed to V8 in
`RenderProcessImpl` ctor. Although this indeed lowers memory pressure, it
has also very negative performance implications. So to keep performance
of M108 Chromium on Tizen TVs this patch changes threshold to one used
for M94.
Patch form:
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/292472/
Reference: https://review.tizen.org/gerrit/c/platform/framework/web/chromium-efl/+/293179
Change-Id: Ieb1cad80ff96deca6bb23cd9e262870964b3a1f5
Signed-off-by: chiragmaheshwari <c.maheshwari@samsung.com>
venu.musham [Thu, 18 Jan 2024 11:00:21 +0000 (16:30 +0530)]
[M120 Migration] Error page isolation & navigation.
Disable error page isolation for EFL port
Use the current SiteInstance for error page navigation
Reference: https://review.tizen.org/gerrit/292258
Change-Id: I5a4d59f096a8814bd35d4ef57b4244105c53b457
Signed-off-by: venu.musham <venu.musham@samsung.com>
Sun-woo Nam [Fri, 2 Feb 2024 05:23:57 +0000 (21:23 -0800)]
[M120 Migration][MM] Set mime type and fix the supported formats.
- Set mime type for Tizen
https://review.tizen.org/gerrit/#/c/293363/
- Support MPEG4 format on FFMpeg demuxer.
https://review.tizen.org/gerrit/#/c/301843/
- Fix warnings in supported_types.cc
https://review.tizen.org/gerrit/#/c/301927/
Change-Id: I85a28a3f77c6eb500ad24b1dd6de65eb10514dc8
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
jingjieli [Mon, 19 Feb 2024 09:28:28 +0000 (17:28 +0800)]
[M120 Migration][VD] elapsed time for url request
This adds end point logs for each url requests.
Also enables HWC log for url request.
Reference:
https://review.tizen.org/gerrit/#/c/297942/
https://review.tizen.org/gerrit/#/c/301473/
Change-Id: I3f3812551ca190c7d5e6b3abb222e60a21d724a0
Signed-off-by: jingjieli <jingjie.li@samsung.com>
Manjeet [Tue, 6 Feb 2024 06:10:48 +0000 (11:40 +0530)]
Cleanup dead code which is no longer needed or used.
Reference:
https://review.tizen.org/gerrit/#/c/290702
Change-Id: I033b9f6179f866d4ea07e9270fcd12c3de3ef411
Signed-off-by: Manjeet <manjeet.1@partner.samsung.com>
Gajendra N [Tue, 20 Feb 2024 05:08:44 +0000 (10:38 +0530)]
Cleanup web_view_evas_handler and related code
This part of the code is no longer used since post aura, hence removing.
Change-Id: I857d5f588d0452dac3008c5bf0e1c2459fff7386
Signed-off-by: Gajendra N <gajendra.n@samsung.com>
Manjeet [Wed, 7 Feb 2024 09:10:19 +0000 (14:40 +0530)]
[M120 Migration] Fix SVACE major issues.
Reference: https://review.tizen.org/gerrit/#/c/290723/
Change-Id: Ic39fb19057f0dd8d44bfcd104991e9b59b3aa1c4
Signed-off-by: Manjeet <manjeet.1@partner.samsung.com>
YongGeol Jung [Tue, 20 Feb 2024 04:22:12 +0000 (20:22 -0800)]
Fix buildbreak that occurs when boost lib dependency is removed from wgt module
Due to modification of wgt-manifest-handlers module, the header file related to
|usleep| was removed. Modified to directly include the relevant header file.
../wrt/src/common/app_db.cc -o obj/wrt/wrt_lib/app_db.o
[ 3577s] ../wrt/src/common/app_db.cc:91:28: error: use of undeclared identifier 'usleep'
[ 3577s] usleep(100000 * (count + 1));
[ 3577s] ^
[ 3577s] 1 error generated.
Change-Id: I0ce50874548dbb5c467366f5614761b101212b2d
Signed-off-by: YongGeol Jung <yg48.jung@samsung.com>
Sun-woo Nam [Fri, 2 Feb 2024 05:21:52 +0000 (21:21 -0800)]
[M120 Migration][MM] Get WebContents in Realtime.
1.web_contents_ varaible is passed by TizenRendererImpl constructor
It may be destroyed and don't notify TizenRendererImpl
which makes dangling pointer access
So get webcontents by render_process_id and routing_id in realtime
References:
https://review.tizen.org/gerrit/#/c/295250/
https://review.tizen.org/gerrit/#/c/297630/
- fixup! Solve GetViewportRect crash
There is also a web_contents_ that is not modified.
https://review.tizen.org/gerrit/#/c/295250/
Change-Id: I2d26e63417d9b383dd8a516d6b7b1cb7d1393259
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
venu.musham [Fri, 16 Feb 2024 11:04:40 +0000 (16:34 +0530)]
[v8] Enable v8 optimization.
V8 lite mode was enabled during upversion to resolve build
issues during bringup. lite mode disables v8 optimizations,
hence canvas performance was low.
Enable V8 optimizations.
Change-Id: I705d25fd91d7b3c6bc11006ac92a1dca1799fbdc
Signed-off-by: venu.musham <venu.musham@samsung.com>
Sun-woo Nam [Fri, 2 Feb 2024 05:12:01 +0000 (21:12 -0800)]
[M120 Migration][MM] Pass |user_agent| instead of WebContents during MediaPlayer creation
This is to avoid dependency on //content in //media/filters
for resolving DA build errors for tizen 6.0.
Reference:
https://review.tizen.org/gerrit/#/c/295064/
Change-Id: I01d5d57075b734e15394624e6572ff11cbae1d04
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
DongHyun Song [Mon, 19 Feb 2024 01:58:01 +0000 (10:58 +0900)]
[WRTjs][VD] Make optional value for multitasking support
Make optional value for multitasking support
Change-Id: Ia19a272c898213f1e70d1ec61369464c4fc4ced3
Signed-off-by: DongHyun Song <dh81.song@samsung.com>
liwei90727 [Thu, 8 Feb 2024 09:12:26 +0000 (17:12 +0800)]
[WRTjs][VD] Unset 500ms delay suspend for non-multitasking app
If app doesn't support multitasking, it's unncessary to delay
500ms for suspend, WRT can suspend immediately, then this app
will be quitted at once.
Change-Id: I815c1c58a85092996d61cadb9fb605ba31c24dd9
Signed-off-by: liwei90727 <wei90727.li@samsung.com>
nishitha [Thu, 15 Feb 2024 10:25:29 +0000 (15:55 +0530)]
[M120 Migration][Tizen] Fixes coverity issue AUTO_CAUSES_COPY
Reference : https://review.tizen.org/gerrit/302479/
Change-Id: If7e5ef6e084586c083d470e6a160c0c772bb85fe
Signed-off-by: nishitha <n.saravanan@samsung.com>
Sun-woo Nam [Fri, 2 Feb 2024 05:09:47 +0000 (21:09 -0800)]
[M120 Migration][MM][CAPI] Fix the logic for media using capi player.
This patch migrates the below previous patches partially for hls contents
to make work normally.
- Support webmedia playback state notification
webbrowser need playbackstart event to show miniplayer button.
https://review.tizen.org/gerrit/#/c/292410/
- Support Preloading feature
Add preload feature for Ligada ADINS tcs.
Which need high performance during video switch.
https://review.tizen.org/gerrit/#/c/292683/
- Support seek for live streams
This patch adds support for seek event on HLS / DASH streams.
https://review.tizen.org/gerrit/#/c/292955/
- Fix SetStreamInfo called multi-times issue
Check ispreparing state to avoid multi-times call.
https://review.tizen.org/gerrit/#/c/293823/
- Report right status and currenttime to app
https://review.tizen.org/gerrit/#/c/295396/
https://review.tizen.org/gerrit/#/c/301906/
- Fix hls video can't seek issue
Add flush_cb.run in it to make mojom pipeline works.
https://review.tizen.org/gerrit/#/c/298059/
- Fix CAPI Player Rotation
Rotation will use resource_id in such cases
- ecore_wl2_window_resource_id_get()
https://review.tizen.org/gerrit/#/c/298825/
- Move player initialization and preparation forward.
The first player initialization and preparation can be moved forward.
TizenRendererImpl::StartPlayingFrom -> TizenRendererImpl::Initialize
https://review.tizen.org/gerrit/#/c/300864/
https://review.tizen.org/gerrit/#/c/301060/
- Fix player release issue
Relax condition to make it unprepre always.
https://review.tizen.org/gerrit/#/c/301908/
- Adjust seeking behavior on media-player-capi-tv
This commit adjusts the way seeking is handled by the media player capi
playback layer.
https://review.tizen.org/gerrit/#/c/302863/
Change-Id: I453a8a6c435ace16c93f767be3b27f82a0c99b5d
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
Sun-woo Nam [Fri, 2 Feb 2024 05:08:23 +0000 (21:08 -0800)]
[M120 Migration][MM] Handle media playback with buffering state.
This patch migrates patches to handle playback behaviors with buffering state.
- Pause video when buffered data is not enough.
Pause video when buffered data is not enough to play.
And play video again when enough data is pushed.
This patch fixes audio loss after network is disabled and reconnected.
https://review.tizen.org/gerrit/#/c/300705/
https://review.tizen.org/gerrit/#/c/301096/
https://review.tizen.org/gerrit/#/c/301303/
- Trigger waiting event to APP
Report kReadyStateHaveCurrentData when no data to decoder.
https://review.tizen.org/gerrit/#/c/303941/
Change-Id: I2b0c6161628dfb987b326f34e6b2539ab5b26f87
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
v-saha [Fri, 9 Feb 2024 12:45:43 +0000 (18:15 +0530)]
fixup! [WRTjs] Enable WRTjs
This patch fixes build errors after enabling WRTjs for M120.
Change-Id: Ib7cfe8ea6166a92c87f34e7d384de71d7c2c8d31
Signed-off-by: v-saha <v.saha@samsung.com>
Sun-woo Nam [Fri, 2 Feb 2024 04:19:46 +0000 (20:19 -0800)]
[M120 Migration][MM] Migrate patches for suspend and resume.
This patch supports suspend and resume behaviors when media goes to
background or the mulit-videos scenario.
- Handle suspend for Capi Player.
Handle suspend request from MediaCapabilityManager and resource conflict.
https://review.tizen.org/gerrit/#/c/292279/
- Arrange the suspend logic.
Release the esplusplayer when resource is conflicted.
https://review.tizen.org/gerrit/#/c/298638/
- Fix potential crash issue
Add null check to avoid crash.
https://review.tizen.org/gerrit/#/c/300715/
- Fix the media suspend/resume issue between apps.
Cancel the request suspend task if it has not been completed
when the player is resumed.
Flush the player buffer before seek.
https://review.tizen.org/gerrit/#/c/298571/
- Distinguish suspend situations based on the resource conflict.
The suspend situation by the player is mainly as follows.
1) If there are multiple videos in one content, request suspend by
MediaCapabilityManager.
2) Resource conflict occurs when another video plays in another process.
In case 1), these suspended videos doon't need to be resumed
when the app is suspended and resumed.
In case 2), the video should be resumed when the app is suspended and resumed.
https://review.tizen.org/gerrit/#/c/299121/
Change-Id: I53a602665458945bd359b89276f3602479fea5e7
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
Sun-woo Nam [Fri, 2 Feb 2024 04:15:11 +0000 (20:15 -0800)]
[M120 Migration][MM] Modifications for basic operation of ME & MSE using espp.
This patch migrates previous patches for media operations such as play, pause
and seek. And this patch categorizes them into several groups.
[Buffer logic]
- Reduce read requests
Avoid read request when player is not playing / seeking.
https://review.tizen.org/gerrit/#/c/292239/
https://review.tizen.org/gerrit/#/c/294027/
- Read data from demuxer during buffer underrun
https://review.tizen.org/gerrit/#/c/294082/
-Shrink unnecessary OnBufferingStateChange call.
The player doesn't need to transfer the same state (BUFFERING_HAVE_ENOUGH)
to the renderer side, so add the condition to shrink it.
https://review.tizen.org/gerrit/#/c/299653/
- Do not return the index -1 for the array.
The potential defect was reported by Coverity.
https://review.tizen.org/gerrit/#/c/293011/
- Remove unutilized code
Remove buffering based player state handling.
https://review.tizen.org/gerrit/#/c/294537/
[Seek]
- fixup! [M108 Migration][MM] Introduce renderer seek
for resume play scenario, app will seek to previous playtime
expected_seek_ is set true, if the player is not ready,
it will stop espp to read data from demuxer, so espp prepare never complete
https://review.tizen.org/gerrit/#/c/294960/
https://review.tizen.org/gerrit/#/c/295324/
- Ignore Flush before prepared
https://review.tizen.org/gerrit/#/c/298597/
- Prevent to esplsuplayer_seek twice.
https://review.tizen.org/gerrit/#/c/300869/
- Do not ignore seeking to 0 before prepared.
https://review.tizen.org/gerrit/#/c/301027/
- Skip the seek when the requested time is same as pending seek position.
https://review.tizen.org/gerrit/#/c/301630/
- Fix seeking after esplayer destroyed
https://review.tizen.org/gerrit/#/c/302426/
[Other]
- Fix video_000 video tct
Fix manual tests "video_000" that expects reference frame
to be displayed on the screen.
https://review.tizen.org/gerrit/#/c/292260/
https://review.tizen.org/gerrit/#/c/292315/
- Do not mute when the playback rate is 2.0.
https://review.tizen.org/gerrit/#/c/296453/
- Keep last frame when receive EOS event
https://review.tizen.org/gerrit/#/c/298157/
- Fix browser main thread stuck issue
player_get_play_position called before prepared.
This sync api will block browser thread.
Only prepare complete, then call this api
https://review.tizen.org/gerrit/#/c/300201/
- Check an espp status before setting the buffer type.
https://review.tizen.org/gerrit/#/c/299286/
- Fix svace warning
https://review.tizen.org/gerrit/#/c/297825/
- Fixup! [MM] Ensure player is destroyed before IEMEDrmBridge
https://review.tizen.org/gerrit/#/c/302624/
Change-Id: I6c77f75da170119892803d3d943cf3422ac5a9df
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
uzair [Tue, 9 May 2023 15:07:59 +0000 (20:37 +0530)]
[M120 Migration] Disable GL_EXT_disjoint_timer_query for TV profile
Below change disables GL_EXT_disjoint_timer_query extension for
TV as its giving invalid values during webapp launch which results
in DidFirstVisuallyNonEmptyPaint() not being sent from engine side
due to which we see black screen on emanual launch.
Reference:
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/292539/
Change-Id: Ib378fea473fb6272d9a2f848f48ffca32703a876
Signed-off-by: uzair <uzair.jaleel@samsung.com>
Sun-woo Nam [Fri, 2 Feb 2024 04:08:19 +0000 (20:08 -0800)]
[M120 Migration][MM] Refactor the relationship between TizenRendererImpl and MediaPlayer.
TizenRendererImpl has MediaPlayer as a memeber variable and calls the functions
of MediaPlayer. MediaPlayer doesn't depend on TizenRendererImpl, but needs to
deliver messages to TizenRendererImpl in some cases.
To remove coupling caused by these two-way calls,
MediaPlayer uses RendererClientInternal which inherits RendererClient
and MediaPlayerTizenClientExtension interface.
(The mojo interfaces RendererClient and MediaPlayerTizenClientExtension are
used to access pipeline from TizenRendererImpl.)
There are three problems in this structure.
1. MediaPlayer has two member variables with different interfaces,
but they point to the same object.
2. In the case of RendererClient, two RendererClient variables are created
according to the audio and video type. They are required when there are
audio and video renderers, but not in the current tizen renderer.
3. I don't think it needs to be implemented according to those interfaces.
The function not included in those interfaces may also be needed.
Therefore, in order to solve these problems,
create MediaPlayerTizenClient interface and make TizenRendererImpl
implement the interface and hand over to MediaPlayer.
In addition, include functions in MediaPlayerTizenClient that were handed over
as callback.
Refernce:
https://review.tizen.org/gerrit/#/c/294565/
https://review.tizen.org/gerrit/#/c/297907/
https://review.tizen.org/gerrit/#/c/300743/
Change-Id: I4da99a4329d7ce1bff02b60dd7ac36b3b1037811
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
DongHyun Song [Wed, 14 Feb 2024 08:12:54 +0000 (17:12 +0900)]
[M120 Migration][Service][VD] Support file extension resolver for ESM type
require.extensions[] extension resolver is only supported on cjs(CommonJS).
For ESM modules, it needs to try to search path with extensions again.
Reference:
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/296123/
Change-Id: I693902979f51d7267cf8d23e2c66d723bc9c45ee
Signed-off-by: DongHyun Song <dh81.song@samsung.com>
DongHyun Song [Thu, 15 Feb 2024 06:52:01 +0000 (15:52 +0900)]
[WRTjs][VD] Hide early if app is visible when termination
If an application is terminated by 3rd party when app is visible,
black screen or abnormal last frame can be observerable for a moment.
So, this patch will hide the window early while closing window.
Change-Id: Ied14bdd3f40891c9695b1ef89250f4bd7010d8f1
Signed-off-by: DongHyun Song <dh81.song@samsung.com>
Sun-woo Nam [Fri, 2 Feb 2024 04:06:25 +0000 (20:06 -0800)]
[M120 Migration][MM] Create the factory class for MediaPlayer creation.
MediaPlayer created in TizenRendererImpl varies depending on the platform
and a media stream type. It complicates the code and makes unnecessary
dependencies.
Therefore, use the factory pattern to increase scalability and
reduce code complexity and dependencies.
Refernce:
https://review.tizen.org/gerrit/#/c/293253/
Change-Id: I57c38e0f6973b57214c8cc04434107cfdca02023
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
Nishitha S [Wed, 14 Feb 2024 11:21:41 +0000 (16:51 +0530)]
[M120 Migration] Fix IME flicker issue
Corresponding IME panel should be shown directly for each input type without
any visible switching between the panel layout types. This patch makes
necessary changes to handle IME flicker issue in RPI4 and FHUB.
Reference: https://review.tizen.org/gerrit/#/c/302466
Change-Id: I3774f05b75d33f538c23decdb19ec99499bc149f
Signed-off-by: nishitha <n.saravanan@samsung.com>
DongHyun Song [Wed, 14 Feb 2024 08:44:32 +0000 (17:44 +0900)]
[WRTjs] Remove build warning
Remove build warning of wrt_service_manager.cc
Change-Id: I027b2476f8d6a971a9a1d7e60f85340f93f8a0c6
Signed-off-by: DongHyun Song <dh81.song@samsung.com>
yh106.jung [Thu, 15 Feb 2024 00:17:26 +0000 (16:17 -0800)]
[M120 Migration][HBBTV] export more symbols to hbbtv
some methods have been moved out of the V8 class into
the namespace v8::api_internal
references:
https://review.tizen.org/gerrit/c/platform/framework/web/chromium-efl/+/291878
https://review.tizen.org/gerrit/c/platform/framework/web/chromium-efl/+/301019
Change-Id: Ieae8248ca5d246d2cb750d7f5d9b19e8cfe455b7
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
Sun-woo Nam [Fri, 2 Feb 2024 04:03:54 +0000 (20:03 -0800)]
[M120 Migration][MM] Remove esplusplayer dependency from the BufferObserver interface.
There is a buffer observer for processing media buffering-related callback
from player.
The current structure is that ESPlusPlayerBufferObserverImpl implements
the BufferObserver interface, which has esplusplayer dependency.
The dependency of certain players is removed from BufferObserver
for scalability to allow Capi mmplayer to also use this interface.
Reference:
https://review.tizen.org/gerrit/#/c/292484/
https://review.tizen.org/gerrit/#/c/292740/
Change-Id: Ie7f5297f37d77f17fe02b8b8a97d903746198e75
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
Sun-woo Nam [Fri, 2 Feb 2024 03:58:36 +0000 (19:58 -0800)]
[M120 Migration][MM] Enable video hole when in full-screen mode in the public profile.
In accordance with the policy, video hole should only be enabled
when the video is in full-screen mode in the public profile.
Therefore, video hole should be dynamically turned on/off
based on whether the video is in full-screen mode or not.
- |esplusplayer_enable_video_hole| is used for this feature.
- Create MediaPlayerESPlusPlayerCommon because |esplusplayer_enable_video_hole|
can be used only for the public profile.
- Extract |SetBufferType| function that sets the buffer type
because the buffer type should be always 'copy' to use
|esplusplayer_enable_video_hole| in the public profile.
- Extract |PrepareVideoHole| function that calls video hole-related apis
to keep the following function call order.
esplusplayer_set_video_frame_buffer_type -> esplusplayer_set_display
-> esplusplayer_enable_video_hole -> esplusplayer_prepare_async
Reference:
https://review.tizen.org/gerrit/#/c/291803/
https://review.tizen.org/gerrit/#/c/292529/
Change-Id: Ibe85b1ad0e2885eb201f309e0630d2eeb40b69a4
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
DongHyun Song [Thu, 8 Feb 2024 09:02:19 +0000 (18:02 +0900)]
[WRTjs][Service][VD] Fix wrt-service crash
When finalize ApplicationData instance on wrt-service, unexpected
acrash is happened probably with wrong instance size.
Change-Id: I5e859f467e3de27def4f7f208087aac3b7fcfdbc
Signed-off-by: DongHyun Song <dh81.song@samsung.com>
sidpaswan [Tue, 6 Feb 2024 04:16:44 +0000 (09:46 +0530)]
[Clang] Updated to Clang 18
Open source llvm 18.0 is built and accelerated for tizen to generate clang,
lld and llvm binaries that are required for clang build for standard profile.
The commit replaces 11.0 headers and binaries with the ones built for 18.0
Basic functionalities tested on TV and rpi4. Working Fine.
Change-Id: Iacd68612b0a04554a9f96105123c0487aa849f59
Signed-off-by: sidpaswan <s.paswan@samsung.com>
sidpaswan [Wed, 7 Feb 2024 09:00:18 +0000 (14:30 +0530)]
Fix for compiler and linker errors with clang 18
Fixes the following linker error:
ld.lld: error: relocation R_ARM_TLS_LE32 against blink::g_thread_specific_
cannot be used with -shared
More details related to the error can be found at:
https://reviews.llvm.org/D93331?id=311994
Change-Id: Ib9471e396415baa5eb77d8471c73433dc88d30f2
Signed-off-by: sidpaswan <s.paswan@samsung.com>
Chandan Padhi [Fri, 9 Feb 2024 08:08:18 +0000 (13:38 +0530)]
fixup! [M120 Migration][MM] Camera and WebRTC patches migration.
This commit fixes desktop build errors resulting from the parent patch.
Change-Id: I8e46faae50771ac8dd1a92d7d457096c5e73204c
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Satyaveer Singh [Thu, 8 Feb 2024 06:10:40 +0000 (11:40 +0530)]
[VD] Disable GPU Rasterization by default
M120 enables GPU Rasterization by default, so we disable it until
it is fully verified. With this patch, improvements on GPU memory
consumption are seen for Naver.
References: https://review.tizen.org/gerrit/291676/
Change-Id: I302d249908e21923f4be8e99616d9547bf956b3e
Signed-off-by: Satyaveer Singh <satyaveer.s@samsung.com>
Sun-woo Nam [Fri, 2 Feb 2024 03:27:35 +0000 (19:27 -0800)]
[M120 Migration][MM] Refactor codes for upversion migration.
Move some codes related to espp to other scopes to migrate next patches easily.
These codes are included in some patches.
https://review.tizen.org/gerrit/#/c/290566/
https://review.tizen.org/gerrit/#/c/291285/
https://review.tizen.org/gerrit/#/c/293459/
Change-Id: I7d3ddd1b81b9ef5d6836c6432bf64f42e3688b1c
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
DongHyun Song [Mon, 5 Feb 2024 06:37:55 +0000 (15:37 +0900)]
[WRTjs][VD] Reduce IS_TIZEN_TV compile flag
Reduce IS_TIZEN_TV compile flag of ApplicationData class
for code readability
Change-Id: I614018414f9b30c3478ab7c9a2fc829fd09e9936
Signed-off-by: DongHyun Song <dh81.song@samsung.com>
zhaosy [Tue, 6 Feb 2024 02:47:11 +0000 (10:47 +0800)]
[M120 Migration][XWalkExtension][VD] Propagates --xwalk-extension-path to renderer
Copy '--xwalk-extension-path' to renderer process to handle xwalk
extensions.
Reference Patch:
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/294333/
Change-Id: I2cbda9b081a4f4a4a8688a0785911594d617da2d
Signed-off-by: zhaosy <shiyusy.zhao@samsung.com>
zhaosy [Sun, 4 Feb 2024 03:21:25 +0000 (11:21 +0800)]
[M120 Migration][WRTjs][VD] Fix camera permission denied issue
In PermissionControllerDelegate::GetPermissionResultForCurrentDocument,
PermissionStatus::DENIED is return as default, so can't use camera for webapp.
Override GetPermissionResultForCurrentDocument in WRT, return PermissionStatus::GRANTED.
Reference:
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/292389/
Change-Id: Ib98e5ec9f73c66493a4df6f8bc1ffa3cfe4a7d7e
Signed-off-by: zhaosy <shiyusy.zhao@samsung.com>
Sun-woo Nam [Fri, 2 Feb 2024 02:48:50 +0000 (18:48 -0800)]
[M120 Migration][MM] Add new class for HBBTV on TV
MediaPlayerBridgeCapi generated MediaPlayerTizen directly.
Delete MediaPlayerEfl MediaPlayerManager MediaPlayerBridgeCapiAdapter.
Reference:
https://review.tizen.org/gerrit/#/c/291756/
Change-Id: I681429ccbe926d8bfd3e6d1a57eb60c56a7428b2
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
Sun-woo Nam [Fri, 2 Feb 2024 01:53:21 +0000 (17:53 -0800)]
[M120 Migration][MM] Make video hole work properly.
This patch includes the three patches below to make video hole work properly
in WRT and so on.
1. fixup! [MM] Fix the issue that video hole is not enabled.
In the previous patch, there is an issue that video hole often doesn't work.
Notify that preferences have been changed when video hole is enabled.
https://review.tizen.org/gerrit/#/c/290642/
2. Enable video hole and remove unused mirror blur codes in WRT.
The video hole feature should be enabled for the web app in the public profile.
To enable the feature, remove unused mirror blur codes in WRT.
The mirror blur is enabled for the wearable profile, but it is unclear whether
the wearable profile will continue to be supported.
https://review.tizen.org/gerrit/#/c/291868/
3. Set window handle for video hole
Video playback will fail on webapps on standard build.
Set window handle to be used for overlay.
https://review.tizen.org/gerrit/#/c/292251/
4. Add onMove logic for window while playing video
For mini-player, window canbe moved. while we move window, we
need to set new geometry for video element.
https://review.tizen.org/gerrit/#/c/295353/
5. Get a current viewport rect to set media geometry.
When a webview was moved, a new viewport rect should be passed to player
to set media geometry for video hole.
Therefore, call |SetPlayerMediaGeometry| in |OnWebViewMoved| callback.
Additionally, remove |ResetMediaGeometry| because there is already logic
for setting deferred.
https://review.tizen.org/gerrit/#/c/295430/
6. Add willdraw logic for web app (partially)
Use willdraw to commit wl_buffer to efl while rotation is done
https://review.tizen.org/gerrit/#/c/294798/
Change-Id: I1787dadff487562c0cffaab8cfdccace83330fdb
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
YongGeol Jung [Wed, 7 Feb 2024 02:15:32 +0000 (18:15 -0800)]
[M120 Migration][WRTjs] Default path for 'ready-to-show'
In order to show the WebApp, a "ready-to-show" message must be generated. The
message should be sent after the first frame is drawn and the layout has been
completed with minimal content. This patch ensures that this timing is met.
Reference:
[1] Modify to ensure |DidFirstVisuallyNonEmptyPaint| callback is called.
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/293610/
[2] fixup! Modify to ensure |DidFirstVisuallyNonEmptyPaint| callback is called.
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/294060/
[3] fixup!(2) Modify to ensure |DidFirstVisuallyNonEmptyPaint| callback is called.
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/294317/
[4] Check presentatoin feedback condition for |DidFirstVisuallyNonEmptyPaint|.
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/294610/
[5] Do not ignore first frame for |DidFirstVisuallyNonEmptyPaint|.
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/295637/
Change-Id: I42979d84c6f3047824bc3e4bec034411b03b23e7
Signed-off-by: YongGeol Jung <yg48.jung@samsung.com>
Sun-woo Nam [Wed, 24 Jan 2024 07:37:11 +0000 (23:37 -0800)]
[M120 Migration][MM] Camera and WebRTC patches migration.
This commit includes commits below.
- Add MJPEG support
Add support for MJPEG camera stream, jpeg frames are internally sent
with PIXEL_FORMAT_ENCODED instead of PIXEL_FORMAT_MJPEG, which avoids
the decoding in default camera pipeline and helps redirecting frames
towards the esplusplayer.
https://review.tizen.org/gerrit/#/c/290488/
https://review.tizen.org/gerrit/#/c/291867/ (partial)
- [GUM] Clean internal tizen codes for camera.
https://review.tizen.org/gerrit/#/c/290574/
- [GUM] Get lens orientation
Camera lenses may give rotated video streams. So, in application lens
orientation is obtained and is used for frame rotation.
https://review.tizen.org/gerrit/#/c/291838/
- Implementation of lazy start
Add lazy_start to capture params when request is generated by
user_media_processor to create camera in suspended state and to create
capture client in paused state.
https://review.tizen.org/gerrit/#/c/291188/
- Fix issues in video capture device tizen
We need keep MJPEG and ENCODED
Fix missing type in function GetCaptureApiTypeString()
https://review.tizen.org/gerrit/#/c/291169/
- Support H.264 codec for the public profile.
Set ffmpeg_branding to "Chrome" for enabling H.264 decoders.
https://review.tizen.org/gerrit/#/c/294042/
Change-Id: I02076dfa9c98ec344cbbdc18847d6a99a781d1a1
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
Sun-woo Nam [Wed, 7 Feb 2024 00:30:33 +0000 (00:30 +0000)]
Add IS_TIZEN_DA to fix build break in standard build.
This patch fixes build break caused by the patch below.
https://review.tizen.org/gerrit/#/c/305076/
Change-Id: I278839c1027c91e3af31a35e6988b63716943891
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
zhaosy [Mon, 5 Feb 2024 07:56:11 +0000 (15:56 +0800)]
[M120][XWalkExtension] Remove EWK_BRINGUP in XWalkExtension
Remove EWK_BRINGUP in XWalkExtension
Change-Id: I9e8dfc0f18e0c5ff511ca7fb7534eae59258fa28
Signed-off-by: zhaosy <shiyusy.zhao@samsung.com>
Gajendra N [Mon, 5 Feb 2024 09:32:15 +0000 (15:02 +0530)]
Fix HTLMInputElement.type not returing "datetime" string for <input type="datetime">
InputType::FormControlType() virtual method is removed in m120 upstream, because
if which 'datetime-local' is returned as string from base impl. Made necesasary
changes to fix the issue.
Change-Id: I439c0e257808f983cbe980c3c7188e208791b80e
Signed-off-by: Gajendra N <gajendra.n@samsung.com>
liwei90727 [Sun, 4 Feb 2024 14:04:55 +0000 (22:04 +0800)]
[M120 Migration][XWalkExtension] Add ewk interface to load XWalk extensions
This interface set a path located xwalk extension json profile file.
- ewk_context_set_xwalk_extension_profile(context, path)
- i.e.,
ewk_context_set_xwalk_extension_profile(
ctx, "/usr/lib/tizen-extensions-crosswalk-ewk/");
Reference Patch:
https://review.tizen.org/gerrit/292805/
Change-Id: I2ddf3e6bdb2ebaf60bcbb360aa6b2a89e0d51b16
Signed-off-by: liwei90727 <wei90727.li@samsung.com>
zhaosy [Sun, 4 Feb 2024 06:07:34 +0000 (14:07 +0800)]
[M120 Migration][WRTjs][Service] Fix some coverity issues
Add initialize for fix some coverity issues.
Reference:
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/305090/
Change-Id: I48a84938fa030fdec0f34a12cd5801b2ab76c06b
Signed-off-by: zhaosy <shiyusy.zhao@samsung.com>
zhaosy [Mon, 22 Jan 2024 07:53:44 +0000 (15:53 +0800)]
[M120][WRTjs][VD] Suspend media tasks without 500ms delay
For webapps, when app is hide, WRT suspend app after 500ms.
But for media, there is resource conflict in this case:
1.Play H5 video in app A
2.Play H5 video in app B
3.Resume app A, media resource conflict
Reason:
In step3, app B is not suspend, so media resource of app B is not released.
Then when app A is fail to play video.
So when app is hide, notify media app is suspend without 500ms delay,
then media will release resource right now.
Reference:
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/304611/
Change-Id: I2aa28df76568d9aee86f5f9cbf68c95e840bb869
Signed-off-by: zhaosy <shiyusy.zhao@samsung.com>
Signed-off-by: DongHyun Song <dh81.song@samsung.com>
(cherry picked from commit
ee9a656b5306a78cfc166e5065b82ddd0b1eeb45)
zhaosy [Tue, 26 Dec 2023 10:45:56 +0000 (18:45 +0800)]
[M120][WRTjs][VD] Fix app is paused issue when VSS app is launched
1.InitializeVSS early for hosted app to make sure aul app com connection is created.
2.In custom case, hide VSS is too later, it caused app window is showing before VSS
video is stopped, then VSS recieve visibility change event and send INTERRUPT event
to app, so app is paused.
So hide VSS in HideSplashScreen(Followed M94 logic).
Reference:
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/303450/
Change-Id: I096dff53987b2b5cdda73d6dfe2c29266f6ac9f7
Signed-off-by: zhaosy <shiyusy.zhao@samsung.com>
(cherry picked from commit
3156f9570c64ed582530c98569c6948d7084d83d)
zhaosy [Fri, 5 Jan 2024 05:08:58 +0000 (13:08 +0800)]
[M120][WRTjs] Fix ApplicationData instance thread safety issue
When app is launched, ApplicationData instance maybe is created
by multi-threads(main thread, prelaunch worker, reallaunch worker)
at the same time.
So add lock in ApplicationData::GetInstance.
Reference:
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/304102/
Change-Id: I883711947700e3cc973f2ad2ce4deee989708517
Signed-off-by: DongHyun Song <dh81.song@samsung.com>
DongHyun Song [Wed, 3 Jan 2024 02:21:06 +0000 (11:21 +0900)]
[M120][WRTjs] Fix double dbus close issue
Change the way to end dbus listening to fix double calls of
dbus_connection_close()
++
wrt-service application handling is not sensitive for
launch performance, so 500ms interval polling looks proper.
In fact, uv-task runner is polling as 500ms either.
Reference:
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/303807/
Change-Id: Icfcfc70a84333d3a8b8f1e0805bafee61b265bc8
Signed-off-by: DongHyun Song <dh81.song@samsung.com>
(cherry picked from commit
d5b98c76536c01ba00086727620dbf71fcd331b0)
(cherry picked from commit
329f0ee54feb80e6c7f2af3efefb23f5a1f9f54b)
Chunling Ye [Tue, 23 Jan 2024 06:23:41 +0000 (14:23 +0800)]
[M120][WRTjs] Add flag to check context_data initialized or not
To avoid visit the invalid uninitialized memory, need add
flag to check context_data initialized or not.
Reference:
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/304681/
Change-Id: I91c9d4c45259591896dbc0f15fa7689cd51d0d0b
Signed-off-by: Chunling Ye <chunling.ye@samsung.com>
(cherry picked from commit
ce59489a22b4f7b3a1e7184520a49b697c6251e5)
Chunling Ye [Wed, 27 Dec 2023 02:18:13 +0000 (10:18 +0800)]
[M120][WRTjs][Service] Refactor the dbus logic for wrt-service
Move the dbus related logic to WrtServiceManager, and then
waitting all init work have done, start RegisterDbusHandler.
Reference:
https://review.tizen.org/gerrit/#/c/platform/framework/web/chromium-efl/+/304105/
Change-Id: I277242e5e3a421b46383cff3740e33cc35b5a2b5
Signed-off-by: Chunling Ye <chunling.ye@samsung.com>
(cherry picked from commit
cf81c129f223890fa12bcb1a6ce8d6a5b3fe23dc)
yh106.jung [Thu, 1 Feb 2024 06:47:36 +0000 (22:47 -0800)]
fixup! [WRTjs] Enable WRTjs
This patch adds empty config.h file to resolve build break.
Reference:
https://github.com/nodejs/node/blob/main/deps/base64/base64/lib/config.h
Change-Id: Ic3041a0bd8ccabdc4c902e8c1ebb5cff68b61265
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
SangYong Park [Fri, 26 Jan 2024 02:42:28 +0000 (02:42 +0000)]
[WRTjs] Enable WRTjs
. electron v28.1.0
+ node modules : @types/node, @types/webpack-env, buffer, husky, process,
timers-browserify, ts-loader, typescript, webpack,
webpack-cli, wrapper-webpack-plugin
+ electron.d.ts : type definitions for electron
. node.js v18.18.2
+ electron's patches
- benchmark, doc, test, tools/node_modules
- some deps (brotli, icu-small, icu-tmp, ngtcp2, npm, openssl, v8, zlib)
. wrt
: from tizen.beta branch (
778559908f17bfec2f28c202c44df1f6bef28a5c)
Change-Id: I7bbaeb2a3d20cc4ee23ffdb9b0220ffbff399bb9
Signed-off-by: SangYong Park <sy302.park@samsung.com>
v-saha [Tue, 23 Jan 2024 21:18:04 +0000 (02:48 +0530)]
[M120][Tizen][Onscreen] Fix build errors for TV profile
This patch fixes TV Onscreen build issues for M120.
Change-Id: I779c25f22364f863fe08b352b628e1cb24d68d9c
Signed-off-by: venu.musham <venu.musham@samsung.com>
Signed-off-by: v-saha <v.saha@samsung.com>
Sun-woo Nam [Mon, 22 Jan 2024 23:05:36 +0000 (15:05 -0800)]
Fix build error for Tizen multimedia migration.
The codes that were changed during the update to m120 are applied.
The features below are enabled.
tizen_multimedia
tizen_audio_io
tizen_web_speech_recognition
tizen_tbm_support is still disabled.
Change-Id: Idfe6f0b877107d00298f4ab772108abfb65b90c2
Signed-off-by: Sun-woo Nam <sunny.nam@samsung.com>
Chandan Padhi [Tue, 16 Jan 2024 06:16:59 +0000 (11:46 +0530)]
Add separate out directory for onscreen chrome build
This commit adds changes to create separate out directory
for onscreen chrome build(desktop and tizen).
Desktop: out.chrome.x64
Tizen: out.chrome.tz_*
Change-Id: I208719e025e2b84b8bf7b6d1cf2d1308207dbc23
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
uzair [Thu, 11 Jan 2024 17:14:22 +0000 (22:44 +0530)]
Accelerate node binary for x86_64 tizen platform
M120 tizen build was randomly hanging as node binary was not
accelerated using qemu-accel. Below change adds node binary
built with qemu-accel which helps fixing random hangs and speeds
up the compilation speed of the same.
Change-Id: I53107cfee1712c43c51e7a9543284aed3ad024b9
Signed-off-by: uzair <uzair.jaleel@samsung.com>
Gajendra N [Mon, 27 Nov 2023 05:58:41 +0000 (11:28 +0530)]
Use proper naming for handles that represent |ewk_view| and its child |main_layout|
In ewk layer, at many places, names like "evas_object()", "evas_object_"
etc., are used to represent |ewk_view| which causes confusion during
debug since there are many evas objects created in efl port.
|ewk_view| is a global object created through ewk_view_add* APIs and is
passed as first argument in most of the ewk APIs, hence it has its own
significance. This patch names it properly across the efl port codebase
for understandibility.
Also, same case with its child object |main_layout|, which is used with
names like "native_view", "parent_view" etc. The child object is created
with api elm_layout_add(), so better to name it like "efl_main_layout_",
since aura::Window is also named with NativeView.
Similarly few functions are renamed as per its usage.
Below is the summary of renaming applied through this patch.
------------------------------------------------------------------------
Before | After
------------------------------------------------------------------------
EWebView::evas_object_ | ewk_view_
::evas_object() / ::getEvasObject() | ewk_view()
WebContentsImpl::efl_native_view_ | efl_main_layout_
WebContentsImpl::CreateEflNativeView() | CreateEflMainLayout()
::GetEflNativeView() | GetEflMainLayout()
EflWindow::native_view_ | events_overlay_
EflEventHandler::native_view_ | events_overlay_
EflWindow::SetNativeViewOffscreen | SetEventsOverlayForOffscreen()
------------------------------------------------------------------------
Change-Id: If8f719ebd0c16ff36c4d521af86e2fa951b70dab
Signed-off-by: Gajendra N <gajendra.n@samsung.com>
Nikhil Shingne [Thu, 11 Jan 2024 06:20:46 +0000 (11:50 +0530)]
[M120] Fix websites loading issue for standard build
This patch fixes websites loading issue for standard build in M120.
Change-Id: I7124cd52234b2cf70592be45bda75b46c0dab9f3
Signed-off-by: Nikhil Shingne <n.shingne@samsung.com>
Suhaspoornachandra [Thu, 28 Dec 2023 08:12:34 +0000 (13:42 +0530)]
[M120][Tizen][Offscreen] Fix build errors for TV profile
This patch fixes TV Offscreen build issues for M120
Change-Id: Ida9265cacd16a9fecc9fac4de014ee238d4ff905
Signed-off-by: v-saha <v.saha@samsung.com>
Signed-off-by: Suhaspoornachandra <s.poornachan@samsung.com>
Suhaspoornachandra [Tue, 2 Jan 2024 13:49:09 +0000 (19:19 +0530)]
Reland "Revert Upgrade NodeJS binary to v16.13.0"
Engine had upgraded nodejs to v16.13.0 for other builds.
This patch upgrades for tizen profile with appropriate
node binary
Change-Id: Ia0fe2a204fad15329fcde0e82ce213b017ff171f
Signed-off-by: Suhaspoornachandra <s.poornachan@samsung.com>
Nikhil Shingne [Fri, 22 Dec 2023 08:20:02 +0000 (13:50 +0530)]
EWK_BRINGUPS fixup for M120
This commit fixes some of the EWK_BRINGUPs added during M114 upversion.
Change-Id: I35402c34d802890e5fe67eab2c31ac0a5d9c765c
Signed-off-by: Nikhil Shingne <n.shingne@samsung.com>
sidpaswan [Thu, 28 Dec 2023 05:49:45 +0000 (11:19 +0530)]
Fix for Onscreen desktop build crash
This patch activates the enable_supervised_users switch.
Change-Id: Ica8733f9c7b38830f9ae6cffbf925b216e943a9c
Signed-off-by: sidpaswan <s.paswan@samsung.com>
Mayank Kumar [Mon, 18 Dec 2023 06:21:59 +0000 (11:51 +0530)]
EWK_BRINGUPS fixup for M120
This commit fixes some of the EWK_BRINGUPs added during M120 upversion.
Change-Id: I3e496b6fc9f11efb6332a1de20ebcf550a2440e9
Signed-off-by: Mayank Kumar <mayank.k@samsung.com>
uzair [Fri, 8 Dec 2023 11:51:38 +0000 (17:21 +0530)]
Fix for zygote crash during browser launch
Zygote process was crashing as its launch path overiding api
from efl port failed. Hence below change adds needed CHECK
macro and partially reverts [1] as CreateDirectory api call
failed in earlier version of tizen as well due to platform specific
"ISDIR" call failure.
[1]https://chromium-review.googlesource.com/c/chromium/src/+/4685555
Change-Id: I0a69511728fdf2d75dd0b44188e5fa8817e1d0b6
Signed-off-by: uzair <uzair.jaleel@samsung.com>
v-saha [Tue, 5 Dec 2023 16:55:01 +0000 (22:25 +0530)]
[M120][EFL][Offscreen] Fix build errors for desktop profile
This commit fixes all gn related, compilation and linker errors
for desktop build.
Change-Id: I590d3c8c33b4dee27e623e7dce9d8214d5c29397
Signed-off-by: uzair <uzair.jaleel@samsung.com>
Signed-off-by: v-saha <v.saha@samsung.com>
v-saha [Thu, 16 Nov 2023 17:22:02 +0000 (22:52 +0530)]
Upload upstream chromium 120.0.6099.5
This is a patch for upstream m120 - m114.
* chromium
dc7563588833ccad6482a3aa5848108c4387e7e5
[SHv2] Hide Safety Hub entry points in guest mode
* v8
81c506e6adcce17d4d88434b8f4a42899684ff22
Version 12.0.267.1
* skia
746dbd8c61ac4e61aab8d74e3197649921e366a6
Merge 11 release notes into RELEASE_NOTES.md
Change-Id: I29f4a234e39422997118427b479849ab50683c2f
Signed-off-by: v-saha <v.saha@samsung.com>
Pranay Chauhan [Fri, 24 Nov 2023 11:16:12 +0000 (16:46 +0530)]
[M114 Migration] Refactor JavaScriptModalDialog for EWK and WRT
Original patch set wrong parent widget to JavaScriptModalDialog class.
Reference: https://review.tizen.org/gerrit/290634
Change-Id: Id1ee9acc57ea8be98064b40f99b012c5e20fb439
Signed-off-by: Pranay Chauhan <pranay.c1@samsung.com>
Nikhil Shingne [Fri, 24 Nov 2023 11:55:16 +0000 (17:25 +0530)]
[M114 Migration] Apply important patches that fixed stability crashes reported on KONA
References: https://review.tizen.org/gerrit/292705
Change-Id: I0f9f18efa2729497cef84235297513184de9fb94
Signed-off-by: Nikhil Shingne <n.shingne@samsung.com>
Pranay Chauhan [Fri, 24 Nov 2023 06:45:10 +0000 (12:15 +0530)]
[M114 Migration] Always set LC_NUMERIC category to 'C' locale
WebVTT's float type position was converted to incorrect css property string in
which ',' is used as decimal point when the locale of LC_NUMERIC category is DE.
blink::String::Format() should always use '.' as decimal point when converting
floats to strings regardless of current locale.
This patch always set LC_NUMERIC category to 'C' locale.
Reference: https://review.tizen.org/gerrit/291129
Change-Id: I601e1ba7e56e5649e078acbc968b5f962f449624
Signed-off-by: Pranay Chauhan <pranay.c1@samsung.com>
Nikhil Shingne [Fri, 24 Nov 2023 07:00:01 +0000 (12:30 +0530)]
[M114 Migration] Remove unused js_dialogs_efl gn target
js_dialogs_efl was originally implemented for content_shell_efl.
As content_shell_efl itself is removed, js_dialogs_efl is
no longer needed.
Reference: https://review.tizen.org/gerrit/#/c/290505/
Change-Id: If93ab010cf0d2f6bbe74b2864a2fdec4df110a29
Signed-off-by: Nikhil Shingne <n.shingne@samsung.com>
Mayank Kumar [Tue, 21 Nov 2023 11:58:37 +0000 (17:28 +0530)]
Squash 3 patches and apply to beta branch
This commit combines and applies the following patches to beta branch:
https://review.tizen.org/gerrit/291694
https://review.tizen.org/gerrit/293029
https://review.tizen.org/gerrit/293259
Change-Id: I0d22e91953121d1c152c02d7ef434655c5aea3ec
Signed-off-by: Mayank Kumar <mayank.k@samsung.com>
Gajendra N [Wed, 24 May 2023 08:32:57 +0000 (14:02 +0530)]
Rename WebContents related delegate classes inside tizen_src
There are around three to four |WebContents**Delegate| classes inside
tizen_src; this causes confusion during debugging the codeflow.
This commit improves readability/understandability by making below changes:
------------------------------------------------------------------------
[1] Rename WebContentsViewDelegateEwk to WebContentsViewDelegateEfl
A class inside tizen_src implementing a opensource public class should have
classname with 'Efl' suffix (instead of 'Ewk').
WebContentsImpl : WebContentsDelegate => WebContentsDelegateEfl
WebContentsViewAura : WebContentsViewDelegate => WebContentsViewDelegateEfl
------------------------------------------------------------------------
[2] Rename WebContentsEflDelegate to WebViewDelegateEfl
Currently WebContentsEflDelegate is created in EWebView and been accessed by
two other classes, hence rename it to WebViewDelegateEfl and make EWebView
own it. Other classes will just use its pointer to route delegate calls.
EWebView \
WebContentsImplEfl --- WebViewDelegateEfl (owned by EWebView)
WebContentsViewAuraHelperEfl /
------------------------------------------------------------------------
After this patch, there exists only 2 |WebContents*DelegateEfl| classes, i.e
WebContentsDelegateEfl and WebContentsViewDelegateEfl, both are inherited
from opensource public classes respectively. Other delegate classnames will
not have prefix 'WebContents'.
Change-Id: I5dafc3f858aed6c9affc81d89a3b8512bfcfc6a9
Signed-off-by: Gajendra N <gajendra.n@samsung.com>
Mayank Kumar [Thu, 16 Nov 2023 10:15:02 +0000 (15:45 +0530)]
fixup! [M108 Migration][Accessibility] Bringup Accessibility
This commit combines the following changes:
1) Migrates below patches from M108
https://review.tizen.org/gerrit/300648
https://review.tizen.org/gerrit/299881
2) Removes EWK_BRINGUPs to enable the A11y flow working.
Change-Id: Ia72564c581f34ca749682fe5c0ddfdfa07079bc4
Signed-off-by: Mayank Kumar <mayank.k@samsung.com>
Satyaveer Singh [Thu, 2 Nov 2023 10:51:07 +0000 (16:21 +0530)]
[M114 Migration][VD] Set the Tizen version of UA
1. Modify Default User Agent
2. [VD][UWE] Set the Tizen version of UA
3. Add UWE App Info in UserAgent only for UWE
References: https://review.tizen.org/gerrit/291510/
Change-Id: I67359cc438731050f62c3bd7b1fd736d649797bc
Signed-off-by: Satyaveer Singh <satyaveer.s@samsung.com>
Nikhil Shingne [Mon, 30 Oct 2023 10:54:15 +0000 (16:24 +0530)]
[M114 Migration][Fixup] Popup window transparent issue
1.Default style is now being provided to applications which
use their own popup edc file so that they can customise their popup
2.C_PopupBasic_WhiteBottom is the UX recommended default style
3.use C_PopupBasic_WhiteBottom instead of default to fix
DF221005-01028,
DF221005-01016
Reference: https://review.tizen.org/gerrit/289305
Change-Id: I80c48b52f04e550185f33495a4dd6f78abbd8d27
Signed-off-by: Nikhil Shingne <n.shingne@samsung.com>
Pranay Pankajbhai Chauhan [Mon, 30 Oct 2023 07:50:46 +0000 (13:20 +0530)]
[M114 Migration] Implement an overridden method in PermissionControllerDelegateEfl
Webpages fetching Geolocation coordinates for first time are supposed to request
for permission from user and show a prompt popup to allow or deny access.
But currently the popup does not appear due to unimplemented method in
PermissionControllerDelegateEfl. This patch adds the same.
Reference: https://review.tizen.org/gerrit/299972
Change-Id: I6131ba88e03d5b881eb83207987b8636a9452506
Signed-off-by: Pranay Pankajbhai Chauhan <pranay.c1@samsung.com>
Chandan Padhi [Wed, 12 Apr 2023 13:00:09 +0000 (18:30 +0530)]
[M114 Migration] Fix for missing mojom binding error during page load
This commit fixes below errors that resulted in renderer process crash
during loading of www.tumblr.com.
[1027/113315.059524:ERROR:render_process_host_impl.cc(5384)] Terminating
render process for bad Mojo message: Received bad user message: No binder
found for interface blink.mojom.BadgeService for the frame/document scope
[1027/113315.059608:ERROR:bad_message.cc(29)] Terminating renderer for bad
IPC message, reason 123
Reference: https://review.tizen.org/gerrit/291273/
Change-Id: Ibd48409d77fa69ebe16a45b33f1965383b801661
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Chandan Padhi [Thu, 26 Oct 2023 09:08:57 +0000 (09:08 +0000)]
Revert "Upgrade NodeJS binary to v16.13.0"
This reverts commit
41902d27495512fe250e450298a2e6adaea5f6be
due to build errors for TV profile.
Change-Id: I71230118cf2b166dad3b578d2635f69430ec78e6
Chandan Padhi [Thu, 26 Oct 2023 09:21:04 +0000 (14:51 +0530)]
fixup! [Tizen] Fix for Compiler and linker errors
This commit ensures that a valid TtsPlatform is returned to fix
segmentation fault crash related to it on following websites.
www.baidu.com
www.hao123.com
www.flipkart.com
Change-Id: I86e9f50fb7f54be8980dabc114ac45af7b7d4a8c
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Gajendra N [Wed, 25 Oct 2023 12:42:49 +0000 (18:12 +0530)]
[Autofill] Make AutofillClientEfl implement ContentAutofillClient
Made changes as per upstream patch [1]. Set ContentAutofillClient as base
class for AutofillClientEfl similar to Android and Chrome implementations.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/4272332
Change-Id: I70d8604cacb61c51e60d26fb70ff6bfc197356a3
Signed-off-by: Gajendra N <gajendra.n@samsung.com>
Nikhil Shingne [Wed, 25 Oct 2023 06:13:31 +0000 (11:43 +0530)]
fixup! [M108 Migration][API] Bring up autofill
This commit enables the autofill feature which was disabled during
m114 bringup. Fixes all the build errors due to changes on upstream.
With this commit, autofill related TCs PASS on NativeTCT.
Change-Id: I26024557dc91654f8bd04fa8f8cdac04565cc95d
Signed-off-by: Nikhil Shingne <n.shingne@samsung.com>
Satyaveer Singh [Wed, 18 Oct 2023 12:19:37 +0000 (17:49 +0530)]
Fix native tct failures related to cookie manager
Due to changes on upstream code, now AllowFileSchemeCookies
should not be called on IO thread. This patch makes necessary changes.
With this, ewk cookie manager TCs are passing on NativeTCT.
Change-Id: I858b97098b829cd1a21db63cc96ca240adec3c36
Signed-off-by: Satyaveer Singh <satyaveer.s@samsung.com>
uzair [Wed, 20 Sep 2023 05:46:19 +0000 (11:16 +0530)]
Fix for runtime error during ubrowser launch
Change-Id: I3d427726a91a0b638b23ee1032f3b749651eb400
Signed-off-by: uzair <uzair.jaleel@samsung.com>
yh106.jung [Mon, 25 Sep 2023 01:42:32 +0000 (18:42 -0700)]
Initialize CommandLine before Mojo core initialization
In order to initialize Mojo core, CommandLine must be initialized first.
This patch calls content::InitializeMojoCore() after
CommandLineEfl::GetDefaultPortParams() to ensure CommandLine
initialization.
Change-Id: I059038909f18eceed1b348cb448e06017758cf6a
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
yh106.jung [Mon, 25 Sep 2023 01:38:20 +0000 (18:38 -0700)]
Always initialize eldbus
eldbus has been used not only in ATX but also in clipboard,
so this patch always initailize edbus.
Change-Id: If19a25f676bc57b61c32c5d18fb8b4a7df29f499
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
Ayush Kumar [Thu, 24 Aug 2023 05:57:54 +0000 (11:27 +0530)]
[M114] Onscreen Rendering support based on Ozone EFL
This commit fixes build errors to bringup content_shell on desktop.
Build: ./tizen_src/build/build_desktop.sh --build-chrome
Launch :
a. content shell : ./content_shell.sh
b. chrome : ./chrome.sh
Change-Id: Id77b8ea98d0ac633903c2cdee046cba1b8f135f3
Signed-off-by: Ayush Kumar <ayush.k123@samsung.com>
Ayush Kumar [Thu, 13 Jul 2023 06:31:53 +0000 (12:01 +0530)]
Revert "[M108 Migration] [SlimDownCode] Delete Redundant Modules"
This commit partially reverts
143b987df202b29f81a056cad7237efa20eea195
to add chromeos/* to resolve chrome build errors.
Change-Id: I0f16969d11e15e49721bf4676bd678e2703e020d
Signed-off-by: Ayush Kumar <ayush.k123@samsung.com>
Chandan Padhi [Thu, 17 Aug 2023 14:58:49 +0000 (20:28 +0530)]
[M114] Avoid adding same EFlWindow to the dispatcher list more than once
This commit ensures the following to fix the below CHECK failure.
1. EflWindow is added to the dispatcher list only once.
2. Previous EflEventHandler is deleted before creating a new one.
[0817/174640.034242:ERROR:observer_list.h(292)] Check failed: false.
Observers can only be added once!
Change-Id: Ibc8f06a5a76b774fd085ea7253fe44cb1dc9e1a9
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Surya Kumar [Tue, 8 Aug 2023 12:34:46 +0000 (18:04 +0530)]
Upgrade NodeJS binary to v16.13.0
Engine had upgraded nodejs to v16.13.0 for other builds.
This patch upgrades for tizen profile with appropriate
node binary
Change-Id: I6a5b2bbde8586adc2d82031d5bb7121b2a8b7918
Signed-off-by: Surya Kumar <surya.kumar7@samsung.com>
Chandan Padhi [Wed, 2 Aug 2023 15:12:01 +0000 (20:42 +0530)]
fixup! Upload upstream chromium 114.0.5735.31
icudtl.dat used currently is from M108 that results in renderer crash
due to below CHECK failure.
[0802/172502.073998:FATAL:url_idna_icu.cc(57)] Check failed: false.
failed to open UTS46 data with error: U_FILE_ACCESS_ERROR. If you see
this error message in a test environment your test environment likely
lacks the required data tables for libicu. See https://crbug.com/778929.
This commit updates icudtl.dat to that from M114 to fix above failure.
Change-Id: I084f46b5a564364ef28b10fbf458bf61fc8172d9
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>