Yunhee Seo [Tue, 9 Jan 2024 10:48:47 +0000 (19:48 +0900)]
feedback: Exclude codes from line coverage
Code that is not covered by test code is excluded.
If the code is only for internal API, it is also omitted.
Also, sound-parser.c will be removed and merged into feedback-config.c later.
feedback-config function is excluded because currently it is not used anywhere.
As such, functions that will undergo major structural changes have also been excluded.
Change-Id: I39581b5ce29b5af015e73487fcd2b1854e7d16c2
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Tue, 19 Dec 2023 08:43:41 +0000 (17:43 +0900)]
feedback: Add feedback_put_theme_ids_internal()
This function is added to feedback.
- int feedback_put_theme_ids_internal(unsigned int **theme_ids);
- This function free the array of theme ids from feedback_get_theme_ids_internal().
After use the array of theme id, it should be freed by caller.
Also, it is possible for the user to release the array directly.
Change-Id: I7d2f2a4456d9e6662c59e3360a1eb0a5490ed6b1
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Fri, 15 Dec 2023 05:00:40 +0000 (14:00 +0900)]
feedback: Add feedback_play_type_with_flags_internal()
To support sound play with priority, new api is added.
This function is added to feedback.
- int feedback_play_type_with_flags_internal(feedback_type_e type, feedback_pattern_internal_e internal_pattern,
feedback_flag_e flag);
- This function plays feedback pattern by pre-defined feedback_flag_e.
Sound play behavior varies depending on feedback_flag_e.
- FEEDBACK_FLAG_NONE
- This flag works the same as feedback_play_type_internal().
- FEEDBACK_FLAG_PRIORITY_BASED_PLAY
- This flag will only work in sound play. Sound pattern will be played with priority.
The sound pattern priority value will be used as defined in the sound conf file.
Change-Id: Idba5314030d393af82d155cd8e4a258a9e6ab82f
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Thu, 14 Dec 2023 04:53:16 +0000 (13:53 +0900)]
sound: Add sound pattern priority parsing
To support sound pattern play with priority, this patch is added.
[SoundPatternPriority] section is supported.
It is almost similar to the usage of [Sound] section.
[SoundPatternPriority] format
FEEDBACK_PATTERN_XXX=priority value(integer 0-N)
The detailed description is added to common/data/sound.conf file.
Change-Id: I526c0054ff9fd05100aa4585ae8c3dad59335fb6
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Wed, 13 Dec 2023 07:43:25 +0000 (16:43 +0900)]
feedback: Change feedback pattern data from list to GHashTable
Before applying this patch, feedback pattern data was handled as a list,
also the sound path of the feedback pattern was get through a linear search.
To handle the pattern data more efficiently, it has been changed to a GHashTable
with a feedback pattern enum key value and a char* sound path value.
Change-Id: Ibb80f05af247f19df9721ec78ee247807300c77f
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Thu, 7 Dec 2023 06:24:31 +0000 (15:24 +0900)]
sound: Remove sound_set_path()
From
b27c0d29aff919b34ec17a59411fff789aa6017e this commit, set_path became unreachable.
Before changing feedback pattern data structure, it is necessary to clean up unused function.
Change-Id: I7c902857db19107705a15bf9d4dbc4ce78a9cba9
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Thu, 7 Dec 2023 05:58:14 +0000 (14:58 +0900)]
feedback: Remove changed data from feedback_data
In the feedback_data structure, there is unreachable char* changed data.
From
b27c0d29aff919b34ec17a59411fff789aa6017e commit, set_path became unavailable.
As set_path became unreachable, changed data is also not used.
Since the changed data unnecessarily occupies as much memory as the number of patterns,
it should be deleted.
Change-Id: I17a266754a51f8c8061978a3b2d9c349de6c6abc
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Tue, 12 Dec 2023 07:47:43 +0000 (16:47 +0900)]
feedback: Add feedback pattern strength type for common profile
Certain feedback patterns must be played without system/media sound volume dependency.
To remove dependency, add specific pattern-volume type rule.
Change-Id: I703268cce7882f24902e6bbc7cbcdfcc1ad5677f
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Fri, 22 Dec 2023 06:42:17 +0000 (15:42 +0900)]
feedback: Change profile version from header files
As profiles are integrated, there is no need to mark versions separately.
Thus, the version has been changed based on mobile.
Change-Id: I16f2693313392f0d6ca617eba0efb359beb5b831
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Thu, 30 Nov 2023 01:36:34 +0000 (10:36 +0900)]
sound: Support sound conf file parsing existing rule
Previously, [Sound] section parsing was supported in sound.conf file.
However, as sound theme handling rule is changed to id-base, it was omitted.
If [Sound] section is used in sound.conf, default theme id will be set to 0.
Basically, it operates as follows.
1. When section [Sound] is found, sound-parser parses feedback pattern immediately.
- This is origin sound.conf parsing style.
2. When section [SoundTheme] is found, sound-parser supports multiple sound theme usage.
- This is new sound.conf parsing style as support multiple theme.
Thus, do not try to [Sound] and [SoundTheme] section at the same time in the sound.conf
Only one of the two styles may be selected and used.
Detailed description is added to common/data/sound.conf file.
Change-Id: I6f9274e91eb062898d45413f2b674663a7d4e30d
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Thu, 30 Nov 2023 01:06:49 +0000 (10:06 +0900)]
sound: Relocate macro related to parse
With the sound-parser separated out, there was no need to place macros on sound.c
It is correct to place conf file path in sound-parser that actually uses the path.
Furthermore, unnecessary function parameter pass has also been deleted.
Change-Id: Ib9e66f01261e51152a6a5d0b41231922ae2d1f1d
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Fri, 24 Nov 2023 08:23:08 +0000 (17:23 +0900)]
sound: Fix checking default theme duplication
Previously, the default theme was not checked properly as intended.
It is necessary to check default sound theme duplication.
Change-Id: I72db18631047e32c564615e6fcca7867adf0bc88
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Fri, 24 Nov 2023 03:51:13 +0000 (12:51 +0900)]
sound: Support maintaining theme id list in parsing order
Before, GHashTable did not guarantee conf file parsing order.
To guarantee conf file parsing order, sound theme id list has been changed
from GHashTable to GList.
Change-Id: Ib225e807d5d77dcf468b5999c36a2e7688ee58f8
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Thu, 23 Nov 2023 02:14:11 +0000 (11:14 +0900)]
sound: Resolve malloc/free mismatch issue
There was a part where free was omitted in the code.
Change-Id: I0b20af7ca585eb5c931a42d9434cc81063889cef
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Mon, 13 Nov 2023 07:59:14 +0000 (16:59 +0900)]
sound: Set sound theme default value as "no"
If the user does not set the "SoundThemeDefault" value in the conf file,
that SoundTheme section default value will be 0 automatically.
Change-Id: I3222330d6f203dfa3fd888b32dc598b9e6a40f46
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Wed, 8 Nov 2023 01:52:54 +0000 (10:52 +0900)]
feedback: Add feedback_get_theme_ids_internal()
Allows getting feedback theme id array supported.
This function is added to feedback.
- int feedback_get_theme_ids_internal(feedback_type_e feedback_type,
unsigned int *count_of_theme, unsigned int **theme_ids);
- This function gets count of theme available and theme id array.
Test codes have also been added to check normal operation.
Change-Id: I396452314d9b87907bbc52658f788b8987bf67af
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Tue, 7 Nov 2023 10:16:42 +0000 (19:16 +0900)]
feedback: Change feedback theme index handling to id-base
Previously, the feedback theme was dealt with based on index.
As handling policy is changed, feedback theme can be selected through id.
Feedback themes are no longer treated sequentially, also not dependent on index.
It is managed through a unique id.
Change-Id: I7556e7d877c106f9a311bed1558cddf0ff61dcc9
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Fri, 20 Oct 2023 04:08:37 +0000 (13:08 +0900)]
feedback: Add feedback theme index range description
The index of sound theme range is 1 ~ N according to conf file.
This index range should be considered when using feedback theme index getter/setter.
Change-Id: I250efd1885c2888c0395850f1e6f174a22e56254
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Thu, 12 Oct 2023 07:58:36 +0000 (16:58 +0900)]
feedback: Add new feedback patterns
Below feedback patterns are supported.
- FEEDBACK_PATTERN_WELCOME
- FEEDBACK_PATTERN_AUTO_DOOR_OPEN
Change-Id: I934d9bd1d193d7d5c347d93c0e91080773e3b267
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Tue, 19 Sep 2023 06:16:18 +0000 (15:16 +0900)]
feedback: Remove unnecessary branch
As support all_str_pattern for common/da profile, unnecessary branch is removed to keep
code quality.
Change-Id: Ib36af481b1e678afa44bcf9b5316a4f3e22fac59
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Tue, 19 Sep 2023 05:31:42 +0000 (14:31 +0900)]
tests: Fix wrong array size for test pattern array initialization
There are arrays which used for keeping enum id of supported/not supported patterns
in INIT_PATTERN_LIST() from tests.
However, arrays were being used inappropriately.
Therefore, arrays type and initialization size are fixed.
Change-Id: I1f8d3cb9a800414177572c9182f5a29843c12788
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Fri, 15 Sep 2023 06:27:28 +0000 (15:27 +0900)]
feedback: Support using all_str_pattern for common profile
All_str_pattern is supported to be used in common profile.
Change-Id: If081f2610c314e58ab4b7ef71bf49ce4060ee6c1
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Wed, 13 Sep 2023 01:39:30 +0000 (10:39 +0900)]
feedback: Add feedback_stop_type_internal()
To support feedback stop according to the feedback type.
With this, it is possible to stop sound feedback play.
"http://tizen.org/privilege/haptic" haptic privilege is required to stop the vibrator.
Change-Id: I4798f805be9f2a6bebc0d6f7da68011a98c3e4f1
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Wed, 13 Sep 2023 07:57:07 +0000 (16:57 +0900)]
feedback: Add new str pattern for all pattern
To support general feedback pattern, all_str_pattern array is added.
With "da" profile, it is possible to use general feedback pattern from all_str_pattern.
Change-Id: Iccb52f7285adf3f05f0d5088ebbde1f37a6dc612
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Thu, 14 Sep 2023 06:22:17 +0000 (15:22 +0900)]
feedback: Modify strncmp indexing comparison
Final null character comparison was missing from strncmp length.
To compare the end of the string, 1 index is added to strlen.
Change-Id: Ied9505ba95eef0b5a41826704d506ae34c9d201a
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Tue, 5 Sep 2023 11:43:45 +0000 (20:43 +0900)]
feedback: Add new feedback_pattern for "da" profile
To support new feedback_pattern from "da" profile,
new feedback_patterns are added to feedback_pattern_internal_e.
Also, "da" profile supports existing common profile feedback_pattern at the same time.
Thus, da_str_pattern has both profile feedback_pattern "da" and "common".
To use "da" profile feedback_pattern, "tizen.org/feature/profile" should be set to "da".
Change-Id: Ia7c544df4f9811a15617b7085fcd6a8c5d8f3a7b
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Fri, 1 Sep 2023 08:03:46 +0000 (17:03 +0900)]
feedback: Add lcov exception code to exclude vibration feature funcs
Add line coverage exception.
Vibration feature is not supported from the line coverage test environment.
Thus, function and codes releated to vibration feature are excluded from the line coverage.
Change-Id: Idf2374f1891f450b572007e611e6f231cb3c51fd
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Wed, 30 Aug 2023 10:17:17 +0000 (19:17 +0900)]
feedback: Add lcov exception code
Add line coverage exception to below cases.
1. Internal API and functions used only in internal functions.
2. Profile specific functions that are not common profile.(ex - mobile/wearable)
3. Error handling code section.
Change-Id: If2efe1239e0738adaad09db2a2b2e8c479549709
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Wed, 23 Aug 2023 02:06:15 +0000 (11:06 +0900)]
feedback: Remove read privilege checking
Allow apps to get theme index without read privilege dependencies.
Read privilege is removed from below functions.
- int feedback_get_count_of_theme_internal(feedback_type_e feedback_type, unsigned int *count_of_theme)
- int feedback_get_theme_index_internal(feedback_type_e feedback_type, unsigned int *index_of_theme)
Change-Id: I315dfcaf310f0948c7710ef366f73725505b490a
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Tue, 22 Aug 2023 07:25:43 +0000 (16:25 +0900)]
sound: Fix wrong variable from sound_set_theme_index()
The index of theme should be set by external parameter.
The wrong variable went into vconf setter as order changed.
Change-Id: I15b51552cf822cd26ac844a02609440561bec1f0
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Fri, 18 Aug 2023 04:14:26 +0000 (13:14 +0900)]
feedback: Fix typo tizen version
feedback_get/set_theme_index_internal(), feedback_get_count_of_theme_internal() functions are
supported from tizen_7.0.
Change-Id: I1f49bd8dbc21710617460ba89a32907b034f6ebe
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Fri, 18 Aug 2023 03:58:40 +0000 (12:58 +0900)]
feedback: Add checking privilege for multi-theme support funcs
Setting feedback theme index is required "http://tizen.org/privilege/systemsettings.admin" privilege.
Getting feedback theme is required "http://tizen.org/privilege/internal/default/public".
If application has above privilege, setting/getting theme index is successful.
Change-Id: I5aad3f3138e0fe0d0211832300929d78a4d7d47b
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Fri, 18 Aug 2023 02:45:42 +0000 (11:45 +0900)]
feedback: Add vconfkey notifier callback from multi-theme selection
Support vconfkey notifier to inform feedback current theme value is changed.
Change-Id: I2d8d7cb52e844ff498c4294ae1b955b01042ed4b
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Thu, 17 Aug 2023 05:55:16 +0000 (14:55 +0900)]
sound: Fix multi-theme start index with 0
In the previous multi-theme support implementation,
default index was different according to multi-theme or single theme.
However default sound theme index should start with 0 to maintain consistency.
User should use index "1~N", and that index will be converted to 0~N-1 in intenral implementation.
Start index will be 0 in terms of implementation.
Change-Id: I8549d2039c399e875ace7c06303bb4d1fd10febb
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Tue, 8 Aug 2023 01:43:03 +0000 (10:43 +0900)]
tests: Add test of sound multi-theme internal API
As support multi theme usage, new internal API test codes are added.
These are added to test-feedback-internal.h
- bool TEST_FEEDBACK_GET_COUNT_OF_SOUND_THEME_INTERNAL(void);
-> This function performs a test to get count of theme from the sound.conf.
- bool TEST_FEEDBACK_GET_SOUND_THEME_INDEX_INTERNAL(void);
-> This function performs a test to get index of sound theme selected.
- bool TEST_FEEDBACK_SET_SOUND_THEME_INDEX_INTERNAL(void);
-> This function performs a test to set index of sound theme, and then plays sound files from selected conf file.
It is possible to check sound file path from FEEDBACK_TEST dlog.
Change-Id: Ia2025141db8901676d5402f7ad0e836a9944fc3e
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Yunhee Seo [Tue, 1 Aug 2023 06:23:52 +0000 (15:23 +0900)]
sound: Support multi-theme sound conf usage
Allows users to select one of several theme files.
Conf file detailed usage is explained in the common/data/sound.conf file.
Example of conf file usage
[SoundMultiTheme] -> It means support multi theme
number_of_theme=2 -> It means how many confs are supported
name_of_default_theme=SoundTheme2 -> It means SoundTheme2 section file is set to default conf
[SoundTheme1] -> Match the conf file number and file path
file_path_of_theme=/usr/share/feedback/sound-theme1.conf
[SoundTheme2]
file_path_of_theme=/usr/share/feedback/sound-theme2.conf
To support this, below functions are newly added to feedback-internal.h.
- int feedback_get_count_of_theme_internal(feedback_type_e feedback_type, unsigned int *count_of_theme);
- This function gets the number of theme described in the config file.
- int feedback_get_theme_index_internal(feedback_type_e feedback_type, unsigned int *index_of_theme);
- This function gets the current index of theme selected.
- int feedback_set_theme_index_internal(feedback_type_e feedback_type, unsigned int index_of_theme);
- This function sets the index of theme will be used.
After that, It is possible to use the feedback files defined in the theme(index_of_theme) conf file.
In deed, this patch only supports sound theme.
Change-Id: Idd25bed7b091fffe6d9c7a5729a670f0f27469c4
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
Youngjae Cho [Fri, 10 Jun 2022 00:46:31 +0000 (09:46 +0900)]
Apply requirement for gcov automation
Change-Id: Ib3396c3e42ba2af9755550b029ec62ab0774a32d
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Wed, 26 Jan 2022 05:59:34 +0000 (21:59 -0800)]
Change gcov object install path
Change-Id: I5a9be1d968a48b4f817062003649831c2eda9e06
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
taemin.yeom [Fri, 19 Mar 2021 08:35:15 +0000 (17:35 +0900)]
Change dbus function name
Change-Id: I359eb66d69148df08933758deb591fe549797164
Signed-off-by: taemin.yeom <taemin.yeom@samsung.com>
taemin.yeom [Fri, 12 Mar 2021 07:45:56 +0000 (16:45 +0900)]
Improve variable naming style
Change-Id: I3b36f44a6acd0dae721959562d9086997ba9a99e
Signed-off-by: taemin.yeom <taemin.yeom@samsung.com>
taemin.yeom [Tue, 9 Mar 2021 01:26:18 +0000 (10:26 +0900)]
Apply libsyscommon gdbus api improvement on error handling
Change-Id: Ib602f152dcc49aecd903cc24f727d88a41c71400
Signed-off-by: taemin.yeom <taemin.yeom@samsung.com>
Yunmi Ha [Wed, 6 Jan 2021 07:45:03 +0000 (16:45 +0900)]
Change prefix of list definition
- list to SYS_G_LIST
Change-Id: Ia491cf8b4705e8c2f58dbd60f271af12b2c836f9
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 5 Jan 2021 09:14:13 +0000 (18:14 +0900)]
Use libsyscommon for list and ini-parser
Change-Id: Id71a4088c732d202b7837992b10986ec8e6bbda8
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Mon, 4 Jan 2021 06:57:25 +0000 (15:57 +0900)]
Add API test tool
Change-Id: Ief52bbe3fc9e21ba63b0474967180406463cd67f
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Mon, 4 Jan 2021 06:38:38 +0000 (15:38 +0900)]
Add excluding line for coverage test
Change-Id: Iad097870ae8fe1dc47f2441ba97976a1a28fc038
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Wed, 21 Oct 2020 11:25:30 +0000 (20:25 +0900)]
Use libsyscommon
To eliminate dbus proxy in feedback api, use libsyscommon instead.
Change-Id: I767494466cda183a33f91a5d7ad9a302ec2ebc49
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Wed, 24 Jun 2020 05:29:06 +0000 (14:29 +0900)]
Add comment for excluding coverage
Change-Id: Icffa61c0f6851e00a7b6b65f22c97b56073a842f
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 23 Jun 2020 09:12:56 +0000 (18:12 +0900)]
Add comment for excluding coverage
Change-Id: Id59d34e563352c4f0aa48d4adfd20a3dbb847231
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 23 Jun 2020 09:08:54 +0000 (18:08 +0900)]
Remove unused fuction
Change-Id: I83f019623515374400ec083665062c1ddc1b7a0f
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 9 Jun 2020 07:24:12 +0000 (16:24 +0900)]
Sync code with mcd product
- Add additional internal ids
- Add additional product ids
- Add some check code for additional vconf value
Change-Id: I8e5420bb6d48aa280c4247ce769ed4276789c216
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 2 Jun 2020 04:57:10 +0000 (13:57 +0900)]
Add DD_LIST_FOREACH_SAFE function
DD_LIST_FOREACH_SAFE function allows you to safely delete a list item
in a foreach statement.
Change-Id: Ic6bc0bf11e62161f9ff2769a66439197d6b81b39
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Thu, 21 May 2020 09:00:43 +0000 (18:00 +0900)]
Sync internal API behavior with product code
- Functionalization of duplicated code.
- Always alert when internal api is called.
Change-Id: I871d00c3812a85cb7e98ed48a4fd5183b673ef23
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 12 May 2020 07:24:50 +0000 (16:24 +0900)]
change vibration config to standard type
Change-Id: I8b55827a8b4ca7e2ceb431e31f345709d790e1a2
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Wed, 6 May 2020 06:52:56 +0000 (15:52 +0900)]
Add interanl API for supporting resource path
Noti app want to play feedback without any vconf changes.
But original API decides resource path for sound play with vconf value.
So add new API which has additional parameter of sound resource path.
Change-Id: I85bb37daacf14684c29e13cabfea6c7ee80e0008
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Thu, 19 Mar 2020 09:35:11 +0000 (18:35 +0900)]
Add sound_stop function
- When called this API, whole exist keytones will be stopped.
Change-Id: I5a11326e8b11f0e1e4532be615a0a84ed6fc6edd
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Mon, 17 Feb 2020 10:07:01 +0000 (19:07 +0900)]
Support multi effect pattern
- Remove rescaling code for level
- Add default pattern for monotone vibration
Change-Id: Ie7b01518bb6c3995c3a3db0193ec7d148bf21611
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
sanghyeok.oh [Wed, 8 Jan 2020 05:30:35 +0000 (14:30 +0900)]
dbus: replace old dbus api with GVariant support api
Change-Id: Id813b8518a2e44b4426efdeb153ed77243a1b80f
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Yunmi Ha [Thu, 6 Feb 2020 05:52:35 +0000 (14:52 +0900)]
sound: Add logic for checking NULL
- For fix svace issue
Change-Id: I1ed485fff3f01686c1120b30e3af85f0d463bced
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Thu, 12 Dec 2019 08:41:15 +0000 (17:41 +0900)]
Change "developer.tizen.org" link to "docs.tizen.org"
Change-Id: I947b9157401648c0da495d12b45358aa972681b9
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Thu, 21 Nov 2019 08:07:43 +0000 (17:07 +0900)]
Make gcov package
- Make gcov package when --define 'gcov ON' is given
Change-Id: I0eb415edaeedc959053fcb6bbd04e8d9f42af9f5
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 14 May 2019 07:20:27 +0000 (16:20 +0900)]
Add comment for excluding coverage - not used function
Change-Id: Ife9615f3709ecdcc3d2fa96ff4bc6a7d1bb104ea
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
pr.jung [Thu, 31 Jan 2019 08:17:11 +0000 (17:17 +0900)]
Change VibrateEffect to VibratePattern
Change-Id: Ibf38bb012c4dcb5bb03c18020cc48bad19c9f7dc
Signed-off-by: pr.jung <pr.jung@samsung.com>
Hyotaek Shim [Thu, 28 Feb 2019 07:40:29 +0000 (16:40 +0900)]
Add .gitignore
Change-Id: Iccb792e56da624293117ca64839756e74f4c3c15
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Thu, 28 Feb 2019 07:38:13 +0000 (16:38 +0900)]
Add a new ids range for IoT devices
Change-Id: Ie5bf43c158b87afc27b16e0a13fb6191e1dbcb59
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Fri, 15 Feb 2019 06:35:03 +0000 (15:35 +0900)]
Delete unused apis
- feedback_get_resource_path
- feedback_set_resource_path
Change-Id: I33b0290b29cec9a9c839068a190fbd0387c379e5
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Thu, 14 Feb 2019 01:47:46 +0000 (10:47 +0900)]
Check return value of vconf apis
Change-Id: Ie7428b1af81c41fcd8451268fd94a2bdc9e5f0b9
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Fri, 7 Dec 2018 06:32:14 +0000 (15:32 +0900)]
dlog: Fix dlog format error
Change-Id: I6af5ccbc830e3b854e050abac5cacbd1235c63de
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Mon, 9 Jul 2018 08:12:46 +0000 (17:12 +0900)]
Check return value for vconf_notify_key_changed and vconf_ignore_key_changed
Change-Id: I4523e53ce1c725acad5d52c20fbcbacbac4ae2c8
Signed-off-by: pr.jung <pr.jung@samsung.com>
sanghyeok.oh [Mon, 2 Jul 2018 09:04:11 +0000 (18:04 +0900)]
dbus: proxy: disable load properties flag
Change-Id: I2328c7cd6f7e73411cf07313ae66647a58b77ed0
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
pr.jung [Wed, 2 May 2018 10:11:22 +0000 (19:11 +0900)]
Add haptic feature
Change-Id: Ia4368aaf2dde249acda91105a0e4a71f5b750fe6
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Fri, 11 May 2018 07:49:44 +0000 (16:49 +0900)]
Patch for line coverage
Change-Id: I8152acfad4385fa91e074d90b2e58610e0b500c4
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Wed, 9 May 2018 06:03:55 +0000 (15:03 +0900)]
Exclude system error for line coverage
Change-Id: Ib1d1562119871c9a9b1c7d3321c0511a09f83c3c
Signed-off-by: pr.jung <pr.jung@samsung.com>
Hyotaek Shim [Tue, 10 Oct 2017 04:53:14 +0000 (13:53 +0900)]
Include "feedback-internal.h" in src/check.c
Change-Id: I8f316806e91e595f55bb4c562c8db6b607fc7fd5
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Thu, 21 Sep 2017 01:43:49 +0000 (10:43 +0900)]
Add description for pattern enum
Change-Id: Ic5d40617f8692aabf8c6f02e869c534f0e8f5e4f
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Mon, 18 Sep 2017 11:36:35 +0000 (20:36 +0900)]
Move some internal enums to public enums
- FEEDBACK_PATTERN_SYSTEM_SHORT = 107
- FEEDBACK_PATTERN_SYSTEM_ERROR = 108
- FEEDBACK_PATTERN_SYSTEM_LONG = 112
- FEEDBACK_PATTERN_SYSTEM_MID = 113
- FEEDBACK_PATTERN_END_EFFECT = 117
- FEEDBACK_PATTERN_GENERAL_STRONG_BUZZ = 135
Change-Id: Iefc9358cabc0426b2d4cdfac6ef39bcb3f6fd80a
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit
af71ca316e997dfb350ab0bfbc71a5cca883711b)
pr.jung [Fri, 15 Sep 2017 02:18:43 +0000 (11:18 +0900)]
Remove svi-data dependency
Change-Id: I5997e3bd50cf924b52216794a36f2ed61524de91
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Tue, 12 Sep 2017 02:43:07 +0000 (11:43 +0900)]
Remove build warning
Change-Id: Icf370d45837201fce71cc7ad420f98ba359dfc0d
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Tue, 12 Sep 2017 02:39:07 +0000 (11:39 +0900)]
Apply Tizen Coding Rule
Change-Id: Iee4d1648248874f17bcc5acdf3c484df11a1fa51
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Wed, 23 Aug 2017 07:04:45 +0000 (16:04 +0900)]
Remove unused custom directory
Change-Id: Idc15bee02abd9b002a3ecc97b32965c391ff7963
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Thu, 31 Aug 2017 02:48:41 +0000 (11:48 +0900)]
Include feedback-ids-internal.h on feedback-internal.h
Change-Id: Ic0b019a08cfafa3f853c9e61902d31b857e32b1b
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Wed, 30 Aug 2017 08:36:34 +0000 (17:36 +0900)]
Remove feedback-ids-internal.h from rootstrap
Change-Id: Ie174d19427f51ba18ea0eba7f1035a96af906f4a
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Tue, 1 Aug 2017 08:02:10 +0000 (17:02 +0900)]
Add feedback_play_internal and feedback_play_type_internal API
- Add an internal API
- Receive feedback_pattern_internal_e as parameter
Change-Id: Ic09612993d4130dfb3445c0d39c08e348a884935
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Fri, 28 Jul 2017 07:00:46 +0000 (16:00 +0900)]
Support feedback internal enums for each profile
- Public and internal pattern enums are not continuous
- libfeedback need to convert pattern id to pattern string and vice versa
Change-Id: I70398d3b488e9420e23a59114d47d91480d5deeb
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Fri, 21 Jul 2017 02:34:08 +0000 (11:34 +0900)]
svi-data rpm has dependency on svi-data-profile_xxx rpm
- svi-data-profile_common is set as default profile package.
Change-Id: Ia8fa900d5c794cd99cccb6e09dc36bfc77d10394
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Thu, 6 Jul 2017 02:11:19 +0000 (11:11 +0900)]
Seperate internal pattern enumerations for each profile
Change-Id: Ib49c8a0f3212434f5da6efaba29664fbf9ce2d41
Signed-off-by: pr.jung <pr.jung@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Tue, 27 Jun 2017 11:30:44 +0000 (20:30 +0900)]
Give different priority for feedback pattern
Change-Id: Ia951563e8469d4fceaf8a83cce3568e4a4f2dd3a
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Mon, 12 Jun 2017 08:30:00 +0000 (17:30 +0900)]
Should return access denied error for EACCES
Change-Id: Idd04a66e40015ea23f16472f3475bbd8f9042cc9
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Tue, 11 Apr 2017 05:53:52 +0000 (14:53 +0900)]
Use %license macro on spec file
Change-Id: I1067ae3d6574b560c865a82d2a444a1cf80d2122
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Fri, 24 Feb 2017 09:07:14 +0000 (18:07 +0900)]
Remove build dependencies on profile
- Remove build dependencies of check.c
- Check the profile on runtime
Change-Id: I256fffa813091a49877d18e936e77c62854e0fef
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Fri, 24 Feb 2017 09:05:39 +0000 (18:05 +0900)]
Remove build dependencies on profile
- Remove build dependencies of svi-data
Change-Id: I7d1b3fada53e0eeb3bdd19caa2f94c6aac0750ff
Signed-off-by: pr.jung <pr.jung@samsung.com>
Jung [Fri, 3 Feb 2017 06:39:43 +0000 (22:39 -0800)]
Revert "[4.0] Remove Profile Build Dependencies"
This reverts commit
4fad77614ae6916670b22a1e8dac0d49e87a5d4b.
Change-Id: Ia8f562a68638cf40640126f57addb6b88fa36379
MyungJoo Ham [Wed, 2 Nov 2016 07:00:39 +0000 (16:00 +0900)]
[4.0] Remove Profile Build Dependencies
1. This is for Tizen 4.0
2. When this commit is being SR'ed, the maintainer need to
create JIRA-TRE issue of:
Add libfeedback-profile_common for common profile if libfeedback exists
Add libfeedback-profile_mobile for mobile profile if libfeedback exists
Add libfeedback-profile_tv for tv profile if libfeedback exists
Add libfeedback-profile_wearable for wearable profile if libfeedback exists
Add libfeedback-profile_ivi for ivi profile if libfeedback exists
Add svi-data-profile_common for common profile if svi-data exists
Add svi-data-profile_mobile for mobile profile if svi-data exists
Add svi-data-profile_tv for tv profile if svi-data exists
Add svi-data-profile_wearable for wearable profile if svi-data exists
Add svi-data-profile_ivi for ivi profile if svi-data exists
Change-Id: Ib295d3b0e844ab8e4cce07107e46d22a26f24944
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
pr.jung [Mon, 9 Jan 2017 01:51:24 +0000 (10:51 +0900)]
Merge remote-tracking branch 'origin/tizen_3.0' into tizen
Change-Id: I6a448529a385574cd5e79328ba2a239516dd046a
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Fri, 6 Jan 2017 08:32:42 +0000 (17:32 +0900)]
Modify api document
Change-Id: I7558be0134bd6b8c098d9c69205691ed22455586
Signed-off-by: pr.jung <pr.jung@samsung.com>
taeyoung [Thu, 29 Dec 2016 01:39:16 +0000 (10:39 +0900)]
Merge branch 'tizen_3.0' into tizen
Signed-off-by: taeyoung <ty317.kim@samsung.com>
Change-Id: I34220898667bc10809cfe90496e5ea2b2b3b33ac
MyungJoo Ham [Wed, 2 Nov 2016 05:36:31 +0000 (14:36 +0900)]
Code Clean: spec / no need for -n
-devel is a postfix for %{name}.
We do not need -n option for postfixes preserving
the main package name (%{name}).
Removed unsed %post -n svi-data entry
Removed dependency on findutils that was probably used by
the deleted %post -n svi-data section.
Change-Id: I7b0a18adf60e2d00dcde24adfe1408a62174896e
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
taeyoung [Thu, 22 Dec 2016 07:16:40 +0000 (16:16 +0900)]
dbus: remove unnecessary codes
callback variable is not set yet.
Change-Id: I615098b24ca12eff4164848418fbddd116a54242
Signed-off-by: taeyoung <ty317.kim@samsung.com>
pr.jung [Wed, 23 Nov 2016 09:34:39 +0000 (18:34 +0900)]
Fix indexing for append_g_variant
Change-Id: Id3f5520c276fe03f9f4fb7902f69c59c8bf8d4bf
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Thu, 17 Nov 2016 09:57:57 +0000 (18:57 +0900)]
Receive signal when deviced-vibrator initiated
- When deviced-vibrator restarted, all vibration handle became invalid.
So after the restart, apps need to get new handle from deviced-vibrator.
- deviced-vibrator let apps knows their initiate condition.
Change-Id: Iebcbf4fafcafe8bb36de230d40feff7e8fb58b54
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Wed, 16 Nov 2016 09:06:52 +0000 (18:06 +0900)]
Apply Tizen Coding Rule
Change-Id: Ib1275f2841fc545d1374e4061a0dc0f89c2ec099
Signed-off-by: pr.jung <pr.jung@samsung.com>