platform/core/connectivity/bluetooth-frwk.git
5 years agoDeinitialize gatt server properly 11/207611/2
injun.yang [Tue, 5 Mar 2019 07:36:29 +0000 (16:36 +0900)]
Deinitialize gatt server properly

[Model] All
[BinType] AP
[Customer] OPEN

[Issue#] N/A
[Request] Internal
[Occurrence Version] N/A

[Problem] register gatt server -> bluetoothd terminated abnormally -> unregister gatt server ->
     bt-frwk recovery BT-> register gatt server -> crash
[Cause & Measure] After BT disabled, gatt server is not deinitialized properly.
[Checking Method] n/a

[Team] IoT Hub
[Developer] Injun Yang
[Solution company] Samsung
[Change Type] Specification change

Change-Id: I6f4356e12e05073656d56302d7e6c39883fc96f2
Signed-off-by: injun.yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoFix : LE scanning malfunction 10/207610/1
injun.yang [Mon, 4 Mar 2019 02:36:51 +0000 (11:36 +0900)]
Fix : LE scanning malfunction

[Model] All
[BinType] AP
[Customer] OPEN

[Issue#] N/A
[Request] Internal
[Occurrence Version] N/A

[Problem] APIs execute successfully without any errors, but LE scanning is not working
[Cause & Measure] Before scan stopping is completed, application request LE scan again.
 After receive LEDiscoveryFinished event, trigger LE scanning again.
[Checking Method] Call bt_adapter_le_start_scan() just after calling bt_adapter_le_stop_scan()

[Team] IoT Hub
[Developer] Injun Yang
[Solution company] Samsung
[Change Type] Specification change

Change-Id: I4927f5ba75451bc6f3fb87d758d2f141cc0c2b8d
Signed-off-by: injun.yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoReturn error code properly 09/207609/1
injun.yang [Mon, 11 Feb 2019 05:31:16 +0000 (14:31 +0900)]
Return error code properly

[Model] All
[BinType] AP
[Customer] OPEN

[Issue#] N/A
[Request] Internal
[Occurrence Version] N/A

[Problem] In disconnection staus, bt frwk return MTU size without error code
[Cause & Measure] When MTU size is invalid, return error code.
[Checking Method] Getting MTU size

[Team] IoT Hub
[Developer] Injun Yang
[Solution company] Samsung
[Change Type] Specification change

Change-Id: I23fa6a2a4bcb1f75c081a502062b7d5e7177111b
Signed-off-by: injun.yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoSupport for internal API to identify internal bonding 03/206903/4
Sudipto Bal [Mon, 3 Jun 2019 11:51:10 +0000 (17:21 +0530)]
Support for internal API to identify internal bonding

Change-Id: Ic22690a7422a0c2d74a766e0a8c47890ba83d99a
Signed-off-by: Sudipto Bal <sudipto.bal@samsung.com>
5 years agoreturn IN_PROGRESS error when pbap connection is on progress 36/206936/1
Deokhyun Kim [Wed, 29 May 2019 07:31:13 +0000 (16:31 +0900)]
return IN_PROGRESS error when pbap connection is on progress

Change-Id: Iaf91555a3d486e7f40997fc10a0c65bf76a6c1dc
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
5 years agoRemove wrong dependency in the systemd service file 88/206588/1 accepted/tizen/unified/20190522.085449 submit/tizen/20190522.020119
DoHyun Pyun [Wed, 22 May 2019 01:28:11 +0000 (10:28 +0900)]
Remove wrong dependency in the systemd service file

Change-Id: Ie995fb37a7da0629be2b0163e207352eaf98d4ae
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoFix TM1 service file to be executed after wifi-ready 93/206093/1 accepted/tizen/unified/20190516.053132 submit/tizen/20190515.040421
Wootak Jung [Tue, 14 May 2019 07:33:13 +0000 (16:33 +0900)]
Fix TM1 service file to be executed after wifi-ready

After=multi-user.target causes cyclic dependency because
this service is executed before multi-user.target phase.
Moreover, in TM1, bluetooth-frwk should be executed after
wifi-ready.
sleep is required to wait for completion of wifi-ready

Change-Id: I20a1b063f48523c19cefb829faa0bde0e52eadaf

5 years agoRevert "Remove After tag to remove cyclic dependency" 04/206004/1 accepted/tizen/unified/20190513.082629 submit/tizen/20190513.072851
DoHyun Pyun [Mon, 13 May 2019 07:10:39 +0000 (16:10 +0900)]
Revert "Remove After tag to remove cyclic dependency"

This reverts commit a1bcaa0ac47faa925156b1cb5a351c0e64e88974.

Change-Id: If21178d335658b12ad6a0950de6e21bd0095060f
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoRevert "Remove After= tag on bluetooth-frwk-core.service" 03/206003/1
DoHyun Pyun [Mon, 13 May 2019 07:09:46 +0000 (16:09 +0900)]
Revert "Remove After= tag on bluetooth-frwk-core.service"

This reverts commit 60e5e8bb77fe846f4b2ccc41615b5bf3ddf94fd8.

Change-Id: I7e3ec4fe645233e9e5890ad365e853ee789d8a7c
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoRemove After tag to remove cyclic dependency 29/204629/1 accepted/tizen/unified/20190429.103759 submit/tizen/20190429.002933
Wootak Jung [Thu, 25 Apr 2019 06:36:29 +0000 (15:36 +0900)]
Remove After tag to remove cyclic dependency

Change-Id: I331c56d236d80567c03564c443d0ed184b1ce2d2

5 years agoMerge "Remove After= tag on bluetooth-frwk-core.service" into tizen accepted/tizen/unified/20190404.021950 submit/tizen/20190403.033924
Pyun DoHyun [Tue, 2 Apr 2019 23:22:36 +0000 (23:22 +0000)]
Merge "Remove After= tag on bluetooth-frwk-core.service" into tizen

5 years agoRemove After= tag on bluetooth-frwk-core.service 27/202627/1
Wootak Jung [Tue, 2 Apr 2019 04:21:48 +0000 (13:21 +0900)]
Remove After= tag on bluetooth-frwk-core.service

bluetooth-frwk-core.service is located in multi-user.target.wants.
And multi-user.target phase is executed after multi-user.target.wants.
so, After=multi-user.taget causes cyclic dependency.

Change-Id: I12e7bb47954103be65a26ee6e3d5fa3e7ef9955f

5 years agoFixed AVRCP controller reply pending request 08/202608/1
Amit Purwar [Mon, 1 Apr 2019 11:38:36 +0000 (17:08 +0530)]
Fixed AVRCP controller reply pending request

Change-Id: I0d086f52f974ea40bb40a104bfa3e6c2e3dcccf5
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoEnable adapter and discoverable mode if headless device 83/202283/1 accepted/tizen/unified/20190327.160554 submit/tizen/20190327.015027
Wootak Jung [Thu, 31 May 2018 07:00:52 +0000 (16:00 +0900)]
Enable adapter and discoverable mode if headless device

Change-Id: I5e1ae7b674931c6d02ad15921382e3abd6857397

5 years agoRemoved A2DP sink disconnect event on A2DP connect fail 62/202162/1 accepted/tizen/unified/20190326.073456 submit/tizen/20190326.003144
Amit Purwar [Mon, 25 Mar 2019 09:50:42 +0000 (15:20 +0530)]
Removed A2DP sink disconnect event on A2DP connect fail

Change-Id: Ia6f95d03c3bb0f17c7b8a7539ff41e4feed93a23
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoFix the ASAN build error 37/201437/2 accepted/tizen/unified/20190318.150550 submit/tizen/20190315.000134
DoHyun Pyun [Thu, 14 Mar 2019 06:11:12 +0000 (15:11 +0900)]
Fix the ASAN build error

Change-Id: I55fb907d0be93419bcf32b35f84b7b71be16b7cd
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoModify the privilege level of OOB data getter APIs 33/200333/1 accepted/tizen/unified/20190312.113015 submit/tizen/20190311.071331
DoHyun Pyun [Thu, 21 Feb 2019 23:24:08 +0000 (08:24 +0900)]
Modify the privilege level of OOB data getter APIs

Application try to bond using oob data without user confirmation.
Because of this, need to give the proper privilege for OOB data
getter APIs

Change-Id: I5fd0083705ac594cbcd307026bf805384318db76
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoDeinitialize gatt server properly 65/199965/1 accepted/tizen/unified/20190219.154249 submit/tizen/20190218.033542
injun.yang [Thu, 3 Jan 2019 03:42:56 +0000 (12:42 +0900)]
Deinitialize gatt server properly

[Problem] register gatt server -> BT off -> unregister gatt server ->
 BT on -> register gatt server -> crash
[Cause & Measure] After BT disabled, gatt server is not deinitialized properly.

Change-Id: Iadc0fb7764a9d87f8e22824233e404a248f130e7

5 years agoMerge "Fixed the descriptor write send response" into tizen accepted/tizen/unified/20190214.060730 submit/tizen/20190214.004027
Pyun DoHyun [Thu, 14 Feb 2019 00:38:37 +0000 (00:38 +0000)]
Merge "Fixed the descriptor write send response" into tizen

5 years agoFixed the descriptor write send response 94/199594/1
Amit Purwar [Wed, 13 Feb 2019 07:14:02 +0000 (12:44 +0530)]
Fixed the descriptor write send response

Change-Id: I803b2c389872294e475caab40bb1d15b6aaf2cb8
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoFix own_prefix tag duplication issue 99/199499/1
Wootak Jung [Tue, 12 Feb 2019 07:21:10 +0000 (16:21 +0900)]
Fix own_prefix tag duplication issue

In case of org.frwk.gatt_service, owner is different depend on
 gatt relay feature. So, I provide a new conf file for where
 gatt relay feature is not in used.

Change-Id: I3a9bb38afe6d49afd701351a9f19213246eee341

5 years agoMerge "Fixed the unicast address for send indication" into tizen accepted/tizen/unified/20190212.084048 submit/tizen/20190211.065813 submit/tizen/20190211.100729
Pyun DoHyun [Mon, 11 Feb 2019 06:57:05 +0000 (06:57 +0000)]
Merge "Fixed the unicast address for send indication" into tizen

5 years agoMerge "Fixed NotifyAcquired property for gatt indication" into tizen
Pyun DoHyun [Mon, 11 Feb 2019 06:57:00 +0000 (06:57 +0000)]
Merge "Fixed NotifyAcquired property for gatt indication" into tizen

5 years agoMerge "Fixed the WriteAcquired property for char write" into tizen
Pyun DoHyun [Mon, 11 Feb 2019 06:56:57 +0000 (06:56 +0000)]
Merge "Fixed the WriteAcquired property for char write" into tizen

5 years agoFixed the unicast address for send indication 92/199392/1
Amit Purwar [Mon, 11 Feb 2019 06:42:05 +0000 (12:12 +0530)]
Fixed the unicast address for send indication

Change-Id: I1308b4d80080b5f98920d7a45c5e959a5cc316b5
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoMerge "Fix for unlimited attepmts to write to socket" into tizen
Pyun DoHyun [Thu, 7 Feb 2019 23:33:52 +0000 (23:33 +0000)]
Merge "Fix for unlimited attepmts to write to socket" into tizen

5 years agoFix for unlimited attepmts to write to socket 30/199130/2
Sudipto [Fri, 1 Feb 2019 11:14:43 +0000 (16:44 +0530)]
Fix for unlimited attepmts to write to socket

Change-Id: Id90bebe5d40f1ac599d996e3e2da66217391a9eb
Signed-off-by: Sudipto <sudipto.bal@samsung.com>
5 years agoFix dbus connection to shared from private 10/199210/1 accepted/tizen/unified/20190208.061633 submit/tizen/20190207.084653
Wootak Jung [Thu, 7 Feb 2019 07:47:03 +0000 (16:47 +0900)]
Fix dbus connection to shared from private

Shared connection should be used because rfcomm interface was registered
 on shared connection not private. Otherwise, dbus rejection is occured
 because dbus policy is only applied on shared connection not private.

Change-Id: I49ca31b06deeec8c9092fd99342d22d0b9290229

5 years agoFixed NotifyAcquired property for gatt indication 64/199164/2
Amit Purwar [Wed, 6 Feb 2019 11:34:39 +0000 (17:04 +0530)]
Fixed NotifyAcquired property for gatt indication

Change-Id: I995f79d0964acf6f8c2c0caa62361c58b046eb54
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoFixed the WriteAcquired property for char write 07/199107/1
Amit Purwar [Mon, 4 Feb 2019 06:32:06 +0000 (12:02 +0530)]
Fixed the WriteAcquired property for char write

Change-Id: Ic49087d5c6a6efc45c102a4d5224e8e5eef3eb31
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoAdd -Wall -Werror build option for bluez hal 11/199011/1
DoHyun Pyun [Fri, 1 Feb 2019 00:26:24 +0000 (09:26 +0900)]
Add -Wall -Werror build option for bluez hal

Change-Id: Ieb22a7a158a47fb45a468832f2fd3e878cc251c2
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoFix the warning errors 10/199010/1
DoHyun Pyun [Fri, 1 Feb 2019 00:26:01 +0000 (09:26 +0900)]
Fix the warning errors

Change-Id: Ib1bb16613a744e730a724de0556fbe69e3a72468
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoMerge "cleanup of acquire notification data for stop notify" into tizen accepted/tizen/unified/20190201.061316 submit/tizen/20190131.063750
Pyun DoHyun [Thu, 31 Jan 2019 06:37:24 +0000 (06:37 +0000)]
Merge "cleanup of acquire notification data for stop notify" into tizen

5 years agoMerge "Handle ACL Disconnect Reason" into tizen
Pyun DoHyun [Wed, 30 Jan 2019 23:34:55 +0000 (23:34 +0000)]
Merge "Handle ACL Disconnect Reason" into tizen

5 years agocleanup of acquire notification data for stop notify 45/198845/1
Amit Purwar [Wed, 30 Jan 2019 09:00:31 +0000 (14:30 +0530)]
cleanup of acquire notification data for stop notify

Change-Id: I75cb3a0edbd159789695cc8c16ae659cc246c5bf
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoHandle ACL Disconnect Reason 27/198827/1
Anupam Roy [Wed, 30 Jan 2019 06:24:58 +0000 (11:54 +0530)]
Handle ACL Disconnect Reason

Following events are Bluez HAL specific
 - Disconnect due to Remote Host
 - Disconnect due to Local Host

Change-Id: I8199847a3cad9040ec1b91ce13f89c773748e8b2
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
5 years agoReduce the indentation and complexity for AVRCP function 16/198816/1
DoHyun Pyun [Wed, 30 Jan 2019 04:07:51 +0000 (13:07 +0900)]
Reduce the indentation and complexity for AVRCP function

Change-Id: I8bc516ced5d8e1632772df1d715b52a6423b51eb
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoSupport in AVRCPT controller commands for multiple controllers 15/198515/2
Avichal [Fri, 25 Jan 2019 05:45:31 +0000 (14:45 +0900)]
Support in AVRCPT controller commands for multiple controllers

Change-Id: I8e913da0bfa6e118c640603d588a9e88b1e08297
Signed-off-by: Avichal <avichal.a@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoMerge "A2DP profile multiple source support" into tizen
Pyun DoHyun [Wed, 30 Jan 2019 01:05:46 +0000 (01:05 +0000)]
Merge "A2DP profile multiple source support" into tizen

5 years agoMerge "Fixed disable notification for acquire notification" into tizen accepted/tizen/unified/20190129.064355 submit/tizen/20190129.000858
Pyun DoHyun [Tue, 29 Jan 2019 00:07:54 +0000 (00:07 +0000)]
Merge "Fixed disable notification for acquire notification" into tizen

5 years agoMerge "fixed gatt server notification event for acquire notify" into tizen
Pyun DoHyun [Tue, 29 Jan 2019 00:07:50 +0000 (00:07 +0000)]
Merge "fixed gatt server notification event for acquire notify" into tizen

5 years agoFixed disable notification for acquire notification 10/198610/3
Amit Purwar [Mon, 28 Jan 2019 05:19:15 +0000 (10:49 +0530)]
Fixed disable notification for acquire notification

Change-Id: I8b870f29ec3c71d6a0b75e915307b76e57d33ad7
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoA2DP profile multiple source support 59/196359/5
Avichal [Thu, 27 Dec 2018 14:23:58 +0000 (19:53 +0530)]
A2DP profile multiple source support

Added Support multiple a2dp and avrctp connections.

Change-Id: I50d4ba897042648afc35a59d91e8e61c3b2ac91e
Signed-off-by: Avichal <avichal.a@samsung.com>
5 years agoFix dbus policies 18/198518/2
Wootak Jung [Fri, 25 Jan 2019 06:01:07 +0000 (15:01 +0900)]
Fix dbus policies

If unknown process owns these well-known name, unexpected deny can be occured.
So, subdivide deny policy.

Change-Id: I8e6cc73d80d60d348e2b510cabc77c73a6cb32ca

5 years agofixed gatt server notification event for acquire notify 51/198451/1
Amit Purwar [Thu, 24 Jan 2019 13:22:41 +0000 (18:52 +0530)]
fixed gatt server notification event for acquire notify

Change-Id: I2b99788b188b3df5f4e64c2966fb1a64bf7ab0ca
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoRemove unnecessary connection getting functions 61/198261/2 submit/tizen/20190124.075029 submit/tizen/20190128.005753
Wootak Jung [Wed, 23 Jan 2019 04:57:50 +0000 (13:57 +0900)]
Remove unnecessary connection getting functions

Remove duplicated function _bt_gdbus_init_system_gconn()
Remove duplicated function __get_gdbus_connection()
Rename _bt_gdbus_get_system_gconn() to _bt_get_system_private_conn()
Rename _bt_init_system_gdbus_conn() to _bt_get_system_shared_conn()
Add 'static' keyword for static functions

Change-Id: I85571703b1c9a74365c83dc9d701cb418963ae59

5 years agoReturn errors without retry if bond info. already exists or it's in progress 94/198194/1 accepted/tizen/unified/20190128.061620 submit/tizen/20190123.050251
Deokhyun Kim [Tue, 22 Jan 2019 07:38:49 +0000 (16:38 +0900)]
Return errors without retry if bond info. already exists or it's in progress

  If create_bond is called in case GATT is connected and it's already bonded,
  then bond info. is removed and GATT is disconnected unexpectedly.

Change-Id: I078da398322f68522e427c7b7f18a8fd8e229f91
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
5 years agoApply send_destination_prefix policy#3 78/198178/1 submit/tizen_5.0/20190118.024626
Wootak Jung [Tue, 22 Jan 2019 05:29:20 +0000 (14:29 +0900)]
Apply send_destination_prefix policy#3

Change rfcomm connection from private to shared

Change-Id: I59924564c134a7d4f7ea13a4c25ffd41345792d8

5 years agoMerge "Enable FD based GATT client data transfer" into tizen
Pyun DoHyun [Tue, 22 Jan 2019 04:17:49 +0000 (04:17 +0000)]
Merge "Enable FD based GATT client data transfer" into tizen

5 years agoApply send_destination_prefix policy#2 28/198128/4
Wootak Jung [Mon, 21 Jan 2019 07:39:49 +0000 (16:39 +0900)]
Apply send_destination_prefix policy#2

gdbus closing logic is not needed anymore

Change-Id: If529a348bee88dfe413fd936fcf07296eb6ae8d0

5 years agoEnable FD based GATT client data transfer 62/198162/1
DoHyun Pyun [Tue, 22 Jan 2019 00:23:18 +0000 (09:23 +0900)]
Enable FD based GATT client data transfer

Change-Id: I35837791ee06c598d53dcc984f46b787dfb41f55
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoApply send_destination_prefix policy#1 06/198106/3
Wootak Jung [Mon, 21 Jan 2019 02:13:06 +0000 (11:13 +0900)]
Apply send_destination_prefix policy#1

default deny/allow options are needed for policy checker

Change-Id: I1feac171c04fc7ec8f63a68a9499149d8c5a9528

5 years agoFix the bug for the OPP server progress callback's file name 59/197659/1 accepted/tizen/unified/20190116.060558 submit/tizen/20190115.054612
DoHyun Pyun [Tue, 15 Jan 2019 05:02:46 +0000 (14:02 +0900)]
Fix the bug for the OPP server progress callback's file name

Change-Id: I3113a1e669304c559580ae0962b67f2ae67f4991
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoAdd new method to disconnect device 86/197186/1 accepted/tizen/unified/20190115.055940 submit/tizen/20190111.043317 submit/tizen/20190114.060943
Deokhyun Kim [Thu, 10 Jan 2019 07:20:01 +0000 (16:20 +0900)]
Add new method to disconnect device

Change-Id: Ia0dd37ce4cd13b2666c3e8f6f112ed0b8321d4b6
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
5 years agoFix svace issue(40981) 63/197163/1
Deokhyun Kim [Thu, 10 Jan 2019 05:04:31 +0000 (14:04 +0900)]
Fix svace issue(40981)

Change-Id: I2fa8b274e275a8aa949c274016b2ba8cfa6c7acb
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
5 years agoMerge "Improve efficiency of using g_array_index" into tizen
Pyun DoHyun [Wed, 2 Jan 2019 07:05:55 +0000 (07:05 +0000)]
Merge "Improve efficiency of using g_array_index" into tizen

5 years agoEnable the connection request event for custom obex server 21/196521/1 accepted/tizen/unified/20190103.061728 submit/tizen/20190102.044100
DoHyun Pyun [Wed, 2 Jan 2019 04:04:55 +0000 (13:04 +0900)]
Enable the connection request event for custom obex server

Change-Id: Id4a07fa2018cfd5eba778e0655bf6292b560cbbb
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoImprove efficiency of using g_array_index 03/196503/1
Deokhyun Kim [Wed, 2 Jan 2019 02:02:30 +0000 (11:02 +0900)]
Improve efficiency of using g_array_index

Change-Id: Ia2c56e65d5900f67d0089290663cfb0c95bb6a85
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
5 years agoCorrect the privilege check logic for MTU size APIs 19/196219/1
Seungyoun Ju [Wed, 26 Dec 2018 09:20:07 +0000 (18:20 +0900)]
Correct the privilege check logic for MTU size APIs

Change-Id: I509d0967b16b9ca17a978ecffc914184b744557d

5 years agogatt-service : Fix some minor bugs 18/196218/1
Seungyoun Ju [Wed, 26 Dec 2018 09:11:17 +0000 (18:11 +0900)]
gatt-service : Fix some minor bugs

[Problem] init -> register service -> deinit -> init -> register service
-> start server : service is not added.
There are some warning about reference to invalid GOBJECT.
[Cause & Measure] Remove pending count. Unref GOBJECT after check of
validation.

Change-Id: I4829505ebac3e3c0668aa2a386de3085163d0b8d

5 years agoFix invalid read 17/196217/1
Seungyoun Ju [Fri, 14 Dec 2018 06:32:25 +0000 (15:32 +0900)]
Fix invalid read

[Problem] There is invalid read report from valgrind
[Cause & Measure] The node was accessed after it was freed. This patch
 frees current node after moving to the next node so that invalid read
 issue has been resolved.

Change-Id: I15eae8c16c8f215aee30fd33ac8f3aadea73b4eb

5 years agoImprove inefficiency 70/195870/2
Deokhyun Kim [Wed, 19 Dec 2018 05:02:48 +0000 (14:02 +0900)]
Improve inefficiency

Change-Id: Icd2b33c68d384680e24eec64de9256efb60c1084
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
5 years agoFix dlog format error 81/195681/2 accepted/tizen/unified/20181218.063056 submit/tizen/20181217.091427
DoHyun Pyun [Mon, 17 Dec 2018 08:04:48 +0000 (17:04 +0900)]
Fix dlog format error

Change-Id: I1c1fcaf6f78e4a0946c86adbdc456b6439f5e395
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoCorrect the privilege check logic for MTU size APIs 64/195364/1
DoHyun Pyun [Thu, 13 Dec 2018 01:43:58 +0000 (10:43 +0900)]
Correct the privilege check logic for MTU size APIs

Change-Id: I14b3e825cfb04691efed9c3fea847d7dfe59d82b
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoModify dbus policies 21/194121/2 accepted/tizen/unified/20181210.152220 submit/tizen/20181210.003120
Wootak Jung [Thu, 29 Nov 2018 07:30:43 +0000 (16:30 +0900)]
Modify dbus policies

- Remove org.projectx.bt_event policy
- Apply default deny for org.projectx.bluetooth.share
- Add send_member for org.tizen.csd.Call.Instance

Change-Id: Ia50f24d807b0f180bcd74f02886f28cc57474d5e

5 years agoModify gdbus proxy flag to G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES 73/193473/2
Wootak Jung [Wed, 21 Nov 2018 05:52:02 +0000 (14:52 +0900)]
Modify gdbus proxy flag to G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES

G_DBUS_PROXY_FLAGS_NONE causes some unnecessary error log

Change-Id: I8be66086d58431bb9894f30d7cbddc4f3ac76a63

5 years agoMerge "Match the correct privilege for RFCOMM listen and accept API" into tizen
Pyun DoHyun [Wed, 5 Dec 2018 00:34:07 +0000 (00:34 +0000)]
Merge "Match the correct privilege for RFCOMM listen and accept API" into tizen

5 years agoMatch the correct privilege for RFCOMM listen and accept API 00/194300/1
DoHyun Pyun [Mon, 3 Dec 2018 01:59:58 +0000 (10:59 +0900)]
Match the correct privilege for RFCOMM listen and accept API

Change-Id: I1a19d3222ec033a55a16f20e8d906a61c6f0b6b7
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoCheck le_adv_slot before access 61/193761/1
Deokhyun Kim [Mon, 26 Nov 2018 06:43:20 +0000 (15:43 +0900)]
Check le_adv_slot before access

 - bt-service crashes by invalid memory access when _bt_is_advertising is called
  before adv info is initialized.

Change-Id: I75b4efb9c4ccb209860453e467f9847669cc7624
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
6 years agoRemove g_bus_own_name() logic in bt-telephony 00/192700/1
Wootak Jung [Thu, 8 Nov 2018 05:12:09 +0000 (14:12 +0900)]
Remove g_bus_own_name() logic in bt-telephony

It is not good to call g_bus_own_name() in api layer, it causes
service name of sender is changed to org.tizen.csd.Call.Instance.

This interface has been used on bluetooth-agent and it can call
method on this interface by using sender_name instead of service_name.

Change-Id: I6f77e23ee15b9b1f9e4a4ce53f4993e852006bce

6 years agoMigrate insmod logic into bt-stack-up.service 91/192391/1 accepted/tizen/unified/20181109.062817 submit/tizen/20181106.081159 submit/tizen/20181108.005303 submit/tizen/20181108.070422
Wootak Jung [Mon, 5 Nov 2018 08:03:19 +0000 (17:03 +0900)]
Migrate insmod logic into bt-stack-up.service

insmod logic should be executed before bt-stack-up.sh logic. But,
insmod logic has been executed after bt-stack-up.sh logic on ARTIK530.
This patch migrates insmod logic into bt-stack-up.sh and creates bt-stack-up.service
This patch should be merged with bluetooth-tools.

Change-Id: I15e3ab996379600173e441effb9d52577ae3203b

6 years agoMerge "Revert "Fix incorrect interface name and improve dbus policy"" into tizen accepted/tizen/unified/20181107.081858 submit/tizen/20181026.055809 submit/tizen/20181105.232950
Pyun DoHyun [Fri, 26 Oct 2018 05:57:33 +0000 (05:57 +0000)]
Merge "Revert "Fix incorrect interface name and improve dbus policy"" into tizen

6 years agoRevert "Fix incorrect interface name and improve dbus policy" 63/191963/1
Wootak Jung [Fri, 26 Oct 2018 05:46:56 +0000 (05:46 +0000)]
Revert "Fix incorrect interface name and improve dbus policy"

This reverts commit fb6c7048cb2a150aebcef0e2821c369e46c5a9ad.

Change-Id: Ia78dd8b41f341441d4c3cbb15bd1450e24dbaf22

6 years agoFix profile check logic to distinguish ivi and iot 99/191899/2
Wootak Jung [Thu, 25 Oct 2018 06:10:58 +0000 (15:10 +0900)]
Fix profile check logic to distinguish ivi and iot

Change-Id: Iaa8e0786787bfba81987d6fdb29d2a95dd867ab9

6 years agoInvoke callback function after all internal work is done 26/191626/1
Deokhyun Kim [Fri, 19 Oct 2018 05:59:42 +0000 (14:59 +0900)]
Invoke callback function after all internal work is done

 - Prevent to access freed service after GATT is destroyed in callback function

Change-Id: I8aa33c48cdcf246578552a58aaa2cad7a94a589c
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
6 years agoRevert "Remove and modify for some dbus policies" 68/191368/1 accepted/tizen_5.0_unified accepted/tizen/5.0/unified/20181102.014759 accepted/tizen/unified/20181018.000410 submit/tizen/20181016.090705 submit/tizen_5.0/20181101.000003
DoHyun Pyun [Tue, 16 Oct 2018 09:05:26 +0000 (18:05 +0900)]
Revert "Remove and modify for some dbus policies"

This reverts commit b493a680894d58efc1879d90be656c6fcdda9c50.

Change-Id: I98e87554fde528a824189a5f3051eb0417b985f4
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoRemove and modify for some dbus policies 45/190745/1 accepted/tizen/unified/20181011.095202 submit/tizen/20181009.235550
Wootak Jung [Fri, 5 Oct 2018 05:06:04 +0000 (14:06 +0900)]
Remove and modify for some dbus policies

- org.projectx.bt_event
 no need policy for using signal
- org.projectx.bluetooth.share
 bluetooth-share owns this service
- org.tizen.csd.Call.Instance
 user owns this service and called by network_fw

Change-Id: I3727e144ffcae9ad9ff12748c7ac5b51c08e0486

6 years agoMerge "Fix incorrect interface name and improve dbus policy" into tizen
Pyun DoHyun [Thu, 4 Oct 2018 02:49:18 +0000 (02:49 +0000)]
Merge "Fix incorrect interface name and improve dbus policy" into tizen

6 years agoDisable GATT Client fd based function 58/190558/1 accepted/tizen/unified/20181005.012503 submit/tizen/20181004.010949
DoHyun Pyun [Thu, 4 Oct 2018 00:58:07 +0000 (09:58 +0900)]
Disable GATT Client fd based function

After applying the security patchset, we will enable this feature.
To pass the web manaul TC, we disable this feature in now.

Change-Id: I35cb8e79bf0aba5a4b27171db1c0f22346e32f44
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoFix incorrect interface name and improve dbus policy 03/190303/1
Wootak Jung [Mon, 1 Oct 2018 01:52:37 +0000 (10:52 +0900)]
Fix incorrect interface name and improve dbus policy

Dbus -> DBus
Objectmanager -> ObjectManager

Change-Id: I97a05856ff7b8357aeb92d595d5d4aacfc786bee

6 years agoFixed the return status for indicate property 27/190227/1 submit/tizen/20180930.234221
Amit Purwar [Fri, 28 Sep 2018 09:18:53 +0000 (14:48 +0530)]
Fixed the return status for indicate property

Return status for indicate property of characteristic
is fixed in set characteristic changed value cb for
TFIVE-14433 TFIVE-14439 issue

Change-Id: Ia3ef28961ef71fb81e7d74bce457e54a99ba3cb5
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
6 years agoModify to path activation for hciconfig command 33/189833/2 accepted/tizen/unified/20180928.080457 submit/tizen/20180927.020120
Wootak Jung [Fri, 21 Sep 2018 04:52:20 +0000 (13:52 +0900)]
Modify to path activation for hciconfig command

Change-Id: Ia091b30464fc2cf1fef96d65c95ff3b0ea296312

6 years agoFix memory double free(crash) issue 35/189735/1 accepted/tizen/unified/20180921.042519 submit/tizen/20180920.060650
Wootak Jung [Thu, 20 Sep 2018 05:41:47 +0000 (14:41 +0900)]
Fix memory double free(crash) issue

g_variant_get_string returns the constant string whereas
g_variant_get_dup_string returns a newly allocated string.
It should not be freed.

    at /usr/src/debug/bluetooth-frwk-0.3.0/bt-oal/bluez_hal/src/bt-hal-adapter-dbus-handler.c:525

Change-Id: I3d8f6bc0eec3d7736a263edbb47c3f3deaee4cef

6 years agoAdded the GATT server disconnect 05/185005/7 accepted/tizen/unified/20180919.141920 submit/tizen/20180919.001852
Amit Purwar [Wed, 25 Jul 2018 06:06:49 +0000 (11:36 +0530)]
Added the GATT server disconnect

Change-Id: I2c38505d92d8610801670cd063d31fbf7f8df4b4
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
6 years agoMerge "Prevent Issue fixes" into tizen
Pyun DoHyun [Wed, 19 Sep 2018 00:18:05 +0000 (00:18 +0000)]
Merge "Prevent Issue fixes" into tizen

6 years agoPrevent Issue fixes 27/189527/2
Abhishek Chandra [Tue, 18 Sep 2018 09:43:57 +0000 (15:13 +0530)]
Prevent Issue fixes

Prevent Issue fixes :
- 1026071
- 1026065
- 1026059
- 1026057
- 1026047
- 1026042
- 1026038

Change-Id: I4517e99e89e5ad5a1fefe07fc2263c27587e61ab
Signed-off-by: Abhishek Chandra <abhishek.ch@samsung.com>
6 years agoremoved gatt service info from list during gatt cleanup 85/189385/1
Amit Purwar [Mon, 17 Sep 2018 09:35:50 +0000 (15:05 +0530)]
removed gatt service info from list during gatt cleanup

Change-Id: I1dbe49424fcf20047c2d86ec6e234929e05f6de2
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
6 years agoAdd "Not Supported" check logic for haltests 08/189308/1 accepted/tizen/unified/20180918.062755 accepted/tizen/unified/20180918.062946 submit/tizen/20180917.041805 submit/tizen/20180917.223052
DoHyun Pyun [Mon, 17 Sep 2018 04:08:51 +0000 (13:08 +0900)]
Add "Not Supported" check logic for haltests

Change-Id: I45b5d88291dbf7b895229b79f7db6479edf72e3d
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoModify bt-oal initialize code readably 89/189089/1
Wootak Jung [Thu, 13 Sep 2018 08:54:44 +0000 (17:54 +0900)]
Modify bt-oal initialize code readably

Change-Id: Ic35ea6d65139f41f63caccd185474ad598f0d2d4

6 years agoRemove duplicated check logic and incorrect return type 32/189032/1
Wootak Jung [Thu, 13 Sep 2018 02:15:14 +0000 (11:15 +0900)]
Remove duplicated check logic and incorrect return type

Change-Id: I5be38b4424e2f8418d06af82c63b4de90b062651

6 years agoMerge "Fix the coding style errors" into tizen accepted/tizen/unified/20180913.064014 accepted/tizen/unified/20180914.073138 submit/tizen/20180912.234844 submit/tizen/20180913.053639
DoHyun Pyun [Wed, 12 Sep 2018 23:48:03 +0000 (23:48 +0000)]
Merge "Fix the coding style errors" into tizen

6 years agoMerge "Fix the build error in aarch64" into tizen
DoHyun Pyun [Wed, 12 Sep 2018 23:47:55 +0000 (23:47 +0000)]
Merge "Fix the build error in aarch64" into tizen

6 years agoMerge "TFIVE-12959: fixed scan response and adv data length" into tizen
Pyun DoHyun [Wed, 12 Sep 2018 23:38:48 +0000 (23:38 +0000)]
Merge "TFIVE-12959: fixed scan response and adv data length" into tizen

6 years agoMerge "TFIVE-12640: fixed the size of handle string" into tizen
Anupam Roy [Wed, 12 Sep 2018 11:10:57 +0000 (11:10 +0000)]
Merge "TFIVE-12640: fixed the size of handle string" into tizen

6 years agoTFIVE-12959: fixed scan response and adv data length 07/189007/1
Amit Purwar [Wed, 12 Sep 2018 10:56:36 +0000 (16:26 +0530)]
TFIVE-12959: fixed scan response and adv data length

Change-Id: Ib1290516f289f1cd4a6bc23cb1b8579a3f4d1b5d
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
6 years agoFix the coding style errors 95/188995/1
DoHyun Pyun [Wed, 12 Sep 2018 09:20:24 +0000 (18:20 +0900)]
Fix the coding style errors

Change-Id: If26907f850ab41859ba48b294af470c35ee9f14f
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoFix the build error in aarch64 87/188987/2
DoHyun Pyun [Wed, 12 Sep 2018 08:51:52 +0000 (17:51 +0900)]
Fix the build error in aarch64

Change-Id: Ieea61a740d960535fa0d67f4f2a52299ca86cd0b
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoAdd Werror option in CFLAG 71/188971/1
DoHyun Pyun [Wed, 12 Sep 2018 06:22:22 +0000 (15:22 +0900)]
Add Werror option in CFLAG

Change-Id: If8d0621fb55f1cd522b3d6787f37a251b762dec5
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoFix the build warnings and typo error 67/188967/1
DoHyun Pyun [Wed, 12 Sep 2018 06:21:55 +0000 (15:21 +0900)]
Fix the build warnings and typo error

Change-Id: I45c386258f39a5dbf71555b4a058caebe16f71df
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoRemove unused local variable and codes - wait_for_async( ) 28/188928/2
Taesoo Jun [Wed, 12 Sep 2018 02:45:44 +0000 (11:45 +0900)]
Remove unused local variable and codes -  wait_for_async( )

Change-Id: Ib9c2e29d3ee4f6e4ca3240e3f8633fff15655021
Signed-off-by: Taesoo Jun <steve.jun@samsung.com>