Youngbok Shin [Tue, 12 Jul 2016 01:20:03 +0000 (10:20 +0900)]
Edje calc: Fix Evas Text width calculation with ellipsis
Summary:
To keep consistency with Evas Textblock part in edje,
text.min has to work logically even if ellipsis is enabled.
If a Text part has minimum width, maximum width and "text.min: 1 X;",
Text part should be expanded until its width reaches to the maximum width.
Then, ellipsis will work. Singleline Textblock is also working like this.
@fix
Reviewers: cedric, herdsman, raster, tasn
Subscribers: Blackmole, z-wony, jpeg
Differential Revision: https://phab.enlightenment.org/D3587
Conflicts:
src/lib/edje/edje_text.c
Change-Id: Id2fac23c01364d78ef8c50b3559e66252b50489c
Daniel Hirt [Sun, 7 Aug 2016 08:13:16 +0000 (11:13 +0300)]
Evas font: fix size query again
Some wrong variables were used in the rewrite at
8c6effae8ee027a928bcee79968a0b21d8250487, basically reverting the original fix.
Change-Id: I343ab8205e23ac23306c1322fa3dd5b7fa7a4179
Signed-off-by: Youngbok Shin <youngb.shin@samsung.com>
Tom Hacohen [Thu, 14 Jul 2016 16:31:09 +0000 (17:31 +0100)]
Evas font: Fix width query for OpenType fonts. (rewrite)
This is essentially a cleaner redo of
ef817f15f0eaec9704ec25d9468c2c8497a5bc13.
Logic should be exactly the same as there, the different is that this
one shares the code between OT and non OT.
Please refer to that commit for more information.
Change-Id: I2ed6829f089039c1fd01215e6525aff9eaecaa1e
Signed-off-by: Youngbok Shin <youngb.shin@samsung.com>
Boram Park [Thu, 18 Aug 2016 09:49:26 +0000 (18:49 +0900)]
create a dummy ecore_drm_device when a drm device doesn't exist
Change-Id: I91ed3405d38c85aed2d0e142fb1810ebbadb35ec
Minchul Lee [Mon, 8 Aug 2016 09:02:57 +0000 (18:02 +0900)]
ecore_wl: support multiple mime types
deliver mime type to data reading callback
Change-Id: I5adad7ba60f0332ebe64b6e8e513fd6e395cf788
Signed-off-by: Minchul Lee <slotus.lee@samsung.com>
Ji-Youn Park [Tue, 16 Aug 2016 09:34:15 +0000 (18:04 +0830)]
ecore: Add multi thread error message.
tizen 2.3 returns ecore_timer or idler even though ecore_timer_add or ecore_job_add called outside of mainloop.
so we add error message to give chance for application to remove wrnog code (call ecore function outside mainloop)
but this can hide the problem and make it hard to know what is real problem.
so if application see the error message, they should their code.
Change-Id: Ib42dfeb5dc30255e40fee5e791523e1108764f2a
Joogab Yun [Fri, 12 Aug 2016 08:50:01 +0000 (17:50 +0900)]
[evas_sw_backend] enable tbm buffer on sw backend and refactoring
Change-Id: Ie20ac91d0af31f27124966effbfa6e87ce71f36c
Sungmin Kwak [Sat, 13 Aug 2016 06:03:10 +0000 (15:03 +0900)]
ecore_imf: fix typo
Change-Id: I2660fa96a0525fcdf9e83e9eb33f449c282f6581
sunghyun kim [Fri, 12 Aug 2016 05:02:21 +0000 (14:02 +0900)]
[evas-gl] enable dynamic_hint in wayland_egl
a feature called dynamic hint has been disabled in wayland.
so i enable this hint and fixed some crash.
1. Add flag in wayland_egl
: we need to check 'EGL_TIZEN_image_native_surface' in wayland
currently only gl_x11 check it.
2. Change dyn.target GL_TEXTURE_EXTERNAL_OES to GL_TEXTURE_2D
: if this target is GL_TEXTURE_EXTERNAL_OES, TM1 only show black screen.
i think some driver can't use GL_TEXTURE_EXTERNAL_OES.
upstream efl only use GL_TEXTURE_2D.
3. fixed crash in ector.
: fixed some crash when ector use dynamic hint.
Change-Id: If7f4b43d0e1634fb5ebdb9ca906c96b178ca283d
Jean Guyomarc'h [Tue, 13 Oct 2015 16:21:36 +0000 (18:21 +0200)]
ecore_cocoa: remove unused events
Change-Id: I08a6d78f0f58c36026a85e971cd10d494917e5c1
Jean Guyomarc'h [Tue, 13 Oct 2015 16:14:13 +0000 (18:14 +0200)]
ecore_cocoa: start doxygen
Change-Id: Idccfc69cf67ff01aa105dfc104cc74eb9abf1720
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Tue, 13 Oct 2015 15:12:53 +0000 (17:12 +0200)]
ecore_evas_cocoa: focus: handle ignore_events
Change-Id: I953a13849960a785ab71e2c106fd1cfb35b98b27
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Tue, 13 Oct 2015 15:09:28 +0000 (17:09 +0200)]
ecore_cocoa: don't track NSAppKitDefined event
Currently, it was used only to get track of focus, howver focus was
already handled (and better) in ecore_cocoa_window (with
NSWindowDelegate).
This led to the LOST_FOCUS event to be posted twice, with different
values, which messed up the focus stack.
@fix
Change-Id: Ibee5c8c6aec7bd0ad0bd539f8c5dbcaca34cce56
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Tue, 13 Oct 2015 14:10:42 +0000 (16:10 +0200)]
ecore_evas_cocoa: don't reset the init count if negative
Change-Id: Idfa606e2425dd4328b9448291da7f60cb236948c
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Tue, 13 Oct 2015 14:10:00 +0000 (16:10 +0200)]
ecore_evas_cocoa: use Eina macro to determine the size of a static array
Change-Id: I54c4e1667059ab37de8352e2aafce18c2892340d
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Tue, 13 Oct 2015 14:08:22 +0000 (16:08 +0200)]
ecore_evas_cocoa: don't shutdown ecore_event_evas() twice
Change-Id: I139db58708fbf6e3884e6f8a4f2fc9be193414a4
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Tue, 13 Oct 2015 14:07:38 +0000 (16:07 +0200)]
ecore_evas_cocoa: EAPI cannot be set for WIN32
Change-Id: Idf05b0603a0c35c1595bf5d6efd549086bcb9610
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Tue, 13 Oct 2015 13:20:27 +0000 (15:20 +0200)]
ecore_cocoa: fix types
Change-Id: I260dc65aafd50e44dd61cf81efe0682267733a44
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Tue, 13 Oct 2015 12:57:52 +0000 (14:57 +0200)]
ecore_evas_cocoa: remove dead code
Change-Id: If9724d11e3d7fc2d057eb6ceaff55013542932a0
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Fri, 9 Oct 2015 15:18:03 +0000 (17:18 +0200)]
ecore_cocoa: copy and paste support
Change-Id: Ia5209723ac8d9dca3339e76fee96cff36d8bd187
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Tue, 13 Oct 2015 09:05:04 +0000 (11:05 +0200)]
ecore_cocoa: silent warning: unused parameter
Change-Id: I76ad921399736ceb40befa4b34af465ec96029cf
Jean Guyomarc'h [Tue, 13 Oct 2015 09:01:15 +0000 (11:01 +0200)]
ecore_cocoa: use EAPI in implementation
Change-Id: I98d115bc041484d648859d101787214972046ffc
Jean Guyomarc'h [Tue, 13 Oct 2015 08:59:13 +0000 (10:59 +0200)]
ecore_cocoa: improve const-correctness
Change-Id: Ied46d73d2c831606840f2558f903a82aca4cae1a
Hosang Kim [Thu, 11 Aug 2016 11:02:26 +0000 (20:02 +0900)]
edje_callbacks: Add mouse,pressed,in/out signal.
Summary:
The mouse,in/out signal has missing parts to use.
When user send down event on specific object, then move
cursor to outside of object.
the mouse,in signal must be called in case. but it's
not in traditional implement.
So i added this signal for support above use case.
In order to satisfy above use case, user can
add both of the signals(mouse,in
mouse,pressed,in).
(Adding new name of signals to do not break
compatibility with before implements.)
@feature
Test Plan:
Add mouse,pressed,in/out
program to object.
Press object which added
signals before.
Move mouse cursor to
out of object, then
check the program
works.
Reviewers: Hermet,
cedric, raster
Subscribers:
cedric
Differential
Revision:
https://phab.enlightenment.org/D2992
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
Change-Id: I720160834f12c1154e6222122cb13fa62a65b24d
Carsten Haitzler (Rasterman) [Mon, 8 Aug 2016 05:27:26 +0000 (14:27 +0900)]
efl - edje entry - dont emit changed on markup set unless text changed
if the text didnt actually change we generat a lot of noise in changed
signals for no change at all in text. shortcut this and check the new
and old text and compare ptrs, 0 length and strings etc.
this fixes T4045
@fix
Change-Id: I889f7e0e7bfa449d991169ee395d2c0c4b6a6178
Signed-off-by: Youngbok Shin <youngb.shin@samsung.com>
Hosang Kim [Tue, 9 Aug 2016 05:21:50 +0000 (14:21 +0900)]
ecore_wl_input: fix timestamp of repeat key event.
Timestamp is not updated when key event is repeated.
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
Change-Id: I73592d6ccc4f85f665e2212e703f23f5b5056428
Jiyoun Park [Tue, 9 Aug 2016 02:20:21 +0000 (19:20 -0700)]
Revert "ecore_wl_input: fix timestamp of repeat key event."
This reverts commit
f0612400d329ff41c5ddae6c7087b0c867c56ca6.
Change-Id: I5bc5accdc1fdd57ab91eca4ec1072a96bb755304
Hosang Kim [Mon, 8 Aug 2016 10:06:45 +0000 (19:06 +0900)]
ecore_wl_input: fix timestamp of repeat key event.
Timestamp is not updated when key event is repeated.
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
Change-Id: I924321ba2e1f05292654b8c8d7b81e369b956977
Jean Guyomarc'h [Mon, 12 Oct 2015 16:49:46 +0000 (18:49 +0200)]
ecore_cocoa: don't specify inline
Change-Id: Id1d86f50281c5e2b4c1b80869d0c8e11948de5b5
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Thu, 8 Oct 2015 09:58:46 +0000 (11:58 +0200)]
ecore_cocoa: add support for system cursors
- Ecore_Cocoa_Cursor enum which references system cursors;
- API to show/hide cursor: ecore_cocoa_window_cursor_show();
- API to set system cursor: ecore_cocoa_window_cursor_set();
- Ecore_Evas interface to get Ecore_Cocoa_Window from Ecore_Evas.
@feature
Change-Id: Iadef3d4bbffd5c92fa2c8d040393f7a9160c8ac4
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Nicolas Aguirre [Thu, 6 Aug 2015 17:06:34 +0000 (19:06 +0200)]
ecore_cocoa/evas_gl_cocoa: fix indent, remove printf, and add DBG messages
Change-Id: I52fbe128a50ca5db69e5bf96fc2d2e78903b97f2
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
sunghyun kim [Mon, 8 Aug 2016 07:51:32 +0000 (00:51 -0700)]
Revert "[evas-gl] change dyn.target & delete api"
This reverts commit
a1cb67bdb9007b58c9b506989a3aacf640b36c53.
Change-Id: I95e64920dab5cdd9283dea717bf6e2993988f9ad
Pankaj Mittal [Tue, 2 Aug 2016 07:38:00 +0000 (13:08 +0530)]
edje_entry: Fix crash on selection.
evas: properly clean up all memory.
Summary:
When text is selected, crash happens due to double free as rectangles are freed both in _sel_update
and _evas_textblock_selection_iterator_free hence removing free from _sel_update.
upstream commit:
6bd863cf4ffb46f0267e96844cea37a95599e9de
Signed-off-by: Pankaj Mittal <m.pankaj@samsung.com>
Change-Id: Ib5afa8be821e983aa2e3c562c5f8df70151e5e00
Jean-Philippe Andre [Mon, 27 Jun 2016 11:36:24 +0000 (20:36 +0900)]
evas: Fix bad clipping with proxy
evas-images2 example was broken due to excessive clipping.
This is one more issue with the cached clip geometry.
By default proxy_src_clip is true. The doc (that I wrote)
mentions that it means both objects (image proxy & source)
share the same clipper. So, this does not mean that the proxy
is clipped to the geometry of the source (this can be useful
in some cases, when replacing an object with a proxy to apply
some kind of effect on it... but this could be rare).
Thanks Amitesh for the report.
@fix
Signed-off-by: Pankaj Mittal <m.pankaj@samsung.com>
Change-Id: I910f57162064aafecc1b0397f8c7af6ba1469e94
Subhransu Mohanty [Fri, 5 Aug 2016 04:45:11 +0000 (13:45 +0900)]
svg: backported from opensource
Change-Id: Ice88f75c1461f3febb6eb1f67be27cf02f6db49d
Tom Hacohen [Fri, 5 Feb 2016 11:48:36 +0000 (11:48 +0000)]
Ecore con local: properly clean up fd on error.
This wasn't done correctly in the previous commit. First of all, the
order of cleanup was wrong, the cleanup area should only be called if
failures occurred after the fd allocation, not before. Also, fd should
be reinitialised to -1 once we close the socket.
Change-Id: I96edd3c4685300e4ec8e25e55aa8a17774700eb5
Signed-off-by: Awadhesh Singh <awadhesh1.s@samsung.com>
Pankaj Mittal [Tue, 2 Aug 2016 07:14:43 +0000 (12:44 +0530)]
Edje data: Fix memory leak in nested data descriptors
upstream commit:
b54fe3fe617710832b0d7bfe361f3bcb3bfd0ad3
this was ported from upstream.
Signed-off-by: Pankaj Mittal <m.pankaj@samsung.com>
Change-Id: If235d930e6acda55a9d2a51ed978b81b56eac263
Pankaj Mittal [Tue, 2 Aug 2016 06:49:51 +0000 (12:19 +0530)]
Evas textblock: Remove redundant NULL check.
this issue was a fix for problem Detected by smatch
This is ported from upstream.
Signed-off-by: Pankaj Mittal <m.pankaj@samsung.com>
Change-Id: I80fc34c11f811b0d69a79fb2db7b9b4db013b049
Hermet Park [Thu, 4 Aug 2016 06:43:41 +0000 (15:43 +0900)]
efl: fix a neon build break.
We found a some build break problem due to a build system.
In efl configuration, our efl configure enables neon if it's available,
but neon gonna partially turned off on evas compilation if the build system
has a non neon CFLAG option (ie, mfpu=vfpv..). In the end, neon is partially enabled
and it turns out a build break.
It's non-sense but we can't allow this breakage.
There is no way to ignore build system option nor override our neon option perfectly,
so, Let efl package ruled by build system overall.
http://git.enlightenment.org/core/efl.git/commit/?id=
77d2e0cb959b9e7ecc6ffc09b67031ac3687f332
Change-Id: Ie94e277b206830a517a4fb33f1187b1fa785d243
InHong Han [Wed, 3 Aug 2016 07:40:24 +0000 (16:40 +0900)]
ecore_imf: Add ECORE_IMF_INPUT_PANEL_LAYOUT_VOICE
Change-Id: I41502d2446b95a4be31fc60a8d995b9d37930844
Doyoun Kang [Wed, 27 Jul 2016 06:09:45 +0000 (15:09 +0900)]
ecore_wayland: added feature for handling indicator
Change-Id: Iba6b112c38da173f3a635dd4421b76d40d4d54ee
MinJeong Kim [Tue, 26 Jul 2016 11:07:28 +0000 (20:07 +0900)]
ecore_wayland: handle 'aux_message' event and create its ecore event
Change-Id: Icaf9f2c1347e45e1a12a96ebfb9fdaa64f111ea3
Signed-off-by: MinJeong Kim <minjjj.kim@samsung.com>
Juyeon Lee [Wed, 13 Jul 2016 12:31:18 +0000 (21:31 +0900)]
ecore_wl_window: resource destroy for tizen_resource iface
Change-Id: Ia9557056b56df76f1ad4acdfc10333831b01ab31
Duna Oh [Mon, 20 Jun 2016 10:52:59 +0000 (19:52 +0900)]
ecore_wl: store last_device_ptr/kbd/touch seperately
tizen_input_device sends event_device events only when event_device's class is changed
Signed-off-by: Duna Oh <duna.oh@samsung.com>
Change-Id: I92bb7fd6833c2574415c99d4286bf0d375f40129
Andrii Kroitor [Wed, 20 Jul 2016 14:36:26 +0000 (17:36 +0300)]
edje_edit: comment out text and size classes
Change-Id: If3c62c3ea030d0f527b250f44bd9d49628252390
Vitalii Vorobiov [Tue, 7 Jun 2016 13:57:02 +0000 (16:57 +0300)]
edje_edit: fix copy&paste type for map functions which should return int
zplane and focal actually returns int, not Eina_Bool
@fix
Change-Id: Ic384276c8e0406a55425ed41d0d0e8b3ccf57058
Mykyta Biliavskyi [Tue, 17 May 2016 09:00:44 +0000 (12:00 +0300)]
Edje_edit: generate code of the image sets.
Added support generate the edc code of the image sets in the image top level block.
And correct support inside the image.normal attribute.
Change-Id: I6f88e7323e8e69c8c4b3e55301cac1d633c9ff1c
Mykyta Biliavskyi [Mon, 16 May 2016 12:48:15 +0000 (15:48 +0300)]
Edje_edit: generate states of the box and table part edc code with inheritance.
Generate inheritance box and table attributes from similar state.
Change-Id: Iec03eb67e04ee94f7cfc082fae5f741045e9e31f
Mykyta Biliavskyi [Mon, 16 May 2016 12:21:59 +0000 (15:21 +0300)]
Edje_edit: generate states of the proxy part edc code with inheritance.
Generate inheritance proxy attribute "source" from similar state.
Change-Id: Ic0aa52bdc3e4d5ff67a0ff84feec8391cb03240c
Mykyta Biliavskyi [Mon, 16 May 2016 12:12:31 +0000 (15:12 +0300)]
Edje_edit: generate states of the image part edc code with inheritance.
Generate inheritance image attributes from similar state.
Change-Id: I4dfe98e888c1096132b1c86d1b3ce4269d70ecfd
Mykyta Biliavskyi [Mon, 16 May 2016 11:55:11 +0000 (14:55 +0300)]
Edje_edit: generate states of the text part edc code with inheritance.
Generate inheritance text attributes from similar state.
Change-Id: I5601a5d13cb025916b46abf71dafc5a8b42ae303
Mykyta Biliavskyi [Mon, 16 May 2016 11:34:02 +0000 (14:34 +0300)]
Edje_edit: generate state code with inheritance map block.
Add ability to generate inherited code for map block.
Change-Id: Ica9ba762295073f246f68c4bbfd0ea42e71d38a9
Mykyta Biliavskyi [Mon, 16 May 2016 11:25:00 +0000 (14:25 +0300)]
Edje_edit: generate state code with inheritance rel block.
Add ability to generate inherited code for relative block.
Change-Id: I327c8ffbedb9cd2fc547e58cf78de0b05db877aa
Mykyta Biliavskyi [Mon, 16 May 2016 10:57:52 +0000 (13:57 +0300)]
Edje_edit: generate state code with inheritance general attributes.
Support inheritance for part states on the edc code generate time.
Only for general attributes are supported, except relative and
map blocks.
Added functions for calculation coefficient of similarity
between two different states of the same part.
Change-Id: I745d36b1170efd6ac0039a30b6b9ce2bd2dfc251
Mykyta Biliavskyi [Mon, 16 May 2016 10:33:42 +0000 (13:33 +0300)]
Edje_edit: move text state edc code generate to standalone func.
Created internal function _edje_generate_source_state_text.
This is needed for implementation generate inheritance
states in edc code.
Change-Id: I6e66a93e9f1642505bf7f8f4b916c0b1d008ce4b
Jean-Philippe Andre [Thu, 28 Apr 2016 07:05:00 +0000 (16:05 +0900)]
Edje Edit: Fix compilation warning
Change-Id: If2d1ddf708c7246fe9f45872b32b816006f3d34e
Mykyta Biliavskyi [Tue, 26 Apr 2016 15:08:23 +0000 (18:08 +0300)]
Edje edit: improve state code generation.
Split function _edje_generate_source_of_state into
separated smallest functions, that represent generation
of source code for different blocks.
List of added internal functions:
- _edje_generate_source_state_map
- _edje_generate_source_state_box
- _edje_generate_source_state_table
- _edje_generate_source_state_image
- _edje_generate_source_state_proxy
- _edje_generate_source_state_relative
Add support collapse blocks, in cases when
block contain only one attribute.
For example:
next EDC code
description { state: "default";
{
rel1 {
relative: 0.5 0;
}
}
now will be replaced by:
description { state: "default";
{
rel1.relative: 0.5 0;
}
Change-Id: Ic71dd14abfb587bca5b91894e166e369ae57d79e
Vyacheslav Reutskiy [Tue, 26 Jul 2016 12:25:01 +0000 (15:25 +0300)]
edje_pick: copy block 'data'
Copy global data from files. Main resoan for it - elementary.
Elementary needs data "version" for load widget styles.
@fix
Change-Id: Ied2584e1bf3a1bbe05246f782fe508545b979eeb
Vyacheslav Reutskiy [Thu, 21 Jul 2016 11:02:46 +0000 (14:02 +0300)]
edje_pick: reset alias flag for copied group
edje_pick make copy of whole group, even if group is alias. So if
group was alias need to reset this flag.
@fix
Change-Id: I38309df35ac890e5226161bc20e36d2253ed5062
Vyacheslav Reutskiy [Tue, 19 Jul 2016 15:25:52 +0000 (18:25 +0300)]
edje_pick: copy dependent group
Parts can use enother groups as source, for example textblock. If source
groups does not exist - group is not valid. This patch extend the group
copy process and copy dependend group too.
@fix
Change-Id: Ib64be93331202029a6204c0406a76a10902c62db
Jean-Philippe Andre [Wed, 13 Jul 2016 02:16:33 +0000 (11:16 +0900)]
edje_pick: Fix use after free
Fixes CID 1267458 (trying again)
Change-Id: I6981873d5bac05d7d407582dcb4c12d8794d96f2
Jaehwan Kim [Thu, 7 Jul 2016 05:30:17 +0000 (14:30 +0900)]
edje_pick: realloc bug fix
@fix
Change-Id: Ibffd5911dd340518cdc583640ca786dfdf1eae90
Jean-Philippe Andre [Mon, 4 Jul 2016 11:25:17 +0000 (20:25 +0900)]
edje: Remove shadow variable
Change-Id: I8554fc21e1b56bc34b97e902f7c88ba75cecc4dd
Jaehwan Kim [Fri, 1 Jul 2016 02:18:27 +0000 (11:18 +0900)]
edje_pick: load just used images.
If the edj is made by partial groups, the images that groups use
should be included.
@fix
Change-Id: I75616642af88abdd465969597623eeb48858d781
Andrii Kroitor [Wed, 20 Jul 2016 14:31:57 +0000 (17:31 +0300)]
edje_edit: fix eo_parent_set calls
Change-Id: I3241279cb6c7fb285f59a8e35e5b10f3dd5c2bcf
Carsten Haitzler (Rasterman) [Sat, 9 Jul 2016 03:17:46 +0000 (12:17 +0900)]
edje edit - api was broken with incorrect l r t b ordering for border
this fixes ordering to match everywhere else ANd usage of the get
func. this was broken already where top/bottom border would swap -
plese see coverity scan CID 1355590 for an example of problems this
created.
Change-Id: I847d4017f540e61f3b9f8137002ef376c9998f71
Carsten Haitzler (Rasterman) [Fri, 8 Jul 2016 06:33:19 +0000 (15:33 +0900)]
edje edit - fix leaks spotted by coverity
fixes CID 1356630
Change-Id: I7bacf8be18cf5ba369468d3b8950b3530684d17a
Vitalii Vorobiov [Thu, 7 Jul 2016 17:31:01 +0000 (20:31 +0300)]
edje_edit: on save_all firstly save all cached group, then all other
this will fix case when aliased group was changed and alias-group was loaded,
so then on saving alias-group WON'T rewrite all changed to aliased group
@fix
Change-Id: I1da040640b87b00608ee172f6a5ef0c9f6a689b9
Mykyta Biliavskyi [Tue, 5 Jul 2016 17:18:32 +0000 (20:18 +0300)]
Edje_Edit: allow set NULL as a style name for textblock part.
NULL as 'style' value remove style name from textblock part state.
Change-Id: I8473a1e6472cc3e20dadba36d2a23be0d99c720c
Carsten Haitzler (Rasterman) [Mon, 4 Jul 2016 05:59:59 +0000 (14:59 +0900)]
edje - reduce memory footprint by rearranging structs and types
this should cut some memory used by edje by using smaller types like
shorts instead of ints where we just dont need a full int range and
short will do, and re-ordering in memory data soit packs better when
accoutning for alignment
Change-Id: Ia4b6755b0056cd6e9dc3260775a6c2bbb01ddd0c
Vitalii Vorobiov [Thu, 30 Jun 2016 09:08:46 +0000 (12:08 +0300)]
edje_edit: remove useless pointer grab as it conflicts with elementary combobox
Summary:
So currently having an issue related to clip_to function from
EdjeEdit API. I am not sure about how and why combobox use pointer grabbing
(just started to use it) but when setting NULL into clip_to of edje edit it
suddenly block entire screen away from mouse. Only when point is moved out of
window and back, only then it will be able to access widgets again.
Take a look at video and maybe try example to reproduce problem
I am not sure if deleting those functions from edje_edit is actually right
decision. But it will fix the problem of course.
Test Plan: See attached video and examples in attached files
Reviewers: NikaWhite, reutskiy.v.v, Hermet, cedric, raster
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D4081
Change-Id: Icda0649a2aadb0d904d9b2e5884b107e1c4833fb
Jean-Philippe Andre [Tue, 21 Jun 2016 06:45:31 +0000 (15:45 +0900)]
evas: Remove common interface and use provider_find
Evas.Common_Interface not only had a bad name, it also
wasn't in line with how we can get a loop object, for
instance.
Use eo_provider_find in each implementing class.
Change-Id: I653d1c5a3687df3dfc9b37015ffa2b939d8bf8d0
Mykyta Biliavskyi [Thu, 16 Jun 2016 11:33:32 +0000 (14:33 +0300)]
Edje_edit: fix text_source_set and text_text_source_set.
Do not need to replace text value inside edje_edit_state_text_text_source_set,
because edje_text module will use text from source.
Change-Id: I7dfb4b2fa6a8fb3bb83c971fafb87c2c7db79300
Vyacheslav Reutskiy [Thu, 16 Jun 2016 07:56:31 +0000 (10:56 +0300)]
edje_edit: return NULL if part has not style attribute
Change-Id: I47358c1250c2d710513f669c09281d48deea8d71
Vitalii Vorobiov [Wed, 15 Jun 2016 09:53:15 +0000 (12:53 +0300)]
edje_edit: save referenced groups when image id's are changed
@fix
Change-Id: I9fbb9bd96598d2933f71050b4c89e0563a44abc2
Vitalii Vorobiov [Wed, 8 Jun 2016 15:47:19 +0000 (18:47 +0300)]
edje_edit: add missed part and description initializations
@fix
Change-Id: I15b37bf613d1fabd5f0512c2b6e8530366b20de1
Vitalii Vorobiov [Tue, 7 Jun 2016 14:56:40 +0000 (17:56 +0300)]
edje_edit: text style should be able to set into NULL
@fix
Change-Id: I790fce553c7dfd42c5fc330986a2e63fae897225
Vitalii Vorobiov [Mon, 6 Jun 2016 17:46:14 +0000 (20:46 +0300)]
edje_edit: fix map API (light, perspective, rotation)
it should be possible to set light or perspective to NULL
and return -1 when nothing is set
also ability to send NULL point to store rotation
@fix
Change-Id: If949b472a19f9a56d12b93fd2bb8a3e86ab904ef
Vyacheslav Reutskiy [Mon, 6 Jun 2016 07:42:14 +0000 (10:42 +0300)]
edje_edit: return lost API *_span_row/col_set declaration
I'm lost this declaration while add API for manager part items by
index and mark as deprecated old funcs
Change-Id: I005d69e363e1e3fb0bd7ce25501e07c5d04c5ddd
Jean Guyomarc'h [Sat, 4 Jun 2016 14:51:38 +0000 (16:51 +0200)]
edje: don't return a boolean when a pointer is expected
Fix a warning thrown by Apple-llvm.
Change-Id: I6790b907e9c21a4a841967817d2ec5fc88414992
Vyacheslav Reutskiy [Fri, 3 Jun 2016 09:26:57 +0000 (12:26 +0300)]
edje_edit: add API for set/get part item
Change-Id: Ib09ffb4b7f565d4736dfe889effb0cb7bf83d294
Vyacheslav Reutskiy [Thu, 2 Jun 2016 14:40:00 +0000 (17:40 +0300)]
edje_edit: add API for get part item attributes by item index
Cedric revert patch
6f7608befd006f8076d237bee5d17c9e9e1e09ac same days
ago.
<quote Cedric>
Your patch
6f7608befd006f8076d237bee5d17c9e9e1e09ac did break elemines
which does relly on the proper index to be given to it. I think
Edje_Edit should be fine and use the index if no name is provided (See
edje_load.c around L1180). In all case this was clearly an ABI break and
needed to be reverted.
</quote Cedric>
So now edje_cc not guarantee name for part items. This is bad, because
edje_edit use item name for access to item attributes. If item have not
name we cann't get it attributes, because edje_edit compare the given
name with part items name from edj-file, strcmp dislake NULL args.
For now I see one way mark all edje_edit_part_item* APIs as deprecated
and add new APIs for manage part items by index.
For clearly and history:
The eason for revert - https://phab.enlightenment.org/D3820
The proposed solution - https://phab.enlightenment.org/D3907
Change-Id: I1d2d497749bdf40fd2ed05deaf488d8dd5e533fe
Vitalii Vorobiov [Tue, 10 May 2016 14:30:03 +0000 (17:30 +0300)]
Edje_Edit: more API for proxy fields like source_clip and source_visible
Setters and getters like
edje_edit_state_proxy_source_clip_set
edje_edit_state_proxy_source_clip_get
edje_edit_state_proxy_source_visible_set
edje_edit_state_proxy_source_visible_get
Change-Id: I13569777f4ad36cb433ee14596191640277c4054
Andrii Kroitor [Tue, 10 May 2016 22:44:30 +0000 (15:44 -0700)]
edje_edit: fix edje_edit_group_copy
Summary:
Writing copy directly to file.
Old way (adding directly to collection cache) leads to possible segfaults
on edje_collection_cache_flush.
Reviewers: reutskiy.v.v, cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D3904
Change-Id: I53bd730a1aad4d19be29b5a896819a2e79972cfb
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Mykyta Biliavskyi [Fri, 29 Apr 2016 08:25:41 +0000 (11:25 +0300)]
Edje edit: remove color generate from SPACER source.
It is possible situation when SPACER structure has colors values.
For example:
group { name: "abc";
parts {
part { name: "rect"; type: RECT;
description { "default" 0.0;
color: 7 7 7 255;
}
}
}
}
group { name:"abc_2";
inherit: "abc";
parts {
part { name: "rect"; type: SPACER;
}
}
}
To avoid failing compilation of generated source code, need avoid
generate color source code for a SPACER part.
Change-Id: Ib4dd565a3df59d899a28553ca2e8a7290f724e03
Vitalii Vorobiov [Thu, 28 Apr 2016 12:38:50 +0000 (15:38 +0300)]
Edje_Edit: update function that return image usage to include sets
Image can be also used not only inside of any image parts, but also
inside of any sets (and plenty of times)
Change-Id: I556c87067f1bf81d3d8f7273ed109ab02bdd5352
Vitalii Vorobiov [Thu, 28 Apr 2016 12:06:20 +0000 (15:06 +0300)]
Edje_Edit: API to delete set of images
Allow to delete set if it is not used by any part
Function to check if set is used by any part is:
edje_edit_set_usage_list_get
Since it uses same struct as image_used_list_get function, it
can be freed by edje_edit_image_usage_list_free.
Change-Id: I5d897ea1823a5cf7654eaa803ccdea95bdf3660c
Vitalii Vorobiov [Wed, 27 Apr 2016 13:34:02 +0000 (16:34 +0300)]
Edje_Edit: setter and getter for set image's scale_by
edje_edit_image_set_image_border_scale_set
edje_edit_image_set_image_border_scale_get
Change-Id: Ib54aadbf04e6d0d9a54b5284c9007535dc60eada
Vitalii Vorobiov [Wed, 27 Apr 2016 13:23:43 +0000 (16:23 +0300)]
Edje_Edit: functions to set and get set's images border
edje_edit_image_set_image_border_set
edje_edit_image_set_image_border_get
Change-Id: Ica644af4555d27f1670ded1d825c1a378b1c14b3
Vitalii Vorobiov [Wed, 27 Apr 2016 12:42:12 +0000 (15:42 +0300)]
Edje_Edit: setters and getters for set's image size (min and max)
Functions are:
edje_edit_image_set_image_min_get
edje_edit_image_set_image_min_set
edje_edit_image_set_image_max_get
edje_edit_image_set_image_max_set
Change-Id: Ib378f0fdce6e3ffc99dd5059411752847c40b090
Vitalii Vorobiov [Wed, 27 Apr 2016 10:58:44 +0000 (13:58 +0300)]
Edje_Edit: some API to manipulate set's images
get list of images of set (edje_edit_image_set_images_list_get)
add image to set (edje_edit_image_set_image_add)
delete image from set by it's place (edje_edit_image_set_image_del)
Change-Id: I4dc2000fb229125eb20ee1c04f0f6c47d6c002cb
Vitalii Vorobiov [Wed, 27 Apr 2016 08:52:04 +0000 (11:52 +0300)]
Edje_Edit: image set API
list of sets (edje_edit_image_set_list_get)
renaming set (edje_edit_image_set_rename)
add new set (edje_edit_image_set_add)
set's id (edje_edit_image_set_id_get)
Change-Id: Idf8aa4061d9199a9bf30a512b3eb266dd5081808
Vitalii Vorobiov [Tue, 26 Apr 2016 12:04:46 +0000 (15:04 +0300)]
Edje_Edit: API to check if given name of "image set" is exist
edje_edit_image_set_exists
Change-Id: Ia43582a270c9fa131350c3f70e426e9d8ce3d9bc
Vitalii Vorobiov [Tue, 26 Apr 2016 11:43:47 +0000 (14:43 +0300)]
Edje_Edit: get "set's name" if it was set as image normal or tween
Sets and Images, they might have same id but different names
Change-Id: Ib674d72e683fdc37ae3537804a2e53b48bb3a968
Andrii Kroitor [Fri, 22 Apr 2016 23:12:26 +0000 (16:12 -0700)]
edje_edit: fix mempools in group/alias add
Summary: moved mempools adding to separate method to avoid this problem in future
Reviewers: cedric, reutskiy.v.v
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D3903
Change-Id: I07f003801de2a6be0a4dc69313b5c4b4f435de2e
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Mykyta Biliavskyi [Tue, 19 Apr 2016 11:19:53 +0000 (14:19 +0300)]
Edje edit: fix aspect_preference value into generate code function.
Add value "SOURCE" as one of possible values for aspect_preference
attributes.
@fix
Change-Id: Ie01fca9ba957b1c7c770ecb9f96fc07825995d0e
Mykyta Biliavskyi [Tue, 19 Apr 2016 11:06:40 +0000 (14:06 +0300)]
Edje edit: add new program actions into code generate function.
Generate edc source code for next action types:
- EDJE_ACTION_TYPE_FOCUS_SET
- EDJE_ACTION_TYPE_FOCUS_OBJECT
- EDJE_ACTION_TYPE_PARAM_COPY
- EDJE_ACTION_TYPE_PARAM_SET
Change-Id: I68583c8a533b32180ca8825b8c4f4bd639a69840
Mykyta Biliavskyi [Mon, 18 Apr 2016 13:46:39 +0000 (16:46 +0300)]
Edje edit: fix get list of program tagrets.
Correct support all types of program actions for constructing
list of targets.
There are 3 group of actions, that related to targets:
- Does not support targets at all.
- Support only parts as targets.
- ACTION_STOP, that supported parts and other programs as targtes.
@fix
Change-Id: Ide38e16c96e26fdb14d463174709dcabba831d1f
Andrii Kroitor [Mon, 18 Apr 2016 23:32:26 +0000 (16:32 -0700)]
edje_edit: add missing mempools on group copy
Reviewers: reutskiy.v.v, cedric
Subscribers: cedric, FurryMyad, NikaWhite, jpeg
Differential Revision: https://phab.enlightenment.org/D3899
Change-Id: I044060c83572670fffc81083933e03c5f3ce6b1d
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tom Hacohen [Thu, 7 Apr 2016 13:56:57 +0000 (14:56 +0100)]
Edje: Reparent when swallowing/unswallowing.
On swallow make the edje object the parent, on unswallow the canvas.
Change-Id: I13d2595abb3d2104a0e484481847528786dfdcd3