SangYoun Kwak [Wed, 4 May 2022 05:47:18 +0000 (14:47 +0900)]
Modify conf keyword, UPPER_SNAKE_CASE to PascalCase
Change-Id: I8791c448ab4136be1c17c8a76d2ebfe268d6c2e3
Signed-off-by: SangYoun Kwak <sy.kwak@samsung.com>
Hyotaek Shim [Tue, 3 May 2022 08:25:25 +0000 (17:25 +0900)]
Rearrange conf source files
Change-Id: I4f19473c89f2de56d49902a043c9a0e97884f954
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Karol Lewandowski [Wed, 27 Apr 2022 15:54:45 +0000 (17:54 +0200)]
block: Ensure srcpath backing loop image mount point is not null
This commit addresses SVACE-reported issue.
Change-Id: I03871ae2cda6c5aede9582dc4be62aeb31696b4b
Youngjae Cho [Tue, 19 Apr 2022 01:07:14 +0000 (18:07 -0700)]
Remove unused code
The dbus library has been replaced to gdbus of libsyscommon on the
below patch.
- commit
b69e936ca63fce2ff6ad779b319176f622f3bd41
Therefore, remove unused dbus source code.
Change-Id: I63f6d826a44e256d95846faf63346035073479d4
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Karol Lewandowski [Tue, 12 Apr 2022 15:26:17 +0000 (17:26 +0200)]
block: properly detect internal/external storage when tizen is run from loop-mounted image
For loop-mounted devices we have to check on which device the image file resides,
and to treat this device as internal storage.
Change-Id: I0c3e1b51e948963b2fdf0fc711539d11631f0110
Mateusz Moscicki [Wed, 9 Feb 2022 21:08:07 +0000 (22:08 +0100)]
block: add support for partitions numbered greater than 9
fnmatch() not match for partitions with numbers greater than 9
(e.g. /dev/mmcblk1p65) for the "mmcblk[0-9]p[0-9]" pattern.
Change-Id: I21ee910ac8bcb00bdc8067f0ece331f2f913bb5a
INSUN PYO [Wed, 21 Jul 2021 01:20:39 +0000 (10:20 +0900)]
udev: change the name of udev monitor buffer size
Change-Id: Ib64098207be5f1f46dd5ce46d27233c81d775c8f
INSUN PYO [Wed, 14 Jul 2021 05:46:29 +0000 (14:46 +0900)]
common: improve G_IO_ERR | G_IO_HUP handling
Change-Id: I00f7434b06a6580f9e19e780d028466ce6085e5c
Yunmi Ha [Tue, 11 May 2021 08:53:00 +0000 (17:53 +0900)]
block: check '/' and '/opt' path for internal storage
Change-Id: I24c8df4e927c94b173f01f2d9e55e0d8a8ab95be
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
INSUN PYO [Tue, 11 May 2021 07:50:27 +0000 (16:50 +0900)]
Support /dev/mapper/rootfs root device
Root device is /dev/mapper/rootfs on RPI4 with dm-verity.
So, the actual root device is not correctly found,
and /dev/mmcblk0 is not recognized as an internal device.
Storaged recognizes the partitions of /dev/mmcblk0p* as external devices,
and storaged mounts them to /opt/media/SDCard@*.
///////////////////////////////////////////////////////////////////
/dev/mmcblk0p1 65390 20830 44560 32% /opt/media/SDCard@1
/dev/mmcblk0p10 59365 1299 53480 3% /opt/media/SDCard@10
/dev/mmcblk0p11 120355 1555 109805 2% /opt/media/SDCard@11
///////////////////////////////////////////////////////////////////
Change-Id: I42f211684e519371a23ee0b403bd3d941d243bb0
Hyotaek Shim [Thu, 29 Apr 2021 05:41:45 +0000 (14:41 +0900)]
Improve alignment and naming style in block.c
Change-Id: I7a7cc306e317da6cbfdd75e8dd080f8bbfb1921d
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Fri, 7 May 2021 01:00:09 +0000 (10:00 +0900)]
Fix resource leak - mnt_new_table/mnt_free_table
Change-Id: Ifd1c0466ed9b6003dcc0e168ed2432cf5c3f3fa1
taemin.yeom [Fri, 19 Mar 2021 07:03:42 +0000 (16:03 +0900)]
Change dbus function name
Change-Id: I60e0727ed5c522d1a7c24bb8a17be46a7697aa1c
Signed-off-by: taemin.yeom <taemin.yeom@samsung.com>
taemin.yeom [Fri, 12 Mar 2021 05:48:31 +0000 (14:48 +0900)]
Improve variable naming style
Change-Id: I92826b02fe83647bc3f418a4d54c9c5807de78da
Signed-off-by: taemin.yeom <taemin.yeom@samsung.com>
taemin.yeom [Tue, 9 Mar 2021 05:48:10 +0000 (14:48 +0900)]
Apply libsyscommon gdbus api improvement on error handling
Change-Id: I6e5fa21dde4f91ce0caff5a4a7c59c6eb6bfdc14
Signed-off-by: taemin.yeom <taemin.yeom@samsung.com>
Yunmi Ha [Wed, 6 Jan 2021 11:58:19 +0000 (20:58 +0900)]
Use libsyscommon for list and ini-parser
Change-Id: I87a0550c6fd536d24dba6de634c559a3146945a4
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Mon, 21 Dec 2020 04:15:23 +0000 (13:15 +0900)]
Remove unused package info
Change-Id: I1c9f2e7fe9256275a6a75bb35f0ed3c10c329c37
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
lokilee73 [Mon, 21 Dec 2020 01:37:46 +0000 (10:37 +0900)]
Fix build error
[ 64s] /home/abuild/rpmbuild/BUILD/storaged-1.0.0/src/block/mmc.c:23:10: fatal error: attr/xattr.h: No such file or directory
[ 64s] 23 | #include <attr/xattr.h>
Change-Id: I9b3bc27008c7a012637fb1b2630d3ae096da694c
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
Yunmi Ha [Wed, 21 Oct 2020 06:07:47 +0000 (15:07 +0900)]
Call "Add_Poweroff_Wait" dbus method asynchronously.
Change-Id: I8b0b9a152971aa8cf196897606a4f2ba4878e460
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
lokilee73 [Thu, 10 Sep 2020 07:30:39 +0000 (16:30 +0900)]
Change function name
ex) dh_get_param_from_var to g_variant_get_safe
Change-Id: Ife46d4922623e82116826ca2550e6f52794207f9
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
Hyotaek Shim [Tue, 8 Sep 2020 08:16:08 +0000 (17:16 +0900)]
Add a build option for enabling or disabling EXTENDED_STORAGE
Change-Id: I95d5a3ca5e86f410386549bf629652922bf93bf6
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Yunmi Ha [Mon, 13 Jul 2020 05:51:17 +0000 (14:51 +0900)]
Fix 'stringop-truncation' build warning
Change-Id: I2e7767af096d854e5d7964744d92ae41b1a56070
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Wed, 27 May 2020 04:32:02 +0000 (13:32 +0900)]
cleanup: remove memory leak
Change-Id: I8d2a705d629eb7d8faa9b36798edfda7b1591445
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
sanghyeok.oh [Fri, 24 Apr 2020 11:53:08 +0000 (20:53 +0900)]
cleanup: convert local array into static variable
Local arrays are not a good option for recursive funtion
Change-Id: I94cd36fd873bd266a3effd978760f51a7c34498f
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Yunmi Ha [Mon, 18 May 2020 08:42:15 +0000 (17:42 +0900)]
Allow to use only filename in the except list
- When use filepath in the except list,
it will compare with full path of item.
- When use filename only in the except list,
it will compare without path of item.
Change-Id: If66104561e641ee8cfacb162147fe5786c513d15
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
sanghyeok.oh [Thu, 23 Apr 2020 07:21:14 +0000 (16:21 +0900)]
dbus: Fix wrong usage of GVariant
Change-Id: Ia0b20203a0b3e1ae45e4f0aa96dfd9501cc80bea
sanghyeok.oh [Tue, 28 Apr 2020 01:59:18 +0000 (10:59 +0900)]
Remove unnecessary code
Change-Id: Id97ff4a0bbfd2b6d6b9c06399a0d6bb05ac74707
Yunmi Ha [Tue, 28 Apr 2020 06:20:30 +0000 (15:20 +0900)]
cleanup: add log file for file space usage
- When cleanup is needed, save result of "du -ah" command.
- system type: "du -ah /opt/ > /var/log/storage/opt_full.log"
- user type: "du -ah /opt/usr/ > /var/log/storage/opt_usr_full.log"
Change-Id: I1c13873e88bb8305b038ba93604bc572f3e1b48b
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Yunmi Ha [Thu, 23 Apr 2020 09:10:11 +0000 (18:10 +0900)]
cleanup: apply 10mins interval
- When requesting the same or lower level of cleanup again
(warning->warning, full->critical or critical->warning),
do it at a specific interval (10 minutes).
- When requesting the higher level of cleanup again
(warning->critical or critical->full),
do it immediately.
Change-Id: I87adc82a6c761394ff1d876b2729202204441279
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Mon, 13 Apr 2020 03:40:30 +0000 (12:40 +0900)]
cleanup: Add "target" option for cleanup config
target has 3 options.
- all : delete all subfiles including the root path
- file : delete all subfiles excluding the root path
- oldfile : delete all old files which has "*.[0-9]" format
Change-Id: I4213be3c764272ebf2bed5e50c05f0d541ac88cc
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Fri, 21 Feb 2020 06:23:04 +0000 (15:23 +0900)]
Wait for releasing open files when BLOCK_UNMOUNT
Change-Id: I1cb8d450c48e138ae8410c9b06b390da07102ec7
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Yunmi Ha [Thu, 6 Feb 2020 07:55:03 +0000 (16:55 +0900)]
Fix svace issue
- Remove unreachable code
- Replace strtok to strtok_r
- Add initialize code
Change-Id: Ia17c0dbfc104b839b4debcb3140aa660563ad91d
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Mon, 6 Jan 2020 11:32:29 +0000 (20:32 +0900)]
block: Remove duplicated 'DeviceChanged2' dbus signal
- No one subscribes to the 'DeviceChanged2' signal.
- All data of the 'DeviceChanged2' signal is contained in
'DeviceChange' signal data.
Change-Id: I48e6ef3e8423ce856730d2c26087581cc4b384a8
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 24 Dec 2019 07:07:50 +0000 (16:07 +0900)]
Remove 'format-truncation' warning for GCC-9
Change-Id: I1ec0fe9415d76e0d6ce3539a7120fb0069e7f2b5
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 24 Dec 2019 02:16:00 +0000 (11:16 +0900)]
block: Move create file logic for block device
- After mount, create "/run/external-storage/id" file.
Change-Id: I7ba6f8fb94206d742742ac422adad8ce2526eec3
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 28 May 2019 08:09:53 +0000 (17:09 +0900)]
block: Add exfat filesystem for mount
Change-Id: I5874518a24b775a1181cb0e3d1220e0ceac15001
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Mon, 2 Dec 2019 01:57:01 +0000 (10:57 +0900)]
block: Improve stability of unmount
- Using AddPowerOffWait/RemovePowerOffWait method of deviced.
- Change unmount processing order
Change-Id: I8754f1d3b732f15c5aa77a2233d918578e9c2aae
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 26 Nov 2019 06:44:11 +0000 (15:44 +0900)]
[cleanup] fix printf format for size_t
Change-Id: I308f1bc1140f213fd54d7fc4f3bfabf8d3ca83a1
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Thu, 31 Oct 2019 05:28:24 +0000 (14:28 +0900)]
Add CleanupStorage Function
Refer to the config file,
delete the data according to the storage level.
config: /etc/storaged/cleanup-storage.conf
Change-Id: I589c7a03fa65ac17a62d12bcd301510485ea8731
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
INSUN PYO [Thu, 21 Nov 2019 05:48:25 +0000 (14:48 +0900)]
Remove default value at systemd services
https://www.freedesktop.org/software/systemd/man/systemd.service.html
- Behavior of notify is similar to exec; ... If NotifyAccess= is missing or set to none, it will be forcibly set to main.
Change-Id: Idc1402ee1322d87f2102c410c5b3f9839853d853
sanghyeok.oh [Fri, 16 Aug 2019 01:56:51 +0000 (10:56 +0900)]
dbus: modified to use renamed api
change 'dbus_handle_broadcast_dbus_signal' to 'dbus_handle_emit_dbus_signal'
Change-Id: I9833be576ed9f9fe37bae72b6aaa5f7440ffc7af
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
sanghyeok.oh [Wed, 14 Aug 2019 08:23:11 +0000 (17:23 +0900)]
dbus: modified to use revised api
Change-Id: I93d1ea9b078ce460dd869defcf5d72c82b6ae785
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Hyotaek Shim [Tue, 23 Jul 2019 02:51:40 +0000 (11:51 +0900)]
Fix WantedBy field in storaged.service
Change-Id: I286fdc9d645bd8ef43e0406d0cc113883a043646
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Mon, 8 Jul 2019 11:27:50 +0000 (20:27 +0900)]
Delete meaningless configuration
Change-Id: Id8f15543dd3431dfb85a4c4bcb7b4b289da5391c
sanghyeok.oh [Mon, 8 Jul 2019 08:06:53 +0000 (17:06 +0900)]
coverity fix
Change-Id: I79e8640d6ccbd0b810451ba284d23c042ff89c67
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
INSUN PYO [Wed, 26 Jun 2019 05:49:47 +0000 (14:49 +0900)]
Move storaged.service from multi-user.target to delayed.target
Change-Id: Id10bce3ae57d76c3cfc335a62b0de515038b0d19
INSUN PYO [Tue, 25 Jun 2019 02:49:19 +0000 (11:49 +0900)]
Remove unnecessary dependency from storaged.service
Change-Id: I1d83cc00e3952ec140a55b15294be1fb6d90dc3b
sanghyeok.oh [Wed, 12 Jun 2019 00:16:42 +0000 (09:16 +0900)]
block: dbus: (rework)modified to reply error type message if failed
- reply empty body gvariant if there are no matched device
- reply error type msg if error occured
Change-Id: Iec43b9c22284bb717939d219a3d7ac8f17d1be7e
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Hyotaek Shim [Mon, 10 Jun 2019 10:17:36 +0000 (10:17 +0000)]
Revert "block: dbus: modified to reply error type message if failed"
This reverts commit
bdbefcfd9dc654860f7988d69753b5159e1bfb86.
Change-Id: I44d2ed00df58ab2871a1f5c36870c44e3d2e0c30
sanghyeok.oh [Mon, 27 May 2019 06:42:45 +0000 (15:42 +0900)]
dbus-policy: modified to use default deny - allow signal
Change-Id: If756dfd5b399debde8ec3893b55084930c219e04
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
sanghyeok.oh [Tue, 14 May 2019 11:08:05 +0000 (20:08 +0900)]
block: add type converting function for enum block_device_type
Change-Id: I04d09f8639b1604d543f9746cfc926a87dd084e0
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
sanghyeok.oh [Fri, 10 May 2019 11:34:00 +0000 (20:34 +0900)]
block: dbus: modified to reply error type message if failed
gdbus method handler should reply g_variant with valid signature or error type message.
Change-Id: I00398b6d0614c5117ac5f0ac5801d504126721dd
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
sanghyeok.oh [Fri, 3 May 2019 05:22:54 +0000 (14:22 +0900)]
dbus-policy: rearrange policy
Just clean up. It doesn't change policy behavior.
Change-Id: I92dc171300c8ce15a172a7a2b9fbbab7d8fd1c27
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
INSUN PYO [Tue, 30 Apr 2019 04:29:49 +0000 (13:29 +0900)]
Fix problem that change smack lable of /run to "*"
Pre condition
- USB memory stick formatted with ext4.
- There should be no regular files.
Problem
- Smack lable of /run is changed to "*".
Cause
- "find $MOUNT_DIRECTORY -type f | xargs" return blank if there is no files.
- storaged runs on "/"
- "chsmack -a '*'" changes all files in the current directory.
Solution
- runs xargs with "-r" option.
- Man page of xargs: "If the standard input does not contain any nonblanks, do not run the command. Normally, the command is run once even if there is no input. This option is a GNU extension."
Change-Id: I642aaf84ea4752698eaa8be18fd105019779f86a
Hyotaek Shim [Mon, 22 Apr 2019 08:30:43 +0000 (17:30 +0900)]
Do not wait for System StartupFinished
1) udev event --> sysinit.target/systemd-udevd.service
2) /tmp --> sysinit.target
3) /opt --> sysinit.target or initrd
4) /opt/usr --> wait-mount@opt-usr.service
So, storaged does not need to wait for StartupFinished.
Without this patch, storaged cannot complete booting_done()
when even a single service unit fails.
dbus-send --system --print-reply
--type=method_call
--dest=org.freedesktop.systemd1
/org/freedesktop/systemd1
org.freedesktop.DBus.Properties.Get
string:"org.freedesktop.systemd1.Manager"
string:"SystemState"
variant string "starting"
Change-Id: I7275cc91e1904600f0c0a7cd7ac2dd243e15922b
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Yunmi Ha [Thu, 11 Apr 2019 08:46:41 +0000 (17:46 +0900)]
Add systemd state checking logic
If system session is already running,
storaged can't receive StartupFinished signal.
In that case, add logic to check the systemd state at startup.
Change-Id: Ied8af322c1e8d4e5e34ea84f2e1c8f968c56a733
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Wed, 10 Apr 2019 08:24:52 +0000 (17:24 +0900)]
Change libgdbus library name to libsyscommon.
Change-Id: Ie86ed9961540c81f9301088b098ad00ef1e9a203
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 9 Apr 2019 05:29:15 +0000 (14:29 +0900)]
block: Added logic to wait for thread processing on exit
If the thread has remain job when it exit,
it need to wait for finishing it.
Change-Id: I09aba16ee427222537d279487711a4ecfbaff795
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 26 Feb 2019 09:27:04 +0000 (18:27 +0900)]
Restore permission of source files.
Change-Id: If50fc0975bd053d71a7fdbc49d22c0822dbb483d
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 26 Feb 2019 02:46:06 +0000 (11:46 +0900)]
Apply consistent log messages.
1. First letter to uppercase.
2. Period at the end.
3. Rearrange parameters.
Change-Id: I6705c61a5d03c99b2371a5df0d76eafa29e39526
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
pr.jung [Fri, 15 Feb 2019 08:57:38 +0000 (17:57 +0900)]
Modify external-storage and extended-internal-sd directory paths
Change-Id: Ibb92488d33812d8d0ff3fecd9c0e4016a44aa064
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Thu, 14 Feb 2019 05:27:01 +0000 (14:27 +0900)]
Avoid TOCTOU condition
- chmod() did't change smack label of already existing directory.
- remove() can't remove not empty directory
Change-Id: I801ecfaf5df86122fb553891598d7b27b43069e3
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Wed, 30 Jan 2019 08:35:27 +0000 (17:35 +0900)]
storaged could cause heap use after free
- Call free() on remove_operation()(Thread)
- Access op->op on add_operation()(Main thread)
Change-Id: Iee3b3a545a04889d79f1d696dadce9d842769259
Signed-off-by: pr.jung <pr.jung@samsung.com>
lokilee73 [Thu, 27 Dec 2018 02:59:13 +0000 (11:59 +0900)]
Remove executable flag from non-executable files
Change-Id: Icd5e1876b505bb4e4cc5f7d513ab0ec60abbc761
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
pr.jung [Mon, 17 Dec 2018 10:50:08 +0000 (19:50 +0900)]
storage: Add popup and notification as well
Change-Id: Ide44a71213baa09e4122c61030c4388b03f65e43
Signed-off-by: pr.jung <pr.jung@samsung.com>
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
(cherry picked from commit
663b8496576b7761ed4b1ae3a7db7b0eab7e6924)
pr.jung [Fri, 14 Dec 2018 04:37:04 +0000 (13:37 +0900)]
dlog: Fix dlog format errors
Change-Id: I9fc9cbdbb7d52aff3de8bcaf23a475b840284ffe
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Fri, 7 Dec 2018 06:28:20 +0000 (15:28 +0900)]
dlog: Fix dlog format errors
Change-Id: I0e8141da652a5c6db57455740f5cb0e09e646c13
Signed-off-by: pr.jung <pr.jung@samsung.com>
Pawel Kowalski [Thu, 16 Aug 2018 10:49:27 +0000 (12:49 +0200)]
Add Apache 2.0 license headers
Change-Id: I52155a8b06a6cc9f2a476d5ec76763051d9c7443
pr.jung [Thu, 26 Jul 2018 08:48:32 +0000 (17:48 +0900)]
Add GetStorageLevel dbus method
Change-Id: I07bff489585935b5a533f010ae79c4e91d72cc65
Signed-off-by: pr.jung <pr.jung@samsung.com>
Hyotaek Shim [Fri, 6 Jul 2018 04:31:48 +0000 (13:31 +0900)]
Change watchdog timeout from 30 sec. to 90 sec.
It has been observed,
after a long suspend timeout/delay, Systemd may kill processes by Watchdog timeout as soon as it is thawed.
This is a workaground patch to avoid such a problem.
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] Freezing of tasks failed after 20.006 seconds (1 tasks refusing to freeze, wq_bu$
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] shealth-exercis D 0 16604 3220 0x00400209
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] Call trace:
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff8008085b70>] __switch_to+0x8c/0xa0
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff80088d4720>] __schedule+0x37c/0x72c
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff80088d4bcc>] schedule+0x8c/0xac
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff80088d786c>] schedule_timeout+0x148/0x38c
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff8008439f78>] kbase_destroy_context+0x394/0x448
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff80084465d4>] kbase_release+0xf4/0x158
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff80081ded58>] __fput+0xf4/0x1a8
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff80081dee68>] ____fput+0xc/0x14
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff80080bd378>] task_work_run+0xbc/0xe8
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff80080891a0>] do_notify_resume+0x80/0x90
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff8008082f8c>] work_pending+0x8/0x10
...
Jul 05 14:37:25 localhost systemd[1]: storaged.service: Watchdog timeout (limit 30s)!
Jul 05 14:37:25 localhost systemd[1]: storaged.service: Killing process 3092 (storaged) with signal SIGABRT.
Change-Id: I4ce6d243dca5b30bc8a6f7cd526c724227dbfcdf
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
sanghyeok.oh [Tue, 3 Jul 2018 06:29:05 +0000 (15:29 +0900)]
svace fix
Change-Id: I35d4440f60d1ef2468bd07a7afea1545c5178ded
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
pr.jung [Mon, 25 Jun 2018 04:58:09 +0000 (13:58 +0900)]
storage: Change NeedCleanup signal from "ss" to "is"
- Change NeedCleanup signal "ss" to "is"
Path is sent by tzplatform_variable enum
- Remove Full and ChangeState signals
Change-Id: Iac9f52b5ef7d03f6bdd38be7bcf29393f310a87d
Signed-off-by: pr.jung <pr.jung@samsung.com>
lokilee73 [Thu, 21 Jun 2018 07:34:30 +0000 (16:34 +0900)]
Fix dbus returned error by unmatched signature between storaged and system-popup
Change-Id: Iecf6cd5c6f57484b813bd9983bf9a5af0975714c
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
pr.jung [Wed, 20 Jun 2018 05:00:07 +0000 (14:00 +0900)]
storage: Add new dbus method "GetStorageLevel"
- input: "i"
TZ_SYS_USER, TZ_SYS_OPT, TZ_SYS_TMP
- output: "s"
normal, warning, critical, full, and error message
Change-Id: I3954776c0f156bdbae43332393b62a55016eb015
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Tue, 12 Jun 2018 09:34:38 +0000 (18:34 +0900)]
storage: Write file when storage status is changed
- /run/storaged/needcleanup/trigger
Change-Id: Ie48cb6020670e321a54771def0a4a40331df6152
Signed-off-by: pr.jung <pr.jung@samsung.com>
Hyotaek Shim [Thu, 21 Jun 2018 02:33:29 +0000 (11:33 +0900)]
Boot optimization: add systemd unit dependency, After=dbus.service deviced.service
Change-Id: I1a6d22fdc5480310d17934c4071b554746ac034c
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Thu, 7 Jun 2018 08:30:50 +0000 (17:30 +0900)]
storage: Check /opt partition storage size and add NeedCleanup signal
- Check /opt/usr, /tmp, /opt size
- Broadcast NeedCleanup signal when memory level is changed
normal -> warning/critical/full
warning -> critical/full
critical -> full
Change-Id: I39d42624be0dbe4923f79c5e744502f2661a2103
Signed-off-by: pr.jung <pr.jung@samsung.com>
sanghyeok.oh [Thu, 17 May 2018 04:50:30 +0000 (13:50 +0900)]
dbus-policy: change to default deny policy
Change-Id: I747566fac4beaf96dc72dbc962231b974e84930c
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Hyotaek Shim [Mon, 14 May 2018 00:26:11 +0000 (09:26 +0900)]
block: Change file permission to "rw-rw-rw-" in vfat external storage
Change-Id: If37a891c911401308e906d2fb2ea14fef7881546
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Tue, 8 May 2018 07:32:18 +0000 (16:32 +0900)]
block: When block device is not found, GetDeviceInfo return with id less than 0
Change-Id: Ic434c6dc0e52625d772e8a9a8c172a8d01dcf182
Signed-off-by: pr.jung <pr.jung@samsung.com>
Hyotaek Shim [Mon, 30 Apr 2018 11:42:12 +0000 (20:42 +0900)]
Add .gitignore
Change-Id: Ia28aca5d442dbf585f70fb94063057d830a66f47
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Mon, 30 Apr 2018 10:56:58 +0000 (19:56 +0900)]
Fix systemd-assisted dbus activation sequence
Change-Id: I6d3ddd8a9673957156f23f8fbd410adce5dd03cb
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
sanghyeok.oh [Tue, 10 Apr 2018 07:42:56 +0000 (16:42 +0900)]
svace fix
Change-Id: Ied1b5ed5a994f53e216e7d8f7105b28623031200
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
lokilee73 [Thu, 5 Apr 2018 04:42:37 +0000 (13:42 +0900)]
fix a compile error
Change-Id: I963a1f94d45c84d84fa781bed22b070ddad834d1
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
lokilee73 [Wed, 4 Apr 2018 12:44:46 +0000 (21:44 +0900)]
Refactor dbus_handle_init into two parts
It's to apply a fix in deviced which timing issue happend by telephony.
When telephony requests AddPoweroffWait, it fails because dbus in deviced is not ready.
Change-Id: I7b333f0a43965ac75ccccf03262fae44dbea66ce
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
Hyotaek Shim [Tue, 3 Apr 2018 08:34:11 +0000 (17:34 +0900)]
Apply Full RELRO linker options ("-Wl,-z,relro,-z,now") to storaged
In addition to Partial RELRO, Full RELRO makes "GOT Table becomes read-only."
Change-Id: I1b946a542281a4b62f578d843189f768d3a6f72c
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Fri, 23 Mar 2018 09:58:14 +0000 (18:58 +0900)]
libgdbus: Change dbus methods to use libgdbus
Change-Id: I91baa9945d6351fbc99a832f4847a25ce4ef0c9e
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Thu, 22 Mar 2018 05:01:21 +0000 (14:01 +0900)]
libgdbus: Move common gdbus interfaces to libsystem package
Change-Id: Icc59a49192a4a5a9f1392eb44a2a7551ecf6ba4d
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Thu, 15 Mar 2018 04:30:16 +0000 (13:30 +0900)]
block: Add mmc inserted & removed popup
- Launch notice popup when mmc is mounted and unexpectedly removed
Change-Id: I0978c2bb8eee80129490065bac1749cf03883674
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Tue, 13 Mar 2018 11:26:19 +0000 (20:26 +0900)]
block: Fix code to be more readable
Change-Id: I413ad40cb7cd633f5ad2f2af3af4343e9e497e79
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Tue, 13 Mar 2018 10:47:02 +0000 (19:47 +0900)]
block: Change external storage permission to 777
- Directory permission is 777, uid is root groupid is priv_externalstorage
- security-manager will handle access control for external storage
- When externalstorage privilege is configured as privacy,
security framework will enforce this privilege with different mechanism - per-application mount namespace.
In such case mount options must be different to allow all users and groups access to mount point.
If an application is not supposed to have access to externalstorage,
security-manager will mount a special directory over sdcard mount point.
In such case access control is no longer based on GID,
so mount options must allow application access regardless of its groups.
Change-Id: I1582d3afd70354cc81d7142fee4c9edf4c94ef30
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Tue, 13 Mar 2018 02:24:28 +0000 (11:24 +0900)]
block: Remove memset
Change-Id: I758bed8d6bbd08425135ea2461ffe4717925f01b
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Mon, 12 Mar 2018 08:59:35 +0000 (17:59 +0900)]
block: Create default directory for mmc
- Create default directories (Images, Videos, Sountds, Downloads) for primary sdcard
Change-Id: If3cb0d66ad41d13c05a00dfc85256f8eabafc8b3
Signed-off-by: pr.jung <pr.jung@samsung.com>
Hyotaek Shim [Wed, 7 Mar 2018 23:50:30 +0000 (08:50 +0900)]
Minor fixes: chmod files, rename dbus conf file, etc.
Change-Id: Ia23bfea0d18dd65f9c3a7a504f0b7b4817980d89
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
sanghyeok.oh [Mon, 5 Mar 2018 13:23:51 +0000 (22:23 +0900)]
dbus: modify dbus policy correctly
Change-Id: I3d26b9ed55aa7462e3fa4fe3ff44a1578f595a4d
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
pr.jung [Tue, 27 Feb 2018 09:08:34 +0000 (18:08 +0900)]
block: Add GetStatvfs dbus method
Change-Id: I2d6f6fa61a8785638624e93ee02992c880da3f70
Signed-off-by: pr.jung <pr.jung@samsung.com>
Hyotaek Shim [Mon, 5 Mar 2018 11:45:26 +0000 (20:45 +0900)]
Add compile options: -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
Change-Id: Ieb40d80c30668673177f6ccee9e580d79b62ef6e
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Tue, 20 Feb 2018 05:50:02 +0000 (14:50 +0900)]
auto-test: Add auto-test for storaged
Change-Id: I272e1c869628569663da76aa377892a58a5042ba
Signed-off-by: pr.jung <pr.jung@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Mon, 26 Feb 2018 11:05:44 +0000 (20:05 +0900)]
Change speedcheck methods by using O_DIRECT read operations
to prevent corruption in existing filesystem on MicroSD card.
Further work might be required to consider optimized zero-page reads in several MicroSD cards.
Change-Id: Ic26f9c3c5396bbad7b21683d1b08a72c6a8404a3
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Fri, 9 Feb 2018 06:05:28 +0000 (15:05 +0900)]
block: Fix dbus method string format for GetControl
Change-Id: Iff6538b88827af03d9622d62dcfa650d78ce2a1c
Signed-off-by: pr.jung <pr.jung@samsung.com>