Bowon Ryu [Thu, 10 Oct 2019 12:05:11 +0000 (21:05 +0900)]
edje_entry: support "preedit_hilight" tag
separate "reverse" and "highlight" by VD request
@tizen_fix
Change-Id: I8d0221de8b321c84800924f4f729756632ac6648
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Marcel Hollerbach [Thu, 5 Sep 2019 13:51:05 +0000 (15:51 +0200)]
introduce script that generates widget hirachy
this scripts generates a .svg with a hirachy like:
https://phab.enlightenment.org/file/data/jtiilbekufvfa77taf5y/PHID-FILE-5iwtamur4qxtktrcwh77/widget_hirachy.png
blue means something is stable, red means, something is beta.
This script requires ete3 to be installed. You can install it via with
pip with: `pip install ete3`
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9850
Mike Blumenkrantz [Wed, 9 Oct 2019 17:22:44 +0000 (13:22 -0400)]
examples/emotion: remove dead code
this can never be reached
CID 1400928
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10322
Mike Blumenkrantz [Wed, 9 Oct 2019 17:07:24 +0000 (13:07 -0400)]
tests/position_manager: initialize variable in declaration
this member is never used anywhere, but it creates a CID
CID 1404747
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10319
Mike Blumenkrantz [Wed, 9 Oct 2019 17:19:36 +0000 (13:19 -0400)]
efl_ui/selection_manager: be explicit with sizeof() usage
Summary:
ensure we don't have issues with portability and type sizes
CID 1385141
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10201
Lauro Moura [Wed, 9 Oct 2019 14:39:38 +0000 (16:39 +0200)]
csharp: Respect beta for type aliases
Summary: Also add beta info to `alias_def` in eolian_cxx.
Reviewers: brunobelo, felipealmeida, woohyun, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10315
Xavi Artigas [Wed, 9 Oct 2019 14:18:14 +0000 (16:18 +0200)]
mono-docs: Merge Property and getter/setter docs
Summary:
Property docs, when present, should always be included in Property and Accessor
(setter and getter) docs.
Accessor docs, when present, should be included in their accessor method, and
also in the property method, as a side note.
This patch does just that.
Depends on D10285
Ref T8309
Test Plan: Generate docs and take a look at `Efl.Ui.Calendar`, for example, which has a bit of everything.
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8309
Differential Revision: https://phab.enlightenment.org/D10298
Lauro Moura [Mon, 7 Oct 2019 08:51:36 +0000 (10:51 +0200)]
eolian: Leave default text for libeolian users
Summary:
Instead of setting the default text at the library level, keep the
summary empty if nothing is provided.
The libeolian users them are free to check if the summary was actually
empty or a placeholder text was added.
ref T8309
Test Plan: Run attached tests
Reviewers: q66, segfaultxavi
Subscribers: cedric, brunobelo, #reviewers, felipealmeida, #committers
Tags: #efl
Maniphest Tasks: T8309
Differential Revision: https://phab.enlightenment.org/D10285
Daniel Kolesa [Wed, 9 Oct 2019 11:19:50 +0000 (13:19 +0200)]
elua: fix error api in lua eolian bindings
Bruno da Silva Belo [Wed, 9 Oct 2019 01:05:34 +0000 (22:05 -0300)]
csharp: updating eina_binbuf docs and hide api.
Reviewers: felipealmeida, lauromoura, segfaultxavi, woohyun
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10310
Bruno da Silva Belo [Wed, 9 Oct 2019 00:49:04 +0000 (21:49 -0300)]
csharp: updating eina_accessor docs and hide api.
Reviewers: felipealmeida, lauromoura, segfaultxavi, woohyun
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10308
Bruno da Silva Belo [Tue, 8 Oct 2019 21:01:11 +0000 (18:01 -0300)]
csharp: removing extra //
Summary: dotnet warning about extras /
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10282
Lauro Moura [Tue, 8 Oct 2019 20:56:37 +0000 (17:56 -0300)]
csharp: Do not use the System Bus for testing.
Summary: To allow the C# bindings running on the CI
Reviewers: zmike, brunobelo, felipealmeida, segfaultxavi, stefan_schmidt
Reviewed By: stefan_schmidt
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8313
Differential Revision: https://phab.enlightenment.org/D10283
Dave Andreoli [Tue, 8 Oct 2019 20:50:55 +0000 (22:50 +0200)]
Pyolian: rewritten tests for the pytest framework
...much more readable now, worst the pain! :)
Mike Blumenkrantz [Tue, 8 Oct 2019 14:49:02 +0000 (16:49 +0200)]
efl_ui/container: remove erroneous negative value checks for uint params
Summary:
../src/lib/elementary/efl_ui_box.c: In function ‘_efl_ui_box_efl_gfx_arrangement_content_padding_set’:
../src/lib/elementary/efl_ui_box.c:411:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limit ]
411 | if (h < 0) h = 0;
| ^
../src/lib/elementary/efl_ui_box.c:412:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limit ]
412 | if (v < 0) v = 0;
| ^
../src/lib/elementary/efl_ui_table.c: In function ‘_efl_ui_table_efl_gfx_arrangement_content_padding_set’:
../src/lib/elementary/efl_ui_table.c:272:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
272 | if (h < 0) h = 0;
| ^
../src/lib/elementary/efl_ui_table.c:273:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
273 | if (v < 0) v = 0;
| ^
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10304
JunsuChoi [Tue, 8 Oct 2019 09:13:43 +0000 (18:13 +0900)]
evas_vg_cache: Hashkey of cache use value provider list
Summary:
Even if the same window, the same file, and the same size,
different images may be requested due to property changes caused by value_provider.
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10303
Change-Id: I7e079a488002c4b17614a823f9138af2eee5c540
Lauro Moura [Tue, 8 Oct 2019 08:04:57 +0000 (10:04 +0200)]
csharp: Add some docs to MVVM infrastructure
Reviewers: SanghyeonLee, felipealmeida, cedric, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10301
JunsuChoi [Tue, 8 Oct 2019 09:13:43 +0000 (18:13 +0900)]
evas_vg_cache: Hashkey of cache use value provider list
Summary:
Even if the same window, the same file, and the same size,
different images may be requested due to property changes caused by value_provider.
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10303
Change-Id: I9044287005ab897dab654fd47eb3f88c0c34453b
Yeongjong Lee [Mon, 7 Oct 2019 09:45:37 +0000 (18:45 +0900)]
elm_widget: Add a API to raise focus_order.
This patch will fix genlist center align issue.
```
Elm_Genlist_Item_Class itc, ctc;
static Evas_Object*
_gl_check_get(void *data, Evas_Object *obj, const char *part)
{
if (strcmp(part, "elm.icon")) return NULL;
Evas_Object *content = elm_check_add(obj);
elm_object_style_set(content, "on&off");
elm_check_state_set(content, EINA_FALSE);
evas_object_show(content);
return content;
}
void
_btn_cb(void *data, Evas_Object *obj, void *event_info)
{
Evas_Object *nf = data;
Evas_Object *btn = elm_button_add(nf);
evas_object_size_hint_weight_set(btn, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(btn, EVAS_HINT_FILL, EVAS_HINT_FILL);
elm_object_text_set(btn, "button");
elm_naviframe_item_push(nf, "Default Styles", NULL, NULL, btn, NULL);
}
static void
create_list_view(appdata_s *ad)
{
Evas_Object *nf = ad->nf;
Evas_Object *genlist = elm_genlist_add(nf);
elm_genlist_mode_set(genlist, ELM_LIST_COMPRESS);
evas_object_smart_callback_add(genlist, "selected", gl_selected_cb, NULL);
itc.item_style = "1text.1icon";
itc.func.text_get = _gl_text_get;
ctc.item_style = "1text.1icon.1";
ctc.func.text_get = _gl_check_text_get;
ctc.func.content_get = _gl_check_get;
elm_genlist_item_append(genlist, &itc, NULL, NULL, ELM_GENLIST_ITEM_NONE, _btn_cb, nf);
elm_genlist_item_append(genlist, &itc, NULL, NULL, ELM_GENLIST_ITEM_NONE, _btn_cb, nf);
// item with check
elm_genlist_item_append(genlist, &ctc, NULL, NULL, ELM_GENLIST_ITEM_NONE, NULL, NULL);
elm_genlist_item_append(genlist, &itc, NULL, NULL, ELM_GENLIST_ITEM_NONE, _btn_cb, nf);
elm_genlist_item_append(genlist, &itc, NULL, NULL, ELM_GENLIST_ITEM_NONE, _btn_cb, nf);
elm_naviframe_item_push(nf, NULL, NULL, NULL, genlist, "empty");
}
```
Test Plan
1. Click on&off check widget.
2. Click text item below. (button view is pushed.)
3. Click back button.
4. Check that genlist item keep center align
@tizen_fix
Change-Id: Ie0946b65d952d51c0204c5b5d82660ac3887d7f0
Yeongjong Lee [Tue, 8 Oct 2019 02:42:41 +0000 (11:42 +0900)]
tizen_genlist: restore legacy focus
@tizen_fix
Change-Id: I7fe206f1bcda94deeecc2214e13e91ac2c568b92
Dave Andreoli [Mon, 7 Oct 2019 20:38:04 +0000 (22:38 +0200)]
Pyolian: implement some missing eolian functions
with tests
Dave Andreoli [Mon, 7 Oct 2019 19:17:10 +0000 (21:17 +0200)]
Pyolian gendoc: make link to events actually work
Dave Andreoli [Mon, 7 Oct 2019 18:32:05 +0000 (20:32 +0200)]
Pyolian gendoc: use some aux eolian functions to simplify templates
Dave Andreoli [Mon, 7 Oct 2019 17:38:50 +0000 (19:38 +0200)]
Pyolian gendoc: add ability to generate only the stable API
gendoc.py --exclude-beta
generate the docs excluding all the classes/types/etc in beta state,
a bit hackish but do the job. There are some broken links around that
refer to objects in beta state that are (correctly) not generated,
nothing we can do to fix this.
Mike Blumenkrantz [Mon, 7 Oct 2019 16:49:19 +0000 (18:49 +0200)]
efl_ui/win: initialize max size hints to -1 during constructor
Summary:
this is just a cosmetic change for ease of debugging since it will already
be clamped to max size during eval if it remains unchanged
for max size hints a value of -1 means that the hint is unset but a value
of 0 is technically valid depending on the implementation
Depends on D10296
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10297
Mike Blumenkrantz [Mon, 7 Oct 2019 16:40:10 +0000 (18:40 +0200)]
efl_ui/win: fix max size hint eval
Summary:
win objects should never permit the max size on any axis to be 0, otherwise
the window will be clamped to 1px on the given axis
fixes T8304
@fix
Depends on D10272
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8304
Differential Revision: https://phab.enlightenment.org/D10296
Mike Blumenkrantz [Mon, 7 Oct 2019 16:40:09 +0000 (18:40 +0200)]
ci: fix return value warning in test build code
Summary: this is a void function
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10272
Xavi Artigas [Mon, 7 Oct 2019 14:40:50 +0000 (16:40 +0200)]
docs: Remove redundant documentation
Lots of EO files had the same information at the property and set/get level.
Removed the redundant bits, and moved to the property level the common ones.
Set and Get documentation should be used only to clarify setter-only or
getter-only behavior.
Cedric BAIL [Mon, 7 Oct 2019 14:04:18 +0000 (10:04 -0400)]
eldbus: properly cleanup local variable during destruction.
Summary: Depends on D10288
Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt, jsuya
Reviewed By: zmike
Subscribers: ProhtMeyhet, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10289
Cedric BAIL [Mon, 7 Oct 2019 14:04:12 +0000 (10:04 -0400)]
eldbus: connection are destroyed on invalidate, there is no point for any object to not cleanup on invalidate.
Summary:
This solve a bug when there is a change in order of destruction and you would expect the model to still work.
Depends on D10287
Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt, jsuya
Reviewed By: bu5hm4n
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10288
Cedric BAIL [Mon, 7 Oct 2019 14:04:05 +0000 (10:04 -0400)]
eldbus: Eldbus_Proxy require to handle self desctruction as refcounting doesn't fully protect.
Summary:
If the connection is destroyed before the proxy, the proxy will clear itself and self destroy.
Before that it will trigger the free callback to handle proper cleanup. Refcounting it doesn't
protect it from this self destruction scenario. So it is mandatory to always have a free callback
set on a proxy to handle its death properly.
Depends on D10286
Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt, jsuya
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10287
Cedric BAIL [Mon, 7 Oct 2019 14:03:58 +0000 (10:03 -0400)]
eldbus: properly call parent finalize during creation of Eldbus.Model_Method.
Summary: @fix
Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt, jsuya
Reviewed By: bu5hm4n
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10286
Marcel Hollerbach [Mon, 7 Oct 2019 13:38:25 +0000 (09:38 -0400)]
efl_test_multi_selectable: ensure consistant state across mode switch
Summary:
When we are in multi, and switch back to single or none, we should
ensure that the state is corrently. Same applies to single -> none.
Reviewers: segfaultxavi, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10277
WooHyun Jung [Mon, 7 Oct 2019 13:38:14 +0000 (09:38 -0400)]
efl_ui_image: fix backward compatibility issue
Summary:
Previously, "anim" property was saved before checking
evas-image's "animated" stated. This patch just corrects
the issue.
Reviewers: zmike, bu5hm4n, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10293
Marcel Hollerbach [Mon, 7 Oct 2019 13:38:12 +0000 (09:38 -0400)]
efl_ui_spec: introduce tests that ensure we are not leaking objects
Summary:
with those two tests we are checking two things:
- Check that there is no left out canvas object after the widget is
invalidated but not deleted. For now this only deals with canvas
objects.
- Additionally this also ensures that ref;del;unref as well as simple
del is never ever going to end up in a error, even with children beeing
added.
This pretty much mirrors the tests for legacy in
0d48cb46d45184608bbbbafa298f0f719e35688f , except that these tests do
not check for evas parent contsruction vs. real widget parent
construction. Which is intendet, as none-legacy widgets do error out
when a not widget object is passed as parent.
Depends on D10291
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10292
Marcel Hollerbach [Mon, 7 Oct 2019 13:38:05 +0000 (09:38 -0400)]
efl_ui_datepicker: no need to delete the manager here
Summary:
it is already picked up when datetime is invalidated, due to the correct
parent beeing set.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10291
Bruno da Silva Belo [Mon, 7 Oct 2019 13:02:10 +0000 (09:02 -0400)]
c: coverity: resource leaked when using realloc.
Summary:
from https://en.cppreference.com/w/c/memory/realloc
```
On success, returns the pointer to the beginning of newly allocated memory.
To avoid a memory leak, the returned pointer must be deallocated with free()
or realloc(). The original pointer ptr is invalidated and any access to it
is undefined behavior (even if reallocation was in-place).
On failure, returns a null pointer. The original pointer ptr remains valid
and may need to be deallocated with free() or realloc(). ```
So a temporary to test if `realloc` failed
then use the original pointer to use `free`.
`CID1404749`
`CID1404741`
Reviewers: lauromoura, felipealmeida, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10284
Stefan Schmidt [Mon, 7 Oct 2019 08:55:02 +0000 (10:55 +0200)]
evil: make it clear in the docs that this library is private to efl
Since the 1.23 release we are stricter with the use of evil. It is
supposed to be used inside efl only and not exposed as API. Make this
clear in the docs as well.
Reviewed-by: Vincent Torri <vincent.torri@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10295
Stefan Schmidt [Fri, 4 Oct 2019 09:15:12 +0000 (11:15 +0200)]
evil: remove stray x character from docs section
Reviewed-by: Vincent Torri <vincent.torri@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10294
Stefan Schmidt [Wed, 2 Oct 2019 10:23:38 +0000 (12:23 +0200)]
evil: bring back doxygen intro page for evil library
While we switched evil to be not a public AP, but internal lib only, we
still want to have its documentation shown.
Reviewed-by: Vincent Torri <vincent.torri@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10270
Jongmin Lee [Mon, 7 Oct 2019 06:59:18 +0000 (15:59 +0900)]
ecore : fix incorrect size of expression for coverity
Summary: correct bad use of sizeof function (detected by coverity tool)
Test Plan: N/A
Reviewers: Hermet, woohyun, kimcinoo, cedric, jsuya
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10281
Change-Id: I90f034dd46c88a332c089af324df406a7600bb29
Taehyub Kim [Mon, 7 Oct 2019 12:18:55 +0000 (21:18 +0900)]
elc_popup: modified theme set logic correctly when button is removed
Change-Id: Iae86c4d72425e33e1b32946d219de600bae6d86e
WooHyun Jung [Mon, 7 Oct 2019 07:15:45 +0000 (16:15 +0900)]
edje_util: restore tizen only APIs to legacy edje_util
Several tizen only APIs should not be opened with new efl interface.
This patch restores them to the original location(i.e edje_util).
Plus, Edje_Cursor is also restored back to Edje_Common.h
@tizen_fix
Change-Id: I3a2b0a96256bfe73e81cb482a9591529af95d5a2
Shinwoo Kim [Fri, 4 Oct 2019 01:42:38 +0000 (10:42 +0900)]
ecore_evas: handle async render for output transform
The commit e50628d "ecore_evas: support output transform" did not take care of
async render. So following issue occured.
[Issue]
At _evas_outbuf_idle_flush which could be called by,
_ecore_evas_wl_common_rotate_update -> _rotation_do -> evas_engine_info_set
-> efl_canvas_output_engine_info_set -> eng_output_update
-> eng_output_resize -> _evas_outbuf_reconfigure -> _evas_outbuf_idle_flush
if Outbuf->priv.onebuf is not NULL, we drop RGBA_Image->cache_entry.
But this means that there is a draw command in evas_thread_cmd queue.
So it could be possible a thread could access RGBA_Image->image.data after it
is set to NULL by _evas_outbuf_idle_flush which is calling
_evas_cache_image_entry_delete -> _evas_common_rgba_image_surface_delete
[Solution]
This patch makes _ecore_evas_wl_common_rotate_update wait for the end of
queued draw command running on a thread before calling _rotation_do.
*tizen_fix
Change-Id: Ia7d5eea2bfae9e64443f2b093e3613cf492e743f
Wonki Kim [Fri, 4 Oct 2019 02:23:35 +0000 (11:23 +0900)]
eina: turn magic check on for eina_list
after disabling eina_magic_check,
a issue that is hard to tracable comes.
this patch re-enables eina_magic check temporally until the issue gets fixed
Change-Id: I7a280d48b68f4c5d8e22cb63fca76cf165ee2439
Jongmin Lee [Sun, 6 Oct 2019 21:32:13 +0000 (06:32 +0900)]
build - remove evas-modules option
@tizen_fix
Change-Id: I534de0cb67f6add0159c4ffee1049d44f5f7f8ff
Carsten Haitzler (Rasterman) [Sat, 5 Oct 2019 19:00:38 +0000 (20:00 +0100)]
build - efl run in tree - make exception for image loaders/savers
due to meson's insistence on naming even moudles libmodule.so, and our
complexity of build as in the previous commits ... have a special case
for in tree module loading for these.
Carsten Haitzler (Rasterman) [Sat, 5 Oct 2019 17:35:00 +0000 (18:35 +0100)]
build - images loaders and saver modules need to link to evas
if your platform is picky enough it won't want to leave unresolved
symbols (which wshould be resovled at runtime from the host lib) so we
need to link these modules to evas. the problem is due to the
complicated build of some modules being static and some shared, evas
is declared with evas_goal and this has to be declared after static
modules are declared but since i was declaring static and shared at
the same time from a table this breaks. so i have to move all the
static and shared module stuff into evas_goal into 2 phases. one phase
for the static and one for the shared after evas is delcared so evas
as a target exists to link to.
Carsten Haitzler (Rasterman) [Sat, 5 Oct 2019 12:14:39 +0000 (13:14 +0100)]
build - bring back loaders and savers as modules and/or static
so the evas modules able to be static or not was a bit pointless as it
could inline all evas modules (or none) not just the most common or
not, but ecore evas modules were still modules, so it really wasn't
being useful.
image loaders ans savers omn the other hand were *ALL* being
statically built in without exception. this was kind of a regression
in the build system in the move to meson. some were static due to
micro optimizations and performance inlining the most common to save a
little extra loading + linking + page fragmentation for loaders you
are likely to need in most cases as well as save the drity pages from
linking in their dependencies (libgif, libtiff, libwebp and all their
dependencies too etc. etc.). this now brings back the ability to
decide which are static and which are shared modules (not exposed to
the user as options for meson - fixed in meson.build files which i
think is good enough given the purpose of this).
Dave Andreoli [Sat, 5 Oct 2019 10:20:44 +0000 (12:20 +0200)]
Pyolian gendoc: the last hidden bits of documentation ref tokens
Now links works also inside documentation text \o/
Dave Andreoli [Sat, 5 Oct 2019 08:30:34 +0000 (10:30 +0200)]
Pyolian gendoc: highlight classes in beta state
Dave Andreoli [Sat, 5 Oct 2019 07:32:35 +0000 (09:32 +0200)]
Pyolian gendoc: more links to types
need to fix links to Eina types and basic types
Lauro Moura [Thu, 3 Oct 2019 23:52:25 +0000 (20:52 -0300)]
csharp: Move locks inside AddRemove native handlers
Summary:
Instead of using a lock block in every method definition, we just need
them inside the actual methods adding/removing the handlers.
Kudos to @herb for the suggestion.
Reviewers: felipealmeida, herb, brunobelo
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, herb, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9758
Carsten Haitzler (Rasterman) [Fri, 4 Oct 2019 12:16:02 +0000 (13:16 +0100)]
build - remove evas-modules option as its rather pointless
evas-modules affects evas engine modules if they are static or shared,
but ecore evas modules are still modules... so all in all this doesnt
help much as it still requires modules to be separate from the shared
libs, thus disallowing for statically linking efl into an app anyway
etc. etc. etc. ... so less options to deal with, less complexity.
better.
Stefan Schmidt [Wed, 2 Oct 2019 14:25:03 +0000 (16:25 +0200)]
efl_ui_video: bring back Elm_video doxygen group for docs
This group got lost at some point and resulted in broken link in our
doxygen documentation.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10273
Stefan Schmidt [Wed, 2 Oct 2019 12:56:22 +0000 (14:56 +0200)]
docs: fix elementary group name in docs
Use aliase for group name for a better look.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10271
Bruno da Silva Belo [Fri, 4 Oct 2019 06:46:29 +0000 (08:46 +0200)]
csharp: Standardizing doc tag.
Reviewers: felipealmeida, brunobelo, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10280
JunsuChoi [Fri, 4 Oct 2019 01:05:45 +0000 (10:05 +0900)]
efl_ui_animation_view : Put @beta on Efl.Ui.Animation_View_State
Summary: Efl.Ui.Animation_View class still in beta state.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10268
Dave Andreoli [Thu, 3 Oct 2019 20:40:16 +0000 (22:40 +0200)]
Pyolian gendoc: make links to functions actually work
Dave Andreoli [Thu, 3 Oct 2019 18:18:54 +0000 (20:18 +0200)]
Pyolian gendoc: unbreak after recent eolian changes
shiny new generated documentation can be seen at:
www.gurumeditation.it/dokuwiki_efl/
Mike Blumenkrantz [Thu, 3 Oct 2019 12:01:35 +0000 (14:01 +0200)]
doc: improve colorselector preview
Summary:
this has always been broken, it was just never noticed because colorselector
was broken
@fix
ref T8304
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8304
Differential Revision: https://phab.enlightenment.org/D10278
Cedric BAIL [Thu, 3 Oct 2019 02:28:38 +0000 (23:28 -0300)]
elementary: always use a font that matches our expectation for our test instead of the system one.
Summary:
Our tests do rely on the font to have certain characteristic so that they have the value and the
item size being calculated is the one we expect. As it is quite hard to support an infinite number
of font with random size, it is easier to embed one we can rely on for our test. I have copied Vera
from Expedite and changed evas global font path to look for it first. After this patch, even with an
incompatible font in the system, it does still pass all tests. This add around 400KB of data to our
git, but is necessary for a reliable tests suite.
@fix
T8277
Reviewers: lauromoura, zmike, bu5hm4n
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8277
Differential Revision: https://phab.enlightenment.org/D10276
Marcel Hollerbach [Wed, 2 Oct 2019 17:03:58 +0000 (19:03 +0200)]
meson: pass correct PACKAGE_DATA_DIR
Summary:
PACKAGE_DATA_DIR was set to the build dir instead to the elementary
specific data dir.
ref T8304
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8304
Differential Revision: https://phab.enlightenment.org/D10275
Mike Blumenkrantz [Wed, 2 Oct 2019 15:52:41 +0000 (17:52 +0200)]
efl_ui/bg: unset finger_size multiplier during construction
Summary:
this is not a clickable widget, so it shouldn't use finger size
ref T8304
@fix
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8304
Differential Revision: https://phab.enlightenment.org/D10274
Marcel Hollerbach [Wed, 2 Oct 2019 15:05:36 +0000 (17:05 +0200)]
elm: add basics test to create a destroy *every* widget with errors
Summary:
this simply creates packs, resizes, and destroys every single widget
that we have in legacy elm.
This i made to ensure that there are no mistakes in the construction
chain. Additionally, a second test case checks that creation with none
elm parents is erroring but not failing, this seems weird, but we have
provided that in the past, so we should continue providing this.
Reviewers: zmike, segfaultxavi
Reviewed By: zmike, segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10088
Xavi Artigas [Wed, 2 Oct 2019 14:37:33 +0000 (16:37 +0200)]
evas: silence compiler warning in textblock
Uninitialized variable.
Mike Blumenkrantz [Wed, 2 Oct 2019 10:13:10 +0000 (12:13 +0200)]
edje/edit: add api for checking 'required' property of parts
Summary: this is useful for verifying api compliance
Reviewers: cedric
Reviewed By: cedric
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10055
Yeongjong Lee [Wed, 2 Oct 2019 10:04:12 +0000 (12:04 +0200)]
efl_gfx_arrangement: change content_padding param type and remove scalable
Summary:
This change `content_padding` parameter type to int from double for consistency
of size properties.
`scalable` should be handled in more common size API.
Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>
ref T7864
Test Plan: ninja test
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7864
Differential Revision: https://phab.enlightenment.org/D10154
Bruno da Silva Belo [Wed, 2 Oct 2019 10:01:25 +0000 (12:01 +0200)]
csharp: More updated docs to 1.23.
Summary: eina_config and eina_common updated to 1.23.
Reviewers: lauromoura, felipealmeida, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10263
Xavi Artigas [Wed, 2 Oct 2019 09:31:19 +0000 (11:31 +0200)]
docs: Fix problems with monospaced text
Eolian recently added support for $[...] which allows highlighting
more than one word in monospaced text.
Stefan Schmidt [Wed, 2 Oct 2019 08:18:16 +0000 (10:18 +0200)]
docs: enable compression for tar file and avoid file name clash
Summary:
While the target name implies a compression we only ever put this all
into a tar archive so far. Using xz compression as we do with our source
archives.
Also adjust the file naming to avoid clashing with the source tarballs.
We used -doc with autotools before, so this is really more of a catchup.
Reviewers: bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: ProhtMeyhet, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10266
Felipe Magno de Almeida [Wed, 2 Oct 2019 07:55:24 +0000 (09:55 +0200)]
elementary: Add documentatio to efl_ui_layout_factory.eo
Summary:
Documentation was very sparse and actually empty in some places. Add proper documentation
Related to T7717
Reviewers: woohyun, cedric, SanghyeonLee, lauromoura, brunobelo, myoungwoon, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10267
JunsuChoi [Wed, 2 Oct 2019 05:32:33 +0000 (14:32 +0900)]
elementary_test: Add the value provider test for animation_view
Summary:
Add an Value Provider item to test vector animation on elementary_test.
This test is to apply Efl.Gfx.Vg.Value_Provider to the loaded efl_ui_animation object.
If Evas Vg Json(Lottie) Loader is not supported,
use the vector class to output the svg file.
Depends on D9874
Depends on D9897
Test Plan: elementary_test -> Value Provider
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #committers, #reviewers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10015
Change-Id: I37d6cd8ce54d413bdbee5146f0b391a61c0c476b
JunsuChoi [Wed, 2 Oct 2019 05:30:06 +0000 (14:30 +0900)]
vg_common_json: Override value_provider list
Summary:
If value_provider is applied to Efl.Ui.Animation_View, it is passed as vector object.
The passed value_provider list passes to Vg_File_Data.
If there is a value_Provider list in Vg_File_Data,
it apply the property to Lottie_Animation using lottie_animation_property_override api.
Depends on D9874
Test Plan:
...
Eo *vp = efl_add(EFL_GFX_VG_VALUE_PROVIDER_CLASS, p);
efl_gfx_vg_value_provider_keypath_set(vp, "**");
efl_gfx_vg_value_provider_fill_color_set(vp, 100, 0 ,0 ,255);
efl_ui_animation_view_value_provider_override(anim_view, vp);
vp = efl_add(EFL_GFX_VG_VALUE_PROVIDER_CLASS, p);
efl_gfx_vg_value_provider_keypath_set(vp, "**");
efl_gfx_vg_value_provider_stroke_width_set(vp, 50.0);
efl_gfx_vg_value_provider_stroke_color_set(vp, 0, 255, 0, 100);
efl_ui_animation_view_value_provider_override(anim_view, vp);
...
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9897
JunsuChoi [Wed, 2 Oct 2019 04:21:35 +0000 (13:21 +0900)]
Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View
Summary:
Efl.Gfx.Vg.Value_Provider is an object for integrating and managing the properties of vector objects.
These values are dependent on the keypath.
Keypath is the target a specific content or a set of contents that will be updated.
It can include the specific name of the contents, wildcard(*) or Globstar(**).
The valueProvider is borrowed from another library that uses a vector object of type json, such as Efl.Ui.Animation_View
(https://github.com/airbnb/lottie-ios/blob/
5fc0e59e0cb85d3586b1d0d1cf4a2c9669b91d15/lottie-swift/src/Public/iOS/AnimatedControl.swift#L50)
This feature should be used with some patches that apply to the vg json loader and Efl.Canvas.Vg.Object.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9874
Hermet Park [Wed, 2 Oct 2019 02:43:32 +0000 (11:43 +0900)]
Revert "evas map: diable high quality texture mapping feature."
This reverts commit
37870505157d252c057de3910e854ac5650865d6.
This patch should go on.
JunsuChoi [Wed, 2 Oct 2019 05:32:33 +0000 (14:32 +0900)]
elementary_test: Add the value provider test for animation_view
Summary:
Add an Value Provider item to test vector animation on elementary_test.
This test is to apply Efl.Gfx.Vg.Value_Provider to the loaded efl_ui_animation object.
If Evas Vg Json(Lottie) Loader is not supported,
use the vector class to output the svg file.
Depends on D9874
Depends on D9897
Test Plan: elementary_test -> Value Provider
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #committers, #reviewers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10015
Change-Id: Ide01f099e395eed3e9c6445681b327eaa69f1115
JunsuChoi [Wed, 2 Oct 2019 05:30:06 +0000 (14:30 +0900)]
vg_common_json: Override value_provider list
Summary:
If value_provider is applied to Efl.Ui.Animation_View, it is passed as vector object.
The passed value_provider list passes to Vg_File_Data.
If there is a value_Provider list in Vg_File_Data,
it apply the property to Lottie_Animation using lottie_animation_property_override api.
Depends on D9874
Test Plan:
...
Eo *vp = efl_add(EFL_GFX_VG_VALUE_PROVIDER_CLASS, p);
efl_gfx_vg_value_provider_keypath_set(vp, "**");
efl_gfx_vg_value_provider_fill_color_set(vp, 100, 0 ,0 ,255);
efl_ui_animation_view_value_provider_override(anim_view, vp);
vp = efl_add(EFL_GFX_VG_VALUE_PROVIDER_CLASS, p);
efl_gfx_vg_value_provider_keypath_set(vp, "**");
efl_gfx_vg_value_provider_stroke_width_set(vp, 50.0);
efl_gfx_vg_value_provider_stroke_color_set(vp, 0, 255, 0, 100);
efl_ui_animation_view_value_provider_override(anim_view, vp);
...
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9897
Change-Id: I1c9a257e86e54dc5fc5df5d0ced7a826e492cbaa
JunsuChoi [Wed, 2 Oct 2019 04:21:35 +0000 (13:21 +0900)]
Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View
Summary:
Efl.Gfx.Vg.Value_Provider is an object for integrating and managing the properties of vector objects.
These values are dependent on the keypath.
Keypath is the target a specific content or a set of contents that will be updated.
It can include the specific name of the contents, wildcard(*) or Globstar(**).
The valueProvider is borrowed from another library that uses a vector object of type json, such as Efl.Ui.Animation_View
(https://github.com/airbnb/lottie-ios/blob/
5fc0e59e0cb85d3586b1d0d1cf4a2c9669b91d15/lottie-swift/src/Public/iOS/AnimatedControl.swift#L50)
This feature should be used with some patches that apply to the vg json loader and Efl.Canvas.Vg.Object.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9874
Change-Id: I2c8423fefecd12da81066943aeba4d7dc883e80f
Hosang Kim [Wed, 2 Oct 2019 04:58:59 +0000 (13:58 +0900)]
elm_conformant: delete ELM_LAYOUT_MIXIN
Once the min size grows, it can't shrink even if recalcuate it.
@tizen_only
Change-Id: Ia865ba248cf7211ebd4d1e1ab0bcabd8b9ac1008
Jongmin Lee [Tue, 1 Oct 2019 21:21:24 +0000 (06:21 +0900)]
build: resolve migration error
Change-Id: Id79c174dea98628d90fec779ecf50a479eeb83c1
Stefan Schmidt [Tue, 1 Oct 2019 15:24:26 +0000 (17:24 +0200)]
build: switch back to plain mode, release is over
Another forgotten detail. Need to switch back to plain mode now that we
are out of freeze again.
Stefan Schmidt [Tue, 1 Oct 2019 14:22:28 +0000 (16:22 +0200)]
NEWS: cleanup file which had an additional copy of news for 1.22
At some point during the 1.22 release we messed this file up and had an
additional summary of fixes and features. While looking over the file I
also fixed two other small style problems.
Marcel Hollerbach [Tue, 1 Oct 2019 12:57:04 +0000 (09:57 -0300)]
meson: support mono bindings building without cxx
Summary:
the mono bindings do depend partitially on the cxx bindings, eina_cxx
and eolian_cxx are needed, nothing more. With this commit you can build
mono without cxx.
fixes T8292
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8292
Differential Revision: https://phab.enlightenment.org/D10264
Stefan Schmidt [Tue, 1 Oct 2019 10:13:56 +0000 (12:13 +0200)]
build: open up development again
Freeze is over, you are free to go wild. :-)
Stefan Schmidt [Tue, 1 Oct 2019 09:41:41 +0000 (11:41 +0200)]
release: Update NEWS and bump version for 1.23.0 release
Marcel Hollerbach [Tue, 1 Oct 2019 09:27:58 +0000 (11:27 +0200)]
docs: do not crash gengrid widget preview
item class is not initialized to 0. This can crash gengrid later on.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10261
Felipe Magno de Almeida [Tue, 1 Oct 2019 03:06:13 +0000 (00:06 -0300)]
csharp: Load library in permanent way for static members and not rely on leaks
Summary:
The LoadFunctionPointer relied on leaks of NativeModules by not
disposing them. Instead do direct loading without instantiating
unnecessary objects.
Reviewers: lauromoura, woohyun, brunobelo
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10258
Lauro Moura [Tue, 1 Oct 2019 03:03:42 +0000 (00:03 -0300)]
csharp: Add missing since docs to a bunch of classes.
Summary:
Proper documentation will come in later commits.
ref T8293
Reviewers: woohyun, felipealmeida, segfaultxavi, brunobelo
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10260
Bruno da Silva Belo [Tue, 1 Oct 2019 02:23:33 +0000 (23:23 -0300)]
csharp: add since 1.23 to eina_accessor.
Summary: updating to since 1.23.
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10257
Bruno da Silva Belo [Tue, 1 Oct 2019 02:14:46 +0000 (23:14 -0300)]
mono_docs:adding and updating eina_binbuf.cs.
Summary: Generating docs and setting to 1.23.
Reviewers: lauromoura, felipealmeida
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10252
Bruno da Silva Belo [Tue, 1 Oct 2019 02:13:07 +0000 (23:13 -0300)]
mono-docs: adding and updating docs for eina_array.
Summary: Generating docs and setting to 1.23 for eina_array.cs
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10251
Lauro Moura [Tue, 1 Oct 2019 02:10:40 +0000 (23:10 -0300)]
csharp: Document Eina.List
Summary:
Also added Since 1.23 info
Depends on D10253o
ref T8293
Test Plan: Check docs
Reviewers: segfaultxavi, brunobelo, felipealmeida
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10254
Lauro Moura [Tue, 1 Oct 2019 02:08:44 +0000 (23:08 -0300)]
csharp: Allow improved cbs in eina comparators
Summary:
Instead of receiving a callback that compares two intptrs (which is
still used internally), expose a more C#-friendly delegate which is
wrapped into the native one.
Test Plan: run test suite
Reviewers: felipealmeida, segfaultxavi, brunobelo
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10253
Lauro Moura [Tue, 1 Oct 2019 02:05:36 +0000 (23:05 -0300)]
csharp: Document Eina.Log
Summary: ref T8293
Reviewers: brunobelo, segfaultxavi, felipealmeida
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10255
Lauro Moura [Tue, 1 Oct 2019 02:03:51 +0000 (23:03 -0300)]
csharp: Add since to Eina.Promise
Summary: ref T8293
Reviewers: segfaultxavi, felipealmeida, brunobelo
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10256
Jaehyun Cho [Tue, 19 Jun 2018 06:41:49 +0000 (15:41 +0900)]
elm_slider: do not clip indicator to slider
By calling evas_object_smart_member_add(), indicator is clipped to slider.
To keep backward compatibility, indicator should not be clipped to slider.
Change-Id: I625413f65641afa0a415776402749f88d7b88338
Wonki Kim [Tue, 1 Oct 2019 09:35:44 +0000 (18:35 +0900)]
ecore: fix improper usage of sizeof keyword
sizeof operator is applied to the address of a variable.
this patch removes & operater.
Change-Id: I46772c52bf916cd4c007fcd81af4cd91f223d158
Jongmin Lee [Mon, 30 Sep 2019 23:48:56 +0000 (08:48 +0900)]
build: resolve migration build error
Change-Id: I0be6fbd7a8d9169271e9631f9ae93676657090a8
Carsten Haitzler (Rasterman) [Mon, 30 Sep 2019 21:06:07 +0000 (22:06 +0100)]
evas - gl_drm - handle modifiers for drm formats
this was/is breaking e on rpi4 as modifiers are used to pass tiling
info it seems. we had no support thus leaving garbage in buffers. this
fixes that.