Michal Michalski [Tue, 30 Jul 2019 10:08:57 +0000 (12:08 +0200)]
[tizen] Add copy ctor to tizen.Bundle.
This will simplify the implementation of API methods which
need to accept both plain json object and tizen.Bundle.
In example: function sendCommand(..., data) { var d = new tizen.Bundle(data); }
instead of manually having to check if data is a tizen.Bundle or object.
[Verification] Added new test case for this constructor, all existing tests passes.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I4c880dbf8889c88bb20a4029b5cbb8fa2941eb1d
Michal Michalski [Tue, 23 Jul 2019 15:00:26 +0000 (17:00 +0200)]
[mediacontroller][common] Support for null values in Json-Bundle conversions.
JsonToBundle and BundleToJson functions didn't support null values. Manually
handling them every time was cumbersome, hence this commit adds support for null values.
[Verification] + bundle c++ unittests 100% pass
+ bundle js tests 100% pass
+ tct-mediacontroller-tizen-tests
20190722 tct package 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I1315899d8ebb66935ea9b10791b5dba82341af45
Michal Michalski [Wed, 24 Jul 2019 08:38:45 +0000 (10:38 +0200)]
[tizen][mediacontroller] Change toJSON implementation to simplify serialization.
Before this commit, in order to send Bundle object to the C++ layer
it was necessary to call Bundle.toString() method, and than picojson::parse()
in C++ to deserialize it. This commit removes the need for both this steps.
They will be done implicitly by the framework.
[Verification] bundle js tests 100% pass rate.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I89b11bc634b56b720dd8a5ecea8537ef1ce51b24
Piotr Kosko [Mon, 22 Jul 2019 12:30:17 +0000 (12:30 +0000)]
Merge "[Application] Fixed path of getAppSharedURI" into tizen
Piotr Kosko [Mon, 22 Jul 2019 12:27:39 +0000 (12:27 +0000)]
Merge "[Project][code_formatter] Fix JS files formatting error" into tizen
[Application] Fixed path of getAppSharedURI
Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy
New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner users 4096 Jul 18 13:06 .
drwxr-xr-x 5 owner users 4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw 58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner users 4096 Jul 18 13:06 trusted
Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res
[Verification] Checked manually in chrome console
TCT Application 100% passrate
Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09
Piotr Kosko [Mon, 22 Jul 2019 11:35:30 +0000 (11:35 +0000)]
Merge "[Project][Coverity] Some static analysis problems were corrected." into tizen
Rafal Walczyna [Mon, 22 Jul 2019 10:55:38 +0000 (12:55 +0200)]
[Project][code_formatter] Fix JS files formatting error
Due to a bug, js files were not formatting.
Tested manually - js formatting works.
Change-Id: I5a4e2f2dc05241e15c85815f8380563303fa7ed1
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Arkadiusz Pietraszek [Thu, 30 May 2019 13:31:03 +0000 (15:31 +0200)]
[Project][Coverity] Some static analysis problems were corrected.
Those Coverity issues were fixed:
CHECKED_RETURN 835501 - Messageport
CHECKED_RETURN 835504 - Download
CHECKED_RETURN 835505 - Messaging Email
CHECKED_RETURN 835506 - Download
CHECKED_RETURN 1064913 - Common
CHECKED_RETURN 1064914 - Common
CHECKED_RETURN 1064915 - Alarm
CHECKED_RETURN 1074834 - Application
CHECKED_RETURN 1074835 - Application
In Alarm module there is fix of Exception message.
There is also correction of logs in Archive module to bring consistency.
Some files was changed only by cude_format script.
[Verification] Coverity was run, and fixed issues are not on a list anymore.
http://10.113.170.22:8810/download/16062/artifacts/analysis_report_I6ddb03_coverity-2017.07.html
TCT pass rate of changed modules is 100%.
Change-Id: I6ddb030c071166d688a902849c9f979cfbae62d6
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Dawid Juszczak [Fri, 19 Jul 2019 09:58:40 +0000 (11:58 +0200)]
[5.5][package] Change deprecated enum to new ones
changed every occurrence of enum values to new ones
native ACR with related changes:
http://suprem.sec.samsung.net/jira/browse/ACR-1419
[Verification]
tct-application-tizen-tests 100% PASS
tct-package-tizen-tests 100% PASS
Change-Id: I2d4898411efeb18a8526f497d4b837b8d2bb2387
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Ernest Borowski [Wed, 3 Jul 2019 12:30:15 +0000 (14:30 +0200)]
[Project][code_formatter] Fix multiple errors in shell scripts:
- Use null character as path delimiter in git and find commands.
It allows file path to contain newlines and other white space characters.
- Add quotes when needed to prevent globbing and word splitting.
- Simplify logic.
Change-Id: I58de7a3bd1e2e3165ada8b7650b2863e1fc95c15
Signed-off-by: Ernest Borowski <e.borowski@partner.samsung.com>
[version] 2.47
Change-Id: I37a5ea2a5100290b0bed1e7c19baef26e384ea54
Dawid Juszczak [Fri, 12 Jul 2019 13:45:22 +0000 (15:45 +0200)]
[mediacontroller][bundle] fixing custom command
Refactored some functions to use tizen.Bundle
and formated code with format script
Changed implementation of functions:
+ MediaControllerInstance::MediaControllerServerReplyCommand
+ MediaControllerInstance::MediaControllerServerInfoSendCommand
+ MediaControllerServer::OnCommandReceived
+ MediaControllerServer::CommandReply
+ MediaControllerClient::OnCommandReply
+ MediaControllerClient::SendCommand
[Verified]
tct-mediacontroller-tizen-tests - 100% passed
also tested manually on chrome console
Change-Id: I9d072d10a5fc272c54d17731f33ae9b733009412
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Michal Michalski [Mon, 15 Jul 2019 10:02:03 +0000 (12:02 +0200)]
[tizen] Update bundle js tests after fix.
+ Added tests for regular arrays and Uint8Arrays.
+ Updated toJSON test after method modification.
+ Added tests for toString method.
[Verification] Tests pass for fixed bundle.
Change-Id: Idd9298b311fee56c4387c5f9c9fbd2b4984944b0
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Mon, 15 Jul 2019 10:01:08 +0000 (12:01 +0200)]
[tizen] Fix issue with regular arrays in Bundle.
Bundle now stored byte streams as Uint8Arrays and converts regular arrays with
octet values to Uint8Arrays in Bundle::set() method.
toString() method now prints Uint8Arrays in the same way as regular arrays
using "[1,2,3]" format, instead of the "{0: 0, 1: 1, 2: 2}" format which is the
default behavior of toString() method on typed arrays.
[Verification] Modified tests passed.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I9eeca40d9760413c81888f4980146c8025d227d2
Piotr Kosko [Thu, 11 Jul 2019 10:56:15 +0000 (10:56 +0000)]
Merge "[tizen] Bundle constructor fix." into tizen
Michal Michalski [Thu, 11 Jul 2019 10:13:53 +0000 (12:13 +0200)]
[tizen] Bundle constructor fix.
xwalk.utils.validator replaced with xwalk.utils.type.
[Verification] All tests passed.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I2a7a8d4c1c2fb81ab8750a122596378d3af975f3
[version] 2.46
Change-Id: I5347699a9a3eab4210560a5e96ac212886954a53
Signed-off-by: Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
[UT][SPEC] Fixed passing tizen_ut_build defined value
[Bug] Build fails when building different profile than mobile
[Verification] Build successfully for unified build and each profile
Change-Id: I37b2f9e8517e7cd9db7956812c39bb57bdff5a42
Michal Michalski [Thu, 4 Jul 2019 14:16:05 +0000 (16:16 +0200)]
[common][tizen][utils] Common Bundle implementation.
http://suprem.sec.samsung.net/jira/browse/TWDAPI-225
Unified the way native bundle objects are used
by WebAPI plugins.
[Verification] unittests pass rate 100%.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I501880daee29f878e4af9fb9b20e386905fbdc0c
Michal Michalski [Fri, 28 Jun 2019 11:23:21 +0000 (13:23 +0200)]
[utils][webapi-plugins.spec][common][tizen-wrt.gyp][tizen] Common bundle tests.
http://suprem.sec.samsung.net/jira/browse/TWDAPI-225
Tests for common Bundle implementation.
[Verification] Pass rate 100%.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ib8ae4415b45f018efc3406c071115782920798f9
[version] 2.45
Change-Id: I6272b2f933c4bd97e2c7963938a6356afb1cc1f3
Signed-off-by: Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Piotr Kosko [Fri, 28 Jun 2019 10:30:57 +0000 (10:30 +0000)]
Merge "[MediaController] Fix for custom command without data" into tizen
Rafal Walczyna [Fri, 28 Jun 2019 06:37:13 +0000 (08:37 +0200)]
[MediaController] Fix for custom command without data
If custom command was sent without additional data then
command was not parsed at all.
[Verification] Tested manually
Change-Id: Id35a5852a7fa61aff48fc181926e77ee01f65ff8
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Arkadiusz Pietraszek [Thu, 27 Jun 2019 12:12:21 +0000 (14:12 +0200)]
[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener.
[verification] TCT 100% passrate
Change-Id: Ic77f57e39b73acc77c67c3f1cff0352a94315206
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Arkadiusz Pietraszek [Thu, 27 Jun 2019 09:14:58 +0000 (11:14 +0200)]
[Mediacontroller] Setter fixes for shuffleMode, repeatMode end position in MediaControllerPlaybackInfo
Previous implementation intended to check for null and undefined and in reality didn't allow for setting 'false' or '0' values.
Change-Id: I03194e81d5d0bd5ef97a88d01a014f758a6ca49d
Michal Michalski [Wed, 19 Jun 2019 06:18:38 +0000 (08:18 +0200)]
[common] Handle nullptr output args in platform_enum.
Methods in platform_enum were not handling a nullptr output argument
case. This could lead to dereferencing of nullptr and to a crash.
Now they will return InvalidValuesError.
[Verification] No verification.
Change-Id: I756cf1495369143eaca78d249fd83229383907fc
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Piotr Kosko [Thu, 13 Jun 2019 09:05:01 +0000 (09:05 +0000)]
Merge "[mediacontroller] Get/set server icon API." into tizen
Michal Michalski [Thu, 25 Apr 2019 14:16:37 +0000 (16:16 +0200)]
[mediacontroller] Get/set server icon API.
http://suprem.sec.samsung.net/jira/browse/TWDAPI-221
+ readonly attribute MediaControllerServerInfo::iconURI
+ attribute MediaControllerServer::iconURI
+ MediaControllerServer::updateIconURI()
[Verification] Manual testing.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: If587a5958c74c224699345ef0ab7ff2575dd12ec
[version] 2.44
Change-Id: I413db071eb1dcbe8256d2368e8628b3345e9cf00
Signed-off-by: Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Lukasz Bardeli [Thu, 6 Jun 2019 08:31:07 +0000 (08:31 +0000)]
Merge "[googletest][googlemock] Add googletest sources to the project." into tizen
Michal Michalski [Tue, 21 May 2019 08:52:35 +0000 (10:52 +0200)]
[googletest][googlemock] Add googletest sources to the project.
Binaries available at tizen repository were causing SEGFAULTS
when tests were executed so we decided to build it from more
recent sources. Added googletest license to the rpm package
containing unit tests.
[Verification] SEGFAULT does not occur when sample tests were
executed.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I9d028ca14dfcfa1d134afc7da733a7b4853c95f1
Piotr Kosko [Tue, 28 May 2019 05:19:13 +0000 (05:19 +0000)]
Merge "[SystemInfo] Add SERVICE_COUNTRY property" into tizen
Piotr Kosko [Mon, 27 May 2019 07:45:26 +0000 (07:45 +0000)]
Merge changes Idb5bec64,I1f140bb8 into tizen
* changes:
[mediacontroller] Get/set playback content type.
[mediacontroller] Declare MediaControllerContentType enum.
Piotr Kosko [Wed, 22 May 2019 12:06:07 +0000 (12:06 +0000)]
Merge "[Utils][fix] Privileges check" into tizen
Piotr Kosko [Wed, 22 May 2019 11:59:27 +0000 (11:59 +0000)]
Merge "[common] Native bundle to json converter." into tizen
Michal Michalski [Tue, 21 May 2019 13:26:11 +0000 (15:26 +0200)]
[common] Native bundle to json converter.
Function which converts native bundle object into json.
[Verification] Code compiles without error.
Change-Id: I932971d40309017c7ba7be9d677a41147ac5b3c2
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Dawid Juszczak [Mon, 13 May 2019 15:07:34 +0000 (17:07 +0200)]
[Utils][fix] Privileges check
http://suprem.sec.samsung.net/jira/browse/XWALK-1909
Added new function to check if value passed to function
checkPrivilegeAccess is privilege
Also changed value of CONTENT_READ to proper
[verification]
tested on chrome console
Change-Id: I9213055621b4627d56f49c4b12227512c9d0c9d0
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Lukasz Bardeli [Tue, 21 May 2019 06:49:42 +0000 (08:49 +0200)]
[Alarm][DataControl] Change console.log to xwalk.utils.log
[Verification] Code compiles properly.
Change-Id: Icfafa4c2b88d382a050f3b3f8ad9aa8884f5ebdb
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Lukasz Bardeli [Fri, 17 May 2019 11:34:35 +0000 (13:34 +0200)]
[SystemInfo] Add SERVICE_COUNTRY property
ACR: http://suprem.sec.samsung.net/jira/browse/TWDAPI-223
[Verification] Code compiles without error. Tested in chrome console.
Change-Id: I449c57fdf6ba1ef884f766a397e950a1c0fdb4cd
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Michal Michalski [Thu, 18 Apr 2019 11:43:29 +0000 (13:43 +0200)]
[mediacontroller] Get/set playback content type.
http://suprem.sec.samsung.net/jira/browse/TWDAPI-219
+ enum MediaControllerContentType
+ MediaControllerPlaybackInfo::contentType
+ MediaControllerServer::updateContentType()
[Verification] Manual tests in js console.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Idb5bec64fac631fa92825920a745abfe02861edf
Michal Michalski [Fri, 10 May 2019 10:09:45 +0000 (12:09 +0200)]
[mediacontroller] Declare MediaControllerContentType enum.
Extracted into separate commit from adding ContentType WebAPI
because it is needed by Search API implementation as well.
[Verification] Code compiles. Both ContentType API implementation and Search API
implementation compile as well with this commit as a parent.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I1f140bb8dd608887b90a1d7b5a202c493e5fd3e4
Pawel Wasowski [Thu, 9 May 2019 11:31:49 +0000 (13:31 +0200)]
[messaging] Fix synchronization issues
Due to the delay between updating email with native C API functions and
updates of the corresponding message/thread records in the mail
database, race conditions occured in the previous implementation,
resulting in inconsitencies between thread_ids in the DB and those of
messages in JS layer. Active waits have been added to mitigate this
problems.
[Verification] tct-tizen-messaging-email pass rate: 100%
Change-Id: Ie0771ffc40e6cdee696756a8e831ae56bbe8f84d
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Rafal Walczyna [Fri, 10 May 2019 08:07:12 +0000 (10:07 +0200)]
[filesystem] Fix svace issue
strerror caused PROC_USE.VULNERABLE SVACE error
Change-Id: I1020097d2f0cace1e585c0bb04f0b9336aad1372
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Michal Michalski [Thu, 9 May 2019 15:04:05 +0000 (17:04 +0200)]
[mediacontroller] Fix sendCommand callbacks.
sendCommand callbacks were not triggered due to problem
with requestId. This commit fixes this bug.
[Verification] MC TCT 100% pass.
Change-Id: Ibb4fbe146dcb8c20d623ac27924377d4097bb67d
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Tue, 7 May 2019 08:59:32 +0000 (10:59 +0200)]
[mediacontroller][common] Use PlatformEnum in MediaController.
Refactor enums in MediaController module using PlatformEnum
template class.
[Verification] Code compiles + MC TCT passed.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ie861d1c0aca7651a2f9ce45b966773082abf6045
Michal Michalski [Tue, 7 May 2019 08:36:56 +0000 (10:36 +0200)]
[common] Define PlatformEnum class template.
Will replace current way enums are defined in webapi-plugins.
[Verification] Code compiles.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Id8c53df46ae9039e81d699884494b72c20d5cba8
Merge branch 'tizen_5.0' into tizen
Change-Id: I80139d08dab29ce640b5fe830bbf22d00d8b773f
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: Ie11b3d545d450613ecf61ccee824744108218c73
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I0d282d007e89b4c761fa74d9b0737ca35c29ec57
Michal Michalski [Tue, 16 Apr 2019 10:26:16 +0000 (12:26 +0200)]
[mediacontroller] Fix error handling in ReplyCommand.
MediaControllerServerReplyCommand function did not
handle errors returned by MediaControllerServer::CommandReply()
call. This commit handles those errors.
[Verification]
Code compiles.
Change-Id: Ibc5acacc32ff23a6d8fa7cac096ade0e40e2b697
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Piotr Kosko [Thu, 25 Apr 2019 08:36:22 +0000 (08:36 +0000)]
Merge "[fix][Content] readonly atributes since 5.5" into tizen
Piotr Kosko [Thu, 25 Apr 2019 08:33:37 +0000 (08:33 +0000)]
Merge "[MediaController] getItems and getAllPlaylists implemented." into tizen
Piotr Kosko [Thu, 25 Apr 2019 08:33:30 +0000 (08:33 +0000)]
Merge "[MediaController] Add listener playlist updated." into tizen
Piotr Kosko [Thu, 25 Apr 2019 08:33:23 +0000 (08:33 +0000)]
Merge "[MediaController] Adding, updating and sending item." into tizen
Piotr Kosko [Thu, 25 Apr 2019 08:33:17 +0000 (08:33 +0000)]
Merge "[Mediacontroller] Add playlist methods" into tizen
Michal Michalski [Wed, 24 Apr 2019 08:08:05 +0000 (10:08 +0200)]
[filesystem] Fix invalid errno usage.
http://suprem.sec.samsung.net/jira/browse/TFDF-1624
Fix for failing cordova filesystem tests.
Issue occured because errno value was not tested
right away after readdir() system function call
and other library functions were overriding errno.
[Verification] Cordova file tests pass.
Change-Id: If84de57e994b5255b1d51006803254f4fe90811b
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Lukasz Bardeli [Wed, 24 Apr 2019 08:54:56 +0000 (10:54 +0200)]
[MediaController] getItems and getAllPlaylists implemented.
- getItems
- server getAllPlaylists
- client getAllPlaylists
[Verification] Code compiles without error. Tested in chrome console
ACR: TWDAPI-199
Change-Id: Idd6594b76d52eeb6e96574f2fbcd5bf82a2245dc
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Dawid Juszczak [Fri, 19 Apr 2019 08:52:17 +0000 (10:52 +0200)]
[fix][Content] readonly atributes since 5.5
this change prevents user from modify
content.geolocation attributes
[Verification]
- tested on chrome console
Change-Id: Ia5e887d6029124e8eb3c0830391506632db16813
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
[Content] isFavorite added to editableAttributes array
[Bug] Since 2.3 isFavorite is an editableAttribute, which was missing
in editableAttributes array. Now added it there.
[Verification] Code compiles without errors.
Change-Id: Ib5266a66920f0050fd5c25287602514bc4ea3762
Lukasz Bardeli [Thu, 18 Apr 2019 05:46:26 +0000 (07:46 +0200)]
[MediaController] Add listener playlist updated.
Add methods
- addPlaylistUpdatedListener
- removePlaylistUpdatedListener
[Verification] Code compiles without error. Tested in chrome console
ACR: TWDAPI-199
Change-Id: Iec717785c4e12ad464d9a302d1b1ccc98ff16acf
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Dawid Juszczak [Wed, 17 Apr 2019 15:09:15 +0000 (17:09 +0200)]
[fix][content] Deprecate filtering attributes
fixed error with printing deprecation warning
[verification]
builded succesfully
tested on mobile device - everything looks fine
Change-Id: If6bc3cab368696d1a74e35805b78b35572669c2b
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
[version] 2.43
Change-Id: I25d5811f20d31f4034841ed106ab43c249fb0c59
Signed-off-by: Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Piotr Kosko [Wed, 17 Apr 2019 11:53:50 +0000 (11:53 +0000)]
Merge "[Content] Some attributes are readonly since 5.5" into tizen
[Content] Some attributes are readonly since 5.5
[Feature] name, description, rating, geolocation and orientation attributes are
readonly since 5.5.
For backward compatibility, the attributes are allowed for modifications for
apps with required version lower than 5.5
modified editableAttributes member also to remove readonly attributes from this array.
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-203
[Verification]
TCT passrate 100% when running with 5.0 TCT - backward compatibility.
14 fails on latest TCT, TCT passrate 100% with TCT fixed by TCT team.
Change-Id: I8382372c51105fb7e11c3037d5994e2de76d59fa
Signed-off-by: Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Piotr Kosko [Wed, 17 Apr 2019 10:35:16 +0000 (10:35 +0000)]
Merge "[Project][Codeformat] Added prettier as partial formatter for JS" into tizen_3.0
Piotr Kosko [Wed, 17 Apr 2019 10:34:30 +0000 (10:34 +0000)]
Merge "[Project][code_formatter] Added u options and changed JS formatting and validating tools" into tizen_3.0
Lukasz Bardeli [Wed, 17 Apr 2019 05:38:44 +0000 (07:38 +0200)]
[MediaController] Adding, updating and sending item.
Add methods
- addItem
- updatePlaybackItem
- sendPlaybackItem
Add callback
- onplaybackitemrequest
[Verification] Code compiles without error. Tested in chrome console
ACR: TWDAPI-199
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Change-Id: Iffeec9bc0473f9a9df54d3fbd5a57dfc3ca21913
Dawid Juszczak [Fri, 5 Apr 2019 11:16:45 +0000 (13:16 +0200)]
[Content] Deprecate filtering attribute
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-210
Change-Id: Ib0ebdee662d7dbb57ad29e98d2b7e427911f9182
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Lukasz Bardeli [Fri, 12 Apr 2019 07:59:39 +0000 (09:59 +0200)]
[Mediacontroller] Add playlist methods
Add methods
- CreatePlaylist
- SavePlaylist
- DeletePlaylist
Define interfaces
- MediaControllerPlaylist
- MediaControllerPlaylistItem
[Verification] Code compiles without error. Tested in chrome console
ACR: TWDAPI-199
Change-Id: Icf9b043c00b23a29c0e3d13d0c3a3dbcba8c0762
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Michal Michalski [Fri, 12 Apr 2019 07:15:48 +0000 (09:15 +0200)]
[mediacontroller] Fix pointer-related bug.
[Verification] Code builds and testted sendCommand function in chrome console.
Change-Id: I3045684b11e85a756854f999ed42c74721bb0ae5
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Piotr Kosko [Wed, 10 Apr 2019 12:10:02 +0000 (12:10 +0000)]
Merge "[mediacontroller] Get/set content age rating API implementation." into tizen
[Project][Codeformat] Added prettier as partial formatter for JS
[Feature] Existing solution check the format using eslint and fix
some issues with predefined rules (which match the requirements
of review.tizen.org CodingRule_Auto bot rules.
However the tool checks the validity, it does not provide auto
formating of too long lines issues.
To ensure such feature, the new tool was introduced and executed before
eslint validation.
Thanks to prettier, the line breaks are unified and handled the same
way in whole project.
Change-Id: I077036521307ef28fda5388ecab01b8d850ad3e3
Merge branch 'tizen_5.0' into tizen
Change-Id: Iff948d1e34e86ebd21401e59a12f5d805e4eb2ac
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I42897295af557b4844c1b9c4a16a687e96045cc5
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I8f28e19de69751b7b92328491366aa0b8c7c6847
[version] 2.32
Change-Id: Idb24a1afa087aa101cebcfde7d46d283d459c956
[Filesystem] listFiles method of File ignores files without access
[Bug] Files with invalid SMACK labels (not allowed to be accessed by app)
caused exception about missing member ("location is required argument").
Fix ignores the files that cannot be accessed.
[Verification] Manually checked with Chrome console and trying to list files
with invalid SMACK label. Files are being ignored.
100% passrate for filesystem module.
Change-Id: I48ed83ebbba5d0c6cfa0e597f083a7a1abce17fa
[version] 2.41
Change-Id: Ib06ff3c123c7763b5b0234827ef8a8f74cc052d7
Dawid Juszczak [Mon, 8 Apr 2019 09:06:05 +0000 (11:06 +0200)]
[Content][fix] related to change in db
changed play_order to value compatible with database.
related to: http://suprem.sec.samsung.net/jira/browse/TFDF-1354
[verification] tct-content-tizen-tests - 100% PASS
Change-Id: I910bddd25ad5654c19565b136f29dea2a5e1dc1f
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Arkadiusz Pietraszek [Wed, 27 Mar 2019 14:29:37 +0000 (15:29 +0100)]
[Project][code_formatter] Added u options and changed JS formatting and validating tools
Now eslint is used to format js files.
Not all issues can be fixed by eslint, so it prints list of issues for user to fix.
All 'u' options in formatter format appropriate files, that was changed from last commit.
Since files to format are not commited, this script backs up those files.
[Verification] Script executes without errors and proper files are chosen to format. Formated .js files have 4 spaces of indentation.
Change-Id: I10509ce3f639b25cca7e68e95e7c9419d9d82304
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Michal Michalski [Wed, 3 Apr 2019 10:52:21 +0000 (12:52 +0200)]
[messageport][common] Move BundleJsonIterator to common.
It will be used in mediacontroller search API.
[Verification]
tct-messageport-tizen-tests 100% pass rate.
Change-Id: I1ef945697c16cc21801cb53e2bb13a389f777e9a
Michal Michalski [Thu, 7 Mar 2019 11:04:36 +0000 (12:04 +0100)]
[mediacontroller] Get/set content age rating API implementation.
http://suprem.sec.samsung.net/jira/browse/TWDAPI-207
[Verification] Manual testing.
Change-Id: I8ecea29c13f4cf97c08edfe2d6fd3a07799459d9
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
[version] 2.40
Change-Id: I00ae696384378c21bb1e384ac1604b90e6ef81f0
Piotr Kosko [Wed, 27 Mar 2019 10:14:38 +0000 (10:14 +0000)]
Merge "[messaging] fixed bug with foldersupdate callback" into tizen
Dawid Juszczak [Tue, 26 Mar 2019 15:22:21 +0000 (16:22 +0100)]
[bluetooth] fixed bug with BluetoothProfileHandler
Refactored implementation of BluetoothProfileHandler constructor.
[Verification] (automated) tct-bluetooth-tizen-tests passed 100%
Change-Id: Iff1d3117f7a893da31ce4e6068e7886c4a21ff78
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Piotr Kosko [Fri, 22 Mar 2019 11:30:24 +0000 (11:30 +0000)]
Merge "[mediacontroller] Use request_id for listener matching in SendCommand." into tizen
Piotr Kosko [Fri, 22 Mar 2019 08:25:46 +0000 (08:25 +0000)]
Merge "[MediaController] Change InvalidState to UnknownError." into tizen
Piotr Kosko [Fri, 22 Mar 2019 08:16:29 +0000 (08:16 +0000)]
Merge "[KeyManager] Add possibility to check whether alias is password protected" into tizen
Michal Michalski [Wed, 20 Mar 2019 17:19:15 +0000 (18:19 +0100)]
[mediacontroller] Use request_id for listener matching in SendCommand.
SendCommand method was using watchId to identify CommandReply callback which
should be called. It was passed in bundle object to mc_client_send_custom_cmd
function. Now instead of passing watchId we use already available request_id
to perform the same matching for command reply listeners.
[Verification]
Manual test.
tct-mediacontroller-tizen-tests - pass 100%
Change-Id: I57e90dbe36d7726f2e2f66866b11910d5d1d5d0d
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 12:42:20 +0000 (13:42 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201889/
Change-Id: Ic48f0740da9c73ef676d30eedf72226c7f4d5699
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 11:19:48 +0000 (12:19 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201880/
Change-Id: I26f3ae8991218e97d1a55cf6a0abffba622ed25f
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Tue, 19 Mar 2019 15:30:43 +0000 (16:30 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201807/
Change-Id: I1389ab8e2ba4bcddada69fead783071626eda12d
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 13:55:22 +0000 (14:55 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201891/
Change-Id: Ia5efe12e79b7f388c2a967a7f118c33edc34d06f
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Michal Michalski [Fri, 15 Mar 2019 11:42:35 +0000 (12:42 +0100)]
[widgetservice][utils] Fix CommonListenerManager implementation.
CommonListenerManager implementation used native.getResultObject
on listener input before passing it to the callback. This behavior
is widgetservice specific and so it was moved outside
CommonListenerManager implementation.
[Verification]
Manual tests.
Change-Id: Ied82281a660562c2697f4f6c298ec11a2e2d5549
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
[version] 2.39
Change-Id: Iace319e63260810fe4d26f5d166c3bdbb629ce21
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Lukasz Bardeli [Fri, 15 Mar 2019 07:50:06 +0000 (07:50 +0000)]
Revert "[messaging] Refactor commonly used functions"
This reverts commit
b3b63e72ae9d1b4d909e5c213830427e8ecc6ed6.
Reason for revert: <INSERT REASONING HERE>
Change-Id: Ief8acc66b387fc8783978e8ce8b2f0474a8511fa
Lukasz Bardeli [Fri, 15 Mar 2019 08:29:14 +0000 (08:29 +0000)]
Merge "Revert "[messaging] Refactor functions used to get email converations from DB"" into tizen
Lukasz Bardeli [Fri, 15 Mar 2019 07:49:48 +0000 (07:49 +0000)]
Revert "[messaging] Refactor functions used to get email converations from DB"
This reverts commit
452dfff3c3eecd63e38295ad0455b961d400d1cb.
Reason for revert: <INSERT REASONING HERE>
Change-Id: I2373c1fc684ff879af16e08ba9f92d26c4ca77da
Piotr Kosko [Thu, 14 Mar 2019 06:16:11 +0000 (06:16 +0000)]
Merge "[Content] Adding comments in code and adding deprecation log" into tizen