JunsuChoi [Fri, 6 Dec 2019 01:56:11 +0000 (10:56 +0900)]
elm_label: Remove tizen only
4afbff patch has been applied to open source.
Therefore, delete tizen only.
Open source patch to be migrated will be empty patch.
Change-Id: I98224acdaef1559a2099d8f6a2b237d1226b297c
Signed-off-by: Prasoon Singh <prasoon.16@samsung.com>
Subodh Kumar [Tue, 3 Dec 2019 11:48:18 +0000 (17:18 +0530)]
[Tizen5.5] Edje: Add color class feature for textblock properties.
These properties were missing, as underline color is being used used heavily.
There is link pressed effect feature which requires color class for underline color.
Also link pressed effect works on link tag. So link tag is provided by default and if app
wants to customises the color then whole style needs to be rrecreated so replacing
color code for link tag will work as aspected.
Change-Id: I04e826a64610981a0491d753a855d5c8984fc259
Prasoon Singh [Wed, 4 Dec 2019 11:46:21 +0000 (17:16 +0530)]
elm_label: Emit click signal on acivate action on label
In screen-reader enabled case click signal of label is not triggered.
Change-Id: I218944122ba9747f7fb7ab425559ad1fc331f34e
Signed-off-by: Prasoon Singh <prasoon.16@samsung.com>
maxerba [Thu, 5 Dec 2019 17:06:12 +0000 (18:06 +0100)]
Updating french translation
JunsuChoi [Thu, 5 Dec 2019 11:25:25 +0000 (20:25 +0900)]
Ector: Prevent access to NULL
Summary: ector thread can called *data(task) after deleting task object.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10804
Change-Id: I05d5226ec7b950214f398f66d0ca82e430099cb5
Ali Alzyod [Thu, 5 Dec 2019 09:37:57 +0000 (10:37 +0100)]
efl_text_attribute_factory: update documention
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10806
JunsuChoi [Thu, 5 Dec 2019 11:25:25 +0000 (20:25 +0900)]
Ector: Prevent access to NULL
Summary: ector thread can called *data(task) after deleting task object.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10804
Change-Id: I9e7b4893fc58a9670f2ac60e9b632cf9969c22c3
Taehyub Kim [Thu, 5 Dec 2019 05:15:16 +0000 (14:15 +0900)]
Revert "ecore_audio, ecore_buffer, ecore_wl2 : Fix build warnings."
This patch cause the ecore_buffer_register tc break,
then this need to revert temporary.
This reverts commit
f8f770ebf854d725b3bf8a2ec10f7526960fd5e2.
Change-Id: I75e6cbf3654dfbc62941715fe7272846f2ac93e7
Jongmin Lee [Wed, 4 Dec 2019 21:34:48 +0000 (06:34 +0900)]
build: remove gstreamer 0.10 support
Change-Id: I83824b7553ed13d17a640049f1077b710c30572a
Stefan Schmidt [Thu, 28 Nov 2019 08:59:41 +0000 (09:59 +0100)]
exotic: remove left-overs from Exotic support
This seems to have been gone a long time ago and only references left
that have not been disturbing the build. Time to clean up!
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10793
Subodh Kumar [Tue, 3 Dec 2019 10:56:00 +0000 (10:56 +0000)]
edje: Add text change signal
There is no way to know about text changes in edc.
This signal will help developer to know about text changes
and do some operation based on that.
@feature
Co-authored-by: Cedric BAIL <cedric.bail@free.fr>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10780
Stefan Schmidt [Wed, 30 Oct 2019 16:09:20 +0000 (17:09 +0100)]
emotion & evas: remove gstreamer 0.10 support
We have Gstreamer 1.x support for a long time already. We used to keep
this around as fallback. By now Linux distributions start to actually no
longer ship the Gstreamer 0.10.x packages and upstream has not seen a
release in in 5 years. Time to remove it on our side as well.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10779
Stefan Schmidt [Fri, 1 Nov 2019 08:35:09 +0000 (09:35 +0100)]
esacpe: remove library from tree
This has not been used for a while and is not even buildable after our
switch to meson. It was a niche to start with given that it needed the
PS3 OS to run on. I asked for any remaining users at EDD and on the list
but heard nothing. Time to remove.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10778
Cedric BAIL [Sat, 23 Nov 2019 09:09:13 +0000 (01:09 -0800)]
elementary: small improvement on example migrating them to newer unified API.
Xavi Artigas [Wed, 4 Dec 2019 17:22:25 +0000 (18:22 +0100)]
code comments: annoying typos
Marcel Hollerbach [Wed, 4 Dec 2019 16:45:25 +0000 (17:45 +0100)]
efl_canvas_animation_group: show that playing backwards is also working
Summary:
playing backwards is also working, this is simply shown here, the
handcrafted backwards animation wasnt showing the correct animation
either.
Depends on D10799
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10802
Xavi Artigas [Wed, 4 Dec 2019 16:25:45 +0000 (17:25 +0100)]
Efl.Canvas.Animation: Rename repeat_count to play_count
Summary:
play_count is a tad simpler to understand, since it means the TOTAL number of
times the animation will play.
The default value is now 1, and 0 means INFINITE (instead of -1). This allows
removing yet another constant from header files.
Depends on D10799
Test Plan: Everything builds and passes tests. Elm_test Animation.Repeat has been adjusted accordingly.
Reviewers: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10800
Lauro Moura [Wed, 6 Nov 2019 18:41:13 +0000 (18:41 +0000)]
charp: Require mono bindings when using dotnet
Allow using `-Ddotnet=true` to automatically pull `bindings=mono`.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10610
JunsuChoi [Wed, 27 Nov 2019 13:23:12 +0000 (08:23 -0500)]
tests/layout: add unit test for legacy layout theme,changed signal
split from D10744
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10751
Mike Blumenkrantz [Wed, 27 Nov 2019 13:12:52 +0000 (08:12 -0500)]
efl_ui/layout: unconditionally emit theme,changed event for legacy layouts
this will automatically be optimized by smart callback internals and fix
emission of this event
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10750
Mike Blumenkrantz [Tue, 26 Nov 2019 15:59:21 +0000 (10:59 -0500)]
tests/layout: add explicit test for implicit theme,changed emission
this must be emitted automatically during finalize if theme_set is
not directly called during construction
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10741
Mike Blumenkrantz [Tue, 26 Nov 2019 15:54:36 +0000 (10:54 -0500)]
tests/layout: validate EFL_UI_LAYOUT_EVENT_THEME_CHANGED emission in theme test
ensure that this callback is emitted exactly one time if the theme is
set during construction
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10740
Mike Blumenkrantz [Tue, 26 Nov 2019 15:52:31 +0000 (10:52 -0500)]
tests/layout: fix theme apply test for layout object
the group previously used (efl/win/background) no longer exists, and
this test never verified that the theme_set call succeeded so this has
been failing silently for a long time
now we check and verify that the call succeeds in addition to using a
valid group
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10739
Mike Blumenkrantz [Tue, 26 Nov 2019 15:49:55 +0000 (10:49 -0500)]
efl_ui/layout: fix multiple emissions of theme,changed during construction
in the case where a layout object was created and had a theme manually set
with efl_ui_layout_theme_set() during construction, the layout would then
call theme_apply() a second time internally during finalize which, if the
theme has not changed (as can only be the case if this flag is unset),
results in a repeated theme_apply for the existing theme
@fix
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10738
Mike Blumenkrantz [Tue, 26 Nov 2019 15:48:42 +0000 (10:48 -0500)]
efl_ui/layout: fix typo in theme,changed event checking and fix this event
this was a copy/paste error
ref
7ad8acc290f078aa9d2bfd32ec15a4e5677ab01f
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10737
Marcel Hollerbach [Tue, 3 Dec 2019 13:47:31 +0000 (14:47 +0100)]
efl_ui_radio_box: declare stable
this was forgotten, the task for it (T8026) was even closed.
Differential Revision: https://phab.enlightenment.org/D10786
Marcel Hollerbach [Mon, 25 Nov 2019 12:33:44 +0000 (13:33 +0100)]
efl_ui_mutli_selectable: stabelize interfaces
these classes are after a long naming discussion stable.
fixes T7871
fixes T8265
fixes T7922
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Differential Revision: https://phab.enlightenment.org/D10734
Marcel Hollerbach [Wed, 4 Dec 2019 13:20:43 +0000 (14:20 +0100)]
efl_canvas_animation_group: remove implicit children behaviour
you could set the duration of the group to all children, however, the
default behaviour was to not do that. This is however a bit probeblatic,
and needs to be more expclicit. If this is needed again, then this can
be reintroduced, however, not in this form.
ref T8437
Depends on D10798
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10799
Marcel Hollerbach [Wed, 4 Dec 2019 09:23:23 +0000 (10:23 +0100)]
remove unsued macros
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10798
Marcel Hollerbach [Wed, 4 Dec 2019 09:20:38 +0000 (10:20 +0100)]
efl_canvas_animation: use floating point infinite instead of macro
the floating point infinite builtin should also work cross languages (so
this is better for bindings).
ref T8437
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10797
Marcel Hollerbach [Wed, 4 Dec 2019 09:14:09 +0000 (10:14 +0100)]
efl_canvas_animation: add a standard value for duration of animations
before this commit the standard time was 0, which results in no
animation played at all. Now its 0.2 and a app that does not like it can
adjust it.
ref T8436
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10796
Marcel Hollerbach [Wed, 4 Dec 2019 09:51:04 +0000 (10:51 +0100)]
efl_canvas_animation_group: use @property instead of method
this also refreshes the documentation of all this.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10795
Daniel Kolesa [Wed, 4 Dec 2019 15:04:19 +0000 (16:04 +0100)]
eolian: fix a parse bug where composites was treated as implements
In the specific case where you had "class A extends B composites C"
the correct composites branch was ignored and instead the implements
branch was used. This was entirely wrong/an oversight that did not
appear until now. Other combinations were handled correctly.
Xavi Artigas [Wed, 4 Dec 2019 14:58:04 +0000 (15:58 +0100)]
docs: slight improvement for Efl.Decelerate_Interpolator
Daniel Kolesa [Wed, 4 Dec 2019 14:30:17 +0000 (15:30 +0100)]
eolian: account for entire inheritance trees when compositing
When a class composites an interface, we need to ignore all of
its extends (and extends of those) as well as the main interface
when doing API checks, as composites essentially provides a
guarantee that this *will* be implemented at runtime, which
further extends to the whole inheritance tree of that interface.
Fixes T8491.
Taehyub Kim [Wed, 4 Dec 2019 10:12:48 +0000 (19:12 +0900)]
fix the wrong method signature for evas_textgrid
Summary:
fix the wrong method signature famliy font get and font size get for evas_textgrid
the method parameter should be changed to return type
@fix
Reviewers: Hermet, ali.alzyod, woohyun
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10794
Marcel Hollerbach [Tue, 3 Dec 2019 15:00:29 +0000 (16:00 +0100)]
efl_canvas_animation_group: move from list to iterator
we should not use lists directly, ownership issues etc. etc..
This moves it to iterators
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10787
Bowon Ryu [Wed, 4 Dec 2019 08:09:33 +0000 (17:09 +0900)]
edje_entry: converting plain_text to '*' using unicode units.
Summary:
When converting plain_text to '*' in retrieve_surrounding_cb,
always convert it to '*' in 1 byte unit.
For example,
2 byte character is converted to "* *"
and 3 byte character is converted to "* * *"
However, this does not match the number of '*' printed in the entry.
Because, '*' in the entry is printed according to number of unicode characters.
This patch converts plain_text into unicode units
when converting plain_text to '*'
Test Plan: N/A
Reviewers: woohyun
Reviewed By: woohyun
Subscribers: cedric, #reviewers, jihoon, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10792
Woochanlee [Wed, 4 Dec 2019 08:19:12 +0000 (17:19 +0900)]
Revert "ecore_buffer: Fix ABI break"
This reverts commit
2e3c342f1a9f5f60cc35072d6437d3d393e3d3b7.
Change-Id: Ibb0b8c582ce32df72f421063b6c3f0342cb10cc0
Woochanlee [Wed, 4 Dec 2019 05:15:56 +0000 (14:15 +0900)]
ecore_buffer: Fix ABI break
Change-Id: I5639130566e4af80ad0c14c6235aff79c471677c
Alastair Poole [Tue, 3 Dec 2019 18:50:38 +0000 (18:50 +0000)]
FreeBSD: Link against OpenSSL in base.
Summary:
When pulling in OpenSSL and building against the
port there are some linker complications.
For example, doing a TLS HTTP transaction will
crash in libcurl which was built against
OpenSSL in base. If we link against FreeBSD's
OpenSSL these issues are resolved.
Test Plan:
On FreeBSD use the openssl port and build EFL
against it.
1) Upload a screenshot in E (segv).
2) Click on a link to image in terminology over
HTTPS (segv).
Reviewers: bu5hm4n, raster
Reviewed By: raster
Subscribers: cedric, Peter2121, #reviewers, q66, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10789
Xavi Artigas [Tue, 3 Dec 2019 17:03:56 +0000 (18:03 +0100)]
Efl.Canvas.Gesture_Zoom: typo in docs
Woochanlee [Tue, 3 Dec 2019 15:59:12 +0000 (10:59 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_title functions
Summary:
tests/ecore_wl2: Add test for ecore_wl2_window_title functions
ref T8016
ref D10743
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8016
Differential Revision: https://phab.enlightenment.org/D10761
Woochanlee [Tue, 3 Dec 2019 15:49:37 +0000 (10:49 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_class functions
Summary:
tests/ecore_wl2: Add test for ecore_wl2_window_class functions
ref T8016
ref D10743
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8016
Differential Revision: https://phab.enlightenment.org/D10759
Christopher Michael [Tue, 3 Dec 2019 15:47:32 +0000 (10:47 -0500)]
ecore-wl2: Move ecore_wl2_window_buffer_transform_set to be internal
This function is unused outside of EFL internals, so there is no need
for it to be a public API.
ref T8013
Christopher Michael [Tue, 3 Dec 2019 15:40:21 +0000 (10:40 -0500)]
ecore-wl2: Move ecore_wl2_window_buffer_attach to be internal
As this function is not used outside of EFL itself, it can be moved to
be internal and not an exposed API function
ref T8013
Xavi Artigas [Tue, 3 Dec 2019 12:51:52 +0000 (12:51 +0000)]
Efl.Ui.Spotlight_Container: update docs after push/pop changes
Differential Revision: https://phab.enlightenment.org/D10784
Marcel Hollerbach [Tue, 3 Dec 2019 11:00:20 +0000 (12:00 +0100)]
efl_ui_spotlight_manager_stack: fix positioning
we also need to reemit the position of current active element. Otherwise
the indicator will display a wrong value.
This is already done in any other spotlight manager.
fixes T8499
Differential Revision: https://phab.enlightenment.org/D10782
Marcel Hollerbach [Tue, 3 Dec 2019 10:48:56 +0000 (11:48 +0100)]
efl_ui_spotlight_container: reverse push and pop semantics
before this commit, push would add before the current element, pop would
return to the next higher element.
after this commit, push would add after the current element, pop would
return to the previous element.
ref T7991
Differential Revision: https://phab.enlightenment.org/D10781
Carsten Haitzler (Rasterman) [Tue, 3 Dec 2019 09:18:35 +0000 (09:18 +0000)]
eina - threadqueue - revert series of comments that moved to mempools
Revert "eina: remove no longer used function _eina_thread_queue_msg_block_real_free"
This reverts commit
695b44526c968787374fd421327422a6eea710a7.
Revert "eina/threadqueue: use mempool_del for hash free function"
This reverts commit
b0cb3b935a8faf2d67bae38a54683946cb01d0b9.
Revert "eina_thread_queue: use normal mempools for block allocation"
This reverts commit
14ae3e3dec7866e74f2990dca417eac44da41058.
Why? Threadqueue is a highly performance sensitive API.
_eina_thread_queue_msg_block_new() may be called quite often. Doing a
hash lookup to then find a mempool handle to then allocate from was
not the same as what was there and was going to be far more costly.
This would have actual performance impact as we have to compute a hash
and rummage through a hash, hunt for an environment var too. The
original code looked at a spare block pool where blocks *MAY* be of
different sizes (not always the same size so using a mempool is
actually wrong and will stop threadqueue from being able to send
larger messages at all). If you send large messages, larger blocks would
have been allocated and put in this pool. In almost all cases the first
item in the pool would be big enough so we don't hunt and the find pulls
out the first memory, resets the fields that are needed and returns that
block. If it needs a bigger one, it does hunt. This is going to be
rare that such big blocks are needed so I never tried to optimize this
(but it could be done with an array of sizes to make a walk to find
the right sized element cheap if the need arises).
Performance dropped quite a lot. On aarch64 The above mempool usage
dropped message rate from 1037251 msg/sec to 610316. On x86 it was even
worse. It dropped from 2815775 msg/sec to 378653.
So backing this out sees the message rate is 7.4 times faster and on
aarch64 it's 1.7 times faster.
So moving to a mempool was actually just wrong (size is not always the
same). Also this ended up with a mempool of 64k for thread queue blocks even
if we only sent messages sporadically, as opposed to a single 4kb
block. So backing this out saves memory by only having 1 or 2 4k blocks
around most of the time, not a 64k mempool.
So the above patch then follow-on patches were done without accounting
for the performance implications. There were good reasons to do what I
did - because this code was highly tuned even to the point where I
used atomics instead of locks specifically to cut down some contention
overhead. Beware when you change something that there may be steep
performance implications. 7.4 times faster to go back to what was
there is a great example.
Stefan Schmidt [Thu, 28 Nov 2019 14:39:43 +0000 (15:39 +0100)]
elementary_test: remove duplicated file
This file is identical with test_naviframe.c and has no reference in our
build system. Found by the use of the Duplo duplicated code checker
tool.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10777
Woochanlee [Tue, 3 Dec 2019 07:14:29 +0000 (07:14 +0000)]
gesture_manager: Changed function param to reduce internal function calls.
The filter_event function calling a lot of times when it runs.
This can help performance by reducing the number of calls to the efl_data_scope_get() function.
Reviewed-by: Hermet Park <hermetpark@gmail.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10437
Hosang Kim [Tue, 19 Nov 2019 09:33:14 +0000 (18:33 +0900)]
ecore_con: fix double close fd
sometimes socket fd is closed twice.
@tizen_only
Change-Id: Ieb2c3e982160d10e6bd0333c82df4af34b0e1d18
Lauro Moura [Mon, 2 Dec 2019 19:23:29 +0000 (16:23 -0300)]
csharp: Simplify field_argument_assignment
Summary: Avoid extra generator calls.
Reviewers: jptiz
Reviewed By: jptiz
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10774
Carsten Haitzler (Rasterman) [Mon, 2 Dec 2019 19:53:31 +0000 (19:53 +0000)]
fix jpeg loading which freed the wrong ptr
fixes T8497
@fix
Chris Michael [Mon, 2 Dec 2019 17:39:55 +0000 (12:39 -0500)]
tests/ecore_wl2: Fix bad window test
Small patch to fix issue where merge of patch did not go so well, and
thus caused Coverity to report an issue where window was not being
initialized.
ref T8016
fixes CID1408311
Marcel Hollerbach [Mon, 2 Dec 2019 15:25:36 +0000 (16:25 +0100)]
introduce efl_ui_{pager/scroller}
They are just helpers, so a user does not need to handcreate spotlight
managers. This also leaves us the possibility of letting
spotlight_managers beeing @beta.
ref T7991
Differential Revision: https://phab.enlightenment.org/D10773
Marcel Hollerbach [Thu, 28 Nov 2019 18:31:04 +0000 (19:31 +0100)]
efl_ui_test_spotlight: check correct transitions without animation
this introduces the test requested in D10701. And checks that all
signals are correctly delivered even if animations are frozen
Differential Revision: https://phab.enlightenment.org/D10767
Marcel Hollerbach [Thu, 28 Nov 2019 16:13:07 +0000 (17:13 +0100)]
efl_ui_spotlight_container: bring in min / max handling
the spotlight now is setting the overall correct min and max size on
itself. Additionally, the page size is now clamped to the size of the
container.
Correct min size of the container is defined to the MAX min size of all
the content.
The correct max size of the container is defined to the MIN max size of
all the content.
ref T7991
Differential Revision: https://phab.enlightenment.org/D10766
Marcel Hollerbach [Wed, 27 Nov 2019 17:34:40 +0000 (18:34 +0100)]
efl_ui_spotlight: do not inherit from layout anymore
before we inherited from layout, however the theme of the layout was
basically just the event part, and the holder part for the indicator.
The indicator part is going to be refactored into something else
anyways, since the indicator should be useable on other widgets as well.
Which means, only the event part is left, which is only used by the
scroller spotlight manager, (and now moved there).
With the move from this away we are saving round about 0.2KB of pure
edje accounting. Additionally, we are saving in perf 4% that is spend in
_efl_canvas_layout_efl_gfx_entity_size_set, which also makes this less
CPU intensive when resizing (Or even just starting is also enough).
ref T7991
Differential Revision: https://phab.enlightenment.org/D10765
Marcel Hollerbach [Wed, 27 Nov 2019 17:30:00 +0000 (18:30 +0100)]
efl_ui_spotlight_indicator: make this undependend from the main widget
the main widget before presented a layout to hold the indicator,
however, for the causual case, this is not really needed. The indicator
itself is anyways going to be a more general prupose widget soon, where
the layout here can be taken as an starting point.
Additionally, this fixes general displaying of the indicator, before the
box padding refactor, a padding would have changed the minsize of the
mix, this is not the case anymore, which forces us to calculate the
minsize of the indicator theme.
Differential Revision: https://phab.enlightenment.org/D10764
Marcel Hollerbach [Wed, 27 Nov 2019 16:04:24 +0000 (17:04 +0100)]
efl_ui_spotlight: move event rectangle
for now the eventrect was a swallow part, created by the container, set
to the edje layout. However, the only real user for this is the scroll
spotlight manager.
Which means, we have mostly unneeded element resized by edje, which is
quite an overhead. With this commit, this is moved to the scroll
manager, which makes the usage with stack and plain less memory heavy.
Differential Revision: https://phab.enlightenment.org/D10763
Marcel Hollerbach [Wed, 27 Nov 2019 15:29:37 +0000 (16:29 +0100)]
efl_ui_spotlight: ensure correct positioning
if something is just repositioned, but not resized, it would not have
been placed correctly. This fixes that.
Differential Revision: https://phab.enlightenment.org/D10762
Ali Alzyod [Mon, 2 Dec 2019 09:41:35 +0000 (10:41 +0100)]
efl_canvas_text: documentation for style set
Summary:
Depends on D10607
Original Material: https://www.enlightenment.org/_legacy_embed/evas_textblock_style_page.html
Reviewers: woohyun, segfaultxavi, AbdullehGhujeh
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10729
Marcel Hollerbach [Mon, 2 Dec 2019 15:29:35 +0000 (16:29 +0100)]
efl_part: declare stable
Summary:
last release we declared efl_part.eo stable. But we accidently forgot
efl_part()...
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10772
Woochanlee [Mon, 2 Dec 2019 13:51:49 +0000 (08:51 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_aspect functions
Summary:
tests/ecore_wl2: Add test for ecore_wl2_window_aspect functions
ref T8016
ref D10743
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8016
Differential Revision: https://phab.enlightenment.org/D10747
Woochanlee [Mon, 2 Dec 2019 13:50:23 +0000 (08:50 -0500)]
ecore_wl2: Add APIs to get window properies.
Summary: Creates APIs to get property.
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10743
Hermet Park [Mon, 2 Dec 2019 11:40:28 +0000 (20:40 +0900)]
Revert "Revert "evas map: diable high quality texture mapping feature.""
This reverts commit
94c193e40b3111664344bf41beb22006bfab2670.
Daniel Kolesa [Mon, 2 Dec 2019 11:06:34 +0000 (12:06 +0100)]
eolian_gen: fix fallback 0 default values for slices
Daniel Kolesa [Mon, 2 Dec 2019 11:06:11 +0000 (12:06 +0100)]
eolian: emit correct c_name for keyword builtins
Marcel Hollerbach [Mon, 2 Dec 2019 07:53:24 +0000 (08:53 +0100)]
eolian_aux: do not leak
Ali Alzyod [Mon, 2 Dec 2019 01:56:12 +0000 (10:56 +0900)]
efl_canvas_text: correct password behaviour with efl_text_password_get/set
Summary:
In simple words:
when we create efl_canvas_text object, efl_text_password_get will return TRUE.
which is wrong,
efl_text_password_get should return FALSE, unless user change the password using efl_text_password_set
Reviewers: woohyun, zmike, segfaultxavi, tasn
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10735
Carsten Haitzler (Rasterman) [Sun, 1 Dec 2019 22:56:15 +0000 (22:56 +0000)]
edje - min calc - ix more regressions due to optimizations
again
37b55172b0d46d71f772af8fba17e1fb1b7c6c2c broke min size calc.
this time it was for mouse cursors. the entry cursor was 0 sized after
commit
37b55172b0d46d71f772af8fba17e1fb1b7c6c2c. this disables the
"don't cacle if its 0 sized) which isnt a valid thing to skip - you
caqn min size calc a 0x0 edje ... and it should then return a valid
min size given that design/layout.
Kunal Sinha [Mon, 2 Dec 2019 06:28:53 +0000 (15:28 +0900)]
edje json: ++exception handling.
Change-Id: I7e7ff93c05cc92dde00c701e79b6e5e69a174128
Kunal Sinha [Mon, 2 Dec 2019 06:22:16 +0000 (15:22 +0900)]
gengrid: ++security code.
snprintf() is safter than sprintf() at memory buffer overflow.
Change-Id: Ied4dcb035608eb96c5ba897795e70d3922951276
Hosang Kim [Fri, 29 Nov 2019 12:55:59 +0000 (21:55 +0900)]
efl_wearable: fix symbol link error
Some APIs are not linked, because of the order in which header files are
declared.
Change-Id: If118ca27cc5c2b55f53c5172a53d0844ebcdf6dc
Hermet Park [Fri, 29 Nov 2019 02:18:15 +0000 (11:18 +0900)]
vector cache: skip animation update as possible.
Since the vector file data is shareable among the multiple vg instances,
vfd could keep the requested frame data already by the other instance.
This case vector cache quickly return the vector data withouth any further progress.
Change-Id: Ibea9833b56018602f6447da51fc8b62e4649f592
Hermet Park [Fri, 29 Nov 2019 01:48:59 +0000 (10:48 +0900)]
evas vector: operate cached vector file data per evas instances.
each vfd loaders construct vector tree data, these can be belongs to evas instance,
they are not likely shareable.
We should operate vfd separately.
Change-Id: Ib1a4cb07cc94815e1f5a7c8aeac4437e69d98bc2
Alastair Poole [Sun, 1 Dec 2019 15:45:39 +0000 (15:45 +0000)]
icon_dummy: replace existing image.
This icon is used whenever an icon cannot be found. It's most
commonly found within E itself. The previous iteration has been
with us since at least Black and White (theme), which is pre
E17. Tried to keep it simple yet informative.
Lauro Moura [Fri, 29 Nov 2019 13:48:09 +0000 (10:48 -0300)]
eo files: Avoid container<ptr(value_type)> usage.
Summary:
Value types are already assumed to be stored by pointer (e.g.
`int val = *(node->data);`)
This commit just changes the current usage of the `ptr` modifier in the
ptr, not affecting the parser.
Reviewers: q66, segfaultxavi, bu5hm4n, felipealmeida
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers, brunobelo
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10769
Woochanlee [Fri, 29 Nov 2019 13:55:19 +0000 (08:55 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_available_rotations functions
Summary:
tests/ecore_wl2: Add test for ecore_wl2_window_available_rotations functions
ref T8016
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8016
Differential Revision: https://phab.enlightenment.org/D10755
Yeongjong Lee [Fri, 29 Nov 2019 09:43:23 +0000 (10:43 +0100)]
elementary: stabilize Efl.Ui.Relative_Container
Summary: ref T8380
Reviewers: segfaultxavi, woohyun, zmike, bu5hm4n, cedric
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8380
Differential Revision: https://phab.enlightenment.org/D10641
Marcel Hollerbach [Wed, 18 Sep 2019 19:47:08 +0000 (21:47 +0200)]
here comes a new example
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10733
WooHyun Jung [Fri, 29 Nov 2019 04:15:48 +0000 (04:15 +0000)]
efl_ui_position_manager_grid: avoid zero division case
This fixes the issue of zero division when columns is zero.
Sometimes columns can be zero when "pd->viewport.w = 0".
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10768
Hermet Park [Fri, 29 Nov 2019 02:18:15 +0000 (11:18 +0900)]
vector cache: skip animation update as possible.
Since the vector file data is shareable among the multiple vg instances,
vfd could keep the requested frame data already by the other instance.
This case vector cache quickly return the vector data withouth any further progress.
Hermet Park [Fri, 29 Nov 2019 01:48:59 +0000 (10:48 +0900)]
evas vector: operate cached vector file data per evas instances.
each vfd loaders construct vector tree data, these can be belongs to evas instance,
they are not likely shareable.
We should operate vfd separately.
Woochanlee [Fri, 29 Nov 2019 07:57:17 +0000 (16:57 +0900)]
ecore_evas: Fix build warnings.
Change-Id: I34b6261da405408a5da3b1dd4b0ae2584117a10e
Suresh Kumar [Tue, 12 Nov 2019 12:37:37 +0000 (18:07 +0530)]
[Gengrid] Fix for circle gengrid item position calculation
sd->circle.enabled condition is not true for circle gengrid style.
Change-Id: I1a6cbfd69417012cfb7e63221315ab0e84c2c363
Signed-off-by: Suresh Kumar <suresh.ku1@samsung.com>
Yeongjong Lee [Fri, 29 Nov 2019 02:34:47 +0000 (11:34 +0900)]
efl_ui_win: remove beta
Efl.Ui.Win hase been stablized on upstream.
Change-Id: I35f49c91c8b00cabbc30d1074a7d024c1e257e95
Woochanlee [Fri, 29 Nov 2019 06:51:41 +0000 (15:51 +0900)]
ecore_audio, ecore_buffer, ecore_wl2 : Fix build warnings.
Change-Id: I907a9b0a626c855129d2c424a34caf9890adf232
Xavi Artigas [Thu, 28 Nov 2019 17:13:47 +0000 (18:13 +0100)]
docs: nitpicking
We should not refer to individual library names anymore. They are all
part of EFL now!
Vincent Torri [Thu, 28 Nov 2019 11:06:24 +0000 (11:06 +0000)]
ecore_win32: fix compose event field
Summary:
compose event field was encoded in UTF-16 and not UTF-8. Also string
event field was not correctly defined and was generating eina error
messages
Test Plan: running a test
Reviewers: raster, cedric, zmike
Reviewed By: raster
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10753
Xavi Artigas [Thu, 28 Nov 2019 10:08:11 +0000 (11:08 +0100)]
Efl.Canvas.Text: Further update docs
Xavi Artigas [Thu, 28 Nov 2019 10:03:55 +0000 (11:03 +0100)]
Efl.Canvas.Text: Update docs
Stefan Schmidt [Thu, 28 Nov 2019 07:52:22 +0000 (08:52 +0100)]
ci: ensure we still test ephysics in all enabled build job
With commit
523a64d2265c13a82ba73022d10919f0e392bab2 we switched the
default for ephysics from true to false. This would result in no CI
coverage if we do not explicitly enable it in this job.
Reviewed-by: Carsten Haitzler (Rasterman) <raster@rasterman.com>
Differential Revision: https://phab.enlightenment.org/D10757
Ali Alzyod [Thu, 28 Nov 2019 07:55:26 +0000 (16:55 +0900)]
Polish text interface methods
Summary:
This patch is set to rename some properties of `Efl.Text_Font` & `Efl.Text_Format` interfaces.
1- efl_text_font_set/get become (efl_text_font_family_set/get, efl_text_font_size_set/get)
2- efl_text_valign/halign become efl_text_vertical/horizontal_align
3- efl_text_halign_auto_type become efl_text_horizontal_align_auto_type
Reviewers: ali.alzyod, woohyun, segfaultxavi, bu5hm4n, zmike, cedric
Reviewed By: woohyun
Subscribers: zmike, #committers, #reviewers, cedric
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10716
abdulleh Ghujeh [Thu, 28 Nov 2019 07:46:30 +0000 (16:46 +0900)]
Efl Canvas Text : Update style parsing code
Summary:
Based on comments in D10607
Update code responsible for parsing "style=" :
-Update string parsing code
-Make the old and new code more readable
-Add tests
Reviewers: segfaultxavi, bu5hm4n, woohyun, ali.alzyod
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10715
Hermet Park [Thu, 28 Nov 2019 06:04:56 +0000 (15:04 +0900)]
vector container: skip only for composition types.
Hermet Park [Thu, 28 Nov 2019 04:38:32 +0000 (13:38 +0900)]
evas vector: make it stable caching logic.
We need a more precise caching mechanism to save memory.
Current root node(key) is limited for caching buffers,
when to share by the multiple animated instances.
This patch is a step for further optmization work,
at the moment we disable the caching buffers for the animated instances.
Change-Id: Ifda143d24bd10bb991a0c15c7d165cb6eef5bf14
abdulleh Ghujeh [Thu, 28 Nov 2019 04:14:15 +0000 (13:14 +0900)]
Efl Canvas Text : Modify Style Property
Summary:
This patch defines the way style property will work at canvas_text object
1- Changing canvas_text style property using Font/Format/Style interfaces or with efl_canvas_text style property are the same.
Example:
```
efl_text_font_set(tb, "Arial", 30);
//is same as
efl_canvas_text_style_set(tb, "font=Arial font_size=30");
//which means calling
char * font;
int size;
int font_size;
efl_text_font_get(tb, &font, &size);
// calling this after any of the top two functions will return same result
```
2- style_get_property
Will return string that contains full details about all the current applied style at canvas_text level.
3- style_set_property
Will only override passed styles and leave everything else as it is
```
efl_canvas_text_style_set(tb, "font=Arial"); // overrider font name to Arial and leave everthing else
efl_canvas_text_style_set(tb, "font_size=30"); // overrider font size to 30 and leave everthing else (font name will stay arial)
```
Reviewers: ali.alzyod, woohyun, tasn, segfaultxavi, bu5hm4n, zmike
Reviewed By: woohyun
Subscribers: zmike, bu5hm4n, segfaultxavi, a.srour, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10607