Seonah Moon [Wed, 8 Feb 2023 13:41:41 +0000 (22:41 +0900)]
Do not use CURLAUTH_ANY
Curl known issue.
https://curl.se/docs/knownbugs.html#libcurl_can_fail_to_try_alternat
6.6 libcurl can fail to try alternatives with --proxy-any
https://github.com/curl/curl/issues/876
Change-Id: I31ce09e8bb3c8286804224df23e4fbfdba663aa5
Seonah Moon [Tue, 7 Feb 2023 11:34:00 +0000 (20:34 +0900)]
bug fix: handle empty proxy address
1. Revert
e09e63a4a974ec9e6f2c094d7562bc89cb3452f8
2. Exception handling for empty proxy address
Change-Id: I012edb83c505cc8c17d6078dfdaa75c291164112
pyun [Tue, 7 Feb 2023 05:55:14 +0000 (14:55 +0900)]
Fix the download fail issue on the normal environment
Change-Id: Ib6ddcbe831dad72e5188f44a598cb3bd5d847bd8
Signed-off-by: Dohyun Pyun <dh79.pyun@samsung.com>
Anjali Nijhara [Wed, 1 Feb 2023 06:58:50 +0000 (12:28 +0530)]
Get status code using CURLINFO_HTTP_CONNECTCODE when using proxy
Change-Id: I93309e8c3ba38e0e7c70b389ac8c6e6caa80b258
cheoleun moon [Wed, 28 Dec 2022 10:20:08 +0000 (19:20 +0900)]
Use the same type to compare values
Change-Id: I98c2c1bb5ee85fe15de100340c19a00530d7f3cd
Signed-off-by: cheoleun moon <chleun.moon@samsung.com>
Seonah Moon [Thu, 20 Oct 2022 13:09:43 +0000 (22:09 +0900)]
Fix svace issues
- SEC_DO_NOT_USE_INT_IN_FOR_LOOP
- SEC_DO_NOT_CAST_LONG_TO_DOUBLE
Change-Id: I0b0fb1f1ccdd00f0281cc404c153cf35e58a7d7a
Seonah Moon [Wed, 30 Mar 2022 06:03:35 +0000 (15:03 +0900)]
Change the naming rule for duplicate files
Change-Id: I25a3010f7e3b8f76deccbfa44ac08966b9fc8441
Seonah Moon [Tue, 29 Mar 2022 01:58:16 +0000 (10:58 +0900)]
Increase max header length to 4096 bytes
Change-Id: I1427ebddbd1f564eef1879ba922b39af96ad5608
Seonah Moon [Mon, 7 Feb 2022 05:50:25 +0000 (14:50 +0900)]
Retry read() when getting EAGAIN
When download is requested from new client, client DB including several tables is created.
This often takes long time on RPI4 and makes IPC error(EAGAIN) in the end.
Change-Id: Ib28dcc22e929d11fe61e5f1690f7da64ee5465b8
Seonah Moon [Fri, 7 Jan 2022 06:26:54 +0000 (15:26 +0900)]
Do not change a permission of files stored in external storage
Change-Id: I1971284beff321a28d50b2e4769cdcf72a441eab
Seonah Moon [Thu, 25 Nov 2021 08:47:55 +0000 (17:47 +0900)]
Change ownership of downloaded file to client's uid
Increase version to 2.3.0 for Tizen 7.0
Change-Id: Ib4c79ee3b20404546a0e459d8964635f143de755
Seonah Moon [Mon, 9 Aug 2021 10:03:36 +0000 (19:03 +0900)]
Fix NULL pointer dereference
Change-Id: I9d2cf34fc9e924da5dec01d5229c4b7532b35f48
Seonah Moon [Tue, 6 Jul 2021 08:54:39 +0000 (17:54 +0900)]
Retry read() when getting EINTR
Change-Id: I476b3db2a3dfb6519d885c67c052914201eeca4c
Seonah Moon [Thu, 27 May 2021 02:34:32 +0000 (11:34 +0900)]
Remove stale data from a client DB when client is terminated
[Problem]
a client DB size is increased unlimitedly when a client is terminated by
itself or a crash.
[Cause]
a client DB is cleaned only if a client is live and has no response
during 2 minutes.
Change-Id: Ib164be4cf446bd6c30b0bc89b50d902b0cc5955f
Cheoleun Moon [Tue, 18 May 2021 04:25:27 +0000 (13:25 +0900)]
Remove an error code to be overwritten
Change-Id: I4f582c81220d42dcf8fb7945b168a439fdcf59f2
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
Cheoleun Moon [Tue, 18 May 2021 04:18:56 +0000 (13:18 +0900)]
Add missed unlock
Change-Id: I9ad8f4f9525e2f9c8f5b43ec7994469a6c68cd4f
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
Seonah Moon [Thu, 25 Mar 2021 07:54:27 +0000 (16:54 +0900)]
Avoid to use stat() function
Doing something after checking of the state of a file has a potential
race condition bug. It is more effiecient that just using execption
handling instead of checking to prevent TOCTOU.
Change-Id: I2a2560d9d49ed9d52008557f0d2f89fa04bb130d
Seonah Moon [Wed, 17 Mar 2021 09:14:43 +0000 (18:14 +0900)]
snprintf(): use sizeof() for size factor
Change-Id: I9a94e6c82b1bd40f06d66e8e2bec13a860ce5f20
INSUN PYO [Wed, 3 Feb 2021 04:24:57 +0000 (13:24 +0900)]
Change systemd-devel package name
Change-Id: I90d548f1f86be4df188fff33d291b6122edbe939
Seonah Moon [Tue, 27 Oct 2020 06:54:39 +0000 (15:54 +0900)]
Change the type of some log messages from DEBUG to INFO
TV image doesn't show DEBUG message.
Change-Id: I6febbb33c936bbb7f3d9440faf8e01681b842179
Seonah Moon [Thu, 8 Oct 2020 03:25:27 +0000 (12:25 +0900)]
Limits concurrent downloads to 15 on TV
Change-Id: Ib70042cd7c9e6f875e7c32cef76e434ec7d6e77a
Seonah Moon [Thu, 17 Sep 2020 01:47:58 +0000 (10:47 +0900)]
Do not free http_info in client request thread
http_info is used in download thread and it is freed if download is
finished.
However, in pause state, client request thread releases http_info if
client requests 'cancel'.
This makes a crash occasionally during download thread is terminating.
So, download thread should have ownership of http_info and this thread
should free it only.
Change-Id: Ia3ec64d1ce64e2aee49e260b901686a4ae6d4d76
Seonah Moon [Wed, 16 Sep 2020 01:29:33 +0000 (10:29 +0900)]
Fix heap-use-after-free
In case of below scenario, da_info is freed immediately after cancel
request.
[client request thread] [http thread]
1. download start
2. network doesn't work temporary
3. wait for auto retry (pthread_cond_timedwait(cond_http))
4. request cancel
5. pthread_cond_signal(cond_http)
6. free da_info
7. access to da_info for
debugging message
(fault)
Change-Id: I3bf0002e643af77dac17f69c543d29570c1f3cde
Seonah Moon [Thu, 13 Aug 2020 08:37:48 +0000 (17:37 +0900)]
Wait for download thread before destroying da_info
A cancel request doesn't take effect immediately. (__http_gotheaders_cb)
So, below scenario can occur.
1. client-request thread requests cancel a download for a number of reasons. (ex. zombie client)
2. client-request thread is terminated.
3. queue-manager deallocates da_info_list for terminating.
4. download is canceled and then a http thread accesses to da_info for notifying download terminated.
5. heap-use-after-free occurs.
Change-Id: I47a7ef4c4d7ddda5f4594ee30885e3af230c6116
Seonah Moon [Thu, 6 Aug 2020 08:41:05 +0000 (17:41 +0900)]
Fix invalid data type of parameter
Change-Id: I0e64b2fea19ca48dac78e53c2ffa3cf2bbc6106b
Cheoleun Moon [Mon, 6 Jul 2020 09:32:43 +0000 (18:32 +0900)]
Free proxy_uri
In condition that proxy_uri is "0.0.0.0", proxy_uri is not freed.
Change-Id: Ifd3759c1a7b416cd69fc134eb653b0a5802a7a73
Seonah Moon [Thu, 2 Jul 2020 05:34:15 +0000 (14:34 +0900)]
Return error when status code isn't 2XX or 3XX
Change-Id: Ie2a85db0c87060f9f275a0f86b075eefde284136
Seonah Moon [Tue, 30 Jun 2020 08:04:41 +0000 (17:04 +0900)]
SAM: remove Global Variable violations
Change-Id: Ib3b4b47aa62517df80ea446ba405fd3f5caa5d33
Seonah Moon [Wed, 3 Jun 2020 11:45:04 +0000 (20:45 +0900)]
Do not unload agent symbol file
If symbol file is unload before terminating program, segfault can occur
when access to static variable. (ex. mutex_da_info_list)
Change-Id: I9e6c61f2d45264682755d5717d85943e5b5c44a3
Seonah Moon [Wed, 3 Jun 2020 11:50:10 +0000 (20:50 +0900)]
Revert "Do not unload agent symbol file"
This reverts commit
37808dc1789f8a3cdb99ce698ac38ec3a917a047.
Seonah Moon [Wed, 3 Jun 2020 11:45:04 +0000 (20:45 +0900)]
Do not unload agent symbol file
If symbol file is unload before terminating program, segfault can occur
when access to static variable. (ex. mutex_da_info_list)
Change-Id: I9e6c61f2d45264682755d5717d85943e5b5c44a3
cheoleun moon [Wed, 22 Apr 2020 05:30:09 +0000 (05:30 +0000)]
Merge changes I780f6179,I29223a72,I4e5182dd into tizen
* changes:
Refine __dp_client_new()
Add a function to handle init request
Use additional functions in dp_client_manager()
Seonah Moon [Fri, 17 Apr 2020 07:11:35 +0000 (16:11 +0900)]
Allow cancel request when download state is paused
download-provider cannot be terminated in case of below scenario.
1. application requests a pause.
2. download-provider pauses the download request.
3. application requests a cancel.
4. the download request couldn't be canceled because a state is paused.
5. http thread is alive constantly.
Change-Id: I7b2566bce98b3e563e2b5980c908a92140ffdcd9
Cheoleun Moon [Fri, 17 Apr 2020 06:21:22 +0000 (15:21 +0900)]
Refine __dp_client_new()
Change-Id: I780f6179436819d471b4e99f2cc2387bc432d025
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
Seonah Moon [Thu, 16 Apr 2020 11:33:40 +0000 (20:33 +0900)]
Add some functions to check request status
Change-Id: I76583efe22dd4ff7bd0d7151d8ab6f9de02bb3ae
Cheoleun Moon [Thu, 16 Apr 2020 11:14:05 +0000 (20:14 +0900)]
Add a function to handle init request
Change-Id: I29223a721e50b0b06a19a329bfdcffaf436bbbbf
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
Cheoleun Moon [Thu, 16 Apr 2020 10:38:49 +0000 (19:38 +0900)]
Use additional functions in dp_client_manager()
Change-Id: I4e5182ddae71600264cfe10e4ac69d88efa3c11d
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
Seonah Moon [Thu, 16 Apr 2020 09:59:24 +0000 (18:59 +0900)]
Remove unnecessary predefined preprocessor
Change-Id: I376d831575e9c22e03691faa7ba0e3d76f682e63
Seonah Moon [Wed, 1 Apr 2020 08:54:59 +0000 (17:54 +0900)]
Change HTTP state properly
Sometimes HTTP thread works abnormally because HTTP state isn't changed
properly.
Change-Id: I5462b6497bd5a7bd64c5b600a00aa7cf3e1954ff
Seonah Moon [Wed, 4 Mar 2020 07:21:08 +0000 (16:21 +0900)]
tv: do not use thread locking function
libcurl has used openssl 1.1 since tizen 6.0.
Change-Id: Ie5b4db0bb7f3f85028373b985f02b3cff1c29db6
Sangwan Kwon [Mon, 2 Mar 2020 03:56:22 +0000 (12:56 +0900)]
Deprecate pubkey-pinning
Pubkey pinning is not supported from tizen-6.0.
Change-Id: Ie3541d9780e70de55d2355e2e2544961a142aa80
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
Seonah Moon [Wed, 19 Feb 2020 05:25:36 +0000 (14:25 +0900)]
Implement internal API for host verification
Change-Id: I0362a6263d177363580ecb95cf6223b611a1b896
seonah moon [Tue, 18 Feb 2020 09:53:33 +0000 (09:53 +0000)]
Merge "Change CA certificate bundle and path for TV" into tizen
Seonah Moon [Tue, 18 Feb 2020 03:49:21 +0000 (12:49 +0900)]
Accept legacy app path to keep backwards compatibility
Change-Id: I6164dd62f8a2c0a55732539a0bd5a73eb772d051
Signed-off-by: Seonah Moon <seonah1.moon@samsung.com>
Seonah Moon [Mon, 17 Feb 2020 08:50:11 +0000 (17:50 +0900)]
Change CA certificate bundle and path for TV
Change-Id: I2029019f151df781ed589646e0b9ed69077f80fa
Seonah Moon [Tue, 21 Jan 2020 09:03:07 +0000 (18:03 +0900)]
Replace app_context API with app_info API for getting package ID
P200120-04045
Change-Id: Id21ffee103b37ec9374e0f5655e3fe73ea7557e2
Seonah Moon [Mon, 20 Jan 2020 02:09:44 +0000 (11:09 +0900)]
[CID-1103253] Fix bad bit shift operation
Change-Id: I91a989c5e6cac89bd64b97bf8ef835c0ac55fdce
Seonah Moon [Fri, 17 Jan 2020 07:30:56 +0000 (16:30 +0900)]
bug fix: add error handling for preventing duplicate file
Change-Id: If3a00019e8b6d6ad586c5e2d5c38b0989c0fa966
Seonah Moon [Thu, 26 Dec 2019 12:38:59 +0000 (21:38 +0900)]
Fix build warnings for gcc9
Change-Id: I57f8c411c130d0b48b9979d5eb0eaa859f239335
Seonah Moon [Tue, 12 Nov 2019 11:39:34 +0000 (20:39 +0900)]
Support proxy authentication
Change-Id: I66b65fe2417db65bb2b0973ca950de2abd7dfea8
Seonah Moon [Fri, 8 Nov 2019 04:21:47 +0000 (13:21 +0900)]
Add ssl thread locking function for openssl 1.0
TV profile doesn't use openssl 1.1 yet.
So, this patch defines thread locking function for TV profile temporaly.
It will be removed or disabled after openssl 1.1 is applied to TV.
Change-Id: Ia7a029b898d85cd84552e0fffe0966e1e14dac8f
Seonah Moon [Thu, 27 Jun 2019 05:10:34 +0000 (14:10 +0900)]
Reduce cyclomatic complexity #1
provider/download-provider-client.c: __dp_request_get_info()
Change-Id: I4332b1611c23e2c521ce23ef0f9822dd858b87c7
Seonah Moon [Tue, 10 Sep 2019 09:04:23 +0000 (18:04 +0900)]
Fix potential thread cancel issue
Change-Id: Id6f37948bfa6b7c3dd61cf2fdc9a585b1f3ec35e
Dariusz Michaluk [Mon, 29 Jul 2019 13:45:11 +0000 (15:45 +0200)]
Migrate to openssl 1.1
Locking mechanism is not needed anymore
Change-Id: If11be650c3366084c7bd28da90b5463348b1c880
cheoleun moon [Tue, 30 Jul 2019 09:26:38 +0000 (09:26 +0000)]
Merge "Remove download-provider.service form graphical.target.wants" into tizen
Seonah Moon [Fri, 26 Jul 2019 08:04:56 +0000 (17:04 +0900)]
Remove unused file
Change-Id: Ic42ed980a559da1fe466392c3015111e5506cd1d
INSUN PYO [Tue, 23 Jul 2019 23:54:59 +0000 (08:54 +0900)]
Remove download-provider.service form graphical.target.wants
Download-provider.service is enabled by socket activation called download-provider.socket.
So, we don't need to execute donwload-provider.service on booting time.
Change-Id: I75df0aa3275174bb053806fede64d1ec77ab9f21
Seonah Moon [Fri, 12 Jul 2019 01:23:02 +0000 (10:23 +0900)]
Remove unnecessary log
Change-Id: I8c54fdbd37fe712c66a798adb4b5a02e5923f22c
cheoleun moon [Wed, 10 Jul 2019 22:52:57 +0000 (22:52 +0000)]
Merge "Change FILE_OFFSET_BITS to 64 bits to support a large file" into tizen
Seonah Moon [Tue, 9 Jul 2019 04:34:02 +0000 (13:34 +0900)]
Limit g_dp_sock size for buffer overflow
[WID-3498058] Buffer 'rset.__fds_bits' of size 32
accessed at dp_client_manager() can overflow,
since its index 'g_dp_sock / 32' can have value
50331680
that is out of range, as indicated by preceding conditional expression.
Change-Id: I6c9c51903faa1df6c207670ab4b63b01038bcb70
Seonah Moon [Fri, 5 Jul 2019 08:03:07 +0000 (17:03 +0900)]
Change FILE_OFFSET_BITS to 64 bits to support a large file
Change-Id: I034da2578c1355a93758fc960431410c7d2edf80
INSUN PYO [Mon, 24 Jun 2019 02:42:25 +0000 (11:42 +0900)]
Remove unnecessary settings on download-provider.socket
Change-Id: Ib12324afbd6ad4ed99025ce4005988674eb8eaea
Seonah Moon [Tue, 25 Jun 2019 00:40:35 +0000 (09:40 +0900)]
Add build macro to avoid conflict with spin
Change-Id: I64918d5f22a4d475b56d056a7eb3a2ce20044929
Seonah Moon [Mon, 24 Jun 2019 06:49:05 +0000 (15:49 +0900)]
Fix merge conflict
Change-Id: Ib014b55edb95b0eafde42b3e39d17ff5929bf1ce
sowmya.b1 [Thu, 6 Apr 2017 13:12:28 +0000 (18:42 +0530)]
Expose new API to set/get http proxy from apps.
Need an API in download provider to set http proxy from app side.
There was no API defined in download provider interface for setting proxy.
Added new API dp_interface_{set,get}_proxy()
Change-Id: Ie79d34cebd4c27f372c7e50a42a0a809f88ca165
Signed-off-by: Sowmya B <sowmya.b1@samsung.com>
Raveendra Karu [Wed, 10 May 2017 05:08:38 +0000 (10:38 +0530)]
Changing download provider notification as in Dowload Manager's notification.
Download provider notification does not display URL information.
Added changes to show URL information in notification.
Also added changes to handle EBUSY case while releasing the acquired lock
on mutex.
Change-Id: I27bfff0495fb7da65fc0fb5deb7bd63b79d7a1a5
Signed-off-by: Sowmya B <sowmya.b1@samsung.com>
Seonah Moon [Tue, 18 Jun 2019 07:38:11 +0000 (16:38 +0900)]
Sync with spin git
Change-Id: Iee53b7172a0076ac80ed457704a01a2edd839ba5
Seonah Moon [Tue, 14 May 2019 08:38:16 +0000 (17:38 +0900)]
[
DF190411-00679] do not handle empty file in case of redirection
Each time content size is 0, empty file is created even if status code means redirection.
(https://review.tizen.org/gerrit/#/c/platform/framework/web/download-provider/+/188428/)
Change-Id: I01e2755e912ae32e1c43c6f182356c05702c3d2d
Seonah Moon [Wed, 8 May 2019 01:45:10 +0000 (10:45 +0900)]
[WGID-372659] reassign fd after using close()
Change-Id: I45081480991bf144dac2a2945e3e898e0b0856fa
Seonah Moon [Tue, 7 May 2019 04:05:42 +0000 (13:05 +0900)]
Remove unnecessary files
Change-Id: I6739a6797dd86383d23e1bfb79e3e949c55ed6ba
Seonah Moon [Tue, 23 Apr 2019 09:46:29 +0000 (18:46 +0900)]
[CID-835380] Access shared data with holding a mutex lock
Change-Id: I4cf8077e4c31c6df5f994b890f389c681a9dabd8
Seonah Moon [Mon, 8 Apr 2019 12:34:28 +0000 (21:34 +0900)]
[
DF190403-00436] Allow shared directory as destination path
Change-Id: Iade2ccfb783fe1475aae2d5b78b4443a9d2ddf2f
Seonah Moon [Mon, 18 Mar 2019 09:09:13 +0000 (18:09 +0900)]
Fix memory leak
Change-Id: I4c16e3d4db431e0b24359bb21694c56403fd1c36
Seonah Moon [Tue, 12 Mar 2019 08:54:14 +0000 (17:54 +0900)]
Do not call pthread_cancel to terminate an event manager thread
Change-Id: I05d840b25ccd59f1bcc30408a86504bc28709f86
Seonah Moon [Fri, 8 Mar 2019 07:04:39 +0000 (16:04 +0900)]
[Security vulnerability] Prevent null pointer dereference
Change-Id: I24e3eab7d754cd5c3794a5eff412270ada9b352d
Seonah Moon [Fri, 8 Mar 2019 05:06:56 +0000 (14:06 +0900)]
Get temp path from download daemon
Even if app doesn't set temp path,
temp path is updated when download is started.
Change-Id: Ifd624581ca42dc1fac5c5aa6b96ea3874297e736
Seonah Moon [Wed, 6 Mar 2019 08:23:29 +0000 (17:23 +0900)]
Convert relative path to absolute path
Even if relative path is passed from user,
absolute path will be delivered to daemon.
Change-Id: I7616eb27f728bda81de4af6bc97aa5ec3b642f5b
Seonah Moon [Mon, 4 Mar 2019 08:39:05 +0000 (17:39 +0900)]
[Security vulnerability] Replace strncmp() with strcmp()
In case comparing whole string, use strcmp().
Change-Id: Iacb667cacece5eb8a964c8dc2219ff0d17908bf3
Seonah Moon [Mon, 4 Mar 2019 09:05:02 +0000 (18:05 +0900)]
[Security vulnerability] Access to a symbolic link
Change-Id: I2207dbe4a72d87cd6665fd27dfc97a30b4617b49
Youngjae Shin [Mon, 11 Feb 2019 04:32:21 +0000 (13:32 +0900)]
fix build error on building gcov mode
Change-Id: I66ab238d807d77cfde9877a62f479545dba6da6f
Cheoleun Moon [Fri, 25 Jan 2019 04:39:53 +0000 (13:39 +0900)]
Use new mutex_lock g_dp_event_mutex to access g_dp_event_thread_id
Change-Id: I5c46017387388a8a734a6a5aafb10b86b9cb967e
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
cheoleun moon [Fri, 25 Jan 2019 04:36:37 +0000 (04:36 +0000)]
Revert "Use mutex_lock to access g_dp_event_thread_id"
This reverts commit
61cb40dc5fdc6cc22dd6a200ce2333f43d3a836a.
Change-Id: If09f0ab1f6b81b07a72824c2526f45fae84338a5
Cheoleun Moon [Thu, 24 Jan 2019 02:02:53 +0000 (11:02 +0900)]
Use mutex_lock to access g_dp_event_thread_id
Change-Id: I8c72f5ea5683e41192251ada63628c8fe1ff42b4
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
Seonah Moon [Thu, 17 Jan 2019 04:25:40 +0000 (13:25 +0900)]
[WGID-370937] fix svace issue(MEMORY_LEAK)
Change-Id: I7ba56013b6f8ab4dfb5d0666d3df040f222e3994
Seonah Moon [Fri, 14 Dec 2018 05:48:06 +0000 (14:48 +0900)]
Fix dlog format error
Change-Id: Ia27a245ba72c34316e2f06ce07f0d8ab0bdf3ffd
Seonah Moon [Wed, 21 Nov 2018 07:56:02 +0000 (16:56 +0900)]
[TNEXT-17554] Fix crash issue
Change-Id: I4ddc18c143592201651e6691ea84695dcbf68074
Seonah Moon [Mon, 15 Oct 2018 04:22:00 +0000 (13:22 +0900)]
[
DF180926-00154] Add speed limit
downloading cannot be canceled in case of no packet.
It's because cancel request is depended on CURLOPT_WRITEFUNCTION.
Therefore, if there is no packet, downloading would be blocked without error.
This patch limits speed and time to prevent this issue.
Change-Id: I13d6538528254f88884d8573cd320608916a9561
Seonah Moon [Thu, 11 Oct 2018 02:52:10 +0000 (11:52 +0900)]
Fixed typo
Change-Id: Ic6fe04e7de87466a8cbad465326695ef6844ea8a
Seonah Moon [Mon, 10 Sep 2018 11:02:35 +0000 (20:02 +0900)]
[CID-1025872] Fix resource leak
Change-Id: I6f95c8d863731b9db1a5c10236eac4c155e2eaff
Seonah Moon [Wed, 5 Sep 2018 05:12:00 +0000 (14:12 +0900)]
Create empty file when content-length is 0
Change-Id: Idd68889083e2e545c0eb48a29af7f9c3bb7c65c3
chleun.moon [Tue, 14 Aug 2018 06:41:56 +0000 (15:41 +0900)]
Check if request is valid to avoid crash
Change-Id: Ic9bb064bbab2bb1386c9aad10a9e7899caddd98f
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
Jaehyun Kim [Mon, 6 Aug 2018 01:55:43 +0000 (01:55 +0000)]
Merge "Fix block issue of main thread" into tizen
Seonah Moon [Fri, 3 Aug 2018 08:50:20 +0000 (17:50 +0900)]
Fix block issue of main thread
Main thread often faces with bloking when pause and resume occur repeatedly.
It's becuase previous resume event causes data packet.
Although pause() is invoked, data packet can be recieved because of previous resume event.
However, download-provider considers this situaition as 'error' state.
This change makes main thread just wait for changing download state properly.
Change-Id: I1e22661fb909d449b94db26aad8bbe2cfb033d8c
Seonah Moon [Fri, 3 Aug 2018 05:13:20 +0000 (14:13 +0900)]
Check request ID before updating download information
downaload thread often accesses to memory which is freed by other thread.
To avoid refering invalid memory, this patch checks whether request ID is
valid or not.
Change-Id: I994bcf73714c2af3d896b07f27534ae8580c0545
Taesoo Jun [Wed, 1 Aug 2018 09:49:02 +0000 (18:49 +0900)]
Fix the variable in the critical sectionfor thread-safety
Change-Id: Ia1578e05cdd78b82d5f24d8821c21f9302932b7a
Signed-off-by: Taesoo Jun <steve.jun@samsung.com>
Seonah Moon [Fri, 27 Jul 2018 07:25:21 +0000 (16:25 +0900)]
Remove unnecessary dependency
Change-Id: Idfef8db8ff40226066b2da1508baa43075597d78
yhji [Tue, 24 Jul 2018 09:44:00 +0000 (18:44 +0900)]
Fix Wformat build error
Change-Id: I33eae328d239242bd272cde275a0d3e79c1db930
Signed-off-by: yhji <yhji.lee@samsung.com>
Seonah Moon [Thu, 19 Jul 2018 07:17:16 +0000 (16:17 +0900)]
Fix invalid path issue
Change-Id: I7aac5194565fefada16c919b48866a59fc0cdc94
cheoleun moon [Tue, 17 Jul 2018 09:42:18 +0000 (09:42 +0000)]
Merge "Add log for debugging" into tizen
Seonah Moon [Tue, 17 Jul 2018 06:55:31 +0000 (15:55 +0900)]
Add log for debugging
Change-Id: Id2f334ac4c8c1ca1952bd357f4e1735f365a9e09