Youngsoo Choi [Sun, 6 Aug 2017 04:27:34 +0000 (04:27 +0000)]
[Bringup] Fix OffScreenRenderWidgetHostView related linking error
The DelegatedFrameHost is not used in chromium-efl.
>> undefined reference to `content::DelegatedFrameHost::WasHidden()'
>> undefined reference to `content::DelegatedFrameHost::ResetCompositor()'
Change-Id: Ibd5631c41153b35bcb8674db48fd57ca1cb2f8ce
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Sun, 6 Aug 2017 05:50:50 +0000 (05:50 +0000)]
[Bringup] Fix security_state related linking error
EFL port needs to be implemented.
>> undefined reference to `security_state::GetSecurityInfo(...)
The chromium-efl does not support security_state.
Change-Id: Ic9332d2ba4e298a5d2ffb21d22d4450c97ba02bf
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Sun, 6 Aug 2017 08:08:37 +0000 (08:08 +0000)]
[Bringup] Fix net related linking error
The net needs to be exported by chromium-efl.
>> undefined reference to `net::CreateProxyServiceUsingV8ProxyResolver(...)
Change-Id: Ic4ac0b535a8586d6695f9a107d3d76c3a7361a4a
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Sun, 6 Aug 2017 08:08:54 +0000 (08:08 +0000)]
[Bringup] Fix widevine_key_system_properties related linking error
EFL port needs to be implemented for
>> undefined reference to `cdm::WidevineKeySystemProperties::
>> WidevineKeySystemProperties(...)'
Change-Id: I3c2aa089b4eab4305833cb897ad7851828a9698c
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Sun, 6 Aug 2017 09:06:28 +0000 (09:06 +0000)]
[Bringup] Fix inspectable_web_contents_view related linking error
EFL port needs to be implemented for inspectable_web_contents_view.
>> undefined reference to `brightray::CreateInspectableContentsView
>> (brightray::InspectableWebContentsImpl*)'
Change-Id: I95c10c2a60afb59bf3454b739214e0248a492831
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Sun, 6 Aug 2017 09:36:21 +0000 (09:36 +0000)]
[Bringup] Fix ShowColorChooser related linking error
EFL port needs to be implemented for ShowColorChooser.
Change-Id: I53f68bd573527f1168d8e5c5d4593ccdd0964eaf
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Wed, 2 Aug 2017 06:14:29 +0000 (06:14 +0000)]
[Bringup] Handle non virtual functions in chromium v56.0.2924.0
There's no virtual functions for followings in chromium v56.0.2924.0
but in chromium v56.0.2924.87.
The opensource patches, related to followings, need to be migrated
to chromium-efl.
bool CanBeEmbeddedInsideCrossProcessFrames();
content::RenderWidgetHost* GetOwnerRenderWidgetHost();
content::SiteInstance* GetOwnerSiteInstance();
void ScriptedPrint(bool user_initiated);
v8::Local<v8::Context> context);
Change-Id: I7a6d56d0c0c7eb89a2cd6f29cb7db4415aa03696
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Wed, 2 Aug 2017 06:14:29 +0000 (06:14 +0000)]
[Bringup] Handle nonexistent function in chromium v56.0.2924.0
The SystemDragEnded's parameters are different
between chromium v56.0.2924.0 and v56.0.2924.87.
Following patches need to be migarated from opensource to chromium-efl.
Until then, this guards the function.
Drag-and-drop: Target drag messages to specific RenderWidgets.
https://codereview.chromium.org/
2505113002
Drag-and-drop: Target drag messages (the sequel).
https://codereview.chromium.org/
2509933002
Change-Id: I1d5aa24826936d30fc293c67380dda8cd1aacb08
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Sat, 5 Aug 2017 10:08:16 +0000 (10:08 +0000)]
[Bringup] Add mockup APIs to bring up EFL port
Following files are added to bring up EFL port.
atom/browser/api/atom_api_menu_efl.cc
atom/browser/api/atom_api_menu_efl.h
atom/browser/api/atom_api_web_contents_efl.cc
atom/browser/common_web_contents_delegate_efl.cc
atom/browser/native_browser_view_efl.cc
atom/browser/native_browser_view_efl.h
atom/browser/native_window_efl.cc
atom/browser/native_window_efl.h
atom/browser/ui/accelerator_util_efl.cc
atom/browser/ui/drag_util_efl.cc
atom/browser/ui/file_dialog_efl.cc
atom/browser/ui/message_box_efl.cc
atom/browser/ui/tray_icon_efl.cc
atom/browser/ui/tray_icon_efl.h
chromium_src/chrome/browser/extensions/global_shortcut_listener_ozone.cc
chromium_src/chrome/browser/extensions/global_shortcut_listener_ozone.h
chromium_src/chrome/browser/icon_loader_efllinux.cc
Change-Id: I170f4b01c6a140159cb1e370880ad466744198b6
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Sat, 5 Aug 2017 07:43:33 +0000 (07:43 +0000)]
Disable desktop_capturer on desktop linux
The chromium-efl supports only tizen webrtc using CAPI.
So, this disables desktop_capturer using webrtc on desktop linux.
Change-Id: Ia6b8481b1347b695ebd07babbbb733cab58bd57c
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Sat, 5 Aug 2017 07:42:21 +0000 (07:42 +0000)]
Add flags for desktop linux
This adds cflags for desktop linux
* Usage in C/C++
#if defined(USE_EFL)
// implementation here
#endif
* Usage in gyp
if (desktop_linux) {
// implementation here
}
Change-Id: I73fb49441fb6581bc87b0a5fba05b1ea6de8a46e
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Wed, 2 Aug 2017 06:10:57 +0000 (06:10 +0000)]
Remove x11, aura, gtk and views dependency
To enable EFL port, the other ports are disabled.
Change-Id: I067bd5ab00d8781cb3b2e33483232a1660a8be54
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Wed, 2 Aug 2017 15:15:54 +0000 (15:15 +0000)]
Support icu library via jhbuild
Change-Id: I1c8a34dc21e234a9123a25c94d165738d3d7c62e
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Wed, 2 Aug 2017 14:07:53 +0000 (14:07 +0000)]
Support EFL libraries via jhbuild
The ecore, elocation, and elementary are added to be linked in build.
Change-Id: Ie021c85e209108bbb51e89baba0fa1dd61a55511
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Wed, 2 Aug 2017 08:13:53 +0000 (08:13 +0000)]
Include header path
In file included from /home/kenshin.choi/blink/workspace/public/chromium-efl/chromium-efl/content/browser/compositor/image_transport_factory.h:15:0,
from /home/kenshin.choi/blink/workspace/public/chromium-efl/chromium-efl/content/browser/renderer_host/delegated_frame_host.h:15,
from ../../atom/browser/osr/osr_render_widget_host_view.h:23,
from ../../atom/browser/api/atom_api_web_contents.cc:20:
/home/kenshin.choi/blink/workspace/public/chromium-efl/chromium-efl/gpu/ipc/common/surface_handle.h:37:2: error: #error Platform not supported.
Change-Id: I901bf6fc3134017dd8e9c81ca8e367835a2c9839
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Sun, 30 Jul 2017 11:03:26 +0000 (11:03 +0000)]
Use platform toolchain
The electron has used toolchain debian_wheezy_amd64-sysroot
that is downloaded from amazon server.
This makes electron use platfrom toolchain.
Change-Id: I59ba9d8954a770b7a95d0c4c2540678acffeb3e9
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Wed, 2 Aug 2017 06:12:33 +0000 (06:12 +0000)]
Refer to desktop sysroot of chromium-efl
Change-Id: Ic4cc6c68cb4ebca5d8fa78e1bedbfa95ad5d7fcf
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Sun, 30 Jul 2017 07:02:42 +0000 (16:02 +0900)]
Build electron linking to chromium-efl
The electron has been liked to prebuilt chromium
that is downloaded from amazon server.
This let electron link to chromium-efl.
Change-Id: I8adc61d9d7f5541bc159943e9eb4f7aa20e75d75
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Sun, 30 Jul 2017 10:57:54 +0000 (10:57 +0000)]
Support c++11 feature
For electron build, c++11 feature is necessary.
Otherwise, tons of errors occur like below.
>> note: C++11 ‘constexpr’ only available with -std=c++11 or -std=gnu++11
>> error: ‘constexpr’ does not name a type
Change-Id: I58307fad59b3d0dfa7ff788797a09564d1337926
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Mon, 31 Jul 2017 02:11:05 +0000 (02:11 +0000)]
Add build script for desktop
The utility script is added for desktop build.
* Usage:
$ ./efl/build/build_desktop.sh --libcc_chromium_efl_path {M56_CHROMIUM_PATH}
Change-Id: Idd020fc5353961e30f50d265acee24c32f830197
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Mon, 31 Jul 2017 05:44:11 +0000 (05:44 +0000)]
Add node module browserify and asar
The added node modules are used by electron build.
>> asar@0.11.0
>> browserify@13.3.0
Change-Id: Iad0ed1db479d4f321b926640e974cb7507dd2ba4
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Fri, 28 Jul 2017 06:14:26 +0000 (15:14 +0900)]
Upload initial electron-related vendors for tizen
The OBS does not allow to use network in build time
and does not support multiple repositories for a project.
So, this removes vendor git submodules and add them as one repository.
The vendor information is like below.
- in electron
f7574aa6cc2c819430c1f05e9a1a1a666ef8169b vendor/boto
c566c50d81f7b1edeaee9f11f5d07bda858d6b64 vendor/breakpad
909c49265493bd095c27cefd999567be2107899a vendor/brightray
eeac857dfb5b255c899c8763d62654863b4c8890 vendor/crashpad
4fa73b8ca6899bc69577932b80145a6bf07e4424 vendor/depot_tools
fd0e7dc4ab778f0d1ccda6c9640464ea06ee771e vendor/native_mate
3fe90cfcf54dd946980e59daf550a7cdb2317c8f vendor/node
a050a339cfeabcfb5f07c313161d2ee27b6c3a39 vendor/pdf_viewer
e4d59bedfd3c7f4f254f4f5d036587bcd8152458 vendor/requests
- in vendor/brightray
549e55a22765ccf99e46b419b2dff6338bcac64a vendor/gyp (heads/master)
44448acf6a21024b9adb7140ffef6402a509f8bf vendor/libchromiumcontent (v51.0.2704.61-225-g44448ac)
- in pdf_viewer
9536fb6429147d27ef1563088341825db0a893cd vendor/grit (9536fb6)
- in breakpad
33a43757f6dadf49cb2240d22f1d0d827bfeae8f src (33a4375)
Change-Id: I36b4e2c117fceeeb6ea6c9361339c2840b6911b7
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Brendan Forster [Thu, 27 Apr 2017 05:12:30 +0000 (15:12 +1000)]
rework docs
Brendan Forster [Thu, 27 Apr 2017 05:06:23 +0000 (15:06 +1000)]
focus on the self-signed certificate flow here
Brendan Forster [Thu, 27 Apr 2017 05:01:55 +0000 (15:01 +1000)]
tighten up indenting
Brendan Forster [Thu, 27 Apr 2017 04:47:50 +0000 (14:47 +1000)]
Merge branch 'master' into certificate-addition-windows
Brendan Forster [Thu, 27 Apr 2017 04:44:58 +0000 (14:44 +1000)]
actually validate the chain before adding
Kevin Sawicki [Wed, 26 Apr 2017 20:03:46 +0000 (13:03 -0700)]
Merge pull request #9299 from electron/menu-item-doc-typos
Fix typos in MenuItem docs
Kevin Sawicki [Wed, 26 Apr 2017 16:06:10 +0000 (09:06 -0700)]
Fix typos
Kevin Sawicki [Wed, 26 Apr 2017 20:02:53 +0000 (13:02 -0700)]
Merge pull request #9290 from electron/coerce-history-go-offset-to-number
Coerce window.history.go offset argument to number in renderer process
Kevin Sawicki [Tue, 25 Apr 2017 21:49:14 +0000 (14:49 -0700)]
Coerce offset to number in renderer process
Kevin Sawicki [Tue, 25 Apr 2017 21:48:01 +0000 (14:48 -0700)]
Add spec for invalid window.history.go offset
Kevin Sawicki [Wed, 26 Apr 2017 19:36:51 +0000 (12:36 -0700)]
Merge pull request #9289 from electron/dont-allow-webpreferences-option-setting
Don't allow webPreferences to be overridden in features string
Kevin Sawicki [Tue, 25 Apr 2017 21:20:39 +0000 (14:20 -0700)]
Don't allow webPreferences to be overrideden in features string
Kevin Sawicki [Tue, 25 Apr 2017 21:19:59 +0000 (14:19 -0700)]
Add spec for webPreferences in features string
Kevin Sawicki [Wed, 26 Apr 2017 17:47:21 +0000 (10:47 -0700)]
Merge pull request #9287 from electron/store-frames-to-guest-as-map
Store frames to guest as Map
Kevin Sawicki [Tue, 25 Apr 2017 20:53:29 +0000 (13:53 -0700)]
Store frame to guests in map
Kevin Sawicki [Tue, 25 Apr 2017 20:52:56 +0000 (13:52 -0700)]
Add specs for window.open frameName argument
Kevin Sawicki [Wed, 26 Apr 2017 17:12:21 +0000 (10:12 -0700)]
Merge pull request #9286 from electron/to-string-renderer-errors
Throw string conversion errors in render process
Kevin Sawicki [Wed, 26 Apr 2017 16:09:42 +0000 (09:09 -0700)]
Fix typos in comment
Kevin Sawicki [Tue, 25 Apr 2017 20:26:47 +0000 (13:26 -0700)]
Convert targetOrigin to string in render process
Kevin Sawicki [Tue, 25 Apr 2017 20:16:28 +0000 (13:16 -0700)]
Convert frameName/features to strings in render process
Kevin Sawicki [Tue, 25 Apr 2017 20:16:07 +0000 (13:16 -0700)]
Add spec for window.open toString errors
Kevin Sawicki [Wed, 26 Apr 2017 16:08:24 +0000 (09:08 -0700)]
Merge pull request #9278 from electron/dont-override-argument-value
Disable node integration in chrome-devtools URLs
Kevin Sawicki [Mon, 24 Apr 2017 17:25:40 +0000 (10:25 -0700)]
Disable node integration in chrome-devtools: URLs
Kevin Sawicki [Mon, 24 Apr 2017 17:25:12 +0000 (10:25 -0700)]
Add spec for chrome-devtools URL with no node integration
Kevin Sawicki [Tue, 25 Apr 2017 20:33:53 +0000 (13:33 -0700)]
Merge pull request #9250 from electron/inherit-javascript-option
Inherit javascript preference in opened windows
Kevin Sawicki [Fri, 21 Apr 2017 18:00:31 +0000 (11:00 -0700)]
Document other inherited web preferences
Kevin Sawicki [Fri, 21 Apr 2017 17:59:33 +0000 (10:59 -0700)]
Disable JavaScript on child when disabled on parent
Kevin Sawicki [Fri, 21 Apr 2017 17:58:47 +0000 (10:58 -0700)]
Add failing spec for inheriting Javascript web preference
Kevin Sawicki [Fri, 21 Apr 2017 17:57:22 +0000 (10:57 -0700)]
Enable setting javascript and contextIsolation via window.open
Kevin Sawicki [Tue, 25 Apr 2017 19:55:58 +0000 (12:55 -0700)]
Merge pull request #9279 from electron/extract-default-app-script
Extract script tags to renderer.js file in default app
Kevin Sawicki [Mon, 24 Apr 2017 18:54:05 +0000 (11:54 -0700)]
Extract script tags to renderer.js file
Kevin Sawicki [Mon, 24 Apr 2017 19:02:05 +0000 (12:02 -0700)]
Merge pull request #9254 from electron/endsession-event
End session event on browser window
Hari Krishna Reddy Juturu [Mon, 24 Apr 2017 18:58:08 +0000 (11:58 -0700)]
Removing #ifdef on endsession api
Hari Krishna Reddy Juturu [Mon, 24 Apr 2017 18:49:21 +0000 (11:49 -0700)]
Removing #ifdef windows for endsession methods
Kevin Sawicki [Mon, 24 Apr 2017 17:26:00 +0000 (10:26 -0700)]
Merge pull request #9255 from electron/emit-auto-updater-error
Emit auto updater error directly as Error
Hari Krishna Reddy Juturu [Mon, 24 Apr 2017 17:16:11 +0000 (10:16 -0700)]
change endsession event name to session-end
Kevin Sawicki [Fri, 21 Apr 2017 23:50:19 +0000 (16:50 -0700)]
Don't run error event on Linux
Kevin Sawicki [Fri, 21 Apr 2017 22:13:43 +0000 (15:13 -0700)]
Emit autoUpdater error directly as Error object
Kevin Sawicki [Fri, 21 Apr 2017 22:12:08 +0000 (15:12 -0700)]
Add spec for remote autoUpdater error event
Kevin Sawicki [Mon, 24 Apr 2017 16:47:05 +0000 (09:47 -0700)]
Merge pull request #9253 from electron/log-crashes-during-specs
Log all crashes during spec running
Kevin Sawicki [Fri, 21 Apr 2017 19:29:46 +0000 (12:29 -0700)]
Log all crashes during specs
Kevin Sawicki [Mon, 24 Apr 2017 16:26:00 +0000 (09:26 -0700)]
Merge pull request #9252 from electron/convert-to-string-in-render-process
Convert alert/confirm arguments to strings in render process
Kevin Sawicki [Fri, 21 Apr 2017 19:21:05 +0000 (12:21 -0700)]
Convert message/title to strings in render process
Kevin Sawicki [Fri, 21 Apr 2017 19:19:37 +0000 (12:19 -0700)]
Add spec for alert/confirm toString errors
Kevin Sawicki [Mon, 24 Apr 2017 16:14:29 +0000 (09:14 -0700)]
Merge pull request #9249 from electron/document-write
Don't use document.write in default app
Kevin Sawicki [Fri, 21 Apr 2017 17:12:19 +0000 (10:12 -0700)]
Don't use document.write in default app
Kevin Sawicki [Mon, 24 Apr 2017 15:50:55 +0000 (08:50 -0700)]
Merge pull request #9246 from rreimann/master
Clarify requirements for resumable downloads
Kevin Sawicki [Mon, 24 Apr 2017 15:50:40 +0000 (08:50 -0700)]
Minor wording tweaks
Kevin Sawicki [Mon, 24 Apr 2017 15:49:59 +0000 (08:49 -0700)]
Wrap header names in backticks
Kevin Sawicki [Mon, 24 Apr 2017 15:48:44 +0000 (08:48 -0700)]
Merge pull request #9273 from electron/update_notification_docs
Updated documentation on desktop notifications on Windows 7
Kevin Sawicki [Mon, 24 Apr 2017 15:48:20 +0000 (08:48 -0700)]
Merge pull request #9262 from ArcticZeroo/patch-1
Fix a typo in faq.md
Ales Pergl [Mon, 24 Apr 2017 07:57:34 +0000 (09:57 +0200)]
Updated documentation on desktop notifications on Windows 7
Brendan Forster [Mon, 24 Apr 2017 01:49:55 +0000 (11:49 +1000)]
clean up the code a bit
Brendan Forster [Mon, 24 Apr 2017 01:13:34 +0000 (11:13 +1000)]
Merge remote-tracking branch 'electron/master' into certificate-addition-windows
Brendan Forster [Mon, 24 Apr 2017 01:10:41 +0000 (11:10 +1000)]
reload the current cert database if the certificate was added
ArcticZeroo [Sun, 23 Apr 2017 03:11:04 +0000 (23:11 -0400)]
Update faq.md
Fix the most horrible typo of all time
rreimann [Sat, 22 Apr 2017 16:15:07 +0000 (18:15 +0200)]
Rephrase note for resume method
Hari Krishna Reddy Juturu [Fri, 21 Apr 2017 21:35:30 +0000 (14:35 -0700)]
Remove wm_state change
Hari Krishna Reddy Juturu [Fri, 21 Apr 2017 20:45:30 +0000 (20:45 +0000)]
End session event on browser window
Kevin Sawicki [Fri, 21 Apr 2017 20:44:01 +0000 (13:44 -0700)]
Merge pull request #8996 from swashcap/master
Add documentation note on dynamic Menu items
Kevin Sawicki [Fri, 21 Apr 2017 20:40:17 +0000 (13:40 -0700)]
Merge pull request #9239 from pfrazee/patch-1
Make note about sync webview calls in docs
Kevin Sawicki [Fri, 21 Apr 2017 20:39:51 +0000 (13:39 -0700)]
Bold note for emphasis
Kevin Sawicki [Fri, 21 Apr 2017 16:15:41 +0000 (09:15 -0700)]
Merge pull request #9248 from electron/stream-test-output-on-windows
Stream test output on Windows CI
Kevin Sawicki [Fri, 21 Apr 2017 15:51:10 +0000 (08:51 -0700)]
Stream test output on Windows CI
Kevin Sawicki [Fri, 21 Apr 2017 15:50:33 +0000 (08:50 -0700)]
Merge pull request #9241 from electron/doc-symstore
Document downloading debugging tools for windows
Kevin Sawicki [Fri, 21 Apr 2017 00:22:15 +0000 (17:22 -0700)]
Mention downloading debugging tools for windows
rreimann [Fri, 21 Apr 2017 13:14:56 +0000 (15:14 +0200)]
Clarify requirements for resumable downloads
Brendan Forster [Fri, 21 Apr 2017 03:09:49 +0000 (13:09 +1000)]
add some docs for Windows usage
Brendan Forster [Fri, 21 Apr 2017 02:47:11 +0000 (12:47 +1000)]
and this is how we invoke the callback
Brendan Forster [Fri, 21 Apr 2017 02:23:50 +0000 (12:23 +1000)]
and the order here matters apparently
Brendan Forster [Fri, 21 Apr 2017 02:17:01 +0000 (12:17 +1000)]
coding style fixes
Kevin Sawicki [Thu, 20 Apr 2017 22:11:27 +0000 (15:11 -0700)]
Merge pull request #9237 from electron/root-modules-describe
Add root describe to modules spec
Kevin Sawicki [Thu, 20 Apr 2017 17:48:17 +0000 (10:48 -0700)]
Add root describe to be able to run whole file
Kevin Sawicki [Thu, 20 Apr 2017 21:17:07 +0000 (14:17 -0700)]
Merge pull request #9238 from electron/wait-for-stdout-close
Wait for close event instead of exit in spec
Paul Frazee [Thu, 20 Apr 2017 19:02:41 +0000 (14:02 -0500)]
Make note about sync webview calls in docs
Kevin Sawicki [Thu, 20 Apr 2017 18:40:04 +0000 (11:40 -0700)]
Wait for close event instead of exit so stdout done
Kevin Sawicki [Thu, 20 Apr 2017 17:49:53 +0000 (10:49 -0700)]
Merge pull request #9095 from seanchas116/better-path-resolve
Search for module from app path when URL is not file protocol
Kevin Sawicki [Thu, 20 Apr 2017 17:33:31 +0000 (10:33 -0700)]
Merge pull request #9108 from yuya-oc/add-macos-sheet-events
Add sheet-begin and sheet-end events to macOS BrowserWindow