platform/core/system/resourced.git
3 years agoBump version to 6.5.x 41/251141/1 accepted/tizen/unified/20210113.121047 submit/tizen/20210108.125336
Karol Lewandowski [Fri, 8 Jan 2021 12:46:25 +0000 (13:46 +0100)]
Bump version to 6.5.x

Change-Id: I32233eb801e55ab1a48ce3835dcd3a542109608b

3 years agomemlimit: Introduce gui app and widget limits 32/250432/4
Karol Lewandowski [Thu, 24 Dec 2020 11:14:29 +0000 (12:14 +0100)]
memlimit: Introduce gui app and widget limits

Use MemLimitGUIApp and MemLimitWidget options to set gui app and widget
limits, respectively.

Change-Id: I70e1040438dd930ea06f268fde0514c3381e17ad

3 years agocpu-sched: move all threads using cgroup.procs 66/249866/3 accepted/tizen/unified/20201218.124446 submit/tizen/20201218.025549
Cho youngjae [Thu, 17 Dec 2020 06:11:17 +0000 (22:11 -0800)]
cpu-sched: move all threads using cgroup.procs

Use cgroup.procs instead of tasks to move all threads.

Change-Id: I83a75ab39ea61036c26e5951998181fd8bc0bdc8
Signed-off-by: Cho youngjae <4nuri1205@naver.com>
3 years agoRevert "cpu-sched: move all threads, not just the main one" 65/249865/4
Cho youngjae [Thu, 17 Dec 2020 06:10:56 +0000 (22:10 -0800)]
Revert "cpu-sched: move all threads, not just the main one"

This reverts commit c18193530e5a5ad0e89902b6318f114e8432cc4c.

Change-Id: Idfe24be6476d731ccc16e41482498e16dc780399
Signed-off-by: Cho youngjae <4nuri1205@naver.com>
3 years agocpu-sched: move all threads, not just the main one 63/249463/8 accepted/tizen/unified/20201216.215925 submit/tizen/20201216.004818
Michal Bloch [Fri, 11 Dec 2020 19:11:06 +0000 (20:11 +0100)]
cpu-sched: move all threads, not just the main one

Change-Id: If8947e4127d49554ca492571c9d08d755d02902a
Signed-off-by: Michal Bloch <m.bloch@partner.samsung.com>
3 years agoType correctness fixes 04/248204/1 accepted/tizen/unified/20201127.130445 submit/tizen/20201126.152656
Michal Bloch [Mon, 23 Nov 2020 13:22:33 +0000 (14:22 +0100)]
Type correctness fixes

Change-Id: I60385a605ac92461da1c438ca0037672954abf0a
Signed-off-by: Michal Bloch <m.bloch@partner.samsung.com>
3 years agoSilence ABI incompatibility warnings 03/248203/1
Michal Bloch [Mon, 23 Nov 2020 19:43:12 +0000 (20:43 +0100)]
Silence ABI incompatibility warnings

Since Tizen stuff gets rebuilt from scratch all the time anyway

Change-Id: I1fcc9c479ce15c160141920ef4885716afee63b9
Signed-off-by: Michal Bloch <m.bloch@partner.samsung.com>
3 years agoFix a strncpy size/length mismatch 02/248202/1 accepted/tizen/unified/20201125.124018 submit/tizen/20201125.015241
Michal Bloch [Mon, 23 Nov 2020 19:42:37 +0000 (20:42 +0100)]
Fix a strncpy size/length mismatch

Doesn't actually do anything (since we
manually add the null) but the compiler complains.

Change-Id: Ie222ec4b9b077268407db3cf8386f82bcb134db3
Signed-off-by: Michal Bloch <m.bloch@partner.samsung.com>
3 years agoBug fix: parsing memcg threshold 07/247507/2 accepted/tizen/unified/20201113.130840 submit/tizen/20201111.094630
Youngjae Cho [Wed, 11 Nov 2020 09:13:41 +0000 (18:13 +0900)]
Bug fix: parsing memcg threshold

Change-Id: I670abe3b9d38f3f7a6ce9c6546e4f2d175c5bb0a
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
3 years agoMake memory logging configurable 50/247350/13
Youngjae Cho [Tue, 10 Nov 2020 05:09:13 +0000 (14:09 +0900)]
Make memory logging configurable

Logging section in memory.conf file now configures the memory
logging. Now it is able to set the path and prefix of a logfile,
maximum number of logfiles, or even disable logging itself.

Change-Id: Id18da1b8df4ab4ba346080ad17f7c59da60acccb
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
3 years agoFix typo 40/246140/1 accepted/tizen/unified/20201102.124342 submit/tizen/20201030.075745
taemin.yeom [Mon, 26 Oct 2020 01:00:09 +0000 (10:00 +0900)]
Fix typo

Change-Id: I47e0174082dbcda4e473a5514496dc26f217e11a
Signed-off-by: taemin.yeom <taemin.yeom@samsung.com>
3 years agoFix the condition for escaping lowmem 38/244838/7
Youngjae Cho [Fri, 25 Sep 2020 01:32:17 +0000 (10:32 +0900)]
Fix the condition for escaping lowmem

The condition for escaping lowmem should be applied only when the lowmem
limit operates as MEM_LIMIT_THRESHOLD.

In case of MEM_LIMIT_OOM, kernel has already blocked the process which
used memory over the limit of cgroup. So if resourced got the eventfd
from the kernel about memory limit, resourced should control the
memory.oom_control node, enabling kernel to handle that oom. Otherwise,
this process would be stuck in D state until receiving SIGKILL signal.

Change-Id: I6279714037a4112823513529c414c3d4a1a04030
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
3 years agoAdd memcg threshold for memory size larger than 2GB 12/245512/5
Youngjae Cho [Mon, 12 Oct 2020 01:30:04 +0000 (10:30 +0900)]
Add memcg threshold for memory size larger than 2GB

Change-Id: I5e7a46cba90d8eb57fa80a3fc181541dc4762269
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
3 years agospec: remove tapi build requirement 96/245296/1
Michal Bloch [Tue, 6 Oct 2020 10:34:32 +0000 (12:34 +0200)]
spec: remove tapi build requirement

Seems to build correctly without.

Change-Id: I832c78c43786f906cb70e45413c688fd45ddb383
Signed-off-by: Michal Bloch <m.bloch@partner.samsung.com>
4 years agoFix svace issue 96/243396/3 accepted/tizen_6.0_unified_hotfix tizen_6.0_hotfix accepted/tizen/6.0/unified/20201030.114030 accepted/tizen/6.0/unified/hotfix/20201103.002008 accepted/tizen/unified/20200911.043144 submit/tizen/20200910.050828 submit/tizen_6.0/20201029.205105 submit/tizen_6.0_hotfix/20201102.192505 submit/tizen_6.0_hotfix/20201103.114805 tizen_6.0.m2_release
Youngjae Cho [Mon, 7 Sep 2020 08:07:27 +0000 (17:07 +0900)]
Fix svace issue

In addition to fix svace issue,
change yoda conditions in cpu-sched.c to usual style.

Change-Id: Ifde1796c2bdfbb2893505ec3365036068e454d75
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
4 years agoswap: do NOT set ZRAM size if it is already set by kernel 06/243206/1 accepted/tizen/unified/20200908.060819 submit/tizen/20200907.113616 submit/tizen/20200908.010406
Elmurod Talipov [Fri, 4 Sep 2020 02:26:40 +0000 (11:26 +0900)]
swap: do NOT set ZRAM size if it is already set by kernel

 ZRAM disksize can be set with configuration in Kernel or by other
 means, in that case setting and verify ZRAM size fails.

Change-Id: Id296cf8106ecbea368959f92e06ad7d7a6a57f4c
Signed-off-by: Elmurod Talipov <e.talipov@samsung.com>
4 years agoRelease 6.0.5 42/242542/5 accepted/tizen/unified/20200828.225436 submit/tizen/20200828.121504
Karol Lewandowski [Thu, 27 Aug 2020 14:22:35 +0000 (16:22 +0200)]
Release 6.0.5

Change-Id: I2af07d1c242916a025ad21320d25c82527b67ea4

4 years agocpu-sched: Fix leaks in load_config 38/242638/3
Karol Lewandowski [Fri, 28 Aug 2020 10:18:05 +0000 (12:18 +0200)]
cpu-sched: Fix leaks in load_config

Change-Id: I46201ea6244fc8fd42cd388f4bc5f78d7d86fa7b

4 years agocpu-sched: Handle suspend event too 41/242541/3
Karol Lewandowski [Thu, 27 Aug 2020 14:22:09 +0000 (16:22 +0200)]
cpu-sched: Handle suspend event too

resume event was supported previously, suggesting suspend is missing

Change-Id: Idabe1e8559961332079de018854321466f8ea902

4 years agocpu-sched: Add support for handling background events 53/242353/4
Karol Lewandowski [Tue, 25 Aug 2020 15:04:38 +0000 (17:04 +0200)]
cpu-sched: Add support for handling background events

Change-Id: I2f1f2b8af0ecf146c507697e02cfda0c9e3f5282

4 years agocpu-sched: Support assigning cpusets to services 07/242307/5
Karol Lewandowski [Tue, 25 Aug 2020 12:00:11 +0000 (14:00 +0200)]
cpu-sched: Support assigning cpusets to services

Change-Id: Ie745a30723d4556fb57efaa4a70f76d63ee08c3e

4 years agocpu-sched: Do not depend on foreground= being set in configuration 82/242182/5
Karol Lewandowski [Mon, 24 Aug 2020 23:35:52 +0000 (01:35 +0200)]
cpu-sched: Do not depend on foreground= being set in configuration

Change-Id: I48330dfe807ab4c581ae2d8a17a0019eead18dd8

4 years agofix svace buffer-overflow issue 97/242597/1 submit/tizen/20200828.070910
Sung-hun Kim [Fri, 28 Aug 2020 06:49:04 +0000 (15:49 +0900)]
fix svace buffer-overflow issue

Change-Id: I1f9b81cf51538d42fcde478fb43dbada82160041
Signed-off-by: Sung-hun Kim <sfoon.kim@samsung.com>
4 years agoswap: zramswap: Use zstd compression algorithm 63/242463/1 accepted/tizen/unified/20200828.121534 submit/tizen/20200827.070546
Dongwoo Lee [Thu, 27 Aug 2020 05:42:07 +0000 (14:42 +0900)]
swap: zramswap: Use zstd compression algorithm

Change-Id: I6bab2db5cc888d3de8fa199a6f62a8a428984a3b
Signed-off-by: Dongwoo Lee <dwoo08.lee@samsung.com>
4 years agoswap: zramswap: Fallback to write default compressor 62/242462/1
Dongwoo Lee [Thu, 27 Aug 2020 05:38:08 +0000 (14:38 +0900)]
swap: zramswap: Fallback to write default compressor

If it fails to write compression algorithm to zram, try again with
default compressor to address that compression algorithm described
in conf file is not supported by kernel.

Change-Id: I69f5b52042b20b5aba504d1baea965e07c315ceb
Signed-off-by: Dongwoo Lee <dwoo08.lee@samsung.com>
4 years agoEnable memory optimization features on default configuration 32/242232/3 submit/tizen/20200827.041709
Dongwoo Lee [Tue, 25 Aug 2020 02:17:22 +0000 (11:17 +0900)]
Enable memory optimization features on default configuration

This enables dedup module and ReclaimAtBoot of swap module as default.
If the kernel does not support deduplcation, it is ignored.

Change-Id: I0902be43e3f8dc1588bbecea33d21a3d66d3a5c9
Signed-off-by: Dongwoo Lee <dwoo08.lee@samsung.com>
4 years agoswap: Add support for reclaiming more memory at boot 08/237208/6
Dongwoo Lee [Mon, 24 Aug 2020 06:52:43 +0000 (15:52 +0900)]
swap: Add support for reclaiming more memory at boot

To reclaim more memory on earily reclaim stage, this provides
new configuration for '[SWAP]' section as "ReclaimAtBootThreshold".
If this is set, reclaim at earily stage continuously until the
reclaimed memory is lower than this threshold. Otherwise, default
value is very large (1024MB), so reclaim will be perfomed once as
before.

Change-Id: Icdd9206cf451a64a9c872833af88e91e8d8a6c6e
Signed-off-by: Dongwoo Lee <dwoo08.lee@samsung.com>
4 years agoDEDUP: a dedup module to control LKSM 52/240852/5
Sung-hun Kim [Thu, 23 Jan 2020 07:18:20 +0000 (16:18 +0900)]
DEDUP: a dedup module to control LKSM

To manage LKSM in the kernel, a dedup module is added to resourced codebase.

The resourced daemon checks memory pressure level when an event is delivered
from the kernel. When the memory pressure level is crossed the predefined
threshold (which is configured by memory.conf), the daemon requests to invoke
memory deduplication via sysfs interface.

In order to enable a dedup module in resourced, the kernel should support LKSM
features.

Change-Id: I6bec596d40e68e1d6cc0c047d80ef30700ab846e
Signed-off-by: Sung-hun Kim <sfoon.kim@samsung.com>
4 years agoRelease 6.0.4 08/241008/1 accepted/tizen/unified/20200814.123106 submit/tizen/20200813.115042
Karol Lewandowski [Thu, 13 Aug 2020 11:34:28 +0000 (13:34 +0200)]
Release 6.0.4

Change-Id: Ifa47a5cc4a601812db1da103f6b41052702771ad

4 years agomemory: Fix: Avoid copying garbage when dir is shorter than fpath 02/241002/1
Karol Lewandowski [Thu, 13 Aug 2020 11:33:09 +0000 (13:33 +0200)]
memory: Fix: Avoid copying garbage when dir is shorter than fpath

Change-Id: If6966bd3623499f88006f6eb1b740d7de3b4b3d9

4 years agoprocfs: Fix: do not copy garbage when filename is shorter than PROC_NAME_MAX 96/240896/2
Karol Lewandowski [Wed, 12 Aug 2020 13:59:04 +0000 (15:59 +0200)]
procfs: Fix: do not copy garbage when filename is shorter than PROC_NAME_MAX

Change-Id: I04d5d68b25fa9795691d109bc52192406758e99f

4 years agoFix ASan build 76/239776/1 accepted/tizen/unified/20200731.145753 submit/tizen/20200730.102703
Slava Barinov [Wed, 29 Jul 2020 10:40:26 +0000 (13:40 +0300)]
Fix ASan build

Address Sanitizer build requires symbols to be visible for interception.

Change-Id: Ifb56beaa6f24273d8f28c05423323828e993c8cf
Signed-off-by: Slava Barinov <v.barinov@samsung.com>
4 years agoIncrease MemLimitService to 128MB 74/239574/2 accepted/tizen/unified/20200728.045250 submit/tizen/20200728.005611
Hyotaek Shim [Tue, 28 Jul 2020 00:48:39 +0000 (09:48 +0900)]
Increase MemLimitService to 128MB

Change-Id: If90f9215189a3ad61a33f637c7496399b1a6af05
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
4 years agoDefault conf file for cpu core pinning 77/239077/1 accepted/tizen/unified/20200722.144549 submit/tizen/20200722.034444
Hyotaek Shim [Tue, 21 Jul 2020 12:11:40 +0000 (21:11 +0900)]
Default conf file for cpu core pinning

Change-Id: I43b1e5e73e83297112cd68935f86424184f7a31c
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
4 years agocpu-sched: check app list on startup 72/237472/5 accepted/tizen/unified/20200722.014938 submit/tizen/20200721.120800
Maciej Słodczyk [Tue, 30 Jun 2020 14:14:54 +0000 (16:14 +0200)]
cpu-sched: check app list on startup

Change-Id: Id0f468171e0b9b750bfc38e5e469928e270fa60f
Signed-off-by: Maciej Słodczyk <m.slodczyk2@partner.samsung.com>
4 years agocpu-sched: add apps' static cpusets 64/237364/6
Maciej Słodczyk [Mon, 29 Jun 2020 13:28:10 +0000 (15:28 +0200)]
cpu-sched: add apps' static cpusets

Change-Id: I1ce586e2923ea39c280c4e7bb53a04335554f5c1
Signed-off-by: Maciej Słodczyk <m.slodczyk2@partner.samsung.com>
4 years agocpu-sched: use apps' foreground events to pin to proper cpuset 65/236965/7
Maciej Słodczyk [Tue, 23 Jun 2020 20:24:08 +0000 (22:24 +0200)]
cpu-sched: use apps' foreground events to pin to proper cpuset

Change-Id: Icb19ef5628f1576aa87f9cc86ed3db59b24f18ef
Signed-off-by: Maciej Słodczyk <m.slodczyk2@partner.samsung.com>
4 years agocpu-sched: use cpu on/off events to create cpusets 64/236964/6
Maciej Słodczyk [Tue, 23 Jun 2020 19:24:48 +0000 (21:24 +0200)]
cpu-sched: use cpu on/off events to create cpusets

Change-Id: I158f2a8e26ae3334065717c06b16b9e161e3281e
Signed-off-by: Maciej Słodczyk <m.slodczyk2@partner.samsung.com>
4 years agocpu-sched: add cpu hotplug notification mechanism 11/236311/7
Maciej Słodczyk [Mon, 15 Jun 2020 14:12:38 +0000 (16:12 +0200)]
cpu-sched: add cpu hotplug notification mechanism

Change-Id: I8b01ef5d757501a709c3e067cdcf95223d522266
Signed-off-by: Maciej Słodczyk <m.slodczyk2@partner.samsung.com>
4 years agocpu-sched: foreground core set data structures 63/236963/6
Maciej Słodczyk [Tue, 23 Jun 2020 18:46:11 +0000 (20:46 +0200)]
cpu-sched: foreground core set data structures

Change-Id: I2bd110e85d7ebc8f30f0b7949abccbbb92cd6881
Signed-off-by: Maciej Słodczyk <m.slodczyk2@partner.samsung.com>
4 years agocpu-sched: add new module 62/236962/6
Maciej Słodczyk [Tue, 23 Jun 2020 13:57:59 +0000 (15:57 +0200)]
cpu-sched: add new module

Change-Id: I324d4e32be5d64ba993f8637d0500d8f76c3986b
Signed-off-by: Maciej Słodczyk <m.slodczyk2@partner.samsung.com>
4 years agoMerge "file-helper: fix possible memleak" into tizen
Maciej Slodczyk [Mon, 13 Jul 2020 05:32:50 +0000 (05:32 +0000)]
Merge "file-helper: fix possible memleak" into tizen

4 years agotests: Fix wrong operator 54/237954/2
sanghyeok.oh [Tue, 7 Jul 2020 02:47:07 +0000 (11:47 +0900)]
tests: Fix wrong operator

Change-Id: Ieb322a7824b29818f112b0fccd81e02821a48e24
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
4 years agofile-helper: fix possible memleak 29/237929/2
Maciej Słodczyk [Mon, 6 Jul 2020 12:45:55 +0000 (14:45 +0200)]
file-helper: fix possible memleak

Assigning NULL to **str passed pointer on fgets() error
may result in being unable to free memory pointed by *str
(if it was previously allocated dynamically).

Change-Id: Ieda457c4d9da02dab277d476ed79537da41e744e
Signed-off-by: Maciej Słodczyk <m.slodczyk2@partner.samsung.com>
4 years agoFix misspelled "swappiness" 07/237207/1
Dongwoo Lee [Mon, 20 Apr 2020 07:55:52 +0000 (16:55 +0900)]
Fix misspelled "swappiness"

Memcg attribute "swappiness" is misspelled as "swapness", so this
corrects them.

Change-Id: Ia6cf4774b26af613e344c25dca6591980a183247
Signed-off-by: Dongwoo Lee <dwoo08.lee@samsung.com>
4 years agoswap: fix wrong indentation 06/237206/1
Dongwoo Lee [Mon, 20 Apr 2020 07:48:56 +0000 (16:48 +0900)]
swap: fix wrong indentation

Change-Id: I95e53f4855ff04cf3241d997d2548e28d7cb3d37
Signed-off-by: Dongwoo Lee <dwoo08.lee@samsung.com>
4 years agoRelease 6.0.3 09/236209/1 accepted/tizen/unified/20200616.170900 submit/tizen/20200615.141410 submit/tizen/20200616.073101
Maciej Słodczyk [Mon, 15 Jun 2020 14:10:33 +0000 (16:10 +0200)]
Release 6.0.3

Change-Id: I5e84c4682e25a285dfa0b579530ad5db82c7cb23
Signed-off-by: Maciej Słodczyk <m.slodczyk2@partner.samsung.com>
4 years agosafe-kill: unit tests 77/235777/3
Maciej Słodczyk [Tue, 9 Jun 2020 15:34:42 +0000 (17:34 +0200)]
safe-kill: unit tests

Change-Id: I658e9e85aa57c2cdffc5ce0fa9a44bd28d5bbb28
Signed-off-by: Maciej Słodczyk <m.slodczyk2@partner.samsung.com>
4 years agosafe-kill: prevent processes from being killed while dumping a core 96/235196/12
Maciej Słodczyk [Tue, 2 Jun 2020 12:58:56 +0000 (14:58 +0200)]
safe-kill: prevent processes from being killed while dumping a core

Change-Id: I24bd152f04b90b3b7b4f64d06561e2833cf3d130
Signed-off-by: Maciej Słodczyk <m.slodczyk2@partner.samsung.com>
4 years agoMerge changes I4f376da7,I60270eda into tizen
Karol Lewandowski [Thu, 4 Jun 2020 13:33:42 +0000 (13:33 +0000)]
Merge changes I4f376da7,I60270eda into tizen

* changes:
  Add common module unit tests
  Fix improper behaviour of strstrip when string contains only whitespaces

4 years agoAdd common module unit tests 37/226437/15
Agnieszka Baumann [Wed, 19 Feb 2020 11:27:47 +0000 (12:27 +0100)]
Add common module unit tests

Change-Id: I4f376da7f1433dd6e4357080abc7927cf7b2c8a3

4 years agoFix improper behaviour of strstrip when string contains only whitespaces 21/226821/7
Agnieszka Baumann [Thu, 5 Mar 2020 19:14:45 +0000 (20:14 +0100)]
Fix improper behaviour of strstrip when string contains only whitespaces

Change-Id: I60270eda72f634cefd059a83c6f93dd0d4446aa9

4 years agoavoid truncate string warning when copying 58/235158/1
Maciej Słodczyk [Tue, 2 Jun 2020 08:05:03 +0000 (10:05 +0200)]
avoid truncate string warning when copying

Deliberately copying substring with strncpy() resulted
in 'output may be truncated' warning. Use memcpy()
to achieve the same without the warning.

Change-Id: Id6a74a3f096f83b1fd6a39728f2f3438172c76f2
Signed-off-by: Maciej Słodczyk <m.slodczyk2@partner.samsung.com>
4 years agotests: make sure all struct fields are initialized 57/235157/1
Maciej Słodczyk [Tue, 2 Jun 2020 08:04:18 +0000 (10:04 +0200)]
tests: make sure all struct fields are initialized

Change-Id: I89820b04c4ce8b15935aad33c6c48a7f5425874c
Signed-off-by: Maciej Słodczyk <m.slodczyk2@partner.samsung.com>
4 years agotests: make sure all vars are unreffed when not needed 56/235156/1
Maciej Słodczyk [Tue, 2 Jun 2020 08:03:47 +0000 (10:03 +0200)]
tests: make sure all vars are unreffed when not needed

Change-Id: I9320fa28495280d801cc6be6dc7ca42b13877787
Signed-off-by: Maciej Słodczyk <m.slodczyk2@partner.samsung.com>
4 years agoproc-watchdog: correct the change in the processing parts for each dbus signal 68/232868/1
Hyotaek Shim [Fri, 8 May 2020 05:19:05 +0000 (14:19 +0900)]
proc-watchdog: correct the change in the processing parts for each dbus signal

It was an old bug even though there is no big impact.
"freeze" signal has both type and pid,
and "suspend" signal has no param.
But it was reversed from the beginning and
an unnecessary error log was continuously being printed in the journal.

Change-Id: I964c99a04c55ec104148e954782a3069e835f0ae
Signed-off-by: ByungSoo Kim <bs1770.kim@samsung.com>
Change-Id: I244b637e62916fa5560ca27614aa8def3a4c3dca
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
4 years agoMerge "Fix double free module_list variable" into tizen
Maciej Slodczyk [Tue, 5 May 2020 06:14:45 +0000 (06:14 +0000)]
Merge "Fix double free module_list variable" into tizen

4 years agoMerge "Fix g_list_remove and g_slist_remove bug" into tizen
Maciej Slodczyk [Tue, 5 May 2020 06:14:37 +0000 (06:14 +0000)]
Merge "Fix g_list_remove and g_slist_remove bug" into tizen

4 years agoFix double free module_list variable 02/231402/3
INSUN PYO [Tue, 21 Apr 2020 08:05:15 +0000 (17:05 +0900)]
Fix double free module_list variable

The modules_list is freed as destructor by remove_module() function.

Change-Id: If5b18c77f9e354599ee1c8d87b6d8cc5a3a93740

4 years agoBlock module priority NORMAL → LATE 75/231875/1 submit/tizen/20200427.110102
ByungSoo Kim [Fri, 24 Apr 2020 14:26:14 +0000 (16:26 +0200)]
Block module priority NORMAL → LATE

Change-Id: I0613ea96f7111ab75070cce702f9b859670d9501
Signed-off-by: Michal Bloch <m.bloch@partner.samsung.com>
4 years agoInitialize late modules after BootingDone 74/231874/1
ByungSoo Kim [Fri, 24 Apr 2020 14:08:33 +0000 (16:08 +0200)]
Initialize late modules after BootingDone

Change-Id: Iadd21d6a6e402fbdb8bbef9e7d981ed3b8bc3c83
Signed-off-by: Michal Bloch <m.bloch@partner.samsung.com>
4 years agoAdded variable initialization for g_variant_get 52/231552/1
INSUN PYO [Wed, 22 Apr 2020 09:33:18 +0000 (18:33 +0900)]
Added variable initialization for g_variant_get

Change-Id: Ica9c29a3ca755a83590ed9af1e8abddedf0cf14a

4 years agoFix g_list_remove and g_slist_remove bug 04/231404/3
INSUN PYO [Wed, 22 Apr 2020 00:39:41 +0000 (09:39 +0900)]
Fix g_list_remove and g_slist_remove bug

Change-Id: I6c460647b69e35f44b7e30a51de14e1c93c9f919

4 years agodbus: modified to reply error type message 26/224826/2
sanghyeok.oh [Thu, 13 Feb 2020 08:25:34 +0000 (17:25 +0900)]
dbus: modified to reply error type message

Change-Id: I4a2067c007810690e1607738099894b7f3b8341a
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
4 years agoInclude all GPerf files verbatim 52/227952/1 accepted/tizen/unified/20200318.130501 submit/tizen/20200317.115543
Michal Bloch [Mon, 16 Mar 2020 13:46:12 +0000 (14:46 +0100)]
Include all GPerf files verbatim

GPerf compilation looks fragile and we already did this to one file
so might as well prevent the problem for the other two.

Change-Id: I808b24ed484e68f4d1ee3d74928d20756e501394
Signed-off-by: Michal Bloch <m.bloch@partner.samsung.com>
4 years agoWorkaround build issue: include gperf file verbatim 26/227826/2
Michal Bloch [Mon, 16 Mar 2020 11:38:28 +0000 (12:38 +0100)]
Workaround build issue: include gperf file verbatim

Change-Id: Ib851cc25d9a2e53851ab22cc01f10217d8a7ef64
Signed-off-by: Michal Bloch <m.bloch@partner.samsung.com>
4 years agoFix some warnings 51/227951/1
Michal Bloch [Tue, 17 Mar 2020 10:40:55 +0000 (11:40 +0100)]
Fix some warnings

Change-Id: Iece5804c05b2ff4dd36e33da4b827813f26eb2ad
Signed-off-by: Michal Bloch <m.bloch@partner.samsung.com>
4 years agoTemporarily disable segfaulting tests 50/227950/1
Michal Bloch [Tue, 17 Mar 2020 10:13:22 +0000 (11:13 +0100)]
Temporarily disable segfaulting tests

They randomly started failing, let's not block the build process while I debug them

Change-Id: I42a2ecaeb3b3d5cf73d2f4bbed1a32dc68ba2d77
Signed-off-by: Michal Bloch <m.bloch@partner.samsung.com>
4 years agoAdd .gitignore 60/227760/1 accepted/tizen/unified/20200316.221102 submit/tizen/20200316.080625
Hyotaek Shim [Mon, 16 Mar 2020 08:05:17 +0000 (17:05 +0900)]
Add .gitignore

Change-Id: Ibf481f8b9062e367746ca3899ea7c639f4d8d5d2
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
4 years agoFix build error 58/227758/1
Hyotaek Shim [Mon, 16 Mar 2020 08:03:21 +0000 (17:03 +0900)]
Fix build error

[   39s] /usr/lib/gcc/armv7l-tizen-linux-gnueabi/9.2.0/include/c++/bits/stl_map.h: In member function 'int LowmemLimitEnv::
cgroup_make_subdir(const char*, const char*, bool*)':
[   39s] /usr/lib/gcc/armv7l-tizen-linux-gnueabi/9.2.0/include/c++/bits/stl_map.h:499:8: note: parameter passing for argument of
type 'std::_Rb_tree<std::__cxx11::basic_string<char>, std::pair<const std::__cxx11::basic_string<char>, LowmemLimitEnv::CGroupData>
, std::_Select1st<std::pair<const std::__cxx11::basic_string<char>, LowmemLimitEnv::CGroupData> >, std::less<std::__cxx11::basic_
string<char> >, std::allocator<std::pair<const std::__cxx11::basic_string<char>, LowmemLimitEnv::CGroupData> > >::const_iterator'
{aka 'std::_Rb_tree_const_iterator<std::pair<const std::__cxx11::basic_string<char>, LowmemLimitEnv::CGroupData> >'} changed in GCC 7.1

Change-Id: Ia62b225a8d26983eced992f7dac5d6b625254487
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
4 years agoFix: parse_bytes prevent out of range value 98/227398/4
Agnieszka Baumann [Wed, 11 Mar 2020 14:45:41 +0000 (15:45 +0100)]
Fix: parse_bytes prevent out of range value

Change-Id: I5a8c59176fc936f02c419cb494548eeac37d0638

4 years agoFix improper behaviour of parse_bytes when string contains only one letter 94/227094/4
Agnieszka Baumann [Mon, 9 Mar 2020 14:13:16 +0000 (15:13 +0100)]
Fix improper behaviour of parse_bytes when string contains only one letter

Change-Id: Ie50ff0a666eedf4396f9e78d3d3aff07d9802885

4 years agoRevert "Temporarily disable built test" 66/227366/2 accepted/tizen/unified/20200312.131057 submit/tizen/20200312.020749
Hyotaek Shim [Wed, 11 Mar 2020 11:34:38 +0000 (11:34 +0000)]
Revert "Temporarily disable built test"

This reverts commit fc88a028951abd2ab116c119c6d3c7de3895073e.

Change-Id: I6a818f8c18195adbfd28a663d0b7bc709b65ea04

4 years agoFix a build test error 32/227232/22
Michal Bloch [Tue, 10 Mar 2020 15:39:47 +0000 (16:39 +0100)]
Fix a build test error

Change-Id: Id4a129f6a88ceec8939b1c4730bbc5b5f6671a6e

4 years agoFix a compilation failure 62/227362/1 submit/tizen/20200311.110552
Michal Bloch [Wed, 11 Mar 2020 10:58:15 +0000 (11:58 +0100)]
Fix a compilation failure

Change-Id: Idc3c8a892a748a7c0f2ded99501c96397a90f603
Signed-off-by: Michal Bloch <m.bloch@partner.samsung.com>
4 years agoTemporarily disable built test 46/227246/2 accepted/tizen/unified/20200311.130752 submit/tizen/20200311.021008
Hyotaek Shim [Wed, 11 Mar 2020 02:09:18 +0000 (11:09 +0900)]
Temporarily disable built test

Change-Id: If64ec46bfedbd94f56d31a38605f4033cddf957e
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
4 years agoparse_bytes prevent out of range value 36/226436/4
Agnieszka Baumann [Mon, 2 Mar 2020 12:16:15 +0000 (13:16 +0100)]
parse_bytes prevent out of range value

Change-Id: I65fd241855fa480ffea53b94f6914c925fde9cda

4 years agocoverity: Fix coverity issue 18/226118/4 accepted/tizen/unified/20200228.123728 submit/tizen/20200227.094013
sanghyeok.oh [Thu, 27 Feb 2020 04:14:03 +0000 (13:14 +0900)]
coverity: Fix coverity issue

Coverity: #1092538 Buffer not null terminated

Change-Id: Ib56db8edb211e819aa947f734894a1b757d5a518

4 years agoAdd proc_app_list test case 53/224453/2
Agnieszka Baumann [Thu, 6 Feb 2020 09:48:07 +0000 (10:48 +0100)]
Add proc_app_list test case

Change-Id: Ie311ee403d35f3200095796c1d535b5a59a60afb

4 years agoFix coverity bugs 71/224871/1 accepted/tizen/unified/20200214.120106 submit/tizen/20200213.180722
Agnieszka Baumann [Thu, 13 Feb 2020 12:21:20 +0000 (13:21 +0100)]
Fix coverity bugs

Change-Id: Ie1f584a9f4b4d42543247dc3657e998b902ddada

4 years agounit tests: add license headers 48/224448/1
Maciej Slodczyk [Mon, 10 Feb 2020 14:12:39 +0000 (15:12 +0100)]
unit tests: add license headers

Change-Id: I4a6d761690c526fb1919688437784eafb947495f
Signed-off-by: Maciej Slodczyk <m.slodczyk2@partner.samsung.com>
4 years agounit tests: remove unnecessary cflags 47/224447/1
Maciej Slodczyk [Mon, 10 Feb 2020 13:47:49 +0000 (14:47 +0100)]
unit tests: remove unnecessary cflags

Change-Id: I7dd8ba4ac8c2232d4d98b6be91435b73837b1e55
Signed-off-by: Maciej Slodczyk <m.slodczyk2@partner.samsung.com>
4 years agoAdd skipped unfinished tests 24/224024/3
Agnieszka Baumann [Tue, 4 Feb 2020 09:30:17 +0000 (10:30 +0100)]
Add skipped unfinished tests

Change-Id: I90935144c9b9d83dfc171919a6821c3ce2af02ee

4 years agoFix -Wextra and -pedantic errors 08/224308/2
Agnieszka Baumann [Wed, 5 Feb 2020 15:31:53 +0000 (16:31 +0100)]
Fix -Wextra and -pedantic errors

Change-Id: I8eddbe7c94cfbbc497d6c1d59c180717d6dde898

4 years agomake filenames consistent 48/223748/2
Agnieszka Baumann [Mon, 3 Feb 2020 15:09:33 +0000 (16:09 +0100)]
make filenames consistent

Change-Id: I4e1bea4a32939d00a312d1efaa8ec28f8f1ba472

4 years agoAdd proc_app_info childs list unit test 27/223427/3
Baumann [Thu, 9 Jan 2020 08:29:44 +0000 (09:29 +0100)]
Add proc_app_info childs list unit test

Change-Id: I61859321333ce5e56a837e7536b290b15fca1706

4 years agounit-tests: file-helper 39/219239/15
Maciej Slodczyk [Mon, 9 Dec 2019 10:26:07 +0000 (11:26 +0100)]
unit-tests: file-helper

Change-Id: If6060efbebcc48abf1398d31e58564c184bd843c
Signed-off-by: Maciej Slodczyk <m.slodczyk2@partner.samsung.com>
4 years agocommon: preserve correct errno value when writing logs 25/223225/2
Maciej Slodczyk [Mon, 27 Jan 2020 18:09:43 +0000 (19:09 +0100)]
common: preserve correct errno value when writing logs

Change-Id: I51dc6443dbb1e3275fdf8887d398f41896ed814e
Signed-off-by: Maciej Slodczyk <m.slodczyk2@partner.samsung.com>
4 years agoAdd dbus_get_cpu_lists tests 19/223219/1
Maciej Slodczyk [Mon, 27 Jan 2020 13:56:57 +0000 (14:56 +0100)]
Add dbus_get_cpu_lists tests

Change-Id: I2f03065f55ca627d1977f854af5de2af230f8199
Signed-off-by: Maciej Slodczyk <m.slodczyk2@partner.samsung.com>
4 years agoAdd dbus_get_memory_lists tests 66/222966/7
Maciej Slodczyk [Mon, 20 Jan 2020 12:16:33 +0000 (13:16 +0100)]
Add dbus_get_memory_lists tests

Change-Id: Ib0a5678825af80d0048ecb798a890c9b35d83926
Signed-off-by: Maciej Slodczyk <m.slodczyk2@partner.samsung.com>
4 years agoAdd proc_add_app_info cmocka unit test 49/221949/10
Baumann [Mon, 16 Dec 2019 14:49:04 +0000 (15:49 +0100)]
Add proc_add_app_info cmocka unit test

Change-Id: I516946ca67fab4787a1d51153ae8a8e191c9bed2

4 years agounit tests: extend proc_dbus_aul_group tests 60/220360/9
Maciej Slodczyk [Tue, 17 Dec 2019 17:02:08 +0000 (18:02 +0100)]
unit tests: extend proc_dbus_aul_group tests

Change-Id: I6735f09b0e8f7b3a312434c709cb4ee82b86e59f
Signed-off-by: Maciej Slodczyk <m.slodczyk2@partner.samsung.com>
4 years agoMerge "tests: fix mocking of large-file syscall versions" into tizen
Maciej Slodczyk [Tue, 21 Jan 2020 13:19:34 +0000 (13:19 +0000)]
Merge "tests: fix mocking of large-file syscall versions" into tizen

4 years agotests: fix mocking of large-file syscall versions 56/222956/1
Michal Bloch [Tue, 21 Jan 2020 12:19:49 +0000 (13:19 +0100)]
tests: fix mocking of large-file syscall versions

Some buildchains produce code that links to large-file versions
of most syscalls (e.g. opendir → opendir64) which also need to
be mocked.

Change-Id: Ia1983069a15ded569172fc326e5f1de07f3cf2d4
Signed-off-by: Michal Bloch <m.bloch@partner.samsung.com>
4 years agoAdd DBus cmocka unit tests 53/220253/9
Baumann [Mon, 18 Nov 2019 14:55:06 +0000 (15:55 +0100)]
Add DBus cmocka unit tests

Change-Id: I62008486b3144f27d91ef91916bd32acef28eb8c
Signed-off-by: Baumann <a.baumann@samsung.com>
4 years agotests: add tests for lowmem-dbus module 02/222102/4
Adrian Szyndela [Thu, 9 Jan 2020 15:18:04 +0000 (16:18 +0100)]
tests: add tests for lowmem-dbus module

Change-Id: Ib92de33c9fbc380dee4037cd787ee8eb33504a02

4 years agotests: add triggering for dbus signals 01/222101/4
Adrian Szyndela [Thu, 9 Jan 2020 15:15:28 +0000 (16:15 +0100)]
tests: add triggering for dbus signals

This adds mocked dbus signals registration function, a registration,
and callback mechanisms. It allows checking if dbus signals handlers
do their thing.

Change-Id: Id6af42d25fd00985e8f84d759d10457e031d39b8

4 years agotests: add lowmem-system tests 76/221976/2
Adrian Szyndela [Wed, 8 Jan 2020 15:38:21 +0000 (16:38 +0100)]
tests: add lowmem-system tests

Change-Id: I2111d33c92d5dd5588685ee95373a8d53e015155

4 years agotests: extract common code for lowmem modules 75/221975/2
Adrian Szyndela [Wed, 8 Jan 2020 15:34:01 +0000 (16:34 +0100)]
tests: extract common code for lowmem modules

This extracts the code which is common for testing lowmem-limit
and lowmem-system modules to separate files.

Add minor improvements:
* extract function for adding test modules in CMakeLists.txt
* add cmocka_wrap.hpp which aims to make including cmocka.h easier.

Change-Id: I67c34e3dbd84316fbd86d075e72333f2d0d14625

4 years agoVarious string buffer size checks 64/221264/3 accepted/tizen/unified/20200108.131420 submit/tizen/20200107.114054
Michal Bloch [Mon, 30 Dec 2019 16:36:29 +0000 (17:36 +0100)]
Various string buffer size checks

Change-Id: I65547beb1beceb0d8eb4a9516dda11cda9d84599
Signed-off-by: Michal Bloch <m.bloch@partner.samsung.com>