Hermet Park [Tue, 19 Nov 2019 04:32:17 +0000 (13:32 +0900)]
Revert "Revert "vg_common_svg: Support opacity attribute of <g> element""
This reverts commit
8a03085d6b97943a720397231de87d58e9d46e44.
Revert again after Tizen 5.5 M2 Public release.
Change-Id: I9e632e8848f95e3d423f13a2473fdd442cdc3454
Bowon Ryu [Mon, 18 Nov 2019 12:25:26 +0000 (21:25 +0900)]
slider: fix value error from step
Summary:
When the slider moves using step,
_drag_value_fetch(), _val_fetch() calculates a value from position of edje_part.
Then the calculated value is updated.
However, this causes a slight error.
This patch updates value first when moving with steps.
* Test Example
```
Evas_Object *sl = elm_slider_add(bx);
elm_slider_min_max_set(sl, -5, 5);
elm_slider_value_set(sl, 0.0);
elm_slider_step_set(sl, 0.1);
evas_object_size_hint_align_set(sl, EVAS_HINT_FILL, EVAS_HINT_FILL);
evas_object_size_hint_weight_set(sl, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_smart_callback_add(sl, "changed", _change_cb, NULL);
```
```
void
_change_cb(void *data, Evas_Object *obj, void *event_info EINA_UNUSED)
{
double val = elm_slider_value_get(obj);
if (val == -5.0) printf("val[%f] == -5.0 \n", val);
if (val == -4.0) printf("val[%f] == -4.0 \n", val);
if (val == -3.0) printf("val[%f] == -3.0 \n", val);
if (val == -2.0) printf("val[%f] == -2.0 \n", val);
if (val == -1.0) printf("val[%f] == -1.0 \n", val);
if (val == 0.0) printf("val[%f] == 0.0 \n", val);
if (val == 1.0) printf("val[%f] == 1.0 \n", val);
if (val == 2.0) printf("val[%f] == 2.0 \n", val);
if (val == 3.0) printf("val[%f] == 3.0 \n", val);
if (val == 4.0) printf("val[%f] == 4.0 \n", val);
if (val == 5.0) printf("val[%f] == 5.0 \n", val);
}
```
If you move the slider using step in this test,
You can see that some logs are not visible. (Some values are incorrect)
Test Plan:
elementary_test -to slider
elementary_test -to efl.ui.slider
Reviewers: woohyun, cedric, bu5hm4n
Reviewed By: woohyun, bu5hm4n
Subscribers: bu5hm4n, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10662
Xavi Artigas [Mon, 18 Nov 2019 11:30:22 +0000 (12:30 +0100)]
docs: Typos in ninja doc screen output
Xavi Artigas [Mon, 18 Nov 2019 10:57:30 +0000 (11:57 +0100)]
doxygen: Prevent auto-linking of invalid links
Anything starting with http://, ftp:// or file:// is automatically
converted into a link by doxygen. However, we have a few instances
where we do not want this. Fortunately, doxygen allows using % to
forbid specific words from being linked.
Cedric BAIL [Fri, 15 Nov 2019 17:39:38 +0000 (09:39 -0800)]
eldbus: only free the data when the future is resolved or rejected.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10684
Hermet Park [Mon, 18 Nov 2019 02:49:52 +0000 (11:49 +0900)]
evas image cache: drop cache properly,
the default reference is 1,
thus we should drop it unless if it's more than 1,
Hermet Park [Mon, 18 Nov 2019 02:48:40 +0000 (11:48 +0900)]
evas vg: improve caching methods for better precise behaviors.
Previously, json file data won't be shared between instances.
Now, objects can share the json data if they use the same file resource.
Hermet Park [Mon, 18 Nov 2019 03:57:18 +0000 (12:57 +0900)]
Revert "evas: migrate the vg json example"
This reverts commit
a1f1cd6dd67de8eac0e302d47ce2aebf44aead16.
Eeek, this shouldn't be pushed yet.
Marcel Hollerbach [Mon, 18 Nov 2019 02:44:15 +0000 (11:44 +0900)]
evas: migrate the vg json example
Summary:
i was not able to run the example before this commit, nor after this
commit. However, i had to migrate this, as i want to remove the player
object.
Depends on D10637
Reviewers: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10666
Cedric BAIL [Thu, 14 Nov 2019 00:01:55 +0000 (16:01 -0800)]
eo: do not over compute the hash when propagating events.
This should slightly improve speed in theory. In practice, I have not seen
a benchmark which would budge by 5%, so I am not sure it improve speed that
much.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10660
Cedric BAIL [Wed, 13 Nov 2019 23:02:51 +0000 (15:02 -0800)]
eo: no need to oversize type.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10659
Cedric BAIL [Wed, 13 Nov 2019 23:01:00 +0000 (15:01 -0800)]
eo: refactor shortcut for EFL_EVENT_DESTRUCT event.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10658
Stefan Schmidt [Thu, 14 Nov 2019 09:48:32 +0000 (10:48 +0100)]
ci/travis: remove no longer needed travis keywords
Highlighted by the new build config validation feature we can see that
sudo is no longer needed and on_cancel is not a valid keyowrk for IRC
notifications.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10665
Stefan Schmidt [Thu, 14 Nov 2019 09:44:33 +0000 (10:44 +0100)]
ci/travis: Enable the new build config validation beta feature
This feature wil enable the validation of our config files (only
.travis.yml in our case) and give out warnings and errors on problematic
parts in the "View Config" tab on the Travis UI.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10664
Stefan Schmidt [Fri, 15 Nov 2019 08:24:48 +0000 (09:24 +0100)]
ci: cleanup the check for old meson versions
We install the newest version via pip on our CI docker images. No longer
need to check for this.
Differential Revision: https://phab.enlightenment.org/D10681
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Stefan Schmidt [Fri, 15 Nov 2019 08:05:16 +0000 (09:05 +0100)]
ci: remove logic for doing coverity builds only on Saturday
We had this disabled for the release and I think having it run every
nice is quite nice to give fast feedback on Coverity issues.
Differential Revision: https://phab.enlightenment.org/D10680
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
maxerba [Sat, 16 Nov 2019 17:11:27 +0000 (18:11 +0100)]
The header was filled with the standard template, now it's filled with correct infos
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2019 14:22:48 +0000 (14:22 +0000)]
edje - box - calc min size correctly at start ...
this fixes a logic hole where no chosen desc has been applied yet to a
box and thus it has no start layout thus no way to calc a min size.
this breaks min size calcs you do when setting up and object. this
fixes that by forcing the chosen desk on a min size calc so there is
one.
@fix
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2019 13:00:21 +0000 (13:00 +0000)]
ecore-x - add some xi2 api's for fiddling with device properties
add some infra to be able to get and set device properties (as well
as know if devices changed to we can refersh a gui or re-apply saved
settings etc.). it doesn't do everything but... it adds enough to
build on in e.
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2019 12:58:34 +0000 (12:58 +0000)]
efreet - consider ctime changes as changes too
some distros do odd things with source desktop files and set their
mtime timestamps to 0... thus we can't tell that there is a change.
thier ctimes do change, so consider the newer of either of these as
the modification time to not miss updates
@fix
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2019 12:57:14 +0000 (12:57 +0000)]
strings - be cleaere we are initialising buffers not appending
also should silence possible code checkers.
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2019 12:56:17 +0000 (12:56 +0000)]
elm theme - ensure hotspot is visible so it is calculated
new changes to avoid calcs on invisible parts means the hotspot doesnt
recalc thus doesnt move thus... is wrong. make it visible in the theme
to ensure it is.
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2019 13:00:12 +0000 (13:00 +0000)]
add .uuid files to ignore
JunsuChoi [Fri, 8 Nov 2019 06:33:50 +0000 (06:33 +0000)]
Eina_Matrix : Use math header for cosf and sinf of rotate function.
The local cos and sin functions differ from
the math header cos and sin functions by result values
The 4th decimal place is different.
Computing large numbers can cause errors.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10467
Stefan Schmidt [Fri, 15 Nov 2019 16:56:56 +0000 (11:56 -0500)]
gl_drm: remove dead return statement
Summary:
This return can never be reached in this function.
CID: 1402607
Depends on D10682
Reviewers: raster, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10683
Stefan Schmidt [Fri, 15 Nov 2019 16:55:47 +0000 (11:55 -0500)]
examples: efl_exe: fix out of bounds write
Summary:
Buf is 4096 in size and rw_slice.len also evaluates to 4096. Write at
the last byte and not over bound instead.
CID: 1403895
Reviewers: raster, bu5hm4n, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10682
Daniel Kolesa [Fri, 15 Nov 2019 12:36:30 +0000 (13:36 +0100)]
eolian: fix memory leak when using error objects
Boris Faure [Fri, 15 Nov 2019 11:54:55 +0000 (12:54 +0100)]
efreet: fix typo
Summary: efreet: fix typo
Test Plan: None
Reviewers: cedric, raster, lauromoura, devilhorns, marcelhollerbach, segfaultxavi, zmike, vtorri
Reviewed By: segfaultxavi, vtorri
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10676
Lauro Moura [Fri, 15 Nov 2019 03:09:29 +0000 (00:09 -0300)]
csharp: FunctionPtr wrappers are not IDisposable
Summary:
They don't actually store unmanaged memory and we already rely on the GC
to free them (not calling Dispose() directly through the managedCb
closure, so we don't need IDisposable.
Just making sure we release the Function Pointer data in the main loop
as the GC runs in a different thread.
Ref T8423
Depends on D10672
Reviewers: brunobelo, felipealmeida, YOhoho
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8423
Differential Revision: https://phab.enlightenment.org/D10673
Lauro Moura [Fri, 15 Nov 2019 03:08:38 +0000 (00:08 -0300)]
csharp: Silence CA2000 in tests
Summary:
These objects are expected to leave scope while alive.
Ref T8423
Depends on D10671
Reviewers: brunobelo, felipealmeida, YOhoho
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8423
Differential Revision: https://phab.enlightenment.org/D10672
Lauro Moura [Fri, 15 Nov 2019 03:07:11 +0000 (00:07 -0300)]
csharp: Suppress CA2000 in native wrappers.
Summary:
These methods may instantiate `IDisposable` classes like `Array`,
`Iterator` to pass to user-overriden C# methods. As we can't
guarantee the user stored the object or not, we can't call Dispose
directly on them.
Ref T8423
Depends on D10670
Reviewers: brunobelo, felipealmeida, YOhoho
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8423
Differential Revision: https://phab.enlightenment.org/D10671
Lauro Moura [Fri, 15 Nov 2019 03:06:29 +0000 (00:06 -0300)]
csharp: More CA2000 fixes
Summary:
For eldbus.Proxy.Send, as the native function takes ownership of the
message, we Ref it so it can still be used afterwards.
Ref T8423
Reviewers: brunobelo, felipealmeida, YOhoho
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8423
Differential Revision: https://phab.enlightenment.org/D10670
abdulleh Ghujeh [Fri, 15 Nov 2019 01:14:03 +0000 (10:14 +0900)]
Edje : textblock_styles strncmp improvement
Summary: Improve string comparison
Reviewers: cedric, ali.alzyod, woohyun, bu5hm4n
Reviewed By: woohyun
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10635
JunsuChoi [Fri, 15 Nov 2019 06:56:04 +0000 (15:56 +0900)]
Revert "efl_ui/layout: selectively inhibit theme,changed event"
This reverts commit
6ed8c7653e87da4f81da5a21c3b942e9fa0f828e.
This patch is under discussion whether or not to revert from open source.
@tizen_only
@tizen_fix
Change-Id: Icfe948cfee17242e6f433656268f33b00625613e
Lauro Moura [Thu, 14 Nov 2019 18:39:24 +0000 (18:39 +0000)]
edje: Remove warnings
Missing declaration from another file and removing unused variable.
After D10605
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10674
Bruno da Silva Belo [Thu, 14 Nov 2019 17:26:16 +0000 (14:26 -0300)]
csharp: Disposing IDisposable objects.
Summary: ref T8423
Reviewers: lauromoura, felipealmeida, YOhoho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8423
Differential Revision: https://phab.enlightenment.org/D10644
Woochanlee [Thu, 14 Nov 2019 05:16:18 +0000 (05:16 +0000)]
edje_calc: Exception handling if no calculation is required.
If there is no object swllowed, do not run part_calc on it.
This swallow will be calculated if there is an associated part, otherwise it will not need to be calculated.
When the app is launched, a lot of edje calculation logic is executed.
Most of the edje size is missing, so the calculation result is meaningless.
Added code to prevent this.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10605
Chris Michael [Thu, 14 Nov 2019 17:21:40 +0000 (12:21 -0500)]
ecore-drm2: Fix issue of shifting 1 by more than 32bits
Based on
9ca573f40f1065cc717c0c5aabb787671bab852b, this patch fixes
potential undefined behaviour on 64 bit systems.
@fix
Daniel Kolesa [Thu, 14 Nov 2019 03:02:09 +0000 (04:02 +0100)]
eo: fix UB in the eo event code (edje_cc hangs etc.)
Today I started experiencing mysterious hanging of edje_cc
during build. "The French are at it again" I thought, and
after spending a while bisecting, I found the culprit.
It's
7f53d9158395504151e1ff3dcae715a799d913a8.
So, what is happening in here?
The idea here was fundamentally sound; compute a special
hash value for event descriptors, taking range between 0
and 63 (on 64-bit systems) and 0 and 31 (on 32-bit systems),
then use a mask sized 32-bit or 64-bit (depending on your
system) and check early if to bail out from callback_call,
saving some resources. So far so good.
The problem is in the way the mask is handled. We're applying
the hash as the shift value like, `x |= (1 << hash)`. On 32-bit
systems this is okay, but on 64-bit systems, C's dumb silent
coercion rules kick in, since the left side of the expression
is 1, a literal with type signed int; that means our shifting
range is limited to 31 and what we get is... undefined behavior.
This is obviously not what we want, so take a 1ULL value as a
base. The previous thing seemingly worked on x86_64 (nobody
reported any issues) and interestingly it worked for me too
for a while (on ppc64le), but undefined behavior can be
unpredictable, so...
This shouldn't need a commit message as long as this, but I'm
making it proportional to the amount of time I wasted on this.
JunsuChoi [Thu, 14 Nov 2019 02:25:52 +0000 (11:25 +0900)]
efl_canvas_vg_node: Prevent access to NULL object for remove warning
Summary:
For remove this warning
WRN<3378>:eo ../src/lib/eo/eo.c:644 _efl_object_call_resolve() NULL passed to function efl_invalidated_get().
Test Plan: elementary_test -> animation_view
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10627
SangHyeon Jade Lee [Thu, 14 Nov 2019 10:55:06 +0000 (19:55 +0900)]
revert "elm/genlist: remove calc jobs"
This reverts commit
576292fc111b4e6ef9d7e4322ceabfa625088bb5.
Change-Id: I68b6f4ef0bc228a94919cf56efa019e8b371f842
SangHyeon Jade Lee [Thu, 14 Nov 2019 10:51:25 +0000 (19:51 +0900)]
Revert "elm/genlist: defer recalc when applying a name filter"
This reverts commit
706e4b279f2da6bdeee28d4ee390b08a58ba0161.
Change-Id: I1e5019e7764cbb0cbc25e82baed89761070d80fd
Godly T.Alias [Mon, 4 Nov 2019 14:47:41 +0000 (20:17 +0530)]
[Genlist] Optimization for genlist clear
Avoid block calculations and cache operations during genlist clear
Change-Id: I16a35d166a71d9f4b57aa49b62758f65e3d66ced
Signed-off-by: Godly T.Alias <godly.talias@samsung.com>
Cedric BAIL [Fri, 8 Nov 2019 20:14:15 +0000 (12:14 -0800)]
efl: improve Efl.BooleanModel test by checking the child del case.
This has detected the bug that previous commit fix.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10634
Cedric BAIL [Fri, 8 Nov 2019 20:13:53 +0000 (12:13 -0800)]
efl: remove useless printf from Efl Container Model tests.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10633
Cedric BAIL [Fri, 8 Nov 2019 20:12:30 +0000 (12:12 -0800)]
ecore: correctly apply the offset on the upper part of the boolean mask for Efl.BooleanModel.
The upper mask is the one that should actually move as the gap is between the lower and
the upper mask when removing an element from the array.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10632
Cedric BAIL [Fri, 8 Nov 2019 20:10:50 +0000 (12:10 -0800)]
ecore: remove the composited children from the source of an Efl.CompositeModel.
The composite model was erroneously giving the reference to a children composited model
instead of the origianl children which made it impossible for the composited model
to delete the right child.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10631
Cedric BAIL [Fri, 8 Nov 2019 00:17:06 +0000 (16:17 -0800)]
elementary: fix initialization order and memory leak when setting model on Efl.Ui.CollectionView.
This patch use volatile model to make sure that a model is properly cleaned once it is not
used anymore.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10625
Cedric BAIL [Fri, 8 Nov 2019 00:14:44 +0000 (16:14 -0800)]
elementary: fix recursive case during model fetch in Efl.Ui.CollectionView.
Figuring out why model fetch was sometime not working recursively allow to
reduce the amount of request that need to be made. In this case, notifying
the position manager or lack of notification was triggering a case where the
item would not show up (Joice of nested asynchronous behavior).
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10624
Cedric BAIL [Fri, 8 Nov 2019 00:08:30 +0000 (16:08 -0800)]
ecore: properly handle children destruction in Efl.BooleanModel.
The children removal event is happening on the parent model, so access
values directly.
T8358
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10623
Lauro Moura [Wed, 13 Nov 2019 13:05:27 +0000 (10:05 -0300)]
csharp: Some missing conversions
Summary:
Ref T8430
Depends on D10616
Reviewers: brunobelo, segfaultxavi, felipealmeida, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8430
Differential Revision: https://phab.enlightenment.org/D10652
Lauro Moura [Wed, 13 Nov 2019 13:05:19 +0000 (10:05 -0300)]
csharp: Add conversion methods for generated types
Summary:
This also adds a helper method to convert from a value type name to the
reference type name. (e.g. int to Int32).
Ref T8430
Reviewers: felipealmeida, brunobelo, YOhoho
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8430
Differential Revision: https://phab.enlightenment.org/D10653
Yeongjong Lee [Wed, 13 Nov 2019 06:58:39 +0000 (03:58 -0300)]
eolian_mono: change OnXXXEvent access modifier from public to protected virtual
Summary:
OnXXXEvent is event invocation wrapper method to allow derived classes to
override the event invocation behavior.
Test Plan: meson with `-Dbindings=mono,cxx`
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10655
JunsuChoi [Wed, 13 Nov 2019 04:40:44 +0000 (13:40 +0900)]
wl_egl : Prevent access to NULL pointer
Summary: The pointer s can be null.
Test Plan: N/A
Reviewers: Jaehyun_Cho, raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10654
Change-Id: I83a92eb98c0010d48e354c92f3c6f6cbc0b3e7c7
Bruno da Silva Belo [Tue, 12 Nov 2019 20:07:48 +0000 (17:07 -0300)]
csharp: Add To and From methods for implicit conversion.
Summary: ref T8430
Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8430
Differential Revision: https://phab.enlightenment.org/D10616
Christopher Michael [Tue, 12 Nov 2019 15:09:54 +0000 (10:09 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_wm_rotation_supported
functions
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:55:41 +0000 (09:55 -0500)]
tests/ecore_wl2: Modify ecore_wl2_window_rotation test
Small patch to modify ecore_wl2_window_rotation test to support
ecore_wl2_window_rotation_set function
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:53:09 +0000 (09:53 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_rotation_app functions
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:50:12 +0000 (09:50 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_preferred_rotation
functions
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:47:36 +0000 (09:47 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_maximized functions
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:44:39 +0000 (09:44 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_fullscreen functions
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:41:29 +0000 (09:41 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_focus_skip_get/set
functions
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:39:15 +0000 (09:39 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_floating_mode_get/set
functions
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:35:50 +0000 (09:35 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_alpha_get/set functions
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:22:09 +0000 (09:22 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_display_compositor_version_get
ref T8016
Yeongjong Lee [Tue, 12 Nov 2019 12:46:20 +0000 (13:46 +0100)]
efl_ui_relative_container: rename relative_layout
Summary:
Also,
Rename parameter name `target` to `base`.
Rename parameter name `relative` to `relative_position`.
ref T8380
Depends On D10639
Test Plan: ninja test
Reviewers: woohyun, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8380
Differential Revision: https://phab.enlightenment.org/D10640
Yeongjong Lee [Tue, 12 Nov 2019 13:14:03 +0000 (10:14 -0300)]
eolian_mono: avoid keyword as a variable name
Summary:
```
private static void relation_left_get(System.IntPtr obj, System.IntPtr pd, Efl.Gfx.IEntity child, out Efl.Gfx.IEntity kw_base, out Efl.Gfx.Align relative_position)
{
Eina.Log.Debug("function efl_ui_relative_container_relation_left_get was called");
var ws = Efl.Eo.Globals.GetWrapperSupervisor(obj);
if (ws != null)
{
base = default(Efl.Gfx.IEntity);relative_position = default(Efl.Gfx.Align);
```
Parameter name is replaced with `kw_base` but `base` is not changed in assignment expression (`base = default(Efl.Gfx.IEntity...`).
This patch will fix following compiler error.
```
src/bindings/mono/efl_ui_relative_container.eo.cs(544,21): error CS1525: Unexpected symbol `=', expecting `.' or `['
```
Test Plan: ninja with D10640
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10639
Yeongjong Lee [Mon, 11 Nov 2019 14:33:03 +0000 (11:33 -0300)]
mono: reduce duplicated event code
Summary: Introduction GetInternalEventCallback function to reduce duplicated event code.
Test Plan: ninja test
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10638
Lauro Moura [Mon, 21 Oct 2019 14:08:58 +0000 (11:08 -0300)]
dotnet: Generate doc and check for warnings
Reviewers: segfaultxavi, brunobelo, felipealmeida
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers, woohyun
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10630
Xavi Artigas [Tue, 12 Nov 2019 12:00:23 +0000 (13:00 +0100)]
Efl.Ui.Scroll_Manager: Fix indentation
JunsuChoi [Tue, 12 Nov 2019 07:23:33 +0000 (16:23 +0900)]
evas_device: Fix typo in evas_device_pop
Summary: Fix wrong null check
Test Plan: N/A
Reviewers: cedric, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10648
Change-Id: Ifd052087c960b81129c1f6db0cc85bc56d05e758
JunsuChoi [Tue, 12 Nov 2019 05:30:25 +0000 (14:30 +0900)]
Efl.Ui.Animation_View: Implement sector playing feature
Summary:
play_sector method is API for playing section.
If the animation object has section information, user can play the section.
Get the start and end section name and get the frame of each section.
And set and play the min and max frames of the current animation object.
Depends on D10506
Test Plan:
For example. Animation objects have "first","second" and "third" sectors.
And sector "second" has duration information.
User can use it like this:
efl_ui_animation_view_play_sector(anim_view, "first", "second");
efl_ui_animation_view_play_sector(anim_view, "second", NULL);
efl_ui_animation_view_play_sector(anim_view, "first", NULL); // first sector ~ end frame of animation object.
efl_ui_animation_view_play_sector(anim_view, "second", "third");
efl_ui_animation_view_play_sector(anim_view, "second", "wrong name");
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10507
JunsuChoi [Tue, 12 Nov 2019 05:30:10 +0000 (14:30 +0900)]
Efl.Gfx.Frame_Controller: Add sector property
Summary:
These APIs to get and set frames for a specific section for playing section.
Depends on D10505
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10506
JunsuChoi [Tue, 12 Nov 2019 05:29:50 +0000 (14:29 +0900)]
evas_cache_vg : Implements sector_get/set internal APIs
Summary:
These APIs to get and set frames for a specific section in vg animation.
get API looks for a sector by name in the markerlist of VG_File_Data.
Then return start and end frames.
Depends on D10504
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10505
JunsuChoi [Tue, 12 Nov 2019 05:28:44 +0000 (14:28 +0900)]
vg_loader: Get markers information form json data.
Summary: If json data has marker information, it is stored in vg file data.
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10504
Shinwoo Kim [Tue, 12 Nov 2019 01:07:54 +0000 (10:07 +0900)]
evas_filter: remove shader compile error
Summary:
When grayscale fillter works there is a compile error:
implicit cast from "float" to "vec3"
Test Plan:
1. Create filter_example with following .
efl_gfx_filter_program_set(image, "grayscale ()", "grayscale");
2. Run.
ELM_ACCEL=gl ./filter_example
Reviewers: Hermet, jsuya
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10595
JunsuChoi [Wed, 13 Nov 2019 04:40:44 +0000 (13:40 +0900)]
wl_egl : Prevent access to NULL pointer
Summary: The pointer s can be null.
Test Plan: N/A
Reviewers: Jaehyun_Cho, raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10654
Change-Id: I2db21b24180bb9a29811617f9996e7f5bdf36196
Bowon Ryu [Tue, 12 Nov 2019 07:43:53 +0000 (16:43 +0900)]
evas_object_textblock: fix coverity warning.
This less-than-zero comparison of an unsigned value is never true.
Change-Id: I4d0845d9e0f0f61200013c76307deeaabb8a5f52
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Bowon Ryu [Tue, 12 Nov 2019 07:35:22 +0000 (16:35 +0900)]
evas_object_textblock: fix svace warning
Change-Id: I2c2712ea5533d8d947933f1c6c779d855f41e18d
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Jaehyun Cho [Fri, 1 Nov 2019 08:14:30 +0000 (17:14 +0900)]
elm_index: implement elm_widget_item_signal_emit
elm_index implements elm_widget_item_signal_emit to support
elm_object_item_signal_emit.
@tizen_feature
Change-Id: I59ae651c2ffe8ae795da7789bec1533b938bc483
JunsuChoi [Tue, 12 Nov 2019 07:23:33 +0000 (16:23 +0900)]
evas_device: Fix typo in evas_device_pop
Summary: Fix wrong null check
Test Plan: N/A
Reviewers: cedric, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10648
Change-Id: I51c3f152c1ac4f49a0ed1787a656e350415c647e
Bowon Ryu [Tue, 12 Nov 2019 03:26:06 +0000 (12:26 +0900)]
Revert "Revert "evas_textblock: content fit feature""
@tizen_feature
This reverts commit
7bd419a6a0a52d90a56bdfb1a193fa8bbe7361f8.
Change-Id: I5c19e99acf4f83a8dc895c4cf2e56ba0de6cf955
Stefan Schmidt [Mon, 11 Nov 2019 08:58:18 +0000 (09:58 +0100)]
ci: fix ccache segfault during setup on CI in release-ready build
Hopefully this is the last place we need to apply this. It has been
bugging the cron daily CI builds a while now.
Differential Revision: https://phab.enlightenment.org/D10643
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Marcel Hollerbach [Thu, 7 Nov 2019 22:00:36 +0000 (23:00 +0100)]
elm: apply the same fix we needed in entry to other scrollable widgets
this here is the same effect as in my previous commit:
When re retheme a object, we need to reset the signals, otherwise there
would be wrongly displayed scrollbars.
This fixes wrong scrollbars in enlightenment.
Differential Revision: https://phab.enlightenment.org/D10628
Marcel Hollerbach [Mon, 11 Nov 2019 09:14:42 +0000 (10:14 +0100)]
efl_canvas_animation: correctly handle double signness
Summary:
start_delay and duration both have to be > 0.0 otherwise there should be
an error. This also adds the neccessary checks, to ensure that.
For now this is only added to the normal evas test suite, maybe we eed
to refactor these efl_* API tests into theire own test suite. However,
not for now.
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10617
Jongmin Lee [Mon, 11 Nov 2019 06:16:02 +0000 (15:16 +0900)]
Revert "ecore-wl2: Move ecore_wl2_surface_create function to be internal"
This reverts commit
624e4bdce82bd26124ef2b78c3125be4cce52901.
Change-Id: I070f804e72fbedd422b1c74e5c8b2985958f2001
Jongmin Lee [Mon, 11 Nov 2019 05:01:35 +0000 (14:01 +0900)]
build:resolve migration build error
Change-Id: I8288c25adc596afa5a4802072601db0440a07337
Wonki Kim [Mon, 11 Nov 2019 02:23:31 +0000 (11:23 +0900)]
Revert "evas_textblock: content fit feature"
This reverts commit
94cacec55471055e69193f03646f5deb823c4319.
Jongmin Lee [Mon, 11 Nov 2019 00:30:43 +0000 (09:30 +0900)]
build: resolve migration build error
Change-Id: Iff129b325858fe6c646374d1b3c7606c17e54849
Bruno da Silva Belo [Fri, 8 Nov 2019 02:33:09 +0000 (23:33 -0300)]
csharp: Localization strings with CultureInfo.
Summary: ref T8404
Reviewers: lauromoura, felipealmeida, YOhoho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8404
Differential Revision: https://phab.enlightenment.org/D10608
Lauro Moura [Fri, 8 Nov 2019 01:46:15 +0000 (22:46 -0300)]
csharp: Fix running headless tests in dotnet
Summary:
CoreCLR, the runtime of dotnet, has some issues regarding storing
environment variables (see dotnet/coreclr issue #15812), keeping them in
a local cache instead of flushing to the native `setenv`.
This commit replaces the usage of
`System.Environment.SetEnvironmentVariable` with a `setenv` wrapper.
Test Plan: Run without DISPLAY set and with dotnet.
Reviewers: felipealmeida, brunobelo, segfaultxavi, YOhoho
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10619
Marcel Hollerbach [Thu, 7 Nov 2019 20:45:02 +0000 (21:45 +0100)]
elm_entry: fix wrong displayed scrollbars
the scrolbars have been displayed wrongly before. Reason for this is
that the theme displays the bars per default, the code however works
with hidden by default. This was worked arround before with the fact
that we are explicitly hiding the vbar/hbar before.
The reason this previous code was not working proberly is that entry
decided to retheme a object that was already set to the interface
scrollable object. Which means, it was not detected by the code. With
the newly introduced reset function you can tell the interface, that you
have changed the group, signals will be emitted accordingly.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10622
Cedric BAIL [Thu, 7 Nov 2019 19:53:15 +0000 (11:53 -0800)]
elementary: watch event on the model Efl.Ui.CollectionView use directly.
Efl.Model can be nested and Efl.Ui.CollectionView use this ability. Listening
on the nested model instead of the nester model can lead to event being triggered
that shouldn't. Better listen on the top model.
Differential Revision: https://phab.enlightenment.org/D10621
Cedric BAIL [Thu, 7 Nov 2019 18:58:04 +0000 (10:58 -0800)]
eo: make sure to return the right value for efl_event_callback_call.
EINA_FALSE is to be returned only if one of the callback did call
efl_event_callback_stop not if their was no callback called.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10620
Cedric BAIL [Wed, 6 Nov 2019 23:09:14 +0000 (15:09 -0800)]
elementary: properly handle in flight request in Efl.Ui.CollectionView.
This fix adding item not always showing up in the CollectionView right away.
The main issue comes down to the fact we can not chain a new request when one
is already resolved partially. The code now make sure to properly do this.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10614
Cedric BAIL [Wed, 6 Nov 2019 23:06:17 +0000 (15:06 -0800)]
elementary: cleanup Eina_Future properly by relying on efl_future_then proper lifecycle.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10613
Lauro Moura [Thu, 7 Nov 2019 20:59:40 +0000 (17:59 -0300)]
csharp: Make GetPart public.
Summary:
`efl_part_get` is protected in C due to the presence of `efl_part`,
which does automatic refcount management in single method calls.
The C# binding has no limitation on this as it already handles the
lifetime for all objects.
Fixes T8462
Reviewers: brunobelo, segfaultxavi, SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8462
Differential Revision: https://phab.enlightenment.org/D10594
Bruno da Silva Belo [Thu, 7 Nov 2019 18:52:31 +0000 (19:52 +0100)]
csharp: Removing a never used class.
Summary: ref T8417
Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8417
Differential Revision: https://phab.enlightenment.org/D10611
Taehyub Kim [Thu, 7 Nov 2019 04:38:47 +0000 (13:38 +0900)]
efl_ui_alert_popup: add title part in parts block
Summary: add title part in parts block
Reviewers: Jaehyun_Cho, woohyun, zmike, segfaultxavi
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10596
Lauro Moura [Thu, 7 Nov 2019 02:47:50 +0000 (23:47 -0300)]
csharp: Fix test build dependency
Summary: Make dotnet target also depend on the manual test files.
Test Plan: Modify one of the manual files and run the tests again. The test target should be rebuilt.
Reviewers: bu5hm4n, segfaultxavi, brunobelo, felipealmeida
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10609