platform/core/system/storaged.git
6 years agoblock: Mapper device should not update udev data on format operation 40/156140/1
pr.jung [Tue, 17 Oct 2017 07:41:06 +0000 (16:41 +0900)]
block: Mapper device should not update udev data on format operation

Change-Id: I2a7473272e8c6b26d66dd5de4f06879e5b0aa038
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoSupport for encrypted internal memory extension 42/129342/20
Krzysztof Jackiewicz [Fri, 22 Sep 2017 12:01:58 +0000 (14:01 +0200)]
Support for encrypted internal memory extension

- Support device mapper devices. Necessary because dmcrypt uses device mapper.
  It also requires proper udev rules for device mapper. Device mapper devices
  will be marked as BLOCK_MAPPER_DEV (previously
  BLOCK_MMC_EXTENDED_INTERNAL_DEV). Update block.conf file and related logic.

- Support different/unknown filesystems. We don't know what kind of data will
  be on sd card, but we have to be able to detect it. All sdcards are marked as
  BLOCK_MMC_DEV. Listener can distinguish cards by fs_type if needed.

- For devices with non-filesystem FS_USAGE (for example "crypto") we don't need
  2.4 backward compatibility and fixed id.

- Don't generate mount path for devices with non-filesystem FS_USAGE.

- Don't check for primary partition on device mapper devices.

- Don't check multimount for unknown filesystems.

- Trigger card setup UI for cards without LUKS or with garbage on them. Don't
  treat unformatted cards as an error.

- For internal memory extension assign the mountpoint in make_block_data() as
  in case of other types of storage.

- Don't try to mount unknown filesystems.

- In case of device mapper udev events treat "change" as "add" (perhaps this
  can be avoided by providing proper udev rules).

- Update device data when udev "change" event occurs. Formatting partition
  externally (LUKS case) requires manual udev read so that both udev and
  storaged have the actual device state. Also notify listeners about this
  change.

- Allow unmounting internal memory extension card. Not sure why it was disabled.

Change-Id: I26f98b31a24936f0b4524fc5c081163f9c9e4878
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
6 years agoModify UX scenario to set up sdcard through setting apps 15/155315/3
Hyotaek Shim [Fri, 13 Oct 2017 02:09:56 +0000 (11:09 +0900)]
Modify UX scenario to set up sdcard through setting apps

Change-Id: Ib6a6bba01222b0c74ad15aff6b47e424a62b0ca9
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
6 years agoVFAT format with the label(emul-sdcard) in the mobile emulator 53/155253/1
Hyotaek Shim [Thu, 12 Oct 2017 12:12:06 +0000 (21:12 +0900)]
VFAT format with the label(emul-sdcard) in the mobile emulator

Change-Id: I0747f1f1540fc844c9fc90483f91cd6261f5ffb4
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
6 years agoblock, app: Add CheckSpeed 72/154872/1
pr.jung [Wed, 11 Oct 2017 07:52:57 +0000 (16:52 +0900)]
block, app: Add CheckSpeed

- Add CheckSpeed dbus method on storaged
- App calls CheckSpeed (internal extended sdcard)

Change-Id: I90817330ce210946d9ee1a1b9fcc9895648d431c
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 645a395e3af4fa85a1f4840b76a30da154f51c93)

6 years agoRemove "Requires: %{name}-org.tizen.extended-sd" 67/154667/1 accepted/tizen/unified/20171011.150308 submit/tizen/20171011.042629 submit/tizen/20171011.074613
Hyotaek Shim [Wed, 11 Oct 2017 04:23:08 +0000 (13:23 +0900)]
Remove "Requires: %{name}-org.tizen.extended-sd"

Change-Id: Iba7f575599447169d33b3d3144ece788d55460ea
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
6 years agoblock: Do not add INSERT operation for unformatted device (except mmc) 67/154367/2 submit/tizen/20171010.082421
pr.jung [Tue, 10 Oct 2017 06:23:49 +0000 (15:23 +0900)]
block: Do not add INSERT operation for unformatted device (except mmc)

Change-Id: I73ed8bf74b367397f25ec043d690d7caa63e7b30
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoapp: svace fix - handle NULL var 64/154264/3 accepted/tizen/unified/20171010.162512 submit/tizen/20171010.031320
sanghyeok.oh [Tue, 10 Oct 2017 02:51:11 +0000 (11:51 +0900)]
app: svace fix - handle NULL var

Change-Id: I6d2ece851362dfdbaa40e2b80d5c65d491e6956a
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
6 years agoAdd "Requires: %{name}-org.tizen.extended-sd" 69/154269/1
Hyotaek Shim [Tue, 10 Oct 2017 02:22:01 +0000 (11:22 +0900)]
Add "Requires: %{name}-org.tizen.extended-sd"

Change-Id: I1efc633404818c65530f4142770466f030166fdb
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
(cherry picked from commit f7aafc6095ba447bd99c621645a86609bd83199d)

6 years agoCoverity fixes. 30/153630/2
INSUN PYO [Fri, 29 Sep 2017 04:04:19 +0000 (13:04 +0900)]
Coverity fixes.

Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I0e0745dbbd84ed7e76f5eb0ff4211c127dfd7687

6 years agoblock: Free th_node_list when block_exit 88/153688/2
pr.jung [Fri, 29 Sep 2017 05:32:41 +0000 (14:32 +0900)]
block: Free th_node_list when block_exit

Change-Id: Iceb902056361ee7e7d470d25cfa73706371c78e4
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoblock: Add a mutex for pipe 89/153689/1
pr.jung [Fri, 29 Sep 2017 06:24:38 +0000 (15:24 +0900)]
block: Add a mutex for pipe

- Multithread should not write pipe at the same time

Change-Id: Ic95645160e339716bdba8874d42c5aeb516aa520
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoinclude src/shared/dbus_macro.h in apps/* 46/152946/1 accepted/tizen/unified/20170929.081543 submit/tizen/20170928.010842 submit/tizen/20170928.082606
Hyotaek Shim [Wed, 27 Sep 2017 10:58:38 +0000 (19:58 +0900)]
include src/shared/dbus_macro.h in apps/*

Change-Id: I4c838338226cfada67e7913e6a8694b0e8b282d8
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
6 years agoudev: Increase udev monitor buffer size 25/152725/1 accepted/tizen/unified/20170928.072235 submit/tizen/20170927.065426 submit/tizen/20170927.232123
INSUN PYO [Wed, 27 Sep 2017 02:58:06 +0000 (11:58 +0900)]
udev: Increase udev monitor buffer size

Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I17054338f2b600f4a17e0b41502a565539b069a6

6 years agoudev: Increase udev monitor buffer size 34/152534/1
pr.jung [Tue, 26 Sep 2017 09:02:37 +0000 (18:02 +0900)]
udev: Increase udev monitor buffer size

Change-Id: Ieb3dffe9548530baa89c114c8ab5b9ac8c09cf52
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoudev: Do not receive G_IO_ERR flag 62/152462/1
pr.jung [Tue, 26 Sep 2017 07:41:40 +0000 (16:41 +0900)]
udev: Do not receive G_IO_ERR flag

Change-Id: I83ab9c89594c1690c54baf7bf7147add012b41e3
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 49bf0ea30237315f833274e3580797c5ddc6b97d)

6 years agoblock: Do not mount unformatted storage at booting time 52/152452/1
pr.jung [Tue, 26 Sep 2017 01:08:02 +0000 (10:08 +0900)]
block: Do not mount unformatted storage at booting time

Change-Id: I3c7608c4e76cc0fe4fcb0b21cfcc039e02aee34b
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 623c073f0783b615750a6d33f0b7ae2e4851e568)

6 years agoblock: Need to set VCONFKEY_SYSMAN_MMC_EXTENDEDINTERNAL_MOUNTED for extended internal... 50/152450/1
pr.jung [Mon, 25 Sep 2017 07:32:20 +0000 (16:32 +0900)]
block: Need to set VCONFKEY_SYSMAN_MMC_EXTENDEDINTERNAL_MOUNTED for extended internal sdcard

Change-Id: If4b596e97f0605d52113b185225ffdadda3a3ad6
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 6f9731069c7c99447548293e84fe1802a989399f)

6 years agodbus: unref reply message 20/152420/1
pr.jung [Mon, 25 Sep 2017 09:59:34 +0000 (18:59 +0900)]
dbus: unref reply message

Change-Id: Id47482a765be09f5994fd692e0366ae2c6ba4a7a
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoremove duplicated exception codes 50/151750/2 submit/tizen/20170922.080655
Hyotaek Shim [Fri, 22 Sep 2017 01:36:48 +0000 (10:36 +0900)]
remove duplicated exception codes

Change-Id: I86d3da1d03b2af52115e37e634e1be506842688f
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
6 years agoblock: Change mount path of extended internal storage at booting time 74/150974/1
pr.jung [Tue, 19 Sep 2017 08:04:33 +0000 (17:04 +0900)]
block: Change mount path of extended internal storage at booting time

Change-Id: I862f4cc1a5d92aeb5870154e7d957fb2d9f2b74b
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoapp: Call myfiles app on Move files button callback 60/150960/1
pr.jung [Tue, 19 Sep 2017 07:35:04 +0000 (16:35 +0900)]
app: Call myfiles app on Move files button callback

Change-Id: I865ba1dc65f0801ea4747aca4375dc61aab09301
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoblock: Change /opt/extendedsd directory access permission 08/150908/1
pr.jung [Tue, 19 Sep 2017 05:28:04 +0000 (14:28 +0900)]
block: Change /opt/extendedsd directory access permission

- 770 root priv_externalstorage * -> 755 root root _

Change-Id: I2428d90e7178fd50af822aa1ff7895dc324fce0b
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit a490b2e4eb125c07771dd5084e324e73a61242a1)

6 years agoblock: Launch sdcard setting popup when sdcard is inserted after booting is done 06/150906/2
pr.jung [Tue, 19 Sep 2017 05:10:00 +0000 (14:10 +0900)]
block: Launch sdcard setting popup when sdcard is inserted after booting is done

Change-Id: Icd62e3be2d58c82d2f4afaf854590a1cf1239fed
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 7ac0b06affd5668ee06c1466d44d7a0bf10dc128)

6 years agoapp: Change async call timeout to 120sec. 05/150905/1
pr.jung [Tue, 19 Sep 2017 04:46:04 +0000 (13:46 +0900)]
app: Change async call timeout to 120sec.

Change-Id: I09f1c634cd09246fb481a7bd4d6a3d32ee629147
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 8b5a310953a56fc7281793ebb63cf79e3634d176)

6 years agoapp: Call FormatwithType asynchronously 64/150764/2
pr.jung [Mon, 18 Sep 2017 11:22:34 +0000 (20:22 +0900)]
app: Call FormatwithType asynchronously

Change-Id: I10d779bbd64d1dd6f856d650df2a42ffea9fc33e
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 0e6ed6b68508fd5fb438377cd99c443712f2b057)

6 years agoblock: Only for primary mmc, vconf key value should be valid 59/150759/2
pr.jung [Mon, 18 Sep 2017 11:19:56 +0000 (20:19 +0900)]
block: Only for primary mmc, vconf key value should be valid

Change-Id: I1b3362978d9e649cd8801d7494743bbcb8ff3350
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 4af347bc7a99dcceaa6e8953946756786e81b53b)

6 years agoblock: Add an app to setup sdcard 88/143988/19
pr.jung [Mon, 14 Aug 2017 06:24:16 +0000 (15:24 +0900)]
block: Add an app to setup sdcard

- When sdcard is inserted, extended-sd app is launched
- User can choose the usage of sdcard (portable storage or internal storage)

Change-Id: I6a6e527bff8e12d56bfe8468c72d089a81a66bda
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 736a22188bd61ae413e548c66d5d086d573970db)

6 years agodbus: incorrect use of GetConnectionUnixProcessID method. 37/150237/1
INSUN PYO [Fri, 15 Sep 2017 01:55:08 +0000 (10:55 +0900)]
dbus: incorrect use of GetConnectionUnixProcessID method.

dbus.c: get_dbus_method_sender_pid(169) > no message : [org.freedesktop.DBus.Error.InvalidArgs:Argument 0 is specified to be of type "int32", but is actually of type "uint32"

Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: Ia1dbe36ae55cd3b24000f406e135d318d4163362

6 years agoApply Tizen Coding Rule 39/149239/3 accepted/tizen/unified/20170913.071536 submit/tizen/20170912.090438
pr.jung [Tue, 12 Sep 2017 02:28:02 +0000 (11:28 +0900)]
Apply Tizen Coding Rule

Change-Id: I8bad9418fc390b46879403fc6bd96dafd51e0991
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoblock: Format as ext4 filesystem when request is for extended internal storage 48/131248/8
pr.jung [Wed, 10 May 2017 10:12:31 +0000 (19:12 +0900)]
block: Format as ext4 filesystem when request is for extended internal storage

Change-Id: Ia00b45e1306b6aeda266a915c21d7514263c0182
Signed-off-by: pr.jung <pr.jung@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
6 years agoblock: Checking calloc failed 32/148432/3 accepted/tizen/unified/20170908.220714 submit/tizen/20170908.052651
pr.jung [Fri, 8 Sep 2017 02:31:33 +0000 (11:31 +0900)]
block: Checking calloc failed

Change-Id: Icad2dd4c3580793d4ce6838210b62df00d7a3c08
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoblock: Only for primary mmc, vconf key value should be valid 58/146958/4
pr.jung [Thu, 31 Aug 2017 08:38:23 +0000 (17:38 +0900)]
block: Only for primary mmc, vconf key value should be valid

Change-Id: I7923441baa51517e304d78bcf07d392ff933223c
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoblock: Create file when sdcard is inserted 86/141086/2 accepted/tizen/4.0/unified/20170816.011942 accepted/tizen/4.0/unified/20170816.015025 accepted/tizen/4.0/unified/20170829.020438 accepted/tizen/unified/20170731.020634 submit/tizen/20170728.063117 submit/tizen_4.0/20170811.094300 submit/tizen_4.0/20170814.115522 submit/tizen_4.0/20170828.100004 submit/tizen_4.0_unified/20170814.115522
pr.jung [Fri, 28 Jul 2017 06:16:49 +0000 (15:16 +0900)]
block: Create file when sdcard is inserted

Change-Id: Ia430af302ac7df92aa916313c73f3bd4d7fc26a9
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoblock: Check return value of mnt_fs_get_srcpath 67/132867/1 accepted/tizen/unified/20170608.184603 submit/tizen/20170608.051314
pr.jung [Thu, 8 Jun 2017 04:58:59 +0000 (13:58 +0900)]
block: Check return value of mnt_fs_get_srcpath

Change-Id: Ib5f35b3a5a0a8eba50d4add92fed9e65c6148b74
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoblock: Prevent buffer overflow 63/132663/1
pr.jung [Wed, 7 Jun 2017 06:00:15 +0000 (15:00 +0900)]
block: Prevent buffer overflow

- Specify a limit on the input string length
when using s with '%' format specifies for scanf-like functions

Change-Id: I7406565b9d834763784ff8c18bdd9cf31119536d
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Change sizeof to strlen to get length of devnode 43/127043/1 accepted/tizen/unified/20170426.195755 submit/tizen/20170426.042525 tizen_4.0.m1_release
pr.jung [Wed, 26 Apr 2017 02:49:07 +0000 (11:49 +0900)]
block: Change sizeof to strlen to get length of devnode

Change-Id: I0af1a7e100917f873c128af63f6796aef217059f
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock, storage: Recevie StartupFinished signal instead of BootingDone signal 36/126536/1 accepted/tizen/unified/20170425.044934 submit/tizen/20170424.085953
pr.jung [Mon, 24 Apr 2017 05:50:51 +0000 (14:50 +0900)]
block, storage: Recevie StartupFinished signal instead of BootingDone signal

- Systemd sends StartupFinished signal when system session is ready.
- Receive StartupFinished(systemd) signal instaed of BootingDone(deviced) signal.

Change-Id: I4f31c437f2dbe5811a20d6ba38407b95bc78fb6f
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Add ExtendedInternalStorage configuration 36/123536/5 accepted/tizen/unified/20170413.162741 submit/tizen/20170413.022542
pr.jung [Thu, 6 Apr 2017 04:40:52 +0000 (13:40 +0900)]
block: Add ExtendedInternalStorage configuration

- When sdcard is inserted, user needs to choose which way to use.
(External storage or extended internal storage)
- BLOCK_MMC_EXTENDED_INTERNAL_DEV is added on block_device_type

Change-Id: I33e200a74ce16d7b74eb498d0e8ccad15a9a8e8b
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agomodule : change the plugin path according to the library of arch. 25/124625/1 accepted/tizen/unified/20170412.152524 submit/tizen/20170412.041900
wchang kim [Wed, 12 Apr 2017 04:05:52 +0000 (13:05 +0900)]
module : change the plugin path according to the library of arch.

Change-Id: Ib2bfd2842aab2677e39efddd6a014c757ba1e34a

7 years agocommon: Not handle missing method 89/124389/3
pr.jung [Tue, 11 Apr 2017 08:08:23 +0000 (17:08 +0900)]
common: Not handle missing method

- If there is method call with not implemented method,
it is not handled and return DBUS_HANDLER_RESULT_NOT_YET_HANDLED

Change-Id: I46e24e2a71e7b29f589705ac7a5439b8c7c6e755
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agocommon: Do not warn about uses of functions, variables, and types marked as deprecate... 91/124591/1
pr.jung [Wed, 12 Apr 2017 01:34:57 +0000 (10:34 +0900)]
common: Do not warn about uses of functions, variables, and types marked as deprecated by using the deprecated attribute.

Change-Id: Ic026783cad4b571d7bd02790a28ae93cc734c7c1
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Should not free block device when add mount operation is failed 82/124382/1
pr.jung [Tue, 11 Apr 2017 07:34:04 +0000 (16:34 +0900)]
block: Should not free block device when add mount operation is failed

- Add insert operation is succeed, so if main thread free block device,
then block thread can't use block device

Change-Id: Ia37923a433b3f62f4c584df1390bdd18241d2c3d
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agocommon: Remove readdir 84/124184/4 accepted/tizen/unified/20170411.164111 submit/tizen/20170411.050818
pr.jung [Mon, 10 Apr 2017 11:25:32 +0000 (20:25 +0900)]
common: Remove readdir

- readdir makes no guarantee of thread safety
- Use readdir_r instead

Change-Id: I0a5c3e6bcabe1ef76291a58dd756a99a5a4a95d0
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoMerge "common: Increase refcount for DBusMessage" into tizen accepted/tizen/unified/20170407.190717 submit/tizen/20170407.050303
pr.jung [Fri, 7 Apr 2017 05:01:17 +0000 (22:01 -0700)]
Merge "common: Increase refcount for DBusMessage" into tizen

7 years agocommon: Increase refcount for DBusMessage 93/123793/1
pr.jung [Fri, 7 Apr 2017 04:33:22 +0000 (13:33 +0900)]
common: Increase refcount for DBusMessage

- DBusMessage should not be freed when result is null
- Refcount is decreased on reply_dbus_method_result

Change-Id: I712790950f42514377e9d39deecb0388e784b0c7
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Storaged needs to check repeated Add uevent 96/123596/1
pr.jung [Thu, 6 Apr 2017 07:42:17 +0000 (16:42 +0900)]
block: Storaged needs to check repeated Add uevent

Change-Id: Ia0f29e164ede7c5ad917e7c49145b9225f0c63c3
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Do not handle repeated uevent. 06/122806/1
pr.jung [Wed, 29 Mar 2017 01:37:40 +0000 (10:37 +0900)]
block: Do not handle repeated uevent.

- Check devnode is already handled.

Change-Id: I754f3192037fc3887a332770f6dbf8d5bfc3236b
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoCreate initial commit 92/118392/13 accepted/tizen_common accepted/tizen_ivi accepted/tizen_mobile accepted/tizen_tv accepted/tizen_wearable accepted/tizen/common/20170403.190742 accepted/tizen/ivi/20170403.130344 accepted/tizen/mobile/20170403.130241 accepted/tizen/tv/20170403.130316 accepted/tizen/unified/20170403.130359 accepted/tizen/wearable/20170403.130328 submit/tizen/20170403.054337
pr.jung [Fri, 10 Mar 2017 07:25:33 +0000 (16:25 +0900)]
Create initial commit

Change-Id: I8a3f42cc179eb266a502dbf1c756a32a64b91f79
Signed-off-by: pr.jung <pr.jung@samsung.com>
Signed-off-by: taeyoung <ty317.kim@samsung.com>
7 years agoInitial empty repository master
Tizen Infrastructure [Wed, 8 Feb 2017 01:50:22 +0000 (17:50 -0800)]
Initial empty repository