Creating socket everytime when network bearer changes (#285)

[CONPRO-1269] Creating socket everytime when network bearer changes

Socket was created only once but changed the logic for creating on every network change
When we are switching WifiAP or disconnect/connect again then we are not able to send unicast data from android side . It gives network unreachable error. So to avoid that we are closing and creating sockets again.

https://github.sec.samsung.net/RS7-IOTIVITY/IoTivity/pull/285
(cherry picked from commit 285875048bda46b6ac1a742c25849d70234d7cd1)

Change-Id: I6829f8e83d64905fd97de0340da0e4c1abf37972
Signed-off-by: Kush <kush.agrawal@samsung.com>
Signed-off-by: Amit KS <amit.s12@samsung.com>

Replace tizen BLE internal APIs with public

Tizen 4.0 build fails in case BLE internal API's are used,
therefore replace them with public API's. All changes are
made under the preprocess define TIZEN_4

https://github.sec.samsung.net/RS7-IOTIVITY/IoTivity/pull/282
(cherry picked from commit d66f237dc92c15a515332d0416f769d8e856bfe9)

Change-Id: I451a6519edfaa792862819d59693500ff46b50ce
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
Signed-off-by: Amit KS <amit.s12@samsung.com>

[CONPRO-1269] Creating socket everytime when network bearer changes

Socket was created only once but changed the logic for creating on every network change

https://github.sec.samsung.net/RS7-IOTIVITY/IoTivity/pull/280
(cherry picked from commit eaa97ac11871f5536ca12e7ab2f9c848b4d99afd)

Change-Id: I991d1d91c352f52baf7379b693ff2df2aaf9ee61
Signed-off-by: Kush <kush.agrawal@samsung.com>
Signed-off-by: Amit KS <amit.s12@samsung.com>

Update Snapshot(2018-04-12)

Change-Id: I0c59fd76abaff03921c5ebc8cab75344087c998d
Signed-off-by: Amit KS <amit.s12@samsung.com>

Crash in OCProcessPresence()

1. Set presence to NULL incase allocation of timeout
array fails. This ensures that OCProcessPresence does
not process this cbNode, thereby preventing possible
NULL dereference of timeout.
2. Do not send request if timeout has reached/exceeded
the  PresenceTimeOutSize. This prevents a possible buffer
overrun in accessing the timeout array.

https://github.sec.samsung.net/RS7-IOTIVITY/IoTivity/pull/279
(cherry picked from commit 22079af2bd0f22a80b98c3b17469c3b8ed601ede)

Change-Id: I6a16c6675236518c008a88c590264dedea698a3a
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
Signed-off-by: Amit KS <amit.s12@samsung.com>

Update Snapshot(2018-04-05)

Change-Id: Iff9df44b5097021dcecaa93ff6ec3fdd3d0a3cfe
Signed-off-by: Amit KS <amit.s12@samsung.com>

Unset gatt callback in network monitor

Gatt connection state changed callback is set in the
network monitor (calenwmonitor.c) but is unset in the
gatt client (caleclient.c). Move this to network
monitor instead

https://github.sec.samsung.net/RS7-IOTIVITY/IoTivity/pull/278
(cherry picked from commit 961ff08710e7acd99277a335f7d9eeca2f68c16e)

Change-Id: I9ee9da268d63fe0d379e4596c901552b10ceb0f1
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
Signed-off-by: Amit KS <amit.s12@samsung.com>

"have choice" error of libmbedtls.so

delete +%{_libdir}/libmbedtls.so from iotivity-devel

https://github.sec.samsung.net/RS7-IOTIVITY/IoTivity/pull/277
(cherry picked from commit 3cd231da7e03a322dd10fbfee0b15582647c191e)

Change-Id: I0833cd20927f4a3b5a62eb3c7835b78d89c2235a
Signed-off-by: Oleksiy Volkov <a.volkov@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>

Update Snapshot(2018-03-28)

Change-Id: If8b1d9096a336ab4cbdbbc996bf2b6a396adbecf
Signed-off-by: Amit KS <amit.s12@samsung.com>

Synchronized observe notification using mutex.

As InProcClientWrapper class creates separate thread for every
obseve callback, There is a chance that more than one thread enter
ObserveCache object and trying to modify m_attributes. More over
same m_attributes is being passed out or RE layer by const reference,
so application is using same member object m_attributes. Mutex allows
only one thread to modify m_attributes.

https://github.sec.samsung.net/RS7-IOTIVITY/IoTivity/pull/276
(cherry picked from commit c87d0d4b14d22349c3563e7cd316d323d068e2ab)

Change-Id: I54c80a6ea9751b8d9f78720121bee949d336ce4f
Signed-off-by: Harry <h.marappa@samsung.com>
Signed-off-by: Amit KS <amit.s12@samsung.com>

[CONPRO-1212] Removing invocation of lock_guard destructor.

std::lock_guard follows RAII for std::mutex. Invoking
std::lock_guard<std::mutex>::~lock_guard() makes unlock
call twice on underlying mutex. As per the API documentation
calling unlock from thread which does not own lock results in
undefined behaviour.

https://github.sec.samsung.net/RS7-IOTIVITY/IoTivity/pull/243
(cherry picked from commit fc681e089d3bbbbd16f90ad05d53208f9a1602d1)

Change-Id: Iaf21d318f5fa46daf2bcc17f0f07ffe9aa887b9d
Signed-off-by: Harry <h.marappa@samsung.com>
Signed-off-by: Amit KS <amit.s12@samsung.com>

Update Snapshot(2018-03-21)

Change-Id: Ia9b1148b62386f521c769a97e1d873cd34a04d0a
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>

[CONPRO-1251]Updated typo error

Changed interface declaration in ocobserve.h

Change-Id: I47a49d2371cf098084ac23b53ad48d32a0119ab4
Signed-off-by: Kush <kush.agrawal@samsung.com>

Update Snapshot(2018-03-07)

Change-Id: Icc2692241f81dd8d7aa06ba779e2270d1c6ab750
Signed-off-by: Amit <amit.s12@samsung.com>

Update Snapshot(2018-02-28)

Change-Id: Ie839b5c1dee0a1a559d04b20a40f549b48e8da6f
Signed-off-by: Amit <amit.s12@samsung.com>

Update snapshot(2018-02-21)

Change-Id: Iacc9ec43b82dce33ed378010a9eb19bd24fdd0ac
Signed-off-by: Amit <amit.s12@samsung.com>

Update snapshot(2018-02-14)

Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Change-Id: Ib7a9cb7e25ead6027b56011a9d8c3cc42c3fdb6d

Update snapshot(2018-02-07)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: If60dc7547c9e14e80d7fbdccc4a86be0ef7d082b

Update snapshot(2018-01-31)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: I2a12ea6904874b5158458d4882688709a0158575

Update snapshot(2018-01-24)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: Ib5c6f3801761bdf022ebf8a56291e104cc5e6e4d

Update snapshot(2018-01-17)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: I0d71eee704b1b6e88d483b6c2771e5cce6750886

Update snapshot(2018-01-10)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: I8e376f3660a9b36ae8ffcba30ca591293be6f913

[CONPRO-1181] Continue De-Initialize BLE even some BLE-API fails as per fw guidelines

 - manually patched from below pull request because of VD PVR schedule

 - [UPDATE] https://github.sec.samsung.net/RS7-IOTIVITY/IoTivity/pull/226

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: I88e508f7a1f2ce449e397cace30ea10128522d7d

[CONPRO-1181] Continue De-Initialize BLE even some BLE-API fails as per fw guidelines

 - manually patched from below pull request because of VD PVR schedule

 - https://github.sec.samsung.net/RS7-IOTIVITY/IoTivity/pull/226

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: Iab0a3e521043b5716495a332cf38b061acc9cd90

Update snapshot(2018-01-04)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: I4f4ee78d3bd2474fcbabc5a2abd41b9ea10b55d2

[CONPRO-1176] iotivity crash during CAReceiveMessage

 - manually patched from below pull request because of VD PVR schedule

 - https://github.sec.samsung.net/RS7-IOTIVITY/IoTivity/pull/215
Signed-off-by: kmook <kmook.choi@samsung.com>
Change-Id: I58811d5a50211aeaddf06c5cdab751a5ca31b8eb

[CONPRO-1172] allocates too much memory

 - rollback a patch to solve segmentation fault issue

 - https://github.sec.samsung.net/RS7-IOTIVITY/IoTivity/pull/206(rollback)

Change-Id: Ie822028ec2469e87d96bbf72a25b0019fb5e8b65
Signed-off-by: kmook <kmook.choi@samsung.com>

[CONPRO-1172] allocates too much memory

 - manually patched from below 2 pull requests because of VD PVR schedule
 - https://github.sec.samsung.net/RS7-IOTIVITY/IoTivity/pull/206
 - https://github.sec.samsung.net/RS7-IOTIVITY/IoTivity/pull/209

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: I71e81ee3c74c0a31623e5713352a44afd123a846

Update snapshot(2017-12-20)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: I04303750581f9349f4694ba903c8e2f6379c91d4

Update snapshot(2017-12-14)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: Iec053ef8f5cc87812aec9c884b1e811f85682de7

Update snapshot(2017-12-06)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: Idef59156a36f5d2e636a7487f140f8c236f5bf8d

Update snapshot(2017-11-29)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: Ife7d3cee9f401c54bcc48923e330fda7f78f064e

Update snapshot(2017-11-23)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: I1f1159259819400edca8bc384bbc8c883168abbf

Update snapshot(2017-11-14)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: Ic39e3e0fcc79a7cf38d00721cfe9fcfafce0b3c6

Update snapshot(2017-11-08)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: Icbbce23a651f542fe2bf3c98ba4eb3d6bb96274a

Update snapshot(2017-11-02)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: Ie9cb19fca33409447339e50e9c5f07e6f11aaf1a

Update snapshot(2017-10-25)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: Ib6b6b8772dd1e136c49393b0dafb8f721d6a42fc

Update snapshot(2017-10-11)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: I0682f26c3c6d0989210a8b7ddfac1485cc10671b

Update snapshot(2017-10-04)

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: If984cf1623bb9bd5dbb4d68920404e0513828f86

replace : iotivity -> iotivity-sec

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: I2832a4cf81d6a312442a5548fa4baa7a8959d7cc

Remove unused pkg dependancy

Change-Id: I310c2e37d0a94c3c9cf3191b8162abc873ceb316

delete wifi API and pkg config in tizen.

since IoTivity already use Tizen Connectivity Manager API instead of wifi API.
it should be removed in this and there.

Change-Id: I9a61d7d4d323fe83e988c792284179c099bc2855
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17079
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Conflicts:
resource/csdk/connectivity/build/tizen/scons/SConscript
resource/csdk/stack/samples/tizen/build/scons/SConscript

Change-Id: I401a44313a3a48fd7bfc5ca9c8519ec1186a8083

[IOT-1643] Fix illegal memory access - Don't return local string

the std::string ret  is a local varaible and is destroyed when the
what() member function returns.

Put the return string into the m_whatMessage variable. Since
'what()' member function is a const function it can not modify the
member variable m_whatMessage so it is generated in the
ResourceInitException constructor.

Issue found using static analysis tool.

Change-Id: I907b984f35dee59b2f300afe6a640b15a26f020f
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/15035
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>

Update spec file (in tools)

Change-Id: I3840a6b3b10070df30e66ca0de8852d0ea76264e

Update License

Change-Id: I47861f7f52f61ef1f5dbda201564f058560d3688

IOT-1877 : start presence issue

When called OCStartPresence() second, OCStartPresence() returns error.
Fixed presenceState variable to OC_PRESENCE_UNINITIALIZED.

Change-Id: I089c826f4105eb3aaf835a8feda4c10b848ebd5d
Signed-off-by: ChaJiWon <jw_wonny.cha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17623
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Way Vadhanasin <wayvad@microsoft.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
(cherry picked from commit 2f11e9592a7374ce28082a523b0c367a6d31baee)
Reviewed-on: https://gerrit.iotivity.org/gerrit/17775

Moved a requestId declaration in OCServerRequest

we should not add attributes after payload as they get overwritten
when payload content gets copied over.

Change-Id: I0c8a430f92c2196d3f9c816e9ba9d16fd44d88e4
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17015
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>

Fixed memory leak on OCSetDeviceInfo and CARetransmissionDestroy

Change-Id: Ic53ae0759020fa26f5f70425d3dab09ff5e7d375
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/17167
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: jaehyun Cho <jaehyun3.cho@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

fix the easy-setup mediator SConscript

Change-Id: If484c27c7336608326af35f3e0aebeac4e4a580a

Fixed double free issue when destroying endpoint

- after destroying memory, set NULL value to prevent double free
- add the usage of oc_mutex_lock() when block data is updated

Change-Id: I78d0d46e37333e099ec737ac4500a2f388d58c4e
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/15447
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

tizen: Enable CLOUD and ship ES lib (downstream)

Sync with upstream's spec

Change-Id: I84ce3dd94e1a90f13f0ff875221ca50600000001
Forwarded: https://gerrit.iotivity.org/gerrit/#/q/I84ce3dd94e1a90f13f0ff875221ca5061828618e
Origin: https://review.tizen.org/gerrit/112583
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

tizen: Enable CLOUD and ship ES lib

Change-Id: I84ce3dd94e1a90f13f0ff875221ca5061828618e
Forwarded: https://gerrit.iotivity.org/gerrit/#/q/I84ce3dd94e1a90f13f0ff875221ca5061828618e
Origin: https://review.tizen.org/gerrit/112583
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16965
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

tizen: Use mediator richsdk lib

Change-Id: Ib63db28697925b02349da82c5feabc1334a39ba2
Forwarded: https://gerrit.iotivity.org/gerrit/#/q/Ib63db28697925b02349da82c5feabc1334a39ba2
Origin: https://review.tizen.org/gerrit/112583
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16963
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

[4.0] Unification: Remove Profile Build Dependency & Prepare 4.0 Build

This is for Tizen 4.0.
 - Removed profile build dependency.
 - Prepare for Tizen 4.0 build.

a. Remove profile build dependency
 - This commit completely removes the build dependencies on Tizen profile.

b. Prepare for Tizen 4.0 build
 - We have assumed that Tizen 4.0 code is going to be more similar with 3.0
   than 2.0. Please do not rely on string '==' compare for version check.
   And, refer to the official macros that are defined in Project Config.
   https://build.tizen.org/project/prjconf?project=<project_name>

@To maintainer:
Please, keep a spec file syntax that was written at an official webpage.
https://docs.fedoraproject.org/ro/Fedora_Draft_Documentation/0.1/html/\
RPM_Guide/ch-specfile-syntax.html
First, if you want to use a comparison operator in %if, don't use
a double-quotes. Second, RPM macro does not support a floating-point
number for the comparison operator.

Change-Id: I8904a25e5e24f6e1bdbd460e434ad563695a3001
Signed-off-by: Geunsik Lim <geunsik.lim@samsung.com>

tizen: Use easy-setup mediator

Change-Id: I2b0681b70218613c0df0d82e0f46fdc61668296e
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

build: Install provisioning ESException.h

Add ESException.h to 'inc' folder and a list of install target headers

Change-Id: Ib0b7e7bbab9cf5d8f7cc0c69e223d966e4b055b0
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Origin: https://gerrit.iotivity.org/gerrit/#/c/16521/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

easy-setup: Rename header to EasySetup.hpp

Prevent potential name clash on case insensitive filesystems:

./service/easy-setup/mediator/richsdk/inc/EasySetup.h
./service/easy-setup/enrollee/inc/easysetup.h

Mediator one is C++ so we rename it to .hpp

Change-Id: I6d784378b5065b162d06abb2338bf70e0147d864
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16479
Reviewed-by: George Nash <george.nash@intel.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 98b92dae54a9244e1947937fcf7432ac38956659)
Origin: https://gerrit.iotivity.org/gerrit/#/c/16481/
pp

build: Ship provisionning headers

New headers should be installed if part of public API:

- OCProvisionningManager.hpp
- OCCloudProvisioning.hpp

Change-Id: I29a322f2dae9b0d978cdd05d4ca3ad71729d1923
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Origin: https://gerrit.iotivity.org/gerrit/#/c/16531/

fix the build error when appcliation build resource encapsulation

 - add the missing header file in installed target header

Change-Id: I71b65d6df422bd758e543118c2580ac770213399
Signed-off-by: JooseokPark <jooseok.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16461
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

revise the spec file for ES

 - tizen: avoid to duplicate headers
 - Rely on pkg-config instead.

Change-Id: I5944d59bb08d8aeeda617f0af5ba95ae9e76e9cc

tizen: avoid to duplicate headers

Rely on pkg-config instead.

Change-Id: Ieff754b33a21015a17fc9a8d107ee29f1376dfa1
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16449
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

build: Add ES NS paths to pkg-config

Public easy-setup and notification headers,
are copied in 2 level depths directory.

Change-Id: I7c9fd3a4bd1143c5ea05e7902292af23cf5e8934
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16447
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

build: Install easy-setup headers

It look like project public headers
 are installed to 2 level depth
 subdirectories (service/$domain/*.h*)

Change-Id: Ia7a66caf5381d24b56f0c5ac1a91929eff9ba7d7
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16445
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

build: Install notification headers

It look like project public headers
 are installed to 2 level depth
 subdirectories (service/$domain/*.h*)

Change-Id: I36ab613ff6aaf7d960e6ba1e94263f8cfdf7c559
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16443
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix the notification service SConscript

 - when application use the notification service, build error occurs.
 - i.e) /usr/include/service/notification/NSConsumerInterface.h:35:22: fatal error: NSCommon.h: No such file or directory
 - Although NSConsumerInterface.h includes NSCommon.h, NSCommon.h file is not installed in SConscript.
 - So, need to add NSCommon.h in installed header

Change-Id: I2f28f84504d68c5506c89513d74adcdf32d2bbfc
Signed-off-by: JooseokPark <jooseok.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/16427
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit e4eca38246a40013530b7df74c1b369960c88897)
Reviewed-on: https://gerrit.iotivity.org/gerrit/16459
Tested-by: Uze Choi <uzchoi@samsung.com>

merge tizen_3.0 to tizen branch

Change-Id: Ib7f30f0231385d4f6c2d2cee8ff430ad6ed6b6ac

tizen: Replace speedpython by python-accel

Tizen toolchain provide same functionality with python-accel's macro

Also Chan Lee from Tizen toolchain project reported:
{
Speedpython macro sometimes cause some build problem

Speedpython macro is parsed when spec parsing time
and it includes other macro in its own.
(I mean, %{build_hostarch} macro)

And when the OBS project config updates,
OBS sometimes cannot sync-up the changes perfectly.

It this case, build error occurs when we use speedpython macro.

It seems OBS limitation but,
we can avoid this problem by using other macro
which provides same functionality.
}

Change-Id: I265220b5e1f2dcb1956ef546a799a94eb460dd88
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

[Tizen]change flag which used for detect ip changed
change netlink interface flags to addr flags
which used for detect network IPv4/6 changed

Change-Id: I827db082879aafdc3e8bd688917180af09531ab2
Signed-off-by: bg.chun <bg.chun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/15595
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1671] Fixed base layer terminate logic

- ObserverList should be removed before destroying ResourceList
to avoid the error of dangling pointer. because ResourceObserver
object includes a resource handle which is memory address allocated
when resource is created.
- Add function to unset network monitoring callback when OCStop()
is called.

bug: https://jira.iotivity.org/browse/IOT-1671
Change-Id: I8a367a24a2100c97bf612db26bc41db5f47f2feb
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/15499
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

fix package install error

 - install error is caused by no manifest in the package (wrong path)
 - remove manifest redefinition

Change-Id: If5ef103231509addb50b5d62a59c27fc8692a2b4

tizen: use tag as base even if not in upstream branch

Change-Id: I53e451092168b9469090b888c12e53ee118a0395
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

tizen: Adapt to support other buildsystem

Some build system does not support .gbs.conf
so we rely on default packging folder

This change is use by other build systems (MCD auto-sync?)

Note, Any suggestion to align to gbs is welcome.

Change-Id: I59a9bc4d67a683dd22e7dbbb9aae67fb6ec5c570
Credit-to: Jooseok Park <jooseok.park@samsung.com>
Origin: https://review.tizen.org/gerrit/#/c/102824/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

tizen: relocate all liboc*.so to resource subpackage

iotivity.pc bring those libs so they should come along.
This was observed while porting Tizen's iotcon to iotivity-1.2.1

Change-Id: I82e7121520c1a7ed8d79e7b85089bec2b0b5012b
Origin: https://gerrit.iotivity.org/gerrit/#/c/15195/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

build: Fix to also support SECURED=0

Note, for later it would be nice to test booleans instead of strings.

Change-Id: I069d865c6e2cc6a80a812e60ab278af15b7eaa85
Origin: https://gerrit.iotivity.org/gerrit/#/c/15163/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

tizen: Ship more security headers if enabled

[youngman]
- Add header files related to security

[Philippe Coval]
- If built with security on, ships all headers or none
- To be used by iotcon
- Only ship them if usable (with security flag on)

Change-Id: I9c8edccddec5626119cb3adb39959437ab350413
Signed-off-by: youngman <yman.jung@samsung.com>
Credit-to: youngman <yman.jung@samsung.com>
Origin: https://gerrit.iotivity.org/gerrit/#/c/13047/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

tizen: Enable TCP

Change-Id: I56b8abcea1a3397f546ef0b8edc42711ff62b9d8
Origin: https://gerrit.iotivity.org/gerrit/#/c/15193/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

tizen: Enable SECURED

Change-Id: Id88b113bc256a51f97f5d1772df323d7bf244bd7
Origin: https://gerrit.iotivity.org/gerrit/#/c/14675/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

mbedtls: Apply OCF patch (20161125)

To provide TLS_ECDH_ANON_WITH_AES_128_CBC_SHA256 feature.

It is strongly recommended to rely on scons instead,
 if not possible, this change workaround this.

For more details about building IoTivity please check:

https://wiki.iotivity.org/build

Bug: https://jira.iotivity.org/browse/IOT-820
Bug-Tizen: https://bugs.tizen.org/jira/browse/TINF-861
Change-Id: I638ec0c0a45e855dcee711c8321039b7489d7e5a
Origin: https://gerrit.iotivity.org/gerrit/#/c/12429/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

mbedtls: Update to mbedtls-2.4.0

t is strongly recommended to rely on scons instead,
 if not possible, this change workaround this.

For more details about building IoTivity please check:
https://wiki.iotivity.org/build

Bug: https://jira.iotivity.org/browse/IOT-820
Bug-Tizen: https://bugs.tizen.org/jira/browse/TINF-861
Change-Id: I29c0d7c6b0d1bb50b82e9bcbeba38cfe1daa9857
Origin: https://gerrit.iotivity.org/gerrit/#/c/14677/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

mbedtls: Import mbedtls-2.3.0

It is strongly recommended to rely on scons instead,
 if not possible, this change workaround this.

For more details about building IoTivity please check:
https://wiki.iotivity.org/build

Bug: https://jira.iotivity.org/browse/IOT-820
Bug-Tizen: https://bugs.tizen.org/jira/browse/TINF-861
Change-Id: I97e8f34408dde1c95bd0587cb74834df966d2463
Origin: https://gerrit.iotivity.org/gerrit/#/c/12423/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

tinycbor: Update import to v0.4

git "module" was converted to patch this way:

  git clone https://github.com/01org/tinycbor.git -b v0.4 extlibs/tinycbor/tinycbor
  rm -rf extlibs/tinycbor/tinycbor/.git
  git add -f  extlibs/tinycbor/tinycbor/
  git commit -sm 'tinycbor: Update import to v0.4' extlibs/tinycbor/tinycbor/

It is strongly recommended to rely on scons instead,
 if not possible, this change workaround this.

For more details about building IoTivity please check:
 https://wiki.iotivity.org/build

Change-Id: I5492732be93e2b0fdf5e1c3eabcdc949b420e4fb
Bug: https://jira.iotivity.org/browse/IOT-820
Bug-Tizen: https://bugs.tizen.org/jira/browse/TINF-861
Origin: https://gerrit.iotivity.org/gerrit/#/c/14679/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

tinycbor: Update to v0.3.2

Needed for IoTivity 1.2.0 and later

It is strongly recommended to rely on scons instead,
 if not possible, this change workaround this.

For more details about building IoTivity please check:
https://wiki.iotivity.org/build

Bug: https://jira.iotivity.org/browse/IOT-820
Bug-Tizen: https://bugs.tizen.org/jira/browse/TINF-861
Change-Id: I9b33b8dd7a97b48b6fd3157b1ef25dadb79f11e2
Origin: https://gerrit.iotivity.org/gerrit/#/c/12705/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

tinycbor: Import v0.2.1

Needed for Iotivity-1.1.1 and lower

It is strongly recommended to rely on scons instead,
 if not possible, this change workaround this.

For more details about building IoTivity please check:
https://wiki.iotivity.org/build

Bug: https://jira.iotivity.org/browse/IOT-820
Bug-Tizen: https://bugs.tizen.org/jira/browse/TINF-861
Change-Id: I0a622b8c7c47cfc4ea7afd8a3cf82720a50618bd
Origin: https://gerrit.iotivity.org/gerrit/#/c/12703/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>

tizen: Remove deprecated libresource_hosting.so

To be squashed into:
https://gerrit.iotivity.org/gerrit/15003

Change-Id: I512cc51a9ad53929a57d30034cb70f1d153789ea
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/15029
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>

android: Fix resource_directory build issue

Adding resource_directory to notification like in master branch,
 then this lib will be found by Android.mk,
 while building on jenkins:

  gradle build -bservice/resource-container/android/build.gradle \
   -PTARGET_ARCH=armeabi -PRELEASE=debug --stacktrace

  Android NDK: ERROR:jni/Android.mk:android-rd: \
   LOCAL_SRC_FILES points to a missing file

  Android NDK: Check that ibresource_directory.so \
   exists  or that its path is correct

https://build.iotivity.org/ci/job/iotivity-verify-android/3761/console

To be squashed into:
https://gerrit.iotivity.org/gerrit/15031

Change-Id: I18af0742fc4e76eda33bd89f721b8fef59f6f490
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/15039
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[IOT-1627][Android]resolve ipadapter memory leak issue

On android ipadapter there is memory leak issue
since the function which used for free pointer
of structure does not free all pointer member

Change-Id: If44dd9dc7562f851fa3f38526830aa84e4b35491
Signed-off-by: bg.chun <bg.chun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14995
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Add links and rep in the response for the collection

- Use common ExtractParamFromQuery in ocresource and occollection to extract query parameters.
- Added links tag to the oic.if.ll and oic.if.baseline.
- Added rts tag in the payload for the baseline. - Added rep tag for oic.if.b response.
- occollection was using extra structure to differentiate ll, baseline, batch and group. Simplified the code to use
a simpler code and removed unwanted structure.
- oic.wk.col added in the types.
- OCStackIfTypes is removed as it was used only internally. This is not needed due to usage of ExtractParamFromQuery.
- BuildResponseRepresentation is updated as it is used in collection. For inner payload, these
values were not being used by ocpayloadconvert.
- oic.if.ll has been updated to give response in form of {links:[{href:"", rt:[""], if:[""]}]}
- oic.if.baseline has been updated to give response in form of {rt:[], if:[], rts:[], links:[{href:"", rt:[""], if:[""]}]}
- oic.if.b has been to response in form of [{"href": "", "rep": {""}}]
- in case of wrong query it will respond with error message.

Change-Id: I98489ac9923ab3c63012ddfe6b55c2b3064c3f28
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14621
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Fix Android SetPropertyValue function call

setPropertyValue call in the Android was swapped, compared to function call how it  was in the JNI layer.
setPropertyValue0 is for passing string array and setPropertyValue1 is passing string.

Change-Id: I91c480f162cc53712a68bef078371559fd2eff21
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/15025
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

android: Fix resource_directory build issue

jni/../../../../out/android/armeabi/debug/libresource_directory.so exists  or that its path is correct

In https://gerrit.iotivity.org/gerrit/#/c/14731, resource_directory was added in the resource-container. It is not
needed and break android build.

Change-Id: I05a1b422f6561102c641cc50cd68baa58768b11a
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/15031
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

tizen: resource-encapsulation prevent to import tools.scons.RunTest

As unit tests are not enabled on tizen, there is no need to import it.

A smarter way would be to follow other tests patterns
 and have them separated and included in supported platforms.

Bug: https://jira.iotivity.org/browse/IOT-1486
Change-Id: I2a925a251480c35d90bab6b2661c4da60f959b6f
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/15027
Reviewed-by: Uze Choi <uzchoi@samsung.com>

service: [IOT-1562] Fix for unittest with SECURED at RE/RC

When IoTivity was built with SECURED and TEST,
some of test case at RE and RC occurring crash.
because RE and RC has not set the precondition of security.

In this patch, added the security flow and persistence storage files at RE.
related security test case is disabled at RC.

Change-Id: I4094bd01cba84d395c408a56f4c57d4ebcb45b44
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Bug: https://jira.iotivity.org/browse/IOT-1562
Reviewed-on: https://gerrit.iotivity.org/gerrit/14837
Tested-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>

connectivity: Enable resource/csdk/connectivity test

Bug: https://jira.iotivity.org/browse/IOT-1486
Change-Id: I6b47f7b3439b923ec12f26b0e159e3b7a1144658
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12721
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Remove resource-hosting service which is deprecated.

Current resource-hosting service is deprecated because
concept of resource proxy can cover with functionality of cloud or relay server.
And this service would not handled for previous releases.
So this service can't cover for recent basic protocols.
If needs is arised for this concept, will be develop on the new service.

Change-Id: Ie14482924b7ccbebbd2512f017ad4b6039d72dd2
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/15003
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Correct callback function for security provisioning in easy setup

Change-Id: Id7d1deb6371d49e4810c191bc52979693ce16e8d
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/15013
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Fix defects detected by static analysis

Change-Id: I9eba31f8f716f8d3b5b04b803bc4c9ecdf035e10
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/15009
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Handle Error during Ownership Transfer

If an error is returned during ownership transfer,
on-boarding tool needs to remove the server's information from PDM DB
and close secure connection with the server.

Patch #1: Initial patch
Patch #2: Change Log Level

Change-Id: I641529552de0e25438bd94da9b2ec45320428a61
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14999
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

build: Bypass and/or fix suspicious tests (workaround)

- Run tests using tools.scons.RunTest
- Add a file parameter to enable valgrind check
- Disable failed test, to make verifier sane again

To be tracked at:
http://wiki.iotivity.org/1.2-rel

Bug: https://jira.iotivity.org/browse/IOT-1486
Change-Id: Ib665de6ab2dfe31b06ab3bb8cb3fb22f27487f4e
Origin: https://gerrit.iotivity.org/gerrit/#/c/14967/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14967
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

build: Bypass non finishing security test (workaround)

Occured when SECURED=1

This change is temporary to make QA verifier sane again,
 with this change:
https://gerrit.iotivity.org/gerrit/#/c/14903/

If merged I will raise bugs for each bypassed testcase related to
https://gerrit.iotivity.org/gerrit/#/q/topic:IOT-1486

Bug: https://jira.iotivity.org/browse/IOT-1486
Origin: https://gerrit.iotivity.org/gerrit/#/c/14925/
Change-Id: I574f92375703bf8a82cad7be6948d46c10776360
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14925
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>

Removed href from device and platform payload

- Created a separate function to handle Device and Platform payload.
- rt, if and attribute information are the only included in the payload.
- BuildResponseRepresentation updated to avoid information about device and platform payload.
- Updated dmv value from res.1.1.0,sh.1.2.0 to res.1.1.0,sh.1.1.0.

Change-Id: I59059997f170d177663e87eddea9df32275ca882
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14979
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

build: Enable unit testing in SECURED=1 mode for resource

Bug: https://jira.iotivity.org/browse/IOT-1486
Change-Id: I38e593d49401f7e14bfa26dd980938d36e66ac68
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14903
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Nivedita Singhvi <niveditasinghvi@gmail.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>