Albert Malewski [Thu, 29 Oct 2015 12:10:01 +0000 (13:10 +0100)]
Fixed closing incognito tab
[Issue] https://bugs.tizen.org/jira/browse/TT-239
[Problem] Browser crashes when tries to close incognito tab.
[Cause] Ewk_Context API was used incorrectly.
[Solution] Moved creation of m_ewkContext from contructor to init().
[Verify] Open Incognito Tab > Tab Manager > Close Incognito Tab.
Change-Id: I117939d1f69a1f9a71a13ae3b2dea9b83a70e0e8
Adam Skobodzinski [Thu, 29 Oct 2015 09:30:07 +0000 (10:30 +0100)]
WebPageUI class refactoring. Adding states manager.
[Issue] n/a
[Problem] States of WebPageUI were indicated based on the scattered
variables or a content of the web_view edc part.
[Solution] Introducting WebPageUIStatesManager which clearly indicates
state of WebPageUI.
[Verify] Functionality related to removed variables and methods,
should not change.
Change-Id: I4722958c5507a34867aa5bced8a22fb9fda1ba1e
Signed-off-by: Adam Skobodzinski <a.skobodzins@partner.samsung.com>
Janusz Majnert [Thu, 29 Oct 2015 11:04:38 +0000 (12:04 +0100)]
Adding -Werror compilation flag
[Issue#] N/A
[Problem] Compilation warnings being ignored by developers
[Cause] Too much compiler output
[Solution] Adding a -Werror compilation flag so that warnings are treated as
errors
[Verify] Check that the project builds without warnings
Compilation warnings should not be ignored. They often warn about things that
may cause trouble if unattended. Too much warnings also pollutes the compiler
output making it illegible.
Adding this compilation flag will allow us to maintain the quality of our code.
Note: This commit also fixes one warning in WebKitEngineService.cpp
(initialization list reordering).
Change-Id: If30512b534268d5857ec08e47935bd5e19eef980
Maciej Skrzypkowski [Wed, 28 Oct 2015 10:37:36 +0000 (11:37 +0100)]
Mobile version of WebPageUI and QuickAccess
[Issue] https://bugs.tizen.org/jira/browse/TM-34
[Problem] There was a lack of mobile edc version.
[Solution] Added edc files with "_mob" extention for mobile profile.
[Verification] Build project for TV and for mobile, check if there is no
regresion for TV, check if there is QuickAcces view for mobile.
Change-Id: If790494ccbd12f405a86a807515e2f6560476496
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Adam Skobodzinski [Tue, 27 Oct 2015 12:54:26 +0000 (13:54 +0100)]
UrlHistoryList: adjusting width and x offset to the views.
[Issue] https://bugs.tizen.org/jira/browse/TT-161
[Problem] UrlHistoryList had fixed width and x offset,
[Solution] Depending on which view is active, list has a different
width and x offset.
[Verify] List should be properly positioned in a QuickAccess view and
a WebPage view.
Change-Id: Id6ae2858238639e38f228316316177983fc76a14
Signed-off-by: Adam Skobodzinski <a.skobodzins@partner.samsung.com>
Adam Skobodzinski [Tue, 27 Oct 2015 12:16:36 +0000 (13:16 +0100)]
UrlHistoryList: adjusting height to the items number.
[Issue] https://bugs.tizen.org/jira/browse/TT-161
[Problem] When displayed small number of items in a list, fragment of
list widget was stopping cursor focus events.
[Cause] Widget size was bigger then sum of items height for small
amount of items.
[Solution] Resizing list depending on the number of added items.
[Verify] Area under list should not block cursor focus events. E.g. in
QuickAcces 'Most visited' button should be cursor-focusable for one
item on a UrlHistoryList.
Change-Id: Ie9a0898e78cd42de8df2b97ca88321ed0361ac99
Signed-off-by: Adam Skobodzinski <a.skobodzins@partner.samsung.com>
posial [Fri, 23 Oct 2015 13:44:57 +0000 (15:44 +0200)]
Prepare running unit tests
[Issue] https://bugs.tizen.org/jira/browse/TT-166
[Problem] When running unit tests segfault occurs and could not start browser
[Solution] Remove unneeded files and disable corrupted test.
[Verification] Build and run unit tests. Note that still there are some failing cases.
Change-Id: If89a56e79015a29418974d6da012824245ec892c
Kamil Nowac [Thu, 22 Oct 2015 09:45:59 +0000 (11:45 +0200)]
Update incognito mode ewk API
[Issue] https://bugs.tizen.org/jira/browse/TT-230
[Problem] Using deprecated function
[Solution] Added new function and reorganization of
of current incognito mode solution
[Verification]
1. Open page in incognito mode
2. Type URL that do not exist it the history
3. Type enter
New URL shouldn't be inserted into history.
4. Close browser with ctrl+c
5. Open browser again
Browser should open without the tab last opened
in incognito mode.
Change-Id: Ia4548e628b30d57e58f9aeee3c4563e39705ab27
Dariusz Frankiewicz [Wed, 21 Oct 2015 08:15:59 +0000 (10:15 +0200)]
Fix D-pad navigation between URI bar and Webview.
[Issue] https://bugs.tizen.org/jira/browse/TT-211
[Problem] Navigation on webview elements is not possible because
focus go to URI bar when UP is pressed.
[Cause] No webview focus lock implemented.
[Solution] Implement focus auto lock on webview.
[Verify] Load sample page, go by D-pad to webview, navigate on webview
elements, to back to URI bar press RED button [F4 on keyboard].
Change-Id: Ia24378ac090364e43b85fba89f5fd3a42f48cc26
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
Albert Malewski [Tue, 27 Oct 2015 12:13:10 +0000 (13:13 +0100)]
Cannot cancel edit mode in Tab Manager
[Issue] https://bugs.tizen.org/jira/browse/TT-215
[Problem] Cannot cancel edit mode in Tab Manager.
[Cause] N/A
[Solution] Added onBackKey function that is called when "Back" key.:
is pressed. This function switches off edit Mode.
[Verify] Add few tabs > Click 'Close Tabs' > Press 'Back' key > Obs
Change-Id: I83b093616e00772ba7c51c9385ccefd2cc908be6
Adam Skobodzinski [Tue, 27 Oct 2015 08:08:14 +0000 (09:08 +0100)]
Displaying UrlHistoryList refactoring (moving class, focus chain).
[Issue] https://bugs.tizen.org/jira/browse/TT-161
[Problem] UrlHistoryList was not included in focus chain and was not
always visible in a WebPage view.
[Solution] UrlHistoryList is moved to WebPageUI. UrlHistoryList is
added to focus chain in 'WebPageUI::refreshFocusChain'. Inserting
focused item's content to uri entry.
[Verify] Displayed UrlHistoryList (QuickAccess view and WebPage view)
should be included in focus chain. Focusing out from list and from
UriEntry should cause list's scroll out. Focusing on item should
change uri entry content.
What is not solved yet: 1) list's width is not adapting to QuickAccess
url width. 2) 'web_view' content in WebPage view is sometimes
colliding with list's focus chain 3) If list is displaying small
number of elements, it's partially covering web page view (blocks
cursor focus events).
Change-Id: Iab263e4e0421adab9e61ac6a6a16f926ace66f67
Signed-off-by: Adam Skobodzinski <a.skobodzins@partner.samsung.com>
m.kawonczyk [Mon, 26 Oct 2015 14:22:22 +0000 (15:22 +0100)]
URL bar shows wrong text
[Issue] https://bugs.tizen.org/jira/browse/TT-234
[Problem] URL bar shows wrong title
[Solution] URL bar had correct url, however showPageTitle()
was not called. Called this function in showUI.
[Verification] 1) Open website in a tab
2) Type url in bar with other website address and
click enter
3) Click on more menu or tabs button
4) Click on close button
5) Do not change focus to observe problem
Check if title shown in URL bar is correct
Change-Id: I569a50973b9bda3d934ff25617b85427581a55c4
m.kawonczyk [Mon, 26 Oct 2015 13:23:25 +0000 (14:23 +0100)]
Disappearing navigation buttons
[Issue] https://bugs.tizen.org/jira/browse/TT-233
[Problem] Navigation buttons are missing
[Solution] Calling efl program responsible of shrinking url bar.
[Verification] 1) Load some webpage
2) Go to tab manager and open new blank page
3) From blank page go to tab manager and switch to
previously loaded page
Check if navigation buttons are present.
Change-Id: If23ac877548465210fcc71fc64d19bd72be6a394
Albert Malewski [Mon, 26 Oct 2015 11:32:56 +0000 (12:32 +0100)]
Hiding UI using "Back" key.
[Issue] https://bugs.tizen.org/jira/browse/TT-226
[Problem] UIs are not hidden when "Back" key is pressed.
[Cause] ViewManager's method popTheStack() is not called.
[Solution] Calling popTheStack method in inBackButton function.
[Verify] Use "Backspace" key to close UIs.
Change-Id: I4e1d279b8dc7e1fea071d0ab294795b9e05496f6
m.kawonczyk [Fri, 23 Oct 2015 11:34:56 +0000 (13:34 +0200)]
Browser - Sometimes Reload button does not work after clicking
Stop button
[Issue] https://bugs.tizen.org/jira/browse/TT-173
[Problem] Sometimes Reload button does not work after clicking
Stop button
[Solution] Stop button created loadFinished signal, to solve this
loadStopped was created. In addition, engine was still
sending __loadProgress signal, which I blocked after
Stop button was clicked. As you can not get title and
snapshot from unloaded page, it was exchanged by blank
image and url for view and for history manager.
[Verification] Open new page and stop load. Page should not load any
additional content. Reload and enter button on url
should force webview to refresh.
Change-Id: I5bdab33254ff8dd0ef5302443b21fd23ed82f661
Albert Malewski [Mon, 26 Oct 2015 09:35:59 +0000 (10:35 +0100)]
Fixed showing ZoomUI after closing History and Bookmark Manager
[Issue] N/A
[Problem] ZoomUI is shown on MoreMenuUI after closing History and Bookmark
Manager.
[Cause] showNavigation functions is called on 'close' button click
[Solution] Removing calling showNavigation
[Verify] Launch browser > Open web page > More Menu > Screen zoom
> set big factor of zoom (so you can see arrows) > open
History or Bookmark Manager > Obs
ZoomUI should not be shown when you are in MoreMenu.
Change-Id: I7aca3cb0e3e558944e0e1cc81fde64bf249c3067
Albert Malewski [Thu, 22 Oct 2015 12:28:05 +0000 (14:28 +0200)]
Exiting from Screen zoom by pressing "Escape" or "Backspace" key.
[Issue] https://bugs.tizen.org/jira/browse/TT-225
[Problem] User cannot exit the screen zoom.
[Cause] Screen zoom is not in ViewManager stack, so it can't be supported
by onBackPressed callback.
[Solution] Added boost signal in PlatformInputManager on "Escape"
and "Backspace" keys.
[Verify] Launch browser > Open web page > More Menu > Screen zoom
Zoom up/down the page. Then press "escape" -> Screen zoom should
disappear and the page should return to normal scale.
Change-Id: Ica7a37a9fe15f3bb27bf4f54dce53238b90cb7b5
Kamil Nowac [Wed, 21 Oct 2015 07:20:31 +0000 (09:20 +0200)]
Incognito Mode Add Tab button should open a new tab
[Issue] https://bugs.tizen.org/jira/browse/TT-221
[Problem] Incognito mode Add Tab button doesn't create new tab
[Solution] IncognitoMode always opens a new tab.
[Verification]
1) Open Tab Manager
2) Add Incognito Tab
3) Type url address and press Enter
2 -> New tab should be opened.
3 -> site should be opened in the current tab.
1) Open Tab Manager
2) Add Incognito Tab
3) Press BookmarkManager and click bookmark
3-> site should be opened in the current tab.
Change-Id: I7e2d98bbba1a2d5bc09afe8b4a4f5d055c2724c2
sungwon2han [Thu, 22 Oct 2015 06:33:44 +0000 (15:33 +0900)]
Remove tab ID checker
Tab ID checker is called after URI is changed.
If a tab with URI chanage is not the current tab,
it changes the current tab to a tab with URI change.
This may cause unwanted tab switching
when some backgound tabs change its URI for some reason.
Change-Id: I6e8583f0952dc961a5a4d148c9e79bb25d536ac1
Signed-off-by: sungwon2han <sungwon2.han@samsung.com>
Janusz Majnert [Wed, 21 Oct 2015 08:35:54 +0000 (10:35 +0200)]
Fix compiler warning in HistoryUI
[Issue] N/A
[Problem] Compilation warning about unused variables and no return statement
[Solution] Remove unused variables, change method return type
[Verification] Build the project and verify that there are no warnings from
HistoryUI
Also changed one reinterpret_cast into a static_cast.
Change-Id: I83fe252409475ef0918978d1d30560f6ab4f85a7
Janusz Majnert [Wed, 21 Oct 2015 07:48:41 +0000 (09:48 +0200)]
Fix for compilation warnings in HistoryService
[Issue] N/A
[Problem] Compilation warnings: Wreorder and Wsign-compare
[Solution] Fix initialization list ordering, fix method signature and cast
values where appropriate
[Verification] Build the project and verify that there are no warnings from
HistoryService files
Change-Id: I6ca4a185dc616e9c9290ba6e6a5f041467df960b
Janusz Majnert [Wed, 21 Oct 2015 09:36:09 +0000 (11:36 +0200)]
Fix compiler warning in SessionStorage
[Issue] N/A
[Problem] Compilation warning about initialization list ordering
[Solution] Fix ordering
[Verification] Build the project and verify that there are no warnings from
SessionStorage
Change-Id: I0d0f080ecdbbc9c2a492596358f87ce715d289ae
Janusz Majnert [Wed, 21 Oct 2015 09:48:38 +0000 (11:48 +0200)]
Fix compiler warning in QuickAccess
[Issue] N/A
[Problem] Compilation warnings:
* initialization list ordering in QuickAccess.cpp
* use of uninitialized variables in GenListManager.cpp
* unused variable in UrlHistoryList.cpp
[Solution] Fix ordering, initialize variables with nullptr and remove unused
variables
[Verification] Build the project and verify that there are no warnings from
QuickAccess
Change-Id: Ibe7a1363366f7e32b12c713276ce03015cb264bc
Janusz Majnert [Wed, 21 Oct 2015 10:06:49 +0000 (12:06 +0200)]
Fix compiler warning in SettingsUI.cpp
[Issue] N/A
[Problem] Warnings: unused variables and initialization list ordering
[Solution] Remove unused variables and fix ordering
[Verification] Build the project and verify that there are no warnings from
SettingsUI.cpp
Change-Id: I6cef34f2a0b90617a82db12f737e86782f3195a5
Janusz Majnert [Wed, 21 Oct 2015 10:29:04 +0000 (12:29 +0200)]
Fix compiler warnings in SimpleUI
[Issue] N/A
[Problem] Warnings: unused variables and wrong order in initilization lists
[Solution] Remove unneeded variables, fix ordering
[Verification] Build the project and verify that there are no warnings from
SimpleUI
Change-Id: Ice75645214823cfb450c9bf7a6db234f0291eb88
Janusz Majnert [Wed, 21 Oct 2015 11:28:45 +0000 (13:28 +0200)]
Fix compiler warning in WebPageUI.cpp
[Issue] N/A
[Problem] Compilation warning about wrong ordering in initialization list
[Solution] Fix ordering
[Verification] Build the project and verify that there are no warnings from
WebPageUI.cpp
Change-Id: I1f4ae2dc629f1ab7b629c2dfee0fee1aa6c2778e
Janusz Majnert [Wed, 21 Oct 2015 12:14:55 +0000 (14:14 +0200)]
Fix compiler warning in ZoomUI.cpp
[Issue] N/A
[Problem] Warnings: unused variables and no return statements
[Solution] Remove unneeded variables, refactor method to always return a
value
[Verification] Build the project and verify that there are no warnings from
ZoomUI.cpp
Change-Id: Ia85163bb5d45887c074508a48c05b1d2fc10b40c
Janusz Majnert [Wed, 21 Oct 2015 13:32:15 +0000 (15:32 +0200)]
Fixed several compilation warnings in WebView.cpp
[Issue] N/A
[Problem] Warnings: unused variables, wrong ordering in initialization list
[Solution] Removed unneeded variables, fixed ordering, submitted a bug for
some missing functionality
[Verification] Build the project and verify that there are no warnings generated
for WebView.cpp
Change-Id: I88b795a9209d96c35b3edc579f212f51dd386e09
Kamil Nowac [Wed, 21 Oct 2015 11:01:27 +0000 (13:01 +0200)]
Fix updateSessionName in SQLStorage
[Issue] https://bugs.tizen.org/jira/browse/TT-218
[Problem] Function does not update name
[Solution] Changed usage of parameter
[Verification] Currently not used so
it must be tested directly from the code.
Change-Id: I16576b3abca48eabc5fab8c8077afacd0c531f47
m.kawonczyk [Tue, 20 Oct 2015 12:57:09 +0000 (14:57 +0200)]
Close Tabs button in Tab Manager
[Issue] https://bugs.tizen.org/jira/browse/TT-219
[Problem] "Close Tabs" button in Tab Manager does not return to
"Close Tabs" from "Close all"
[Solution] Found that signals created in TabUI arent called, while
signals from SimpleUI are. Copied code that is responsible
for text change to right location.
[Verification] Open tabs manager. Click "Close Tabs" button. Either
close a tab, click "Close All" or exit from Tab
Manager. Reopen Tab Manager.
Change-Id: Iba4ab9aa916cf39a6d3e919a7215c5c265e597aa
Albert Malewski [Tue, 20 Oct 2015 12:06:28 +0000 (14:06 +0200)]
Navigation in Screen Zoom
[Issue] https://bugs.tizen.org/jira/browse/TT-213
[Problem] User cannot control screen zoom by D-Pad navigation.
[Cause] Lack of implementation.
[Solution] Refactored screen zoom. Added focus on slider.
[Verify] Launch browser > Open web page > More Menu > Screen zoom
Select zoom ratio by left/right arrows > Press OK (enter)
to confirm.
Change-Id: I4b8bed8bf9f00e76140d9ee020d8d9838e38cbcd
Dariusz Frankiewicz [Tue, 13 Oct 2015 10:16:10 +0000 (12:16 +0200)]
Add webview suspend and resume functions.
[Issue] https://bugs.tizen.org/jira/browse/TT-208
[Problem] ewk_view_suspend and ewk_view_resume are not called in
required moments.
[Cause] Not implemented function calls.
[Solution] Implement required functions and it's calls.
[Verify] Open few tabs, try to switch between them.
Suspend and resume browser.
Change-Id: I9f292a0c316056e3d2c928332bd47a58e9eba23a
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
Maciej Skrzypkowski [Tue, 20 Oct 2015 08:56:32 +0000 (10:56 +0200)]
Mobile profile build
[Issue] https://bugs.tizen.org/jira/browse/TM-34
[Problem] There was no build for mobile profile.
[Solution] Added new profile and build option
[Verify] Run build_mobile.sh script, check if it works.
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Change-Id: Ic3057435427df0d8e4bc90e769b8e2ab78de1e46
Janusz Majnert [Tue, 20 Oct 2015 13:32:22 +0000 (15:32 +0200)]
Fix compiler warning in MoreMenuUI
[Issue] N/A
[Problem] Compilation warning about unused variable
[Solution] Use the defined variable
[Verification] Build the project and verify that there are no warnings from
MoreMenuUI.cpp
Change-Id: I35891dd6c18e64bcd4b0003d4ac47fe25e641eb7
Janusz Majnert [Mon, 19 Oct 2015 14:07:21 +0000 (16:07 +0200)]
Fix for unused variable copilation warning in BookmarkService
[Issue] N/A
[Problem] Compilation warning about unused variable
[Solution] Remove the unneeded variable
[Verification] Build the project and verify that there are no warnings from
BookmarkService.cpp
Change-Id: Id663552f0be06ce1c009c51864e9f06e23a485a5
Janusz Majnert [Mon, 19 Oct 2015 14:04:50 +0000 (16:04 +0200)]
Fix an unused variable compilation warning in BookmarkManagerUI
[Issue] N/A
[Problem] Compilation warning about unused variable
[Solution] Remove the unused variable declaration
[Verification] Build the project and verify that there are no warnings from
BookmarkManagerUI.cpp
Change-Id: I1093b838cbe8afcea424abe404d96cb65cd95402
Janusz Majnert [Mon, 19 Oct 2015 10:50:45 +0000 (12:50 +0200)]
Fix compiler warning in FocusManager.cpp
[Issue] N/A
[Problem] Compilation warnings about unused variable
[Solution] Remove unneeded variable
[Verification] Build the project and verify that there are no warnings from
FocusManager.cpp
Change-Id: Iefda280361a6ff12dbe40179d1bfe67a39aab533
Janusz Majnert [Mon, 19 Oct 2015 10:20:18 +0000 (12:20 +0200)]
Fixed compilation warnings in SqlStorage modules
[Issue] N/A
[Problem] Compilation warnings about:
1. Unused variable newName
2. Ignored type qualifier
[Solution] 1. Suppress the warning temporarily, submit a bug to fix the method
2. Remove the redundant const qualifier
[Verification] Build the project. Check if there are warnings generated from
SqlStorage.* files
Change-Id: I6a94a92faffa37047fd93498dfc207cc42be78bb
Janusz Majnert [Tue, 20 Oct 2015 13:34:45 +0000 (15:34 +0200)]
Fix compiler warning in PlatformInputManager
[Issue] N/A
[Problem] Compilation warning about unused variable
[Solution] Suppress the warning
[Verification] Build the project and verify that there are no warnings from
PlatformInputManager.cpp
Change-Id: I0d8e9d669785cd220c28ea14d8e0d8d8f5c57d9f
posial [Tue, 20 Oct 2015 13:28:08 +0000 (15:28 +0200)]
Set-up unit test infrastructure
[Issue] https://bugs.tizen.org/jira/browse/TT-166
[Problem] Outdated unit tests caused build errors
[Solution] Update unit tests to current browser structure
[Verification] Build browser unit tests
Change-Id: I0d65b28b47c7b0e44153ffed6d143b2e5de2aeb0
Adam Skobodzinski [Tue, 20 Oct 2015 08:50:07 +0000 (10:50 +0200)]
Using UrlHistoryList do display history list (on urientry edition).
[Issue] https://bugs.tizen.org/jira/browse/TT-161
[Problem] 'Display URL from browser history that matches to given keyword.'
[Solution] UrlHistoryList is receiving list of matched entries and
creates a genlist. List is hidden, when list item is selected (with
cursor only for now) or focus changes from the uri entry. Created
genlist is not added to a focus chain yet (this will be delivered
soon).
[Verify] Typing words in uri entry should display list with matched
entries. Choosing item shoud load page in a new tab. Loading page or
focusing out from urientry should hide the list.
Signed-off-by: Adam Skobodzinski <a.skobodzins@partner.samsung.com>
Change-Id: Icb67a9b5c47556788d256613c832cdacb7620bf3
posial [Tue, 20 Oct 2015 10:31:16 +0000 (12:31 +0200)]
Cannot link boost libraries when building unit tests
[issue] https://bugs.tizen.org/jira/browse/TT-166
[problem] Cannot link boost libraries when building unit tests
[solution] Remove cmake variables names shadowing
[verification] build browser
Change-Id: I79e4619860ad1234d36e96240279c311086eb55d
Kamil Nowac [Thu, 15 Oct 2015 11:03:20 +0000 (13:03 +0200)]
Add incognito screen and icon to the url bar
[Issue] https://bugs.tizen.org/jira/browse/TT-185
[Problem] Incognito screen and icons are not implemented
[Solution] Added screen and icons
[Verification]
1. Open incognito tab
Incognito start screen and incognito icon should be
visible in the url bar
Change-Id: I18cf592433ebedd5e6a85b1b5d7809f1e4802562
sungwon2han [Tue, 20 Oct 2015 06:01:09 +0000 (15:01 +0900)]
Add "XF86Back" key name to process back key event from remote controller.
Change-Id: I65ffa278a3a903ca42e192f3a99c7a5ae0842fe2
Signed-off-by: sungwon2han <sungwon2.han@samsung.com>
m.kawonczyk [Mon, 12 Oct 2015 13:11:53 +0000 (15:11 +0200)]
Limit number of opened tabs in brower
[Issue] https://bugs.tizen.org/jira/browse/TT-174
[Problem] When more than 30 tabs are opened the browser crashes.
[Solution] Limit the number of simultaneously opened tabs to 10.
If user wants to add another tab, popup is shown.
WebCore Part must check, if sending out=NULL in __newWindowRequest doesn't create
another bug.
[Verification] Please open 10 tabs and try to add another one, with either + in tab manager
or "Open link in new tab" in popup.
Change-Id: I342fe4dda10e6ae11e2199893ce3a8412c01227e
m.kawonczyk [Mon, 19 Oct 2015 10:14:31 +0000 (12:14 +0200)]
Focus cannot be moved to "Stop" button in Web Page UI
[Issue] https://bugs.tizen.org/jira/browse/TT-217
[Problem] After clicking Thumb in history new DetailedPopup is shown,
which then forces "refreshFocusChain" function second time.
[Solution] Added another variable - m_after_history_thumb, which blocks
"refreshFocusChain" from running second time.
[Verification] Add new tab from History Manager, try to change focus to
"Stop" using arrows.
Change-Id: I0f4a241ac85f72acb213f92ab303bf347d247d39
Adam Skobodzinski [Wed, 14 Oct 2015 09:49:17 +0000 (11:49 +0200)]
Adding UrlHistoryList class and other classes managing display of 'URL from history'
[Issue] https://bugs.tizen.org/jira/browse/TT-161
[Problem] 'Display URL from browser history that matches to given keyword.'
[Solution] Adding necessary class and .edc files. Usage implemention in other commit.
Signed-off-by: Adam Skobodzinski <a.skobodzins@partner.samsung.com>
Change-Id: I35c8b86409e024e107498a552623840553fb3735
Adam Skobodzinski [Wed, 14 Oct 2015 08:55:08 +0000 (10:55 +0200)]
Adding HistoryService::getHistoryItemsByKeywordsString().
[Issue] https://bugs.tizen.org/jira/browse/TT-161
[Problem] "Url from history" needed new method in HistoryService getting urls basing on a keywords string.
[Solution] New method in HistoryService.
Signed-off-by: Adam Skobodzinski <a.skobodzins@partner.samsung.com>
Change-Id: I0d2ed414eb6af2b7cb61a14dfb9f7024e55a6729
posial [Tue, 13 Oct 2015 14:55:55 +0000 (16:55 +0200)]
Change Url bar guide text
[Issue] https://bugs.tizen.org/jira/browse/TT-216
[Problem] Outdated URL bar guide text
[Solution] URL bar guide text changed in accordance with new guidline specification
[Verify]
1. Focus on empty URL bar
2. Write some text
3. Clear text
4. Change focus
Change-Id: I4365b332e4ce7d3cec554366d3d34fa84ecfd7e4
Albert Malewski [Mon, 12 Oct 2015 08:26:52 +0000 (10:26 +0200)]
Setting page title in the URI entry.
[Issue] https://bugs.tizen.org/jira/browse/TT-193
[Problem] After page is loaded URL full URL address is displayed
instead of the name of the page.
[Cause] N/A
[Solution] Added setPageTitle function and connected it to titleChanged
signal. Added showing URI when entry is focused and page title
when unfocused. Additionally removed unneded _cb_mouse_in
and _cb_mouse_out callbacks.
[Verify] Launch browser > Enter an URL address > Obs
Only page name should be visible.
Change-Id: Icd9da0fc2dbffb1779be895130d36391dd04835d
Dariusz Frankiewicz [Thu, 8 Oct 2015 06:58:22 +0000 (08:58 +0200)]
Notification Popup implementation
[Issue] N/A
[Problem] Lack of notification popup in settings.
[Solution] Implement missing functionality.
[Verify] Go to settings and press all three buttons, afterch each of
them notification popup should appear.
Change-Id: I45d217fbacb5f05c2d9d25d72dc2642df4142ab6
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
Maciej Skrzypkowski [Tue, 13 Oct 2015 13:35:29 +0000 (15:35 +0200)]
Refactoring, renamed MainUI to QuickAccess
[Issue] N/A
[Problem] Misleading name
[Solution] Changed
[Verify] Open Quick Access view, check if it works by clicking tiles etc.
Change-Id: Ibebaa3b3e4216adb762453b8d9bfc74dfa6ff3d8
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Maciej Skrzypkowski [Tue, 13 Oct 2015 11:13:36 +0000 (13:13 +0200)]
Cookies saving between browser restarts.
[Issue] https://bugs.tizen.org/jira/browse/TT-138
[Problem] Cookies saving path was not set.
[Solution] Addes cookies saving path.
[Verify] Open onet.pl > click on X button in cookies popup information
> close browser > open again onet.pl,
cookies popup should not appear.
Change-Id: I4d0c4d1a544bd59a093dcf62092365121ef17435
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Maciej Skrzypkowski [Mon, 12 Oct 2015 11:27:54 +0000 (13:27 +0200)]
Refactoring, removed unneeded check in WebkitEngineService
[Issue] N/A
[Problem] Unneeded check and unneeded line
[Solution] Removed
[Verify] 1.Open few tabs.
2. Try to switch between them and check if it's OK
Change-Id: I0d9bb2eaa485277de4bd567a146fb6a49e768075
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Kamil Nowac [Mon, 12 Oct 2015 11:07:17 +0000 (13:07 +0200)]
Add a few missing thumbail images
[Issue] N/A
[Problem] Lack of few images
[Solution] Added images
Change-Id: I0f75c5d88d973e51d66f85403b5cddec76a968d3
Albert Malewski [Tue, 13 Oct 2015 08:04:47 +0000 (10:04 +0200)]
Navigation in Tab Manager
[Issue] https://bugs.tizen.org/jira/browse/TT-214
[Problem] Focus cannot move to "New Tab/New Incognito Tab" buttons.
[Cause] N/A
[Solution] Added focus directions:
"Up" arrow on "Opened tabs" -> focus moves to "Close tabs"
"Left" arrow on "Close tabs" -> focus moves to "new incognito tab"
[Verify] Launch browser > Open Tab Manager > Move focus to
"New Tab/New Incognito Tab"
Change-Id: Ia5aea25a36e4fa779bca541621c250e45ec60f28
Kamil Nowac [Fri, 9 Oct 2015 08:03:40 +0000 (10:03 +0200)]
Fix for receiving of the last session from database
[Issue] https://bugs.tizen.org/jira/browse/TT-182
[Problem] Browser does not load the last session
properly.
[Solution] Changed SQL instruction and a Session
copy constructor
[Verify]
1.Open few tabs.
2.Close browser.
3.Open browser.
Tabs from the last session should be loaded.
Change-Id: I401a7ea2f864c8459e6b2c2a6cef3af035138627
Signed-off-by: Kamil Nowac <k.nowac@samsung.com>
t.dakowicz [Fri, 4 Sep 2015 15:25:46 +0000 (17:25 +0200)]
Implemented ZoomUI service
[Issue#] https://bugs.tizen.org/jira/browse/TT-133
[Problem] Page zoom implementation
[Cause] N/A
[Solution] New ZoomUI service
[Verify] Open a new page -> MoreMenu -> Screen Zoom
Check if zooming/navigating the page works.
Change-Id: I1c47d5fd37927e0a8f88f8952af1350791eac02f
Kamil Nowac [Thu, 8 Oct 2015 10:27:34 +0000 (12:27 +0200)]
Add star image to the quick access bookmark thumbnails
[Issue] https://bugs.tizen.org/jira/browse/TT-202
[Problem] No image
[Solution] Added image according to the GUI guideline
[Verification] Add some bookmarks. Go to the Bookmarks
in Quick Access menu. Star should be visible.
Change-Id: Iad04388526e84618d58a01065228366b6094f5fa
Signed-off-by: Kamil Nowac <k.nowac@samsung.com>
Kamil Nowac [Wed, 7 Oct 2015 10:27:41 +0000 (12:27 +0200)]
Remove "On other devices" button from Tab Manager
[Issue] https://bugs.tizen.org/jira/browse/TT-207
[Problem] "On other devices" button is excluded
from phase 1.
[Solution] Commented EDC parts connected with
the button
[Verification] Open tabs manager. There should be no
"On Other Devices" button.
Change-Id: I602d8be8feb16c880fe01a9a067f108af47339de
Signed-off-by: Kamil Nowac <k.nowac@samsung.com>
Albert Malewski [Wed, 7 Oct 2015 08:34:04 +0000 (10:34 +0200)]
Fixed navigating by D-pad in Bookmark Manager
[Issue] https://bugs.tizen.org/jira/browse/TT-183
[Problem] There was a problem with navigation in Bookmark Manager.
[Cause] Disabled "Add to bookmarks" button was blocking moving
the focus.
[Solution] This is a workaround (because 'custom focus chain' API
did not work properly. FocusManager class is used.
Additionally, changed topContent from genlist to layout.
[Verify] Launch browser > Navigate to Bookmarka Manager > Use arrows to
move the focus.
Change-Id: I8f22bb24653f9df0dde5f5e009fbbd73d887d6ec
Albert Malewski [Tue, 6 Oct 2015 15:18:14 +0000 (17:18 +0200)]
Implemented new class FocusManager that manages focus in MoreMenu
[Issue] https://bugs.tizen.org/jira/browse/TT-183
[Problem] There was a problem with navigation in MoreMenu.
[Cause] Disabled "Add to bookmarks" button was blocking moving
the focus.
[Solution] This is a workaround (because 'custom focus chain' API
did not work properly. I have created new class that
stores objects to focus and implements mechanism of
mooving the focus.
[Verify] Launch browser > Navigate to More menu > Use arrows to
move the focus.
Change-Id: I3942e97c3176a204fc2ccd8738344f179cf1e89b
Kamil Nowac [Tue, 6 Oct 2015 13:32:39 +0000 (15:32 +0200)]
Add dimmed Add to Bookmarks
[Issue] https://bugs.tizen.org/jira/browse/TT-204
[Problem] Add to bookmarks button is not dimmed when are
no loaded pages
[Solution] According to the GUI guideline v0.5 dimmed button
should have white background and black text with
50% opacity.
Change-Id: Id0035d4bbcee6a5ecc67bc9caf35136e878652bd
Signed-off-by: Kamil Nowac <k.nowac@samsung.com>
Maciej Skrzypkowski [Thu, 8 Oct 2015 09:46:48 +0000 (11:46 +0200)]
D-pad navigation for bookmarks in Quick Access view
[Issue] https://bugs.tizen.org/jira/browse/TT-205
[Problem] Threre was no d-pad navigation for bookmarks
[Cause] Not implemented.
[Solution] Implemented adding and removing items from focus
chain while switching between Most Visted and Bookmarks.
Additionaly fixed switching between Most Visited
and Bookmark buttons.
[Verify] Add few bookmarks, switch to bookmarks view on Quick
Access page, try to navigate using keboard.
Change-Id: Idb3f89e46af1ae3656fc3cc3d9ddb65115ba549e
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Dariusz Frankiewicz [Tue, 6 Oct 2015 11:56:41 +0000 (13:56 +0200)]
Fix Reset browser functionality.
[Issue] https://bugs.tizen.org/jira/browse/TT-176
[Problem] Reset browser button didn't work.
[Cause] Not implemented
[Solution] Add function calls that remove necessary items.
[verify] Open some tabs, add some pages to bookmarks.
Then go to the settings and press Reset Broswser.
History, bookmarks, cookies, opened tabs should be deleted.
Change-Id: I592f2897e1d7447c544d2c8fc14847668c8e2059
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
sungwon2han [Tue, 6 Oct 2015 01:42:04 +0000 (10:42 +0900)]
Remove dead code from WebView class
Change-Id: I112affb7ce2924388cc7fb701a66671111d2c047
Signed-off-by: sungwon2han <sungwon2.han@samsung.com>
Dariusz Frankiewicz [Mon, 5 Oct 2015 09:00:32 +0000 (11:00 +0200)]
Fix reset most visited sites functionality.
[Issue] https://bugs.tizen.org/jira/browse/TT-175
[Problem] Reset most visited sites isn't working.
[Cause] Not implemented.
[Solution] Implemented setting site visit counter to 0 and
displaying only sites with counter grater then 0.
[Verify] Visit some sites, go to settings, press Reset Most Visted
Sites button, check if on new tab most visited sites are empty.
Change-Id: I05d44043744a1b7859b23df282dfb53745fb894d
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
Maciej Skrzypkowski [Mon, 5 Oct 2015 07:29:48 +0000 (09:29 +0200)]
Focus mode for DetailPopup.
[Issue] https://bugs.tizen.org/jira/browse/TT-196
[Problem] Keyboard navigation for Detail Popup was not implemented.
[Cause] N/A
[Solution] Added links to focus chain.
[Verify] Launch browser > Open few web pages > open Quick Access
> navigate using keyboard, open Detail Popup, navigate there
using keyboard, try choosing main link and history links.
Change-Id: Ia78b68f364220232359ec1583c3e32c8aa191924
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Kamil Nowac [Mon, 5 Oct 2015 10:28:47 +0000 (12:28 +0200)]
[PointerMode] Pointer Mode removal
[Issue] https://bugs.tizen.org/jira/browse/TT-130
[Problem] Not needed feature
[Solution] N/A
Change-Id: Id3e2df1abe346d1c2575b915e1a906d73bb1b722
Signed-off-by: Kamil Nowac <k.nowac@samsung.com>
Maciej Skrzypkowski [Thu, 1 Oct 2015 08:45:19 +0000 (10:45 +0200)]
Changed ordering of hiding Detail Popup.
[Issue] https://bugs.tizen.org/jira/browse/TT-199
[Problem] Clicking on history link in detail popup caused openig gray,
empty page.
[Cause] Wrong order of opening new web page caused referencing
to deleted object.
[Solution] Changed order, now popup hiding is after opening new URL.
[Verify] Launch browser > Open few web pages > open Quick Access
view, click on thumbnail, check if history links work.
Change-Id: I519e023592bc5870ab1330ec0157c06836eb154c
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Maciej Skrzypkowski [Mon, 28 Sep 2015 06:54:23 +0000 (08:54 +0200)]
Removed dead code from SimpleUI
[Issue#:] https://bugs.tizen.org/jira/browse/TT-157
[Problem:] SimpleUI contains dead code. Lots of unimplemented and
unused methods in class definition.
[Cause:] N/A
[Solution:] Remove dead code and unused method definitions.
[Verify:] Changes builds and doesn't breaks anything.
Change-Id: Id1e0df1abe445d8c2575b915e1a906d70bb1b741
Maciej Skrzypkowski [Tue, 29 Sep 2015 08:21:22 +0000 (10:21 +0200)]
Introduced new window management.
Continuation of patch proposed by Marcin Łapiński.
[Issue] https://bugs.tizen.org/jira/browse/TT-157
[Problem] There was no proper views management
[Cause] N/A
[Solution] New class ViewManager for controling switching
between views.
[Verify] Launch browser > switch between different
views (page view, more menu, settings, etc.),
check if switching is correct check if there
are no relevant warnings in logs.
Change-Id: I8827964b6539ecb7a4c02edd3d296b72a149a9e7
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Dariusz Frankiewicz [Fri, 25 Sep 2015 12:53:50 +0000 (14:53 +0200)]
Fix bad progress bar position.
[Issue] N/A
[Problem] Progress bar is invisible while page is loading.
[Cause] Bad posiotion.
[Solution] Move progress bar down.
[Verify] Load some page and check if progress bar is visible.
Change-Id: I0c628d60c46ae855dc517150bf235331846f7ed0
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
Dariusz Frankiewicz [Tue, 22 Sep 2015 15:07:19 +0000 (17:07 +0200)]
Rename some labels in browser.
[Issue] https://bugs.tizen.org/jira/browse/TT-179
[Problem] Some labels are incorrect according to UI guidelines.
[Verify] Check if reported labels are consistent with UI guidelines.
Change-Id: I4bb700e9003477611a9999aff415486a3236d2a2
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
Dariusz Frankiewicz [Tue, 22 Sep 2015 09:14:40 +0000 (11:14 +0200)]
Reneme More Menu tooltip label
[Issue] https://bugs.tizen.org/jira/browse/TT-172
[Problem] Wrong tooltip label.
[Solution] Rename label.
[Verify] Open browser, point More Menu button and check if label is
"More Menu" instead of "Settings".
Change-Id: I4694d62669952fae28533c8ae3540f6a7828fe18
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
t.dakowicz [Tue, 22 Sep 2015 12:15:06 +0000 (14:15 +0200)]
TT-168 Proper display of current site info
[Issue#] https://bugs.tizen.org/jira/browse/TT-168
[Problem] Current site info was wrong for Home Page (Quick Access view)
[Cause] Home Page status was not checked
[Solution] Added method for that case and added posibillity of disabling
the 'add to bookmark' button when needed
[Verify] Check if adding blank page doesn't work
Change-Id: Iaf287a26a238732029897f867a34a8f1f810c813
Maciej Skrzypkowski [Wed, 23 Sep 2015 14:44:14 +0000 (16:44 +0200)]
D-pad navigation for Quic access view
[Issue] https://bugs.tizen.org/jira/browse/TT-183
[Problem] There was no support for D-pad navigation in Quick Access.
[Cause] Some elements seemed not to be allowed to be focused.
[Solution] Added buttons which enables to focus tiles in Quick Access.
[Verify] Launch browser > Open few web pages > open Quick Access
view, try to navigate using D-pad.
Change-Id: Ie0e5b661a8502d551539e9d89e59162d554eb044
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Albert Malewski [Wed, 23 Sep 2015 11:06:16 +0000 (13:06 +0200)]
Fixed navigating by D-pad in History and Settings
[Issue] https://bugs.tizen.org/jira/browse/TT-183
[Problem] There was no support for D-pad navigation in More Menu.
[Cause] Some elements seemed not to be allowed to be focused.
[Solution] Added focus on some elements in HistoryUI and SettingsUI
using elm_object_focus_custom_chain_append. Set focus on
'Close' button by default. Cleared focused elements from
MoreMenuUI that were visible in HistoryUI, BookmarkManagerUI
and SettingsUI.
[Verify] Launch browser > Navigate to More menu > Choose an item
You should be able to go into Bookmarks/History/Settings
from More Menu just using keyboard/D-pad.
Change-Id: Ica000176f025659b2a4352a2b4e49fe13f552b92
Albert Malewski [Wed, 23 Sep 2015 06:13:29 +0000 (08:13 +0200)]
Fixed navigating by D-pad in More Menu
[Issue] https://bugs.tizen.org/jira/browse/TT-183
[Problem] There was no support for D-pad navigation in More Menu.
[Cause] Incorrect method of callback registration was used.
[Solution] Registered callback in elm_gengrid_item_append function
instead of evas_object_smart_callback_add.
[Verify] Launch browser > Navigate to More menu > Choose an item
You should be able to go into Bookmarks/History/Settings
from More Menu just using keyboard/D-pad.
Change-Id: Ib4673f0e645dbc1c3cbf4d4e2503cf4609b5a205
sungwon2han [Wed, 23 Sep 2015 06:18:59 +0000 (15:18 +0900)]
Browser exit when load history items
[Issue#] NA
[Problem] Browser cannot get history info from browser-provider
[Cause] browser-provider issue
[Solution] add error check routine for browser-provider
Change-Id: I12368bc9394e8115c4debfa9b72d8aa5a9aa9f5c
Signed-off-by: sungwon2han <sungwon2.han@samsung.com>
sungwon2han [Wed, 23 Sep 2015 04:53:33 +0000 (13:53 +0900)]
Browser exit when load bookmark items
[Issue#] NA
[Problem] Browser cannot get bookmark info from browser-provider
[Cause] browser-provider issue
[Solution] add error check routing for browser-provider
Change-Id: If91dc072d4c6294d331294b7cde74433d1dc2f2f
Signed-off-by: sungwon2han <sungwon2.han@samsung.com>
t.dakowicz [Mon, 21 Sep 2015 11:47:00 +0000 (13:47 +0200)]
TT-171 Removing bookmark folders from browser
[Issue#] https://bugs.tizen.org/jira/browse/TT-171
[Problem] N/A
[Cause] Newest guide doesn't contain folders anymore
[Solution] Removed bookmark folders
[Verify] Check if bookmarks are added/removed/displayed properly
Change-Id: Ife3cd8859ef4e1ceb1c4fae0412f40314e89fe02
t.dakowicz [Tue, 15 Sep 2015 14:40:23 +0000 (16:40 +0200)]
TT-163 'Add to bookmarks' UI change
[Issue#] https://bugs.tizen.org/jira/browse/TT-163
[Problem] N/A
[Cause] 1.02 UI guideline
[Solution] Added checkbox that defines current bookmark status
and toast popup for info purpose
Choosing folder for a new bookmark is still there.
Checkbox's style 'favorite' is not available.
Change-Id: I78eaf6ca94d6c0ca6605b6822ea5e5c087260d90
Albert Malewski [Mon, 21 Sep 2015 08:45:52 +0000 (10:45 +0200)]
Changed database path
[Issue] N/A
[Problem] There was wrong database path which resulted in fails
while launching the browser.
[Cause] Wrong Tizen platform variable was used.
[Solution] Used TZ_USER_APP instead of TZ_USER_DB and added <pkgid>/data
directory.
[Verify] Launch browser > Observe logs
There shouldn't be fails in logs while loading database.
Change-Id: Ibb2a6934f25b4974d2c6990cc78b1d97b8137bce
Maciej Skrzypkowski [Mon, 21 Sep 2015 08:48:29 +0000 (10:48 +0200)]
Closing app when pressing back key on Web Page view.
[Issue#] https://bugs.tizen.org/jira/browse/TT-170
[Problem] Browser didn't close when pressing back key.
[Cause] There was a check if back button is enabled which prevent
from closing app when there was no previous web page.
[Solution] Removed unneeded check.
[Verify] Run browser, visit some web page, press back button, check
if browser will close.
Change-Id: I46c29149a1d311679f9b6ef141f6dd71dc335363
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Maciej Skrzypkowski [Mon, 21 Sep 2015 09:24:46 +0000 (11:24 +0200)]
Moved code responsible for web page ui to separate service.
[Issue] https://bugs.tizen.org/jira/browse/TT-167
[Problem] Functionality of SimpleUI was confusing.
[Cause] N/A
[Solution] Created new class WebPageUI, moved all classes connected
to web page ui to new service.
Change-Id: I633b5c5abad0040b9b7d51e5fb532de2c0d25689
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Dariusz Frankiewicz [Fri, 18 Sep 2015 14:53:18 +0000 (07:53 -0700)]
Revert "Changed database path"
This reverts commit
5059e93c83493911ad58c4c26162f2792c99ded6.
Change-Id: I8cdfa7391739693de3813eed6d2179a90f94f76f
Albert Malewski [Fri, 18 Sep 2015 13:02:56 +0000 (15:02 +0200)]
Changed database path
[Issue] N/A
[Problem] There was wrong database path which resulted in fails
while launching the browser.
[Cause] Wrong Tizen platform variable was used.
[Solution] Used TZ_USER_APP instead of TZ_USER_DB.
[Verify] Launch browser > Observe logs
There shouldn't be fails in logs while loading database.
Change-Id: I2641314543647e15cdfc70b5b8decc201fdcc57b
Dariusz Frankiewicz [Fri, 18 Sep 2015 10:18:53 +0000 (12:18 +0200)]
fixup! ViewManager class added.
Change-Id: I9a52869f215df69a9e82c18ab2b3e4c547ea1c1d
Marcin Lapinski [Fri, 11 Sep 2015 13:37:24 +0000 (15:37 +0200)]
ViewManager class added.
[Issue#:] https://bugs.tizen.org/jira/browse/TT-157
[Problem:] New window management class is needed.
[Cause:] N/A
[Solution:] Implemented new class with following public methods:
popStackTo
popTheStack
pushViewToStack
getContent
[Verify:] Class is not used. Changes builds and doesn't crash.
Merge this after merging this patch:
https://review.tizen.org/gerrit/#/c/48052/
Change-Id: I4b8ca2866fa1cecbf858b4aed41e42112620a9f7
Marcin Lapinski [Fri, 11 Sep 2015 12:04:37 +0000 (14:04 +0200)]
Make AbstractUIComponent doing anything.
[Issue#:] https://bugs.tizen.org/jira/browse/TT-157
[Problem:] New window management class needs AbstractUIComponent to
have some view managing functions.
[Cause:] N/A
[Solution:] Added needed methods to interface:
void init(Evas_Object* parent)
Evas_Object* getContent()
void showUI()
void hideUI()
[Verify:] Change builds. Browser is not crashing on loading services.
Merge it after all UI components implement these methods.
Change-Id: I7c67cad62a5b68a713395ecc1487fa9e90c72bc7
Maciej Skrzypkowski [Tue, 15 Sep 2015 08:33:12 +0000 (10:33 +0200)]
Remove unused classes.
[Issue#] N/A
[Problem] These classes were unused.
[Cause] N/A
[Solution] Delete classes and theirs references.
[Verify] Run browser, check if page browsing works.
Change-Id: I11bd790c0cec58dfa7e13f7b9d553a8b822e69a3
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Marcin Lapinski [Mon, 14 Sep 2015 13:48:57 +0000 (15:48 +0200)]
MoreMenuUI Implementing new AbstractUIComponent methods.
[Issue#:] https://bugs.tizen.org/jira/browse/TT-157
[Problem:] New window management class needs AbstractUIComponent to
have some view managing functions.
[Cause:] N/A
[Solution:] Implemented needed methods:
void init(Evas_Object* parent)
Evas_Object* getContent()
void showUI()
void hideUI()
[Verify:] Change is not affecting browsers behaviour.
Change-Id: I4aef907e35f5240be86c259f4d6705a43c93ee4a
Marcin Lapinski [Mon, 14 Sep 2015 16:16:49 +0000 (18:16 +0200)]
TabUI Implementing new AbstractUIComponent methods.
[Issue#:] https://bugs.tizen.org/jira/browse/TT-157
[Problem:] New window management class needs AbstractUIComponent to
have some view managing functions.
[Cause:] N/A
[Solution:] Implemented needed methods:
void init(Evas_Object* parent)
Evas_Object* getContent()
void showUI()
void hideUI()
[Verify:] Change is not affecting browsers behaviour.
Change-Id: I6d4a91af909722050564690510f64e9c331b7fe5
Albert Malewski [Mon, 14 Sep 2015 12:12:12 +0000 (14:12 +0200)]
Removed inheritance of AbstractUIComponent in MainUI and SimpleURI classes
[Issue] https://bugs.tizen.org/jira/browse/TT-157
[Problem] MainUI and SimpleURI classes are not UI components in fact.
They are not suspected to call AbstractUIComponent's methods.
[Cause] N/A
[Solution] Removed inheritance of AbstractUIComponent in MainUI
and SimpleURI classes.
[Verify] This patch does not change browser's behaviour.
Change-Id: I048c6ad288df7af331efda6552565b83a112af08
Marcin Lapinski [Fri, 11 Sep 2015 11:54:40 +0000 (13:54 +0200)]
BookmarkManagerUI Implementing new AbstractUIComponent methods.
[Issue#:] https://bugs.tizen.org/jira/browse/TT-157
[Problem:] New window management class needs AbstractUIComponent to
have some view managing functions.
[Cause:] N/A
[Solution:] Implemented needed methods:
void init(Evas_Object* parent)
Evas_Object* getContent()
void showUI()
void hideUI()
[Verify:] Change is not affecting browsers behaviour.
Change-Id: Ia8f4eca29b82a54f239671f32bc6c43f9a47b7fe
Maciej Skrzypkowski [Mon, 14 Sep 2015 11:07:04 +0000 (13:07 +0200)]
Added proper handler for bookmark click in Quick Access view.
[Issue] N/A
[Problem] Clicking on bookmark caused opening popup or crashing.
[Cause] Wrong callback was assigned to bookmark click.
[Solution] Changed callback to opening new tab.
Change-Id: I85dbaa29ba83005e25a4796f80a80c901a23a1f9
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Maciej Skrzypkowski [Mon, 14 Sep 2015 10:25:36 +0000 (12:25 +0200)]
Refactoring - removed genlist from Quick Access tiles.
[Issue] N/A
[Problem] Genlist were unneeded for tiles.
[Cause] N/A
[Solution] Removed genlist, added aditional swallows for tiles.
Change-Id: I9a561d2973c9db0b70f413792dfdab4a2e7c24ab
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
t.dakowicz [Fri, 11 Sep 2015 11:16:44 +0000 (13:16 +0200)]
TT-165 Fixed browser crash after opening page from history/bookmarks
[Issue#] https://bugs.tizen.org/jira/browse/TT-165
[Problem] Browser's crash after opening a page from bookmarks/history
[Cause] Favicon was inserted into freed object
[Solution] Added disconnects from signals after closing MoreMenu
[Verify] New Tab -> MoreMenu -> History -> open page
or New Tab -> Bookmarks -> open page
Check if browser crashes
Please keep in mind that disconnects are needed here because views
are removed when exiting, which won't be done in future new browser's
structure.
Change-Id: I7a8db96b35d397b88196bbdbba21f526c73c2ec8
Marcin Lapinski [Tue, 1 Sep 2015 11:33:29 +0000 (13:33 +0200)]
SimpleUI refactoring
[Issue#:] https://bugs.tizen.org/jira/browse/TT-157
[Problem:] Function exec() covers functionality which will be
covered by different classes;
[Cause:] N/A
[Sollution:] Splitted huge exec() to few smaller.
[Verify:] Refactor is not affecting browsers behaviour.
Change-Id: I073154a3116ef7ff9723e2445737a699f59e214e