Szymon Jastrzebski [Mon, 18 Sep 2017 09:30:34 +0000 (11:30 +0200)]
[PROJECT] Refactoring entering logs into ScopeLogger
Removing logs in trivial function and adding when they are missed will be part of another commit
PS2 Rebase
PS3 Change some left Loggers
PS4 After using clang
PS5 Utilizing changes in ScopeLogger
PS6 Cleaning up
PS8 Adding missing logs - not formatted
PS9 Clang
PS10 Rebase
[Verification] Code compiles
10 random packages has 100% passrate:
alarm, systemsetting, systeminfo, security, content, filesystem, iotcon,
push, capability, privillege
Change-Id: I7972fee44dd13277d9ef7693433aad7b0321dd68
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Piotr Kosko [Mon, 9 Oct 2017 11:57:35 +0000 (13:57 +0200)]
[Tools] Added scripts for code style validation and auto fixing
[Feature] Added below scripts:
- tools/codestyle/code_formatter.sh - common formatter for both C and JS
(changes files)
- tools/codestyle/code_validation.sh - common validator for both C and JS
(does not change files)
- tools/codestyle/c++_clang_formatter.sh - for auto formating C++ files
- tools/codestyle/js_clang_formatter.sh - for auto formating JS files
- tools/codestyle/cpplint_tizen_160919.py and tools/codestyle/cpplint_tizen_dir.sh
scripts for C++ code style validation, provided by HQ
- tools/codestyle/eslint_config_mandatory_length90.js - coding rules for
JS sources validation - provided by HQ
- code_format and code_validate - links to scripts for easier access
[Help] You can check usage for code_format and code_validate using '-h' option
[Verification] Checked manually. Analysis seem to be done properly.
Since now, we should reformat new code using:
./code_format -c <path/to/changed/module>
and validate:
./code_validate -c <path/to/changed/module>
Using scripts for JS sources is not recommended for now.
Change-Id: I4af01a1f23c93547cd140ba7e5fed6294726c161
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 4 Oct 2017 07:45:45 +0000 (09:45 +0200)]
[Sensor] Fixed some bugs
[Bug]
- listener interval in case of multiple setListener calls was not updated
- start/stop/setListener/unsetListener was not protected against multithread access
- different behaviour in below scenarios:
a.> HRMrawsensor = tizen.sensorservice.getDefaultSensor("HRM_RAW");
> HRMrawsensor.stop()
undefined /// nothing happen
b.> HRMrawsensor = tizen.sensorservice.getDefaultSensor("HRM_RAW");
> HRMrawsensor.start(function(s){console.log(s)}, function(s){console.log(s)})
WebAPIException {code: 9, name: "NotSupportedError", message: "None HRM LED sensor is supported."}
> HRMrawsensor.stop()
Uncaught WebAPIException {code: 9, name: "NotSupportedError", message: "None HRM LED sensor is supported."}
[Verification] Manual and Auto TCT passed 100% (s.jastrzebsk)
Change-Id: I4862823f84fc386d05eabfeb3dabb7345e9c592c
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Wed, 18 Oct 2017 11:27:07 +0000 (13:27 +0200)]
[version] 2.05
Change-Id: I26e4d40ed0d09cbcf4c55f1c0e19082d3c6c6262
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Lukasz Bardeli [Tue, 17 Oct 2017 09:38:26 +0000 (11:38 +0200)]
[Iotcon] fix to prevent crash.
Store data in vector and check in every call
RemoteResourceResponseCallback if wasn't free earlier.
[Verification] Code compiles without errors. TCT passrate 100%
Change-Id: Ia3feb69460de99a0ad70915ae4b7098980fecb91
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Piotr Kosko [Wed, 11 Oct 2017 09:43:14 +0000 (11:43 +0200)]
[version] 2.04
Change-Id: Ica388eef8319574e89f2c0c7f586d8a1f7ef0f98
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 3 Oct 2017 06:29:50 +0000 (08:29 +0200)]
[Download] Added information about HTTP status in error message
[Feature] Error message of onfailed callback of start method, return only
Unknown error. Now information about HTTP status was added into message.
[Verification] Checked in chrome console.
TCT passrate - 100%.
Change-Id: I157053d10a1e770c070b55465f1a7351c0c80cce
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 11 Oct 2017 09:41:37 +0000 (11:41 +0200)]
Revert "[version] 2.04"
This reverts commit
89b277b80e408f1527ce145e9cb79a4a128f6b5f.
Change-Id: I9aac524a3b19a54c92a30436a77f4ed5dcff0d26
Piotr Kosko [Wed, 11 Oct 2017 09:27:55 +0000 (11:27 +0200)]
[version] 2.04
Change-Id: Ieae2c1837b41a866fa3288270b674305b643a9c7
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 11 Oct 2017 09:21:48 +0000 (11:21 +0200)]
Revert "[Iotcon] Prevent posible crash."
This reverts commit
7d553b6906feb5205c93da6e3ed0428a3d2c1edd.
Change-Id: I42eec0d4ce0f24dea8895aed3a8bbda4ca1d6426
Piotr Kosko [Thu, 5 Oct 2017 09:53:02 +0000 (09:53 +0000)]
Merge "[Iotcon] Prevent posible crash." into tizen_3.0
Lukasz Bardeli [Thu, 5 Oct 2017 09:12:24 +0000 (11:12 +0200)]
[Iotcon] Prevent posible crash.
[Feature] If Timeout was returned then it is possible to call
RemoteResourceResponseCallback again.
In this case data is deleted, but not set to null.
Call data->fun causes crash.
[Verification] Code compiles without error. Auto tests 100% passrate.
Change-Id: I07a3d1e38c933506620184f811b571d60e4b59fd
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Michal Bistyga [Wed, 4 Oct 2017 11:01:35 +0000 (13:01 +0200)]
[Common] Upgrading ScopeLogger
Changes:
- Extra argument to entering logs is not written at the end of scope
Change-Id: Id8824d5a91df54c9cb97f02b501e0da8f49852a2
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Piotr Kosko [Wed, 27 Sep 2017 10:56:29 +0000 (12:56 +0200)]
[version] 2.03
Change-Id: I940a2aa78782ddcba3c5031442d8821f9c932c8a
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Szymon Jastrzebski [Mon, 25 Sep 2017 09:28:02 +0000 (11:28 +0200)]
[Convergence] Removing Convergence API
segwon.han has requested to remove Convergence API.
Code compiles.
Change-Id: I89ab9f753de111277e444ca1b659ce301a13ae1a
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Mon, 25 Sep 2017 12:54:56 +0000 (14:54 +0200)]
[PROJECT][C++] Reformatting the whole project
The refactoring was requested by yj99.shin.
With this change, the cpplint does not find any more errors.
The change has been applied to C++ files only.
[Verification] Code compiles.
Change-Id: I03534fa2140a98b78099c78a1a915f9917c3927d
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Mon, 25 Sep 2017 12:14:23 +0000 (14:14 +0200)]
[Utils] Fixing typo
Change-Id: I853c37c6f0ba6039ed1bce64b61bab86f0aa962e
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Thu, 21 Sep 2017 10:13:10 +0000 (12:13 +0200)]
[Sensor] fixing listener behaviours
[Bug] Listeners are not called in deterministic way,
several "api calls order" issues are fixed.
[Verification] Code compiles properly
TCT passrate 100% - auto & manual
Web widget service tests of sensor - 119 pass - 100% passrate
Change-Id: I720e23e0f23a9a849fb2d507e8721f196578ac48
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 20 Sep 2017 07:40:40 +0000 (07:40 +0000)]
Merge "[Download] Checking if device is connected before" into tizen_3.0
Piotr Kosko [Wed, 20 Sep 2017 05:07:18 +0000 (07:07 +0200)]
[version] 2.02
Change-Id: I80ac163b28617a3aa31400acd7042f57fdc06af2
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Michal Bistyga [Fri, 15 Sep 2017 09:46:00 +0000 (11:46 +0200)]
[Download] Checking if device is connected before
When wi-fi has been disconnected, plugins would throw not intuitive error description.
It was especially important on XU3, where short disconnect occurs more often.
[Verification] 100% TCT pass rate on TM1
Change-Id: I22712dd8e815ac810b8fec5549c370e91498ed85
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Piotr Kosko [Tue, 19 Sep 2017 11:42:31 +0000 (11:42 +0000)]
Merge "[Sensor] Not using ECMAScript6 code" into tizen_3.0
Piotr Kosko [Tue, 19 Sep 2017 11:06:47 +0000 (13:06 +0200)]
[Sensor] Not using ECMAScript6 code
[Bug] Web Widget Engine does not support ECMAScript6,
so it is needed to workaround internal code which used it.
[Verification] Code compiles without errors.
TCT passrate of sensors is 100%.
Some Web Widget tests passed without error.
Change-Id: I2110b35ce0ed9a4a8e3660b9c77b2a687585063f
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Szymon Jastrzebski [Tue, 19 Sep 2017 11:03:20 +0000 (13:03 +0200)]
[MediaController] Fixing typo
Change-Id: Iff3d210bafb9bbf98c44511910c38f6ffc0c266d
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Tue, 19 Sep 2017 08:18:10 +0000 (10:18 +0200)]
[MediaControler] Adding missing enum mapping
Native API uses MC_SERVER_STATE_NONE, which must be mapped to 'INACTIVE'
Web API enum. The 'NONE' state is the default state for native MC server.
[Verification] Code compiles, MC TCT passed 100%.
Change-Id: Ida2acbad265dfa7b9a91d79e64e90bccb6632e56
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Fri, 15 Sep 2017 09:41:15 +0000 (11:41 +0200)]
[NBS] Removing unnecessary code
[Verification] Code compiles. TCT NBS 100%
Change-Id: Ibeb40bcf0f22f6765ca4e92464dc57373d07fbb4
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Rafal Walczyna [Thu, 14 Sep 2017 10:27:32 +0000 (12:27 +0200)]
[widgetservice] Check if widget_id is not null
[verification] TCT pass rate 100% on TM1
[svace] 289591
Change-Id: I03b2fd5914965e3c52c69fef7bdb2fc3c73c99a5
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Piotr Kosko [Mon, 11 Sep 2017 07:53:11 +0000 (07:53 +0000)]
Merge "[CallHistory] Fix for find method" into tizen_3.0
Michal Bistyga [Thu, 7 Sep 2017 13:18:04 +0000 (15:18 +0200)]
[CallHistory] Fix for find method
[Bug]Multiple threads could access one vector, which resulted in crash.
[Verification]Pass rate didn't change.
Change-Id: I46a809c0df2965220b35a8e78389f2fdc8746c77
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Lukasz Bardeli [Thu, 7 Sep 2017 15:25:18 +0000 (17:25 +0200)]
[version] 2.01
Change-Id: I836d8a6a5ddcc6adfb07808d529ec1aa29ec1293
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Jakub Skowron [Thu, 7 Sep 2017 14:41:04 +0000 (16:41 +0200)]
[Systeminfo] Fix core dump in SystemInfoManager
Cellular network listener was not unregistered, which caused
core dump if network status changed after SystemInfoManager
destructor.
This is a hack, more robust solution should be developed.
Change-Id: Id4d26492426028a87ebaf1109e4f7750dd10b7c4
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>
Piotr Kosko [Wed, 6 Sep 2017 11:13:08 +0000 (13:13 +0200)]
[version] 2.0
Change-Id: I5904cd964c4449cdb22447654b38cd36d29fb622
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 6 Sep 2017 11:08:24 +0000 (11:08 +0000)]
Merge "[MediaController] Fixing client's listeners" into tizen_3.0
Piotr Kosko [Wed, 6 Sep 2017 11:07:52 +0000 (11:07 +0000)]
Merge "[NBS] Fix for releasing domains." into tizen_3.0
Szymon Jastrzebski [Tue, 5 Sep 2017 10:31:17 +0000 (12:31 +0200)]
[NBS] Fix for releasing domains.
Change-Id: I47a2a86d93e11b6b2f7d02001ec6eda4f65e0b30
Signed-off-by: Tomasz Marciniak <t.marciniak@samsung.com>
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Wed, 6 Sep 2017 09:45:21 +0000 (09:45 +0000)]
Merge "[Application] Adding debug logs" into tizen_3.0
Michal Bistyga [Tue, 29 Aug 2017 15:20:39 +0000 (17:20 +0200)]
[Application] Adding debug logs
Change-Id: I9fca94f5bda30b39bfff700f8cd37c5abe81d9f3
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Szymon Jastrzebski [Thu, 31 Aug 2017 11:54:52 +0000 (13:54 +0200)]
[MediaController] Fixing client's listeners
Listeners, which are registered per MediaControllerServerInfo object
work globally. This causes to invoke the registered listener for every
change in any server.
[Verification] TCT MC 100% pass rate.
Change-Id: I950e047b07a16d351959fe98e47ea1ca7ff68518
Saaigned-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Thu, 31 Aug 2017 05:55:44 +0000 (05:55 +0000)]
Merge "[Download] Enable download with net_proxy" into tizen_3.0
Pawel Wasowski [Tue, 29 Aug 2017 14:12:17 +0000 (16:12 +0200)]
[Download] Enable download with net_proxy
[Verification] TCT download pass rate, (wearable connected
to the internet with Android mobile as a network proxy,
no Wi-Fi/cellular network connection): 100 %
Change-Id: I0efb8c2d5281d5249dad46d58eaf8aa7c5ddc930
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Piotr Kosko [Wed, 30 Aug 2017 10:30:29 +0000 (12:30 +0200)]
[version] 1.99
Change-Id: I7ddff1b2974fe3361f62d498f736ec9ab779681d
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Tomasz Marciniak [Mon, 28 Aug 2017 12:27:47 +0000 (14:27 +0200)]
[Sensor] Check if error callback exists before calling
[Verification] Code compiles. Exception is not throw if
error callback is not defined. TCT pass rate did not change.
Change-Id: I95053c70e598c1a17022edebdd6be8a334a05a06
Signed-off-by: Tomasz Marciniak <t.marciniak@samsung.com>
Piotr Kosko [Mon, 21 Aug 2017 10:30:13 +0000 (12:30 +0200)]
[version] 1.98
Change-Id: I751ce338fdcce6ab1de120b31b427cbbad065b34
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Szymon Jastrzebski [Mon, 21 Aug 2017 09:35:52 +0000 (11:35 +0200)]
[Sensor] Fixing DefaultEventComparator
Comparator DefaultEventComparator should iterate through
all received values. It should NOT compare timestamps.
The amount of received values depend on the type of used
sensor. The sensor_value_count_ values are taken from
Native Sensor's Guides.
[Verification] Code compiles. TCT (TW1) passed 100%.
Change-Id: I60d5af338a7feea2dd4fb40cdff0f6bd03f8d650
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Mon, 21 Aug 2017 06:16:38 +0000 (06:16 +0000)]
Merge "[Sensor] Fix for HRM Sensor" into tizen_3.0
Piotr Kosko [Mon, 21 Aug 2017 05:48:59 +0000 (05:48 +0000)]
Merge "[Sensor] Fix for HRM Sensor Change Listener" into tizen_3.0
Tomasz Marciniak [Thu, 17 Aug 2017 12:17:20 +0000 (14:17 +0200)]
[version 1.97]
Change-Id: I84d1035105246be61f76dc052f626c52fc83faa3
Signed-off-by: Tomasz Marciniak <t.marciniak@samsung.com>
Lukasz Bardeli [Thu, 17 Aug 2017 12:12:55 +0000 (12:12 +0000)]
Merge "[Filesystem] Fix for moving files on different file systems" into tizen_3.0
Tomasz Marciniak [Wed, 16 Aug 2017 12:39:52 +0000 (14:39 +0200)]
[Filesystem] Fix for moving files on different file systems
[Verification] Code compiles. Now files can be moved
between different mounted file systems.
TCT pass rate 100% (286/286/0/0/0)
Change-Id: I5b70bc96f14a53bcebd2b2db3f12748949aab410
Signed-off-by: Tomasz Marciniak <t.marciniak@samsung.com>
Szymon Jastrzebski [Thu, 17 Aug 2017 07:00:14 +0000 (09:00 +0200)]
[Sensor] Fix for HRM Sensor Change Listener
An exception was thrown when trying to call 'tryCall' with data received
from C++ layer, making it not possible to set listener for HRM Sensor.
sensorType string starts with 'LED_' but there are no any sensor in
_sensorListeners object.
[Verification] Sensor TCT passed 100% (TW1).
Change-Id: I1b4ffe6ac754c6c407ebafea94b1eda48b59844d
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Thu, 17 Aug 2017 07:05:15 +0000 (09:05 +0200)]
[Sensor] Fix for HRM Sensor
Currently, successCallback nor errorCallback functions are invoked after
calling start() method for HRM sensor. This occurs only on platforms
that do not support HRM sensor.
Thus, it's better to invoke errorCallback in above case instead of
successCallback.
[Verification] Code compiles, TCT 100% pass rate (TM1, TW1), except
emulators, which do not support HRM sensor.
Sensor startSuccessCallbacks are invoked after
receiving an event from sensors.
Change-Id: I6484b44fd66f966c72b29fbc277b14f9006ca205
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Lukasz Bardeli [Wed, 16 Aug 2017 10:13:47 +0000 (12:13 +0200)]
[version] 1.96
Change-Id: I245b3ee789170f473b94addb7b305144f6d17e9c
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Szymon Jastrzebski [Wed, 16 Aug 2017 09:06:03 +0000 (11:06 +0200)]
Revert "[Utils] Fix privilege bypass, StringCopy function"
This reverts commit
3b71b0bac5e1bb09c50c97168dba1619b3ed40d6.
Change-Id: I2e8c2480e2fa3632853ef35d7a457ffed19ae7ce
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Tomasz Marciniak [Thu, 10 Aug 2017 11:01:13 +0000 (13:01 +0200)]
[version] 1.95
Change-Id: I2da7ee4bcf674c0e740473b0c58d03af1e47e50e
Signed-off-by: Tomasz Marciniak <t.marciniak@samsung.com>
Tomasz Marciniak [Thu, 10 Aug 2017 08:26:32 +0000 (10:26 +0200)]
[Systeminfo] Get status and mac address if WiFi is off
[Feature] Status and mac address of the WiFi interface
were retrieved only if device was connected to some AP.
Now they are retrieved always.
[Verification] Code compiles. TCT pass rate 100%
Change-Id: Ia16d22f204a71d4084e13ce5ab647b60c7acee60
Signed-off-by: Tomasz Marciniak <t.marciniak@samsung.com>
Lukasz Bardeli [Wed, 9 Aug 2017 08:47:39 +0000 (10:47 +0200)]
[version] 1.94
Change-Id: I753bfbe604e766f46a55ef671900d178bf47227f
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Lukasz Bardeli [Wed, 9 Aug 2017 08:34:45 +0000 (08:34 +0000)]
Merge "[Sensor] Delay invokation of successCallback in start() method" into tizen_3.0
Szymon Jastrzebski [Tue, 8 Aug 2017 11:16:03 +0000 (13:16 +0200)]
[Sensor] Delay invokation of successCallback in start() method
It is not guaranted that after calling successCallback,
user will be able to receive instantly sensor data values
by calling get<sensor>SensorData methods.
Thus, we need to delay invokation of successCallback
to make sure that there will not be timing issues.
Now, successCallback will be called after receiving the first
sensor event. The callback is used once, every time sensor
is started.
[Requester] ethan.jeong@samsung.com
[Verification] TCT Sensor passed 100%.
Change-Id: I5a8ebc9b851d26a35189258b13dacec0ae17149c
Szymon Jastrzebski [Thu, 3 Aug 2017 13:31:21 +0000 (15:31 +0200)]
[Sensor] Fixing setChangeListener method
According to the documentation parameter 'batchLatency'
in setChangeListener method should only be optional,
not nullable.
[Verification] TCT passed 100%.
Change-Id: I811dedb1e8779cc6fbb8e21310577d8b9979111c
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Lukasz Bardeli [Wed, 2 Aug 2017 07:43:59 +0000 (09:43 +0200)]
[version] 1.93
Change-Id: I82e136107d2f03a2ed163b33d1295d5513f5fc8c
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Piotr Kosko [Fri, 21 Jul 2017 09:43:43 +0000 (11:43 +0200)]
[HAM] fixed SVACE issue
[Verification] HAM tct 100%
Change-Id: Ibba5969d26a0eb95b4320ab1c62c276d7454d68f
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Fri, 21 Jul 2017 06:19:09 +0000 (08:19 +0200)]
[version] 1.92
Change-Id: If809da9009b050536c900907457f633c60c606de
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Thu, 20 Jul 2017 13:51:22 +0000 (13:51 +0000)]
Merge "[HAM] Adding casting int64_t to float" into tizen_3.0
Piotr Kosko [Thu, 20 Jul 2017 13:50:01 +0000 (13:50 +0000)]
Merge "[SystemInfo] Adding casting int to double + fix InchToMm constant" into tizen_3.0
Piotr Kosko [Thu, 20 Jul 2017 13:49:02 +0000 (13:49 +0000)]
Merge "[Messaging] Adding checking return value of calloc" into tizen_3.0
Tomasz Marciniak [Thu, 13 Jul 2017 13:35:18 +0000 (15:35 +0200)]
[NBS] Add support for ipv6 addresses.
[Verification] Code compiles.
TCT pass rate is 100% (24/24/0/0/0)
Change-Id: Iee84d0ba90acfb78ed33c0f759430ffb05644efb
Signed-off-by: Tomasz Marciniak <t.marciniak@samsung.com>
Szymon Jastrzebski [Wed, 19 Jul 2017 11:26:34 +0000 (13:26 +0200)]
[HAM] Adding casting int64_t to float
SVACE detected problem with code NO_CAST.INTEGER_DIVISION (25137).
[Verification] Code compiles, TCT HAM passed 100%.
Change-Id: Ie48c2250b70f79c29ea002d2c1e9b89f81e0ac24
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Wed, 19 Jul 2017 10:35:55 +0000 (12:35 +0200)]
[SystemInfo] Adding casting int to double + fix InchToMm constant
SVACE detected problem with code NO_CAST.INTEGER_DIVISION.
[Verification] Code compiles, TCT SystemInfo passed 100%.
Change-Id: Ie6249780860cd61a8c331d77648b6d37b9241c4c
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Wed, 19 Jul 2017 08:26:56 +0000 (10:26 +0200)]
[Messaging] Adding checking return value of calloc
SVACE detected problem with code DEREF_OF_NULL.RET.ALLOC.
[Verification] Code compiles.
Change-Id: Ibf604637e9f9d08e8c486a421afd94bbe6d6bddc
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Lukasz Bardeli [Wed, 19 Jul 2017 07:07:36 +0000 (09:07 +0200)]
[version] 1.91
Change-Id: I253cb2dfb07843f3a46694eba5a69719d6006450
Piotr Kosko [Tue, 18 Jul 2017 12:23:46 +0000 (12:23 +0000)]
Merge "[Systeminfo] Fixed condition, which caused to call successCallback when not needed" into tizen_3.0
Piotr Kosko [Tue, 18 Jul 2017 10:52:28 +0000 (10:52 +0000)]
Merge "[Contact] Fixing bug when adding Contact to AddressBook" into tizen_3.0
Szymon Jastrzebski [Tue, 18 Jul 2017 09:20:35 +0000 (11:20 +0200)]
[Systeminfo] Fixed condition, which caused to call successCallback when not needed
According to documentation, the successCallback is called in
4 different possible situations.
The condition, which fills the requirements is optimized.
[Verification] SystemInfo TCT passed 100%.
Change-Id: Ie6b24853ed233ecb8ac9d5ee28677e84d2b22f2f
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Pawel Wasowski [Fri, 7 Jul 2017 16:02:53 +0000 (18:02 +0200)]
[EXIF] Fix privilege issue
Problem: implementation of getExifInfo() used Web API filesystem
resolve() function to check, if file exists on the device. Use of this
function required declaring http://tizen.org/privilege/filesystem.read.
File existence checking has been implemented in EXIF plugin and does not
require declaring any additional privileges.
[Verification] TCT EXIF: 100% pass rate,
manuall tests with Chrome DevTools did not show any problems
Change-Id: Id9d19965eddb31902f14817eac0bd5ad897f1568
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Thu, 13 Jul 2017 19:57:37 +0000 (21:57 +0200)]
[Application] Fix category array population bug
Problem: application's categories were not passed from C++ to JS layer
Verification: it has been proved in tests in Chrome DevTools, that
application's categories may be obtained with Application API
TCT Application pass rate: 100%
Change-Id: I0995cd464315c9194196874fa488d52de49b1e69
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Szymon Jastrzebski [Thu, 13 Jul 2017 06:19:53 +0000 (08:19 +0200)]
[Contact] Fixing bug when adding Contact to AddressBook
There was a bug, which caused application to crash everytime
when adding more than one nickname.
In every iteration of nicknames, the same nickname-handler
was added to parent-handler. The crash happened during attempting
to free parent-handler with all its children (double free).
Contact TCT passed 100%.
Change-Id: Ibaddf2ce17aacb6dcf40422fc0303ec5e1142089
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Wed, 12 Jul 2017 09:28:36 +0000 (11:28 +0200)]
[version] 1.90
Change-Id: Iae694af4c97bdd2a918a8a2ca59d2633f1863b7b
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 11 Jul 2017 10:54:26 +0000 (10:54 +0000)]
Merge "[FMRadio] Fixing memory leak" into tizen_3.0
Piotr Kosko [Tue, 11 Jul 2017 10:53:38 +0000 (10:53 +0000)]
Merge "[Messaging] Replacing call of email_attachment_data_t structure constructor to calloc" into tizen_3.0
Piotr Kosko [Tue, 11 Jul 2017 10:17:25 +0000 (10:17 +0000)]
Merge "[Bluetooth] Fixing memory leak" into tizen_3.0
Szymon Jastrzebski [Mon, 10 Jul 2017 11:12:39 +0000 (13:12 +0200)]
[Bluetooth] Fixing memory leak
user_data was lost when native function app_control_send_launch_request
returned value different from APP_CONTROL_ERROR_NONE.
In case of fail, we need to delete allocated memory manually.
TCT bluetooth passed 100%.
Change-Id: I5aa08bfdda97a5dfab7718177be0fbb3f4c9dae0
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Fri, 7 Jul 2017 12:41:54 +0000 (14:41 +0200)]
[Messaging] Replacing call of email_attachment_data_t structure constructor to calloc
Native function email_free_attachment_data uses free() to release allocated
memory pointing by tmp. Thus, we should call calloc() instead of structure's
constructor.
Messaging-email TCT passed 100%.
Change-Id: Ib81f1da2e0270cfa76aef0eab7005d968c1f102c
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Mon, 10 Jul 2017 10:31:20 +0000 (12:31 +0200)]
[FMRadio] Fixing memory leak
There was a memory leak, which happened when user called
tizen.fmradio.scanStop, after starting scanning.
user_data was allocated in method FMRadioManager::ScanStart
but it was lost when scanning was interrupted.
FMRadio TCT passed 100%.
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Change-Id: I2f4b8b74c8a7703dd9d31f5ca8e338caa5e90c45
Piotr Kosko [Mon, 10 Jul 2017 09:46:02 +0000 (11:46 +0200)]
[Filesystem] Support for 2GB+ files added
[Feature] Plugins are build with '-D_FILE_OFFSET_BITS=64' flag to
support files larger that 2GB.
[Verification] Code compiles without errors.
TCT passrate 100%.
Checked in console with code:
// bigfiletest contains 4GB file
tizen.filesystem.resolve(
'images/bigfiletest',
function(dir) {
function onsuccess(files) {
for (var i = 0; i < files.length; i++) {
console.log(files[i].name + " size: " + files[i].fileSize );
}
}
dir.listFiles(onsuccess);
}, function(e) {
console.log("Error: " + e.message);
}, "r"
);
/// result
// BIG.txt size:
4294967296
Change-Id: I21513b533eeee0294267888d416ec3d0a85c91bf
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 5 Jul 2017 07:10:11 +0000 (09:10 +0200)]
[version] 1.89
Change-Id: Icf0dcfdfa530d3fad644cc560a00ea1933064188
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Jakub Skowron [Fri, 30 Jun 2017 14:02:34 +0000 (16:02 +0200)]
[Utils] Fix privilege bypass, StringCopy function
User could redefine String and String.indexOf to bypass privilege
check and to go outside of virtual-root by ../ in path
Change-Id: Ia9f7210ba685d1df18c9c443706361f624a38c1e
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>
Piotr Kosko [Wed, 28 Jun 2017 06:48:39 +0000 (08:48 +0200)]
[version] 1.88
Change-Id: I8944a33b7b9421c481f988f09f753c668fae927c
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Lukasz Bardeli [Wed, 28 Jun 2017 06:24:32 +0000 (08:24 +0200)]
[Application][Alarm] Free app_control_h using app_control_destroy
[Verification] Code compiles without error. TCT passrate
Alarm 100%
AppControl 100%
Application 100%
Change-Id: I5c32e2307d9b7e8b36df0919c670c97b5828a572
Pawel Wasowski [Thu, 22 Jun 2017 10:29:13 +0000 (12:29 +0200)]
[SystemInfo] Fix for "BATTERY" property value change listener callbacks
Callbacks called on "BATTERY" property value change threw an exception,
if "lowThreshold" or "highThreshold" SystemInfoOptions were specified.
[Verification] Tested in Chrome DevTools, registered callbacks work
fine.
Change-Id: Ie50dfb0710e9b203e072ff5336b77ff27c464031
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Piotr Kosko [Wed, 14 Jun 2017 05:26:56 +0000 (07:26 +0200)]
[version] 1.87
Change-Id: Ic2a1806af385df069553fcdb38d57e362ff94c36
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Tomasz Marciniak [Wed, 7 Jun 2017 10:07:09 +0000 (12:07 +0200)]
[Power] Restore system side brightness
[Verification] Code compiles.
TCT pass rate 100% (auto and manual)
Now system side brightness is restored when
application is closed/terminated.
Change-Id: I9fe5a60c7f4f85e5ed9f891f16fb7e5cf57ee857
Signed-off-by: Tomasz Marciniak <t.marciniak@samsung.com>
Piotr Kosko [Wed, 7 Jun 2017 06:47:54 +0000 (08:47 +0200)]
[version] 1.86
Change-Id: Ifcc9c5bcf836582ab986f53808fdf1ec3ce14ce7
Lukasz Bardeli [Wed, 7 Jun 2017 06:27:26 +0000 (08:27 +0200)]
[Archive] checking if dynamic_cast succeeded
[Verification] Code compiles without error
Change-Id: Id48b95aaea1d69573a1e50acaa12304b338b8ef8
Piotr Kosko [Wed, 7 Jun 2017 05:41:52 +0000 (05:41 +0000)]
Merge "[Convergence] Disabling Convergence module" into tizen_3.0
Lukasz Bardeli [Fri, 2 Jun 2017 09:55:09 +0000 (11:55 +0200)]
[Archive][Convergence][Sound] fix cppTest issue
[verification] Code compiles without error
Change-Id: Iee11cdaf9647103fa54ede1c00168413f747016b
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Szymon Jastrzebski [Mon, 5 Jun 2017 07:16:04 +0000 (09:16 +0200)]
[Convergence] Disabling Convergence module
HQ requested to remove Convergence API from Tizen 3.0.
Change-Id: Ide749fe9bd2f23c1d0c845042d7530fe3146cafc
Piotr Kosko [Wed, 31 May 2017 10:14:21 +0000 (12:14 +0200)]
[version] 1.85
Change-Id: Ib8a70c3f450f4e96598b13f3018bb4bd37b74c1c
Piotr Kosko [Mon, 29 May 2017 12:56:34 +0000 (12:56 +0000)]
Merge "[Iotcon] fix for iotcon, pass information about representation" into tizen_3.0
Piotr Kosko [Thu, 25 May 2017 12:10:25 +0000 (14:10 +0200)]
fixed setters of DownloadRequest
[Verification] Code checked with chrome console.
TCT passrate 100%.
Change-Id: I7c9976efaf900452ee3da63fb13a3de1f0fa4466
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 24 May 2017 10:10:23 +0000 (12:10 +0200)]
[version] 1.84
Change-Id: I96ee3646219e313a394cdf73595eaea57876aca6