Junkyeong Kim [Mon, 23 Jul 2018 11:50:12 +0000 (20:50 +0900)]
virtual: send set_physical_size when voutput connect
change tdm_client tc mode values for virtual output test
Change-Id: Ib3b904388cc44c2042bcb3d8b2aa7ce51fa9df78
Signed-off-by: Junkyeong Kim <jk0430.kim@samsung.com>
Junkyeong Kim [Mon, 23 Jul 2018 11:35:02 +0000 (20:35 +0900)]
virtual: add tdm_voutput_connect & disconnect
Change-Id: Ia80b476627ff79ff3eac2e3187aa8e8577a7cf6b
Signed-off-by: Junkyeong Kim <jk0430.kim@samsung.com>
Junkyeong Kim [Mon, 23 Jul 2018 06:25:35 +0000 (15:25 +0900)]
virtual: execute tdm_display_destroy_output when voutput destroy
execute set_available_modes and set_physical_size when connect
Change-Id: Ifd37190120ee6b4139d0c75a2f53001f6475ba09
Signed-off-by: Junkyeong Kim <jk0430.kim@samsung.com>
Junkyeong Kim [Mon, 23 Jul 2018 06:03:45 +0000 (15:03 +0900)]
virtual: add set_physical_size protocol
Change-Id: I19f67d59f816bd1486f6c1f408416856c03469ac
Signed-off-by: Junkyeong Kim <jk0430.kim@samsung.com>
Junkyeong Kim [Fri, 20 Jul 2018 09:48:41 +0000 (18:48 +0900)]
virtual: add set_available_mode & set_phsycal_size function
Change-Id: I9f0e0115ab64786207db49f934d72a0d7c7e8ffc
Signed-off-by: Junkyeong Kim <jk0430.kim@samsung.com>
Seunghun Lee [Thu, 19 Jul 2018 08:59:03 +0000 (17:59 +0900)]
virtual output: fix build break.
Remove redefinition, 'tdm_server_voutput_info'.
Change-Id: I277e3a14cd31e3db712c9005420e811f88528318
Seunghun Lee [Thu, 19 Jul 2018 07:42:23 +0000 (16:42 +0900)]
virtual output: Remove definition, 'tdm_client_output_set_buffer_queue'.
Change-Id: Ia3dec1f59ed6afe316b8ff37b551f9bf8ea548f6
Seunghun Lee [Thu, 19 Jul 2018 07:17:14 +0000 (16:17 +0900)]
virtual output: Add implementation for set_available_modes, connect and disconnect.
Change-Id: Ic85238c5833286ae22fc698d3d8b3fe2fc903e24
Junkyeong Kim [Wed, 18 Jul 2018 10:50:26 +0000 (19:50 +0900)]
virtual:add omitted definitions
fix build fail
Change-Id: Ia217cf3dd11e7ea2b9320af0f5d14fd7b6b99c6e
Signed-off-by: Junkyeong Kim <jk0430.kim@samsung.com>
Junkyeong Kim [Wed, 18 Jul 2018 10:31:12 +0000 (19:31 +0900)]
virtual:add virtual output create/destroy
Change-Id: Ib8ef9133c166e8fc67a9b338667941fe35849764
Signed-off-by: Junkyeong Kim <jk0430.kim@samsung.com>
Junkyeong Kim [Wed, 18 Jul 2018 02:51:46 +0000 (11:51 +0900)]
virtual:add virtual backend
copy dummy backend.
load virtual backend module default.
Change-Id: If130aa455e28ecf01a5674ae87d8247554144a09
Signed-off-by: Junkyeong Kim <jk0430.kim@samsung.com>
Boram Park [Mon, 9 Apr 2018 12:34:02 +0000 (21:34 +0900)]
implementation
Change-Id: I6600b589fb140b2ff5a5c5258f4ddf9bcab89e87
Signed-off-by: Junkyeong Kim <jk0430.kim@samsung.com>
Seunghun Lee [Tue, 17 Jul 2018 08:23:31 +0000 (17:23 +0900)]
virtual output: Add implementation for client and test case for virtual output.
- Added implementation for creation of virtual output.
- Added definition for the rest of client's api of virtual output.
- Added TC for client's Virtual Output API.
Change-Id: Ic6959e852ec12fed4c8f7ba77c4cf3a360ce855a
Seunghun Lee [Wed, 27 Jun 2018 10:23:33 +0000 (19:23 +0900)]
tdm_client: Introduce header of tdm_virtual_output.
Change-Id: I6365c41f02a015f31f9e19f8c3379a902181df55
Junkyeong Kim [Mon, 25 Jun 2018 06:23:06 +0000 (15:23 +0900)]
vblank: avoid mutex lock error.
Change-Id: I4c47966a7b6bb2afab62ed51ed2f06fa097b58c7
Signed-off-by: Junkyeong Kim <jk0430.kim@samsung.com>
SooChan Lim [Wed, 30 May 2018 01:39:46 +0000 (10:39 +0900)]
tc: add tests for tdm_hwc and tdm_hwc_window
Change-Id: Id19c9f11771397f60204ef5a6af07576f4da7f37
SooChan Lim [Mon, 21 May 2018 07:49:58 +0000 (16:49 +0900)]
package version up to 2.0.0
- add haltest cases
- add the new backend APIs for the TDM-HWC at tdm_backend.h
- increase the major verion of the TBM backend ABI to version 2.0
The tdm backend module needs to set the valid backend version.
Change-Id: I62538cb7d634e465e007900e7b49595ea4cd9226
SooChan Lim [Mon, 21 May 2018 07:46:11 +0000 (16:46 +0900)]
define the backend ABI version
The TDM backend ABI version should be separated with TDM front-end ABI.
Therefore, tdm defines the TDM backend ABI version at the tbm_backend.h.
The tdm checks the module ABI version with this backend ABI version
when the libtdm loads the backend modules.
Change-Id: I80d842f225d261f7fc024c6928dc66c9d4a95a65
SooChan Lim [Mon, 14 May 2018 06:31:48 +0000 (15:31 +0900)]
package version up to 1.18.2
Change-Id: I9497d4acca1549053030f5865016d825fd17413e
Seunghun Lee [Mon, 14 May 2018 06:12:41 +0000 (15:12 +0900)]
thread: Do not send a value of sync as '1' to display thread (quick-fix)
Sync type event from display-thread(main thread) can't be handled. In this way,
if we call tdm_thread_send_cb() with 'cb_base->sync = 1', then libtdm will
eveventually raise abort().
Please see commit '
4abfab36' for more detail.
Change-Id: Ia588141fc9e752753dbe04fda835c5532839d95e
SooChan Lim [Fri, 4 May 2018 04:03:33 +0000 (13:03 +0900)]
package version up to 1.18.1
Change-Id: Icc67dbafb9eb78699c53098d0aa88a2a543110a1
SooChan Lim [Fri, 4 May 2018 04:02:16 +0000 (13:02 +0900)]
change the utests to haltests
change all symbol and file name.
Change-Id: Id48ccad285938dfcbb8f136c71592806c120d47e
SooChan Lim [Mon, 30 Apr 2018 04:06:19 +0000 (13:06 +0900)]
package version up to 1.18.0
Change-Id: I9edc4541e61d361a235ae5d333a423712afa054b
SooChan Lim [Mon, 30 Apr 2018 04:05:28 +0000 (13:05 +0900)]
change the package name
change the libtbm-utests to the libtbm-haltests
Change-Id: If56366b88d0280d33eb609ac66d28e73c85834e8
Changyeon Lee [Wed, 25 Apr 2018 02:51:36 +0000 (11:51 +0900)]
fix build break
Change-Id: I2f83c749d48a25a9cb9a62443d02777340129826
Changyeon Lee [Mon, 23 Apr 2018 09:06:32 +0000 (18:06 +0900)]
hwc: add tdm_backend_register_func_hwc in tdm_backend.h
Change-Id: Idd35dc2d2cc92998c746433a9803ae78f7ae285b
SooChan Lim [Thu, 19 Apr 2018 04:21:48 +0000 (13:21 +0900)]
package version up to 1.17.1
Change-Id: I5a8481fa32f2a3c6a5d74becab4134907862d693
SooChan Lim [Thu, 19 Apr 2018 03:49:51 +0000 (12:49 +0900)]
add pthred_unlock
Change-Id: I101904deef6c6045e39d58c948a7ead76ecdc5e8
SooChan Lim [Fri, 13 Apr 2018 01:51:29 +0000 (10:51 +0900)]
package version up to 1.17.0
Change-Id: I40c285e4e703d8da3dcf997894885443f2001905
SooChan Lim [Fri, 30 Mar 2018 11:08:55 +0000 (20:08 +0900)]
hwc: redesign the hwc
change the frontend apis for hwc
change the backend apis for hwc
remove the useless codes
Change-Id: I7571dfb817140ebc25a3bbff77dffb7edae2ff35
SooChan Lim [Wed, 11 Apr 2018 04:22:34 +0000 (13:22 +0900)]
package version up to 1.16.13
Change-Id: Icacee006b6aad474889c50a0b615bd432db69e0c
Boram Park [Tue, 10 Apr 2018 23:52:09 +0000 (08:52 +0900)]
hwc: add omitted unlocks
Change-Id: I7631a2a6d9549a5361a05de2ccdc3a65b0452b6c
Boram Park [Mon, 9 Apr 2018 12:18:37 +0000 (21:18 +0900)]
display: find the correct output
To find a primary output, we have to check the connection status first.
If there is no connected output, this function will return the first output.
Change-Id: If386dcabc6524ce81a1f08c87082342a259278f3
Boram Park [Mon, 9 Apr 2018 12:15:59 +0000 (21:15 +0900)]
common: remove unuseful condition
output_get_capability can't be null at this function. checking null is
already done in other function.
Change-Id: I737ab197eba4763cc6afbfd65d8b8e8183c4a122
Boram Park [Mon, 9 Apr 2018 11:44:18 +0000 (20:44 +0900)]
common: fix syntax error
Change-Id: Ib6c52268e151511ba4aef5f15a84ac2adcba993b
Boram Park [Mon, 9 Apr 2018 11:43:57 +0000 (20:43 +0900)]
common: remove unuseful variable
Change-Id: I1f47f58fb65b5b18f08e64b790e11c4c195e1c32
Boram Park [Fri, 6 Apr 2018 07:42:06 +0000 (16:42 +0900)]
buffer: remove unuseful function
the behavior of tdm_buffer_remove_release_handler_internal is not clear.
even if commit is failed, the buffer release function seems to need to be called.
Change-Id: Idbf92ea109272d5556680ed87212095126d8b1cf
Boram Park [Fri, 6 Apr 2018 07:40:25 +0000 (16:40 +0900)]
common: add excluding coverage comments
Change-Id: I3608620a3fd494a1416dfb53df057241e074f114
Boram Park [Fri, 6 Apr 2018 07:38:59 +0000 (16:38 +0900)]
utests: add excluding coverage comments
Change-Id: I8533054065c261c059294bc3f8101f64d1623ab3
Boram Park [Tue, 3 Apr 2018 08:24:03 +0000 (17:24 +0900)]
event_loop: destroy clients before destroying display
Change-Id: I6e143aa8446d6cd1e3c5567604dac227b647d6fe
Boram Park [Tue, 3 Apr 2018 08:04:40 +0000 (17:04 +0900)]
doc: update dot file
Change-Id: I6cfe80a55147c2bf9ef22b4e095c2c2607dc43b0
Boram Park [Tue, 3 Apr 2018 08:04:00 +0000 (17:04 +0900)]
doc: fix carriage return
Change-Id: I850997b73174ff25e60b59c33e52b0b8cb89d1bc
Boram Park [Tue, 3 Apr 2018 07:46:34 +0000 (16:46 +0900)]
config: not export tdm_config function to backend
Change-Id: I2c8d162912c0971e6be5443c18535df81055eca7
Boram Park [Tue, 3 Apr 2018 07:26:13 +0000 (16:26 +0900)]
add plantuml, dot files
Change-Id: I99569149d5b46722426a97e8f59e39fa3db526bc
Boram Park [Mon, 2 Apr 2018 06:51:42 +0000 (15:51 +0900)]
thread: only allow a sync event from tdm-thread to display-thread
A sync-type event from display-thread to tdm-thread can't be handled.
If sync-type events happen in both threads at the same time,
it would make a deadlock issue.
Change-Id: Ic45207a173dfe9413f419506da1a6d36e86d06e3
Boram Park [Mon, 2 Apr 2018 06:37:57 +0000 (15:37 +0900)]
thread: not reset find_funcs table when deinit
tdm_thread_cb_call can be called after tdm_thread deinited.
Change-Id: Ic58fd0a1c194e1f977f7b9c3b26017bbfed0a57a
Boram Park [Mon, 2 Apr 2018 04:55:28 +0000 (13:55 +0900)]
config: move to src
Change-Id: If7c889f1704be1c0aa0d8bbd2f4b5785368feb60
Boram Park [Mon, 2 Apr 2018 03:59:08 +0000 (12:59 +0900)]
monitor: move to tools
Change-Id: I251df596f253a71293ad16b76b280e1a0372c129
Boram Park [Sun, 1 Apr 2018 22:49:01 +0000 (07:49 +0900)]
output: call output_change callbacks asynchronously
Change-Id: I72a8460101efd8e12a109c465ecd8249890b7801
Boram Park [Tue, 27 Mar 2018 04:29:44 +0000 (13:29 +0900)]
utests: use ut_tdm_display_handle_events for timeout
Change-Id: I4b672f599e77d5b8ed5ec8679cb7a5a9efa05d36
Boram Park [Fri, 30 Mar 2018 04:32:35 +0000 (13:32 +0900)]
package version up to 1.16.12
Change-Id: I79b8bfc47a794f715802d1cecf63bfbfa9b3ab18
Boram Park [Fri, 30 Mar 2018 04:04:00 +0000 (13:04 +0900)]
add LIST_FIRST_ENTRY, LIST_LAST_ENTRY macro
Change-Id: I98adf7df5ecb3dd94627e06bda3eb253033b289d
Boram Park [Fri, 30 Mar 2018 01:55:24 +0000 (10:55 +0900)]
utests: scale up to screen size
We have to make more TCs to test various different sizes later.
Change-Id: Ie36ef263d486d17905d0b73fcc58c23cef7a1d70
Boram Park [Fri, 30 Mar 2018 01:54:22 +0000 (10:54 +0900)]
utests: use TDM_CONFIG_KEY_DEBUG_DUMP to dump all tc's buffer
All tcs do tdm_display_init/deinit repeatly. "tdm-monitor -dump" can't be used.
So we'd better use env.
Change-Id: If518b97cc45e4d8620e89c2e513ad8056be1b8f9
Boram Park [Fri, 30 Mar 2018 01:51:55 +0000 (10:51 +0900)]
helper: try to dump all formats to a raw file
Change-Id: Id2aa867fe19930aa01d5c3d73e1156b28aa45dd5
Junkyeong Kim [Fri, 30 Mar 2018 02:47:22 +0000 (11:47 +0900)]
set to null current mode after output update if output disconnected
Change-Id: I27b78b4ea4cd63c1ba2ef480e2c3afab71d0140e
Signed-off-by: Junkyeong Kim <jk0430.kim@samsung.com>
Boram Park [Wed, 28 Mar 2018 05:58:02 +0000 (14:58 +0900)]
Revert "output: set output connection status if needed"
This reverts commit
ebb1cbd983e6251a7d4869538c75916a996ef3d9.
Change-Id: I8b7620d2e39f6500b7257ae0c0c2affecaf9b3a2
Boram Park [Wed, 28 Mar 2018 04:55:21 +0000 (13:55 +0900)]
package version up to 1.16.11
Change-Id: I83da899535b541cbe57c729e7b68651885676cd4
Boram Park [Mon, 26 Mar 2018 11:37:58 +0000 (20:37 +0900)]
display: rename to _tdm_display_setup
Change-Id: I2cb9b73d98e6b337a2c1b1b7279db6cfd3e36b3a
Boram Park [Mon, 26 Mar 2018 12:08:18 +0000 (21:08 +0900)]
utests: change pp scale test src buffer size
to test YUV buffers correctly
Change-Id: I4ae8ac621df9da577caa10a32c787d0f3da4759e
Boram Park [Mon, 26 Mar 2018 12:00:53 +0000 (21:00 +0900)]
utests: fix wrong input param
Change-Id: I99d930aba8cdbc080a935e0734601dee77a5f3bd
Boram Park [Mon, 26 Mar 2018 11:24:54 +0000 (20:24 +0900)]
utests: remove unuseful tcs
Change-Id: I5acfce9cc3ee9ef2f7d8b883c8e47d73f8ea5c22
Boram Park [Mon, 26 Mar 2018 11:22:46 +0000 (20:22 +0900)]
common: remove unuseful functions
Change-Id: I47dd2ac0cde4a5acb2d0d6a2ac4bf39c9af00aa2
Boram Park [Mon, 26 Mar 2018 11:19:10 +0000 (20:19 +0900)]
display: move function position
Change-Id: Icccd42165bd5b19f97ebb2b0e358318004ab346b
Junkyeong Kim [Mon, 26 Mar 2018 09:56:57 +0000 (18:56 +0900)]
utests: change pp scale test src buffer size
Change-Id: Ia80d1fea3d626132b4ff6ee7b638a58048d53a17
Signed-off-by: Junkyeong Kim <jk0430.kim@samsung.com>
Boram Park [Mon, 26 Mar 2018 06:23:30 +0000 (15:23 +0900)]
correct email address
Change-Id: I75c8d8e7b4937d5812021890d7f47e34bb219fec
Boram Park [Mon, 26 Mar 2018 05:29:53 +0000 (14:29 +0900)]
utests: fix build-error
Change-Id: Id0f1188f4ebbf46af4549151a33dfef63c043c54
Boram Park [Mon, 26 Mar 2018 05:16:46 +0000 (14:16 +0900)]
package version up to 1.16.10
Change-Id: I1029cb73e838a998f046f5987b97c9c6c2486139
Boram Park [Mon, 26 Mar 2018 05:11:32 +0000 (14:11 +0900)]
utests: fix warning message
Change-Id: Ied96807659fdc9189064edf1a6e2c1eaad20df36
Boram Park [Mon, 26 Mar 2018 03:00:27 +0000 (12:00 +0900)]
utests: fix getchar issue
Change-Id: I1e217b2594be0b46564626d8fe103a49fb3f6349
Boram Park [Mon, 26 Mar 2018 01:16:34 +0000 (10:16 +0900)]
event_loop: ensure freeing sources when deinit
Change-Id: I1eca94d1e572e7b6ce4d799c18f5d3d61a48e252
Boram Park [Fri, 23 Mar 2018 05:11:07 +0000 (14:11 +0900)]
package version up to 1.16.9
Change-Id: Icab648436c08d43e6d7bdf9592329b8a4aa84087
Boram Park [Fri, 23 Mar 2018 04:52:30 +0000 (13:52 +0900)]
rename to tdm_log_printf
Change-Id: I3e44a3e79c1e788d4a0c0d0c1f626f45c0a041a8
Boram Park [Fri, 23 Mar 2018 04:43:31 +0000 (13:43 +0900)]
output: print out the missed log
Change-Id: I862e3710709fbdad2a56902c263746e35589fc3d
Boram Park [Fri, 23 Mar 2018 04:39:32 +0000 (13:39 +0900)]
log: enhance debugging logs
Change-Id: I6fcf7705e60652ecd6987737aed4686de9569d65
Boram Park [Thu, 22 Mar 2018 09:35:13 +0000 (18:35 +0900)]
package version up to 1.16.8
Change-Id: I1dfa7c51b5e5912899ff079c9be1c939a108a138
Boram Park [Thu, 22 Mar 2018 09:31:41 +0000 (18:31 +0900)]
utests: change log level
Change-Id: Icfb0e00e9edf45fa8dfccc881274802d0e583da0
Boram Park [Thu, 22 Mar 2018 09:20:44 +0000 (18:20 +0900)]
common: remove redundant logs
Change-Id: I6843477d9227ec3db27200a1c82646acff3798f5
Boram Park [Thu, 22 Mar 2018 09:09:10 +0000 (18:09 +0900)]
dummy: consider vblank interval
Change-Id: Ifcee3acc89ec9938e1174a8a17bffb2f59aea68f
Boram Park [Thu, 22 Mar 2018 08:39:45 +0000 (17:39 +0900)]
output: set output connection status if needed
Change-Id: I8352ba1d63193ecf97ab64d568e8673451f9f766
Boram Park [Thu, 22 Mar 2018 04:44:29 +0000 (13:44 +0900)]
config: fix infinite loop
Change-Id: I8e74042c6cc711e64bc7f932dc2cb66be731872d
Boram Park [Tue, 20 Mar 2018 09:58:14 +0000 (18:58 +0900)]
utest: remove unuseful tcs
Change-Id: I84fa3d1f9839e9d70745766767a3bdc8323890fe
Boram Park [Tue, 20 Mar 2018 09:39:25 +0000 (18:39 +0900)]
package version up to 1.16.7
Change-Id: Ifda4cc084c2bd44ba1b1e279bddb0b914ad80cfa
Boram Park [Tue, 20 Mar 2018 08:09:23 +0000 (17:09 +0900)]
thread: sending the exit request instead of using pthread_cancel
To ensure that all operations in the tdm thread are done
Change-Id: I05aa6a1d187876522eeaaa2a694bdc2cc8673516
Boram Park [Tue, 20 Mar 2018 01:53:30 +0000 (10:53 +0900)]
common: add description for pp, capture capability
Change-Id: I3e11cb35c4a4f752282756e339e07e4f939437c0
Boram Park [Mon, 19 Mar 2018 10:46:30 +0000 (19:46 +0900)]
utests: show the result via a layer
Change-Id: I8ca6f448a2a124f0f2925ba7a26a652ebe57b6ec
Boram Park [Mon, 19 Mar 2018 06:58:54 +0000 (15:58 +0900)]
utests: set initialized value
Change-Id: I79b87512b495d271cbe1ed266aeebf9aa8ccff6b
Boram Park [Mon, 19 Mar 2018 06:58:38 +0000 (15:58 +0900)]
utests: check return value
Change-Id: I21868201523ec15af93d13bfc85fe17a8e770bf7
Boram Park [Mon, 19 Mar 2018 06:58:12 +0000 (15:58 +0900)]
tests: check return value
Change-Id: I15bc563500889e26f42600a6066dd0fe884fc29f
Boram Park [Mon, 19 Mar 2018 06:57:54 +0000 (15:57 +0900)]
mutex: remove pthread_mutex_trylock
We don't need to call pthread_mutex_trylock to call pthread_mutex_unlock.
Just call pthread_mutex_unlock to ensure all mutexes are locked.
Change-Id: Id43c9fdddaa400454f9d462430ae90ecf25615c8
Boram Park [Mon, 19 Mar 2018 10:46:12 +0000 (19:46 +0900)]
capture: correct debugging logs
Change-Id: I00f06b8d917e135c269bc581605ea131f6f5d12a
Boram Park [Mon, 19 Mar 2018 10:46:00 +0000 (19:46 +0900)]
pp: correct debugging logs
Change-Id: I599a9e78919b0a0195f0ccee3c0b41544614b7fa
Boram Park [Mon, 19 Mar 2018 05:10:22 +0000 (14:10 +0900)]
pp: remove unuseful pp capabilities
scale and transform seems as the default pp capabilities.
Change-Id: I68eff0222105f1e255210ea1ebe58a22599af32a
Boram Park [Tue, 20 Mar 2018 01:11:32 +0000 (10:11 +0900)]
output: enhance debugging logs
Change-Id: I01db98634347826e9a3f9b22eafa77a233d86a18
Boram Park [Tue, 20 Mar 2018 01:10:22 +0000 (10:10 +0900)]
buffer: enhance debugging logs
Change-Id: If1fda435f672768ab0a46a1c4e0f18dcc991fad8
Boram Park [Mon, 19 Mar 2018 04:53:11 +0000 (13:53 +0900)]
capture: enhance debugging logs
Change-Id: I54b5cc0ffb52ea8abc11b26b5763064524d960f7
Boram Park [Mon, 19 Mar 2018 04:53:05 +0000 (13:53 +0900)]
pp: enhance debugging logs
Change-Id: I447c3e9f8a1f359511976479d06d39c31f964292
Boram Park [Mon, 19 Mar 2018 04:30:33 +0000 (13:30 +0900)]
layer: enhance debugging logs
Change-Id: Iccea69b432837b72158a2a864b2f6d00871a95ae
Boram Park [Mon, 19 Mar 2018 04:29:41 +0000 (13:29 +0900)]
layer: add tdm_layer_get_index()
Change-Id: Id0e660ba20bd586a8368c4fc4256aa4a01ea246e
Boram Park [Fri, 16 Mar 2018 08:20:02 +0000 (17:20 +0900)]
package version up to 1.16.6
Change-Id: Ic5461303138ef6207b2fcafaaa17fd45cdbf33ff