Yeongjong Lee [Thu, 30 Jan 2020 11:34:14 +0000 (20:34 +0900)]
efl_ui_widget: remove unused atspi,highlighted/atspi,unhighlighted event in eo
atspi,highlighted/atspi,unhighlighted event is used for only legacy.
They don't need to define in eo file.
@tizen_fix
Change-Id: I88dde7b69be7db3583482f6882d6099692eeb5fe
Jongmin Lee [Wed, 29 Jan 2020 22:14:18 +0000 (07:14 +0900)]
Revert "eolian: enforce that list<> can only be used with @beta API."
This reverts commit
f67fe75517736045549fb61a530856f0709f5d9d.
Ali Alzyod [Wed, 29 Jan 2020 18:30:39 +0000 (19:30 +0100)]
efll.ui.internal_text_interactive: remove useless condition
Summary: Remove useless condition and unreachable return value
Reviewers: woohyun, segfaultxavi, bu5hm4n
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11231
Ali Alzyod [Wed, 29 Jan 2020 15:34:27 +0000 (16:34 +0100)]
config: replace evil tabs with spaces
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11232
Cedric BAIL [Thu, 2 Jan 2020 23:41:36 +0000 (15:41 -0800)]
eolian: enforce that list<> can only be used with @beta API.
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Differential Revision: https://phab.enlightenment.org/D11050
Felipe Magno de Almeida [Wed, 29 Jan 2020 15:22:15 +0000 (16:22 +0100)]
C#: Fix using beta for lists and hashes in tests
Reviewers: segfaultxavi, bu5hm4n
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11235
Woochanlee [Wed, 29 Jan 2020 14:01:51 +0000 (09:01 -0500)]
ecore_wl2: Fix doc(delete tags).
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11226
Christopher Michael [Wed, 29 Jan 2020 14:01:06 +0000 (09:01 -0500)]
tests/ecore_wl2: Fix check for Enlightenment compositor
ref T8016
Woochanlee [Wed, 29 Jan 2020 14:00:08 +0000 (09:00 -0500)]
tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions.
Summary:
Add dummy tests for below functions.
Updates will be... when there is a better verification method.
ref T8016
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8016
Differential Revision: https://phab.enlightenment.org/D11214
JunsuChoi [Wed, 29 Jan 2020 12:40:28 +0000 (21:40 +0900)]
vg_common_json: Supports transform properties
Summary:
Supports scale, position, and rotation properties
related to transform among properties supported by value provider.
Test Plan:
Remove 'json' in evas-loaders-disabler
build
elementary_test -to "value provider"
(path : layer.box1)
Depends on D11213
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11129
JunsuChoi [Wed, 29 Jan 2020 12:39:53 +0000 (21:39 +0900)]
Efl.Gfx.Vg.Value_Provider: Change transform value type to Matrix4
Summary:
Change type to matrix4 for 3-axis use when using value provider.
Depends on D11159
Test Plan: N/A
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11213
Proht [Sat, 25 Jan 2020 19:06:33 +0000 (19:06 +0000)]
edje_legacy: avoid calling any functions if part is NULL
This avoids calling any functions like _edje_fetch if part is NULL, because it's unnecessary. This does not fix any null pointers, the EINA_SAFE* macros are just used for convenience.
Differential Revision: https://phab.enlightenment.org/D11189
Ali Alzyod [Tue, 28 Jan 2020 17:04:51 +0000 (17:04 +0000)]
efl.ui.textbox: replace strncmp with strcmp for Part
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11218
Ali Alzyod [Tue, 28 Jan 2020 16:36:52 +0000 (16:36 +0000)]
efl.ui.textbox: replace ecore_job with Efl_Future
This patch will replace the use of ecore_job with Efl_Future
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11216
Ali Alzyod [Tue, 28 Jan 2020 16:54:32 +0000 (16:54 +0000)]
efl.ui.textbox: clean up all evas_object related functions from stable methods/interfaces
This patch will:
- Replace all Evas callbacks with unified ones.
- Replace evas_object* methods with unified ones (For **stabilized** methods and interfaces)
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11217
Marcel Hollerbach [Wed, 29 Jan 2020 09:45:24 +0000 (10:45 +0100)]
Revert "eolian: enforce that list<> can only be used with @beta API."
This reverts commit
6b110e578d24b2a99c4c1b158433327a0a43ce1a.
This breaks bindings compilation.
Marcel Hollerbach [Wed, 29 Jan 2020 09:45:06 +0000 (10:45 +0100)]
Revert "mono-test: Fix build break"
This reverts commit
594f00c815d8ee15878071b23f041e5092abe7c2.
This breaks tests
Xavi Artigas [Wed, 29 Jan 2020 09:23:08 +0000 (10:23 +0100)]
mono-test: Fix build break
Recent
6b110e578d24b2a99c4c1b158433327a0a43ce1a forbids list<> in
stable contexts.
Subodh Kumar [Fri, 24 Jan 2020 14:49:03 +0000 (14:49 +0000)]
edje_entry: Add matching tag.
When textblock has several other tags
which are closing as </>, textblock
is not able to find the matching one.
@fix
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D11172
Cedric BAIL [Fri, 3 Jan 2020 19:22:12 +0000 (11:22 -0800)]
elementary: do not use list<> in Efl.Ui.Focus_Manager.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11051
Cedric BAIL [Thu, 2 Jan 2020 23:41:36 +0000 (15:41 -0800)]
eolian: enforce that list<> can only be used with @beta API.
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Differential Revision: https://phab.enlightenment.org/D11050
Cedric BAIL [Thu, 2 Jan 2020 23:27:56 +0000 (15:27 -0800)]
efl: mark @beta Efl.Gfx.Event.Render_Post.
This is an oversight during last release. It should not affect anyone as
all the user of this type are marked @beta themself.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Differential Revision: https://phab.enlightenment.org/D11049
Cedric BAIL [Thu, 2 Jan 2020 23:26:44 +0000 (15:26 -0800)]
evas: prepare separation of POST_RENDER event from being an unified and legacy event at the same time.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Differential Revision: https://phab.enlightenment.org/D11048
JunsuChoi [Wed, 29 Jan 2020 05:56:05 +0000 (14:56 +0900)]
eina_matrix: Add eina_matrix4 operator(translate, rotate, scale)
Summary:
Add an operator related to the 3D transform in eina_matrix.
enum eina_matrix_axis
EINA_MATRIX_AXIS_X
EINA_MATRIX_AXIS_Y
EINA_MATRIX_AXIS_Z
eina_matrix4_translate
eina_matrix4_scale
eina_matrix4_rotate
eina_matrix4_transpose
Test Plan: src/tests/eina/eina_test_matrix.c
Reviewers: Hermet, bu5hm4n, kimcinoo, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11159
Yeongjong Lee [Wed, 29 Jan 2020 04:46:37 +0000 (13:46 +0900)]
eolian_mono: blacklist c-only internal APIs
Summary: This patch prevent generating c-only internal APIs. C# doesn't need c-only APIs.
Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: felipealmeida, Jaehyun_Cho, woohyun
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11151
Change-Id: Id4d1b46952645ff4fb0242a11648e03c4995e205
Yeongjong Lee [Wed, 29 Jan 2020 04:45:56 +0000 (13:45 +0900)]
eolian_mono: change property name from args to Args
Summary: PascalCasing is always used for property names.
Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: woohyun, felipealmeida, segfaultxavi
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11149
Yeongjong Lee [Wed, 29 Jan 2020 04:13:10 +0000 (13:13 +0900)]
eolian_mono: generate Efl.IPlayer.PlaybackPosition again
Summary: There is no reason that `efl_player_playback_position_get` is in blacklist..
Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11152
Change-Id: I6da9a0882b966264e39973fb36d5570c056cf1ba
JunsuChoi [Tue, 28 Jan 2020 15:36:33 +0000 (16:36 +0100)]
Efl.Player: Move autoplay/playback_loop from Efl.Ui.Vg_Animation
Summary:
Move autoplay and playback_loop method from Efl.Ui.Vg_Animation/
and The playback_loop changed from looping
because it conflict with the efl_ui_scrollable's symbol.
Efl.Ui.Image and Efl.Ui.Image_Zoomable is needed implements about this method.
So it temporarily set the @empty marker.
ref T8476
Test Plan:
elementary_test -to "Vector Graphics Animation"
check to 'loop'
Reviewers: Hermet, bu5hm4n, zmike, Jaehyun_Cho, jsuya
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, woohyun, kimcinoo
Tags: #efl
Maniphest Tasks: T8476
Differential Revision: https://phab.enlightenment.org/D11212
Carsten Haitzler (Rasterman) [Tue, 28 Jan 2020 11:17:51 +0000 (11:17 +0000)]
lz4 - sync to latest current lz4 upstream source
Carsten Haitzler (Rasterman) [Tue, 28 Jan 2020 11:00:03 +0000 (11:00 +0000)]
add build conf for win and osx
not sure if they totally work - but based on ci scripts and build
scripts that peolpe do use.
Carsten Haitzler (Rasterman) [Tue, 28 Jan 2020 08:28:10 +0000 (08:28 +0000)]
webp - promote to default on
i just noticed a pattern... we recommend in our sample confs ... to
not disable webp. why keep doing that and why not just make it a dep
on by default you need to explicitly disable? make lives easier and
less complex. it was a good exercise to write these as it points this
out... :)
Yeongjong Lee [Tue, 28 Jan 2020 05:46:10 +0000 (14:46 +0900)]
eolian_mono: make struct immutable
Summary:
Immutable value type is recommeneded for struct type in cs world.
`DO NOT define mutable value types.`
(see, https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/struct)
Also, this patch include refactoring of generated struct types.
1. Change field type to property type that have only getter. it will fix CA1051(ref T8397).
2. Remove internal NativeStruct. there is private field for marshalling struct instead.
3. Fix some test cases that change value inside struct. because struct is immutable.
Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: woohyun, felipealmeida, Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8397
Differential Revision: https://phab.enlightenment.org/D11146
Marcel Hollerbach [Mon, 27 Jan 2020 21:49:46 +0000 (06:49 +0900)]
efl_ui_textbox / efl_ui_image_zoomable: remove duplicated code
Summary:
these implementations were totally equal to what is there in
efl_ui_layout. No point in keeping them. (Note, entry_edje is equal to
resize_obj)
ref T8522
Reviewers: segfaultxavi, cedric, zmike, woohyun
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8522
Differential Revision: https://phab.enlightenment.org/D11141
Yeongjong Lee [Tue, 28 Jan 2020 12:08:20 +0000 (21:08 +0900)]
efl_mono: remove "Event" from event name in efl_csharp_application.cs
"Event" is removed from event name in efl_csharp_application.cs.
This patch is required for
b94538d474a9a3473254a68f54bf4099e8d64095
@tizen_only
Change-Id: I3ffa19e5a13335fb293e6906b8a9f613ce3e5737
Hermet Park [Tue, 28 Jan 2020 09:04:05 +0000 (18:04 +0900)]
canvas vector: fix incorrect caching hit.
animated vector(lottie) caches current playing resource data,
for resuing if it's possible, but it must take care of the drawing size.
Previous logic missed that part, fixed it.
Change-Id: Ic572f4baf330e8a8a09d7ce13f8b12fd84f41b92
Woochanlee [Tue, 28 Jan 2020 07:41:47 +0000 (16:41 +0900)]
ecore_wl2 : Fix keyboard repeate rate formula to Tizen form.
Change-Id: I76bd9bc22d92e4562a3de4f729a805048a441b61
Jihoon Kim [Tue, 28 Jan 2020 01:47:24 +0000 (10:47 +0900)]
edje: Use transaction start and end enum for freezing and thaw
Change-Id: I965999e8c005df750725708d7b89ae3ce91369c2
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
InHong Han [Fri, 23 Mar 2018 06:26:03 +0000 (15:26 +0900)]
edje: Add missing comment
Change-Id: I0aa371a5544ca3007c49291306e62259a3eece7f
InHong Han [Thu, 22 Mar 2018 06:39:36 +0000 (15:39 +0900)]
edje: modified not to send cursor position until the transaction isn't terminated
Change-Id: Iac0183e06b705a54becf8698595c26924d5fa55a
SangHyeon Jade Lee [Wed, 22 Jan 2020 10:24:23 +0000 (19:24 +0900)]
Elementary : add transition_duration_factor in legacy API
Change-Id: I55e7d4d98ba4493f8a987fe22b651f43ca6c61d6
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
godlytalias14573465 [Tue, 21 Jan 2020 11:02:52 +0000 (16:32 +0530)]
[Genlist] Optimization of first item get
Change-Id: I18eae42f7ced7803ea038c01a001239e134ec671
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
Prasoon Singh [Mon, 9 Dec 2019 15:36:05 +0000 (21:06 +0530)]
access: Do not accept children with unacceptable role
Highlight frame on tap does not appear because of obj
with unacceptable role being returned.
Change-Id: I08011738ef43d9574c2789d02349b008a2c0c6a8
Signed-off-by: Prasoon Singh <prasoon.16@samsung.com>
Jongmin Lee [Mon, 27 Jan 2020 21:16:53 +0000 (06:16 +0900)]
spec: disable jp2k evas loader
Change-Id: I9c622a2ccc230608d7370cd97c5f3b83dcce8983
Carsten Haitzler (Rasterman) [Mon, 27 Jan 2020 20:03:13 +0000 (20:03 +0000)]
ecore_con - try an extended bsd workaround by keeping lock open
so keep lock file open for whole duration the socket is bound because
bsd seesm to not do this right... :( (2 things can call bind() on the
same socket with 1 of them block forever).
João Paulo Taylor Ienczak Zanette [Mon, 27 Jan 2020 16:51:53 +0000 (17:51 +0100)]
csharp: Escape contents of struct fields' value tag.
Summary:
In structs' definition, field `<value>` tags weren't scaping
characters, so characters like "&" would lead to invalid XML errors.
Fixes T8588.
Test Plan: Run ninja test.
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8588
Differential Revision: https://phab.enlightenment.org/D11202
Marcel Hollerbach [Mon, 27 Jan 2020 16:23:30 +0000 (11:23 -0500)]
ecore_wl2: do not silently return
Summary:
if we are getting a up event after our touch window object is not
focused anymore, then the compositor has sent a invalid up. Beeing
explicit here is important, otherwise we might leak a pressed finger on
the touchscreen.
Depends on D11199
Reviewers: zmike, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11200
Marcel Hollerbach [Mon, 27 Jan 2020 16:23:13 +0000 (11:23 -0500)]
ecore_wl2: only ungrab/grab on last/first down/up event
Summary: otherwise we are silently forgetting about up events.
Reviewers: zmike, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11199
ali [Fri, 31 May 2019 23:34:50 +0000 (23:34 +0000)]
evas_textblock: <ps> tag respects multiline propertie
previously multi-line property does not effect <ps> tag.
now <ps> is treated visually like <br> when multiline is set to EINA_FALSE
this issue was that each new paragraph will create new line regardless of multi line property value, now only first paragraph will create new line if multi-line property is false, and other paragraphs will use same line
this will also fix the following patch https://phab.enlightenment.org/D8603
And both will use same test suite code
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9064
Carsten Haitzler (Rasterman) [Sat, 25 Jan 2020 20:16:47 +0000 (20:16 +0000)]
evas - loaders - jp2k - re-enable in the build after it was lost
it seems to have been forgotten. bring it back to building again
@fix
Carsten Haitzler (Rasterman) [Sat, 25 Jan 2020 15:47:22 +0000 (15:47 +0000)]
add some sample configureations for a few os's
the idea is - if the configure fails .. provide the dep it's asking
for. that simple. the rest of the build is the same (ninja -C build
etc.)
Carsten Haitzler (Rasterman) [Sat, 25 Jan 2020 15:05:01 +0000 (15:05 +0000)]
pythoin scripts - use /usr/bin/env to fond python3 like the others
Carsten Haitzler (Rasterman) [Sat, 25 Jan 2020 05:08:01 +0000 (05:08 +0000)]
README - update the removal of bullet and libxp and mention harfbuzz
Cedric BAIL [Thu, 2 Jan 2020 23:23:14 +0000 (15:23 -0800)]
eolian: move list<> tests to be @beta and preserve enough meaningful that are not @beta.
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11046
Cedric BAIL [Thu, 2 Jan 2020 23:24:12 +0000 (15:24 -0800)]
eolian_cxx: move tests of list<> to be protected by @beta.
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11047
Simon Tischer [Fri, 24 Jan 2020 07:40:48 +0000 (08:40 +0100)]
theme: fix close issue for notification popup
This gives back the ability to close the notification.
fixes T8316
Hosang Kim [Thu, 23 Jan 2020 14:03:08 +0000 (09:03 -0500)]
efl_ui_layout: send theme signal when style is already updated.
Summary:
If you run below code, text is invisible.
```
efl_add(EFL_UI_BUTTON_CLASS, box,
efl_ui_widget_style_set(efl_added, "anchor"),
efl_text_set(efl_added, "anchor style"),
efl_pack_end(box, efl_added));
```
But below code is working well.
```
efl_add(EFL_UI_BUTTON_CLASS, box,
efl_text_set(efl_added, "anchor style"),
efl_ui_widget_style_set(efl_added, "anchor"),
efl_pack_end(box, efl_added));
```
Test Plan: run efl_ui_theme_example_01
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11118
Ali Alzyod [Thu, 23 Jan 2020 11:31:57 +0000 (12:31 +0100)]
efl.canvas.textblock: annotate obstacle methods as beta
Summary:
We decided to annotate these methods as beta
**obstacle_add**
**obstacle_del**
**obstacles_update**
Reviewers: woohyun, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8460
Differential Revision: https://phab.enlightenment.org/D11136
Marcel Hollerbach [Thu, 23 Jan 2020 10:14:33 +0000 (11:14 +0100)]
ecore_wl2: fix compilation
Xavi Artigas [Thu, 23 Jan 2020 09:34:29 +0000 (10:34 +0100)]
docs: Slight improvements to eina_types.eot Matrix docs
Reference D11158
JunsuChoi [Thu, 23 Jan 2020 09:15:23 +0000 (10:15 +0100)]
Eolian eina_types: Add Eina.Matrix4 type
Summary: for using in eolian
Test Plan: N/A
Reviewers: Hermet, bu5hm4n, segfaultxavi
Reviewed By: bu5hm4n, segfaultxavi
Subscribers: bu5hm4n, segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11158
Ali Alzyod [Thu, 23 Jan 2020 08:54:11 +0000 (08:54 +0000)]
efl.ui.textbox: move file implementation in to internal class
We want to keep implementation for file interface in a safe place and remove it from our side world (eo).
This is a simple copy-paste, from efl.ui.textbox into efl_ui_internal_text_interactive
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11153
JunsuChoi [Thu, 23 Jan 2020 08:36:41 +0000 (17:36 +0900)]
Revert "efl_ui_image: Call unload file when calling file_set"
Summary:
This reverts commit
93bd97025983e48ae8048d0c63b5d8b314f1de42.
efl.ui.image using prev and current inner image object.
Unloading the efl.ui.image class can be unloaded up to the prev image.
And because efl.ui.image is using the image caching feature together,
it may get unexpected errors. Therefore, revert this patch.
Test Plan: N/A
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11157
Ali Alzyod [Wed, 22 Jan 2020 07:33:58 +0000 (07:33 +0000)]
efl_text_interactive: selection enhancment
1- Implement setting selection range programmatically by modifying selection cursors from **efl_text_interactive_selection_cursors_get**
2- Add setter with **efl_text_interactive_selection_cursors_set** to set the range at once (modify start and end)
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: WooHyun Jung <wh0705.jung@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10968
Ali Alzyod [Thu, 23 Jan 2020 07:21:22 +0000 (16:21 +0900)]
evas_object_textblock: treat variation sequence as single run
Summary:
Variation sequence treated as a single run, if we found one, we keep looking adding to the same run, but if it is not, then we need to start a new one.
Before:
{
F3826735}
After:
{
F3826736}
Test Plan:
```
#include <stdio.h>
#include <Elementary.h>
/*
gcc -o example test.c `pkg-config --cflags --libs elementary`
*/
EAPI_MAIN int
elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
{
Evas_Object *win, *en;
elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);
win = elm_win_util_standard_add("emoji-example", "emoji-example");
elm_win_autodel_set(win, EINA_TRUE);
en = elm_entry_add(win);
elm_entry_scrollable_set(en, EINA_TRUE);
evas_object_size_hint_weight_set(en, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(en, EVAS_HINT_FILL, EVAS_HINT_FILL);
elm_object_text_set(en, "<font_size=25>☪☪️☪ê°€</font_size>");
evas_object_show(en);
elm_object_content_set(win, en);
evas_object_resize(win, 400, 200);
evas_object_show(win);
elm_run();
return 0;
}
ELM_MAIN()
```
Reviewers: woohyun, bowonryu
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8542
Differential Revision: https://phab.enlightenment.org/D11096
Ali Alzyod [Thu, 23 Jan 2020 07:07:42 +0000 (16:07 +0900)]
efl.text.interactive: use Eina_Int_Range for selection range event
Summary:
1- add new Eina type (Eina_Int_Range). which represents int range (start, Len).
2- Use this type instead of Efl.Text_Range with selection events.
Reviewers: cedric, woohyun, bu5hm4n, segfaultxavi, zmike
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8570
Differential Revision: https://phab.enlightenment.org/D11128
Jaehyun Cho [Thu, 23 Jan 2020 03:55:16 +0000 (12:55 +0900)]
efl_ui_spotlight: rename Stack_Manager to Fade_Manager
Summary:
Since Stack_Manager displays fade in/out transition effects, the class
name is renamed from Stack_Manager to Fade_Manager.
Depends on D11142
Reviewers: segfaultxavi, bu5hm4n, zmike
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11143
Jaehyun Cho [Thu, 23 Jan 2020 03:55:12 +0000 (12:55 +0900)]
efl_ui_spotlight: rename Manager_XXX and Indicator_XXX
Summary:
In spotlight classes, "Manager" and "Indicator" are used as prefix in
the class names.
e.g. Efl.Ui.Spotlight.Manager_Plain, Efl.Ui.Spotlight.Indicator_Icon
However, those classes are basically manager and indicator classes with
different features. Therefore, "Manager" and "Indicator" should be used
as postfix in the class names.
e.g. Efl.Ui.Spotlight.Plain_Manager, Efl.Ui.Spotlight.Icon_Indicator
However, for the easier usage of C APIs, c_prefix of those classes are
remained to be "efl_ui_spotlight_manager_xxx" and
"efl_ui_spotlight_indicator_xxx".
Reviewers: segfaultxavi, bu5hm4n, zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11142
Carsten Haitzler (Rasterman) [Wed, 22 Jan 2020 23:31:30 +0000 (23:31 +0000)]
edje - store original size in edje struct and dont exceed max size
evas can tell us max texture size. in edje when we have image sets
(multiple images that make up mipmaps effectively for a logical
image), we now can avoid choosing an image that exceeds max texture
size. this actually fixes bugs i have seen on the rpi3 which has a max
texture size of 2048 which makes it easy to exceed it with wallpapers
or even terminology's default theme.
so combo of new feature and fix... but requires a rebuild of the edj
files...
@feat + @fix
Yeongjong Lee [Wed, 22 Jan 2020 22:30:13 +0000 (07:30 +0900)]
csharp: cleanup concrete class
Summary:
Concrete class is only used to call static member of NativeMethod. they don't
need any inheritance and implementation of c functions.
Depends on D9893
Test Plan: ninja test
Reviewers: lauromoura, felipealmeida
Subscribers: Jaehyun_Cho, woohyun, segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9894
ali [Wed, 22 Jan 2020 21:54:44 +0000 (06:54 +0900)]
eina: add new range Data type
Summary:
Introduce new data type (Eina.Range) which represent range (part of series)
**eina_range_max_get**
**eina_range_intersect**
**eina_range_union**
**eina_range_contains**
**eina_range_equal**
Reviewers: cedric, woohyun, bu5hm4n, segfaultxavi, zmike
Reviewed By: woohyun
Subscribers: vtorri, cedric, #committers, #reviewers
Tags: #efl
Maniphest Tasks: T8570
Differential Revision: https://phab.enlightenment.org/D11133
Jaehyun Cho [Thu, 23 Jan 2020 11:25:30 +0000 (20:25 +0900)]
efl_mono: remove "Event" from event name in GenericModel.cs
"Event" is removed from event name in GenericModel.cs.
This patch is required for
b94538d474a9a3473254a68f54bf4099e8d64095
@tizen_only
Change-Id: I69afed831b7546d05c985565956963f9c3499a94
Yeongjong Lee [Thu, 23 Jan 2020 04:45:41 +0000 (13:45 +0900)]
efl_ui_win: add condition to check minimized change before its event call
This patch prevent emitting EFL_UI_WIN_EVENT_MINIMIZED_CHANGED when ch_witdrawn
is true. ch_witdrawn is not related to MINIMIZED_CHANGED event.
@tizen_fix
Change-Id: I7ce849a33405a6f5fc164b37e63b6713f7eab816
Yeongjong Lee [Thu, 23 Jan 2020 04:42:45 +0000 (13:42 +0900)]
eolian_mono: replace event name to prevent name conflict
Efl.Loop.Quit => Efl.Loop.LoopQuit
Efl.Loop.Idle => Efl.Loop.Idling
@tizen_fix
Change-Id: I8f44dfc335c57c0b48569a22dd6349a3ab9e6303
Jaehyun Cho [Wed, 22 Jan 2020 11:27:46 +0000 (20:27 +0900)]
eolian_mono: add blacklist events which have same names with properties
Some events have the same name with properties.
Since event and property names should not be same in a C# class, those
events are added to blacklist.
Since the events "normal" and "minimized" in Efl.Ui.Win are going to be
replaced with "minimized,changed", the event "normal" is added to
blacklist as well.
@tizen_only
Change-Id: Icf78727ae02697142c3e9a5a61d5919579c8e66a
Yeongjong Lee [Wed, 22 Jan 2020 11:49:53 +0000 (20:49 +0900)]
efl_ui_win: add minimized,changed event to avoid name conflict in bindings
There is name conflict between `minimized` method and `minimized` event in bindings.
To solve this problem, `minimized,changed` event will be used instead of `minimized`.
@tizen_fix
Change-Id: I8157f755a9b0070fc4860b7de25e0e44b6347d7d
Jongmin Lee [Wed, 22 Jan 2020 21:26:56 +0000 (06:26 +0900)]
build: resolve migration build error
Change-Id: I0d630cb27c7c5df2f09c1e175feaab9cc55d237c
JunsuChoi [Wed, 22 Jan 2020 16:57:26 +0000 (11:57 -0500)]
efl_ui_image: Call unload file when calling file_set
Summary:
We have checked that unload is not called even if different files
call again elm_image_file_set on the same object.
If file_set is called repeatedly, I think a potential error can occur.
So, modify to call unload when doing file_set by referring to efl_ui_zoomable.
Test Plan: N/A
Reviewers: Hermet, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11148
Marcel Hollerbach [Fri, 17 Jan 2020 13:40:58 +0000 (14:40 +0100)]
evas_object_box: fix invalidator
the iteration over the content of the box did never cleanup the
children pointer, which resulted in buggy behavior.
This fixes test suite crashes with freeq debugging on.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11123
Christopher Michael [Wed, 22 Jan 2020 13:37:33 +0000 (08:37 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_input_keyboard_repeat functions
ref T8016
Woochanlee [Wed, 22 Jan 2020 12:41:39 +0000 (07:41 -0500)]
tests/ecore_wl2: Add tests for move, resize, resizing_get functions.
Summary:
Add
ecore_wl2_window_move
ecore_wl2_window_resize
ecore_wl2_window_resizing_get
ref T8016
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8016
Differential Revision: https://phab.enlightenment.org/D11150
Woochanlee [Wed, 22 Jan 2020 12:37:23 +0000 (07:37 -0500)]
ecore_wl2: Add ecore_wl2_input_default_input_get() API.
Summary: Gets default input which created by display.
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11132
Woochanlee [Wed, 22 Jan 2020 12:37:11 +0000 (07:37 -0500)]
ecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API.
Summary:
Add API to set input's keyboard repeat.
get API was already there.
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11131
Jaehyun Cho [Wed, 22 Jan 2020 02:33:41 +0000 (11:33 +0900)]
Revert "efl_mono: remove class ExtensionTag"
Extension Methods' classes have methods with same names and parameters.
e.g. Text<T>(this Efl.Ui.ItemFactory<T> fac)
Although the where clause contains different classes, they cannot be
identified as different methods by C# compiler.
e.g. Text<T>(this Efl.Ui.ItemFactory<T> fac) where T : Efl.Ui.Button
e.g. Text<T>(this Efl.Ui.ItemFactory<T> fac) where T : Efl.Ui.Check
As a result, to avoid ambiguous methods, ExtensionTag should be used as
a second parameter of each method.
e.g. Text<T>(this Efl.Ui.ItemFactory<T> fac, ExtensionTag<Efl.Ui.Button, T>magic = null) where T : Efl.Ui.Button
e.g. Text<T>(this Efl.Ui.ItemFactory<T> fac, ExtensionTag<Efl.Ui.Check, T>magic = null) where T : Efl.Ui.Check
This reverts commit
76631f502a8234c04ed8124bfdebe62ed5bdf954.
Yeongjong Lee [Wed, 22 Jan 2020 00:40:18 +0000 (09:40 +0900)]
eolian_mono: avoid generating set-only property
Summary:
According to Property Design Guidelines of MS, set-only properties are not recommeneded.
(see more, https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/property)
Furthermore, there is stylecop warnings(CA1044)
ref T8396
List of removed set-only properies.
```
Efl.Access.Editable.IText.TextContent { set; }
Efl.App.CommandArray { set; }
Efl.App.CommandString { set; }
Efl.Canvas.Filter.IInternal.FilterChanged { set; }
Efl.Canvas.Filter.IInternal.FilterInvalid { set; }
Efl.Canvas.ImageInternal.FilterChanged { set; }
Efl.Canvas.ImageInternal.FilterInvalid { set; }
Efl.Canvas.Textblock.FilterChanged { set; }
Efl.Canvas.Textblock.FilterInvalid { set; }
Efl.Canvas.Vg.Image.Data { set; }
Efl.Canvas.Vg.Node.CompMethod { set; }
Efl.Core.ICommandLine.CommandArray { set; }
Efl.Core.ICommandLine.CommandString { set; }
Efl.Exe.CommandArray { set; }
Efl.Exe.CommandString { set; }
Efl.Ui.AlertPopup.Button { set; }
Efl.Ui.Collection.MatchContent { set; }
Efl.Ui.CollectionView.MatchContent { set; }
Efl.Ui.IScrollable.MatchContent { set; }
Efl.Ui.ImageZoomable.MatchContent { set; }
Efl.Ui.Panel.MatchContent { set; }
Efl.Ui.PositionManager.Grid.DataAccess { set; }
Efl.Ui.PositionManager.Grid.ScrollPosition { set; }
Efl.Ui.PositionManager.Grid.Viewport { set; }
Efl.Ui.PositionManager.IDataAccessV1.DataAccess { set; }
Efl.Ui.PositionManager.IEntity.ScrollPosition { set; }
Efl.Ui.PositionManager.IEntity.Viewport { set; }
Efl.Ui.PositionManager.List.DataAccess { set; }
Efl.Ui.PositionManager.List.ScrollPosition { set; }
Efl.Ui.PositionManager.List.Viewport { set; }
Efl.Ui.Scroll.Manager.MatchContent { set; }
Efl.Ui.Scroll.Manager.Pan { set; }
Efl.Ui.Scroller.MatchContent { set; }
Efl.Ui.Spotlight.Manager.Size { set; }
Efl.Ui.Textbox.TextContent { set; }
Efl.Ui.Widget.ResizeObject { set; }
Efl.Ui.Win.PropFocusSkip { set; }
```
Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: woohyun, felipealmeida, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8396
Differential Revision: https://phab.enlightenment.org/D11138
Yeongjong Lee [Mon, 20 Jan 2020 22:00:44 +0000 (07:00 +0900)]
Revert "csharp: Property Indexer implementation"
Summary:
This reverts commit
0954e501fd4008c40b3848de1f2c91bcd53b2f71.
According to Framework Design Guidelines of MS, most of indexed properties are
not recommended in EFL#.
(see, https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/property)
It is better to leave properties which have a key as methods.
Reviewers: woohyun, felipealmeida
Reviewed By: woohyun
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11114
Change-Id: I972878e39ea30c56ce82b0d60a7f82ec4b06b76c
Chris Michael [Tue, 21 Jan 2020 18:04:06 +0000 (13:04 -0500)]
tests/ecore_wl2: Fix issue of tests running without a Wayland display
This fixes an issue with CI where these tests would try to run without
a Wayland compositor. This was missed during review, Thanks Marcel for
pointing this out.
ref T8016
Marcel Hollerbach [Tue, 21 Jan 2020 16:11:31 +0000 (17:11 +0100)]
Revert "efl_text_interactive: selection enhancment"
This reverts commit
09f0d66d90e4db5f879f4c998e8a07b26fa749fc.
This breaks CI, and tests do not pass anymore, hence no other revision
can be verified.
The revision is reopened. lets take a second look at this.
Woochanlee [Tue, 21 Jan 2020 13:13:52 +0000 (08:13 -0500)]
tests/ecore_wl2: Code clean up and Add, Modify TCs.
Summary:
Code clean up.
Add flush, sync_is_done APIs.
Modify input_find.
ref T8016
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8016
Differential Revision: https://phab.enlightenment.org/D11111
Marcel Hollerbach [Mon, 20 Jan 2020 12:22:59 +0000 (13:22 +0100)]
efl_ui_spotlight/pager/stack: remove @beta
there has been more than 1 month without any comment, i think this looks
fine now ?
The transition event is kept beta for now, as we have right now a
discussion about range that we might be able to use here.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Reviewed-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11135
Jaehyun Cho [Tue, 21 Jan 2020 10:32:34 +0000 (19:32 +0900)]
efl_ui_spotlight_manager: fix not to change sub objects' color
Summary:
Widget's group_member_add() sets its sub objects' color with the
parent's color.
Since spotlight managers call group_member_add() with spotlight
container and its sub objects, the sub objects' color can be changed.
e.g. packed rectangle's color is changed to white (default color value)
To resolve the above issue, spotlight managers set data "_elm_leaveme"
before calling group_member_add() not to change sub objects' color.
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11134
Shinwoo Kim [Tue, 21 Jan 2020 10:28:59 +0000 (19:28 +0900)]
Efl.Canvas.Group: implement Efl.Gfx.Filter
Summary: This patch makes Efl.Canvas.Group work for Efl.Gfx.Filter
Reviewers: Hermet, jsuya, zmike
Reviewed By: Hermet
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10435
Xavi Artigas [Tue, 21 Jan 2020 09:59:12 +0000 (10:59 +0100)]
docs: Typos in Doxygen docs
Ali Alzyod [Mon, 20 Jan 2020 22:39:14 +0000 (07:39 +0900)]
efl_text_interactive: selection enhancment
Summary:
1- Implement setting selection range programmatically by modifying selection cursors from **efl_text_interactive_selection_cursors_get**
2- Add setter with **efl_text_interactive_selection_cursors_set** to set the range at once (modify start and end)
Reviewers: woohyun, segfaultxavi, zmike, bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8521, T8522
Differential Revision: https://phab.enlightenment.org/D10968
Shinwoo Kim [Thu, 7 Nov 2019 05:58:44 +0000 (14:58 +0900)]
evas proxy: use part of source
This makes a proxy object use a selective region of a source object.
This is useful when the source is too big to allocate a proxy surface.
This will be used by elm_scroller to solve following issue.
[Issue]
If size of elm_sclloer content is too big, then the proxy of
elm_scroller to show loop effect does not work. Because
evas_gl_common_image_surface_new does not allow
bigger size surface than max_texture_size
This is a Tizen only patch to fix product issue quickly.
Related patch (https://phab.enlightenment.org/D10604) is under the review.
*tizen_only
Change-Id: I57c58efdf067be4100c6963c8d9894f8bfa04de1
Prasoon Singh [Fri, 13 Dec 2019 07:10:57 +0000 (12:40 +0530)]
access: Add support for unfocusable window
For unfocusable window need a distinction to add window on show signal.
As, for unfocusable window activate signal does not come in screen-reader.
Change-Id: I27647ce9057fb84b90454f4231225d157c082034
Signed-off-by: Prasoon Singh <prasoon.16@samsung.com>
Marcel Hollerbach [Mon, 20 Jan 2020 16:51:40 +0000 (17:51 +0100)]
Revert "ecore_wl2: Fix a memory leaking case"
This reverts commit
97e71b9dc4fa73da99a890d9c39d6617e529dc94.
This commit is absolutly wrong. This makes running wayland apps intree
impossible, and also crashes tests when run in wayland mode.
I asked multiple times in the revision for clarification, noone
answered.
This tricked me today for the second time, so better revert that.
Ali Alzyod [Mon, 20 Jan 2020 12:25:43 +0000 (21:25 +0900)]
efl.input.text.hints_type: rename into content_type
Reviewers: woohyun, segfaultxavi
Reviewed By: woohyun, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8541
Differential Revision: https://phab.enlightenment.org/D11130
Ali Alzyod [Mon, 20 Jan 2020 07:55:31 +0000 (16:55 +0900)]
efl.ui.textbox: using efl_provider_find
Summary: > Code structures like top = elm_widget_top_get(data); and if (efl_isa(top, EFL_UI_WIN_CLASS)) can be replaced with top = efl_provider_find(widget, EFL_UI_WIN_CLASS) No type check needed. (That should enhance the performance)
Reviewers: woohyun, bu5hm4n, cedric
Reviewed By: bu5hm4n, cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8522
Differential Revision: https://phab.enlightenment.org/D11127
Jaehyun Cho [Mon, 20 Jan 2020 03:53:09 +0000 (12:53 +0900)]
efl_canvas_animation: rename Animation_XXX to XXX_Animation
Summary:
In animation classes, "Animation" is not used as a namespace but it is
used as a prefix in the class names.
e.g. Efl.Canvas.Animation_Alpha
However, those classes are basically animation classes with different
features. Therefore, "Animation" should be used as a postfix in the
class names.
e.g. Efl.Canvas.Animation_Alpha -> Efl.Canvas.Alpha_Animation
However, for the easier usage of C APIs, c_prefix of animation classes
are remained to be "efl_animation_xxx".
Reviewers: segfaultxavi, bu5hm4n, zmike, Hermet, jsuya
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11108
ali [Mon, 20 Jan 2020 01:07:40 +0000 (10:07 +0900)]
efl.text.cursor: movement types rename
Summary: replace prev with previous, replace char with character
Reviewers: woohyun, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8567
Differential Revision: https://phab.enlightenment.org/D11095