Kamil Nowac [Mon, 5 Oct 2015 10:28:47 +0000 (12:28 +0200)]
[PointerMode] Pointer Mode removal
[Issue] https://bugs.tizen.org/jira/browse/TT-130
[Problem] Not needed feature
[Solution] N/A
Change-Id: Id3e2df1abe346d1c2575b915e1a906d73bb1b722
Signed-off-by: Kamil Nowac <k.nowac@samsung.com>
Maciej Skrzypkowski [Thu, 1 Oct 2015 08:45:19 +0000 (10:45 +0200)]
Changed ordering of hiding Detail Popup.
[Issue] https://bugs.tizen.org/jira/browse/TT-199
[Problem] Clicking on history link in detail popup caused openig gray,
empty page.
[Cause] Wrong order of opening new web page caused referencing
to deleted object.
[Solution] Changed order, now popup hiding is after opening new URL.
[Verify] Launch browser > Open few web pages > open Quick Access
view, click on thumbnail, check if history links work.
Change-Id: I519e023592bc5870ab1330ec0157c06836eb154c
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Maciej Skrzypkowski [Mon, 28 Sep 2015 06:54:23 +0000 (08:54 +0200)]
Removed dead code from SimpleUI
[Issue#:] https://bugs.tizen.org/jira/browse/TT-157
[Problem:] SimpleUI contains dead code. Lots of unimplemented and
unused methods in class definition.
[Cause:] N/A
[Solution:] Remove dead code and unused method definitions.
[Verify:] Changes builds and doesn't breaks anything.
Change-Id: Id1e0df1abe445d8c2575b915e1a906d70bb1b741
Maciej Skrzypkowski [Tue, 29 Sep 2015 08:21:22 +0000 (10:21 +0200)]
Introduced new window management.
Continuation of patch proposed by Marcin Łapiński.
[Issue] https://bugs.tizen.org/jira/browse/TT-157
[Problem] There was no proper views management
[Cause] N/A
[Solution] New class ViewManager for controling switching
between views.
[Verify] Launch browser > switch between different
views (page view, more menu, settings, etc.),
check if switching is correct check if there
are no relevant warnings in logs.
Change-Id: I8827964b6539ecb7a4c02edd3d296b72a149a9e7
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Dariusz Frankiewicz [Fri, 25 Sep 2015 12:53:50 +0000 (14:53 +0200)]
Fix bad progress bar position.
[Issue] N/A
[Problem] Progress bar is invisible while page is loading.
[Cause] Bad posiotion.
[Solution] Move progress bar down.
[Verify] Load some page and check if progress bar is visible.
Change-Id: I0c628d60c46ae855dc517150bf235331846f7ed0
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
Dariusz Frankiewicz [Tue, 22 Sep 2015 15:07:19 +0000 (17:07 +0200)]
Rename some labels in browser.
[Issue] https://bugs.tizen.org/jira/browse/TT-179
[Problem] Some labels are incorrect according to UI guidelines.
[Verify] Check if reported labels are consistent with UI guidelines.
Change-Id: I4bb700e9003477611a9999aff415486a3236d2a2
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
Dariusz Frankiewicz [Tue, 22 Sep 2015 09:14:40 +0000 (11:14 +0200)]
Reneme More Menu tooltip label
[Issue] https://bugs.tizen.org/jira/browse/TT-172
[Problem] Wrong tooltip label.
[Solution] Rename label.
[Verify] Open browser, point More Menu button and check if label is
"More Menu" instead of "Settings".
Change-Id: I4694d62669952fae28533c8ae3540f6a7828fe18
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
t.dakowicz [Tue, 22 Sep 2015 12:15:06 +0000 (14:15 +0200)]
TT-168 Proper display of current site info
[Issue#] https://bugs.tizen.org/jira/browse/TT-168
[Problem] Current site info was wrong for Home Page (Quick Access view)
[Cause] Home Page status was not checked
[Solution] Added method for that case and added posibillity of disabling
the 'add to bookmark' button when needed
[Verify] Check if adding blank page doesn't work
Change-Id: Iaf287a26a238732029897f867a34a8f1f810c813
Maciej Skrzypkowski [Wed, 23 Sep 2015 14:44:14 +0000 (16:44 +0200)]
D-pad navigation for Quic access view
[Issue] https://bugs.tizen.org/jira/browse/TT-183
[Problem] There was no support for D-pad navigation in Quick Access.
[Cause] Some elements seemed not to be allowed to be focused.
[Solution] Added buttons which enables to focus tiles in Quick Access.
[Verify] Launch browser > Open few web pages > open Quick Access
view, try to navigate using D-pad.
Change-Id: Ie0e5b661a8502d551539e9d89e59162d554eb044
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Albert Malewski [Wed, 23 Sep 2015 11:06:16 +0000 (13:06 +0200)]
Fixed navigating by D-pad in History and Settings
[Issue] https://bugs.tizen.org/jira/browse/TT-183
[Problem] There was no support for D-pad navigation in More Menu.
[Cause] Some elements seemed not to be allowed to be focused.
[Solution] Added focus on some elements in HistoryUI and SettingsUI
using elm_object_focus_custom_chain_append. Set focus on
'Close' button by default. Cleared focused elements from
MoreMenuUI that were visible in HistoryUI, BookmarkManagerUI
and SettingsUI.
[Verify] Launch browser > Navigate to More menu > Choose an item
You should be able to go into Bookmarks/History/Settings
from More Menu just using keyboard/D-pad.
Change-Id: Ica000176f025659b2a4352a2b4e49fe13f552b92
Albert Malewski [Wed, 23 Sep 2015 06:13:29 +0000 (08:13 +0200)]
Fixed navigating by D-pad in More Menu
[Issue] https://bugs.tizen.org/jira/browse/TT-183
[Problem] There was no support for D-pad navigation in More Menu.
[Cause] Incorrect method of callback registration was used.
[Solution] Registered callback in elm_gengrid_item_append function
instead of evas_object_smart_callback_add.
[Verify] Launch browser > Navigate to More menu > Choose an item
You should be able to go into Bookmarks/History/Settings
from More Menu just using keyboard/D-pad.
Change-Id: Ib4673f0e645dbc1c3cbf4d4e2503cf4609b5a205
sungwon2han [Wed, 23 Sep 2015 06:18:59 +0000 (15:18 +0900)]
Browser exit when load history items
[Issue#] NA
[Problem] Browser cannot get history info from browser-provider
[Cause] browser-provider issue
[Solution] add error check routine for browser-provider
Change-Id: I12368bc9394e8115c4debfa9b72d8aa5a9aa9f5c
Signed-off-by: sungwon2han <sungwon2.han@samsung.com>
sungwon2han [Wed, 23 Sep 2015 04:53:33 +0000 (13:53 +0900)]
Browser exit when load bookmark items
[Issue#] NA
[Problem] Browser cannot get bookmark info from browser-provider
[Cause] browser-provider issue
[Solution] add error check routing for browser-provider
Change-Id: If91dc072d4c6294d331294b7cde74433d1dc2f2f
Signed-off-by: sungwon2han <sungwon2.han@samsung.com>
t.dakowicz [Mon, 21 Sep 2015 11:47:00 +0000 (13:47 +0200)]
TT-171 Removing bookmark folders from browser
[Issue#] https://bugs.tizen.org/jira/browse/TT-171
[Problem] N/A
[Cause] Newest guide doesn't contain folders anymore
[Solution] Removed bookmark folders
[Verify] Check if bookmarks are added/removed/displayed properly
Change-Id: Ife3cd8859ef4e1ceb1c4fae0412f40314e89fe02
t.dakowicz [Tue, 15 Sep 2015 14:40:23 +0000 (16:40 +0200)]
TT-163 'Add to bookmarks' UI change
[Issue#] https://bugs.tizen.org/jira/browse/TT-163
[Problem] N/A
[Cause] 1.02 UI guideline
[Solution] Added checkbox that defines current bookmark status
and toast popup for info purpose
Choosing folder for a new bookmark is still there.
Checkbox's style 'favorite' is not available.
Change-Id: I78eaf6ca94d6c0ca6605b6822ea5e5c087260d90
Albert Malewski [Mon, 21 Sep 2015 08:45:52 +0000 (10:45 +0200)]
Changed database path
[Issue] N/A
[Problem] There was wrong database path which resulted in fails
while launching the browser.
[Cause] Wrong Tizen platform variable was used.
[Solution] Used TZ_USER_APP instead of TZ_USER_DB and added <pkgid>/data
directory.
[Verify] Launch browser > Observe logs
There shouldn't be fails in logs while loading database.
Change-Id: Ibb2a6934f25b4974d2c6990cc78b1d97b8137bce
Maciej Skrzypkowski [Mon, 21 Sep 2015 08:48:29 +0000 (10:48 +0200)]
Closing app when pressing back key on Web Page view.
[Issue#] https://bugs.tizen.org/jira/browse/TT-170
[Problem] Browser didn't close when pressing back key.
[Cause] There was a check if back button is enabled which prevent
from closing app when there was no previous web page.
[Solution] Removed unneeded check.
[Verify] Run browser, visit some web page, press back button, check
if browser will close.
Change-Id: I46c29149a1d311679f9b6ef141f6dd71dc335363
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Maciej Skrzypkowski [Mon, 21 Sep 2015 09:24:46 +0000 (11:24 +0200)]
Moved code responsible for web page ui to separate service.
[Issue] https://bugs.tizen.org/jira/browse/TT-167
[Problem] Functionality of SimpleUI was confusing.
[Cause] N/A
[Solution] Created new class WebPageUI, moved all classes connected
to web page ui to new service.
Change-Id: I633b5c5abad0040b9b7d51e5fb532de2c0d25689
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Dariusz Frankiewicz [Fri, 18 Sep 2015 14:53:18 +0000 (07:53 -0700)]
Revert "Changed database path"
This reverts commit
5059e93c83493911ad58c4c26162f2792c99ded6.
Change-Id: I8cdfa7391739693de3813eed6d2179a90f94f76f
Albert Malewski [Fri, 18 Sep 2015 13:02:56 +0000 (15:02 +0200)]
Changed database path
[Issue] N/A
[Problem] There was wrong database path which resulted in fails
while launching the browser.
[Cause] Wrong Tizen platform variable was used.
[Solution] Used TZ_USER_APP instead of TZ_USER_DB.
[Verify] Launch browser > Observe logs
There shouldn't be fails in logs while loading database.
Change-Id: I2641314543647e15cdfc70b5b8decc201fdcc57b
Dariusz Frankiewicz [Fri, 18 Sep 2015 10:18:53 +0000 (12:18 +0200)]
fixup! ViewManager class added.
Change-Id: I9a52869f215df69a9e82c18ab2b3e4c547ea1c1d
Marcin Lapinski [Fri, 11 Sep 2015 13:37:24 +0000 (15:37 +0200)]
ViewManager class added.
[Issue#:] https://bugs.tizen.org/jira/browse/TT-157
[Problem:] New window management class is needed.
[Cause:] N/A
[Solution:] Implemented new class with following public methods:
popStackTo
popTheStack
pushViewToStack
getContent
[Verify:] Class is not used. Changes builds and doesn't crash.
Merge this after merging this patch:
https://review.tizen.org/gerrit/#/c/48052/
Change-Id: I4b8ca2866fa1cecbf858b4aed41e42112620a9f7
Marcin Lapinski [Fri, 11 Sep 2015 12:04:37 +0000 (14:04 +0200)]
Make AbstractUIComponent doing anything.
[Issue#:] https://bugs.tizen.org/jira/browse/TT-157
[Problem:] New window management class needs AbstractUIComponent to
have some view managing functions.
[Cause:] N/A
[Solution:] Added needed methods to interface:
void init(Evas_Object* parent)
Evas_Object* getContent()
void showUI()
void hideUI()
[Verify:] Change builds. Browser is not crashing on loading services.
Merge it after all UI components implement these methods.
Change-Id: I7c67cad62a5b68a713395ecc1487fa9e90c72bc7
Maciej Skrzypkowski [Tue, 15 Sep 2015 08:33:12 +0000 (10:33 +0200)]
Remove unused classes.
[Issue#] N/A
[Problem] These classes were unused.
[Cause] N/A
[Solution] Delete classes and theirs references.
[Verify] Run browser, check if page browsing works.
Change-Id: I11bd790c0cec58dfa7e13f7b9d553a8b822e69a3
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Marcin Lapinski [Mon, 14 Sep 2015 13:48:57 +0000 (15:48 +0200)]
MoreMenuUI Implementing new AbstractUIComponent methods.
[Issue#:] https://bugs.tizen.org/jira/browse/TT-157
[Problem:] New window management class needs AbstractUIComponent to
have some view managing functions.
[Cause:] N/A
[Solution:] Implemented needed methods:
void init(Evas_Object* parent)
Evas_Object* getContent()
void showUI()
void hideUI()
[Verify:] Change is not affecting browsers behaviour.
Change-Id: I4aef907e35f5240be86c259f4d6705a43c93ee4a
Marcin Lapinski [Mon, 14 Sep 2015 16:16:49 +0000 (18:16 +0200)]
TabUI Implementing new AbstractUIComponent methods.
[Issue#:] https://bugs.tizen.org/jira/browse/TT-157
[Problem:] New window management class needs AbstractUIComponent to
have some view managing functions.
[Cause:] N/A
[Solution:] Implemented needed methods:
void init(Evas_Object* parent)
Evas_Object* getContent()
void showUI()
void hideUI()
[Verify:] Change is not affecting browsers behaviour.
Change-Id: I6d4a91af909722050564690510f64e9c331b7fe5
Albert Malewski [Mon, 14 Sep 2015 12:12:12 +0000 (14:12 +0200)]
Removed inheritance of AbstractUIComponent in MainUI and SimpleURI classes
[Issue] https://bugs.tizen.org/jira/browse/TT-157
[Problem] MainUI and SimpleURI classes are not UI components in fact.
They are not suspected to call AbstractUIComponent's methods.
[Cause] N/A
[Solution] Removed inheritance of AbstractUIComponent in MainUI
and SimpleURI classes.
[Verify] This patch does not change browser's behaviour.
Change-Id: I048c6ad288df7af331efda6552565b83a112af08
Marcin Lapinski [Fri, 11 Sep 2015 11:54:40 +0000 (13:54 +0200)]
BookmarkManagerUI Implementing new AbstractUIComponent methods.
[Issue#:] https://bugs.tizen.org/jira/browse/TT-157
[Problem:] New window management class needs AbstractUIComponent to
have some view managing functions.
[Cause:] N/A
[Solution:] Implemented needed methods:
void init(Evas_Object* parent)
Evas_Object* getContent()
void showUI()
void hideUI()
[Verify:] Change is not affecting browsers behaviour.
Change-Id: Ia8f4eca29b82a54f239671f32bc6c43f9a47b7fe
Maciej Skrzypkowski [Mon, 14 Sep 2015 11:07:04 +0000 (13:07 +0200)]
Added proper handler for bookmark click in Quick Access view.
[Issue] N/A
[Problem] Clicking on bookmark caused opening popup or crashing.
[Cause] Wrong callback was assigned to bookmark click.
[Solution] Changed callback to opening new tab.
Change-Id: I85dbaa29ba83005e25a4796f80a80c901a23a1f9
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Maciej Skrzypkowski [Mon, 14 Sep 2015 10:25:36 +0000 (12:25 +0200)]
Refactoring - removed genlist from Quick Access tiles.
[Issue] N/A
[Problem] Genlist were unneeded for tiles.
[Cause] N/A
[Solution] Removed genlist, added aditional swallows for tiles.
Change-Id: I9a561d2973c9db0b70f413792dfdab4a2e7c24ab
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
t.dakowicz [Fri, 11 Sep 2015 11:16:44 +0000 (13:16 +0200)]
TT-165 Fixed browser crash after opening page from history/bookmarks
[Issue#] https://bugs.tizen.org/jira/browse/TT-165
[Problem] Browser's crash after opening a page from bookmarks/history
[Cause] Favicon was inserted into freed object
[Solution] Added disconnects from signals after closing MoreMenu
[Verify] New Tab -> MoreMenu -> History -> open page
or New Tab -> Bookmarks -> open page
Check if browser crashes
Please keep in mind that disconnects are needed here because views
are removed when exiting, which won't be done in future new browser's
structure.
Change-Id: I7a8db96b35d397b88196bbdbba21f526c73c2ec8
Marcin Lapinski [Tue, 1 Sep 2015 11:33:29 +0000 (13:33 +0200)]
SimpleUI refactoring
[Issue#:] https://bugs.tizen.org/jira/browse/TT-157
[Problem:] Function exec() covers functionality which will be
covered by different classes;
[Cause:] N/A
[Sollution:] Splitted huge exec() to few smaller.
[Verify:] Refactor is not affecting browsers behaviour.
Change-Id: I073154a3116ef7ff9723e2445737a699f59e214e
Albert Malewski [Fri, 11 Sep 2015 08:27:53 +0000 (10:27 +0200)]
Implementing AbstractUIComponent's new interface methods in SettingsUI
[Issue] https://bugs.tizen.org/jira/browse/TT-157
[Problem] Improper view navigation is used.
[Cause] N/A
[Solution] Implemented needed methods:
void init(Evas_Object *parent)
Evas_Object* getContent()
void showUI()
void hideUI()
[Verify] Launch browser > More Menu > Settings > Obs
Settings should be displayed correctly.
It needs implementation on SimpleUI side - when it's done,
show() function should be removed.
Change-Id: Ic28f501398cf55de4b4a5a9d5bae20bada55c525
Albert Malewski [Thu, 10 Sep 2015 13:14:29 +0000 (15:14 +0200)]
HistoryUI Refactor
[Issue] https://bugs.tizen.org/jira/browse/TT-157
[Problem] Improper view navigation is used.
[Cause] N/A
[Solution] Implemented needed methods:
void init(Evas_Object *parent)
Evas_Object* getContent()
void showUI()
void hideUI()
[Verify] Launch browser > More Menu > History > Obs
History should be displayed correctly.
It needs implementation on SimpleUI side - when it's done,
show() function should removed.
Change-Id: I83500ec9053f9ac9fc418f63f7b87f5a24a38c92
Maciej Skrzypkowski [Thu, 10 Sep 2015 12:34:17 +0000 (14:34 +0200)]
Added thubnail and history links clicking for detail popup.
[Issue] https://bugs.tizen.org/jira/browse/TT-144
[Problem] Detail popup missed thumbnail.
[Cause] N/A
[Solution] Added thumbnail in proper size.
[Verify] Launch browser > open few pages >
check thubnails Most Visited view in detail popup,
check if history links in popup are clickable.
Change-Id: I50d3e2862fc672a41de8cdc50f790f48f19ff21d
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
t.dakowicz [Wed, 9 Sep 2015 13:57:01 +0000 (15:57 +0200)]
TT-101 Fixed URL bar update and added doc icon
[Issue#] https://bugs.tizen.org/jira/browse/TT-101
[Problem] URL bar shows wrong URL after back/forward action
[Cause] Multiple URL changes and lack of direct connection to
proper SimpleURI method
[Solution] Added direct connection to SimpleURI::changeUri and
added doc icon for pages not loaded completely
(placeholder)
[Verify] Check if back/forward action causes correct URL update
Change-Id: Ibc5cad20397328789d3bfcc07e0852d41d1a87b7
t.dakowicz [Thu, 10 Sep 2015 13:55:02 +0000 (15:55 +0200)]
Fixed bookmark creation
[Issue#] N/A
[Problem] Bookmarks couldn't be created
[Cause] Variables used in 'bp_bookmark_adaptor_easy_create()' had some
not initialized values
[Solution] std::memset before passing its reference
[Verify] Check if bookmarks can be created
Change-Id: I861e70a6f6fa8e980423eb2721899421de9c485b
Maciej Skrzypkowski [Tue, 8 Sep 2015 14:04:20 +0000 (16:04 +0200)]
Fixed crash while loading page without title.
[Issue] https://bugs.tizen.org/jira/browse/TT-162
[Problem] Browser crashed while loading page.
[Cause] There was no check if page title is empty while comparing.
[Solution] Changed compering to URL, added check if it's empty.
[Verify] Launch browser > go to: http://jmajnert.github.io/tests/localStorage_test/localStoragePersistance.html
refresh page > close browser > open again > go to previous site.
Browser shouldn't crash.
Change-Id: Icc19ad7a327d97fe6ff79777b0fc819189cf660a
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Albert Malewski [Tue, 8 Sep 2015 07:44:29 +0000 (09:44 +0200)]
Fixed radio selection in settings
[Issue] https://bugs.tizen.org/jira/browse/TT-154
[Problem] Cannot select any item in radio list at Web contents Sharing section.
[Cause] Every radio was set to one group. Missing state valuesof radios.
[Solution] Added enums with state values and separate radio buttons within
3 lists.
[Verify] Launch browser > More Menu > Settings > Obs
You should be able to select any radio in settings.
Change-Id: I894d6527770c51066be60372cc3e69646c21ff82
Maciej Skrzypkowski [Tue, 8 Sep 2015 08:27:34 +0000 (10:27 +0200)]
Switching between mobile/desktop mode per tab.
[Issue#] https://bugs.tizen.org/jira/browse/TT-132
[Problem] View mode was set as global flag.
[Cause] N/A
[Solution] Added flag for each tab to remeber current mode.
[Verify] Open new tab (google.com), open settings, switch to mobile
mode, page should reload in mobile view.
Change-Id: I19a6f1965938930b45f46b076ce030f2fe9c10ed
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Maciej Skrzypkowski [Tue, 8 Sep 2015 08:39:46 +0000 (10:39 +0200)]
Refactoring - deleted unused history SQLite classes.
[Issue#] N/A
[Problem] These history classes were not used.
[Cause] N/A
[Solution] Removed dead code.
[Verify] Open few pages, check if they appeared in history.
Change-Id: Ia996b2259a7cc8c6e5506eb707a4f0a89c494aae
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Albert Malewski [Fri, 4 Sep 2015 11:23:47 +0000 (13:23 +0200)]
Added switching between 'Open Tabs' and 'On Other Devices'
[Issue] https://bugs.tizen.org/jira/browse/TT-149
[Problem] "Opened Tabs" is not toggle with "On Other Devices" in Tab Manager.
[Cause] Lack of implementation.
[Solution] Added boolean onOtherDevicesSwitch variable, which allows to switch
between 'Open Tabs' and 'On Other Devices' correctly. Changed type
of onotherdevices_click and openedtabs_click from RECT to SWALLOW.
Additionally, changed 'tab_gengird' to 'tab_gengrid'.
[Verify] Launch browser > Open new tab > Tabs > On Other Devices > Obs
Tabs should be hidden when 'On Other Devices' is clicked.
Change-Id: I18529df81e274dcbc658e8db7ef038b4080e907d
t.dakowicz [Thu, 3 Sep 2015 14:25:39 +0000 (16:25 +0200)]
TT-158 Fixed 'Clear History' bug
[Issue#] https://bugs.tizen.org/jira/browse/TT-158
[Problem] Browser's crash after clicking on 'clear history'
button
[Cause] 'm_historyUI' object was not freed after closing the HistoryUI,
which caused multiple sending of the clearHistory signal
[Solution] Provided proper object management and prevented multiple
creation of the 'm_historyUI'.
In addition, there is a problem with displaying NoHistoryLabel
from the HistoryUI - currently, it is not available from there
[Verify] Do some browsing -> MoreMenu -> History Manager -> Clear
Check if this action causes browser's crash
Change-Id: I8be4b31c67b901d241d0bafdd621b72d5ea4c5f4
Albert Malewski [Thu, 3 Sep 2015 06:16:11 +0000 (08:16 +0200)]
Fixed creating history list
[Issue#] https://bugs.tizen.org/jira/browse/TT-159
[Problem] "Close Tabs" function is not implemented in Tab Manager.
[Cause] N/A
[Solution] Added closeAllTabs, closeTabsClicked functions. Added boolean
'editMode' variable that conditions action in _thumbSelected function.
Added callback to make 'X' icon and '[OK] to close' visible.
[Verify] Launch browser > Add tabs > Tab manager > Close Tabs
Check if 'Close all' button works properly
Check if closing selected item works properly
Change-Id: I98453027ad3ccfa797ab94e1e2c3ffa67f65d28f
Dariusz Frankiewicz [Mon, 31 Aug 2015 07:13:00 +0000 (09:13 +0200)]
Refactor SettingsUI
[Issue#] https://bugs.tizen.org/jira/browse/TT-153
[Problem] Check boxes in settings menu can't be clicked.
[Cause] Invisible platform rectangle covers this screen area.
[Solution] Refactoring settings UI code by replacing unneded genlist,
with layout inside scrooler. Also added possibility to click
check box labels as a complementary fix for platform issue
with invisible rectangle.
[Verify] Open More menu -> Settings and check if check boxes: Cache,
Cookies and History can be changed by clicking their labels.
Change-Id: I49e2ea04054cb1efdecd3fed02d26914b1ecac48
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
Maciej Skrzypkowski [Thu, 3 Sep 2015 10:28:26 +0000 (12:28 +0200)]
User agent set depending on browsing mode (desktop/mobile).
[Issue#] https://bugs.tizen.org/jira/browse/TT-132
[Problem] Browising mode switching was not implemented.
[Cause] N/A
[Solution]Added changing user agent by using EWK API
method: ewk_view_user_agent_set.
[Verify] Open new page, go to google.com then
settings > view mobile web then close settings,
type in new URL google.com, it should appear
in mobile mode.
Change-Id: I8a6888d09b94f97eb51b9d2440f04bf8e2ba544c
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
t.dakowicz [Thu, 27 Aug 2015 16:32:57 +0000 (18:32 +0200)]
TT-106 Removed MoreMenu's tiles from BookmarkManager screen
[Issue#] https://bugs.tizen.org/jira/browse/TT-106
[Problem] Tiles from MoreMenu was visible and accessible
from BookmarkManager screen
[Caused] Items were not cleared/hidden
[Solution] This solution just clear those problematic items from
MoreMenu - it should be removed after the new correct
displaying design will be done
[Verify] MoreMenu->BookmarkManager or
MainUI->Bookmarks->BookmarkManager
Check if any invisible tile is accessible or visible
Change-Id: I371496d9befb64095721354f76fbb56d5fd18fc9
Maciej Skrzypkowski [Tue, 1 Sep 2015 07:28:14 +0000 (09:28 +0200)]
Fixed not displaying thumbnails on Most visited screen.
[Issue#] https://bugs.tizen.org/jira/browse/TT-73
[Problem] There was no thumbnails on main screen.
[Cause] Website thumbnail was not saved and not fetched.
[Solution] Added saving thumbnail on page finish loading and fetching it
for Most visited screen.
[Verify] Visit few different sites (wait until page is fully loaded) > open
the Most visited screen, check if there are thumbnails.
Change-Id: I8d8e648df0d1314fa772e5519ee07a06e795bc63
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Maciej Skrzypkowski [Fri, 28 Aug 2015 14:23:53 +0000 (16:23 +0200)]
Added detail popup to most visited view.
[Issue#] https://bugs.tizen.org/jira/browse/TT-144
[Problem] N/A
[Cause] N/A
[Solution] Create popup view.
[Verify] Open most visited view, click on tile, check if new popup
with history appears
Change-Id: Ia8ecffbba4d93e7d759780cf49f35a2c03c87fda
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Albert Malewski [Thu, 27 Aug 2015 12:12:36 +0000 (14:12 +0200)]
Fixed creating history list
[Issue#] https://bugs.tizen.org/jira/browse/TT-156
[Problem] There is at most 5 items visible in history and the list
is not updated.
[Cause] There was used getMostVisitedHistoryItems function to generate
history list.
[Solution] Added several functions in HistoryService to get history list:
getHistoryAll, getHistoryToday, getHistoryYesterday, getHistoryLastWeek,
getHistoryLastMonth, getHistoryOlder.
[Verify] Launch browser > More Menu > History > Obs
History should not crash after clicking on 'History' button.
Change-Id: I1dde7088555a4cdba01e92be78c3dda5276040c4
t.dakowicz [Thu, 27 Aug 2015 14:43:15 +0000 (16:43 +0200)]
TT-141 Added current web page info sync
[Issue#] https://bugs.tizen.org/jira/browse/TT-141
[Problem] Current web page info wasn't always updated and
favicon wasn't loaded
[Cause] Lack of proper signals
[Solution] Added signals, removed genlist and used single layout instead,
resized space for site info, removed pointless image reload
from WebView::getFavicon
[Verify] Open a new page -> type web url -> MoreMenu
Check if the info is properly loaded
Change-Id: Ibe3f7cd97279470761eaa9f58c9e40b06c655eeb
Albert Malewski [Thu, 27 Aug 2015 07:45:37 +0000 (09:45 +0200)]
Fixed crash that occurs after clicking on 'History' button
[Issue#] https://bugs.tizen.org/jira/browse/TT-98
[Problem] Browser crashes after clicking on 'History' button.
[Cause] There was used normal pointer that pointed to the destroyed object.
[Sollution] 1. Changed type of HistoryService::getHistoryItems() and
HistoryService::getMostVisitedHistoryItems() functions that the return
std::shared_ptr<std::vector<std::shared_ptr<HistoryItem> > >.
2. Added HistoryService::getHistoryItem function which returns HistoryItem by id.
3. Added HistoryService::getCurrentTab functions that returns currently
observed web page's info.
4. Changed type of h_item pointer in MoreMenuUI.cpp from normal pointer to
shared_ptr.
5. Added listItemDel function to avoid memory leaks when genlist is cleared.
[Verify] Launch browser > More Menu > History > Obs
History should not crash after clicking on 'History' button.
Change-Id: I9140c1dedc061b2d014792aa14da92053e7aa27f
Marcin Lapinski [Fri, 21 Aug 2015 13:33:02 +0000 (15:33 +0200)]
Refactoring MainUI
[Issue#] https://bugs.tizen.org/jira/browse/TT-72
[Problem] MainUI needs refactoring.
[Cause] N/A
[Sollution] Following actions were taken:
-Split humongous show functions into several smaller.
-Removed unused functions.
-Logically split most visited and bookmark view.
-Replace redundant class members with local variables.
-Renamed functions and variables to make names more adequate.
[Verify] 1. Browser builds
2. Refactor does not change behaviour of browser.
Change-Id: I44a5c958ad4e7b0c694434a4cfdb45702c871ec7
Marcin Lapinski [Tue, 25 Aug 2015 15:48:36 +0000 (17:48 +0200)]
Refactoring TabUI
[Issue#] https://bugs.tizen.org/jira/browse/TT-72
[Problem] TabUI needs refactoring.
[Cause] N/A
[Sollution] Following actions were taken:
-Split humongous show functions into several smaller.
-Removed unused functions.
-Replaced redundant class members with local variables.
-Renamed functions, variables and edc names to make names
more adequate.
[Verify] 1. Browser builds
2. Refactor does not change behaviour of browser.
Change-Id: I12a850bfb239b2d8477536517dfb93bb1db76df4
cookie [Wed, 26 Aug 2015 06:42:49 +0000 (15:42 +0900)]
Change the log level INFO to DEBUG
[Issue#] The browser log don't display by journalctl -fl
[Problem] The browser log don't display for debugging
[Cause] The log level is INFO
[Sollution] Change to log level to LoggerLevel::DEBUG
Change-Id: Iefd33af8344996d0de812e290476f948a387fa1b
Signed-off-by: cookie <cookie@samsung.com>
Jung Ick Guack [Wed, 26 Aug 2015 06:01:02 +0000 (15:01 +0900)]
Fixed bug that 2nd app control is not working
[Issue#] HQ Synergy TF team reported the issue
[Problem] Only 1st app control is working.
After 2nd app control is not working.
[Cause] There is wrong scope for first initializing code when start SimpleUI::exec
[Sollution] Move opening new tab to out of first initializing scope.
[Verify] App control should open the tab even after 2nd command.
HQ Synergy TF team verified thie fix.
Change-Id: Ic59d7e977c07a90de6aea455224d4bb44db7c922
Signed-off-by: Jung Ick Guack <ji.guack@samsung.com>
Marcin Lapinski [Mon, 10 Aug 2015 09:18:01 +0000 (11:18 +0200)]
Reintroduce removed ewk_view_screenshot_contents_get api call.
[Issue#] https://bugs.tizen.org/jira/browse/TT-89
[Problem] Bookmark items do not show its thumbnail.
[Cause] N/A
[Sollution] Put ewk_view_screenshot_contents_get call back as it
was moved to public api.
[Verify] Bookmark items thumbnalis should be visible.
Change-Id: I50538f737eebbce566565f5c6052266125d52610
t.dakowicz [Wed, 19 Aug 2015 13:00:17 +0000 (15:00 +0200)]
TT-134 Implemented tree structure of bookmark folders
[Issue#] https://bugs.tizen.org/jira/browse/TT-134
[Problem] New folders were always added to the root folder
[Cause] N/A
[Solution] Used properly a current folder variable,
changed displaying/updating folder content and
did minor style improvements
[Verify] Check if new folder addition inside a folder
actually adds a folder to the selected one.
Please keep in mind that there are some problems with diplaying
content inside folders, which will be handled in separate issue.
Change-Id: Ic5f71c57d78e95bb9878bf17d84db57eb57b8f9d
Marcin Lapinski [Wed, 19 Aug 2015 12:25:54 +0000 (14:25 +0200)]
Refactoring MainUI
[Issue#] https://bugs.tizen.org/jira/browse/TT-72
[Problem] MainUI needs refactoring.
[Cause] N/A
[Sollotion] -Removed redundant gengrid from bottom panel.
-Removed unused declarations.
-Removed redundant namespace identifiers.
[Verify] 1. Browser builds
2. Refactor does not change behaviour of browser.
Change-Id: If23e9979914cb44af91b881b25e5caffbba4c246
Maciej Skrzypkowski [Wed, 19 Aug 2015 13:49:06 +0000 (15:49 +0200)]
Added "no visited site" view for Most visted tab.
[Issue#] https://bugs.tizen.org/jira/browse/TT-73
[Problem] For no history there was no message.
[Cause] N/A
[Solution] Added label "No visited site" when there is no history
[Verify] Run fresh browser instance, there should be "No visited site"
message in Most visited tab.
Change-Id: I171f6d5d74dbc175102a08afac37b22ff3bb6e50
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Janusz Majnert [Tue, 18 Aug 2015 07:40:57 +0000 (09:40 +0200)]
Removing ewk_context_default_get call
[Issue#] N/A
[Problem] Call to internal EWK API
[Cause] Code restored during branch merge
[Solution] Remove the call, it is not needed
[Verify] Build and run the browser, load a few tabs, close tabs
The call to ewk_context_default get was restored by mistake when performing a
merge between branches. The version in tizen branch had the code replaced with
another method to implicitly initialize EWK internal contexts.
Change-Id: If21dcc4ca40242786c22e80b7a5591a70c56ecfb
Albert Malewski [Tue, 18 Aug 2015 11:02:37 +0000 (13:02 +0200)]
Fixed navigating to links from history
[Issue#] https://bugs.tizen.org/jira/browse/TT-93
[Problem] Browser cannot navigate to links from history.
[Cause] There is no implemented callback on click event in history.
[Solution] Implemented callback _history_item_clicked_cb and switching the view.
[Verify] Launch Browser > More menu > History > Click on some link > Obs
Browser should load clicked webpage.
Change-Id: Iaac04dd59776b302fa199dd6d631aafa03eca139
Maciej Skrzypkowski [Wed, 19 Aug 2015 09:13:52 +0000 (11:13 +0200)]
Add removing http prefix from URL, add preventing from loading view two times.
[Issue#] https://bugs.tizen.org/jira/browse/TT-73
[Problem] Full URL was shown, second click on button caused
hiding view.
[Cause] N/A
[Solution] Parsing URL, preventing second view show.
[Verify] Check URL on "Most visited" tiles, check if second click on
"Most visited" or "Bookmark" button causes hiding view.
Change-Id: I0b043c75e2779ae277620cc16d14c221da64df22
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Maciej Skrzypkowski [Mon, 17 Aug 2015 14:02:17 +0000 (16:02 +0200)]
Change view of Most Visited tiles.
[Issue#] https://bugs.tizen.org/jira/browse/TT-73
[Problem] Font sizes, colors, highlight were wrong.
[Cause] N/A
[Solution] Changed to proper ones.
[Verify] Check tiles title and URL font and it's location acording to
guideline. Check backgrounds. Check highliting tiles.
Change-Id: I8ab0b869a72f6baedaf3832e58edb88c40135940
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Marcin Lapinski [Tue, 18 Aug 2015 09:46:41 +0000 (11:46 +0200)]
Set callback for bookmark gengrid item instead of items thumbnail.
[Issue#] https://bugs.tizen.org/jira/browse/TT-135
[Problem] Clicking on bookmark folder text doesn't work.
[Cause] Callback was set on thumbnail instead of on whole item.
[Sollution] Move callback to bookmark gengrid item click.
[Verify] 1. Run browser
2. Create some bookmark folders
3. Open More Menu -> Bookmark manager
4. Click on some bookmark folder description
5. Bookmark folder shold be opened.
Additional changes:
- Changed some function names to make code more self-explaining.
- Removed redundant focus managment callbacks causing problems
in the current approach.
Change-Id: Ibddc457a7cfdc19f7b68ce4163f4b2ae04d793db
Albert Malewski [Mon, 17 Aug 2015 12:22:02 +0000 (14:22 +0200)]
Added action on "Exit browser" button
[Issue#] https://bugs.tizen.org/jira/browse/TT-131
[Problem] "Exit browser" in More Menu is not working.
[Cause] There was no action connected to "exit browser" button.
[Solution] Added function _exitClicked that calls elm_exit().
[Verify] Browser -> MoreMenu -> Exit browser -> Obs
Browser should be closed.
Change-Id: I14473625d1b8ba9d60e9049005193b63e3a66208
Janusz Majnert [Mon, 17 Aug 2015 13:58:22 +0000 (15:58 +0200)]
Merge branch 'new_ui' into tizen
Conflicts:
services/BookmarkService/BookmarkService.cpp
services/SimpleUI/SimpleUI.cpp
services/WebKitEngineService/WebView.cpp
Change-Id: If7f333aa9127d034e9a4f0ade2d303688572ee2e
Maciej Skrzypkowski [Mon, 17 Aug 2015 13:03:27 +0000 (15:03 +0200)]
Remove unneeded genlist from top buttons.
[Issue#] https://bugs.tizen.org/jira/browse/TT-73
[Problem] Uneeded genlist caused scrolling of top buttons.
[Cause] N/A
[Solution] Removed genlist.
[Verify] Check if buttons "Most visited" and "Bookmarks" work.
Change-Id: I044d8502be38d55fe7ce9b44c1674f3cf155922c
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
t.dakowicz [Thu, 13 Aug 2015 13:05:35 +0000 (15:05 +0200)]
Bug TT-94 Fixed bookmarks folder creation bug
[Issue#] https://bugs.tizen.org/jira/browse/TT-94
[Problem] User couldn't create new folder for bookmarks.
[Cause] Wrong initialization of variable
[Solution] The variable initialized with zeros
[Verify] MoreMenu -> Add bookmark -> '+' -> type new folder's
name. Check if the folder is visible in Bookmark
Manager.
Change-Id: I630787ae4251cbe6ab4ad53ce23b756996173e3d
Marcin Lapinski [Mon, 17 Aug 2015 12:28:24 +0000 (14:28 +0200)]
Disabled START_MINIBROWSER and READ_MODE features
[Issue#] https://bugs.tizen.org/jira/browse/TT-129
[Problem] N/A
[Cause] N/A
[Solution] N/A
[Verify] 1. Change builds.
2. Feature buttons in More Menu should be not visible.
Change-Id: I9aec51faabafb9503a31e30955cd92d0ed31b10b
Albert Malewski [Wed, 12 Aug 2015 10:32:04 +0000 (12:32 +0200)]
Fixed tabs addition
[Issue#] https://bugs.tizen.org/jira/browse/TT-92
[Problem] Multiple tabs are added when navigating a page
from Most Visited or Bookmarks.
[Cause] Slots were added to signals every time the ShowMainUI
function was called.
[Solution] Changed time of adding slots. Now they are added in function exec
only once (if m_initialised is false).
[Verify] Launch Browser > Create new tabs > Obs
Number of open tabs should be correct.
Change-Id: I0401061a1cc75984c739a582be6bb83465849556
Marcin Lapinski [Thu, 13 Aug 2015 09:58:37 +0000 (11:58 +0200)]
Refactor of HistoryUI::showActionBar function.
[Issue#] https://bugs.tizen.org/jira/browse/TT-72
[Problem] HistoryUI::showActionBar is too complicated. Uses unnecessary
genlist, with only one item to create action bar. This makes
code long and unclear as it is not the proper use of genlist.
[Cause] N/A
[Solution] Use layout instead the genlist to make the code shorter and
more self-explaining.
[Verify] 1. Browser builds.
2. Run the browser and check history ui to see if the change
is not introducing any new issues.
Change-Id: I9b1ad458d7497af9d85741978e844ebb4f918079
Marcin Lapinski [Wed, 12 Aug 2015 13:31:53 +0000 (15:31 +0200)]
Added action on clear history button clicked.
[Issue#] https://bugs.tizen.org/jira/browse/TT-99
[Problem] 'Clear History' button does not work.
[Cause] Buttons callback was empty.
[Solution] Trigger history clear on button click.
[Verify] 1. (History is not empty)
2. Open More menu -> history.
3. Click 'Clear History' button.
4. History should be deleted.
Change-Id: I7d9b5d40451398d21ef88359f37660261ce1e6e6
Maciej Skrzypkowski [Wed, 12 Aug 2015 12:03:09 +0000 (14:03 +0200)]
Improve sizes of tiles, remove unneeded medium style,
small refactoring of white spaces.
[Issue#] https://bugs.tizen.org/jira/browse/TT-73
[Problem] Sizes of most visited tiles were wrong.
[Cause] N/A
[Solution] Fixed style for small tiles, removed style for medium
tiles.
[Verify] Check if Most visited view has proper tiles sizes.
Change-Id: I4d884e3d099056e553c99b492469b8abb03d8b16
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Janusz Majnert [Tue, 11 Aug 2015 08:44:06 +0000 (10:44 +0200)]
Refactored HistoryUI service
[Issue#] https://bugs.tizen.org/jira/browse/TT-72
[Problem] Lots of style fixes, several fixes for build warnings
[Cause] n/a
[Solution] Reformat code, fix casting and remove unused variables
[Verify] 1. Check that there are no build problems caused by this change
2. Run the browser and explore the history ui to see if nothing got broken
List of changes:
* tabs -> spaces
* proper indentation
* other minor style fixes
* removing unused variables' declarations
* renaming a few class members to better express their use
* replacing reinterpret_cast with static_cast where appropriate
* adding null-checks in callback functions
* replacing deprecated Elementary API call with its successor
Change-Id: Id2c4c020573138d641a8e6a676942830a6505ab5
t.dakowicz [Tue, 11 Aug 2015 12:46:23 +0000 (14:46 +0200)]
Bug TT-96 Fixed 'Bookmark Manager' button in the More Menu
[Issue#] https://bugs.tizen.org/jira/browse/TT-96
[Problem] Bookmark Manager couldn't be accessed from
More Menu
[Cause] Proper signal wasn't created
[Solution] Added signal to MoreMenu class
[Verify] Check if Bookmark Manager button does anything
Change-Id: Idad6aaa774ad30fb9ff9b0207d4ef2a2004bf751
Janusz Majnert [Mon, 10 Aug 2015 14:41:33 +0000 (16:41 +0200)]
Refactored SettingsUI service
[Issue#] https://bugs.tizen.org/jira/browse/TT-72
[Problem] Lots of style fixes, several fixes for build warnings
[Cause] n/a
[Solution] Reformat code, fix casting and remove unused variables
[Verify] 1. Check that there are no build problems caused by this change
2. Run the browser and explore the settings to see if nothing's broken
List of changes:
* tabs -> spaces
* proper indentation
* other minor style fixes
* removing unused variables' declarations
* renaming a few class members to better express their use
* replacing reinterpret_cast with static_cast where appropriate
* adding null-checks in callback functions
* replacing deprecated Elementary API call with its successor
Change-Id: Ic9e00dd20b93f9392af61bede11868df18448478
Janusz Majnert [Fri, 7 Aug 2015 17:01:24 +0000 (19:01 +0200)]
Refactored TabUI service
[Issue#] https://bugs.tizen.org/jira/browse/TT-72
[Problem] Lots of style fixes, several fixes for build warnings
[Cause] n/a
[Solution] Reformat code, fix casting and remove unused variables
[Verify] 1. Check that there are no build problems caused by this change
2. Run the browser and explore the tab functionality to see if nothing's broken
List of changes:
* tabs -> spaces
* proper indentation
* other minor style fixes
* removing unused variables' declarations
* renaming a few class members to better express their use
* replacing reinterpret_cast with static_cast where appropriate
* adding null-checks in callback functions
Change-Id: Ib2a5731683c99aa5b89acf9f00417a41d207c579
Janusz Majnert [Fri, 7 Aug 2015 10:01:38 +0000 (12:01 +0200)]
Refactored MoreMenuUI service
[Issue#] https://bugs.tizen.org/jira/browse/TT-72
[Problem] Lots of style fixes, several fixes for build warnings
[Cause] n/a
[Solution] Reformat code, fix casting and remove unused variables
[Verify] 1. Check that there are no build problems caused by this change
2. Run the browser and explore the More Menu to see if nothing's broken
List of changes:
* tabs -> spaces
* proper indentation
* other minor style fixes
* removing unused variables' declarations
* renaming a few class members to better express their use
* replacing reinterpret_Cast with static_cast where appropriate
* adding null-checks in callback functions
* replacing shared_ptr copy-assignments with make_shared
Change-Id: I6a65bbcf9efaef42db955c689ba81673cb12e1fa
Janusz Majnert [Fri, 7 Aug 2015 09:28:57 +0000 (11:28 +0200)]
Minor style fixes and cleanup in BookmarkManagerUI
[Issue#] https://bugs.tizen.org/jira/browse/TT-72
[Problem] Wrong indenting, wrong casting method, unused variable
[Cause] n/a
[Solution] Reformat code, fix casting and remove unused variable
[Verify] Check that there are no build problems caused by this change
Change-Id: Ic5d8b7b3d24322aa93111d2ab195ccceb5cca6e0
k.lis2 [Thu, 6 Aug 2015 16:10:28 +0000 (18:10 +0200)]
Remove ewk_context_favicon_database_directory_set internal API call
[Issue#] https://bugs.tizen.org/jira/browse/TT-70
[Problem] ewk_context_favicon_database_directory_set needs to be removed
[Cause] Internal API shouldn't be used in this project
[Solution] Remove the call to this function
[Verify] Perform basic sanity check.
Change-Id: I67bd61e1c92704c43d833f2f9a1ecc862d03130a
k.lis2 [Tue, 21 Jul 2015 11:50:39 +0000 (13:50 +0200)]
Bug TT-69 Remove private ewk_cookie_manager_persistent_storage_set calls
[Issue#] https://bugs.tizen.org/jira/browse/TT-69
[Problem] ewk_cookie_manager_persistent_storage_set calls persist
in the code
[Cause] -
[Solution] Remove ewk_cookie_manager_persistent_storage_set
calls from browser code.
[Verify] Perform browser sanity check.
Change-Id: I516f9881e81e5f5a2dd1f2f44df2ae31c7bc6e33
Signed-off-by: k.lis2 <k.lis2@samsung.com>
k.lis2 [Tue, 21 Jul 2015 11:54:00 +0000 (13:54 +0200)]
Bug TT-67 Remove private ewk_view_context_ APIs from browser code
[Issue#] https://bugs.tizen.org/jira/browse/TT-67
[Problem] ewk_view_context_ APIs persist in the code
[Cause] -
[Solution] Remove the context api calls from the code.
[Verify] Perform browser sanity check.
Change-Id: Id92d143ab383a701e7c36c249db5e4937760ac84
Signed-off-by: k.lis2 <k.lis2@samsung.com>
k.lis2 [Fri, 31 Jul 2015 09:29:59 +0000 (11:29 +0200)]
Bug TT-71 Remove private ewk_auth_* and ewk_ceritifcate_* API calls
[Issue#] https://bugs.tizen.org/jira/browse/TT-71
[Problem] Private api calls within browser code
[Cause] -
[Solution] Remove auth and certificate api calls from browser code.
[Verify] Auth and Certificate functionality is not expected
to work after this change.
Change-Id: I60167ea847bc535e292681542b5d9af04c5d3817
Signed-off-by: k.lis2 <k.lis2@samsung.com>
k.lis2 [Tue, 21 Jul 2015 14:37:22 +0000 (16:37 +0200)]
Bug TT-70 Remove remaining private API calls from browser code
[Issue#] https://bugs.tizen.org/jira/browse/TT-70
[Problem] Remaining private apis called in the code
[Cause] -
[Solution] Remove the rest of private api calls from the code.
[Verify] Perform basic sanity check. Zoom & thumbnail
functionalities do not work.
Change-Id: I5e700493534a93f9fa81204ec298cbbbbed59e86
k.lis2 [Tue, 21 Jul 2015 14:09:04 +0000 (16:09 +0200)]
Bug TT-66: Remove private ewk_view_javascript_* APIs from browser code
[Issue#] https://bugs.tizen.org/jira/browse/TT-66
[Problem] Private ewk_view_javascript_ APIs persist in the code
[Cause] -
[Solution] Removejs api calls from the code.
[Verify] Calls to ewk_view_javascript_ API are within dead code
so just run the browser to verify the build was
correct.
Change-Id: I621f082ffc04c453f27b5068f31cdf8b8b8b7f10
Signed-off-by: k.lis2 <k.lis2@samsung.com>
k.lis2 [Thu, 23 Jul 2015 10:32:08 +0000 (12:32 +0200)]
Bug TT-68 Remove private ewk_*_permission_request_* APIs from browser code
[Issue#] https://bugs.tizen.org/jira/browse/TT-68
[Problem] ewk_*_permission_request_* APIs persist in the code
[Cause] -
[Solution] Remove the permission request api calls from the code.
[Verify] This modification can be tested using files attached
in bugzilla.
Change-Id: I2e0514e1db8f063b27b2cb316e7a9224487315c6
Signed-off-by: k.lis2 <k.lis2@samsung.com>
k.lis2 [Tue, 14 Jul 2015 11:59:14 +0000 (13:59 +0200)]
Bug TT-65 Remove the ewk_view_smart APIs from the browser code
[Issue#] https://bugs.tizen.org/jira/browse/TT-65
[Problem] ewk_view_smart APIs persist in the code
[Cause] -
[Solution] Remove the smart api calls from the code.
[Verify] This modification can be tested on www.html.am,
w3schools.com and many other sites.
Change-Id: I59e74a2c7ea2ad0f4e5cda756323b32deec83810
Signed-off-by: k.lis2 <k.lis2@samsung.com>
t.dakowicz [Wed, 5 Aug 2015 11:47:59 +0000 (13:47 +0200)]
Bug TT-88 Fixed asynchronous favicon loading
[Issue] https://bugs.tizen.org/jira/browse/TT-88
[Problem] Favicon wasn't loaded if an image was send
asynchronously
[Solution] Used "icon,received" callback instead of "favicon,change"
which is not implemented
[Verify] Check if favicon is always loaded
Change-Id: If56b9b4d80bc4a94abd52b0830aac42dfa88216f
k.lis2 [Tue, 4 Aug 2015 08:31:47 +0000 (10:31 +0200)]
Task TT-79 Implement Setting view
[Issue#] https://bugs.tizen.org/jira/browse/TT-79
[Problem] Task TT-79 Implement Setting view
[Cause] -
[Solution] Add SettingsUI. Enable code referring to
SettingsUI in SimpleUI.
[Verify] Perform basic sanity check.
Change-Id: Ia1c25f3ac47e25a8b0707b1679671ea6325d8fd4
k.lis2 [Tue, 4 Aug 2015 14:06:54 +0000 (16:06 +0200)]
Task TT-80 Implement History view
[Issue#] https://bugs.tizen.org/jira/browse/TT-80
[Task] TT-80 Implement History view
[Cause] -
[Solution] Add HistoryUI. Enable code referring to
HistoryUI in SimpleUI
[Verify] Perform basic sanity check.
Change-Id: I87c20a27f825cda1ec7166e16133f2a5328c45a4
k.lis2 [Tue, 4 Aug 2015 08:24:57 +0000 (10:24 +0200)]
Task TT-77 Implement More Menu view
[Issue#] https://bugs.tizen.org/jira/browse/TT-77
[Task] TT-77 Implement More Menu view
[Cause] -
[Solution] Add MoreMenuUI. Enable code referring to
MoreMenuUI in SimpleUI
[Verify] Perform basic sanity check.
Change-Id: If623da956d560be47550a429f461443919ce3675
k.lis2 [Tue, 4 Aug 2015 08:16:56 +0000 (10:16 +0200)]
Task TT-76 Implement Bookmark view
[Issue#] https://bugs.tizen.org/jira/browse/TT-76
[Task] TT-76 Implement Bookmark view
[Cause] -
[Solution] Add BookmarkManagerUI. Enable code referring to
BookmarkManagerUI in SimpleUI.
[Verify] Perform basic sanity check.
Change-Id: I196746e4153d0b9ce86b562fbcd82f33068eef14
k.lis2 [Tue, 4 Aug 2015 08:27:40 +0000 (10:27 +0200)]
Task TT-78 Implement Tab Manager view
[Issue#] https://bugs.tizen.org/jira/browse/TT-78
[Problem] Task TT-78 Implement Tab Manager view
[Cause] -
[Solution] Add TabUI. Enable code referring to TabUI in SimpleUI.
[Verify] Perform basic sanity check.
Change-Id: I3745297ce0e82320ccd32d0897ac3d3716574fbc
t.dakowicz [Fri, 31 Jul 2015 08:35:44 +0000 (10:35 +0200)]
Bug TT-87 History button is disabled after opening a browser
[Issue#] https://bugs.tizen.org/jira/browse/TT-87
[Problem] History is not loaded on a first run, it is done
after invoking SimpleUI::showHistory()
[Solution] Loaded the history at the beginning
[Verify] Check if the history can be shown after opening
a browser
Change-Id: I875e2813ec641cf861d4eaff6c7a393e92e74e11
t.dakowicz [Thu, 30 Jul 2015 09:24:24 +0000 (11:24 +0200)]
Bug TT-81 Changed URL validation regex
[Issue#] https://bugs.tizen.org/jira/browse/TT-81
[Problem] Browser tries to navigate to malformed URLs instead
of putting them into search engine query
[Solution] Corrected the regex
[Verify] Check if URLs with spaces are put into Google's search query
Change-Id: Ic49cfa498194cf878bab70007a7dae8ada53708e
k.lis2 [Wed, 29 Jul 2015 13:44:44 +0000 (15:44 +0200)]
Task TT-75 Implement "Main page loading UI" view
Merge main page UI from the new ui imeplementation. This commit
includes the following major changes:
* Remove BookmarksUI service
* Add MainUI service
* Add BookmarksManager
* Merge all changes in SimpleUI, code which refers to parts which
are to be merged in consecutive tasks is currently ifdef'ed
* Merge all changes in BookmarkService and HistoryService
Change-Id: Idbdfd334d61af3370be79fa936a31a5e044e514c
Jung Ick Guack [Thu, 9 Jul 2015 01:18:46 +0000 (10:18 +0900)]
Fixed privilege for web-history.admin
Change-Id: I3c3c35421d7bb229af00e283e4686eafde7268a4
Signed-off-by: Jung Ick Guack <ji.guack@samsung.com>
sungwon2.han [Tue, 7 Jul 2015 05:23:30 +0000 (14:23 +0900)]
Change text wrap type of popup object from CHAR to WORD
Change-Id: Ib47aa1c143aca49c0fe079383efc77e0aaaacf68
Signed-off-by: sungwon2.han <sungwon2.han@samsung.com>
sungwon2.han [Tue, 7 Jul 2015 04:50:54 +0000 (13:50 +0900)]
Delete "Private Browsing" menu item from "Settings"
Change-Id: Ifb7a23d1bbc618469f055054188e5bc51f0bcc59
Signed-off-by: sungwon2.han <sungwon2.han@samsung.com>