Suyeon Hwang [Mon, 24 Jul 2023 04:53:48 +0000 (13:53 +0900)]
Update version (1.80.3)
Change-Id: I468af7803bdf6863022413992a051b8593855c07
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 18 Jul 2023 10:21:24 +0000 (19:21 +0900)]
Fix typo in function and variable names
Change-Id: I55cb92a1b44c0d2e136baf1caa897a4826346c7f
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 18 Jul 2023 07:35:44 +0000 (16:35 +0900)]
Fix coding style for internal function and constant
- Contents:
This patch removes the two underscore identifier from function name. And
also this patch renames the constant variables to fit the common coding
convention.
Change-Id: I6df8cec4d4f35697a4a840889f49aa5f15dc88c3
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 18 Jul 2023 07:23:08 +0000 (16:23 +0900)]
Fix the description of each test cases
- Content:
This patch fixes the description proper. It is no neccessary but this
change will help to understand each test cases.
Change-Id: I1be749e7c6c9fd01b35803fe7261c993b5d8e48b
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 3 Jul 2023 08:42:49 +0000 (17:42 +0900)]
Remove unused or unreachable code
- Contents:
This patch removes some unused or unrechable code. Through this patch,
unvaluable code is removed and also test cases covers more code and
logics.
Change-Id: I7822086a9160fafd6014e6759508a6cf3cfaa2cb
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 3 Jul 2023 07:55:00 +0000 (16:55 +0900)]
Add new test cases to increse the coverage
- Contents:
This patch adds new test cases for uncovered line. Through this patch,
developers can check the behavior about specific situations.
Change-Id: I5e9175a9997ff26c58cd4b6ab31e05dd154b4408
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 30 Jun 2023 12:10:44 +0000 (21:10 +0900)]
Refactor unit tests with utility class
- Contents:
This patch fixes all unit tests using new utility class from previous
commit. Through this change, many duplicated codes in test cases can be
removed.
Change-Id: Ia869ae0b334e2505deaebbf9c9484bef36a58468
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 29 Jun 2023 01:56:39 +0000 (10:56 +0900)]
Add test utility class
- Contents:
This patch introduces new utility class for test case. Through this
class, developers can easily make the test cases. This new class
provides many useful utility methods and frequently used code blocks.
Change-Id: Ife285e7e7bd065423197727bcaeb72219a3ecc8e
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
wn.jang [Thu, 6 Jul 2023 05:14:48 +0000 (14:14 +0900)]
Change error to no error, when speak data is empty
Cause: In the __wait_synthesis() function, if the synth_control is changed from DOING
to DONE and there's no next speak_data, the synthesis is terminated. At this time, it
is normal operation, even if there's no speak data.
Solution: Change error to no error, when speak data is empty.
Reference log:
01-27 05:01:43.733+0900 I/ttsd (P 798, T 798): ttsd_server.c: __wait_synthesis(100) > [Server] synth_control(1)
01-27 05:01:43.733+0900 D/ttsd (P 798, T 798): ttsd_server.c: __synthesis(116) > @@@ SYNTHESIS START
01-27 05:01:43.733+0900 W/ttsd (P 798, T 798): ttsd_data.cpp: ttsd_data_get_speak_data(563) > [DATA WARNING] There is no speak data
01-27 05:01:43.733+0900 D/ttsd (P 798, T 798): ttsd_server.c: __synthesis(121) > @@@ Fail to get speak data. ret(-
49348604)
01-27 05:01:43.733+0900 D/ttsd (P 798, T 798): ttsd_server.c: __synthesis(122) > @@@ SYNTHESIS END
Change-Id: I8ce4823ee9791b1b2854c1f1ed7c01469151807e
wn.jang [Tue, 4 Jul 2023 10:51:47 +0000 (19:51 +0900)]
Send synthesized PCM data from TTS engine to client
Change-Id: I91dd83aaa808fa46bc2e4768797db66da3f524c1
Suyeon Hwang [Mon, 5 Jun 2023 02:00:12 +0000 (11:00 +0900)]
Update version (1.80.2)
Change-Id: Ie7bdbf99e02260da7de2e4d9078baa982e54fe18
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 2 Jun 2023 11:27:19 +0000 (20:27 +0900)]
Destroy old rpc handle for clean reconnection
- Issue:
When the client is disconnected, sometimes, the rpc handle can be
expired.
- Solution:
When the client is disconnected, the client should try to reconnect.
However, sometimes, the client can try to reconnect with expired rpc
handle. In this case, the client library can not create new rpc handle,
because current logic only makes new rpc handle if the function returns
I/O error. To resolve this issue, this patch destroyes the old handle
if the client is disconnected. Through this change, the client will be
sure to reconnect with new rpc handle.
Change-Id: Ic801abf2f69a291ca6b5c8748a67f987be81aa93
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
wn.jang [Fri, 2 Jun 2023 06:11:44 +0000 (15:11 +0900)]
Update version (1.80.1)
Change-Id: Ic0834deb2ffac2c1df02882cbc4cf6d33d667818
wn.jang [Fri, 2 Jun 2023 05:30:53 +0000 (14:30 +0900)]
Add binary file to support risc64 build
Change-Id: I457e42fc9af41fd50092d2e6110ad701e3771b6f
Suyeon Hwang [Wed, 31 May 2023 01:28:24 +0000 (10:28 +0900)]
Update version (1.80.0)
Change-Id: I88058c8dd0e61ffc417cd065329fac37a5e4c9fc
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 31 May 2023 01:27:40 +0000 (10:27 +0900)]
Fix tizen version description (7.5 -> 8.0)
Change-Id: I9bfe513275e17c3d373c4d826b945e8f66d8fd48
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 8 May 2023 06:18:47 +0000 (15:18 +0900)]
Update version (1.75.10)
Change-Id: Iecc5d11592f204fd3c97aa4e2edafc0b39d1b839
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 8 May 2023 06:15:02 +0000 (15:15 +0900)]
Set status vconf when the synthesis is started
Change-Id: Id6152a67321c63d917fb763a5837e35f5ea36386
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 24 Apr 2023 02:51:08 +0000 (11:51 +0900)]
Revert owner as 'ui_fw'
Change-Id: I6ff2bafe0b459baf8a107eb1f67ac6cde9bd9fd8
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 21 Apr 2023 08:38:02 +0000 (17:38 +0900)]
Add write permission to group
Change-Id: I518bd6381b25267cd42fc79e485eb3a2fca92d1e
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 21 Apr 2023 04:21:41 +0000 (13:21 +0900)]
Update version (1.75.9)
Change-Id: I189d0395f75140faf5ad35fcb1b8865144e6a72c
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 20 Apr 2023 02:29:09 +0000 (11:29 +0900)]
Fix pointer checking condition and owner of config file
- Issue:
tts_setting_set_voice() does not set voice properly.
- Solution:
Previous code validates the voice with invalid condition. So, the
function returns error even if the voice is valid. Meanwhile, the app
can not write the config file because of the owner of the file. To
resolve these issues, this patch fixes the checking condition and owner
of config file. Through this patch, the function will properly set the
voice.
To resolve this
issue, this patch fixes the condition as a right way.
Change-Id: I01ac1fd09edb9a10ea365c2376ccf3d6d7a9c4f1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 19 Apr 2023 11:26:35 +0000 (11:26 +0000)]
Merge "Update version (1.75.8)" into tizen
Wonnam Jang [Wed, 19 Apr 2023 09:53:25 +0000 (09:53 +0000)]
Merge "Add logs to measure xRT for synthesizing from tts engine" into tizen
Suyeon Hwang [Wed, 19 Apr 2023 08:36:35 +0000 (17:36 +0900)]
Update version (1.75.8)
Change-Id: Ia522f2b9b72e4a97789785a84304cbf663a070d2
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
wn.jang [Thu, 13 Apr 2023 01:30:17 +0000 (10:30 +0900)]
Add logs to measure xRT for synthesizing from tts engine
Change-Id: I9a43b12403df907db02d6309a5cdd4c5957a3be8
Suyeon Hwang [Wed, 19 Apr 2023 02:43:53 +0000 (11:43 +0900)]
Pass missing parameter to real function
- Issue:
After reprepare_on_demand(), the client handle is missing.
- Solution:
Previous code does not pass all neccessary parameters, so the function
can write value into arbitrary pointer. And this pointer access can
cause critical memory crash. Thus, this patch fixes the code to make
sure the tts_ipc module pass all proper parameters to actual function in
tts_dbus and tts_tidl module.
Change-Id: I2276c05e3b29f070664b8fad607cc1d13ddb9cee
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 17 Apr 2023 11:29:19 +0000 (20:29 +0900)]
Update version (1.75.7)
Change-Id: Icb8c92cd7b57b45422c018ee74dd31944573d7d0
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 18 Apr 2023 02:39:17 +0000 (11:39 +0900)]
Move unreleased definitions to the internal header
Change-Id: I4746d219d5385713b278bca58abf9115061837c3
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 17 Apr 2023 11:26:10 +0000 (20:26 +0900)]
Fix wrong condition for parameter checker
- Issue:
tts_set_playing_mode() always returns invalid parameter error.
- Solution:
This patch fixes the condition for parameter checker in
tts_set_playing_mode(). Previous condition statement always returns
true, so the function works wrong. Through this patch, the function will
properly check the paramter.
Change-Id: I2fdb5254f942f6e9c1c1741e241bcfc32fe4cbdf
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 17 Apr 2023 07:21:43 +0000 (16:21 +0900)]
Update version (1.75.6)
Change-Id: I58057a859231875fe95e2927e7e9aef7474f0fe0
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 17 Apr 2023 06:48:57 +0000 (15:48 +0900)]
Prohibit engine ID access after tts_core_deinitialize()
- Issue:
check_engine_launching_status() is invoked and it makes the segmentation
fault even though tts_core_deinitialize() is already finished.
- Solution:
After tts_core_deinitialize(), there is no client, so
check_engine_launching_stats() is not neccessary to be invoked. However,
previous code does not unset the callback, so the callback is still
invoked and it makes segmentation fault error by accessing invalid
pointer. To resolve this issue, this patch makes the code unset the
callback in tts_core_deinitialize(). And also this patch adds null
checker in the callback. Thus, invalid pointer access will not occur
through this patch.
Change-Id: I703e0a0e3cbc7d548e84b274609f27d9442d8537
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 6 Apr 2023 06:56:21 +0000 (15:56 +0900)]
Update version (1.75.5)
Change-Id: I08dd17b619db1e69166b21ee7f551e7e62ed0b55
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 5 Apr 2023 12:30:11 +0000 (21:30 +0900)]
Set name for TTS player thread
Change-Id: I72067b8a0e59e2529157d59e4a9bac6e59ce7937
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
wn.jang [Fri, 9 Dec 2022 09:39:39 +0000 (18:39 +0900)]
Add to set playing mode to decide where the synthesized pcm data will be played
Needs: The application wants to play the synthesized pcm data on client side.
Solution: Provides the Api to set playing mode to decide where it will be played.
This commit is related to following commit.
https://review.tizen.org/gerrit/#/c/platform/core/uifw/tts/+/284933/
Change-Id: If9e73f05409feab8e9ff371aee1570b38d6e2407
dyamy-lee [Fri, 31 Mar 2023 01:12:49 +0000 (10:12 +0900)]
Update version (1.75.4)
Change-Id: I931f1687cd0ec57f051f76f60bd9eb9f64d43281
dyamy-lee [Thu, 30 Mar 2023 11:48:36 +0000 (20:48 +0900)]
set option -t on engine-info directory
- Issue : When engine config file created, the file's smack label is still not follow directory.
- Solution : By giving transmute option of smack, it can works all created file and directory get same smack label with this directory.
Change-Id: I0ca6d2a9f0aef13ff252d3b94a61f5ab6313f35c
dyamy-lee [Thu, 30 Mar 2023 06:56:39 +0000 (15:56 +0900)]
change the timing of smack label change in spec file
- Issue : tts directory which under .voice directory is not applied change of smack label, becasue it did before directory created.
- Solution : Change the timeing of execution smack label change after tts directory created.
Change-Id: I40ca5df3d735382fb91f4f002ec728d81e7ad9dd
dyamy-lee [Thu, 30 Mar 2023 02:43:17 +0000 (11:43 +0900)]
Smack label change in spec file
- Issue : After tts engine update, a config file which created under engine-info directory is changed following installing program's smack label.
So, it's not working after engine update.
- Solution : By change smack label from underscore('_') to specific label('User::App::Shared'),
it can prevent following installing program's smack label
Change-Id: If90b4e42201e4573d80a2a64855aa08076c065d8
dyamy-lee [Wed, 22 Mar 2023 06:09:41 +0000 (15:09 +0900)]
Update version (1.75.3)
Change-Id: I34e0e65cb70002abcd22babccc1ffb7276d865d6
dyamy-lee [Tue, 21 Mar 2023 07:50:15 +0000 (16:50 +0900)]
Resolve unused value and overite problem
- Issue : coverity reports these as issues. It does free and set NULL, but when assigning value NULL, that stored value is overwritten before it can be used.
- Solution : define value in that value's scope
Change-Id: I53644403ff1595cdfad790d7b454d2b33a0a8e44
dyamy-lee [Wed, 21 Dec 2022 06:53:13 +0000 (15:53 +0900)]
Change directories' permission of config xml file
- Issue : In case of root daemon, it cannot read tts-config file because permission didn't allow it.
- Solution : We change tts-config file's directory permission every user can read the tts-config file.
Change-Id: I133de3acfbb8286890558837953cfa871c5dd413
sooyeon [Fri, 26 Aug 2022 02:39:43 +0000 (11:39 +0900)]
Change directories of tts-config file and engine-info file
- Issue: In case of root daemon, it cannot access tts-config file and engine-info file,
because they are installed in user directories respectively.
- Solution: We move tts-config file and engine-info file to global user data (/opt/usr/data)
to make both root daemon and users access the files.
Change-Id: Iedd7249b3526edaa600805d1a8c3f3c6504b7549
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
wn.jang [Tue, 21 Mar 2023 01:59:15 +0000 (10:59 +0900)]
Update version (1.75.2)
Change-Id: I2d840d64edac48d17b99b786238cb05b74f931ad
wn.jang [Tue, 21 Mar 2023 00:49:09 +0000 (09:49 +0900)]
Fix memory leak detected by static analysis tool
Change-Id: I332780d46eb2d8ad297a0526a87eac1ae06afdad
Suyeon Hwang [Thu, 16 Mar 2023 00:35:39 +0000 (09:35 +0900)]
Update version (1.75.1)
Change-Id: I1c35ae367783fd6579227c28dee8a5b016f4d192
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 15 Mar 2023 01:09:55 +0000 (10:09 +0900)]
Add the version notification for new enum values
- Requirements:
New enum values require the version description.
- Contents:
This patch adds the version description for new enum values.
Change-Id: I25f7db9189cb2594c92e70d6056ba9d6a2d79650
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 9 Mar 2023 02:21:11 +0000 (11:21 +0900)]
Update version (1.75.0)
Change-Id: I184c08b8358b590c2254488adeaafe710fa2e6dd
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 24 Feb 2023 05:14:10 +0000 (14:14 +0900)]
Invoke config changed callbacks directly
- Issue:
If the app changes the config using setting API, the framework did not
invoke config changed callbacks.
- Solution:
In previous code, tts_config_mgr module can knows the config changes by
checking the difference between the values in memory and config file.
However, the values in memory and config file were the same if the app
uses the setting API. This is because the setting API sets the value to
both memory and the file.
So, this patch adds a new logic for invoking the callacks. Through this
patch, tts_config_mgr module calls the related callbacks in case the app
changes the config itself.
Change-Id: If2da13a32e8e12b321812586e4c4bb93fd5f769e
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 23 Feb 2023 06:47:49 +0000 (15:47 +0900)]
Refactor logic for automatically setting voice
- Issue:
The logic is too complicated to enhance and expand. And also, the logic
requires unnecessary duplicated code.
- Solution:
This patch refactors the logic for automatically setting voice. Through
this patch, the logic will become easier to read and enhance. And also,
this patch removes unnecessary duplicated code.
Change-Id: I214d1a4d0a31ed34d794573eec9cec405769cedf
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 23 Feb 2023 02:07:42 +0000 (11:07 +0900)]
Unify the order of log to store value
- Issue:
Each functions have different order of logic for storing value.
- Solution:
In previous code, some functions first stored file and then changed the
memory. However, some other functions did the reverse of it. So, this
patch unifies the order of logic for storing values in each functions.
Through this patch, all functions will store the file first and then
update the config struture on the memory.
Change-Id: Id8e4671bc342060c7c779578e7b3e75ea0dd640a
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 22 Feb 2023 04:27:06 +0000 (13:27 +0900)]
Fix client releasing code simpler
- Issue:
tts_config_mgr_unset_callback should be invoked for all clients when
they are released.
- Solution:
This patch fixes the __tts_config_release_client()'s behavior. Through
this patch, __tts_config_release_client() will invoke
tts_config_mgr_unset_callback() to reset all callbacks in client
structure.
And plus, this patch changes the name and type of these functions. These
two functions are only invoked in this file. This means that those
functions are private. So, this patch makes these functions as static
and changes the name of these functions which avoids the reserved
identifiers.
Change-Id: I2d20ca73595eacca5a37d8e84822a8d4e0602df7
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 2 Mar 2023 02:43:50 +0000 (11:43 +0900)]
Set invalid UID if getting value is failed
Change-Id: If06e2122c6a824f65b7485e586597e048d3af6c1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 7 Feb 2023 08:21:58 +0000 (17:21 +0900)]
Set service state by engine launching status
- Issue:
If the client is out of service by service reset, client can not get
proper service state.
- Solution:
By the on-demand reprepare logic, the clients subscribing service state
changed event can not get service state until that the client invokes
the API. However, if the client invokes the API depending on service
state, the client may not call the API, so it can be out of service
permanently.
To solve this problem, this patch adds logic for checking engine
launching status. Through this patch, the client library can check
whether the engine is launched or not. When the engine is launched, the
client library notifies the service state changed event to the client
app can run the code which depends on the service state.
Change-Id: If4e3310054143732f5705ed4acfae42762fa21b1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 6 Mar 2023 05:02:27 +0000 (05:02 +0000)]
Merge changes Ied3e8043,I465c4e34 into tizen
* changes:
Reprepare instantly for the client speicifed by server
Update UID of instant reprepare client
Suyeon Hwang [Thu, 16 Feb 2023 08:53:17 +0000 (17:53 +0900)]
Add feature checking logic for engine API
- Issue:
Most of the engine API did not return 'not supported error' when the
device does not support the TTS feature.
- Solution:
This patch adds feature checking logic to the beginning of each API
implementation. Through this change, each API will properly check the
required feature and return error. And this behavior is matched to the
description of each API.
Change-Id: I744cb3bbeb6670f3fdfedc1ecd3f9d710f822be2
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 7 Feb 2023 06:07:42 +0000 (15:07 +0900)]
Reprepare instantly for the client speicifed by server
- Requirement:
In order to start engine quickly, one of the clients needs to reprepare
instantly.
- Contents:
This patch adds new logic for repreparing. Through this patch, one of
clients which is specified by the server library will reprepare instantly
when the service is out. This specified client will help quick tts engine
launch.
Change-Id: Ied3e804378c835ea2e744bb948462337802ebc39
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 2 Feb 2023 08:10:38 +0000 (17:10 +0900)]
Update UID of instant reprepare client
- Requirement:
In order to start engine quickly, one of the clients needs to reprepare
instantly.
- Contents:
To make one of the clients reprepare instantly, this patch adds new
logic into the engine library. Through this patch, the engine library
will update the UID of the clieant which needs to reprepare instantly.
This UID update will occur when the connection of the service is changed.
Change-Id: I465c4e3444fbd177feb3bdabdb20338bbab5daf1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 20 Feb 2023 02:13:24 +0000 (11:13 +0900)]
Destroy tts handle always on the main thread
- Issue:
In C# application, the garbage colletor can destroy tts handle on a sub
thread, and this behavior can make thread safety issues.
- Solution:
The C# garbage collector can release the instance on a sub thread, so
this can make race condition issues. To prevent this kind of issues,
this patch adds a new logic to tts_destroy() function. Through this
change, the handle destruction logic of tts_destroy() will always be
run on a main thread. This change will prevent race condition issues
because the logic insures that every handle destructions are run on a
main thread and they are not destroyed at the same time.
Change-Id: I90c248a4975410d4211dea93f24ea43e7c00ecb1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 13 Jan 2023 08:19:26 +0000 (17:19 +0900)]
Try to prepare when the API is invoked on service out
- Requirement:
To reduce the resource for repreparing, clients need to reprepare when
the API is invoked.
- Contents:
This patch changes the logic about service reset and repreparing.
Through this patch, all clients just set service out flag when the
service reset occurs. Plus, each clients will try to reprepare when the
API is invoked by the app. In previous code, all clients tried to
reprepare at the same time when the service reset occurs. However, this
behavior needed to too much resource for repreparing in short time. This
patch intends to decrease the resource requirements for repreparing by
spreading the reprepare requests.
Change-Id: I4fd7b8905975692efba973a7e6c2423d604b4624
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 29 Dec 2022 11:10:41 +0000 (20:10 +0900)]
Store current service state from engine library
- Requirement:
Client library needs to get current service state when preparing is
succeeded.
- Contents:
This patch makes client library store the service state in client
structure when preparing is succeeded. If the client listen the service
state changed event, client has to maintain the current service state
even if the service is out. To do this, each client structure has to
store the current service state.
Through this patch, client structure can maintain the latest service
state at preparing success.
Change-Id: If2ea7b9ebc627363f0b16c51a918d2910a4bcd26
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 29 Dec 2022 09:04:34 +0000 (18:04 +0900)]
Send service state when preparing is succeeded
- Requirement:
Client library needs to get current service state when preparing is
succeeded.
- Contents:
This patch makes engine library send service state to client library.
To implement on-demand repreparing, client library needs to maintain
current service state. Through this patch, client library can get
service state in preparing protocol.
Change-Id: I7d8b7fb261401abcb230610aac0fd645bab015a1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 29 Dec 2022 08:01:33 +0000 (17:01 +0900)]
Add new IPC parameter for sending service state
- Requirement:
Client library needs to get current service state when preparing is
succeeded.
- Contents:
This patch changes the IPC interface parameter for service state. The
client library needs to service state information for enhancing
repreparing logic. Through this patch, client application can receive
service state information when preparing is succeeded.
Change-Id: I62eeab554074455d09ac1c28b369dde83318f399
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 26 Jan 2023 07:52:09 +0000 (16:52 +0900)]
Destroy RPC handle in ecore idler
- Issue:
Invoking tts_unprepare() in event callbacks is allowed and this may
cause segmentation fault by destroying RPC handle in the callback which
is invoked by RPC message.
- Solution:
The app can call tts_unprepare() in the callback. However, this
invocation may cause segmentation fault by destroying the RPC handle in
the callback of the RPC handle itself.
To solve this issue, this patch fixes the RPC handle destruction logic.
Through this patch, the client lib will destroy the handle in ecore idler
callback. This behavior can avoid wrong handle destruction.
Change-Id: I01a2ae528be8f0fa8683c608b3786b5db282d0e1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
(cherry picked from commit
96dd49ebd12b1c1853071cfe5e570e183c6133ee)
Suyeon Hwang [Thu, 26 Jan 2023 07:50:38 +0000 (07:50 +0000)]
Merge changes I0ab5030b,Ieed4a8fe into tizen
* changes:
Fix coding convention about member variables and static functions
Merge branch 'tizen_7.0' into tizen
wn.jang [Thu, 19 Jan 2023 06:04:15 +0000 (15:04 +0900)]
Extend time delay every 5 failures
Cause:
In case of robot image, pkgmgr_client_new() function always returns fail.
So it cause a lot of error message and it makes a huge log file over 1GB.
Solution:
Time delay is extended every 5 failures.
This patch makes only 92 errors in 1 day, and only 110 error messages in 10 days.
Change-Id: Ibd5e5844a543adc6831d5ce76858254505dcba3d
Suyeon Hwang [Thu, 19 Jan 2023 06:01:08 +0000 (15:01 +0900)]
Fix coding convention about member variables and static functions
- Issue:
Using two underscores(__) as name of variables or functions is
reserved by C and CPP compilers, so it may occur name colision.
- Solution:
Previously, most of the code followed old tizen coding convention.
However, in case of name, the convention conflicts with C and CPP
standard, because two underscore is already reserved as an identifier by
C and CPP standard. Thus, using two underscores may cause some problems.
To resolve this collision, this patch fixes the name of member variables
and static functions to match C and CPP standard. Through this patch,
CPP files in the project do not use two underscore as name of variables
and functions anymore.
Change-Id: I0ab5030b018d0d28c9cf2927ddbdf8711ecb788b
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 19 Jan 2023 06:23:12 +0000 (15:23 +0900)]
Merge branch 'tizen_7.0' into tizen
Change-Id: Ieed4a8fe9cd58f50ad26c227baf743119902ecc8
Suyeon Hwang [Tue, 10 Jan 2023 09:38:53 +0000 (18:38 +0900)]
Update version (1.70.17)
Change-Id: Ia967177c08ae60c7f59f41646da37316985f5aa3
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 10 Jan 2023 05:23:20 +0000 (14:23 +0900)]
Check and try to recreate the handle if the handle is invalid
- Issue:
Sometimes, the handle creation for audio framework is failed, but the
stt framework try to use this invalid handle.
- Solution:
The AudioStream class did not set nullptr to audio handles. Because of
this behavior, if the handle was not created from the audio framework,
the AudioStream class tried to use garbage pointer as audio handle. This
caused some crashes. To solve this issue, this patch makes the
AudioStream class initialize the audio handle as nullptr. And also, this
patch adds new code for re-creating audio handles of AudioStream and
BackgroundVolume class. This new code is going to be invoked when some
audio handles are not valid.
Change-Id: I7c98473bf9ced056e4a6dfd579455e94db0b9993
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 6 Jan 2023 01:21:38 +0000 (10:21 +0900)]
Update version (1.70.16)
Change-Id: I584b5a4484a89bba86ad3b8bafbb054d4b0b8cdf
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 3 Jan 2023 03:33:06 +0000 (12:33 +0900)]
Fix rpc port creation timing
- Issue:
Even if the tidl connection is out, client lib may ignore connect
request.
And also, the tidl can not re-connect synchronously right after the tidl
is disconnected.
- Solution:
TIDL connect request is up to connected flag variable in tidl info
structure. However, the connected flag is only set by connected,
rejected, and disconnected event callback. And also, tidl can not
re-connect synchronously right after the disconnect() of tidl is invoked.
So, current client lib can not connect to stub in some specific
situation.
To solve this issue, this patch changes the rpc port creation timing.
Through this patch, tts_tidl module always reset the rpc port when the
io error occurs. And also, tts_tidl module can assure the connection by
creating new rpc port when the client want to prepare.
Change-Id: I8cfc143aebb331389d1fb205b7526b43f0301fee
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 12 Dec 2022 11:09:41 +0000 (20:09 +0900)]
Merge branch 'tizen' into tizen_7.0
Change-Id: I9cb1e0ee0851c6cbdeade7f9ce67487f0cc55d89
Wonnam Jang [Fri, 9 Dec 2022 09:37:47 +0000 (09:37 +0000)]
Merge "Add codes in client side to set/unset callback for retrieving sythesized pcm data" into tizen
Suyeon Hwang [Thu, 8 Dec 2022 05:59:56 +0000 (14:59 +0900)]
Update version (1.70.15)
Change-Id: I3924400bb6249e2d9f5d8a21546c92e71953baaa
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 8 Dec 2022 02:02:12 +0000 (11:02 +0900)]
Try to reprepare when IPC I/O error occurs
- Issue:
TTS API will be failed when the engine is terminated after the client
library already sends request.
- Solution:
Current client library does not handle the network connection failed
situation because almost those situations are covered by reprepare
logic. However, if the engine is terminated without handling client IPC
message, client library should returns error.
Thus, this patch adds new retry logic when network error occurs. Through
this logic, some of the issue case will be covered. However, if engine
has critical issue, then this logic also can cover those situations.
Change-Id: I07075e0139d058f9f9bc84026a00309bf1815066
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
wn.jang [Thu, 1 Dec 2022 07:48:34 +0000 (16:48 +0900)]
Add codes in client side to set/unset callback for retrieving sythesized pcm data
Change-Id: I938872f2546f8462eb8ffd10fc40b522909ee16c
Suyeon Hwang [Tue, 22 Nov 2022 04:47:47 +0000 (13:47 +0900)]
Update version (1.70.14)
Change-Id: I3035a53632eb0a2803efee077faff67e62a72a6e
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 22 Nov 2022 01:12:38 +0000 (10:12 +0900)]
Add TC for checking prepare
- Contents:
This patch adds new TC for check whether tts_prepare() properly succeed
after tts_unprepare().
Change-Id: I3766898d06f33c18a07c80a201e125de94789325
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 21 Nov 2022 10:37:27 +0000 (19:37 +0900)]
Assure that client always registers the callback in sync prepare
- Issue:
Sometimes, the message receive callback registration is skipped even if
the connection is normal.
- Solution:
The client lib always checks the 'register_callback_invoked' flag, but
this flag may not be set properly some cases even if client tries to
prepare synchronously. Thus, this patch removes the flag checking code
from synchronous prepare logic. The synchronous prepare should insure
the invocation of all protocol, so through this patch, the all step of
preparation will be invoked.
Change-Id: If89f4065f139ec032bedddebf6a9927c74f100e7
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 17 Nov 2022 01:08:32 +0000 (10:08 +0900)]
Update version (1.70.13)
Change-Id: Ic76ca3b081b7a38de6b3d0912b3cbea1997cfa71
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 16 Nov 2022 11:11:19 +0000 (20:11 +0900)]
Add mutex for set repeat text
- Issue:
Sometimes, invalid access occurs if app tries to add text in multi
thread enviroment.
- Solution:
App can add text frequently. And also, app can add text in multi thread
enviroment. However, the text_repeat property of client is not safe in
multi thread enviroment. Thus, this patch adds mutex lock for protect
text_repeat from race condition. Through this patch, app can be add text
safely in multi thread.
Change-Id: Iffcce54fcbc34436bf9f4d7ec7aadf571f05889b
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 8 Nov 2022 10:53:30 +0000 (19:53 +0900)]
Merge branch 'tizen' into tizen_7.0
Change-Id: I5a6cc17069ed5460946025805f916770ac0ff6a1
Suyeon Hwang [Mon, 7 Nov 2022 04:47:24 +0000 (13:47 +0900)]
Remove logs making delay of IPC
- Issue:
Sometimes, the IPC request from client is delayed.
- Solution:
By the priority of the process, app manager APIs can be delayed. Thus,
this patch removes some logs that needs to invoke app manager APIs.
Through this patch, the IPC requests will be invoked directly without
any delay.
Change-Id: I19feed1a444364da4f54a729b72ab562a5ea2865
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 7 Nov 2022 04:55:38 +0000 (13:55 +0900)]
Update version (1.70.12)
Change-Id: I6a125484a513bce5e8555ec85b69b46dd90d7668
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 7 Nov 2022 04:47:24 +0000 (13:47 +0900)]
Remove logs making delay of IPC
- Issue:
Sometimes, the IPC request from client is delayed.
- Solution:
By the priority of the process, app manager APIs can be delayed. Thus,
this patch removes some logs that needs to invoke app manager APIs.
Through this patch, the IPC requests will be invoked directly without
any delay.
Change-Id: I19feed1a444364da4f54a729b72ab562a5ea2865
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 2 Sep 2022 05:05:40 +0000 (14:05 +0900)]
Delete timer handle for service state changed notification
- Issue:
The timer handle for service state changed notification is not deleted
if ttsd_finalize() is invoked before that the timer is handled.
- Solution:
This patch makes ttsd_finalize() delete the timer handle. And also, the
memory which stores the state change information should be deleted with
deleting the timer, because the memory is allocated for this timer
behavior.
Change-Id: I7a429c8ab5fb89237ba38c2b1c44c9d606ef01dd
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 2 Sep 2022 02:11:14 +0000 (11:11 +0900)]
Send callback message to clients which set callback
- Requirements:
Server wants to send required IPC message when service state is changed.
- Solution:
Through previous commit, callback registration information was added.
Using this new information, server can decide whether the client require
to receive service state changed event. This patch adds checker for
deciding whether client regists callback.
Change-Id: I3ea1cc9e61626f393dc49a9bceff6c4b05a4a77c
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 1 Sep 2022 11:25:30 +0000 (20:25 +0900)]
Add callback set information into prepare interface
- Requirement:
Server wants to information about whether the client set the service
state changed callback.
- Solution:
Service state is frequently changed, so IPC for notification of service
state change is invoked so many times for all client. However, most of
the client did not register the callback, so many resource can be
wasted by this unvaluable invocation. To reduce wasted resources, this
patch adds callback registration information into IPC interface.
Through this new information server can send valid notification without
waste.
Change-Id: I8a70b694854eefa9c1f2e58726cb6f4c54ba2f65
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 2 Nov 2022 06:59:36 +0000 (15:59 +0900)]
Clean up unnecessary header files
Change-Id: If88d1be2aef5989c2e5859750f9a97e2a273fae5
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 14 Oct 2022 02:58:40 +0000 (11:58 +0900)]
Fix static anlysis issues
- Contents:
This patch includes these changes:
- Remove equality check of floating point values.
- Remove TOC-TOU problem.
- Make blocks for code in switch-case statements.
- Remove arguments from void parameter function.
Change-Id: I119d15f3a600a9cf51e5b9150a69530f782cd04b
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
sooyeon [Fri, 28 Oct 2022 01:44:09 +0000 (10:44 +0900)]
Change sound_server_ready to focus_server_ready
Change-Id: I120f3efc7514c71ee294e8267a6b1c683bc13850
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Fri, 28 Oct 2022 01:44:09 +0000 (10:44 +0900)]
Change sound_server_ready to focus_server_ready
Change-Id: I120f3efc7514c71ee294e8267a6b1c683bc13850
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
Jihoon Kim [Tue, 18 Oct 2022 06:39:37 +0000 (06:39 +0000)]
Merge changes I439a2879,Iaef6463d into tizen
* changes:
Remove trailing whitespaces
Fix typo issue in tts_setting document
Jihoon Kim [Tue, 18 Oct 2022 06:31:22 +0000 (15:31 +0900)]
Remove trailing whitespaces
Change-Id: I439a2879de0c3f4dde3f21b47483798d0fa52cb4
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jihoon Kim [Tue, 18 Oct 2022 06:21:13 +0000 (15:21 +0900)]
Fix typo issue in tts_setting document
Change-Id: Iaef6463d77ebe7a742c9e7cd3c4ffd1a148f4413
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Suyeon Hwang [Thu, 13 Oct 2022 09:27:16 +0000 (18:27 +0900)]
Update version (1.70.12)
Change-Id: I0cf661a275ac86b49f0cbd6240fff581a17d694f
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 13 Oct 2022 07:45:49 +0000 (16:45 +0900)]
Set engine id from vconf value when default config is set
- Issue:
When default configuration is loaded, invalid engine id can be set.
- Solution:
Default configuration stores fixed engine id, so the engine id can be
not installed in the image. Thus, this patch changes the logic for
loading default configuration. Through this patch, vconf value is used
default engine id when default configuration is loaded.
Change-Id: Ifa37d1eceb5df126b69ac7455aea0dc0e12005fa
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
sooyeon [Wed, 5 Oct 2022 05:40:36 +0000 (14:40 +0900)]
Rollback of changing engine-info directories and file mod
Change-Id: If455a705207a310818345fa121d159b907998d62
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
wn.jang [Thu, 22 Sep 2022 05:40:11 +0000 (14:40 +0900)]
Update version (1.70.11)
Change-Id: Ib203747a3b2b43bd1acd8efefcc1d9be5a2997be