Semun Lee [Wed, 18 Mar 2020 06:46:45 +0000 (15:46 +0900)]
Fix SIGBUS in pipe backend
make log entry to be aligned by 4
Change-Id: Ibe17b0f7e99dfcdf823b4dc8d328f4c65b4c436a
Signed-off-by: Semun Lee <semun.lee@samsung.com>
Michal Bloch [Tue, 17 Mar 2020 18:38:49 +0000 (18:38 +0000)]
Merge changes I6d9bf6cd,If5f5eebd,Icf4b49c2,Ib4f2522d into tizen
* changes:
libdlogutil: extract more locals into the state
libdlogutil: mainloop accepts state by param
libdlogutil: extract state initialisation
libdlogutil mainloop: keep state in a struct
Mateusz Majewski [Tue, 17 Mar 2020 15:59:42 +0000 (16:59 +0100)]
Fix integration tests
Change-Id: I1ce295e95902e44d319999d98435434d14eb971f
Michal Bloch [Tue, 17 Mar 2020 15:11:56 +0000 (16:11 +0100)]
Workaround gettid test failure
Change-Id: Ie36fb856973f2d180da562d3c0d6d6ee380f46c7
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Agnieszka Baumann [Mon, 9 Mar 2020 19:00:30 +0000 (20:00 +0100)]
libdlog_android divided into positive and negative tests
Change-Id: I06842f7ed3a9ac619b94d5b767fbee8560fcc090
Agnieszka Baumann [Mon, 9 Mar 2020 17:18:03 +0000 (18:18 +0100)]
libdlog_base divided into positive and negative tests
Change-Id: I75319256eca5d110cf5c2439097e9c1f50a65d79
Agnieszka Baumann [Mon, 10 Feb 2020 15:50:03 +0000 (16:50 +0100)]
Fix -Wextra and -pedantic errors
Change-Id: I9267a6c9eabd680c5306ad6d80cf4be72b05355a
Agnieszka Baumann [Mon, 9 Mar 2020 15:39:39 +0000 (16:39 +0100)]
kmsg_parser divided into positive and negative tests
Change-Id: I2ec28842022640869856a6af9b71fa1ffe8eb986
Mateusz Majewski [Fri, 13 Mar 2020 12:23:09 +0000 (13:23 +0100)]
Document disabling SIGPIPE
Change-Id: If0865473e70d195b0d133d60bd8b870a9261ef8c
Michal Bloch [Fri, 13 Mar 2020 12:08:45 +0000 (12:08 +0000)]
Merge "Inline flush" into tizen
Michal Bloch [Fri, 13 Mar 2020 12:08:45 +0000 (12:08 +0000)]
Merge changes into tizen
Michal Bloch [Fri, 13 Mar 2020 12:08:45 +0000 (12:08 +0000)]
Merge "Move callback call out of fdi_push_log" into tizen
Michal Bloch [Tue, 10 Mar 2020 17:44:25 +0000 (18:44 +0100)]
libdlogutil: extract more locals into the state
Change-Id: I6d9bf6cd7a0681320f9b56fec50b28bceca213ee
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 10 Mar 2020 17:13:37 +0000 (18:13 +0100)]
libdlogutil: mainloop accepts state by param
Change-Id: If5f5eebdd06c5fcffe51ba223ad97b13fb169802
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 10 Mar 2020 16:59:43 +0000 (17:59 +0100)]
libdlogutil: extract state initialisation
Change-Id: Icf4b49c21718fdb30820340a006c85a898dc44e8
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 10 Mar 2020 13:11:31 +0000 (14:11 +0100)]
libdlogutil mainloop: keep state in a struct
Change-Id: Ib4f2522d0e9a1c4a22ddb73c9ab5dbebe7acb320
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Mateusz Majewski [Wed, 4 Mar 2020 17:31:48 +0000 (18:31 +0100)]
Inline flush
Change-Id: I73dff034985e689006fc67532336ca049ac41e66
Mateusz Majewski [Mon, 2 Mar 2020 12:01:48 +0000 (13:01 +0100)]
Move callback call out of fdi_push_log
Change-Id: I06e10a24042d3a011cba579370ccf001bfbbb955
Mateusz Majewski [Mon, 2 Mar 2020 08:05:11 +0000 (09:05 +0100)]
Simplify sort_vector_push
This is done by assuming that the vector is not full. It is better to
handle that case elsewhere.
Change-Id: Ie62d9c71628ec98edc8daaafb6b97cb14503cf12
Michal Bloch [Thu, 5 Mar 2020 10:39:21 +0000 (11:39 +0100)]
Const correctness
Change-Id: I631bde8942110ed76372c7b9a067e9c7b43b5d42
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Wed, 19 Feb 2020 18:20:00 +0000 (19:20 +0100)]
pipe: salvage corrupted logs at reception
Change-Id: I64087026138e2f894dda23b003a8da8a56418803
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Mateusz Majewski [Mon, 2 Mar 2020 12:54:01 +0000 (13:54 +0100)]
Add non-empty assert in sort_vector_pop
Change-Id: Ic732324f3be18ebe3b5689ba20a959892068c3a7
sanghyeok.oh [Thu, 27 Feb 2020 07:37:15 +0000 (16:37 +0900)]
coverity: Fix coverity issue
Coverity: #1124568, #1044318
Change-Id: I87b998521582b7562ac4e056332301cdb7697e54
Michal Bloch [Mon, 24 Feb 2020 13:40:58 +0000 (14:40 +0100)]
tests: improve coverage
Change-Id: Ia252acaea242ff924e3c20bbbe817a5e82f9140a
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Wed, 26 Feb 2020 10:14:07 +0000 (10:14 +0000)]
Merge "Make some global variables static" into tizen
Mateusz Majewski [Wed, 26 Feb 2020 07:42:39 +0000 (08:42 +0100)]
Make some global structs const
Change-Id: Ia179bafdbb923576468c31c47fd25956085a51de
Michal Bloch [Tue, 25 Feb 2020 10:01:10 +0000 (11:01 +0100)]
Make some global variables static
Change-Id: I0bbe2c4fbfa052abc85eff3f5f97498bbcefdc31
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Mateusz Majewski [Mon, 24 Feb 2020 07:04:37 +0000 (08:04 +0100)]
Document log limiting limitations
Change-Id: If7ec6c9219d7d924199d707eadfe910bc4305a3d
Mateusz Majewski [Fri, 21 Feb 2020 16:38:35 +0000 (17:38 +0100)]
Release 6.0.8
This release adds the --sort-by option to dlogutil and some minor
improvements to dlogutil, critical_log, documentation and tests.
Change-Id: I90b73fb96c902fcf2841505274c6b7eabd541af2
Michal Bloch [Wed, 19 Feb 2020 13:51:05 +0000 (14:51 +0100)]
dlogutil: no print-related prep for clear/getsize
Change-Id: I4670d24c29f9845497b7abfd88535704ed750936
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Wed, 19 Feb 2020 13:12:27 +0000 (14:12 +0100)]
util: use EXIT_{SUCCESS,FAILURE}
Change-Id: I909237fb0afa534fcd766092b83a49a1fcb5e747
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 17 Feb 2020 13:03:44 +0000 (14:03 +0100)]
dlogutil: extract clear/getsize to own functions
Change-Id: Idc399f92adb916107604a81f039e9d039b430e77
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Mateusz Majewski [Fri, 21 Feb 2020 11:11:24 +0000 (12:11 +0100)]
Remove a lie
Change-Id: I614bdc01f7519293042323e812b7234b1d5a0be3
Mateusz Majewski [Wed, 19 Feb 2020 12:12:50 +0000 (13:12 +0100)]
Add a missing newline in logutil's usage text
Change-Id: Ibad036376507f8ea53a32462d29aca3b57314a07
Mateusz Majewski [Wed, 19 Feb 2020 10:03:36 +0000 (11:03 +0100)]
Add monitor mode integration tests
Change-Id: I639bf18439826c6900a843dd918c8c10e1d6bbee
Mateusz Majewski [Wed, 19 Feb 2020 10:03:20 +0000 (11:03 +0100)]
Add continuous mode integration tests
Change-Id: I7090e6b127477eadab7bf34491fa2e442d9507ce
Karol Lewandowski [Tue, 18 Feb 2020 09:43:57 +0000 (10:43 +0100)]
critical log: Ensure critical log timestamps are set correctly
Change-Id: I573d674a7db16adbb3a2f5667a9b3a3afd7b3b9f
Mateusz Majewski [Tue, 18 Feb 2020 13:30:34 +0000 (14:30 +0100)]
Make tests exit when impossible to run
Change-Id: I6de0237e38707a018c27968d4d587d01639d6efb
Mateusz Majewski [Tue, 11 Feb 2020 13:28:07 +0000 (14:28 +0100)]
Add an --sort-by option to dlogutil
Change-Id: I9ea6579af9361abd61315a0296f421bc72d7083f
Michal Bloch [Tue, 7 Jan 2020 12:48:39 +0000 (13:48 +0100)]
Documentation: make boxes more boxy
Change-Id: I86765ca0912acee188bab31b5b3c0509066f827b
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Mateusz Majewski [Tue, 18 Feb 2020 07:01:37 +0000 (08:01 +0100)]
Optimise dumping while using the logger backend
Change-Id: I78ae67e8800bf8aed962a859f7ccd2afdddbf39f
Mateusz Majewski [Tue, 18 Feb 2020 07:22:10 +0000 (08:22 +0100)]
Refactor FDI EOF signalisation
Change-Id: I235a4176a7b0966f2be46c0088cd062ac0239e81
Karol Lewandowski [Fri, 14 Feb 2020 14:23:26 +0000 (14:23 +0000)]
Merge "Port old GCC compatibility from Tizen 5.5" into tizen
Michal Bloch [Fri, 14 Feb 2020 13:53:11 +0000 (14:53 +0100)]
Port old GCC compatibility from Tizen 5.5
Change-Id: Id3743dffb81bdace9a29746cec8a3c0eb877a939
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Mateusz Majewski [Wed, 12 Feb 2020 07:54:52 +0000 (08:54 +0100)]
Add permissions information
Change-Id: I17defcb9dc262c63596ec4f0f61fb561182d81e4
Michal Bloch [Fri, 14 Feb 2020 10:51:32 +0000 (11:51 +0100)]
Fix compilation for old GCC
Change-Id: I5936c466cd6e65bda7421ea8f2df045d3610d745
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 14 Feb 2020 10:28:16 +0000 (11:28 +0100)]
Release 5.5.3: sync with Tizen 6.0.7
Change-Id: I7fff9f2d60d2cf3deee00cd993380c457f013ade
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Thu, 13 Feb 2020 17:06:44 +0000 (18:06 +0100)]
Release 6.0.7
This release adds critical log rotation and a monitoring mode for dlogutil.
Change-Id: I84a428cda7f09d16e2c2e25ac4b09c83aace2593
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Agnieszka Baumann [Thu, 13 Feb 2020 16:06:50 +0000 (17:06 +0100)]
Fix coverity bugs
Change-Id: I6eebf286936628452962e18a566092448369febb
Karol Lewandowski [Thu, 13 Feb 2020 16:19:09 +0000 (16:19 +0000)]
Merge "[lib]dlogutil: add a monitoring mode" into tizen
Michal Bloch [Mon, 3 Feb 2020 15:45:05 +0000 (16:45 +0100)]
Critical logs: introduce rotation
Change-Id: I5afff333ef105c8a13142457bef0cbea3c9c319c
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 3 Feb 2020 13:25:06 +0000 (14:25 +0100)]
Critical log: lock the file when handling it
Change-Id: I09452ab1a84447e8d846444c723cb40bed8fed0a
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 3 Feb 2020 13:10:51 +0000 (14:10 +0100)]
Use OOP for the critical log writer
Change-Id: I54303cf2fd9f73487cc1be9519c8ec297e9a2878
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 4 Feb 2020 11:51:43 +0000 (12:51 +0100)]
Critical logs: move path default to autoconf
Change-Id: Ifc7b88efb4ef764a20e47b0e36e1c634de34e4c0
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 3 Feb 2020 11:56:51 +0000 (12:56 +0100)]
Compile critical log writer as C++
Change-Id: I45bfd0d5fe616f1a338fc04f0c0ec1f15fb61517
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Wed, 12 Feb 2020 16:37:31 +0000 (17:37 +0100)]
Release 6.0.6
This release fixes a common crash and some other minor bugs.
Change-Id: Id0635cb8ddae217079cd7862cb1c99bfa4bcc9bb
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 10 Feb 2020 17:29:07 +0000 (18:29 +0100)]
Optimize out a redundant call
Change-Id: Ibf9a656712b83435466df431a2c5ab1374666a81
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Wed, 12 Feb 2020 12:14:21 +0000 (13:14 +0100)]
Fix a compiler warning
'strncpy' specified bound equals destination size [-Wstringop-truncation]
Change-Id: Ia3729336ca95a750c08eb89bcc2f657627725b26
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 16 Dec 2019 13:21:15 +0000 (14:21 +0100)]
[lib]dlogutil: add a monitoring mode
Change-Id: Ifa07a832e32e1f7e0523823c7150e97a35a8f5e6
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Mateusz Majewski [Wed, 12 Feb 2020 11:22:36 +0000 (12:22 +0100)]
Get rid of useless LINE_MAX macro
Change-Id: If0fd4b3db60586d17d512fff75006b010ecff13e
Michal Bloch [Mon, 10 Feb 2020 16:24:52 +0000 (17:24 +0100)]
Apply consistent comment style
Change-Id: I63467afa521c2072a317f63ce2a79427e9bb6d53
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Mateusz Majewski [Wed, 12 Feb 2020 08:26:06 +0000 (09:26 +0100)]
Add integration test sanity checks
Change-Id: Ide49b5bea792a929b108495698c1cff00b0fbcbf
Michal Bloch [Tue, 11 Feb 2020 11:20:49 +0000 (12:20 +0100)]
Fix "rwtime" unit tests for the timestamp change
Change-Id: Ic8426033d3e34b78869b760d7040165a9af0e5da
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
(cherry picked from commit
602976f0145106f217da7f5e2b80b1c692f3d699)
Michal Bloch [Tue, 11 Feb 2020 11:20:49 +0000 (12:20 +0100)]
Fix "rwtime" unit tests for the timestamp change
Change-Id: Ic8426033d3e34b78869b760d7040165a9af0e5da
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Hyotaek Shim [Tue, 11 Feb 2020 07:04:05 +0000 (16:04 +0900)]
Restore kmsg time format as 'rwtime'
Change-Id: I8d561fdfdf39f79ff5dd49b478b72b1458f402f7
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
(cherry picked from commit
3d2673186770d4b50ea8ff33cec7f14284db26f1)
Michal Bloch [Tue, 11 Feb 2020 11:10:40 +0000 (12:10 +0100)]
Fix "rwtime" format to use SENT mono timestamp
Reverts a change introduced in
0652433919dc6018cd7769d33e78bbd20d16138e.
Change-Id: I6dbe9fac4531ffaeba282f5c3271c72884ed8452
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
(cherry picked from commit
b32cc43573473f08907751371552ba93a4257fbe)
Hyotaek Shim [Tue, 11 Feb 2020 07:04:05 +0000 (16:04 +0900)]
Restore kmsg time format as 'rwtime'
Change-Id: I8d561fdfdf39f79ff5dd49b478b72b1458f402f7
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Michal Bloch [Tue, 11 Feb 2020 11:10:40 +0000 (12:10 +0100)]
Fix "rwtime" format to use SENT mono timestamp
Reverts a change introduced in
0652433919dc6018cd7769d33e78bbd20d16138e.
Change-Id: I6dbe9fac4531ffaeba282f5c3271c72884ed8452
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Mateusz Majewski [Tue, 11 Feb 2020 10:09:19 +0000 (11:09 +0100)]
Fix various SVACE complaints
Change-Id: I910508371c5c728b00aec5c749fb11c8526a1bfb
Mateusz Majewski [Tue, 11 Feb 2020 09:35:40 +0000 (10:35 +0100)]
Add various log_format tests
Change-Id: I197addc62f7aec55722f3d44aa1f4a59fc10a730
Michal Bloch [Thu, 6 Feb 2020 10:30:54 +0000 (11:30 +0100)]
Reduce warnings for -pedantic clients
ISO C does not permit named variadic macros
Change-Id: I88c7cbfe094b8f054622ac847240155dfe0cd99c
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Mon, 10 Feb 2020 13:23:58 +0000 (13:23 +0000)]
Merge "Fix empty message formatting" into tizen
Karol Lewandowski [Mon, 10 Feb 2020 13:23:50 +0000 (13:23 +0000)]
Merge "Document confusing daemon structures" into tizen
Michal Bloch [Mon, 10 Feb 2020 11:20:58 +0000 (12:20 +0100)]
Remove unused variables
Change-Id: Icec5002e1b1cb1845021bf7d79fa6b9e859938fc
Mateusz Majewski [Mon, 10 Feb 2020 07:59:43 +0000 (08:59 +0100)]
Use TEMP_FAILURE_RETRY instead of manual looping
Change-Id: I84f1d39a1180c428f5ecbfc8ec959b9db0d60577
Mateusz Majewski [Mon, 10 Feb 2020 08:34:03 +0000 (09:34 +0100)]
Clarify the a && b || c && d type expression with parens
As suggested by -Wall.
Change-Id: Ifd6316a637542cd88aa4f115dcb2b62af38dc36e
Mateusz Majewski [Mon, 27 Jan 2020 13:46:43 +0000 (14:46 +0100)]
Add some libdlogutil negative tests
Change-Id: I7fc0aef2e522ae1a997399fb318b448a55c0a237
Mateusz Majewski [Mon, 10 Feb 2020 07:03:02 +0000 (08:03 +0100)]
Fail on no buffers passed
Change-Id: I2b7957c620fcd78507a4155de81a34036711009c
Mateusz Majewski [Fri, 31 Jan 2020 15:11:41 +0000 (16:11 +0100)]
Change -ENOTSUP to TIZEN_ERROR_NOT_SUPPORTED
This is actually a behavior change, since the both values are actually
not equal.
Change-Id: I4239f42ee2553c22095aa9bda02721b0489ff1d6
Mateusz Majewski [Fri, 7 Feb 2020 09:37:49 +0000 (10:37 +0100)]
Add exit code propagation to the integration tests
Now, if any of the tests fails, the dlog_test script will return a
nonzero error code. You can use this, for example, to execute
`dlog_test pipe && dlog_test logger`.
Note that, if you are using SDB, running `sdb shell dlog_test pipe` or a
similar command will NOT pass the exit code to the local shell. This is
because SDB always returns 0 as the exit code, no matter what was the
code of the underlying command; the nonzero exit codes are reserved for,
for example, connection failures.
Change-Id: I935ad63170ce7e02d27b496d1cf62f8c755bc3ab
Mateusz Majewski [Fri, 7 Feb 2020 08:24:11 +0000 (09:24 +0100)]
Add various libdlogutil filterspec tests
Change-Id: I12ab4b598142670e4c30fa35063261f41241e13f
Hyotaek Shim [Fri, 7 Feb 2020 01:53:23 +0000 (10:53 +0900)]
Change dlog_logger options to increase the size of log backup files
Change-Id: Ib68c769d8edc38a55c9965e8e0b8da74547ca79f
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Fri, 7 Feb 2020 01:53:23 +0000 (10:53 +0900)]
Change dlog_logger options to increase the size of log backup files
Change-Id: Ib68c769d8edc38a55c9965e8e0b8da74547ca79f
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
(cherry picked from commit
7005a42682bab02a332da46e7a1fa28684c290cc)
Michal Bloch [Thu, 6 Feb 2020 15:57:09 +0000 (16:57 +0100)]
Document confusing daemon structures
Change-Id: I48ce2d790538f4228cf362565841e9b10508b588
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Wed, 5 Feb 2020 17:50:49 +0000 (18:50 +0100)]
Fix empty message formatting
Change-Id: I115dd269933435300e1a5bbff8578795fd6b0850
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Mateusz Majewski [Wed, 5 Feb 2020 12:35:24 +0000 (13:35 +0100)]
Improve filter tests
Change-Id: Id8b56bf3db4ceef43a8df61fc54a432912c111b8
Mateusz Majewski [Wed, 5 Feb 2020 12:19:59 +0000 (13:19 +0100)]
Add tests for tag filtering
To make sure I won't break it ever again.
Change-Id: Ie0f9a56d9692bf09ff288975de454060e6d09c33
Mateusz Majewski [Wed, 5 Feb 2020 07:21:55 +0000 (08:21 +0100)]
Make the FDI creation check more strict
Change-Id: I4d2ca0aaf12e451cb13ce4288046863daa3127ca
Mateusz Majewski [Thu, 16 Jan 2020 07:02:14 +0000 (08:02 +0100)]
Add colorful output integration tests
Change-Id: I40fa224bf367908a3850875d25c2892e9e09ef0e
Karol Lewandowski [Wed, 5 Feb 2020 11:16:06 +0000 (12:16 +0100)]
Release 6.0.5
This release rewrite of dlogutil to use libdlogutil and numerous bugfixes.
Change-Id: I4dca1823a6a3b33b33c7b0825bb727509ee326e3
Mateusz Majewski [Mon, 3 Feb 2020 14:43:10 +0000 (15:43 +0100)]
Add KMSG integration test
Change-Id: Id41b5091cc7a9cfa6a74a712e01310e80fcce958
Michal Bloch [Tue, 28 Jan 2020 17:05:14 +0000 (18:05 +0100)]
Fix the handling of KMSG with regard to timestamps
Change-Id: I62542b352439f4447139fcd4cdd74a3e01da8e8f
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Mateusz Majewski [Wed, 5 Feb 2020 09:22:04 +0000 (10:22 +0100)]
Fix libdlogutil tag filtering
It turns out that it never worked in first place! :(
There was a tiny logical error in translation of dlogutil code into
libdlogutil; namely, dlogutil added the "*:D" at the end if no other
filterspec was added. Obviously I, not knowing how filterspec works,
decided that it would be equivalent to add it at the beginning no matter
if there are any other filterspec. This assumption is hiliarously wrong,
and now needs to be fixed.
Change-Id: I8496e3a4e248bd060d82ab5814e9b439bc2212b7
Mateusz Majewski [Wed, 5 Feb 2020 10:18:55 +0000 (11:18 +0100)]
Fix log_filter_from_filter
Change-Id: I7609bf7d586b66109bcf7f905295f647bcaf5ffe
Mateusz Majewski [Wed, 5 Feb 2020 07:21:55 +0000 (08:21 +0100)]
Fix the sed command
This command used to be wrong because it contains a star. When shell
sees the star, it expands it, which is very wrong in our case. The test
somehow still passes, but sed spams the error message on the stderr,
which is unhelpful while debugging.
Change-Id: Ief9666698b7163e6b332bb5c7535cc6814abd50e
Mateusz Majewski [Mon, 27 Jan 2020 11:26:57 +0000 (12:26 +0100)]
Enable returning TIZEN_ERROR_INVALID_PARAMETERS on invalid params instead of asserting them
Change-Id: I9754699e774b4b3de8a166063bb9b44b52c3bf06
Michal Bloch [Tue, 28 Jan 2020 11:30:13 +0000 (12:30 +0100)]
Critical logs: move to /var/log/dlog
The writer binary now has the 'System' smack label to allow this.
Change-Id: I2f8486c02caa2e45cff5594b19d3155919ddd1e9
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 31 Jan 2020 12:51:45 +0000 (13:51 +0100)]
Critical logs: avoid leaving zombie processes
libdlog doesn't really want to wait for the writer child process,
so now it leaves reaping it to init through the double fork idiom,
where the worker process is actually a grandchild and the immediate
child exists just to die and be reaped immediately.
Change-Id: I7a5c903f55b0ccd0f56824a228ee69f21ed87cac
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 31 Jan 2020 16:26:01 +0000 (17:26 +0100)]
Critical logs: less fragile unit tests
Change-Id: I826970a7a13c89051ca2dd18689ea001e2722632
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Hyotaek Shim [Mon, 3 Feb 2020 04:50:20 +0000 (13:50 +0900)]
Change time option for dlog_logger (recv_realtime -> threadtime)
Change-Id: I3ef8c23721cec38a555da5b090af9c6173544b21
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
(cherry picked from commit
c40fbeb4ffd0dd45f3aef3abb7b4119cba4f0c84)
projects / platform / core / system / dlog.git / log