platform/core/appfw/app-installers.git
5 years agoFix RecoverSignature 19/213419/5
Junghyun Yeon [Thu, 5 Sep 2019 06:23:22 +0000 (15:23 +0900)]
Fix RecoverSignature

- Privilege level should be initialized to untrusted to
  get privilege level from signature file if exists.
- Change root path of signature files for wgt packages.

Change-Id: Ie2e1055d6201753f742b54e7398506ad6aa01da3
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoChange the start location of package-recovery.service 66/208266/3
INSUN PYO [Fri, 21 Jun 2019 02:26:38 +0000 (11:26 +0900)]
Change the start location of package-recovery.service

The default.target.wants is not used for this purpose.
So the localtion of package-recovery.service is multi-user.target.wants.

Change-Id: I3c518b04e04c54adc4094b33f0a1170a31968a02

5 years agoFix mismatching of error code for signal 36/213436/3
Sangyoon Jang [Thu, 5 Sep 2019 07:52:14 +0000 (16:52 +0900)]
Fix mismatching of error code for signal

Change-Id: I57f3b7555f3f36fd4f9eb47f314cef6fd0480103
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoCheck config file for disabling legacy shareddata dir support 33/213433/3
Sangyoon Jang [Thu, 5 Sep 2019 07:42:34 +0000 (16:42 +0900)]
Check config file for disabling legacy shareddata dir support

Change-Id: I7072f6983cde10ae8ab226462834cc0272b81239
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRefactor creating shared/data directory 25/213425/3
Sangyoon Jang [Thu, 5 Sep 2019 07:26:17 +0000 (16:26 +0900)]
Refactor creating shared/data directory

Change-Id: I2b849df574fab2c17fb44c482abbd24b278f5f0a
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRelease version 1.30.11 28/213428/1 accepted/tizen/unified/20190906.111946 submit/tizen/20190905.075836
Ilho Kim [Thu, 5 Sep 2019 07:30:25 +0000 (16:30 +0900)]
Release version 1.30.11

Changes:
 - Fix memory leak
 - Remove checking cert mismatch from Signature class
 - Add FileLogBackend class
 - Log installation history
 - Change log directory to /var/log/appfw/app-installers
 - Fix Uninitialized scalar field

Change-Id: I211342a2838d4d1f3c341c7e82a91dff99513aa8
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix Uninitialized scalar field 10/213210/6
Ilho Kim [Tue, 3 Sep 2019 01:35:58 +0000 (10:35 +0900)]
Fix Uninitialized scalar field

Change-Id: I0eb2a1e0d574b51336b52342e779a2ca453b3ad2
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoChange log directory to /var/log/appfw/app-installers 00/213300/2
Sangyoon Jang [Wed, 4 Sep 2019 05:30:14 +0000 (14:30 +0900)]
Change log directory to /var/log/appfw/app-installers

Change-Id: I5bf3246c12f78d0741b12350b9476901711a74a6
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoLog installation history 90/213190/4
Sangyoon Jang [Mon, 2 Sep 2019 10:59:54 +0000 (19:59 +0900)]
Log installation history

Change-Id: I760f67df0fe39f714be4370e95f94e7326f09fc2
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoAdd FileLogBackend class 89/213189/2
Sangyoon Jang [Mon, 2 Sep 2019 10:39:12 +0000 (19:39 +0900)]
Add FileLogBackend class

FileLogBackend is custom logbackend class.

Requires:
 - https://review.tizen.org/gerrit/#/c/platform/core/appfw/manifest-parser/+/213188

Change-Id: I48ddcfa63cc0dce04cf81137e1c4a9e4323cb5b6
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRemove checking cert mismatch from Signature class 27/213227/1
Sangyoon Jang [Tue, 3 Sep 2019 05:27:53 +0000 (14:27 +0900)]
Remove checking cert mismatch from Signature class

This should be done at StepCheckOldCertificate step.

Change-Id: I9923c55f02f476cee57e90ed91e470bdf318231b
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix memory leak 82/213082/2
Sangyoon Jang [Fri, 30 Aug 2019 05:52:58 +0000 (14:52 +0900)]
Fix memory leak

Change-Id: Iab2eebe7a83897c5be850a7aecaf59327018c31a
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRelease version 1.30.10 99/212999/1 accepted/tizen/unified/20190903.052625 submit/tizen/20190829.072413 submit/tizen/20190902.052445
Ilho Kim [Thu, 29 Aug 2019 07:09:50 +0000 (16:09 +0900)]
Release version 1.30.10

Changes:
 - Add GetRecoverFileInfo for recovery test

Change-Id: I754666b4d5d0ec1a8a00cbccca1d39e17d0a7256
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoAdd GetRecoverFileInfo for recovery test 35/212535/4
Ilho Kim [Thu, 22 Aug 2019 11:55:47 +0000 (20:55 +0900)]
Add GetRecoverFileInfo for recovery test

Related changes
 - https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-backend/+/212537/

Change-Id: Ia0e60e6285bd2f69f56edb4f77bd4bcfa457bac1
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoRelease version 1.30.9 96/212896/1 accepted/tizen/unified/20190828.075500 submit/tizen/20190828.041046
Sangyoon Jang [Wed, 28 Aug 2019 04:08:51 +0000 (13:08 +0900)]
Release version 1.30.9

Changes:
 - Remove requires dependency wait-mount service from package-recovery service

Change-Id: I4ea05ee054e4e73cb7388a5a2b20897cd87b6475
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRemove requires dependency wait-mount service from package-recovery service 71/212671/1
Sangyoon Jang [Mon, 26 Aug 2019 04:50:25 +0000 (13:50 +0900)]
Remove requires dependency wait-mount service from package-recovery service

wait-mount service may not exist at some profile.

Change-Id: Ifb95f3eced133649efb61c1076848474499df416
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRelease version 1.30.8 86/212486/1 accepted/tizen/unified/20190823.092342 submit/tizen/20190822.055306
Ilho Kim [Thu, 22 Aug 2019 04:26:34 +0000 (13:26 +0900)]
Release version 1.30.8

Changes:
 - Add new install option
 - Fix manifest install/update

Change-Id: I7ae48377afb67c1129e8df0b68b5068acd3f7159
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix manifest install/update 29/212429/3
Ilho Kim [Wed, 21 Aug 2019 10:20:12 +0000 (19:20 +0900)]
Fix manifest install/update

- In case of manifest install, remain storage directories
- In case of manifest update in user request mode,
  do not needed update storage directory

Change-Id: Ib2a31be2d16bfd146f2e203b636bd283f46ec55a
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoAdd new install option 28/212328/4
Ilho Kim [Tue, 20 Aug 2019 08:24:26 +0000 (17:24 +0900)]
Add new install option

This option will be used for fast installation without optimization

Related changes
    [app-installers] https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/212328/
    [pkgmgr-tool] https://review.tizen.org/gerrit/#/c/platform/core/appfw/pkgmgr-tool/+/212326/
    [slp-pkgmgr] https://review.tizen.org/gerrit/#/c/platform/core/appfw/slp-pkgmgr/+/212327/

Change-Id: I5907597dcc3136278b26a7c020f9ef27a27cb1fa
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoRelease version 1.30.7 77/212277/1 accepted/tizen/unified/20190820.115026 submit/tizen/20190820.015710
Ilho Kim [Tue, 20 Aug 2019 01:36:45 +0000 (10:36 +0900)]
Release version 1.30.7

Changes:
 - Parse 'addon' element
 - Fix static analysis issue

Change-Id: I79bd27a0ee64f0505b58c329f03437d5b91f632b
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix static analysis issue 66/211766/6
Ilho Kim [Fri, 9 Aug 2019 04:12:40 +0000 (13:12 +0900)]
Fix static analysis issue

Fix NULL Pointer dereference when memory allocation fails

Change-Id: If23103d7135852ba98cc52173982cdc5bca47ca0
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoParse 'addon' element 06/210406/6
Junghoon Park [Fri, 19 Jul 2019 01:12:19 +0000 (10:12 +0900)]
Parse 'addon' element

- Requires :
  https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-manifest-handlers/+/209520/
  https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-backend/+/209744/

Change-Id: Ia902f8d049c86cce36f418d1a98fa67500e8f618
Signed-off-by: Junghoon Park <jh9216.park@samsung.com>
5 years agoRelease version 1.30.6 07/211807/1 accepted/tizen/unified/20190812.235615 submit/tizen/20190809.084335
Ilho Kim [Fri, 9 Aug 2019 08:15:02 +0000 (17:15 +0900)]
Release version 1.30.6

Changes:
 - Add function to kill child process used smoke test
 - Add dependency for mounting opt/usr
 - Skip dependency ckecking when backend has executed as root

Change-Id: I849d670be4d579cc9d13b9057880a917adbcdf74
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoSkip dependency ckecking when backend has executed as root 19/211719/1
Junghyun Yeon [Thu, 8 Aug 2019 08:59:36 +0000 (17:59 +0900)]
Skip dependency ckecking when backend has executed as root

Change-Id: I42a89ac1d5cc17d754c6580b9c650cad18473e01
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoAdd dependency for mounting opt/usr 15/211615/1
Junghoon Park [Wed, 7 Aug 2019 06:55:59 +0000 (15:55 +0900)]
Add dependency for mounting opt/usr

Change-Id: I2a8ea1cd6a4c099d57557044a3a52c3d4b27531b
Signed-off-by: Junghoon Park <jh9216.park@samsung.com>
5 years agoAdd function to kill child process used smoke test 77/209477/5
Ilho Kim [Mon, 8 Jul 2019 07:40:19 +0000 (16:40 +0900)]
Add function to kill child process used smoke test

Change-Id: If096fde0ac13b80d2fef94212ae3c7a4de21b02d
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoRelease version 1.30.5 49/210549/1 accepted/tizen/unified/20190723.053623 submit/tizen/20190722.090051
Junghyun Yeon [Mon, 22 Jul 2019 08:44:20 +0000 (17:44 +0900)]
Release version 1.30.5

Changes:
 - Add initialize db function for smoke test
 - Revert "Change database removal logic"
 - Revert "Add initialize db function for smoke test"

Change-Id: Iea69f19a8302ee65f8d1bebdbae1d0763e000797
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRevert "Add initialize db function for smoke test" 22/210522/2
ilho kim [Mon, 22 Jul 2019 05:34:44 +0000 (05:34 +0000)]
Revert "Add initialize db function for smoke test"

This reverts commit 8d743975f0a0ab068638c37c4e665ca615e4a5da.

Change-Id: Ie447f9f630a323e19e62ae0eaba731e435554cc6

5 years agoRevert "Change database removal logic" 19/210519/3
ilho kim [Mon, 22 Jul 2019 05:33:25 +0000 (05:33 +0000)]
Revert "Change database removal logic"

This reverts commit 66f0018a9d36e6f6638f7272d80245c9b5cb5858.

Change-Id: Ifa278212372491fa9f9f565cbf87b3ea2ff9258e

5 years agoAdd initialize db function for smoke test 53/210253/4
Ilho Kim [Wed, 17 Jul 2019 07:53:37 +0000 (16:53 +0900)]
Add initialize db function for smoke test

After below patch
   https://review.tizen.org/gerrit/#/c/platform/core/appfw/pkgmgr-info/+/207513/
The smoke test requires the process of creatring db for testing.
This is because opening the db with the "SQLITE_OPEN_READWRITE" flag doesn't create a db.

Related changes
   [tpk-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-backend/+/210255/
   [wgt-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-backend/+/210254/

Change-Id: I16161eba7b8b649a7e912891def3b81c1dc6dff6
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoRelease version 1.30.4 84/209884/1 accepted/tizen/unified/20190717.115154 submit/tizen/20190712.071407 submit/tizen/20190716.022534
Ilho Kim [Fri, 12 Jul 2019 06:34:14 +0000 (15:34 +0900)]
Release version 1.30.4

Changes:
 - Combine StorageDirectories Steps
 - Fix StepCheckInstallable
 - Change log directory's file atrributes
 - Refactor StepCreateStorageDirectories
 - Fix creating storage directories
 - Synchronize save, delete signature
 - Fix coding style
 - Change database removal logic

Change-Id: I45a6482aa433bdeedb6ad0f145545a513314dd2d
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoChange database removal logic 54/207554/7
Junghyun Yeon [Fri, 7 Jun 2019 04:15:10 +0000 (13:15 +0900)]
Change database removal logic

Journaling mode has changed to WAL so removing logic should be changed.

Related changes:
[pkgmgr-info] : https://review.tizen.org/gerrit/c/platform/core/appfw/pkgmgr-info/+/207513

Change-Id: If5515815c9a1a71f7d7cd83f8526431462d4aafc
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoFix coding style 30/209730/1
Sangyoon Jang [Wed, 10 Jul 2019 08:41:09 +0000 (17:41 +0900)]
Fix coding style

Add some missing #include statement.

Change-Id: I1c953c954878e8dfa96b88c34d9d244686159456
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoSynchronize save, delete signature 68/207768/7
Ilho Kim [Wed, 12 Jun 2019 07:18:13 +0000 (16:18 +0900)]
Synchronize save, delete signature

To prepare for sudden power loss,
write the signature infomation to the physical disk
and then synchronously delete the unpacked signature file using fsync()

Change-Id: I2a23f518cc7e71634ad93e00b594505223caee4c
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix creating storage directories 09/208709/1
Sangyoon Jang [Thu, 27 Jun 2019 08:06:42 +0000 (17:06 +0900)]
Fix creating storage directories

Now creating storage directories is performed after security registration,
installer should label those storage directories explicitly.

Change-Id: I587dc84d3fd4d5df80da22a6d1cfba788afef755
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRefactor StepCreateStorageDirectories 04/208704/3
Sangyoon Jang [Thu, 27 Jun 2019 07:24:10 +0000 (16:24 +0900)]
Refactor StepCreateStorageDirectories

Remove duplicated code. Remove unused variables. Improve readability.

Change-Id: I495e03b7a192d725a8058313418863d735c013f7
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoChange log directory's file atrributes 87/208487/3
Ilho Kim [Tue, 25 Jun 2019 05:42:06 +0000 (14:42 +0900)]
Change log directory's file atrributes

Change-Id: I22ae9470d6275059a752cdea0c2dc682eea1fde1
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix StepCheckInstallable 91/208291/6
Sangyoon Jang [Fri, 21 Jun 2019 07:09:04 +0000 (16:09 +0900)]
Fix StepCheckInstallable

Check required version of dependent packages.

Change-Id: Ia804ac9a47f0466dac747194814c322fa8d87064
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoCombine StorageDirectories Steps 75/206075/23
Ilho Kim [Tue, 14 May 2019 01:48:01 +0000 (10:48 +0900)]
Combine StorageDirectories Steps

Combined step :
 - StepCreateStorageDirectories and StepCreatePerUserStorageDirectories
 - StepUpdateStorageDirectories and StepUpdatePerUserStorageDirectories
 - StepRecoverStorageDirectories and StepRecoverPerUserStorageDirectories

Related changes
    [app-installers] https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/206075/
    [tpk-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-backend/+/206194/
    [wgt-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-backend/+/206193/

Change-Id: I7ebc32c5cb9b66a1dd007a064785d940e6de6f68
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoRelease version 1.30.3 50/208550/1 accepted/tizen/unified/20190626.064934 submit/tizen/20190626.013636
Ilho Kim [Wed, 26 Jun 2019 01:50:07 +0000 (10:50 +0900)]
Release version 1.30.3

Changes:
 - Remove unused variable
 - Fix namespace of StepCreateRecoveryFile
 - Fix StepParsePreload
 - Fix error logging when adding/removing/replacing step
 - Add PkgQueryInterface::Version() for getting version of package
 - Change log directory
 - Improve StepCopyBackup
 - Move the plugin info(prefer_dotnet_aot) of dotnet

Change-Id: Idc94a60427026ed2a5e6c6fbf086628b560e8300
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoMove the plugin info(prefer_dotnet_aot) of dotnet 07/207107/4
j-h.choi [Thu, 30 May 2019 05:26:40 +0000 (14:26 +0900)]
Move the plugin info(prefer_dotnet_aot) of dotnet

Dependency : https://github.sec.samsung.net/dotnet/dotnet-launcher/pull/58

Change-Id: I8e1b5c937d8202f580b817b9f4bcb01cdb29cd52

5 years agoImprove StepCopyBackup 25/208025/5
Junghyun Yeon [Mon, 17 Jun 2019 07:28:16 +0000 (16:28 +0900)]
Improve StepCopyBackup

Replace copy operation to move improves performance.

Change-Id: I623059a21e311420942ab860b3b151c95d371562
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoChange log directory 39/208039/4
Junghyun Yeon [Mon, 17 Jun 2019 12:18:27 +0000 (21:18 +0900)]
Change log directory

Log collecting module doesn't have enough permission to copy
file owned by root

Change-Id: Ibd5dc0ecdc7ff290954e1ffb77d761228406b12d
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoAdd PkgQueryInterface::Version() for getting version of package 93/208293/1
Sangyoon Jang [Fri, 21 Jun 2019 07:24:43 +0000 (16:24 +0900)]
Add PkgQueryInterface::Version() for getting version of package

Change-Id: Ic0e9e03862bd0a6d41d0b12c0642e81f8868fd3f
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix error logging when adding/removing/replacing step 10/207710/6
Sangyoon Jang [Tue, 11 Jun 2019 08:41:27 +0000 (17:41 +0900)]
Fix error logging when adding/removing/replacing step

HandleStepError is for sending signal when the step returns fail.

Change-Id: I4ba079aee5a399e11079950954c30e42583f3371
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix StepParsePreload 91/208091/2
Sangyoon Jang [Tue, 18 Jun 2019 07:04:50 +0000 (16:04 +0900)]
Fix StepParsePreload

Allow handle readonly package when ReadonlyUpdateUninstall mode.
ReadonlyUpdateUninstall mode makes the package as readonly package back.

Change-Id: I0a0fc007e73b3497b125833c7904192c3024aec3
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix namespace of StepCreateRecoveryFile 59/206959/7
Sangyoon Jang [Wed, 29 May 2019 10:05:16 +0000 (19:05 +0900)]
Fix namespace of StepCreateRecoveryFile

This step should be included at "recovery" namespace.

Change-Id: Id12a75327641b3d75bdb35b5d132d3e9c436b54f
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRemove unused variable 50/207350/1
Junghyun Yeon [Mon, 3 Jun 2019 12:45:28 +0000 (21:45 +0900)]
Remove unused variable

Change-Id: Id75cf5859fa788bfa312e6fb13174ade6066c6a3
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRelease version 1.30.2 57/207257/1 accepted/tizen/unified/20190604.081847 submit/tizen/20190531.072406 submit/tizen/20190603.050018
Ilho Kim [Fri, 31 May 2019 07:09:36 +0000 (16:09 +0900)]
Release version 1.30.2

Changes:
 - Combine Signature Steps
 - Set external image path at pkgmgr registration
 - Parse api-version of application if exist
 - Add PackageAttributes structure at smoke utils
 - Fix plugin_xml_parser
 - Delete unused header files
 - Refactor PluginsXmlParser::NextChildElement()
 - Fix checking return code app2sd API
 - Fix coding style
 - Fix app2ext_dynamic_service
 - Fix plugin manager
 - Standardize use of STEP_NAME()
 - Fix memory leak in using "g_object_get()"
 - Combine Plugin Steps
 - Fix static anylysis issue
 - Allow copy constructor and assign operator of PkgQueryInterface
 - Remove gumd security user

Change-Id: I5d5d4699f244f5c53431a097f4f92be5f771f711
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoRemove gumd security user 58/206958/4
INSUN PYO [Wed, 29 May 2019 09:58:56 +0000 (18:58 +0900)]
Remove gumd security user

Container feature is removed, so we don't need to handle gumd security user.
Security user is only used by container.

Change-Id: Ie76630476235056033e8062747611f27dfa2f0e2

5 years agoAllow copy constructor and assign operator of PkgQueryInterface 94/207094/2
Sangyoon Jang [Thu, 30 May 2019 02:56:17 +0000 (11:56 +0900)]
Allow copy constructor and assign operator of PkgQueryInterface

PkgQueryInterface was changed to using shared ptr of PkgHandle object
which has actual query data.

Change-Id: Iffec5a63de2236cc62cbcc8a6bba743962ad9583
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix static anylysis issue 42/206842/2
Junghyun Yeon [Tue, 28 May 2019 04:41:57 +0000 (13:41 +0900)]
Fix static anylysis issue

Change-Id: I0394b2007b64291e87e560ef5affdcda3cb3b3ca
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoCombine Plugin Steps 52/204652/9
Ilho Kim [Thu, 25 Apr 2019 08:21:34 +0000 (17:21 +0900)]
Combine Plugin Steps

StepRunParserPlugin combines below steps
 - StepRegisterPluginInfo
 - StepUpdatePluginInfo
 - StepUnregisterPluginInfo

Related changes
    [app-installers] https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/204652/
    [tpk-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-backend/+/204757/
    [wgt-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-backend/+/205385/

Change-Id: If090bb5855145077599c877d80335df1636d8e34
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix memory leak in using "g_object_get()" 32/206132/3
Ilho Kim [Tue, 14 May 2019 12:17:52 +0000 (21:17 +0900)]
Fix memory leak in using "g_object_get()"

Change-Id: I0e8263fee35852376992f856449d54691c74d133
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoStandardize use of STEP_NAME() 75/206275/2
Ilho Kim [Thu, 16 May 2019 02:55:56 +0000 (11:55 +0900)]
Standardize use of STEP_NAME()

In case class name is StepExampleClass, Pass "ExampleClass" to STEP_NAME()

Change-Id: I9aba996dc34109f391dc08f2f998b62417d956b2
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix plugin manager 67/205167/8
Sangyoon Jang [Tue, 30 Apr 2019 01:54:25 +0000 (10:54 +0900)]
Fix plugin manager

Fix crash when manifest is not provided.

Change-Id: I1f1c50856f3553c2a2f6d218a8af2ec2dbfd5b95
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix app2ext_dynamic_service 36/205736/4
Ilho Kim [Thu, 9 May 2019 01:54:49 +0000 (10:54 +0900)]
Fix app2ext_dynamic_service

Disable external pkg function was misused

Change-Id: I8a468ce9eb78f7b16890b5b7506e05a82d710505
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix coding style 30/205530/3
Junghyun Yeon [Tue, 7 May 2019 08:03:05 +0000 (17:03 +0900)]
Fix coding style

Change to use pointer when pass error_message as parameter.

Change-Id: I46d1b1704ca870a281136345a37a2a2eac1c2bd8
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoFix checking return code app2sd API 06/205606/4
Sangyoon Jang [Wed, 8 May 2019 04:38:12 +0000 (13:38 +0900)]
Fix checking return code app2sd API

It may return positive return value in case of error.

Change-Id: Ic40cd8241d3fb1dd4deba3f67ac94343b16065c8
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRefactor PluginsXmlParser::NextChildElement() 35/205635/2
Sangyoon Jang [Wed, 8 May 2019 06:03:54 +0000 (15:03 +0900)]
Refactor PluginsXmlParser::NextChildElement()

Call xmlTextReaderRead() until reaching child element.

Change-Id: I523187efb4402b81e703b6ff065ef50165b486e2
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoDelete unused header files 35/205735/1
Ilho Kim [Thu, 9 May 2019 01:51:30 +0000 (10:51 +0900)]
Delete unused header files

Change-Id: Ifca102788294950da05e397b2f89f766c9676772
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix plugin_xml_parser 07/205607/2
Ilho Kim [Wed, 8 May 2019 04:32:11 +0000 (13:32 +0900)]
Fix plugin_xml_parser

If xml file have comment line at root tag's depth, parsing is stopped

Change-Id: I04be43a4fdbeeda77937fb1d2996178561fea31b
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoAdd PackageAttributes structure at smoke utils 12/203612/5
Sangyoon Jang [Tue, 16 Apr 2019 07:53:07 +0000 (16:53 +0900)]
Add PackageAttributes structure at smoke utils

This structure can be used comparing package attributes such as
system, readonly, update, etc.
Some test cases of smoke-tests such as ReadonlyUpdateUninstall can
do additional validation using this structure.

Change-Id: I62579fb27e51d23cb8667fa4b8b85478af91af47
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoParse api-version of application if exist 97/199997/9
Sangyoon Jang [Mon, 18 Feb 2019 05:49:52 +0000 (14:49 +0900)]
Parse api-version of application if exist

Change-Id: I52dfe3477cd951b9f2b098486f3fbaa7dcd601f3
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoMerge "Combine Signature Steps" into tizen
ilho kim [Fri, 3 May 2019 07:30:58 +0000 (07:30 +0000)]
Merge "Combine Signature Steps" into tizen

5 years agoSet external image path at pkgmgr registration 93/204793/2
Sangyoon Jang [Fri, 26 Apr 2019 08:45:04 +0000 (17:45 +0900)]
Set external image path at pkgmgr registration

security-manager needs package information when getting privilege type,
but when installing package at external storage, the external image path is
set at clean() phase. So security-manager cannot get package information.

Change-Id: I8a2810da4cc417c0bc656f25e4a0d679c791833d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoCombine Signature Steps 40/203140/16
ilho [Thu, 4 Apr 2019 04:28:04 +0000 (13:28 +0900)]
Combine Signature Steps

StepCheckSignature and StepSaveSignature are combined

Related changes
    [app-installers] https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/203140/
    [tpk-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-backend/+/203141/
    [wgt-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-backend/+/203513/

Change-Id: I71de6ef5e9cdffc88f9f4f25f130e1f1c6b84714
Signed-off-by: ilho <ilho159.kim@samsung.com>
5 years agoRelease version 1.30.1 06/205306/1 accepted/tizen/unified/20190502.112933 submit/tizen/20190502.061205
Ilho Kim [Thu, 2 May 2019 07:06:19 +0000 (16:06 +0900)]
Release version 1.30.1

Changes:
 - Fix removed plugin feature
 - Delete unused plugin from plugins_list
 - Delete downloadable_font plugin from plugin_list

Change-Id: Id60fd9fdddb96e8394ffe861382d96b3112b7c56
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoDelete downloadable_font plugin from plugin_list 05/205305/2
Ilho Kim [Thu, 2 May 2019 07:01:56 +0000 (16:01 +0900)]
Delete downloadable_font plugin from plugin_list

Change-Id: I6978bfbdd6bc92d064dde9d4e909ee51686b9e90
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoDelete unused plugin from plugins_list 56/205256/1
Ilho Kim [Wed, 1 May 2019 23:36:59 +0000 (08:36 +0900)]
Delete unused plugin from plugins_list

Change-Id: I8d8a7201aea3b64b1757cbb28976623c7a90a787
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix removed plugin feature 18/204718/1
Junghyun Yeon [Fri, 26 Apr 2019 02:41:08 +0000 (11:41 +0900)]
Fix removed plugin feature

- Getting index from tuple was wrong.

Change-Id: I879e03437a9a3f4843710d699af6369e0778d32d
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRelease version 1.30.0 16/203816/1 accepted/tizen/unified/20190419.110513 submit/tizen/20190418.021839 submit/tizen/20190418.055722
Sangyoon Jang [Thu, 18 Apr 2019 02:16:31 +0000 (11:16 +0900)]
Release version 1.30.0

Changes:
 - Add explicit linker flag for boost-system at pc file
 - Initialize steps at Run()

Change-Id: I58d7f71d948fda8a6b90b08a0b67d631003ad442
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoInitialize steps at Run() 60/203760/4
Sangyoon Jang [Wed, 17 Apr 2019 11:38:17 +0000 (20:38 +0900)]
Initialize steps at Run()

Now installer backends does not need to call Init() itself.

Change-Id: I9ccba5900998a5615b5d0d4a781c16c7cf32a43b
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoAdd explicit linker flag for boost-system at pc file 59/203759/2
Sangyoon Jang [Wed, 17 Apr 2019 11:37:13 +0000 (20:37 +0900)]
Add explicit linker flag for boost-system at pc file

Some installer backend may not use boost library.

Change-Id: I50fca7703f65dcae2469c66ad0bdadb2bf6c80c3
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRelease version 1.29.2 30/203630/1 accepted/tizen/unified/20190417.132332 submit/tizen/20190416.100651 submit/tizen/20190416.233814
Junghyun Yeon [Tue, 16 Apr 2019 08:55:25 +0000 (17:55 +0900)]
Release version 1.29.2

Changes:
 - Adjust parsing component-based application
 - Remove package-recovery-helper service
 - Recycle pkgmgrinfo query result

Change-Id: I3de09922b7c28e257fd8c429f41c15cdcf89998a
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRecycle pkgmgrinfo query result 23/202723/5
Sangyoon Jang [Wed, 3 Apr 2019 07:44:54 +0000 (16:44 +0900)]
Recycle pkgmgrinfo query result

Change-Id: I720974e6697f3d9c0a79f02706f4dfbe661736ea
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRemove package-recovery-helper service 01/202801/6
Sangyoon Jang [Thu, 4 Apr 2019 06:12:34 +0000 (15:12 +0900)]
Remove package-recovery-helper service

Now package-recovery service handles all recovery process directly.

Change-Id: Ic599c965c832538b4bf28d212f955e8a92b29736
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoAdjust parsing component-based application 38/203138/1
Hwankyu Jhun [Wed, 10 Apr 2019 06:25:01 +0000 (15:25 +0900)]
Adjust parsing component-based application

FillComponentInfo step is removed.
FillAppControl, FillDataControl, FillMetadata, FillCategories and
FillSplashScreen are added.

Change-Id: I3c47918f04def3015f20df800005d88850cb8198
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
5 years agoRelease version 1.29.1 26/202726/1 accepted/tizen/unified/20190404.022016 submit/tizen/20190403.083158
Sangyoon Jang [Wed, 3 Apr 2019 08:28:51 +0000 (17:28 +0900)]
Release version 1.29.1

Changes:
 - Change log level of printing parsed pkgid
 - Revert "Reduce db connection while installer backend is running"

Change-Id: I3a07b53ccf360c8e7ce1c514c05fa700c1257df6
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRevert "Reduce db connection while installer backend is running" 22/202722/1
Sangyoon Jang [Tue, 2 Apr 2019 07:47:04 +0000 (16:47 +0900)]
Revert "Reduce db connection while installer backend is running"

This reverts commit 5c30ad9f49cabedf7baa01dd5b23af22d669c230.

Change-Id: I8302871edf14c3968bdde0fc2b82b26bcb79354b

5 years agoChange log level of printing parsed pkgid 19/202519/1
Sangyoon Jang [Fri, 29 Mar 2019 08:46:37 +0000 (17:46 +0900)]
Change log level of printing parsed pkgid

Changed to INFO from DEBUG.

Change-Id: I087ba05e3e6359637ff1f85f697458c113d5106d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRelease version 1.29.0 67/202467/1 submit/tizen/20190329.023054 submit/tizen/20190401.061033
Sangyoon Jang [Fri, 29 Mar 2019 02:09:35 +0000 (11:09 +0900)]
Release version 1.29.0

Changes:
 - Reduce db connection while installer backend is running
 - Fix recovery helper
 - Merge "Reduce db connection while installer backend is running" into tizen
 - Fix build error
 - Fix exception case of plugin info callback
 - Fix coding style checker error
 - Add RemoveStep
 - Write log to file when installation process failed

Change-Id: Ifb0394b02ef504463038112588edb0d7e2330cda
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoWrite log to file when installation process failed 72/202272/6
Sangyoon Jang [Tue, 26 Mar 2019 12:05:32 +0000 (21:05 +0900)]
Write log to file when installation process failed

When installation process failed, installer will write entire log at
"/var/log/app-installers.log". (except DEBUG level log)

Change-Id: I1d7aee6be3f67d16ff2749405bf28fc14e076cfe
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoAdd RemoveStep 89/202089/2
Junghyun Yeon [Fri, 22 Mar 2019 11:04:20 +0000 (20:04 +0900)]
Add RemoveStep

RemoveStep() will be used to remove certain step already added at step list.

Change-Id: I0c8d132323a23cd95a5fa67559cb225a3406d9c4
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoFix coding style checker error 13/202313/2
Sangyoon Jang [Wed, 27 Mar 2019 05:12:05 +0000 (14:12 +0900)]
Fix coding style checker error

Change-Id: Id1542aa29cf21c90b7146a8e5773f99453d93277
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix exception case of plugin info callback 12/202312/1
Sangyoon Jang [Wed, 27 Mar 2019 05:00:28 +0000 (14:00 +0900)]
Fix exception case of plugin info callback

The appid can be null.

Change-Id: Id6d409936e33df7b7aa6505f2eb9b616b243d02b
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix build error 11/202311/1
Sangyoon Jang [Wed, 27 Mar 2019 04:58:09 +0000 (13:58 +0900)]
Fix build error

Fix wrong merged code.

Change-Id: I544c52b5f802823e75aaf9ca40056f071e90a908
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoMerge "Reduce db connection while installer backend is running" into tizen
Junghyun Yeon [Fri, 22 Mar 2019 10:30:10 +0000 (10:30 +0000)]
Merge "Reduce db connection while installer backend is running" into tizen

5 years agoFix recovery helper 46/202046/1
Sangyoon Jang [Fri, 5 Jan 2018 04:39:57 +0000 (13:39 +0900)]
Fix recovery helper

We don't need to check if the file is directory or not.

Change-Id: I5d43a0c6e8af10b61c3985ac72a86d5eea4c2ab4
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
(cherry picked from commit 3f040e9398d74cef639154e24493e74bf7c2dacd)

5 years agoReduce db connection while installer backend is running 38/200938/7
Junghyun Yeon [Wed, 6 Mar 2019 08:48:16 +0000 (17:48 +0900)]
Reduce db connection while installer backend is running

- Db connection during installation cause delay
  when some hard scenarios.

Change-Id: Id313d669d029e98d1e3540c808ccaa75b391df50
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRelease version 1.28.1 64/201964/1 accepted/tizen/unified/20190322.075512 submit/tizen/20190321.084911
Sangyoon Jang [Thu, 21 Mar 2019 08:43:18 +0000 (17:43 +0900)]
Release version 1.28.1

Changes:
 - Fix a bug when recover preload-rw update
 - Fix crash issue
 - Adjust to change of pkgmgrinfo_pkg_dependency_list_cb

Change-Id: I364c4b40948425fdcd7a33194b8e56ad9234bea3
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoAdjust to change of pkgmgrinfo_pkg_dependency_list_cb 68/201368/4
Sangyoon Jang [Wed, 13 Mar 2019 07:40:21 +0000 (16:40 +0900)]
Adjust to change of pkgmgrinfo_pkg_dependency_list_cb

Requires:
 - https://review.tizen.org/gerrit/c/platform/core/appfw/pkgmgr-info/+/201198

Change-Id: I20f0257cf7825306b5c96919db87a8ff32643df0
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix crash issue 95/201695/1
Hwankyu Jhun [Tue, 19 Mar 2019 02:31:49 +0000 (11:31 +0900)]
Fix crash issue

Before calling FillExtraInfo(), FillComponentBasedApplicationInfo()
should be called.

Change-Id: Icd436417f8e05618b16f243a6cf61607251054ef
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
5 years agoFix a bug when recover preload-rw update 96/201596/2
Sangyoon Jang [Mon, 18 Mar 2019 06:08:53 +0000 (15:08 +0900)]
Fix a bug when recover preload-rw update

The preload-rw package should not be a system package.

Change-Id: Iba5d917105fbdbfc699cd9a55403097638446aa3
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoMerge "Release version 1.28.0" into tizen accepted/tizen/unified/20190318.150652 submit/tizen/20190315.084013
Junghyun Yeon [Fri, 15 Mar 2019 08:38:36 +0000 (08:38 +0000)]
Merge "Release version 1.28.0" into tizen

5 years agoProvide methods for adding or replacing steps 89/201189/3
Junghoon Park [Mon, 11 Mar 2019 07:56:39 +0000 (16:56 +0900)]
Provide methods for adding or replacing steps

Change-Id: I0845a49e34dc3816d826502b55203dbd930ba744
Signed-off-by: Junghoon Park <jh9216.park@samsung.com>
5 years agoRelease version 1.28.0 94/201494/1
Hwankyu Jhun [Fri, 15 Mar 2019 03:05:00 +0000 (12:05 +0900)]
Release version 1.28.0

Changes:
 - Fix StepKillApps
 - Use lambda expressions for simple callback function
 - Implement package dependency feature
 - Add string into include list
 - Remove using assert() in ExternalStorage
 - Add GetRequestTypeString() to print request type
 - Change visibility of steps to protected
 - Print request type at StepConfigure
 - Remove routine for checking name duplication on installer plugin
 - Fix bug of debug mode installation of hybrid package
 - Implement execution of removed plugin feature
 - Parse new elements for component-based application

Change-Id: Ic3e0ab612712535f43a5efd1f51da35b3a8850d5
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
5 years agoParse new elements for component-based application 91/200691/8
Hwankyu Jhun [Thu, 28 Feb 2019 07:42:46 +0000 (16:42 +0900)]
Parse new elements for component-based application

Requires:
 - https://review.tizen.org/gerrit/#/c/platform/core/appfw/pkgmgr-info/+/200568/
 - https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-manifest-handlers/+/200669/
 - https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/200691/
 - https://review.tizen.org/gerrit/#/c/platform/core/appfw/amd/+/200773/

Change-Id: Ia2a277fd0eaff0c8ad761294b4f45bf29c8e99a4
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
5 years agoImplement execution of removed plugin feature 44/195744/24
Junghyun Yeon [Fri, 14 Dec 2018 08:46:03 +0000 (17:46 +0900)]
Implement execution of removed plugin feature

Related changes:
[pkgmgr-info] : https://review.tizen.org/gerrit/#/c/platform/core/appfw/pkgmgr-info/+/195920/

Change-Id: Ief580418d693f98458334c7ac2a353964e9dd6ed
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoFix bug of debug mode installation of hybrid package 97/200897/3
Sangyoon Jang [Tue, 5 Mar 2019 11:53:12 +0000 (20:53 +0900)]
Fix bug of debug mode installation of hybrid package

The appdebugging privilege should be added for all applications
included in hybrid package.

Change-Id: Id0bced11063f7fb8c66b4a10ac696c5832f0acc7
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>