platform/upstream/efl.git
5 years agogengrid: fix wrong condition on next item search 19/200619/2
SangHyeon Jade Lee [Wed, 27 Feb 2019 09:56:25 +0000 (18:56 +0900)]
gengrid: fix wrong condition on next item search

Change-Id: I81b157092eb028d5bb27a4c01f34d20db3c31dcf
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
5 years agoRevert "evas_map: fix rendering bug 'mapped smart parent'+'image_object_update_add'" 15/200515/2
Shinwoo Kim [Tue, 26 Feb 2019 05:43:10 +0000 (14:43 +0900)]
Revert "evas_map: fix rendering bug 'mapped smart parent'+'image_object_update_add'"

This reverts commit 23de6660338021abb596bebd807b5e3889551748.

to fix auto scroll FPS issue.
You can check this on elm-demo-tizen-tv > Performance menu.
For more information please contact sungguk.na@samsung.com

Change-Id: I64983527ae5ce9439ee6bfaacf901027cefda2a3

5 years agoefl_access: Add class check for using access_parent_set 71/200371/3
JunsuChoi [Fri, 22 Feb 2019 08:49:05 +0000 (17:49 +0900)]
efl_access: Add class check for using access_parent_set

[dlog]
E/EFL     (  790): eo<790> lib/eo/eo.c:569 _efl_object_call_resolve() in lib/elementary/efl_access_object.eo.c:50: func 'efl_access_object_access_parent_set' (464) could not be resolved for class 'Efl.Canvas.Layout'.
E/EFL     (  790): eo<790> lib/eo/eo.c:569 _efl_object_call_resolve() in lib/elementary/efl_access_object.eo.c:50: func 'efl_access_object_access_parent_set' (464) could not be resolved for class 'Efl.Canvas.Layout'.
E/EFL     (  790): eo<790> lib/eo/eo.c:569 _efl_object_call_resolve() in lib/elementary/efl_access_object.eo.c:50: func 'efl_access_object_access_parent_set' (464) could not be resolved for class 'Efl.Canvas.Rectangle'.
E/EFL     (  790): eo<790> lib/eo/eo.c:569 _efl_object_call_resolve() in lib/elementary/efl_access_object.eo.c:50: func 'efl_access_object_access_parent_set' (464) could not be resolved for class 'Efl.Canvas.Layout'.
E/EFL     (  790): eo<790> lib/eo/eo.c:569 _efl_object_call_resolve() in lib/elementary/efl_access_object.eo.c:50: func 'efl_access_object_access_parent_set' (464) could not be resolved for class 'Efl.Canvas.Rectangle'.
E/EFL     (  790): eo<790> lib/eo/eo.c:569 _efl_object_call_resolve() in lib/elementary/efl_access_object.eo.c:50: func 'efl_access_object_access_parent_set' (464) could not be resolved for class 'Efl.Canvas.Layout'.
E/EFL     (  790): eo<790> lib/eo/eo.c:569 _efl_object_call_resolve() in lib/elementary/efl_access_object.eo.c:50: func 'efl_access_object_access_parent_set' (464) could not be resolved for class 'Efl.Canvas.Rectangle'.
E/EFL     (  790): eo<790> lib/eo/eo.c:569 _efl_object_call_resolve() in lib/elementary/efl_access_object.eo.c:50: func 'efl_access_object_access_parent_set' (464) could not be resolved for class 'Efl.Canvas.Layout'.
E/EFL     (  790): eo<790> lib/eo/eo.c:569 _efl_object_call_resolve() in lib/elementary/efl_access_object.eo.c:50: func 'efl_access_object_access_parent_set' (464) could not be resolved for class 'Efl.Canvas.Layout'.
E/EFL     (  790): eo<790> lib/eo/eo.c:569 _efl_object_call_resolve() in lib/elementary/efl_access_object.eo.c:50: func 'efl_access_object_access_parent_set' (464) could not be resolved for class 'Evas.Box'.
E/EFL     (  790): eo<790> lib/eo/eo.c:569 _efl_object_call_resolve() in lib/elementary/efl_access_object.eo.c:50: func 'efl_access_object_access_parent_set' (464) could not be resolved for class 'Efl.Canvas.Rectangle'.
E/EFL     (  790): eo<790> lib/eo/eo.c:569 _efl_object_call_resolve() in lib/elementary/efl_access_object.eo.c:50: func 'efl_access_object_access_parent_set' (464) could not be resolved for class 'Evas.Image'.
E/EFL     (  790): eo<790> lib/eo/eo.c:569 _efl_object_call_resolve() in lib/elementary/efl_access_object.eo.c:50: func 'efl_access_object_access_parent_set' (464) could not be resolved for class 'Efl.Canvas.Rectangle'.
E/EFL     (  790): eo<790> lib/eo/eo.c:569 _efl_object_call_resolve() in lib/elementary/efl_access_object.eo.c:50: func 'efl_access_object_access_parent_set' (464) could not be resolved for class 'Evas.Image'.# Please enter the commit message for your changes. Lines starting

Change-Id: I986b275e135320c77323dc0223d6d2e7065e57f1

5 years agoRevert "evas_image: fix pixels_dirty_set(False) makes wrong object-change..." 71/200471/1
Shinwoo Kim [Mon, 25 Feb 2019 12:09:59 +0000 (21:09 +0900)]
Revert "evas_image: fix pixels_dirty_set(False) makes wrong object-change..."

This reverts commit 55b5209f9e50a1dbe3a25aafe1194879057d7247.

to fix TCT issue.

The issue fixed by commit "55b5209f9 evas_image: fix pixels_dirty_set..."
would be fixed by "90e2fad evas_object_image: render_post returns if...".

Change-Id: I6511b94fb673b45c223742da068b117289d89bb1

5 years agospec: fix not to contain a unnecessary library 46/200446/1
Wonki Kim [Mon, 25 Feb 2019 05:39:10 +0000 (14:39 +0900)]
spec: fix not to contain a unnecessary library

libelementary.so.1.21.100 is a library for platform specific behavior for mobile
and it should not be installed by installing elementary.rpm.
so that this patch removes it from elementary definition.

Change-Id: I82cf7b9ebf60d98057fec73b7f2530f0467692bd
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
5 years agoRevert "efl_ui_animation_view: update interfaces usages." 39/200439/2 accepted/tizen/unified/20190225.232721 submit/tizen/20190225.071954
Hermet Park [Mon, 25 Feb 2019 06:36:36 +0000 (15:36 +0900)]
Revert "efl_ui_animation_view: update interfaces usages."

This reverts commit 797a49f4092ed666aa2676ba64bb48fd12310cc9.

This patch must be applied with the latest efl upstream patches.

Change-Id: I8039500493c630a473a17ef76c3571239e83e717

5 years agomeson: add a option for selecting lua interpreter 40/200340/2
Wonki Kim [Thu, 14 Feb 2019 10:25:09 +0000 (10:25 +0000)]
meson: add a option for selecting lua interpreter

this patch is for selecting lua interpreter such as luajit, lua51
and in addition, little more changes to unify lua dependency over efl

Reviewed-by: Marcel Hollerbach <marcel-hollerbach@t-online.de>
Differential Revision: https://phab.enlightenment.org/D7564

Change-Id: I8f0d072d124638510c5245904b474da0aef0457d
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
5 years agoeio: fix a potentional BOF problem 39/200339/2
Wonki Kim [Thu, 21 Feb 2019 05:25:09 +0000 (05:25 +0000)]
eio: fix a potentional BOF problem

if length of path arguments are longer than PATH_MAX,
there could be a BOF problem potentionally.
this patch fixes it.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D7919

Change-Id: Iaeff6a373d8c251b20264549be3fd350c71f3110
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
5 years agoefl_ui_animation_view: replace naming, keyframe to progress. 26/200426/3
Hermet Park [Mon, 25 Feb 2019 04:52:40 +0000 (13:52 +0900)]
efl_ui_animation_view: replace naming, keyframe to progress.

To make consistency with Xamarin-Lottie interfaces,
here replace the api. Progress is more clear to understand.

Change-Id: If5afb780353bfbce5151c83ef4aa980f32f7dd09

5 years agoeio: cancel registered future before it's freed 27/200427/2 submit/tizen/20190225.055416
Shinwoo Kim [Mon, 25 Feb 2019 05:14:41 +0000 (14:14 +0900)]
eio: cancel registered future before it's freed

This is tizen only patch to solve TC issue quickliy
For more information, please refer to following upstream patch under reivew.

https://phab.enlightenment.org/D7970

This patch would be reverted when corrected patch is merged.

@tizen_only

Change-Id: I63e9faf43a848d597433fb0a74ab80118a44fa0c

5 years agoefl_ui_animation_view: update interfaces usages. 22/200422/1
Hermet Park [Mon, 25 Feb 2019 04:43:10 +0000 (13:43 +0900)]
efl_ui_animation_view: update interfaces usages.

Change-Id: Id353cc825525f44a2898a6149690dc9892d52995

5 years agoRevert "eo: fix to remove unreachable loop" 67/200367/1
Jaehyun Cho [Fri, 22 Feb 2019 07:45:06 +0000 (16:45 +0900)]
Revert "eo: fix to remove unreachable loop"

This reverts commit 86ea8f993dd576a8bbf1911d615a0720707df2c5.

Change-Id: I98f2da824e5ffca010dad149b9571c24be92a9cb

5 years agoecore_imf: Add since_tizen in keycode member of key event structs 49/200349/3
Jihoon Kim [Fri, 22 Feb 2019 05:02:03 +0000 (14:02 +0900)]
ecore_imf: Add since_tizen in keycode member of key event structs

Change-Id: I238c9c33627447c01846089d8e1b0b4280fccce8
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
5 years agoRevert "eet: add counter for number of frees needed in each directory" 31/200331/2 submit/tizen/20190222.044455
Shinwoo Kim [Thu, 21 Feb 2019 23:13:42 +0000 (08:13 +0900)]
Revert "eet: add counter for number of frees needed in each directory"

This reverts commit 83be62392df0392be435b6d3c52db6d59b7efda6.

To solve heap memory usage problem.
Please refer to following massif result.

 n1: 236176 0x541A92C: edje_mmap_data_get (in /usr/lib/libedje.so.1.21.99)
   n1: 236176 0x4A5C038: _elm_theme_file_item_add (elm_theme.c:63)
    n1: 236176 0x4A5C886: _elm_theme_parse (elm_theme.c:485)
     n1: 236176 0x4981160: _config_apply (elm_config.c:1686)
      n1: 236176 0x498DFDE: _elm_config_init (elm_config.c:4755)
       n1: 236176 0x4A0E05A: elm_quicklaunch_sub_init (elm_main.c:867)
 n1: 58267 0x541A92C: edje_mmap_data_get (in /usr/lib/libedje.so.1.21.99)
  n1: 58267 0x4A5C038: _elm_theme_file_item_add (elm_theme.c:63)
   n1: 58267 0x4A5C886: _elm_theme_parse (elm_theme.c:485)
    n1: 58267 0x4981160: _config_apply (elm_config.c:1686)
     n1: 58267 0x498DFDE: _elm_config_init (elm_config.c:4755)
      n1: 58267 0x4A0E05A: elm_quicklaunch_sub_init (elm_main.c:867)

Change-Id: Ib3c1fd58c5e038da2059855ba644309e9bafb04e

5 years agoevas_object_image: render_post returns if preloading. 29/200329/2
Shinwoo Kim [Thu, 21 Feb 2019 06:57:17 +0000 (06:57 +0000)]
evas_object_image: render_post returns if preloading.

The render_post calls evas_object_change if o->changed is true which is added
by commit "36fc2e6 evas image: fix non-rendered preload image.".
But an image could lose chance to render. Please refer to the following.

(1) 1st render_updates_internal
  render_post - evas_object_change for image and its parents
  evas_object_reset - for its parent

(2) _evas_image_load_post_update - o->preload is changed to true here

(3) 2nd render_updates_internal
  evas_render_mapped cannot call render

The reason of (3) would be unchanged parents.

If render_post returns if an image is preloading, then evas_object_change works
for the image and its parents at (2). And finally (3) will call render.
It would be reasonable because render_pre, and render returns as well.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D7973

Change-Id: Ifc84f6733bb7cc6a5e21c9686edba811270d1bab

5 years agoRevert "edje: add ability to reference images from other edje files" 28/200328/2
Shinwoo Kim [Thu, 21 Feb 2019 12:51:52 +0000 (21:51 +0900)]
Revert "edje: add ability to reference images from other edje files"

This reverts commit fdd4472129c4cf6d3d118e841bdf0b11497da9db.

To solve memory usage problem using 140(= 3564 - 3424)KB bigger than before.

sh-3.2# memps <pid of launchpad-loader>

 Before: 3424 00489000-0084e000 [heap]
 After : 3564 004e0000-008c6000 [heap]

Change-Id: Ib79eb9fc9f29da515bfa705343290c08e6a7e57e

5 years agoecore_imf: Add keycode in key down and key up event structs 42/200342/1
Jihoon Kim [Fri, 22 Feb 2019 02:05:56 +0000 (11:05 +0900)]
ecore_imf: Add keycode in key down and key up event structs

Change-Id: I5f81cfc054adb72c17ea69b7657637c3adddbcdc
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
5 years agogengrid : fix missing circluar condition 78/200278/2 submit/tizen/20190222.001114
SangHyeon Jade Lee [Thu, 21 Feb 2019 05:26:52 +0000 (14:26 +0900)]
gengrid : fix missing circluar condition

Change-Id: I05d2135fdf5545d0e189dedd4843389a23320c84

5 years agoevas_map: fix rendering bug 'mapped smart parent'+'image_object_update_add' 58/200258/1
Jiyoun Park [Wed, 20 Feb 2019 11:39:41 +0000 (20:39 +0900)]
evas_map: fix rendering bug 'mapped smart parent'+'image_object_update_add'

Problem case:
1. there is smart object(e_comp_object) + mapped
2. e_comp_object's mapped size 400X400
3. image object A is child of e_comp_object
4. map surface is (800X800) , image_object size is also (800X800)
5. e_comp_object is mapped, so map surface (800X800) will be rendered 400X400 into evas by map image render.

step1: E20 calls evas_object_image_data_update_add(A,  100X100)

step2: e_comp_object and A are added "render_objects" list according below process
    -> _evas_render_phase1_object_process(e_comp_object)
        ->e_comp_object cahnged, and it is smart object and mapped ,
             so map_not_can_map=1 & obj_changed=1;
        ->_evas_render_phase1_object_mapped(e_comp_object)
           ->_evas_render_phase1_object_process(A)
             ->_evas_render_phase1_object_changed_normal(A)

step3: _evas_render_phase1_direct function
      -> 400X400 is added into rende area by e_comp_object's render pre function
      -> 800X800 is removed and 100X100 is added by evas_object_image_render_pre(A)

The problem is 800X800 is removed because
   o->pixels->pixel_updates=1   by update_add function.
   inside that condition evas_render_update_del(800X800)

I think evas update rect should not be affectey by render area related with inside map.

if image object's parent is mapped, image object will be rendered whole area in map render code,
I add code to check this

@tizen_only

Change-Id: Id0f3f56a3602481fa9d5761d922f89a107c7d397
Signed-off-by: Jiyoun Park <jy0703.park@samsung.com>
5 years agotest/efl_ui_pager: add NULL checking after calloc() function 08/200208/2
Jaeun Choi [Wed, 20 Feb 2019 05:28:54 +0000 (14:28 +0900)]
test/efl_ui_pager: add NULL checking after calloc() function

Change-Id: I410043dfd759bcfaf59004ab73a632b87a76992b

5 years agoelm_spinner: check focus manager using internal button visibility 44/192244/3
Yeongjong Lee [Thu, 1 Nov 2018 10:04:10 +0000 (19:04 +0900)]
elm_spinner: check focus manager using internal button visibility

spinner should get focus even if there is no focusable button.

@tizen_fix

Change-Id: Id2aec17d1b144c3168ff2d4776543c90baa2d820

5 years agoefl_page_transition_scroll: avoid explicit null dereference 04/200204/2
Jaeun Choi [Wed, 20 Feb 2019 04:53:32 +0000 (13:53 +0900)]
efl_page_transition_scroll: avoid explicit null dereference

Change-Id: If17fe18a92f7a5dbe85e4eb68841de9f1392086e

5 years agoefl_ui_pager: change data type 03/200203/1
Jaeun Choi [Wed, 20 Feb 2019 04:29:59 +0000 (13:29 +0900)]
efl_ui_pager: change data type

Change-Id: I52a6a4c849f7a7043a259f1dcb80f02682f9e479

5 years agoefl_ui : fix infinite loop in efl_ui_exact model 96/200196/1
SangHyeon Jade Lee [Thu, 14 Feb 2019 13:50:04 +0000 (08:50 -0500)]
efl_ui : fix infinite loop in efl_ui_exact model

Summary:
the loop in infinite because of wrong condition.
need to loop while the count of list_index.

Reviewers: cedric, zmike

Subscribers: zmike, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7925

Change-Id: Id209ee3c44ec8225dd2ad6a7a07b04ad2338ce0c

5 years agoEvas_GL: fix doxygen link. 86/200086/1
Hosang Kim [Tue, 19 Feb 2019 04:39:17 +0000 (13:39 +0900)]
Evas_GL: fix doxygen link.

Change-Id: I69bc80360e2e883e455e7db16e6ce060a35dde71

5 years agoelc_fileselector: add safety code for eina value 04/200004/2
Taehyub Kim [Mon, 18 Feb 2019 06:09:15 +0000 (15:09 +0900)]
elc_fileselector: add safety code for eina value

Change-Id: I6fa5ab0b3e70cdaf250b163498866fc2b9d3bc45

5 years agopng: fixed switch-case statement to initialize a variable in every case 60/199760/2
Jaeun Choi [Tue, 15 Jan 2019 06:48:39 +0000 (15:48 +0900)]
png: fixed switch-case statement to initialize a variable in every case

Change-Id: I6313b7f0034e69d19b724a763ddeddca7a6f5dc4

5 years agoevas vg: check for OOM when calloc() 12/200012/2
Hermet Park [Mon, 18 Feb 2019 06:17:41 +0000 (15:17 +0900)]
evas vg: check for OOM when calloc()

Change-Id: I9f0b43ad7d45d8263fa8ab48dca44d43d921a07d

5 years agoevas vg: check for OOM when calloc() 11/200011/2
Hermet Park [Mon, 18 Feb 2019 06:09:44 +0000 (15:09 +0900)]
evas vg: check for OOM when calloc()

Change-Id: I665ba9dd1d1955071f75ce0d57827c830829996e

5 years agoevas vg: check for OOM when calloc() 10/200010/2
Hermet Park [Mon, 18 Feb 2019 06:07:01 +0000 (15:07 +0900)]
evas vg: check for OOM when calloc()

Change-Id: Ib80ece5e912f176e91a85cb06f1b024dafdc2bbb

5 years agoevas vg: check for OOM when calloc() 09/200009/2
Hermet Park [Mon, 18 Feb 2019 06:02:47 +0000 (15:02 +0900)]
evas vg: check for OOM when calloc()

Change-Id: I0c5f9cbc407b508e3dd7a635bd4af6298879fc9c

5 years agoevas vg: avoid integral division not to loss precision. 08/200008/2
Hermet Park [Mon, 18 Feb 2019 05:53:09 +0000 (14:53 +0900)]
evas vg: avoid integral division not to loss precision.

Change-Id: I887043a78cc03202ec72e9da155440f6d89f1543

5 years agoevas vg: use strncpy() instead of strcpy() for better security. 07/200007/2
Hermet Park [Mon, 18 Feb 2019 05:47:14 +0000 (14:47 +0900)]
evas vg: use strncpy() instead of strcpy() for better security.

Change-Id: I950e52cd82ea92a644be4237a0f0724dafa3f504

5 years agoevas main: check for OOM when calloc(). 06/200006/2
Hermet Park [Mon, 18 Feb 2019 05:35:27 +0000 (14:35 +0900)]
evas main: check for OOM when calloc().

Change-Id: I091396e3dea3a48c0f3c2ff3460b2a1a1a2868db

5 years agoefl_io_model: fix not to cause memory overflow by strcpy 86/199986/2
Jaehyun Cho [Mon, 18 Feb 2019 04:48:39 +0000 (13:48 +0900)]
efl_io_model: fix not to cause memory overflow by strcpy

Since the destination string size is EINA_PATH_MAX, the string is copied
up to EINA_PATH_MAX size.

Change-Id: Ibc0c9b830af3b0befd648cea3dd3288212358ec1

5 years agoeo: fix to remove unreachable loop 84/199984/2
Jaehyun Cho [Mon, 18 Feb 2019 04:24:27 +0000 (13:24 +0900)]
eo: fix to remove unreachable loop

Change-Id: Ia8c0b3329faba15b699c3329377ee8c299b6af15

5 years agoeo: fix to handle null eo pointer case 83/199983/1
Jaehyun Cho [Mon, 18 Feb 2019 04:21:49 +0000 (13:21 +0900)]
eo: fix to handle null eo pointer case

Change-Id: I5da82c97b6c84fb79ea3f6c1476843dc236e0967

5 years agoecore_con: Fix potentional problems around ecore_con 00/199900/1
Wonki Kim [Wed, 13 Feb 2019 04:06:36 +0000 (04:06 +0000)]
ecore_con: Fix potentional problems around ecore_con

non-thread safe functions are used like rand(), strerror().
this patch replace them with thread safe one.
and also this patch contains a change to fix a memory leak problem.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D7917

Change-Id: Ibfa8cbdef468666c738ebd4d7ca725c2bd06dd05

5 years agoecore_wl2: replace strcpy with strncpy 99/199899/1
Wonki Kim [Wed, 13 Feb 2019 15:43:23 +0000 (10:43 -0500)]
ecore_wl2: replace strcpy with strncpy

Summary: this patch replaces a volnerable function with a safer one.

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7920

Change-Id: I7e83ba8c07dd3dfab892e67f00582c1692d802e7

5 years agoecore_evas: fix a potentional deref after null problem 98/199898/1
Wonki Kim [Wed, 13 Feb 2019 15:42:24 +0000 (10:42 -0500)]
ecore_evas: fix a potentional deref after null problem

Summary:
this patch modify a logic to return after,
failing to call eore_evas_buffer_allocfunc_new function.

Reviewers: Hermet, bu5hm4n, cedric, devilhorns

Reviewed By: devilhorns

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7918

Change-Id: I7a7d294b7fc023de052d03dcd7bc3ccf2e917c8a

5 years agoeet_dictionary: remove dead code 17/199817/2
Jaehyun Cho [Wed, 13 Feb 2019 07:59:46 +0000 (07:59 +0000)]
eet_dictionary: remove dead code

If index value is not -1, then eet_dictionary_string_add() returns.
Therefore, it does not need to check the index value after that.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D7922

Change-Id: I2fe87bb4e30fa705b243a88e181615c68d4090b2

5 years agoeet_dictionary: remove dead code 62/199862/2
Jaehyun Cho [Wed, 13 Feb 2019 07:59:46 +0000 (07:59 +0000)]
eet_dictionary: remove dead code

If index value is not -1, then eet_dictionary_string_add() returns.
Therefore, it does not need to check the index value after that.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D7922

Change-Id: I7181d02df14c96287760d8f266a866471b125435

5 years agoedje: add missing NULL checks 57/199857/2
Jaeun Choi [Wed, 13 Feb 2019 10:38:48 +0000 (19:38 +0900)]
edje: add missing NULL checks

Change-Id: I8c5b6c798bcb5356275443bf097281466b9d5479
Signed-off-by: JunsuChoi <jsuya.choi@samsung.com>
5 years agoedje: add missing NULL check 55/199855/1
Jaeun Choi [Wed, 13 Feb 2019 07:15:57 +0000 (16:15 +0900)]
edje: add missing NULL check

Change-Id: Ia34598789cd1a57678c143fa81e466b5bb8d704c
Signed-off-by: JunsuChoi <jsuya.choi@samsung.com>
5 years agoevas json: Load mask property from rlottie. 80/199380/2
JunsuChoi [Mon, 11 Feb 2019 05:07:01 +0000 (14:07 +0900)]
evas json: Load mask property from rlottie.

Summary:
   Load the mask information of the layer for implement the mask feature.
   The mask shape is transformed into a EFL_CANVAS_VG_CONTAINER and used like a matte.
   The mask interface uses the option implemented for matte temporarily.

Test Plan: N/A

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, SanghyeonLee, #reviewers, smohanty, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7891

Change-Id: I69830d0675ee2ec236fcac3c643323619581ef21

5 years agoelm_code_file: remove redundant code 93/199593/2 accepted/tizen/unified/20190218.063900 submit/tizen/20190215.002439
Jaehyun Cho [Wed, 13 Feb 2019 06:47:38 +0000 (15:47 +0900)]
elm_code_file: remove redundant code

EINA_SAFETY_ON_NULL_RETURN_VAL(code, NULL) returns NULL if the variable
"code" is NULL.
Therefore, the redundant NULL checking code is removed.

Change-Id: I15f1e02e45d612b62498543e11f234349cfafc9e

5 years agoRevert "elm_config: fix elm_config_save not to wake idle processes up" 27/199727/1
Marcel Hollerbach [Wed, 13 Feb 2019 11:30:00 +0000 (12:30 +0100)]
Revert "elm_config: fix elm_config_save not to wake idle processes up"

This reverts commit 8b0b9ed2819588fbf81299b784a600c6ac7ccd13.

There have been issues with this commit, for further informations,
please see https://phab.enlightenment.org/D7354 for more details.

Change-Id: Ia70a1eb5f06e178bd3c28ddef13eeab4d20dee01

5 years agogbs: give a customized tag to gbs explicitly 48/199448/4
Wonki Kim [Mon, 11 Feb 2019 10:45:35 +0000 (19:45 +0900)]
gbs: give a customized tag to gbs explicitly

gbs build system manages a target source coude incrementally, which means
it loads a clean source that is imported from upstream,
then applies patches from the imported commit to HEAD commit over the clean source every time.

to reduce time to apply huge amount of patches,
this patch gives HEAD as tag to gbs build system.

Change-Id: Iee39e7e315319d6ce11631c9038de06277999570
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
5 years agospec: refactoring spec file 37/199637/2
Wonki Kim [Wed, 30 Jan 2019 05:18:58 +0000 (14:18 +0900)]
spec: refactoring spec file

this patch contains changes for preparing of landing Meson build system,
cleaning up definitions.

Change-Id: I5c258fc2eabd417970cd47ebad92eddc08cd5aba

5 years agoecore_wl2: replace non-thread safe call with thread safe one 91/199591/2
Wonki Kim [Wed, 13 Feb 2019 07:05:05 +0000 (16:05 +0900)]
ecore_wl2: replace non-thread safe call with thread safe one

this patch replaces non-thread safe call 'strerror' with
thread safe one 'eina_error_msg_get'

Change-Id: Idfc38bbfad547eead6d95dfd0ce33d3d4def8852

5 years agoecore_evas: Fix a potenional null dereferencing problem 56/199556/2
Wonki Kim [Wed, 13 Feb 2019 04:39:26 +0000 (13:39 +0900)]
ecore_evas: Fix a potenional null dereferencing problem

there is a potentional problem while comparing strings.
this patch fixes it.

Change-Id: I47683300cc8e49d8450cb20590749d98c4257ba2
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
5 years agoHandling failed memory allocation 39/198739/2
Myoungwoon Roy, Kim [Tue, 29 Jan 2019 06:02:59 +0000 (15:02 +0900)]
Handling failed memory allocation

Change-Id: I9785d708d9d4024318edbdbf17c53cede792f5a5

5 years ago evas_image: fix pixels_dirty_set(False) makes wrong object-change-list. 85/198785/2
Jiyoun Park [Tue, 29 Jan 2019 12:05:40 +0000 (21:05 +0900)]
evas_image: fix pixels_dirty_set(False) makes wrong object-change-list.

    Summary:
    evas_object_image_pixels_dirty_set(img B, False) means
    1. app want to mark image object's data is not dirty anymore
    2. app don't want to be called get_pixels callback.

    that does not mean image need to be redraw.

    evas_object_image_pixels_dirty_set(img B, True) means
    1. image object's data is dirty, so image object need to be redraw.
    2. app want to be called get_pixels callback.

    but pixels_dirty_set(img B, FALSE) function also set o->changed to true,
    it cause problem related with rendering

    Below case is the example of problem.

    1. Smart object A
    2. Child image object B
    3. app call pixels_dirty_set(FALSE) inside pixels_get_callback
       pixels_get_callback is called inside the image object B's rendering.

    enlightenment's e_comp_object_render do upper job.

    After adding preload fetch,
    evas_object_image_render_post can call evas_object_change.

    https://phab.enlightenment.org/D7157

    evas_render_updates_internal

    0. enlightenment call evas_object_image_pixels_dirty_set(img B, TRUE)
       o->changed = 1;
       evas_object_change(img B)
    1. smart obj A is in render_objects
    2. evas_object_image_render_pre B, o->change=0
    3. evas_render_mapped (Smart A)
         3-1. evas_render_mapped (img B)
             : enlightenment call evas_object_image_pixels_dirty_set(img B, False)
             : o->changed=1

         3-2. evas_object_change_reset(img B)
    4. pending_change(img B)
         4-1. evas_object_image_render_post(img B)
              o->changed=1 (3-1 step) evas_object_change(img B)->evas_object_change(Smart A)

    5. render_post_reset
       smart A is chaged(4-1 step), so, called   evas_object_change_reset(Smart A)
       ###smart A is reset(5 step), img B is changed(4-1 step). after this case,
        img B never get change to be redraw.

    Reviewers: Hermet, cedric

    Subscribers: #reviewers, #committers

    Tags: #efl

    Differential Revision: https://phab.enlightenment.org/D7821

   commit 7beadd49e50a495bd30d34362050513ae132298c
   Author: Jiyoun Park <jy0703.park@samsung.com>
   Date:   Tue Jan 29 20:51:08 2019 +0900

Change-Id: I2da052e327473fd26e60e9d293b3736960b60108

5 years agogenlist: fix wrong returns in window tooltip set. 26/199526/1 accepted/tizen/unified/20190214.060613 submit/tizen/20190213.001307 submit/tizen/20190213.060634 submit/tizen/20190213.062652
SangHyeon Jade Lee [Tue, 12 Feb 2019 11:09:20 +0000 (20:09 +0900)]
genlist: fix wrong returns in window tooltip set.

tooltip_window_mode_set returns input disable value not a successibility of API actions.
when user set window_mode to false, it must return false regardless of item view existence.

this patch is port of uptream patch D7912

Change-Id: Iee4ee1c522005f6087ef6bfba7f1628b834834ac

5 years agobuild: next attempt to fix build race condition submit/tizen/20190211.061543
Marcel Hollerbach [Thu, 7 Feb 2019 14:35:58 +0000 (15:35 +0100)]
build: next attempt to fix build race condition

the source should be used in the dependency. However, only the generated
header source, not the .c files or we will get duplicated sources.

This is another attempt to fix the build OSX travis failure

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D7896

5 years agoefl-mono: Turn printfs into debug messages.
Lauro Moura [Fri, 8 Feb 2019 10:55:58 +0000 (11:55 +0100)]
efl-mono: Turn printfs into debug messages.

Summary: Cleaner output by default.

Test Plan: Run examples and tests

Reviewers: segfaultxavi, vitor.sousa

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7895

5 years agoeo: lets drop efl_interfaces
Marcel Hollerbach [Thu, 7 Feb 2019 13:44:18 +0000 (14:44 +0100)]
eo: lets drop efl_interfaces

its not required anymore, our wonderfull new syntax solves the original
problem it was trying to solve.

fixes T7565

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D7893

5 years agoefl_ui_text: s/ELM_SEL_FORMAT_IMAGE/EFL_UI_SELECTION_FORMAT_IMAGE/g
Mike Blumenkrantz [Thu, 7 Feb 2019 17:59:41 +0000 (12:59 -0500)]
efl_ui_text: s/ELM_SEL_FORMAT_IMAGE/EFL_UI_SELECTION_FORMAT_IMAGE/g

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl_widgets

Differential Revision: https://phab.enlightenment.org/D7894

5 years agoefl: Change non required constructors to @optional.
Lauro Moura [Thu, 7 Feb 2019 17:02:21 +0000 (18:02 +0100)]
efl: Change non required constructors to @optional.

Summary:
These constructors aren't checked for in the finalize step of the
initialization and may be given the @optional tag.

For C# this means they can be ommitted from the constructor call.

This also adds `Efl.Ui.View.model` as a constructor of
`Efl.Composite_Model` as the finalizer checks for it.

Fixes T7673

Test Plan: make check

Reviewers: segfaultxavi, zmike, bu5hm4n, cedric, felipealmeida

Reviewed By: segfaultxavi, cedric

Tags: #efl, #do_not_merge

Maniphest Tasks: T7673

Differential Revision: https://phab.enlightenment.org/D7855

5 years agoeo: here comes reflection API
Marcel Hollerbach [Tue, 5 Feb 2019 14:40:41 +0000 (15:40 +0100)]
eo: here comes reflection API

this adds support in eo to generate a reflection API. To get the actaul
reflection to the klass, the API efl_class_reflection_table_set needs to
be called, the table in the end can be generated by eolian. Reflection
API is inherited by the extended class. This means, if you have two
reflection tables, first, the most upperst is called, then the next
lower one is called.

For now this API accepts NULL setter or getter, and will ignore them
silently when they are called.

fix T7681

Differential Revision: https://phab.enlightenment.org/D7879

5 years agoeo: change API call of efl_class_functions_set
Marcel Hollerbach [Wed, 6 Feb 2019 08:53:25 +0000 (09:53 +0100)]
eo: change API call of efl_class_functions_set

The next commit will bring support for something like reflection. This
commit prepares the whole tree for getting another argument in
efl_class_functions_set.

ref T7681

Differential Revision: https://phab.enlightenment.org/D7882

5 years agoefl_ui_text: emit EFL_UI_TEXT_EVENT_CHANGED_USER from paste + drop operations
Mike Blumenkrantz [Thu, 7 Feb 2019 11:42:00 +0000 (12:42 +0100)]
efl_ui_text: emit EFL_UI_TEXT_EVENT_CHANGED_USER from paste + drop operations

Summary:
this is a user-triggered change so it must emit the event

ref T6979
Depends on D7886

Reviewers: bu5hm4n, cedric, segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl_widgets

Maniphest Tasks: T6979

Differential Revision: https://phab.enlightenment.org/D7887

5 years agoefl_ui_text: forward EFL_TEXT_INTERACTIVE_EVENT_SELECTION_CHANGED event
Mike Blumenkrantz [Thu, 7 Feb 2019 11:41:55 +0000 (12:41 +0100)]
efl_ui_text: forward EFL_TEXT_INTERACTIVE_EVENT_SELECTION_CHANGED event

Summary:
this is emitted on the internal object and must be propagated

fix T6535
Depends on D7885

Reviewers: bu5hm4n, cedric, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl_widgets

Maniphest Tasks: T6535

Differential Revision: https://phab.enlightenment.org/D7886

5 years agoefl_ui_text: forward EFL_UI_TEXT_EVENT_CHANGED_USER events
Mike Blumenkrantz [Thu, 7 Feb 2019 11:41:54 +0000 (12:41 +0100)]
efl_ui_text: forward EFL_UI_TEXT_EVENT_CHANGED_USER events

Summary:
these are emitted on the internal object and need to be propagated

ref T7621
Depends on D7884

Reviewers: bu5hm4n, cedric, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl_widgets

Maniphest Tasks: T7621

Differential Revision: https://phab.enlightenment.org/D7885

5 years agoefl_ui_text: emit EFL_UI_TEXT_EVENT_CHANGED events properly
Mike Blumenkrantz [Thu, 7 Feb 2019 11:41:52 +0000 (12:41 +0100)]
efl_ui_text: emit EFL_UI_TEXT_EVENT_CHANGED events properly

Summary:
these should be emitted any time text is changed in the object

fix T7615, T7417, T6978, T6979
Depends on D7883

Reviewers: bu5hm4n, cedric, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl_widgets

Maniphest Tasks: T7615, T7417, T6979, T6978

Differential Revision: https://phab.enlightenment.org/D7884

5 years agoefl_ui_text: use Efl_Ui_Selection_Format for cnp_mode struct member
Mike Blumenkrantz [Thu, 7 Feb 2019 11:41:51 +0000 (12:41 +0100)]
efl_ui_text: use Efl_Ui_Selection_Format for cnp_mode struct member

Summary: fix T7068

Reviewers: bu5hm4n, cedric, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl_widgets

Maniphest Tasks: T7068

Differential Revision: https://phab.enlightenment.org/D7883

5 years agoEfl.Canvas.Vg.Object : Fix unnecessary resize function call. 62/199262/1
JunsuChoi [Thu, 7 Feb 2019 09:57:58 +0000 (18:57 +0900)]
Efl.Canvas.Vg.Object : Fix unnecessary resize function call.

Summary:
   When size of view changed, call resize function in render.

Test Plan: N/A

Reviewers: Hermet

Subscribers: cedric, SanghyeonLee, #reviewers, smohanty, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7890

Change-Id: Id235b654a2b14f09533a6dff5466ec1170e56c5f

5 years agoresolve build error regarding to use of efl_layout_signal_callback_add submit/tizen/20190206.232055
Jongmin Lee [Wed, 6 Feb 2019 22:49:56 +0000 (07:49 +0900)]
resolve build error regarding to use of efl_layout_signal_callback_add

Change-Id: I802aa0b1c9819add5bae625078adc9754d80c2b7

5 years agoefl-mono: Remove uneeded declaration from classes.
Lauro Moura [Wed, 6 Feb 2019 21:47:40 +0000 (19:47 -0200)]
efl-mono: Remove uneeded declaration from classes.

Summary: The constructing method is not used anymore after D7789 landed.

Test Plan: run tests

Reviewers: segfaultxavi, felipealmeida, vitor.sousa

Reviewed By: segfaultxavi, vitor.sousa

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7875

5 years agoedje: migrate Eo API to use Eo callback instead of opaque type.
Cedric BAIL [Wed, 6 Feb 2019 18:48:43 +0000 (13:48 -0500)]
edje: migrate Eo API to use Eo callback instead of opaque type.

Summary: Depends on D7869

Reviewers: zmike, q66, segfaultxavi, bu5hm4n

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7671

Differential Revision: https://phab.enlightenment.org/D7870

5 years agoedje: make legacy edje call rely directly on edje internal.
Cedric BAIL [Wed, 6 Feb 2019 18:08:19 +0000 (13:08 -0500)]
edje: make legacy edje call rely directly on edje internal.

Reviewers: zmike, q66, segfaultxavi, bu5hm4n

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7671

Differential Revision: https://phab.enlightenment.org/D7869

5 years agoecore-drm2: Minor formatting fixes.
Christopher Michael [Wed, 6 Feb 2019 15:07:20 +0000 (10:07 -0500)]
ecore-drm2: Minor formatting fixes.

NB: No functional changes

5 years agoecore-drm2: Reduce duplicated code
Christopher Michael [Wed, 6 Feb 2019 15:03:02 +0000 (10:03 -0500)]
ecore-drm2: Reduce duplicated code

No need for this line to be there twice as it is going to be called in
either case.

NB: No functional changes

5 years agoecore-drm2: Remove useless if check
Christopher Michael [Wed, 6 Feb 2019 15:00:51 +0000 (10:00 -0500)]
ecore-drm2: Remove useless if check

_ecore_drm2_use_atomic is already checked just above this, so there is
no need for this if statement

5 years agoeolian_gen: add support for header-only depfiles
Daniel Kolesa [Wed, 6 Feb 2019 13:07:35 +0000 (14:07 +0100)]
eolian_gen: add support for header-only depfiles

By default, dependency files are now generated only for headers.
This makes sense for the C generator and our dependency tracking
needs. If full dependencies are needed, there is now the 'D'
output, which has the old behavior.

5 years agoeo: remove whitespaces
Marcel Hollerbach [Tue, 5 Feb 2019 15:11:44 +0000 (16:11 +0100)]
eo: remove whitespaces

remove the whitespaces from this file. Every editor in this world
removes unneccessay whitespaces at the end of a line. So every time i am
touching this header, i need to get rid of them, which is super
annoying. I know we are used to *not* doing such patches, but this is
just a waste of time, getting them out of the header every and every
single time.

Differential Revision: https://phab.enlightenment.org/D7880

5 years agoeo: repair EO_CLASS_POINTER macros
Marcel Hollerbach [Tue, 5 Feb 2019 13:45:51 +0000 (14:45 +0100)]
eo: repair EO_CLASS_POINTER macros

the function has changed, but the macro was not adjusted.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D7878

5 years agoautotools: remove all usage of evas_image_loader_tgv_(cflags|libs)
Mike Blumenkrantz [Tue, 5 Feb 2019 16:08:01 +0000 (11:08 -0500)]
autotools: remove all usage of evas_image_loader_tgv_(cflags|libs)

Summary:
these are empty variables which are apparently causing build errors for
some users in certain cases

Reviewers: bu5hm4n, stefan_schmidt

Reviewed By: stefan_schmidt

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7876

5 years agodocs: Minor Efl.Access.Window EO fixes
Xavi Artigas [Tue, 5 Feb 2019 12:29:15 +0000 (13:29 +0100)]
docs: Minor Efl.Access.Window EO fixes

5 years agoecore: tests: add missing include path to make ecore_audio build in distcheck
Stefan Schmidt [Tue, 5 Feb 2019 08:53:48 +0000 (09:53 +0100)]
ecore: tests: add missing include path to make ecore_audio build in distcheck

We missed the include path to the tests folder where the generated
ecore_audio_ou_test files are located. Found by our relentless TravisCI
cron job.

Reviewed-by: Marcel Hollerbach <marcel-hollerbach@t-online.de>
Differential Revision: https://phab.enlightenment.org/D7877

5 years agotests: improve efl loop test (concentric)
Mike Blumenkrantz [Mon, 4 Feb 2019 15:04:46 +0000 (10:04 -0500)]
tests: improve efl loop test (concentric)

I forgot to spin the sub-loop, so this was previously just a test to verify
that the IDLE callback was working.

now this spins the sub-loop on the idle callback and tests the idle enter
callback to verify that the main loop is being iterated

Reviewed-by: Derek Foreman <derekf@osg.samsung.com>
Differential Revision: https://phab.enlightenment.org/D7874

5 years agoeo: implement class overriding (+unit tests)
Mike Blumenkrantz [Mon, 4 Feb 2019 15:42:25 +0000 (10:42 -0500)]
eo: implement class overriding (+unit tests)

this enables an app or a platform to add an override for a given class,
then return a different object when that class is created. the benefit is
that a class can be internally customized by the app without needing to
modify upstream versions of that class

@feature
fix T7516

Reviewed-by: Marcel Hollerbach <marcel-hollerbach@t-online.de>
Differential Revision: https://phab.enlightenment.org/D7702

5 years agoexamples: ecore: bring back inet.h include for inet_pton()
Stefan Schmidt [Mon, 4 Feb 2019 12:10:40 +0000 (13:10 +0100)]
examples: ecore: bring back inet.h include for inet_pton()

In commit f7c560c311d0ba0da94346e17c8b20f40a0ed152 this include has been
removed while we still need it for inet_pton() as the compliler warns us
about.

Reviewed-by: Vincent Torri <vincent.torri@gmail.com>
Differential Revision: https://phab.enlightenment.org/D7873

5 years agobuild: fix macos race condition
Marcel Hollerbach [Fri, 1 Feb 2019 14:49:06 +0000 (15:49 +0100)]
build: fix macos race condition

There was the problem that evas_ector_software_buffer.eo was not arround
but required by the gl_generic engine, this fixes that by adding the
generated source and dependencies to the software_generic dependency.

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D7871

5 years agotests: add explicit test for concentric loop usage
Mike Blumenkrantz [Fri, 1 Feb 2019 20:11:04 +0000 (15:11 -0500)]
tests: add explicit test for concentric loop usage

having multiple loops which interact is a valid use case that should be
tested to ensure functionality

Reviewed-by: Derek Foreman <derekf@osg.samsung.com>
Differential Revision: https://phab.enlightenment.org/D7868

5 years agotests/elm: speed up all main loop timer execution
Mike Blumenkrantz [Fri, 1 Feb 2019 19:42:40 +0000 (19:42 +0000)]
tests/elm: speed up all main loop timer execution

this spins a second loop which manages a timer to trigger the canvas tick
and increase the loop timer by a fixed interval on every timer call

by increasing the loop time manually, timers such as edje animation timers
which would usually take a very long time (e.g., 0.5s) to run will instead
complete almost instantly, making tests run much faster

the second loop is necessary in this case in order to accurately provide ticks
at a consistent interval without any modifications to timing

Reviewed-by: Derek Foreman <derekf@osg.samsung.com>
Differential Revision: https://phab.enlightenment.org/D6791

5 years agoefl_interfaces: missing interfaces prefix
Larry Lira [Fri, 1 Feb 2019 19:03:24 +0000 (14:03 -0500)]
efl_interfaces: missing interfaces prefix

Summary: efl_ui_direction_readonly.c is missing "interfaces" prefix path in .eo.c include

Reviewers: lauromoura, cedric, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7848

5 years agoeolian-mono: Provide constructor parameters based on the constructors
Felipe Magno de Almeida [Fri, 1 Feb 2019 19:03:02 +0000 (14:03 -0500)]
eolian-mono: Provide constructor parameters based on the constructors
section of the Eo files.

Reviewers: woohyun, segfaultxavi, bu5hm4n, felipealmeida

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7789

5 years agoexamples: Example still use IPPROTO_CTP from in.h
Lauro Moura [Fri, 1 Feb 2019 18:54:35 +0000 (13:54 -0500)]
examples: Example still use IPPROTO_CTP from in.h

../src/examples/ecore/ecore_fd_handler_gnutls_example.c: In function ‘tcp_connect’:
../src/examples/ecore/ecore_fd_handler_gnutls_example.c:93:23: error: storage size of ‘sa’ isn’t known
    struct sockaddr_in sa;
                       ^~
../src/examples/ecore/ecore_fd_handler_gnutls_example.c:101:19: error: ‘IPPROTO_TCP’ undeclared (first use in this function)
    setsockopt(sd, IPPROTO_TCP, TCP_NODELAY, (char *)&flag, sizeof(int));
                   ^~~~~~~~~~~
../src/examples/ecore/ecore_fd_handler_gnutls_example.c:101:19: note: each undeclared identifier is reported only once for each function it appears in
../src/examples/ecore/ecore_fd_handler_gnutls_example.c:106:4: warning: implicit declaration of function ‘inet_pton’; did you mean ‘eina_htonl’? [-Wimplicit-function-declaration]
    inet_pton(AF_INET, SERVER, &sa.sin_addr);
    ^~~~~~~~~
    eina_htonl
../src/examples/ecore/ecore_fd_handler_gnutls_example.c:93:23: warning: unused variable ‘sa’ [-Wunused-variable]
    struct sockaddr_in sa;
                       ^~
Reviewers: vtorri, raster, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7867

5 years agoreplace hton and ntoh family functions with ones defined in eina
Vincent Torri [Fri, 1 Feb 2019 11:04:17 +0000 (11:04 +0000)]
replace hton and ntoh family functions with ones defined in eina

Summary: This fixes especially the execution of edje_cc on Windows

Test Plan: execution of edje_cc

Reviewers: cedric, raster

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7834

5 years agoefl-cxx: Fix compilation error when using a ptr to const any_value
Felipe Magno de Almeida [Fri, 1 Feb 2019 10:46:52 +0000 (10:46 +0000)]
efl-cxx: Fix compilation error when using a ptr to const any_value

Reviewers: lauromoura, cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7858

5 years agoeo: fix efl_isa to work propertly with interfaces
Marcel Hollerbach [Fri, 1 Feb 2019 10:08:34 +0000 (11:08 +0100)]
eo: fix efl_isa to work propertly with interfaces

mro only contains special interfaces, not in general all, in order to
have a working function, while NOT having a bad performance. In order to
achive that we just copy the code that is done on efl_isa for a object.
which is a linear walk of a list

ref D7857

Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7860

5 years agoecore_imf: fix wrong sample code
Jihoon Kim [Fri, 1 Feb 2019 07:44:57 +0000 (16:44 +0900)]
ecore_imf: fix wrong sample code

Change-Id: Iad016ed76468cc39ac63c0c28df496f8150e8546
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
5 years agoRevert "evas: make efl_canvas_animation abstract"
Jaehyun Cho [Fri, 1 Feb 2019 06:17:26 +0000 (15:17 +0900)]
Revert "evas: make efl_canvas_animation abstract"

Efl.Canvas.Animation class can be used for custom animation with
Efl.Player class' event callbacks as follows.

Example code:

void _anim_running_cb(void *data, const Efl_Event *event)
{
   //Do custom animation
}
{
   Eo *anim = efl_add(EFL_CANVAS_ANIMATION_CLASS, win);
   Eo *player = efl_add(EFL_CANVAS_ANIMATION_PLAYER_CLASS,
                        efl_animation_player_animation_set(efl_added,
                                                           anim));
   efl_event_callback_add(player, EFL_ANIMATION_PLAYER_EVENT_RUNNING,
                          _anim_running_cb, NULL);
}

As a result, Efl.Canvas.Animation is required to be a regular class
instead of an abstract class.

This reverts commit ea9ff9f547b54255d36973da8e8ba378c5ad2684.

5 years agoefl_ui_win_part: remove unused interface
WooHyun Jung [Fri, 1 Feb 2019 02:28:42 +0000 (11:28 +0900)]
efl_ui_win_part: remove unused interface

Summary:
Efl.Gfx.Entity is not used in Efl.Ui.Win.Part.
The interface can be added when it is needed later.

ref T5719

Test Plan: make check

Reviewers: zmike, bu5hm4n, cedric, Jaehyun_Cho, Hermet

Reviewed By: Hermet

Subscribers: Hermet, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T5719

Differential Revision: https://phab.enlightenment.org/D7844

5 years agoevas_private: Fix typo
Derek Foreman [Thu, 31 Jan 2019 20:10:44 +0000 (15:10 -0500)]
evas_private: Fix typo

Summary: Depends on D7853

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7854

5 years agoevas_object_smart: Consistently use MY_CLASS
Derek Foreman [Thu, 31 Jan 2019 20:06:46 +0000 (15:06 -0500)]
evas_object_smart: Consistently use MY_CLASS

Summary:
While it may not be popular opinion that MY_CLASS is confusing and does
more harm than good, using it sometimes and not others in the same file
is pretty obviously not helpful to casual readers.

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7852

5 years agoefl_ui_win: add 'exit_on_close' property and unit test
Mike Blumenkrantz [Thu, 31 Jan 2019 16:54:58 +0000 (11:54 -0500)]
efl_ui_win: add 'exit_on_close' property and unit test

Summary:
this property can enable the associated window to quit the main loop with
the passed exit code when the window is destroyed

@feature
fix T5494

Depends on D7594

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T5494

Differential Revision: https://phab.enlightenment.org/D7595

5 years agoefl_ui_win: add 'exit_on_all_windows_closed' class property and unit test
Mike Blumenkrantz [Thu, 31 Jan 2019 16:54:54 +0000 (11:54 -0500)]
efl_ui_win: add 'exit_on_all_windows_closed' class property and unit test

Summary:
this property causes the main loop to exit with the passed exit code
when the standby event is triggered

@feature
ref T5494

Reviewers: cedric, bu5hm4n, segfaultxavi

Reviewed By: cedric, bu5hm4n, segfaultxavi

Subscribers: segfaultxavi, bu5hm4n, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T5494

Differential Revision: https://phab.enlightenment.org/D7594

5 years agoelput: Update doxygen parameters
Christopher Michael [Thu, 31 Jan 2019 13:45:42 +0000 (08:45 -0500)]
elput: Update doxygen parameters

NB: No functional changes