Junseok, Kim [Mon, 13 May 2019 08:38:04 +0000 (17:38 +0900)]
ecore_wl2_display: Add some null checks.
Change-Id: I82ca08b465852ad7aff74ccc53ed82882e3643af
Hermet Park [Mon, 13 May 2019 06:45:50 +0000 (15:45 +0900)]
evas png: apply interpolation when scale down image loading.
Summary:
This patch improves png quality when image uses scale-down at image loading.
Since current scale-down logic just works like point sampling,
image result could be wholely different,
Simply, if source data is consist of continous white and black pixels,
and scale down factor is 2, the sampled data would be only white,
and lose all black pixels, or vice versa.
The result can be unexpected by users.
Even current jpeg scale-down works with interpolation.
Before:
{
F3711651}
After:
{
F3711652}
Original:
{
F3711653}
Reviewers: cedric, raster, #committers, kimcinoo, jsuya
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8788
Change-Id: I904ace4bfe944e76beb4818af43f6bc63077c163
Myoungwoon Roy, Kim [Mon, 13 May 2019 01:35:23 +0000 (10:35 +0900)]
elm doc: fix wrong ingroup name of textpath.
This patch fixes the wrong ingroup name of textpath for API reference documentation.
Change-Id: I1a23ad77afe59e9464aca290b2a9f28c6d9b24c2
Jaehyun Cho [Thu, 9 May 2019 06:59:54 +0000 (15:59 +0900)]
efl_mono: generate efl_canvas_vg_object.eo.cs
To use vector graphics in efl csharp bindings, it is permitted to
generate efl_canvas_vg_object.eo.cs.
Other efl_canvas_vg .eo.cs files have already been generated because the
file names were changed from efl_vg to efl_canvas_vg.
Change-Id: Idc8f4a7dfde7c89ba963d93d0ddd1cc7ea3463e9
Jaehyun Cho [Fri, 3 May 2019 07:41:06 +0000 (16:41 +0900)]
packaging: install libeflcustomexportsmono.so by efl-devel rpm
Like other .so files, libeflcustomexportsmono.so is supposed to be
installed by devel rpm (efl-devel rpm).
Change-Id: I9060c9f95a8dbe34c30381935f55a87131a8ca7b
Hermet Park [Thu, 9 May 2019 04:08:09 +0000 (13:08 +0900)]
ecore wayland: enable engine alpha channel in default.
This might bring less performwance at full region rendering,
but there are some compatibility issues,
Non-background ui apps, overlay video apps has been already...
Change-Id: Iebf5cdbb5cb7416d942f6e3a9de65f0fc9a68308
JunsuChoi [Wed, 8 May 2019 07:57:19 +0000 (16:57 +0900)]
ector_software_rasterizer: Support gradient mask blending
Summary: This patch supports mask blending of gradient shapes.
Test Plan: N/A
Reviewers: Hermet, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, smohanty, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8855
Change-Id: I536b6f325734f4606ba5b736c750491dcf8cb61e
Lauro Moura [Tue, 7 May 2019 11:44:23 +0000 (13:44 +0200)]
csharp: Add Part suffix for the part wrappers
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8835
Vincent Torri [Tue, 7 May 2019 10:07:19 +0000 (11:07 +0100)]
eina_file: speed up listing of directories on Windows
Summary:
forbid the creation of short name (legacy of DOS)
Without optimisation
1. using only Win32 API, just iterating over directories (in micro seconds) :
10 files : 47
1000 files : 270
100000 files : 73227
2. using eina_file_dir_list() with a callback which does nothing :
10 files : 53
1000 files : 265
100000 files : 69624
usually there is a small overhead for eina API, which is normal
With optimisation
1. using only Win32 API, just iterating over directories (in micro seconds) :
10 files : 51
1000 files : 256
100000 files : 33345
2. using eina_file_dir_list() with a callback which does nothing :
10 files : 53
1000 files : 251
100000 files : 33832
speed up with 1000 files and more. Twice faster with 100000 files
Test Plan: benchmark program
Reviewers: raster, cedric, zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8842
Hermet Park [Tue, 7 May 2019 08:34:12 +0000 (17:34 +0900)]
efl_ui_textpath: remove err log in none error case.
Ali Alzyod [Mon, 6 May 2019 12:01:24 +0000 (14:01 +0200)]
efl_ui_text: clear selection after cut
Test Plan:
```
#define EFL_EO_API_SUPPORT 1
#define EFL_BETA_API_SUPPORT 1
#include <Eina.h>
#include <Elementary.h>
#include <Efl_Ui.h>
static void
_gui_quit_cb(void *data EINA_UNUSED, const Efl_Event *event EINA_UNUSED)
{
efl_exit(0);
}
static void
_gui_setup()
{
Eo *win, *box;
win = efl_add(EFL_UI_WIN_CLASS, efl_main_loop_get(),
efl_ui_win_type_set(efl_added, EFL_UI_WIN_TYPE_BASIC),
efl_text_set(efl_added, "Hello World"),
efl_ui_win_autodel_set(efl_added, EINA_TRUE));
// when the user clicks "close" on a window there is a request to delete
efl_event_callback_add(win, EFL_UI_WIN_EVENT_DELETE_REQUEST, _gui_quit_cb, NULL);
box = efl_add(EFL_UI_BOX_CLASS, win,
efl_content_set(win, efl_added),
efl_gfx_hint_size_min_set(efl_added, EINA_SIZE2D(360, 240)));
efl_add(EFL_UI_TEXT_CLASS, box,
efl_text_markup_set(efl_added, "Hello World.<ps>This is an <b>Efl.Ui</b> application!"),
efl_text_interactive_selection_allowed_set(efl_added, EINA_TRUE),
efl_text_multiline_set(efl_added,EINA_TRUE),
efl_gfx_hint_weight_set(efl_added, 1.0, 0.9),
efl_gfx_hint_align_set(efl_added, 0.5, 0.5),
efl_pack(box, efl_added));
efl_add(EFL_UI_BUTTON_CLASS, box,
efl_text_set(efl_added, "Quit"),
efl_gfx_hint_weight_set(efl_added, 1.0, 0.1),
efl_pack(box, efl_added),
efl_event_callback_add(efl_added, EFL_UI_EVENT_CLICKED,
_gui_quit_cb, efl_added));
}
EAPI_MAIN void
efl_main(void *data EINA_UNUSED, const Efl_Event *ev EINA_UNUSED)
{
_gui_setup();
}
EFL_MAIN()
```
Reviewers: woohyun, bowonryu, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8833
Carsten Haitzler (Rasterman) [Mon, 6 May 2019 20:31:01 +0000 (21:31 +0100)]
evas - map render - quick fix for segv in new map renderer
u or v go below 0... sometimes. right now i don't know the full path
to there, bute crashes with flat theme when the busy spinner shows
over an ibar icon when you launch... this at least stops that.
this needs hunting in more detail than i'm going to do on my laptop
on the couch...
Ali Alzyod [Tue, 23 Apr 2019 15:46:47 +0000 (15:46 +0000)]
elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer
This patch deal with two cases:
1- Setting text in Entry (elm_entry_entry_set) , as the one get using (elm_entry_entry_get), caused the entry to become empty.
* becase entry string was free inside the elm_entry_entry_set function, without checking new passed string.
Now we check if same string was passed to the function, then nothing need to be changed.
```
// Old Behaviour : Entry will become empty
// New Behaviour : Entry will Skip setting same text
elm_entry_entry_set(app->entry, elm_entry_entry_get(app->entry));
```
2- Setting text in Entry (elm_entry_entry_set) , with same content string.
* internally entry will set empty string then set passed string, which will case recalculation and re-render the entry element.
Now we check if same string data that is passed to the function is the same of the entry content, then nothing need to be changed.
```
// This will be skiped internally since same text is set
elm_entry_entry_set(app->entry, "aaaaa");
elm_entry_entry_set(app->entry, "aaaaa"); //skipped
```
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8572
Daniel Kolesa [Mon, 6 May 2019 14:48:21 +0000 (16:48 +0200)]
eolian: fail on scan file conflict
If two files of the same name are found in the include paths,
the scan should fail.
Daniel Kolesa [Mon, 6 May 2019 14:46:50 +0000 (16:46 +0200)]
eolian: fix conflicts between eo file names in tests
Fixes T7911.
Mike Blumenkrantz [Tue, 30 Apr 2019 19:30:02 +0000 (15:30 -0400)]
meson: enable and fix build of ddrag+gdi engines for evas
there are some specific defines and cflags needed for these builds
to succeed and provide the expected functionality
Depends on D8733
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Vincent Torri <vincent.torri@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8734
Mike Blumenkrantz [Fri, 26 Apr 2019 13:11:59 +0000 (09:11 -0400)]
meson: fix and enable win32 ecore-evas engine build
these defines must be set in order to provide the expected engine functionality
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8733
Mike Blumenkrantz [Tue, 30 Apr 2019 19:09:59 +0000 (15:09 -0400)]
meson: do not build emotion generic loader on windows
this is not supported
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8732
Mike Blumenkrantz [Mon, 6 May 2019 14:24:56 +0000 (10:24 -0400)]
meson: add sdl deps for corresponding ecore-evas engine
this fixes the sdl engine build
Depends on D8730
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8731
Mike Blumenkrantz [Fri, 26 Apr 2019 13:10:28 +0000 (09:10 -0400)]
meson: add versioning to and install the evil dll
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8730
Mike Blumenkrantz [Fri, 26 Apr 2019 13:09:00 +0000 (09:09 -0400)]
evil: explicitly define HAVE_DL$FUNC for dl functions
these would normally be set by the build system when detecting the
system's libdl functions, but since we are providing them then we must
advertise the functionality to ensure that the right codepaths will
be used
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8729
Mike Blumenkrantz [Fri, 26 Apr 2019 13:08:23 +0000 (09:08 -0400)]
meson: set HAVE_ELEMENTARY_WIN32 on windows
this enables windows engine selections and other functionality
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8728
Mike Blumenkrantz [Fri, 26 Apr 2019 13:07:29 +0000 (09:07 -0400)]
eina: explicitly include Evil.h in eina_inline_slice.x
this file is included by itself (without Eina.h) so it must also include
its dependency headers
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8727
Mike Blumenkrantz [Fri, 26 Apr 2019 13:06:47 +0000 (09:06 -0400)]
meson: conditionally compile ecore_pipe_simple_example for windows
windows does not have fork() so this cannot be built
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8726
Mike Blumenkrantz [Fri, 26 Apr 2019 13:06:07 +0000 (09:06 -0400)]
meson: add intl to efreet all binary deps
this must be explicitly added for windows builds
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8725
Mike Blumenkrantz [Fri, 26 Apr 2019 13:04:25 +0000 (09:04 -0400)]
meson: don't run edje_cc in tree using `env`
this breaks library path setup in the build: the dependencies for runtime
are set for the 'env' executable instead of for edje_cc
for now, EFL_RUN_IN_TREE must be set manually
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8724
Mike Blumenkrantz [Fri, 26 Apr 2019 12:57:47 +0000 (08:57 -0400)]
meson: don't add / after DESTDIR in install scripts
this breaks windows usage and is unnecessary since the filename begins
with /
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8723
Mike Blumenkrantz [Fri, 26 Apr 2019 12:57:14 +0000 (08:57 -0400)]
meson: support ecore-win32
thx @vtorri
fix T7786
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8722
Lauro Moura [Mon, 6 May 2019 11:35:31 +0000 (13:35 +0200)]
csharp: Fix property helper doc indent
Summary:
Documentation generators must received their indentation as parameter
instead of explicit scope_tabs
Fixes T7794
Reviewers: segfaultxavi, felipealmeida, vitor.sousa
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7794
Differential Revision: https://phab.enlightenment.org/D8818
Daniel Kolesa [Sun, 5 May 2019 15:06:21 +0000 (17:06 +0200)]
eolian: add support for marking and checking parts as beta
Fixes T7837.
Marcel Hollerbach [Thu, 2 May 2019 18:35:34 +0000 (20:35 +0200)]
efl_ui_navigation_bar: remove Efl.Content implemention
Efl.Content implementation is here quite useless. The default part is
not in the theme, the setting will just error out. And from my POV, a
default content would not make sense.
ref T7817
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8807
Marcel Hollerbach [Thu, 2 May 2019 19:35:35 +0000 (19:35 +0000)]
efl_ui_autorepeat: fix documentations
eo_prefix is not required here. And the class documentation is improved.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8806
Marcel Hollerbach [Thu, 2 May 2019 17:48:29 +0000 (19:48 +0200)]
efl_ui_autorepeat: get rid of supported property
the property should not exist. if something is not supported then do not
inherit from this interface. If something wants to use the button
theme, then this can be easily used via API.
In legacy we already have the situation that things inherit from the
button class. To solve this, the enabled call is disabled on those
widgets, and disable every time it is called.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8805
Daniel Kolesa [Fri, 3 May 2019 15:08:34 +0000 (17:08 +0200)]
eolian tests: use parse instead of path_parse
Daniel Kolesa [Fri, 3 May 2019 14:55:59 +0000 (16:55 +0200)]
eolian: refactor parsing API and path handling
This splits the eolian_file_parse API into two, one for parsing
files already present in the database (always by filename) and
one for parsing paths.
It fixes several bugs/leaks on the way (incorrect use of
stringshare etc.) as well as adds checking for whether there
are no conflicting filenames at scan time, for free. That means
it is now no longer possible to scan two paths which have an eo
or eot file of the same name in them.
It should also be faster now.
It also fixes T7820.
@fix
Lauro Moura [Fri, 3 May 2019 14:21:58 +0000 (16:21 +0200)]
csharp: Add docs for aliases
Summary: Fixes T7689
Reviewers: vitor.sousa, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7689
Differential Revision: https://phab.enlightenment.org/D8808
Lauro Moura [Fri, 3 May 2019 13:30:00 +0000 (15:30 +0200)]
model: Add some missing docs bits.
Reviewers: cedric, segfaultxavi
Reviewed By: cedric, segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8810
Xavi Artigas [Fri, 3 May 2019 13:28:15 +0000 (15:28 +0200)]
docfx: Filter out *Concrete classes (again)
As the C# API settles down, some classes go in and out of public space.
Vincent Torri [Fri, 3 May 2019 12:09:07 +0000 (13:09 +0100)]
replace strndup with eina_strndup, remove strndup definition in evil and elm_test_dnd
Test Plan: compilation
Reviewers: cedric, zmike, raster
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8814
Lauro Moura [Fri, 3 May 2019 08:09:58 +0000 (10:09 +0200)]
csharp: Some docs improvements.
Summary:
- Silent missing docs warnign for API delegates
- Document variables
- Better docs for async functions
Reviewers: segfaultxavi, vitor.sousa
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8809
Yeongjong Lee [Fri, 3 May 2019 09:20:17 +0000 (09:20 +0000)]
ui.relative_layout: implement Efl.Pack
Now, efl_content_iterate, efl_content_count, efl_pack, efl_pack_unpack,
efl_pack_unpack_all and efl_pack_clear are available for relative_layout.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8631
Xavi Artigas [Fri, 3 May 2019 08:34:16 +0000 (10:34 +0200)]
CXX examples: remove wrong header inclusion
This was an oversight from the previous refactor.
Jaehyun Cho [Fri, 3 May 2019 07:42:42 +0000 (16:42 +0900)]
efl_mono: fix to load libevas.so based on efl.Libs.Evas
libevas.so is loaded based on efl.Libs.Evas in efl_libs.cs.
Therefore, the hard coded string "evas" is replaced with efl.Libs.Evas.
Lauro Moura [Thu, 2 May 2019 21:47:49 +0000 (21:47 +0000)]
cxx: Fix missing bits from header rename
Reviewed-by: Vincent Torri <vincent.torri@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8811
Myoungwoon Roy, Kim [Fri, 3 May 2019 04:21:05 +0000 (13:21 +0900)]
evas doc: Add a comment for Efl_Canvas_Object type.
Change-Id: I8ea0f2ce074b7d6f1ab6a0716e82bb98016f1729
Lauro Moura [Thu, 2 May 2019 18:08:04 +0000 (15:08 -0300)]
cxx: Rename Elementary.hh into Efl_Ui.hh
Also include Efl_Ui.h alongside Elementary.h (the latter is still needed
by some widgets).
Woochanlee [Thu, 2 May 2019 14:34:04 +0000 (14:34 +0000)]
evas_object_textblock: Fix binary search fail.
D8610 Makes API Testcase fault.
"<" is never searching.
@fix
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8803
Radoslaw Cybulski [Tue, 30 Apr 2019 11:59:53 +0000 (11:59 +0000)]
Fix for invalid ATSPI role on naviframe page element
ATSPI role page_tab was set on invalid object and thus ignored.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8789
Shinwoo Kim [Thu, 2 May 2019 06:57:28 +0000 (06:57 +0000)]
gfx_filter: add an example
Add an example using efl_gfx_filter_program_set with text and image object.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8719
Xavi Artigas [Mon, 29 Apr 2019 13:57:28 +0000 (15:57 +0200)]
efl-mono: Add markup support to Efl.Ui.Text
Summary:
Markup support is added to Efl.Ui.Text through runtime composition, but the C#
bindings do not know about it unless Efl.Text_Markup appears in the hierarchy.
Test Plan: The Markup property is available now for Efl.Ui.Text, it can be used and renders the expected results.
Reviewers: lauromoura, bu5hm4n, zmike
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8758
Christopher Michael [Thu, 2 May 2019 12:11:27 +0000 (14:11 +0200)]
eina_test_strbuf: Fix resource leak
Summary:
Coverity reports that we leak storage that 'buf' points to because we
are reassigning the variable, so lets free the previous strbuf so we
don't leak.
Fixes CID1400952
@fix
Depends on D8769
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8770
Christopher Michael [Thu, 2 May 2019 12:11:20 +0000 (14:11 +0200)]
eo_test_manager_xattr: Fix resource leak
Summary:
Coverity reports that we leak the eina_binbuf returned from
eina_value_to_binbuf function, so add a call to eina_binbuf_free.
Fixes CID1400953
@fix
Depends on D8762
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8769
Christopher Michael [Thu, 2 May 2019 12:11:12 +0000 (14:11 +0200)]
eina_test_tiler: Fix resource leak
Summary:
Coverity reports that reassigning 't' here leaks the storage that t
points to, so free the previous eina_tiler before reassigning the
variable.
Fixes CID1401068
@fix
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8762
Shinwoo Kim [Thu, 2 May 2019 11:50:24 +0000 (20:50 +0900)]
evas_object_image: save EVAS_IMAGE_CONTENT_HINT_DYNAMIC image
Summary:
evas_gl_common_image_content_hint_set makes RGBA_Image NULL if content hint
is EVAS_IMAGE_CONTENT_HINT_DYNAMIC with 'sec_tbm_surface' and 'egl_tbm_ext'.
efl_file_save(_efl_canvas_image_internal_efl_file_save_save) does not work
in this case because ENFN->image_data_direct_get returns FALSE.
This patch makes ENFN->image_data_direct_get work but you need to free its
returned data after using it.
Reviewers: Hermet, jsuya
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8516
Christopher Michael [Thu, 2 May 2019 11:48:27 +0000 (13:48 +0200)]
eina_test_ustr: Fix resource leak
Summary:
Coverity reports that we leak 'buf' here so add a call to free
Fixes CID1400784
@fix
Depends on D8781
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8782
Christopher Michael [Thu, 2 May 2019 11:48:22 +0000 (13:48 +0200)]
emile_test_base64: Fix memory leak
Summary:
Coverity reports that we leak 'str' here, so change the call from
eina_strbuf_reset to eina_strbuf_free
Fixes CID1400815
@fix
Depends on D8780
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8781
Christopher Michael [Thu, 2 May 2019 11:48:18 +0000 (13:48 +0200)]
emile_test_base64: Fix resource leak
Summary:
Coverity reports that we leak 'buffer' here so add a call to
eina_binbuf_free
Fixes CID1400820
@fix
Depends on D8779
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8780
Christopher Michael [Thu, 2 May 2019 11:48:11 +0000 (13:48 +0200)]
efl_ui_test_widget: Fix resource leak
Summary:
Coverity reports that we leak the variable 'a' here so lets add a call
to eina_array_free
Fixes CID1400824
@fix
Depends on D8778
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8779
Christopher Michael [Thu, 2 May 2019 11:48:00 +0000 (13:48 +0200)]
ecore_test_ecore_file: Fix resource leak
Summary:
Coverity reports that we leak the store returned from
ecore_file_realpath so add a call to free the returned storage when we
are done with it
Fixes CID1400825
@fix
Depends on D8777
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8778
Christopher Michael [Thu, 2 May 2019 11:47:55 +0000 (13:47 +0200)]
emile_test_base64: Fix resource leak
Summary:
Coverity reports that we leak the storage returned from
eina_binbuf_new here, so lets add a call to eina_binbuf_free before we
exit
Fixes CID1400852
@fix
Depends on D8776
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8777
Christopher Michael [Thu, 2 May 2019 11:47:50 +0000 (13:47 +0200)]
efl_ui_test_widget: Fix resource leak
Summary:
Coverity reports that we leak the storage returned from eina_array_new
here, so lets add a call to eina_array_free
Fixes CID1400857
@fix
Depends on D8775
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8776
Christopher Michael [Thu, 2 May 2019 11:47:45 +0000 (13:47 +0200)]
emile_test_base64: Fix resource leak
Summary:
Coverity reports that we leak the storage of variable 'decoded' here,
so lets add a call to eina_binbuf_free
Fixes CID1400868
@fix
Depends on D8774
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8775
Christopher Michael [Thu, 2 May 2019 11:47:39 +0000 (13:47 +0200)]
efl_ui_test_widget: Fix memory leak
Summary:
Coverity reports that we leak the memory from eina_array_new so lets
add a call to eina_array_free
Fixes CID1400889
@fix
Depends on D8773
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8774
Christopher Michael [Thu, 2 May 2019 11:47:33 +0000 (13:47 +0200)]
eldbus_test_eldbus_message: Fix resource leak
Summary:
Coverity reports that we leak the variable 'msg' going out of scope
here, so lets add a call to unref the returned eldbus_message so it
gets freed
Fixes CID1400921
@fix
Depends on D8772
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8773
Christopher Michael [Thu, 2 May 2019 11:47:28 +0000 (13:47 +0200)]
eina_test_file: Fix resource leak
Summary:
Coverity reports that we leak 'path' here, so free the returned string
Fixes CID1400926
@fix
Depends on D8771
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8772
Christopher Michael [Thu, 2 May 2019 11:47:22 +0000 (13:47 +0200)]
evas_test_image: Fix resource leak
Summary:
Coverity reports that we leak variable 'f' going out of scope here, so
if we are going to exit the test, lets close the file before we do
Fixes CID1400945
@fix
Depends on D8770
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8771
Christopher Michael [Thu, 2 May 2019 11:46:33 +0000 (13:46 +0200)]
eina_bench_stringshare: Fix resourcce leak
Summary:
Coverity reports that we leak the return from eina_counter_dump here,
so store the result, print it out, then we can free it.
Fixes CID1400975
@fix
Depends on D8767
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8768
Christopher Michael [Thu, 2 May 2019 11:45:59 +0000 (13:45 +0200)]
efl_ui_test_widget: Fix memory leak
Summary:
Coverity reports that we leak the eina_array 'a' here, so add a call
to eina_array_free
Fixes CID1400844
@fix
Depends on D8766
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8767
Christopher Michael [Thu, 2 May 2019 11:45:38 +0000 (13:45 +0200)]
efl_ui_test_widget: Fix memory leak
Summary:
Coverity reports that we leak the eina_array 'a' here, so add a call
to eina_array_free before we exit
Fixes CID1401003
@fix
Depends on D8765
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8766
Christopher Michael [Thu, 2 May 2019 11:44:22 +0000 (13:44 +0200)]
eina_test_binbuf: Fix memory leak
Summary:
Coverity reports that we leak 'test_buf' here so add eina_binbuf_free
to plug the leak
Fixes CID1401004
@fix
Depends on D8764
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8765
Christopher Michael [Thu, 2 May 2019 11:43:57 +0000 (13:43 +0200)]
evas_test_mesh: Fix memory leak
Summary:
Coverity reports that we leak file_mask variable here (storage
returned from strdup), so lets free the variable before we exit the test
Fixes CID1401009
@fix
Depends on D8763
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8764
Christopher Michael [Thu, 2 May 2019 11:43:32 +0000 (13:43 +0200)]
emile_test_base64: Fix resource leak
Summary:
Coverity reports that we leak storage of variable 'str' here, so call
eina_strbuf_free
Fixes CID1401062
@fix
Depends on D8762
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8763
Christopher Michael [Thu, 2 May 2019 11:43:04 +0000 (13:43 +0200)]
elm_test_widget_focus: Fix memory leak
Summary:
Coverity reports that we leak the 'map' hash here, so lets add a call
to free the hash
Fixes CID1401069
@fix
Depends on D8760
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8761
Christopher Michael [Thu, 2 May 2019 11:42:08 +0000 (13:42 +0200)]
efl_check: Fix memory leak
Summary:
Coverity reports that we leak variable 'n' here (memory returned from
strdup) so let's free it
Fixes CID1401070
@fix
Depends on D8759
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8760
Christopher Michael [Thu, 2 May 2019 11:40:31 +0000 (13:40 +0200)]
eina_test_file: Fix memory leak
Summary:
Coverity reports that we leak big_buffer here, so lets free it.
Fixes CID1401072
@fix
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8759
Hermet Park [Thu, 2 May 2019 11:19:24 +0000 (20:19 +0900)]
Revert "evas png: apply interpolation when scale down image loading."
This reverts commit
53cdf850ba0f10a4a4db3e3c7f7cf1742ca88db1.
It's still on reviewing, I didn't intend submitting.
Hermet Park [Thu, 2 May 2019 07:42:25 +0000 (16:42 +0900)]
evas png: apply interpolation when scale down image loading.
Summary:
This patch improves png quality when image uses scale-down at image loading.
Since current scale-down logic just works like point sampling,
image result could be wholely different,
Simply, if source data is consist of continous white and black pixels,
and scale down factor is 2, the sampled data would be only white,
and lose all black pixels, or vice versa.
The result can be unexpected by users.
Even current jpeg scale-down works with interpolation.
Before:
{
F3711651}
After:
{
F3711652}
Original:
{
F3711653}
Reviewers: cedric, raster, #committers, kimcinoo, jsuya
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8788
Vincent Torri [Tue, 30 Apr 2019 15:37:54 +0000 (15:37 +0000)]
Eina: add eina_strndup() API as inlined function
this add strndup implementation that does not seg fault when string is NULL.
This also implements strndup on Windows.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8790
Marcel Hollerbach [Fri, 26 Apr 2019 14:04:03 +0000 (16:04 +0200)]
efl_ui_spec: we can add efl_ui_pager now
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8752
Marcel Hollerbach [Fri, 26 Apr 2019 18:22:14 +0000 (20:22 +0200)]
efl_ui_pager: track lifetime of children
when a child is deleted (externally), the widget should be forgotten
internally.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8751
Marcel Hollerbach [Fri, 26 Apr 2019 16:54:24 +0000 (18:54 +0200)]
efl_ui_pager: error when you try to delete something which unavailable
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8750
Marcel Hollerbach [Fri, 26 Apr 2019 16:53:44 +0000 (18:53 +0200)]
efl_ui_pager: redirect deleted objects to the top
otherwise we would not give up ownership of the widget
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8749
Marcel Hollerbach [Fri, 26 Apr 2019 16:52:29 +0000 (18:52 +0200)]
efl_ui_pager: implement rollover behavior
this behavior is implemented in efl_pack, so this should be in this
implementation.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8748
Marcel Hollerbach [Fri, 26 Apr 2019 16:50:59 +0000 (18:50 +0200)]
efl_ui_widget: error on NULL passing
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8747
Marcel Hollerbach [Fri, 26 Apr 2019 16:30:31 +0000 (18:30 +0200)]
efl_ui_pager: refactor object addition
this reduces LOC and keeps functionality.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8746
Marcel Hollerbach [Fri, 26 Apr 2019 15:30:35 +0000 (17:30 +0200)]
efl_ui_pager: ensure that only valid objects are removed
everything else will just print errors
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8745
Marcel Hollerbach [Fri, 26 Apr 2019 15:25:05 +0000 (17:25 +0200)]
efl_ui_pager: implement content iterator
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8744
Marcel Hollerbach [Fri, 26 Apr 2019 15:19:59 +0000 (17:19 +0200)]
efl_ui_pager: ensure deletion behavior
when a object is unpacked, we should ensure that only elements are
deleted from the box when they are added.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8742
Marcel Hollerbach [Fri, 26 Apr 2019 15:19:37 +0000 (17:19 +0200)]
efl_ui_pager: ensure objects are added and deduplicated
everything else will make things fall apart
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8741
Marcel Hollerbach [Fri, 26 Apr 2019 14:46:58 +0000 (16:46 +0200)]
efl_ui_pager: refactor registering function for pager
this is a starting point for further function additions. this is esp.
usefull since a few functions need to be executed to every added object.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8740
Marcel Hollerbach [Fri, 26 Apr 2019 13:51:09 +0000 (15:51 +0200)]
efl_ui_pager: provide a pack( implementation
this is needed in order to make efl_ui_pager complete.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8739
Marcel Hollerbach [Fri, 26 Apr 2019 12:29:20 +0000 (14:29 +0200)]
efl_ui_pager: lets stop returning false when in animation
i don't know why this is here. But undependend from if the widget is in
animation or not. We should ensure that the added content to the pager
is displayed and added. Having this failing is super unexpected to the
user, and basically undebuggable.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8738
Marcel Hollerbach [Fri, 26 Apr 2019 12:23:58 +0000 (14:23 +0200)]
efl_ui_pager: mark box internal
otherwise they will adjust the parent property, and we do not want to
have that.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8737
Marcel Hollerbach [Fri, 26 Apr 2019 12:16:30 +0000 (14:16 +0200)]
efl_ui: add a internal flag to mark widgets internal
when a widget is marked internal, widgets can use that to behave in
certain ways. Box for example uses this to not alter the widget_parent
property anymore. Which is usefull for when boxes are used internally.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8736
Carsten Haitzler (Rasterman) [Tue, 30 Apr 2019 10:49:12 +0000 (11:49 +0100)]
ecore drm2 - fix timeout in case case called from thread
so sw rendering make call ecore drm2 calls from a thread - i didnt
know that. so this makes my fix for gl hangs add hangs in sw as a
result. this fixes that. not perfect but better. do need refcoutnts on
outputs to be perfect...
also sometimes the commits fail so retry a few times...
this still leaves us wth another hang that is a separate issue.
@fix
Carsten Haitzler (Rasterman) [Tue, 30 Apr 2019 10:48:15 +0000 (11:48 +0100)]
ecore evas drm - make vsync animators a possible ifdef
this makes it easyeir to swizzle on and off
Marcel Hollerbach [Tue, 30 Apr 2019 10:15:33 +0000 (12:15 +0200)]
meson: add docs
Summary:
this here brings one new top level target which is doc. It is not build
by default, and does rerun everything on every call.
ninja doc will create previews and run the doxygen command. After this
is done, a tarbal of the html & man will be created, latex is not added
for now, due to the unability to compile the resulting .tex files.
Nothing of the documentation is installed for now, if this would be
enabled, then every single ninja install would regenerate the whole
documentation again, which is quite a lot, and quite a pain (and
sometimes crashes)
While porting this over, i encountered a problem with *convert* the bug
report is linked in the comment.
fix T7781
Depends on D8690
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7781
Differential Revision: https://phab.enlightenment.org/D8561
Vincent Torri [Tue, 30 Apr 2019 08:23:38 +0000 (09:23 +0100)]
eina_unicode: return NULL if allocation fails
Reviewers: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8785
Jaehyun Cho [Tue, 30 Apr 2019 02:16:06 +0000 (11:16 +0900)]
Revert "efl.ui.widget: disable parts{} block for now"
This reverts commit
06aabbf8529edd5f09a1ce7c3c59237b2857e98a.
The original commit is reverted after release.
Change-Id: Ife55d7ca922bb70c9a766522318d521106e359a5
JunsuChoi [Tue, 7 May 2019 07:25:48 +0000 (16:25 +0900)]
Revert "canvas vg: code refactoring."
This reverts commit
83522bce29e546e90c51cc9220121a1c8220c84b.
This is a commit that was caused by an wrong migration.
revert it because it causes an error during animation play.
Change-Id: Ie6e03004888b79b48a25f9aa44d658f9571914e0