platform/core/connectivity/bluetooth-frwk.git
19 months agoAdd EIR manufacturer data handling logic 17/290917/1
Wootak Jung [Wed, 5 Apr 2023 05:04:14 +0000 (14:04 +0900)]
Add EIR manufacturer data handling logic

Change-Id: Ie320eeb1663f6384c20daf4c4336abdfe13e4609
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
20 months agoAdd adv data custom name handling logic 04/288404/2 accepted/tizen/unified/20230303.162750
Wootak Jung [Thu, 16 Feb 2023 06:40:30 +0000 (15:40 +0900)]
Add adv data custom name handling logic

Change-Id: Ia7a9db2d407855dfa4b38ee31f35be08f9f80bd3
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
20 months agoAdd support for custom advertising flags. 50/286850/5 accepted/tizen/unified/20230223.162142
Jakub Latusek [Wed, 1 Feb 2023 05:56:12 +0000 (14:56 +0900)]
Add support for custom advertising flags.

It is required to set proper advertising flags when establishing a
connection using
Bluetooth low energy to properly recognize device type.
Without this, the Linux device cannot recognize the Tizen device
properly and establish a connection.

Change-Id: I7899e9ab56a40095df3a91aa15fc956ebd2aea58
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
Signed-off-by: Jakub Latusek <j.latusek@samsung.com>
20 months agoAdd DA feature newly 94/287994/2
Wootak Jung [Thu, 9 Feb 2023 01:17:17 +0000 (10:17 +0900)]
Add DA feature newly

da feature contains many da models as well as fhub

Change-Id: I6094be712d02db52f9f0164ab54b1620c558c6d8
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
21 months agoMerge "Fix Coverty Issues" into tizen accepted/tizen/unified/20230130.165630
Ayush Garg [Mon, 16 Jan 2023 05:16:34 +0000 (05:16 +0000)]
Merge "Fix Coverty Issues" into tizen

21 months agoIncrease the version to 7.5 84/286784/1 accepted/tizen/unified/20230117.140440
Wootak Jung [Fri, 13 Jan 2023 01:05:08 +0000 (10:05 +0900)]
Increase the version to 7.5

Change-Id: I23a790f0908340d36b259edfef7e8d5f91fda64f
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
22 months agoFix Coverty Issues 74/286674/1
Anuj Kumar Singh [Wed, 11 Jan 2023 11:01:04 +0000 (16:31 +0530)]
Fix Coverty Issues

This patch fixes following covery issues:
CID-1619563
CID-1619564

Change-Id: Idcc24b7a3696bcad14ba98d0d7eead2605613eaa
Signed-off-by: Anuj Kumar Singh <anujk.singh@samsung.com>
22 months agoChange the adapter state check logic 37/286437/1 accepted/tizen/unified/20230111.174536
Wootak Jung [Fri, 6 Jan 2023 04:58:37 +0000 (13:58 +0900)]
Change the adapter state check logic

Change-Id: If283fa348962eec9a175119ff1e9e2c6880697db
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
22 months agoFix adapter state mismatch issue 37/286337/4 accepted/tizen/unified/20230109.151000
Wootak Jung [Thu, 5 Jan 2023 02:34:43 +0000 (11:34 +0900)]
Fix adapter state mismatch issue

if bt-service crashed, adapter disabled event is coming.
but, right after receiving the event, adapter state is enabled
add service available check logic

Change-Id: I729b10c5fa0b0a4971c4bd37c60836acac8c1c96
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
22 months agoModify the timeout value for l2cap connect 62/286262/1
Wootak Jung [Tue, 3 Jan 2023 02:43:11 +0000 (11:43 +0900)]
Modify the timeout value for l2cap connect

50s is too late in timeout case

Change-Id: Ib721035ebb2ff07fc124f359a5d871c1c73cb2de
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
22 months agoFix remote device address in connectionStateChangedCb 66/286066/1
Ayush Garg [Mon, 26 Dec 2022 10:12:49 +0000 (15:42 +0530)]
Fix remote device address in connectionStateChangedCb

This patch will fill the correct remote address in the
connectionStateChangedCb when the socket connection got failed.

Change-Id: I1d468408b6e3afca3f26e3935cc9bb84de7af43f
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
23 months agoAdd l2cap channel EOF handling logic like rfcomm 39/285039/2 accepted/tizen/unified/20221206.170557
Wootak Jung [Mon, 5 Dec 2022 03:46:53 +0000 (12:46 +0900)]
Add l2cap channel EOF handling logic like rfcomm

Remove the unnecessary bluedroid specific logic

Change-Id: I9054e035d461bd6a8a5daa874e47747c920e1399
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
23 months agoAdd discovery busy logic if bonding is in progress 13/284713/1
Wootak Jung [Thu, 24 Nov 2022 06:13:20 +0000 (15:13 +0900)]
Add discovery busy logic if bonding is in progress

Change-Id: I151e022e58c996e26d5d503836e9a2a799661431
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
2 years agoAdd sender to invocation info 15/283915/1
Wootak Jung [Mon, 7 Nov 2022 06:27:13 +0000 (15:27 +0900)]
Add sender to invocation info

Change-Id: I7b7939b0407cf3c212ec8574259876c53196a2c1
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
2 years agoChange some non-inclusive words 39/283539/1 accepted/tizen/unified/20221103.165737
Wootak Jung [Fri, 28 Oct 2022 08:25:05 +0000 (17:25 +0900)]
Change some non-inclusive words

Change-Id: I06c475809ead89c6edb16ba42bc0d3d1fccdb4a6
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
2 years agoChange log level from error to debug 34/283334/2
Jakub Latusek [Mon, 24 Oct 2022 12:26:04 +0000 (14:26 +0200)]
Change log level from error to debug

This is a debug message which is not needed to be logged as an error.

Change-Id: I52f95741b4dc1a2dce3bde8de371c9b5d63ba368
Signed-off-by: Jakub Latusek <j.latusek@samsung.com>
2 years agoInclusive language changes 78/283178/2
Anuj Jain [Thu, 20 Oct 2022 01:02:01 +0000 (06:32 +0530)]
Inclusive language changes

BT core spec 5.3 promotes the usage of inclusive languages.
This patch replaces non-inclusive words with inclusive ones.

Change-Id: I7946af9cab584f0f44baa208782b6930e6afcef1
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
2 years agoFix the rssi parsing issue 87/282887/1
Wootak Jung [Thu, 13 Oct 2022 04:29:45 +0000 (13:29 +0900)]
Fix the rssi parsing issue

D/BLUETOOTH_HAL(  336): bt-hal-event-receiver.c: __bt_hal_device_properties_lookup(1793) > Device RSSI [0] Property num [6]
D/BLUETOOTH_HAL(  336): bt-hal-event-receiver.c: __bt_hal_device_properties_lookup(1793) > Device RSSI [0] Property num [6]
D/BLUETOOTH_HAL(  336): bt-hal-event-receiver.c: __bt_hal_device_properties_lookup(1793) > Device RSSI [0] Property num [6]

Change-Id: I1efa6e609bafb368ae2ae247cebbd5b83f85edc2
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
2 years agofhub: remove duplicate code in bluetooth_hf_audio_mute API 77/282277/1 accepted/tizen_7.0_unified_hotfix tizen_7.0_hotfix accepted/tizen/7.0/unified/20221110.060830 accepted/tizen/7.0/unified/hotfix/20221116.105140 accepted/tizen/unified/20221006.065308 accepted/tizen/unified/20221006.065347 tizen_7.0_m2_release
Ayush Garg [Thu, 29 Sep 2022 09:12:06 +0000 (14:42 +0530)]
fhub: remove duplicate code in bluetooth_hf_audio_mute API

Change-Id: I914d10f81e998c4f9d208ece96c3706fce3905e9
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
2 years agofhub: terminate bt-core when the core adapter status is abnormal 03/281703/1
Ayush Garg [Wed, 21 Sep 2022 02:13:33 +0000 (07:43 +0530)]
fhub: terminate bt-core when the core adapter status is abnormal

when BT core status is abnormal (ex. recursive BT module detachment),
bt-core process is not terminated because of it is recovery mode.
then the core adapter status is stuck in BT_DEACTIVATING status,
after that the BT adapter can't be enabled / disabled.

So, in bt_check_terminating_condition, add check core status and recovery mode.
if it is abnormal, let the bt-core be terminated.

Change-Id: I48e4903e448e54743469afbd7b59d8cec7d520d2
Signed-off-by: shss-choi <shss.choi@samsung.com>
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
2 years agofhub: add DA features 02/281702/1
Ayush Garg [Tue, 20 Sep 2022 08:18:26 +0000 (13:48 +0530)]
fhub: add DA features

Applied patches:
- add bluetooth_hf_audio_mute api
- modify to set BT frwk adapter state to 'deactived' when
adapter_enable is failed abnormally

Change-Id: Ifc77646b0ef4cac509c88b647d86855baa658d3e
Signed-off-by: shss-choi <shss.choi@samsung.com>
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
2 years agofhub: reject A2DP sink/HF/AVRCP CT profile connect request when local a2dp role is... 01/281701/1
Ayush Garg [Tue, 20 Sep 2022 07:29:21 +0000 (12:59 +0530)]
fhub: reject A2DP sink/HF/AVRCP CT profile connect request when local a2dp role is source

Change-Id: I83a0c8c132945971acd4dde3e840f8b43c91e14b
Signed-off-by: shss-choi <shss.choi@samsung.com>
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
2 years agofhub: reject A2DP(sink)/AVRCP(controller) multi connection 00/281700/1
Ayush Garg [Tue, 20 Sep 2022 06:46:28 +0000 (12:16 +0530)]
fhub: reject A2DP(sink)/AVRCP(controller) multi connection

if there is connected A2DP source device,
reject incoming A2DP(local: sink, remote: source) connection.
if there is connected AVRCP target device,
reject incoming AVRCP(local: CT, remote: TG) connection.

Change-Id: Id455b77641977c921eec936aaa4aa98552619652
Signed-off-by: shss-choi <shss.choi@samsung.com>
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
2 years agofhub: set general discoverable mode to default 76/281476/2
Ayush Garg [Mon, 19 Sep 2022 09:13:19 +0000 (14:43 +0530)]
fhub: set general discoverable mode to default

in first booting, set discoverable mode to general discoverable mode (visibility on)

Change-Id: I3905052489abea0e2c68212f1b1312c065d3cb27
Signed-off-by: shss-choi <shss.choi@samsung.com>
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
2 years agofhub: Add new profile for Family Hub 75/281475/2
Ayush Garg [Fri, 16 Sep 2022 04:39:17 +0000 (10:09 +0530)]
fhub: Add new profile for Family Hub

Change-Id: If609de47a88749fa2029b0d64048c9d0a5e21154
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
2 years agoExclude files from SAM analysis 61/280561/2
Anuj Jain [Wed, 31 Aug 2022 16:36:16 +0000 (22:06 +0530)]
Exclude files from SAM analysis

Files having calls to library functions of gio/gio.h are excluded as
they have similar syntax leading to duplicate code.

Change-Id: I8307dffcca0b22136573f840a835298531edc0cc
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
2 years agoMerge "Refactoring of Code to improve SAM score Patch-5" into tizen
Pyun DoHyun [Mon, 5 Sep 2022 03:01:22 +0000 (03:01 +0000)]
Merge "Refactoring of Code to improve SAM score Patch-5" into tizen

2 years agoMerge "Refactoring of Code to improve SAM score Patch-4" into tizen
Pyun DoHyun [Mon, 5 Sep 2022 03:01:19 +0000 (03:01 +0000)]
Merge "Refactoring of Code to improve SAM score Patch-4" into tizen

2 years agoMerge "Refactoring of Code to improve SAM score Patch-3" into tizen
Pyun DoHyun [Mon, 5 Sep 2022 03:01:16 +0000 (03:01 +0000)]
Merge "Refactoring of Code to improve SAM score Patch-3" into tizen

2 years agoMerge "Refactoring of Code to improve SAM score Patch-2" into tizen
Pyun DoHyun [Mon, 5 Sep 2022 03:01:13 +0000 (03:01 +0000)]
Merge "Refactoring of Code to improve SAM score Patch-2" into tizen

2 years agoMerge "Refactoring of Code to improve SAM score Patch-1" into tizen
Pyun DoHyun [Mon, 5 Sep 2022 03:01:11 +0000 (03:01 +0000)]
Merge "Refactoring of Code to improve SAM score Patch-1" into tizen

2 years agoRefactoring of Code to improve SAM score Patch-5 60/280560/2
Anuj Jain [Wed, 31 Aug 2022 16:34:35 +0000 (22:04 +0530)]
Refactoring of Code to improve SAM score Patch-5

Remove Duplicate code:

- Move duplicate functions to common accessible file.
- Implement new function in common file for duplicate code segment.

Change-Id: Id2e205e587a21e195aba7474b9165f8ac36b06b7
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
2 years agoRefactoring of Code to improve SAM score Patch-4 59/280559/2
Anuj Jain [Wed, 31 Aug 2022 16:26:37 +0000 (21:56 +0530)]
Refactoring of Code to improve SAM score Patch-4

Remove duplicated code:

- Create new common file and move duplicate function to it.

Change-Id: I715b5806174d05a3febb58752519ee8681c23e7b
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
2 years agoRefactoring of Code to improve SAM score Patch-3 58/280558/2
Anuj Jain [Wed, 31 Aug 2022 16:22:02 +0000 (21:52 +0530)]
Refactoring of Code to improve SAM score Patch-3

Remove duplicated code:

- Add sub function for duplicated code.

Change-Id: I4defc0de7c9f67ef397af58776cd3d04eaf0e7d2
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
2 years agoRefactoring of Code to improve SAM score Patch-2 57/280557/4
Anuj Jain [Wed, 31 Aug 2022 16:19:16 +0000 (21:49 +0530)]
Refactoring of Code to improve SAM score Patch-2

Remove duplicated code:

- Add sub function for duplicated code.

Change-Id: I4907f1d86e0530500ddff2a6777e8ef7eab5ea9a
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
2 years agoRefactoring of Code to improve SAM score Patch-1 56/280556/1
Anuj Jain [Wed, 31 Aug 2022 16:15:29 +0000 (21:45 +0530)]
Refactoring of Code to improve SAM score Patch-1

Remove duplicated code:

- Implement common function for functions with duplicated code.

Change-Id: I87c245bbe393a120439de23ec1395424a3dd1fa6
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
2 years agoFix the issue that the data is not fully delivered 89/280489/2
Wootak Jung [Wed, 31 Aug 2022 01:42:03 +0000 (10:42 +0900)]
Fix the issue that the data is not fully delivered

I/BLUETOOTH_FRWK_API( 3421): bt-l2cap-le-client.c: __write_all(542) > written: 122, len 122
I/BLUETOOTH_FRWK_API( 3421): bt-l2cap-le-client.c: __write_all(544) > index 0 : data 79
I/BLUETOOTH_FRWK_API( 3421): bt-l2cap-le-client.c: __write_all(544) > index 1 : data 1a
I/BLUETOOTH_FRWK_API( 3421): bt-l2cap-le-client.c: __write_all(544) > index 2 : data 77
I/BLUETOOTH_FRWK_API( 3421): bt-l2cap-le-client.c: __write_all(544) > index 3 : data 8b
..
I/BLUETOOTH_HAL( 9157): bt-hal-l2cap-le-dbus-handler.c: app_event_cb(255) > len: 3
I/BLUETOOTH_HAL( 9157): bt-hal-l2cap-le-dbus-handler.c: app_event_cb(257) > Received data, index: 0 : 79
I/BLUETOOTH_HAL( 9157): bt-hal-l2cap-le-dbus-handler.c: app_event_cb(257) > Received data, index: 1 : 1a
I/BLUETOOTH_HAL( 9157): bt-hal-l2cap-le-dbus-handler.c: app_event_cb(257) > Received data, index: 2 : 77
D/BLUETOOTH_HAL( 9157): bt-hal-l2cap-le-dbus-handler.c: write_all(191) > len 3
I/BLUETOOTH_HAL( 9157): bt-hal-l2cap-le-dbus-handler.c: write_all(197) > written 3

Change-Id: I4ee146230c0113592a45ad1c39f9bb6bc71cf6b5

2 years agoMerge "Modify authorize to FALSE in l2cap le connection" into tizen accepted/tizen/unified/20220823.131823 submit/tizen/20220816.082553 submit/tizen/20220822.114248
Wootak Jung [Tue, 9 Aug 2022 22:41:02 +0000 (22:41 +0000)]
Merge "Modify authorize to FALSE in l2cap le connection" into tizen

2 years agoModify authorize to FALSE in l2cap le connection 13/279413/1
Wootak Jung [Tue, 9 Aug 2022 04:19:22 +0000 (13:19 +0900)]
Modify authorize to FALSE in l2cap le connection

Change-Id: Icf4d8a51acc444765a9b61224a3a5d3fd26bfa65

2 years agoGATT: Add support for multiple services and descriptors with same UUID. 59/279059/1
Anuj Jain [Mon, 1 Aug 2022 09:16:58 +0000 (14:46 +0530)]
GATT: Add support for multiple services and descriptors with same UUID.

This patch adds support to handle GATT operations on
1. Multiple Services with same UUID.
2. Multiple Descriptors with same UUID.

Change-Id: I946183cb5c5fcc4e4d9ff2fbad2f807419b6ade5
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
2 years agoFix the crash issue when name changed 30/278930/1
Wootak Jung [Thu, 28 Jul 2022 01:48:19 +0000 (10:48 +0900)]
Fix the crash issue when name changed

Change-Id: Ie2f9290f250d1def551c6c31272970c832ce36ed

2 years agoFix paired device array exceed issue 29/278929/1
Wootak Jung [Wed, 27 Jul 2022 23:28:30 +0000 (08:28 +0900)]
Fix paired device array exceed issue

bt-hal-adapter-dbus-handler.c: __bt_adapter_bonded_devices_cb(1765) >\
Send Adapter properties changed event to HAL user, Num Prop [1] total size [1031]

Change-Id: I516b66587484c4a4ace363a34bf497ef319515b7

2 years agoAdd support for multiple charateristics with same UUID 59/277359/1
Anuj Jain [Tue, 5 Jul 2022 12:32:37 +0000 (18:02 +0530)]
Add support for multiple charateristics with same UUID

This patch adds support to handle GATT operations on multiple
characteristics of a Service with same UUID.

Change-Id: Ic3574862d76a050baf9e2ebb0e90e8767a4bbfbf
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
2 years agobt-api: Add container handling logic 71/276871/1 accepted/tizen/unified/20220629.152913 accepted/tizen/unified/20220629.152919 submit/tizen/20220627.234633 submit/tizen/20220627.235246
Wootak Jung [Mon, 27 Jun 2022 08:14:21 +0000 (17:14 +0900)]
bt-api: Add container handling logic

Don't read vconf to check le status

Change-Id: Idae35113635cdc0d51ca5cc6930b0cc737da6855

2 years agoFix Dereferencing of NULL pointer error 62/276262/1
Anuj Jain [Mon, 13 Jun 2022 13:44:06 +0000 (19:14 +0530)]
Fix Dereferencing of NULL pointer error

Change-Id: Ia3e1e098401ffe0e3ff4ec23b4bae601be570c08
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
2 years agoRemove unnecessary logs and update internal functions as static 00/275900/1 accepted/tizen/unified/20220615.135349 submit/tizen/20220614.010252
Anuj Jain [Mon, 6 Jun 2022 08:24:40 +0000 (13:54 +0530)]
Remove unnecessary logs and update internal functions as static

Change-Id: I42e6413c5350c19c3fc79bc33b474f79e4b8e404
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
2 years agoModify platform scan filter logic 92/275492/2 submit/tizen/20220531.044319 submit/tizen/20220601.225953
Wootak Jung [Thu, 26 May 2022 01:05:03 +0000 (10:05 +0900)]
Modify platform scan filter logic

Add vendor filter flag
Don't request filter operation to oal if vendor filter not supported

Change-Id: Idcdca2f1b98ed9d079035a5d00641628fb17e4f5

2 years agoFix bt-service crash issue in FHub product 95/274695/3
Anuj Jain [Fri, 6 May 2022 07:19:32 +0000 (12:49 +0530)]
Fix bt-service crash issue in FHub product

This patch fixes bt-service crash occuring due to array overflow.

Change-Id: Idde2cccd6e31c2c5fdafc06add7fff6745339fcd
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
2 years agoFix crash issue in FHub product 91/274391/1 accepted/tizen/unified/20220503.071444 submit/tizen/20220502.051527 submit/tizen/20220502.224718
Ayush Garg [Wed, 27 Apr 2022 10:25:45 +0000 (15:55 +0530)]
Fix crash issue in FHub product

Backtrace:
4  0xb62d7a4e in g_malloc0 (n_bytes=n_bytes@entry=4294967295) at ../glib/gmem.c:134 --> libglib (rpm)
5  0x00472432 in __bt_set_multi_adv_param (adv_setup=adv_setup@entry=0xbe0db954, adv_data=adv_data@entry=0xbe0dba5c, length=length@entry=2) at /usr/src/debug/bluetooth-frwk-0.6.0/bt-service/services/adapter/bt-service-core-adapter-le.c:1467 --> bluetooth-frwk-service (rpm)
6  0x004729b4 in _bt_set_scan_response_data (sender=0x518228 ":1.108", adv_handle=5764800, response=response@entry=0xbe0dba5c, length=2, use_reserved_slot=use_reserved_slot@entry=0) at /usr/src/debug/bluetooth-frwk-0.6.0/bt-service/services/adapter/bt-service-core-adapter-le.c:1768 --> bluetooth-frwk-service (rpm)

The crash was occuring due to incorrect manufacturer
length.
This patch fixes the same.

Change-Id: I16cfd653e46615ed5fa386a6e8281591526ff689
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
2 years agoFix the ADV crash issue in FHub product 32/274332/1
Ayush Garg [Tue, 26 Apr 2022 10:26:15 +0000 (15:56 +0530)]
Fix the ADV crash issue in FHub product

Backtrace:
0  0xb2c5a112 in __bt_hal_parse_uuid (len=len@entry=44300, src=0x0, src@entry=0x102 <error: Cannot access memory at address 0x102>, dest=dest@entry=0xbe3747b4 "", length=0xbe3747ac, length@entry=0xbe37478c, is_solicit=is_solicit@entry=1) at /usr/include/bits/string_fortified.h:34 --> bluetooth-frwk-oal (rpm)
1  0xb2c5b2d2 in _bt_hal_set_advertising_data (adv_param_setup=...) at /usr/src/debug/bluetooth-frwk-0.6.0/bt-oal/bluez_hal/src/bt-hal-adapter-le.c:802 --> bluetooth-frwk-oal (rpm)

The crash was occuring due to parsing of wrong appearance
characteristic length.
This patch fixes the same.

Change-Id: I48524f69158b7fd3ac01811f05f2d9dbfe139fc6
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
2 years agoFix unnecessary event sending issue 49/273949/1
Wootak Jung [Tue, 19 Apr 2022 01:34:43 +0000 (10:34 +0900)]
Fix unnecessary event sending issue

passkey conformation event is not required in auto accept case

Change-Id: Idff8dc50b14416487ec358154fd7704aa95149ec

2 years agoChange the privilege level for L2CAP listen related functions 68/273668/1
Wootak Jung [Tue, 12 Apr 2022 02:19:30 +0000 (11:19 +0900)]
Change the privilege level for L2CAP listen related functions

Change-Id: Ic5b577ab81a643e6b969e865eeb3daf204838cc5

2 years agoLE CoC: Fix LE_L2CAP socket connection timeout issue 43/273343/1
Anuj Jain [Mon, 4 Apr 2022 12:53:02 +0000 (18:23 +0530)]
LE CoC: Fix LE_L2CAP socket connection timeout issue

This patch fixes the issue of non occurence of authentication
pop-up upon connection request by client.

Change-Id: Iea5e1807c6c577baf8fe9b43da4053df97bbbc0b
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
2 years agoFix svace issue 60/272560/1 accepted/tizen/unified/20220323.062643 submit/tizen/20220322.002237
Wootak Jung [Mon, 21 Mar 2022 02:34:39 +0000 (11:34 +0900)]
Fix svace issue

Remove unnecessary check logic

Change-Id: I50ad8b43185c81722b85102de41d0b1057ba8ad1

2 years agoLE CoC: Fix socket events not coming in client role 25/272425/1
Ayush Garg [Wed, 16 Mar 2022 07:25:18 +0000 (12:55 +0530)]
LE CoC: Fix socket events not coming in client role

This patch will add the support for registering
L2CAP LE socket client events.

Change-Id: If991e7f5ed3cb2b79070fbc6daceff47482b70fe
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
2 years agoLE CoC: Fix build issue for aarch64 89/272289/1 accepted/tizen/unified/20220318.133048 submit/tizen/20220313.220938 submit/tizen/20220314.225934 submit/tizen/20220316.003414 submit/tizen/20220317.013237
Ayush Garg [Mon, 14 Mar 2022 06:39:44 +0000 (12:09 +0530)]
LE CoC: Fix build issue for aarch64

Change-Id: I2fc506e2ca46803d20275d4ec91c4693caee04be
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
2 years agoMerge "Remove mobile profile specific logic" into tizen
Wootak Jung [Fri, 11 Mar 2022 05:42:44 +0000 (05:42 +0000)]
Merge "Remove mobile profile specific logic" into tizen

2 years agoLE CoC: Add FRWK APIs for L2CAP_LE type socket 64/272064/1
Ayush Garg [Mon, 7 Mar 2022 06:28:00 +0000 (11:58 +0530)]
LE CoC: Add FRWK APIs for L2CAP_LE type socket

This patch adds the following:
- Export APIs to create and remove L2CAP_LE socket
- Export APIs to listen, connect and disconnect to
L2CAP_LE socket
- Implement event handler for connection, disconnection
and authorization.

Change-Id: I7808664b833da9f0625b75d7fe4640fdd3cd52b3
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
2 years agoRemove mobile profile specific logic 22/272022/2
Wootak Jung [Mon, 7 Mar 2022 01:31:58 +0000 (10:31 +0900)]
Remove mobile profile specific logic

Change-Id: I3d6cdfa86cca2582dd8de3532f33bbaf467201b7

2 years agoLE CoC: Add support for L2CAP_LE type socket in bt-service 53/271753/2
Ayush Garg [Wed, 23 Feb 2022 10:58:48 +0000 (16:28 +0530)]
LE CoC: Add support for L2CAP_LE type socket in bt-service

This patch adds the following:
- Implement methods to connect and listen to SOCK_TYPE_L2CAP_LE
Socket.
- Implement methods to authorize(accept/reject) incoming L2CAP_LE
connection.

Change-Id: If47da01dc9a867d892ced3f847927213da9b66cf
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
2 years agoLE CoC: Add support for L2CAP_LE type socket in OAL 57/271557/1
Ayush Garg [Mon, 21 Feb 2022 10:44:26 +0000 (16:14 +0530)]
LE CoC: Add support for L2CAP_LE type socket in OAL

This patch adds support for OAL_SOCK_L2CAP_LE type
socket.

Change-Id: I190535687e7eb312535b5ff5584f51fcac47ec38
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
2 years agoLE CoC: Add HAL implementation for L2CAP_LE type socket 37/271437/2
Ayush Garg [Mon, 21 Feb 2022 07:43:45 +0000 (13:13 +0530)]
LE CoC: Add HAL implementation for L2CAP_LE type socket

This patch adds following
- Implement HAL interface to create and remove L2CAP_LE Socket
- Implement HAL interface to listen and connect to L2CAP_LE Socket
- Support for L2CAP_LE socket authorization

Change-Id: Ifd4297f77a327ded5b7f51a3bc56c72f1416c9f1
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
2 years agoStore EIR Manufacturer specific data into the device information 23/270223/1 accepted/tizen/unified/20220206.211909 submit/tizen/20220127.054201
dh79pyun [Thu, 27 Jan 2022 00:44:26 +0000 (09:44 +0900)]
Store EIR Manufacturer specific data into the device information

Change-Id: Ia3d9d62db972f394d30b9db934bbceee6977098f
Signed-off-by: dh79pyun <dh79.pyun@samsung.com>
2 years agoDon't allow the invalid ADV handle 12/269312/1 accepted/tizen/unified/20220117.135002 submit/tizen/20220112.235928
dh79pyun [Wed, 12 Jan 2022 23:40:52 +0000 (08:40 +0900)]
Don't allow the invalid ADV handle

Change-Id: Ieca085a04733bcfdc69d028d9fde8205d21f1c67
Signed-off-by: dh79pyun <dh79.pyun@samsung.com>
2 years agoMerge "Fix Svace Issues" into tizen submit/tizen/20220110.224444
Pyun DoHyun [Tue, 11 Jan 2022 22:55:55 +0000 (22:55 +0000)]
Merge "Fix Svace Issues" into tizen

2 years agoFix Svace Issues 73/269073/3
Anuj Jain [Fri, 7 Jan 2022 07:38:41 +0000 (13:08 +0530)]
Fix Svace Issues

This patch fixes scave issues:
473071: DIVISION_BY_ZERO
473376: MEMORY_LEAK

Change-Id: I8818accf1d7ff5a5b8adbbd2311e82d292f9b568
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
2 years agoDisable the factory test mode in TV product 39/269039/1
dh79pyun [Fri, 7 Jan 2022 02:54:44 +0000 (11:54 +0900)]
Disable the factory test mode in TV product

Change-Id: I93dcce0afdf3425f7fd7763d5733426c852dc3b6
Signed-off-by: dh79pyun <dh79.pyun@samsung.com>
2 years agoReplace g_memdup to g_memdup2 84/267884/1 accepted/tizen/unified/20211222.230419 submit/tizen/20211212.233427
dh79pyun [Mon, 13 Dec 2021 02:25:50 +0000 (11:25 +0900)]
Replace g_memdup to g_memdup2

Change-Id: Ia7c3a7341073df0de79fb725435a3c47ccbca20c
Signed-off-by: dh79pyun <dh79.pyun@samsung.com>
2 years agoMerge "Add a function to find remote client info matched addr and inst id" into tizen
Pyun DoHyun [Tue, 7 Dec 2021 22:09:53 +0000 (22:09 +0000)]
Merge "Add a function to find remote client info matched addr and inst id" into tizen

2 years agoFix invalid unique name issue 74/267474/1 accepted/tizen/unified/20211207.133118 submit/tizen/20211206.062656
Wootak Jung [Mon, 6 Dec 2021 05:05:54 +0000 (14:05 +0900)]
Fix invalid unique name issue

I/BLUETOOTH_FRWK_SERVICE(  392): bt-service-main.c: __on_log_glib(85) >
g_variant_new_string: assertion 'g_utf8_validate (string, -1, NULL)' failed
E/CYNARA  (  392): Getting client credentials by calling dbus method
GetConnectionCredentials on Id <:1.19482`��U> failed with error
<GDBus.Error:org.freedesktop.DBus.Error.NameHasNoOwner: Could not get
credentials of name '[Invalid UTF-8]': no such name>

Change-Id: I296767876dc143449d8147e00cc3d302ce0378d8

2 years agoAdd a function to find remote client info matched addr and inst id 70/267470/1
Wootak Jung [Mon, 6 Dec 2021 04:26:36 +0000 (13:26 +0900)]
Add a function to find remote client info matched addr and inst id

Change-Id: Ifed5672d2302910a7d9521b2644535a475c432f8

2 years agoChange if statement order to set the visible mode 34/267234/1 accepted/tizen/unified/20211202.120751 submit/tizen/20211201.061349
dh79pyun [Tue, 30 Nov 2021 05:46:35 +0000 (14:46 +0900)]
Change if statement order to set the visible mode

The prioriy of the model name is higer than the
profile name.

Change-Id: Id28d03145f433da07d9b3b7ccc33848c5f6f92a5
Signed-off-by: dh79pyun <dh79.pyun@samsung.com>
2 years agoEnable the default connectable mode for the commom profile 76/267076/1 accepted/tizen/unified/20211126.111806 accepted/tizen/unified/20211130.125450 submit/tizen/20211124.060921 submit/tizen/20211129.075122
dh79pyun [Thu, 25 Nov 2021 04:29:08 +0000 (13:29 +0900)]
Enable the default connectable mode for the commom profile

Change-Id: Id7f4e80608d59e7df9dc0f6f3f6ee0ca71a5d017
Signed-off-by: dh79pyun <dh79.pyun@samsung.com>
2 years agoAdd the logic for checking privilege to container 45/266745/2
Wootak Jung [Thu, 18 Nov 2021 06:20:33 +0000 (15:20 +0900)]
Add the logic for checking privilege to container

Change-Id: Iffa438bd53b6ef0e5eee8165a5bb0f286f631898

2 years agoSet the connectable mode in IOT profile 22/266522/1 submit/tizen/20211114.231048
dh79pyun [Mon, 15 Nov 2021 02:11:24 +0000 (11:11 +0900)]
Set the connectable mode in IOT profile

Change-Id: I5fbdcf58781eeaef725fa46a625428762b740f9e
Signed-off-by: dh79pyun <dh79.pyun@samsung.com>
3 years agoCheck the privilege for register profile method 42/266342/1
dh79pyun [Wed, 10 Nov 2021 22:58:49 +0000 (07:58 +0900)]
Check the privilege for register profile method

Change-Id: I17e2b1977b22f1fa7bca19a84cc2d4d2269d4043
Signed-off-by: dh79pyun <dh79.pyun@samsung.com>
3 years agoAdd container request check logic 54/266254/2
Wootak Jung [Wed, 10 Nov 2021 01:21:28 +0000 (10:21 +0900)]
Add container request check logic

Change-Id: I8f7419f03e4937c9d41ece4a704b8f411ad04227

3 years agoIncrease the version 05/266105/2
dh79pyun [Mon, 8 Nov 2021 02:31:19 +0000 (11:31 +0900)]
Increase the version

Change-Id: I18d63c47d55e622fb7b8ace91e11e6b7e2798740
Signed-off-by: dh79pyun <dh79.pyun@samsung.com>
3 years agoRemove the trust logic in the Robot profile 04/266104/1
dh79pyun [Mon, 8 Nov 2021 02:26:39 +0000 (11:26 +0900)]
Remove the trust logic in the Robot profile

Change-Id: I77ca652fd7475c3e342c0a56e032e20f1af06c8f
Signed-off-by: dh79pyun <dh79.pyun@samsung.com>
3 years agoAdd container handling logic 10/266010/3 accepted/tizen/unified/20211108.181406 submit/tizen/20211104.234019
Wootak Jung [Thu, 4 Nov 2021 04:07:47 +0000 (13:07 +0900)]
Add container handling logic

bt-service is running in host only
All requests received from container will re-direct to host
Don't read vconf to check bt status

Change-Id: If2d42cde897c8f90f700aa5279232d8ab8f8a523

3 years agoDon't check the address for RESYNC svc change event 55/265855/1 accepted/tizen/unified/20211102.024812 submit/tizen/20211101.044616
dh79pyun [Sun, 31 Oct 2021 23:15:22 +0000 (08:15 +0900)]
Don't check the address for RESYNC svc change event

Change-Id: I9de5e4497c3a068a45f76796a92c2ea349d433ea
Signed-off-by: dh79pyun <dh79.pyun@samsung.com>
3 years agoHandle BT_GATT_CLIENT_SERVICE_RESYNC event 01/265801/1
dh79pyun [Fri, 29 Oct 2021 01:09:45 +0000 (10:09 +0900)]
Handle BT_GATT_CLIENT_SERVICE_RESYNC event

Change-Id: I1d7f1ee6196e15cbaf9cfdc8d67fd77c4b6c4559
Signed-off-by: dh79pyun <dh79.pyun@samsung.com>
3 years agoRemove unused code 21/265721/1
INSUN PYO [Wed, 27 Oct 2021 22:25:33 +0000 (07:25 +0900)]
Remove unused code

Change-Id: I6ab2e413f95bf4bcaf2d7e679c7c6142f36a5ec4

3 years agoAdd more conditions for the robot profile 49/265549/1 accepted/tizen/unified/20211028.122145 submit/tizen/20211028.013751
dh79pyun [Fri, 22 Oct 2021 00:53:44 +0000 (09:53 +0900)]
Add more conditions for the robot profile

Change-Id: I9dcb05d93c711231b2e46d45eb8018bcabb48ea9
Signed-off-by: dh79pyun <dh79.pyun@samsung.com>
3 years agoFix coverity issue 96/262296/1 accepted/tizen/6.5/unified/20211028.095929 accepted/tizen/unified/20210823.124243 submit/tizen/20210806.053226 submit/tizen/20210820.043301 submit/tizen_6.5/20211028.162201 tizen_6.5.m2_release
Wootak Jung [Fri, 6 Aug 2021 05:21:40 +0000 (14:21 +0900)]
Fix coverity issue

param should be initialized

Change-Id: I5da0ab3ad7f6a74322038b97357e7141f2983ac3
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
3 years agoGATT: Parse client address in StartNotify and StopNotify DBUS APIs 68/262168/1 accepted/tizen/unified/20210805.131629 submit/tizen/20210804.223925
Anuj Jain [Tue, 3 Aug 2021 08:44:07 +0000 (14:14 +0530)]
GATT: Parse client address in StartNotify and StopNotify DBUS APIs

This patch enables client address to be reported in
Notification Enable/Diable callback in Tizen CAPI.

In GATT server role, client address is parsed from incoming dbus
message and is passed up the stack.

This patchset should be merged with the following capi and bluez's
patchset in order to match API and avoid crash:
bluez Change-Id: I81a0994f2299e988f8ef6428537647c899700fda
capi Change-Id: Ic4868234a4fc682f9bff2c66ac1aee2683f3d6c6

Change-Id: Ib54ba54c318692b4ee0eaef9b2310c60dadeb661
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
3 years agoFix gatt service uuid duplicated registration issue 68/261868/2 accepted/tizen/unified/20210803.123909 submit/tizen/20210801.230254
Wootak Jung [Wed, 28 Jul 2021 04:23:53 +0000 (13:23 +0900)]
Fix gatt service uuid duplicated registration issue

Change-Id: I33aa85aa436badf16d82226fcd69d7e65f85ce9d
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
3 years agoGATT: Clear dbus pending invocation list when gatt disconnection occurs. 14/260114/2
Anuj Jain [Sun, 20 Jun 2021 04:08:32 +0000 (09:38 +0530)]
GATT: Clear dbus pending invocation list when gatt disconnection occurs.

In GATT client role, When an application makes a dbus sync request
to BT-Service and is waiting for its reply,
Meanwhile BT-Service encounters GATT disconnection, because of which
it could not send the corresponding replies to application as the
connection info is already removed and thus causing dbus timeout error.

This patch will prevent such situation by sending BLUTOOTH_INTERNAL_ERROR
reply corresponding to all those pending dbus invocations when GATT
disconnection occurs.

Change-Id: Ib1cc93427a0d7156885381174e81616010cf9267
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
3 years agoRevert "GATT: Clear dbus pending invocation list when gatt disconnection occurs."
Ayush Garg [Sun, 20 Jun 2021 04:48:55 +0000 (10:18 +0530)]
Revert "GATT: Clear dbus pending invocation list when gatt disconnection occurs."

This reverts commit 702713c02a0256416f1a3f2a1aa49eff30408316.

3 years agoGATT: Clear dbus pending invocation list when gatt disconnection occurs.
Anuj Jain [Sun, 20 Jun 2021 04:08:32 +0000 (09:38 +0530)]
GATT: Clear dbus pending invocation list when gatt disconnection occurs.

In GATT client role, When an application makes a dbus sync request
to BT-Service and is waiting for its reply,
Meanwhile BT-Service encounters GATT disconnection, because of which
it could not send the corresponding replies to application as the
connection info is already removed and thus causing dbus timeout error.

This patch will prevent such situation by sending BLUTOOTH_INTERNAL_ERROR
reply corresponding to all those pending dbus invocations when GATT
disconnection occurs.

Change-Id: Ib1cc93427a0d7156885381174e81616010cf9267
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
3 years agoFix the coverity issue (Memory leak) 61/259561/1 accepted/tizen/unified/20210616.132535 submit/tizen/20210610.054148 submit/tizen/20210615.073416
DoHyun Pyun [Wed, 9 Jun 2021 23:25:05 +0000 (08:25 +0900)]
Fix the coverity issue (Memory leak)

Change-Id: I5d8c9e91f73e005606f274d071983d36b49c5b14
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
3 years agoAdd auto accept and set trusted logic for robot 80/259180/1 accepted/tizen/unified/20210607.124412 submit/tizen/20210606.232858
Wootak Jung [Wed, 2 Jun 2021 02:01:30 +0000 (11:01 +0900)]
Add auto accept and set trusted logic for robot

Change-Id: If99c752a1163c611eb461503093f5b6f4723c5fe

3 years agoAdd robot socket channel 77/259177/3
Wootak Jung [Tue, 1 Jun 2021 00:15:30 +0000 (09:15 +0900)]
Add robot socket channel

Change-Id: Iab39beae121598e659f5e646d306ac7577600269
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
3 years agoAllow zero length for GATT server write request 03/259003/1
DoHyun Pyun [Mon, 31 May 2021 01:22:11 +0000 (10:22 +0900)]
Allow zero length for GATT server write request

Google's Chromecast app needs to response for zero
length write request in GATT server.

Change-Id: Ie925246c23078c070898f84a5fd8db908d2c854b
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
3 years agoFix coverty issues 64/258764/1
anuj.bhumiya [Tue, 25 May 2021 08:58:41 +0000 (14:28 +0530)]
Fix coverty issues

Change-Id: I06b246df43582a066d071b899558b9a39b9be57d
Signed-off-by: anuj.bhumiya <anuj.bhumiya@samsung.com>
3 years agoFix the crash issue in FHub product 56/258256/1
DoHyun Pyun [Thu, 13 May 2021 02:40:01 +0000 (11:40 +0900)]
Fix the crash issue in FHub product

0xb60d394a in print_bt_properties (num_properties=1, properties=0xbe2d1160) at /usr/src/debug/bluetooth-frwk-0.6.0/bt-oal/common/oal-utils.c:205
        i = <optimized out>
        __func__ = "print_bt_properties"
Backtrace stopped: Cannot access memory at address 0x2d6c6166

Change-Id: I3dcbafb6ffd1b10a6db41f03df8658653e1d0b27
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
3 years agoMerge "Mesh: added message response on Node Role" into tizen accepted/tizen/unified/20210427.085752 submit/tizen/20210426.061315
Pyun DoHyun [Mon, 26 Apr 2021 05:53:36 +0000 (05:53 +0000)]
Merge "Mesh: added message response on Node Role" into tizen

3 years agoMesh: added message response on Node Role 26/257126/4
anuj.bhumiya [Mon, 19 Apr 2021 10:00:19 +0000 (15:30 +0530)]
Mesh: added message response on Node Role

This patch implements the message response from node
side to Provisioner node when it receive any message
from provisioner.

Change-Id: Ic70c7589f9328dd80ebcf5de7a76937c9c640e6c
Signed-off-by: anuj.bhumiya <anuj.bhumiya@samsung.com>
3 years agoRemove unnecessary dependency 67/256867/1 accepted/tizen/unified/20210420.002128 submit/tizen/20210419.025911
Wootak Jung [Wed, 14 Apr 2021 04:31:51 +0000 (13:31 +0900)]
Remove unnecessary dependency

Change-Id: Iba251c1e6ce130c9269b0794aaf698ec9ad517eb
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
3 years agoCorrect the privilege check for BT_UPDATE_LE_CONNECTION_MODE 73/256773/2
DoHyun Pyun [Mon, 12 Apr 2021 23:17:51 +0000 (08:17 +0900)]
Correct the privilege check for BT_UPDATE_LE_CONNECTION_MODE

Change-Id: I974080862a48defc67752e3b3a0f5d23200182db
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>