Yeongjong Lee [Thu, 23 Jan 2020 04:42:45 +0000 (13:42 +0900)]
eolian_mono: replace event name to prevent name conflict
Efl.Loop.Quit => Efl.Loop.LoopQuit
Efl.Loop.Idle => Efl.Loop.Idling
@tizen_fix
Change-Id: I8f44dfc335c57c0b48569a22dd6349a3ab9e6303
Jaehyun Cho [Wed, 22 Jan 2020 11:27:46 +0000 (20:27 +0900)]
eolian_mono: add blacklist events which have same names with properties
Some events have the same name with properties.
Since event and property names should not be same in a C# class, those
events are added to blacklist.
Since the events "normal" and "minimized" in Efl.Ui.Win are going to be
replaced with "minimized,changed", the event "normal" is added to
blacklist as well.
@tizen_only
Change-Id: Icf78727ae02697142c3e9a5a61d5919579c8e66a
Yeongjong Lee [Wed, 22 Jan 2020 11:49:53 +0000 (20:49 +0900)]
efl_ui_win: add minimized,changed event to avoid name conflict in bindings
There is name conflict between `minimized` method and `minimized` event in bindings.
To solve this problem, `minimized,changed` event will be used instead of `minimized`.
@tizen_fix
Change-Id: I8157f755a9b0070fc4860b7de25e0e44b6347d7d
Jongmin Lee [Wed, 22 Jan 2020 21:26:56 +0000 (06:26 +0900)]
build: resolve migration build error
Change-Id: I0d630cb27c7c5df2f09c1e175feaab9cc55d237c
JunsuChoi [Wed, 22 Jan 2020 16:57:26 +0000 (11:57 -0500)]
efl_ui_image: Call unload file when calling file_set
Summary:
We have checked that unload is not called even if different files
call again elm_image_file_set on the same object.
If file_set is called repeatedly, I think a potential error can occur.
So, modify to call unload when doing file_set by referring to efl_ui_zoomable.
Test Plan: N/A
Reviewers: Hermet, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11148
Marcel Hollerbach [Fri, 17 Jan 2020 13:40:58 +0000 (14:40 +0100)]
evas_object_box: fix invalidator
the iteration over the content of the box did never cleanup the
children pointer, which resulted in buggy behavior.
This fixes test suite crashes with freeq debugging on.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11123
Christopher Michael [Wed, 22 Jan 2020 13:37:33 +0000 (08:37 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_input_keyboard_repeat functions
ref T8016
Woochanlee [Wed, 22 Jan 2020 12:41:39 +0000 (07:41 -0500)]
tests/ecore_wl2: Add tests for move, resize, resizing_get functions.
Summary:
Add
ecore_wl2_window_move
ecore_wl2_window_resize
ecore_wl2_window_resizing_get
ref T8016
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8016
Differential Revision: https://phab.enlightenment.org/D11150
Woochanlee [Wed, 22 Jan 2020 12:37:23 +0000 (07:37 -0500)]
ecore_wl2: Add ecore_wl2_input_default_input_get() API.
Summary: Gets default input which created by display.
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11132
Woochanlee [Wed, 22 Jan 2020 12:37:11 +0000 (07:37 -0500)]
ecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API.
Summary:
Add API to set input's keyboard repeat.
get API was already there.
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11131
Jaehyun Cho [Wed, 22 Jan 2020 02:33:41 +0000 (11:33 +0900)]
Revert "efl_mono: remove class ExtensionTag"
Extension Methods' classes have methods with same names and parameters.
e.g. Text<T>(this Efl.Ui.ItemFactory<T> fac)
Although the where clause contains different classes, they cannot be
identified as different methods by C# compiler.
e.g. Text<T>(this Efl.Ui.ItemFactory<T> fac) where T : Efl.Ui.Button
e.g. Text<T>(this Efl.Ui.ItemFactory<T> fac) where T : Efl.Ui.Check
As a result, to avoid ambiguous methods, ExtensionTag should be used as
a second parameter of each method.
e.g. Text<T>(this Efl.Ui.ItemFactory<T> fac, ExtensionTag<Efl.Ui.Button, T>magic = null) where T : Efl.Ui.Button
e.g. Text<T>(this Efl.Ui.ItemFactory<T> fac, ExtensionTag<Efl.Ui.Check, T>magic = null) where T : Efl.Ui.Check
This reverts commit
76631f502a8234c04ed8124bfdebe62ed5bdf954.
Yeongjong Lee [Wed, 22 Jan 2020 00:40:18 +0000 (09:40 +0900)]
eolian_mono: avoid generating set-only property
Summary:
According to Property Design Guidelines of MS, set-only properties are not recommeneded.
(see more, https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/property)
Furthermore, there is stylecop warnings(CA1044)
ref T8396
List of removed set-only properies.
```
Efl.Access.Editable.IText.TextContent { set; }
Efl.App.CommandArray { set; }
Efl.App.CommandString { set; }
Efl.Canvas.Filter.IInternal.FilterChanged { set; }
Efl.Canvas.Filter.IInternal.FilterInvalid { set; }
Efl.Canvas.ImageInternal.FilterChanged { set; }
Efl.Canvas.ImageInternal.FilterInvalid { set; }
Efl.Canvas.Textblock.FilterChanged { set; }
Efl.Canvas.Textblock.FilterInvalid { set; }
Efl.Canvas.Vg.Image.Data { set; }
Efl.Canvas.Vg.Node.CompMethod { set; }
Efl.Core.ICommandLine.CommandArray { set; }
Efl.Core.ICommandLine.CommandString { set; }
Efl.Exe.CommandArray { set; }
Efl.Exe.CommandString { set; }
Efl.Ui.AlertPopup.Button { set; }
Efl.Ui.Collection.MatchContent { set; }
Efl.Ui.CollectionView.MatchContent { set; }
Efl.Ui.IScrollable.MatchContent { set; }
Efl.Ui.ImageZoomable.MatchContent { set; }
Efl.Ui.Panel.MatchContent { set; }
Efl.Ui.PositionManager.Grid.DataAccess { set; }
Efl.Ui.PositionManager.Grid.ScrollPosition { set; }
Efl.Ui.PositionManager.Grid.Viewport { set; }
Efl.Ui.PositionManager.IDataAccessV1.DataAccess { set; }
Efl.Ui.PositionManager.IEntity.ScrollPosition { set; }
Efl.Ui.PositionManager.IEntity.Viewport { set; }
Efl.Ui.PositionManager.List.DataAccess { set; }
Efl.Ui.PositionManager.List.ScrollPosition { set; }
Efl.Ui.PositionManager.List.Viewport { set; }
Efl.Ui.Scroll.Manager.MatchContent { set; }
Efl.Ui.Scroll.Manager.Pan { set; }
Efl.Ui.Scroller.MatchContent { set; }
Efl.Ui.Spotlight.Manager.Size { set; }
Efl.Ui.Textbox.TextContent { set; }
Efl.Ui.Widget.ResizeObject { set; }
Efl.Ui.Win.PropFocusSkip { set; }
```
Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: woohyun, felipealmeida, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8396
Differential Revision: https://phab.enlightenment.org/D11138
Yeongjong Lee [Mon, 20 Jan 2020 22:00:44 +0000 (07:00 +0900)]
Revert "csharp: Property Indexer implementation"
Summary:
This reverts commit
0954e501fd4008c40b3848de1f2c91bcd53b2f71.
According to Framework Design Guidelines of MS, most of indexed properties are
not recommended in EFL#.
(see, https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/property)
It is better to leave properties which have a key as methods.
Reviewers: woohyun, felipealmeida
Reviewed By: woohyun
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11114
Change-Id: I972878e39ea30c56ce82b0d60a7f82ec4b06b76c
Chris Michael [Tue, 21 Jan 2020 18:04:06 +0000 (13:04 -0500)]
tests/ecore_wl2: Fix issue of tests running without a Wayland display
This fixes an issue with CI where these tests would try to run without
a Wayland compositor. This was missed during review, Thanks Marcel for
pointing this out.
ref T8016
Marcel Hollerbach [Tue, 21 Jan 2020 16:11:31 +0000 (17:11 +0100)]
Revert "efl_text_interactive: selection enhancment"
This reverts commit
09f0d66d90e4db5f879f4c998e8a07b26fa749fc.
This breaks CI, and tests do not pass anymore, hence no other revision
can be verified.
The revision is reopened. lets take a second look at this.
Woochanlee [Tue, 21 Jan 2020 13:13:52 +0000 (08:13 -0500)]
tests/ecore_wl2: Code clean up and Add, Modify TCs.
Summary:
Code clean up.
Add flush, sync_is_done APIs.
Modify input_find.
ref T8016
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8016
Differential Revision: https://phab.enlightenment.org/D11111
Marcel Hollerbach [Mon, 20 Jan 2020 12:22:59 +0000 (13:22 +0100)]
efl_ui_spotlight/pager/stack: remove @beta
there has been more than 1 month without any comment, i think this looks
fine now ?
The transition event is kept beta for now, as we have right now a
discussion about range that we might be able to use here.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Reviewed-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11135
Jaehyun Cho [Tue, 21 Jan 2020 10:32:34 +0000 (19:32 +0900)]
efl_ui_spotlight_manager: fix not to change sub objects' color
Summary:
Widget's group_member_add() sets its sub objects' color with the
parent's color.
Since spotlight managers call group_member_add() with spotlight
container and its sub objects, the sub objects' color can be changed.
e.g. packed rectangle's color is changed to white (default color value)
To resolve the above issue, spotlight managers set data "_elm_leaveme"
before calling group_member_add() not to change sub objects' color.
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11134
Shinwoo Kim [Tue, 21 Jan 2020 10:28:59 +0000 (19:28 +0900)]
Efl.Canvas.Group: implement Efl.Gfx.Filter
Summary: This patch makes Efl.Canvas.Group work for Efl.Gfx.Filter
Reviewers: Hermet, jsuya, zmike
Reviewed By: Hermet
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10435
Xavi Artigas [Tue, 21 Jan 2020 09:59:12 +0000 (10:59 +0100)]
docs: Typos in Doxygen docs
Ali Alzyod [Mon, 20 Jan 2020 22:39:14 +0000 (07:39 +0900)]
efl_text_interactive: selection enhancment
Summary:
1- Implement setting selection range programmatically by modifying selection cursors from **efl_text_interactive_selection_cursors_get**
2- Add setter with **efl_text_interactive_selection_cursors_set** to set the range at once (modify start and end)
Reviewers: woohyun, segfaultxavi, zmike, bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8521, T8522
Differential Revision: https://phab.enlightenment.org/D10968
Shinwoo Kim [Thu, 7 Nov 2019 05:58:44 +0000 (14:58 +0900)]
evas proxy: use part of source
This makes a proxy object use a selective region of a source object.
This is useful when the source is too big to allocate a proxy surface.
This will be used by elm_scroller to solve following issue.
[Issue]
If size of elm_sclloer content is too big, then the proxy of
elm_scroller to show loop effect does not work. Because
evas_gl_common_image_surface_new does not allow
bigger size surface than max_texture_size
This is a Tizen only patch to fix product issue quickly.
Related patch (https://phab.enlightenment.org/D10604) is under the review.
*tizen_only
Change-Id: I57c58efdf067be4100c6963c8d9894f8bfa04de1
Prasoon Singh [Fri, 13 Dec 2019 07:10:57 +0000 (12:40 +0530)]
access: Add support for unfocusable window
For unfocusable window need a distinction to add window on show signal.
As, for unfocusable window activate signal does not come in screen-reader.
Change-Id: I27647ce9057fb84b90454f4231225d157c082034
Signed-off-by: Prasoon Singh <prasoon.16@samsung.com>
Marcel Hollerbach [Mon, 20 Jan 2020 16:51:40 +0000 (17:51 +0100)]
Revert "ecore_wl2: Fix a memory leaking case"
This reverts commit
97e71b9dc4fa73da99a890d9c39d6617e529dc94.
This commit is absolutly wrong. This makes running wayland apps intree
impossible, and also crashes tests when run in wayland mode.
I asked multiple times in the revision for clarification, noone
answered.
This tricked me today for the second time, so better revert that.
Ali Alzyod [Mon, 20 Jan 2020 12:25:43 +0000 (21:25 +0900)]
efl.input.text.hints_type: rename into content_type
Reviewers: woohyun, segfaultxavi
Reviewed By: woohyun, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8541
Differential Revision: https://phab.enlightenment.org/D11130
Ali Alzyod [Mon, 20 Jan 2020 07:55:31 +0000 (16:55 +0900)]
efl.ui.textbox: using efl_provider_find
Summary: > Code structures like top = elm_widget_top_get(data); and if (efl_isa(top, EFL_UI_WIN_CLASS)) can be replaced with top = efl_provider_find(widget, EFL_UI_WIN_CLASS) No type check needed. (That should enhance the performance)
Reviewers: woohyun, bu5hm4n, cedric
Reviewed By: bu5hm4n, cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8522
Differential Revision: https://phab.enlightenment.org/D11127
Jaehyun Cho [Mon, 20 Jan 2020 03:53:09 +0000 (12:53 +0900)]
efl_canvas_animation: rename Animation_XXX to XXX_Animation
Summary:
In animation classes, "Animation" is not used as a namespace but it is
used as a prefix in the class names.
e.g. Efl.Canvas.Animation_Alpha
However, those classes are basically animation classes with different
features. Therefore, "Animation" should be used as a postfix in the
class names.
e.g. Efl.Canvas.Animation_Alpha -> Efl.Canvas.Alpha_Animation
However, for the easier usage of C APIs, c_prefix of animation classes
are remained to be "efl_animation_xxx".
Reviewers: segfaultxavi, bu5hm4n, zmike, Hermet, jsuya
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11108
ali [Mon, 20 Jan 2020 01:07:40 +0000 (10:07 +0900)]
efl.text.cursor: movement types rename
Summary: replace prev with previous, replace char with character
Reviewers: woohyun, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8567
Differential Revision: https://phab.enlightenment.org/D11095
SangHyeon Jade Lee [Fri, 17 Jan 2020 11:46:40 +0000 (20:46 +0900)]
genlist : add edje message signal process in cache push.
this code is missing after tizen 4.0 applied
Change-Id: Ia0e8879f9cad1feaa992e91e56063bd30516ca3d
Prince Kumar Dubey [Mon, 23 Dec 2019 09:21:52 +0000 (14:51 +0530)]
[Elm_Panel][More_Option] Performance Enhancement and Bug fixes.
Change-Id: I807ca64ef0d7714ffe3d5c486a21151362d160fb
Signed-off-by: Prince Kumar Dubey <prince.dubey@samsung.com>
Prince Kumar Dubey [Fri, 13 Dec 2019 12:42:53 +0000 (18:12 +0530)]
[OneUI 1.5] Popup VI effect support added.
Repo efl-modules have dependency on this patch.
Change-Id: I4af358688aae65d4759dff781c7899f72fc71e33
Signed-off-by: Prince Kumar Dubey <prince.dubey@samsung.com>
Prince Kumar Dubey [Thu, 19 Dec 2019 08:09:09 +0000 (13:39 +0530)]
[Widget] Support added to allow to set/get transition duration of vi-effect on widget.
Change-Id: I7e5864ea1404d64d26dfcc165be6462b3df663c1
Signed-off-by: Prince Kumar Dubey <prince.dubey@samsung.com>
Bowon Ryu [Fri, 17 Jan 2020 09:23:35 +0000 (18:23 +0900)]
[Progressbar] send pulse start signal even when pulse is not set
@tizen_fix
Change-Id: I7d4602cdf9f949f2183d1c1f43cfa8d815e85909
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
godlytalias14573465 [Tue, 31 Dec 2019 10:50:33 +0000 (16:20 +0530)]
[Genlist] Apply align item logic during item show
Change-Id: Idf7f7562fbcd22d6b2aa77b13be3d48047d99d7e
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
godlytalias14573465 [Tue, 31 Dec 2019 12:53:43 +0000 (18:23 +0530)]
[Genlist] Fix for genlist item position change on free
Change-Id: Ia672825c5f06158b0263d5a1d8d29aaf2d220be0
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
godlytalias14573465 [Tue, 31 Dec 2019 12:45:33 +0000 (18:15 +0530)]
[CtxPopup] Show / Hide VI effect
Change-Id: I32f3e7a6abfc82dcbc4ca0bb8111ac7ee490da40
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
godlytalias14573465 [Mon, 16 Dec 2019 12:20:50 +0000 (17:50 +0530)]
[OneUI1.5] Genlist Item Add / Del FX
Change-Id: I292f8eb6a8969aa8215ea406627fdcc227ff041d
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
Carsten Haitzler (Rasterman) [Sun, 19 Jan 2020 10:52:34 +0000 (10:52 +0000)]
elm win - fix client side move/resize req handling csd in x
we dont keep our window id up to date... it changes somewhere along
the way during init.... (ecore evas does this e.g. go from normal to
alpha window it has tocreate a new window id anyway)... so stay up to
date so we send a req for the right window id...
@fix
Carsten Haitzler (Rasterman) [Sun, 19 Jan 2020 10:51:29 +0000 (10:51 +0000)]
elm test - make window 480x490 to differentiate width vs height
Carsten Haitzler (Rasterman) [Sat, 18 Jan 2020 12:25:08 +0000 (12:25 +0000)]
evas - fix access-after-free number 2
follow on from
3aa250e17ff34a1b0466b65fe55ffe1fced291ff and T8534
looking into more possible problems and fixes
@fix
Carsten Haitzler (Rasterman) [Fri, 17 Jan 2020 22:23:25 +0000 (22:23 +0000)]
ecore_con - freebsd bind blocking workaround
this is to try do a workaround a hard to reproduce blocking bind on
some freebsd systems (i can't repro it on my fbsd vm), so try use file
locks as an extra barrier and hope they do the right thing without
other mysterious problems.
@fix
Carsten Haitzler (Rasterman) [Fri, 17 Jan 2020 13:09:29 +0000 (13:09 +0000)]
elm - fix filesel deferred unref to not crash
@fix
Carsten Haitzler (Rasterman) [Fri, 17 Jan 2020 12:14:11 +0000 (12:14 +0000)]
evas - fix access-after-free where during destroy hash item not cleared
leave it in the hash unfreed as it will be freed when the hash is soon
after durint destruction.
@fix
Hosang Kim [Fri, 10 Jan 2020 09:26:32 +0000 (09:26 +0000)]
efl_ui_scrollbar: change scrollbar state when theme is reloaded.
Scrollbar visible state is not synchronized when theme is reloaded.
Differential Revision: https://phab.enlightenment.org/D10649
Marcel Hollerbach [Fri, 17 Jan 2020 15:06:52 +0000 (16:06 +0100)]
Introduce Separator
Summary:
this is just like elm_separator, just written for unified widgets.
This inherits from item, which has the advantage that this separator can
also be added into item container.
Reviewers: zmike, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11125
Felipe Magno de Almeida [Fri, 17 Jan 2020 14:51:24 +0000 (09:51 -0500)]
C++: Fix use of @c_type tag in struct definition
Summary: Depends on D11090
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11099
Marcel Hollerbach [Fri, 17 Jan 2020 14:49:13 +0000 (09:49 -0500)]
efl_ui_suite: fix test code of grid
Summary:
this test code seemed buggy, we used the iterator *after* the content
was changed. Additionally, we freed the iterator with free instead of
eina_iterator_free.
This fixes test test suite.
Depends on D11123
Reviewers: raster, zmike, cedric, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11124
ali [Fri, 17 Jan 2020 08:20:14 +0000 (08:20 +0000)]
efl: correct class description name of simple class
Name of Efl_Class_Description should be eo-style class name.
related to D11115
Reviewed-by: YeongJong Lee <cleanlyj@naver.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11117
Xavi Artigas [Fri, 17 Jan 2020 11:56:51 +0000 (12:56 +0100)]
docs: Typo in Efl.Text_Cursor
Yeongjong Lee [Fri, 17 Jan 2020 06:06:18 +0000 (15:06 +0900)]
efl_text_cursor: correct class description name of simple class
Summary:
Name of `Efl_Class_Description` should be eo-style class name.
Please check there is no segmentation fault on Test code below.
Thanks to @woohyun for reporting and test case.
Test Plan:
```
//mcs test.cs -out:test.exe `pkg-config --libs efl-mono`
using System;
class Program
{
public static void Main() {
Efl.All.Init(Efl.Csharp.Components.Ui);
Efl.Ui.Win win = new Efl.Ui.Win(null);
Efl.Ui.Box box = new Efl.Ui.Box(win);
Efl.Ui.Textbox tb = new Efl.Ui.Textbox(win);
Efl.Ui.Button btn = new Efl.Ui.Button(box);
btn.Text = "Click Me!";
btn.ClickedEvent += (s, e) =>
{
Efl.Text.Cursor cur1, cur2;
tb.GetSelectionCursors(out cur1, out cur2);
cur1.SetPosition(3);
cur2.SetPosition(7);
};
box.Pack(btn);
box.Pack(tb);
win.SetContent(box);
win.SetSize(new Eina.Size2D(200, 400));
Efl.Ui.Config.Run();
Efl.All.Shutdown();
}
}
```
Reviewers: woohyun, ali.alzyod, bu5hm4n
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers, woohyun
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11115
Xavi Artigas [Thu, 16 Jan 2020 15:05:43 +0000 (15:05 +0000)]
docs: Give some love to progress bar docs.
Differential Revision: https://phab.enlightenment.org/D11112
Ali Alzyod [Thu, 16 Jan 2020 10:19:08 +0000 (10:19 +0000)]
efl.ui.textbox: update _part_is_efl_ui_textbox_part
efl.ui.textbox: update _part_is_efl_ui_textbox_part
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11109
Ali Alzyod [Thu, 16 Jan 2020 11:55:59 +0000 (11:55 +0000)]
efl.ui.textbox: theme code cleanup
>You should not theme in _efl_ui_textbox_efl_object_finalize, but rather in theme_apply
>All part swallow things should be done in theme_apply.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11103
JunsuChoi [Thu, 16 Jan 2020 11:11:49 +0000 (20:11 +0900)]
Efl.Ui.Vg_Animation: Change property name autorepeat to looping
Summary:
autoplay and autorepeat look similar and can be confusing.
so change autorepeat to looping.
ref T8476
Depends on D11022
Test Plan: N/A
Reviewers: Hermet, bu5hm4n, kimcinoo, segfaultxavi, zmike
Reviewed By: Hermet, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8476
Differential Revision: https://phab.enlightenment.org/D11061
a.srour [Thu, 16 Jan 2020 08:53:36 +0000 (17:53 +0900)]
Efl.Ui.Textbox: Fix Ctrl+Backspace & Ctrl+Delete keys
Summary:
This should fix the behaviour of Ctrl+Backspace & Ctrl+Delete key down on `Efl.Ui.Textbox`.
Also added two tests for it.
Reviewers: woohyun, ali.alzyod, cedric, bu5hm4n
Reviewed By: woohyun
Subscribers: ProhtMeyhet, stefan_schmidt, segfaultxavi, bu5hm4n, #committers, #reviewers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11040
JunsuChoi [Thu, 16 Jan 2020 02:12:37 +0000 (02:12 +0000)]
tests: Add test cases for Efl.Ui.Vg_Animation
Add test cases for Efl.Ui.Vg_Animation APIs
- vg_anim_playing_control
- vg_anim_frame_control
ref T8476
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11022
WooHyun Jung [Thu, 16 Jan 2020 07:47:23 +0000 (07:47 +0000)]
efl_ui_textbox: rename efl_ui_text_part to efl_ui_textbox_part
ref T8522
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11107
Marcel Hollerbach [Mon, 13 Jan 2020 14:04:07 +0000 (15:04 +0100)]
theme: remove not yet used groups
these groups are not used yet. So remove the groups for now.
ref T8501
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11077
Marcel Hollerbach [Mon, 13 Jan 2020 14:00:56 +0000 (15:00 +0100)]
efl_ui_progressbar: fix theming of progressbar
There was code in progressbar that parsed its own theme name, applied a
change, reassembed it, and set it again. However, when we simply stick
to the theme apply code path that we have in efl.ui.layout_base, we can
simply set the horizontal / vertical part to be the element, the rest is
the class. This safes a lot of code, additionally, the setting of the
spacer had to be moved to the theme_apply method, as this would not work
otherwise.
ref T8501
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11076
Marcel Hollerbach [Mon, 13 Jan 2020 13:49:31 +0000 (14:49 +0100)]
efl_ui_progressbar: do not allow parts on unified widgets
this only allows the default part to be gotten when running the unified
widget. A later widget can then be used to expose the second progressbar
part.
ref T8501
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11075
Ali Alzyod [Thu, 16 Jan 2020 00:12:01 +0000 (09:12 +0900)]
efl.ui.textbox: part implementation comments clean up!
Summary:
We did not use the **ELM_PART_OVERRIDE_** because it produces compilation error
```
../src/lib/elementary/efl_ui_textbox.c:3603:40: error: ‘EFL_UI_TEXTBOX_PART_CLASS’ undeclared (first use in this function)
ELM_PART_OVERRIDE_PARTIAL(efl_ui_text, EFL_UI_TEXTBOX, Efl_Ui_Textbox_Data, _part_is_efl_ui_text_part)
```
Reviewers: woohyun, bu5hm4n
Reviewed By: woohyun
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8522
Differential Revision: https://phab.enlightenment.org/D11102
Hermet Park [Fri, 17 Jan 2020 01:48:24 +0000 (10:48 +0900)]
canvas vector: fix to refresh svg file of vector object.
previously, svg file is not refreshed though the file is changed.
Let changed flag true properly to re-render properly.
@fix
Change-Id: I637fd5ecabb607dbaca6a28da0d46c6738cd22ea
Jihoon Kim [Thu, 16 Jan 2020 04:46:03 +0000 (13:46 +0900)]
ecore_imf: Add since_tizen in deprecated autofill enums
Change-Id: I51ba88bf4c9db1fe34610b99aeddfeccd0400796
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jihoon Kim [Thu, 9 Jan 2020 09:46:16 +0000 (18:46 +0900)]
ecore_imf: Deprecated autofill enums in input hints
Change-Id: I9da57d10d0646377119cbb9f33851f6622901f97
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jongmin Lee [Thu, 16 Jan 2020 04:02:30 +0000 (13:02 +0900)]
Revert "ecore-wl2: Move ecore_wl2_window_aux hint functions to be internal"
This reverts commit
272dd08ceb11d407b2c8daeaa1185b94f4e3eeec.
Jongmin Lee [Thu, 16 Jan 2020 00:33:42 +0000 (09:33 +0900)]
build: resolve migration build error
Change-Id: Ic8b8f46d17f2654f6491bb54489a80690398dbbd
SangHyeon Jade Lee [Fri, 10 Jan 2020 10:39:14 +0000 (19:39 +0900)]
Genlist: fix item del animation by using del_intercept
Change-Id: Ia4dffb3c0ceb6099bc1cf80af5119a6721e7f143
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Carsten Haitzler (Rasterman) [Wed, 15 Jan 2020 19:23:44 +0000 (19:23 +0000)]
eina - fix eina_strndup test passing
Carsten Haitzler (Rasterman) [Wed, 15 Jan 2020 18:10:24 +0000 (18:10 +0000)]
eina - rmeove dup EINA_PRINTF
sorry for the noise...
Carsten Haitzler (Rasterman) [Wed, 15 Jan 2020 17:41:29 +0000 (18:41 +0100)]
eina - eina_strndup - use universal impl because strndup is an issue
freebsd/clang report strndup is not defined and string.h doesnt seem
to help if its included so move to the universal re-implementation
that was there for win32 anyway
Carsten Haitzler (Rasterman) [Wed, 15 Jan 2020 17:35:46 +0000 (18:35 +0100)]
eina - enable EINA_PRINTF for clang as well as gcc
Christopher Michael [Wed, 15 Jan 2020 16:05:22 +0000 (11:05 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_input_pointer_xy_get function
ref T8016
Christopher Michael [Wed, 15 Jan 2020 15:19:59 +0000 (10:19 -0500)]
tests/ecore_wl2: Remove test of ecore_wl2_window_hint_aux functions
These functions are now internal to EFL and do not require tests.
ref T8016
Christopher Michael [Wed, 15 Jan 2020 15:17:40 +0000 (10:17 -0500)]
ecore-wl2: Move ecore_wl2_window_aux hint functions to be internal
These functions are unused outside of EFL (not used in Enlightenment
or Tizen), so there is no need to expose them publicly.
ref T8013
Christopher Michael [Wed, 15 Jan 2020 14:39:21 +0000 (09:39 -0500)]
tests/ecore_wl2: Minor formatting fix
JunsuChoi [Wed, 15 Jan 2020 14:24:12 +0000 (09:24 -0500)]
elementary_test: Apply changed event related to Efl.Ui.Vg_Animation
Summary:
Events has changed from Efl.Ui.Vg_Animation to Efl.Player.
Apply the changes.
ref T8476
Depends on D11080
Test Plan: elementary_test -to "Vector Graphics Animation"
Reviewers: zmike, Hermet, kimcinoo
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, segfaultxavi, bu5hm4n
Tags: #efl
Maniphest Tasks: T8476
Differential Revision: https://phab.enlightenment.org/D11100
Mike Blumenkrantz [Wed, 15 Jan 2020 14:24:07 +0000 (09:24 -0500)]
efl/player: merge in and rework events from vg_animation
Summary:
this adds comprehensive events for the player interface which can be used
to provide details about the state of the playback
ref T8476
Depends on D11098
Reviewers: jsuya, bu5hm4n
Reviewed By: jsuya
Subscribers: jsuya, segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8476
Differential Revision: https://phab.enlightenment.org/D11080
Mike Blumenkrantz [Wed, 15 Jan 2020 14:23:59 +0000 (09:23 -0500)]
elm/animation: correctly implement legacy class
Summary: cmon.
Reviewers: bu5hm4n, jsuya
Reviewed By: jsuya
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11098
Jaehyun Cho [Wed, 15 Jan 2020 13:35:03 +0000 (14:35 +0100)]
evas_gesture: change getter methods to read-only properties
Summary:
From language bindings' perspective, it seems better that read-only
properties are provided instead of getter methods.
ref T8557
Reviewers: segfaultxavi, CHAN
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8557
Differential Revision: https://phab.enlightenment.org/D11094
WooHyun Jung [Wed, 15 Jan 2020 13:14:27 +0000 (14:14 +0100)]
efl_text_cursor: update doc for Efl.Text.Cursor_Type
Summary: ref T8566
Reviewers: segfaultxavi, ali.alzyod
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8566
Differential Revision: https://phab.enlightenment.org/D11105
Carsten Haitzler (Rasterman) [Wed, 15 Jan 2020 02:35:11 +0000 (02:35 +0000)]
ecore_exe/efl_exe - implement exit with parent on bsds with procctl
Felipe Magno de Almeida [Tue, 14 Jan 2020 14:02:05 +0000 (11:02 -0300)]
c#: Remove warning about unused variable
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11097
Jaehyun Cho [Wed, 15 Jan 2020 09:44:30 +0000 (09:44 +0000)]
efl_canvas_animation_group: preserve each animation's duration
To preserve each animation's duration, group animation's duration is
copied to each animation's duration only if group animation's duration
is set.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11104
Ali Alzyod [Mon, 13 Jan 2020 11:50:37 +0000 (11:50 +0000)]
efl.ui.textbox: paste in mouse button 2
efl.ui.textbox: paste in mouse button 2 work on primary instead of clipboard
Differential Revision: https://phab.enlightenment.org/D11068
Ali Alzyod [Tue, 14 Jan 2020 16:29:50 +0000 (16:29 +0000)]
efl.ui.textbox: replace hoversel with popup
efl.ui.textbox: replace hoversel with popup
**I think this may need some changes, please let me know what you think**
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11072
Jaehyun Cho [Wed, 15 Jan 2020 09:45:38 +0000 (18:45 +0900)]
efl_mono: remove class ExtensionTag
Summary:
Since class BindablePart and class BindableProperty use generic type
constraint as "where T : <class name>", class ExtensionTag is no longer
needed.
Reviewers: SanghyeonLee, felipealmeida, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11101
Ali Alzyod [Wed, 15 Jan 2020 00:19:14 +0000 (09:19 +0900)]
efl.ui.textbox: add efl.input text as composite interface
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8522
Differential Revision: https://phab.enlightenment.org/D11092
Shilpa Singh [Fri, 13 Dec 2019 11:05:21 +0000 (16:35 +0530)]
[OneUI 1.5][Genlist][Access]: Check for style and set state
If style is groupindex, set state of the item as expanded/collapsed
Change-Id: Iab712fe948b39c89b5f6c3c7149f801bd6308bb8
Signed-off-by: Nihar Raichada <n.raichada@samsung.com>
WooHyun Jung [Tue, 14 Jan 2020 09:22:52 +0000 (09:22 +0000)]
edje_entry: fix some preediting bugs
1. Attributes can come with random sequence.
So, attribute list should be sorted based on start_index.
2. None tag can be used for some languages' preediting.
So, the tag also needs to be handled the same with other tags.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11059
WooHyun Jung [Tue, 14 Jan 2020 08:47:17 +0000 (08:47 +0000)]
efl_ui_textbox: mark @beta to cnp_mode and item_factory
After stabilizing efl_ui_textblox, these properties should be
kept as @beta.
ref T8522
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11093
Woochanlee [Tue, 14 Jan 2020 13:24:22 +0000 (08:24 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_xxx functions
Summary:
Add below APIs.
ecore_wl2_window_commit
ecore_wl2_window_frame_callback_add, del
ecore_wl2_window_free
ecore_wl2_window_hide
ecore_wl2_window_shell_surface_exists
ecore_wl2_window_show
ecore_wl2_window_update_begin
+ Fix ecore_wl2_activated_get()
ref T8016
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8016
Differential Revision: https://phab.enlightenment.org/D11007
Yeongjong Lee [Tue, 14 Jan 2020 08:17:04 +0000 (17:17 +0900)]
eina_mono: replace eina_list and eina_array with IList
Summary:
Eina.List<T> => System.Collections.Generic.IList<T>
Eina.Array<T> => System.Collections.Generic.IList<T>
ref T8486
Depends On D10785
Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: felipealmeida, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8486, T8488
Differential Revision: https://phab.enlightenment.org/D10902
Ali Alzyod [Tue, 14 Jan 2020 01:42:06 +0000 (10:42 +0900)]
efl.input.text: add variation enums + remove @since word
Summary: efl.input.text: add variation enums + remove @since word
Reviewers: woohyun, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8541
Differential Revision: https://phab.enlightenment.org/D11066
Marcel Hollerbach [Mon, 13 Jan 2020 17:59:22 +0000 (18:59 +0100)]
Revert "efl_ui_spin_button: add tests for direct input feature"
This reverts commit
f62cee28cbb634731d7c39378dd29530d767b505.
This seems to cause trouble on the CI - lets recheck that.
Marcel Hollerbach [Mon, 13 Jan 2020 12:38:45 +0000 (13:38 +0100)]
eina_types: declare unicode type stable
this is needed in order to get text stable.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11074
Marcel Hollerbach [Fri, 3 Jan 2020 17:41:29 +0000 (18:41 +0100)]
efl_ui_spin_button: test that max can be reached by clicking inc
this is esp. testing if this is possible with step not beeing a multiple
of max.
Differential Revision: https://phab.enlightenment.org/D11011
Marcel Hollerbach [Fri, 3 Jan 2020 17:40:26 +0000 (18:40 +0100)]
efl_ui_spin_button: add tests for direct input feature
this simply passes in some key sequences and checks if the validation is
working. Additionally the output value is checked.
Differential Revision: https://phab.enlightenment.org/D11010
Marcel Hollerbach [Thu, 2 Jan 2020 16:46:46 +0000 (17:46 +0100)]
efl_ui_spin_button: add test for sequential inc
before there was a bug with this, as there was a int cast in the
internal dataflow. This ensures that this is working.
Differential Revision: https://phab.enlightenment.org/D11009
Marcel Hollerbach [Thu, 2 Jan 2020 15:45:05 +0000 (16:45 +0100)]
efl_ui_spin_button: test wraparround
this tests the wraparround feature.
Differential Revision: https://phab.enlightenment.org/D11008
Mike Blumenkrantz [Thu, 2 Jan 2020 19:05:41 +0000 (14:05 -0500)]
efl_ui/spin_button: fix step clamping
values for this needs to be rounded off the step in order to be expected
step-values and not just double garbage
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11006