platform/upstream/efl.git
5 years agoRevert "Temp: Remove Tizen Only Size Calculation Code in Elm_Label for Efl Sharp... 14/191314/2
Taehyub Kim [Tue, 16 Oct 2018 02:27:54 +0000 (11:27 +0900)]
Revert "Temp: Remove Tizen Only Size Calculation Code in Elm_Label for Efl Sharp Popup Demo"

This reverts commit 0ff0d06ab44d6c5fdc173cb06cda3590a08b051c.

Change-Id: I4d7370e8c99da3c729009c1a7af170fca9a3d92f

5 years agodevas vg: return default root node if possible. 45/191345/1
Hermet Park [Tue, 16 Oct 2018 06:07:36 +0000 (15:07 +0900)]
devas vg: return default root node if possible.

Summary:

It could return NULL root node
while user expect a valid root node in default
as It did before.

This is a regresion bug from long ago.

@fix

Reviewers: #committers

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7162

Change-Id: I20f116f64f3ddbb73754e22173193d3040726a46

5 years agoevas vector: fix typo. 24/191324/1
Hermet Park [Wed, 10 Oct 2018 05:19:18 +0000 (14:19 +0900)]
evas vector: fix typo.

Change-Id: I6f106ec042af4372b970c241415d874ac4d0328e

5 years agoevas: remove redundant internal functions. 23/191323/1
Hermet Park [Thu, 11 Oct 2018 04:46:36 +0000 (13:46 +0900)]
evas: remove redundant internal functions.

Summary:
Since efl object is introduced, magic check is no more used.
Plus, remove redundant object functions interfaces
 - type_id,
 - visual_id,
 - store
 - unstore

Reviewers: #committers, bu5hm4n

Reviewed By: #committers, bu5hm4n

Subscribers: bu5hm4n, raster, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7153

Change-Id: I42f15ae8209f7cf3b2670bb6c300bac267334eb2

5 years agoevas cache: clear up caching locking and reference count. 22/191322/1
Hermet Park [Thu, 11 Oct 2018 04:54:40 +0000 (13:54 +0900)]
evas cache: clear up caching locking and reference count.

Summary:
On reviewing, found out some logical problems in evas cache.

ref-drop pair doesn't make sense, proper locking for cache image neither.

Reviewers: raster, #reviewers

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7129

Change-Id: I9337cdb34fa06539a3f8e515a0b4652e10a75381

5 years agoevas image: fix preloading compatibility broken. 20/191320/2
Hermet Park [Fri, 12 Oct 2018 05:27:35 +0000 (14:27 +0900)]
evas image: fix preloading compatibility broken.

Well... Logically, we don't need to request preload again,
If image is loaded already. But somewhow it broke the enlightenment pager
and I need to revert the previous behavior here.

Whatever image is loaded or not, here image requests preload again,
unless it is already on preloading.

This was introduced by babacf41b7269a257065a41a2a4ec7763bada25f.

This fixes enlightenment pager bg non visible issue.

Change-Id: I7933f1463038afbbb0990f742baab5f972de17aa

5 years agoevas vg: fix memory leak. 18/191318/2
Hermet Park [Tue, 16 Oct 2018 03:24:01 +0000 (12:24 +0900)]
evas vg: fix memory leak.

Summary:
eina array must be flushed when object is deleted.

@fix

Reviewers: #committers, devilhorns

Reviewed By: #committers, devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7160

Change-Id: I16ac0bedcf8d947af4999713e8363060b9447c79

5 years agoevas vg: fix memory leak. 80/191280/1
Hermet Park [Mon, 15 Oct 2018 08:24:06 +0000 (17:24 +0900)]
evas vg: fix memory leak.

Here cached vg tree is not released properly.
Remove it before allocate another one.

Change-Id: Id823db19ae68cb77e02ce7a9ef50ed5c550b0ec5

5 years agoevas vg: don't overfull cache size. 21/191021/2
Hermet Park [Wed, 10 Oct 2018 12:18:01 +0000 (21:18 +0900)]
evas vg: don't overfull cache size.

Vg Animation requests a lot of frame surfaces.
On animatation, Previously cache key is not correct,
all vg frames would cached even repeated.

By storing cache key, we do hit cache properly
And let LRU Cache mechanism work over LRU_CACHE_LIMIT.

Change-Id: I066e33597c258109579bd9604c542c6941d2749c

5 years agoecore_wl2: fix build break 97/191197/2 accepted/tizen/unified/20181014.114328 submit/tizen/20181012.112410
Juyeon Lee [Fri, 12 Oct 2018 10:16:16 +0000 (19:16 +0900)]
ecore_wl2: fix build break

Change-Id: Ie83fa6abf34b189eb3ddd0391bf93720c4bfc974

5 years agoTemp: Remove Tizen Only Size Calculation Code in Elm_Label for Efl Sharp Popup Demo 57/189857/3
Taehyub Kim [Fri, 21 Sep 2018 07:49:10 +0000 (16:49 +0900)]
Temp: Remove Tizen Only Size Calculation Code in Elm_Label for Efl Sharp Popup Demo

Change-Id: I67d03decf20f8add4268c6b0af3ea39f580ed7ed

5 years agoecore_wl2_window: add null check condition 67/191167/3
Juyeon Lee [Fri, 12 Oct 2018 04:07:42 +0000 (13:07 +0900)]
ecore_wl2_window: add null check condition

Change-Id: Ied0e34f8382228fd2c3493b864cec834f666ee2e

5 years agoeocre_wl2_window: destroy zxdg_surface and xdg_surface after Null buffer commit 30/191130/1
Juyeon Lee [Thu, 11 Oct 2018 12:54:56 +0000 (21:54 +0900)]
eocre_wl2_window: destroy zxdg_surface and xdg_surface after Null buffer commit

@tizen_only

Change-Id: Idcb317bd6735e802cf3240482cebc0b61396b8cf

5 years agoevas filter: remove critical messages from Evas Filter 47/190447/7
Youngbok Shin [Tue, 2 Oct 2018 06:07:32 +0000 (15:07 +0900)]
evas filter: remove critical messages from Evas Filter

When you run filter examples with enabling GL engine support,
you can see critical messages which say don't use efl_unref for buffer object.
So, efl_unref has to be replaced with efl_del.
@tizen_fix

Change-Id: I487ec3591f9655d71263d7d6325c364da5719304

5 years agoefl_ui_win: Move force resize code on first draw 20/191120/1
JunsuChoi [Thu, 11 Oct 2018 11:30:25 +0000 (20:30 +0900)]
efl_ui_win: Move force resize code on first draw

Summary:
In D6165, there was a modification that forced resize_job
to be called using sd-> deferred_resize_job.
Even if we set true in sd-> deferred_resize_job,
it will be changed to false by calling other function to be called.
(sd->deferred_resize_job = EINA_TRUE; ->
  _elm_win_resize_objects_eval ->
  _elm_win_resize_job ->
   sd->deferred_resize_job = EINA_FALSE;)
Eventually _elm_win_frame_obj_update is not called.
There is a case where _elm_win_frame_obj_update can not called in tizen.
For this reason, make sure to call resize_job when first drawing based on D6165.

Test Plan: N/A

Reviewers: eagleeye, zmike, woohyun

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7156

Change-Id: Ib91d8c73d5dd0a106b77ce1fb5494b60a9fdb8e4

5 years agoefl_ui_progressbar: avoid meaningless theme_apply 16/191116/1
WooHyun Jung [Thu, 11 Oct 2018 10:42:57 +0000 (19:42 +0900)]
efl_ui_progressbar: avoid meaningless theme_apply

Change-Id: I0c94f69701e271f67b1126bd2ff8e9a072038cc1
Signed-off-by: WooHyun Jung <wh0705.jung@samsung.com>
5 years agoevas engine: add a missing change from EvasGL Render Thread patch 06/191106/2
Youngbok Shin [Thu, 11 Oct 2018 09:36:13 +0000 (18:36 +0900)]
evas engine: add a missing change from EvasGL Render Thread patch

It fixes an issue: Evas Filter with SW backend didn't work at all.

@tizen_fix

Change-Id: Ib3063f0b7dc082d35ac51ed4cfbfec0221cad796

5 years agoecore_wl2: fix build break 87/191087/1
Hosang Kim [Thu, 11 Oct 2018 07:49:18 +0000 (16:49 +0900)]
ecore_wl2: fix build break

 when i tested this commit i had wayland turned off. Sorry for the
 noise.

Change-Id: I25e3a3557c700a7b6d60803bb79d8bd0b290599c

5 years agoeocre_wl2_window: unset zxdg_surface and xdg_surface when hide 77/191077/1
Juyeon Lee [Thu, 11 Oct 2018 06:33:52 +0000 (15:33 +0900)]
eocre_wl2_window: unset zxdg_surface and xdg_surface when hide

if a client is hide and render while hide, using wl_surface_commit
than, display server would regard the wl_buffer attach and wl_surface commit
show request. and map a window on screen.
to prevent this behavior, destory xdg_surface while implicit hide request
as a result, display server would not map those windows(hide but rendering in bg)

@tizen_only

Change-Id: Icccf0f6010d960538137aef6cd29c1cab940d231

5 years agoecore_wl2: fix coverity issue. (Resource Leak) 08/191008/1
Hosang Kim [Wed, 10 Oct 2018 10:35:08 +0000 (19:35 +0900)]
ecore_wl2: fix coverity issue. (Resource Leak)

Summary: Module is not freed when eina_module_load is failed.

Reviewers: Hermet, marcelhollerbach, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: bu5hm4n, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7152

Change-Id: Ic03e20955d2b196dbcf8ac68603f08bd1a7d10bb

5 years agoefl_ui_tab_pager: modified test for regression test 98/190998/1
Bowon Ryu [Wed, 10 Oct 2018 09:05:18 +0000 (18:05 +0900)]
efl_ui_tab_pager: modified test for regression test

Summary: Fixed randomly generated tab items to be generated sequentially in test code.

Test Plan: elementary_test -to efl.ui.tab_pager

Reviewers: Jaehyun_Cho, jsuya

Reviewed By: jsuya

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7154

Change-Id: Ic0f72f95f7590e5f5aadc1938ac049230f725d8d
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
5 years agoelm_interface_scrollable: set to NULL when ecore job is finished. 81/190981/3
Hosang Kim [Wed, 10 Oct 2018 07:12:01 +0000 (16:12 +0900)]
elm_interface_scrollable: set to NULL when ecore job is finished.

In ecore_job callbak, job pointer should set to NULL.

@fix @tizen_only

Change-Id: Id5b0b838ac12d8c66df5aedfe745dc505b6976bf

5 years ago ecore_evas_extn: seperate event queue for tizen_embedded_compositor_get_socket 98/190898/1
Jiyoun Park [Mon, 8 Oct 2018 10:45:38 +0000 (19:45 +0900)]
   ecore_evas_extn: seperate event queue for tizen_embedded_compositor_get_socket

   sometimes, ecore_evas_extn can not get the proper socket event even though wayland server sends socket event.
   so add seperate queue for extn socket event.

Change-Id: Ic07560cbb27ba80365b072e62da41487ae881186

5 years agogenlist: increase genlist width min size from zero 92/190892/2
SangHyeon Jade Lee [Mon, 8 Oct 2018 09:54:12 +0000 (18:54 +0900)]
genlist: increase genlist width min size from zero

genlist pan width mininum size was decrease from large number 999999 before,
but it may not give proper size when the first item block calculation is
not called before _calc() function is called.

also, it cannot cover largest item size case, cause it choose smallest
item width size for min width.

genlist width min must be lagest item's width, to show whole item in
scrolling pan, so increase 0 to bigger is proper than decrease lager
one.

@tizen_fix

Change-Id: I27d2175ce85da6ce20229fef07dc1180176f7845

5 years agoedje: Update original position for text which running marquee 66/190866/2
Youngbok Shin [Mon, 8 Oct 2018 06:48:27 +0000 (15:48 +0900)]
edje: Update original position for text which running marquee

It fixes text's wrong position issue when a marquee ends.

@tizen_fix

Change-Id: I1238be9666ea47574f95f7897e3decbf41a54e54

5 years agoelm_genlist: prevent null pointer access 72/190772/2
JunsuChoi [Fri, 5 Oct 2018 07:56:09 +0000 (16:56 +0900)]
elm_genlist: prevent null pointer access

Summary: it->item->block can be null. so add null check.

Test Plan: elementary_test -to "genlist show/bring"

Reviewers: SanghyeonLee

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7146

Change-Id: Idca2dd57900380b9952558926ed66c02701b7b39

5 years agoecore_con_legacy: fix coverity issues (use after free) 65/190665/2
JunsuChoi [Thu, 4 Oct 2018 12:27:29 +0000 (21:27 +0900)]
ecore_con_legacy: fix coverity issues (use after free)

Summary:
for hard failures (highly unlikely), the handle would be deleted and the next use would crash.

Test Plan: N/A

Reviewers: Jaehyun_Cho, zmike, cedric, bu5hm4n

Subscribers: bu5hm4n, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7139

Change-Id: I9de4952abadfad4f92ee2a5e316c0146d2cfd8c7

5 years agoevas_events : last_mouse needs to be used even pdata is founded 36/190836/2 accepted/tizen/unified/20181007.224906 submit/tizen/20181006.080128
WooHyun Jung [Sat, 6 Oct 2018 07:42:45 +0000 (16:42 +0900)]
evas_events : last_mouse needs to be used even pdata is founded

In some cases, unexpected pdata is founded and all the logics in
evas_events are conflicted becuase of failure in pdata matching.

For example, mouse_down and mouse_up use the same ev->device, but
mouse_move uses the different one.

This only can be happened in Tizen, so just keep it as Tizen Only
Fix.

@hosang will improve this patch to keep the last_mouse not per evas
but per seat.

@tizen_fix

Change-Id: Ic80a36b4c8c1a3431f97099f397d5da6f84e7324

5 years agoefl_ui_clock: Prevent NULL pointer reference. 10/190810/1
Hosang Kim [Fri, 5 Oct 2018 11:01:18 +0000 (20:01 +0900)]
efl_ui_clock: Prevent NULL pointer reference.

When _elm_datetime_items_get() calling with only time format after
datetime creation.
The location has been swapped. so some of sorted_field index address
gets a invalid
address. then it makes a crash.

@tizen_fix

Change-Id: I34856201bc9ed5a4adc2c6aeb2693a294e7b4430

5 years agoevas : bug fixed about missing gl_context 64/190764/1
Joogab Yun [Fri, 5 Oct 2018 07:06:18 +0000 (16:06 +0900)]
evas : bug fixed about missing gl_context

Change-Id: I03fe2aa347aa741e0b90003917a4f0c9e91a7e6a

5 years agoedje: fix null pointer access bug
Jaeun Choi [Fri, 5 Oct 2018 06:38:28 +0000 (15:38 +0900)]
edje: fix null pointer access bug

Change-Id: Ifac6693f2ae5d27fa99c28d901a28196ae59bc9f

5 years agoefl_selection_manager: skip other process's send event 67/190667/2
Taehyub Kim [Thu, 4 Oct 2018 12:47:11 +0000 (21:47 +0900)]
efl_selection_manager: skip other process's send event

Change-Id: I0d187f4893beca1c1af431fe2dc3ed71bd7940a8

5 years agoelm_theme: fix return value when default style fallback is done 47/190647/1 submit/tizen/20181004.233344 submit/tizen/20181005.064551
Jaehyun Cho [Thu, 4 Oct 2018 07:50:21 +0000 (16:50 +0900)]
elm_theme: fix return value when default style fallback is done

To keep backward compatibility, EFL_UI_THEME_APPLY_DEFAULT is returned
instead of EFL_UI_THEME_APPLY_SUCCESS if style is not found in theme and
default style fallback is done instead.

This patch fixes 7353fc1cb85e08eb6e884ed8bbf9a009226069b6

@fix

Change-Id: I012a310c9c98b0c15e667fe9846e62b4c480b305

5 years agoeina debug: fix a double unlock issue 43/190643/2
Youngbok Shin [Thu, 4 Oct 2018 09:58:04 +0000 (18:58 +0900)]
eina debug: fix a double unlock issue

Summary:
It was caught by Covertity.
This patch will remove a potential double unlock issue.
@fix

Test Plan: N/A

Reviewers: zmike, raster, cedric, Hermet, eagleeye

Reviewed By: eagleeye

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7137

Change-Id: I290009b92ed961d662c6d1549de92644647f4dee

5 years agoelementary entry: apply scale to all edje objects 42/190642/1
Youngbok Shin [Thu, 4 Oct 2018 09:53:36 +0000 (18:53 +0900)]
elementary entry: apply scale to all edje objects

Summary:
When an entry is scrollable, its resize object is scr_edje.
So, to apply scale properly, elm_entry needs to apply scale
to its entry_edje, too.
@fix

Test Plan: Apply scale to scrollable entry

Reviewers: herdsman, woohyun, cedric, eagleeye

Reviewed By: eagleeye

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7140

Change-Id: I09f546a70ed306a5a08ec37728478729a3c2d793

5 years agoefl_page_transition_scroll: fix warning the dereference before null check 78/190478/1
Bowon Ryu [Tue, 2 Oct 2018 10:24:28 +0000 (19:24 +0900)]
efl_page_transition_scroll: fix warning the dereference before null check

Summary: if target is null, then terminate the function because it is not intended.

Test Plan: N/A

Reviewers: eunue

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7127

Change-Id: Ia7f78e5a8a5e246623afee94231cc128df88d965
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
5 years agoecore_evas_extn: check error case if bind result is null 73/190473/3
Jiyoun Park [Tue, 2 Oct 2018 09:53:16 +0000 (18:53 +0900)]
ecore_evas_extn: check error case if bind result is null

Change-Id: I3b75aa56aa8bb405f5234fc52327d720e7f91f41

5 years agoslider: add "slider,drag,start/stop" smart callbacks. 97/190397/2
Hosang Kim [Mon, 1 Oct 2018 11:29:26 +0000 (20:29 +0900)]
slider: add "slider,drag,start/stop" smart callbacks.

These callbacks are missing, when we merge codes.

Change-Id: Ie6b2f40cf47dd887b0fdb049af8e3dad7852a6e2

5 years agoevas gl: fix invalid image size. 02/190402/1
Hermet Park [Mon, 1 Oct 2018 12:06:36 +0000 (21:06 +0900)]
evas gl: fix invalid image size.

Summary:
When we reset of texture for a valid object,
this object cache size become -1 x -1 with null texture.

Later, we reset a new texture of the object,
Its texture size could be -1 x -1.
That brings to incorrect result drawing.

Can't see any points of using cache size there.

This bug was introduced by 9e01cf2698d5b24f440d696fd57d469cdc5a6b5f

@fix

Reviewers: #committers, raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7077

Change-Id: I210e31954ce347efa96197370dc63fc51a149f02

5 years agoevas_textblock_hyphenation: remove incorrect expression 71/190271/2 accepted/tizen/unified/20181002.093305 submit/tizen/20181001.055502
Jaeun Choi [Fri, 28 Sep 2018 14:43:34 +0000 (23:43 +0900)]
evas_textblock_hyphenation: remove incorrect expression

dict->cset is an array, not a pointer, thus is never NULL.
this was discovered by coverity.
upstream patch: https://phab.enlightenment.org/D7121

Change-Id: I0c1ebe264d1d2ecfb2197ccb7e4f57cbf12736de

5 years agoefl_ui_image: remove ecore job temporarily. 26/190326/2
Hosang Kim [Mon, 1 Oct 2018 04:02:42 +0000 (13:02 +0900)]
efl_ui_image: remove ecore job temporarily.

When we use ecore_job, it increases usage of graphic memory.
Until find a real cause, remove ecore job teomporarily.

@tizen_only

Change-Id: I26143d628e060d70b7e785b003b76e4f15ac2915

5 years agoecore_wl2_window: fix migration side effect 97/190297/2
Jiyoun Park [Mon, 1 Oct 2018 01:05:34 +0000 (10:05 +0900)]
ecore_wl2_window: fix migration side effect

Before code: if ((win->surface) && (win->display->wl.efl_aux_hints))
Wrong code: if ((!win->surface) && (!win->display->wl.efl_aux_hints))
Modified code:if ((!win->surface) || (!win->display->wl.efl_aux_hints))

Change-Id: I7fe97cd9eded322d2238452bf7fb5520ba712814

5 years agoefl_selection: add return value check for fwrite
Yeongjong Lee [Mon, 1 Oct 2018 02:11:57 +0000 (11:11 +0900)]
efl_selection: add return value check for fwrite

Summary: found by coverity

Reviewers: raster, Hermet

Subscribers: Hermet, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7109

5 years agoeldbus: remove unreachable code. 52/190252/1
Hosang Kim [Fri, 28 Sep 2018 11:53:31 +0000 (20:53 +0900)]
eldbus: remove unreachable code.

Coverity doesn't like this unreachable code.
https://phab.enlightenment.org/D7120

@fix

Change-Id: I87eec8aede73d34bf3a107c003cb6d739dd52852

5 years agoevas vg: +legacy api 49/190249/2
Hermet Park [Fri, 28 Sep 2018 11:35:19 +0000 (20:35 +0900)]
evas vg: +legacy api

evas_object_vg_file_set()

Change-Id: Ief22caae2551969a7716f8497d1f1ef5ee40e5ec

5 years agoevas vg: add two legacy apis. 41/190241/2
Hermet Park [Fri, 28 Sep 2018 10:49:46 +0000 (19:49 +0900)]
evas vg: add two legacy apis.

evas_object_vg_animated_frame_duration_get()
evas_object_vg_animated_frame_get()

Change-Id: I57d9b01a927076d077d4af8e8e78d462d535a94e

5 years agoelementary bg: revert scale disable patch to support bg_option functions 33/190233/1
Youngbok Shin [Fri, 28 Sep 2018 10:01:27 +0000 (19:01 +0900)]
elementary bg: revert scale disable patch to support bg_option functions

It was applied to fix scale policy issue.
The patch was disabling scale by elm_objeect_scale_set with 0.0~#.
But, it also disabled image scale feature which is used for bg_option functions.
So, it has to be reverted and revised for elm_object_scale_set() problem.
@tizen_fix

Change-Id: I6eb44d0a8eb1c1cd35b067ffa6745dc99df8cfab

5 years ago evas_object_textblock: fix warning the dereference before null check 26/190226/1
Jiyoun Park [Fri, 28 Sep 2018 09:07:01 +0000 (18:07 +0900)]
   evas_object_textblock: fix warning the dereference before null check

Change-Id: I1e473357002b8b012d42c961de8861a51351f27e

5 years agoelm entry - dont seg if the obj has been deleted by callback time 24/190224/1
Carsten Haitzler (Rasterman) [Sat, 17 Feb 2018 09:00:19 +0000 (18:00 +0900)]
elm entry - dont seg if the obj has been deleted by callback time

i spotted a segv with elm entry + efm ... sd was NULl because obj was
seemingly not valid at that point, so fix and check the smart data
returns before moving on.

Change-Id: Id8e52679c1e6ba0dd7ed0d6651a42fb68de2b1ca

5 years agoedje: call recalc in part_text_get if there is no available text data 12/190212/1
Yeongjong Lee [Fri, 28 Sep 2018 07:13:39 +0000 (16:13 +0900)]
edje: call recalc in part_text_get if there is no available text data

Summary:
If edje_text_get is called before any edje_text_set function call, it return
null, because rp->typedata.text->text is only set by edje_text_set function.
If there is no available text data, find it from rp(edc).

ref 7bbf18a950c027a365fea1b88e8dc3f16bb81abe

Test Plan: make check

Reviewers: zmike, id213sin, herdsman

Reviewed By: id213sin

Subscribers: Hermet, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6961

Change-Id: Ife4c30a23b90c0b41dbf2da2240c922cb8ae4cf2

5 years agoelm_interface_scrollable: fix using wrong variable. 03/190203/1
Hosang Kim [Fri, 28 Sep 2018 06:39:18 +0000 (15:39 +0900)]
elm_interface_scrollable: fix using wrong variable.

vy isn't initialized when p >1.0 or p<0.

https://phab.enlightenment.org/D7114

@fix

Change-Id: If294ef7b96a18863490b1ae703ce42ad716e9ca1

5 years agoedje vector: fix wrong implementations from the Edje json support patch 02/190202/1
Youngbok Shin [Fri, 28 Sep 2018 06:31:50 +0000 (15:31 +0900)]
edje vector: fix wrong implementations from the Edje json support patch

Change-Id: Ic359f3cd2aa07269331bb37d60aa5f4fb4e9bc7b

5 years agoecore_audio_obj_out_tizen: check efl_key_data_get return 45/190045/4 submit/tizen/20180928.051038
Yeongjong Lee [Thu, 27 Sep 2018 00:30:59 +0000 (09:30 +0900)]
ecore_audio_obj_out_tizen: check efl_key_data_get return

Found by coverity

Change-Id: I1301d9481d9ef3c7cef49b7ac0b59f85ec7ed136

5 years agoecore_con: Add docs for ecore_con legacy functions
JunsuChoi [Thu, 27 Sep 2018 09:22:22 +0000 (11:22 +0200)]
ecore_con: Add docs for ecore_con legacy functions

Summary:
Find docs of missing legacy functions
from 9c33623(ecore: add ecore_con_url_ssl_ca_set.),
40edc9c(ecore: add ecore_con_url_ssl_verify_peer_set patch by Raoul Hecky.)
and add them.

Test Plan: make doc

Reviewers: cedric, Hermet, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7117

5 years agoecore_timer: Add docs for ecore_timer legacy functions
JunsuChoi [Thu, 27 Sep 2018 09:12:46 +0000 (11:12 +0200)]
ecore_timer: Add docs for ecore_timer legacy functions

Summary:
Find docs of missing legacy functions
from 47cdbe3 and add them.

Test Plan: make doc

Reviewers: cedric, Hermet, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7118

5 years agoefl_vg: calculate center point with double type
Jaehyun Cho [Fri, 21 Sep 2018 12:30:50 +0000 (12:30 +0000)]
efl_vg: calculate center point with double type

Although the center point is double type, the calculation is integer type.
To calculate center point correctly, calculate with double type.
Differential Revision: https://phab.enlightenment.org/D7097

5 years agoefreet_menu: remove unused and unreachable code.
Alastair Poole [Mon, 24 Sep 2018 10:26:23 +0000 (10:26 +0000)]
efreet_menu: remove unused and unreachable code.

Coverity doesn't like this unreachable code. This purges
efreet_menu of all unused code for the deprecated and
non-working menu_async methods. The warnings remain
at compile time and run time.
Differential Revision: https://phab.enlightenment.org/D7101

5 years agoefl_ui_stack: Partially Revert "efl_ui_stack: remove unnecessary condition of EINA_IN...
Yeongjong Lee [Thu, 27 Sep 2018 07:33:37 +0000 (07:33 +0000)]
efl_ui_stack: Partially Revert "efl_ui_stack: remove unnecessary condition of EINA_INLIST_CONTAINER_GET return value"

This partially reverts commit 820dcb9cd975e93271977246aaf1b1a707435851.

top_cd can be NULL when cd->stack is NULL.

Thanks to bu5hm4n for reporting.
Differential Revision: https://phab.enlightenment.org/D7116

5 years agoeina_value: return null when eina_value_pget failed
Yeongjong Lee [Thu, 27 Sep 2018 05:10:31 +0000 (14:10 +0900)]
eina_value: return null when eina_value_pget failed

Summary:
Add return value check.
found by coverity.

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7107

5 years agoelm_genlist: prevent null pointer access
Yeongjong Lee [Thu, 27 Sep 2018 05:08:39 +0000 (14:08 +0900)]
elm_genlist: prevent null pointer access

Summary: found by coverity

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7108

5 years agoefl_exe: check fcntl return
Yeongjong Lee [Thu, 27 Sep 2018 04:58:08 +0000 (13:58 +0900)]
efl_exe: check fcntl return

Summary: Found by coverity

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7110

5 years agoefl_ui_stack: remove unnecessary condition of EINA_INLIST_CONTAINER_GET return value
Yeongjong Lee [Thu, 27 Sep 2018 04:57:33 +0000 (13:57 +0900)]
efl_ui_stack: remove unnecessary condition of EINA_INLIST_CONTAINER_GET return value

Summary:
Becase EINA_INLIST_CONTAINER_GET always return true, it doesn't need to check
whether return value is null.

Reviewers: Jaehyun_Cho, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7112

5 years agoefl_ui_list: fix wrong variable usage
Yeongjong Lee [Thu, 27 Sep 2018 04:55:20 +0000 (13:55 +0900)]
efl_ui_list: fix wrong variable usage

Reviewers: SanghyeonLee, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7113

5 years agoefl-csharp: Fix event struct marshalling.
Lauro Moura [Wed, 26 Sep 2018 15:01:49 +0000 (12:01 -0300)]
efl-csharp: Fix event struct marshalling.

Summary:
The efl.Event struct has a class field that gets generated normally but
can be problematic when marshalling the struct back from C to C#. The
compilation works fine but when C# runtime tries to marshall the C data
(e.g. accessing the Event.Info field), it becomes erratic, either
complaining about missing references to object or even segfault.

This commit changes the event handling code to use the
"Event_StructInternal" struct as is already done when receiving structs
from C code.

In order to work with other assemblies, the _StructInternal fields were
made publit too.

Fixes the events tests and the text editor app.

Test Plan: make check and run the text editor app in examples repo.

Reviewers: segfaultxavi, vitor.sousa

Reviewed By: vitor.sousa

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7106

5 years agodocs: Fix Efl.Ui.Focus.Object.Focus() docs
Xavi Artigas [Wed, 26 Sep 2018 07:21:26 +0000 (09:21 +0200)]
docs: Fix Efl.Ui.Focus.Object.Focus() docs

Summary:
The same description was used for both the Setter and the Getter, which makes
no sense.

Reviewers: zmike, bu5hm4n, bryceharrington, devilhorns

Reviewed By: bu5hm4n, devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7071

5 years agoelementary_test: use snprintf to prevent memory overflow in test_efl_ui_text
Youngbok Shin [Mon, 24 Sep 2018 10:17:26 +0000 (11:17 +0100)]
elementary_test: use snprintf to prevent memory overflow in test_efl_ui_text

Summary: To prevent memory overflow, use snprintf instead of sprintf.

Test Plan: N/A

Reviewers: raster, cedric, zmike, Hermet, netstar

Reviewed By: netstar

Subscribers: netstar, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7095

5 years agoeina: Improve doxygen formatting for eina_debug.h
Bryce Harrington [Fri, 21 Sep 2018 18:34:28 +0000 (14:34 -0400)]
eina: Improve doxygen formatting for eina_debug.h

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7098

5 years agoexamples - fix avahi examples to compile
Carsten Haitzler (Rasterman) [Fri, 21 Sep 2018 12:39:45 +0000 (13:39 +0100)]
examples - fix avahi examples to compile

add links to avahi system client libs.

5 years agoColorselector : Add docs of elm_colorselector_palette_item_* APIs
JunsuChoi [Fri, 21 Sep 2018 11:05:44 +0000 (20:05 +0900)]
Colorselector : Add docs of elm_colorselector_palette_item_* APIs

Summary:
Add documentation for these APIs
elm_colorselector_palette_item_color_get
elm_colorselector_palette_item_color_set
elm_colorselector_palette_item_selected_get
elm_colorselector_palette_item_selected_set

Test Plan: make doc

Reviewers: cedric, Hermet, zmike, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7091

5 years agoDocs: Fix incorrectly information for elm_config_softcursor_mode_set
JunsuChoi [Fri, 21 Sep 2018 11:03:18 +0000 (20:03 +0900)]
Docs: Fix incorrectly information for elm_config_softcursor_mode_set

Summary: N/A

Test Plan: make doc

Reviewers: cedric, Hermet, zmike, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7094

5 years agoDocs: Add a group of APIs for which group is not declared in elm_config
JunsuChoi [Fri, 21 Sep 2018 11:02:33 +0000 (20:02 +0900)]
Docs: Add a group of APIs for which group is not declared in elm_config

Summary:
Longpress
   elm_config_longpress_timeout_get
   elm_config_longpress_timeout_set
SotfCursor
   elm_config_softcursor_mode_set
   elm_config_softcursor_mode_get
Tooltips (Add in Elm_Tooltips)
   elm_config_tooltip_delay_get
   elm_config_tooltip_delay_set

Test Plan: make doc

Reviewers: cedric, Hermet, zmike, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7093

5 years agoedje: add missing eina_deprecated to apis.
Hermet Park [Fri, 21 Sep 2018 08:59:30 +0000 (17:59 +0900)]
edje: add missing eina_deprecated to apis.

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7090

5 years agoEdje: update doc.
Hermet Park [Fri, 21 Sep 2018 08:55:14 +0000 (17:55 +0900)]
Edje: update doc.

Summary: fix and add missing doxygen conent.

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7088

5 years agoelm_entry: update documentation for elm_entnry_textonly_mode_set/get
Taehyub Kim [Fri, 21 Sep 2018 09:04:49 +0000 (18:04 +0900)]
elm_entry: update documentation for elm_entnry_textonly_mode_set/get

Summary: update documentation

Reviewers: Jaehyun_Cho, raster

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7089

5 years agodocs: correct group name of segmentcontrol for API docs.
Bowon Ryu [Fri, 21 Sep 2018 08:25:56 +0000 (17:25 +0900)]
docs: correct group name of segmentcontrol for API docs.

Summary:
correct group name of segmentcontrol for API docs consistency.
Elm_SegmentControl -> Elm_Segment_Control

Test Plan: N/A

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7087

5 years agoedje example: fix svg data.
Hermet Park [Fri, 21 Sep 2018 07:56:05 +0000 (16:56 +0900)]
edje example: fix svg data.

Summary:
these svg data format didn't have the standard.

Specify 0 ~ 100 in % unit i.e. 50%
Otherwise, 0 ~ 1 in normalized value. i.e. 0.5

Reviewers: #committers

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7054

5 years agoeina: Grammar improvements
Bryce Harrington [Fri, 21 Sep 2018 07:55:36 +0000 (16:55 +0900)]
eina: Grammar improvements

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7058

5 years agoelementary: fix memory leak from Efl.Ui.Layout.Object
Youngbok Shin [Fri, 21 Sep 2018 07:50:30 +0000 (16:50 +0900)]
elementary: fix memory leak from Efl.Ui.Layout.Object

Summary:
The 'data' could not be added to hash in a condition.
It has to be free'd before ending the function.
@fix

Test Plan: N/A

Reviewers: cedric, raster, Hermet, zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7083

5 years agoevas cache: add more null check for cache
Youngbok Shin [Fri, 21 Sep 2018 07:32:07 +0000 (16:32 +0900)]
evas cache: add more null check for cache

Summary:
The 'cache' pointer is checked against null but then
dereferenced anyway. It needs to add null checking conditions.

Test Plan: N/A

Reviewers: raster, cedric, Hermet, zmike

Reviewed By: Hermet

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7084

5 years agoevas_object_callbacks: do not error on NULL on del
Marcel Hollerbach [Wed, 12 Sep 2018 19:16:39 +0000 (21:16 +0200)]
evas_object_callbacks: do not error on NULL on del

it does not really matter if a obj is NULL or not when deleting a callback.
The result might be NULL anyways when the callback is not found.
Additionally, this is very verbose, and leads to the fact that most of
the time normal calls to evas_object_event_callback_del* should be if
(!obj) evas_object_event_callback_del* which is annoying and wastefull.

Differential Revision: https://phab.enlightenment.org/D7028

5 years agoelementary: remove meaningless memory allocation and leaking
Youngbok Shin [Fri, 21 Sep 2018 07:23:36 +0000 (07:23 +0000)]
elementary: remove meaningless memory allocation and leaking

'evt_data' was allocated. Actually, it was not used in anywhere in its function.
@fix
Differential Revision: https://phab.enlightenment.org/D7086

5 years agoeina_vpath: fix the memory leak
Taehyub Kim [Fri, 21 Sep 2018 06:05:58 +0000 (15:05 +0900)]
eina_vpath: fix the memory leak

Summary:
 fix the memory leak
@fix

Reviewers: Jaehyun_Cho, bu5hm4n

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7081

5 years agoecore_main: fix the invalid return value
Taehyub Kim [Fri, 21 Sep 2018 05:46:50 +0000 (14:46 +0900)]
ecore_main: fix the invalid return value

Summary:
fix the invalid return value
@fix

Reviewers: Jaehyun_Cho, raster, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7080

5 years agoeina: Improve explanation of read-only binbuf's
Bryce Harrington [Tue, 18 Sep 2018 23:41:52 +0000 (08:41 +0900)]
eina: Improve explanation of read-only binbuf's

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7057

5 years agoeina: Refer to sin/cos as sine/cosine instead of sinus/cosinus
Bryce Harrington [Tue, 18 Sep 2018 23:38:32 +0000 (08:38 +0900)]
eina: Refer to sin/cos as sine/cosine instead of sinus/cosinus

Summary:
Sinus and cosinus are just the Latin words for sine and cosine, but we
should use the English versions to avoid any possible confusion.

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7059

5 years agoeina promise: Fix example error message in docs
Bryce Harrington [Tue, 18 Sep 2018 23:37:39 +0000 (08:37 +0900)]
eina promise: Fix example error message in docs

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7060

5 years agoeina cow: Cleanup doxygen syntax
Bryce Harrington [Tue, 18 Sep 2018 23:35:02 +0000 (08:35 +0900)]
eina cow: Cleanup doxygen syntax

Summary:
The "be careful" advice seems a bit odd in api docs, better to just flag
them with doxygen @note's.

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7061

5 years agoemotion: Convert to new animators
Derek Foreman [Tue, 18 Sep 2018 14:43:22 +0000 (09:43 -0500)]
emotion: Convert to new animators

Summary:
Use more efficient animator mechanism.
Depends on D7051

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7052

5 years agoefl_canvas_animation_player: Convert to new animators
Derek Foreman [Tue, 18 Sep 2018 14:43:17 +0000 (09:43 -0500)]
efl_canvas_animation_player: Convert to new animators

Summary:
Use more efficient animator mechanism.
Depends on D7050

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7051

5 years agoemotion: Convert to new animators
Derek Foreman [Tue, 18 Sep 2018 14:43:14 +0000 (09:43 -0500)]
emotion: Convert to new animators

Summary:
Use more efficient animator mechanism.
Depends on D7049

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7050

5 years agoelu_ews_wm: Convert to new animators
Derek Foreman [Tue, 18 Sep 2018 14:43:09 +0000 (09:43 -0500)]
elu_ews_wm: Convert to new animators

Summary:
Use more efficient animator mechanism.
Depends on D7048

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7049

5 years agoelm_transit: Convert to new animators
Derek Foreman [Tue, 18 Sep 2018 14:43:05 +0000 (09:43 -0500)]
elm_transit: Convert to new animators

Summary:
Use more efficient animator mechanism.
Depends on D7047

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7048

5 years agoelm_genlist: Convert to new animators
Derek Foreman [Tue, 18 Sep 2018 14:43:02 +0000 (09:43 -0500)]
elm_genlist: Convert to new animators

Summary:
Use more efficient animator mechanism.
Depends on D7046

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7047

5 years agoelm_gengrid: Convert to new animators
Derek Foreman [Tue, 18 Sep 2018 14:42:58 +0000 (09:42 -0500)]
elm_gengrid: Convert to new animators

Summary:
Use more efficient animator mechanism.
Depends on D7045

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7046

5 years agoelm_box: Convert to new animators
Derek Foreman [Tue, 18 Sep 2018 14:42:54 +0000 (09:42 -0500)]
elm_box: Convert to new animators

Summary:
Use more efficient animator mechanism.
Depends on D7044

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7045

5 years agoelm_actionslider: Convert to new animators
Derek Foreman [Tue, 18 Sep 2018 14:42:50 +0000 (09:42 -0500)]
elm_actionslider: Convert to new animators

Summary:
Use more efficient animator mechanism.
Depends on D7043

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7044

5 years agoefl_ui_flip: Convert to new animators
Derek Foreman [Tue, 18 Sep 2018 14:42:46 +0000 (09:42 -0500)]
efl_ui_flip: Convert to new animators

Summary:
Use more efficient animator mechanism.
Depends on D7042

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7043

5 years agoselection_manager: Convert to new animators
Derek Foreman [Tue, 18 Sep 2018 14:42:42 +0000 (09:42 -0500)]
selection_manager: Convert to new animators

Summary:
Use more efficient animator mechanism.

Depends on D7041

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7042

5 years agoecore: Add new way to register animators
Derek Foreman [Tue, 18 Sep 2018 14:42:38 +0000 (09:42 -0500)]
ecore: Add new way to register animators

Summary:
We have back-ends that can generate their own tick sources, but
ecore_animator_add()/ecore_animator_timeline_add() gives no indication
which backend the animator is running on.  This means that all animators
have to cause all currently in use backends to tick.

For example, if under wayland 4 application windows are open, all 4
windows will create ticks when any animator is present.

These new animator APIs that take an evas object allow us to figure out
out the backend and only cause the appropriate one to tick.

Depends on D7040

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7041

5 years agoecore_anim: Move struct Ecore_Animator to private header
Derek Foreman [Tue, 18 Sep 2018 14:42:34 +0000 (09:42 -0500)]
ecore_anim: Move struct Ecore_Animator to private header

Summary:
We're going to use this in ecore_evas shortly.

Depends on D7039

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7040