platform/upstream/elementary.git
6 years agoAdd attributes_get for widget item. 13/168413/1
JunsuChoi [Fri, 26 Jan 2018 09:07:07 +0000 (18:07 +0900)]
Add attributes_get for widget item.

  Add widget item to provide attribute for style.
  This is also an upstream code.

  ----------------------------------------------------------------------
   efl_access: Add attribute_append, attributes_clear APIs

   Summary:
   Add attribute append and attributes clear API, attributes of widget/widget_item helps in adding additional information
   about the widget/widget item in the form of key-value pair.

   Test Plan:
   Query the attributes using atspi_accessible_get_attributes in atspi_client and an hash table consisting
   of updates attributes should be returned.

   Signed-Off By: Shilpa Singh <shilpa.singh@samsung.com>
   Signed-Off By: Lukasz Wlazly <l.wlazly@partner.samsung.com>

   Reviewers: kimcinoo, lukasz.stanislawski

   Subscribers: cedric, govi, rajeshps, jpeg

   Differential Revision: https://phab.enlightenment.org/D5510

Change-Id: I5c64828b8accab550c980b0f4a80e7bc4770413e

6 years agoctxpopup: fix build warning 09/167809/1 submit/tizen/20180124.103314
JinYong Park [Mon, 22 Jan 2018 07:26:23 +0000 (16:26 +0900)]
ctxpopup: fix build warning

@tizen_fix

Change-Id: I102f8cd43efd7aa7d7627586cb89576626147010
Signed-off-by: JinYong Park <j4939.park@samsung.com>
6 years agoelm_config : fix the mismatch count of init/shutdown call 91/167491/1
jiin.moon [Thu, 18 Jan 2018 03:57:06 +0000 (12:57 +0900)]
elm_config : fix the mismatch count of init/shutdown call

Change-Id: I94ed13a07db0d636f0e2b8df317c1ca3c9bf0821

6 years agoctxpopup: add animation signal emit after sizing eval. 35/166635/1 accepted/tizen/unified/20180119.061046 submit/tizen/20180116.114446
JinYong Park [Thu, 11 Jan 2018 07:31:06 +0000 (16:31 +0900)]
ctxpopup: add animation signal emit after sizing eval.

In some case, sizing eval calculate new ctxpopup direction,
but animation signal doesn't be emitted.
For example, move ctxpopup after show is called.

Change-Id: I19c4ef215853783d18f80b1469584979dbbe0fc6
Signed-off-by: JinYong Park <j4939.park@samsung.com>
6 years agoctxpopup: fix unintentional item style change 89/166589/3
JinYong Park [Thu, 11 Jan 2018 02:41:44 +0000 (11:41 +0900)]
ctxpopup: fix unintentional item style change

When ctxpopup set style, show, set horizontal, change item's text,
item change style to smae with ctxpopup although it has its own style.

Change-Id: If2a7b897ee156015af078db7eee4b10fd1f9d56d
Signed-off-by: JinYong Park <j4939.park@samsung.com>
6 years agoelm_datetime: elm_widget_can_focus_set before module init for support TV UX 27/166627/1
Jeonghyun Yun [Thu, 11 Jan 2018 07:32:40 +0000 (16:32 +0900)]
elm_datetime: elm_widget_can_focus_set before module init for support TV UX

@tizen_fix

Change-Id: I802dd21e1a0ea66c4d984b54091bb98fe4163e9c
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
6 years agoentry: Add autofill hint 49/165849/2
Jihoon Kim [Thu, 4 Jan 2018 09:43:56 +0000 (18:43 +0900)]
entry: Add autofill hint

Change-Id: I487b5b74f80663198d0457e5ed0e396fbd0e3152
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
6 years agonaviframe: Move focus from last content to first content by focus next 85/166285/2 accepted/tizen/unified/20180111.074150 submit/tizen/20180110.035612
Jaehyun Cho [Tue, 9 Jan 2018 06:48:32 +0000 (15:48 +0900)]
naviframe: Move focus from last content to first content by focus next

Previously, if naviframe focus reaches to the last content, then the
next focus goes to naviframe itself and focus remains the last content.

Now, if naviframe focus reaches to the last content, then the next focus
goes to the first content.

Change-Id: I2bac890cd5953bfe77fee47044b2f86ce7d4c148

6 years agogenlist: fix white bg issue in item clip unset 22/166022/3
SangHyeon Lee [Fri, 5 Jan 2018 08:04:04 +0000 (17:04 +0900)]
genlist: fix white bg issue in item clip unset

Change-Id: If610c2ec963452e971aaa9ea08b443b13d4a695b
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
6 years agolayout: add elm_layout_valign_set/get APIs 47/166147/1
Youngbok Shin [Tue, 2 Jan 2018 11:18:12 +0000 (20:18 +0900)]
layout: add elm_layout_valign_set/get APIs

@tizen_feature

Change-Id: Id49dff4811801aa4d6bbd691177003eeeda14612
(cherry picked from commit 679c65f7c93863a7d3c12ff5968e5a08d2e27c18)

6 years agoatspi: gengrid removes item from atspi_children 52/165852/5
Shinwoo Kim [Thu, 4 Jan 2018 09:56:21 +0000 (18:56 +0900)]
atspi: gengrid removes item from atspi_children

The gengrid appends an item to the atspi_children list when the item is
created. But the gengrid does not remove an item from atspi_children list when
the item is removed. So there is a crash issue in the _sort_items function of
eina_list_sort, because this function tries to compare using removed data.

For more information, the cbhm-service has following stack.

(1) when genlist removes item
_item_del at elm_gengrid.c:4290
_elm_gengrid_item_elm_widget_item_del_pre at elm_gengrid.c:4433
elm_wdg_item_del_pre at elm_widget_item.eo.c:236
_elm_widget_item_del at elm_widget.c:4921
elm_wdg_item_del at elm_widget_item.eo.c:128
elm_object_item_del at elm_widget_item.eo.c:653
_drawer_item_del at /usr/src/debug/cbhm-1.0.0/daemon/cbhmd_drawer.c:420
_cbhmd_item_free at /usr/src/debug/cbhm-1.0.0/daemon/cbhmd_item.c:47
cbhmd_item_delete_by_cnp_item at /usr/src/debug/cbhm-1.0.0/daemon/cbhmd_item.c:443
_drawer_item_add at /usr/src/debug/cbhm-1.0.0/daemon/cbhmd_drawer.c:396
cbhmd_item_add_by_cnp_item at /usr/src/debug/cbhm-1.0.0/daemon/cbhmd_item.c:94
cbhmd_storage_init at /usr/src/debug/cbhm-1.0.0/daemon/cbhmd_storage.c:212
app_create at /usr/src/debug/cbhm-1.0.0/daemon/cbhmd.c:134
?? () from target:/lib/libappcore-efl.so.1
appcore_base_init () from target:/lib/libappcore-common.so.1
appcore_ui_base_init () from target:/lib/libappcore-ui.so.1
appcore_efl_base_init () from target:/lib/libappcore-efl.so.1
appcore_efl_init () from target:/lib/libappcore-efl.so.1
appcore_efl_main () from target:/lib/libappcore-efl.so.1
main at /usr/src/debug/cbhm-1.0.0/daemon/cbhmd.c:296

(2) when genlist sorts item
_sort_items at elm_gengrid.c:6429
eina_list_sort at lib/eina/eina_list.c:1082
_elm_gengrid_elm_widget_screen_reader at elm_gengrid.c:4864
elm_obj_widget_screen_reader at elm_widget.eo.c:405
elm_widget_screen_reader at elm_widget.c:970
elm_widget_screen_reader at elm_widget.c:968
elm_widget_screen_reader at elm_widget.c:968
_elm_win_screen_reader at elm_win.c:3074
_screen_reader_enabled_get at elm_atspi_bridge.c:6455
?? () from /lib/libeldbus.so.1
?? () from /lib/libdbus-1.so.3
dbus_connection_dispatch () from /lib/libdbus-1.so.3
?? () from /lib/libeldbus.so.1
?? () from /lib/libecore.so.1
?? () from /lib/libecore.so.1
?? () from /lib/libecore.so.1
ecore_main_loop_begin () from /lib/libecore.so.1
appcore_base_init () from /lib/libappcore-common.so.1
appcore_ui_base_init () from /lib/libappcore-ui.so.1
appcore_efl_base_init () from /lib/libappcore-efl.so.1
appcore_efl_init () from /lib/libappcore-efl.so.1
appcore_efl_main () from /lib/libappcore-efl.so.1
?? ()
__libc_start_main () from /lib/libc.so.6
_start ()

Change-Id: I3db7042316f3ef6aee4b7e4bbe3e24fa292cdce6

6 years agoentry: fix cursor position initialization issues when theme is changed 68/165268/1 accepted/tizen/unified/20180105.065619 submit/tizen/20180103.114435 submit/tizen/20180104.104342
Youngbok Shin [Wed, 27 Dec 2017 10:28:31 +0000 (19:28 +0900)]
entry: fix cursor position initialization issues when theme is changed

The issue was caused by the following patch.
"elm_entry: Save cursor position before entry text clear"

It needed to get cursor position at the text_set function to avoid
cursor position issue by delaying signal callback functions.
So, we can't remove the patch. In the theme_apply, we need to handle
cursor position more carefully to fix this side effect.

@tizen_fix

Change-Id: Id63aa401ba2572559bc241f54350b781c72f5092

6 years agoelementary: apply slide ALWAYS mode for Edje marquee 23/162623/2
Youngbok Shin [Mon, 4 Dec 2017 08:36:30 +0000 (17:36 +0900)]
elementary: apply slide ALWAYS mode for Edje marquee

Dependency warning: It should be applied with the following patch.
https://review.tizen.org/gerrit/162567

@tizen_fix

Change-Id: I0ff3a8dee81aef26f3cbce38477b816e7bd576f2
(cherry picked from commit 6292aca2b931efbe286dec1dd92127d1b26a9dd8)

6 years agogenlist: fix tooltip_cb_set wrong exception handling 46/164446/1 accepted/tizen/unified/20171221.071234 submit/tizen/20171220.062652
SangHyeon Lee [Tue, 19 Dec 2017 06:34:55 +0000 (15:34 +0900)]
genlist: fix tooltip_cb_set wrong exception handling

Change-Id: I34fa14a91213917fb0842ba36e4bf0efb29ba953
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
6 years agodxygen: fixed textwidth warning. 02/158102/2
subhransu mohanty [Mon, 30 Oct 2017 00:46:29 +0000 (09:46 +0900)]
dxygen: fixed textwidth warning.

Change-Id: Ibdc39a6a9dddfe4ca5dc5df932fc808c12493cbf

6 years agoctxpopup: fix multi-resolution problem by advanced flexible feature 86/132286/14
JinYong Park [Fri, 2 Jun 2017 06:08:11 +0000 (15:08 +0900)]
ctxpopup: fix multi-resolution problem by advanced flexible feature

 ctxpopup size decision priority
  1. size hint min/max set by user
  2. match_min_width / match_max_width data in theme
  3. visible_maxw / visible_maxh data in theme

  - Requirement
     profile/mobile/platform/core/uifw/efl-theme-tizen-mobile
     https://review.tizen.org/gerrit/132651

Change-Id: I4d895c865bb76b01332a6791506158861aa762c6
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
6 years agoatspi: not accept redundant leaf object 89/163689/2 accepted/tizen/unified/20171215.132215 submit/tizen/20171214.113147
Shinwoo Kim [Fri, 8 Dec 2017 07:54:54 +0000 (16:54 +0900)]
atspi: not accept redundant leaf object

An object which role is ELM_ATSPI_ROLE_REDUNDANT_OBJECT, has been acceptable
so far regardless its children. So it was possible to find its children.
But it does not make sense to accept ELM_ATSPI_ROLE_REDUNDANT_OBJECT object if
it does not have children.

There was an issue on Browser application because we accepted REDUNDANT leaf
object. There is a button which role is ELM_ATSPI_ROLE_REDUNDANT_OBJECT, this
button would be used for conveying focus event to embedded web page.
The button was accepted, so it was not possible grab an object on web page.

Please refer to following part of accessibility tree. It is not possible to
get Elm_Atspi_Ewk_Wrapper, if Elm_Button is accepted for "GetNavigableAtPoint"

Elm_Layout
     - Elm_Button [redundant object][0,148,1080,1604]
     - Elm_Atspi_Ewk_Wrapper [embedded][0,148,1080,1604]

Change-Id: I355a913314d0132e0b0e0f7779e1d7c0b66b25db

6 years agoatspi: do not accept ELM_ATSPI_ROLE_IMAGE_MAP 87/163687/2
Shinwoo Kim [Wed, 29 Nov 2017 12:14:19 +0000 (21:14 +0900)]
atspi: do not accept ELM_ATSPI_ROLE_IMAGE_MAP

There are two widgets using ELM_ATSPI_ROLE_IMAGE_MAP role.
One is elm_mapbuf which does not have to grab highlight.
It does not make sense because the elm_mapbuf only works for its content.
The other is elm_map. So far the elm_map does not have to grab highlight, and
it seems that the ELM_ATSPI_ROLE_IMAGE_MAP is improper role for elm_map.
We have to find proper role for elm_map when it is neccesary to grab highlight.
So this patch set would be reasonable.

Change-Id: I8fc82c8f278b12f1e6367f4e40bf6b37c44b1481

6 years agoAdd scrollable-like functions to at-spi component object 80/157880/8
Radoslaw Cybulski [Thu, 26 Oct 2017 10:51:50 +0000 (12:51 +0200)]
Add scrollable-like functions to at-spi component object

Extends scrollable interface and at-spi protocol with scroll
functionality. Used in Universal Switch to implement scroll up / down a page,
scroll to end and fluid scrolling over time.

Change-Id: Ib2ac1fb8e85817f6e817e30a858886749e6bb8a6

6 years agoFix embedding after stoping and restarting at-spi 19/159519/5
Radoslaw Cybulski [Thu, 9 Nov 2017 10:21:12 +0000 (11:21 +0100)]
Fix embedding after stoping and restarting at-spi

Restarting at-spi doesnt remove __widget_proxy property from
smart object. As a result, when proxy is queried for children,
it will return previous at-spi object, which is already
defuncted. This patch adds checking for defunct flag on object
and reinitialization, if such object is found in __widget_proxy.

Change-Id: I7fe7c494738f223ced81629f78397b8ca21d43a5

6 years agogenlist: enabled select on focus 63/162263/1 accepted/tizen/unified/20171204.072212 submit/tizen/20171130.115009
SangHyeon Jade Lee [Thu, 30 Nov 2017 04:24:15 +0000 (13:24 +0900)]
genlist: enabled select on focus

Change-Id: I9740b7ef0148c24bacc126a439fc1f8cfd64ceb0
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
6 years agofocus: Add second_level for focus direction weight calculate 05/162105/1
Jeonghyun Yun [Wed, 29 Nov 2017 06:29:39 +0000 (15:29 +0900)]
focus: Add second_level for focus direction weight calculate

@tizen_fix

Change-Id: Ifab1a45485741b12ac68a17a5fb24581dab3bce8
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
6 years agogenlist: fix item calculation performance issue 82/161182/1 accepted/tizen/unified/20171124.064607 submit/tizen/20171123.082406
SangHyeon Jade Lee [Wed, 22 Nov 2017 05:12:00 +0000 (14:12 +0900)]
genlist: fix item calculation performance issue

in calc(),
we only need to process first viewport items,
but currently it forcely calculate block sized items in
every single calc() funciton calls because of || operator.
it must be changed as && operator for orignal purpose.

Change-Id: If57081046d67c09d66c360dbbb75b31101ecc1e6
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
7 years agoelc_ctxpopup: Add item_style_get API 50/160350/3
Shilpa Singh [Wed, 15 Nov 2017 12:48:33 +0000 (18:18 +0530)]
elc_ctxpopup: Add item_style_get API

Change-Id: I1911c4fb41a21e71ffeb9cfde193755872f6909b
Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>
7 years agoatspi: Use bottom up approach for PAGE_TAB 27/159027/7
Shinwoo Kim [Mon, 6 Nov 2017 12:04:13 +0000 (21:04 +0900)]
atspi: Use bottom up approach for PAGE_TAB

The naviframe item is elm_layout, and its atspi role is ELM_ATSPI_ROLE_PAGE_TAB.
The screen-reader could ask an object at point by using the naviframe item as a
root object. In this case, elementary did not us bottom up approach.
For the consistency, and to make it work better, This patch set is using the
bottom up approach for the naviframe item.

Change-Id: Icfe0791e340dac0c3998b56217fab8c34922cc5b

7 years agoRevert "ctxpopup: fix 'more' style problem. remove white space, fix landscape and... 85/160385/1
JinYong Park [Thu, 16 Nov 2017 02:29:43 +0000 (11:29 +0900)]
Revert "ctxpopup: fix 'more' style problem. remove white space, fix landscape and size bug"

This reverts commit 7c35cdd837100ff1762e1482201b7a92e224d7dc.

Signed-off-by: JinYong Park <j4939.park@samsung.com>
Change-Id: If3d6c64811676655bbaab1ecbf25ba313070aa64

7 years agorename .gbs.conf to gbs.conf.bak temporarily 87/159987/1 accepted/tizen/unified/20171116.060656 submit/tizen/20171115.071100
Youngbok Shin [Tue, 14 Nov 2017 04:49:19 +0000 (13:49 +0900)]
rename .gbs.conf to gbs.conf.bak temporarily

There was a build failure issue with the latest gbs (0.24.9).
I found removing .gbs.conf will fix the issue.
Also, modifying upstream_branch's value "upstream" to
"origin/upstream" or "origin/tizen" etc will fix it, too.

I don't know which way is correct way to fix this issue.
To keep history of this file, I just rename it.
So, you can use gbs 0.24.9 to build the packages.

@tizen_fix

Change-Id: I668f5c6aa0bff1e1fc5cbd5d8600f87335e30844

7 years agoRemove invalid link for examples 35/159735/1
Myoungwoon Roy, Kim [Mon, 13 Nov 2017 00:36:54 +0000 (09:36 +0900)]
Remove invalid link for examples

Change-Id: Idff895c2ec25d1aa0a6b777fc6b6200c46ecd269

7 years agoSuppress build warning message 28/159028/6
Shinwoo Kim [Mon, 6 Nov 2017 12:20:06 +0000 (21:20 +0900)]
Suppress build warning message

Change-Id: I320984158df1ad037005472c40451546d4e9ea3a

7 years agoelm_panel: show and hide necessary object when scrollable is set 21/159421/1
Jeonghyun Yun [Thu, 9 Nov 2017 01:19:17 +0000 (10:19 +0900)]
elm_panel: show and hide necessary object when scrollable is set

@tizen_fix

Change-Id: I229f9872551a5ba656c9fd91a1f62b34db282824
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
7 years agoatspi: use correct object for highlight_grabbing 75/158375/3 accepted/tizen/unified/20171108.063507 submit/tizen/20171107.093719
Shinwoo Kim [Tue, 31 Oct 2017 10:54:04 +0000 (19:54 +0900)]
atspi: use correct object for highlight_grabbing

elm_object_accessibility_highlight_set is using VIEW object as a "target"
object for the ELM_WIDGET_ITEM_CLASS object. And the "target" object is used
for all highlight related lines in the elm_win including highlight_grabbing.

So when the elm_widget sets highlight_grabbing for the ELM_WIDGET_ITEM_CLASS
object, the VIEW object should be used.

Change-Id: I6bd1e40e69883e81f968ea82a6a48be9204206d2

7 years agoElm_Entry: Add annotation to unnamed enum 85/158185/4 accepted/tizen/unified/20171102.061557 submit/tizen/20171101.082936
JinYong Park [Mon, 30 Oct 2017 08:35:35 +0000 (17:35 +0900)]
Elm_Entry: Add annotation to unnamed enum

Summary

There are unnamed enumeration in Elm_Entry,
so add annotation and names like D5376 (https://phab.enlightenment.org/D5376)

https://phab.enlightenment.org/D5401

Change-Id: I3cf2f8ebb5357e2b1e63ebae6fc340cfe4511d20
Signed-off-by: JinYong Park <j4939.park@samsung.com>
7 years agofix \textwidth doxygen warning 05/158305/1
JinYong Park [Tue, 31 Oct 2017 04:41:43 +0000 (13:41 +0900)]
fix \textwidth doxygen warning

Change-Id: I980dd615fb909b32fcdc78634b5e0cd7bbfcb011
Signed-off-by: JinYong Park <j4939.park@samsung.com>
7 years agoimage, gesture_layer, glview: remove doxygen warnings 50/157650/5
Youngbok Shin [Wed, 25 Oct 2017 12:04:27 +0000 (21:04 +0900)]
image, gesture_layer, glview: remove doxygen warnings

- Remove warning messages caused by referencing to internal API.
- Add missing parameter descriptions.
- Put a space between ref keyword and colon character.

Change-Id: Ia5f09f68250e45b6fd7b5b16189907ca46df858a

7 years agoelementary index: fix wrong reference in its header document 59/158059/2
Youngbok Shin [Fri, 27 Oct 2017 11:48:25 +0000 (20:48 +0900)]
elementary index: fix wrong reference in its header document

Summary:
elm_index.h uses legacy keyword for ref tag.
The patch update each keywords for widgets.
And colon ":" character should be seperated from reference keyword.
It will remove doxygen warning messages from elm_index.h file.

Test Plan: N/A

Reviewers: cedric, raster, jpeg

Differential Revision: https://phab.enlightenment.org/D5387

Change-Id: I9623cac2f1a5e9f312df004ef96e61ff9a0d5f3b

7 years agodoc: fixed warnings caused by "@ref Scroller" 11/158111/1
Jaeun Choi [Mon, 30 Oct 2017 01:34:21 +0000 (10:34 +0900)]
doc: fixed warnings caused by "@ref Scroller"

Change-Id: I2058381f8292215c927d63ac44550928899fe572

7 years agoelm_entry: add missing parameter description (upstream merged) 43/157943/2
JinYong Park [Fri, 27 Oct 2017 02:49:28 +0000 (11:49 +0900)]
elm_entry: add missing parameter description (upstream merged)

Summary : Add missing parameter description to remove doxygen warning

Test Plan : API Doxygen Revision

https://phab.enlightenment.org/D5389

Change-Id: Ie95de1c8a9dcb74a42c726a0c184e0aee3fbc520
Signed-off-by: JinYong Park <j4939.park@samsung.com>
7 years agoelm_config: add missing parameter description (upstream merged) 42/157942/2
JinYong Park [Fri, 27 Oct 2017 02:47:11 +0000 (11:47 +0900)]
elm_config: add missing parameter description (upstream merged)

Summary : Add missing parameter description to remove doxygen warning

Test Plan : API Doxygen Revision

https://phab.enlightenment.org/D5390

Change-Id: I018b91808e4b90a86f2e0d879f827b1ed31a193a
Signed-off-by: JinYong Park <j4939.park@samsung.com>
7 years agoelm_box: add missing parameter description (upstream merged) 38/157938/1
JinYong Park [Fri, 27 Oct 2017 02:43:48 +0000 (11:43 +0900)]
elm_box: add missing parameter description (upstream merged)

Summary : Add missing parameter description to remove doxygen warning

Test Plan : API Doxygen Revision

https://phab.enlightenment.org/D5391

Change-Id: I0cbe075630d978859245984ee8e4440b31d115e5
Signed-off-by: JinYong Park <j4939.park@samsung.com>
7 years agoadd doxygen description from upstream 94/157794/4
JinYong Park [Thu, 26 Oct 2017 08:35:41 +0000 (17:35 +0900)]
add doxygen description from upstream

Change-Id: I7b9bc81bb9f71973046b2e358cc520fa69c85305
Signed-off-by: JinYong Park <j4939.park@samsung.com>
7 years agoelm_bg_legacy: add missing parameter description 95/157795/1
JinYong Park [Thu, 26 Oct 2017 08:42:18 +0000 (17:42 +0900)]
elm_bg_legacy: add missing parameter description

Summary : Add missing parameter description to remove doxygen warning

Test Plan : API Doxygen Revision

https://phab.enlightenment.org/D5388

Change-Id: Ic73b7983a8d22f261f8182edfc4d82ab7da7697b
Signed-off-by: JinYong Park <j4939.park@samsung.com>
7 years agoAdd return type description (from opensource) 48/157748/1
JinYong Park [Thu, 26 Oct 2017 05:42:51 +0000 (14:42 +0900)]
Add return type description (from opensource)

Change-Id: I61e5e2167d744852c05ecf6cfac5dc2acff993e5
Signed-off-by: JinYong Park <j4939.park@samsung.com>
7 years ago[elm_deprecated] add param, return type description 36/157736/1
JinYong Park [Thu, 26 Oct 2017 04:55:17 +0000 (13:55 +0900)]
[elm_deprecated] add param, return type description

Change-Id: Iadfb4dc387f54955e983101681322ebb72f58fd5
Signed-off-by: JinYong Park <j4939.park@samsung.com>
7 years agoEnhacne documentation 85/157085/2 accepted/tizen/unified/20171027.152008 submit/tizen/20171025.103743 submit/tizen/20171026.050851
Shinwoo Kim [Mon, 23 Oct 2017 08:53:39 +0000 (17:53 +0900)]
Enhacne documentation

- elm_win.eo

Change-Id: Idd209c7f17ea5e5be362be5a92c18c7fc2487a62

7 years agodoc: fix textwidth parameter 37/157337/2
Thiep Ha [Tue, 24 Oct 2017 06:22:28 +0000 (15:22 +0900)]
doc: fix textwidth parameter

Change-Id: I6e645c1fd7fca043c79ac9ffee8a51749163e787

7 years agodoc: add missing parameters and fix references for some elm widgets 34/157334/2
Thiep Ha [Tue, 24 Oct 2017 06:13:07 +0000 (15:13 +0900)]
doc: add missing parameters and fix references for some elm widgets

Change-Id: Iced4250100d557e0fd180f554683558f3c8e93dc

7 years agoFix documentation warning. 24/157324/1
Woochan Lee [Tue, 24 Oct 2017 07:31:08 +0000 (16:31 +0900)]
Fix documentation warning.

@tizen_fix

Change-Id: I4ad34b704f64e3382ca6d52852715c5a16f1c844

7 years agoelm_url: matched between url and proxy environment 17/157217/1
Jeonghyun Yun [Mon, 23 Oct 2017 11:44:18 +0000 (20:44 +0900)]
elm_url: matched between url and proxy environment

@tizen_fix

Change-Id: Ic46db15739a1c86d39b223aa47cf114d52419f3e
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
7 years agoatspi: fix name, description callback issue 16/156816/2
Shinwoo Kim [Fri, 20 Oct 2017 05:51:28 +0000 (14:51 +0900)]
atspi: fix name, description callback issue

The accessible name, description callback did not work for the naviframe item.
Because the naviframe item has used VIEW object for its accessible object.
If user calls elm_atspi_accessible_name_cb_set(naviframe_item, cb, data),
then the callback cb should set to VIEW object, not naviframe item, because
atspi_accessible_name_get is using the VIEW object.

Change-Id: I8b0d25d36b8e66a45a3757efa900ff9082d6fbf3

7 years ago[Accessibility]: Access frame going behind popup issue fix when popup is created... 64/156764/3
Shilpa Singh [Wed, 18 Oct 2017 13:31:04 +0000 (19:01 +0530)]
[Accessibility]: Access frame going behind popup issue fix when popup is created in transition,finished callback.

Change-Id: I4e4bdf9c7ce6bd9528311319119c5f8c9e287d17

7 years agoatspi : Do not send signal, if current object and highlight object are same 27/156827/4
JunsuChoi [Fri, 20 Oct 2017 05:28:18 +0000 (14:28 +0900)]
atspi : Do not send signal, if current object and highlight object are same

Change-Id: I3ef37909e674496be0b96beee33a5b5b75c1abac

7 years agoatspi: fix translation domain for naviframe item 65/156765/2
Shinwoo Kim [Fri, 20 Oct 2017 01:12:19 +0000 (10:12 +0900)]
atspi: fix translation domain for naviframe item

The naviframe item have used its VIEW object for accessible name and
description. But the naviframe item did not care about the translation
domain. So there was a translation problem.

Change-Id: I3163f4b078a62c82686806f265487c9a3082abc9

7 years agoelm_scroller: fix scrolling with key move 31/156531/1 accepted/tizen/unified/20171025.075156 submit/tizen/20171020.120936
Jeonghyun Yun [Wed, 18 Oct 2017 22:48:46 +0000 (07:48 +0900)]
elm_scroller: fix scrolling with key move

Use content_region_show instead of content_pos_set in _key_action_move

Summary:
When user keep pressing key down or else on scroller content, scroller
animation is lagging because of elm_interface_scrollable_content_pos_set
by step_x or step_y value.  When focus moved to next object by press key
down or else, content_pos_set by ecore_animator continuously.  In this
time, content_pos_set in _key_action_move by step_x or step_y value
caused animation lagging problem.  I fixed to use content_region_show
instead of content_pos_set in _key_action_move for remove exist
animator.

Test Plan:
1. elementary_test -> Scroller3
2. Press 3 times "Append 10 Items in 3s" button
3. focus to Item1 and keep pressing key_down

Reviewers: jpeg, woohyun

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5278

Change-Id: Ia112e52594ad1189fe767bcc7bb0c37a82bcc3e6
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
7 years agoatspi : Change default label append of popup from show_finish_cb to on_show 83/156483/2
JunsuChoi [Fri, 13 Oct 2017 03:13:31 +0000 (12:13 +0900)]
atspi : Change default label append of popup from show_finish_cb to on_show

   show_finish_cb is called after animation of popup has finished.
   default label time limit for screen-readers is 0.3 seconds.
   Default label does not work if animation does not finish in 0.3 seconds
   So change it so that it can be processed by smart show.

Change-Id: I8df4833662d7252ded0ab2912e337d59d2f45ad3

7 years agoEnhance documentation 02/156402/3
Shinwoo Kim [Tue, 17 Oct 2017 02:23:21 +0000 (11:23 +0900)]
Enhance documentation

- elm_entry.eo
- elm_flip.h
- elm_flipselector.h
- elm_config.h
- elm_focus.h
- elm_gen.h
- elm_object.h
- elm_genlist.eo
- elm_genlist.h
- elm_grid.eo
- elm_icon.h
- elm_image.h
- elm_image_legacy.h
- elm_index.h

Change-Id: Ic82c977595f8819f53552b38174815e06268952b

7 years agoelm_map: fix copyright scalability issue 89/123289/6
Sungtaek Hong [Wed, 5 Apr 2017 06:43:33 +0000 (15:43 +0900)]
elm_map: fix copyright scalability issue

 - Since copyright may have long text, the text cannot be shown properly
   in low resolution.

@tizen_fix

Change-Id: I063b386bf4ec2c4b8a1f29d7d3cbff6abed9802e
Signed-off-by: Sungtaek Hong <sth253.hong@samsung.com>
7 years agoatspi: not use destructed eo object 56/155856/3
Shinwoo Kim [Mon, 16 Oct 2017 06:58:56 +0000 (15:58 +0900)]
atspi: not use destructed eo object

It is possible to access destructed eo object using ATSPI interface.
The following sequence is possilbe, because AT-client such as screen-reader
does not know whether a widget object deleted or not.

1. _elm_radio_evas_object_smart_del
2. _elm_radio_elm_interface_atspi_accessible_state_set_get

So before using eo interface, we have to check if the eo object is vlid or
not using eo_destructed_is.

Change-Id: I7ffaf7bd905dcc2ef5770d9c1cef9de52ec77322

7 years agoelm_box: fix a potential null pointer dereferencing in elm_box 39/154439/3
Wonki Kim [Tue, 10 Oct 2017 07:56:44 +0000 (16:56 +0900)]
elm_box: fix a potential null pointer dereferencing in elm_box

Summary:
if 'evas_object_smart_data_get' return null somehow,
logic that dereference the smart data pointer will cause problems.
This patch prevent a potential bug in advance.

Reviewers: jpeg, woohyun, cedric

Differential Revision: https://phab.enlightenment.org/D5290

Change-Id: I3bb685468cc3bdf44bddff1c51988f8ab37e7627
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
7 years agoexamples: remove doxygen warning messages 24/156024/2
Youngbok Shin [Tue, 17 Oct 2017 04:02:43 +0000 (13:02 +0900)]
examples: remove doxygen warning messages

It only remove warning messages which don't need example files.

Change-Id: Ia152012a0a197d7cc0472fefddeeccc090300f0f

7 years agoRemove @ref for Start 91/154691/2
Myoungwoon Roy, Kim [Wed, 11 Oct 2017 05:40:10 +0000 (14:40 +0900)]
Remove @ref for Start

Change-Id: I88ca7a1f5888c6090ecaf9d49ed7277595dcae74

7 years agoSpinner: Fix can't input number in case of min value is bigger than 1. 28/154528/2
Woochan Lee [Tue, 10 Oct 2017 10:57:59 +0000 (19:57 +0900)]
Spinner: Fix can't input number in case of min value is bigger than 1.

Min Max validate logic has been changed to support decimal point counting.
It makes this side effect.

Change-Id: Iede1a1ee48b60680387a770eaecd68a499d9eed4

7 years agoatspi : During the highlight grab, out signal is not sent. 72/155372/2
JunsuChoi [Wed, 11 Oct 2017 03:12:45 +0000 (12:12 +0900)]
atspi : During the highlight grab, out signal is not sent.

   There is an action that takes time to complete
   the highlight grab, such as scroll bring in.
   So the highlight box can be outside the screen.
   After the highlight grab process is completed,
   will check the highlight box status.

Change-Id: I7c6b92aebf2ab0f04ec833aa701e9705208d9671

7 years agoatspi : Do not center align when genlist item is highlighted in wearable profile 76/154976/4
JunsuChoi [Wed, 11 Oct 2017 13:09:14 +0000 (22:09 +0900)]
atspi : Do not center align when genlist item is highlighted in wearable profile

Change-Id: Ie6f5d80b5dc100ba1fc7af84607cefa3bb15939b

7 years agoatspi : Add check for chain end object with attribute 69/154969/2
JunsuChoi [Wed, 13 Sep 2017 03:04:42 +0000 (12:04 +0900)]
atspi : Add check for chain end object with attribute

   When searching for a neighbor object,
   check whether there is an "relation_chain_end" attribute.
   If it does, it returns the current object.

Change-Id: If84cd1fd0176e16b7a5ac79f60411491cc15c952

7 years agoatspi : Remove role check when getting an accessible object to a point. 72/154972/2
JunsuChoi [Fri, 29 Sep 2017 04:10:39 +0000 (13:10 +0900)]
atspi : Remove role check when getting an accessible object to a point.

Change-Id: Iae21fb219f39cb6b0acd088d50ae3ef5fe143869

7 years agoatspi: Improves how to find the can_highlight of the widget. 73/154973/2
JunsuChoi [Fri, 29 Sep 2017 11:55:32 +0000 (20:55 +0900)]
atspi: Improves how to find the can_highlight of the widget.

   Returns EINA_FALSE if any of parents is EINA_FALSE
   when determining can_highlight.
   To determine can_highlight for the parent of an object,
   we try to find the parent of the parent again.
   As it repeats, it traverses as much as depth size factorial (d!)
   However, if any of the parent of the object has can_highlight of the widget data is EINA_FALSE,
   it is eventually EINA_FALSE

Change-Id: I0b6d2907aaf4c4778519dd56232d126249fe636f

7 years agoelm_image: stop preloading before intenal_file_set as it may hit to-be-freed memory 35/154635/2 submit/tizen/20171012.123430
Jeonghyun Yun [Wed, 11 Oct 2017 01:45:57 +0000 (10:45 +0900)]
elm_image: stop preloading before intenal_file_set as it may hit to-be-freed memory

Change-Id: I8df88ac5736058983a5c3db1addd573402b214bc
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
7 years agoadd return check for eldbus 13/153713/3
JunsuChoi [Fri, 29 Sep 2017 07:35:41 +0000 (16:35 +0900)]
add return check for eldbus

Change-Id: I366df41ee38dc29ab5a9448e378e4a2064bac7cd

7 years agoatspi: use detail value of window activated signal 46/153846/1
Shinwoo Kim [Mon, 25 Sep 2017 13:57:02 +0000 (22:57 +0900)]
atspi: use detail value of window activated signal

The detail value of window activated signal is using for following cases

(1) support "default_label" attribute of window
(2) notify existing keyboard window.
The keyboard window would exist always, once it shows.
So if screen-reader turns off, and turn on again, there was no ATSPI signal.
We are using 'activate' signal for this case to get the reference of
keyboard window. And we are using detail value to reduce a call of IPC.

Change-Id: I11db347b89f283ad2ab7fd5378ca123948dbbaf5

7 years agoatspi: win overrides atspi component get interface 45/153845/1
Shinwoo Kim [Sat, 23 Sep 2017 13:34:52 +0000 (22:34 +0900)]
atspi: win overrides atspi component get interface

(1) The efl_ui_win overrides _elm_interface_atspi_component_extents_get to give
correct value if screen_coord is EINA_FALSE which means relative position.
The efl_ui_win has given its object geometry value + ecore evas geometry value.
The object geometry value was equal to the ecore evas geometry value, so the
relative position was not correct(twice of ecore evas geometry value).

(2) Allow ELM_ROLE_INPUT_METHOD_WINDOW to send signal

Change-Id: I1b6832e960b3123d2a817d6253313447bc31af08

7 years agoatspi: make datetime itself unacceptable object 44/153844/1
Shinwoo Kim [Wed, 27 Sep 2017 09:30:06 +0000 (18:30 +0900)]
atspi: make datetime itself unacceptable object

This depends on UI definition. The datetime itself does not have highlight.
Only each part objects such as inc/dec button, year, month, and day in it.

Change-Id: I6a14dec2a24ee280ad19fa885acec0992acc9400

7 years agoatspi: fix infinite loop issue 43/153843/1
Shinwoo Kim [Wed, 20 Sep 2017 04:14:27 +0000 (13:14 +0900)]
atspi: fix infinite loop issue

It is possilbe to get a target object as a return value of get_object_at_point.
In this case _elm_widget_elm_interface_atspi_component_accessible_at_point_get
works again with the target which is same with root object.

[Enhanced]
- We do not have to go parent if the bottom up logic meets root object.
- Visiblity of panel is always true. So we are checking its SHOWING state.
  If the panel is not SHOWING, remove it from valid children list.

Change-Id: I2edeefdc9a0c5955f1c28926321b74424c71bc40

7 years agoatspi: set elm_access layer to MAX 42/153842/1
Shinwoo Kim [Fri, 29 Sep 2017 05:28:21 +0000 (14:28 +0900)]
atspi: set elm_access layer to MAX

Set access object layer to max, because the highlight frame could be covered
by other object which has higher layer.

Change-Id: I16e54469f0c749fb2caab6da9ea68b8dc97d9b02

7 years agoelementary: atspi - fix dbus abort 41/153841/1
Shinwoo Kim [Thu, 28 Sep 2017 11:46:44 +0000 (20:46 +0900)]
elementary: atspi - fix dbus abort

This patch set fix following abort occured on dbus side.

(gdb) bt
0   __GI_raise (sig=sig@entry=6)
1   __GI_abort ()
2   _dbus_abort ()
3   _dbus_warn_check_failed
4   dbus_message_iter_append_basic
5   append_basic
6   eldbus_message_iter_basic_append
7   _bridge_signal_send
8   _text_text_removed_send
9   _bridge_accessible_event_dispatch
10  _elm_interface_atspi_accessible_event_emit
11  elm_interface_atspi_accessible_event_emit
12  _entry_changed_user_signal_cb

(gdb) f 12
(gdb) p *$1
$2 = {change = {insert = {content = 0x0, pos = 0, plain_length = 1},
                del = {content = 0x0, start = 0, end = 1}},
      insert = 0 '\000', merge = 0 '\000'}

The following patch set would fix the root cause of this problem.
https://phab.enlightenment.org/D5240

Change-Id: Ifea8c2fead631f06b7d54ce9a6517f795b3cbf06

7 years agoatspi: block event which is not interested in 40/153840/1
Shinwoo Kim [Sat, 23 Sep 2017 08:42:55 +0000 (17:42 +0900)]
atspi: block event which is not interested in

The following ATSPI dbus signal is not interested in.
Moreover the following ATSPI dbus signal occurs a lot at init time.
This could cause a performance issue.

 - 'ChildrenChanged' with added child
 - 'ChildrenChanged' with deleted child
 - 'AddAccessible'
 - 'RemoveAccessible'

Change-Id: Iebfb4ef75b5f32bf025e275dd9b548bd3581b2de

7 years agoatspi: support "default_label" attribute of window 39/153839/1
Shinwoo Kim [Thu, 21 Sep 2017 07:40:49 +0000 (16:40 +0900)]
atspi: support "default_label" attribute of window

Wearable profile application does not want to use default label functionality
because it is hard to meet application UI definition.
So if the window has attribute "default_label" key, and its "disabled" value,
then screen-reader does not read out default label, and does not clear
currently highlight object.

Application should append attribute as below.

elm_atspi_accessible_attribute_append(window, "default_label", "disabled");

This patch set works with following patch set.

https://review.tizen.org/gerrit/151570 (screen-reader)

Change-Id: I354c6ecf30db3a0011658d69577ad384fcb900db

7 years agoatspi: Handle default label object on toolkit side 38/153838/1
Shinwoo Kim [Tue, 19 Sep 2017 11:28:12 +0000 (20:28 +0900)]
atspi: Handle default label object on toolkit side

There are unexpected difficult cases to make default label work correctly.
The following would be the case.

(top of accessible tree) - (bottom side)
PageTab1 - Panel1 - PageTab2 - Panel2  -  PageTab3 - Panel3(currently showing)

Application could make as below:
PageTab1 - Panel1 - PageTab3 - Panel3  -  PageTab2 - Panel2(currently showing)

or following tree would normally be possilbe:
PageTab1 - Panel1 - PageTab2 - Panel2(currently showing)

There are much of complicated case over there.
So we are handling the default label object stack on toolkit(Elementary) side.

Please refer to following patch set:
https://review.tizen.org/gerrit/#/c/151025/ (at-spi2-core)
https://review.tizen.org/gerrit/#/c/151030/ (screen-reader)

Change-Id: I0834f9d0625f4e787d6315ce4858bdec4a67ab18

7 years agoatspi: clear current highlighted object 41/151041/3
Shinwoo Kim [Fri, 15 Sep 2017 10:14:19 +0000 (19:14 +0900)]
atspi: clear current highlighted object

The _elm_win_screen_reader does not clear current highlighted object when the
screen reader is disabled. It tried to clear window highlight even though the
window does not have highlight.

Change-Id: Icc5de54361852c0210c0640f2801483f6a2c6468

7 years agoatspi: enhance line related to highlight frame 42/151042/3
Shinwoo Kim [Sat, 16 Sep 2017 08:09:33 +0000 (17:09 +0900)]
atspi: enhance line related to highlight frame

1. Before elm_widget_theme_object_set for a11y highlight frame was called in
 _elm_win_accessibility_highlight_show which is called in highlighted object
 move, resize callback.

2. Before evas_object_smart_changed was not called even though a11y highlight
 frame is added as a smart member of highlighted object.

※ Refer to commit: c3b5da9 (atspi: make highlight frame be a smart member)

Change-Id: I1f5dc367d2fc5565d61ae12d44fb1e8a49eeb979

7 years agoelementary: fix memory leaks when using elm_prefs 46/153446/1
Youngbok Shin [Thu, 28 Sep 2017 10:41:56 +0000 (19:41 +0900)]
elementary: fix memory leaks when using elm_prefs

"regex" is heap-allocated and is not handled by regfree().
We must explicitely call free() after a regfree() to remove
the regex_t from memory.

Change-Id: Ib278f4bd49b6246b7d6eaf7f646dd1c36aca4419
Author: Jean Guyomarc'h <jean@guyomarch.bzh>
Date:   Fri Aug 12 16:36:12 2016 +0200

7 years agoentry: fix memory leak issue for atspi 28/153428/2
Youngbok Shin [Thu, 28 Sep 2017 10:13:05 +0000 (19:13 +0900)]
entry: fix memory leak issue for atspi

@tizne_fix

Change-Id: Ib7820537a74b504939c78848b03cf5f644e49970

7 years agoelm_win: prevent Null pointer ref. 93/153293/3
Woochan Lee [Thu, 28 Sep 2017 07:47:06 +0000 (16:47 +0900)]
elm_win: prevent Null pointer ref.

_elm_config could be null. in case launch the app using app_launch command in shell.

@tizen_fix

Change-Id: I27006548a32c56fffd6ff9aea98941b5e6036593

7 years agoelm_need_efret() - improve error handling according to coverity 65/153265/1
Hosang Kim [Thu, 28 Sep 2017 07:05:21 +0000 (16:05 +0900)]
elm_need_efret() - improve error handling according to coverity

fix CID 1360466, CID 1353589

we don't actually chekc if efreet inits right with elm_need_efreet()
as we just assume it inits (And there pretty much is no case where it
will not), but make coverity happy and check.

@fix
Change-Id: Ieb37ab35a6ebc3a7e30b9fd5be6bb0e5b06aa64f

7 years agoelm dbus menu - handle return value of eldbus_message_iter_arguments_get 51/153251/2
Hosang Kim [Thu, 28 Sep 2017 06:40:44 +0000 (15:40 +0900)]
elm dbus menu - handle return value of eldbus_message_iter_arguments_get

handle possible error return of eldbus_message_iter_arguments_get()
according to coverity CID 1353591. this should fix that.

Change-Id: I213f644c6450e550f5a26fd9a0c11a707d71f94a

7 years agoelm_config: add since_tizen tags for language auto mirrored functions 56/153256/2
Taehyub Kim [Thu, 28 Sep 2017 06:02:45 +0000 (15:02 +0900)]
elm_config: add since_tizen tags for language auto mirrored functions

Change-Id: I855d620001346327358fffaa25f8073611b2fe5e

7 years agoelm_interface_atspi_accessible: modified since_tizen tags for relationships clear 54/153254/1
Taehyub Kim [Thu, 28 Sep 2017 05:56:20 +0000 (14:56 +0900)]
elm_interface_atspi_accessible: modified since_tizen tags for relationships clear

Change-Id: I772ca0b888cba32ed9d1b99ccddad6c9cc12ca1a

7 years agoadd color for build message(error:red, warning:ylw) 37/152237/2
JunsuChoi [Mon, 25 Sep 2017 09:58:23 +0000 (18:58 +0900)]
add color for build message(error:red, warning:ylw)

Change-Id: I6fe5cf69b56d99085fa2b8655e96e0c8121cd8ef

7 years agoelm image: Fix async open to avoid multiple mmap 90/151290/2 accepted/tizen/unified/20170929.081254 submit/tizen/20170928.042726
jiin.moon [Wed, 20 Sep 2017 10:18:07 +0000 (19:18 +0900)]
elm image: Fix async open to avoid multiple mmap

 From cb3b4cc8d7794bea575a85325c8a58f25f0507b2 Mon Sep 17 00:00:00 2001
 From: Jean-Philippe Andre <jp.andre@samsung.com>
 Date: Fri, 15 Sep 2017 14:39:14 +0900
 Subject: [PATCH] elm image: Fix async open to avoid multiple mmap

 Reported by @jiin.moon:

 In case of async_open for an elm_image, we try and open a file in a
 thread, then map it and populate a bit, as this may take some time
 (blocking I/O). This creates a mmap with eina_file_map_new. But later
 evas image loaders will (usually) try and map the entire file with
 eina_file_map_all() which creates another mmap. Since the size is
 different (32Kb first then all) the returned map might be different
 (it's up to the kernel to decide at this point).

 So, in order to avoid having multiple maps on the same file, and try to
 reduce the peak memory usage, we should prefer using the same map all
 the time, i.e. the global one returned by eina_file_map_all().

 This patch relies on the previous patch in eina_file which fixes
 eina_file_map_populate() for the global map.

 @fix

Change-Id: If27d42b89269493ac2425737198338689687459d

7 years agointerface_scrollable: Cast result of divide explicitly 28/148828/2 submit/tizen/20171012.121301
Wonki Kim [Mon, 11 Sep 2017 04:12:57 +0000 (13:12 +0900)]
interface_scrollable: Cast result of divide explicitly

cast from double to int explicitly to remove smell of code

Change-Id: Ic02d3c24f212be1d71ecb5a8b0e923795e8296d3
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
7 years agogenlist & gengrid : fix build warnings 57/151657/2
SangHyeon Jade Lee [Thu, 21 Sep 2017 10:52:33 +0000 (19:52 +0900)]
genlist & gengrid : fix build warnings

Change-Id: Ia356f41294f8e0bb84446699a7de87757d1b23b3
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
7 years agoels_tooltip: Fix to use some functions before tooltip_test_set or tooltip_content_cb_set 01/151101/1
Jeonghyun Yun [Wed, 20 Sep 2017 01:02:56 +0000 (10:02 +0900)]
els_tooltip: Fix to use some functions before tooltip_test_set or tooltip_content_cb_set

Summary:
If user call tooltip_orient_set or tooltip_style_set or tooltip_window_mode_set
before tooltip_test_set or tooltip_content_cb_set, those functions doesn't work.
Because elm_tooltip will be created when tooltip_content_cb_set is called.
I fixed logic to use some functions before tooltip_test_set or tooltip_content_cb_set.

Test Plan: elementary_test -> Popups -> Tooltip

Reviewers: jpeg, Jaehyun

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5183

Change-Id: Ia058679cd1645a12e048d8c5b0db0566f2742fca
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
7 years agoelm_conform: consider window's geometry while reflecting keyboard conformant geometry 35/150235/1 accepted/tizen/unified/20170921.072252 submit/tizen/20170920.082902
Doyoun Kang [Fri, 15 Sep 2017 00:30:21 +0000 (09:30 +0900)]
elm_conform: consider window's geometry while reflecting keyboard conformant geometry

There was a bug that the partial window was resized when the keyboard was shown on landscape mode.
So, we add code to consider window's geometry while calculating conformant's geometry.

Change-Id: Iaa895335ddbc78697044f6712e7477317f4d3758

7 years agoatspi: enhance _accessible_at_point_get 95/149995/2 submit/tizen/20170915.074959
Shinwoo Kim [Wed, 13 Sep 2017 12:34:44 +0000 (21:34 +0900)]
atspi: enhance _accessible_at_point_get

The _elm_widget_elm_interface_atspi_component_accessible_at_point_get is
seaching accessible object from bottom of tree.

If elm_popup, or elm_panel comes as a root object, then
the _elm_widget_elm_interface_atspi_component_accessible_at_point_get does not
search from bottom of tree.

To make seach logic consistent, we are using bottom-up approach first for both
elm_popup and elm_panel from this patch.

Change-Id: I2a31725e8ff69455b836d6f888e0b42695ad2af5

7 years agoelm_win: do deferred resize job first before calling rotation change callback 62/149562/4
Doyoun Kang [Tue, 12 Sep 2017 12:20:17 +0000 (21:20 +0900)]
elm_win: do deferred resize job first before calling rotation change callback

there was a bug that the elm_win didn't resize when an user called evas_object_resize
with previous width and height in "wm,rotation,changed" smart callback function.

Change-Id: I8ac58abbb51e4e4135ff742c1c8a77e0c246ac7d

7 years agoatspi: enhance _accessible_at_point_top_down_get 32/149332/1
Shinwoo Kim [Tue, 12 Sep 2017 05:44:39 +0000 (14:44 +0900)]
atspi: enhance _accessible_at_point_top_down_get

If there is only one valid child at point, then return it.
The evas_tree_objects_at_xy_get could not find proper object,
if application does not have well aligned objects.

This could be a role of application, but this patch set could solve somehow.

Change-Id: I6326a23b88904f6003a99e8b17885452890c7222

7 years agogenlist: re-focus on genlist in item focus set when sub-object was focused 12/146412/9
SangHyeon Jade Lee [Mon, 28 Aug 2017 10:55:05 +0000 (19:55 +0900)]
genlist: re-focus on genlist in item focus set when sub-object was focused

Change-Id: I6de90b593dc0e251bc401bdd245dcfb507a90a98
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
7 years agoatspi: enhance po file to translate "Alert" 83/148883/2
Shinwoo Kim [Mon, 11 Sep 2017 05:33:41 +0000 (14:33 +0900)]
atspi: enhance po file to translate "Alert"

There was no information to translate "Alert".

Change-Id: I339548b707d2d34df77dcc36774d0a4665854e63

7 years agoatspi: follow edje_entry logic to send anchor name 76/148876/2
Shinwoo Kim [Mon, 11 Sep 2017 05:29:46 +0000 (14:29 +0900)]
atspi: follow edje_entry logic to send anchor name

The edje_entry has logic remove unnecessary character.
The elm_entry is following the logic to give correct information.

Change-Id: I55114193d9b23117ddc8b9863c2b14741f42a215

7 years agoatspi: emit signal after atspi bridge is connected 70/148770/2
Shinwoo Kim [Sun, 10 Sep 2017 00:50:21 +0000 (09:50 +0900)]
atspi: emit signal after atspi bridge is connected

This patch set emitting popup SHOWING signal, and window ACTIVE signal after
the atspi bridge is connectted.

The SHOWING signal of popup does not work properly, if the popup shows before
the atspi bridge is not connected. In this case, the screen-reader cannot read
popup information. So the SHOWING signal should be emitted after the connection
is established.

The ACTIVE signal does not work properly in the following case.
There are two windows show in one process at the same time. In this case,
the ACTIVE signal was not emitted because window_activated_broadcast_needed is
set to EINA_FALSE. This would be a bug.

Change-Id: Ieb1883c94c2570fdb92b9770a1c20e7d95c27a60

7 years agoatspi : Fix "bring_in" of the genlist item in wearable profile 72/148672/2
JunsuChoi [Fri, 8 Sep 2017 09:13:05 +0000 (18:13 +0900)]
atspi : Fix "bring_in" of the genlist item in wearable profile

Change-Id: I440fa9e8583e6b8d0089c64c7d15bce717155ec1