platform/core/appfw/tpk-backend.git
4 years agoAdd description at help message for recovery test for clarification 12/233712/1
Junghyun Yeon [Mon, 18 May 2020 10:38:34 +0000 (19:38 +0900)]
Add description at help message for recovery test for clarification

Change-Id: I08f5c765b6586b42c8c67743c71af3cba9fad8a6
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
4 years agoFix build error 48/231748/1
Sangyoon Jang [Fri, 24 Apr 2020 05:14:07 +0000 (14:14 +0900)]
Fix build error

Change-Id: I38e9b2ab62dee51ca495b808adacb69aa6604ae3
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoFix minor coding rule 27/218827/5
Junghyun Yeon [Thu, 28 Nov 2019 10:05:14 +0000 (19:05 +0900)]
Fix minor coding rule

- Apply early-return policy.
- Print error while some boost API calling has failed.

Change-Id: I659e486fe6e7ed540497613470fa3c3a19d774e1
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
4 years agoFix ReadonlyUpdateInstallSteps base step name 55/230755/3
Ilho Kim [Tue, 14 Apr 2020 04:38:34 +0000 (13:38 +0900)]
Fix ReadonlyUpdateInstallSteps base step name

Relates :
- [app-installers]https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/230753/

Change-Id: Iccec6f1d54c48349197871064fc05c5bbf8f94a1
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoMove CrashTpkInstaller class to tpk-smoke-utils 58/228658/5
Sangyoon Jang [Tue, 24 Mar 2020 11:11:44 +0000 (20:11 +0900)]
Move CrashTpkInstaller class to tpk-smoke-utils

This class can be used at other test, such as smoke test of unified-installer.

Change-Id: Idf72e0c8533b5d70530d36684d7ec7c534627416
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoMake smoke utils as a library 04/228604/5
Sangyoon Jang [Tue, 24 Mar 2020 06:18:09 +0000 (15:18 +0900)]
Make smoke utils as a library

This tpk-smoke-utils library is used at smoke test of unified-installer.

Requires:
 - https://review.tizen.org/gerrit/c/platform/core/appfw/app-installers/+/228720

Change-Id: I342c1827141c3331459a2d752c133aa86ee408dd
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoAdd GetArchiveInfo 01/227301/5
Ilho Kim [Wed, 11 Mar 2020 06:02:26 +0000 (15:02 +0900)]
Add GetArchiveInfo

Requires :
- [app-installers]https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/228145/

Change-Id: I0fa47880207b598e7ae9ad6d4f87dadfdf529e96
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoRelease version 1.10.2 53/229753/1 accepted/tizen/unified/20200413.012249 submit/tizen/20200403.082852 submit/tizen/20200410.073851
Ilho Kim [Fri, 3 Apr 2020 06:44:45 +0000 (15:44 +0900)]
Release version 1.10.2

Changes:
 - Fix TpkArchiveInfo

Change-Id: Idfeaa8a620758ec0ce1fea7c0d0643c15219da12
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoFix TpkArchiveInfo 97/226597/6
Sangyoon Jang [Thu, 27 Feb 2020 03:30:33 +0000 (12:30 +0900)]
Fix TpkArchiveInfo

There is a new base class for TpkArchiveInfo.

Requires:
 - https://review.tizen.org/gerrit/c/platform/core/appfw/app-installers/+/226596

Change-Id: Icba15e406426f6e53f5be17e11e12269c54f8bc8
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoRelease version 1.10.1 06/226906/1 accepted/tizen/unified/20200309.031503 submit/tizen/20200306.075320
Ilho Kim [Fri, 6 Mar 2020 07:43:40 +0000 (16:43 +0900)]
Release version 1.10.1

Changes:
 - Add StepCrash's clean operation

Change-Id: I3f5b48bb158126856d4ef173f421ae121b4de425
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoAdd StepCrash's clean operation 02/226102/3
Ilho Kim [Thu, 27 Feb 2020 01:17:20 +0000 (10:17 +0900)]
Add StepCrash's clean operation

This patch can be used to test the installation termination in a clean operation

Change-Id: Iea285d4f6e66dc7104c00665c46a3295a91c8b93
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoRelease version 1.10.0 14/226114/1 accepted/tizen/unified/20200302.041955 submit/tizen/20200227.033434 submit/tizen/20200228.073402
Sangyoon Jang [Thu, 27 Feb 2020 03:32:19 +0000 (12:32 +0900)]
Release version 1.10.0

Changes:
 - Split rpm packaging into library part and backend part
 - Fix smoke test

Change-Id: Ie355e126c4ff2411ab42e2493d19586367f87f92
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoFix smoke test 50/225150/2
Ilho Kim [Tue, 18 Feb 2020 00:10:40 +0000 (09:10 +0900)]
Fix smoke test

Recovery check routine changed after the recovery file is created

Change-Id: Ie3641e07104ba1f4bc6e3ee7d7a6dc1396a3ed5d
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoSplit rpm packaging into library part and backend part 76/203976/19
Sangyoon Jang [Thu, 18 Apr 2019 08:44:39 +0000 (17:44 +0900)]
Split rpm packaging into library part and backend part

Change-Id: Icab87d25d042bfdd678395699eeb0df4bf766efa
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoRelease version 1.9.3 53/224953/1 accepted/tizen/unified/20200217.213833 submit/tizen/20200214.080724
Ilho Kim [Fri, 14 Feb 2020 07:54:36 +0000 (16:54 +0900)]
Release version 1.9.3

Changes:
 - Change clean operations not to return failure

Change-Id: I3e00c713fc5096e145e5ea07923be986f37bfd14
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoChange clean operations not to return failure 14/223114/3
Ilho Kim [Thu, 23 Jan 2020 01:41:29 +0000 (10:41 +0900)]
Change clean operations not to return failure

Change-Id: I586f5785661eaf8dd06c841656323066ba038113
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoRelease version 1.9.2 86/223586/1 accepted/tizen/unified/20200212.125959 submit/tizen/20200131.050227 submit/tizen/20200210.091657 submit/tizen/20200211.010149
Ilho Kim [Fri, 31 Jan 2020 04:33:19 +0000 (13:33 +0900)]
Release version 1.9.2

Changes:
 - Change the way to invoke installer as a subprocess
 - Add backup_type option for smoke test

Change-Id: I877ead97220c401331aac3743b5f63376653c11f
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoAdd backup_type option for smoke test 08/218508/11
Ilho Kim [Fri, 22 Nov 2019 02:26:03 +0000 (11:26 +0900)]
Add backup_type option for smoke test

Run smoke tests with argumant "--backup-type <move|copy>"
select backup's type 'move' or 'copy and remove'

Requires:
   - https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/217537/

Change-Id: Iebe9c6ef1f7e6c1d03753a78bf049ecc628197ee
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoChange the way to invoke installer as a subprocess 05/220005/12
Ilho Kim [Thu, 12 Dec 2019 04:28:32 +0000 (13:28 +0900)]
Change the way to invoke installer as a subprocess

Requires :
   [app-installers]https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/220004/

Change-Id: I18b51a7bdf85daeb1dad60178fa045bf40f85cad

4 years agoRelease version 1.9.1 13/222713/1 accepted/tizen/unified/20200120.133149 submit/tizen/20200117.084916
Ilho Kim [Fri, 17 Jan 2020 08:42:53 +0000 (17:42 +0900)]
Release version 1.9.1

Changes:
 - Resolve static analysis issue

Change-Id: Iecfadd443a627be00d0b2bf27bf408965ffa1407
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoResolve static analysis issue 32/222632/2
Junghyun Yeon [Fri, 17 Jan 2020 01:27:58 +0000 (10:27 +0900)]
Resolve static analysis issue

Change-Id: I0c532cc7ca55da09fcfc1bb661aa2b81387d2496
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
4 years agoRelease version 1.9.0 64/221764/1 accepted/tizen/unified/20200108.131457 submit/tizen/20200107.095413
Ilho Kim [Tue, 7 Jan 2020 08:59:39 +0000 (17:59 +0900)]
Release version 1.9.0

Changes:
 - Refactor recovery test tool
 - Fix adding steps using default steps

Change-Id: I182734cc16877d239f5979564cb0c18e43b053a2
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoFix adding steps using default steps 16/207216/17 submit/tizen_5.5/20200103.002242
Sangyoon Jang [Wed, 29 May 2019 10:06:01 +0000 (19:06 +0900)]
Fix adding steps using default steps

Requires:
 - https://review.tizen.org/gerrit/c/platform/core/appfw/app-installers/+/207215

Change-Id: Ibba0273f806b5c636b23a5bc7b9924b5a91758f7
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoRefactor recovery test tool 72/218972/4
Ilho Kim [Fri, 29 Nov 2019 06:59:33 +0000 (15:59 +0900)]
Refactor recovery test tool

- Use enum class, not typedef
- Use boost program options for parsing argument

Change-Id: I1d129ab935e65b3eda701135e732e45eba55180f
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoRelease version 1.8.14 10/220110/1 tizen_5.5_tv accepted/tizen/5.5/unified/20200105.221100 accepted/tizen/unified/20191216.222226 submit/tizen/20191213.074937 submit/tizen_5.5/20200103.003447
Ilho Kim [Fri, 13 Dec 2019 07:02:59 +0000 (16:02 +0900)]
Release version 1.8.14

Changes:
 - Add no backup option for smoke tests
 - Fix smoke-test functions for rollback cases
 - Change duplicated step name
 - Add test cases for updating shared data dir
 - Fix recovery test when recovery file doesn't exist

Change-Id: I399c3dc57ed93a34a84caf4b64247b24aba893cf
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoFix recovery test when recovery file doesn't exist 97/219197/3
Ilho Kim [Tue, 3 Dec 2019 05:21:09 +0000 (14:21 +0900)]
Fix recovery test when recovery file doesn't exist

If installer is terminated before creating the recovery file
The test should be skipped, not failed

Change-Id: I9df1d77f2848c5e975596b7d4085700f41a0d6d3
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoAdd test cases for updating shared data dir 92/218192/13
Sangyoon Jang [Tue, 19 Nov 2019 09:16:29 +0000 (18:16 +0900)]
Add test cases for updating shared data dir

Added:
 - RollbackTest.UpdateMode_SharedData: update case of shareddata -> non-shareddata
 - RollbackTest.UpdateMode_NonSharedData: update case of non-shareddata -> shareddata
 - SmokeTest.RecoveryMode_SharedData: recovery case of shareddata -> non-shareddata
 - SmokeTest.RecoveryMode_NonSharedData: recovery case of non-shareddata -> shareddata

Requires:
 - https://review.tizen.org/gerrit/c/platform/core/appfw/app-installers/+/218218

Change-Id: I078c5b1f907382b3ff88b42508678b772da48e13
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoChange duplicated step name 30/218830/2
Junghyun Yeon [Thu, 28 Nov 2019 11:10:18 +0000 (20:10 +0900)]
Change duplicated step name

Same step name exists on wgt-backend.

Change-Id: Iea12e8def08dd21e91302a602c82c1eb91881c97
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
4 years agoFix smoke-test functions for rollback cases 94/218094/8
Sangyoon Jang [Tue, 19 Nov 2019 09:17:04 +0000 (18:17 +0900)]
Fix smoke-test functions for rollback cases

Requires:
 - https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/218093

Change-Id: I456bfa94a24169384629b7c661dbdfff1a35f7de
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoAdd no backup option for smoke tests 84/218084/12
Ilho Kim [Tue, 19 Nov 2019 06:18:33 +0000 (15:18 +0900)]
Add no backup option for smoke tests

Run smoke tests with argument "--no-backup", backup is skipped

Change-Id: I83d58214b63f5528a0cc3c110cfa8554c5a0e544
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoRelease version 1.8.13 43/218543/1 accepted/tizen/unified/20191201.221516 submit/tizen/20191128.101053 submit/tizen_5.5/20191205.065343
Junghyun Yeon [Mon, 25 Nov 2019 08:21:47 +0000 (17:21 +0900)]
Release version 1.8.13

Changes:
 - Revert "Fix recovery test's failure"

Change-Id: I2b38f1ff3b7506464f2e2f0a631f8ff2e2ac7489
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
4 years agoRevert "Fix recovery test's failure" 60/218060/1
Sangyoon Jang [Tue, 19 Nov 2019 04:54:34 +0000 (13:54 +0900)]
Revert "Fix recovery test's failure"

This reverts commit c6435c86d25654408945b09f1ad48723b38aaa67.

PkgQuery should not be used directly.

Change-Id: Ie90b8087d092bdf6917e0ef7a48e674ab7f72c1f

4 years agoRelease version 1.8.12 68/217468/1 accepted/tizen/5.5/unified/20191118.084820 accepted/tizen/unified/20191115.083951 submit/tizen/20191112.050420 submit/tizen/20191114.120558 submit/tizen/20191115.055644 submit/tizen_5.5/20191112.065048 submit/tizen_5.5/20191114.121100 submit/tizen_5.5/20191115.055905
Ilho Kim [Tue, 12 Nov 2019 04:28:40 +0000 (13:28 +0900)]
Release version 1.8.12

Changes:
 - Move implementation of virtual functions which does nothing
 - Add capability and exec_label for recovery_test
 - Fix build warning
 - Change packages used in recovery test
 - Adjust order of steps
 - Fix coding rule
 - Modify recovery test to handle cleanup type

Change-Id: I057e2abcf8c6d8ab2963dd0c66f7b34ee42948d9
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoModify recovery test to handle cleanup type 34/217234/1
Ilho Kim [Fri, 8 Nov 2019 00:45:19 +0000 (09:45 +0900)]
Modify recovery test to handle cleanup type

When recovery file set cleanup, recovery package is updated
So in this case, it is necessary to compare updated content

-Reference
    [app-installers]https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/216457/

Change-Id: Id005fcb3ec495822c90e00f7fd4a396b31f9ff56
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix coding rule 23/217023/1
Junghyun Yeon [Tue, 5 Nov 2019 11:40:05 +0000 (20:40 +0900)]
Fix coding rule

Change-Id: Ia7c301b2ada2c3528d270cc064c8e06e52d390db
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoAdjust order of steps 29/216129/2
Ilho Kim [Mon, 21 Oct 2019 08:35:06 +0000 (17:35 +0900)]
Adjust order of steps

Revert from 'ca625dadda76259cec5543a2c4096e1d39fbc15f'

Change-Id: Iad1907e2eb583a769db2abbb16472c1558144b33
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoChange packages used in recovery test 71/216471/5
Ilho Kim [Fri, 25 Oct 2019 08:45:59 +0000 (17:45 +0900)]
Change packages used in recovery test

Increase the package size

Change-Id: Ie3723b4e431a9e0abce29669a0d4a60c9d1df0b4
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix build warning 53/216453/10
Ilho Kim [Fri, 25 Oct 2019 04:52:56 +0000 (13:52 +0900)]
Fix build warning

Warning that "deprecated conversion from string constant to 'char*'"

Change-Id: I358e41d668af069b79e40ff353f3ce62339a9654
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoAdd capability and exec_label for recovery_test 48/216448/2
Ilho Kim [Fri, 25 Oct 2019 04:08:21 +0000 (13:08 +0900)]
Add capability and exec_label for recovery_test

Install request requires some capability and smack label

Change-Id: I593a895d7f42009287497d76591b3582e6a6837e
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoMove implementation of virtual functions which does nothing 28/216728/1
Junghyun Yeon [Thu, 31 Oct 2019 07:49:52 +0000 (16:49 +0900)]
Move implementation of virtual functions which does nothing

Change-Id: I693a5cebff4b31ca013b765185f810837e36382b
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRelease version 1.8.11 88/214288/1 accepted/tizen_5.5_unified_mobile_hotfix tizen_5.5_mobile_hotfix accepted/tizen/5.5/unified/20191031.024132 accepted/tizen/5.5/unified/mobile/hotfix/20201027.084042 accepted/tizen/unified/20191011.080002 submit/tizen/20190920.015601 submit/tizen/20191001.095121 submit/tizen/20191002.002728 submit/tizen/20191011.034248 submit/tizen_5.5/20191031.000003 submit/tizen_5.5_mobile_hotfix/20201026.185103 tizen_5.5.m2_release
Ilho Kim [Fri, 20 Sep 2019 01:38:22 +0000 (10:38 +0900)]
Release version 1.8.11

Changes:
 - Fix StepTpkPatchIcons

Change-Id: Ic52a056a2e3b79e66a0b205cd62ab8b2f7a9b854
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix StepTpkPatchIcons 50/210950/5
Junghyun Yeon [Fri, 26 Jul 2019 07:25:20 +0000 (16:25 +0900)]
Fix StepTpkPatchIcons

- Fix coding rules.
- Fix possible static issue.
- Add error checking routines.

Change-Id: Ic7d8e7a3977a196c872cb55f8ec68116aeeb82ba
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRelease version 1.8.10 01/213001/1 accepted/tizen/unified/20190903.052631 submit/tizen/20190829.072413 submit/tizen/20190902.052445
Ilho Kim [Thu, 29 Aug 2019 07:10:26 +0000 (16:10 +0900)]
Release version 1.8.10

Changes:
 - Change order of StepRemoveTemporaryDirectory
 - Add recover test for crash after unzip

Change-Id: Ic646ecf3d9ac41725c0af63a54db364e6172e91b
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoAdd recover test for crash after unzip 37/212537/3
Ilho Kim [Thu, 22 Aug 2019 11:57:30 +0000 (20:57 +0900)]
Add recover test for crash after unzip

requires:
 - https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/212535/

Change-Id: I842ef743a815a4ff040c554e1795d3bc5d443b93
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoChange order of StepRemoveTemporaryDirectory 77/212677/1
Ilho Kim [Mon, 26 Aug 2019 05:32:10 +0000 (14:32 +0900)]
Change order of StepRemoveTemporaryDirectory

In case installation terminated after StepUnzip,
recovery file doesn't have pkgid,
and then StepParseManifest will return RECOVERY_DONE,
and temporary file doesn't be removed

Change-Id: I671090285767b7d2ecbe10e5f28e0772b14f18b1
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoRelease version 1.8.9 75/212275/1 accepted/tizen/unified/20190820.115020 submit/tizen/20190820.015710
Ilho Kim [Tue, 20 Aug 2019 01:36:36 +0000 (10:36 +0900)]
Release version 1.8.9

Changes:
 - Fix static analysis issue
 - Fix recovery test's failure
 - Add GetDependencyInfo at TPK archive info

Change-Id: Id5fa83dbc4f59f86d38588e3cb2d1ec72c34552f
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoAdd GetDependencyInfo at TPK archive info 15/211115/4
Junghyun Yeon [Tue, 30 Jul 2019 07:50:09 +0000 (16:50 +0900)]
Add GetDependencyInfo at TPK archive info

Related changes:
[slp-pkgmgr] : https://review.tizen.org/gerrit/211114
[pkgmgr-info] : https://review.tizen.org/gerrit/211111

Change-Id: I7c8fd6dcf8be0387c7fcd98f8018f0174044b873
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoFix recovery test's failure 54/211054/3
Ilho Kim [Mon, 29 Jul 2019 11:04:55 +0000 (20:04 +0900)]
Fix recovery test's failure

In testcase with repeat, PkgQuery has handle that made from singleton,
so there is a need to reset the singleton

Change-Id: If95e80525a7ed1763dc0bc58f3ca9086ce4652de
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix static analysis issue 69/211769/3
Ilho Kim [Fri, 9 Aug 2019 04:17:46 +0000 (13:17 +0900)]
Fix static analysis issue

Fix NULL Pointer dereference when memory allocation fails

Change-Id: Id988582b90da46dffb799ac17414b3e9b2a7cdd9
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoRelease version 1.8.8 11/211811/1 accepted/tizen/unified/20190812.235628 submit/tizen/20190809.084335
Ilho Kim [Fri, 9 Aug 2019 08:15:54 +0000 (17:15 +0900)]
Release version 1.8.8

Changes:
 - Implement recovery test for forced termination
 - Fix coding style

Change-Id: I6f0a0072f85b9824f38118f7725d883d8b4b6389
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix coding style 82/211182/2
Ilho Kim [Wed, 31 Jul 2019 03:28:12 +0000 (12:28 +0900)]
Fix coding style

Change-Id: I9353b9beb35f888cb9d06c60d9475c6028b84b14
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoImplement recovery test for forced termination 64/207664/15
Ilho Kim [Wed, 5 Jun 2019 07:45:54 +0000 (16:45 +0900)]
Implement recovery test for forced termination

Using time interval, kill install process and perform a recovery test

Requires:
 - https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/209477/

Change-Id: Ifa90cab0b5b0da70f620bfcfcb8f39a81d2ee180
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoRelease version 1.8.7 48/210548/1 accepted/tizen/unified/20190723.053619 submit/tizen/20190722.090051
Junghyun Yeon [Mon, 22 Jul 2019 08:44:11 +0000 (17:44 +0900)]
Release version 1.8.7

Changes:
 - Fix smoke test
 - Revert "Fix smoke test"

Change-Id: I991fae939df464b24b711a2177f8b19b34990639
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRevert "Fix smoke test" 21/210521/1
ilho kim [Mon, 22 Jul 2019 05:34:29 +0000 (05:34 +0000)]
Revert "Fix smoke test"

This reverts commit 554cc188a5a66e0642123905dfa690a20dc46dce.

Change-Id: I451e68ffcd413c3023a57d0fa53d9d2bdc29c290

5 years agoFix smoke test 55/210255/1
Ilho Kim [Wed, 17 Jul 2019 08:11:15 +0000 (17:11 +0900)]
Fix smoke test

Add process to initialize DB for test

Requires:
 - https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/210253/

Change-Id: I86de0dc31a08a26604eee7095469000d78a4f0b1
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoRelease version 1.8.6 89/209889/1 accepted/tizen/unified/20190717.115211 submit/tizen/20190712.071407 submit/tizen/20190716.022534
Ilho Kim [Fri, 12 Jul 2019 06:47:13 +0000 (15:47 +0900)]
Release version 1.8.6

Changes:
 - Combine StorageDirectories Steps
 - Unit tests for duplicated splash screen detection

Change-Id: I18c8a2d01b408e9251e6aae1f74c9eea3d5acee1
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoUnit tests for duplicated splash screen detection 51/205151/2
Michal Marszal [Mon, 29 Apr 2019 14:37:29 +0000 (16:37 +0200)]
Unit tests for duplicated splash screen detection

Patch requires: https://review.tizen.org/gerrit/#/c/205150/

Change-Id: I0c65e0e3e933f3dc1760417192c45ce3c7146acb
Signed-off-by: Michal Marszal <m.marszal@samsung.com>
5 years agoCombine StorageDirectories Steps 94/206194/7
Ilho Kim [Tue, 14 May 2019 01:47:19 +0000 (10:47 +0900)]
Combine StorageDirectories Steps

Combined step :
 - StepCreateStorageDirectories and StepCreatePerUserStorageDirectories
 - StepUpdateStorageDirectories and StepUpdatePerUserStorageDirectories
 - StepRecoverStorageDirectories and StepRecoverPerUserStorageDirectories

Related changes
    [app-installers] https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/206075/
    [tpk-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-backend/+/206194/
    [wgt-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-backend/+/206193/

Change-Id: I0de7d1c33cfd06619b130c988bc77c7a9dccbd9e
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoRelease version 1.8.5 51/208551/1 accepted/tizen/unified/20190626.064939 submit/tizen/20190626.013636
Ilho Kim [Wed, 26 Jun 2019 01:50:54 +0000 (10:50 +0900)]
Release version 1.8.5

Changes:
 - Fix namespace of StepCreateRecoveryFile
 - Fix smoke test helper
 - Fix name of some steps

Change-Id: Iac924691ecaee45babed138825d27aae2abbfe32
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix name of some steps 11/207711/2
Sangyoon Jang [Tue, 11 Jun 2019 08:45:17 +0000 (17:45 +0900)]
Fix name of some steps

The name of class StepExampleClass should be "ExampleClass"

Change-Id: Ic6c72e66ea2868e998849d212a55fffe4edf1ef7
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix smoke test helper 45/204345/5
Sangyoon Jang [Tue, 23 Apr 2019 07:39:37 +0000 (16:39 +0900)]
Fix smoke test helper

To use custom step, we need to derive a new class.
(refer: https://review.tizen.org/gerrit/c/platform/core/appfw/app-installers/+/203760)

Change-Id: I8eadd437e8a1a2b20a34fa0a3d7f0cd8b75d0f96
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix namespace of StepCreateRecoveryFile 60/206960/4
Sangyoon Jang [Wed, 29 May 2019 10:07:15 +0000 (19:07 +0900)]
Fix namespace of StepCreateRecoveryFile

Requires:
 - https://review.tizen.org/gerrit/c/platform/core/appfw/app-installers/+/206959

Change-Id: Ia36967a54acbc12a56883a1894a19abc1c1e5967
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRelease version 1.8.4 05/207305/1 accepted/tizen/unified/20190604.081856 submit/tizen/20190603.050018
Sangyoon Jang [Mon, 3 Jun 2019 04:42:15 +0000 (13:42 +0900)]
Release version 1.8.4

Changes:
 - Fix libtpk

Change-Id: I934aaae337e184904319e936201e08b2f9d14b67
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix libtpk 98/207298/1
Sangyoon Jang [Mon, 3 Jun 2019 02:31:33 +0000 (11:31 +0900)]
Fix libtpk

Add extern "C" to using at C module.

Change-Id: I1f8479346b22649368d58c2974cdb9113ed7002f
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRelease version 1.8.3 55/207255/1 submit/tizen/20190531.072406
Ilho Kim [Fri, 31 May 2019 06:23:39 +0000 (15:23 +0900)]
Release version 1.8.3

Changes:
 - Combine Signature Steps
 - Remove visibility flag to export all classes
 - Standardize use of STEP_NAME()
 - Combine Plugin Steps
 - Add comparing package attributes for ReadonlyUpdateUninstall test

Change-Id: I65eb04084b7fe4199d8e886a523044c7ff78ad49
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoAdd comparing package attributes for ReadonlyUpdateUninstall test 13/203613/3
Sangyoon Jang [Tue, 16 Apr 2019 07:56:31 +0000 (16:56 +0900)]
Add comparing package attributes for ReadonlyUpdateUninstall test

Requires:
 - https://review.tizen.org/gerrit/c/platform/core/appfw/app-installers/+/203612

Change-Id: I8f1def6d86993b411c856bc1dd168d134cb7d149
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoCombine Plugin Steps 57/204757/5
Ilho Kim [Fri, 26 Apr 2019 05:57:26 +0000 (14:57 +0900)]
Combine Plugin Steps

StepRunParserPlugin combines below steps
 - StepRegisterPluginInfo
 - StepUpdatePluginInfo
 - StepUnregisterPluginInfo

Related changes
    [app-installers] https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/204652/
    [tpk-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-backend/+/204757/
    [wgt-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-backend/+/205385/

Change-Id: I4a4730f20ab09c98e6040eda901258f94e050e21
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoStandardize use of STEP_NAME() 17/206317/2
Ilho Kim [Thu, 16 May 2019 03:00:05 +0000 (12:00 +0900)]
Standardize use of STEP_NAME()

In case class name is StepExampleClass, Pass "ExampleClass" to STEP_NAME()

Change-Id: Id2bcb7c21b704a949613896527731c68ef8743ac
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoRemove visibility flag to export all classes 48/206248/2
Sangyoon Jang [Wed, 15 May 2019 11:14:57 +0000 (20:14 +0900)]
Remove visibility flag to export all classes

This flag was added to reduce binary size, but it doesn't meaningful at
this time. And we need to export all classes for custom backends.

- Binary size comparison
 Before this patch: 1599404 Bytes
  After this patch: 1616560 Bytes

Change-Id: I12b6680671c220488494df130f5245c97c3d57c3
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoCombine Signature Steps 41/203141/4
ilho [Wed, 10 Apr 2019 06:22:45 +0000 (15:22 +0900)]
Combine Signature Steps

StepCheckSignature and StepSaveSignature are combined

Related changes
    [app-installers] https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/203140/
    [tpk-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-backend/+/203141/
    [wgt-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-backend/+/203513/

Change-Id: Ie2e20c033f2663f08aab09e0f4810a19a6d4b174
Signed-off-by: ilho <ilho159.kim@samsung.com>
5 years agoRelease version 1.8.2 15/203815/1 accepted/tizen/unified/20190419.110516 submit/tizen/20190418.021839 submit/tizen/20190418.055722
Sangyoon Jang [Thu, 18 Apr 2019 02:16:41 +0000 (11:16 +0900)]
Release version 1.8.2

Changes:
 - Do not call Init() for initialize steps

Change-Id: I68a52673c76a252b2342e00d13d16e54c1dc58d3
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoDo not call Init() for initialize steps 61/203761/1
Sangyoon Jang [Wed, 17 Apr 2019 11:39:38 +0000 (20:39 +0900)]
Do not call Init() for initialize steps

Init() will be called internally by AppInstaller class. (inside Run())

Requires:
 - https://review.tizen.org/gerrit/c/platform/core/appfw/app-installers/+/203760

Change-Id: Ibf4bda5584432404397b2d757e9e7f21f7875315
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRelease version 1.8.1 34/203634/1 accepted/tizen/unified/20190417.132341 submit/tizen/20190416.100651 submit/tizen/20190416.233814
Junghyun Yeon [Tue, 16 Apr 2019 08:57:19 +0000 (17:57 +0900)]
Release version 1.8.1

Changes:
 - Fix StepConvertXml

Change-Id: I3319dfc0410288687c3b6719751e62daf0af61f4
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoFix StepConvertXml 14/202314/1
Junghyun Yeon [Wed, 27 Mar 2019 05:31:04 +0000 (14:31 +0900)]
Fix StepConvertXml

- Fail log will be printed only when remove has failed.

Change-Id: Ia91bd07f4b14a2e4213a93303a549a7b13becd53
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRelease version 1.8.0 28/201528/1 accepted/tizen/unified/20190318.150644 submit/tizen/20190315.084013
Junghyun Yeon [Fri, 15 Mar 2019 08:35:16 +0000 (17:35 +0900)]
Release version 1.8.0

Changes:
 - Remove empty line for coding style
 - Change visibility of steps to protected
 - Add StepRegisterPluginInfo
 - Add step StepCheckUpgradable

Change-Id: I4221da5735408c4735a74fe012962904334d8805
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoAdd step StepCheckUpgradable 59/201359/1
Sangyoon Jang [Wed, 13 Mar 2019 06:29:02 +0000 (15:29 +0900)]
Add step StepCheckUpgradable

This step check the package upgradable using package dependency info.

Change-Id: I0c26e23d44c7325d2d0f94781304c575c3258682
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoAdd StepRegisterPluginInfo 24/195924/10
Junghyun Yeon [Wed, 19 Dec 2018 12:13:58 +0000 (21:13 +0900)]
Add StepRegisterPluginInfo

- By adding procedure for storing plugin execution info,
  additional Step for storing it to db is needed.

Related changes:
[pkgmgr-info] : https://review.tizen.org/gerrit/#/c/platform/core/appfw/pkgmgr-info/+/195920/
[app-installers] : https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/195744/

Change-Id: I5b0ec598a6c65eb8abc2ce34d5bbc18eb868dfdd
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoChange visibility of steps to protected 23/200323/2
Sangyoon Jang [Thu, 21 Feb 2019 11:11:48 +0000 (20:11 +0900)]
Change visibility of steps to protected

For extensibility, change visibility to protected.

Requires:
 - https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/200321

Change-Id: I75b65b68f8f2a93f2f0865ec8c3133aaf0acdd8e
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRemove empty line for coding style 20/200020/1
Junghyun Yeon [Mon, 18 Feb 2019 07:11:48 +0000 (16:11 +0900)]
Remove empty line for coding style

Change-Id: Ieb8e2ebcd362d55bdf6024d2c567199139f514da
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRelease version 1.7.8 60/199960/1 accepted/tizen_5.0_unified accepted/tizen/5.0/unified/20190419.092309 accepted/tizen/unified/20190218.163216 submit/tizen/20190218.024446 submit/tizen_5.0/20190401.082359 submit/tizen_5.0/20190418.042706
Junghyun Yeon [Mon, 18 Feb 2019 02:32:27 +0000 (11:32 +0900)]
Release version 1.7.8

Changes:
 - Add dependency explicitly

Change-Id: Idca504259accb37f470394a04ac2232daadee1e5
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoAdd dependency explicitly 53/199953/1
Junghyun Yeon [Mon, 18 Feb 2019 01:46:52 +0000 (10:46 +0900)]
Add dependency explicitly

Change-Id: Ie6d972c3dad8f5df6ee35eaa01c5de0eabdb2ebf
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRelease version 1.7.7 96/199896/1 submit/tizen/20190215.085133
ilho [Fri, 15 Feb 2019 08:47:22 +0000 (17:47 +0900)]
Release version 1.7.7

Changes:
 - Fix static analysis issue

Change-Id: I19e2b7c50ce102a680cf399f4c2076dfd11480d2
Signed-off-by: ilho <ilho159.kim@samsung.com>
5 years agoFix static analysis issue 71/197971/2
Junghyun Yeon [Thu, 17 Jan 2019 10:21:33 +0000 (19:21 +0900)]
Fix static analysis issue

Change-Id: I99998235039fac7f78ce3a5f69be9ef7d61dd375
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoRelease version 1.7.6 70/186770/1 accepted/tizen/5.0/unified/20181102.015125 accepted/tizen/unified/20180816.062951 submit/tizen/20180814.083738 submit/tizen_5.0/20181101.000003
Junghyun Yeon [Tue, 14 Aug 2018 07:42:26 +0000 (16:42 +0900)]
Release version 1.7.6

Changes:
 - Replace StepRegisterTrustAnchor into StepRecoverTrustAnchor

Change-Id: Iac731726932de9cde293ef8aa9f0cc7f35981370
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoReplace StepRegisterTrustAnchor into StepRecoverTrustAnchor 23/186123/3
Junghyun Yeon [Tue, 7 Aug 2018 10:33:35 +0000 (19:33 +0900)]
Replace StepRegisterTrustAnchor into StepRecoverTrustAnchor

Related changes:
[app-installers] : https://review.tizen.org/gerrit/#/c/186122

Change-Id: Ief86c915f079415ec71f8378aba70a3e51666f13
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoRelease version 1.7.5 34/184834/1 accepted/tizen/unified/20180724.073413 submit/tizen/20180723.124652
Junghyun Yeon [Mon, 23 Jul 2018 12:45:28 +0000 (21:45 +0900)]
Release version 1.7.5

Changes:
 - Fix Recover request type

Change-Id: I70f81e725ac555bfcdd23621def611e4f6566ed9
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoFix Recover request type 17/184617/1
Junghyun Yeon [Thu, 19 Jul 2018 07:49:48 +0000 (16:49 +0900)]
Fix Recover request type

- Remove StepManifestAdjustment.

Change-Id: Idbf00767b78e4c180f1c57ad9e3fef441a341886
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoRelease version 1.7.4 63/184463/1 accepted/tizen/unified/20180719.063018 submit/tizen/20180718.064806
Junghyun Yeon [Wed, 18 Jul 2018 05:45:49 +0000 (14:45 +0900)]
Release version 1.7.4

Changes:
 - Add RecoverDB step

Change-Id: I1762d937bb7747cad9586680ecbcb9dd6dad965f
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoAdd RecoverDB step 77/182177/4
Junghyun Yeon [Thu, 21 Jun 2018 06:16:19 +0000 (15:16 +0900)]
Add RecoverDB step

- This will be invoked when db has corrupted

Related changes:
[app-installers] : https://review.tizen.org/gerrit/182176

Change-Id: Ifbd28927721cc80b52010337f8ac39616976eaf0
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoRelease version 1.7.3 21/182521/1 accepted/tizen/unified/20180627.070027 submit/tizen/20180626.064201
Sangyoon Jang [Tue, 26 Jun 2018 01:35:10 +0000 (10:35 +0900)]
Release version 1.7.3

Changes:
 - Supplement ParserPlugin

Change-Id: Icfd0e517b5e1e07a6834815d4f87fc8f6cbd6fba
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoSupplement ParserPlugin 63/179063/4
Junghyun Yeon [Tue, 15 May 2018 11:22:50 +0000 (20:22 +0900)]
Supplement ParserPlugin

- Adjust order of steps.
- Add StepRecoverParserPlugin.

Related changes:
[app-installers] : https://review.tizen.org/gerrit/178962

Change-Id: I7bddab2ef30a9c6f4adc252bb41270f7559c2f86
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoRelease version 1.7.2 64/178664/1 accepted/tizen/unified/20180514.094115 submit/tizen/20180511.064939
Junghyun Yeon [Fri, 11 May 2018 06:45:24 +0000 (15:45 +0900)]
Release version 1.7.2

Changes:
 - Add StepSaveSignature at mount install or update
 - Supress build warning
 - Add StepRevokeTrustAnchor steps for several installation cases.

Change-Id: I930d2319fcf3ff98be449ddfce38fcd6aa232b2b
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoAdd StepRevokeTrustAnchor steps for several installation cases. 87/158887/9
Junghyun Yeon [Sun, 5 Nov 2017 23:56:36 +0000 (08:56 +0900)]
Add StepRevokeTrustAnchor steps for several installation cases.

- When updating pkg has failed, trust anchor should be revoked.

Related changes:
[app-installers] : https://review.tizen.org/gerrit/#/c/158351/
Change-Id: I02e39983e26129f8618ccb0329448c00afec7208
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoSupress build warning 31/175731/1
Junghyun Yeon [Thu, 12 Apr 2018 04:22:10 +0000 (13:22 +0900)]
Supress build warning

Change-Id: I05e365f62f21af390a910717ce8958e4dda060cb
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoAdd StepSaveSignature at mount install or update 98/174998/1
Junghyun Yeon [Fri, 6 Apr 2018 00:29:59 +0000 (09:29 +0900)]
Add StepSaveSignature at mount install or update

- Distributor signature don't have to be extracted
  because its value will be stored at separated directory.

Related changes:
[app-installers] : https://review.tizen.org/gerrit/174993

Change-Id: Ie55c10fff95954dabe54b75e11ad555ad60ac07f
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoRelease version 1.7.1 81/174681/1 accepted/tizen/unified/20180405.131210 submit/tizen/20180404.060840 submit/tizen/20180405.022120
Sangyoon Jang [Tue, 3 Apr 2018 10:57:34 +0000 (19:57 +0900)]
Release version 1.7.1

Changes:
 - Fix static analyzer issues

Change-Id: I9ad239dd4a8b347699158b4a612336ff3f72a628
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoFix static analyzer issues 04/174504/1
Sangyoon Jang [Mon, 2 Apr 2018 11:06:55 +0000 (20:06 +0900)]
Fix static analyzer issues

- Fix uncaught exception.

Change-Id: I004cf553ecf9f96db1d2ab1642c3905cd8ea56ef
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoRelease version 1.7.0 53/174353/1 accepted/tizen/unified/20180403.060140 submit/tizen/20180330.082234 submit/tizen/20180402.081755
Junghyun Yeon [Fri, 30 Mar 2018 08:13:48 +0000 (17:13 +0900)]
Release version 1.7.0

Changes:
 - Add StepSaveSignature step

Change-Id: Ie2d4e12063b47d90b7340401c34da2ec1fc3342f
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoAdd StepSaveSignature step 02/171602/6
Junghyun Yeon [Tue, 6 Mar 2018 07:51:01 +0000 (16:51 +0900)]
Add StepSaveSignature step

- Add StepSaveSignature step to store signature data
  needed to compare and retrieving signature data.

Related changes:
[app-installers] : https://review.tizen.org/gerrit/#/c/171653/

Change-Id: Id1999fbdc3cf1b5ba3ef81d2019af2daabcf83d8
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoRelease version 1.6.5 74/173974/1 accepted/tizen/unified/20180330.060617 submit/tizen/20180327.085346
Junghyun Yeon [Tue, 27 Mar 2018 08:50:07 +0000 (17:50 +0900)]
Release version 1.6.5

Changes:
 - Fix extensive smoke test

Change-Id: I8b27cf8fa3feb04f50b10f4df1855b62c9bcd35b
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>