platform/core/connectivity/bluetooth-frwk.git
5 years agoAdd -Wall -Werror build option for bluez hal 11/199011/1
DoHyun Pyun [Fri, 1 Feb 2019 00:26:24 +0000 (09:26 +0900)]
Add -Wall -Werror build option for bluez hal

Change-Id: Ieb22a7a158a47fb45a468832f2fd3e878cc251c2
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoFix the warning errors 10/199010/1
DoHyun Pyun [Fri, 1 Feb 2019 00:26:01 +0000 (09:26 +0900)]
Fix the warning errors

Change-Id: Ib1bb16613a744e730a724de0556fbe69e3a72468
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoMerge "cleanup of acquire notification data for stop notify" into tizen accepted/tizen/unified/20190201.061316 submit/tizen/20190131.063750
Pyun DoHyun [Thu, 31 Jan 2019 06:37:24 +0000 (06:37 +0000)]
Merge "cleanup of acquire notification data for stop notify" into tizen

5 years agoMerge "Handle ACL Disconnect Reason" into tizen
Pyun DoHyun [Wed, 30 Jan 2019 23:34:55 +0000 (23:34 +0000)]
Merge "Handle ACL Disconnect Reason" into tizen

5 years agocleanup of acquire notification data for stop notify 45/198845/1
Amit Purwar [Wed, 30 Jan 2019 09:00:31 +0000 (14:30 +0530)]
cleanup of acquire notification data for stop notify

Change-Id: I75cb3a0edbd159789695cc8c16ae659cc246c5bf
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoHandle ACL Disconnect Reason 27/198827/1
Anupam Roy [Wed, 30 Jan 2019 06:24:58 +0000 (11:54 +0530)]
Handle ACL Disconnect Reason

Following events are Bluez HAL specific
 - Disconnect due to Remote Host
 - Disconnect due to Local Host

Change-Id: I8199847a3cad9040ec1b91ce13f89c773748e8b2
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
5 years agoReduce the indentation and complexity for AVRCP function 16/198816/1
DoHyun Pyun [Wed, 30 Jan 2019 04:07:51 +0000 (13:07 +0900)]
Reduce the indentation and complexity for AVRCP function

Change-Id: I8bc516ced5d8e1632772df1d715b52a6423b51eb
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoSupport in AVRCPT controller commands for multiple controllers 15/198515/2
Avichal [Fri, 25 Jan 2019 05:45:31 +0000 (14:45 +0900)]
Support in AVRCPT controller commands for multiple controllers

Change-Id: I8e913da0bfa6e118c640603d588a9e88b1e08297
Signed-off-by: Avichal <avichal.a@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoMerge "A2DP profile multiple source support" into tizen
Pyun DoHyun [Wed, 30 Jan 2019 01:05:46 +0000 (01:05 +0000)]
Merge "A2DP profile multiple source support" into tizen

5 years agoMerge "Fixed disable notification for acquire notification" into tizen accepted/tizen/unified/20190129.064355 submit/tizen/20190129.000858
Pyun DoHyun [Tue, 29 Jan 2019 00:07:54 +0000 (00:07 +0000)]
Merge "Fixed disable notification for acquire notification" into tizen

5 years agoMerge "fixed gatt server notification event for acquire notify" into tizen
Pyun DoHyun [Tue, 29 Jan 2019 00:07:50 +0000 (00:07 +0000)]
Merge "fixed gatt server notification event for acquire notify" into tizen

5 years agoFixed disable notification for acquire notification 10/198610/3
Amit Purwar [Mon, 28 Jan 2019 05:19:15 +0000 (10:49 +0530)]
Fixed disable notification for acquire notification

Change-Id: I8b870f29ec3c71d6a0b75e915307b76e57d33ad7
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoA2DP profile multiple source support 59/196359/5
Avichal [Thu, 27 Dec 2018 14:23:58 +0000 (19:53 +0530)]
A2DP profile multiple source support

Added Support multiple a2dp and avrctp connections.

Change-Id: I50d4ba897042648afc35a59d91e8e61c3b2ac91e
Signed-off-by: Avichal <avichal.a@samsung.com>
5 years agoFix dbus policies 18/198518/2
Wootak Jung [Fri, 25 Jan 2019 06:01:07 +0000 (15:01 +0900)]
Fix dbus policies

If unknown process owns these well-known name, unexpected deny can be occured.
So, subdivide deny policy.

Change-Id: I8e6cc73d80d60d348e2b510cabc77c73a6cb32ca

5 years agofixed gatt server notification event for acquire notify 51/198451/1
Amit Purwar [Thu, 24 Jan 2019 13:22:41 +0000 (18:52 +0530)]
fixed gatt server notification event for acquire notify

Change-Id: I2b99788b188b3df5f4e64c2966fb1a64bf7ab0ca
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
5 years agoRemove unnecessary connection getting functions 61/198261/2 submit/tizen/20190124.075029 submit/tizen/20190128.005753
Wootak Jung [Wed, 23 Jan 2019 04:57:50 +0000 (13:57 +0900)]
Remove unnecessary connection getting functions

Remove duplicated function _bt_gdbus_init_system_gconn()
Remove duplicated function __get_gdbus_connection()
Rename _bt_gdbus_get_system_gconn() to _bt_get_system_private_conn()
Rename _bt_init_system_gdbus_conn() to _bt_get_system_shared_conn()
Add 'static' keyword for static functions

Change-Id: I85571703b1c9a74365c83dc9d701cb418963ae59

5 years agoReturn errors without retry if bond info. already exists or it's in progress 94/198194/1 accepted/tizen/unified/20190128.061620 submit/tizen/20190123.050251
Deokhyun Kim [Tue, 22 Jan 2019 07:38:49 +0000 (16:38 +0900)]
Return errors without retry if bond info. already exists or it's in progress

  If create_bond is called in case GATT is connected and it's already bonded,
  then bond info. is removed and GATT is disconnected unexpectedly.

Change-Id: I078da398322f68522e427c7b7f18a8fd8e229f91
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
5 years agoApply send_destination_prefix policy#3 78/198178/1 submit/tizen_5.0/20190118.024626
Wootak Jung [Tue, 22 Jan 2019 05:29:20 +0000 (14:29 +0900)]
Apply send_destination_prefix policy#3

Change rfcomm connection from private to shared

Change-Id: I59924564c134a7d4f7ea13a4c25ffd41345792d8

5 years agoMerge "Enable FD based GATT client data transfer" into tizen
Pyun DoHyun [Tue, 22 Jan 2019 04:17:49 +0000 (04:17 +0000)]
Merge "Enable FD based GATT client data transfer" into tizen

5 years agoApply send_destination_prefix policy#2 28/198128/4
Wootak Jung [Mon, 21 Jan 2019 07:39:49 +0000 (16:39 +0900)]
Apply send_destination_prefix policy#2

gdbus closing logic is not needed anymore

Change-Id: If529a348bee88dfe413fd936fcf07296eb6ae8d0

5 years agoEnable FD based GATT client data transfer 62/198162/1
DoHyun Pyun [Tue, 22 Jan 2019 00:23:18 +0000 (09:23 +0900)]
Enable FD based GATT client data transfer

Change-Id: I35837791ee06c598d53dcc984f46b787dfb41f55
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoApply send_destination_prefix policy#1 06/198106/3
Wootak Jung [Mon, 21 Jan 2019 02:13:06 +0000 (11:13 +0900)]
Apply send_destination_prefix policy#1

default deny/allow options are needed for policy checker

Change-Id: I1feac171c04fc7ec8f63a68a9499149d8c5a9528

5 years agoFix the bug for the OPP server progress callback's file name 59/197659/1 accepted/tizen/unified/20190116.060558 submit/tizen/20190115.054612
DoHyun Pyun [Tue, 15 Jan 2019 05:02:46 +0000 (14:02 +0900)]
Fix the bug for the OPP server progress callback's file name

Change-Id: I3113a1e669304c559580ae0962b67f2ae67f4991
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoAdd new method to disconnect device 86/197186/1 accepted/tizen/unified/20190115.055940 submit/tizen/20190111.043317 submit/tizen/20190114.060943
Deokhyun Kim [Thu, 10 Jan 2019 07:20:01 +0000 (16:20 +0900)]
Add new method to disconnect device

Change-Id: Ia0dd37ce4cd13b2666c3e8f6f112ed0b8321d4b6
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
5 years agoFix svace issue(40981) 63/197163/1
Deokhyun Kim [Thu, 10 Jan 2019 05:04:31 +0000 (14:04 +0900)]
Fix svace issue(40981)

Change-Id: I2fa8b274e275a8aa949c274016b2ba8cfa6c7acb
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
5 years agoMerge "Improve efficiency of using g_array_index" into tizen
Pyun DoHyun [Wed, 2 Jan 2019 07:05:55 +0000 (07:05 +0000)]
Merge "Improve efficiency of using g_array_index" into tizen

5 years agoEnable the connection request event for custom obex server 21/196521/1 accepted/tizen/unified/20190103.061728 submit/tizen/20190102.044100
DoHyun Pyun [Wed, 2 Jan 2019 04:04:55 +0000 (13:04 +0900)]
Enable the connection request event for custom obex server

Change-Id: Id4a07fa2018cfd5eba778e0655bf6292b560cbbb
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
5 years agoImprove efficiency of using g_array_index 03/196503/1
Deokhyun Kim [Wed, 2 Jan 2019 02:02:30 +0000 (11:02 +0900)]
Improve efficiency of using g_array_index

Change-Id: Ia2c56e65d5900f67d0089290663cfb0c95bb6a85
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
6 years agoCorrect the privilege check logic for MTU size APIs 19/196219/1
Seungyoun Ju [Wed, 26 Dec 2018 09:20:07 +0000 (18:20 +0900)]
Correct the privilege check logic for MTU size APIs

Change-Id: I509d0967b16b9ca17a978ecffc914184b744557d

6 years agogatt-service : Fix some minor bugs 18/196218/1
Seungyoun Ju [Wed, 26 Dec 2018 09:11:17 +0000 (18:11 +0900)]
gatt-service : Fix some minor bugs

[Problem] init -> register service -> deinit -> init -> register service
-> start server : service is not added.
There are some warning about reference to invalid GOBJECT.
[Cause & Measure] Remove pending count. Unref GOBJECT after check of
validation.

Change-Id: I4829505ebac3e3c0668aa2a386de3085163d0b8d

6 years agoFix invalid read 17/196217/1
Seungyoun Ju [Fri, 14 Dec 2018 06:32:25 +0000 (15:32 +0900)]
Fix invalid read

[Problem] There is invalid read report from valgrind
[Cause & Measure] The node was accessed after it was freed. This patch
 frees current node after moving to the next node so that invalid read
 issue has been resolved.

Change-Id: I15eae8c16c8f215aee30fd33ac8f3aadea73b4eb

6 years agoImprove inefficiency 70/195870/2
Deokhyun Kim [Wed, 19 Dec 2018 05:02:48 +0000 (14:02 +0900)]
Improve inefficiency

Change-Id: Icd2b33c68d384680e24eec64de9256efb60c1084
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
6 years agoFix dlog format error 81/195681/2 accepted/tizen/unified/20181218.063056 submit/tizen/20181217.091427
DoHyun Pyun [Mon, 17 Dec 2018 08:04:48 +0000 (17:04 +0900)]
Fix dlog format error

Change-Id: I1c1fcaf6f78e4a0946c86adbdc456b6439f5e395
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoCorrect the privilege check logic for MTU size APIs 64/195364/1
DoHyun Pyun [Thu, 13 Dec 2018 01:43:58 +0000 (10:43 +0900)]
Correct the privilege check logic for MTU size APIs

Change-Id: I14b3e825cfb04691efed9c3fea847d7dfe59d82b
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoModify dbus policies 21/194121/2 accepted/tizen/unified/20181210.152220 submit/tizen/20181210.003120
Wootak Jung [Thu, 29 Nov 2018 07:30:43 +0000 (16:30 +0900)]
Modify dbus policies

- Remove org.projectx.bt_event policy
- Apply default deny for org.projectx.bluetooth.share
- Add send_member for org.tizen.csd.Call.Instance

Change-Id: Ia50f24d807b0f180bcd74f02886f28cc57474d5e

6 years agoModify gdbus proxy flag to G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES 73/193473/2
Wootak Jung [Wed, 21 Nov 2018 05:52:02 +0000 (14:52 +0900)]
Modify gdbus proxy flag to G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES

G_DBUS_PROXY_FLAGS_NONE causes some unnecessary error log

Change-Id: I8be66086d58431bb9894f30d7cbddc4f3ac76a63

6 years agoMerge "Match the correct privilege for RFCOMM listen and accept API" into tizen
Pyun DoHyun [Wed, 5 Dec 2018 00:34:07 +0000 (00:34 +0000)]
Merge "Match the correct privilege for RFCOMM listen and accept API" into tizen

6 years agoMatch the correct privilege for RFCOMM listen and accept API 00/194300/1
DoHyun Pyun [Mon, 3 Dec 2018 01:59:58 +0000 (10:59 +0900)]
Match the correct privilege for RFCOMM listen and accept API

Change-Id: I1a19d3222ec033a55a16f20e8d906a61c6f0b6b7
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoCheck le_adv_slot before access 61/193761/1
Deokhyun Kim [Mon, 26 Nov 2018 06:43:20 +0000 (15:43 +0900)]
Check le_adv_slot before access

 - bt-service crashes by invalid memory access when _bt_is_advertising is called
  before adv info is initialized.

Change-Id: I75b4efb9c4ccb209860453e467f9847669cc7624
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
6 years agoRemove g_bus_own_name() logic in bt-telephony 00/192700/1
Wootak Jung [Thu, 8 Nov 2018 05:12:09 +0000 (14:12 +0900)]
Remove g_bus_own_name() logic in bt-telephony

It is not good to call g_bus_own_name() in api layer, it causes
service name of sender is changed to org.tizen.csd.Call.Instance.

This interface has been used on bluetooth-agent and it can call
method on this interface by using sender_name instead of service_name.

Change-Id: I6f77e23ee15b9b1f9e4a4ce53f4993e852006bce

6 years agoMigrate insmod logic into bt-stack-up.service 91/192391/1 accepted/tizen/unified/20181109.062817 submit/tizen/20181106.081159 submit/tizen/20181108.005303 submit/tizen/20181108.070422
Wootak Jung [Mon, 5 Nov 2018 08:03:19 +0000 (17:03 +0900)]
Migrate insmod logic into bt-stack-up.service

insmod logic should be executed before bt-stack-up.sh logic. But,
insmod logic has been executed after bt-stack-up.sh logic on ARTIK530.
This patch migrates insmod logic into bt-stack-up.sh and creates bt-stack-up.service
This patch should be merged with bluetooth-tools.

Change-Id: I15e3ab996379600173e441effb9d52577ae3203b

6 years agoMerge "Revert "Fix incorrect interface name and improve dbus policy"" into tizen accepted/tizen/unified/20181107.081858 submit/tizen/20181026.055809 submit/tizen/20181105.232950
Pyun DoHyun [Fri, 26 Oct 2018 05:57:33 +0000 (05:57 +0000)]
Merge "Revert "Fix incorrect interface name and improve dbus policy"" into tizen

6 years agoRevert "Fix incorrect interface name and improve dbus policy" 63/191963/1
Wootak Jung [Fri, 26 Oct 2018 05:46:56 +0000 (05:46 +0000)]
Revert "Fix incorrect interface name and improve dbus policy"

This reverts commit fb6c7048cb2a150aebcef0e2821c369e46c5a9ad.

Change-Id: Ia78dd8b41f341441d4c3cbb15bd1450e24dbaf22

6 years agoFix profile check logic to distinguish ivi and iot 99/191899/2
Wootak Jung [Thu, 25 Oct 2018 06:10:58 +0000 (15:10 +0900)]
Fix profile check logic to distinguish ivi and iot

Change-Id: Iaa8e0786787bfba81987d6fdb29d2a95dd867ab9

6 years agoInvoke callback function after all internal work is done 26/191626/1
Deokhyun Kim [Fri, 19 Oct 2018 05:59:42 +0000 (14:59 +0900)]
Invoke callback function after all internal work is done

 - Prevent to access freed service after GATT is destroyed in callback function

Change-Id: I8aa33c48cdcf246578552a58aaa2cad7a94a589c
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
6 years agoRevert "Remove and modify for some dbus policies" 68/191368/1 accepted/tizen_5.0_unified accepted/tizen/5.0/unified/20181102.014759 accepted/tizen/unified/20181018.000410 submit/tizen/20181016.090705 submit/tizen_5.0/20181101.000003
DoHyun Pyun [Tue, 16 Oct 2018 09:05:26 +0000 (18:05 +0900)]
Revert "Remove and modify for some dbus policies"

This reverts commit b493a680894d58efc1879d90be656c6fcdda9c50.

Change-Id: I98e87554fde528a824189a5f3051eb0417b985f4
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoRemove and modify for some dbus policies 45/190745/1 accepted/tizen/unified/20181011.095202 submit/tizen/20181009.235550
Wootak Jung [Fri, 5 Oct 2018 05:06:04 +0000 (14:06 +0900)]
Remove and modify for some dbus policies

- org.projectx.bt_event
 no need policy for using signal
- org.projectx.bluetooth.share
 bluetooth-share owns this service
- org.tizen.csd.Call.Instance
 user owns this service and called by network_fw

Change-Id: I3727e144ffcae9ad9ff12748c7ac5b51c08e0486

6 years agoMerge "Fix incorrect interface name and improve dbus policy" into tizen
Pyun DoHyun [Thu, 4 Oct 2018 02:49:18 +0000 (02:49 +0000)]
Merge "Fix incorrect interface name and improve dbus policy" into tizen

6 years agoDisable GATT Client fd based function 58/190558/1 accepted/tizen/unified/20181005.012503 submit/tizen/20181004.010949
DoHyun Pyun [Thu, 4 Oct 2018 00:58:07 +0000 (09:58 +0900)]
Disable GATT Client fd based function

After applying the security patchset, we will enable this feature.
To pass the web manaul TC, we disable this feature in now.

Change-Id: I35cb8e79bf0aba5a4b27171db1c0f22346e32f44
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoFix incorrect interface name and improve dbus policy 03/190303/1
Wootak Jung [Mon, 1 Oct 2018 01:52:37 +0000 (10:52 +0900)]
Fix incorrect interface name and improve dbus policy

Dbus -> DBus
Objectmanager -> ObjectManager

Change-Id: I97a05856ff7b8357aeb92d595d5d4aacfc786bee

6 years agoFixed the return status for indicate property 27/190227/1 submit/tizen/20180930.234221
Amit Purwar [Fri, 28 Sep 2018 09:18:53 +0000 (14:48 +0530)]
Fixed the return status for indicate property

Return status for indicate property of characteristic
is fixed in set characteristic changed value cb for
TFIVE-14433 TFIVE-14439 issue

Change-Id: Ia3ef28961ef71fb81e7d74bce457e54a99ba3cb5
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
6 years agoModify to path activation for hciconfig command 33/189833/2 accepted/tizen/unified/20180928.080457 submit/tizen/20180927.020120
Wootak Jung [Fri, 21 Sep 2018 04:52:20 +0000 (13:52 +0900)]
Modify to path activation for hciconfig command

Change-Id: Ia091b30464fc2cf1fef96d65c95ff3b0ea296312

6 years agoFix memory double free(crash) issue 35/189735/1 accepted/tizen/unified/20180921.042519 submit/tizen/20180920.060650
Wootak Jung [Thu, 20 Sep 2018 05:41:47 +0000 (14:41 +0900)]
Fix memory double free(crash) issue

g_variant_get_string returns the constant string whereas
g_variant_get_dup_string returns a newly allocated string.
It should not be freed.

    at /usr/src/debug/bluetooth-frwk-0.3.0/bt-oal/bluez_hal/src/bt-hal-adapter-dbus-handler.c:525

Change-Id: I3d8f6bc0eec3d7736a263edbb47c3f3deaee4cef

6 years agoAdded the GATT server disconnect 05/185005/7 accepted/tizen/unified/20180919.141920 submit/tizen/20180919.001852
Amit Purwar [Wed, 25 Jul 2018 06:06:49 +0000 (11:36 +0530)]
Added the GATT server disconnect

Change-Id: I2c38505d92d8610801670cd063d31fbf7f8df4b4
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
6 years agoMerge "Prevent Issue fixes" into tizen
Pyun DoHyun [Wed, 19 Sep 2018 00:18:05 +0000 (00:18 +0000)]
Merge "Prevent Issue fixes" into tizen

6 years agoPrevent Issue fixes 27/189527/2
Abhishek Chandra [Tue, 18 Sep 2018 09:43:57 +0000 (15:13 +0530)]
Prevent Issue fixes

Prevent Issue fixes :
1026071
1026065
1026059
1026057
1026047
1026042
1026038

Change-Id: I4517e99e89e5ad5a1fefe07fc2263c27587e61ab
Signed-off-by: Abhishek Chandra <abhishek.ch@samsung.com>
6 years agoremoved gatt service info from list during gatt cleanup 85/189385/1
Amit Purwar [Mon, 17 Sep 2018 09:35:50 +0000 (15:05 +0530)]
removed gatt service info from list during gatt cleanup

Change-Id: I1dbe49424fcf20047c2d86ec6e234929e05f6de2
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
6 years agoAdd "Not Supported" check logic for haltests 08/189308/1 accepted/tizen/unified/20180918.062755 accepted/tizen/unified/20180918.062946 submit/tizen/20180917.041805 submit/tizen/20180917.223052
DoHyun Pyun [Mon, 17 Sep 2018 04:08:51 +0000 (13:08 +0900)]
Add "Not Supported" check logic for haltests

Change-Id: I45b5d88291dbf7b895229b79f7db6479edf72e3d
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoModify bt-oal initialize code readably 89/189089/1
Wootak Jung [Thu, 13 Sep 2018 08:54:44 +0000 (17:54 +0900)]
Modify bt-oal initialize code readably

Change-Id: Ic35ea6d65139f41f63caccd185474ad598f0d2d4

6 years agoRemove duplicated check logic and incorrect return type 32/189032/1
Wootak Jung [Thu, 13 Sep 2018 02:15:14 +0000 (11:15 +0900)]
Remove duplicated check logic and incorrect return type

Change-Id: I5be38b4424e2f8418d06af82c63b4de90b062651

6 years agoMerge "Fix the coding style errors" into tizen accepted/tizen/unified/20180913.064014 accepted/tizen/unified/20180914.073138 submit/tizen/20180912.234844 submit/tizen/20180913.053639
DoHyun Pyun [Wed, 12 Sep 2018 23:48:03 +0000 (23:48 +0000)]
Merge "Fix the coding style errors" into tizen

6 years agoMerge "Fix the build error in aarch64" into tizen
DoHyun Pyun [Wed, 12 Sep 2018 23:47:55 +0000 (23:47 +0000)]
Merge "Fix the build error in aarch64" into tizen

6 years agoMerge "TFIVE-12959: fixed scan response and adv data length" into tizen
Pyun DoHyun [Wed, 12 Sep 2018 23:38:48 +0000 (23:38 +0000)]
Merge "TFIVE-12959: fixed scan response and adv data length" into tizen

6 years agoMerge "TFIVE-12640: fixed the size of handle string" into tizen
Anupam Roy [Wed, 12 Sep 2018 11:10:57 +0000 (11:10 +0000)]
Merge "TFIVE-12640: fixed the size of handle string" into tizen

6 years agoTFIVE-12959: fixed scan response and adv data length 07/189007/1
Amit Purwar [Wed, 12 Sep 2018 10:56:36 +0000 (16:26 +0530)]
TFIVE-12959: fixed scan response and adv data length

Change-Id: Ib1290516f289f1cd4a6bc23cb1b8579a3f4d1b5d
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
6 years agoFix the coding style errors 95/188995/1
DoHyun Pyun [Wed, 12 Sep 2018 09:20:24 +0000 (18:20 +0900)]
Fix the coding style errors

Change-Id: If26907f850ab41859ba48b294af470c35ee9f14f
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoFix the build error in aarch64 87/188987/2
DoHyun Pyun [Wed, 12 Sep 2018 08:51:52 +0000 (17:51 +0900)]
Fix the build error in aarch64

Change-Id: Ieea61a740d960535fa0d67f4f2a52299ca86cd0b
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoAdd Werror option in CFLAG 71/188971/1
DoHyun Pyun [Wed, 12 Sep 2018 06:22:22 +0000 (15:22 +0900)]
Add Werror option in CFLAG

Change-Id: If8d0621fb55f1cd522b3d6787f37a251b762dec5
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoFix the build warnings and typo error 67/188967/1
DoHyun Pyun [Wed, 12 Sep 2018 06:21:55 +0000 (15:21 +0900)]
Fix the build warnings and typo error

Change-Id: I45c386258f39a5dbf71555b4a058caebe16f71df
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoRemove unused local variable and codes - wait_for_async( ) 28/188928/2
Taesoo Jun [Wed, 12 Sep 2018 02:45:44 +0000 (11:45 +0900)]
Remove unused local variable and codes -  wait_for_async( )

Change-Id: Ib9c2e29d3ee4f6e4ca3240e3f8633fff15655021
Signed-off-by: Taesoo Jun <steve.jun@samsung.com>
6 years agoTFIVE-12640: fixed the size of handle string 98/188898/1
Amit Purwar [Tue, 11 Sep 2018 12:05:12 +0000 (17:35 +0530)]
TFIVE-12640: fixed the size of handle string

Change-Id: I944c5d7d6e45d96b88be179d0c57113afd87cc05
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
6 years agoRemove duplicated logic 77/188877/1
Wootak Jung [Tue, 11 Sep 2018 08:35:22 +0000 (17:35 +0900)]
Remove duplicated logic

Remove incorrect comment

Change-Id: I40ad8a799e2c90b6af5d580489dfb5f26ed179f1

6 years agoFix return-type mismatch issue 76/188876/1
Wootak Jung [Tue, 11 Sep 2018 08:28:32 +0000 (17:28 +0900)]
Fix return-type mismatch issue

Change-Id: I07ed4db7b8f6395ba9b532ceaa744d9148de8e47

6 years agoRemoved duplicate g_variant_get call 60/188760/1 accepted/tizen/unified/20180911.055340 submit/tizen/20180910.080716
Abhishek Chandra [Mon, 10 Sep 2018 06:09:55 +0000 (11:39 +0530)]
Removed duplicate g_variant_get call

g_variant_get is called to extract
address , offset for read value request
in __bt_gatt_char_method_call twice .
Removed the redundant call.

Change-Id: Id5694e6437cef8ac016e701964b9c2a288161db6
Signed-off-by: Abhishek Chandra <abhishek.ch@samsung.com>
6 years agoAdd HFP HF API : bt_hf_request_call_status_info_list() 26/188726/1
Wootak Jung [Mon, 10 Sep 2018 01:48:30 +0000 (10:48 +0900)]
Add HFP HF API : bt_hf_request_call_status_info_list()

Change-Id: I4ddd7cfadb91a8ef39231cd927e5fdb0a23e152e

6 years agoStop sending notification data on fd from BT_GATT_SERVER_UPDATE_VALUE 05/188705/2 accepted/tizen/unified/20180910.172010 submit/tizen/20180910.002032
Avichal Agarwal [Fri, 7 Sep 2018 11:47:46 +0000 (17:17 +0530)]
Stop sending notification data on fd from BT_GATT_SERVER_UPDATE_VALUE

Change-Id: Ifad181ac984b8209495df0f59ec00dc6e9cf9117
Signed-off-by: Avichal Agarwal <avichal.a@samsung.com>
6 years agoFixing BLUETOOTH_EVENT_GATT_CHAR_VAL_CHANGED for notify 04/188704/3
Avichal Agarwal [Fri, 7 Sep 2018 11:37:55 +0000 (17:07 +0530)]
Fixing BLUETOOTH_EVENT_GATT_CHAR_VAL_CHANGED for notify

using correct  stucture parameter value.

Change-Id: I6a59d53cbe9e1f003ced8823cfa953cd253f44f4
Signed-off-by: Avichal Agarwal <avichal.a@samsung.com>
6 years agoHandling characteristics properties Indicate and Notify functionality 29/188129/3
Avichal Agarwal [Fri, 31 Aug 2018 12:37:33 +0000 (18:07 +0530)]
Handling characteristics properties Indicate and Notify functionality

in case of property Indicate StartNotify will be called
in case of property Notify AcquireNotify will be called

Change-Id: Ice299d23be8e68c44f6b0a6746bafa8169529102
Signed-off-by: Avichal Agarwal <avichal.a@samsung.com>
6 years agoGatt server ReadValue parsing fix 96/188296/3
Abhishek Chandra [Mon, 3 Sep 2018 12:19:00 +0000 (17:49 +0530)]
Gatt server ReadValue parsing fix

Gatt server ReadValue parsing was always returning
NULL as addr was always NULL when passed to
__bt_find_remote_gatt_client_info  ,To fix this
address and request id is extracted from the variant
parameter.

Change-Id: If4b19109e893662b66663013c0051111461cc9bd
Signed-off-by: Abhishek Chandra <abhishek.ch@samsung.com>
6 years agoAdd AVRCP control volume up / down method 80/188580/3
Wootak Jung [Thu, 6 Sep 2018 08:03:21 +0000 (17:03 +0900)]
Add AVRCP control volume up / down method

Change-Id: I3c25106ef79181ed699123a703a0b50300c7853a

6 years agoFix oal_bt_deinit crash issue 34/188634/2
Wootak Jung [Fri, 7 Sep 2018 02:18:50 +0000 (11:18 +0900)]
Fix oal_bt_deinit crash issue

Change-Id: I67bd8b537358e1f22f33490320d0b4e1e691bb23

6 years agoMerge "Add dbus policy for GATT service" into tizen
Pyun DoHyun [Fri, 7 Sep 2018 05:11:10 +0000 (05:11 +0000)]
Merge "Add dbus policy for GATT service" into tizen

6 years agoAdd dbus policy for GATT service 54/188454/1
Wootak Jung [Wed, 5 Sep 2018 02:06:21 +0000 (11:06 +0900)]
Add dbus policy for GATT service

No send_destination because private connection does not have well-known service name

Change-Id: I599f17e562207387e9c61815f31e19e39f3000dd

6 years agoresolving merge conflict with StartNotify 43/188243/1
Avichal Agarwal [Mon, 3 Sep 2018 09:03:18 +0000 (14:33 +0530)]
resolving  merge conflict with StartNotify

Using same structure as defined for
signal BLUETOOTH_EVENT_GATT_CHAR_VAL_CHANGED

Change-Id: Iac3a18c7b76105e765892ba0e8d6d33115cd1e68

6 years agoAdded feature : notification of GATT char Changed Value 80/187980/4
Amit Purwar [Fri, 31 Aug 2018 11:30:37 +0000 (17:00 +0530)]
Added feature : notification of GATT char Changed Value

Change-Id: I387bb74f169da38481ee4a03a65817f0ec0e89f9
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
6 years agoBLE Gatt Client Socket write and notify implementation 10/186410/10
Avichal Agarwal [Thu, 9 Aug 2018 10:04:13 +0000 (15:34 +0530)]
BLE Gatt Client Socket write and notify implementation

Client can write data using file descriptor on Characteristic
with property “write-without-response” . AcquireWrite
Method handler of bluez called to get write file descriptor.

Client can read notifications from File descriptors
on characteristics with property “Notify” .AcquireNotify
method handler of bluez called to get the notify file descriptor.

Change-Id: Idb06a14ae5368540f796d78e666d6896739c5579
Signed-off-by: Avichal Agarwal <avichal.a@samsung.com>
6 years agoBLE Gatt Server Socket notify implementation. 70/186570/6
Avichal Agarwal [Fri, 10 Aug 2018 11:07:50 +0000 (16:37 +0530)]
BLE Gatt Server Socket notify implementation.

Server will notify data using file descriptor on Characteristic
 with property “NOYIFY”. AcquireNotify Method handler of is
implemented in HAL,which provide file descriptor to bluez.

Change-Id: I7b567bd3ede9c1dfdb022d1af286758d93a59c72
Signed-off-by: Avichal Agarwal <avichal.a@samsung.com>
6 years agoRemove duplicated dbus policy 48/187948/1
Wootak Jung [Thu, 30 Aug 2018 00:11:37 +0000 (09:11 +0900)]
Remove duplicated dbus policy

- Some policies are existing in bluez already

Change-Id: I7d71d53f885a8ceb793bbe6a2af484da5fd7cd70

6 years agoBLE Gatt Server Socket write implemetation 65/186165/8
Avichal Agarwal [Tue, 7 Aug 2018 16:51:26 +0000 (22:21 +0530)]
BLE Gatt Server Socket write implemetation

Server with characterstics property 'write-without-response' will receive the data
on socket file descriptor.AcquireWrite method handler is implemented in OAL

Change-Id: I4b8134b8eda87f775ebf72b5e98ce6753e6a9b84
Signed-off-by: Avichal Agarwal <avichal.a@samsung.com>
6 years agoModify dbus policies based on default deny 15/187615/2
Wootak Jung [Mon, 27 Aug 2018 01:54:42 +0000 (10:54 +0900)]
Modify dbus policies based on default deny

Change-Id: I6df07a1032f1d3cd58ea68ae87323f9095143619

6 years agoPBAP: seperate a PBAP connect error cause in detail 52/187252/1
Deokhyun Kim [Tue, 21 Aug 2018 08:23:45 +0000 (17:23 +0900)]
PBAP: seperate a PBAP connect error cause in detail

Change-Id: I45c97b3c5a79103c0ab8af8abf2ccc65016714fa
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
6 years agoModify the package name for bluetooth-haltests 00/187200/1 accepted/tizen/unified/20180823.072123 submit/tizen/20180821.044826 submit/tizen/20180822.041942
DoHyun Pyun [Tue, 21 Aug 2018 02:21:42 +0000 (11:21 +0900)]
Modify the package name for bluetooth-haltests

Change-Id: I60f9b05a8020945964b1e93146f227b29544459e
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoModify OAL hal test binary name 97/187097/1 accepted/tizen/unified/20180821.090920 submit/tizen/20180820.023013
DoHyun Pyun [Mon, 20 Aug 2018 02:27:54 +0000 (11:27 +0900)]
Modify OAL hal test binary name

Change-Id: I60e870bd23f1eb4d4d36551d78d26767732f254d
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoNotification was faling as Gatt serv info was NULL 71/186671/1
Abhishek Chandra [Mon, 13 Aug 2018 09:06:49 +0000 (14:36 +0530)]
Notification was faling as Gatt serv info was NULL

String pointer were compaired for the path in
__bt_gatt_get_service_state , which was causing the
API to return NULL.

Fix : string compairition for service path is used.

Change-Id: I5ec7d768f9a63780cbc18ef1f8b00c31542c3adc
Signed-off-by: Abhishek Chandra <abhishek.ch@samsung.com>
6 years agoRemove the coverage check option for OAL library 73/186473/3 accepted/tizen/unified/20180816.134643 submit/tizen/20180814.011534
DoHyun Pyun [Fri, 10 Aug 2018 00:56:01 +0000 (09:56 +0900)]
Remove the coverage check option for OAL library

Change-Id: I0bc439758904b1c311ff4dcf7ef763c5d0ec5ffb
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoFix memory leak: cb_device_properties in oal-device-mgr.c 04/186304/1
Taesoo Jun [Thu, 9 Aug 2018 00:53:37 +0000 (09:53 +0900)]
Fix memory leak: cb_device_properties in oal-device-mgr.c

Change-Id: Ie5cec6a51ea2e5b20d24df202d727eae31680a79
Signed-off-by: Taesoo Jun <steve.jun@samsung.com>
6 years agoBT 5.0: Implement Is feature support API's 27/186027/5
Anupam Roy [Mon, 6 Aug 2018 21:04:10 +0000 (02:34 +0530)]
BT 5.0: Implement Is feature support API's

This patch implements FRWK API's which check
whether adapter supports LE 2M PHY and
LE CODED PHY features or not

Change-Id: I31284348e3c18f2b2122883c7b83b5d7486dfb62
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
6 years agoMerge "Implement local LE features adapter property" into tizen
Pyun DoHyun [Wed, 8 Aug 2018 06:14:41 +0000 (06:14 +0000)]
Merge "Implement local LE features adapter property" into tizen

6 years agoImplement local LE features adapter property 15/186215/1
Anupam Roy [Wed, 8 Aug 2018 06:13:29 +0000 (11:43 +0530)]
Implement local LE features adapter property

This patch handles Adapter's local LE features property
which will indicate whether adapter supports LE 2M PHY
and LE CODED PHY. This property is emitted by bluetoothd
as adapter's property changed event and handled in
bluetooth HAL layer. LE features are further propagated to
bt-service via new OAL event OAL_EVENT_BLE_LOCAL_FEATURES.
LE features will be finally saved in bt-service daemon.
Application can read these values directly from bt-service.

Change-Id: I9e1b617851693b7bab038a9f10861c6bf3ba8835
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
6 years agodevice : Handle "Does Not Exist" error in get_ida 08/186008/1
Seungyoun Ju [Mon, 6 Aug 2018 11:31:35 +0000 (20:31 +0900)]
device : Handle "Does Not Exist" error in get_ida

[Problem] Even though LE RPA device is not paired, operation failed
 error code (BLUETOOTH_ERROR_INTERNAL) is reported.
[Cause & Measure] Check error->message and report BLUETOOTH_ERROR_NOT_PAIRED
 when LE RPA device is not bonded
[Checking Method] N/A

Change-Id: I726c389c8f2cc0d9458a803ac4bb3463a9e25b60