platform/upstream/efl.git
5 years agoefl_access_object: modify gesture type for resolving namespace error 09/196409/3
Taehyub Kim [Fri, 28 Dec 2018 05:30:49 +0000 (14:30 +0900)]
efl_access_object: modify gesture type for resolving namespace error

Change-Id: I317e2759a3784c8301ed795117f638d01656db6e

5 years agoefl_mono: remove efl_access_object_role_get from blacklist 64/196664/2
Jaehyun Cho [Thu, 3 Jan 2019 08:31:16 +0000 (17:31 +0900)]
efl_mono: remove efl_access_object_role_get from blacklist

In 2fda262ca47fde2c83a0571bb61ef33c3be62cdc, efl_access_role_get is
modified to efl_access_object_role_get unlike upstream.

So this change is reverted in this patch to remove
efl_access_object_role_get from blacklist.

Change-Id: I3cfee63cb6b8d6487b0a6664c7681d70e173fbcd

5 years agoefl_input_device: modify the input device subtype for resolving namespace error 08/196408/2
Taehyub Kim [Fri, 28 Dec 2018 05:29:07 +0000 (14:29 +0900)]
efl_input_device: modify the input device subtype for resolving namespace error

Change-Id: I622aea806a9b939205fe7d341a8d094aeaa8553c

5 years agoevas vg: correct caching last frame index. 84/196584/3
Hermet Park [Wed, 2 Jan 2019 12:23:49 +0000 (21:23 +0900)]
evas vg: correct caching last frame index.

lottie-player accepts range 0 to totalFrame,
so don't need to -1 here.

Change-Id: Ic92618717184bc51b8154db15f4e1400d1075960

5 years agoelm_slider: added check for existence of parts. 15/196615/1
Bowon Ryu [Wed, 2 Jan 2019 12:04:44 +0000 (21:04 +0900)]
elm_slider: added check for existence of parts.

Tizen has various UX themes according to profile and product.
For a theme that does not have a part,
such as elm.dragable2.slider, elm.units, elm.units.min, elm.units.max, etc.
Many error messages are generated.
This patch checks the existence of the part first and then does someting.

@tizen_only

Change-Id: Ia282db92f238fb749633acc43c94b88bc22ff886
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
5 years agoevas vg: ++safe code. 57/196557/2
Hermet Park [Wed, 2 Jan 2019 08:22:08 +0000 (17:22 +0900)]
evas vg: ++safe code.

null argument handling.

Change-Id: Iced2af61c505f3d5ea7f944dddb1f86d66c78f1d

5 years agoevas vg: fix typo.
Hermet Park [Wed, 2 Jan 2019 04:38:23 +0000 (13:38 +0900)]
evas vg: fix typo.

Change-Id: I9fde4e25b0a68c85016b6fa954d34b722d7a576b

5 years agoevas vg: ++safe code
Hermet Park [Wed, 2 Jan 2019 04:33:25 +0000 (13:33 +0900)]
evas vg: ++safe code

strong check validation of vg object.

Change-Id: Ib6364797d4b57d94cbf2c0dae331c2b8a6d66591

5 years agoevas json: optimizing by reusing node-tree. 32/196432/1
Hermet Park [Fri, 28 Dec 2018 08:46:09 +0000 (17:46 +0900)]
evas json: optimizing by reusing node-tree.

We assume that structure of node tree(scene-graph) is not changable,
its tree heirarchy would be same every frame.

In this case, we don't need to reconstruct vector nodes,
just resuse them of previous frames.

Change-Id: I2dc43fac7eb784fd895228ae2b16f25997fccfa9

5 years agoevas vg: stablizing parenting logic. 17/196417/1
Hermet Park [Fri, 28 Dec 2018 06:13:55 +0000 (15:13 +0900)]
evas vg: stablizing parenting logic.

Cleaned up the case when null parent is coming.

and found out efl_data_scope_get() could return invalid data
when invalid CLASS type is given. it's handled as well.

Change-Id: Ic8996ec547b0f82bf0ef572021964e6c4e72f801

5 years agoevas vg: more strict check for the argument. 16/196416/1
Hermet Park [Fri, 28 Dec 2018 04:38:36 +0000 (13:38 +0900)]
evas vg: more strict check for the argument.

a shape node must have vg node as the parent.

Change-Id: I3b477342f416a7229200f66f1b750cf31bda131b

5 years agoefl gfx_path: remove EFL_GFX_PATH_EVENT_CHANGED 70/195970/6
Hermet Park [Fri, 28 Dec 2018 03:20:15 +0000 (12:20 +0900)]
efl gfx_path: remove EFL_GFX_PATH_EVENT_CHANGED

Summary:
Here is an additional optmization patch for removing
unnecessary updation of path,

For instance, let's assume this scenario:

If one vg object has 20 path nodes(shapes),
and every single nodes would have 50 path changes.
(like, append_cubic, append_rect, append_xxx ...);
There would 1000 events triggering.

Furthermore, if there are 20 vector objects in one view,
hese events would be triggered 20000 in one frame.

It's insane, actually I could figured out that happens.
and it took a lot of cpu consumption in some vector usages.

efl_gfx_path_commit() is my idea to avoid this.
When path is ready, the path need to get this api call in the last
 to make object changed properly.

@feature

Reviewers: #committers, cedric

Reviewed By: #committers, cedric

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7494

Change-Id: Ie5353c360a8cfa1bd8b0fcdf6d20bd9b58144bd

5 years agoRevert "Revert "evas vg: optimize vg object internal connections."" 48/196348/1
Hermet Park [Thu, 27 Dec 2018 10:53:36 +0000 (19:53 +0900)]
Revert "Revert "evas vg: optimize vg object internal connections.""

This reverts commit ec7eb6951287ea4fc54e89a0960b904432a7680e.

fixed the wearable issue, recover this patch.

Change-Id: Id911bd3ec7d24cda46aaf3aa22e873b220c576c6

5 years agoRevert "evas vg: optimize vg object internal connections." 31/196331/1 submit/tizen/20181227.084356
SangHyeon Jade Lee [Thu, 27 Dec 2018 07:48:01 +0000 (16:48 +0900)]
Revert "evas vg: optimize vg object internal connections."

This reverts commit 90d311db9c5a7aeb2264073c4a45bcfdcc30c730.

Change-Id: Ie46f314940c37707a6708617e5f67db275001ed8
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
5 years agoRevert "Revert "ecore: make efl_loop_promise_new a function of Efl.Loop_Consumer.""
Carsten Haitzler (Rasterman) [Wed, 26 Dec 2018 17:47:47 +0000 (17:47 +0000)]
Revert "Revert "ecore: make efl_loop_promise_new a function of Efl.Loop_Consumer.""

This reverts commit 42e886d8d61d551bb544b777e6d254ce4dd3fcf1.

5 years agomeson - fix meson build to specifically link to GL or GLES
Carsten Haitzler (Rasterman) [Wed, 26 Dec 2018 17:36:03 +0000 (17:36 +0000)]
meson - fix meson build to specifically link to GL or GLES

these are explicit options to choose gl or gles. i found that evas
moduels were not linking to gles, but to GL even wiht gles enabled.

5 years agofix crashes created by "make efl_loop_promise_new a function"
Carsten Haitzler (Rasterman) [Tue, 25 Dec 2018 13:00:38 +0000 (13:00 +0000)]
fix crashes created by "make efl_loop_promise_new a function"

commit 9b5155c9f135f9ef450a817979f5884352b2d4c0 brought about crashes
- specifically that i saw in terminology because it actually uses
eina_promise_data_set() and the new efl_loop_promise_new basically
took over ownership of that data, but if anyone used
eina_promise_data_set() the data ptr used by this new code would bwe
overwritten, causing segfauls when terminology loses selection
ownership. for days i had mysterious crashes of terminology until i
narrowed it down to the above, so if you have too, then this will fix
it.

what this does is create a data set intercept function callback that
for now is only for use inside efl to everride data sets so they set
data inside the new struct that tracks data. i also had to add and
intercept for eina_promise_data_free_cb_set() as this in theory could
also ber a similar problem.

so perhaps the idea/design of efl_loop_promise_new() is not right and
this kind of thgn has to be internal to eina promise... this means
eina promise and loops are much more tied together.

5 years agoefl_ui: activate widget focus on efl.ui.item.
SangHyeon Jade Lee [Wed, 26 Dec 2018 10:45:44 +0000 (19:45 +0900)]
efl_ui: activate widget focus on efl.ui.item.

Summary:
Unlikely efl.ui.Layout, Item need to be focusable,
so it may traverse list by your command of focus moving.

Test Plan:
tested in
efl_ui_list_example_1.c
efl_ui_grid_example_1.c
check whether item show their focus properly.

scroll feature is not yet supported by efl_ui_scroll itself.

Reviewers: eagleeye, cedric, Hermet, felipealmeida, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: bu5hm4n, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7465

5 years agobuild: there have been missing build files
Marcel Hollerbach [Wed, 26 Dec 2018 11:31:19 +0000 (12:31 +0100)]
build: there have been missing build files

there are the 3 files in ecore. However, they have not been tested,
there are additionally no examples at all, which did not bring up the
missing API calls, now they are here.

Note: they are compiling, however, it seems that it is not working right
now.

5 years agoRevert "ecore: make efl_loop_promise_new a function of Efl.Loop_Consumer."
Marcel Hollerbach [Wed, 26 Dec 2018 11:15:21 +0000 (12:15 +0100)]
Revert "ecore: make efl_loop_promise_new a function of Efl.Loop_Consumer."

This reverts commit 9b5155c9f135f9ef450a817979f5884352b2d4c0.

For now lets revert this, this breaks copy and paste, further more it
has the potential to break a lot more things, as eio_model tends to use
efl_loop_promise new, and then eina_promise_data_set, which is
explicitly forbidden.

This fixes crashing terminology instances.

5 years agoRevert "efl gfx_path: remove EFL_GFX_PATH_EVENT_CHANGED"
Hermet Park [Wed, 26 Dec 2018 10:32:18 +0000 (19:32 +0900)]
Revert "efl gfx_path: remove EFL_GFX_PATH_EVENT_CHANGED"

This reverts commit 7c38c0c9154b0971ccb8ecf5ea8f15467cfb6662.

Oops, didn't intend this patch.

5 years agoevas textblock: fix render_pre bug related with clipper
Jiyoun Park [Wed, 26 Dec 2018 10:28:59 +0000 (19:28 +0900)]
evas textblock: fix render_pre bug related with clipper

Summary:
  assumtion: textblock A has the clipper rect B.

  1. evas_render_updates_internal start
   : evas_object_clip_dirty_do( rect B)
   : evas_object_textblock_render_pre( textblock A)
     - if textlock A's o->redraw is EINA_TRUE (o->changed=1 is also same case)
     - textblock A's vis 1->0
     - clipper rect B lose the chance to call render_pre function.
     - clipper rect B's evas_render_mapped function is not called
   : pending_change(Rect B)
     - obj->pre_render_done = 0, so rect cannot be get the change to call evas_object_change_reset

  when rect b remained the pending list and changed value is EINA_TRUE, it cause textblock's rendering problem

Reviewers: raster, Hermet, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7512

5 years agoefl gfx_path: remove EFL_GFX_PATH_EVENT_CHANGED
Hermet Park [Mon, 24 Dec 2018 05:31:05 +0000 (14:31 +0900)]
efl gfx_path: remove EFL_GFX_PATH_EVENT_CHANGED

Summary:
Here is an additional optmization patch for removing
unnecessary updation of path,

For instance, let's assume this scenario:

If one vg object has 20 path nodes(shapes),
and every single nodes would have 50 path changes.
(like, append_cubic, append_rect, append_xxx ...);
There would 1000 events triggering.

Furthermore, if there are 20 vector objects in one view,
hese events would be triggered 20000 in one frame.

It's insane, actually I could figured out that happens.
and it took a lot of cpu consumption in some vector usages.

efl_gfx_path_commit() is my idea to avoid this.
When path is ready, the path need to get this api call in the last
 to make object changed properly.

@feature

Reviewers: #committers, cedric

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7494

5 years agobuild: enable luajit per default like in autotools
Marcel Hollerbach [Fri, 21 Dec 2018 15:24:02 +0000 (16:24 +0100)]
build: enable luajit per default like in autotools

5 years agoefl gfx_path: introduce efl_gfx_path_reserve()
Hermet Park [Mon, 24 Dec 2018 04:52:13 +0000 (13:52 +0900)]
efl gfx_path: introduce efl_gfx_path_reserve()

Summary:
This method reserves path commands buffer in advance.
If user know the count of path commands coming,
they can reserve commands buffer in advance to avoid buffer growing job.

This reserved buffer would grow up by double size, if the buffer is full.

@feature

Reviewers: #committers, cedric

Reviewed By: #committers, cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7456

5 years agoefl-mono: Remove trailing () from doc references
Xavi Artigas [Fri, 21 Dec 2018 16:52:34 +0000 (17:52 +0100)]
efl-mono: Remove trailing () from doc references

Summary:
Some EO docs include () after a @method reference (some don't).
When the method reference is redered by DocFX it already includes
the trailing parenthese (and it even includes the parameter types),
so it looks very weird: Efl.Gfx.Stack.Raise()()

This patch removes the "()" string from any text comment following
an @ reference.

Test Plan:
Check DocFX docs for Efl.Gfx.Stack.Lower before and after this patch.
There are references to other methods which include the double parentheses.

Reviewers: lauromoura

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7504

5 years agoefl-mono: Remove warnings
Lauro Moura [Fri, 21 Dec 2018 15:04:43 +0000 (16:04 +0100)]
efl-mono: Remove warnings

Test Plan: run tests

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7501

5 years agoefl-mono: Use alternate docs when a property has no doc
Xavi Artigas [Fri, 21 Dec 2018 14:21:46 +0000 (15:21 +0100)]
efl-mono: Use alternate docs when a property has no doc

Summary:
Use the getter or the setter documentation when a property has no documentation.
This is not ideal (all properties should have documentation!) but at least we
have less undocumented properties.
See for example Efl.Canvas.Vg.Above.

Test Plan:
The Efl.Canvas.Vg.Above property in src/lib/evas/canvas/efl_canvas_vg_node.eo.cs
was previously undocumented because that property (inherited from Efl.Gfx.Stack)
has no docs, only its getter has docs.

Reviewers: lauromoura

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7500

5 years agodoc: Turn comments from EO to C# XML syntax
Xavi Artigas [Fri, 21 Dec 2018 13:52:11 +0000 (14:52 +0100)]
doc: Turn comments from EO to C# XML syntax

Summary:
This allows them to be nicely rendered by IDEs and automatic
documentation generators like DocFX.
The conversion includes things like turning $name to <c>name</c>
or solving references to objects, which in turn requires converting
from EO object names to C# names.

It uses the same helper methods used to generate the C# object names,
so if these change in the future, the references in the comments
will change too.

Additionally, this patch fixes some minor bugs, like <para> tags
outside <summary> tags, misspelled <returns> tags or missing <returns>
documentation for getter methods.

Fixes T7453

Reviewers: lauromoura, vitor.sousa

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7453

Differential Revision: https://phab.enlightenment.org/D7467

5 years agoecore: fix build by having proper parameters order.
Cedric BAIL [Thu, 20 Dec 2018 22:07:19 +0000 (14:07 -0800)]
ecore: fix build by having proper parameters order.

5 years agoecore: make efl_loop_promise_new a function of Efl.Loop_Consumer.
Cedric BAIL [Thu, 20 Dec 2018 00:35:24 +0000 (16:35 -0800)]
ecore: make efl_loop_promise_new a function of Efl.Loop_Consumer.

I am not sure this is the right way to do it as binding would have to likely
to bind it manually.

Reviewed-by: Lauro Neto <Lauro Moura <lauromoura@expertisesolutions.com.br>>
Differential Revision: https://phab.enlightenment.org/D7492

5 years agoeina: add a function to free Eina_Promise attached data when the promise is destroyed.
Cedric BAIL [Thu, 20 Dec 2018 00:25:38 +0000 (16:25 -0800)]
eina: add a function to free Eina_Promise attached data when the promise is destroyed.

Reviewed-by: Lauro Neto <Lauro Moura <lauromoura@expertisesolutions.com.br>>
Differential Revision: https://phab.enlightenment.org/D7491

5 years agoefl: fix function call order.
Cedric BAIL [Thu, 20 Dec 2018 19:47:28 +0000 (11:47 -0800)]
efl: fix function call order.

Reviewed-by: Marcel Hollerbach <marcel-hollerbach@t-online.de>
Differential Revision: https://phab.enlightenment.org/D7497

5 years agocmake: remove!
Marcel Hollerbach [Tue, 12 Dec 2017 10:22:47 +0000 (11:22 +0100)]
cmake: remove!

This build was never complete and also was not maintained probebly.

It is also dropped in favour of meson which is cool, merged, works & is fast.

Differential Revision: https://phab.enlightenment.org/D7010

5 years agomeson - vix ecore wl2 pc generation to not include nonexistent wl lib
Carsten Haitzler (Rasterman) [Thu, 20 Dec 2018 16:38:16 +0000 (16:38 +0000)]
meson - vix ecore wl2 pc generation to not include nonexistent wl lib

the ecore wl2.pc wanted to -lwayland_protocol ... which is never
installed. it's an in-tree .a we stattically link in, so remove it
from the pub libs in the pc. rthis was causing things that build
against efl to fail (like enlightenment).

5 years agoelementary: switch to the new efl_future_then syntax.
Cedric BAIL [Sat, 8 Dec 2018 00:03:49 +0000 (16:03 -0800)]
elementary: switch to the new efl_future_then syntax.

Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7448

5 years agoelementary: make all view generate an event when the item is created.
Cedric BAIL [Fri, 7 Dec 2018 23:51:30 +0000 (15:51 -0800)]
elementary: make all view generate an event when the item is created.

Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7447

5 years agoefl: add facility to generate an event when an item is created by the factory.
Cedric BAIL [Fri, 7 Dec 2018 23:51:09 +0000 (15:51 -0800)]
efl: add facility to generate an event when an item is created by the factory.

Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7446

5 years agoeina: use the correct type for casting to avoid issue on Windows.
Cedric BAIL [Fri, 14 Dec 2018 20:30:43 +0000 (12:30 -0800)]
eina: use the correct type for casting to avoid issue on Windows.

Reviewed-by: Vincent Torri <vincent.torri@gmail.com>
Differential Revision: https://phab.enlightenment.org/D7458

5 years agoeio-tests: fix deadlocking of the testsuite
Marcel Hollerbach [Tue, 4 Dec 2018 15:14:25 +0000 (16:14 +0100)]
eio-tests: fix deadlocking of the testsuite

what happens was is that efl_model_children_count_get trigger the
monitoring to start. However, that means that *sometimes* the created
file in this test was sometimes called in a ADDED event due to the
listing of files, and sometimes due to the event of a newly added file.
The problem here is that when the ADDED event is added due to the file
listing and not the monitoring, then there *could* be a ADDED event and
the deletion of the file will not trigger a REMOVED event. Which is a
bug.

However, up to this point it is not fully clear to me if this is
solvable with this setup of monitoring or not. So this test is changed
to not trigger this deadlock anymore, the idea of the test is still
tested, just in another way.

ref T7478

Differential Revision: https://phab.enlightenment.org/D7412

5 years agotheme: hide next and prev buttons when title is hidden
Marcel Hollerbach [Tue, 18 Dec 2018 14:05:01 +0000 (15:05 +0100)]
theme: hide next and prev buttons when title is hidden

This ensures that a button is hidden when not beeing able to be visible.

fixes T6891

Differential Revision: https://phab.enlightenment.org/D7420

5 years agoefl_app: introduce app_main for getting the app object
Marcel Hollerbach [Wed, 19 Dec 2018 19:02:08 +0000 (20:02 +0100)]
efl_app: introduce app_main for getting the app object

This brings in the possibility to receive the app object from bindings.
With the app object you can listen to pause / args / terminate / resume
events.

fix T7509

Differential Revision: https://phab.enlightenment.org/D7480

5 years agoelm_widget: remove defines that are not implemented
Marcel Hollerbach [Thu, 20 Dec 2018 10:55:19 +0000 (19:55 +0900)]
elm_widget: remove defines that are not implemented

Summary:
they are not implemented - so using them would not work, to me it looks
like they can be dropped.

Reviewers: cedric, raster, stefan_schmidt, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7455

5 years agotests: eolian_cxx: ensure property_holder.eo file lands in dist
Stefan Schmidt [Thu, 20 Dec 2018 10:49:50 +0000 (11:49 +0100)]
tests: eolian_cxx: ensure property_holder.eo file lands in dist

Summary:
In commit 98b716d0fa745fe5aa4d110615bf0dd90f695ddb the new file was
added but the autotools build system not made aware that it is needed in
dist as well. The missing file broke the eolian_cxx tes suite build in
distcheck.
Depends on D7477

Reviewers: lauromoura, q66

Reviewed By: q66

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7478

5 years agobuild: ensure we have a data_aux direcroy in our dist for the test eo files
Stefan Schmidt [Thu, 20 Dec 2018 10:45:15 +0000 (11:45 +0100)]
build: ensure we have a data_aux direcroy in our dist for the test eo files

Summary:
Due to our EXTRA_DIST2 crutch we need to handle the directory creation
on our won here. That was forgotten for the new data_aux folder in the
eolian tests. Creating it allows the files to be copied over and the
eolain seuite to pass in distcheck.

Reviewers: q66

Reviewed By: q66

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7477

5 years agoIntruduce Efl.Ui.Panel (Create Efl Ui Widget from elm widget(elm_panel))
Woochanlee [Thu, 20 Dec 2018 02:32:28 +0000 (11:32 +0900)]
Intruduce Efl.Ui.Panel (Create Efl Ui Widget from elm widget(elm_panel))

Summary: Create Efl Ui Widget from elm widget(elm_panel)

Test Plan: elementary_test -> efl_ui_panel

Reviewers: woohyun, Jaehyun_Cho, segfaultxavi

Reviewed By: Jaehyun_Cho, segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7238

5 years agodoc: Remove misplaced blank line
Xavi Artigas [Wed, 19 Dec 2018 12:51:55 +0000 (13:51 +0100)]
doc: Remove misplaced blank line

5 years agoevas: fix distcheck build of ector evas engine
Stefan Schmidt [Mon, 17 Dec 2018 16:13:24 +0000 (17:13 +0100)]
evas: fix distcheck build of ector evas engine

In commit fbe92aa67f18f8c0401cdc6d4440ed512c43b131 a dependency on the
software_generic header file was brought to the gl_generic module.
The include path to make this work was updated for meson but not for the
autotools build.

TravisCI distcheck builds found this for us.

Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D7468

5 years agobuild: make edje files dependencies of the theme
Marcel Hollerbach [Tue, 18 Dec 2018 15:07:24 +0000 (16:07 +0100)]
build: make edje files dependencies of the theme

this makes theme work way more easier

5 years agosilence most left over compiler warnings
Jérémy Zurcher [Tue, 18 Dec 2018 12:01:34 +0000 (13:01 +0100)]
silence most left over compiler warnings

Summary: silence -Wshadow -Wunused-variable -Wunused-parameter

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7473

5 years agoevas vg: fix indentation.
Hermet Park [Tue, 18 Dec 2018 06:25:24 +0000 (15:25 +0900)]
evas vg: fix indentation.

5 years agoefl_canvas_surface: change mixin to abstract
Jaehyun Cho [Tue, 18 Dec 2018 02:17:12 +0000 (11:17 +0900)]
efl_canvas_surface: change mixin to abstract

Summary:
If Efl.Canvas.Surface is changed from mixin to abstract, then its sub
classes do not need to inherit from Efl.Object to be a class.
Moreover, Efl.Canvas.Surface's data can be derived to its sub classes
easily.

Reviewers: jpeg, segfaultxavi, woohyun, Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7411

5 years agoevas_textblock: fix clipper bug related with textblock 14/196214/1
Jiyoun Park [Wed, 26 Dec 2018 08:14:10 +0000 (17:14 +0900)]
evas_textblock: fix clipper bug related with textblock

assumtion: textblock A has the clipper rect B.

1. evas_render_updates_internal start
 : evas_object_clip_dirty_do( rect B)
 : evas_object_textblock_render_pre( textblock A)
   - if textlock A's o->redraw is EINA_TRUE (o->changed=1 is also same case)
   - textblock A's vis 1->0
   - clipper rect B lose the chance to call render_pre function.
   - clipper rect B's evas_render_mapped function is not called
 : pending_change(Rect B)
   - obj->pre_render_done = 0, so rect cannot be get the change to call evas_object_change_reset

when rect b remained the pending list and changed value is EINA_TRUE, it cause textblock's rendering problem

https://phab.enlightenment.org/D7512

Change-Id: I3624b85c39d0d79b0175965d26739a3a91505c97

5 years agoevas json: replace legacy calls with interface calls. 52/196052/2
Hermet Park [Fri, 21 Dec 2018 04:15:09 +0000 (13:15 +0900)]
evas json: replace legacy calls with interface calls.

This helps to avoid internal path events triggerings.

Change-Id: I5cf05506e9c0d2772cb59755aca07356f688f994

5 years agoRevert "disable lottie-player" 72/195972/1
Hermet Park [Thu, 20 Dec 2018 07:23:24 +0000 (16:23 +0900)]
Revert "disable lottie-player"

This reverts commit 8b901ae906cd037171e56faed26deb0de1036912.

Enable again after resolving TC issue.

Change-Id: I719e1f8291bc89492a180b75c63d1b0556ddccfb

5 years agoevas vg: optimize vg object internal connections. 32/195832/3
Hermet Park [Thu, 20 Dec 2018 05:42:38 +0000 (14:42 +0900)]
evas vg: optimize vg object internal connections.

Dectected huge amount of unnecessray internal events triggering
which were signaled via vg nodes.

By events, nodes were connected with each others,
and finally reaches to vg object to update its rendering properly.

However GFX_PATH_CHANGE signal is too commonly triggered for scenarios,
listening and response it is too burdensome.

We acutally don't need to do this if all nodes could share the
vg object. Nodes directly notify vg object to update it.

Next patch will come to remove stupid GFX_PATH_CHANGE that's aweful
in performance wise.

Change-Id: I5b92d2c05986670999b690255b1eb41688c8fb39

5 years agoevas vg: fix indentation. 25/195825/2
Hermet Park [Tue, 18 Dec 2018 06:25:24 +0000 (15:25 +0900)]
evas vg: fix indentation.

Change-Id: Ib4a5c3132be9471aa7c489588dd78c2842c8301f

5 years agoecore_wl2_window: save set_config.geometry for client demand geometry changes 11/195911/5
Juyeon Lee [Wed, 19 Dec 2018 10:34:56 +0000 (19:34 +0900)]
ecore_wl2_window: save set_config.geometry for client demand geometry changes

fix for the consistancy of geometry set by the client itself

@tizen_only

Change-Id: Ida908a00ebea029797773727990ab6c987c8011f

5 years agodisable lottie-player 76/195876/1 accepted/tizen/unified/20181220.061729 submit/tizen/20181219.071252
Yeongjong Lee [Wed, 19 Dec 2018 06:21:11 +0000 (15:21 +0900)]
disable lottie-player

Change-Id: Ib4c922098ac252482095d9fc49fa7f66a1e352b6

5 years agobuild: make bindings cross compileable submit/tizen/20181218.080725
Marcel Hollerbach [Mon, 17 Dec 2018 16:30:40 +0000 (17:30 +0100)]
build: make bindings cross compileable

Differential Revision: https://phab.enlightenment.org/D7470

5 years agobuild: remove unused meson file
Marcel Hollerbach [Mon, 17 Dec 2018 16:29:38 +0000 (17:29 +0100)]
build: remove unused meson file

this was added by accident

Differential Revision: https://phab.enlightenment.org/D7469

5 years agomeson: Enable dev flags for cpp
Lauro Moura [Mon, 17 Dec 2018 13:26:47 +0000 (13:26 +0000)]
meson: Enable dev flags for cpp

Had to add a pragma around CityHash64 to make it work with
-f-visibility=hidden

Reviewed-by: Marcel Hollerbach <marcel-hollerbach@t-online.de>
Differential Revision: https://phab.enlightenment.org/D7466

5 years agoevas vg: remove redundant function code.
Hermet Park [Mon, 17 Dec 2018 10:59:29 +0000 (19:59 +0900)]
evas vg: remove redundant function code.

5 years agoeolian_mono: use System.Type explicitly
Jaehyun Cho [Mon, 17 Dec 2018 10:35:04 +0000 (19:35 +0900)]
eolian_mono: use System.Type explicitly

Previously, "Type" was used with "using System".
However, it caused ambiguity if some classes had "Type" property.

Therefore, "System.Type" is used explicitly to remove ambiguity.

5 years agoelm_gengrid: improve genlist behaviour
Marcel Hollerbach [Wed, 12 Dec 2018 18:08:44 +0000 (19:08 +0100)]
elm_gengrid: improve genlist behaviour

the new behaviour is (as genlist in the previous commit):
- focus the first item when down is pressed
- focus the last item when up is pressed
- do not go into the widget with tab or ctrl+tab and just return
immidiantly

fixes T6805

Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7454

5 years agoelm_widget_item_static_focus: fix ERR prints
Marcel Hollerbach [Wed, 12 Dec 2018 11:49:37 +0000 (12:49 +0100)]
elm_widget_item_static_focus: fix ERR prints

There is the case that the deletion of the adapter can cause another
registeration, which then calls another time prepare, which then deletes
the adapter, before the actaul deletion of the first efl_del happened,
which means it will throw an error. To avoid this we track if we are in
process of a unrealization, and if so, do not delete the item there.

Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7453

5 years agoelm_genlist: behaviour fixes for genlist
Marcel Hollerbach [Wed, 12 Dec 2018 11:49:19 +0000 (12:49 +0100)]
elm_genlist: behaviour fixes for genlist

This implements the behaviour in case no item is yet focused, but the
genlist is focused.

ref T6805

Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7452

5 years agoelm_gen****: fix focus restoring on window focus changes
Marcel Hollerbach [Tue, 11 Dec 2018 15:40:40 +0000 (16:40 +0100)]
elm_gen****: fix focus restoring on window focus changes

this ensures that if there is no focused item, that at least the
container is focused. This leads to the fact that the elm_genlist
/elm_gengrid is refocused when a window is unfocused and focused again.

Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7451

5 years agoefl_ui_focus_manager: performance optimize order setting
Marcel Hollerbach [Sat, 8 Dec 2018 13:54:48 +0000 (14:54 +0100)]
efl_ui_focus_manager: performance optimize order setting

setting the order is a little bit expensive, this performance optimizes
order setting in the focus manager.  We don't need to set the order each
time something is registered, it is enough to set it once we need the
correct order.

We don't need to evalulate the state in the Manager_Root_Focus if the
rect is not registered. If its not, then another new element cannot
cause the rect to be registered.

Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7450

5 years agoelm-test: add a test for checking the focus_next_object_set
Yeongjong Lee [Tue, 20 Nov 2018 15:44:15 +0000 (15:44 +0000)]
elm-test: add a test for checking the focus_next_object_set

The object which is set by elm_object_focus_next_object_set should be considered
first when focus moved.

ref T7389

Reviewed-by: Marcel Hollerbach <marcel-hollerbach@t-online.de>
Differential Revision: https://phab.enlightenment.org/D7310

5 years agoelm_focus: implement legacy targets for logical widgets
Marcel Hollerbach [Mon, 3 Dec 2018 15:28:05 +0000 (16:28 +0100)]
elm_focus: implement legacy targets for logical widgets

they are now handled. The list of parents is walked until a possible
candidate is found or the parent chain is the same then in the next
focused element.

fix T7389

Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7404

5 years agoelm_focus: implement elm_object_focus_next_item_set / get
Marcel Hollerbach [Mon, 3 Dec 2018 10:46:48 +0000 (11:46 +0100)]
elm_focus: implement elm_object_focus_next_item_set / get

you can use this now to let the focus move to the widget container of
the passed item.

I know this patch contains a whitespace change, but i have to get out
this whitespace each & every time i am editing the file - which is
annoying. So remove it once, which makes further work easier.

fixes T6183.

Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7408

5 years agoelm_config: fix valgrind warnings
Marcel Hollerbach [Wed, 12 Dec 2018 16:18:15 +0000 (17:18 +0100)]
elm_config: fix valgrind warnings

buf is only initializied, if on_flush is true.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D7449

5 years agobuild: add warnings and compiler flags to meson
Marcel Hollerbach [Fri, 7 Dec 2018 15:30:48 +0000 (16:30 +0100)]
build: add warnings and compiler flags to meson

this moves meson and autotools closer to each other. The flags are
selected in order to keep the amount of warnings low.

Differential Revision: https://phab.enlightenment.org/D7429

5 years agoevas gl - make GLintptr etc. also ndefed for GL_VERSION_1_5 fix typedef
Carsten Haitzler (Rasterman) [Sat, 15 Dec 2018 16:19:01 +0000 (16:19 +0000)]
evas gl - make GLintptr etc. also ndefed for GL_VERSION_1_5 fix typedef

It seems that GL_VERSION_1_5 define == these provided by gl already. At
least reading the mesa headers I do, so this should fix T7502

@fix

5 years agoefl-mono: Fix call of virtual methods after new API
Lauro Moura [Fri, 14 Dec 2018 22:39:09 +0000 (20:39 -0200)]
efl-mono: Fix call of virtual methods after new API

Summary:
After the new API, the virtual wrapper classes (*NativeInherit) just
declared the wrappers for the current class. But as they didn't have any
inheritance information, reimplementing methods from a parent Eo class
wouldn't work. (e.g. Efl.Ui.Button reimplementing Efl.Object
FinalizeAdd).

This commit changes these NativeInherit classes to mimic the inheritance
chain of their regular/abstract counterparts, reusing the virtual
wrapper implementations.

In order to access the correct Eo class created, the methods on it were
changed from static to instance methods. The instance will be held as a
class member of the regular/abstract API class to keep the delegates
alive and allow getting C Function pointers from them.

The class_initializer method was also split in two. The method
collecting the wrapper delegates was extracted in order to call the
parent ones.

Also avoid exception in cached strings queries as TryGetValue requires
non-null keys.

Test Plan: Run test suite.

Reviewers: vitor.sousa, felipealmeida

Reviewed By: vitor.sousa

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7460

5 years agoeolian-cxx: Add parent/extensions information to klass_def
Lauro Moura [Fri, 14 Dec 2018 20:52:56 +0000 (18:52 -0200)]
eolian-cxx: Add parent/extensions information to klass_def

Summary: Following new Eolian api.

Test Plan: Run newly added test

Reviewers: vitor.sousa, felipealmeida

Reviewed By: vitor.sousa

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7459

5 years agoeolian_mono: Add support for C# style properties
Lauro Moura [Fri, 14 Dec 2018 20:17:23 +0000 (18:17 -0200)]
eolian_mono: Add support for C# style properties

Summary: Syntatic sugar around the Get/Set functions for now.

Test Plan: Run efl-mono-suite

Reviewers: vitor.sousa, segfaultxavi, felipealmeida, Jaehyun_Cho

Reviewed By: vitor.sousa

Subscribers: cedric

Tags: #efl_language_bindings

Differential Revision: https://phab.enlightenment.org/D7394

5 years agoefl_ui_win: Don't allow the frame object to change size before first draw
Derek Foreman [Fri, 7 Dec 2018 16:46:11 +0000 (10:46 -0600)]
efl_ui_win: Don't allow the frame object to change size before first draw

This fixes a bug where calling:

evas_object_show(win);
evas_object_resize(win, 400, 400);
elm_run();

Would show a much smaller than 400,400 window on wayland, as the CSD
calcs would set the size smaller.

It also fixes some differences in startup size between X and wayland for
some trivial test clients.

Signed-off-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Reviewed-by: Chris Michael <cp.michael@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7438

5 years agoevas_render: Ignore objects on planes for rendering
Derek Foreman [Mon, 22 Oct 2018 15:37:35 +0000 (10:37 -0500)]
evas_render: Ignore objects on planes for rendering

We want to pretend they're just not there at this point since the
hardware is responsible for drawing them.

Signed-off-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D7198

5 years agoecore_wl2: Fix anchor for xdg pop-ups
Derek Foreman [Thu, 6 Dec 2018 15:54:10 +0000 (09:54 -0600)]
ecore_wl2: Fix anchor for xdg pop-ups

Anchors are in window geometry, so we should be using 0,0 instead
of the parent x,y for the top left corner of the window.

Signed-off-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Reviewed-by: Chris Michael <cp.michael@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7436

5 years agoee_wayland: Use object geometry instead of window geometry
Derek Foreman [Wed, 5 Dec 2018 16:34:01 +0000 (10:34 -0600)]
ee_wayland: Use object geometry instead of window geometry

wayland window geometry isn't currently being handled properly, but the
ecore_evas geometry should be correct and coherent.

Signed-off-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Reviewed-by: Chris Michael <cp.michael@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7435

5 years agoecore_evas: Validate shadow geometry
Derek Foreman [Wed, 5 Dec 2018 16:12:01 +0000 (10:12 -0600)]
ecore_evas: Validate shadow geometry

Negative values in shadow geometry make no sense at all, however it's
happening all the time in wayland.  Let's throw an ERR so it doesn't go
unnoticed.

Signed-off-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Reviewed-by: Chris Michael <cp.michael@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7434

5 years agogl_drm: use dlsym looked up symbol for extension check
Derek Foreman [Mon, 3 Dec 2018 19:25:30 +0000 (13:25 -0600)]
gl_drm: use dlsym looked up symbol for extension check

We looked this up with dlsym, so I guess we should use that even though
the direct call seems to work just fine most of the time.

Signed-off-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Reviewed-by: Chris Michael <cp.michael@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7433

5 years agoee_wayland: Replace set_config.geometry direct use with getters
Derek Foreman [Wed, 28 Nov 2018 20:19:56 +0000 (14:19 -0600)]
ee_wayland: Replace set_config.geometry direct use with getters

I'm going to deal with some ugly geometry problems in the getter func
shortly.

Signed-off-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Reviewed-by: Chris Michael <cp.michael@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7432

5 years agoecore_wl2: Replace direct usage of set_config.geometry with getters
Derek Foreman [Wed, 28 Nov 2018 20:18:45 +0000 (14:18 -0600)]
ecore_wl2: Replace direct usage of set_config.geometry with getters

I'm going to deal with some ugly geometry problems in the getter func
shortly.

Signed-off-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Reviewed-by: Chris Michael <cp.michael@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7431

5 years agoecore_wl2: remove uniconify path from ecore_wl2_window_iconified_set
Derek Foreman [Wed, 28 Nov 2018 20:12:27 +0000 (14:12 -0600)]
ecore_wl2: remove uniconify path from ecore_wl2_window_iconified_set

Wayland shells have no way to unset iconified state.  What this code
did was corrupt current window state in potentially fatal ways.

Signed-off-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Reviewed-by: Chris Michael <cp.michael@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7430

5 years agoevas_render: Ensure proper rendering when objects are on planes
Derek Foreman [Mon, 22 Oct 2018 15:35:39 +0000 (10:35 -0500)]
evas_render: Ensure proper rendering when objects are on planes

If only objects on planes change, we don't see any damage for the main
buffer, so a page flip never occurs and the plane doesn't update.  For
now forcing a tiny damage area is the easy way to work around this.

Also force a pixels get callback for enlightenment's surface frame
callback tracking.

Signed-off-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D7196

5 years agoevas_render: Render missing bits when plane state changes
Derek Foreman [Mon, 22 Oct 2018 15:33:35 +0000 (10:33 -0500)]
evas_render: Render missing bits when plane state changes

When we move an object into or off of a plane, we need the scene to be
rendered as if the object wasn't there.  This adds apprpopriate damage
to make that happen.

Signed-off-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D7195

5 years agoevas_render: Move plane setup code
Derek Foreman [Mon, 22 Oct 2018 15:32:24 +0000 (10:32 -0500)]
evas_render: Move plane setup code

Put this at the start of render so we can remove stuff on planes from
the scene graph entirely.  This stops us from drawing the entire object
underneat the plane.

Signed-off-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D7194

5 years agoevas_render: Refactor plane code
Derek Foreman [Mon, 22 Oct 2018 15:30:23 +0000 (10:30 -0500)]
evas_render: Refactor plane code

It's just tidier this way.

Signed-off-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D7193

5 years agoevas_object: Add function to test if hardware plane status changed
Derek Foreman [Mon, 22 Oct 2018 15:22:26 +0000 (10:22 -0500)]
evas_object: Add function to test if hardware plane status changed

This is used to check if an object has been put on or removed from a
hardware plane between calls.

Signed-off-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D7192

5 years agoevas_object: Add function to test if an object is on a hardware plane
Derek Foreman [Mon, 22 Oct 2018 15:20:28 +0000 (10:20 -0500)]
evas_object: Add function to test if an object is on a hardware plane

Signed-off-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D7190

5 years agomeson: fix build on power/ppc targets with altivec enabled
Daniel Kolesa [Sun, 9 Dec 2018 21:31:30 +0000 (22:31 +0100)]
meson: fix build on power/ppc targets with altivec enabled

5 years agomeson - systemd - fix check to systemd209+ checks that were not done
Carsten Haitzler (Rasterman) [Sat, 8 Dec 2018 04:47:06 +0000 (04:47 +0000)]
meson - systemd - fix check to systemd209+ checks that were not done

autofoo did these and set defines code relied on. meson did not. this
fixes that and makes meson do the same checks with the same defines.

5 years agoevas cpu - just rely on eina cpu entirely to avboid feature dups
Carsten Haitzler (Rasterman) [Sat, 8 Dec 2018 04:46:03 +0000 (04:46 +0000)]
evas cpu - just rely on eina cpu entirely to avboid feature dups

so evas cpu used to be the thing then eina cpu came and did the same
and evas cpu optionalyl could lsit on top... just move it all to eina
cpu so one central place does this and evas_cpu is purely a compat
wrapper.

5 years agoelementery: fix mouse selection of items in efl.ui.list_view
Leonardo Loch [Thu, 6 Dec 2018 16:28:41 +0000 (14:28 -0200)]
elementery: fix mouse selection of items in efl.ui.list_view

5 years agobuild: draw is using functions from rg_etc
Marcel Hollerbach [Fri, 7 Dec 2018 14:01:21 +0000 (15:01 +0100)]
build: draw is using functions from rg_etc

this means when you use draw you should automatically drag in rg_etc.

This fixes a build problem reported on irc.

5 years agoecore_con: no need for a long timeout when we know the test is supposed to timeout.
Cedric BAIL [Wed, 5 Dec 2018 18:47:06 +0000 (10:47 -0800)]
ecore_con: no need for a long timeout when we know the test is supposed to timeout.

Reviewed-by: Marcel Hollerbach <marcel-hollerbach@t-online.de>
Differential Revision: https://phab.enlightenment.org/D7422

5 years agoeo: fix efl_future_then example.
Cedric BAIL [Fri, 7 Dec 2018 12:22:31 +0000 (13:22 +0100)]
eo: fix efl_future_then example.

Summary: Depends on D7393

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7472

Differential Revision: https://phab.enlightenment.org/D7423