Pawel Wasowski [Wed, 12 Aug 2020 10:47:26 +0000 (12:47 +0200)]
[Bluetooth] Add validators for BluetoothGATTServer*InitData objects
This commit adds ValidateBluetoothGATT*Init() functions, that validate
BluetoothGATT{Service, Characteristic, Descriptor}Init objects and fill
optional fields with default values.
Verification: webapi-plugins build succeeds. Instantiating
tizen.bluetooth in Chrome Dev Tools succeeds.
The code will be further verified together with the code that relies on
it. Verification results will be reported in the next commits.
Change-Id: I1fc2017a8c970bd24a3cc3ef0a0c85ca7faf7569
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Pawel Wasowski [Wed, 12 Aug 2020 11:19:08 +0000 (13:19 +0200)]
[Bluetooth] Add BluetoothGATTServer{Service, Characteristic, Descriptor}
This commit adds 3 interfaces, used to represent GATT objects exposed by
the local server.
[Verification] webapi-plugins build succeeds. Instantiating
tizen.bluetooth in Chrome Dev Tools succeeds.
The code will be further verified together with the code that
relies on it. Verification results will be reported in the next commits.
Change-Id: I8c5dd6a6da6d213518d0eb46d3bb0ca3e37b4629
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Dawid Juszczak [Wed, 22 Jul 2020 16:11:06 +0000 (18:11 +0200)]
[Bluetooth] Rename BluetoothGATTService to BluetoothGATTClientService
[Verification] Each method implemented by BluetoothGATTClientService was
called in Chrome Dev Tools.
All auto Bluetooth and manual BLE tests pass.
Change-Id: I530e94aa40b294d43525aed50c9a19dde3c2a1c4
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Piotr Kosko [Tue, 25 Aug 2020 10:23:48 +0000 (10:23 +0000)]
Merge "[Bluetooth] Add BluetoothGATTServer. Implement start, stop and getServer" into tizen
Piotr Kosko [Mon, 24 Aug 2020 08:23:29 +0000 (10:23 +0200)]
[Common] Fixed initialization of non-static members
Related Coverity issue: 1146371
[Verification] Code compiles without errors.
Change-Id: I91da0bcdc083b83caa08ff69d9a9e31244aa1e0e
Pawel Wasowski [Mon, 6 Jul 2020 18:36:21 +0000 (20:36 +0200)]
[Bluetooth] Add BluetoothGATTServer. Implement start, stop and getServer
ACR: TWDAPI-263
This commit adds BluetoothGATTServer class in C++ and implements JS
APIs:
- tizen.bluetooth.getGATTServer()
- BluetoothGATTServer.start()
- BluetoothGATTServer.stop()
Verification: The code tested in the Chrome DevTools console works fine
Change-Id: I688df55298be1b5ec997a5ae8ff42877f1bd6a24
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
[version] 2.72
Change-Id: I55fb5aba0b6d4f43eebe205b9f1d0605d10b075b
Piotr Kosko [Wed, 29 Jul 2020 08:57:22 +0000 (08:57 +0000)]
Merge "[Common] Added cache for JS privilege checking" into tizen
[Common] Added cache for JS privilege checking
Commit improves the performance of asking for application privileges.
Values are cached.
[Verification]
Code compiles without errors.
Privilege TCT passrate 100%
Change-Id: Id1772d9b14e4d4ff07e6a7ca0993027b98a4f2f4
Piotr Kosko [Wed, 15 Jul 2020 05:10:46 +0000 (07:10 +0200)]
[Bookmark] Removed whole implementation of module.
By HQ decision whole module was removed.
[ACR] https://code.sec.samsung.net/jira/browse/TWDAPI-266
[Verification] Code compiles without errors.
Change-Id: Icff7a08dfb7250c2029de677be0373236e98812f
Piotr Kosko [Wed, 15 Jul 2020 05:02:39 +0000 (07:02 +0200)]
[version] 2.71
Change-Id: I2fdcec5a0ca7e43cf24be3b8863f24b99b939dca
Piotr Kosko [Wed, 15 Jul 2020 04:50:06 +0000 (04:50 +0000)]
Merge "[common][utils] Add new helper methods" into tizen
Arkadiusz Pietraszek [Tue, 14 Jul 2020 15:25:28 +0000 (17:25 +0200)]
[utils] Remove of unused functions ValidateMethod and ValidateArguments
ValidateMethod and ValidateArguments functions located in utils_api.js are not used anywhere in Web API code.
[Verification] Grep search does not find any occurences of those
functions.
Change-Id: Ifad5f7005e82fb31e1c44c73dbed3a363d25d4ad
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@samsung.com>
Piotr Kosko [Tue, 14 Jul 2020 10:13:25 +0000 (10:13 +0000)]
Merge "[6.0][Bluetooth] Representation of binary data unification" into tizen
Arkadiusz Pietraszek [Fri, 24 Apr 2020 13:38:11 +0000 (15:38 +0200)]
[6.0][Bluetooth] Representation of binary data unification
Currently binary data is passed to functions and received in return as different types.
This API change has been designed to unify binary data handling across Bluetooth module.
Adding type:
typedef (byte[] or DOMString or Uint8Array) Bytes;
Adding functions:
byte[] toByteArray(Bytes);
DOMString toDOMString(Bytes);
Uint8Array toUint8Array(Bytes);
Changing functions signatures:
BluetoothLEServiceData(DOMString uuid, Bytes data);
BluetoothLEManufacturerData(DOMString uuid, Bytes data);
void BluetoothGATTCharacteristic::writeValue (Bytes value, optional SuccessCallback? successCallback, optional ErrorCallback? errorCallback);
void BluetoothGATTDescriptor::writeValue (Bytes value, optional SuccessCallback? successCallback, optional ErrorCallback? errorCallback);
unsigned long BluetoothSocket::writeData(Bytes);
[ACR]
https://code.sec.samsung.net/jira/browse/TWDAPI-259
[Verification]
Automatic bluetooth tct pass rate 100%
Unit tests for new functions added
Change-Id: I31e436149ecab6c4b7223ba493d13638cd707851
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@samsung.com>
Arkadiusz Pietraszek [Mon, 4 May 2020 12:03:12 +0000 (14:03 +0200)]
[6.0] Replace deprecated validateMethod with validateArgs
https://code.sec.samsung.net/jira/browse/XWALK-2102
Changed modules:
alarm
application
humanactivitymonitor
inputdevice
iotcon
playerutil
power
time
tvinputdevice
widgetservice
[verification]
tct-pass rate did not change.
It is 100% for all changed modules, except playerutil, that crashes after argument validation.
Related task: https://code.sec.samsung.net/jira/browse/TSIX-3440
Change-Id: I805e92857cea9da7580c2bd3117227b1a5abb514
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@samsung.com>
Piotr Kosko [Wed, 8 Jul 2020 09:23:30 +0000 (11:23 +0200)]
[version] 2.70
Change-Id: Ibdd3c4eef53bedffdb629532b162e9c987ae9630
Piotr Kosko [Wed, 8 Jul 2020 09:22:14 +0000 (11:22 +0200)]
[Bluetooth] Fix build break for disabled APP_CONTROL_SETTINGS_SUPPORT
[Verification] Plugins for TV platform build with the change and
APP_CONTROL_SETTINGS_SUPPORT flag.
Change-Id: I23b87954b877ae278970446a03bc94ffe16c9aed
[Metadata] Changed path property to uri
* removed not used variables in js file
* path renamed with uri
* some helper functions moved from instance.cc to metadata_file_handle.cc
[Verification] Checked in chrome console
Change-Id: I560cd2b4c2c176b5386c53dd94d50b20a274732b
[Metadata] Implementation of get() and release()
Implementation supports release() which frees all resources allocated
for metadata extraction.
Implementation supports get() for gathering metadata values. If get is called
after release(), API automatically recreates all handles for file.
[ACR] https://code.sec.samsung.net/jira/browse/TWDAPI-265
[Verification] Chcecked in chrome console:
> m = tizen.metadata.createFileHandle("file:///home/owner/media/Videos/mp4video_mp3audio.mp4")
> m.get("DURATION")
> m.release()
> m.get("DURATION")
> m.get("VIDEO_WIDTH")
> m.release()
Change-Id: I2ed27a7c8009325817c32c993f5f8d4f00cd063e
Pawel Wasowski [Mon, 15 Jun 2020 08:14:00 +0000 (10:14 +0200)]
[common][utils] Add new helper methods
This commit adds 2 helper methods, that may be used from all modules:
- (JS) NativeManager.getErrorObjectAndValidate(), that creates a
WebAPIException from the data sent from C++ layer. If the exception is
not among valid exceptions passed to this function, it is replaced with
a default value (e.g. UnknownError). A list of exceptions/errors,
defined for a function in the documentation can be passed as the list of
valid exceptions to ensure, that the function will only report errors
defined in the documentation.
- (C++) PlatformResult::SetMessage() method to set the error message.
This commit also allows to use JS console.assert() through
xwalk.utils.assert().
[Verification] The code compiles. I use it in the next commit and the
code works fine.
Change-Id: If2291a4123b3235971ff1f1f1c69320bbb1ee167
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
[Metadata] Implementation of handles management
Implementation supports creation a handle for a file, with returned
basic structure of MetadataFileHandle.
[ACR] https://code.sec.samsung.net/jira/browse/TWDAPI-265
[Verifcation] Code compiles without errors.
Checked with Chrome console.
Change-Id: I421afbed3b618e7d376b9a93a8cf484d334a72b2
[Metadata] Created template of module
[ACR] https://code.sec.samsung.net/jira/browse/TWDAPI-265
[verification] Code compiles and module is visible in Web application.
Change-Id: Ic4697a0e5af8dc6a4204a7fd5947f1cdadc8c477
Pawel Wasowski [Wed, 29 Jan 2020 14:38:38 +0000 (15:38 +0100)]
[Bluetooth] Add or modify uuid fields of BLE GATT objects
This commit adds uuid field to BluetoothGATTCharacteristic and
BluetoothGATTDescriptor objects and serviceUuid to BluetoothGATTService.
uuid values of BluetoothGATT{Characteristic, Descriptor} and
BluetoothGATTService::serviceUuid default to null,
if Web API implementation is unable to retrieve them from Native API.
There are more UUID fields in Bluetooth API objects, but have not been
made nullable. We expect values of BluetoothLEServiceData::uuid,
BluetoothSocket::uuid, BluetoothServiceHandler::uuid fields
to be valid, if the objects containing them are created successfully.
Related ACR: TWDAPI-255
[Verification] tct-bluetooth-tizen-tests auto: 100%;
manual Bluetooth04_BLE_wearable: 100%
Change-Id: I4c7fe4e8b4507f07f58c0fb043081eb6d93c933c
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Piotr Kosko [Tue, 16 Jun 2020 10:40:38 +0000 (10:40 +0000)]
Merge "[Bluetooth][ACR: TWDAPI-256] Sanitize UUIDs in BLE APIs" into tizen
Piotr Kosko [Tue, 16 Jun 2020 10:39:18 +0000 (10:39 +0000)]
Merge "[Bluetooth] Fix onnamechanged callback" into tizen
Piotr Kosko [Tue, 16 Jun 2020 10:38:45 +0000 (10:38 +0000)]
Merge "[Bluetooth] Fix onvisibilitychanged callback" into tizen
Piotr Kosko [Tue, 16 Jun 2020 10:37:55 +0000 (10:37 +0000)]
Merge "[Bluetooth] Fix onstatechanged callback" into tizen
Piotr Kosko [Wed, 10 Jun 2020 11:19:07 +0000 (13:19 +0200)]
[Systeminfo] Fixed behaviour of Network property
[Bug] When using device with not supported feature
http://tizen.org/feature/network.telephony
e.g. R800 device, below code returns no error:
tizen.systeminfo.getPropertyValueArray("NETWORK", (s) => {console.log(s)}, (s) => {console.log(s)})
listener for "NETWORK" property is never triggered also:
tizen.systeminfo.addPropertyValueChangeListener("NETWORK", (s) => console.log(s));
[verification]
Systeminfo TCT 100% passrate.
After fix, listener and getter works properly on TW3.
Change-Id: I9f0d533055926d186305fb7c39418de1fed76f5b
Dawid Juszczak [Wed, 8 Apr 2020 08:53:15 +0000 (10:53 +0200)]
[Bluetooth] Fix onnamechanged callback
https://code.sec.samsung.net/jira/browse/XWALK-2065
[Description]
+ removed unnecessary calls of onnamechanged of BluetoothAdapterChangeCallback
+ refactor setName function
[Verification]
+ tested manually on chrome console
+ tct-bluetooth-tizen-tests (auto) 100% PASS
Change-Id: Iaca69d08d18cc95d1f624678873a3d6f9ae2c575
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Mon, 8 Jun 2020 18:14:47 +0000 (20:14 +0200)]
[Bluetooth] Fix onvisibilitychanged callback
https://code.sec.samsung.net/jira/browse/XWALK-2065
[Description]
+ removed unnecessary calls of onvisibilitychanged of BluetoothAdapterChangeCallback
+ refactor setVisible function
[Verification]
+ tested manually on chrome console
+ tct-bluetooth-tizen-tests (auto) - 100% PASS
Change-Id: I7edcb5a1028fec68d917a9b0e91a18c4d0d5294c
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Wed, 8 Apr 2020 08:14:22 +0000 (10:14 +0200)]
[Bluetooth] Fix onstatechanged callback
https://code.sec.samsung.net/jira/browse/XWALK-2065
[Description]
+ removed unnecessary calls of onstatechanged of BluetoothAdapterChangeCallback
+ refactor setPowered function
[Verification]
+ tested manually on chrome console
+ tct-bluetooth-tizen-tests (auto) - 100% PASS
Change-Id: I4109151dd805c06aab3c73d1eb55ae4236391ab4
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Pawel Wasowski [Thu, 27 Feb 2020 10:47:47 +0000 (11:47 +0100)]
[Bluetooth][ACR: TWDAPI-256] Sanitize UUIDs in BLE APIs
The ACR defines ways, in which Bluetooth APIs will handle UUIDs passed
as arguments and returned from functions and adds clarifications about
converisons of UUIDs passed to the Web API, that are made before
advertising.
It also adds tizen.bluetooth.BASE_UUID constant.
APIs modified in this commit:
BluetoothLEDevice::getService():
- now it accepts UUIDs in any of the 3 formats defined in BluetoothUUID
BluetoothLEDevice::getServiceAllUuids():
- a bugfix and slight change of behavior:
In the past, this function has always trimmed UUIDs retrieved
from native API to 16 bit format. In case of UUIDs not built with
Bluetooth's BASE_UUID the conversions were erroneous, for example:
"
198d3a9c-e21a-4f72-a48b-
39a6bad7e583" was converted to "3a9c" which
(almost surely) did not correspond to any service on the device.
The function now returns UUIDs in their shortest formats.
BluetoothLEAdvertiseData::uuids and
BluetoothLEAdvertiseData::solicitationuuids:
- now they accept UUIDs in any of the 3 formats defined in
BluetoothUUID
BluetoothLEAdvertiseData::serviceData:
- it accepts UUIDs in any of the 3 formats defined in BluetoothUUID
Verification: tct-bluetooth-tizen-tests pass rate:
Auto: 100% (BLE suite)
Manual: 10/11 tests passed. The fail is due to a bug in TCT tests
Manual tests in Chrome DevTools:
tizen.bluetooth.BASE_UUID exists and its value is correct
BluetoothLEAdapter::startAdvertise:
BluetoothLEAdvertiseData::uuids:
16 bit: advertised as 16 bit (OK)
32 bit: advertised as 32 bit
Random 128 bit: advertised as 128 bit (OK)
16 bit as 128 bit: advertised as 16 bit (OK)
32 bit as 128 bit: advertised as 32 bit
BluetoothLEAdvertiseData::solicitationuuids:
16 bit: advertised as 16 bit (OK)
32 bit: advertised as 32 bit
Random 128 bit: advertised as 128 bit (OK)
16 bit as 128 bit: advertised as 16 bit (OK)
32 bit as 128 bit: advertised as 32 bit
BluetoothLEAdvertiseData::BluetoothLEServiceData::uuid:
16 bit: advertised as 16 bit (OK)
32 bit: InvalidValuesErrror, Invalid parameter (OK)
Random 128 bit: InvalidValuesErrror: Invalid parameter (OK)
16 bit as 128 bit: advertised as 16 bit (OK)
32 bit as 128 bit: InvalidValuesErrror: Invalid parameter (OK)
BluetoothLEAdapter::startScan() and BluetoothLEScanCallback():
BluetoothLEDevice::uuids:
16 bit: found as 16 bit (OK)
32 bit: not found at all (OK - native API does not support detecting
32 bit UUIDs at all)
Random 128 bit: found as 128 bit (OK)
16 bit as 128 bit: found as 128 bit (OK)
32 bit as 128 bit: found as 128 bit (OK)
BluetoothLEDevice::solicitationuuids:
16 bit: found as 16 bit (OK)
32 bit: not found at all (OK - native API does not support detecting
32 bit UUIDs at all)
Random 128 bit: found as 128 bit (OK)
16 bit as 128 bit: found as 128 bit (OK)
32 bit as 128 bit: found as 128 bit (OK)
BluetoothLEDevice::BluetoothLEServiceData::uuid:
16 bit: found as 16 bit (OK)
32 bit: not found at all (probably OK - native API supports only 128
bit UUIDs)
Random 128 bit: not found at all (native support for 128 bit UUIDs
will be introduced in Tizen 6.0)
16 bit as 128 bit: not found at all (native support for 128 bit UUIDs
will be introduced in Tizen 6.0)
32 bit as 128 bit: not found at all (native support for 128 bit UUIDs
will be introduced in Tizen 6.0)
BluetoothLEDevice::getServiceAllUuids():
16 bit: found as 16 bit (OK)
32 bit:
According to the Bluetooth Core Specification (Version 5.2, Vol 3, Part G,
chapter 3.1 "Service Definition"), GATT servers can only provide 16
and 128 bit services, so a 32 bit service UUID could not be created.
Random 128 bit: found as 128 bit (OK)
16 bit as 128 bit: found as 16 bit (OK)
32 bit as 128 bit: found as 32 bit (OK)
BluetoothLEDevice::getService(): TEST 1 - passing UUID as a parameter:
16 bit to retrieve 16 bit service: OK
16 bit to retrieve 128 bit built with BASE_UUID service: OK
128 bit to retrieve 128 bit built with BASE_UUID service: OK
Random 128 bit: OK
BluetoothLEDevice::getService(): TEST 2 - the value of
BluetoothGATTService::uuid:
The same as passed to the getService() for all cases.
BluetoothLEDevice::getService(): TEST 3 - values of
BluetoothGATTService::uuid in the
service objects from services
included in a service
I was unable to test this functionality. I have tried to create a
GATT service incluing secondary services, but was unable to do that neither
using a BLE adapter and bluetoothctl command on my PC, nor the Android app
I use for tests.
Change-Id: Ic0b75867cb4be3e2fb3fa9ea046b515503363edb
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Piotr Kosko [Tue, 2 Jun 2020 06:03:26 +0000 (06:03 +0000)]
Merge "[Bluetooth] Add changeListener flag in c++ layer" into tizen
Piotr Kosko [Tue, 2 Jun 2020 05:57:40 +0000 (05:57 +0000)]
Merge "[6.0][Bluetooth] Add JS functionalities enabling conversions and comparisons of UUIDs" into tizen
Piotr Kosko [Fri, 29 May 2020 10:21:19 +0000 (12:21 +0200)]
Merge branch 'tizen_5.5' into tizen
Change-Id: I633089bf180dcb69725ba092f6a62a6630ce335f
Piotr Kosko [Fri, 29 May 2020 10:07:56 +0000 (12:07 +0200)]
Merge branch 'tizen_5.0' into tizen_5.5
Change-Id: I2fcaac28cd70e48e7007c3db1a5d15bd30f85dbf
Piotr Kosko [Fri, 29 May 2020 10:06:12 +0000 (12:06 +0200)]
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: If003c06d7b3ed61e67b370011b59993e7f211d69
Piotr Kosko [Fri, 29 May 2020 09:59:52 +0000 (11:59 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I00cb2f4c2c127315e11546b3d244f25208f921f3
Piotr Kosko [Fri, 29 May 2020 09:11:31 +0000 (11:11 +0200)]
[version] 2.42
Change-Id: I21e64688f0d19c08c7ce6ce28b1c1209c3c3d04d
Michal Michalski [Thu, 28 May 2020 11:47:22 +0000 (13:47 +0200)]
[archive] Fix paths comparator for permissions dictionary.
[Verification] tct-archive-tizen-tests 100% pass rate on TM1 emulator.
Change-Id: I675857a5f1335d8fb28a623ff15edc2d6d1aa8b5
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Piotr Kosko [Tue, 26 May 2020 10:48:06 +0000 (12:48 +0200)]
Merge branch 'tizen_5.5' into tizen
Change-Id: I7cea95dc5be02242ee425f417cf692f5e8b8edb1
Piotr Kosko [Tue, 26 May 2020 10:24:42 +0000 (10:24 +0000)]
Merge "[version] 2.64" into tizen_5.5
Piotr Kosko [Tue, 26 May 2020 10:24:21 +0000 (10:24 +0000)]
Merge "[5.5][humanactivitymonitor] Deprecate STRESS_MONITOR" into tizen_5.5
Dawid Juszczak [Fri, 22 May 2020 17:58:09 +0000 (19:58 +0200)]
[5.5][humanactivitymonitor] Deprecate STRESS_MONITOR
[ACR]
https://code.sec.samsung.net/jira/browse/TWDAPI-262
[Description]
Deprecated methods:
- addStressMonitorChangeListener()
- removeStressMonitorChangeListener()
Deprecated interfaces:
- HumanActivityStressMonitorData
- StressMonitorDataRange
- stressMonitorListener
[Verification]
builds witout errors
Change-Id: I3adffddcca970cb668a65bbb1254564a3bde30b1
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
[version] 2.64
Change-Id: I9edf53a093e350c02ca9e7ff522c33412e6d5951
Dawid Juszczak [Fri, 22 May 2020 17:58:09 +0000 (19:58 +0200)]
[6.0][humanactivitymonitor] Deprecate STRESS_MONITOR
[ACR]
https://code.sec.samsung.net/jira/browse/TWDAPI-262
[Description]
Deprecated methods:
- addStressMonitorChangeListener()
- removeStressMonitorChangeListener()
Deprecated interfaces:
- HumanActivityStressMonitorData
- StressMonitorDataRange
- stressMonitorListener
[Verification]
builds witout errors
Change-Id: I3adffddcca970cb668a65bbb1254564a3bde30b1
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
[Application] Fixed behaviour of clearing data for reply callbacks
[Bug] Issue reported by PLM P200525-06256
When application suspends the reply callback, e.g. because of waiting for
user interaction, the data for callback was released too early. This caused
that everytime when reply callback is delayed, data was already freed and it
caused crash of application.
[Fix] Issue was fixed with saving pointers for releasing during manager destruction.
[Verification] PLM application has no longer any issues.
TCT passrate is 100%.
Change-Id: I575ab5f9ce4ccd0ce0bff0e6e9bdc15cadc09ed5
Piotr Kosko [Thu, 21 May 2020 04:25:06 +0000 (06:25 +0200)]
[version] 2.63
Change-Id: I6495eef497d12b3753236115ca371a6dd2da0847
Piotr Kosko [Thu, 14 May 2020 11:32:43 +0000 (13:32 +0200)]
[mediacontroller] Fix to handle changed behaviour of native API
Native API was returning invalid pointer in case when metadata was
missing. This caused passing junk data to WebAPI. Now native API returns
null if metadata is missing. Unfortunately, Web API design does not
allow null value for metadata members. To workaround this problem, we
just pass empty strings to Javascript.
[Verification] mediacontroller TCT passrate 100%.
Change-Id: Icb6813c10bc74caff4cecca2cbc6b55788f08a92
Piotr Kosko [Fri, 15 May 2020 04:27:37 +0000 (06:27 +0200)]
[version] 2.67
Change-Id: I497d50336fc06b5fe7f140fcbe13b818230e0bbb
Piotr Kosko [Thu, 14 May 2020 11:32:43 +0000 (13:32 +0200)]
[mediacontroller] Fix to handle changed behaviour of native API
Native API was returning invalid pointer in case when metadata was
missing. This caused passing junk data to WebAPI. Now native API returns
null if metadata is missing. Unfortunately, Web API design does not
allow null value for metadata members. To workaround this problem, we
just pass empty strings to Javascript.
[Verification] mediacontroller TCT passrate 100%.
Change-Id: Icb6813c10bc74caff4cecca2cbc6b55788f08a92
Arkadiusz Pietraszek [Thu, 2 Apr 2020 12:03:08 +0000 (14:03 +0200)]
[6.0][Bluetooth] Add JS functionalities enabling conversions and comparisons of UUIDs
Added functions:
uuidTo128bit
uuidToShortestPossible
uuidsEqual
Related ACR: TWDAPI-258
[Verification]
Function tested manually in console.
Unit test added:
+ test_UUIDTo128bit.js
+ test_UUIDToShortestPossible.js
+ test_UUIDsEqual.js
pass rate is 100%
Change-Id: I2e41443d4ad5eeb8997a5381901af2c2f96151c8
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@samsung.com>
Piotr Kosko [Fri, 8 May 2020 10:52:00 +0000 (12:52 +0200)]
[iotcon] Fix timeout error
Missing break statement caused crash on iotcon error.
Verification: Build succesfull, TCT 100% pass
Change-Id: I5a20c2506007954874725da59869f15fe1fb4ab6
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
(cherry picked from commit
b597711b9a85bdadc321d5709d05de0d0ac85888)
Piotr Kosko [Fri, 8 May 2020 12:17:20 +0000 (12:17 +0000)]
Merge "[iotcon] Fix timeout error" into tizen
Piotr Kosko [Fri, 8 May 2020 10:52:00 +0000 (12:52 +0200)]
[iotcon] Fix timeout error
Missing break statement caused crash on iotcon error.
Verification: Build succesfull, TCT 100% pass
Change-Id: I5a20c2506007954874725da59869f15fe1fb4ab6
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Piotr Kosko [Thu, 30 Apr 2020 10:33:44 +0000 (10:33 +0000)]
Merge "[Bluetooth] Add uuid_in_source_format field to UUID class" into tizen
Piotr Kosko [Wed, 29 Apr 2020 11:58:16 +0000 (11:58 +0000)]
Merge "[Bluetooth][Minor] Replace deprecated ValidateMethod with ValidateArgs" into tizen
Arkadiusz Pietraszek [Mon, 27 Apr 2020 13:15:32 +0000 (15:15 +0200)]
[Bluetooth][Minor] Replace deprecated ValidateMethod with ValidateArgs
https://code.sec.samsung.net/jira/browse/TSIX-3080
[Verification] tct pass rate 100%
Change-Id: Icf77d6ebaad1d54c147b03696f50df1a0678d600
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@samsung.com>
Arkadiusz Pietraszek [Thu, 16 Apr 2020 09:36:47 +0000 (11:36 +0200)]
[Bluetooth] Implementation of MAC address validator fix
Functions IsValidAddress() and IsValidUUID have been fixed.
[Verification]
Code compiles without errors. Functions tested manually in developer console.
Change-Id: I3e975f6ea08061528ef5b6cfe14e8a6f814e693c
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@samsung.com>
Piotr Kosko [Thu, 9 Apr 2020 08:10:38 +0000 (08:10 +0000)]
Merge "[Bookmark] Added deprecation warnings" into tizen
Dawid Juszczak [Wed, 8 Apr 2020 07:14:43 +0000 (09:14 +0200)]
[Bluetooth] Add changeListener flag in c++ layer
https://code.sec.samsung.net/jira/browse/XWALK-2065
[Description]
+ add flag to c++ layer about set callback
[Verification]
tct-bluetooth-tizen-tests (auto) 100% PASS
Change-Id: I5588a613951a20f1e5d45ee16faea4d5b4019d3c
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Rafal Walczyna [Thu, 2 Apr 2020 07:59:47 +0000 (09:59 +0200)]
[Tools] Add script for SAM with SVACE 3.0 engine
Change-Id: I421dad53fc79ae0ab45d26b4b9c75af0f2a1f725
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Pawel Wasowski [Fri, 3 Apr 2020 09:49:12 +0000 (11:49 +0200)]
[Bluetooth] Add uuid_in_source_format field to UUID class
Some legacy functions have returned UUID in the very same format,
they get it from the user. In order to preserve backward compatibility,
we cannot return this UUID in another form and we have to keep
the UUID in source format in UUID object.
Change-Id: Ia2668aaa331ddfd3331ffe7c42133e8a97cb06bc
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Piotr Kosko [Wed, 1 Apr 2020 11:25:38 +0000 (13:25 +0200)]
[Bookmark] Added deprecation warnings
Whole module is deprecated since 6.0 - added warnings for C++ and JS
layers.
[ACR] https://code.sec.samsung.net/jira/browse/TWDAPI-257
[Verification] Code compiles without errors.
Change-Id: Iea2fb030b2876e0546273adf17b0f6e7c43ec296
Piotr Kosko [Thu, 26 Mar 2020 10:33:02 +0000 (11:33 +0100)]
Merge branch 'tizen_5.5' into tizen
Change-Id: Id8bcb09c4bf225bb80726a922deee7b30733d0a6
Piotr Kosko [Thu, 26 Mar 2020 10:25:26 +0000 (11:25 +0100)]
Merge branch 'tizen_5.0' into tizen_5.5
Change-Id: I4e6eafdfe9c3fc56deed4d50b0a99c08ab877bb6
Piotr Kosko [Thu, 26 Mar 2020 09:09:19 +0000 (10:09 +0100)]
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: Iba85c9ce0c49127d8cbe14687d6e21cb5e9bb444
Piotr Kosko [Thu, 26 Mar 2020 08:32:14 +0000 (09:32 +0100)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Ifbd17f0ca3fcaa5922f6a2194c5f2ffc007ee1c6
Piotr Kosko [Thu, 26 Mar 2020 08:30:38 +0000 (09:30 +0100)]
[version] 2.41
Change-Id: If5ba0f4ac89de2b51259a0a94be4a3a2f156e5a5
Piotr Kosko [Thu, 26 Mar 2020 07:41:59 +0000 (08:41 +0100)]
[Alarm] Fixed Coverity issue and undefined behaviour
[Coverity] 1134493
Change-Id: I3c9aa41a640efc6ca001ea96978374994a88e029
Piotr Kosko [Tue, 24 Mar 2020 11:51:10 +0000 (12:51 +0100)]
Merge branch 'tizen_5.5' into tizen
Change-Id: I9ee6e22707bc89ff0191164b97d157b2fa072e1e
Piotr Kosko [Tue, 24 Mar 2020 11:01:40 +0000 (12:01 +0100)]
[version] 2.61
Change-Id: I45017805b30ec6e0afd49f4f07f895b6d0949949
Piotr Kosko [Tue, 24 Mar 2020 09:48:55 +0000 (10:48 +0100)]
[application] Fixing memory management for app_control_send_launch_request_async
[Bug] Order of reply and result callbacks is not defined (because both
signals come from different processes). This causes that we cannot just
release the memory in well defined way. Thus we added delay for removing
a data passed to callbacks to prevent crash.
[Verification] application tct passrate 100%
deprecate tct passrate 100%
Verified manually with application from PLM issue P200214-04877
Change-Id: Id50e80f7aecbaa9a01d46258f4f2a8eabe322409
Pawel Wasowski [Fri, 28 Feb 2020 13:43:19 +0000 (14:43 +0100)]
[Bluetooth] Add unit tests for UUID class
Change-Id: I28bcc5e0bc48eb613a9076e93e6d68abe27cdc13
Verification: tests build; pass rate: 100%
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Pawel Wasowski [Fri, 28 Feb 2020 13:02:25 +0000 (14:02 +0100)]
[Bluetooth] Add UUID class
UUID class will handle validation of string UUIDs and conversions
between different UUID formats.
Verification: unit tests (added in the next commit) pass rate: 100%
Change-Id: Ie075379d7c5a4567646c04097888d5ae2f560b5b
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Pawel Wasowski [Thu, 20 Feb 2020 11:52:15 +0000 (12:52 +0100)]
[common][optional] Add operator==
Verification: the compilation doesn't fail; further validation will be
done when the operator will be used in the UUID class code
Change-Id: If7bee4f1f4b5d994aeaa11d32e2e2371397e94ba
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
[version] 2.64
Change-Id: I8d45775a26877a7770d7455846e08ec227ef70e5
[tv][6.0] enable bluetooth module on TV
[ACR] https://code.sec.samsung.net/jira/browse/TWDAPI-253
[Verification] Code compiles without errors.
Change-Id: If580567a72be0fc0f282584b6a7b7fa1dcda065f
Merge branch 'tizen_5.5' into tizen
Change-Id: Iba20b786c516812af5700a5eadf47bd6d73712b7
Merge branch 'tizen_5.0' into tizen_5.5
Change-Id: I87da3bb68de8658d2330fe09dcd736acc5d809dd
[version] 2.47
Change-Id: I2960e1b4a2214206304d3a944814bcc37f140a85
Piotr Kosko [Mon, 24 Feb 2020 13:00:29 +0000 (13:00 +0000)]
Merge "[Filesystem] fix for preventing integer overflow during subtraction." into tizen
Lukasz Bardeli [Mon, 24 Feb 2020 10:08:21 +0000 (11:08 +0100)]
[Filesystem] fix for preventing integer overflow during subtraction.
Filesystem TCT passrate 100%
Deprecated TCT passrate 100%
Change-Id: Ia2bf2bd10d79cf5bfba1bc4597ab7b1b5c634b02
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Revert "[Application] Make launch() and launchAppControl() asynchronous"
This reverts commit
b6cff5d0cf62f059dc2cf5e64208d05794d31f5d.
[Verification]
TCT application - 100%
TCT deprecated - 100%
Change-Id: I1d1c42cfa5c5731ce329525b7007127b56de796b
[Application] Fixed behaviour of launch() function
[Bug] Behaviour of launch() function changed.
For already launched application, now force launch is processed.
Before changing internal implementation, application was resumed
in this case.
With changing app_control_send_launch_request() call to
app_control_send_resume_request() this problem was fixed.
[Verification] binary tizen-5.5-unified_20200219.2 - TW3
PLM P191224-08332 - issue resolved.
Application TCT passrate 100%
Change-Id: I0ab3672e3a64cfbd3bb18d54e71acf562cfa3ff3
(cherry picked from commit
41f3c3c2fdf72399f1cc66a0970d455a3a82290c)
[Application] Fixed behaviour of launch() function
[Bug] Behaviour of launch() function changed.
For already launched application, now force launch is processed.
Before changing internal implementation, application was resumed
in this case.
With changing app_control_send_launch_request() call to
app_control_send_resume_request() this problem was fixed.
[Verification] binary tizen-5.5-unified_20200219.2 - TW3
PLM P191224-08332 - issue resolved.
Application TCT passrate 100%
Change-Id: I0ab3672e3a64cfbd3bb18d54e71acf562cfa3ff3
[version] 2.62
Change-Id: I684eac733fd78108c5b5b426c8d342cc934637af
[messaging][bluetooth] Fixing Coverity issues
Fixing below issues:
- messaging: 1098090, 1102306
- bluetooth: 1094938
[Verification]
bluetooth auto TCT: 100%
messaging sms TCT: 100%
messaging mms TCT: 100%
Change-Id: I12dc9d5cdc3ddd1e6c5c71f8fb92942bd1c63d96
Michal Michalski [Mon, 17 Feb 2020 10:06:24 +0000 (11:06 +0100)]
[humanactivitymonitor][bluetooth][application] Autoformatting not-formatted code.
Change-Id: I2d45925ffa0441690d619c19b119aefbf68948a6
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Mon, 17 Feb 2020 10:04:25 +0000 (11:04 +0100)]
[SDL-92][messaging] Macro parameters should be wrapped in brackets.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: If2a2cdfac845faec13c36f12b61a8e31a18097d7
[version] 2.61
Change-Id: I77f7340c0972610dc2088c995ced2b94367c3b17
Piotr Kosko [Tue, 11 Feb 2020 09:40:30 +0000 (09:40 +0000)]
Merge "[Filesystem] Fixing SVACE issue 423267" into tizen
[Filesystem] Fixing SVACE issue 423267
Preventing integer overflow during subtraction.
Change-Id: I5ea92045a0b3b12641cba8c05de914f71997dae9
Pawel Wasowski [Wed, 5 Feb 2020 13:00:47 +0000 (14:00 +0100)]
[common][messaging] Move toLowerCase from messaging to common module
The function is generic and may be used in modules other than messaging.
Function name was changed to comply with Google C++ coding style.
Change-Id: I52053780fb6f860fe7fcc1e0c7c1d912ecdd85f9
Verification: auto tct-messaging-{email,sms,mms}-tizen-tests pass rate: 100%
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Merge branch 'tizen_5.5' into tizen
Change-Id: I86a17b4aceb2d036060b303bde438784463f316c
Merge branch 'tizen_5.0' into tizen_5.5
Change-Id: Ibf67711087f0a032290a8e953b90335e4400372b
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I47343e6732942b125e9eae672626a60967704062
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I1bd47bf631acfcd842c26a5076c3538d8cbe8247
[version] 2.40
Change-Id: I06a43e95787fe3e97fc87cbaaee7f2e430b99b97