INSUN PYO [Tue, 10 Mar 2020 01:49:41 +0000 (10:49 +0900)]
Improve handling of the usb debug mode
debug on + rndis on : USB_FUNCTION_ACM | USB_FUNCTION_SDB | USB_FUNCTION_RNDIS
debug on + rndis off : USB_FUNCTION_MTP | USB_FUNCTION_ACM | USB_FUNCTION_SDB
debug off + rndis on : USB_FUNCTION_RNDIS
debug off + rndis off : USB_FUNCTION_MTP | USB_FUNCTION_ACM
Change-Id: I917efe98e4ed0e722efb938cb809116cba8001d9
INSUN PYO [Tue, 10 Mar 2020 00:36:48 +0000 (09:36 +0900)]
Improve handling of the usb tethering mode
On: Use predefined mode (USB_FUNCTION_ACM | USB_FUNCTION_SDB | USB_FUNCTION_RNDIS)
Off: Use predefined mode (USB_FUNCTION_MTP | USB_FUNCTION_ACM) + USB_FUNCTION_SDB(conditional)
Caution: If usb debug menu was enabled, add USB_FUNCTION_SDB to new mode to use.
When tethering is enabled, additionally enable usb debug(USB_FUNCTION_SDB) unconditionally.
Since usb debug is always enabled when you turn off usb tethering, there is no way to know if usb debug was enabled or not.
So before enabling usb tethering, save the previous state.
This saved value is used to check if the debug menu was enabled or not when you turn off usb tethering.
In addition, if someone changes the usb mode while tethering on,
use the latest usb mode to determine the usb debug mode instead of using the saved value.
Change-Id: I20cf762f4d45b96cd7142cf3e6e43a402213a415
Youngjae Cho [Mon, 9 Mar 2020 09:28:44 +0000 (18:28 +0900)]
Add additional conditions for bezel wakeup
(UX improvement for DND mode)
If every or either of the two vconf keys below is true,
- VCONFKEY_SETAPPL_THEATER_MODE_ENABLE
- VCONFKEY_SETAPPL_GOODNIGHT_MODE_ENABLE
disables bezel wakeup even if bezel wakeup is turned on.
Change-Id: I96d40593dd5ca6ae6e2bb7d7fa9feb13ad59568c
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Fri, 6 Mar 2020 11:07:56 +0000 (20:07 +0900)]
Fix dbus_getbrightness to consider pm_cur_state
Change-Id: I52ba74786246d399ddd915e90e03bf089a205817
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Fri, 6 Mar 2020 07:19:54 +0000 (16:19 +0900)]
Rearrange the send_usb_state_changed_event code when usb_change_mode is called
Change-Id: I5b890d82c78b1739a93e55880f0ae7e59135e7db
Youngjae Cho [Thu, 5 Mar 2020 08:26:14 +0000 (17:26 +0900)]
Turn off display when display is detached
Change-Id: I09a203694da1af7bb564cf4faa5839c119839b21
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Thu, 5 Mar 2020 23:50:32 +0000 (08:50 +0900)]
Fixed the vconf values in usb debug mode and usb selected mode to always match
1. When usb mode is changed, debug mode should be 1 if sdb is enabled and 0 if disabled.
2. If sdb is enabled in selected mode when deviced starts, enable debug mode; otherwise disable.
Change-Id: I8b85bc2d31c0febfccf844619b6ad53a160161ac
INSUN PYO [Thu, 5 Mar 2020 03:51:49 +0000 (12:51 +0900)]
Fix to shutdown usb0 interface when USB cable is disconnected in rndis mode
When the usb cable is disconnected, it just disables the gadget, but keeps the gadget's configuration.
So usb0 is left and rndis.service fails the next time you plug the usb cable.
Change-Id: I4245f4cbfcc71b6f42dd9332de2b6e7f564e1358
INSUN PYO [Wed, 4 Mar 2020 07:44:13 +0000 (16:44 +0900)]
Remove duplicate code and clean up in usb module
usb_config_init and usb_change_gadget are duplicated with the exact same code.
Change-Id: Ie3899df4ccb8d2c861b9af80ed4e652e7bb7a489
Hyotaek Shim [Wed, 4 Mar 2020 07:55:51 +0000 (16:55 +0900)]
Fix critical log for long lasting lock
Change-Id: Ibd9d1e8bbf5e0409f5879614d46f90f795c5b68a
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Wed, 4 Mar 2020 07:43:06 +0000 (16:43 +0900)]
Add is_app() as a common api
Change-Id: I5d195ffea25602af85276145a41a4d849696e7d8
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Wed, 4 Mar 2020 06:17:33 +0000 (15:17 +0900)]
Rearrange display lock and unlock in the usb module
If an error occurs during usb enable, do not acquire display lock.
Target may enter sleep mode with the USB cable is connected
To prevent this situation, acquire the lock when usb cable is connected,
and release the lock when usb cable is disconnected.
Change-Id: I9850e593957e182a415298eeb63361d09c21dc3a
INSUN PYO [Wed, 4 Mar 2020 04:53:53 +0000 (13:53 +0900)]
Refactoring usb_state_update_state #5
Reimplemented by separating change_usb_state_notification_handler() from usb_state_update_state().
A change_usb_state_notification_handler() is only changed when the usb gadget is enabled or disabled.
Change-Id: I58a30bf3a41abe082ed5f91da2cddd232ed0c6e4
INSUN PYO [Wed, 4 Mar 2020 03:25:48 +0000 (12:25 +0900)]
Refactoring usb_state_update_state #4
Reimplemented by separating send_usb_state_changed_event() from usb_state_update_state().
USB_DISCONNECTED : VCONFKEY_SYSMAN_USB_DISCONNECTED
USB_CONNECTED + USB_FUNCTION_NONE : VCONFKEY_SYSMAN_USB_CONNECTED
USB_CONNECTED + USB_FUNCTION_OOOO : VCONFKEY_SYSMAN_USB_AVAILABLE
When connecting the usb cable : "disconnected"(previous value) -> "connected" -> "available"
When disconnecting the usb cable : "available"(previous value) -> "dosconnected"
When changing usb mode : "available"(previous value) -> "connected" -> "available"
When USB cable is connected but USB initialization fails : It stays "connected" without going to "available"
Change-Id: I8a9d84884388bb0dcf24f44735224c695d2f10ec
Youngjae Cho [Tue, 3 Mar 2020 08:34:04 +0000 (17:34 +0900)]
Add critical-log for long lasting lock
Check locks every 10 minutes. (disp_plgn.lockcheck_timeout = 600)
Change-Id: I6cee6df8e46f947131a30c46c373332d456134dd
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Tue, 3 Mar 2020 06:57:59 +0000 (06:57 +0000)]
Revert "Add more robust usb error handling"
This reverts commit
982e0040a8ed197ea2a35c05052ae3bacd2f6068.
Change-Id: I634d301d2b22a905e8c2d014076f847eb1b3fa73
INSUN PYO [Tue, 3 Mar 2020 06:02:40 +0000 (15:02 +0900)]
Refactoring usb_state_update_state #3
Reimplemented by separating usb_state_set_current_mode() from usb_state_update_state().
A usb_state_set_current_mode() is olny changed when the usb gadget is enabled or disabled.
Change-Id: I0baaf031f52d2417d9aef84d56ff4b0e4c394b5f
Youngjae Cho [Tue, 3 Mar 2020 05:36:40 +0000 (14:36 +0900)]
Delete critical-log for pmlock/unlock
Change-Id: Ia09f99ad4a94adc5e2272cf6650c7832910e07a2
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Tue, 3 Mar 2020 05:09:39 +0000 (14:09 +0900)]
Refactoring usb_state_update_state #2
Reimplemented by separating usb_state_set_connection() from usb_state_update_state().
A usb_state_set_connection() is olny changed when the usb cable is connected or disconnected.
Change-Id: Ib2f9ca0eb12cb60e9f50f5badcedacaa71f8663b
INSUN PYO [Tue, 3 Mar 2020 02:42:50 +0000 (11:42 +0900)]
Add usb configuration exception handling code
If an error occurs during usb configuration, change the usb current mode to USB_FUNCTION_NONE.
The meaning of usb current mode is that usb is working correctly.
If any error occurs, USB operation is not guaranteed.
The value of usb current mode should not have a meaningless value and should have USB_FUNCTION_NONE.
Change-Id: Ia882f517fe696a03cf1a39f97b382383d970e9d5
INSUN PYO [Tue, 3 Mar 2020 00:06:06 +0000 (09:06 +0900)]
Add more robust usb error handling
The extcon uvent handler usb_state_changed() handles errors for usb connect/disconnect,
but adds additional exception handling code for more robust usb error handling.
Change-Id: I6c79fa99078ec71a19a2a72a94d28d31c8b9571f
Youngjae Cho [Fri, 28 Feb 2020 04:07:25 +0000 (13:07 +0900)]
Add pmqos for WirelessSendFile
Change-Id: I6d721794f937d99dee51d22e200691b4c3abdf5e
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Wed, 26 Feb 2020 10:32:25 +0000 (19:32 +0900)]
Cleanup usb code
Change-Id: I6bee810fb808b2caf6de69bcd17db2a9ea4b8677
Hyotaek Shim [Wed, 26 Feb 2020 10:15:22 +0000 (19:15 +0900)]
Fix SVACE
After having been compared to NULL value at bezel.c:111,
pointer 'bezel_dev->set_sw_state' is dereferenced at bezel.c:128
Change-Id: I7bf465007fffe6f373621ac3ca16e0df0117929a
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Wed, 26 Feb 2020 09:57:06 +0000 (18:57 +0900)]
Fixed to use default usb sel mode(MTP + ACM) for invalid vocnf value #2
Change-Id: I304abc9eef84328887f7ec6da282ae8aa43a2f6b
Youngjae Cho [Wed, 26 Feb 2020 04:45:44 +0000 (13:45 +0900)]
Fix wearable_mode() related code according to profile
Leave one of 'if' or 'else' statement related to wearable_mode()
according to profile.
Change-Id: I378ce12d334444dcfc4643dafb256eca4abc16cb
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Wed, 26 Feb 2020 05:38:25 +0000 (14:38 +0900)]
Refactoring usb_state_update_state
Since these four functions are handled in one function, they must be separated.
1. add and remove usb state notification handler
2. change usb connection state
3. send usb state changed event: event, vconf, dbus signal
4. change usb current mode
Change-Id: I202a069f36b7feb5a7c0db38e2d2e15f805802aa
Youngjae Cho [Tue, 25 Feb 2020 05:38:22 +0000 (14:38 +0900)]
Add delay to set_brightness_level() when AOD is on
When display state changes from AOD to LCDON, brightness change
effect seems sluggish because of heavy load of jobs for turning on
display. So delay this brightness change a bit to avoid this
heavy loaded time and therefore make it change smoothly.
Change-Id: Ie59e572becbb4bfc204634d5720818531d43121e
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Wed, 26 Feb 2020 03:30:53 +0000 (12:30 +0900)]
Fixed to use default usb sel mode(MTP + ACM) for invalid vocnf value
Deviced must never run in USB_FUNCTION_NONE mode.
So if vconf value is invalid, deviced uses the default usb mode internally.
Keep the problematic vconf values in order to define the problem correctly.
Change-Id: Iaeda7d02accbdc3576acb173f4c60cbe38f33519
Youngjae Cho [Tue, 25 Feb 2020 05:56:34 +0000 (14:56 +0900)]
Fix build warning
Change-Id: Ie04008f348ccb3c2b23fffcaeab0ec53651e7045
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Mon, 24 Feb 2020 03:06:33 +0000 (12:06 +0900)]
Add software bezel control
Change-Id: I1c1625892c7d04531d88079fdb70ab404a9c6065
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Mon, 24 Feb 2020 03:10:01 +0000 (12:10 +0900)]
Remove is_emulator() on usb
Deviced only uses three functions in usb_client hal: disable, enable and reconfigure_gadget.
If emulator's usb_client hal provides these three functions as dummy,
deviced can be used on both the emulator and target as a single code.
Change-Id: Ie2f32403e9767f65d4166ab8be6c83b68891b452
INSUN PYO [Mon, 24 Feb 2020 06:09:30 +0000 (15:09 +0900)]
Removed the usb_state_changed() function that was called by usb_init() without meaning.
The following call stack ensures that usb_state_changed() is called after usb_init.
///////////////////////////////////////////////////////////////////////////////////////////////////////////
extcon_init() --> usb_init() -->
event_handler_state_changed (DEVICE_NOTIFIER_STATE_START) --> add_extcon_event_handler() -->
get_extcon_init_state() -> config_parse() -> extcon_load_uevent() -> extcon_update() -> usb_state_changed()
///////////////////////////////////////////////////////////////////////////////////////////////////////////
Also, when usb_state_changed() is called from usb_init,
the extcon value is always -1 because the extcon initial value has not yet been retrieved.
The initial state of usb_state_changed() is -1, and usb_state_changed(-1) does nothing.
Change-Id: I77d774c9a396b3773203a69db83aa408e315205a
INSUN PYO [Mon, 24 Feb 2020 05:06:30 +0000 (14:06 +0900)]
Removed "route add" in rndis usb mode
Ifconfig command will also automatically add route information to the routing table in the kernel.
So if you run "route add" additionally, you have duplicate routing table entries.
sh-3.2# route
Kernel IP routing table
Destination Gateway Genmask Flags Metric Ref Use Iface
default 192.168.0.1 0.0.0.0 UG 0 0 0 wlan0
cns1.sec.samsun 192.168.0.1 255.255.255.255 UGH 0 0 0 wlan0
cns2.sec.samsun 192.168.0.1 255.255.255.255 UGH 0 0 0 wlan0
192.168.0.0 * 255.255.255.0 U 0 0 0 wlan0
192.168.0.1 * 255.255.255.255 UH 0 0 0 wlan0
192.168.129.0 * 255.255.255.0 U 0 0 0 usb0 <== here
192.168.129.0 * 255.255.255.0 U 0 0 0 usb0 <== here
Change-Id: I96c290ce5de1da81ff7b9f99cfaefc8a64b618ac
sanghyeok.oh [Tue, 11 Feb 2020 12:10:34 +0000 (21:10 +0900)]
add static keyword to locally used functions
Change-Id: Ia9869628db2e6fe89f3a95d89894f4c31eeb9592
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Youngjae Cho [Fri, 21 Feb 2020 05:49:59 +0000 (14:49 +0900)]
Add LCD_OFF_COMPLETE notifier
DEVICE_NOTIFIER_LCD_OFF_COMPLETE is used for disabling lbm on LCDOFF.
Change-Id: I88064ef316dd69623be197e5824c168c0069bf74
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 20 Feb 2020 08:40:45 +0000 (17:40 +0900)]
Add strings for LCDON triggered from bezel/backkey
Change-Id: I2dc3a91991ee318b5419822f8f161d648820715d
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Fri, 21 Feb 2020 03:47:17 +0000 (12:47 +0900)]
sync usb mode index with vconf
Change-Id: Ifa79010dd982e48df995a02a6c6dc519c0e40733
Youngjae Cho [Thu, 20 Feb 2020 05:54:28 +0000 (14:54 +0900)]
Add FreqStrength to locate optimal position for D2D charging
For D2D charge, user doesn't know the optimal location for charging.
To improve this, support information about frequency strength to user
so that they can adjust device charging position.
Change-Id: Id002cc62b1aaf37d31328fcc47e0ef3368a0a20f
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 20 Feb 2020 04:17:39 +0000 (13:17 +0900)]
Update pm_cur_state correctly in lcd_on_direct()
Change-Id: Ic72bbd46a90a597e814de87b45f9c2962d3d7e0d
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Wed, 19 Feb 2020 08:23:02 +0000 (17:23 +0900)]
Fix dbus method: change_usb_client_mode()
Change-Id: I285ecde35f611642bbec068ddade0482107603a5
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Wed, 19 Feb 2020 00:00:21 +0000 (09:00 +0900)]
Remove to check if mtp-responder.service exists.
If you disable mtp mode if there is not mtp service.
The predefined usb mode and current usb state do not match.
So, mtp-responder-dummy.service is created int libdevice-node.
This prevents inconsistencies between predefined usb mode and the current state.
Change-Id: I05dec48b4aabe8bbf0f9139502a2092e518d1aa3
INSUN PYO [Wed, 19 Feb 2020 07:28:34 +0000 (07:28 +0000)]
Merge "Fix usb mode<->vconf conversion" into tizen
Youngjae Cho [Thu, 13 Feb 2020 07:40:09 +0000 (16:40 +0900)]
Fix usb mode<->vconf conversion
We consider usb mode is always valid wherease usb vconf may not
represent the mode correctly as it is determined manually. (eg.
As mode mapping table or vconf definition is hard-coded manually,
it can cause mismatch as usb policy changes.) So mode update always
take place, but vconf update doesn't if converted vconf is invalid.
You can see this in usb_state_set_selected_mode(). usb_selected_mode
is always updated regardless of converted vconf is valid or not. The
vconf update, on the other hand, doesn't take place if the converted
vconf is invalid.
Change-Id: I4f7b0d7529b3612947baf2b9869f4b77571d264f
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Tue, 18 Feb 2020 06:07:35 +0000 (15:07 +0900)]
Enable rndis usb mode for tv and iot profile
Iot profile use rndis usb mode without usb tethering feature.
So, all profile have to support usb rndis mode.
Change-Id: Ib75aaf0c141fcb8b554cdcd2adea9a8ad37e3b02
Hyotaek Shim [Tue, 18 Feb 2020 05:36:27 +0000 (14:36 +0900)]
Add iot-display.conf
Change-Id: I40b5b40f7cabb5165baaaacf6776139f1faf22cc
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Youngjae Cho [Mon, 17 Feb 2020 08:14:58 +0000 (17:14 +0900)]
Introduce critical-log API from dlog
Below are added as critical-log
- Power(Display) lock/unlock
- PowerOff/Reboot
- Battery status/health
Change-Id: I6f2f5b1ee660d4f6a8a426b71d311719f9304a36
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Mon, 17 Feb 2020 09:47:41 +0000 (18:47 +0900)]
Delete critical-log module
Replace critical-log module to dlog API
Change-Id: Ie2e7c6ddebe47a1d5c89cf494f7ce0fe6102f89f
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Fri, 14 Feb 2020 02:43:05 +0000 (11:43 +0900)]
Add dbus interface for setting DIM_FLAG
Path : /Org/Tizen/System/DeviceD/Display
Interface : org.tizen.system.deviced.display
Method : DimStayControl
Signature : "(i)"
Parameter : 0(Unset flag), 1(Set flag)
Control DimStay. Update DIM_FLAG and change brightness accordingly.
Change-Id: I7b3197a965044fdf9e0313ebf8b4d1f383ea7017
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 13 Feb 2020 08:36:57 +0000 (17:36 +0900)]
Fix coverity issue
CID 1123903 (#1 of 1): Incorrect deallocator used (ALLOC_FREE_MISMATCH)
Change-Id: I88366204c9bb349e42dd3a79688a1c13280fe622
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Wed, 12 Feb 2020 10:59:58 +0000 (19:59 +0900)]
Add static configurations for usb gadget mode according to sdb debugging on/off
On:
SET_USB_SDB (USB_FUNCTION_MTP | USB_FUNCTION_ACM | USB_FUNCTION_SDB)
Off:
SET_USB_DEFAULT (USB_FUNCTION_MTP | USB_FUNCTION_ACM)
Change-Id: I88248ee3508a9529f875bb85a12b020907e40798
INSUN PYO [Wed, 12 Feb 2020 08:00:20 +0000 (17:00 +0900)]
Add static configurations for usb gadget mode according to tethering on/off
On:
SET_USB_RNDIS_SDB (USB_FUNCTION_ACM | USB_FUNCTION_SDB | USB_FUNCTION_RNDIS)
Off:
SET_USB_SDB (USB_FUNCTION_ACM | USB_FUNCTION_SDB | USB_FUNCTION_MTP)
Change-Id: I18cad16c6cebfa6d168beb2acca6462e673d2701
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Wed, 12 Feb 2020 07:24:29 +0000 (07:24 +0000)]
Merge "Improved log readability" into tizen
INSUN PYO [Tue, 11 Feb 2020 06:15:23 +0000 (15:15 +0900)]
Change usb_cur_mode from bitOR to index.
In MCD 4.0, VCONFKEY_USB_SEL_MODE has been changed to usb function index instead of bitOR of USB_FUNCTION_OOO.
Deviced works internally as bitOR of USB_FUNCTION_OOO, so you must convert it when you read/write from vconf.
Since these two values are not 1:1 mapping, so you have to be careful when you convert bitOR to usb function index.
Mapping table
//////////////////////////////////////////////////////////////////////////////////////////////
[SET_USB_NONE] = USB_FUNCTION_NONE
[SET_USB_DEFAULT] = USB_FUNCTION_MTP | USB_FUNCTION_ACM
[SET_USB_SDB] = USB_FUNCTION_MTP | USB_FUNCTION_ACM | USB_FUNCTION_SDB
[SET_USB_SDB_DIAG] = USB_FUNCTION_MTP | USB_FUNCTION_ACM | USB_FUNCTION_SDB | USB_FUNCTION_DIAG
[SET_USB_RNDIS_TETHERING] = USB_FUNCTION_RNDIS | USB_FUNCTION_SDB | USB_FUNCTION_ACM
[SET_USB_RNDIS] = USB_FUNCTION_RNDIS
[SET_USB_RNDIS_SDB] = USB_FUNCTION_RNDIS | USB_FUNCTION_SDB | USB_FUNCTION_ACM
[SET_USB_DIAG_SDB] = USB_FUNCTION_MTP | USB_FUNCTION_ACM | USB_FUNCTION_SDB | USB_FUNCTION_DIAG
[SET_USB_RNDIS_DIAG] = USB_FUNCTION_RNDIS | USB_FUNCTION_DIAG
[SET_USB_DIAG_RMNET] = USB_FUNCTION_DIAG | USB_FUNCTION_RMNET
[SET_USB_ACM_SDB_DM] = USB_FUNCTION_ACM | USB_FUNCTION_SDB | USB_FUNCTION_DM
[SET_USB_RNDIS_SDB_ACM] = USB_FUNCTION_RNDIS | USB_FUNCTION_ACM | USB_FUNCTION_SDB
Reverse mapping table
//////////////////////////////////////////////////////////////////////////////////////////////
USB_FUNCTION_NONE = SET_USB_NONE
USB_FUNCTION_RNDIS = SET_USB_RNDIS
USB_FUNCTION_MTP | USB_FUNCTION_ACM = SET_USB_DEFAULT
USB_FUNCTION_DIAG | USB_FUNCTION_RNDIS = SET_USB_RNDIS_DIAG
USB_FUNCTION_DIAG | USB_FUNCTION_RMNET = SET_USB_DIAG_RMNET
USB_FUNCTION_MTP | USB_FUNCTION_ACM | USB_FUNCTION_SDB = SET_USB_SDB
USB_FUNCTION_ACM | USB_FUNCTION_SDB | USB_FUNCTION_RNDIS = SET_USB_RNDIS_SDB
USB_FUNCTION_ACM | USB_FUNCTION_SDB | USB_FUNCTION_DM = SET_USB_ACM_SDB_DM
USB_FUNCTION_MTP | USB_FUNCTION_ACM | USB_FUNCTION_SDB | USB_FUNCTION_DIAG = SET_USB_SDB_DIAG
Mapping excluded from reverse table
//////////////////////////////////////////////////////////////////////////////////////////////
USB_FUNCTION_ACM | USB_FUNCTION_SDB | USB_FUNCTION_RNDIS = SET_USB_RNDIS_TETHERING
USB_FUNCTION_ACM | USB_FUNCTION_SDB | USB_FUNCTION_RNDIS = SET_USB_RNDIS_SDB_ACM
USB_FUNCTION_MTP | USB_FUNCTION_ACM | USB_FUNCTION_SDB | USB_FUNCTION_DIAG = SET_USB_DIAG_SDB
Change-Id: I3bd0227e274a45135218ae1b015926e13dd9469a
INSUN PYO [Wed, 12 Feb 2020 02:20:09 +0000 (11:20 +0900)]
Improved log readability
Change-Id: I5b48879b74fd9a73e8ff889781146cd73ceddc5e
Youngjae Cho [Tue, 11 Feb 2020 08:53:57 +0000 (17:53 +0900)]
Fix coverity issue
CID 1099199 (#1 of 1): Read from pointer after free (USE_AFTER_FREE)
20. deref_after_free: Dereferencing freed pointer elem.
Change-Id: I85c34f351db0cc10ce384176b90ba72067e3c051
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Tue, 11 Feb 2020 07:56:20 +0000 (16:56 +0900)]
Fix lockcheck interval
Change-Id: Ifac60f83149cb94f8ac1392950fe57b454203cad
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Tue, 11 Feb 2020 00:51:00 +0000 (09:51 +0900)]
Refactoring usb current mode
Change-Id: Ieaec11ed3cf352c60adf30724552a7fbdfb5a015
Yunmi Ha [Mon, 10 Feb 2020 08:15:01 +0000 (17:15 +0900)]
Fix svace issue
- Remove memory-leak
- Remove unreachable code
Change-Id: Ie4f9a2819e0e839e21fa7a35aa672ed12f08f158
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Youngjae Cho [Tue, 11 Feb 2020 00:27:40 +0000 (09:27 +0900)]
Don't check if timeout is 0 in dbus_sethbm_timeout()
When turning off hbm, it is natural that both the value and the timeout
should be zero as parameters. For turning on the hbm, timeout 0 will be
checked again in hbm_set_state_with_timeout().
Change-Id: I97819bacdff3c156cf5c458ca5f4f230f83f1eb2
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Fri, 7 Feb 2020 10:16:28 +0000 (19:16 +0900)]
Apply changeable RNDIS IP address
Change-Id: Icddea9c594cf9aee5afa9d203a5681276ca8f016
INSUN PYO [Tue, 4 Feb 2020 00:52:24 +0000 (09:52 +0900)]
Add log related to engineer mode for usb state
Change-Id: Iad11d4ec9021c6854a912b3596a193545ac4b5d0
Youngjae Cho [Mon, 3 Feb 2020 07:34:06 +0000 (16:34 +0900)]
Change powerlock/unlock signal name for consistency
Change-Id: I7c4c81431511d7aa696220c55b49546d69574f7a
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Hyotaek Shim [Mon, 3 Feb 2020 05:53:26 +0000 (14:53 +0900)]
Change version
Change-Id: I1d0ae4cdcc6290f81c289e53ce36596d2d64f9db
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Youngjae Cho [Fri, 31 Jan 2020 01:32:50 +0000 (10:32 +0900)]
Change version
Change-Id: Ib3bdef354fd5bec99665783e663c4c2ca078ffff
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Fri, 31 Jan 2020 07:24:20 +0000 (16:24 +0900)]
Generate signal about power lock/unlock information
Change-Id: I75b2a36ff57243bf13a8d6bcd8047d40a015939f
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Fri, 31 Jan 2020 06:23:33 +0000 (15:23 +0900)]
Provide time info for suspend/wakeup signal
Change-Id: Ia79922caa6a1cde39022c4d092b781217eace58b
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Fri, 31 Jan 2020 01:18:15 +0000 (10:18 +0900)]
Add pmqos ultrapowersaving
Change-Id: I56d47fbc1741c04e01f0b630f8125d6b2f645f0d
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Tue, 28 Jan 2020 11:15:51 +0000 (20:15 +0900)]
Modify powersaving within the touchscreen_start()
Change-Id: I979e67d4d0caeb2095ee1e2014c368c4a009d291
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Wed, 29 Jan 2020 08:14:51 +0000 (17:14 +0900)]
Remove unused function usb_state_get_mode_str()
To break bad dependencies with libdeviced, remove unused functions.
Change-Id: I72d9712e955f96e3de3acdbb623a40a64a675f15
Hyotaek Shim [Wed, 29 Jan 2020 05:28:30 +0000 (14:28 +0900)]
Fix dbus policy
01-21 17:04:28.264 E/W-SETTING(P14042, T14042): StDeviceModel.cpp: _sendDbusMessage(748) >
[0;31m* Critical * dbus_connection_send error(org.freedesktop.DBus.Error.AccessDenied:Rejected
send message, 2 matched rules; type="method_call", sender=":1.3163"
(uid=5001 pid=14042 comm="/usr/apps/com.samsung.clocksetting/bin/setting-dev")
interface="org.tizen.system.deviced.touch" member="SetSensitivity" error name="(unset)"
requested_reply="0" destination="org.tizen.system.deviced" privilege="(n/a)"
(uid=0 pid=2682 comm="/usr/bin/deviced ")
rule(<deny send_destination="org.tizen.system.deviced" send_type="method_call" />))
Change-Id: I209fec572db02cf6ce83b5e40966739b78e6846b
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Tue, 28 Jan 2020 11:20:34 +0000 (20:20 +0900)]
Fix build warning
Change-Id: If9c91e88101653de559727d8685f6625a7329d5c
Youngjae Cho [Tue, 28 Jan 2020 08:49:17 +0000 (17:49 +0900)]
Add an additional condition for touchscreen_stop()
Check for the display_conf in case touchscreen_stop() is called
before touchscreen_init().
Change-Id: Ieaf676e1f07487de082a9ddf27941fd61c6e2b1d
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Hyotaek Shim [Tue, 28 Jan 2020 07:06:41 +0000 (16:06 +0900)]
Fix touchscreen_stop
Touchscreen powersaving/enable/disable is required also for AOD mode.
Change-Id: I3602de43d76dd8c36af144e2a1633d526aca4f71
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Wed, 22 Jan 2020 04:32:53 +0000 (13:32 +0900)]
Fix Poweroff, reboot enum for PowerOff.ChangeState
0: None
1: Power Off Popup is launched (not supported since Tizen5.5)
2: Poweroff
3: Restart
4: Exit
Change-Id: I704ca9da1e8c4b50a9eff0e148e3945d1f0d1919
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Youngjae Cho [Tue, 21 Jan 2020 05:56:48 +0000 (14:56 +0900)]
Do not unref timeout_source right after the attach
Unref right after the attach make gsource be automatically freed on
returning G_SOURCE_REMOVE by callback. This make potential segfault.
To avoid this, move the unref after the callbacks.
Change-Id: I4022565b5f9d667867d2a99dbe8b915ae76648f5
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
sanghyeok.oh [Fri, 6 Dec 2019 12:59:08 +0000 (21:59 +0900)]
auto-test: add dbus interface for deviced
Change-Id: I7b4b693c081e41729fa541dad9652ca30f57dc49
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Youngjae Cho [Fri, 17 Jan 2020 02:55:01 +0000 (11:55 +0900)]
Fix display savelog output format
Change-Id: Ie2e578782f7e98484b2cc095f3b4d59000df5158
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 16 Jan 2020 09:23:49 +0000 (18:23 +0900)]
Delete duplicate request check
Delete duplicate request condition. This can be problem when request
timeout happen. When the timeout happen it cannot update state, causing
mismatch between real state and variable state.
Change-Id: I3c1557e0abc198645e44f5e44b99cc63ee386bd7
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 16 Jan 2020 11:16:38 +0000 (20:16 +0900)]
Fix segfault when referencing undefined function
Change-Id: I1c076acaa49255ae2f884f4471480785b35e867b
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 16 Jan 2020 05:20:34 +0000 (14:20 +0900)]
Support touch wakeup, touchscreen powersaving
Change-Id: I39e4b002a4acf24dabf5c1f78ef4c30e46aede9d
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Thu, 16 Jan 2020 06:35:21 +0000 (15:35 +0900)]
Fix to determine network interface name at runtime in rndis mode
TM1, TW2, XU3 : use "usb0" name
TW3 : use "rndis0" name
/////////////////////////////////////////////////////////////////////////////////////////////////////////////
TM1, TW2
- It is not configfs, so it has no /sys/kernel/config/usb_gadget/hal-gadget/functions/rndis.default/ifname.
- Use "usb0" interface name fixed by kernel.
TW3 (tizen 5.5)
- It is not configfs.
- Kernel does not support rndis.
TW3 (tizen 6.0)
- It is configfs.
- "/sys/kernel/config/usb_gadget/hal-gadget/functions/rndis.default/ifname" has "rndis0" intarface name.
XU3
- It is configfs.
- "/sys/kernel/config/usb_gadget/hal-gadget/functions/rndis.default/ifname" has "usb0" intarface name.
Change-Id: Ibf902121e11007e84321e5fee421273fc03a1a58
Youngjae Cho [Thu, 16 Jan 2020 04:16:06 +0000 (13:16 +0900)]
Fix function return type
Change-Id: I5a64d4d2bd3c9a55ecc4449812308979f59bae1e
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Wed, 15 Jan 2020 01:12:44 +0000 (10:12 +0900)]
Fix type of extcon_notifier member variable
Change-Id: Id1325fd93d277ef3485963bbc48889c5fa1037b4
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Hyotaek Shim [Tue, 14 Jan 2020 12:14:03 +0000 (21:14 +0900)]
Ignore AddPowerOffWait in the middle of poweroff sequence
Change-Id: I22f92c7c2b57f8adca8c245f23b38a2cca428810
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Tue, 14 Jan 2020 11:46:26 +0000 (20:46 +0900)]
Start poweroff_start_animation() right after PowerOff event broadcasting
Change-Id: I890e75dc8973d77f260dc16a61e4cdec7c170fab
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Tue, 14 Jan 2020 11:41:11 +0000 (20:41 +0900)]
Add spare time for AddPowerOffWait requests
Some services are executed under PowerOff event, and trigger AddPowerOffWait.
Change-Id: I3fac3e48bff151e6c4ccd7db6f6292a23068790a
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Youngjae Cho [Thu, 26 Dec 2019 04:00:28 +0000 (13:00 +0900)]
Make dpms_set_state() synchronous
Make dpms_set_state() synchronous. This change allowes the two
get/set client to use the same dpms_context, which enables
merging those two client into one.
Change-Id: I41bb33e0dd25ff3306e2450e921e65887d13f905
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Tue, 14 Jan 2020 02:22:59 +0000 (11:22 +0900)]
Add dbus method for touchscreen enable/disable
Change-Id: Ib96ac050d0e4ee934440838b3a4f50302f86fc98
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Mon, 13 Jan 2020 01:04:39 +0000 (10:04 +0900)]
Fix memory leak
Change-Id: Ie04df74cf2c15d0bc23c634ace44ec1b9834c06b
INSUN PYO [Fri, 10 Jan 2020 09:37:12 +0000 (18:37 +0900)]
Fix bug. use "and" operation(&) instead of "or" operation(|)
Change-Id: I09107adac1b695294de3b4196b7173f69bc1c85c
(cherry picked from commit
43bbe64b8453dc6c93da3a756219dd23a6a9a9e3)
INSUN PYO [Fri, 10 Jan 2020 05:00:10 +0000 (14:00 +0900)]
Enable usb_mode udev event for factory mode.
Factory jig internally disconnects only signal cable(in Blue and White) of USB cable.
It makes a strange state.
In general, when the USB cable is disconnected, switch udev event and usb_mode udev event occur.
But, in factory jig case, usb_mode udev event only occurs.
Without luck, data-router.service crashs on factory jig because of one's own problems.
So, we have to restart data-router.service when usb_mode udev event happens.
And, sdbd.service and mtp-response.service also restart as a preventive measure.
Change-Id: Ia538383aefd82bad9eaf976fc4dedef605c60026
Youngjae Cho [Fri, 10 Jan 2020 04:39:52 +0000 (13:39 +0900)]
Fix display to release lock on booting done.
Change-Id: I1743869f2ca7d218ef3745cab71c1f7785edadde
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 9 Jan 2020 08:39:23 +0000 (17:39 +0900)]
Fix GCC-9 build error on x86_64, aarch64
Change-Id: I7ede3309e98ddf58ad11e5feffec4f01abfdc40b
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 9 Jan 2020 05:43:40 +0000 (14:43 +0900)]
Support display blink on logdump
Change-Id: I9ee202204711b196c2d10807a8da09845bacc203
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Thu, 9 Jan 2020 06:12:29 +0000 (15:12 +0900)]
Extend USB gadget configuration for further usage #2
Change-Id: I9d0086b2bea235baab8241b0f7e89d3fca47c8e5
Youngjae Cho [Tue, 7 Jan 2020 09:25:40 +0000 (18:25 +0900)]
Rename functions, variables for consistency
dbus_platformlcdcontrol() -> dbus_changestatebyreason()
display_platform_on() -> display_on_by_reason()
display_platform_off() -> display_off_by_reason()
display_platform_control() -> deleted
enum platform_control -> deleted
Change-Id: I66e0024e235983629d7c8853510ab5bae2921906
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Wed, 8 Jan 2020 06:05:56 +0000 (15:05 +0900)]
Fix build warning on x86_64, aarch64
warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
Change-Id: I8a17c36bb5b79e01ce814be2cfa563ca95780836
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
sanghyeok.oh [Tue, 10 Dec 2019 12:29:01 +0000 (21:29 +0900)]
battery-monitor: modified to use consecutive sessions
Monitoring data consists of multiple sessions.
Session means monitoring data within device enabled(on) state.
So display battery monitor should distinguish each lcd on-off as session.
Change-Id: I99d1e91857af802890de9f851ff08c69797bffba
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Youngjae Cho [Wed, 8 Jan 2020 02:44:10 +0000 (11:44 +0900)]
Fix log type specifier
Change-Id: If0b713d19c48bbde1e855401fcf09e9b4e24e083
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
projects / platform / core / system / deviced.git / log