Sangchul Lee [Mon, 9 May 2022 10:53:43 +0000 (19:53 +0900)]
webrtc_private: Clear event source not fired before overwriting it
It was an issue with a short test case that results a crash in sometimes.
[Version] 0.2.169
[Issue Type] Bug fix
Change-Id: Ic82742df40438d7077d7f44585099d4694d0f707
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 6 May 2022 05:24:32 +0000 (14:24 +0900)]
webrtc_private: Fix crash when handling callback in idle
It was possible to access freed memory in log.
The crash rarely happened during ITc_webrtc_create_offer_async_p().
[Version] 0.2.168
[Issue Type] Bug fix
Change-Id: Ib1da621b4c2a853f63446454b356332fd8aaed83
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 4 May 2022 02:37:58 +0000 (11:37 +0900)]
webrtc_private: Fix negotiation state bugs
Setting the result state is moved inside __idle_cb().
Invalid converting enums are also fixed.
Getting the state in the callback is added to webrtc_test.
[Version] 0.2.167
[Issue Type] Bug fix
Change-Id: If91bae0f87397d7b9d7350bdf24f93c34a4e3e7c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 26 Apr 2022 08:02:47 +0000 (17:02 +0900)]
webrtc_test: Check return value of g_io_channel_read_chars()
[Version] 0.2.166
[Issue Type] Coverity defects
Change-Id: I0320f4b95c94da0dec4ef2f447c90d6b561aa6c1
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 29 Mar 2022 12:31:09 +0000 (21:31 +0900)]
Revise description
webrtc_doc.h
- Fix invalid information
webrtc.h
- Add @remarks to callback function prototypes
[Version] 0.2.165
[Issue Type] Doxygen
Change-Id: Iac7524e8fcee20341a147d1c8eaefb58cfec1035
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 31 Mar 2022 05:09:03 +0000 (14:09 +0900)]
Add missing required libraries for pkg config
[Version] 0.2.164
[Issue Type] pkg-config
Change-Id: I3e1bbe2957379c9a58e2fae7e5e22014f837971e
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 2 Mar 2022 11:40:04 +0000 (20:40 +0900)]
webrtc_private: Add omitted lock/unlock mutex for g_cond_signal()
This ensures to call g_cond_wait_until() before sending the signal.
[Version] 0.2.163
[Issue Type] Bug fix
Change-Id: I78b799067cf3f6a4a45ddf58c9341e679415a079
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 22 Feb 2022 05:11:22 +0000 (14:11 +0900)]
webrtc_test: Fix data type to prevent integer overflow
[Version] 0.2.162
[Issue Type] SVACE
Change-Id: I5722a5c8f5fc8ef0b4d8200ff2d74113cc06037c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 18 Feb 2022 10:25:46 +0000 (19:25 +0900)]
Add more mutex guard for callbacks
[Version] 0.2.161
[Issue Type] Improvement
Change-Id: I1f536532c3c4bac4101d68c125197d80b267856f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 8 Feb 2022 00:32:53 +0000 (09:32 +0900)]
webrtc_sink/source: Add const keywords
[Version] 0.2.160
[Issue Type] Improvement
Change-Id: Icd1575632033d62f245b29d4a7a8528ef879a02e
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 27 Jan 2022 06:12:48 +0000 (15:12 +0900)]
webrtc_data_channel: Remove unreachable code and revise error log
[Version] 0.2.159
[Issue Type] Improvement
Change-Id: I3fb502f8ea712233a660e382904a65fd2e47fee0
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 27 Jan 2022 04:14:29 +0000 (13:14 +0900)]
Revise doxygen
Post command regarding error callback is described in case of
failure on sending data via data channel.
[Version] 0.2.158
[Issue Type] Doxygen
Change-Id: I3fa1e5f84b25a35bda9260292945889dda429a9c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 20 Jan 2022 04:52:37 +0000 (13:52 +0900)]
Change gcov object install path
[Version] 0.2.157
[Issue Type] Gcov
Change-Id: I10061f55df49d2c7cc4ae43de352cd46808b1e82
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 14 Jan 2022 05:49:27 +0000 (14:49 +0900)]
Add omitted error checking in webrtc_create()
[Version] 0.2.156
[Issue Type] Improvement
Change-Id: Ib208fc70c4f477495b8f44a155a85e9ba3c5c123
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 4 Jan 2022 04:59:54 +0000 (13:59 +0900)]
Remove event sources not invoked when destroying webrtc handle
A crash can happen with the previous codes.
It is fixed by removing event sources of idle callbacks
which are not invoked yet before destroying webrtc handle.
[Version] 0.2.155
[Issue Type] Bug fix
Change-Id: Icff390fdd63ee2aa7bfeedd547d63dbb3e0f5d5a
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 23 Dec 2021 07:07:21 +0000 (16:07 +0900)]
webrtc_ini: Add new item to set bundle policy and apply it
[general]
; SDP bundle policy (0:none, 1:balanced, 2:max compat, 3:max bundle)
bundle policy = 3
Note that 1 and 2 are not supported yet.
[Version] 0.2.154
[Issue Type] Improvement
Change-Id: I47f72ad12d21399727a398ea74da7e452b5a71ec
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 14 Dec 2021 09:42:22 +0000 (18:42 +0900)]
webrtc_ini: Revise two default values
1. DEFAULT_USE_ULPFEC_RED is changed to FALSE
FEC is optional functionality that also affects bitrate and latency,
so, set it FALSE as a default value.
2. DEFAULT_VPXENC_KEYFRAME_MAX_DIST is changed from 999999 to 10
The previous value which has been brought from www.webmproject.org
with no thought of that we are using 'wait-for-keyframe' of VP8
depayloader. With a high value, received video stream can be shown
to be freezed when a RTP packet gets lost. Therefore, this value is
now changed to the reasonable value.
Note that these values affect only if there's empty value in ini file
or there's no ini file in a target.
[Version] 0.2.153
[Issue Type] Improvement
Change-Id: I19dd64b5bdb3fd21f09ab213cf2d8bae9b52a190
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 16 Nov 2021 03:38:00 +0000 (12:38 +0900)]
webrtc_private: Add excluded element list to CREATE_ELEMENT_FROM_REGISTRY()
The excluded element list from ini file is now referenced by two locations.
1. sink side (previous one) - _decodebin_autoplug_select_cb()
2. source side - CREATE_ELEMENT_FROM_REGISTRY() in __create_rest_of_elements()
[Version] 0.2.152
[Issue Type] Improvement
Change-Id: I277dfd574d8abbb9cd25e961a46efbaff7855ffc
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 9 Nov 2021 07:37:59 +0000 (16:37 +0900)]
webrtc_test: Show server ip/port/status when using private signaling server
It is also fixed to use designated initializers for some string arrays.
[Version] 0.2.151
[Issue Type] Improvement
Change-Id: I28f50fee799466de6ac0fee6de1772374a196246
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 12 Nov 2021 08:00:43 +0000 (17:00 +0900)]
fixup! Added vpx encoder system configure setting for real-time CBR encoding and streaming
Wrong comparisons are fixed. The previous patch is now affected.
Change-Id: If16b7a7be15ad1062b3736352bcdccd7071e8f15
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 9 Nov 2021 06:56:05 +0000 (15:56 +0900)]
webrtc_source: Fix typos
DEFAULT_NAME_XXX should be ELEMENT_NAME_XXX.
[Version] 0.2.150
[Issue Type] Typo fix
Change-Id: Id365803d8e92272aec050e9bccc1a4b2075bfa28
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 9 Nov 2021 06:25:52 +0000 (15:25 +0900)]
webrtc_sink: Set channel and samplerate if available when making a media format
This code blocks is activated when user calls webrtc_set_encoded_audio_frame_cb().
[Version] 0.2.149
[Issue Type] Improvement
Change-Id: I663a3e3416beb2cf974f346c43bd0b750ae79737
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 8 Nov 2021 01:29:05 +0000 (10:29 +0900)]
webrtc_source: Use list to carry elements to remove these from file source
Variable and function are also renamed to use 'payloader' not 'payload'.
[Version] 0.2.148
[Issue Type] Refactoring
Change-Id: Iaf165625dc135d2e0248e3c103ffc0aa9775bcd4
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 12 Nov 2021 03:53:53 +0000 (12:53 +0900)]
Merge branch 'tizen' into tizen_6.5
Change-Id: I2f807e574904dfe7ddbe10f8c671f07fe0e55ee7
Sangchul Lee [Mon, 1 Nov 2021 09:54:15 +0000 (18:54 +0900)]
webrtc_internal: Revise webrtc_screen_source_set/unset_crop()
Parameter check codes are revised.
g_mutex_locker_new() applies to this function.
[Version] 0.2.147
[Issue Type] Refactoring
Change-Id: I1ce481aa9e65a34a5b813258885019a0f7e6afa9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 1 Nov 2021 06:26:16 +0000 (15:26 +0900)]
webrtc_source: Use list to carry elements for making encoded media packet source
Some codes exiting without releasing resources are fixed.
Level of logs in __link_elements() is changed.
Redundant logs are removed.
[Version] 0.2.146
[Issue Type] Improvement
Change-Id: I3d315984ab5fd4d2046a546d823549a29ab4c7e2
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 2 Nov 2021 04:12:29 +0000 (13:12 +0900)]
webrtc_source: Improve list handling in __complete_mediapacketsrc_from_raw_format()
When an error occurs, a node memory of list for appsrc is not freed.
It is now fixed.
[Version] 0.2.145
[Issue Type] Bug fix
Change-Id: I092cfb4dc86570fca0f77e4c68171c5b9a228908
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 2 Nov 2021 03:32:42 +0000 (12:32 +0900)]
webrtc_source: Improve error handling when failure on adding element to bin
If an error occurs when calling gst_bin_add() for element list,
error handling codes for unreferencing the elements should be divided
with two phases, one is for elements already added to the bin, the other
one is for the rest of elements in the list.
[Version] 0.2.144
[Issue Type] Improvement
Change-Id: Ie5a8c9eaa0f8dd462ec0079a59e85ebc1b8f070a
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 28 Oct 2021 03:27:15 +0000 (12:27 +0900)]
webrtc_test: Fix to add ice candidate to the valid handle
[Version] 0.2.143
[Issue Type] Bug fix
Change-Id: Ic3c8a754382b222d74143fd8062146449d20d842
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 28 Oct 2021 01:16:38 +0000 (10:16 +0900)]
webrtc_private: Append webrtc handle pointer address to webrtcbin name
This can help user analyze logs more easily.
[Version] 0.2.142
[Issue Type] Debug
Change-Id: I6afaa2d622f76cf57a63823dff4c80e6fd709b8f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 26 Oct 2021 00:01:01 +0000 (09:01 +0900)]
webrtc_test: Support data channel in case of room join test
It is now possible send/receive text message via data channel
in case of room join test.
'zs', 'zb' menu can be used to send message to peers in the room.
[Version] 0.2.141
[Issue Type] New feature
Change-Id: Ia4847e8a91e55023c789bd113cbc6e4c6d8e1813
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 25 Oct 2021 06:13:58 +0000 (15:13 +0900)]
webrtc_test: Fix bug of room join test
In case of room scenario, when a remote peer is joining the room
where the first handle has already joined, new webrtc handle uses
same media sources that the first handle is using.
[Version] 0.2.140
[Issue Type] Bug fix
Change-Id: Ifa9ecea9b01a35370d871a8277668cba4b64083c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 25 Oct 2021 09:47:40 +0000 (18:47 +0900)]
webrtc_test: Abandon connection change menu
The connection change menu intended to use multiple websocket
connections is not that useful considering the conflict of display
object. This application is now modified to use only one websocket
connection with signaling server.
The room joining scenario still can have multiple peers(webrtc handles)
with only one websocket connection.
[Version] 0.2.139
[Issue Type] Clean-up
Change-Id: I712665a9f1040e192706716e6fa6b4f75fb7599a
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 21 Oct 2021 01:06:48 +0000 (10:06 +0900)]
webrtc_test: Show text message from data channel to the display
[Version] 0.2.138
[Issue Type] Improvement
Change-Id: I217484ed9bf9d74a1519dee8726afaf8f9b5c4d4
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
backto.kim [Wed, 20 Oct 2021 02:49:19 +0000 (11:49 +0900)]
webrtc_source: Use list to carry elements for loopback pipeline
[Version] 0.2.137
[Issue Type] Refactoring
Change-Id: I35530c0bb7fdb89bdcdde5897d068a8acfaa599c
Sangchul Lee [Thu, 21 Oct 2021 01:36:12 +0000 (10:36 +0900)]
Apply macros to exclude lines from coverage measurement #2
[Version] 0.2.136
[Issue Type] Line coverage
Change-Id: I472ebce3a0748d0056ec929a920388262f1e1288
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 19 Oct 2021 11:09:00 +0000 (20:09 +0900)]
webrtc_source: Apply GENERATE_DOT() macro to loopback and filesrc
The filesrc pipeline name and loopback render pipeline name are
changed to be identified easily that which source belongs to it
by its name.
Dot file names are also changed.
[Version] 0.2.135
[Issue Type] Debug feature
Change-Id: I843eb7b4e8f42df20c5cd04a89c42a773e79af8c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 20 Oct 2021 02:34:18 +0000 (11:34 +0900)]
webrtc_private: Revise macro definitions
Some are modified to use do/while(0).
[Version] 0.2.134
[Issue Type] Improvement
Change-Id: Iae3b8aa519077fd03593651b3478deb7f2397e57
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
backto.kim [Tue, 19 Oct 2021 08:25:30 +0000 (17:25 +0900)]
webrtc_source: Add parameter to __create_rest_of_elements() to check the exact media type.
file source can have audio and video together in the "media type".
So, actual media type to make proper elements should not be determined only by the "media type".
[Version] 0.2.133
[Issue Type] Improvement
Change-Id: Idc9ffa36d5ca01bdf59410be78dad8c57158e0d5
Sangchul Lee [Tue, 19 Oct 2021 09:54:23 +0000 (18:54 +0900)]
webrtc_private: Add explicit pipeline parameter to GENERATE_DOT macro
This will be used to print dot of other piplines.
Log level is changed to 'warning' in _generate_dot().
[Version] 0.2.132
[Issue Type] Debug feature
Change-Id: Iaa91b2d8ab77614f5b3d6f2dc0e729c79eb1b34a
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 19 Oct 2021 08:30:02 +0000 (17:30 +0900)]
Skip creating resource manager handle if any resources required in ini file
[Version] 0.2.131
[Issue Type] Improvement
Change-Id: I1648153301ef56f27c5d07f83d2b8a781baf81d2
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 15 Oct 2021 04:50:26 +0000 (13:50 +0900)]
webrtc_private: Skip making rendering sink during stopping or destroying handle
[Version] 0.2.130
[Issue Type] Improvement
Change-Id: I2a563aefd9734333cd9e54f9c25a3ef36e1eb2b0
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
backto.kim [Tue, 19 Oct 2021 07:05:45 +0000 (16:05 +0900)]
define SAFE_G_LIST_FREE_FULL()
[Version] 0.2.129
[Issue Type] Refactoring
Change-Id: I05c1c0953d74427faa01b5be108439723f68d8af
backto.kim [Tue, 19 Oct 2021 03:26:36 +0000 (12:26 +0900)]
webrtc_source: rearrange codes to reduce code complexity
[Version] 0.2.128
[Issue Type] Refactoring
Change-Id: Ie67fa8314d79461b51d8424ab7b3bca695ccfa24
backto.kim [Thu, 14 Oct 2021 07:38:38 +0000 (16:38 +0900)]
webrtc_source: Enable file path change for the same source
[Version] 0.2.127
[Issue Type] Improvement
Change-Id: I3af2d27448915826bbd2becd1fade6e3c99dd14c
Sangchul Lee [Mon, 18 Oct 2021 09:47:41 +0000 (18:47 +0900)]
Apply macros to exclude lines from coverage measurement
[Version] 0.2.126
[Issue Type] Line coverage
Change-Id: I7ec0f6c1aaf05d23d393fb0d4fec098ad2b58599
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 18 Oct 2021 06:04:33 +0000 (15:04 +0900)]
Add gcov package for line coverage automation
[Version] 0.2.125
[Issue Type] Line coverage
Change-Id: I65bcf327b8735057aa2162f4f3f3e1c90d9e6b0b
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 15 Oct 2021 04:02:54 +0000 (13:02 +0900)]
webrtc_test: Maintain received ICE candidates before destroying handle
Based on gstreamer webrtcbin, it does not gather ICE candidate again
when after gathering completed until unref the bin.
These ICE candidates can be used after webrtc_stop().
Missing * are added in menu for internal API.
[Version] 0.2.124
[Issue Type] Improvement
Change-Id: Ie43a3157315f5586bcbbec377cdab8b234c825c5
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 13 Oct 2021 07:43:09 +0000 (16:43 +0900)]
webrtc_data_channel: Close data channel before destroying the handle
It'll trigger the close callback on the data channel.
[Version] 0.2.123
[Issue Type] Improvement
Change-Id: I578a70a3677652addd5aa9896bdf7323ee67988a
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 12 Oct 2021 11:06:12 +0000 (20:06 +0900)]
webrtc_private/sink: Print handle pointer address
Some logs for webrtc handle and decodebin are added.
[Version] 0.2.122
[Issue Type] Log
Change-Id: Ib07f9216c482d3e73a38cf51069e8cabc0669c94
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 12 Oct 2021 10:37:57 +0000 (19:37 +0900)]
webrtc/webrtc_source: Print webrtc handle pointer address
[Version] 0.2.121
[Issue Type] Log
Change-Id: I37e8f900275a79a48d171f1104d4f64367ede6f7
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 8 Oct 2021 11:11:36 +0000 (20:11 +0900)]
webrtc_source: Disable clock synchronization of loopback pipeline audiosink
Webrtc handle can have a source that consists of audio, video or both
media types. Each type can have a loopback pipeline. So it is set to FALSE
to render the incoming data from pad probe callback as soon as possible.
[Version] 0.2.120
[Issue Type] Improvement
Change-Id: I3f46e96123031598a5d86fa8fc85c1ec96772e4a
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
backto.kim [Fri, 8 Oct 2021 06:26:59 +0000 (15:26 +0900)]
webrtc_source: add queue after the decodebin in the filesrc pipeline
[Version] 0.2.119
[Issue Type] Improvement
Previously, a probe for loopback support was attached to decodebin's pad,
but decodebin deletes all pads when state goes to NULL.
The loopback setting must be maintained until the user unset it.
So, a queue was added after the decodebin and support loopback.
Change-Id: Ia1aaba9fa3b5b995161216294dcb49b6930c8624
Seungbae Shin [Wed, 6 Oct 2021 12:42:12 +0000 (21:42 +0900)]
webrtc_source: refactor audio/video branches using static mapping table
[Version] 0.2.118
[Issue Type] Refactoring
Change-Id: I5046a03cf070e54a8e7624b273219ac4099e0d3b
backto.kim [Wed, 6 Oct 2021 09:30:16 +0000 (18:30 +0900)]
webrtc_source: rearrange codes to reduce code complexity
[Version] 0.2.117
[Issue Type] Refactoring
Change-Id: I31b43afb40ae1bd5a829dc1ccb99685bd4ead1a4
Sangchul Lee [Thu, 7 Oct 2021 08:08:39 +0000 (17:08 +0900)]
webrtc_source: Return error when loopback pipeline has already been set
[Version] 0.2.116
[Issue Type] Bug fix
Change-Id: Ie6b408cfb75cc7a827a94b068e8d0042a064cb3a
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
backto.kim [Wed, 6 Oct 2021 07:30:28 +0000 (16:30 +0900)]
webrtc_source: rearrange codes of __create_rest_of_elements_for_filesrc_pipeline() to reduce code complexity
[Version] 0.2.115
[Issue Type] Refactoring
Change-Id: Ibed6a8d5b613e91af1a8a6c6f944e59dcdeae569
backto.kim [Tue, 5 Oct 2021 05:13:38 +0000 (14:13 +0900)]
webrtc_source: Fix invalid use of capsfilter
[Version] 0.2.114
[Issue Type] Improvement
Change-Id: I98dc18b2139c767f6d917962d1e5d613a679d37b
backto.kim [Tue, 28 Sep 2021 03:39:54 +0000 (12:39 +0900)]
Add API to set/get file source looping
Functions are added as below.
- webrtc_file_source_set_looping()
- webrtc_file_source_get_looping()
[Version] 0.2.113
[Issue type] API
Change-Id: Ie088db29ac4aeaf19fe2d5f85138787c4da5c9f7
backto.kim [Fri, 17 Sep 2021 08:35:03 +0000 (17:35 +0900)]
Change the structure of file src
A separate pipeline for filesrc is added, and the existing src bin receives input with appsrc.
This makes functions such as file looping convenient by separately managing pipelines.
[Version] 0.2.112
[Issue Type] Improvement
Change-Id: I69e1edea62515eb57987624e12bf863fa653b3fc
Sangchul Lee [Thu, 30 Sep 2021 08:31:09 +0000 (17:31 +0900)]
webrtc_test: Apply -Wcast-function-type and fix the error
It is added to comply with VD COSMOS build configuration.
[Version] 0.2.111
[Issue Type] Improvement
Change-Id: I104e55c2520708641b6bf56daf7a9765a4f41c2e
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 29 Sep 2021 07:55:37 +0000 (16:55 +0900)]
webrtc_websocket: Fix missing field initializers
Apply -Wmissing-field-initializers and fix the errors.
It is added to comply with VD build configuration.
[Version] 0.2.110
[Issue Type] Improvement
Change-Id: Iab651b06a2d89e51c4c8f40c9fb5831d4038c8c6
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 29 Sep 2021 06:40:05 +0000 (15:40 +0900)]
webrtc_sink/data_channel: Fix coverity issues (CHECKED_RETURN)
[Version] 0.2.109
[Issue Type] Coverity (CHECKED_RETURN)
Change-Id: I6911282dc9f226be4eafa59f485d2a5cc109a244
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 29 Sep 2021 03:08:30 +0000 (12:08 +0900)]
webrtc_test: Fix coverity issue of USE_AFTER_FREE
[Version] 0.2.108
[Issue Type] Coverity (USE_AFTER_FREE)
Change-Id: Ic67674d991bfe8de19e03058b77646248d634221
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 17 Sep 2021 07:20:23 +0000 (16:20 +0900)]
webrtc_test: Prepare for test case with esplusplayer to render data when using encoded frame callback
It'll be the default case to test encoded frame callback.
For now, it is excluded when TV profile build.
[Version] 0.2.107
[Issue Type] Improvement
Change-Id: I85bae50e99bd937daf2e53aa901a1ecd90a6de98
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 27 Sep 2021 09:19:47 +0000 (18:19 +0900)]
webrtc: Add missing precondition for negotiation callbacks
[Version] 0.2.106
[Issue Type] Doxygen
Change-Id: If95522da7cdd138ca5a4f1eb734bd9b4f0a7353d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 27 Sep 2021 08:31:56 +0000 (17:31 +0900)]
Apply -Wsign-compare and fix the errors
It is added to comply with VD build configuration.
[Version] 0.2.105
[Issue Type] Improvement
Change-Id: Ia863063842cd95f23c6db3b320923ae182ef6945
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 27 Sep 2021 08:07:32 +0000 (17:07 +0900)]
Apply -Wshadow and fix the errors
It is added to comply with VD build configuration.
[Version] 0.2.104
[Issue Type] Improvement
Change-Id: Id1481b5077723fd0ca74107fe1d618a0d5974c20
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 24 Sep 2021 09:22:56 +0000 (18:22 +0900)]
webrtc_display: Revise logic for display mode/visible
Default mode and visible values are set when allocating display.
These values can be updated by setter APIs regardless of sink_element set.
Check properties for mode and visible before g_object_set().
[Version] 0.2.103
[Issue Type] Improvement
Change-Id: I9f98c764e73e23e7f6a87a167ba1211460b45360
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 24 Sep 2021 06:27:14 +0000 (15:27 +0900)]
webrtc_test: Add menu to get data channel label
dl. Get data channel label
[Version] 0.2.102
[Issue Type] Add
Change-Id: I37a592bb42d3a6a854b8dca03c223b873b9e71ee
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 24 Sep 2021 05:47:30 +0000 (14:47 +0900)]
webrtc_test: Print * to represent the internal API
[Version] 0.2.101
[Issue Type] Revise
Change-Id: Ibdbe0c53d503dadf50f22180a714d51ae44b4419
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 15 Sep 2021 09:07:53 +0000 (18:07 +0900)]
webrtc_sink: Use fakesink to drop receiving audio data if stream_info is not set
[Version] 0.2.100
[Issue Type] Improvement
Change-Id: I056d6b1b4fce1dfcb0a20a969631326ec7d7be7d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 15 Sep 2021 08:41:06 +0000 (17:41 +0900)]
webrtc_sink: Use fakesink to drop receiving video data if display is not set
[Version] 0.2.99
[Issue Type] Improvement
Change-Id: I69296f2abe7792e5b6f2c468d5b1bbba58b4f860
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Hyunil [Thu, 2 Sep 2021 05:57:27 +0000 (14:57 +0900)]
Add new internal APIs for setting or unsetting crop screen source
- webrtc_screen_source_set_crop()
- webrtc_screen_source_unset_crop()
- Add function test to webrtc_test
[Version] 0.2.98
[Issue Type] New feature
Change-Id: Ib1f36d6b84ce3ff429ff0ae20879b50b6f5af011
Signed-off-by: Hyunil <hyunil46.park@samsung.com>
Sangchul Lee [Wed, 8 Sep 2021 01:18:49 +0000 (10:18 +0900)]
webrtc_doc: Update description
[Version] 0.2.97
[Issue Type] Document
Change-Id: I546caef069a8ba2f7319dabe72e021e4e7260dac
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 8 Sep 2021 04:53:19 +0000 (13:53 +0900)]
webrtc_sink: Lock mutex of display in __build_videosink()
It is improved to guard display structure while accessing it.
[Version] 0.2.96
[Issue Type] Improvement
Change-Id: I61f86eaa3970e659b614d3bdb9cb9d589254b23b
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 7 Sep 2021 10:19:56 +0000 (19:19 +0900)]
webrtc_ini: Add support for printing stats log periodically
[general]
stats log period = 0
It is added to print statistics log periodically to check current
situation of data transmission without any user input.
In case of 0 sec, it does not print any stats logs.
[Version] 0.2.95
[Issue Type] Log
Change-Id: Ibc0b418d7c6544f995b5d78822d8df241c064f7c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
backto.kim [Mon, 6 Sep 2021 07:43:01 +0000 (16:43 +0900)]
move webrtc_file_source_set_path() to internal
[Version] 0.2.94
[Issue Type] API
Change-Id: I8913184b8ab51d85f70fdcfda0aec0dc585645d8
Sangchul Lee [Mon, 6 Sep 2021 05:18:01 +0000 (14:18 +0900)]
fixup! webrtc_ini: Add new item to set libnice verbose log
Change-Id: Ife051178de6bc972a4925124c0270fae74c86c24
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
YoungHun Kim [Wed, 18 Aug 2021 06:22:08 +0000 (15:22 +0900)]
webrtc_ini: Add new item to set libnice verbose log
[Version] 0.2.93
[Issue Type] Improvement
Change-Id: Ib173a0b87c0cf9aed322e158c302127b35682117
Sangchul Lee [Tue, 31 Aug 2021 08:57:45 +0000 (17:57 +0900)]
webrtc_test: Add menu for creating offer/answer asynchronously
[Version] 0.2.92
[Issue Type] New feature
Change-Id: I2b30064c4731d82c38786913ff0ddc0f866144f4
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 27 Aug 2021 09:27:18 +0000 (18:27 +0900)]
Add new asynchronous API to create offer/answer
Functions are added as below.
- webrtc_create_offer_async()
- webrtc_create_answer_async()
[Version] 0.2.91
[Issue Type] API
Change-Id: I5641f98fcd272ddd52f5173c048a9db3a94a9222
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 31 Aug 2021 05:43:29 +0000 (14:43 +0900)]
webrtc_test: Add missing initializing variables after free()
It caused a double-free crash when negotiating again with new handle
even if the 'd'(destroy) menu was executed for the previous handle
without program exit.
[Version] 0.2.90
[Issue Type] Bug fix
Change-Id: I48df929d6744d434f23f7d550d692e92b0b61609
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 30 Aug 2021 09:21:22 +0000 (18:21 +0900)]
webrtc_source: Set omitted display->sink_element in case of OVERLAY display type
It will be used when setting a display mode/visible to the track id of
video loopback pipeline.
[Version] 0.2.89
[Issue Type] Bug fix
Change-Id: I03cc2b3807495d3851643fc804f03570ad2ebab8
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 27 Aug 2021 08:40:02 +0000 (17:40 +0900)]
webrtc_source: Use fixed payload id for particular codecs
This patch enables normal operation with that codecs between
web API and gstreamer webrtc at last.
[Version] 0.2.88
[Issue Type] Improvement
Change-Id: Ib4094ac5814d59632032f649a69e0b45bc5b4b1d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 27 Aug 2021 06:23:51 +0000 (15:23 +0900)]
webrtc_private: Apply FEC in case of answerer without setting any media source
If a webrtc handle that does not have any media source, so-called recvonly,
tries to create an answer SDP with the received offer SDP, FEC also should be
applied according to ini configuration if the offerer wants to use the FEC.
[Version] 0.2.87
[Issue Type] Improvement
Change-Id: I182bbc1a982ff244e0656d78dbc9cc833fd0b4f0
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 27 Aug 2021 03:51:09 +0000 (12:51 +0900)]
webrtc_source: Add support for G.711 one of mandatory audio codecs
PCMU and PCMA which support 64kbps with 8kHz sample rates are added.
Please refer to https://datatracker.ietf.org/doc/html/rfc7874 for
more details.
[Version] 0.2.86
[Issue Type] New feature
Change-Id: I56b2972817a652761cc8f0249d4ecf29389ec0df
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 26 Aug 2021 11:10:48 +0000 (20:10 +0900)]
webrtc_source: Remove S24LE audio raw format
The gstreamer encoders for PCMU/PCMA/OPUS, the formats supported by
the WebRTC spec, do not support 24bit PCM format as its input.
[Version] 0.2.85
[Issue Type] Clean-up
Change-Id: I374876c7806b01ba0902cb72a554a676863c550f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 26 Aug 2021 07:16:00 +0000 (16:16 +0900)]
webrtc_source/display/tbm: Change some logs to verbose level
[Version] 0.2.84
[Issue Type] Log
Change-Id: I815d44f8332e839604f7660c678c26cca4a6347e
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 26 Aug 2021 05:57:06 +0000 (14:57 +0900)]
webrtc_ini: Add new item for verbose logging
[general]
verbose log = yes or no
LOG_VERBOSE() macro is also added.
[Version] 0.2.83
[Issue Type] New feature
Change-Id: I84d74b99496e1062445ef49423b6b9a643534286
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 25 Aug 2021 08:58:02 +0000 (17:58 +0900)]
webrtc_private: Increase timeout value when getting an offer/answer message
It is changed from 10 sec. to 30 sec.
Also, null checking code is added for gst_promise_get_reply().
[Version] 0.2.82
[Issue Type] Improvement
Change-Id: Ic83418d46a33eb0a0c98628f4fbc4631862cc21d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 24 Aug 2021 08:14:16 +0000 (17:14 +0900)]
webrtc_private: Remove workaround codes regarding negotiation needed callback
[Version] 0.2.81
[Issue Type] Improvement
Change-Id: I9e1686e858b3c7ae25976af2ed5ff9fde482d040
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 17 Aug 2021 11:25:54 +0000 (20:25 +0900)]
Add support for statistic functionality
[Version] 0.2.80
[Issue Type] New feature
Change-Id: I284137c02bc53c24e731c90265e6df3e420bbdef
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 23 Aug 2021 03:09:13 +0000 (12:09 +0900)]
webrtc_display: Check return value of gst_video_info_from_caps()
[Version] 0.2.79
[Issue Type] Coverity (CHECKED_RETURN)
Change-Id: I6c7ff1dfc4c2352122c57c5a53fa160928033cec
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 17 Aug 2021 03:53:04 +0000 (12:53 +0900)]
webrtc_private: Remove unuseful generating dot files
These are not related to the pipeline changes.
Plus some invoked in the main thread are cause of deadlock
when the 'generate dot' is enabled in ini file.
[Version] 0.2.78
[Issue Type] Cleanup & Bug fix
Change-Id: I61dbf149b26999672f748ae4867f46476fd9f929
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
backto.kim [Wed, 11 Aug 2021 09:00:23 +0000 (18:00 +0900)]
webrtc_source: enable loopback for filesrc
When the pipeline status becomes NULL, the decodebin destroys all of the added pads and associated probes.
so, the probe information related to loopback should be reinitialized when the pad in the decodebin is removed.
[Version] 0.2.77
[Issue Type] Improvement
Change-Id: I2e07ac17736304bf32b1d31bfa52d99e75613fdb
backto.kim [Mon, 9 Aug 2021 03:25:31 +0000 (12:25 +0900)]
webrtc_source: set proper media types for filesrc
[Version] 0.2.76
[Issue Type] Improvement
Change-Id: I3bf6b2ac6c1d8e641e2628f6a4e31eb28d339cea
Sangchul Lee [Thu, 12 Aug 2021 09:19:00 +0000 (18:19 +0900)]
webrtc/webrtc_websocket: Apply g_mutex_locker_new()
Unused macros are removed
[Version] 0.2.75
[Issue Type] Refactoring
Change-Id: Icba100fdca5d5f8a92bd25bd7cfab4a8eb31fc88
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 12 Aug 2021 03:38:35 +0000 (12:38 +0900)]
webrtc_test: Check null before freeing device list
[Version] 0.2.74
[Issue Type] Bug fix
Change-Id: If1686021704fa72df73834f3269139e07ef0be38
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 12 Aug 2021 03:10:40 +0000 (12:10 +0900)]
webrtc_test: Realign menu
[Version] 0.2.73
[Issue Type] Cleanup
Change-Id: If3cb054baf5de692a764b32455649fd22aad975c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>