Niraj Kumar Goit [Mon, 23 Sep 2019 10:15:33 +0000 (15:45 +0530)]
Added support to enable/disable Auto-IP option.
Added support to enable/disable Auto-IP option using main.conf
Change-Id: Iea1cae5a28681a90a5f79735c7374791a227feb7
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Nishant Chaprana [Fri, 20 Sep 2019 09:47:57 +0000 (15:17 +0530)]
Fixed dbus rules for connman-vpn-dbus.conf
Change-Id: Iaa437db1f9408f34f4f95ac47bbc2a2da49b2779
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Nishant Chaprana [Tue, 17 Sep 2019 13:30:55 +0000 (19:00 +0530)]
Imported Upstream version 1.37
Change-Id: Idb47c1ddbedc9f97181b8e9a5eeac04ddd832a2c
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Jaehyun Kim [Tue, 10 Sep 2019 08:11:13 +0000 (08:11 +0000)]
Merge "Emit Service PropertyChanged when ConnectReason and DisconnectionRequested changes" into tizen
Jaehyun Kim [Tue, 10 Sep 2019 08:08:14 +0000 (08:08 +0000)]
Merge "Update RSSI/Strength of connected service using SignalPoll event" into tizen
Nishant Chaprana [Fri, 6 Sep 2019 15:22:47 +0000 (20:52 +0530)]
Emit Service PropertyChanged when ConnectReason and DisconnectionRequested changes
Description: The properties perform below tasks:-
1. ConnectReason: To identify whether connection was an autoconnection or user initiated.
2. DisconnectionRequested: To identify whether disconnection was user initiated or not.
Change-Id: I2ba4fc4637673571745517cdc33fc3a6d6367953
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Jaehyun Kim [Wed, 4 Sep 2019 11:52:00 +0000 (20:52 +0900)]
Fixed invalid state transitions
Fixed the case where the ConnMan is changed to Idle state without going through Disconnect state in Connected state.
* Disconnect state indicates that it is going to terminate the current connection and will return to the Idle state.
Change-Id: I81becdd043d599df4257d30c94ce2a2038f72b2d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Nishant Chaprana [Tue, 30 Apr 2019 12:22:29 +0000 (17:52 +0530)]
Update RSSI/Strength of connected service using SignalPoll event
This patch reduced the SignalPoll monitor from 30 second to 10 second frequency.
This patch also extracts already available parameter strength/RSSI in SignalPoll
and update connected service's RSSI/Strength accordingly.
Change-Id: Ie9bbb21bf50ad0b8c72e3ca2fc9f7f6500c77f23
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Niraj Kumar Goit [Mon, 26 Aug 2019 12:00:39 +0000 (17:30 +0530)]
Sort hidden profiles based on modified time.
When there are multiple hidden profiles stored in connman, sort
hidden profiles based on modified time (latest on top) and then
send scan request.
Change-Id: Ib27a31db94b4fafe9521414ab19702f08f5df783
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Jaehyun Kim [Mon, 19 Aug 2019 06:41:33 +0000 (06:41 +0000)]
Merge "Remove DefaultDependencies=no at connman.service" into tizen
INSUN PYO [Wed, 7 Aug 2019 02:44:29 +0000 (11:44 +0900)]
Remove duplicate dependency with implicit dependencies at "Type=dbus"
Refs: https://www.freedesktop.org/software/systemd/man/systemd.service.html
- Services with Type=dbus set automatically acquire dependencies of type Requires= and After= on dbus.socket.
Change-Id: Ic6009027222e293f8525a6b4a97512d7580be3f0
Jaehyun Kim [Tue, 6 Aug 2019 07:40:26 +0000 (16:40 +0900)]
Add support to find stored Hidden AP when it's channel is changed
Change-Id: Ideb03d497be9654f6b03fcd289a0b30aba42b189
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Wed, 31 Jul 2019 13:45:54 +0000 (22:45 +0900)]
Add an option for gateway timeserver handling
Change-Id: I19f09647b7471f146adb95bc7e81fd9ab11f18ac
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 29 Jul 2019 08:58:04 +0000 (08:58 +0000)]
Merge "Add OWE security mode support" into tizen
Jaehyun Kim [Fri, 26 Jul 2019 12:22:49 +0000 (12:22 +0000)]
Merge "Refactoring of scan for stored hidden profiles." into tizen
Jaehyun Kim [Thu, 25 Jul 2019 12:58:47 +0000 (21:58 +0900)]
Do not validate the passphrase for the SAE security type when it is encrypted.
Change-Id: Ibd82d445a8c0bd80a9b0804dd3d8b639797f8cb2
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Thu, 25 Jul 2019 12:34:33 +0000 (12:34 +0000)]
Merge "Added support to get AP hidden status." into tizen
Jaehyun Kim [Thu, 25 Jul 2019 12:32:22 +0000 (12:32 +0000)]
Merge "Delete meaningless configuration" into tizen
Niraj Kumar Goit [Tue, 16 Jul 2019 11:20:22 +0000 (16:50 +0530)]
Added support to get AP hidden status.
Change-Id: Ib8014d9ff53d896a12d0bf985168b7df589d9f22
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Yu [Thu, 25 Jul 2019 04:24:57 +0000 (13:24 +0900)]
Add OWE security mode support
Change-Id: I03ab90b8ab78e489d1ef70fbec57f10576860a57
Signed-off-by: Yu jiung <jiung.yu@samsung.com>
INSUN PYO [Tue, 23 Jul 2019 11:17:53 +0000 (20:17 +0900)]
Remove unnecessary setting
Service and Socket unit has an implicit dependencies.
Refre: https://www.freedesktop.org/software/systemd/man/systemd.socket.html
"Socket units automatically gain a Before= dependency on the service units they activate."
Change-Id: I97710fb27fd3294332283a8bffde0d3765b4428e
INSUN PYO [Wed, 17 Jul 2019 04:29:12 +0000 (13:29 +0900)]
Remove DefaultDependencies=no at connman.service
net-config.service has "After=net-config.service" dependency.
But net-config.service don't have DefaultDependencies=no.
So "DefaultDependencies=no" does not have any effect on connman.service, but instead it is confusing.
Change-Id: I6a3c78f18c3029314c2a8c0e6b8c72e65c868fe8
INSUN PYO [Mon, 8 Jul 2019 10:02:25 +0000 (19:02 +0900)]
Delete meaningless configuration
Change-Id: Ida02a51bc1efe14b8d271e27898b3bd0d105797b
Nishant Chaprana [Thu, 4 Jul 2019 12:11:09 +0000 (17:41 +0530)]
Imported Upstream version 1.37
Change-Id: Ib5957e7ee3a9315ee86a331189bc3e9e71751ee8
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Jaehyun Kim [Fri, 28 Jun 2019 05:59:03 +0000 (05:59 +0000)]
Merge "Change the config value of the "FreeBind=" ("true" -> "yes")" into tizen
Niraj Kumar Goit [Wed, 26 Jun 2019 08:02:17 +0000 (13:32 +0530)]
Append disconnect reason code in case of invalid key.
Change-Id: Ie95d9be974d685f0601b2a6592c5f2d45e88fdd7
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
INSUN PYO [Wed, 26 Jun 2019 00:54:33 +0000 (09:54 +0900)]
Change the config value of the "FreeBind=" ("true" -> "yes")
Change-Id: I5cbc48dfe7ab4f4402d04fdb5ebba1d220e457a6
Niraj Kumar Goit [Thu, 30 May 2019 10:43:20 +0000 (16:13 +0530)]
Added support of WPA3-SAE security mode.
Change-Id: I8612c52dc0cc078459fa19aa8a639597f070b293
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Jaehyun Kim [Tue, 11 Jun 2019 12:55:14 +0000 (21:55 +0900)]
Fixed to prevent bssid corruption
Change-Id: I26b9d81fad917939750b42c893ea5e44824ba270
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Tue, 21 May 2019 13:08:20 +0000 (22:08 +0900)]
Improve support of Multiple same SSIDs including band steering.
1. Supports up to 8 BSSIDs per each SSID
2. Attempt to connect only once per each BSSID
3. Sorted by signal strength and try to connect in sorted order
4. Sets the correct frequency for each bssid.
Change-Id: I668fff29f2df99b2e5f637a39b5c70da84f8ee1c
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Niraj Kumar Goit [Mon, 24 Dec 2018 12:20:27 +0000 (17:50 +0530)]
Added support to get maximum scan SSIDs.
Added support to get Max number of SSIDs scan supported by wlan chipset.
Change-Id: If4cbc07f6937718fab123600a962179b3adbc081
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Nishant Chaprana [Wed, 22 May 2019 16:48:39 +0000 (22:18 +0530)]
Fixed build issue when built with --enable-tizen-ext-wifi-mesh option
Below error comes when compiled with --enable-tizen-ext-wifi-mesh option:-
[ 168s] src/mesh-netlink.c:29:31: fatal error: netlink/genl/genl.h: No such file or directory
[ 168s] #include <netlink/genl/genl.h>
[ 168s] ^
[ 168s] compilation terminated.
[ 168s] Makefile:4430: recipe for target 'src/src_connmand-mesh-netlink.o' failed
[ 168s] make[1]: *** [src/src_connmand-mesh-netlink.o] Error 1
[ 168s] make[1]: *** Waiting for unfinished jobs....
[ 168s] CC gweb/vpn_connman_vpnd-gionotls.o
[ 169s] Makefile:1815: recipe for target 'all' failed
[ 169s] make: *** [all] Error 2
Change-Id: Ib62a65cc0dbecca86a6ae9d67bfae880fcb30bbd
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Niraj Kumar Goit [Thu, 16 May 2019 06:04:40 +0000 (11:34 +0530)]
Refactoring of scan for stored hidden profiles.
To improve scan performance, when there are hidden profiles stored
in connman and user request for scan, send ScanDone signal after
scanning maximum scan ssids supported by driver instead of sending signal
after scanning all the stored hidden profiles.
Similarly in next scan request, perform scanning (maximum scan ssids) from
remaining hidden profiles and send ScanDone signal.
Change-Id: I6195668c59b0a75bd0e0097ab6e6b7e3d33aae38
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Nishant Chaprana [Wed, 1 May 2019 05:16:30 +0000 (10:46 +0530)]
Use libnl-3.0 in place of libnl-2.0
Change-Id: Ic654296e6494b587d7aaf1f888715b59ddee1bf4
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Niraj Kumar Goit [Fri, 29 Mar 2019 10:35:49 +0000 (16:05 +0530)]
Added support of Multiple same SSIDs including band steering.
When there are multiple APs with the same SSID and security,
this patch support below features:
1. If AP does not respond to probe request during connection
procedure, connman tries to connect with the next available BSSID
before sending disconnected event to application.
2. If connection with AP is failed during association due to
ASSOC_REJECT, connman tries to connect with the next available BSSID
before sending disconnected event to application.
Change-Id: Ie80939bd013a12b9c88e91a1fd5a05fbb57c1833
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Niraj Kumar Goit [Fri, 29 Mar 2019 05:24:53 +0000 (10:54 +0530)]
[Upstream]gsupplicant: Switch to different BSSID of same SSID in case of signal bss removed
Teach ConnMan to select the next BSSID when two APs (e.g. 2.4 GHz and
5 GHz) with the same SSID and security configuration are available.
Currently when one AP disappears ConnMan will retry to connect to the
old AP point even though there is another matching BSSID available.
So when wpa_supplicant sends a remove signal we find a matching BSSID
and use it even when it's not from the same AP.
https://git.kernel.org/pub/scm/network/connman/connman.git/commit/?id=
c1debcac758ef1f76a788225679003e2e67d9fdf
Change-Id: Ic5ce438addc823ebd0c6bedd2a974f559b33ae25
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Jaehyun Kim [Tue, 19 Feb 2019 04:41:22 +0000 (13:41 +0900)]
Remove the timer for MaxSpeed polling when the interface is removed
Change-Id: I1ed15eb5815c4e7e94c2d26a7f6358f15b2b68ef
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Lokesh [Mon, 18 Feb 2019 10:03:04 +0000 (15:33 +0530)]
Fix the dangling pointer(network) inside autosignalpoll_timeout().
Change-Id: I47d74342b861db29c2b36094539a84b73dce7e55
Signed-off-by: Lokesh <l.kasana@samsung.com>
Jaehyun Kim [Thu, 31 Jan 2019 13:08:15 +0000 (22:08 +0900)]
Disable backtrace option
Change-Id: Ie53230568c290b1449e145e9c77f36cfc1af8a03
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Thu, 24 Jan 2019 13:24:50 +0000 (22:24 +0900)]
Fixed SVACE issues
Change-Id: I84e9c9a7719e017892d4f353cf141901ca94beb8
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Tue, 22 Jan 2019 06:56:35 +0000 (15:56 +0900)]
Increase MAX_LOG_COUNT to 15
Change-Id: I9558c05c45ec0327e15377efb61f3f19592e75af
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Seonah Moon [Wed, 26 Dec 2018 08:44:54 +0000 (17:44 +0900)]
Add code for handling NULL exception
Change-Id: I5b3ae0a5305db81aeba848e5d7353ca44522f35c
Jaehyun Kim [Tue, 18 Dec 2018 02:26:30 +0000 (02:26 +0000)]
Merge "Copy vsie_list before remove old list" into tizen
Jaehyun Kim [Tue, 18 Dec 2018 02:25:30 +0000 (02:25 +0000)]
Merge "[Upstream] Fix return value in error path." into tizen
Seonah Moon [Mon, 17 Dec 2018 11:53:34 +0000 (20:53 +0900)]
Copy vsie_list before remove old list
Change-Id: Iec590090bbc87d3a2d573148929681abae5d8c02
Abhishek Sansanwal [Thu, 13 Dec 2018 05:21:58 +0000 (10:51 +0530)]
Added dbus method to get whether 5Ghz band is supported
Change-Id: Ib3b189615648a35aa876eab3e3f61c47ac0c1e68
Signed-off-by: Abhishek Sansanwal <abhishek.s94@samsung.com>
Niraj Kumar Goit [Wed, 12 Dec 2018 08:48:34 +0000 (14:18 +0530)]
[Upstream] Fix return value in error path.
Returning -1 in a function with bool as return value is the same as
returning true. Change to false to indicate error if inet_aton() fails.
Change-Id: I3dea40bc2506b1a2a0a65e7e838691fc3af957bd
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Jaehyun Kim [Tue, 6 Nov 2018 10:38:29 +0000 (10:38 +0000)]
Merge "Add IEEE 802.11 protocol(b/g/n/a/ac) Modes of APs" into tizen
Jaehyun Kim [Tue, 6 Nov 2018 10:37:10 +0000 (10:37 +0000)]
Merge "[CONNMAN][Change AP's max speed logic]" into tizen
Milind Murhekar [Fri, 21 Sep 2018 14:06:20 +0000 (19:36 +0530)]
Add IEEE 802.11 protocol(b/g/n/a/ac) Modes of APs
This patch appends the IEEE 802.11b/g/n/a/ac PHY
protocol modes of scanned Access Points
using internal logic.
Following logic is used to determine WLAN HW protocol:-
1) If “Supported rates” is only till 11 Mbps, and frequency is in
2.4GHz band, then protocol is 802.11B.
2) If “Supported rates” is till 54Mbps or “Extended supported rates”
are present, and frequency is in 2.4GHz band, then protocol is 802.11G.
3) If “Supported rates” is only till 54 Mbps, frequency is in 5GHz
band , then protocol is 802.11A.
4) If “HT capabilities” is supported , then protocol is 802.11N.
5) If “HT capabilities” & “VHT” is supported and frequency is in 5 GHz
band, then protocol is 802.11AC.
Change-Id: I1156ef249cf4a8052a883d31da66788c7d2de22f
Mayank Haarit [Tue, 18 Sep 2018 14:43:57 +0000 (20:13 +0530)]
[CONNMAN][Change AP's max speed logic]
This patch changes the internal logic of getting
max speed from connected AP.
Change-Id: I7191a09f1d974f1158ce9440cfa6924feca61340
Signed-off-by: Mayank Haarit <mayank.h@samsung.com>
Niraj Kumar Goit [Thu, 27 Sep 2018 11:48:05 +0000 (17:18 +0530)]
Added support to update EAP manual IP.
Added support to update EAP manual IP setting using
wifi_manager_update_ap()
Change-Id: Ifa331ec3b1e4bd95262f63698d32f65e6128518c
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Jaehyun Kim [Wed, 19 Sep 2018 08:39:04 +0000 (17:39 +0900)]
Fixed null dereferencing
Change-Id: I969a45edc0d4e16d61de0050466cd80c92c7c5e1
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Fri, 14 Sep 2018 10:36:47 +0000 (19:36 +0900)]
Disable the changed default connection policy
Change-Id: I56071afe5fe303a977b791807089ec8c3786ceef
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Fri, 14 Sep 2018 10:29:50 +0000 (10:29 +0000)]
Merge "Online Check: Change default connection policy" into tizen
Jaehyun Kim [Thu, 13 Sep 2018 04:08:21 +0000 (13:08 +0900)]
Fixed 'incompatible pointer type' warning
Change-Id: If6a491f11ab73e2039d3194b8a02a24313fa78d7
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Thu, 13 Sep 2018 03:57:48 +0000 (12:57 +0900)]
Fixed some build warnings
Change-Id: I09c0c02541a0f7cb469e009b53d87fccbed742e1
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 10 Sep 2018 12:39:40 +0000 (21:39 +0900)]
Modified dbus config file permission
Change-Id: I4d1a8560399fcfd726271682f6f26d68b1408bf5
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
taesub.kim [Tue, 4 Sep 2018 03:57:51 +0000 (03:57 +0000)]
Merge "Modified file permission" into tizen
Nishant Chaprana [Fri, 31 Aug 2018 12:59:58 +0000 (18:29 +0530)]
[Wi-Fi Mesh] Added dbus privilege for method calls
Change-Id: I2f6b6233ac682959abd1221a61aaeffa5bdfdd63
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Saurav Babu [Fri, 31 Aug 2018 09:40:24 +0000 (15:10 +0530)]
Online Check: Change default connection policy
1. Modified the priority of default connection
2. Disconnect the cellular when wifi state is online
3. Added a dbus-api for downgrading the wifi state to ready
4. Modified the connman_service_get_default_connection()
Change-Id: Ie062d86479a9bc80919ba7d0c168028f61a9c7be
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
taesub.kim [Tue, 28 Aug 2018 06:42:43 +0000 (15:42 +0900)]
Modified file permission
Change-Id: I519f531250371b30b3bc882046ac9dbc739a7836
Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
Nishant Chaprana [Fri, 10 Aug 2018 11:11:37 +0000 (16:41 +0530)]
[connman] Added Tizen Wi-Fi Mesh
Change-Id: Iec2ec99fb7d4fc6d9c0539e5a9e7c903e1969580
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Nishant Chaprana [Thu, 16 Aug 2018 04:19:38 +0000 (09:49 +0530)]
[Fix][icmpv6_recv] No need to free data using xs_cleanup(), data is already freed in icmpv6_event()
Change-Id: I19b028f5a93f7a4efbcf6e7c92113c363d7bb534
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
taesub.kim [Tue, 7 Aug 2018 06:14:32 +0000 (15:14 +0900)]
Remove unnecessary rule in dbus.conf file
Change-Id: I89ab130e5451756d9e8df6e576836f036be0b5b4
Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
taesub kim [Wed, 1 Aug 2018 21:26:50 +0000 (21:26 +0000)]
Merge "Fixed the EAP security issue" into tizen
Jaehyun Kim [Fri, 27 Jul 2018 12:45:51 +0000 (21:45 +0900)]
Fixed invalid memory access during connection
Change-Id: I10e219cdc4ea66f0e5e3208d1c9e505a63758607
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Bhaskar Dutta [Fri, 20 Jul 2018 12:10:11 +0000 (17:40 +0530)]
Fixed the EAP security issue
Description :
1. App send anonymous identity and connect with EAP network.
And connman store it inside corresponding network pointer.
2. Then if user disconnect that connection,forgetAP will be called.
And connman does not clear last anonymous identity data for that service.
3. Next time when user again connect with same EAP network, but without anonymous identity.
Then previous anonymous identity will be passwed to WPA suplicant. But blank anonymous identity should be treated.
Change-Id: I267bea4d394390e82351ae997229c69785ea6d6d
Signed-off-by: Bhaskar Dutta <bhaskar.d@samsung.com>
Saurav Babu [Thu, 5 Jul 2018 09:32:32 +0000 (15:02 +0530)]
service: Add new property to set passphrase of service
When AP is connected using WPS without SSID then its password needs to
be saved for future autoconnection
Change-Id: I7d771c14867e19c379ff4bba262f10a2fb578c17
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Jaehyun Kim [Thu, 28 Jun 2018 10:07:40 +0000 (19:07 +0900)]
Fixed an issue where communication with the telephony failed.
Change-Id: I0fee6ddc39aa6eacb268ade832a442c90a5961bd
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Saurav Babu [Tue, 5 Jun 2018 10:50:56 +0000 (16:20 +0530)]
Upstream: gdbus: Fixed incorrect DBusConnection reference counting
Commit ID:
c42a5f926fe2109e7a1dcc58fe6713bc3f5fd21d
Change-Id: I26ebd6150b183da7f1bf7102db8935c3bde6574e
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Tue, 5 Jun 2018 07:27:31 +0000 (12:57 +0530)]
telephony: Fixed memory leak
Valgrind reported memory leak with below backtrace
==3471== 1,934 (80 direct, 1,854 indirect) bytes in 2 blocks are
definitely lost in loss record 190 of 194
==3471== at 0x484801C: calloc (vg_replace_malloc.c:711)
==3471== by 0x49D687B: dbus_malloc0 (dbus-memory.c:572)
==3471== by 0x49BB9A3: _dbus_pending_call_new_unlocked (dbus-pending-call.c:124)
==3471== by 0x4995963: dbus_connection_send_with_reply (dbus-connection.c:3449)
==3471== by 0x135D8D: __dbus_request.constprop.8 (telephony.c:396)
==3471== by 0x135E6D: __request_get_services (telephony.c:477)
==3471== by 0x136F19: __add_modem (telephony.c:802)
==3471== by 0x13732F: __response_get_modems (telephony.c:464)
==3471== by 0x498FABB: complete_pending_call_and_unlock (dbus-connection.c:2340)
==3471== by 0x49981BF: dbus_connection_dispatch (dbus-connection.c:4757)
==3471== by 0x18E815: message_dispatch (mainloop.c:72)
==3471== by 0x48BB8E7: g_main_dispatch (gmain.c:3234)
==3471== by 0x48BB8E7: g_main_context_dispatch (gmain.c:3887
When dbus response is received then we should unref memory allocated by
libdbus
Change-Id: I81c514506f0df42e537d63382b2eb2ebc51c58c8
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Wed, 30 May 2018 07:06:40 +0000 (12:36 +0530)]
gsupplicant: Fixed invalid read issue
==1071== Invalid read of size 4
==1071== at 0x48DBB00: g_slist_length (gslist.c:856)
==1071== by 0x12A3C7: add_or_replace_bss_to_network (supplicant.c:1930)
==1071== by 0x12BB4D: signal_bss_changed (supplicant.c:3194)
==1071== by 0x12AFD1: g_supplicant_filter (supplicant.c:4038)
==1071== by 0x4998A17: dbus_connection_dispatch (dbus-connection.c:4808)
==1071== by 0x18E931: message_dispatch (mainloop.c:76)
==1071== by 0x48BB8E7: g_main_dispatch (gmain.c:3234)
==1071== by 0x48BB8E7: g_main_context_dispatch (gmain.c:3887)
==1071== by 0x48BBC77: g_main_context_iterate.isra.30 (gmain.c:3960)
==1071== by 0x48BBFD7: g_main_loop_run (gmain.c:4156)
==1071== by 0x119389: main (main.c:851)
==1071== Address 0x4e800a4 is 4 bytes inside a block of size 8 free'd
==1071== at 0x4846EC8: free (vg_replace_malloc.c:530)
==1071== by 0x48DB10F: g_slice_free_chain_with_offset (gslice.c:1232)
==1071== by 0x12A03F: remove_bss (supplicant.c:841)
==1071== by 0x48A858F: g_hash_table_remove_all_nodes.part.0 (ghash.c:548)
==1071== by 0x48A95B7: g_hash_table_remove_all_nodes (ghash.c:1428)
==1071== by 0x48A95B7: g_hash_table_remove_all (ghash.c:1431)
==1071== by 0x48A964B: g_hash_table_destroy (ghash.c:1124)
==1071== by 0x12A8E5: remove_network (supplicant.c:814)
==1071== by 0x48A8A3F: g_hash_table_remove_internal (ghash.c:1360)
==1071== by 0x12BB47: signal_bss_changed (supplicant.c:3192)
==1071== by 0x12AFD1: g_supplicant_filter (supplicant.c:4038)
==1071== by 0x4998A17: dbus_connection_dispatch (dbus-connection.c:4808)
==1071== by 0x18E931: message_dispatch (mainloop.c:76)
==1071== Block was alloc'd at
==1071== at 0x48458A4: malloc (vg_replace_malloc.c:299)
==1071== by 0x48C11B3: g_malloc (gmem.c:94)
==1071== by 0x48DA4A3: g_slice_alloc (gslice.c:1025)
==1071== by 0x48DB4AF: g_slist_prepend (gslist.c:254)
==1071== by 0x12C7D7: bss_process_ies (supplicant.c:2176)
==1071== by 0x12C7D7: bss_property (supplicant.c:2388)
==1071== by 0x1301FF: supplicant_dbus_property_foreach (dbus.c:145)
==1071== by 0x1302A1: property_get_all_reply (dbus.c:184)
==1071== by 0x498FABB: complete_pending_call_and_unlock (dbus-connection.c:2340)
==1071== by 0x49981BF: dbus_connection_dispatch (dbus-connection.c:4757)
==1071== by 0x18E931: message_dispatch (mainloop.c:76)
==1071== by 0x48BB8E7: g_main_dispatch (gmain.c:3234)
==1071== by 0x48BB8E7: g_main_context_dispatch (gmain.c:3887)
==1071== by 0x48BBC77: g_main_context_iterate.isra.30 (gmain.c:3960)
==1679== Invalid read of size 4
==1679== at 0x484D358: memmove (vg_replace_strmem.c:1258)
==1679== by 0x49D8307: memmove (string3.h:59)
==1679== by 0x49D8307: copy.isra.3 (dbus-string.c:1219)
==1679== by 0x49D209F: marshal_1_octets_array (dbus-marshal-basic.c:868)
==1679== by 0x49D209F: _dbus_marshal_write_fixed_multi (dbus-marshal-basic.c:1041)
==1679== by 0x49A4A3B: _dbus_type_writer_write_fixed_multi (dbus-marshal-recursive.c:2681)
==1679== by 0x13088D: supplicant_dbus_property_append_fixed_array (dbus.c:611)
==1679== by 0x12E775: supplicant_dbus_dict_append_fixed_array (dbus.h:121)
==1679== by 0x12E775: interface_add_network_params (supplicant.c:5518)
==1679== by 0x1306FB: supplicant_dbus_method_call (dbus.c:515)
==1679== by 0x12AF05: decryption_request_reply (supplicant.c:5713)
==1679== by 0x498FABB: complete_pending_call_and_unlock (dbus-connection.c:2340)
==1679== by 0x49981BF: dbus_connection_dispatch (dbus-connection.c:4757)
==1679== by 0x18E931: message_dispatch (mainloop.c:76)
==1679== by 0x48BB8E7: g_main_dispatch (gmain.c:3234)
==1679== by 0x48BB8E7: g_main_context_dispatch (gmain.c:3887)
Change-Id: I53652b06891fa8465e9dd425f425210ebc67ee9f
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Thu, 24 May 2018 06:31:54 +0000 (12:01 +0530)]
Fixed various memory leaks
Below are few of the valgrind outputs:
==2694== 7,484 (576 direct, 6,908 indirect) bytes in 72 blocks are definitely lost in loss record 196 of 197
==2694== at 0x48458A4: malloc (vg_replace_malloc.c:299)
==2694== by 0x48C11B3: g_malloc (gmem.c:94)
==2694== by 0x48DA4A3: g_slice_alloc (gslice.c:1025)
==2694== by 0x48DBA13: g_slist_append (gslist.c:213)
==2694== by 0x12EF29: g_supplicant_network_get_wifi_vsie(supplicant.c:1605)
==2694== by 0x127097: network_added (wifi.c:3447)
==2694== by 0x12A41D: callback_network_added (supplicant.c:624)
==2694== by 0x12A41D: add_or_replace_bss_to_network(supplicant.c:1967)
==2694== by 0x12B9C9: interface_bss_added_with_keys(supplicant.c:2457)
==2694== by 0x12B9C9: signal_bss_added (supplicant.c:3106)
==2694== by 0x12AF1D: g_supplicant_filter (supplicant.c:4045)
==2694== by 0x49904EB: dbus_connection_dispatch (in/usr/lib/libdbus-1.so.3.14.6)
==2694== by 0x18E921: message_dispatch (mainloop.c:76)
==2694== by 0x48BB8E7: g_main_dispatch (gmain.c:3234)
==2694== by 0x48BB8E7: g_main_context_dispatch (gmain.c:3887)
==2694== 1,980 (304 direct, 1,676 indirect) bytes in 38 blocks are definitely lost in loss record 187 of 197
==2694== at 0x48458A4: malloc (vg_replace_malloc.c:299)
==2694== by 0x48C11B3: g_malloc (gmem.c:94)
==2694== by 0x48DA4A3: g_slice_alloc (gslice.c:1025)
==2694== by 0x48DBA13: g_slist_append (gslist.c:213)
==2694== by 0x128D3F: update_bssid_list (supplicant.c:1637)
==2694== by 0x48A989F: g_hash_table_foreach (ghash.c:1610)
==2694== by 0x12EF91: g_supplicant_network_get_bssid_list(supplicant.c:1649)
==2694== by 0x127177: network_added (wifi.c:3489)
==2694== by 0x1294D5: callback_network_added (supplicant.c:624)
==2694== by 0x1294D5: scan_network_update (supplicant.c:2810)
==2694== by 0x130151: supplicant_dbus_array_foreach (dbus.c:106)
==2694== by 0x1298E3: scan_bss_data (supplicant.c:2824)
==2694== by 0x130071: property_get_reply (dbus.c:273)
==2694== 28 bytes in 2 blocks are definitely lost in loss record 87 of 197
==2694== at 0x48458A4: malloc (vg_replace_malloc.c:299)
==2694== by 0x48C11B3: g_malloc (gmem.c:94)
==2694== by 0x48DBF03: g_strdup (gstrfuncs.c:363)
==2694== by 0x12A65B: merge_network (supplicant.c:1737)
==2694== by 0x12A7D9: network_property (supplicant.c:1758)
==2694== by 0x12A7D9: interface_network_added (supplicant.c:1808)
==2694== by 0x12AF1D: g_supplicant_filter (supplicant.c:4045)
==2694== by 0x49904EB: dbus_connection_dispatch (in /usr/lib/libdbus-1.so.3.14.6)
==2694== by 0x18E921: message_dispatch (mainloop.c:76)
==2694== by 0x48BB8E7: g_main_dispatch (gmain.c:3234)
==2694== by 0x48BB8E7: g_main_context_dispatch (gmain.c:3887)
==2694== by 0x48BBC77: g_main_context_iterate.isra.30 (gmain.c:3960)
==2694== by 0x48BBFD7: g_main_loop_run (gmain.c:4156)
==2694== by 0x119391: main (main.c:851)
Change-Id: I3d86724c44b1593e5444a65eb7519bc150e50ee5
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Jaehyun Kim [Wed, 23 May 2018 12:47:34 +0000 (21:47 +0900)]
gsupplicant: Fixed resource leak
Change-Id: I423a3e680e528a36f98db5bdc2f68db15e707015
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Saurav Babu [Wed, 23 May 2018 11:50:59 +0000 (17:20 +0530)]
gsupplicant: Fixed crash issue
Change-Id: I568ffb360881ed78ac3c119c458220829d582d56
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Mon, 21 May 2018 09:46:26 +0000 (15:16 +0530)]
Don't remove network when G_SUPPLICANT_STATE_DISCONNECTED is received
In case of WPS PBC connection without SSID, sometimes few attempts fail
and on subsequent retries connection is established successfully. If we
remove network when disconnection is received for the first time from
wpa_supplicant then future retries doesn't take place and WPS connection
without SSID always fails
Change-Id: I2a5754c5e4a442e3305befdea3a94a6c728ef817
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Fri, 18 May 2018 05:54:45 +0000 (11:24 +0530)]
gsupplicant: Fixed crash issue when network exists in supplicant
In some cases interface->network_path exists but
interface->network_info.ssid is NULL which leads to crash with below
backtrace:
Program received signal SIGSEGV, Segmentation fault.
0xb6b0d184 in memcmp () from /lib/libc.so.6
(gdb) bt
#0 0xb6b0d184 in memcmp () from /lib/libc.so.6
#1 0xb6eb5530 in compare_network_parameters (ssid=0xb85aec20,
interface=0xb85a1710) at gsupplicant/supplicant.c:445
#2 g_supplicant_interface_connect (interface=0xb85a1710,
ssid=0xb85aec20, callback=0xb6eab039 <connect_callback>,
user_data=0xb859cbb0) at gsupplicant/supplicant.c:5839
#3 0xb6ecc000 in __connman_network_connect (network=0xb859cbb0) at
src/network.c:1711
#4 0xb6edaabe in service_connect (service=0xb85a6558) at
src/service.c:8143
#5 __connman_service_connect (service=service@entry=0xb85a6558,
reason=reason@entry=CONNMAN_SERVICE_CONNECT_REASON_USER) at
src/service.c:8203
#6 0xb6edc148 in connect_service (conn=<optimized out>, msg=0xb85d3b80,
user_data=0xb85a6558) at src/service.c:5570
#7 0xb6f1653e in process_message
(connection=connection@entry=0xb859b600,
message=message@entry=0xb85d3b80,
iface_user_data=iface_user_data@entry=0xb85a6558, method=<optimized
out>, method=<optimized out>) at gdbus/object.c:259
#8 0xb6f167be in generic_message (connection=0xb859b600,
message=0xb85d3b80, user_data=<optimized out>) at gdbus/object.c:1071
#9 0xb6d126b0 in ?? () from /lib/libdbus-1.so.3
#10 0xb6d014a8 in dbus_connection_dispatch () from /lib/libdbus-1.so.3
#11 0xb6f144f2 in message_dispatch (data=0xb859b600) at
gdbus/mainloop.c:76
#12 0xb6d898e8 in g_main_dispatch (context=0xb8599808) at gmain.c:3234
#13 g_main_context_dispatch (context=context@entry=0xb8599808) at
gmain.c:3887
#14 0xb6d89c78 in g_main_context_iterate (context=0xb8599808,
block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at
gmain.c:3960
#15 0xb6d89fd8 in g_main_loop_run (loop=0xb85999a8) at gmain.c:4156
#16 0xb6e9f352 in main (argc=<optimized out>, argv=<optimized out>) at
src/main.c:851
Change-Id: I9ed4c69d31389bd7aa0c8ab250d92c45cdab7507
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Mayank Haarit [Fri, 20 Apr 2018 15:27:32 +0000 (20:57 +0530)]
Add BSSID , signal strength and frequency list of the APs
This patch sends the list of BSSID, signal strength and
frequency of an APs having same SSID and Security type.
Change-Id: I368d37de310687ca173418dfad91fae7082b2357
Signed-off-by: Mayank Haarit <mayank.h@samsung.com>
Mayank Haarit [Wed, 18 Apr 2018 14:29:49 +0000 (19:59 +0530)]
Added logic to get country code of APs
It also includes parsing country code from IEs received from the supplicant
Change-Id: Iea5f8b2ea7cc8fefe07591cc4d636d27b015d427
Signed-off-by: Mayank Haarit <mayank.h@samsung.com>
taesub kim [Mon, 16 Apr 2018 08:06:44 +0000 (08:06 +0000)]
Merge "Add SSID and Frequency mixed scan." into tizen
Niraj Kumar Goit [Thu, 5 Apr 2018 06:27:15 +0000 (11:57 +0530)]
Add SSID and Frequency mixed scan.
Change-Id: I6ca91a5f073c11712a936844589aa72c27c0145e
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
taesub kim [Tue, 10 Apr 2018 02:39:51 +0000 (02:39 +0000)]
Merge "Added dbus/cynara policy" into tizen
hyunuktak [Tue, 3 Apr 2018 04:36:36 +0000 (13:36 +0900)]
Fixed a coverity for resource leak
Change-Id: I990f3c1d314580546c4dfa4716d1a2e535bcd491
Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
taesub kim [Mon, 2 Apr 2018 08:36:12 +0000 (17:36 +0900)]
Added dbus/cynara policy
Change-Id: I82192eb00243dd45e64e37e806d7c7e90fa3fac2
Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
hyunuktak [Fri, 23 Mar 2018 01:27:16 +0000 (10:27 +0900)]
Fix a coverity for logically dead code
Change-Id: I649ed8bbf277611324934db7895d7a8c0cb25ec8
Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
Niraj Kumar Goit [Thu, 15 Feb 2018 11:19:26 +0000 (16:49 +0530)]
[connman]Added support of EAP-FAST,EAP-PWD and EAP-AKA'.
Change-Id: Ibb75ff2c2e54c8d3d53f3b184502647918bf7e24
igned-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Jaehyun Kim [Tue, 20 Feb 2018 06:37:40 +0000 (15:37 +0900)]
Added new dbus method to support bssid based connection
Change-Id: I95d2a56c1d26db06cbdb5c85dc0e2b33b3c10da3
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
taesub kim [Tue, 23 Jan 2018 08:06:16 +0000 (08:06 +0000)]
Merge "Fixed uninitialized scalar variable" into tizen
hyunuktak [Tue, 23 Jan 2018 07:08:42 +0000 (16:08 +0900)]
Fixed uninitialized scalar variable
Change-Id: Ia285faae7af652612fadbe95f0863bc315d429a6
Niraj Kumar Goit [Thu, 4 Jan 2018 09:18:49 +0000 (14:48 +0530)]
Modified logic to process each VSIE of all vendors.
Modified logic to process each VSIE of all vendors instead of
only samsung vendor(OUI: 001632). Received VSIE will be appended
in the list and shared with application.
Change-Id: Ifbb0159f40a8949a6f117416e5d436d5c2299b49
Jaehyun Kim [Fri, 12 Jan 2018 09:38:45 +0000 (18:38 +0900)]
Handles the passphrase decryption failure case
Change-Id: I8511bbc2b025f296770420dc9c8e7b85aa2be60d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Seonah Moon [Tue, 23 Jan 2018 05:50:50 +0000 (14:50 +0900)]
Updated connman to version 1.35
Change-Id: I13526fbf80296a79be15548fc226a308941ac9ec
Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
taesub kim [Mon, 22 Jan 2018 05:52:51 +0000 (05:52 +0000)]
Merge "Modified logic to process each VSIE of all vendors." into tizen
Jaehyun Kim [Fri, 12 Jan 2018 09:38:45 +0000 (18:38 +0900)]
Handles the passphrase decryption failure case
Change-Id: Id8a29b6156449bf3dd23f79a7224ab39e9599b82
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Seonah Moon [Mon, 8 Jan 2018 04:42:54 +0000 (13:42 +0900)]
Imported Upstream version 1.35
Change-Id: I174854914d9fd06a813270b57d1f7bc2bac63c6a
Signed-off-by: Seonah Moon <seonah1.moon@samsung.com>
Niraj Kumar Goit [Thu, 4 Jan 2018 09:18:49 +0000 (14:48 +0530)]
Modified logic to process each VSIE of all vendors.
Modified logic to process each VSIE of all vendors instead of
only samsung vendor(OUI: 001632). Received VSIE will be appended
in the list and shared with application.
Change-Id: I11fee186c04677fdcd7746fcef7fd1dee4a0b02e
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
taesub kim [Wed, 3 Jan 2018 07:50:24 +0000 (16:50 +0900)]
Add new rpm with disalbled-ethernet
Change-Id: Ib5b1b2a166d26180f75793f03d8770ef37cc1329
Jaehyun Kim [Thu, 28 Dec 2017 11:02:31 +0000 (20:02 +0900)]
Make WiFi passphrase enc/dec routine async to prevent mutual synchronous call to net-config
Change-Id: Ic7795b430e92b7ee81d4c65b39ef1aa914fccc1a
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Saurav Babu [Wed, 27 Dec 2017 10:43:05 +0000 (16:13 +0530)]
connman: Get HS20 property of service correctly
Change-Id: I21d3a4ba5632d5a00a3254137b12dfdbd1dbe3dc
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>