injun.yang [Tue, 3 Jul 2018 09:36:58 +0000 (18:36 +0900)]
Fix : Multiple advertising feature was not working
[Problem] Multiple advertising feature was not working
[Cause & Measure] Advertising slot was not initialized because BT
chipset supported slot count is over the defined maximum. Platform can
support the large number of slots if BT chipset can. So we don't need
to define maximum value of slots. This patch removes the maximum value
of slots.
[Checking Method] Turn on Bluetooth and check advertising slot's
initialization.
Change-Id: Ic0a3293b4f4e7f7b048b61074fb95b9898efba7e
injun.yang [Tue, 3 Jul 2018 09:35:38 +0000 (18:35 +0900)]
Fix the crash
- le_adv_slot is accessed in __bt_hold_current_advertising_timeout_cb()
after it's freed.
Change-Id: Id9c394e07f33c8df09b6a8c0f07f0e0afe4b9294
Signed-off-by: injun.yang <injun.yang@samsung.com>
injun.yang [Tue, 3 Jul 2018 09:32:46 +0000 (18:32 +0900)]
Fix the memory leak
Change-Id: I59acfc652c1bcf742e919c456fcee15ac34e25d6
Signed-off-by: injun.yang <injun.yang@samsung.com>
injun.yang [Tue, 3 Jul 2018 05:55:06 +0000 (14:55 +0900)]
Code optimize
Change-Id: Id79d33f51003da6786e7bbd18b581836b7e75719
Signed-off-by: injun.yang <injun.yang@samsung.com>
injun.yang [Fri, 29 Jun 2018 04:40:49 +0000 (13:40 +0900)]
Change the name of dbus property of EIR manufacturer data
Same property for adv is introduced in upstream
Change-Id: Ib65befe8105d88ca0bdd788ce904e3bfa592e3e2
Signed-off-by: injun.yang <injun.yang@samsung.com>
Deokhyun Kim [Thu, 28 Jun 2018 07:33:35 +0000 (16:33 +0900)]
Improve inefficient logic converting UUID to string
Change-Id: Id0ab908edd526cd4c9af977612ab159f24c02ff2
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Amit Purwar [Tue, 26 Jun 2018 07:05:28 +0000 (12:35 +0530)]
Handled multiple gatt char with same uuid in a service
Change-Id: Ib0eeeea41a002d5eccde82e75e09f9e1fc75b069
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
Amit Purwar [Thu, 21 Jun 2018 10:39:48 +0000 (16:09 +0530)]
Fixed gatt characteristic property
This change fix the issue that Gatt characteristic property
was not sent when descriptor is not present.
Change-Id: I8dc6ec159ed049a3d550c2b8660506c5193a2a0c
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
Amit Purwar [Tue, 19 Jun 2018 10:23:42 +0000 (15:53 +0530)]
Fixed zero length data of descriptor read
Change-Id: If1fe3d0ed882ae9ab9dc1b9d808f5f45c17d4fc1
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
Deokhyun Kim [Mon, 18 Jun 2018 10:25:51 +0000 (19:25 +0900)]
Set owner & group of auto-pair-blacklist as 'network_fw'
- fopen(auto-pair-blacklist,w) fails
Change-Id: Ib8d2a21a30fd2e6aecf52202ae41cf5fedf777a5
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Atul Rai [Mon, 18 Jun 2018 10:17:20 +0000 (15:47 +0530)]
Remove handling for device found event in obex
This patch handles following:
1/ Removes handling of device found event from obex
2/ Removes unused code from obex event receiver
3/ Fixes Memory leak and GLib issues ipsp event reciever
Change-Id: I23cf6b3f89c81d23b6c6d8b747b86cb816fd547b
Signed-off-by: Atul Rai <a.rai@samsung.com>
Atul Rai [Mon, 18 Jun 2018 10:16:24 +0000 (15:46 +0530)]
[HAL]Add NULL check before calling g_variant_unref
Change-Id: I6830b7c305ec696e8cbd3aed95a5e9db77a72e5a
Signed-off-by: Atul Rai <a.rai@samsung.com>
Atul Rai [Mon, 18 Jun 2018 10:15:07 +0000 (15:45 +0530)]
Fix build warnings in bluetooth-frwk
Change-Id: I17a391471d2ea4a83bbad3053da836582e926cc9
Signed-off-by: Atul Rai <a.rai@samsung.com>
Amit Purwar [Mon, 18 Jun 2018 07:10:35 +0000 (12:40 +0530)]
Fixed gatt char read value when length of value is zero
Change-Id: I5515f6a02c728b9e1eeff038654d067dc01b3773
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
Wootak Jung [Mon, 18 Jun 2018 01:18:43 +0000 (10:18 +0900)]
Add bt-driver-insmod.service trigger logic
Change-Id: I50c045b7116cea43bdff0fc9fb5c211ed7d3a04e
Amit Purwar [Tue, 12 Jun 2018 11:56:50 +0000 (17:26 +0530)]
Implemented enable and disable Gatt watch notification
Implemented enable and disable the watch notification on
gatt characteristic
Change-Id: I192746b8a6ec2d8012f8590dd0b9be45334f9c8e
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
injun.yang [Mon, 11 Jun 2018 10:41:06 +0000 (19:41 +0900)]
Fix: glib error
Change-Id: I7e664429d6508f105ef5041af63f97cc2a6d1615
Atul Rai [Fri, 8 Jun 2018 09:09:17 +0000 (14:39 +0530)]
Fix invalid UTF-8 charactor error in AVRCP track info
Change-Id: I26c27ec1e7febb31569109ec4ada31b8f75fdfca
Signed-off-by: Atul Rai <a.rai@samsung.com>
DoHyun Pyun [Thu, 7 Jun 2018 02:39:01 +0000 (11:39 +0900)]
Revert "Enable adapter and discoverable mode if headless device"
This reverts commit
79849f72fef6a026ff89e2f201b3be27ce3f9dbe.
Change-Id: I27ce383da9f034900a419d8ef12dfc56b04a5c11
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
injun.yang [Mon, 4 Jun 2018 01:16:56 +0000 (10:16 +0900)]
Allow dbus mothod call for system_fw group
Change-Id: I7e47dc64730b41a12ef341f0904d9717a20a4418
Amit Purwar [Fri, 1 Jun 2018 09:41:16 +0000 (15:11 +0530)]
Set the write request type for gatt characteristic
Change-Id: Ie75eaeecb7aa784be8e01d6a5112ba52b173d2cb
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
Wootak Jung [Thu, 31 May 2018 07:00:52 +0000 (16:00 +0900)]
Enable adapter and discoverable mode if headless device
Change-Id: I9c32f299367d787355d36ecabbbb96c17c43221a
injun.yang [Tue, 29 May 2018 08:08:53 +0000 (17:08 +0900)]
Enhance debug message
Change-Id: I053db03105b03f4e0416e8a052dd742ba930a157
DoHyun Pyun [Mon, 28 May 2018 05:09:12 +0000 (05:09 +0000)]
Merge "Modify the dbus policy for agent1" into tizen
DoHyun Pyun [Wed, 23 May 2018 04:50:11 +0000 (13:50 +0900)]
Modify the dbus policy for agent1
Change-Id: I1dc605be738a3c354288850a9f87c7492581125a
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Mon, 28 May 2018 04:35:54 +0000 (13:35 +0900)]
Use the file activation to run bt-stack-down.sh script
Change-Id: Ie3708161a4f275f7888991fed57e7b4314923abc
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Mon, 28 May 2018 03:25:50 +0000 (12:25 +0900)]
Use the multi-user target group for the common profile
Change-Id: Idf1f10fa526bb689c8a9ac56cf57b04e5768c73e
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Mon, 28 May 2018 03:25:40 +0000 (12:25 +0900)]
Remove the file activation logic to insmod the artik530
Change-Id: I267a427ce88d93576a78f2f0144080bc16ec2207
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Fri, 25 May 2018 06:56:41 +0000 (15:56 +0900)]
Disable auto enable logic by bt-core
Change-Id: Ia2ca1578bd189b8590ac6c17958810f927c8d00b
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Wootak Jung [Thu, 24 May 2018 04:45:09 +0000 (13:45 +0900)]
Fix prevent issue
Change-Id: I7a2f9f1bf6b19a70e40cbf80d624d55d7eab77e5
Wootak Jung [Thu, 24 May 2018 03:38:12 +0000 (12:38 +0900)]
Fix prevent issues
Change-Id: Iadec24b45ee77613553e75ef89103dd135046362
DoHyun Pyun [Thu, 24 May 2018 00:04:37 +0000 (09:04 +0900)]
Remove unused mashal codes
Change-Id: If6f1199ea369bfcd6f715eb0fb21831bd3a98ff5
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Wed, 23 May 2018 12:05:17 +0000 (21:05 +0900)]
Set the smack label as '_' of the library
Change-Id: If19a9a1607739fe78a8d9f33a368d0ed84a4b39c
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Wed, 23 May 2018 12:04:33 +0000 (21:04 +0900)]
Fix the write request functionality from GATT client
Change-Id: I8c18e0de026ed5bde935fd8978f22daec771cc28
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Amit Purwar [Thu, 17 May 2018 14:13:41 +0000 (19:43 +0530)]
gatt client adaptation feature changes on HAL
Change-Id: Idef21c381035f119072575ff28ebd4b07c37c780
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
Amit Purwar [Thu, 17 May 2018 14:17:51 +0000 (19:47 +0530)]
gatt client adaptation feature changes bt-api bt-service OAL
Change-Id: If19155c4dc6aaa6367094a02a346d949d29be183
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
Wootak Jung [Mon, 21 May 2018 01:23:06 +0000 (10:23 +0900)]
Fix wrong expression in dbus policy
Change-Id: Ibc5d72822c721a0ffe4536e3eb8624ccaa9d60d9
DoHyun Pyun [Thu, 17 May 2018 07:34:15 +0000 (16:34 +0900)]
Allow the dbus method call for bluetooth.admin privilege app
BT system popup will call dbus method directly to confirm the pairing.
So we should allow the method from app user if it has the privilege
Change-Id: I0cafcebad827cb5fd516ed4a1e5b2d5015281d65
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Wed, 16 May 2018 09:13:37 +0000 (18:13 +0900)]
Fix TCT fail issue on ARTIK530
ARTIK530's BT kernel is not ported yet. Because of this,
LE scan operation is not working physically. This patchset
is for the exception case.
Change-Id: I03b6e2a312d4b493c2bd2d00f957df9324941286
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Wed, 16 May 2018 06:40:31 +0000 (15:40 +0900)]
Adjust the timing to load BT driver
Change-Id: Ieba46283aec98db78f35e8f2dc39c0b2ee66a380
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Thu, 10 May 2018 00:50:29 +0000 (09:50 +0900)]
Add the allow and deny own dbus policy
Change-Id: Ib5af0b85404d031b087d97e4353e881868343e38
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Wootak Jung [Thu, 10 May 2018 00:31:02 +0000 (09:31 +0900)]
Add bt-driver-insmod.service trigger logic
Change-Id: I0e4b4b994d7a0c74440d495c70d7f96ee914bb68
Wootak Jung [Tue, 8 May 2018 04:32:32 +0000 (13:32 +0900)]
Fix privilege violation
Need default deny policy for internal interface
Change-Id: If7ecc83424efb736f6d30a0ac43a0a510bf51437
DoHyun Pyun [Thu, 3 May 2018 06:50:51 +0000 (15:50 +0900)]
Modify the dbus policy for user session
Change-Id: I26e95019d71e78f70e7cccd3f57d92d26f487438
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Hyuk Lee [Thu, 26 Apr 2018 01:18:34 +0000 (10:18 +0900)]
Fix the svace issue
Change-Id: I196e12ddc9ad87007464221d21b7888b69e41180
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
Wootak Jung [Fri, 20 Apr 2018 01:16:23 +0000 (10:16 +0900)]
Add disconnect logic when dpm policy is updated
Change-Id: I9aaaf07e823c7a123478e7221fabe27be61797d5
Hyuk Lee [Fri, 20 Apr 2018 05:05:48 +0000 (14:05 +0900)]
Fix the crash issue in OAL event loop
Change-Id: Id955d5e63429139ba2c7a869347956311c27b3d1
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
Wootak Jung [Wed, 18 Apr 2018 09:03:50 +0000 (18:03 +0900)]
Fix bt_core dbus policy issue
Change-Id: I34c3863ecba512615267ed46a07135429b21ed67
Pyun DoHyun [Wed, 18 Apr 2018 06:16:45 +0000 (06:16 +0000)]
Merge "Add default deny policy in conf files" into tizen
Wootak Jung [Tue, 17 Apr 2018 06:57:35 +0000 (15:57 +0900)]
Add default deny policy in conf files
Remove at_console policy
Change-Id: I31a6089386e9bf9d095fa9390215a746aac4e263
DoHyun Pyun [Wed, 18 Apr 2018 02:28:55 +0000 (11:28 +0900)]
Remove the package dependency for pkgmgr and dbus-glib-1
Change-Id: I3b2e8a621594cae48db31bfcd69074dc02463646
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Pyun DoHyun [Wed, 18 Apr 2018 00:38:39 +0000 (00:38 +0000)]
Merge "Add the AVRCP delay changed callback" into tizen
Wootak Jung [Tue, 17 Apr 2018 05:06:46 +0000 (14:06 +0900)]
Fix privilege check logic
BT_CHECK_PRIVILEGE is required in 1st param to check privilege
Change-Id: Iff6760952080e8a05479169ca13b6ed2f6acab8d
Hyuk Lee [Wed, 11 Apr 2018 08:28:16 +0000 (17:28 +0900)]
Add the rfkill udev rule file
Change-Id: I8e7af48093446359d684eb1743f140688abfd8b2
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
Pyun DoHyun [Mon, 9 Apr 2018 05:21:06 +0000 (05:21 +0000)]
Merge "Add the media transport interface to adaptation code" into tizen
Hyuk Lee [Wed, 28 Mar 2018 05:56:49 +0000 (14:56 +0900)]
Add the media transport interface to adaptation code
Change-Id: I6cfd4c4b10a87894b4326c331f32a845a239a845
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
Wootak Jung [Mon, 9 Apr 2018 01:09:10 +0000 (10:09 +0900)]
Remove unnecessary dpm policy check logic
dpm policy was already done during rfcomm connection.
no need to check dpm policy in socket writing
Change-Id: I5412d2b4c273a0627911cf52beeb0ded44587a87
Hyuk Lee [Tue, 3 Apr 2018 02:22:51 +0000 (11:22 +0900)]
Add the AVRCP delay changed callback
Change-Id: Ieaf16bba7a03aeb8c8984f1a5fab8cada3b9a5eb
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
Pyun DoHyun [Thu, 22 Mar 2018 23:49:12 +0000 (23:49 +0000)]
Merge "Svace fix: WGID-319844 'characteristic.handle' doubble free" into tizen
Pyun DoHyun [Thu, 22 Mar 2018 23:48:59 +0000 (23:48 +0000)]
Merge "Svace fix WGID:324430 :statement in the source code might be unreachable during program execution" into tizen
Anupam Roy [Thu, 22 Mar 2018 07:01:02 +0000 (12:31 +0530)]
SVACE : WGID 324403
Change-Id: I38c66e9e23546005c7ff42f73b51f3a588232cdb
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
Abhishek Chandra [Thu, 22 Mar 2018 06:35:27 +0000 (12:05 +0530)]
[Bluetooth-frwk] SVACE issue fixed for WGID:324402
Change-Id: Ib5aab65c6ae272f03da5d66ebdc5f1ca89c6e02f
Signed-off-by: Abhishek Chandra <abhishek.ch@samsung.com>
Avichal Agarwal [Thu, 22 Mar 2018 06:27:49 +0000 (11:57 +0530)]
Svace fix: WGID-319844 'characteristic.handle' doubble free
Change-Id: I50c493329672477239fc029ce68c1c8ef7271477
Avichal Agarwal [Thu, 22 Mar 2018 06:25:18 +0000 (11:55 +0530)]
Svace fix WGID:324430 :statement in the source code might be unreachable
during program execution
Change-Id: Ic75be3839330c649e47fcd17ab16f468be68cc07
Amit Purwar [Wed, 21 Mar 2018 07:31:13 +0000 (13:01 +0530)]
svace fixes done
Change-Id: I2acea06b83ab5ebb9c3dbd200108f3704520d2c9
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
Wootak Jung [Mon, 19 Mar 2018 05:14:53 +0000 (14:14 +0900)]
Initialize VCONFKEY_BT_DEVICE to NONE when bt is enabled/disabled
Change-Id: I44692c267963ddf68e5549d842f6b823eb9bccf6
Wootak Jung [Wed, 14 Mar 2018 00:48:43 +0000 (09:48 +0900)]
Fix NULL dereference issue
Change-Id: I2c2ec27c180425cbe7727bf85813dd6f3af73092
Hyuk Lee [Mon, 12 Mar 2018 10:42:43 +0000 (19:42 +0900)]
Add the rfkill control to bluetooth stack up
Change-Id: I1c1ef5f085517b363e7f67fc6a42c48094699407
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
Hyuk Lee [Wed, 21 Feb 2018 00:20:48 +0000 (09:20 +0900)]
Add the service file for bt-core
Change-Id: I8d7af5e04ad558579a6b434bf7c8d68fccda584f
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
Hyuk Lee [Mon, 12 Feb 2018 01:16:00 +0000 (10:16 +0900)]
Modify the bt-core's UID/GID to network_fw
Change-Id: I1bff9d8ebff0c3479c4c113ccdfe1ae29fba991d
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
Abhishek Chandra [Wed, 7 Feb 2018 09:02:55 +0000 (14:32 +0530)]
[Bluetooth-OAL] Jira issue : TFIVE-26
LIB path not defined for 64bit architecture .
Added changes in the spec file and
defined path for lib64 .
Change-Id: I42f4f5721b0b6a66aa061742b2ed8a1540c98181
Signed-off-by: Abhishek Chandra <abhishek.ch@samsung.com>
Abhishek Chandra [Tue, 30 Jan 2018 10:39:37 +0000 (16:09 +0530)]
[Bluetooth-Frwk] CSharp TCT Fixes over Latest Tizen branch
Change-Id: I6a25081323c1293a7f4373ad419e2053ac38817d
Signed-off-by: Abhishek Chandra <abhishek.ch@samsung.com>
Abhishek Chandra [Thu, 25 Jan 2018 05:47:04 +0000 (11:17 +0530)]
[Bluetooth-Frwk] TCT Fixes over Latest Tizen branch
Fixed issues in the TCT failures on Tizen branch
Fixed SVACE warnings and errors
Change-Id: Iab509cabfe0472954119a31bb0bfc88a8e8a1395
Signed-off-by: Abhishek Chandra <abhishek.ch@samsung.com>
DoHyun Pyun [Thu, 11 Jan 2018 05:06:58 +0000 (14:06 +0900)]
Fix the build error in x86_64
Change-Id: Ia732f932ed1c0d4c6e595b1cc80eeea1b8487806
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Amit Purwar [Wed, 3 Jan 2018 10:59:53 +0000 (16:29 +0530)]
resolved the code rule warnings
Change-Id: I14806911d8adbf1b5fadb98bb89c6b2f6d955514
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Atul Rai [Thu, 28 Dec 2017 09:42:07 +0000 (15:12 +0530)]
Fix SVACE issues in Tizen New BT Architecture
Change-Id: I93a762e037e6c4a5b814c8d064cd586259ccc44a
Signed-off-by: Atul Rai <a.rai@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Wed, 6 Dec 2017 04:15:44 +0000 (13:15 +0900)]
Merge tizen_next codes into tizen branch
---------------------------------------------------
commit
bdd924ebbd4727e0a02323d00e3f53e714dd3b46
Author: DoHyun Pyun <dh79.pyun@samsung.com>
Date: Mon Dec 4 16:03:43 2017 +0900
Apply latest changes in tizen branch
---------------------------------------------------
Change-Id: I8dc8758f06c4c7690afe6beba54adb3baf729890
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Seungyoun Ju [Wed, 29 Nov 2017 09:02:07 +0000 (18:02 +0900)]
Fix : Visibility timer is not cancelled when PSCAN off
[Problem] Visibility timer is not stopped when connectable mode is
turned off.
[Cause & Measure] There is no logic to cancel timer. So this patch adds
the cancel logic.
[Checking Method] Turn on limited discoverable mode -> Turn off
connectable mode -> Check discoverable timeout event
Change-Id: Icc800e9704f8c9cdb09338f2d1e5504d5c60f64d
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Seungyoun Ju [Wed, 29 Nov 2017 09:00:10 +0000 (18:00 +0900)]
Add the interface to start / stop visibility timer
[Problem] Visibility timer is not stopped when connectable mode is
turned off.
[Cause & Measure] This patch adds the interface to control visibility
timer in event handler module.
[Checking Method] Turn on limited discoverable mode -> Turn off
connectable mode -> Check discoverable timeout event
Change-Id: I528b4093427bbda9e9fac4e4ce1b72b1ffb41873
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Seungyoun Ju [Wed, 29 Nov 2017 08:47:15 +0000 (17:47 +0900)]
Fix : logic error in MDM visibility policy
[Problem] There are some logic error regarding Discoverable property
changed event.
1. When limited discoverable mode is not allowed and general
discoverable is set, general discoverable is requested again.
2. When limited discoverable mode and discoverable mode are both not
allowed, it tries to set general discoverable mode.
3. DiscoverableTimeout property is not updated.
[Cause & Measure] 1. Check current discoverable mode and only if it is
in limited discoverable mode and limited discoverable mode is not
allowed, set to general discoverable mode.
2. After handling discoverable mode policy, don't check limited
discoverable mode policy.
3. Use proper type to set DiscoverableTimeout property.
[Checking Method] Code review
Change-Id: I8e3d9a6a56769c21faa2ef1361623ff0cfd22a8b
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Deokhyun Kim [Tue, 7 Nov 2017 09:52:16 +0000 (18:52 +0900)]
Fix mem leak.
Change-Id: Iaa6f68f1e773ea543d45d9b3695e569552e0399a
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Deokhyun Kim [Tue, 7 Nov 2017 09:49:21 +0000 (18:49 +0900)]
Proceed HID connection procedure when it's already connected.
- Application can use fd of HID channel even though it's already connected.
Change-Id: I15421dfd0378735cd15d7dae66a24d064341f3bc
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Deokhyun Kim [Wed, 25 Oct 2017 01:38:27 +0000 (10:38 +0900)]
Cleanup HID device codes.
Change-Id: I699a10bf46bbc8a4af43f1fb587c0771c26a0261
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Sangki Park [Wed, 18 Oct 2017 10:46:22 +0000 (19:46 +0900)]
Fix memory leak
[Problem] Fix memory leak
[Checking Method] Turn BT on -> off
Change-Id: I0fae995235f649d66e73cd248559999de9232ebf
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Seungyoun Ju [Fri, 20 Oct 2017 11:49:36 +0000 (20:49 +0900)]
Revert "Use FindDevice to get device object path" partially
This partially reverts commit
30314c18fea269785f2c25d6f7dcd765008ad7a7
[Problem] Application couldn't make BREDR connection when remote device
supports BREDR and LE both.
[Cause & Measure] Wrong device object path is used for BREDR connection.
When a remote device supports BREDR/LE, bluez has two
device object which has same bdaddr but different bdaddr_type. In this
case, FindDevice call returns the first searched device's object path.
To solve this issue, instead of FindDevice call,
object path should be constructed from address.
Change-Id: If5fb0041906ec7564cc30d88be16479c3078c85e
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Atul Rai [Thu, 26 Oct 2017 11:12:33 +0000 (16:42 +0530)]
Fix memory leak in __bt_get_device_info_in_message
Change-Id: I6a356c490510cb3ec4a8c541aed2cacb121a7a61
Signed-off-by: Atul Rai <a.rai@samsung.com>
DoHyun Pyun [Mon, 23 Oct 2017 08:35:13 +0000 (17:35 +0900)]
Fix TBT socket client fail issue
Adjust the location to free the variable. We should free the value
after using it.
Change-Id: I7a7ccfb79023dbff16734b1098dbe478df8e6090
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Deokhyun Kim [Thu, 19 Oct 2017 08:25:18 +0000 (17:25 +0900)]
Fix bt-service crash issue.
- le_adv_slot is accessed in __bt_hold_current_advertising_timeout_cb()
after it's freed.
Change-Id: I105617fcd42d65e5de80400564e20e7859f82d12
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
injun.yang [Tue, 17 Oct 2017 06:34:36 +0000 (15:34 +0900)]
Enhance debug message
When service added from remote device,
get uuid information and display it
Change-Id: I659fe1df18c36c1a15cbd25650b26fcb7c42706f
Signed-off-by: injun.yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Biman Paul [Wed, 11 Oct 2017 09:12:13 +0000 (18:12 +0900)]
fix unable to pair with headset having pin '1234'
[Problem] unable to pair with headset having pin '1234'
[Cause & Measure] For headset, usually default pin is
'0000' and request is Pairing pin is send as '0000'. But
when pin is not '0000' first attempt fails and remote
device BD address is blacklisted(saved in a file) and for
all future requests blacklisted devices are checked and
pin popup is shown.
But here bt-service is unable to write to blacklist file.
Measure:
1. Allow write mode for blacklist file.
2. Give appropriate smack label.
[Checking Method] Use Mecapp:
1. Set COD such as Mecapp is recognised as Headset.
2. Initiate a pairing request to Mecapp.
3. Give pin 1234 or anything other than '0000' in mecapp.
Change-Id: I1aa0e66625601965c889005fbe23813f3ed2903b
Signed-off-by: injun.yang<injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
injun.yang [Wed, 11 Oct 2017 06:15:47 +0000 (15:15 +0900)]
Add uuid information
Change-Id: I12ec33b7284f5c5a5a337ac1981f38e354fc0f64
Signed-off-by: injun.yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Seungyoun Ju [Fri, 22 Sep 2017 02:07:31 +0000 (11:07 +0900)]
Fix memory leak
[Problem] There are some memory leak in code
[Cause & Measure] Fix memory leak
324 bytes in 18 blocks are definitely lost in loss record 1,471 of 1,512
at 0x48458E8: malloc (vg_replace_malloc.c:299)
by 0x4B9E271: g_variant_get (gvariant.c:5368)
by 0x12DAC5: _bt_get_remote_device_info_by_object_path (bt-service-device.c:516)
by 0x11A295: __bt_device_property_changed_event (bt-service-event-receiver.c:1076)
by 0x11A295: _bt_handle_property_changed_event (bt-service-event-receiver.c:1403)
by 0x11D235: __bt_manager_event_filter (bt-service-event-receiver.c:2885)
504 bytes in 72 blocks are definitely lost in loss record 1,479 of 1,512
at 0x48458E8: malloc (vg_replace_malloc.c:299)
by 0x4B9E271: g_variant_get (gvariant.c:5368)
by 0x12579D: __bt_get_bonded_device_info (bt-service-adapter.c:374)
by 0x12579D: _bt_get_bonded_device_info (bt-service-adapter.c:3153)
by 0x143815: __bt_bluez_request (bt-request-handler.c:880)
by 0x147439: __bt_service_method (bt-request-handler.c:275)
648 bytes in 36 blocks are definitely lost in loss record 1,486 of 1,512
at 0x48458E8: malloc (vg_replace_malloc.c:299)
by 0x4B9E271: g_variant_get (gvariant.c:5368)
by 0x13402F: _bt_get_device_ida (bt-service-device.c:3563)
by 0x1449ED: __bt_bluez_request (bt-request-handler.c:1792)
by 0x147439: __bt_service_method (bt-request-handler.c:275)
1,008 bytes in 36 blocks are definitely lost in loss record 1,490 of 1,512
at 0x48458E8: malloc (vg_replace_malloc.c:299)
by 0x4B79E89: g_malloc (gmem.c:97)
by 0x4B89755: g_slice_alloc (gslice.c:1007)
by 0x4B5664B: g_array_sized_new (garray.c:193)
by 0x147191: __bt_service_method (bt-request-handler.c:220)
21,852 bytes in 1,214 blocks are definitely lost in loss record 1,509 of 1,512
at 0x48458E8: malloc (vg_replace_malloc.c:299)
by 0x4B9E271: g_variant_get (gvariant.c:5368)
by 0x11B96D: _bt_handle_device_event (bt-service-event-receiver.c:2200)
by 0x11D8B1: __bt_manager_event_filter (bt-service-event-receiver.c:2897)
22,662 (432 direct, 22,230 indirect) bytes in 18 blocks are definitely lost in loss record 1,511 of 1,512
at 0x48458E8: malloc (vg_replace_malloc.c:299)
by 0x4B9E271: g_variant_get (gvariant.c:5368)
by 0x11D17D: __bt_manager_event_filter (bt-service-event-receiver.c:2679)
Change-Id: Ib00c46ac04eff5d62b94bbf31876bd06dac6aa2a
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Seungyoun Ju [Wed, 20 Sep 2017 05:01:52 +0000 (14:01 +0900)]
Fix : Some properties of adapter couldn't be handled
[Problem] Some property changed events for adapter object couldn't be handled
[Cause & Measure] It returns in the iterate loop
Change-Id: I17395d7cea094cac324fec110add10ae8c13cc8b
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Seungyoun Ju [Wed, 20 Sep 2017 03:58:03 +0000 (12:58 +0900)]
Fix : Multiple advertising feature was not working
[Problem] Multiple advertising feature was not working
[Cause & Measure] Advertising slot was not initialized because BT
chipset supported slot count is over the defined maximum. Platform can
support the large number of slots if BT chipset can. So we don't need
to define maximum value of slots. This patch removes the maximum value
of slots.
[Checking Method] Turn on Bluetooth and check advertising slot's
initialization.
bt-service-event-receiver.c: __bt_adapter_property_changed_event(847) > name = adv_inst_max
bt-service-event-receiver.c: __bt_adapter_property_changed_event(849) > Value = 17
bt-service-adapter-le.c: _bt_update_le_feature_support(134) > (slot_num > BT_ADV_MULTI_MAX) return
bt-service-event-receiver.c: __bt_adapter_property_changed_event(851) > Fail to update LE feature info
Change-Id: I93e020908636627c9cf0b6ac1377e71126717dd0
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Abhishek Chandra [Wed, 20 Sep 2017 12:29:23 +0000 (17:59 +0530)]
Added NULL pointer guard check before
g_ascii_strcasecmp.
Change-Id: Iec3f82a5b6d9dec394b4cdcfd34e09693efec36e
Signed-off-by: Abhishek Chandra <abhishek.ch@samsung.com>
DoHyun Pyun [Wed, 20 Sep 2017 07:32:27 +0000 (16:32 +0900)]
Fix the svace issue - memory leak
Change-Id: Ia9c24145cf0cedd82622e6eeab599ec46c5ecb37
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Biman Paul [Thu, 7 Sep 2017 11:18:39 +0000 (16:48 +0530)]
Use FindDevice to get device object path
[Problem] Reduce dbus overhead to get device object path.
[Cause & Measure] GetManagedObjects returns exhaustive
list of iterfaces and their properties recursively which
is redundant.
Measure: Use FindDevice method to get device object path.
[Checking Method] NA
Change-Id: I394bc2fc7ef003d837c34d9953d783f412cd1b8b
Signed-off-by: injun.yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Anupam Roy [Tue, 12 Sep 2017 11:22:02 +0000 (16:52 +0530)]
SVACE Fixes
ID's: 228340, 252922, 252923
252928, 258235, 258245
260752, 271421, 271423
Change-Id: Iccfe27233877e14d04beea2c24cfe07786fb74b8
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
Deokhyun Kim [Tue, 12 Sep 2017 06:53:46 +0000 (15:53 +0900)]
Fix SVace issue.
Change-Id: I7e7db0bf260d0ebc2f0139eb35c34734603a7ab8
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Tue, 12 Sep 2017 05:48:25 +0000 (14:48 +0900)]
Fix tizen coding style errors and warnings
Change-Id: I686a9b692ae77ff858be3d6237eb0f0fd5a6aadf
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
projects / platform / core / connectivity / bluetooth-frwk.git / log