Jeonghyun Yun [Fri, 11 Aug 2017 04:48:06 +0000 (13:48 +0900)]
elm_scroller: focus_direction should not be called when scroller focusable and no focusable child
Summary:
when scroller can have focus and scroller's child can't have focus,
there is a problem that scroller is always selected to next focus object.
In this case, it should not enter into _elm_scroller_elm_widget_focus_direction()
Reviewers: woohyun
Reviewed By: woohyun
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5085
Change-Id: I235dbd87e28118295ef4150817deddec50c84fbe
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
Wonki Kim [Fri, 11 Aug 2017 05:16:48 +0000 (14:16 +0900)]
Revert "interface_scrollable: Fix not hold the flag on mouse down"
This reverts commit
012537f1e5cb2355940c7cf15c75027e3fbc6c2c.
Change-Id: I86e61f88c2cea008383ecb6fcd395c11a52c6b62
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Jaeun Choi [Tue, 8 Aug 2017 07:48:58 +0000 (16:48 +0900)]
test_gesture_layer3: fix typo
this typo was detected by SVACE
Change-Id: I3e32a058a0ddf7f4f22bac1106dc05698ff185a6
origin: upstream (
52368bf463c2b5ea7b69e15a7e34b1ea13258ca1)
Jaeun Choi [Tue, 8 Aug 2017 06:43:15 +0000 (15:43 +0900)]
test_gesture_layer: fix typo
this typo was detected by SVACE
Change-Id: I6b005aede302598dfe1f4af7fb38199dc4371b12
origin: upstream (
a9fdcc4cc2f5567fbc05ae418c4e3a4d13286f45)
Jaeun Choi [Wed, 9 Aug 2017 07:16:35 +0000 (16:16 +0900)]
elm_color_class: add null checking after memory allocation
origin: upstream (
15bbf4712ee1e9356fa975de6f2861bc5ce3076a)
Change-Id: Id9b82282635f8b722f6d282f3d0e84ee98aafdb0
Jaeun Choi [Wed, 9 Aug 2017 07:21:03 +0000 (16:21 +0900)]
elm_dbus_menu: add null checking after memory allocation
Change-Id: I43d0a47eb8d382007b6a9ed1d877415ad37ed52d
origin: upstream (
0927221c1a0e26b7fe006eb3110ca2bffd671b89)
Jaeun Choi [Wed, 9 Aug 2017 07:28:42 +0000 (16:28 +0900)]
elm_gesture_layer: add null checking after memory allocation
Change-Id: Ib504732e21203c414bb1e58936788e84da23cba9
origin: upstream (
41ea255002d93d285da331e2452488c8f6088f1f)
Jaeun Choi [Wed, 9 Aug 2017 07:32:36 +0000 (16:32 +0900)]
elm_gesture_layer_extra_gestures: add null checking after memory allocation
Change-Id: Ifc32e16b0489685d154b35c2d3f7a4cd71409e14
origin: upstream (
db33efb79238f5843251795ff193773bd36c83b1)
Jaeun Choi [Wed, 9 Aug 2017 07:36:13 +0000 (16:36 +0900)]
elm_prefs_data: add null checking after memory allocation
Change-Id: Ia14b6585a030fe598a9e09dc16ddc27dd1d789df
origin: upstream (
38abae53c0a5aca320984475c82fc6f6f5ae048b)
Jaeun Choi [Wed, 9 Aug 2017 07:39:54 +0000 (16:39 +0900)]
test_gesture_layer: add null checking after memory allocation
Change-Id: Id45ecd0d3ebc4d49cab51f36f319feb813d2d828
origin: upstream (
6641c07262085faf062679a21659ff7b45b05a67)
Jaeun Choi [Wed, 9 Aug 2017 07:43:27 +0000 (16:43 +0900)]
test_gesture_layer2: add null checking after memory allocation
Change-Id: Ic733f8e173d1a0ca4c90479961b05fb27f8b3b4b
origin: upstream (
530455fcee4767ce17ba56200b13dc688b64857a)
Jaeun Choi [Wed, 9 Aug 2017 07:49:15 +0000 (16:49 +0900)]
test_gesture_layer3: add null checking after memory allocation
Change-Id: I0d189511e9c65496d23a7799631f37513f16c690
origin: upstream (
c311dc638b8358f27664fba3985d9212748cf92a)
smohanty [Fri, 11 Aug 2017 00:14:08 +0000 (09:14 +0900)]
tizen_vector: Fixed the integer division issue.
Change-Id: Ib17b7a440cdc5807059774ddd0031e17b42be400
Jaehyun Cho [Wed, 9 Aug 2017 13:37:26 +0000 (22:37 +0900)]
elc_naviframe: Use tizen_effect_cancel from naviframe_effect module
Use tizen_effect_cancel API from naviframe_effect module to cancel push
effect when a newly pushed item is deleted before the push effect is
started.
Change-Id: Ia3d89bda1b4f128a80c1cf78e3ac33e34c564dc2
SangHyeon Jade Lee [Thu, 10 Aug 2017 07:37:04 +0000 (16:37 +0900)]
genlist : fix re-calculate on language changed
Change-Id: I3a599c45228e652624d38fa8f73db45de084c35e
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
Jaehyun Cho [Wed, 9 Aug 2017 14:32:35 +0000 (23:32 +0900)]
elc_naviframe: Fix to handle item deletion right after item push
If an item is deleted right after the item is newly pushed, the push
transition should not happen for both the new item and the current item.
Change-Id: Iba5b9547aae8b3916e76d9e7af3e9250229c563b
Jeonghyun Yun [Thu, 10 Aug 2017 05:22:48 +0000 (14:22 +0900)]
elm_ctxpopup: Implemented elm_widget_item_del_pre for elm_ctxpopup_item
ctxpopup item have elm_list item internally.
But when elm_ctxpopup item was deleted, elm_list item was not deleted.
elm_list item in elm_ctxpopup item should be deleted in del_pre
when elm_ctxpopup item is deleted by elm_wdg_item_del()
Test Plan:
1. launch elementary_test - ctxpopup
2. click Ctxpopup with label only
3. "Never Show" item should not shown in ctxpopup
Reviewers: jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5044
Change-Id: I2264a3efbb3050017b89cbbd087042d35eb8830d
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
SangHyeon Jade Lee [Mon, 7 Aug 2017 07:36:47 +0000 (16:36 +0900)]
elm_object_item: update pre_notify_del document
Change-Id: Ie9a2e6e20fa60449b934c870b98e55aa82d2df5c
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
SangHyeon Jade Lee [Wed, 2 Aug 2017 10:50:20 +0000 (19:50 +0900)]
gengrid: fix integer division type casting warning
Change-Id: I1c7db5310a4edb16f4fda13e2ce19c71e8389741
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
SangHyeon Jade Lee [Wed, 2 Aug 2017 10:31:10 +0000 (19:31 +0900)]
gengrid: fix wrong access info returns in access info set
Change-Id: I66478fee1468c1f57cddbf7ba9fd8c98344de161
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
JunsuChoi [Tue, 8 Aug 2017 01:17:39 +0000 (10:17 +0900)]
Add null check for svace issues
Add null check because alloc function could return null
Change-Id: Ife8a3cc2cf48ba176e7e94c50c7d78bb2329fc6b
JinYong Park [Mon, 7 Aug 2017 11:51:40 +0000 (20:51 +0900)]
layout: fix "elm,state,text,hidden" signal never be emitted
In _elm_layout_text_set function, text_signal_emit is called.
But in that case, check text whether it is null or not null before call signal_emit.
So "text" is not null always, and text_signal_emit's parameter "visible" is also always EINA_TRUE.
opensource link : https://phab.enlightenment.org/D5049
Change-Id: I0decfc0144c7e13e4706ca90aa38824921ee4673
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
woochan lee [Mon, 7 Aug 2017 11:29:07 +0000 (11:29 +0000)]
Revert "Fix Svace issuese."
This reverts commit
7b2fe927cbf3bd4a50d9da61de48e437d81ee383.
Change-Id: I7fcfe87b8d0c8a340704f8eb67969df4cfbda3d1
woochan lee [Mon, 7 Aug 2017 11:28:56 +0000 (11:28 +0000)]
Revert "Fix Svace issue."
This reverts commit
3798e5047e98c27c62b483d3059ec2b23f8221ab.
Change-Id: I74e6d1970415337af0e73d3bbe0a5b66b5d1b92d
Woochan Lee [Mon, 7 Aug 2017 08:31:04 +0000 (17:31 +0900)]
Fix Svace issue.
Change-Id: I5559eabddbb9bb3034ba9eea8fec1aadb2f6d3d8
Woochan Lee [Mon, 7 Aug 2017 08:07:00 +0000 (17:07 +0900)]
Fix Svace issuese.
Change-Id: I9a2f66edbe51908735315fbf859dc1a0d7641252
Woochan Lee [Mon, 7 Aug 2017 07:42:35 +0000 (16:42 +0900)]
Datetime: Apply UI Mirroring for Tizen 4.0
The datetime is not including UI Mirroring feature.
Change-Id: Iacdf0bf589e328a7ef3902555e92d11f505492ff
Myoungwoon Roy, Kim [Fri, 4 Aug 2017 05:20:03 +0000 (14:20 +0900)]
Fix accessbility mode doxygen warning
Summary:
Fix 4.0 API Reference Doxygen warnings.
Change-Id: I3f38685943efeb790422338de2c1f77311b686a0
Shinwoo Kim [Thu, 3 Aug 2017 06:46:25 +0000 (15:46 +0900)]
atspi: do not accept invisible object
Issue:
If an object is child of scrollable parent, then the object is accepted even
though the object is invisible.
Solution:
Do not accept invisible object.
Change-Id: I0492eb9f5f265211521f066acd6f56d9c24356c0
Shinwoo Kim [Thu, 3 Aug 2017 06:23:13 +0000 (15:23 +0900)]
atspi: enhance elm_atspi_gesture_cb_set document
Change-Id: Ib6ff7016389bf9b6252c517c2565839e5f5943d1
Shinwoo Kim [Wed, 2 Aug 2017 12:15:56 +0000 (21:15 +0900)]
atspi: handle "gesture_required" attribute
The elementary sends the "detail2" information highlight based on the attribute
"gesture_required" when an object grabs.
If an object has attribute key "gesture_required", and "scroll" for its value,
then the "detail2" is 1. Otherwise, the "detail2" is 0.
The screen-reader AT client calls "ObjectNeedsScrollGesture" method of
e-mod-tizen-screen-reader window manager module with object geometry value,
if the "detail2" is 1. Otherwise, the object geometry value is not used.
The e-mod-tizen-screen-reader window manager module will send mouse event
based on the object geometry.
Application side could use this feature setting attribute as below:
- elm_atspi_accessible_attribute_append(btn, "gesture_required", "scroll");
This patch set depends on:
https://review.tizen.org/gerrit/#/c/142108/ (screen-reader)
https://review.tizen.org/gerrit/#/c/142107/ (e-mod-tizen-screen-reader)
Change-Id: I0b731ce947be569b2d782fdc21f18c79ffebf70e
Youngbok Shin [Fri, 4 Aug 2017 02:59:29 +0000 (11:59 +0900)]
label: set duration/speed for text marquee using internal functions
@tizen_feature
Change-Id: I3746364acd1818a9f0766ce18e029c8a3f70dc0d
Youngbok Shin [Fri, 4 Aug 2017 02:45:14 +0000 (11:45 +0900)]
cursor: remove a warning message from a unused static variable
@tizen_fix
Change-Id: Icfcaf6e0c92aa259afae816313eb29550456d9f8
Wonki Kim [Thu, 3 Aug 2017 03:15:20 +0000 (12:15 +0900)]
elm_win: Match return type of function
this commit fix the svace warning
Change-Id: I9f3b00c35190808d1a2f641ed360bdb0d85f6dfe
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Youngbok Shin [Thu, 3 Aug 2017 07:39:18 +0000 (16:39 +0900)]
entry: remove a warning message caused by unused parameter for cbhm
@tizen_fix
Change-Id: Ib1f61049b4c7fc075ac9764642eca0a9e7cb358e
Shinwoo Kim [Wed, 2 Aug 2017 06:51:25 +0000 (15:51 +0900)]
atspi: suppress warning message
The following is warning message.
In function '_elm_genlist_elm_widget_screen_reader':
warning: declaration of 'l' shadows a previous local [-Wshadow]
Eina_List *l;
^
note: shadowed declaration is here
Eina_List *l;
Change-Id: I8af5c5e4a49219bebccd2a51ddc0ddfc853f447f
Youngbok Shin [Wed, 2 Aug 2017 10:57:05 +0000 (19:57 +0900)]
entry: remove unused label for goto
@tizen_fix
Change-Id: I7ea5763432b9118eb7e33f20419be2e25ccf7a9f
Shinwoo Kim [Tue, 1 Aug 2017 10:22:03 +0000 (19:22 +0900)]
atspi: access overrides Accessible.state_set.get
The elm_access a widget makes primitive object accessible. If a primitive
object is not visible, then the elm_access should NOT have state VISIBLE, and
SHOWING. From now the elm_access is checking visibility of primitive object.
Change-Id: I27c2f29d3346e03329784872281e4734ec753160
Jiyoun Park [Wed, 2 Aug 2017 08:04:06 +0000 (17:04 +0900)]
elm_win: add ELM_WIN_SOCKET_IMAGE type check
elm_win_socket_listen api only work for ELM_WIN_SOCKET_IMAGE type window.
So it is better to add type check code.
Change-Id: Id8b27ac5a7f78b7ac4bf97cf7b7fdd6a7a0b6ac0
Wonki Kim [Wed, 2 Aug 2017 07:23:02 +0000 (16:23 +0900)]
elm_win: Fix build warning
fix build warning on elm_win
Change-Id: I548a9d5bdfac569f3d97c07b48337ebb394aa9dc
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Wonki Kim [Wed, 2 Aug 2017 07:22:30 +0000 (16:22 +0900)]
conform: Fix build warning
fix build warning on elm_conform
Change-Id: I61efd9675246a353e0f6fcdc35b8557455b77f74
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Wonki Kim [Wed, 2 Aug 2017 07:06:29 +0000 (16:06 +0900)]
inteface_scrollable: fix build warning
fix build warning on interface_scrollable.c
Change-Id: I9f0d190b91bdda35a34b1d5bb9a8ec228ae6eae7
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Bowon Ryu [Wed, 2 Aug 2017 06:30:54 +0000 (15:30 +0900)]
toolbar: fix unused parameters.
Change-Id: Iff64a42eb14f5ec25c773daebdeb09a809e4af12
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
SangHyeon Jade Lee [Wed, 2 Aug 2017 05:45:19 +0000 (14:45 +0900)]
genlist : fix unused values and parameters
Change-Id: Ic8bb3e04c275032afdfc26fefdae68df1f4a03aa
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
SangHyeon Jade Lee [Wed, 2 Aug 2017 04:46:00 +0000 (13:46 +0900)]
genlist :fix wrong item paramenter pass on focus_set
Change-Id: Ibe4e0e0709020e4d16788094854cb2ccdb187167
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
Wonki Kim [Thu, 8 Jun 2017 04:40:23 +0000 (13:40 +0900)]
scroller: Initialize member variables which are used for unstable situation
This commit inits member vars to set proper position
when scroller initialy comes out.
Change-Id: I3b5490cbcc38fe77e549d152a7e4c666b6c4a518
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Woochan Lee [Thu, 27 Jul 2017 13:08:22 +0000 (22:08 +0900)]
multibuttonentry: Fix item resource clean up logic.
Summary:
There are four cases where items are deleted.
1. Select item and push back button.
2. Delete "X" part of item.
3. Calling elm_object_item_del().
4. MBE deleted.
Previous logic is can't support for all cases.
below problems were there.
eina_list_remove() called twice.
list data free twice.
@fix
Test Plan: elementary_test -> multibuttonentry test.
Reviewers: jpeg, cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5030
Change-Id: I523afadb2c767b42ecc253f6b691e4de512c1199
Shinwoo Kim [Mon, 24 Jul 2017 10:11:48 +0000 (19:11 +0900)]
atspi: grab highlight using unrealized item
The looping naviation could make the first(or last) item grab highlight.
But the _elm_widget_item_elm_interface_atspi_component_highlight_grab returns
without setting highlight if sd->view is NULL that means the item is NOT
realized in case of genlist.
So the _elm_genlist_item_elm_interface_atspi_component_highlight_grab BRINGs
the first(or last) item IN first before grabbing highlight.
Change-Id: Id36716d1e2d6249532d67dede9357e152b3d3107
Shinwoo Kim [Thu, 20 Jul 2017 23:46:34 +0000 (08:46 +0900)]
atspi: genlist - remove unnecessary lines
Looping navigation could make first object grab highlight.
If the first object is unrealized genlist item, the genlist item will be
realized. While the first genlist item is realized, genlist calculation logic
makes the first genlist item unhighligted, and gives highlight to next proper
genlist item based on geometry value. See the following backtrace.
※ Backtrace
0 elm_interface_atspi_component_highlight_grab
1 in _item_position
2 in _item_all_position
3 in _item_block_realize
4 in _elm_genlist_pan_evas_object_smart_calculate
5 in evas_obj_smart_calculate
6 in ?? () from target:/lib/libevas.so.1
7 in ?? () from target:/lib/libevas.so.1
8 in ?? () from target:/lib/libevas.so.1
9 in evas_canvas_render_async
10 in evas_render_async
11 in ?? () from target:/lib/ecore_evas/engines/wayland/v-1.16/module.so
12 in ?? () from target:/lib/libecore_evas.so.1
13 in ?? () from target:/lib/libecore.so.1
14 in ?? () from target:/lib/libecore.so.1
15 in ecore_main_loop_begin () from target:/lib/libecore.so.1
16 in elm_run () at elm_main.c:1128
17 in ?? () from target:/usr/lib/libappcore-efl.so.1
18 in appcore_base_init () from target:/lib/libappcore-common.so.1
19 in appcore_ui_base_init () from target:/lib/libappcore-ui.so.1
20 in appcore_efl_base_init () from target:/usr/lib/libappcore-efl.so.1
21 in ?? () from target:/usr/lib/libcapi-appfw-application.so.0
22 in ui_app_main () from target:/usr/lib/libcapi-appfw-application.so.0
23 in main () from target:/usr/apps/org.tizen.watch-setting/bin/watch-setting
24 in _start ()
It seems that this is a mistake of commit migration from Tizen 3.0
to Tizen 4.0. So the lines should be removed.
※ migration commit:
d8bdb91a65cb678258ac3704d11610520aa8948d
Change-Id: Ib5a58b8959828ad47867298338a40c76b4417bf7
SangHyeon Jade Lee [Mon, 24 Jul 2017 11:30:42 +0000 (20:30 +0900)]
genlist : fix build warnings
Change-Id: I342307152e8eb94517a1d37b5d5ddc8625992262
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
Thiep Ha [Mon, 24 Jul 2017 22:35:49 +0000 (07:35 +0900)]
elm_plug: remove unused variable
Change-Id: Ifeabbe326dfdd82d1c3a3a12a945666a8e525c07
Minchul Lee [Mon, 24 Jul 2017 11:02:22 +0000 (20:02 +0900)]
copypaste: remove build warning
Change-Id: I596f1080cd93d16d9154dcfe5649db9525eb9177
Signed-off-by: Minchul Lee <slotus.lee@samsung.com>
Youngbok Shin [Wed, 19 Jul 2017 10:54:28 +0000 (19:54 +0900)]
label: fix elm_label_style_user_push to work without default format
@tizen_fix
Change-Id: Ie786c075714cbaa26bbf55d669fbd291a8fda960
JinYong Park [Mon, 24 Jul 2017 07:20:55 +0000 (16:20 +0900)]
popup: fix build warning
This warning is not occur in upstream
Change-Id: Iccf8be67a6ae736789352861a5139583f2f062a0
Signed-off-by: JInyong Park <j4939.park@samsung.com>
JunsuChoi [Mon, 24 Jul 2017 06:52:05 +0000 (15:52 +0900)]
atspi: Remove build warning
Remove null initialization becuase of
variable ss(Elm_Atspi_State_Set) is not pointer
Change-Id: Ic9024047f7946c587fc42c0773bfde3f9710c1ce
Hosang Kim [Mon, 24 Jul 2017 05:35:13 +0000 (14:35 +0900)]
slider: changed negative zero to zero
When slider value is between 0.0 and -0.5, -0 is printed.
Change-Id: I7381dabc0749555b77be53e67c74e646c17840c1
JinYong Park [Thu, 20 Jul 2017 11:02:51 +0000 (20:02 +0900)]
mobile_lib/ctxpopup: fix float calculate problem
Change-Id: I37874f6bbc84db5dac172e44bef9f9b5a233ce7a
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
SangHyeon Lee [Tue, 18 Jul 2017 07:30:26 +0000 (16:30 +0900)]
genlist : fix wrong item referencing in pos adjust
Change-Id: Ie055661c4f20308511f7c39c92e2dee36bbcdb15
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
JEONGHYUN YUN [Thu, 20 Jul 2017 08:17:06 +0000 (17:17 +0900)]
elm_colorselector : set selected status directly in selected_set function
Change-Id: Ibaaf0035f90c5b3b766f2dbc4746bd12fc46661c
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
Shinwoo Kim [Wed, 19 Jul 2017 07:38:42 +0000 (16:38 +0900)]
atspi: Expose API
The following API is exposed on the Mobile profile.
- elm_object_part_access_register
- elm_object_part_access_object_get
- elm_access_object_register
- elm_access_object_unregister
- elm_access_object_get
- elm_atspi_bridge_utils_say
- elm_atspi_accessible_name_cb_set
- elm_atspi_accessible_description_cb_set
- elm_atspi_accessible_attribute_append
- elm_atspi_accessible_reading_info_type_set
- elm_atspi_accessible_reading_info_type_get
- elm_atspi_accessible_gesture_cb_set
- elm_atspi_accessible_can_highlight_set
- elm_atspi_accessible_can_highlight_get
- elm_atspi_component_highlight_grab
- elm_atspi_component_highlight_clear
Change-Id: I4fbcf06f384bc79581285d8747f409f65bdb7554
JEONGHYUN YUN [Wed, 19 Jul 2017 11:25:43 +0000 (20:25 +0900)]
elm_colorselector : support marking change when color set on ELM_COLORSELECTOR_PALETTE mode only
@tizen_fix
Change-Id: Ibde5ec8668f6dc960035a5deba5ad7d4765daad1
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
JEONGHYUN YUN [Mon, 17 Jul 2017 07:57:32 +0000 (16:57 +0900)]
mobile_lib/ctxpopup : enable elm_ctxpopup_item_content_unset
Change-Id: Id61addf2b57db6f3b2f4e2cf921c76b1f35092de
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
JEONGHYUN YUN [Wed, 19 Jul 2017 07:42:51 +0000 (16:42 +0900)]
elm_colorselector: changed item selection procedure to handle by _on_color_selected()
Deleted duplicate item selection procedure code
in _elm_color_item_selected_set() and _item_action_activate()
@tizen_fix
Change-Id: I607658ec651f393ca3658c2746c11ecc7a841d41
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
JEONGHYUN YUN [Mon, 17 Jul 2017 07:55:15 +0000 (16:55 +0900)]
elm_ctxpopup: Implemented elm_widget_item_part_content_unset for elm_ctxpopup_item
Summary:
ctxpopup item have elm_list item internally.
item_part_content_unset need to pass on content part to elm_list item.
Test Plan:
1. launch elementary_test - ctxpopup
2. click Ctxpopup with part text & content function
3. press "Icon Set" and press "Icon Unset"
Reviewers: jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5018
Change-Id: I5e9bcb853a040d11e7cac4017a417e2fd7260a79
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
Wonki Kim [Wed, 19 Jul 2017 06:13:28 +0000 (15:13 +0900)]
interface_scrollable: fix build fail on interface_scrollable
typo error
Change-Id: I4d9e786a71ff7bc765ff08e1c5266fb6801455b0
Wonki Kim [Tue, 18 Jul 2017 11:15:21 +0000 (20:15 +0900)]
interface_scrollable: Add "content,resize" callback to keep backward compat
There was a "content,resize" callback before tizen 3.0.
Even if it was a tizen only code block, there could be a backward compat issue
without the callback.
This commit emits the callback after whole procedure for content resizing.finished.
@tizen_feature
Change-Id: I0eccf8ebc8c704e1403056c0078bd6625d612265
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
SangHyeon Lee [Wed, 5 Jul 2017 10:55:38 +0000 (19:55 +0900)]
genlist: add select_on_focus_disable condition in left/right key actions
Change-Id: I85f35bd97ec7f8307e0774d5c06f068efa88c1cb
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
Myoungwoon Roy, Kim [Mon, 17 Jul 2017 04:17:54 +0000 (13:17 +0900)]
Fix a wrong group info.
Summary:
Fix a wrong group info. and some wrong expressions.
Change-Id: I5eb6da156e388a7ab496c53a566591ddc729528d
Myoungwoon Roy, Kim [Fri, 14 Jul 2017 01:01:24 +0000 (10:01 +0900)]
Make elm_win_window_id_get public
Summary:
This API is opened to support quickpanel window features.
Change-Id: I6c01e89421efb85f76d18c16621c53a9770a3afc
Shinwoo Kim [Tue, 11 Jul 2017 11:30:16 +0000 (20:30 +0900)]
atspi: use last appended relation information
So far, the screen reader has used the first relation information.
So application should remove appended relation information, before appending
relation information newly. This is hard to use in some point of view.
The application used *append API as *set API.
So using last appended relation information makes more sense.
Change-Id: Id7c3e7dc02acc0a883eb7e55b3892461aee259a3
JEONGHYUN YUN [Wed, 12 Jul 2017 11:38:25 +0000 (20:38 +0900)]
mobile_lib/ctxpopup : fix item part text and icon set logic
when icon or text is null, theme will be changed if it needs
Change-Id: I58c0377e0149bdbcd256c55eaf9e7904cf08f186
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
JunsuChoi [Tue, 4 Jul 2017 01:36:39 +0000 (10:36 +0900)]
change markup text to utf8 when called accessible_name_get function
Change-Id: I3a13146ed11287c35d007bfb0d5f712ff40a7fb3
JEONGHYUN YUN [Wed, 12 Jul 2017 06:38:44 +0000 (15:38 +0900)]
elm_ctxpopup: enable ctxpopup item insert before/after for mobile_lib
Change-Id: I4f96499e0636e1784b634116e7915df8e33e2a45
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
JEONGHYUN YUN [Wed, 12 Jul 2017 06:04:18 +0000 (15:04 +0900)]
elm_ctxpopup: Add APIs to insert before/after item to a ctxpopup object.
Summary:
There were only 2 APIs (item_append, item_prepend) for ctxpopup item add.
Added more item add APIs (item_insert_before and item_insert_after) for convenience.
Test Plan:
1. launch elementary_test - ctxpopup
2. click Ctxpopup with callback function sample
3. check whether there are 3 items on ctxpopup
Reviewers: jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5004
Change-Id: Iaee2310ff78dd727e7edfd420d14913fec02b4cd
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
JinYong Park [Tue, 11 Jul 2017 07:50:55 +0000 (16:50 +0900)]
mobile_lib/ctxpopup: fix item theme set logic
icon_style must be set when icon and label is null
Change-Id: Ibe352ef81ff80614ab0357d6f37a9c14ec8ccba6
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
Shinwoo Kim [Tue, 11 Jul 2017 10:39:50 +0000 (19:39 +0900)]
atspi: enhance finding the first,last obj
There are two kind of first(or last) object.
(1) The first object in viewport of its scrollable parent.
(2) The first object in accessibilty tree regardless of scrollable parent.
Looping navigation should use the first object of type (2)
Other cases should use the first object of type (1)
If view is changed, then there is no highlight. In this case the first object
of type (1) should be used. For example, if view is changed to 1 depth from
2 depth, then the highlight should use the first object of type (1).
If the following is 1 depth view after 2 depth view disapears, then there is
not currently highlighted object. In this case the item 4 should grab highlight
for next object, and the item 6 should grab highlight for the previous object.
+--------+
| item 4 |
|--------|
| item 5 |
|--------|
| item 6 |
+--------+
Change-Id: Ie9e2d2c754d991e5dfb2fd32fca6954282b99061
Shinwoo Kim [Fri, 7 Jul 2017 02:44:14 +0000 (11:44 +0900)]
atspi: consider scrollable parent for "GetNeighbor"
To determine the next object,
find top scrollable parent of next object excluding scrollable parents of start
object, and check if the next object exists inside of the top scrollable parent
viewport.
If there is not top scrollable parent, then use the next object.
(layout)
|
|----------|----------|
| | |
(btn1) (scroller) (btn3)
|
|
|----------|----------|
| | |
(btn2) (genlist) (toolbar)
[case: top scrollable parent is scroller]
If current highlighted(start) object is btn1, and the 10th genlist item shows
just under the btn1 (i.e. btn2, and 1st ~ 9th items are scrolled out),
then the next object should be the 10th item.
[case: top scrollable parent is NULL]
After the 10th genlist item grabs highlight, the previous object should be the
9th genlist item, not the btn1. In this case scrollable paretns of start object
are scroller, and genlist. the next object has same scrollable parents. So the
top scrollable parent is NULL.
If the 10th genlist item is the next object of btn1, then the btn1 object could
be the previous object of 10th genlist. But this patch set make the 9th genlist
item previous. This behavior is quite dependent on UX definition.
Change-Id: I8ded2d533f0b77202be25713eafca652e1886bcb
Youngbok Shin [Tue, 11 Jul 2017 07:28:11 +0000 (16:28 +0900)]
entry: pop freezed scroll by longpress_cb from mouse up event before checking type of event
@tizen_fix
Change-Id: I4a6235f565aead6f25b088de2317aa57755e675c
JinYong Park [Tue, 28 Mar 2017 08:34:23 +0000 (17:34 +0900)]
ctxpopup: fix item style set logic
label_style_item is wrong style
and comparing order change to same with other comparing logic
Change-Id: Ief9616bd437130f228317ccd93e21d6548057592
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
JinYong Park [Tue, 11 Jul 2017 06:46:27 +0000 (15:46 +0900)]
popup: fix sizing eval logic when scrollable set TRUE
When scrollable set TRUE,
scroller must be calculated its size except using item.
If content is removed, scroller doesn't calculate its size, so it has previous size.
So there is a empty space in this case.
@fix
https://phab.enlightenment.org/D5010
Change-Id: Ib930461dc8f6f31a7c08a247d0fc120913ea2fd4
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
JEONGHYUN YUN [Tue, 11 Jul 2017 04:39:42 +0000 (13:39 +0900)]
ctxpopup: enable ctxpopup item prepend for mobile_lib
Change-Id: I476ec842631e8e7d34073f97ec18e1b780f1b2ee
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
JinYong Park [Fri, 7 Jul 2017 05:11:26 +0000 (14:11 +0900)]
popup: fix wrong signal emit when remove all button
In visuals_set function,
check action_area is NULL, and signal emit action_area,visible/hidden
So, before call visuals_set, action_area should be deleted.
https://phab.enlightenment.org/D5007
@fix
Change-Id: I7180a759a2ab0db85fc1e55b8280b8b39f4d371a
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
SangHyeon Lee [Wed, 5 Jul 2017 10:59:57 +0000 (19:59 +0900)]
genlist: fix dangling item pointer accessing in filter queue idle enterer
Change-Id: Iceaf891673f98a9b51088eb7694bd8a1956db1d7
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
Shinwoo Kim [Wed, 5 Jul 2017 08:10:47 +0000 (17:10 +0900)]
atspi: fix integer underflow issue
Change-Id: I99a498b901c0980d62e5c8abaf42687fb54ac335
Youngbok Shin [Wed, 5 Jul 2017 03:55:17 +0000 (12:55 +0900)]
toolbar: fix build failure caused by recent changes on Edje
edje_obj_message_signal_process() changed to recieve a parameter.
@tizen_fix
Change-Id: I336e7d746b866ae081ce25ca6a7de2082ed2a040
Shinwoo Kim [Fri, 30 Jun 2017 09:15:29 +0000 (18:15 +0900)]
atspi: fix bug of finding the last object
The last object can be found only if all_children_visited is false.
The start is same with root, when looking for the last object.
The first object can be found already, even though the start is same with root.
Because the forwarding navigation can visit its children.
Change-Id: I763994505d5b2b21ee8aa459b39c08512a34a279
Shinwoo Kim [Fri, 30 Jun 2017 02:35:51 +0000 (11:35 +0900)]
atspi: suppress runtime error, build warning
[runtime error]
(1) elm_atspi_bridge.c:2787 _bridge_path_from_object() safety check failed: eo == NULL
(2) elm_atspi_bridge.c:6184 _bridge_object_register() Unable to register class w/o Elm_Interface_Atspi_Accessible!
(3) lib/eo/eo.c:697 _eo_call_resolve() in elm_widget.eo.c:169: func 'elm_obj_widget_access_highlight_in_theme_get' (288) could not be resolved for class 'Edje_Object'
- Note: The access_highlight_in_theme (3) should handle non Elm_LAYOUT_CLASS.
Or the access_highlight_in_theme should be removed. If the screen-reader
shows highlight, then the access_highlight_in_theme doesn't make sense.
[build warning]
(1) warning: passing argument 2 of '_object_get_bus_name_and_path' discards 'const' qualifier from pointer target type
(2) warning: passing argument 3 of '_object_get_bus_name_and_path' from incompatible pointer type
Change-Id: I4a690afdbf90f2bf72b497d0c3916c7fc83ddb74
Shinwoo Kim [Thu, 29 Jun 2017 07:31:44 +0000 (16:31 +0900)]
atspi: check accessible parent for can_highlight
If an object is Elm_Widget and accessible child of Elm_Widget_Item, then
can_child of this object does not check value of the Elm_Widget_Item.
Because the _elm_widget_item_highlightable has used elm_widget_parent_get.
It doesn't return Elm_Widget_Item. It returns parent object of Elm_Widget_Item.
So _elm_widget_item_highlightable should have to use accessible parent.
Change-Id: Iecbc162fc676efeb6e3162418ac3eb34b761195d
Woochan Lee [Mon, 3 Jul 2017 04:46:23 +0000 (13:46 +0900)]
elm_spinner: Entry hide when inc/dec button pressed.
The entry cursor does not disappear when the user pressed(long press value change case) inc/dec button.
Change-Id: I750dd17aa951b956d46923847c34823a45201153
Jihoon Kim [Fri, 30 Jun 2017 06:24:38 +0000 (15:24 +0900)]
entry: Fix build error due to since_tizen tag
Change-Id: I5c6d38888f06ffd35b042e2d3a4e64d86638b398
Shinwoo Kim [Tue, 16 May 2017 08:15:55 +0000 (17:15 +0900)]
Resize highlight rectangle if target object is clipped
Change-Id: I352b123d49626d4254236d7b3ab656b657024927
Jihoon Kim [Mon, 26 Jun 2017 10:59:11 +0000 (19:59 +0900)]
entry: Add prediction hint API
prediction hint can be used to provide an intelligent reply suggestion.
@feature
Change-Id: I9d5f482acd8104d2cadf3b00aa3eb573e2daa49f
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jaehyun Cho [Thu, 29 Jun 2017 07:12:37 +0000 (16:12 +0900)]
els_tooltip: Remove infinite job calls
Summary:
When tooltip or content size is 0, tooltip reconfigure job is called infinitely.
This patch removes the infinite job calls.
Test Plan:
See following patch, test case "Tooltip" -> "Tooltip with no min size"
Reviewers: zmike
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4982
Change-Id: I730017aa2b417f96302d81ba7c2eb43ffb4a63f4
JunsuChoi [Wed, 14 Jun 2017 06:07:34 +0000 (15:07 +0900)]
atspi: moved highlight when object is out of screen
when highlighted object is out of screen or scroll view
, elementary send 'object:move-outed' signal to screen-reader
need this commit:
screen-reader - https://review.tizen.org/gerrit/#/c/135993/
at-spi2-core - https://review.tizen.org/gerrit/#/c/135994/
Change-Id: Id8f6d55569f5213a3bdbf37c836ef0f38090d21a
jiin.moon [Wed, 31 May 2017 10:01:03 +0000 (19:01 +0900)]
elm_image: Fix previous image visible issue
Summary: Previous image still visible when elm_image_file_set has wrong file path.
Test Plan: self
Reviewers: jpeg, jypark, singh.amitesh
Reviewed By: singh.amitesh
Subscribers: singh.amitesh, minkyu, cedric
Differential Revision: https://phab.enlightenment.org/D4888
Change-Id: If8393e3851ea7cec1673540d7798eba1850cc75d
Jean-Philippe Andre [Thu, 20 Apr 2017 09:29:26 +0000 (18:29 +0900)]
elm_image: Fix file_set when preload is disabled
If we disable preload, then the second file set on an elm_image
object would not trigger a deletion of the first image. As a
consequence, both images would be visible... really bad if there's
alpha or different dimensions!
Thanks Anand Kumar for the report!
@fix
Change-Id: If708c2d6bbc432585ba4493d6068467ab1a6086b
Daniel Zaoui [Mon, 21 Nov 2016 09:52:27 +0000 (11:52 +0200)]
efl_ui_image: fix removal of the internal evas image
During the replacement of the image with the new preloaded one,
the previous image is deleted but not removed from the list of
children of the icon (efl_ui_image), leading to Eo errors when
walking over the icon children.
@fix
Change-Id: Ic5e606bf2b485051e419b1ea0ba263cd5c7808f9
Myoungwoon Roy, Kim [Thu, 29 Jun 2017 00:46:15 +0000 (09:46 +0900)]
Fix typo and some wrong expressions
Fix typo and some wrong expressions in doc, box, gesture, index, map, and toolbar API reference doxygen.
Change-Id: I5d8bc5d6adc4af08fc62c85a11392c3b257114b6
Shinwoo Kim [Mon, 26 Jun 2017 06:25:06 +0000 (15:25 +0900)]
atspi: find the first, last obj using "GetNeighbor"
The reducing IPC task overlooked functionality to get the first, last object.
This commit is related to the following commit.
[screen-reader]
commit
72e3396fac3a377f49422af454875a0e4c9a58bc
Add loop navigation feature.
Screen reader gives FOCUS_CHAIN_END_NOTIFICATION_EVENT notification if there is
no more object in its direction. If user gives next(or prev) gesture in same
direction one more time, then the first(or last) object will grab highlight.
Change-Id: I0e68c84a595396cbf7d0d2ae4d93fca4c425f0ea
Shinwoo Kim [Wed, 21 Jun 2017 02:39:18 +0000 (11:39 +0900)]
atspi: handle atspi proxy connection at runtime
The following cases make atspi proxy work incorrectly.
[case 1]
1. screen reader on, then a11y order would be
A1(embedding, deputy) - B1(embedded) - B2(embedded) - A2(embedding)
2. make A2 grab highlight
3. go previous, then A1 grabs highlight.
but expected result is that the B2 grabs highlight
[case 2]
1. screen reader on, then a11y order would be
A1(embedding, deputy) - B1(embedded) - B2(embedded) - A2(embedding)
2. make A1 grab highlight
3. go next, then B1 grabs highlight.
This means that the proxy connection is made properly.
4. screen reader off
5. screen reader on, then a11y order is
A1(embedding, deputy) - A2(embedding)
but the following is expected result as step 1
A1(embedding, deputy) - B1(embedded) - B2(embedded) - A2(embedding)
So far the pory connects if elm_interface_atspi_children_get is called.
So there is no chance to make connection for the [case 1].
When atspi is disabled, then all atspi related interface is closed.
But the proxy related resources are not removed.
If atspi is enabled again, then newly created interface is used on new BUS.
And the proxy related resources are reused.
So the [case 2] happens.
This patch set depends on screen-connector to use "widget,create" signal to
connect proxy on elementary side. This should be removed, and we have to
provide proper API to be used on screen-connector side to connect proxy.
Change-Id: I86f610504848db816e6db355316f8da06db513df