Aditya Mandaleeka [Tue, 28 Jun 2016 22:25:11 +0000 (15:25 -0700)]
Fix platform logic in symbol stripping code.
Aditya Mandaleeka [Tue, 21 Jun 2016 23:06:05 +0000 (16:06 -0700)]
Merge pull request #3097 from vors/docx
Convert SOSAndICorDebug.docx to SOSAndICorDebug.md
Jarret Shook [Tue, 21 Jun 2016 22:49:33 +0000 (15:49 -0700)]
Merge pull request #5900 from jashook/gc_stress_incompat
Set b14364 as gcstress incompat
Jarret Shook [Tue, 21 Jun 2016 22:49:18 +0000 (15:49 -0700)]
Merge pull request #5898 from jashook/gcstress_timeout_update
Up the default timeout for GCStress
Aditya Mandaleeka [Tue, 21 Jun 2016 22:40:25 +0000 (15:40 -0700)]
Merge pull request #5907 from Maoni0/stress_txt
updated stress run description
Maoni0 [Tue, 21 Jun 2016 22:36:05 +0000 (15:36 -0700)]
added a note about the reason why we ignore failures from tests in the stress run infrastructure
William Godbe [Tue, 21 Jun 2016 21:25:49 +0000 (14:25 -0700)]
Merge pull request #5903 from wtgodbe/groovester
Archive entire obj directory in coverage jobs
wtgodbe [Tue, 21 Jun 2016 21:21:45 +0000 (14:21 -0700)]
Archive entire obj directory
Maoni Stephens [Tue, 21 Jun 2016 20:56:01 +0000 (13:56 -0700)]
Merge pull request #5894 from Maoni0/seg_table
We need to have seg_mapping_table aligned on its natural alignement
Gaurav Khanna [Tue, 21 Jun 2016 20:22:03 +0000 (13:22 -0700)]
Merge pull request #5899 from dotnet-bot/UpdateDependencies20160621051655
Updating External dependencies to beta-24221-00
Sejong Oh [Tue, 21 Jun 2016 20:06:29 +0000 (13:06 -0700)]
Merge pull request #5892 from sejongoh/group_jitstress_jobs
Initial changes to move JIT stress jobs into jitstress directory on CI
Fadi Hanna [Tue, 21 Jun 2016 18:51:05 +0000 (11:51 -0700)]
Generic dictionary minor performance improvement and simplification for R2R (#5690)
A set of refactoring changes to slighly improve the performance of generic dictionary access on R2R images, and simplifying the codebase:
1) Removing dependency on CEEInfo::ComputeRuntimeLookupForSharedGenericTokenStatic (and deleting the API).
2) Stop parsing the generic type/method signatures when generating the R2R dictionary lookup assembly stub.
3) Avoid re-encoding the generic type/method signatures in a new in-memory blob using a SigBuilder (signatures used directly from the R2R image)
4) Moved the parsing/loading of type/method signatures to Dictionary::PopulateEntry()
5) Dictionary index and slot number are now encoded in the generated assembly stub instead of the signature (stub takes a pointer to a data blob, which contains the signature, the dictionary index and slot, and the module pointer)
Brian Sullivan [Tue, 21 Jun 2016 18:45:15 +0000 (11:45 -0700)]
Merge pull request #5895 from briansull/UnboxingStub-Fix
Fix for generic unboxing stub with x8 return buffer argument
Carol Eidt [Tue, 21 Jun 2016 18:10:47 +0000 (11:10 -0700)]
Merge pull request #5813 from mikedn/no-setflags
Remove useless gtSetFlags calls
Brian Robbins [Tue, 21 Jun 2016 17:42:10 +0000 (10:42 -0700)]
Merge pull request #5885 from brianrob/docker_perf
Update Linux Tracing Instructions for Docker Containers
jashoo [Tue, 21 Jun 2016 17:30:13 +0000 (10:30 -0700)]
Set b14364 as gcstress incompat
This test is set to be excluded to in interal testing under gc stress.
Add that information here as well.
dotnet-bot [Tue, 21 Jun 2016 17:16:55 +0000 (17:16 +0000)]
Updating External dependencies to beta-24221-00
jashoo [Tue, 21 Jun 2016 16:35:02 +0000 (09:35 -0700)]
Up the default timeout for GCStress
Gaurav Khanna [Tue, 21 Jun 2016 15:46:09 +0000 (08:46 -0700)]
Merge pull request #5887 from gkhanna79/Fix5883
Update Prerelease version to Beta and increment patch version.
Brian Sullivan [Tue, 21 Jun 2016 01:29:11 +0000 (18:29 -0700)]
Fix for generic unboxing stub with x8 return buffer argument
When we have nonstandard args we have to handle them before
we setup to expect the return buffer arg.
Added additional JitDump information about the call and its return type in impImportCall.
All of the ARM64 EXPECTED_PASS tests will now pass when hasFixedRerBufReg is enabled.
Additional changes are needed for the IL_STUB_PInvoke to get the Interop tests to pass
But these tests are currentlt alreay in the EXPECTED_FAIL catagory.
Gaurav Khanna [Mon, 20 Jun 2016 20:56:09 +0000 (13:56 -0700)]
Update Prerelease version to Beta and increment patch version.
Rahul Kumar [Tue, 21 Jun 2016 01:52:22 +0000 (18:52 -0700)]
Merge pull request #5893 from rahku/test
Enable building only native test components
Aditya Mandaleeka [Tue, 21 Jun 2016 01:26:16 +0000 (18:26 -0700)]
Merge pull request #4983 from benaadams/patch-2
Add slack channel
Aditya Mandaleeka [Tue, 21 Jun 2016 01:18:06 +0000 (18:18 -0700)]
Merge pull request #3074 from Dmitry-Me/useElseIfForExclusive
Use else-if for mutually exclusive conditions
Maoni0 [Wed, 15 Jun 2016 20:37:35 +0000 (13:37 -0700)]
We need to have seg_mapping_table aligned on its natural alignement (ptr size). When it's not aligned,
aside from the perf problem, we also have a functional problem when an address that's not on a heap
segment is passed - we could read an intermediate value which would cause an AV. If the address is
on a heap segment it means we are guaranteed to read a ptr size atomically. This only affects functions
like IsHeapPointer which can be run when EE is not suspended.
Rahul Kumar [Tue, 21 Jun 2016 00:01:34 +0000 (17:01 -0700)]
Enable building only native test components
William Godbe [Mon, 20 Jun 2016 23:47:12 +0000 (16:47 -0700)]
Merge pull request #5889 from wtgodbe/Loader
Fix race condition in Loader regression 523654 test
Aditya Mandaleeka [Mon, 20 Jun 2016 23:38:49 +0000 (16:38 -0700)]
Merge pull request #5879 from mattwarren/patch-1
Added links to CoreCLR issues, small formatting fix
Aditya Mandaleeka [Mon, 20 Jun 2016 23:35:14 +0000 (16:35 -0700)]
Merge pull request #5888 from adityamandaleeka/generate_core_dumps_runtest
Set coredump_filter to include shared library code in CI core dumps
Sejong Oh [Mon, 20 Jun 2016 22:42:22 +0000 (15:42 -0700)]
Initial changes to group JIT stress jobs into a sub directory on CI
Add jitstress2_jitstressregs1 scenario first and then will add others
after testing.
wtgodbe [Mon, 20 Jun 2016 22:21:44 +0000 (15:21 -0700)]
Fix race condition in Loader regression 523654 test
Sean Gillespie [Mon, 20 Jun 2016 21:56:29 +0000 (14:56 -0700)]
Merge pull request #5886 from swgillespie/longgc-netci
Switch to double-quotes for interpolated string in netci.groovy
Aditya Mandaleeka [Mon, 20 Jun 2016 21:29:37 +0000 (14:29 -0700)]
Set coredump_filter to include shared library code.
Brian Robbins [Fri, 17 Jun 2016 23:04:10 +0000 (16:04 -0700)]
Update Linux tracing instructions for Docker containers.
Sean Gillespie [Mon, 20 Jun 2016 20:11:18 +0000 (13:11 -0700)]
Switch to double-quotes for interpolated string
Stephen Toub [Mon, 20 Jun 2016 19:34:27 +0000 (15:34 -0400)]
Merge pull request #5882 from stephentoub/fix_ev_bytearray
Fix EventSource deserializing of byte[]s
Pat Gavlin [Mon, 20 Jun 2016 17:25:07 +0000 (10:25 -0700)]
Merge pull request #5875 from pgavlin/JitStdoutVbuf
Disable buffering on jitstdout.
Stephen Toub [Mon, 20 Jun 2016 17:05:18 +0000 (13:05 -0400)]
Fix EventSource deserializing of byte[]s
It's incorrectly repeating the first element for all elements.
Gaurav Khanna [Mon, 20 Jun 2016 15:35:28 +0000 (08:35 -0700)]
Merge pull request #5876 from dotnet-bot/UpdateDependencies20160620061718
Updating External dependencies to rc4-24220-00
Matt Warren [Mon, 20 Jun 2016 10:29:55 +0000 (11:29 +0100)]
Added links to CoreCLR issues, small formatting fix
Jan Vorlicek [Mon, 20 Jun 2016 09:57:00 +0000 (11:57 +0200)]
Fix GC background thread start in OOM (#5840)
This change fixes a problem that happened when the `gc_heap::create_bgc_thread`
calls SetupUnstartedThread and it fails to allocate a Thread object and throws.
The GC doesn't expect that and so when the stack is unwound, the `gc_heap::gc_started`
stays set. Now we try to allocate memory for the Throwable for the exception, so we go
to GC heap and since there is not enough space, we end up calling
`gc_heap::try_allocate_more_space`, which calls `gc_heap::wait_for_gc_done`.
And that’s the end of it, since the `gc_started` is still set and we wait forever.
The fix is to catch exception from the SetupUnstartedThread. I have also fixed couple of
places where this method was being called and the exception was not expected.
As an additional cleanup, I have moved the thread creation in GC to the GCToEEInterface.
dotnet-bot [Mon, 20 Jun 2016 06:17:18 +0000 (06:17 +0000)]
Updating External dependencies to rc4-24220-00
Pat Gavlin [Mon, 20 Jun 2016 04:42:09 +0000 (21:42 -0700)]
Disable buffering on jitstdout.
This avoid the need to call fflush() throughout the code.
Sejong Oh [Mon, 20 Jun 2016 02:01:55 +0000 (19:01 -0700)]
Merge pull request #5380 from sejongoh/x86_decompose_storeind
Decomposing 64-bit storeind instruction to 32-bit storeind instructions
Sejong Oh [Wed, 25 May 2016 01:11:52 +0000 (18:11 -0700)]
Decomposing 64-bit storeind instruction to 32-bit storeind instructions
Mike McLaughlin [Sun, 19 Jun 2016 22:24:49 +0000 (15:24 -0700)]
Fix source/line info in unhandled exceptions (#5874)
* Fix no source/line info for unhandled exceptions.
Issue #5828.
* Remove comment.
Peter Jas [Sun, 19 Jun 2016 18:37:06 +0000 (21:37 +0300)]
Remove the corner cases from sscanf test (#5873)
Jan Kotas [Sun, 19 Jun 2016 16:40:48 +0000 (09:40 -0700)]
Update GC from CoreRT (#5859)
https://github.com/dotnet/corert/tree/master/src/Native/gc
53276850bc2e7e531908434b2d062fcff3e1d58d
Jan Kotas [Sat, 18 Jun 2016 04:03:23 +0000 (21:03 -0700)]
Merge pull request #5858 from dotnet-bot/from-tfs
Merge changes from TFS
Kyungwoo Lee [Sat, 18 Jun 2016 03:46:05 +0000 (20:46 -0700)]
Merge pull request #5865 from kyulee1/fixgcstruct
ARM64: Fix GC hole for Multi-Reg Struct
Aditya Mandaleeka [Sat, 18 Jun 2016 02:38:35 +0000 (19:38 -0700)]
Merge pull request #5863 from adityamandaleeka/generate_core_dumps_runtest
Add option to runtest.sh to enable limited dump generation.
Andy Ayers [Sat, 18 Jun 2016 01:45:25 +0000 (18:45 -0700)]
Merge pull request #5868 from AndyAyersMS/BooleansRule
JIT: standardize on bool for return type of GenTree OperIs methods
Aditya Mandaleeka [Sat, 18 Jun 2016 01:30:06 +0000 (18:30 -0700)]
Merge pull request #5862 from adityamandaleeka/remove_dead_code
Remove some dead code in notifyexternals
Brian Sullivan [Fri, 17 Jun 2016 23:27:25 +0000 (16:27 -0700)]
Merge pull request #5831 from briansull/fix-5759
Fix for issue 5795
Andy Ayers [Fri, 17 Jun 2016 22:31:32 +0000 (15:31 -0700)]
JIT: standardize on bool for return type of GenTree OperIs methods
We had a mixture of bool and int return types. Standardize on bool.
Otherwise callers must match the mixed typing to avoid the fatal
C4800 warning on windows.
Aditya Mandaleeka [Fri, 17 Jun 2016 19:42:27 +0000 (12:42 -0700)]
Remove dead code in notifyexternals
Aditya Mandaleeka [Fri, 17 Jun 2016 22:13:19 +0000 (15:13 -0700)]
Enable core dump generation in CI test jobs
Kyungwoo Lee [Fri, 17 Jun 2016 21:27:36 +0000 (14:27 -0700)]
ARM64: Fix GC hole for Multi-Reg Struct
Fixes https://github.com/dotnet/coreclr/issues/5817
When we pass struct in multi-reg, we dropped the GC info on creating
instruction.
The fix is that for GT_LCL_FLD, we enforce non-float type size while
holding the gc type.
Validate with small cutdown. And also confirmed that the gc range is
reasonable in System.Reflection.RuntimeParameterInfo.GetParameters.
Russ Keldorph [Fri, 17 Jun 2016 22:02:55 +0000 (15:02 -0700)]
Merge pull request #5836 from RussKeldorph/nogcsosx
Disable GCStress=C periodic triggers for OSX
Andy Ayers [Fri, 17 Jun 2016 21:42:02 +0000 (14:42 -0700)]
Merge pull request #5856 from AndyAyersMS/ConstantObservations
JIT: Cleanup code in and around fgFindJumpTargets
Aditya Mandaleeka [Fri, 17 Jun 2016 20:49:53 +0000 (13:49 -0700)]
Add option to runtest.sh to enable limited dump generation.
Brian Sullivan [Thu, 16 Jun 2016 17:06:55 +0000 (10:06 -0700)]
Fix for issue 5795
We incorrectly pass the ret buf arg in x9 instead of x8
It is required that we call SortArgs and EvalArgsToTemps whenever we have any register arguments
We were not doing that when we only had a retBufArg argument in x8.
Fix for UNIX_AMD64 structs
Jan Kotas [Fri, 17 Jun 2016 17:43:24 +0000 (10:43 -0700)]
Merge pull request #5854 from dotnet-bot/from-tfs
Merge changes from TFS
Andy Ayers [Thu, 16 Jun 2016 22:33:48 +0000 (15:33 -0700)]
JIT: Cleanup code in and around fgFindJumpTargets
Reorder code to remove gotos. Extract two large chunks of logic as
subroutines. Add braces and update comments. Bring `fgStack` class up
to current Jit coding conventions. Reunite some orphaned comments for
fgFindJumpTargets.
No behavior change expected. No diffs seen via jit-diff tool. No diffs
seen in desktop testing.
Sean Gillespie [Fri, 17 Jun 2016 16:55:33 +0000 (09:55 -0700)]
Merge pull request #5839 from swgillespie/gc-batch-fix
Fix GC test batch script skip conditions that were behaving unexpectedly
Jan Kotas [Fri, 17 Jun 2016 15:17:25 +0000 (08:17 -0700)]
Fix full framework build break
[tfs-changeset: 1613359]
Gaurav Khanna [Fri, 17 Jun 2016 15:09:45 +0000 (08:09 -0700)]
Merge pull request #5852 from gkhanna79/Fix5837
Correctly resolve binding from Resolving event for static load
Eric St. John [Fri, 17 Jun 2016 14:16:31 +0000 (07:16 -0700)]
Changes to update TFS packages post 1.0
[tfs-changeset: 1613358]
Gaurav Khanna [Fri, 17 Jun 2016 13:29:41 +0000 (06:29 -0700)]
Add missing check to allow assembly bound using the Resolving event to be used during static binding scenario
Gaurav Khanna [Fri, 17 Jun 2016 12:32:04 +0000 (05:32 -0700)]
Merge pull request #5843 from dotnet-bot/UpdateDependencies20160617052045
Updating External dependencies to rc4-24217-00
Jonghyun Park [Fri, 17 Jun 2016 11:36:07 +0000 (20:36 +0900)]
Use LEAF_END_MARKED instead of LEAF_END for ARM64 debugbreak.S (#5850)
This commit applies the changes in #5847 (which fixes #5845) into ARM64
stub.
Jonghyun Park [Fri, 17 Jun 2016 08:55:43 +0000 (17:55 +0900)]
Use Use LEAF_END_MARKED instead of LEAF_END for various functions (#5849)
This commit fixes #5848.
Jonghyun Park [Fri, 17 Jun 2016 08:55:24 +0000 (17:55 +0900)]
Use LEAF_END_MARKED instead of LEAF_END for DBG_DebugBreak (#5847)
This commit tries to fix #5845
Jarret Shook [Fri, 17 Jun 2016 06:21:43 +0000 (23:21 -0700)]
Merge pull request #5842 from prajwal-aithal/devel/arm-ci-emul-fix
ARM-CI: Create mount path if not already present
dotnet-bot [Fri, 17 Jun 2016 05:20:45 +0000 (05:20 +0000)]
Updating External dependencies to rc4-24217-00
Prajwal A N [Fri, 17 Jun 2016 03:24:24 +0000 (12:24 +0900)]
ARM-CI: Create mount path if not already present
* Previous PRs assumed that the mount path is already created on the CI machine
* This results in errors if the same is not true
Signed-off-by: Prajwal A N <an.prajwal@samsung.com>
Rahul Kumar [Fri, 17 Jun 2016 01:05:11 +0000 (18:05 -0700)]
Merge pull request #5841 from rahku/master
Fix arm64 build break
Rahul Kumar [Fri, 17 Jun 2016 00:59:06 +0000 (17:59 -0700)]
Fix arm64 build break
Aditya Mandaleeka [Thu, 16 Jun 2016 23:36:36 +0000 (16:36 -0700)]
Merge pull request #5822 from adityamandaleeka/setup-runtime-dependencies_changes
Remove set -x from tests/setup-runtime-dependencies.sh.
Sean Gillespie [Thu, 16 Jun 2016 23:30:54 +0000 (16:30 -0700)]
Fix GC test batch script skip conditions that were behaving unexpectedly
Russ Keldorph [Thu, 16 Jun 2016 22:29:19 +0000 (15:29 -0700)]
Disable GCStress=C periodic triggers for OSX
Fixes #5763
William Godbe [Thu, 16 Jun 2016 22:05:19 +0000 (15:05 -0700)]
Merge pull request #5835 from wtgodbe/buildFix
Fix error when passing msbuild args to build.cmd/buildtest.cmd
wtgodbe [Thu, 16 Jun 2016 19:47:06 +0000 (12:47 -0700)]
Fix error when passing msbuild args to build.cmd/buildtest.cmd
Jan Kotas [Thu, 16 Jun 2016 19:32:16 +0000 (12:32 -0700)]
Mark Volatile methods with NonVersionable attribute (#5830)
Aditya Mandaleeka [Thu, 16 Jun 2016 18:57:06 +0000 (11:57 -0700)]
Fix some typos in setup-runtime-dependencies.cmd
Kyungwoo Lee [Thu, 16 Jun 2016 18:08:16 +0000 (11:08 -0700)]
Merge pull request #5821 from kyulee1/fixwb
ARM64: Fix WriteBarrier
Kyungwoo Lee [Wed, 15 Jun 2016 22:57:19 +0000 (15:57 -0700)]
ARM64: Fix WriteBarrier
I think this finally fixes most of long outstanding GC issues that appear in different
forms so far that include #4877, #4879, #4890 and more.
The issues was WriteBarrier implementation.
When we update card table, the address has been already incremented by 8.
With this fix, all corefx tests seem to run on xunit framework without crashing.
I verified this with an out-of-date build locally, so there are not found
assembly errors like System.Runtime.Extensions with different versions, though.
These are what I tested so far that safely finished all runs with very high percentage of pass.
System.Collections.Tests
System.Dynamic.Runtime.Tests
System.Linq.Expressions.Tests
System.Linq.Parallel.Tests
Potentially more coreclr tests will pass. I will update them as tests go.
Wes Haggard [Thu, 16 Jun 2016 17:04:18 +0000 (10:04 -0700)]
Merge pull request #5824 from dotnet-bot/UpdateDependencies20160616051753
Updating External dependencies to rc4-24216-00
Jan Vorlicek [Thu, 16 Jun 2016 13:15:08 +0000 (15:15 +0200)]
Remove end labels from regular asm procs on Unix (#5777)
All ASM proc now unnecessarily have xxx_End label marking
the end of the proc. This causes confusing stack traces in
some cases, especially on OSX, when instead of a name of
an actual function, a name of the previous one with the
_End attached to it is shown.
This change fixes that by modifying the LEAF_END macro to
not to be defined as an equivalent of the LEAF_END_MARKED.
Andy Ayers [Thu, 16 Jun 2016 05:53:47 +0000 (22:53 -0700)]
Merge pull request #5819 from AndyAyersMS/InlineTestsV1
Inliner: simple performance tests
dotnet-bot [Thu, 16 Jun 2016 05:17:53 +0000 (05:17 +0000)]
Updating External dependencies to rc4-24216-00
Brian Sullivan [Thu, 16 Jun 2016 01:10:01 +0000 (18:10 -0700)]
Merge pull request #5794 from briansull/vm-retbuf
Fixes for two JIT helpers that should not use the x8 RetBuf argument on ARM64
Aditya Mandaleeka [Thu, 16 Jun 2016 00:26:05 +0000 (17:26 -0700)]
Remove set -x from tests/setup-runtime-dependencies.sh.
Brian Sullivan [Mon, 13 Jun 2016 21:06:14 +0000 (14:06 -0700)]
Fixes for two JIT helpers that should not use the x8 RetBuf argument on ARM64
Fixes these two JIT helpers" CORINFO_HELP_GETFIELDSTRUCT and CORINFO_HELP_UNBOX_NULLABLE
We no longer set GTF_CALL_M_RETBUFFARG for the two special Jit helpers
We insert the extra byref argument in the x0 position for these two JIT helpers
William Godbe [Wed, 15 Jun 2016 22:57:56 +0000 (15:57 -0700)]
Merge pull request #5820 from wtgodbe/groovyR2R
Update crossgen strings for coreclr coverage tests
wtgodbe [Wed, 15 Jun 2016 22:54:33 +0000 (15:54 -0700)]
Update crossgen strings for coreclr coverage tests
Bruce Forstall [Wed, 15 Jun 2016 22:54:22 +0000 (15:54 -0700)]
Merge pull request #5815 from BruceForstall/RemoveAmd64Legacy
Remove AMD64 code from legacy code path
John Chen [Wed, 15 Jun 2016 22:29:56 +0000 (15:29 -0700)]
Merge pull request #5814 from JohnChen0/r2rtest
Modify CrossGen test script to work around cmd.exe bug
Andy Ayers [Fri, 10 Jun 2016 21:58:11 +0000 (14:58 -0700)]
Inliner: simple performance tests
Tests that demonstrate that constant arguments passed to callees can
lead to inlining performance wins. All numeric types are tested, as
well as strings.
Tests are generally written as positive/negative pairs with calls to
the same inlinee. This exposes the call site sensitivity. Performance
of the positive test should be better than the negative test.
The overall benchmarking approach used here is something that we might
consider adopting for other small-scale codegen performance tests.
Mike McLaughlin [Wed, 15 Jun 2016 22:03:57 +0000 (15:03 -0700)]
Fix exception stacktrace when ulimit is hit OSX. (#5802)
* Fix exception stacktrace when ulimit is hit OSX.
Issue #5782.
Wrap the everything in try/catch replacing the existing try/finally
and removed the recursion protection thread var.
* Restore recursion protection.