Simon Legner [Wed, 2 Jan 2019 07:18:07 +0000 (08:18 +0100)]
fix(crypto/tls): typo
David Fort [Mon, 24 Dec 2018 10:17:16 +0000 (11:17 +0100)]
Merge pull request #5168 from ckelsel/master
fix button_set_locked no return statement
kunming.xie [Mon, 24 Dec 2018 06:52:59 +0000 (14:52 +0800)]
fix button_set_locked no return statement
David Fort [Tue, 18 Dec 2018 14:38:41 +0000 (15:38 +0100)]
Merge pull request #5158 from akallabeth/wayland_mouse
Improved wayland mouse support
Armin Novak [Tue, 18 Dec 2018 12:30:13 +0000 (13:30 +0100)]
Implemented horizontal mouse wheel for wayland.
Armin Novak [Tue, 18 Dec 2018 12:43:17 +0000 (13:43 +0100)]
Implemented mouse buttons 4 and 5 for wayland.
David Fort [Fri, 14 Dec 2018 13:13:38 +0000 (14:13 +0100)]
Merge pull request #5148 from akallabeth/cert_accepted_fail
Fixed return value for already accepted certificate.
Armin Novak [Fri, 14 Dec 2018 08:52:25 +0000 (09:52 +0100)]
Fixed return value for already accepted certificate.
Bernhard Miklautz [Fri, 14 Dec 2018 08:13:42 +0000 (08:13 +0000)]
Merge pull request #5146 from oshogbo/master
There is only one primary monitor do not look for more.
Mariusz Zaborski [Thu, 13 Dec 2018 13:16:50 +0000 (14:16 +0100)]
There is only one primary monitor do not look for more.
akallabeth [Thu, 13 Dec 2018 12:48:44 +0000 (13:48 +0100)]
Merge pull request #5145 from bmiklautz/sshagent_server
fix [channels]: remove sshagent server side
David Fort [Thu, 13 Dec 2018 09:21:11 +0000 (10:21 +0100)]
Merge pull request #5144 from ondrejholy/coverity2
uwac: Do not return destroyed UwacSeat
Bernhard Miklautz [Thu, 13 Dec 2018 09:17:46 +0000 (10:17 +0100)]
fix [channels]: remove sshagent server side
The server side channel wasn't tested and does not work this way with
FreeRDP. Rely on the server side channel that come with the RDP
server(s).
Ondrej Holy [Thu, 13 Dec 2018 08:47:26 +0000 (09:47 +0100)]
uwac: Do not return destroyed UwacSeat
This is needed to fix the following defects reported by Covscan:
use_after_free: Using freed pointer "seat".
warning: Value stored to 'seat' is never read
This is follow up for https://github.com/FreeRDP/FreeRDP/pull/4970
https://github.com/FreeRDP/FreeRDP/issues/4820
David Fort [Wed, 12 Dec 2018 20:25:14 +0000 (21:25 +0100)]
Merge pull request #5143 from jphein/master
Added help description for /drive:hotplug,*
Jeffrey Hein [Wed, 12 Dec 2018 19:29:58 +0000 (11:29 -0800)]
Added help description for /drive:hotplug,*
akallabeth [Wed, 12 Dec 2018 14:36:39 +0000 (15:36 +0100)]
Merge pull request #5142 from astrand/master
Define scancodes for virtual keys, used by VNC servers
Bernhard Miklautz [Wed, 12 Dec 2018 12:08:34 +0000 (12:08 +0000)]
Merge pull request #5133 from akallabeth/enable_fonts_by_default
Enable smooth fonts by default.
Peter Åstrand (astrand) [Wed, 12 Dec 2018 10:43:03 +0000 (11:43 +0100)]
Define scancodes for virtual keys, used by VNC servers
The list of fake keycodes can be found at:
https://cgit.freedesktop.org/xkeyboard-config/tree/keycodes/evdev#n290
This commit adds support for AltGr when xfreerdp is used in
TigerVNC/Xvnc and ThinLinc sessions.
Martin Fleisz [Tue, 11 Dec 2018 13:40:58 +0000 (14:40 +0100)]
Merge pull request #5134 from oshogbo/master
Respect settings while sending the input capabilities.
Mariusz Zaborski [Tue, 11 Dec 2018 12:34:31 +0000 (13:34 +0100)]
Respect settings while sending the input capabilities.
Armin Novak [Tue, 11 Dec 2018 12:02:26 +0000 (13:02 +0100)]
Enable smooth fonts by default.
Martin Fleisz [Tue, 11 Dec 2018 09:30:39 +0000 (10:30 +0100)]
Merge pull request #5125 from akallabeth/clipboard_string_length_fix
Fix #5121: Determine actual string length for input data
Bernhard Miklautz [Tue, 11 Dec 2018 09:12:24 +0000 (09:12 +0000)]
Merge pull request #5075 from akallabeth/clipboard_channel_cleanup
Fixed clipboard channel cleanup.
Bernhard Miklautz [Tue, 11 Dec 2018 08:53:39 +0000 (08:53 +0000)]
Merge pull request #5126 from akallabeth/x11_button_mapping
X11 extended button remapping support.
Armin Novak [Tue, 11 Dec 2018 08:32:11 +0000 (09:32 +0100)]
Modified flag checks to avoid invalid flag sets.
Martin Fleisz [Tue, 11 Dec 2018 08:19:46 +0000 (09:19 +0100)]
Merge pull request #5083 from akallabeth/mac_client_fixes
Mac client fixes
Bernhard Miklautz [Mon, 10 Dec 2018 17:03:53 +0000 (18:03 +0100)]
fix [client/Mac]: UI API needs to be called in main thread
With recent SDKs the view won't update it the UI API is called
from a different thread.
Bernhard Miklautz [Mon, 10 Dec 2018 17:07:16 +0000 (17:07 +0000)]
Merge pull request #5128 from akallabeth/rail_crashes
Fixed crashes in rail mode after merge of floatbar fixes.
Armin Novak [Mon, 10 Dec 2018 14:41:20 +0000 (15:41 +0100)]
Fixed crashes in rail mode after merge of floatbar fixes.
Armin Novak [Mon, 10 Dec 2018 13:25:07 +0000 (14:25 +0100)]
X11 extended button remapping support.
Up until now X11 mouse button remapping was only possible for the
default buttons 1 to 3.
With this pull any X11 mouse button can be mapped to any RDP mouse
event and all X11 remappings are respected.
Martin Fleisz [Mon, 10 Dec 2018 13:45:10 +0000 (14:45 +0100)]
Merge pull request #5020 from akallabeth/floatbar_fixes
Floatbar fixes and windows support
Armin Novak [Mon, 10 Dec 2018 13:31:38 +0000 (14:31 +0100)]
Fixed variable hiding by not redeclaring it in subscope.
Armin Novak [Mon, 10 Dec 2018 13:02:57 +0000 (14:02 +0100)]
Added missing define for _wcsnlen for windows.
David Fort [Mon, 10 Dec 2018 12:41:06 +0000 (13:41 +0100)]
Merge pull request #5123 from akallabeth/rail_hash_function
Fixed rail window key hash function to work with UINT32
Bernhard Miklautz [Mon, 10 Dec 2018 12:23:13 +0000 (12:23 +0000)]
Merge pull request #5124 from akallabeth/cert_accept_fix
Fixed certificate accept
Armin Novak [Mon, 10 Dec 2018 11:41:04 +0000 (12:41 +0100)]
Fix #5121: Determine actual string length for input data
ConvertFromUnicode ignores '\0' sequences when the length of the input
string is given. Clipboard strings may be larger than the actual string
length and padded with random data leading to decoding errors.
Limit the length to the first occurrence of a '\0'.
Armin Novak [Mon, 10 Dec 2018 11:39:32 +0000 (12:39 +0100)]
Added _wcsnlen function for WCHAR string length.
Armin Novak [Mon, 10 Dec 2018 11:03:55 +0000 (12:03 +0100)]
Fixed certificate accept
certificate_data_replace can only replace an existing entry,
use certificate_data_print for new ones.
Martin Fleisz [Mon, 10 Dec 2018 10:58:43 +0000 (11:58 +0100)]
Merge pull request #5096 from akallabeth/dsp_channel_mix
Fix #5019: Added channel up/downmixing code for mono/stereo.
Armin Novak [Mon, 10 Dec 2018 10:16:43 +0000 (11:16 +0100)]
Fixed rail window key hash function to work with UINT32
akallabeth [Mon, 10 Dec 2018 09:26:52 +0000 (10:26 +0100)]
Merge pull request #5117 from hardening/rail_hash
rails: allow a window with id == 0
David Fort [Fri, 7 Dec 2018 09:33:07 +0000 (10:33 +0100)]
rails: allow a window with id == 0
Armin Novak [Fri, 7 Dec 2018 14:45:05 +0000 (15:45 +0100)]
Fixed windows floatbar title.
Martin Fleisz [Fri, 7 Dec 2018 14:45:59 +0000 (15:45 +0100)]
Merge pull request #5109 from akallabeth/gw_logging
Added additional gateway error logging.
Armin Novak [Wed, 21 Nov 2018 08:54:09 +0000 (09:54 +0100)]
Unified windows client window title settings.
Armin Novak [Wed, 21 Nov 2018 08:49:50 +0000 (09:49 +0100)]
Fixed #5040: Unified xfreerdp window title setting.
Armin Novak [Fri, 16 Nov 2018 09:33:29 +0000 (10:33 +0100)]
Refactored floatbar, extended command line settings.
Don Caton [Wed, 22 Jun 2016 18:58:39 +0000 (14:58 -0400)]
Windows client: Suppress minimize and restore buttons in float bar when toggle-fullscreen is false, added window title to float bar, improved overall appearance with gradients, shadow and transparent icons.
# Conflicts:
# client/Windows/wf_client.c
# client/Windows/wf_event.c
# client/Windows/wf_floatbar.c
Don Caton [Tue, 14 Jun 2016 18:15:08 +0000 (14:15 -0400)]
Updated .gitignore to exclude Visual Studio 2015 db files
Armin Novak [Thu, 15 Nov 2018 16:58:00 +0000 (17:58 +0100)]
Updated settings.h
Armin Novak [Thu, 15 Nov 2018 16:53:28 +0000 (17:53 +0100)]
Fixed a compiler warning for iterator type
Armin Novak [Thu, 15 Nov 2018 16:35:52 +0000 (17:35 +0100)]
Fixed monitor width and height checks.
Armin Novak [Thu, 15 Nov 2018 13:42:31 +0000 (14:42 +0100)]
Floatbar self contained.
Armin Novak [Thu, 6 Dec 2018 09:07:15 +0000 (10:07 +0100)]
Added additional gateway error logging.
Bernhard Miklautz [Fri, 7 Dec 2018 13:03:46 +0000 (13:03 +0000)]
Merge pull request #5099 from akallabeth/floatbar_close_window
Fixed #5098: Abort connection and let the application clean up resour…
Bernhard Miklautz [Fri, 7 Dec 2018 12:30:55 +0000 (12:30 +0000)]
Merge pull request #5118 from akallabeth/pem_warn_fix
Fix #5115: Cast PEM data from BYTE* to char* to silence warnings.
Armin Novak [Fri, 7 Dec 2018 11:36:18 +0000 (12:36 +0100)]
Fix #5115: Cast PEM data from BYTE* to char* to silence warnings.
David Fort [Fri, 7 Dec 2018 10:30:58 +0000 (11:30 +0100)]
Merge pull request #5116 from akallabeth/drive_ts_fix
Fixed #5113: The timestamps for FileFullDirectoryInformation were inverted
Martin Fleisz [Fri, 7 Dec 2018 10:28:22 +0000 (11:28 +0100)]
Merge pull request #5102 from akallabeth/rail_cleanups
Cleaned up xf_rail_server_handshake
Armin Novak [Fri, 7 Dec 2018 09:59:52 +0000 (10:59 +0100)]
Fixed #5113: The timestamps for FileFullDirectoryInformation were inverted.
Armin Novak [Fri, 30 Nov 2018 10:35:40 +0000 (11:35 +0100)]
Moved to extended certificate verification API
Armin Novak [Thu, 29 Nov 2018 17:35:20 +0000 (18:35 +0100)]
Fixed compile issue
Armin Novak [Thu, 29 Nov 2018 17:13:31 +0000 (18:13 +0100)]
Fixed glitches with certificate dialog.
Armin Novak [Thu, 29 Nov 2018 16:23:09 +0000 (17:23 +0100)]
Added certificate dialog.
Armin Novak [Thu, 29 Nov 2018 15:29:07 +0000 (16:29 +0100)]
Added client callbacks.
Armin Novak [Thu, 29 Nov 2018 14:50:43 +0000 (15:50 +0100)]
removed strcpy
Armin Novak [Thu, 29 Nov 2018 14:46:37 +0000 (15:46 +0100)]
Updated mac build.
Martin Fleisz [Thu, 6 Dec 2018 09:08:17 +0000 (10:08 +0100)]
Merge pull request #5085 from akallabeth/cert_callbacks_update
Refactored Certificate callbacks (but keep compatible)
Armin Novak [Thu, 6 Dec 2018 08:39:50 +0000 (09:39 +0100)]
Fixe accidental removal of certificate_data_replace
Martin Fleisz [Wed, 5 Dec 2018 15:27:05 +0000 (16:27 +0100)]
Merge pull request #5106 from hardening/wayland_seat7
Wayland seat version 7 and useful script
David Fort [Wed, 5 Dec 2018 14:21:00 +0000 (15:21 +0100)]
uwac: handle wl_seat with version >= 7
Starting at version 7, the wayland client is supposed to mmap the keymap as MAP_PRIVATE
to prevent accidental or intentional modifications.
David Fort [Wed, 5 Dec 2018 14:20:11 +0000 (15:20 +0100)]
script: add a usefull script to create code snippets from specification blobs
akallabeth [Wed, 5 Dec 2018 10:24:51 +0000 (11:24 +0100)]
Merge pull request #5104 from hardening/license_2k3
license: fix licencing against windows 2003 server
Martin Fleisz [Wed, 5 Dec 2018 10:20:34 +0000 (11:20 +0100)]
Merge pull request #5036 from akallabeth/auth_fixes
Refactor NEGO NLA and redirection to use opaque handles
Martin Fleisz [Wed, 5 Dec 2018 10:19:53 +0000 (11:19 +0100)]
Merge pull request #5103 from akallabeth/android_timezone
Fixed #5093: Try to read timezone from java TimeZone first
Martin Fleisz [Wed, 5 Dec 2018 09:57:43 +0000 (10:57 +0100)]
Merge pull request #5062 from akallabeth/init_freerdp_image_copy_from_pointer_data
Fix #5061: Initialize output buffer transparent.
Armin Novak [Tue, 20 Nov 2018 17:01:13 +0000 (18:01 +0100)]
Updated error info from spec.
Armin Novak [Tue, 20 Nov 2018 16:27:47 +0000 (17:27 +0100)]
Fixed requested protocol define names according to spec.
Armin Novak [Tue, 20 Nov 2018 16:03:50 +0000 (17:03 +0100)]
Fixed warnings in nego.
Armin Novak [Tue, 20 Nov 2018 15:48:59 +0000 (16:48 +0100)]
Refactored NLA to be self contained.
Armin Novak [Tue, 20 Nov 2018 15:40:42 +0000 (16:40 +0100)]
Hide redirection implementation details.
Armin Novak [Tue, 20 Nov 2018 15:38:06 +0000 (16:38 +0100)]
Made nego self contained.
David Fort [Wed, 5 Dec 2018 09:50:47 +0000 (10:50 +0100)]
license: fix licencing against windows 2003 server
The spec says:
"For Windows Server 2008, Windows Server 2008 R2, and Windows Server
2012, the EncryptedLicenseInfo variable (part of the Server Upgrade License PDU) sent by the server
to the client has the wBlobType parameter set to value BB_ENCRYPTED_DATA_BLOB (0x0009). For
Windows Server 2003, the value of wBlobType is not defined."
So don't enforce the message type.
Armin Novak [Wed, 5 Dec 2018 09:20:21 +0000 (10:20 +0100)]
Fixed #5093: Try to read timezone from java TimeZone first
persist.sys.timezone property might not exist, try to get the
timezone identifier from the java class first.
Armin Novak [Wed, 5 Dec 2018 08:13:04 +0000 (09:13 +0100)]
Cleaned up xf_rail_server_handshake
akallabeth [Wed, 5 Dec 2018 07:58:08 +0000 (08:58 +0100)]
Merge pull request #5100 from wintersandroid/master
Add jni interface for get_last_error_string
David Fort [Tue, 4 Dec 2018 21:42:25 +0000 (22:42 +0100)]
Merge pull request #5097 from hualet/master
Fixed RAIL window can't show again once hidden
Mathew Winters [Tue, 4 Dec 2018 18:56:05 +0000 (07:56 +1300)]
Add jni interface for get_last_error_string
Armin Novak [Tue, 4 Dec 2018 15:56:22 +0000 (16:56 +0100)]
Follow up to #4959: Lock gdi_UpdateSurfaces like xf_UpdateSurfaces
Armin Novak [Tue, 4 Dec 2018 15:42:28 +0000 (16:42 +0100)]
Fixed #5098: Abort connection and let the application clean up resources before exit.
Martin Fleisz [Tue, 4 Dec 2018 15:40:44 +0000 (16:40 +0100)]
Merge pull request #5087 from hardening/remotefx_chunks
remotefx: don't require data messages to come all in one chunk
David Fort [Tue, 4 Dec 2018 13:38:11 +0000 (14:38 +0100)]
Merge pull request #5094 from akallabeth/suppress_output_setting
Make "suppress output" setting available on command line
Martin Fleisz [Tue, 4 Dec 2018 13:29:59 +0000 (14:29 +0100)]
Merge pull request #4959 from akallabeth/gfx_lock_fix
Implemented GFX mutex locking and enforce return value checks.
Hualet Wang [Tue, 4 Dec 2018 12:28:32 +0000 (20:28 +0800)]
Fixed RAIL window can't show again once hidden
The cause is very simple: we didn't map the xwindow on receiving
WINDOW_SHOW. but doing that causes another problem that you can't
hide a window anymore, and that is because whlie window hiding, the
_NET_WM_STATE and WM_STATE properies of the xwindow may change, in
the function `xf_event_PropertyNotify` we just assume that windows
not maximized, not minimized, yet not showing normally should be
corrected to be shown, we just need to consider the situation that
the window is hidden here.
fix: #5078
Armin Novak [Tue, 4 Dec 2018 10:38:02 +0000 (11:38 +0100)]
Fix #5019: Added channel up/downmixing code for mono/stereo.
David Fort [Fri, 30 Nov 2018 10:37:23 +0000 (11:37 +0100)]
remotefx: don't require data messages to come all in one chunk
The spec doesn't require that FRAME_BEGIN, REGION, TILESET, and FRAME_END come all in one
chunk. This patch adds the necessary state saving.
A unitary test is also added.
Martin Fleisz [Tue, 4 Dec 2018 09:31:01 +0000 (10:31 +0100)]
Merge pull request #5077 from akallabeth/win_client_fixes
Win client fixes
Armin Novak [Fri, 30 Nov 2018 10:41:51 +0000 (11:41 +0100)]
Duplicate PEM when accepted.
Armin Novak [Fri, 30 Nov 2018 10:04:20 +0000 (11:04 +0100)]
Added new default certificate callbacks with extended information.
The extended information provided by VerifyCertificateEx and
VerifyChangedCertificateEx is now exploited by the new functions
client_cli_verify_certificate_ex and client_cli_verify_changed_certificate_ex.
The old callbacks now print out deprecation warnings to inform the
user and developer about this deprecation.