Tobin Ehlis [Mon, 21 Nov 2016 22:15:52 +0000 (15:15 -0700)]
layers:Use ptr to cmd buffer object in log_msg
This new error was incorrectly referencing the ptr to the cb_node,
which is internal validation state, instead of the cmd buffer object
that the node wraps.
Mark Lobodzinski [Tue, 22 Nov 2016 15:02:59 +0000 (08:02 -0700)]
scripts: Improve paths in update_ext_resources.sh
Script was relying on $PWD for determining the current path which
is unreliable in some situations. Updated to a more robust method
allowing spaces in paths.
Change-Id: Ibdb780c479ad7fa831d113e445cc598830806806
Mark Lobodzinski [Fri, 18 Nov 2016 20:48:44 +0000 (13:48 -0700)]
build: Add check for spirv-headers revision file
Change-Id: I9bc225275c4d890f44c7ab4dd2076b981778ac20
Mark Lobodzinski [Fri, 18 Nov 2016 20:20:36 +0000 (13:20 -0700)]
build: Move revision files into external_revisions
Moved glslang, spirv-tools and spirv-headers revision files into
the external_revisions subdirectory. Modified the Win/Lin update
external sources files to use the new locations.
Change-Id: I56138d5ae21430bcc564e6a42723accae1bcb9de
Mark Young [Tue, 22 Nov 2016 15:44:21 +0000 (08:44 -0700)]
docs: Fix loader doc mention of linux dirs
The Linux "Properly-Installed ICDs" section wasn't coming across
into HTML properly.
Change-Id: I2538b3c027c88ad5923d23f554bba1734c60ec06
Mark Young [Mon, 21 Nov 2016 23:20:06 +0000 (16:20 -0700)]
loader: Fix debug report memory leaks
Found a couple of memory leaks in the debug report code in the loader
while testing out allocators in cube.
Change-Id: I56b401394ca43bd8eb9b4f85baa52dfa597a6f49
Tobin Ehlis [Mon, 21 Nov 2016 22:51:45 +0000 (15:51 -0700)]
scripts:Some database clean-ups
Fix a bad test name in database file.
Update two checks which are implemented but didn't have "Y" in their
implemented column of the database file.
Fix a bug in stats script that failed to turn off red txt coloring.
Karl Schultz [Tue, 22 Nov 2016 01:31:48 +0000 (18:31 -0700)]
tests: Update layer doc to reflect recent test changes
Change-Id: I52ed15e0455b88ad7cf7474baa1d1790a13a86f0
Tobin Ehlis [Mon, 21 Nov 2016 20:58:59 +0000 (13:58 -0700)]
layers:Database update
Update database to record that check 1006 is implemented and has a test
Tobin Ehlis [Mon, 21 Nov 2016 19:33:49 +0000 (12:33 -0700)]
tests:Add InvalidQueryPoolCreate test
This test intentionally creates a device with the
pipelineStatisticsQuery feature disabled and then attempts to create a
QueryPool that for queryType VK_QUERY_TYPE_PIPELINE_STATISTICS.
Tobin Ehlis [Mon, 21 Nov 2016 19:30:06 +0000 (12:30 -0700)]
layers:Verify pipe stats are enabled for device
From Riku Salminen
At vkCreateQueryPool() time, make sure that if PIPELINE_STATISTICS
are requested, then the device must have pipelineStatisticsQuery
enabled.
Tobin Ehlis [Mon, 21 Nov 2016 17:36:16 +0000 (10:36 -0700)]
tests:Add DSUpdateEmptyBinding test
Try to update an empty descriptor binding and verify that correct error
is flagged.
Also updated database file to record testname and the fact that the
check is implemented.
Tobin Ehlis [Mon, 21 Nov 2016 17:33:40 +0000 (10:33 -0700)]
tests:Use unique error enum
Update InvalidDSUpdateIndex test to use unique error enum.
Update database to record test for this case.
Tobin Ehlis [Mon, 21 Nov 2016 16:50:49 +0000 (09:50 -0700)]
layers:Remove redundant periods
These error messages are all amended to error messages that already
include a period at the end so deleting the extra periods.
Tobin Ehlis [Mon, 21 Nov 2016 16:41:57 +0000 (09:41 -0700)]
layers:Check for update of empty binding
Validation error if descriptor update performed on an empty binding.
Chris Forbes [Mon, 31 Oct 2016 04:20:22 +0000 (17:20 +1300)]
layers: Tweak comments for swapchain checks to be less brittle
Referring to specific lines within an expression breaks every time this
code changes.
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Chris Forbes [Mon, 17 Oct 2016 02:01:40 +0000 (15:01 +1300)]
layers: Remove (mostly poor) descriptions from CV error enums
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Chris Forbes [Wed, 12 Oct 2016 22:59:22 +0000 (11:59 +1300)]
test: Disable the existing WSI tests
The existing support in Swapchain for this is going to be generalized to
every known extension entrypoint in PV, but that hasn't happened yet.
Disable this test for now so we don't get random breakage as other bits
of swapchain get disassembled.
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Chris Forbes [Wed, 12 Oct 2016 02:00:46 +0000 (15:00 +1300)]
layers: Remove husk of capabilities tracking from swapchain
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Chris Forbes [Wed, 12 Oct 2016 01:57:25 +0000 (14:57 +1300)]
layers: Remove remaining bits of image tracking from swapchain
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Chris Forbes [Wed, 12 Oct 2016 00:31:00 +0000 (13:31 +1300)]
layers: Remove husks of Acquire/Present from swapchain
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Chris Forbes [Wed, 12 Oct 2016 00:27:13 +0000 (13:27 +1300)]
layers: Move too many images case to CV
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Chris Forbes [Tue, 11 Oct 2016 23:24:44 +0000 (12:24 +1300)]
layers: Move most of remaining swapchain creation checks to CV
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Chris Forbes [Tue, 11 Oct 2016 21:21:19 +0000 (10:21 +1300)]
layers: Move complaints about presenting on bad queues to CV
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Chris Forbes [Tue, 11 Oct 2016 21:18:39 +0000 (10:18 +1300)]
layers: Have the instance WSI flags unconditionally exist
Code that changes its behavior based on these flags shouldn't also need
to be a mess of ifdef.
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Chris Forbes [Tue, 11 Oct 2016 19:55:03 +0000 (08:55 +1300)]
layers: Track surface support for gpu+queue
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Chris Forbes [Tue, 11 Oct 2016 03:21:32 +0000 (16:21 +1300)]
layers: Move caps query / swapchain creation interaction to CV
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Chris Forbes [Tue, 11 Oct 2016 02:57:55 +0000 (15:57 +1300)]
layers: Capture surface capabilities
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Karl Schultz [Mon, 21 Nov 2016 20:25:32 +0000 (13:25 -0700)]
build: Fix 32-bit Linux notes
Tony Barbour [Mon, 21 Nov 2016 19:56:25 +0000 (12:56 -0700)]
demos: Set attachment description flag bits in cube
Fixes a cubepp crash running on AMD
Change-Id: Ie8ef8625a2e8a8a416bcbfe4a62871fef5e07f71
Karl Schultz [Sat, 19 Nov 2016 17:24:47 +0000 (10:24 -0700)]
build: Update docs for Linux 32-bit
Change-Id: I38c19a166b25af8dba6bdac4d4c09eb1cfdc698d
Karl Schultz [Sat, 19 Nov 2016 16:02:27 +0000 (09:02 -0700)]
build: loader: Fix warnings for 32-bit linux
Change-Id: Ied7668aa7edeef01675dd4f358916d3e8bc07b27
Mark Lobodzinski [Fri, 18 Nov 2016 22:10:27 +0000 (15:10 -0700)]
build: Update .gitignore w/new __pycache__ location
Change-Id: I096d61d7e1ff20ab34672efe24a3cfaa888f0018
Mark Lobodzinski [Fri, 18 Nov 2016 22:04:50 +0000 (15:04 -0700)]
build: Move vk.xml file into scripts dir
- Update android-generate batch/script files
- Update layers CMakeLists.txt file
Change-Id: I6423f441d61daa20aef2cc5e8bc719113fd7978d
Mark Lobodzinski [Fri, 18 Nov 2016 21:58:57 +0000 (14:58 -0700)]
build: Move XML codegen scripts into scripts dir
- Update android-generate.bat and android-generate.sh
- Updated layer CMakeLists.txt files for new path
Change-Id: I1b1c9dbc9e944c90e95542fcfdda1d2e804517f3
Mark Lobodzinski [Fri, 18 Nov 2016 21:44:37 +0000 (14:44 -0700)]
build: Move codegen scripts into scripts dir
- Set SCRIPTS_DIR in root CMakeLists.txt
- Update android-generate.bat and android-generate.sh
- Updated layer/loader/tests CMakeLists.txt files for new path
- Updated test layer doc scripts for new location
Change-Id: I2d519ec40883ebeec4e9daab8641ad65515bb08c
Mark Lobodzinski [Fri, 18 Nov 2016 21:12:01 +0000 (14:12 -0700)]
scripts: Move determine_vs_version into scripts dir
- Moved determine_vs_version.py into scripts dir
- Updated build_windows_targets.bat
- Updated update_external_sources.bat
Change-Id: I951a05763a7004f2ba641dad72ae3c109ce0aa5c
Tobin Ehlis [Mon, 21 Nov 2016 15:31:01 +0000 (08:31 -0700)]
layers:Warn on cmd buffer invalidate
From Mikko Strandborg
When a resource gets deleted, any command buffer that references it
gets invalidated, and an error gets thrown whenever that command buffer
is submitted. However, for a developer, it's quite hard to deduce what
exactly caused that to happen. This patch emits a warning whenever a
command buffer that's in CB_RECORDING state (meaning that it has had
its vkBeginCommandBuffer called but not End). This way the developer
can set a breakpoint on that to see exactly what causes the buffer to
be invalidated.
Destroying a resource that's being used in an open command buffer is
almost certainly a bug, but there might still be cases where it might
be valid behavior (for example, when the application decides to abort
an operation), therefore it's not an error but a warning instead.
Tobin Ehlis [Mon, 21 Nov 2016 15:08:17 +0000 (08:08 -0700)]
scripts:Update unique error enums as of 11/21/16
4 Updated checks and 1 new check.
Cmd line was:
python spec.py -update -remap 918-768,2:1096-936:2170-1964 > output.txt
Tobin Ehlis [Fri, 18 Nov 2016 23:56:15 +0000 (16:56 -0700)]
scripts:Check image.cpp for unique error enums
Stats script wasn't checking image.cpp when looking for implemented
unique error enums.
Also updated script to include number of enums that it finds which are
claiming to be implemented but not located in source.
Chris Forbes [Sun, 20 Nov 2016 21:45:39 +0000 (10:45 +1300)]
Update out of range attachment check to use unique enum
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Chris Forbes [Wed, 16 Nov 2016 01:30:05 +0000 (14:30 +1300)]
layers: Only call ValidateLayouts if no prior error
The long-term solution here is to merge some of this code together, but
validating the layouts later and only if nothing else was bogus is a
good start.
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Chris Forbes [Tue, 15 Nov 2016 19:59:10 +0000 (08:59 +1300)]
tests: Add a test for an out of range attachment reference.
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Chris Forbes [Tue, 15 Nov 2016 19:58:32 +0000 (08:58 +1300)]
layers: Improve wording of attachment-index-out-of-range error
This wasn't correct for the == case.
Signed-off-by: Chris Forbes <chrisforbes@google.com>
joey-lunarg [Mon, 7 Nov 2016 18:27:00 +0000 (11:27 -0700)]
vulkaninfo: Fix variable, struct and function names
Cleanup to match Google c++ style guide.
Change-Id: Ifecbf5c8680159684e24a184421e907d1d815627
joey-lunarg [Wed, 2 Nov 2016 20:36:19 +0000 (14:36 -0600)]
vulkaninfo: Add surface present modes
Change-Id: Icb6c30a81743cf5854fd7ecc974d87e814be856d
Jeremy Hayes [Fri, 18 Nov 2016 18:59:55 +0000 (11:59 -0700)]
demos: fix validation error
Change-Id: Idd89d98bf8932c07df2c1452f27d2f3002fb2d8a
Jeremy Hayes [Wed, 16 Nov 2016 21:54:41 +0000 (14:54 -0700)]
demos: call DeviceWaitIdle before DestroyDevice
Change-Id: Ic5819027b706e8c5d66ae78d0d0da1133c16085b
Jeremy Hayes [Wed, 16 Nov 2016 21:47:13 +0000 (14:47 -0700)]
demos: make present mode a command line option
Change-Id: I0dedd685225f5aecaba968ba81da487e5d05da26
Jeremy Hayes [Wed, 16 Nov 2016 21:15:25 +0000 (14:15 -0700)]
demos: move staging texture to demo struct
Change-Id: I8b0319d0f0bab8aba6c41e8fa324f0a9f7128baf
Jeremy Hayes [Wed, 16 Nov 2016 20:42:08 +0000 (13:42 -0700)]
demos: move cmd bfr creation out of layout util
Change-Id: I01c4f59497f4ac22f2a96bda535c7965d34156d8
Mark Lobodzinski [Fri, 18 Nov 2016 15:36:15 +0000 (08:36 -0700)]
header: Update header files to version 1.0.34
- Updated vulkan.h
- Updated vk.xml
- updated windows/linux *.json files
- updated Linux SOVERSION
- updated vulkan.hpp
Change-Id: I288e2646445aec88aa4a3a9243dd65293fe1028a
Tobin Ehlis [Thu, 17 Nov 2016 20:51:54 +0000 (13:51 -0700)]
layers:Check reqs before call to BindImageMemory
There's an implicit spec requirement that GetImageMemoryRequirements()
should be called prior to calling BindImageMemory() b/c various return
values from GetImageMemoryRequirements() are expected to be complied
with.
This change adds a warning if GetImageMemoryRequirements() has not
been called prior to BindImageMemory(). In this case it will make the
call itself in order to populate internal state tracking.
Tobin Ehlis [Thu, 17 Nov 2016 20:39:57 +0000 (13:39 -0700)]
layers:Check reqs before call to BindBufferMemory
There's an implicit spec requirement that GetBufferMemoryRequirements()
should be called prior to calling BindBufferMemory() b/c various return
values from GetBufferMemoryRequirements() are expected to be complied
with.
This change adds a warning if GetBufferMemoryRequirements() has not
been called prior to BindBufferMemory(). In this case it will make the
call itself in order to populate internal state tracking.
Tobin Ehlis [Wed, 16 Nov 2016 16:30:23 +0000 (09:30 -0700)]
layers:Rename BUFFER_NODE->BUFFER_STATE
Tobin Ehlis [Tue, 15 Nov 2016 22:37:18 +0000 (15:37 -0700)]
layers:Check all memory bindings
There are a few places in the code where we assume that an image or
buffer doesn't have a sparse binding. These cases break with sparse
bindings.
To fix I added a function to BINDING class to retrieve all memory
bindings and then updated a few spots with bad assumption to make use
of this new GetBoundMemory() function.
Tobin Ehlis [Wed, 16 Nov 2016 16:01:28 +0000 (09:01 -0700)]
layers:Check buffer offset against required size
Fixes #1030
Use the required memory size instead of bound memory size when
validating the offset into a memory buffer. This will correctly handle
both sparse and non-sparse cases.
Tobin Ehlis [Wed, 16 Nov 2016 15:57:22 +0000 (08:57 -0700)]
layers:Save memory requirements
Add memory requirements member to the BINDABLE class and save memory
requirements for images and buffers in their respective
Get*MemoryRequirements() functions.
David Pinedo [Thu, 17 Nov 2016 22:03:16 +0000 (15:03 -0700)]
codegen: change script to handle NV ext structs
Modified vk_helper.py to handle NV-specific structures
Mark Lobodzinski [Thu, 17 Nov 2016 17:56:14 +0000 (10:56 -0700)]
layers: GH949, Fix ObjTrkr to destroy NULL handles
ObjectTracker emitted errors when a destroy/free call was made with
VK_NULL_HANDLE, which *is* allowed by the spec.
Change-Id: I2b4e19999e539d68b5856139566d4a7a8a530ca6
Tobin Ehlis [Thu, 17 Nov 2016 17:54:13 +0000 (10:54 -0700)]
tests:Add test DynamicOffsetWithInactiveBinding
This is a positive test that features an inactive binding with a
dynamic descriptor and an associated dynamic offset passed in at bind
time.
This previously caused an invalid validation error b/c we weren't
skipping entries in the dynamic offset array for inactive bindings
Tobin Ehlis [Thu, 17 Nov 2016 17:50:52 +0000 (10:50 -0700)]
layers:Fix descriptor dynamic offset handling
Fixes #1162
The dynamic offsets passed in at descriptor bind time are ordered based
on the binding order and any consecutive array indicies within those
bindings. When we validate the dynamic offsets at draw time, we were
using the entire dynamic offset array, but only the active bindings.
If we had an inactive dynamic binding before the end of the bindings
we would use the wrong offsets.
This change fixes the issue by creating a mapping between bindings and
dynamic offset array indicies at descriptor layout creation time. At
draw time the mapping is then used to lookup the correct dynamic offset
array index for a given binding.
Mark Lobodzinski [Thu, 17 Nov 2016 17:20:12 +0000 (10:20 -0700)]
Revert "layers: Update vulkan.py with new extensions"
This reverts commit
f504ff6e45bb15a0517a8de2e2d75e90df7e4627.
This caused huge issues in the VulkanTools repo, reverting for
now.
Mark Lobodzinski [Wed, 16 Nov 2016 21:53:26 +0000 (14:53 -0700)]
layers: Update vulkan.py with new extensions
Change-Id: I1b0623587d7d02849ece97de00ddb1c6bad58819
Mark Lobodzinski [Wed, 16 Nov 2016 22:34:26 +0000 (15:34 -0700)]
header: Update header files to version 1.0.33
- Updated vulkan.h
- Updated vk.xml
- updated windows/linux *.json files
- updated Linux SOVERSION
- updated vulkan.hpp
Change-Id: I8128a610d1cd24a1ac49712f28d566f712f4cc94
Rene Lindsay [Thu, 17 Nov 2016 01:52:55 +0000 (18:52 -0700)]
docs: add libxkbcommon dependency (Keyboard handling)
Mark Lobodzinski [Tue, 15 Nov 2016 16:40:32 +0000 (09:40 -0700)]
layers: Update error enum database
Updated status for new MappedMemoryRanges device limits checks.
Change-Id: Id5e1973fa2b7d798abfa3e54f751b69c1b29f2d1
Mark Lobodzinski [Tue, 15 Nov 2016 16:38:51 +0000 (09:38 -0700)]
tests: Add LVTs for MapMemRange device limits
Tacked them onto InvalidMemoryMapping test.
Change-Id: I62a094461730bcac14649a2ad6adf5cfdd0f2c58
Mark Lobodzinski [Tue, 15 Nov 2016 16:14:24 +0000 (09:14 -0700)]
tests: Fix unexpected errors in InvalidMemoryMapping
Old tests for offset/size range violations did not respect device
limits.
Change-Id: I83a1360197db1cdf6a2d9fcc521627643d3ef74d
Mark Lobodzinski [Mon, 14 Nov 2016 23:28:01 +0000 (16:28 -0700)]
layers: GH329, Add MappedMemoryRanges limits checks
When VkMappedMemoryRange structures are used, the offset and size
members must be a multiple of the device limit nonCoherentAtomSize.
Added these checks in core_validation.
Change-Id: If7eded4c52d31c1a25740ac08ec5434c93c5cecc
Mark Lobodzinski [Tue, 15 Nov 2016 14:59:58 +0000 (07:59 -0700)]
layers: Fixup MappedMemRanges call ordering
Moved validation out of API calls.
Change-Id: I95f3b24d69d469ea98b7c955bbab56c9b47ad487
Mark Lobodzinski [Tue, 15 Nov 2016 14:48:49 +0000 (07:48 -0700)]
layers: Fixup MappedMemory variable names for style
Change-Id: I4f8aae213753dc69ae28a945d7f34cff2af7ccd9
Mark Lobodzinski [Tue, 15 Nov 2016 20:55:22 +0000 (13:55 -0700)]
layers: Fixup validateMemoryIsMapped for style
Var names.
Change-Id: I69b441f986c017f2d34a62669c8b3e7511a2dd5f
Mark Lobodzinski [Tue, 15 Nov 2016 15:56:03 +0000 (08:56 -0700)]
layers: Update ValidateMemIsMapped error enums
Plumbed in VU error enums, updated tests and database.
Change-Id: I114d269c686cddd6b1d3acb098d0b2f5fe4fdc17
Mark Lobodzinski [Tue, 15 Nov 2016 20:40:03 +0000 (13:40 -0700)]
layers: Updated error database for new check
Vertex attribute formats, 1413.
Change-Id: Ieddd05c0f40a643db074ade79659f9c09699c436
Mark Lobodzinski [Tue, 15 Nov 2016 20:30:38 +0000 (13:30 -0700)]
tests: Add test for Vtx Attr Format check
Change-Id: Iee24796050cc87d6f912033ccdf0b18785bb2f60
Mark Lobodzinski [Wed, 16 Nov 2016 18:12:30 +0000 (11:12 -0700)]
layers: GH1143, Validate vertex attribute formats
Formats specified as vertex attributes (createGraphicsPipelines->
pCreateInfos->pVertexInputState->pVertexAttributeDescriptions.format)
must have the VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT set.
Change-Id: I907c37e2edbcfb7bcb405f912cea8d215acccb11
Mark Lobodzinski [Wed, 16 Nov 2016 19:12:56 +0000 (12:12 -0700)]
layers: Save PDev in device's layer data
Needed for physical-device calls or to access data belonging to
the physical device.
Change-Id: I2a1f6eadcaf82c2247a68c91c39d97ef3284b22a
Mark Lobodzinski [Wed, 16 Nov 2016 17:11:02 +0000 (10:11 -0700)]
layers: Update CGP var names for style
Changed CreateGraphicsPipeline local vars to match style guidelines.
Change-Id: I3204ce878b37ef3cb0ce58ecff00d65a4fed4f28
Mark Lobodzinski [Wed, 16 Nov 2016 17:05:30 +0000 (10:05 -0700)]
layers: Move val to PreCallCreateGraphicsPipelines
In core validation, created a pre-call function and moved the
validation calls into it.
Change-Id: Ib7831c3d2f36628e24b90083be902ac724f25483
Mark Lobodzinski [Wed, 16 Nov 2016 16:51:44 +0000 (09:51 -0700)]
layers: Remove verifyPipeLlineCreateState unused parm
Core-validation, device was unused.
Change-Id: Ia02ff0a3c9ce85c69b175c3e80b101dd2ddc8214
Jeremy Hayes [Tue, 15 Nov 2016 22:41:47 +0000 (15:41 -0700)]
layers: update valid usage
Change-Id: Ia46300db1e9140e0547c3e089cef17f774b44cf3
Tony Barbour [Mon, 14 Nov 2016 21:46:33 +0000 (14:46 -0700)]
demos: Enable building combinations of xcb and xlib
Change-Id: I055c12e8c93d05db747239df46611386eb8b8278
Tobin Ehlis [Tue, 15 Nov 2016 17:18:56 +0000 (10:18 -0700)]
scripts:Update unique error enums as of 11/15/16
2 new checks and 1 deleted check.
Cmd line was "python spec.py -update"
joey-lunarg [Mon, 14 Nov 2016 22:20:43 +0000 (15:20 -0700)]
demos: Fix compiler warning in smoketest
Replaced snprintf with stringstream.
Karl Schultz [Fri, 11 Nov 2016 23:09:47 +0000 (16:09 -0700)]
layers: gh125 Add check for memory obj max count
Fixes #125
Change-Id: I1b0b4eb2894494dc6df9c8dd1beab6f3645a707c
Cody Northrop [Mon, 14 Nov 2016 22:48:08 +0000 (15:48 -0700)]
android: Add default core count in case ncpus not available
qnope [Thu, 10 Nov 2016 17:56:51 +0000 (18:56 +0100)]
layers: GH1141, Fix host-bit/PREINITIALIZED warning
Validation layers [core_validation] give a warning when transitioning
an image layout from PREINITIALIZED with srcAccessMask = 0. Since the
barrier should be done implicitly when the commandBuffer is submitted,
the message from the validation layers is incorrect.
Change-Id: I0ebc9f300b029237d4d3527e411d88f64c485ac4
Cody Northrop [Thu, 3 Nov 2016 20:44:55 +0000 (14:44 -0600)]
android: Move external under build-android
Cody Northrop [Thu, 3 Nov 2016 20:35:08 +0000 (14:35 -0600)]
android: Build toolchain with more cores
Cody Northrop [Thu, 3 Nov 2016 20:34:17 +0000 (14:34 -0600)]
android: Pull known good toolchain versions
This includes pulling libSPIRV-Tools-opt into the build
to satisfy new shaderc revision.
Mark Young [Mon, 14 Nov 2016 22:03:34 +0000 (15:03 -0700)]
loader: Fix pointer dereference issue.
I was setting a value after the object containing it was deleted.
Change-Id: I8c41d454d3f9c89144e876c5b9feaf32af6e2500
Karl Schultz [Mon, 14 Nov 2016 18:53:08 +0000 (11:53 -0700)]
vulkaninfo: Fix unused label err for Windows
Also other rework of previous commit for vulkaninfo:
- remove label and goto
- make Xcb and Xlib display open failure handling more consistent.
Change-Id: Ibfa5cc6f591b987eda26d1ff7059a44dd41c220f
Mark Lobodzinski [Mon, 14 Nov 2016 18:39:39 +0000 (11:39 -0700)]
Revert "tests: Back DeviceWaitIdle out of test bindings"
This reverts commit
cd64bc300668e99aa56f3872f591a4d39db0f07f.
A DeviceWaitIdle was added to vktestbinding.cpp (which is correct),
but this caused crashes in LVTs. The commit was reverted, tests/layers
were fixed for crashes, and DevWaitIdle was added back. This caused
failures in the loader validation tests due to DS errors generated
during test teardown in LVTs. Once again, temporarily removing the
devicewaitidle until the layers can be fixed to close up some holes
(see github issues 945 and 1031).
Change-Id: If72d10d7173f8bea5efbbd7db9232c64e04e3e40
Mark Young [Mon, 7 Nov 2016 20:27:02 +0000 (13:27 -0700)]
loader: gh1120/gh1134 - Object wrapping issues
First issue was that we needed to override vkGetDeviceProcAddr. Instead
of allowing this to always go directly to the ICD, we needed to intercept
a few commands because they require a loader trampoline and terminator
call. Most commands still return a pointer directly to ICD command.
GH1120 - Unwrap both the physical device handles and the
KHR_surface handles in the loader during both the trampoline and
terminator calls for DebugMarker commands. This has to be done since the
values given to an application are the loader trampoline versions, and the
values given to the last layer is the loader terminator versions.
GH1134 - We were passing down the wrong device object to the ICD functions
when querying the ICD command function address and comparing it in the
override functions.
Thanks to Baldur (Mr. Renderdoc) for discovering this, testing my
fixes, and resolving several bugs.
Change-Id: I7618d71ffee6c53d9842758210a9261f6b3a1797
Awais Belal [Fri, 11 Nov 2016 10:13:40 +0000 (15:13 +0500)]
vulkaninfo: fix segfault when DISPLAY is not set
Both xlib and xcb interfaces expect the DISPLAY environment
variable to be set before creation of a window and the
display creation mechanism would segfault if that is
not the case and won't provide the user with details on
what has to be done to correct the problem.
We now handle such scenarios and exit cleanly after
providing the user with some details.
Signed-off-by: Awais Belal <awais_belal@mentor.com>
Mark Lobodzinski [Mon, 14 Nov 2016 15:18:09 +0000 (08:18 -0700)]
layers: GH321, vkAllocateMemory return code handling
If a custom allocator is used and fails, validation will continue,
using a null pointer and leading to invalid/unuseful validation
errors. Added a check for a good return code.
Change-Id: I2a91f2e9b3b951296b1e452364c863bca6b67b9f
Mark Lobodzinski [Fri, 11 Nov 2016 22:53:35 +0000 (15:53 -0700)]
Revert "tests: Back DeviceWaitIdle out of test bindings"
This reverts commit
93288504c01c2c89a4ba01c34f4af00ec1f507fa. Null-
checks were added to core_validation and the test was updated, so
this commit should no longer crash the layers.
Mark Lobodzinski [Fri, 11 Nov 2016 22:51:31 +0000 (15:51 -0700)]
tests: Fix CommandBufferTwoSubmits unexpected error
Needed some kindo of wait after the submits.
Change-Id: Ib365b3f9f1c6e87fbe4c8da24ee214b9c30d48b3
Mark Lobodzinski [Fri, 11 Nov 2016 22:27:12 +0000 (15:27 -0700)]
layers: Add null checks to RetireWorkOnQueue
API misuse was causing invalid object dereferences and crashes.
Change-Id: I81ff28b029b984a106a6c60063810e61a07cb945