platform/kernel/opensbi.git
5 years agoMerge pull request #4 from riscv/avpatel/master
Atish Patra [Sat, 22 Dec 2018 18:02:52 +0000 (10:02 -0800)]
Merge pull request #4 from riscv/avpatel/master

Remove PLAT_<xyz> defines from platform and firmwares

5 years agotop: Typo fix in top-level README.md
Anup Patel [Sat, 22 Dec 2018 15:44:23 +0000 (21:14 +0530)]
top: Typo fix in top-level README.md

The platform specific options will be PLATFORM_<xyz> and not
PLAT_<xyz> hence this patch fixes typo in top-level README.md.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agoplatform: Remove PLAT_HART_COUNT and PLAT_HART_STACK_SIZE
Anup Patel [Sat, 22 Dec 2018 15:31:40 +0000 (21:01 +0530)]
platform: Remove PLAT_HART_COUNT and PLAT_HART_STACK_SIZE

The PLAT_HART_COUNT and PLAT_HART_STACK_SIZE are only used
by platform code so no need of exposing these to everyone
by adding it to platform-cppflags-y.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agofirmware: Don't depend on PLAT_HART_COUNT and PLAT_HART_STACK_SIZE
Anup Patel [Sat, 22 Dec 2018 07:10:54 +0000 (12:40 +0530)]
firmware: Don't depend on PLAT_HART_COUNT and PLAT_HART_STACK_SIZE

The hart_count and hart_stack_size information is already available
in "struct sbi_platform" so we use that instead of depending on
PLAT_HART_COUNT and PLAT_HART_STACK_SIZE.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agofirmware: Remove stack section from common linker script
Anup Patel [Sat, 22 Dec 2018 06:32:31 +0000 (12:02 +0530)]
firmware: Remove stack section from common linker script

We don't need a separate stack section for per-HART stack
instead we create per-HART stack at the end of firmware
(i.e. after _fw_end symbol).

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agoplatform: Remove PLAT_NAME from all platforms
Anup Patel [Sat, 22 Dec 2018 05:45:37 +0000 (11:15 +0530)]
platform: Remove PLAT_NAME from all platforms

The PLAT_NAME is used only in platform.c for all platforms hence
remove it.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agoMerge pull request #3 from riscv/unleashed_working_12_21
Anup Patel [Sat, 22 Dec 2018 15:12:48 +0000 (20:42 +0530)]
Merge pull request #3 from riscv/unleashed_working_12_21

Unleashed working 12 21

5 years agoDisable all interrupts during warm irqchip init.
Atish Patra [Sat, 22 Dec 2018 05:31:12 +0000 (21:31 -0800)]
Disable all interrupts during warm irqchip init.

M mode is not expected to recieve any interrupts.
S mode interrupts shouldn't be enabled in M mode.

Signed-off-by: Atish Patra <atish.patra@wdc.com>
5 years agoIntroduce hart disabled parameter in platform.
Atish Patra [Fri, 21 Dec 2018 19:29:28 +0000 (11:29 -0800)]
Introduce hart disabled parameter in platform.

As of now, uboot doesn't have support for SMP.
Moreover, unleashed board has a E51 hart which
doesn't not support S mode.

We should only boot only 1 non-zero hart.

Signed-off-by: Atish Patra <atish.patra@wdc.com>
5 years agoFix plic warm init in platform code.
Anup Patel [Fri, 21 Dec 2018 23:46:37 +0000 (15:46 -0800)]
Fix plic warm init in platform code.

Pass S-Mode and M-mode context id separately to common warm init.

Signed-off-by: Atish Patra <atish.patra@wdc.com>
Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agoFix plic warm init in common code.
Anup Patel [Fri, 21 Dec 2018 23:45:14 +0000 (15:45 -0800)]
Fix plic warm init in common code.

Unleashed doesn't have S mode for hart 0.
PLIC register base calculation is current wrong because of that.

Signed-off-by: Atish Patra <atish.patra@wdc.com>
Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agoMove hardcoded uart constant to macros.
Atish Patra [Fri, 21 Dec 2018 23:16:59 +0000 (15:16 -0800)]
Move hardcoded uart constant to macros.

Signed-off-by: Atish Patra <atish.patra@wdc.com>
5 years agoIntroduce HAS_MFAULTS_DELEGATION feature
Damien Le Moal [Fri, 21 Dec 2018 10:19:54 +0000 (19:19 +0900)]
Introduce HAS_MFAULTS_DELEGATION feature

Conditionnally delegate page fault exceptions from M mode to S mode
based on the platform features.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agoplatform: kendryte/k210: Don't include math.h
Anup Patel [Fri, 21 Dec 2018 10:02:28 +0000 (15:32 +0530)]
platform: kendryte/k210: Don't include math.h

The math.h is not required anymore and it also gives
compile error for certain toolchains hence thsi patch
removes math.h include from kendryte/k210/sysctl.c.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agofirmware: Remove redundant write to mideleg and medeleg
Anup Patel [Fri, 21 Dec 2018 09:35:59 +0000 (15:05 +0530)]
firmware: Remove redundant write to mideleg and medeleg

The mideleg and medeleg are already programmed in delegate_traps()
so no need to set it here.

Any CSR setup in our reference firmware becomes a requirement
for bootloader linking to libsbi.a so we should have minimum
possible CSR setup in our reference firmware.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agoRevert "Fix FDT relocation"
Anup Patel [Fri, 21 Dec 2018 09:15:14 +0000 (14:45 +0530)]
Revert "Fix FDT relocation"

This patch reverts "Fix FDT relocation" because it breaks
fw_jump firmware.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agolib: Remove prints from sbi_hart_switch_mode()
Anup Patel [Fri, 21 Dec 2018 08:42:10 +0000 (14:12 +0530)]
lib: Remove prints from sbi_hart_switch_mode()

The sbi_hart_switch_mode() will be used by CPU hotplug. This means
if we have prints in sbi_hart_switch_mode() then these prints will
mix with Linux prints.

Being a runtime firmware, we should be verbose only at coldboot
time and error situations.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agolib: Fix delegate_traps() for Linux boot
Anup Patel [Fri, 21 Dec 2018 08:36:17 +0000 (14:06 +0530)]
lib: Fix delegate_traps() for Linux boot

commit d403c70fb11fb55042ca3cef0dbe399ed87cc79b breaks Linux
booting because of fewer exceptions delegated to S-mode. This
patch fixes Linux booting by having all required exceptions
delegated to S-mode.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agoconsole: protect output with a spinlock
Damien Le Moal [Fri, 21 Dec 2018 09:12:58 +0000 (18:12 +0900)]
console: protect output with a spinlock

Avoid getting messages from multiple harts mingled into garbage text
with a spinlock serializing calls to sbi_puts() and sbi_printf().

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agoKendryte-k210: Remove unnecessary asm functions
Damien Le Moal [Fri, 21 Dec 2018 08:20:56 +0000 (17:20 +0900)]
Kendryte-k210: Remove unnecessary asm functions

Use functions defined in sbi/riscv_asm.h.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agoIntroduce sbi_current_hartid()
Damien Le Moal [Fri, 21 Dec 2018 08:06:59 +0000 (17:06 +0900)]
Introduce sbi_current_hartid()

Use this helper instead of hardcoding csr_read(mhartid).

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agoCleanup and rename sbi_hart_boot_next()
Damien Le Moal [Fri, 21 Dec 2018 07:44:53 +0000 (16:44 +0900)]
Cleanup and rename sbi_hart_boot_next()

Cleanup sbi_hart_boot_nexti() code, adding messages for clarity and
rename the function to sbi_hart_switch_mode() to reflect what the
function actually does.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agoFiw comment typo
Damien Le Moal [Fri, 21 Dec 2018 07:35:33 +0000 (16:35 +0900)]
Fiw comment typo

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agoUpdate Kendryte k210 support
Damien Le Moal [Fri, 21 Dec 2018 00:14:44 +0000 (09:14 +0900)]
Update Kendryte k210 support

Booting now.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agoFix interrupt and exception delegation
Damien Le Moal [Fri, 21 Dec 2018 06:05:33 +0000 (15:05 +0900)]
Fix interrupt and exception delegation

When S mode is not supported, simply clear mideleg and medeleg.
Otherwise, set delegation from M-mode to S-mode, removing the page
fault exceptions as those would not happen in M-mode.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agoAdd a hang message
Damien Le Moal [Fri, 21 Dec 2018 06:04:16 +0000 (15:04 +0900)]
Add a hang message

Make it clear that the end of the FW execution was reached without the
hand being passed to any payload.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agoAdd a banner
Damien Le Moal [Fri, 21 Dec 2018 05:58:23 +0000 (14:58 +0900)]
Add a banner

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agofw: Disable delegation
Damien Le Moal [Fri, 21 Dec 2018 05:48:42 +0000 (14:48 +0900)]
fw: Disable delegation

Also disable interrupts and exceptions delegation when clearing mie and
mip.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agoFix FDT relocation
Damien Le Moal [Fri, 21 Dec 2018 01:03:56 +0000 (10:03 +0900)]
Fix FDT relocation

Or rather, disable it if FW_PAYLOAD_FDT_ADDR is not defined. This
correspond to cases where the underlying FW that loaded and started
opensbi did not provide any FDT. In such case, the platform code will
need to prepare one.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agoRefine platform features control
Damien Le Moal [Fri, 21 Dec 2018 00:13:37 +0000 (09:13 +0900)]
Refine platform features control

Allow a platform to report its supported features in more details.
The new features defined are:
* SBI_PLATFORM_HAS_PMP
* SBI_PLATFORM_HAS_SCOUNTEREN
* SBI_PLATFORM_HAS_MCOUNTEREN

In addition, define the macro SBI_PLATFORM_DEFAULT_FEATURES as the set
of features that are generally expected to be supported by a Linux
capable platform.

Operations touching the features controlled with these falgs are not
executed if the platform does not set the corresponding feature flags.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agolib: Hang in sbi_hart_boot_next() if next mode is not supported
Atish Patra [Fri, 21 Dec 2018 05:36:20 +0000 (11:06 +0530)]
lib: Hang in sbi_hart_boot_next() if next mode is not supported

We should not jump to next stage if next mode (S-mode or U-mode)
is not supported by HART.

Signed-off-by: Atish Patra <atish.patra@wdc.com>
Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agotop: Rename "plat" to "platform" everywhere
Anup Patel [Fri, 21 Dec 2018 05:05:04 +0000 (10:35 +0530)]
top: Rename "plat" to "platform" everywhere

This patch renames "plat" to "platform" everywhere for better
readablility.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agolib: Introduce bitmap to track HARTs waiting for coldboot
Anup Patel [Fri, 21 Dec 2018 04:39:33 +0000 (10:09 +0530)]
lib: Introduce bitmap to track HARTs waiting for coldboot

On QEMU Virt, max supported HARTs are 8 but number of HARTs
actually depend on "-smp" command-line parameter passed to
QEMU. This creates problems in sbi_hart_wake_coldboot_harts()
because when number of HARTs are less than 8.

To tackle this, we introduce a bitmap to track HARTs waiting
for coldboot to finish. We wake only those HARTs who have
set their bit in coldboot bitmap.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agotop: Rename "blob" to "firmware" everywhere
Anup Patel [Fri, 21 Dec 2018 04:22:27 +0000 (09:52 +0530)]
top: Rename "blob" to "firmware" everywhere

This patch renames "blob" to "firmware" everywhere for better
and intutive naming.

Signed-off-by: Anup Patel <anup@brainfault.org>
5 years agolib: sbi_hart: Remove unwanted sbi_printf()
Anup Patel [Fri, 21 Dec 2018 02:21:59 +0000 (07:51 +0530)]
lib: sbi_hart: Remove unwanted sbi_printf()

This patch removes unwanted sbi_printf() from
sbi_hart_wait_for_coldboot().

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agodocs: Add documentation for firmware blobs
Anup Patel [Thu, 20 Dec 2018 15:34:38 +0000 (21:04 +0530)]
docs: Add documentation for firmware blobs

This patch adds documentation for fw_jump and fw_payload
firmware blobs.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agotop: More detailed top-level README.md
Anup Patel [Thu, 20 Dec 2018 12:53:52 +0000 (18:23 +0530)]
top: More detailed top-level README.md

This patch adds more details to top-level README.md based on
current state of OpenSBI.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agoMerge pull request #1 from riscv/atish_fix_1
Anup Patel [Fri, 21 Dec 2018 01:53:26 +0000 (07:23 +0530)]
Merge pull request #1 from riscv/atish_fix_1

Various fixes for unleashed board

5 years agoSupport unsigned long in sbi_printf
Atish Patra [Thu, 20 Dec 2018 01:32:46 +0000 (17:32 -0800)]
Support unsigned long in sbi_printf

Signed-off-by: Atish Patra <atish.patra@wdc.com>
5 years agoUse wfi for coldboot finish call.
Atish Patra [Tue, 18 Dec 2018 00:35:07 +0000 (16:35 -0800)]
Use wfi for coldboot finish call.

Signed-off-by: Atish Patra <atish.patra@wdc.com>
5 years agoFix baud rate divisor computation for U540.
Atish Patra [Mon, 17 Dec 2018 23:31:49 +0000 (15:31 -0800)]
Fix baud rate divisor computation for U540.

Signed-off-by: Atish Patra <atish.patra@wdc.com>
5 years agoSupport /r/n as newline character.
Atish Patra [Mon, 17 Dec 2018 21:46:30 +0000 (13:46 -0800)]
Support /r/n as newline character.

Signed-off-by: Atish Patra <atish.patra@wdc.com>
5 years agoHiFive Unleashed has 5 harts. Fix the config to reflect that.
Atish Patra [Mon, 17 Dec 2018 21:44:06 +0000 (13:44 -0800)]
HiFive Unleashed has 5 harts. Fix the config to reflect that.

Signed-off-by: Atish Patra <atish.patra@wdc.com>
5 years agoplat: kendryte/k210: Enable fw_payload in config.mk
Anup Patel [Thu, 20 Dec 2018 06:21:22 +0000 (11:51 +0530)]
plat: kendryte/k210: Enable fw_payload in config.mk

We can only use fw_payload blob on Kendryte K210 board
because there is no previous booting stage hence this
patch enables fw_payload for Kendryte K210 board.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agoplat: Add Kendryte k210 initial support
Damien Le Moal [Thu, 20 Dec 2018 05:40:41 +0000 (14:40 +0900)]
plat: Add Kendryte k210 initial support

Only compiles for now, completely untested.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agoblob: Fix comments
Damien Le Moal [Thu, 20 Dec 2018 05:39:32 +0000 (14:39 +0900)]
blob: Fix comments

Add comments to assembler (not trivial to follow).

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agoAdded .gitignore
Damien Le Moal [Thu, 20 Dec 2018 05:36:49 +0000 (14:36 +0900)]
Added .gitignore

Ignore build and install directories

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agoblob: payload: Add FW_PAYLOAD_FDT_PATH option
Anup Patel [Wed, 19 Dec 2018 13:02:49 +0000 (18:32 +0530)]
blob: payload: Add FW_PAYLOAD_FDT_PATH option

This patch extends fw_payload blob to provide FW_PAYLOAD_FDT_PATH
option using which we can embed custom FDT in .text section of
fw_payload blob. In other words, FW_PAYLOAD_FDT_PATH is an option
to forcefully override FDT passed by previous booting stage in
a1 register.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agoblob: Rename FW_xyz_FDT_OFFSET to FW_xyz_FDT_ADDR
Anup Patel [Wed, 19 Dec 2018 09:56:11 +0000 (15:26 +0530)]
blob: Rename FW_xyz_FDT_OFFSET to FW_xyz_FDT_ADDR

Instead of placing FDT (passed by previous booting stage) at a
location relative to next address we should have absolute
location of placing FDT so that we more freedom of placing FDT.

This will be particularly useful for platforms/boards with
very less RAM (such as Kendryte board).

Due to above motivation, we rename FW_xyz_FDT_OFFSET options
to FW_xyz_FDT_ADDR options and use FW_xyz_FDT_ADDR options as
absolute address for placing FDT.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agoblob: Rename PLAT_TEXT_START to FW_TEXT_START
Anup Patel [Wed, 19 Dec 2018 09:35:45 +0000 (15:05 +0530)]
blob: Rename PLAT_TEXT_START to FW_TEXT_START

The PLAT_TEXT_START is only used by our firmware blobs hence
rename it to FW_TEXT_START.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agoblob: payload: Introduce FW_PAYLOAD_OFFSET compile time option
Anup Patel [Wed, 19 Dec 2018 09:23:26 +0000 (14:53 +0530)]
blob: payload: Introduce FW_PAYLOAD_OFFSET compile time option

This patch remove hard-coding of payload location in
fw_payload.elf.ldS by adding compile-time option
FW_PAYLOAD_OFFSET.

With the new compile-time option, payload will be placed
at PLAT_TEXT_START + FW_PAYLOAD_OFFSET address.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agoblob: Fix comment typos
Damien Le Moal [Wed, 19 Dec 2018 08:02:53 +0000 (17:02 +0900)]
blob: Fix comment typos

Various typos fix.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
5 years agoplat: clint: Reduce use of atomic operation on IPI registers
Anup Patel [Sun, 16 Dec 2018 08:21:16 +0000 (13:51 +0530)]
plat: clint: Reduce use of atomic operation on IPI registers

Currently, we aggresively use atomic operation on CLINT IPI
register. This patch simplify CLINT IPI APIs by reducing use
of atomic operations. In future, we will gradually increase
use of atomic operations for CLINT IPI APIs.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agoplat: Add separate platform support for QEMU sifive_u machine
Anup Patel [Sun, 16 Dec 2018 04:35:39 +0000 (10:05 +0530)]
plat: Add separate platform support for QEMU sifive_u machine

The QEMU sifive_u machine is not excatly same as HiFive Unleashed
board hence we add separate platform support for QEMU sifive_u
machine.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agolib: Don't emulate CSR read for misa and mhartid
Anup Patel [Sat, 15 Dec 2018 13:00:58 +0000 (18:30 +0530)]
lib: Don't emulate CSR read for misa and mhartid

Emulation of CSR read for misa and mhartid was a workaround for
bootloader accessing these CSRs in S-mode. This patch removes
CSR read emulation for misa and mhartid.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
5 years agoInitial commit.
Anup Patel [Tue, 11 Dec 2018 13:54:06 +0000 (19:24 +0530)]
Initial commit.

Signed-off-by: Anup Patel <anup.patel@wdc.com>