wtgodbe [Thu, 26 Jan 2017 22:01:18 +0000 (14:01 -0800)]
Speed up test native binary syncing in pipeline
Bruce Forstall [Thu, 26 Jan 2017 18:32:20 +0000 (10:32 -0800)]
Merge pull request #9132 from BruceForstall/FixBuildTest
Fix build-test.cmd
Bruce Forstall [Thu, 26 Jan 2017 18:16:32 +0000 (10:16 -0800)]
Merge pull request #9125 from BruceForstall/ImproveAddrModeJitDump
Improve address mode detection JitDumps
Bruce Forstall [Thu, 26 Jan 2017 18:16:08 +0000 (10:16 -0800)]
Merge pull request #9126 from BruceForstall/CleanUnusedTailcallNodes
Clean up unused tailcall via helper nodes
Bruce Forstall [Thu, 26 Jan 2017 18:14:55 +0000 (10:14 -0800)]
Merge pull request #9133 from BruceForstall/ImproveSimdTests
Improve SIMD tests
Gaurav Khanna [Thu, 26 Jan 2017 16:32:50 +0000 (08:32 -0800)]
Merge pull request #9120 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24925-08, beta-24926-02, respectively (master)
dotnet-bot [Thu, 26 Jan 2017 15:15:11 +0000 (15:15 +0000)]
Update CoreClr, CoreFx to beta-24925-08, beta-24926-02, respectively
Jonghyun Park [Thu, 26 Jan 2017 14:13:23 +0000 (23:13 +0900)]
Extract GetStackParameterSize from ESPIncrOnReturn (#9135)
Jonghyun Park [Thu, 26 Jan 2017 14:10:59 +0000 (23:10 +0900)]
Show register name in UPDATEREG log (#9134)
Mike McLaughlin [Thu, 26 Jan 2017 14:07:00 +0000 (06:07 -0800)]
Implement PAL_ProbeMemory with write/read to pipe (issue #4094) (#9122)
The recommended way to validate/probe memory on Linux/xplat is to use the write/read file apis to a pipe instead
of the hacky fragile hardware exception catching based probing we have now.
This builds on previous cleanup work in the master branch that removed the PAL Read/WriteProcessMemory
functions and added/replaced them with PAL_ProbeMemory. The DbgTransportSession::CheckBufferAccess that
issue mentions was also replaced.
Eugene Rozenfeld [Thu, 26 Jan 2017 06:08:24 +0000 (22:08 -0800)]
Merge pull request #9114 from erozenfeld/SecurityPermissionAttribute
Remove System.Security.Permissions.SecurityPermissionAttribute from System.Private.CoreLib.
Bruce Forstall [Thu, 26 Jan 2017 05:48:36 +0000 (21:48 -0800)]
Merge pull request #9124 from BruceForstall/FixSimdDetection
Fix non-deterministic AVX2 detection
Justin Van Patten [Thu, 26 Jan 2017 05:30:02 +0000 (21:30 -0800)]
Reduce number of branches and IL size of string.Trim methods (#9115)
Bruce Forstall [Thu, 26 Jan 2017 02:53:44 +0000 (18:53 -0800)]
Improve SIMD tests
1. Since the F1/F2 tests of VectorReturn found an issue Vector2
on x86, I added variants of the same test for Vector3 and Vector4
(by basically copying F1/F2 and altering appropriately).
2. I noticed VectorMin for Vector4 wasn't checking the 'W' member,
so I fixed that.
Bruce Forstall [Thu, 26 Jan 2017 02:25:11 +0000 (18:25 -0800)]
Fix build-test.cmd
Move set of __TestWorkingDir so it is available even when
__BuildAgainstPackages is not defined.
Eugene Rozenfeld [Wed, 25 Jan 2017 19:09:57 +0000 (11:09 -0800)]
Remove System.Security.Permissions.SecurityPermissionAttribute from System.Private.CoreLib.
When compiling with /unsafe+ Roslyn emits
.permissionset reqmin
= {class 'System.Security.Permissions.SecurityPermissionAttribute, System.Private.CoreLib,
Version=4.0.0.0, Culture=neutral, PublicKeyToken=
7cec85d7bea7798e' =
{property bool 'SkipVerification' = bool(true)}}
if System.Security.Permissions.SecurityPermissionAttribute is present.
In particular, System.Private.CoreLib.dll is compiled with /unsafe+ and has the above in the manifest.
https://github.com/dotnet/coreclr/commit/
e516211b2d3a3ae2dbd80f2c94b129910a9e280d
made BclRewriter remove System.Security.Permissions.SecurityPermissionAttribute
from System.Private.CoreLib.dll but the above reference remained.
This change removes System.Security.Permissions.SecurityPermissionAttribute completely
to avoid confusion when tools are analyzing msil and try to resolve the manifest
of System.Private.CoreLib.dll.
Bruce Forstall [Fri, 13 Jan 2017 07:28:51 +0000 (23:28 -0800)]
Clean up unused tailcall via helper nodes
For x86 tailcall via helper, delete the unused placeholder target
location nodes when they are replaced.
Bruce Forstall [Thu, 26 Jan 2017 00:23:55 +0000 (16:23 -0800)]
Improve address mode detection JitDumps
Koundinya Veluri [Thu, 26 Jan 2017 00:28:52 +0000 (16:28 -0800)]
Fix `Span<T>` GCStress issue on x86 (#9116)
x86 by default treats the type of `ByReference<T>` as the actual type of its IntPtr field as an optimization. `ByReference<T>` is a special case where the struct needs to be treated as a value type so that its field can be considered as a by-ref pointer. This fixes `GCStress=f` issues on span tests on x86.
Bruce Forstall [Wed, 11 Jan 2017 06:38:57 +0000 (22:38 -0800)]
Fix non-deterministic AVX2 detection
The caller required ECX to be zero when calling CPUID, but wasn't calling
the getextcpuid() function to cause that to happen.
Jonghyun Park [Wed, 25 Jan 2017 23:59:20 +0000 (08:59 +0900)]
Introduce REGDISPLAY_BASE (#9095)
* Introduce REGDISPLAY_BASE
William Godbe [Wed, 25 Jan 2017 23:54:37 +0000 (15:54 -0800)]
Merge pull request #9119 from wtgodbe/fixGroovyFx
Fix CoreFX Binary copying in netci.groovy
wtgodbe [Wed, 25 Jan 2017 23:45:52 +0000 (15:45 -0800)]
Fix CoreFX Binary copying in netci.groovy
Michelle McDaniel [Wed, 25 Jan 2017 21:04:20 +0000 (13:04 -0800)]
Merge pull request #9111 from adiaaida/fixCompatJitLeg
Fix x86compatjit and x86lb legs
William Godbe [Wed, 25 Jan 2017 20:12:18 +0000 (12:12 -0800)]
Merge pull request #9099 from wtgodbe/CoreRootRunTest
Reintroduce building Core_Root to runtest.cmd
William Godbe [Wed, 25 Jan 2017 20:11:06 +0000 (12:11 -0800)]
Merge pull request #9113 from wtgodbe/groovyRelease
Always use release folder for CoreFxBinDir
Michelle McDaniel [Wed, 25 Jan 2017 18:44:49 +0000 (10:44 -0800)]
Fix x86compatjit and x86lb legs
Change 7eacdd7 moved Exclude from runtest.cmd to build-test.cmd, which
broke the x86compatjit and x86lb legs in the lab. This change splits the
builds for these jobs into build.cmd skiptests and build-tests.cmd Exclude
<exclusion file> and removes the Exclude option from the runtest command.
wtgodbe [Wed, 25 Jan 2017 19:03:21 +0000 (11:03 -0800)]
Always use release folder for CoreFxBinDir
William Godbe [Wed, 25 Jan 2017 18:51:59 +0000 (10:51 -0800)]
Merge pull request #9112 from wtgodbe/fixbuildagainstpackages
Fix arg parsing for buildagainstpackages argument
wtgodbe [Wed, 25 Jan 2017 18:50:50 +0000 (10:50 -0800)]
Fix arg parsing for buildagainstpackages argument
Michelle McDaniel [Wed, 25 Jan 2017 18:50:48 +0000 (10:50 -0800)]
Merge pull request #9100 from adiaaida/vso370233
Update isUsedFromMemory to include CNS_DBLs
Michelle McDaniel [Tue, 24 Jan 2017 23:56:18 +0000 (15:56 -0800)]
Update isUsedFromMemory to include CNS_DBLs
Contained GT_CNS_DBLs should also be considered as isUsedFromMemory.
Fixes VSO 370233.
Stephen Toub [Wed, 25 Jan 2017 14:31:59 +0000 (09:31 -0500)]
Merge pull request #9024 from stephentoub/fix_taskwhenany
Fix race condition in Task.WhenAny
Jan Kotas [Wed, 25 Jan 2017 13:48:56 +0000 (05:48 -0800)]
Merge pull request #9102 from dotnet/revert-8969-encoding
Revert "Fast-path for ASCII & UTF8 Encoding ASCII data"
Jan Kotas [Wed, 25 Jan 2017 13:48:38 +0000 (05:48 -0800)]
Merge pull request #9104 from dotnet/revert-9091-perf-CompareOrdinalIgnoreCaseHelper
Revert "Improve CompareOrdinalIgnoreCaseHelper performance for matching chars"
Sivarv [Wed, 25 Jan 2017 04:50:37 +0000 (20:50 -0800)]
Merge pull request #9084 from hqueue/arm/ryujit/fp_sqrt
[Ryujit/ARM32] Implement GT_INTRINSIC_Sqrt for floating point type
Jan Kotas [Wed, 25 Jan 2017 04:17:48 +0000 (20:17 -0800)]
Revert "Improve CompareOrdinalIgnoreCaseHelper performance for matching chars"
Tarek Mahmoud Sayed [Wed, 25 Jan 2017 03:25:23 +0000 (19:25 -0800)]
Revert "Fast-path for ASCII & UTF8 Encoding ASCII data"
Drew Scoggins [Wed, 25 Jan 2017 03:14:21 +0000 (19:14 -0800)]
Merge pull request #9073 from DrewScoggins/DevEngUbuntuFix
Fix Ubuntu Perf Runs
Drew Scoggins [Sat, 21 Jan 2017 00:05:16 +0000 (16:05 -0800)]
Fix Ubuntu Perf Runs
After the dev/eng work the Ubuntu perf runs were broken because of
layout changes in the bin drop of CoreFX. We relied on these for the
CoreFX that we used during perf testing. I have made changes on the
CoreFX side to tar up the new runtime folder instead of a collection of
other bin folder. This change allows the infrastructure to consume
this.
Andy Ayers [Wed, 25 Jan 2017 01:44:58 +0000 (17:44 -0800)]
Merge pull request #9096 from AndyAyersMS/RevComplement
Add BenchmarkGames revcomp benchmark
Brian Sullivan [Wed, 25 Jan 2017 00:57:30 +0000 (16:57 -0800)]
Merge pull request #9020 from briansull/jumpstub-logging
Add logging for jumpsStubs and ClrVirtualAllocWithinRange
William Godbe [Wed, 25 Jan 2017 00:49:49 +0000 (16:49 -0800)]
Merge pull request #9092 from wtgodbe/fixRunTest
Fix runtest.sh build of Coreoverlay to account for new directory structure in CoreFX
wtgodbe [Wed, 25 Jan 2017 00:16:22 +0000 (16:16 -0800)]
Reintroduce building Core_Root to runtest.cmd
wtgodbe [Tue, 24 Jan 2017 21:59:29 +0000 (13:59 -0800)]
Fix runtest.sh build of Coreoverlay to account for new directory strucure in CoreFX
Andy Ayers [Wed, 18 Jan 2017 00:07:41 +0000 (16:07 -0800)]
Add BenchmarkGames revcomp benchmark
This is based on version 1 of the C# variants. Am not including
the largest input file since it is ~250MB. Instead we iterate
on a smaller file.
Note the text input files are opened as binary and the app looks for
Unix line endings, hence the update to .gitattributes.
The benchmark is setup to look for its input next to the benchmark exe
as run in both normal test and xunit-perf test modes, keying off the
CORE_ROOT environment variable. In the xunit-perf mode the input files
are subsequently copied into the sandbox.
Also updated the ending copyright date on the Benchmark Games
license page.
Brian Sullivan [Fri, 20 Jan 2017 02:38:33 +0000 (18:38 -0800)]
Document jumpStub usage in Codeman.cpp
Added new STRESS_LOG calls that do the following:
logging for JumpStubs
log the total count of jump stub lookups: JumpStubLookup
log the number of actual jump stub thunks created: JumpStubUnique
log the number of jump stub blocks allocated: JumpStubBlockAllocCount
log the number jump stub blocks that are completely filled: JumpStubBlockFullCount
logging for ClrVirtualAllocWithinRange
log the total number of calls to ClrVirtualAllocWithinRange
log the number of VirtualQuery operations used by the current call
log the range that was requested
log the return value
log any reasons for failure.
Bruce Bowyer-Smyth [Tue, 24 Jan 2017 22:22:01 +0000 (08:22 +1000)]
Improve CompareOrdinalIgnoreCaseHelper performance for matching chars (#9091)
Andy Ayers [Tue, 24 Jan 2017 22:15:00 +0000 (14:15 -0800)]
Merge pull request #9065 from pgavlin/FixPhaseListOrder
Fix the ordering of phases in compphases.h.
William Godbe [Tue, 24 Jan 2017 22:03:02 +0000 (14:03 -0800)]
Merge pull request #8973 from wtgodbe/HelixTestRuns
Add support for running CoreCLR Tests in Helix
Rahul Kumar [Tue, 24 Jan 2017 21:47:37 +0000 (13:47 -0800)]
Merge pull request #9090 from rahku/arm64fix
Fix arm64 build break
Ben Adams [Tue, 24 Jan 2017 21:21:52 +0000 (21:21 +0000)]
Fast-path for ASCII & UTF8 Encoding ASCII data (#8969)
* ASCII Encoding fast-path
* Add skipp for BIGENDIAN
* fixes
* ascii GetBytes(char[] chars) fix
* feedback
* Clean up
* Reuse exception block
* Add debug Asserts
Ian Hays [Tue, 24 Jan 2017 21:18:27 +0000 (13:18 -0800)]
Merge pull request #8944 from DmitryDzuba/patch-1
Add version increment into Sort(Comparison<T>)
wtgodbe [Tue, 17 Jan 2017 22:47:51 +0000 (14:47 -0800)]
Add support for running CoreCLR Tests in Helix
Gaurav Khanna [Tue, 24 Jan 2017 19:57:12 +0000 (11:57 -0800)]
Merge pull request #9071 from gkhanna79/FixVer200
Update CoreCLR nuget package versions to 2.0.0
Rahul Kumar [Tue, 24 Jan 2017 19:32:24 +0000 (11:32 -0800)]
Fix arm64 build break
Gaurav Khanna [Tue, 24 Jan 2017 17:28:56 +0000 (09:28 -0800)]
Merge pull request #9076 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24924-01, beta-24924-02, respectively (master)
mikedn [Tue, 24 Jan 2017 15:30:45 +0000 (17:30 +0200)]
Delete unused files (#9082)
- *.vrg files (registry entries)
- *.ini files (performance counters)
- *.vcproj/vcxproj/vspscc/sln (out of date)
- mscorrc.rc2 (not referenced from anywhere)
dotnet-bot [Tue, 24 Jan 2017 15:13:54 +0000 (15:13 +0000)]
Update CoreClr, CoreFx to beta-24924-01, beta-24924-02, respectively
Jonghyun Park [Tue, 24 Jan 2017 14:54:37 +0000 (23:54 +0900)]
[x86/Linux] Port CheckRegDisplaySP (#9081)
Remove duplicated declarations of CheckRegDisplaySP, and enable it for x86.
Hyung-Kyu Choi [Tue, 24 Jan 2017 11:50:12 +0000 (20:50 +0900)]
Fix codegen for GT_NEG to handle floating point type
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Jonghyun Park [Tue, 24 Jan 2017 12:39:37 +0000 (21:39 +0900)]
[x86/Linux] Fix EH Region Mismatch (#9043)
Jonghyun Park [Tue, 24 Jan 2017 11:09:16 +0000 (20:09 +0900)]
Simplify #ifdef related with UnwindStackFrame (#9052)
Hyung-Kyu Choi [Tue, 24 Jan 2017 11:04:09 +0000 (20:04 +0900)]
Implement GT_INTRINSIC_Sqrt for floating-point
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Jonghyun Park [Tue, 24 Jan 2017 09:36:30 +0000 (18:36 +0900)]
Clean up #else in EECodeManager::FixContext (#9048)
* Clean up #else in EECodeManager::FixContext
* Remove FixContext decl from EECodeManager
Jonghyun Park [Tue, 24 Jan 2017 09:31:51 +0000 (18:31 +0900)]
Clean up LeaveFinally/LeaveCatch (#9050)
* Hide LeaveFinally/LeaveCatch when WIN64EXCEPTION is defined
Bruce Forstall [Tue, 24 Jan 2017 07:27:47 +0000 (23:27 -0800)]
Merge pull request #9074 from BruceForstall/FixGenTreeHash
Fix GenTree hash function for commutative operators
Koundinya Veluri [Tue, 24 Jan 2017 07:13:26 +0000 (23:13 -0800)]
Disallow statics of spans and class instance members of span (#9061)
Functional fix for #8516 to cover some additional cases. IL tests will be coming later in a separate PR.
Jonghyun Park [Tue, 24 Jan 2017 06:52:45 +0000 (15:52 +0900)]
[x86/Linux] Port two preconditions in ExceptionTracker::ResetThreadAbortStatus (#9079)
Jonghyun Park [Tue, 24 Jan 2017 06:50:20 +0000 (15:50 +0900)]
Rename Esp in x86 REGDISPLAY as SP (#9070)
* Rename Esp in x86 REGDISPLAY as SP
* Fix x86/Windows build error
Carol Eidt [Tue, 24 Jan 2017 06:25:25 +0000 (22:25 -0800)]
Merge pull request #8672 from mikedn/cmp-lower-refactoring
Refactor TreeNodeInfoInitCmp
Carol Eidt [Tue, 24 Jan 2017 06:24:53 +0000 (22:24 -0800)]
Merge pull request #9072 from CarolEidt/DevDiv_1206929
Add a test case for a test optimization
Jan Kotas [Tue, 24 Jan 2017 06:23:18 +0000 (22:23 -0800)]
Port GC fixes from CoreRT (#9078)
Jonghyun Park [Tue, 24 Jan 2017 06:08:06 +0000 (15:08 +0900)]
Remove PALAPI attribute from PAL Callback (#9075)
Jonghyun Park [Tue, 24 Jan 2017 05:50:05 +0000 (14:50 +0900)]
Clean up #else in EECodeManager::GetAmbientSP (#9049)
Andy Ayers [Tue, 24 Jan 2017 04:02:20 +0000 (20:02 -0800)]
Merge pull request #8910 from AndyAyersMS/SpanBench
Add a simple span benchmark
Sean Gillespie [Tue, 24 Jan 2017 03:44:10 +0000 (19:44 -0800)]
[Local GC] Provide an implementation of GCToOSInterface for Unix-like platforms (#8976)
* Add way to build with FEATURE_STANDALONE_GC from build.sh
* Make CMake changes to build the GC 'PAL' as its own build target (to avoid -nostdinc).
In addition, introduce a "GC PAL" that provides an implementation of
GCToOSInterface on Unix-like platforms, for use with
FEATURE_STANDALONE_GC.
Bruce Forstall [Tue, 24 Jan 2017 01:19:30 +0000 (17:19 -0800)]
Fix GenTree hash function for commutative operators
gtHashValue() computes a hash value for a tree that, at least now,
is only used for determining whether to display the tree in the
JitDump after morphing. The hash function for commutative binary
operators was designed to return the same value if the operands
were switched (possibly this was used for CSE previously?). However,
this means that in some cases, nearly symmetric operands before and
after morphing would cause the "after morph" tree not to be displayed,
which is very confusing, since it implies that morphing had no
effect on the tree.
Since it appears we have no need for this special handling of
commutative binary operators, remove the special hashing done for them.
Sean Gillespie [Tue, 24 Jan 2017 01:11:15 +0000 (17:11 -0800)]
Disable GC/Scenarios/DoublinkList/doublinkgen (#9063)
* Disable DoublinkGen (see #6574)
* Add test to testsFailingOutsideWindows.txt
Sean Gillespie [Tue, 24 Jan 2017 00:50:51 +0000 (16:50 -0800)]
[Local GC] Add three finalization-related operations to GCToEEInterface (#9029)
* Add three finalization-related operations to GCToEEInterface and utilize them from the GC
* Code review feedback
* Code review feedback
* Fix standalone GC build break
* Repair the standalone GC build
Carol Eidt [Tue, 24 Jan 2017 00:23:29 +0000 (16:23 -0800)]
Add a test case for a test optimization
Gaurav Khanna [Tue, 24 Jan 2017 00:18:31 +0000 (16:18 -0800)]
Merge pull request #9056 from dotnet-bot/master-UpdateDependencies
Update CoreClr to beta-24923-06 (master)
Gaurav Khanna [Mon, 23 Jan 2017 23:39:52 +0000 (15:39 -0800)]
Update CoreCLR nuget package versions to 2.0.0
Jan Kotas [Mon, 23 Jan 2017 23:11:50 +0000 (15:11 -0800)]
Merge pull request #9058 from dotnet/redundant_neg
Remove redundant symbols disabled in CoreCLR
Matt Ellis [Mon, 23 Jan 2017 22:58:44 +0000 (14:58 -0800)]
Merge pull request #9059 from omajid/rhel7
Treat RHEL 7.x versions as RHEL 7 when building
Pat Gavlin [Mon, 23 Jan 2017 22:53:11 +0000 (14:53 -0800)]
Fix the ordering of phases in compphases.h.
PHASE_EMPTY_FINALLY and PHASE_CLONE_FINALLY were out-of-order in the
phase list with respect to their execution order, which caused the total
cycle count accounting to report incorrect data. This change places
these phases in the correct position in the phase list.
Dmitry [Mon, 23 Jan 2017 22:07:40 +0000 (01:07 +0300)]
Move version increment, add size conditions
Move version increment out of the if block.
Add new or modify existing conditions in the Reverse and two Sort methods to skip an operation if the collection size is less than 2.
dotnet-bot [Mon, 23 Jan 2017 19:44:01 +0000 (19:44 +0000)]
Update CoreClr to beta-24923-06
Omair Majid [Mon, 23 Jan 2017 18:08:08 +0000 (13:08 -0500)]
Treat RHEL 7.x versions as RHEL 7 when building
All RHEL 7.x versions are backwards compatible with each other. A .NET
Core build from 7.2 works fin on RHEL 7.3, for example. Treat this as a
general case and handle all 7.x versions the same.
This change only affects whether packages are built or not.
danmosemsft [Mon, 23 Jan 2017 19:05:12 +0000 (11:05 -0800)]
Remove desktop props
danmosemsft [Mon, 23 Jan 2017 18:40:54 +0000 (10:40 -0800)]
Remove disabled FEATURE_APTCA
danmosemsft [Mon, 23 Jan 2017 18:38:35 +0000 (10:38 -0800)]
Remove disabled FEATURE_APPDOMAINMANAGER_INITOPTIONS
danmosemsft [Mon, 23 Jan 2017 18:36:22 +0000 (10:36 -0800)]
Remove disabled FEATURE_APPX_BINDER
danmosemsft [Mon, 23 Jan 2017 18:15:34 +0000 (10:15 -0800)]
Remove disabled FEATURE_X509_SECURESTRINGS
danmosemsft [Mon, 23 Jan 2017 18:14:02 +0000 (10:14 -0800)]
Remove disabled FEATURE_X509
danmosemsft [Mon, 23 Jan 2017 18:10:54 +0000 (10:10 -0800)]
Remove disabled FEATURE_UNSAFE_CONTRACTS
danmosemsft [Mon, 23 Jan 2017 18:08:33 +0000 (10:08 -0800)]
Remove disabled FEATURE_SERIALIZATION
danmosemsft [Mon, 23 Jan 2017 18:07:06 +0000 (10:07 -0800)]
Remove disabled FEATURE_RWLOCK
danmosemsft [Mon, 23 Jan 2017 18:02:09 +0000 (10:02 -0800)]
Remove disabled FEATURE_PLS
danmosemsft [Mon, 23 Jan 2017 17:59:09 +0000 (09:59 -0800)]
Remove disabled FEATURE_NORM_IDNA_ONLY