serya@chromium.org [Thu, 21 Oct 2010 14:53:19 +0000 (14:53 +0000)]
Fixing build failure - added a missed file.
Review URL: http://codereview.chromium.org/3965004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5690
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
serya@chromium.org [Thu, 21 Oct 2010 14:21:00 +0000 (14:21 +0000)]
Optimizing HandleScope. Also fixed HandleScope destruction when API getter throws an exception.
Review URL: http://codereview.chromium.org/3792003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5689
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Thu, 21 Oct 2010 14:19:07 +0000 (14:19 +0000)]
Clean up the log-stack-tracer test.
Create the functions using the normal API and remove some
unnecessary helpers.
Review URL: http://codereview.chromium.org/4024003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5688
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Thu, 21 Oct 2010 13:15:12 +0000 (13:15 +0000)]
Implement --noinline-new flag fully on x64 and ia32 platforms.
Review URL: http://codereview.chromium.org/3961005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5687
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
floitschV8@gmail.com [Thu, 21 Oct 2010 11:54:32 +0000 (11:54 +0000)]
Strtod fast-case that uses DiyFps and cached powers of ten.
This is a fixed version of r5677.
Review URL: http://codereview.chromium.org/3898007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5686
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 21 Oct 2010 06:16:52 +0000 (06:16 +0000)]
Revert r5455 from bleeding_edge: attempt to collect more garbage
before panicking with out of memory.
TBR=antonm@chromium.org
Review URL: http://codereview.chromium.org/4034002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5681
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
floitschV8@gmail.com [Wed, 20 Oct 2010 15:30:59 +0000 (15:30 +0000)]
Fix build-breakage.
Revert "Strtod fast-case that uses DiyFps and cached powers of ten."
This reverts commit
493da023514021a63e1d3ba3f70348a275ac4042.
TBR: whesse@chromium.org
Review URL: http://codereview.chromium.org/3870003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5678
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
floitschV8@gmail.com [Wed, 20 Oct 2010 15:13:34 +0000 (15:13 +0000)]
Strtod fast-case that uses DiyFps and cached powers of ten.
Review URL: http://codereview.chromium.org/3760013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5677
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 20 Oct 2010 13:19:03 +0000 (13:19 +0000)]
Fix GC error in ES5 read-only properties implementation.
Review URL: http://codereview.chromium.org/3920005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5676
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 20 Oct 2010 12:01:17 +0000 (12:01 +0000)]
Fix the --noinline-new flag on ARM so that it forces us into C++ code
on every allocation. Fix three places where the generated code couldn't
cope with an unlucky GC.
Review URL: http://codereview.chromium.org/3872003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5674
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Wed, 20 Oct 2010 11:54:20 +0000 (11:54 +0000)]
Prepare push to trunk. Now working on version 2.5.2. Fixed past tense in ChangeLog.
Review URL: http://codereview.chromium.org/3913007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5673
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Wed, 20 Oct 2010 11:36:42 +0000 (11:36 +0000)]
Prepare push to trunk. Now working on version 2.5.2.
Review URL: http://codereview.chromium.org/3898006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5672
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Wed, 20 Oct 2010 08:52:46 +0000 (08:52 +0000)]
Update x64 RecordWrite comment. When the offset is zero the index
should be an untagged 32-bit integer on x64. There are debug mode
asserts in the code that catch tagged integers so we get test
failures if we get it wrong.
Review URL: http://codereview.chromium.org/3928002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5668
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Wed, 20 Oct 2010 08:32:24 +0000 (08:32 +0000)]
CPU Profiler: postpone moved functions registration until GC completes.
An attempt to retrieve security context for a function may fail if the
destination heap space is in an incomplete state. To fix this, we only
record unknown functions discovered at GC object moves, and then
register them after GC completes.
BUG=crbug/59627
Review URL: http://codereview.chromium.org/3763012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5667
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Wed, 20 Oct 2010 06:47:49 +0000 (06:47 +0000)]
Remove vm-state.cc from build files. Forgot to do that when
removing the file from the repository.
Review URL: http://codereview.chromium.org/3950001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5666
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Wed, 20 Oct 2010 05:54:23 +0000 (05:54 +0000)]
Make state stack thread local. When using Lockers the state stacks of
multiple threads got mixed up so that the current state could be an
already deallocated state from another thread.
Review URL: http://codereview.chromium.org/3828016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5665
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Tue, 19 Oct 2010 16:56:44 +0000 (16:56 +0000)]
Try to fix win64 build.
TBR=mikhail.naganov@gmail.com
Review URL: http://codereview.chromium.org/3797016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5664
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Tue, 19 Oct 2010 16:45:11 +0000 (16:45 +0000)]
Support profiling based on linux kernel performance events.
Since 2.6.31 perf_events interface has been available in the
kernel. There's a nice tool called "perf" (linux-2.6/tools/perf) that
uses this interface and provides capabilities similar to oprofile. The
simplest form of its usage is just dumping the raw log (trace) of
events generated by the kernel. In this patch I'm adding a script
(tools/ll_prof.py) to build profiles based on perf trace and our code
log. All the heavy-lifting is done by perf. Compared to oprofile agent
this approach does not require recompilation and supports code moving
garbage collections.
Expected usage is documented in the ll_prof's help. Basically one
should run V8 under perf passing --ll-prof flag and then the produced
logs can be analyzed by tools/ll_prof.py.
The new --ll-prof flag enables logging of generated code object
locations and names (like --log-code), and also of their bodies, which
can be later disassembled and annotated by the script.
Review URL: http://codereview.chromium.org/3831002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5663
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Tue, 19 Oct 2010 14:00:01 +0000 (14:00 +0000)]
Limit end-anchored regexps to testing end of string where possible.
Review URL: http://codereview.chromium.org/3844006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5661
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Tue, 19 Oct 2010 11:14:03 +0000 (11:14 +0000)]
Change the StackGuard runtime function to take no arguments.
For some reason the StackGuard runtime function took a dummy argument
that it always ignored. Change it to take no arguments.
Review URL: http://codereview.chromium.org/3838003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5660
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Tue, 19 Oct 2010 10:37:54 +0000 (10:37 +0000)]
Revert revision 5657.
TBR: erik.corry
Review URL: http://codereview.chromium.org/3812012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5658
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Tue, 19 Oct 2010 09:42:40 +0000 (09:42 +0000)]
Use finite-length end-anchored regexps to reduce part of regexp that is searched.
Review URL: http://codereview.chromium.org/3850005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5657
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Tue, 19 Oct 2010 09:16:57 +0000 (09:16 +0000)]
Return false from PagedSpace::Contains if the page from an address is not valid.
This can happen on Mac where C++ code can be in the 4-8K range.
Review URL: http://codereview.chromium.org/3781020
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5656
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Tue, 19 Oct 2010 08:23:47 +0000 (08:23 +0000)]
Make randomized allocations along 64k granularity boundaries to avoid comitting unused memory.
BUG=56036
TEST=None.
Patch by Justin Schuh <jschuh@chromium.org>
Review URL: http://codereview.chromium.org/3849004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5655
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Tue, 19 Oct 2010 08:14:41 +0000 (08:14 +0000)]
Clear normalized map caches in all global contexts not just in those reachable from ThreadLocalTops.
Issue reported by Mark Lam <mark.lam@palm.com> from Hewlett-Packard Development Company, LP.
Review URL: http://codereview.chromium.org/3828011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5654
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Mon, 18 Oct 2010 17:34:27 +0000 (17:34 +0000)]
Update sync profiling changes for Solaris platform.
Patch by Maciej Blizinski <blizinski@google.com>
TBR=kasperl@chromium.org
BUG=901
Review URL: http://codereview.chromium.org/3794008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5653
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Mon, 18 Oct 2010 17:01:30 +0000 (17:01 +0000)]
Fix TestInternalWeakLists test
Releasing context handle is not enough to release context, it might be indirectly reachable through compilation cache.
TBR=sgjesse@chromium.org
Review URL: http://codereview.chromium.org/3750017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5652
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
floitschV8@gmail.com [Mon, 18 Oct 2010 16:37:19 +0000 (16:37 +0000)]
Disable double strtod in ARM-simulator.
The ARM simulator is compiled for 32bits. On Linux the floating-point
operations are hence invalid for the simulator too.
Fixes build-breakage.
Review URL: http://codereview.chromium.org/3813009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5651
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
floitschV8@gmail.com [Mon, 18 Oct 2010 15:19:39 +0000 (15:19 +0000)]
Fix double-rounding in strtod.
Don't use floating-point operations on Linux,x86 to compute strtod. Since the
floating-point stack on Linux is set to 80bit double rounding may occure.
When falling back to gay_strtod append several '0's so that Gay doesn't take
the same shortcut either.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3851003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5650
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Mon, 18 Oct 2010 14:59:03 +0000 (14:59 +0000)]
Link all global contexts into a weak list.
Review URL: http://codereview.chromium.org/3764011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5649
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Mon, 18 Oct 2010 14:39:59 +0000 (14:39 +0000)]
SConstruct: make help work even if guesses failed.
Review URL: http://codereview.chromium.org/3811010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5648
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Mon, 18 Oct 2010 14:04:28 +0000 (14:04 +0000)]
Fix bug in comparison of two smis that differ by MIN_SMI on full compiler on all platforms.
Review URL: http://codereview.chromium.org/3767016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5643
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
antonm@chromium.org [Mon, 18 Oct 2010 12:58:56 +0000 (12:58 +0000)]
Get rid of requested size in RetryAfterGC.
This was only used by Heap::CollectGarbage to check if after GC
available space is bigger than was requested, but nobody checked
the value returned by Heap::CollectGarbage, so requested size
was efficiently unused.
However, it may trigger spurious out of memory exceptions if requested
size is big enough.
BUG=http://code.google.com/p/chromium/issues/detail?id=54580
Review URL: http://codereview.chromium.org/3836001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5642
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Mon, 18 Oct 2010 12:37:07 +0000 (12:37 +0000)]
Try to simplify the semantics of the profiling code by making
sure to suspend the thread (if necessary) on mac/win32 before
reading the VM state.
Avoid dealing with signals delivered to non-VM threads on
linux no matter if we're profiling or not.
Review URL: http://codereview.chromium.org/3845006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5641
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Mon, 18 Oct 2010 12:16:38 +0000 (12:16 +0000)]
Fix missing check for GC failure in number dictionary code.
Review URL: http://codereview.chromium.org/3781014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5640
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Mon, 18 Oct 2010 11:06:51 +0000 (11:06 +0000)]
Prepare push to trunk. Now working on version 2.5.1.
Review URL: http://codereview.chromium.org/3748013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5637
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Mon, 18 Oct 2010 10:23:45 +0000 (10:23 +0000)]
Fix compilation error on ARM with gcc 4.4. Remove NULL check of pointer to member, which was dead code (never failed).
Review URL: http://codereview.chromium.org/3793011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5636
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Mon, 18 Oct 2010 09:15:38 +0000 (09:15 +0000)]
New Heap profiler: add dumping HeapNumbers and InternalFields to snapshot.
HeapNumbers do consume memory, so it's worth dumping them. However, we
don't dump their values, as they are not as self-descriptive as values
of strings, and they will increase snapshot size. Storing heap numbers
values can be added if we will feel a sufficient demand for that.
InternalFields are used, e.g. for storing references to DOM nodes
event handlers.
Review URL: http://codereview.chromium.org/3769007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5635
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Fri, 15 Oct 2010 14:50:49 +0000 (14:50 +0000)]
Do not return the constant singleton float -0.0 from UnaryOpStub, because it may be overwritten, on X64 platform.
Review URL: http://codereview.chromium.org/3748007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5631
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Fri, 15 Oct 2010 13:03:59 +0000 (13:03 +0000)]
Remove trailing spaces from js files.
This is a cosmetic change only.
Review URL: http://codereview.chromium.org/3797009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5630
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Fri, 15 Oct 2010 11:45:05 +0000 (11:45 +0000)]
Add stop-at flag implementation to full compiler on all platforms.
Review URL: http://codereview.chromium.org/3791009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5629
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Fri, 15 Oct 2010 10:45:18 +0000 (10:45 +0000)]
Fix new-space-too-small test crash on 64 bit VM.
Review URL: http://codereview.chromium.org/3778009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5628
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Fri, 15 Oct 2010 07:54:20 +0000 (07:54 +0000)]
Fix creation of an exception to avoid rare GC corner case.
Review URL: http://codereview.chromium.org/3782009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5627
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 14 Oct 2010 18:54:53 +0000 (18:54 +0000)]
Fix the version number in the ChangeLog.
TBR=kmillikin@chromium.org
Review URL: http://codereview.chromium.org/3757004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5625
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
floitschV8@gmail.com [Thu, 14 Oct 2010 15:54:51 +0000 (15:54 +0000)]
Work around Windows bug. Use different constants.
Windows' strtod doesn't correctly read 3e-324 a the lowest denormal, but returns 0.0 instead.
Using 4e-324 is still the same value and works.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3744008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5624
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
floitschV8@gmail.com [Thu, 14 Oct 2010 13:47:48 +0000 (13:47 +0000)]
Weed out extreme exponents in strtod.
If a decimal exponent is less than -309 return 0.0.
If a decimal exponent is greater than +324 return +infinity.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3519017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5623
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Thu, 14 Oct 2010 12:54:00 +0000 (12:54 +0000)]
Restructure RegExp exec cache code.
Review URL: http://codereview.chromium.org/3778004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5622
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Thu, 14 Oct 2010 11:46:55 +0000 (11:46 +0000)]
Remove line added by accident.
TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/3761002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5621
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Thu, 14 Oct 2010 11:39:48 +0000 (11:39 +0000)]
Added USE_SIMULATOR macro that explicitly indicates that we wish to use the simulator as the execution engine. For example, this allows us to run with the ARM simulator on ARM.
Patch by Mark Lam <mark.lam@palm.com> from Hewlett-Packard Development Company, LP
Review URL: http://codereview.chromium.org/3825001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5620
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Thu, 14 Oct 2010 08:51:20 +0000 (08:51 +0000)]
Fix bug in cache handling of lastIndex on global regexps.
Review URL: http://codereview.chromium.org/3745005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5615
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Wed, 13 Oct 2010 14:57:00 +0000 (14:57 +0000)]
Better align heap snapshots contents with debugger info.
I created a heap snapshot in Chromium, and then started comparing
it side-by-side with representations of objects provided by
the debugger, fixing discrepancies.
Review URL: http://codereview.chromium.org/3590029
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5612
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Wed, 13 Oct 2010 08:12:58 +0000 (08:12 +0000)]
Prepare push to trunk. Now working on version 2.5.0.
Review URL: http://codereview.chromium.org/3776001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5609
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Fri, 8 Oct 2010 13:07:55 +0000 (13:07 +0000)]
Fix a bug in our handling of conditional expressions in test contexts.
In the FullCodeGenerator, we compile the true subexpression of a
conditional (ternary) expression in the inherited context of the
entire expression. This is correct for effect and value contexts, but
not for test contexts where the context includes a possible
fall-through label.
Review URL: http://codereview.chromium.org/3621013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5607
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
floitschV8@gmail.com [Thu, 7 Oct 2010 13:02:36 +0000 (13:02 +0000)]
Simplify powers-of-ten cache.
The existing cache was build to support changes to fast-dtoa. This complicated the cache. Since the cached numbers are now in a .cc file they can be shared with other parts of v8.
Review URL: http://codereview.chromium.org/3608011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5606
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
floitschV8@gmail.com [Thu, 7 Oct 2010 12:53:59 +0000 (12:53 +0000)]
Implement fast case for strtod.
Reapply r5603 with additional fix: use OS::StrNCpy instead of posix strncpy.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3557010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5605
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 7 Oct 2010 12:24:02 +0000 (12:24 +0000)]
Revert strtod fast-case change (r5603) because of Windows compilation
errors.
TBR=floitschV8@gmail.com
Review URL: http://codereview.chromium.org/3582017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5604
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
floitschV8@gmail.com [Thu, 7 Oct 2010 12:01:25 +0000 (12:01 +0000)]
Implement fast case for strtod.
If there are few non-zero digits and the 10^exponent fits into a double then
we can compute the result using 1 (or 2) double operations.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3584015
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5603
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Thu, 7 Oct 2010 09:40:26 +0000 (09:40 +0000)]
Fix new strtod on Windows platform, using OS::SNPrintF instead of snprintf. Fixes error in r5600.
Review URL: http://codereview.chromium.org/3601018
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5602
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
floitschV8@gmail.com [Thu, 7 Oct 2010 09:12:21 +0000 (09:12 +0000)]
Fix build-breakage. Add new line to end of strtod.h. TBR: whesse@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/3584018
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5601
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
floitschV8@gmail.com [Thu, 7 Oct 2010 08:54:10 +0000 (08:54 +0000)]
Move gay_strtod outside conversions.cc.
This is the first part of removing calls to gay's strtod. Future CLs will
get rid of calls to gay_strtod entirely.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3563009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5600
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Thu, 7 Oct 2010 07:25:22 +0000 (07:25 +0000)]
Promote the current V8 benchmark suite candidate to version 6.
Review URL: http://codereview.chromium.org/3571021
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5596
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Wed, 6 Oct 2010 08:47:08 +0000 (08:47 +0000)]
Fix presubmit failure.
Review URL: http://codereview.chromium.org/3605008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5595
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
floitschV8@gmail.com [Wed, 6 Oct 2010 08:33:52 +0000 (08:33 +0000)]
During StringToDouble negative exponents may be less than -999 with a result that is not 0.0.
Review URL: http://codereview.chromium.org/3564011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5594
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Wed, 6 Oct 2010 06:09:05 +0000 (06:09 +0000)]
Land for Rodolph Perfetta.
Added a missing SetCC in the ARM CompareStub.
BUG=none
TEST=none
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5593
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Tue, 5 Oct 2010 13:29:31 +0000 (13:29 +0000)]
Code clean-up in src/top.cc This patch addresses late review comments for code.google.com/p/v8/source/detail?r=5586
Review URL: http://codereview.chromium.org/3596005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5592
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
antonm@chromium.org [Tue, 5 Oct 2010 13:10:43 +0000 (13:10 +0000)]
Do not shortcut union of keys if lhs is empty.
The problem is other array may have holes, for example
when fixed array comes from JSArray (in case of named interceptor).
If that would prove to be a performance problem, we could
pass an additional argument into UnionOfKeys to hold actual length.
Review URL: http://codereview.chromium.org/3595013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5591
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
antonm@chromium.org [Tue, 5 Oct 2010 12:48:32 +0000 (12:48 +0000)]
Add a check that accessors set to instance template work even if we have a custom call handler.
Review URL: http://codereview.chromium.org/3526008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5590
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Tue, 5 Oct 2010 12:01:46 +0000 (12:01 +0000)]
Fix typo in the spec reference.
TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/3547012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5589
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Tue, 5 Oct 2010 11:51:41 +0000 (11:51 +0000)]
Addressing Mads' comments from codereview.chromium.org/3585010/show.
Review URL: http://codereview.chromium.org/3613009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5588
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Tue, 5 Oct 2010 09:07:17 +0000 (09:07 +0000)]
Fix lint errors
TBR=mnaganov
Review URL: http://codereview.chromium.org/3525014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5587
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Tue, 5 Oct 2010 08:53:51 +0000 (08:53 +0000)]
StackTrace should provide access to //@ sourceURL=... value
Review URL: http://codereview.chromium.org/3602013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5586
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Mon, 4 Oct 2010 15:21:38 +0000 (15:21 +0000)]
Make lint happy.
TBR=kmillikin@chromium.org
Review URL: http://codereview.chromium.org/3609008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5585
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Mon, 4 Oct 2010 15:04:16 +0000 (15:04 +0000)]
API: expose RegExp.
Review URL: http://codereview.chromium.org/3585010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5584
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Mon, 4 Oct 2010 14:30:43 +0000 (14:30 +0000)]
More refactoring of class Compiler's interface.
Change more functions used by the Compiler class to have a uniform
interface: they get passed as argument an input/output pointer to a
CompilationInfo that they mutate if they succeed, and they return a
flag telling whether they succeeded.
Also, remove some unnecessary timers.
Review URL: http://codereview.chromium.org/3561012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5583
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Mon, 4 Oct 2010 12:54:31 +0000 (12:54 +0000)]
Previously, there was a bug there, fixed in r5581. But having an assert still makes sense.
Also, add functions registration to CPU profiler in case
when closure code wasn't compiled yet.
Review URL: http://codereview.chromium.org/3557007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5582
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Mon, 4 Oct 2010 11:35:46 +0000 (11:35 +0000)]
Begin a more aggressive refactoring of the Compiler interface.
The plan is to use the CompilationInfo class to communicate inputs and
outputs to compilation pipeline phases, which each return a boolean
success/failure flag.
The intent is to make it easier to compose small pieces of the
pipeline without having to grow a custom function each time, each
taking a half dozen arguments.
This change modifies the very front end (the parser).
Review URL: http://codereview.chromium.org/3586006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5581
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Mon, 4 Oct 2010 07:57:07 +0000 (07:57 +0000)]
Prepare push to trunk. Now working on version 2.4.9.
Review URL: http://codereview.chromium.org/3538009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5579
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Fri, 1 Oct 2010 15:32:32 +0000 (15:32 +0000)]
Fix a pair of compilation failure bugs in test files due to r5576.
1. parser.h depends on ast.h, but only gets it included implicitly
everywhere parser.h is included (except for tests). Include ast.h in
parser.h.
2. Regular expression tests test the free functions that have just been
moved into class Parser.
TBR=fschneider@chromium.org
Review URL: http://codereview.chromium.org/3602007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5577
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Fri, 1 Oct 2010 14:10:47 +0000 (14:10 +0000)]
Make some free functions into static members of class Parser.
Review URL: http://codereview.chromium.org/3518005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5576
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kaznacheev@chromium.org [Fri, 1 Oct 2010 12:40:30 +0000 (12:40 +0000)]
Fix property array length calculation in TransformPropertiesToFastFor.
It was silently assumed that inobject_properties value is not too large.
Recent introduction of inobject slack tracking made the assumption false
and debug tests with no snapshot failed.
Review URL: http://codereview.chromium.org/3584004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5575
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Fri, 1 Oct 2010 09:30:42 +0000 (09:30 +0000)]
Rename include guard to match file name
Review URL: http://codereview.chromium.org/3532006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5574
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Fri, 1 Oct 2010 09:08:52 +0000 (09:08 +0000)]
Fix bad cast in string-search.h.
Review URL: http://codereview.chromium.org/3530004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5572
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kaznacheev@chromium.org [Fri, 1 Oct 2010 08:28:28 +0000 (08:28 +0000)]
Fine-tune inobject slack tracking.
The current parameters (initial slack = 6, kGenerousAllocationsCount = 16)
caused 15-20% performance regression on 3d-raytrace on x64
(visible both in standalone shell and in the web harness). This is very
likely some kind of an alignment problem (it goes away completely with --prof).
A similar problem can be observed on ia32 with initial slack=2.
Increased initial slack to 8 and decreased constructions count to 8.
This made the regression go away (and did not harm any of the other tests).
Review URL: http://codereview.chromium.org/3595002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5571
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Fri, 1 Oct 2010 07:19:23 +0000 (07:19 +0000)]
Fix HeapSnapshotsDiff test, diff implementation, and a bug introduced
during snapshot size optimization.
Sorry, now I figured out that the diff implementation itself was also
incorrect. Reachable nodes must be filtered from the beginning,
otherwise, an object that is already disconnected, but not discarded
yet, will not appear as a deleted (thankfully, this bug for some
reason had appeared on the x64 port.)
BUG=868
TEST=HeapSnapshotRootPreservedAfterSorting
Review URL: http://codereview.chromium.org/3531005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5570
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Thu, 30 Sep 2010 17:39:31 +0000 (17:39 +0000)]
Use existing global cell status as a hint when generating loads.
Review URL: http://codereview.chromium.org/3537003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5569
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 30 Sep 2010 12:35:03 +0000 (12:35 +0000)]
Revert last commit due to check fail on Linux.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5568
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 30 Sep 2010 12:24:56 +0000 (12:24 +0000)]
Fix HeapSnapshotsDiff test and a bug introduced during snapshot size optimization.
The bug wasn't revealed because the test was disabled.
BUG=848
TEST=HeapSnapshotsDiff,HeapSnapshotRootPreservedAfterSorting
Review URL: http://codereview.chromium.org/3572003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5567
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
antonm@chromium.org [Thu, 30 Sep 2010 11:48:03 +0000 (11:48 +0000)]
Rename some x64 macros to be more precise about their semantics.
Review URL: http://codereview.chromium.org/3574002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5566
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 30 Sep 2010 10:50:39 +0000 (10:50 +0000)]
Add fflush after writing to log (Issue 868).
BUG=868
Review URL: http://codereview.chromium.org/3605001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5565
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Thu, 30 Sep 2010 09:35:50 +0000 (09:35 +0000)]
Prepare push to trunk. Now working on version 2.4.8.
Review URL: http://codereview.chromium.org/3585003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5562
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Thu, 30 Sep 2010 09:28:58 +0000 (09:28 +0000)]
Cleanup of the parser.
The lazy parsing functions took a host of arguments that can all be
derived from the SharedFunctionInfo, and the SharedFunctionInfo is
always available when parsing lazily. Change the interface to take a
single CompilationInfo or SharedFunctionInfo argument.
Also remove a flag in the parser that was always false when it was read.
Review URL: http://codereview.chromium.org/3538005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5561
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Thu, 30 Sep 2010 08:48:37 +0000 (08:48 +0000)]
Introduce subclasses of class CompilationInfo.
It was a wart that we had three handle fields, exactly one of which
was non-null; and that we had three overloaded constructors. Instead,
introduce subclasses and virtual methods.
Remove some unused fields from class CompilationInfo.
Review URL: http://codereview.chromium.org/3566003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5560
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 30 Sep 2010 07:22:53 +0000 (07:22 +0000)]
New attempt to make the allocation routines 64 bit clean.
This one has been approved by the 64 bit compiler in MSVC
2005 so I hope it also passes the 2008 version.
The --max-new-space-size option is now in kBytes.
The --max-old-space-size option is now in MBytes.
Some issues remain with 64 bit heaps and the counters. See
http://code.google.com/p/v8/issues/detail?id=887
Review URL: http://codereview.chromium.org/3573005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5559
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
antonm@chromium.org [Wed, 29 Sep 2010 18:15:36 +0000 (18:15 +0000)]
Add another check to be sure non-negative smi fits into Uint32 range.
Review URL: http://codereview.chromium.org/3546003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5558
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Wed, 29 Sep 2010 17:38:37 +0000 (17:38 +0000)]
Remove some unused fields from class CompilationInfo.
Review URL: http://codereview.chromium.org/3533007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5557
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
antonm@chromium.org [Wed, 29 Sep 2010 15:08:38 +0000 (15:08 +0000)]
Do not invoke indexed interceptor getters for negative indices.
BUG=https://bugs.webkit.org/show_bug.cgi?id=46689
Review URL: http://codereview.chromium.org/3520006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5553
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 29 Sep 2010 14:06:30 +0000 (14:06 +0000)]
Add cast to make Win-64 compile without warnings. This is a commit of codereview.chromium.org/3521002 for lrn.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5552
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Wed, 29 Sep 2010 12:12:45 +0000 (12:12 +0000)]
Added missing file. Mea culpa.
Review URL: http://codereview.chromium.org/3586001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5551
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Wed, 29 Sep 2010 10:57:23 +0000 (10:57 +0000)]
Refactored string search code.
Made string search state explicit for repreated calls (a StringSearch class).
Review URL: http://codereview.chromium.org/3467010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5550
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Wed, 29 Sep 2010 07:51:47 +0000 (07:51 +0000)]
Add an AST node type enum to AST nodes.
When inspecting an AST node in the debugger, it can be difficult to
find its concrete type. Add a "node_type" virtual function to all the
concrete AST nodes.
Use a macro to generate the definition of node_type as well as Accept
and the AsXXX type testing/casting functions.
Review URL: http://codereview.chromium.org/3431026
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5549
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00