David PHAM-VAN [Tue, 28 Jun 2016 21:39:29 +0000 (14:39 -0700)]
Fix Memory Leaks in RdpSnd
David PHAM-VAN [Tue, 28 Jun 2016 21:39:14 +0000 (14:39 -0700)]
Fix Memory Leaks in RdpDR
David PHAM-VAN [Tue, 28 Jun 2016 21:39:01 +0000 (14:39 -0700)]
Fix Memory Leaks in Disp channel
David Fort [Fri, 9 Sep 2016 09:16:29 +0000 (11:16 +0200)]
Merge pull request #3482 from realjiangms/fix_gfx_win8
server/shadow: Fix regression with rdp8.0
zihao.jiang [Sat, 27 Aug 2016 13:51:29 +0000 (21:51 +0800)]
server/shadow: Fix regression with rdp8.0
Shadow server crash with rdp8.0 with gfx enabled.
Root Cause: rdp8.0 is not support in shadow gfx and rdpgfx_caps_advertise returns an error. However setChannelError crashs because context->errorDescription is NULL
1. Fix shadow gfx to handle rdp8.0
2. Initialize context->errorDescription for server side new-context
Martin Fleisz [Thu, 25 Aug 2016 07:00:56 +0000 (09:00 +0200)]
Merge pull request #3435 from akallabeth/uuid_find_fix
CMake FindUUID fixes.
Martin Fleisz [Thu, 25 Aug 2016 06:17:52 +0000 (08:17 +0200)]
Merge pull request #3284 from ondrejholy/endianness
Endianness fixes
David Fort [Wed, 24 Aug 2016 09:08:00 +0000 (11:08 +0200)]
Merge pull request #3316 from realjiangms/server_gfx
rdpgfx: Implementation for server side channel
akallabeth [Wed, 24 Aug 2016 08:40:31 +0000 (10:40 +0200)]
Merge pull request #3476 from FreeRDP/mh-fix-transport
libfreerdp/core: transport_write unchecked parameters
Martin Haimberger [Mon, 22 Aug 2016 09:17:11 +0000 (02:17 -0700)]
libfreerdp/core: transport_write unchecked parameters
transport_write did not check if transport or bio are
set. The transport read checks it. In using fastpath
and for example a mouse input is sent, the transport
is never checked and can cause a segfault.
zihao.jiang [Sat, 20 Aug 2016 17:02:13 +0000 (01:02 +0800)]
rdpgfx/server: Fix for windows10 clients
1. Fix order of gfx reset and new-surface. Windows10 client will show black screen with this issue(FreeRDP itself is dramatically immune to this issue)
2. Handle RDPGFX_QOE_FRAME_ACKNOWLEDGE_PDU for FPS control
zihao.jiang [Fri, 19 Aug 2016 17:36:37 +0000 (01:36 +0800)]
rdpgfx/server: More minor fix
zihao.jiang [Tue, 16 Aug 2016 06:49:56 +0000 (14:49 +0800)]
rdpgfx/server: More minor fix according to comments:
Not use sizeof on packet memory structure for stream length check/estimating and use number directly.
Most of the packet size could be obviously calculated/verified from code and comments in same function.
Macro is defined for those were referenced multiple times.
zihao.jiang [Thu, 2 Jun 2016 18:33:31 +0000 (02:33 +0800)]
rdpgfx/server: Minor fix: allow configurable codec parameter
zihao.jiang [Sat, 28 May 2016 05:43:33 +0000 (13:43 +0800)]
rdpgfx/server: Minor fix: use switch for pdu length estimation
zihao.jiang [Thu, 26 May 2016 18:11:52 +0000 (02:11 +0800)]
rdpgfx: more minor changes
1. Fix style for channels/rdpgfx/server/rdpgfx_main.c according to scripts/format_code.sh
2. Refactor and introduce APIs to allow rdpgfx server channel running in existing thread (similar to rdpsnd)
zihao.jiang [Tue, 3 May 2016 16:48:59 +0000 (00:48 +0800)]
rdpgfx: various fixes according to comments
1. Fix stream leak in rdpgfx
2. Make src data const in zgfx. Harden zgfx to be independent to byte order
3. Fix written bytes return value in channel write
4. Add check for return value in shadow_client.c
5. Add gfx callback to send surface command with frame marker pdu.
6. Check remain length for recv subroutine
7. Fix compile errors
zihao.jiang [Sat, 23 Apr 2016 17:49:10 +0000 (01:49 +0800)]
rdpgfx: Implementation for server side channel
server/shadow: support h264 codec with gfx channel
Marc-André Moreau [Fri, 22 Jul 2016 13:34:49 +0000 (09:34 -0400)]
Merge pull request #3451 from awakecoding/nla_server_fix
NLA Server Side Improvements
Marc-André Moreau [Fri, 22 Jul 2016 13:06:07 +0000 (09:06 -0400)]
freerdp: make modifications to NLA server-side fixes according to PR comments
Marc-André Moreau [Thu, 21 Jul 2016 22:58:24 +0000 (18:58 -0400)]
freerdp: add configurable NTLM SAM file option for server-side NLA
Marc-André Moreau [Thu, 21 Jul 2016 21:53:20 +0000 (17:53 -0400)]
freerdp: fix sending of TLS alert on NLA failure, add better handling of server-side NLA in shadow server
Marc-André Moreau [Wed, 20 Jul 2016 13:26:04 +0000 (09:26 -0400)]
Merge pull request #3449 from awakecoding/android_toolchain_fix
cmake: fix Android toolchain missing usage of CMAKE_PREFIX_PATH
Marc-André Moreau [Wed, 20 Jul 2016 01:53:23 +0000 (21:53 -0400)]
cmake: fix Android toolchain missing usage of CMAKE_PREFIX_PATH
Bernhard Miklautz [Mon, 18 Jul 2016 12:53:53 +0000 (14:53 +0200)]
Merge pull request #3445 from lanoxx/master
docs: Make doxygen silent
akallabeth [Mon, 18 Jul 2016 11:23:00 +0000 (13:23 +0200)]
Merge pull request #3447 from bmiklautz/package_updates
pkg: update packages
Bernhard Miklautz [Mon, 18 Jul 2016 10:33:44 +0000 (12:33 +0200)]
pkg: update packages
* include wlog man page
Sebastian Geiger [Sun, 17 Jul 2016 20:29:09 +0000 (22:29 +0200)]
docs: Make doxygen silent
Martin Fleisz [Fri, 8 Jul 2016 09:14:25 +0000 (11:14 +0200)]
Merge pull request #3438 from akallabeth/android_build_paths
Fixed android libfreerdp install paths.
Bernhard Miklautz [Thu, 7 Jul 2016 12:41:34 +0000 (12:41 +0000)]
Merge pull request #3436 from akallabeth/openh264_1_6_support
Added support for OpenH264 1.6
akallabeth [Thu, 7 Jul 2016 08:38:51 +0000 (10:38 +0200)]
Merge pull request #3405 from hardening/wlog_man
Add a dedicated man page for wLog
Armin Novak [Wed, 6 Jul 2016 15:21:46 +0000 (17:21 +0200)]
Added gradle.properties to extend heap size.
Armin Novak [Wed, 6 Jul 2016 15:17:39 +0000 (17:17 +0200)]
Fixed android libfreerdp install paths.
Norbert Federa [Wed, 6 Jul 2016 11:58:10 +0000 (13:58 +0200)]
Merge pull request #3384 from akallabeth/android64_build
Android64 build fixes
Armin Novak [Wed, 6 Jul 2016 11:02:35 +0000 (13:02 +0200)]
Updated gradle.
Armin Novak [Wed, 6 Jul 2016 09:59:08 +0000 (11:59 +0200)]
Disabled OpenH264 build for pull request tester.
Armin Novak [Wed, 6 Jul 2016 09:50:53 +0000 (11:50 +0200)]
Using android build-tools 24 (23 is broken)
David Fort [Tue, 5 Jul 2016 13:35:41 +0000 (15:35 +0200)]
Merge pull request #3402 from doughdemon/master
Compile without <sys/queue.h>
David Fort [Tue, 5 Jul 2016 13:15:19 +0000 (15:15 +0200)]
Merge pull request #3433 from akallabeth/wlog_callbac_init_fix
Wlog callback init fix
Armin Novak [Tue, 5 Jul 2016 11:22:28 +0000 (13:22 +0200)]
Proper wLogMessage initialisation.
Armin Novak [Tue, 5 Jul 2016 11:00:54 +0000 (13:00 +0200)]
Initialise WLog PrefixString for each message type.
Armin Novak [Mon, 4 Jul 2016 10:33:52 +0000 (12:33 +0200)]
Added support for OpenH264 1.6
David Fort [Thu, 30 Jun 2016 20:43:05 +0000 (22:43 +0200)]
Merge pull request #3428 from nfedera/fix-getcomputernameex-lentgh-calculation
winpr/sspi/ntlm: fix computer name len calculation
Norbert Federa [Thu, 30 Jun 2016 15:15:40 +0000 (17:15 +0200)]
winpr/sspi/ntlm: fix computer name len calculation
The lpnSize parameter for GetComputerNameEx specifies the total
size of the buffer (in characters).
However, the current code calculated the amount of bytes.
Since only GetComputerNameExA was used and because sizeof(CHAR) == 1
the result was correct but the math was wrong.
Credit goes to @byteboon
Bernhard Miklautz [Mon, 27 Jun 2016 13:28:22 +0000 (15:28 +0200)]
Merge pull request #3426 from nfedera/fix-read-extended-info-packet
protocol violation: rdp_read_extended_info_packet
Norbert Federa [Mon, 27 Jun 2016 08:56:40 +0000 (10:56 +0200)]
protocol violation: rdp_read_extended_info_packet
The clientTimeZone and all subsequent fields in the Extended Info Packet
(MS RDPBCGR 2.2.1.11.1.1.1) are optional but were not handled as such.
Armin Novak [Mon, 27 Jun 2016 08:11:19 +0000 (10:11 +0200)]
Fixed UUID find.
Martin Fleisz [Wed, 22 Jun 2016 13:32:11 +0000 (15:32 +0200)]
Merge pull request #3418 from llyzs/rdpsnd_server_latency
rdpsnd/server: decrease audio latency and make it configurable.
David Fort [Tue, 21 Jun 2016 13:10:09 +0000 (15:10 +0200)]
Add an environment variables section to the man
Vic Lee [Tue, 21 Jun 2016 06:05:29 +0000 (14:05 +0800)]
rdpsnd/server: decrease audio latency and make it configurable.
David Fort [Wed, 15 Jun 2016 20:39:03 +0000 (22:39 +0200)]
man pages needed love
This patch cleans things up so that generated man pages for argument are nicer.
David Fort [Mon, 13 Jun 2016 20:16:36 +0000 (22:16 +0200)]
Add a dedicated man page for wLog
Bernhard Miklautz [Thu, 16 Jun 2016 14:16:37 +0000 (16:16 +0200)]
Merge pull request #3408 from hendwolt/master
fix errors in xdg-shell-xml for protocol creation
Martin Fleisz [Thu, 16 Jun 2016 12:46:27 +0000 (14:46 +0200)]
Merge pull request #3410 from nfedera/fix-symbols
Fix win32 linker hell and more
Norbert Federa [Thu, 16 Jun 2016 09:47:33 +0000 (11:47 +0200)]
winpr: fix win32 linking issues
Depending on the windows target version (_WIN32_WINNT), the used
SDK and the build configuration the linker will see multiple
libraries exporting the same symbols.
To prevent ugly hacks (e.g. modifying cmake's default system
libraries or fragile library linking order chains) we prefix
these functions with "winpr_" and create corresponding defines
to keep the current api names.
Norbert Federa [Wed, 15 Jun 2016 16:01:38 +0000 (18:01 +0200)]
freerdp: remove static inet_ntop
inet_ntop is already implemented in winpr
Norbert Federa [Wed, 15 Jun 2016 11:54:31 +0000 (13:54 +0200)]
cmake: remove some void statements and fix winpr source group
Norbert Federa [Wed, 15 Jun 2016 11:36:27 +0000 (13:36 +0200)]
cmake: replaced STATIC_CHANNELS with BUILTIN_CHANNELS
Norbert Federa [Wed, 15 Jun 2016 11:30:38 +0000 (13:30 +0200)]
channels/audin/client/winmm: requires winpr
Hendrik Woltersdorf [Tue, 14 Jun 2016 18:43:35 +0000 (20:43 +0200)]
fix errors in xdg-shell-xml for protocol creation
Bernhard Miklautz [Tue, 14 Jun 2016 11:57:00 +0000 (13:57 +0200)]
Merge pull request #3407 from nfedera/enable-tests-on-windows
ci: build tests on windows from now on
Norbert Federa [Tue, 14 Jun 2016 10:57:30 +0000 (12:57 +0200)]
ci: build tests on windows from now on
Bernhard Miklautz [Tue, 14 Jun 2016 10:54:01 +0000 (12:54 +0200)]
Merge pull request #3406 from nfedera/fix-winpr-ntlm
winpr/sspi/ntlm: fix GetComputerNameExA parameters
Norbert Federa [Tue, 14 Jun 2016 10:37:37 +0000 (12:37 +0200)]
winpr/sspi/ntlm: fix GetComputerNameExA parameters
On input, the lpnSize [in, out] parameter for GetComputerNameEx()
specifies the total size of the buffer (in characters).
Several functions in ntlm.c were off by one which caused ntlm to fail
if the netbios hostname's strlen was exactly MAX_COMPUTERNAME_LENGTH.
akallabeth [Tue, 14 Jun 2016 08:20:52 +0000 (10:20 +0200)]
Merge pull request #3404 from nfedera/fix-pathmakepath
winpr: fix PathMakePathA and TestWLog
Norbert Federa [Mon, 13 Jun 2016 17:19:28 +0000 (19:19 +0200)]
winpr: fix PathMakePathA and TestWLog
PathMakePathA:
- This function had an endless loop if no native delimiter was in the string
- Use SHCreateDirectoryExA on Windows
- Replaced old code with a new implementation
TestWLog:
- Windows has no "/tmp" by default
- Use GetKnownPath(KNOWN_PATH_TEMP) for the WLog "outputfilepath"
Bernhard Miklautz [Mon, 13 Jun 2016 08:06:51 +0000 (10:06 +0200)]
Merge pull request #3403 from TingPing/freerdp-client.pc
Fix include path in freerdp-client.pc
TingPing [Mon, 13 Jun 2016 02:10:00 +0000 (22:10 -0400)]
Fix include path in freerdp-client.pc
Felix Janda [Sun, 12 Jun 2016 15:54:52 +0000 (17:54 +0200)]
Make iOS workaround iOS specific
Fixes compilation on systems without <sys/queue.h>.
Ondrej Holy [Wed, 8 Jun 2016 09:43:11 +0000 (11:43 +0200)]
winpr/crt: Make TestString endian-independent
Wide char strings use always little endian encoding since commit f722dc5.
Use only strings in little endian to make the tests endian-independent.
Ondrej Holy [Wed, 8 Jun 2016 09:42:27 +0000 (11:42 +0200)]
winpr/crt: Fix endianness in string utils
All WCHAR strings are stored as little endian after commit f722dc5,
therefor WCHAR string utils have to be changed appropriately.
Bernhard Miklautz [Fri, 10 Jun 2016 13:08:49 +0000 (15:08 +0200)]
Merge pull request #3399 from nfedera/fix-winpr-library2
winpr/library: fix GetModuleFileName and tests
Norbert Federa [Fri, 10 Jun 2016 11:10:39 +0000 (13:10 +0200)]
winpr/library: fix GetModuleFileName and tests
- Use correct SetLastError values in GetModuleFileName
- Fix wrong return codes in GetModuleFileName
- Build the TestLibraryA/TestLibraryB libraries always shared and
put them in the test output directory
- TestLibraryGetModuleFileName always returned success
- Improve TestLibraryGetModuleFileName to also check last error values
and insufficient buffer sizes
- Change TestLibraryGetProcAddress and TestLibraryLoadLibrary to load
the TestLibrary from the test executable's directory
Marc-André Moreau [Wed, 8 Jun 2016 15:03:40 +0000 (11:03 -0400)]
Merge pull request #3397 from awakecoding/master
add missing inet_pton implementation on Windows
Marc-André Moreau [Wed, 8 Jun 2016 14:51:58 +0000 (10:51 -0400)]
wayk-now: add missing inet_pton implementation on Windows
Bernhard Miklautz [Wed, 8 Jun 2016 09:50:43 +0000 (11:50 +0200)]
Merge pull request #3393 from nfedera/fix-winpr-library-wtimer-test
winpr: fix some tests
Hardening [Wed, 8 Jun 2016 06:21:13 +0000 (08:21 +0200)]
Merge pull request #3394 from nfedera/fix-client-x11-locked-mutex
client/x11: don't close locked mutex
Norbert Federa [Tue, 7 Jun 2016 16:57:27 +0000 (18:57 +0200)]
client/x11: don't close locked mutex
Norbert Federa [Tue, 7 Jun 2016 15:20:56 +0000 (17:20 +0200)]
winpr: fix some tests
TestNtCreateFile, TestPipeCreateNamedPipeOverlapped
- These tests are currently only expected to succeed on _WIN32
- Also reflect the reverse meaning of this fact in the return values
TestSynchWaitableTimer, TestSynchWaitableTimerAPC:
- These tests are currently expected to fail on __APPLE__
- Also reflect the reverse meaning of this fact in the return values
This logic makes sure that we don't forget to fix the tests if the
corresponding WinPR implementations are fixed.
TestLibrary:
- TestLibraryA and TestLibraryB must always get built as shared libraries
MartinHaimberger [Tue, 7 Jun 2016 13:33:49 +0000 (15:33 +0200)]
Merge pull request #3392 from nfedera/fix-winpr-barrier-deadlock
winpr/synch: fix barrier deadlock in release build
Norbert Federa [Tue, 7 Jun 2016 11:06:50 +0000 (13:06 +0200)]
winpr/synch: fix barrier deadlock in release build
Let the compiler know that we're comparing a volatile value.
Otherwise the compiler might nuke the comparison operation
and produce code that will spin endlessly.
Bernhard Miklautz [Tue, 7 Jun 2016 07:34:12 +0000 (09:34 +0200)]
Merge pull request #3391 from nfedera/fix-initializewaitabletimer-result
winpr/synch: fix InitializeWaitableTimer result
Norbert Federa [Mon, 6 Jun 2016 21:06:12 +0000 (23:06 +0200)]
winpr/synch: fix InitializeWaitableTimer result
InitializeWaitableTimer must not reported success if the operating
sytem does not provide the required functionality.
Norbert Federa [Mon, 6 Jun 2016 14:21:39 +0000 (16:21 +0200)]
Merge pull request #3390 from nfedera/fix-winpr-barrier2
winpr/synch: improve barrier test
Norbert Federa [Mon, 6 Jun 2016 13:33:16 +0000 (15:33 +0200)]
winpr/synch: improve barrier test
The SYNCHRONIZATION_BARRIER_FLAGS_SPIN_ONLY flag caused this test
to run extremely long if the system has very few processors.
Although this is expected (thread starvation) this will cause a
intolerably long execution time for automated tests.
Changed the number of threads to be calculated dyamically based
on the number of processors.
Also do proper cleanup to prevent memory leaks.
Bernhard Miklautz [Mon, 6 Jun 2016 11:54:39 +0000 (13:54 +0200)]
Merge pull request #3388 from nfedera/fix-winpr-pool-synch
winpr: several pool and synch fixes
Bernhard Miklautz [Mon, 6 Jun 2016 11:44:48 +0000 (13:44 +0200)]
Merge pull request #3386 from nfedera/fix-winpr-barrier
winpr/synch: rewrite barrier implementation & test
Bernhard Miklautz [Mon, 6 Jun 2016 11:39:36 +0000 (13:39 +0200)]
Merge pull request #3389 from nfedera/fix-winpr-synch-timer-queue-segfault
winpr/synch: fix timerqueue segfault
Norbert Federa [Mon, 6 Jun 2016 11:18:00 +0000 (13:18 +0200)]
winpr/synch: fix timerqueue segfault
The current experimental/incomplete WinPR timer queue implementation
has several race conditions.
This commit fixes a segfault caused by not unklinking freed timers
from the timer queue timers list.
Armin Novak [Mon, 6 Jun 2016 09:32:25 +0000 (11:32 +0200)]
Updated readme for android.
akallabeth [Mon, 6 Jun 2016 07:23:41 +0000 (09:23 +0200)]
Merge pull request #3387 from nfedera/fix-wfreerdp-verify-cert-callback
wfreerdp: fix invalid VerifyCertificate callback
Norbert Federa [Sat, 4 Jun 2016 15:13:07 +0000 (17:13 +0200)]
wfreerdp: fix invalid VerifyCertificate callback
Norbert Federa [Sat, 4 Jun 2016 15:04:12 +0000 (17:04 +0200)]
winpr: several pool and synch fixes
pool:
- the winpr implementation fallback was not used on older windows editions
- drop useless and conflicting TP_CALLBACK_ENVIRON_V3
- fix race conditions by using use proper one-time initialization
- on win32 WinPR tried to load several pool/callback_environment functions
from kernel32.dll but since these are defined as inline functions in the
windows headers, no windows edition has ever exported them in any dll.
- removed callback_environment.c and added corresponding static inline
function to pool.h
- fix segfault in TestPoolWork: CloseThreadpoolWork() must not be called
if there is a cleanup group associated with the work object since calling
CloseThreadpoolCleanupGroupMember() already releases the work object
sync:
- The windows headers incorrectly define InitializeCriticalEx support if
_WIN32_WINNT >= 0x0403 instead of >= 0x0600 (Vista)
- created a compatible define to deal with this issue
Norbert Federa [Sat, 4 Jun 2016 11:40:01 +0000 (13:40 +0200)]
winpr/synch/barrier: fix return value and test
- According to the msdn docs DeleteSynchronizationBarrier always returns TRUE
- Added additional error checks to the barrier test
Norbert Federa [Fri, 3 Jun 2016 22:55:27 +0000 (00:55 +0200)]
winpr/synch: add spinning support to barrier
Implemented the SYNCHRONIZATION_BARRIER_FLAGS_BLOCK_ONLY and
SYNCHRONIZATION_BARRIER_FLAGS_SPIN_ONLY flags.
Norbert Federa [Fri, 3 Jun 2016 16:56:36 +0000 (18:56 +0200)]
winpr/synch: rewrite barrier implementation & test
The synchronization barrier test as well as the actual WinPR
implementation were completely broken.
Bernhard Miklautz [Fri, 3 Jun 2016 16:53:14 +0000 (18:53 +0200)]
Merge pull request #3381 from nfedera/fix-winpr-misc
fix race conditions, tests and some invalid return values
Armin Novak [Fri, 3 Jun 2016 12:23:06 +0000 (14:23 +0200)]
Fixed defined symbols for function check.
Armin Novak [Fri, 3 Jun 2016 11:02:30 +0000 (13:02 +0200)]
Setting lib64 preference now.
Armin Novak [Fri, 3 Jun 2016 11:02:13 +0000 (13:02 +0200)]
Updated toolchain file, added new variable for lib64 detection.