platform/upstream/libSkiaSharp.git
11 years agofix the android build. now both android_ninja _and_ android_make work.
mtklein@google.com [Mon, 30 Sep 2013 20:58:48 +0000 (20:58 +0000)]
fix the android build.  now both android_ninja _and_ android_make work.

BUG=

Review URL: https://codereview.chromium.org/25319003

git-svn-id: http://skia.googlecode.com/svn/trunk@11542 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoVERBOSE -> SKIA_ANDROID_VERBOSE_SETUP
mtklein@google.com [Mon, 30 Sep 2013 20:53:36 +0000 (20:53 +0000)]
VERBOSE -> SKIA_ANDROID_VERBOSE_SETUP

BUG=
R=borenet@google.com

Review URL: https://codereview.chromium.org/25269008

git-svn-id: http://skia.googlecode.com/svn/trunk@11541 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomake vanilla android_ninja work, and add quiet options
mtklein@google.com [Mon, 30 Sep 2013 20:42:10 +0000 (20:42 +0000)]
make vanilla android_ninja work, and add quiet options

BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/25275006

git-svn-id: http://skia.googlecode.com/svn/trunk@11540 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove uneeded copy of gdbserver from apk
djsollen@google.com [Mon, 30 Sep 2013 20:33:21 +0000 (20:33 +0000)]
Remove uneeded copy of gdbserver from apk

R=mtklein@google.com

Review URL: https://codereview.chromium.org/25336002

git-svn-id: http://skia.googlecode.com/svn/trunk@11539 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReduce max number of textures to 4 to make room for a larger class id in effect key
bsalomon@google.com [Mon, 30 Sep 2013 19:57:15 +0000 (19:57 +0000)]
Reduce max number of textures to 4 to make room for a larger class id in effect key

git-svn-id: http://skia.googlecode.com/svn/trunk@11538 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMark when effects and programs have vertex code
commit-bot@chromium.org [Mon, 30 Sep 2013 19:55:49 +0000 (19:55 +0000)]
Mark when effects and programs have vertex code

Adds a 'hasVertexCode' method to GrEffect and a 'fHasVertexCode' field
to GrGLProgramDesc::KeyHeader. Also adds a GrVertexEffect class that
effects have to inherit from in order to set the 'hasVertexCode' flag
and be able to emit vertex code, and updates the existing effects to
use it as needed.

R=bsalomon@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/23653059

git-svn-id: http://skia.googlecode.com/svn/trunk@11537 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd 3 color variant to gradient bench, include scale in name, add more benchs
commit-bot@chromium.org [Mon, 30 Sep 2013 19:41:09 +0000 (19:41 +0000)]
Add 3 color variant to gradient bench, include scale in name, add more benchs

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/25294003

git-svn-id: http://skia.googlecode.com/svn/trunk@11536 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix Android release builds
mtklein@google.com [Mon, 30 Sep 2013 19:23:05 +0000 (19:23 +0000)]
fix Android release builds

BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/25300005

git-svn-id: http://skia.googlecode.com/svn/trunk@11535 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a GrCustomCoordsTextureEffect class
commit-bot@chromium.org [Mon, 30 Sep 2013 18:41:38 +0000 (18:41 +0000)]
Add a GrCustomCoordsTextureEffect class

Extracts a GrCustomCoordsTextureEffect class from
GrSimpleTextureEffect. This way there are no effects that can
conditionally require a vertex shader. They either always need one or
never do. Also removes kCustom_CoordsType from the CoordsType enum in
GrEffect (that enum is really only meant for coords provided by the
framework), and updates GrSimpleTextureEffect::TestCreate to make the
effect with position as well, instead of just local coords.

R=bsalomon@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/24018007

git-svn-id: http://skia.googlecode.com/svn/trunk@11531 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoquiet down more third-party warnings in poppler and jsoncpp
commit-bot@chromium.org [Mon, 30 Sep 2013 18:19:26 +0000 (18:19 +0000)]
quiet down more third-party warnings in poppler and jsoncpp

BUG=
R=djsollen@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/25319002

git-svn-id: http://skia.googlecode.com/svn/trunk@11530 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove unecessary warnings from third_party code
djsollen@google.com [Mon, 30 Sep 2013 18:06:34 +0000 (18:06 +0000)]
remove unecessary warnings from third_party code

R=mtklein@google.com

Review URL: https://codereview.chromium.org/25030003

git-svn-id: http://skia.googlecode.com/svn/trunk@11529 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd GrSurface::savePixels().
commit-bot@chromium.org [Mon, 30 Sep 2013 18:05:43 +0000 (18:05 +0000)]
Add GrSurface::savePixels().

R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/25021006

git-svn-id: http://skia.googlecode.com/svn/trunk@11528 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd android_ninja, like android_make for ninja.
mtklein@google.com [Mon, 30 Sep 2013 17:32:09 +0000 (17:32 +0000)]
Add android_ninja, like android_make for ninja.

android_ninja {tests,bench,gm,bench_pictures,render_pictures} all build and run
fine.  They build so fast I thought maybe they were broken.

Note that android_ninja with no argument is failing:
    ninja: Entering directory `out/config/android-arm_v7_thumb/Debug'
    ninja: error: 'lib.target/libSampleApp.so', needed by 'android/libs/armeabi-v7a/libSampleApp.so', missing and no known rule to make it
Will look into this.

BUG=
R=djsollen@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11525

Review URL: https://codereview.chromium.org/24833002

git-svn-id: http://skia.googlecode.com/svn/trunk@11527 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Add android_ninja, like android_make for ninja."
mtklein@google.com [Mon, 30 Sep 2013 17:22:48 +0000 (17:22 +0000)]
Revert "Add android_ninja, like android_make for ninja."

Broke some builds.  Will try again.

BUG=

Review URL: https://codereview.chromium.org/25307002

git-svn-id: http://skia.googlecode.com/svn/trunk@11526 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd android_ninja, like android_make for ninja.
mtklein@google.com [Mon, 30 Sep 2013 17:13:58 +0000 (17:13 +0000)]
Add android_ninja, like android_make for ninja.

android_ninja {tests,bench,gm,bench_pictures,render_pictures} all build and run
fine.  They build so fast I thought maybe they were broken.

Note that android_ninja with no argument is failing:
    ninja: Entering directory `out/config/android-arm_v7_thumb/Debug'
    ninja: error: 'lib.target/libSampleApp.so', needed by 'android/libs/armeabi-v7a/libSampleApp.so', missing and no known rule to make it
Will look into this.

BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/24833002

git-svn-id: http://skia.googlecode.com/svn/trunk@11525 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIgnore flaky shadertext2_pdf-poppler tests on Mac-10.7 Release builds
epoger@google.com [Mon, 30 Sep 2013 15:46:50 +0000 (15:46 +0000)]
Ignore flaky shadertext2_pdf-poppler tests on Mac-10.7 Release builds
BUG=skia:1692
TBR=edisonn

Review URL: https://codereview.chromium.org/25287002

git-svn-id: http://skia.googlecode.com/svn/trunk@11524 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove the GL shader compilation step into GrGLShaderBuilder
commit-bot@chromium.org [Mon, 30 Sep 2013 15:30:27 +0000 (15:30 +0000)]
Move the GL shader compilation step into GrGLShaderBuilder

Moves the compilation step and a few other blocks of code from
GrGLProgram to GrGLShaderBuilder. This way GrGLProgram doesn't have to
know whether or not there is a vertex shader.

R=bsalomon@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/23533066

git-svn-id: http://skia.googlecode.com/svn/trunk@11523 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Add a requiresVertexShader method to GrGLEffect"
commit-bot@chromium.org [Mon, 30 Sep 2013 15:13:58 +0000 (15:13 +0000)]
Revert "Add a requiresVertexShader method to GrGLEffect"

This reverts commit 1a30a3af805b7ea688d4a0f0bfe373c204085a27. We're
going to take a different direction for vertexless shaders.

R=bsalomon@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/23464082

git-svn-id: http://skia.googlecode.com/svn/trunk@11521 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoHTTP GM results viewer: server now returns category summaries along with testData
epoger@google.com [Mon, 30 Sep 2013 15:06:25 +0000 (15:06 +0000)]
HTTP GM results viewer: server now returns category summaries along with testData

(SkipBuildbotRuns)

R=borenet@google.com

Review URL: https://codereview.chromium.org/25045003

git-svn-id: http://skia.googlecode.com/svn/trunk@11520 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert temporary r11517
epoger@google.com [Mon, 30 Sep 2013 07:01:55 +0000 (07:01 +0000)]
revert temporary r11517

Review URL: https://codereview.chromium.org/25215002

git-svn-id: http://skia.googlecode.com/svn/trunk@11518 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm: temporarily re-enable multiple rendermodes, to make sure they haven't regressed
epoger@google.com [Mon, 30 Sep 2013 06:29:19 +0000 (06:29 +0000)]
gm: temporarily re-enable multiple rendermodes, to make sure they haven't regressed

Review URL: https://codereview.chromium.org/25213002

git-svn-id: http://skia.googlecode.com/svn/trunk@11517 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMore image rebaselines
robertphillips@google.com [Sun, 29 Sep 2013 17:57:36 +0000 (17:57 +0000)]
More image rebaselines

https://codereview.chromium.org/25184002/

git-svn-id: http://skia.googlecode.com/svn/trunk@11516 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded SK_API to SkPathRef.h
robertphillips@google.com [Sun, 29 Sep 2013 14:48:38 +0000 (14:48 +0000)]
Added SK_API to SkPathRef.h

git-svn-id: http://skia.googlecode.com/svn/trunk@11515 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 28 Sep 2013 07:01:33 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11513 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselining some stragglers
robertphillips@google.com [Fri, 27 Sep 2013 23:18:16 +0000 (23:18 +0000)]
Rebaselining some stragglers

https://codereview.chromium.org/25098008/

git-svn-id: http://skia.googlecode.com/svn/trunk@11512 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoLimit warning message to de-clutter bench output logs
robertphillips@google.com [Fri, 27 Sep 2013 21:53:39 +0000 (21:53 +0000)]
Limit warning message to de-clutter bench output logs

https://codereview.chromium.org/25112002/

git-svn-id: http://skia.googlecode.com/svn/trunk@11511 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline after quadratic-circle approximation change
robertphillips@google.com [Fri, 27 Sep 2013 21:50:21 +0000 (21:50 +0000)]
Rebaseline after quadratic-circle approximation change

https://codereview.chromium.org/25078003/

git-svn-id: http://skia.googlecode.com/svn/trunk@11510 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline inconsequential changes to quadclosepath on N10 msaa4
bsalomon@google.com [Fri, 27 Sep 2013 21:22:45 +0000 (21:22 +0000)]
Rebaseline inconsequential changes to quadclosepath on N10 msaa4

R=epoger@google.com

Review URL: https://codereview.chromium.org/25104003

git-svn-id: http://skia.googlecode.com/svn/trunk@11509 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGrAtlas cleanup: Split out GrPlot and GrAtlas
commit-bot@chromium.org [Fri, 27 Sep 2013 19:39:38 +0000 (19:39 +0000)]
GrAtlas cleanup: Split out GrPlot and GrAtlas

This breaks up GrAtlas into the head of the list (GrAtlas) and the list elements (GrPlot). It also moves all of the GrPlot management code into GrAtlasMgr. It adds a simple pool allocator for GrPlots and removes use of GrPlotMgr.

R=bsalomon@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/24981004

git-svn-id: http://skia.googlecode.com/svn/trunk@11508 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove unlikely-to-be-inlined code from SkPathRef.h to SkPathRef.cpp
robertphillips@google.com [Fri, 27 Sep 2013 17:48:49 +0000 (17:48 +0000)]
Move unlikely-to-be-inlined code from SkPathRef.h to SkPathRef.cpp

https://codereview.chromium.org/24998004/

git-svn-id: http://skia.googlecode.com/svn/trunk@11506 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded two more GMs to the suppressions file
robertphillips@google.com [Fri, 27 Sep 2013 17:36:22 +0000 (17:36 +0000)]
Added two more GMs to the suppressions file

git-svn-id: http://skia.googlecode.com/svn/trunk@11505 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThis CL effectively reverts:
robertphillips@google.com [Fri, 27 Sep 2013 17:05:59 +0000 (17:05 +0000)]
This CL effectively reverts:

r5997 Altered arcTo's canonical points to (usually) be convex (https://codereview.appspot.com/6709051/)
r9928 GM (and fix) for drawArc capping issue (https://codereview.chromium.org/18271003/)

Instead of pushing some of the on-curve points out to attain convexity, this patch pulls all the off curve points in.

R=reed@google.com

Review URL: https://codereview.chromium.org/24810002

git-svn-id: http://skia.googlecode.com/svn/trunk@11504 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding gms for tileimagefilter and offsetimagefilter
sugoi@google.com [Fri, 27 Sep 2013 15:08:53 +0000 (15:08 +0000)]
Adding gms for tileimagefilter and offsetimagefilter

BUG=skia:1684

Review URL: https://codereview.chromium.org/25068002

git-svn-id: http://skia.googlecode.com/svn/trunk@11501 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCreate HTTP-based GM results viewer.
epoger@google.com [Fri, 27 Sep 2013 15:02:44 +0000 (15:02 +0000)]
Create HTTP-based GM results viewer.

For now, it only allows VIEWING results... next, it will allow the user to
rebaseline GM results via the web interface.

R=borenet@google.com

Review URL: https://codereview.chromium.org/24274003

git-svn-id: http://skia.googlecode.com/svn/trunk@11500 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselining xfermodeimagefilter
sugoi@google.com [Fri, 27 Sep 2013 15:00:22 +0000 (15:00 +0000)]
Rebaselining xfermodeimagefilter

Adding new baselines and removing the line in ignore-tests.txt

BUG=
R=bsalomon@google.com, epoger@google.com

Review URL: https://codereview.chromium.org/25062002

git-svn-id: http://skia.googlecode.com/svn/trunk@11499 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix android_run_skia
borenet@google.com [Fri, 27 Sep 2013 14:28:45 +0000 (14:28 +0000)]
Fix android_run_skia

If STATUS_FILENAME doesn't exist, exit 1.

R=djsollen@google.com, jvanverth@google.com

Review URL: https://codereview.chromium.org/24770002

git-svn-id: http://skia.googlecode.com/svn/trunk@11498 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix asan build. Duh, don't return a stack address...
mtklein@google.com [Fri, 27 Sep 2013 13:39:14 +0000 (13:39 +0000)]
Fix asan build.  Duh, don't return a stack address...

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/25026004

git-svn-id: http://skia.googlecode.com/svn/trunk@11497 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline hairline images & remove suppression
robertphillips@google.com [Fri, 27 Sep 2013 13:33:17 +0000 (13:33 +0000)]
Rebaseline hairline images & remove suppression

https://codereview.chromium.org/25045002/

git-svn-id: http://skia.googlecode.com/svn/trunk@11496 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCompiler warning/error fix for Chromium
robertphillips@google.com [Fri, 27 Sep 2013 12:27:27 +0000 (12:27 +0000)]
Compiler warning/error fix for Chromium

git-svn-id: http://skia.googlecode.com/svn/trunk@11494 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 27 Sep 2013 07:01:29 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11493 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger build.
scroggo@google.com [Thu, 26 Sep 2013 22:58:20 +0000 (22:58 +0000)]
Whitespace change to trigger build.

git-svn-id: http://skia.googlecode.com/svn/trunk@11492 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix a warning.
scroggo@google.com [Thu, 26 Sep 2013 21:49:46 +0000 (21:49 +0000)]
Fix a warning.

git-svn-id: http://skia.googlecode.com/svn/trunk@11489 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a buffered SkStream class.
scroggo@google.com [Thu, 26 Sep 2013 21:35:39 +0000 (21:35 +0000)]
Add a buffered SkStream class.

This is used by Android to buffer an input stream which may not
otherwise be able to rewind.

Add a test for the new class.

R=bungeman@google.com, mtklein@google.com, reed@google.com

Review URL: https://codereview.chromium.org/23717055

git-svn-id: http://skia.googlecode.com/svn/trunk@11488 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm: add a flag to force perspective usage in all gms
commit-bot@chromium.org [Thu, 26 Sep 2013 20:44:24 +0000 (20:44 +0000)]
gm: add a flag to force perspective usage in all gms

BUG=
R=reed@google.com, epoger@google.com, borenet@google.com

Author: edisonn@google.com

Review URL: https://chromiumcodereview.appspot.com/23587029

git-svn-id: http://skia.googlecode.com/svn/trunk@11487 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomove GrMalloc, GrFree, Gr_bzero to their sk equivalents
reed@google.com [Thu, 26 Sep 2013 19:56:51 +0000 (19:56 +0000)]
move GrMalloc, GrFree, Gr_bzero to their sk equivalents

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/23566022

git-svn-id: http://skia.googlecode.com/svn/trunk@11486 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd counting to Globals, and refactor some for clarity
reed@google.com [Thu, 26 Sep 2013 19:28:27 +0000 (19:28 +0000)]
add counting to Globals, and refactor some for clarity

BUG=

Review URL: https://codereview.chromium.org/24447003

git-svn-id: http://skia.googlecode.com/svn/trunk@11484 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove uses of unnamed namespace in bench/ directory.
commit-bot@chromium.org [Thu, 26 Sep 2013 19:23:03 +0000 (19:23 +0000)]
Remove uses of unnamed namespace in bench/ directory.

Skia prefers to use static over unnamed namespace.

BUG=None
TEST=None, no functional changes.
R=bsalomon@google.com, robertphillips@google.com

Author: tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/24660003

git-svn-id: http://skia.googlecode.com/svn/trunk@11483 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd SkDivMod with a special case for ARM.
commit-bot@chromium.org [Thu, 26 Sep 2013 19:22:54 +0000 (19:22 +0000)]
Add SkDivMod with a special case for ARM.

BUG=skia:1663
R=djsollen@google.com, tomhudson@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/24159009

git-svn-id: http://skia.googlecode.com/svn/trunk@11482 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCorrecting expectations file
sugoi@google.com [Thu, 26 Sep 2013 17:24:27 +0000 (17:24 +0000)]
Correcting expectations file

git-svn-id: http://skia.googlecode.com/svn/trunk@11479 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespaces
sugoi@google.com [Thu, 26 Sep 2013 17:12:47 +0000 (17:12 +0000)]
Whitespaces

Ignore failing gms

git-svn-id: http://skia.googlecode.com/svn/trunk@11478 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded SkTileImageFilter to SkFlattenable::InitializeFlattenables()
sugoi@google.com [Thu, 26 Sep 2013 17:03:38 +0000 (17:03 +0000)]
Added SkTileImageFilter to SkFlattenable::InitializeFlattenables()

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/24764003

git-svn-id: http://skia.googlecode.com/svn/trunk@11477 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMoving 4 SkImageFilter derived classes from blink to skia
commit-bot@chromium.org [Thu, 26 Sep 2013 16:09:28 +0000 (16:09 +0000)]
Moving 4 SkImageFilter derived classes from blink to skia

There were 4 classes in blink that derived from SkImageFilter :
- TileImageFilter -> SkTileImageFilter
- OffsetImageFilter -> SkOffsetImageFilter (already existed)
- FloodImageFilter -> SkFloodImageFilter
- CompositeImageFilter -> SkCompositeImageFilter

All functions were copied as is, without modification (except for warnings fixes), except for the offset filter, which was merged into the existing SkOffsetImageFilter class, as a special case when a crop rect is provided. Since the names won't clash with the names in blink, it should be easy to integrate them in blink later and fix issues, if needed.

BUG=
R=senorblanco@google.com, senorblanco@chromium.org, bsalomon@google.com, reed@google.com, mtklein@google.com

Author: sugoi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/24157005

git-svn-id: http://skia.googlecode.com/svn/trunk@11475 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGrAtlas refactor: Replace GrMaskFormat usage in GrAtlas with GrPixelConfig.
commit-bot@chromium.org [Thu, 26 Sep 2013 15:28:40 +0000 (15:28 +0000)]
GrAtlas refactor: Replace GrMaskFormat usage in GrAtlas with GrPixelConfig.

This gets the font-specific GrMaskFormat out of GrAtlas and replaces it with
more generic configs, allowing GrAtlas to be used for other things.

R=robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/24751003

git-svn-id: http://skia.googlecode.com/svn/trunk@11474 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoARM Skia NEON patches - 24 - S32_D565_Blend_Dither slight speedup/bugfix
commit-bot@chromium.org [Thu, 26 Sep 2013 15:25:23 +0000 (15:25 +0000)]
ARM Skia NEON patches - 24 - S32_D565_Blend_Dither slight speedup/bugfix

BlitRow565: S32_D565_Blend_Dither, slight speedup + bugfix

This patch adds a rewrite of S32_D565_Blend_Dither in intrinsics.
The newer version is faster (10-20% depending on the value of count)
and also supports ARGB as well as ABGR. It also adds the missing
assert at the beginning of the function.

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/22566002

git-svn-id: http://skia.googlecode.com/svn/trunk@11473 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWe don't flatten or unflatten SkPaintOptionsAndroid. Reproduce and fix.
commit-bot@chromium.org [Thu, 26 Sep 2013 15:16:12 +0000 (15:16 +0000)]
We don't flatten or unflatten SkPaintOptionsAndroid.  Reproduce and fix.

BUG=skia:1625
R=djsollen@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/24075010

git-svn-id: http://skia.googlecode.com/svn/trunk@11472 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIgnore incosistent results of pdf-mac and pdf-poppler renderers, and remove a temp...
edisonn@google.com [Thu, 26 Sep 2013 14:49:02 +0000 (14:49 +0000)]
Ignore incosistent results of pdf-mac and pdf-poppler renderers, and remove a temp file checked in by mistake.

Review URL: https://codereview.chromium.org/24642003

git-svn-id: http://skia.googlecode.com/svn/trunk@11471 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFirst pass at font cache refactor: Create an atlas manager per texture
commit-bot@chromium.org [Thu, 26 Sep 2013 12:57:19 +0000 (12:57 +0000)]
First pass at font cache refactor: Create an atlas manager per texture

This changes the AtlasMgr from a singleton class to one that is
created per-texture. This is the first step in allowing us to create
Atlases of other types (e.g., combine small icons into one big texture).

R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/24608002

git-svn-id: http://skia.googlecode.com/svn/trunk@11468 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove bound and isFinite into pathref
robertphillips@google.com [Thu, 26 Sep 2013 12:18:23 +0000 (12:18 +0000)]
Move bound and isFinite into pathref

https://codereview.chromium.org/24350006/

git-svn-id: http://skia.googlecode.com/svn/trunk@11467 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd GM case for arc truncation error bug
robertphillips@google.com [Thu, 26 Sep 2013 12:05:32 +0000 (12:05 +0000)]
Add GM case for arc truncation error bug

https://codereview.chromium.org/23532082/

git-svn-id: http://skia.googlecode.com/svn/trunk@11466 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 26 Sep 2013 07:01:39 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11465 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd skia_tsan_build to match skia_asan_build and fix one example race.
bungeman@google.com [Wed, 25 Sep 2013 22:39:22 +0000 (22:39 +0000)]
Add skia_tsan_build to match skia_asan_build and fix one example race.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/24644003

git-svn-id: http://skia.googlecode.com/svn/trunk@11464 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix iOS build.
scroggo@google.com [Wed, 25 Sep 2013 22:10:04 +0000 (22:10 +0000)]
Fix iOS build.

More SkStream -> SkStreamRewindable.

git-svn-id: http://skia.googlecode.com/svn/trunk@11463 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix a warning.
scroggo@google.com [Wed, 25 Sep 2013 22:01:17 +0000 (22:01 +0000)]
Fix a warning.

git-svn-id: http://skia.googlecode.com/svn/trunk@11462 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBench baseline for mostly 0 image.
scroggo@google.com [Wed, 25 Sep 2013 21:42:12 +0000 (21:42 +0000)]
Bench baseline for mostly 0 image.

Add a baseline for decoding a mostly 0 image. This is in advance of
https://codereview.chromium.org/24269006/ which provides an option to
skip writing those 0s (as part of BUG=skia:1661). On my Nexus 4, the
benchmark does not slow down after that change.

As suggested in https://codereview.chromium.org/24269006/ add a
resourcePath flag to bench. Will require a change in buildbot in order
to actually use the flag.

Add an image used by the test.

Until https://codereview.chromium.org/24448002 is submitted,
the test will not actually be run by the bots (since it
won't know where to find the file).

BUG=skia:1661
R=djsollen@google.com, mtklein@google.com

Review URL: https://codereview.chromium.org/24440002

git-svn-id: http://skia.googlecode.com/svn/trunk@11461 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange SkImageDecoders to take an SkStreamRewindable.
scroggo@google.com [Wed, 25 Sep 2013 21:34:24 +0000 (21:34 +0000)]
Change SkImageDecoders to take an SkStreamRewindable.

Only affects factories, static functions that will use the factories,
and subset decoding, which all require rewinding. The decoders
themselves continue to take an SkStream. This is merely documentation
stating which functions will possibly rewind the passed in SkStream.

This is part of the general change to coordinate SkStreams with
Android's streams, which don't necessarily support rewinding in all
cases.

Update callers to use SkStreamRewindable.

BUG=skia:1572
R=bungeman@google.com, reed@google.com

Review URL: https://codereview.chromium.org/23477009

git-svn-id: http://skia.googlecode.com/svn/trunk@11460 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPrint a better error message.
scroggo@google.com [Wed, 25 Sep 2013 21:27:31 +0000 (21:27 +0000)]
Print a better error message.

Use format_message to print the proper error message in JPEG decoder.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/24461002

git-svn-id: http://skia.googlecode.com/svn/trunk@11459 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse the default resync_to_restart in jpeg.
scroggo@google.com [Wed, 25 Sep 2013 21:17:41 +0000 (21:17 +0000)]
Use the default resync_to_restart in jpeg.

Our version requires rewinding the stream, which is not always
supported. Instead, depend on jpeg's default version.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/23464068

git-svn-id: http://skia.googlecode.com/svn/trunk@11458 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReplace GR_*_BUILD by their SK_BUILD_FOR_* equivalents.
commit-bot@chromium.org [Wed, 25 Sep 2013 20:57:51 +0000 (20:57 +0000)]
Replace GR_*_BUILD by their SK_BUILD_FOR_* equivalents.

BUG=None
TEST=None, no functional changes.
R=bsalomon@google.com, robertphillips@google.com

Author: tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/24253009

git-svn-id: http://skia.googlecode.com/svn/trunk@11457 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDeletes bench_expectations.txt and change comments to refer to the new per-bot expect...
bensong@google.com [Wed, 25 Sep 2013 20:51:16 +0000 (20:51 +0000)]
Deletes bench_expectations.txt and change comments to refer to the new per-bot expectation files.
Review URL: https://codereview.chromium.org/23830009

git-svn-id: http://skia.googlecode.com/svn/trunk@11456 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRefactor PathTest.cpp test_isNestedRects and test_isRect.
bungeman@google.com [Wed, 25 Sep 2013 18:21:39 +0000 (18:21 +0000)]
Refactor PathTest.cpp test_isNestedRects and test_isRect.

The existing implementations make it difficult to add new tests
and rely on non-local side effects.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/24502004

git-svn-id: http://skia.googlecode.com/svn/trunk@11455 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds.
rmistry@google.com [Wed, 25 Sep 2013 01:01:30 +0000 (01:01 +0000)]
Whitespace change to trigger rebuilds.

git-svn-id: http://skia.googlecode.com/svn/trunk@11452 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse different unique identifier for a fallback family.
djsollen@google.com [Tue, 24 Sep 2013 20:08:47 +0000 (20:08 +0000)]
Use different unique identifier for a fallback family.

BUG=chromium:266412
R=mtklein@google.com, reed@google.com

Review URL: https://codereview.chromium.org/24288002

git-svn-id: http://skia.googlecode.com/svn/trunk@11451 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove obsolete USE_CACHE_HASH
reed@google.com [Tue, 24 Sep 2013 19:59:44 +0000 (19:59 +0000)]
remove obsolete USE_CACHE_HASH

BUG=

Review URL: https://codereview.chromium.org/23526082

git-svn-id: http://skia.googlecode.com/svn/trunk@11450 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGalaxyNexus rebaselines for testimagefilters and imagefilterscropped. (I guess this...
senorblanco@chromium.org [Tue, 24 Sep 2013 17:51:26 +0000 (17:51 +0000)]
GalaxyNexus rebaselines for testimagefilters and imagefilterscropped. (I guess this bot was previously failing before generating GMs?)

TBR=bsalomon

Review URL: https://codereview.chromium.org/23531087

git-svn-id: http://skia.googlecode.com/svn/trunk@11449 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebase gradients[_*_perspective] tests on GN after test change.
bsalomon@google.com [Tue, 24 Sep 2013 14:17:12 +0000 (14:17 +0000)]
rebase gradients[_*_perspective] tests on GN after test change.

R=epoger@google.com

Review URL: https://codereview.chromium.org/23531085

git-svn-id: http://skia.googlecode.com/svn/trunk@11445 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline gradient changes on GN due to test change.
bsalomon@google.com [Mon, 23 Sep 2013 20:00:30 +0000 (20:00 +0000)]
Rebaseline gradient changes on GN due to test change.

R=epoger@google.com

Review URL: https://codereview.chromium.org/24161005

git-svn-id: http://skia.googlecode.com/svn/trunk@11441 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselines -- some stragglers for morphology.
senorblanco@chromium.org [Mon, 23 Sep 2013 17:23:21 +0000 (17:23 +0000)]
Rebaselines -- some stragglers for morphology.

TBR=bungeman

Review URL: https://codereview.chromium.org/23688007

git-svn-id: http://skia.googlecode.com/svn/trunk@11440 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds
rmistry@google.com [Mon, 23 Sep 2013 13:53:46 +0000 (13:53 +0000)]
Whitespace change to trigger rebuilds

git-svn-id: http://skia.googlecode.com/svn/trunk@11438 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds.
rmistry@google.com [Mon, 23 Sep 2013 12:08:20 +0000 (12:08 +0000)]
Whitespace change to trigger rebuilds.

git-svn-id: http://skia.googlecode.com/svn/trunk@11430 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPatch SkImage.h so Chrome will compile
robertphillips@google.com [Sun, 22 Sep 2013 21:57:03 +0000 (21:57 +0000)]
Patch SkImage.h so Chrome will compile

git-svn-id: http://skia.googlecode.com/svn/trunk@11429 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove SK_ENABLE_LEGACY_API_ALIASING from SkImage.h
robertphillips@google.com [Sun, 22 Sep 2013 21:01:28 +0000 (21:01 +0000)]
Remove SK_ENABLE_LEGACY_API_ALIASING from SkImage.h

git-svn-id: http://skia.googlecode.com/svn/trunk@11428 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r11423 (low hanging calloc fruit)
robertphillips@google.com [Sun, 22 Sep 2013 20:18:07 +0000 (20:18 +0000)]
Revert r11423 (low hanging calloc fruit)

git-svn-id: http://skia.googlecode.com/svn/trunk@11427 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 21 Sep 2013 07:01:53 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11426 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMoar rebaselines for testimagefilters and imagefilterscropped.
senorblanco@chromium.org [Fri, 20 Sep 2013 20:24:55 +0000 (20:24 +0000)]
Moar rebaselines for testimagefilters and imagefilterscropped.

TBR=bungeman

Review URL: https://codereview.chromium.org/23749010

git-svn-id: http://skia.googlecode.com/svn/trunk@11425 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse new globally scoped SkAlphaType
reed@google.com [Fri, 20 Sep 2013 20:05:01 +0000 (20:05 +0000)]
use new globally scoped SkAlphaType

git-svn-id: http://skia.googlecode.com/svn/trunk@11424 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agolow hanging calloc fruit
mtklein@google.com [Fri, 20 Sep 2013 19:59:47 +0000 (19:59 +0000)]
low hanging calloc fruit

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/24267014

git-svn-id: http://skia.googlecode.com/svn/trunk@11423 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd trailing quote on #error
reed@google.com [Fri, 20 Sep 2013 19:47:32 +0000 (19:47 +0000)]
add trailing quote on #error

git-svn-id: http://skia.googlecode.com/svn/trunk@11422 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopromote SkImage::AlphaType to SkAlphaType
reed@google.com [Fri, 20 Sep 2013 19:33:52 +0000 (19:33 +0000)]
promote SkImage::AlphaType to SkAlphaType

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/24130009

git-svn-id: http://skia.googlecode.com/svn/trunk@11421 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years ago[PDF] clear() and drawPaint() where applying the initial transform twice.
commit-bot@chromium.org [Fri, 20 Sep 2013 18:58:30 +0000 (18:58 +0000)]
[PDF] clear() and drawPaint() where applying the initial transform twice.

BUG=b/10845219
R=edisonn@google.com, djsollen@google.com

Author: vandebo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/24130010

git-svn-id: http://skia.googlecode.com/svn/trunk@11420 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMap Calibri to Carlito
bungeman@google.com [Fri, 20 Sep 2013 17:41:52 +0000 (17:41 +0000)]
Map Calibri to Carlito

Chrome OS will have Carlito as a metric-compatible replacement for Calibri.

This change has to be combined with a Chrome OS change to add
Calibri and configure fontconfig accordingly.

BUG=280557
TEST=With the CrOS change, a page using Calibri will use Carlito instead of the default fallback font (Arimo in case of English UI).
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23618061

git-svn-id: http://skia.googlecode.com/svn/trunk@11418 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix slight hinting with GDI.
bungeman@google.com [Fri, 20 Sep 2013 17:25:31 +0000 (17:25 +0000)]
Fix slight hinting with GDI.

Sometimes GDI manages to return a different number of points for hinted
and non-hinted outlines. This change handles that case and falls back
to non-hinted. This does not re-enable slight hinting, so there should be
no observable difference in tests. There are still issues with 'D' in
some font/size combinations where 'flips' are used.

git-svn-id: http://skia.googlecode.com/svn/trunk@11417 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoravaseline (pdf and gradients)
edisonn@google.com [Fri, 20 Sep 2013 17:23:56 +0000 (17:23 +0000)]
ravaseline (pdf and gradients)

BUG=

Review URL: https://codereview.chromium.org/23677013

git-svn-id: http://skia.googlecode.com/svn/trunk@11416 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoARM Skia NEON patches - 21 - new NEON S32_D565_Opaque
commit-bot@chromium.org [Fri, 20 Sep 2013 15:38:49 +0000 (15:38 +0000)]
ARM Skia NEON patches - 21 - new NEON S32_D565_Opaque

BlitRow565: NEON version of S32_D565_Opaque

Here's a new implementation of S32_D565_Opaque in NEON. It
improves dramatically the speed compared to S32A_D565_Opaque.

Here are the benchmark results (speedup vs. existing NEON):

+-------+-----------+------------+
| count | Cortex-A9 | Cortex-A15 |
+-------+-----------+------------+
| 1     | +130%     | +139%      |
+-------+-----------+------------+
| 2     | +65,2%    | +51%       |
+-------+-----------+------------+
| 4     | -25,5%    | +10,2%     |
+-------+-----------+------------+
| 8     | +63,8%    | +32,1%     |
+-------+-----------+------------+
| 16    | +110%     | +49,2%     |
+-------+-----------+------------+
| 64    | +153%     | +123,5%    |
+-------+-----------+------------+
| 256   | +151%     | +144,7%    |
+-------+-----------+------------+
| 1024  | +272%     | +157,2%    |
+-------+-----------+------------+

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/22351006

git-svn-id: http://skia.googlecode.com/svn/trunk@11415 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd sk_calloc. Remove SkMemory_stdlib, which seems unused.
mtklein@google.com [Fri, 20 Sep 2013 14:31:45 +0000 (14:31 +0000)]
Add sk_calloc.  Remove SkMemory_stdlib, which seems unused.

I'm seeing basically no difference between malloc + bzero and calloc on my desktop, but on a Galaxy Nexus calloc is never slower, and significantly faster once the allocation size becomes large, both for allocation and for _reading_.

BUG=skia:1662
R=reed@google.com

Review URL: https://codereview.chromium.org/24251008

git-svn-id: http://skia.googlecode.com/svn/trunk@11414 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 20 Sep 2013 07:01:33 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11411 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoYet more testimagefilters and imagefilterscropped rebaselines.
senorblanco@chromium.org [Fri, 20 Sep 2013 01:57:40 +0000 (01:57 +0000)]
Yet more testimagefilters and imagefilterscropped rebaselines.

TBR=bungeman

Review URL: https://codereview.chromium.org/24244007

git-svn-id: http://skia.googlecode.com/svn/trunk@11410 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agosilence the error test to be a better citizen
commit-bot@chromium.org [Thu, 19 Sep 2013 22:11:38 +0000 (22:11 +0000)]
silence the error test to be a better citizen

BUG=
R=caryclark@google.com, bsalomon@google.com, tfarina@chromium.org, mtklein@google.com

Author: humper@google.com

Review URL: https://chromiumcodereview.appspot.com/23481012

git-svn-id: http://skia.googlecode.com/svn/trunk@11409 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for SampleFilterFuzz compiler warning/error
robertphillips@google.com [Thu, 19 Sep 2013 22:02:37 +0000 (22:02 +0000)]
Fix for SampleFilterFuzz compiler warning/error

git-svn-id: http://skia.googlecode.com/svn/trunk@11408 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert ignore-failures changes from r11395, since the tests have been rebaselined.
senorblanco@chromium.org [Thu, 19 Sep 2013 21:25:48 +0000 (21:25 +0000)]
Revert ignore-failures changes from r11395, since the tests have been rebaselined.

TBR=epoger

Review URL: https://codereview.chromium.org/23440054

git-svn-id: http://skia.googlecode.com/svn/trunk@11407 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMore testimagefilters and imagefilterscropped rebaselines.
senorblanco@chromium.org [Thu, 19 Sep 2013 21:06:10 +0000 (21:06 +0000)]
More testimagefilters and imagefilterscropped rebaselines.

TBR=bungeman

Review URL: https://codereview.chromium.org/23503079

git-svn-id: http://skia.googlecode.com/svn/trunk@11406 2bbb7eff-a529-9590-31e7-b0007b416f81