Matthias Braun [Thu, 2 Jun 2022 01:51:35 +0000 (18:51 -0700)]
Fix compilation in gold-plugin triggered by D125847
Siva Chandra Reddy [Wed, 25 May 2022 21:07:23 +0000 (21:07 +0000)]
[libc] Add pthread_create and pthread_join functions.
They do not yet support all the feature/attributes in pthread_attr_t.
Future changes will add such support.
Reviewed By: lntue
Differential Revision: https://reviews.llvm.org/D126718
Joe Loser [Tue, 31 May 2022 00:21:56 +0000 (18:21 -0600)]
[libc++][test] Enable constexpr string comparison tests
Some tests in `string.view.comparison` are not enabled due to previous lack of
support for `constexpr std::string`. Now that it is implemented, we can enable
these tests.
Differential Revision: https://reviews.llvm.org/D126737
Chris Bieneman [Thu, 2 Jun 2022 01:18:41 +0000 (20:18 -0500)]
Fix DXContainer test on ppcbe
Silly mistake, the code here was byteswapping in-place which corrupts
the data structure that is used later to write the correct file.
Alexander Yermolovich [Thu, 2 Jun 2022 01:15:41 +0000 (18:15 -0700)]
[BOLT][DWARF] Fix TU Index handling for DWARF4/5
When we generate split dwarf with -fdebug-types-section we will have
.debug_types.dwo sections. These go into TU Index when we run llvm-dwp. BOLT was
not handling DWP input correctly with this section.
Added support for handling DWP with TU Index as an input and output for DWARF4.
Added support for handling DWP with TU Index as an input for DWARF5
Reviewed By: maksfb
Differential Revision: https://reviews.llvm.org/D126087
Matt Arsenault [Fri, 22 Apr 2022 23:15:58 +0000 (19:15 -0400)]
BranchFolder: Require NoPHIs
The pass doesn't handle SSA and breaks any phis.
Matt Arsenault [Wed, 4 May 2022 12:12:51 +0000 (13:12 +0100)]
AMDGPU: Add release notes about atomic load and store
Matt Arsenault [Wed, 18 May 2022 15:00:41 +0000 (16:00 +0100)]
AMDGPU: Fix missing c++ mode comment
Matthias Braun [Wed, 18 May 2022 03:33:22 +0000 (20:33 -0700)]
LTO: Decide upfront whether to use opaque/non-opaque pointer types
LTO code may end up mixing bitcode files from various sources varying in
their use of opaque pointer types. The current strategy to decide
between opaque / typed pointers upon the first bitcode file loaded does
not work here, since we could be loading a non-opaque bitcode file first
and would then be unable to load any files with opaque pointer types
later.
So for LTO this:
- Adds an `lto::Config::OpaquePointer` option and enforces an upfront
decision between the two modes.
- Adds `-opaque-pointers`/`-no-opaque-pointers` options to the gold
plugin; disabled by default.
- `--opaque-pointers`/`--no-opaque-pointers` options with
`-plugin-opt=-opaque-pointers`/`-plugin-opt=-no-opaque-pointers`
aliases to lld; disabled by default.
- Adds an `-lto-opaque-pointers` option to the `llvm-lto2` tool.
- Changes the clang driver to pass `-plugin-opt=-opaque-pointers` to
the linker in LTO modes when clang was configured with opaque
pointers enabled by default.
This fixes https://github.com/llvm/llvm-project/issues/55377
Differential Revision: https://reviews.llvm.org/D125847
Hendrik Greving [Thu, 2 Jun 2022 00:46:50 +0000 (00:46 +0000)]
[ValueTypes] Define MVTs for v128i2/v64i4 as well as i2 and i4.
Adds MVT::v128i2, MVT::v64i4, and implied MVT::i2, MVT::i4.
Keeps MVT::i2, MVT::i4 lowering actions as expand, which should be
removed once targets set this explicitly.
Adjusts 11 lit tests to reflect slightly different behavior during
DAG combine.
Differential Revision: https://reviews.llvm.org/D125247
Fangrui Song [Thu, 2 Jun 2022 00:33:14 +0000 (17:33 -0700)]
[Polly] Fix -Wreorder-ctor. NFC
Quentin Colombet [Thu, 2 Jun 2022 00:14:03 +0000 (17:14 -0700)]
[RegisterClassInfo] Invalidate cached information if ignoreCSRForAllocationOrder changes
Even if CSR list is same between functions, we could have had a different
allocation order if ignoreCSRForAllocationOrder is evaluated differently.
Hence invalidate cached register class information if
ignoreCSRForAllocationOrder changes.
Patch by Srividya Karumuri <srividya_karumuri@apple.com>
Differential Revision: https://reviews.llvm.org/D126565
Fangrui Song [Thu, 2 Jun 2022 00:04:58 +0000 (17:04 -0700)]
[Object] Fix namespace style issues in D122069
https://llvm.org/docs/CodingStandards.html#use-namespace-qualifiers-to-implement-previously-declared-functions
Shilei Tian [Wed, 1 Jun 2022 23:53:36 +0000 (19:53 -0400)]
[OMPIRBuilder] Add the support for compare capture
This patch adds the support for `compare capture` in `OMPIRBuilder`.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D120007
Philip Reames [Wed, 1 Jun 2022 23:08:19 +0000 (16:08 -0700)]
[RISCV] Split fixed-vector-strided-load-store.ll so it can be autogened
I've gotten tired of updating register allocation changes by hand, let's just autogen this even if we have to duplicate it.
Alexey Bataev [Wed, 1 Jun 2022 22:40:00 +0000 (15:40 -0700)]
Revert "[SLP]Improve shuffles cost estimation where possible."
This reverts commit
fd5a6ce9dcb77b7821c95355d73af0b3b2020647 to fix
a crash detected by a buildbot
https://lab.llvm.org/buildbot/#/builders/179/builds/3805/steps/11/logs/stdio.
Joseph Huber [Wed, 1 Jun 2022 19:28:34 +0000 (15:28 -0400)]
[Binary] Promote OffloadBinary to inherit from Binary
We use the `OffloadBinary` to create binary images of offloading files
and their corresonding metadata. This patch changes this to inherit from
the base `Binary` class. This allows us to create and insepect these
more generically. This patch includes all the necessary glue to
implement this as a new binary format, along with added the magic bytes
we use to distinguish the offloading binary to the `file_magic`
implementation.
Reviewed By: tra
Differential Revision: https://reviews.llvm.org/D126812
Craig Topper [Wed, 1 Jun 2022 22:37:48 +0000 (15:37 -0700)]
[RISCV] Use MachineRegisterInfo::use_instr_begin instead of use_begin+getParent. NFCI
David Tenty [Tue, 10 May 2022 15:39:58 +0000 (11:39 -0400)]
[clang][AIX] add option mdefault-visibility-export-mapping
The option mdefault-visibility-export-mapping is created to allow
mapping default visibility to an explicit shared library export
(e.g. dllexport). Exactly how and if this is manifested is target
dependent (since it depends on how they map dllexport in the IR).
Three values are provided for the option:
* none: the default and behavior without the option, no additional export linkage information is created.
* explicit: add the export for entities with explict default visibility from the source, including RTTI
* all: add the export for all entities with default visibility
This option is useful for targets which do not export symbols as part of
their usual default linkage behaviour (e.g. AIX), such targets
traditionally specified such information in external files (e.g. export
lists), but this mapping allows them to use the visibility information
typically used for this purpose on other (e.g. ELF) platforms.
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D126340
Matthias Springer [Wed, 1 Jun 2022 21:59:58 +0000 (23:59 +0200)]
[mlir][sparse][NFC] Switch InitOp to bufferization::AllocTensorOp
Now that we have an AllocTensorOp (previously InitTensorOp) in the bufferization dialect, the InitOp in the sparse dialect is no longer needed.
Differential Revision: https://reviews.llvm.org/D126180
Chris Bieneman [Wed, 1 Jun 2022 21:45:49 +0000 (16:45 -0500)]
Temporarily disabling this test on arm
This is failing on an arm32 builder, and it is going to take me a while
to debug. To not block further progress I'm disabling this test on
arm32 configuraitons.
wren romano [Tue, 31 May 2022 22:26:52 +0000 (15:26 -0700)]
[mlir][sparse] Using non-empty function name suffix for OverheadType::kIndex
The trick of using an empty token in the `FOREVERY_O` x-macro relies on preprocessor behavior which is only standard since C99 6.10.3/4 and C++11 N3290 16.3/4 (whereas it was undefined behavior up through C++03 16.3/10). Since the `ExecutionEngine/SparseTensorUtils.cpp` file is required to be compile-able under C++98 compatibility mode (unlike the C++11 used elsewhere in MLIR), we shouldn't rely on that behavior.
Also, using a non-empty suffix helps improve uniformity of the API, since all other primary/overhead suffixes are also non-empty. I'm using the suffix `0` since that's the value used by the `SparseTensorEncoding` attribute for indicating the index overhead-type.
Depends On D126720
Reviewed By: aartbik
Differential Revision: https://reviews.llvm.org/D126724
Florian Hahn [Wed, 1 Jun 2022 21:11:06 +0000 (22:11 +0100)]
[LV] Update var name to Exiting, in line with terminology (NFC)
Recently the terminology used has been changed from Exit->Exiting in
line with common LLVM loop terminology. Update a remaining use of the
old terminology.
Huan Nguyen [Wed, 1 Jun 2022 20:59:28 +0000 (13:59 -0700)]
[BOLT][TEST] Replace cache+ option with ext-tsp
Replace "cache+" with "ext-tsp" in all BOLT tests
Test Plan:
```
ninja check-bolt
grep -rnw . -e "cache+"
```
no more tests containing "cache+"
"cache+" and "ext-tsp" are aliases
Reviewed By: rafauler
Differential Revision: https://reviews.llvm.org/D126714
Nicolai Hähnle [Tue, 24 May 2022 23:57:14 +0000 (01:57 +0200)]
update_mir_test_checks: Better handling of common prefixes
Support the pattern where a test file uses multiple prefixes per run line:
one prefix that is unique to the run line, and additional prefixes that are
common with other run lines.
Decide on a per-function basis which prefix(es) to emit, based on which run
lines have the same output.
Move the renaming of vregs earlier, so that we can compare the output as it
would actually be printed in check lines.
Differential Revision: https://reviews.llvm.org/D126411
Benjamin Kramer [Wed, 1 Jun 2022 20:49:34 +0000 (22:49 +0200)]
[bazel] Add a missing dependency after
f3bdb56d61e3
Chris Bieneman [Wed, 1 Jun 2022 20:50:20 +0000 (15:50 -0500)]
Temporarily disabling this test on arm
This is failing on an arm32 builder, and it is going to take me a while
to debug. To not block further progress I'm disabling this test on
arm32 configuraitons.
Peter Klausler [Wed, 1 Jun 2022 18:05:55 +0000 (11:05 -0700)]
[flang][NFC] Document intentional non-support for an extension
F18 doesn't accept INTEGER operands to the intrinsic LOGICAL operations;
some compilers do. This usage is not portable, and not just because it's
non-conforming -- the bit representations of LOGICAL also vary between
compilers and options. The "MIL-STD" bit intrinsics IAND() & al. have been
avaiable since the late 70's and should be used instead.
Differential Revision: https://reviews.llvm.org/D126798
Maksim Panchenko [Wed, 1 Jun 2022 19:29:34 +0000 (12:29 -0700)]
[BOLT][NFC] Remove unused variable
Reviewed By: Amir
Differential Revision: https://reviews.llvm.org/D126808
LLVM GN Syncbot [Wed, 1 Jun 2022 20:34:21 +0000 (20:34 +0000)]
[gn build] Port
129c056d6269
Chris Bieneman [Wed, 1 Jun 2022 14:10:28 +0000 (09:10 -0500)]
[ObjectYAML][DX] Support yaml2dxcontainer
This patch adds a the first bits of support for a yaml representation
of dxcontainer files.
Since the YAML representation's primary purpose is testing
infrastructure, the yaml representation supports both verbose and a
more friendly format by making computable sizes and offsets optional.
If provided they are validated to be correct, otherwise they are
computed on the fly during emission.
As I expand the format I'll be able to make more size fields optional,
and I will continue to make the format easier to work with.
Depends on D124804
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D124944
Paul Robinson [Wed, 1 Jun 2022 18:02:10 +0000 (11:02 -0700)]
[PS5] Add PS5OSTargetInfo class, update affected tests
Paul Robinson [Wed, 1 Jun 2022 15:53:26 +0000 (08:53 -0700)]
Refactor PS4OSTargetInfo into a base class and PS4 subclass; prep for PS5
Hendrik Greving [Wed, 1 Jun 2022 20:26:34 +0000 (13:26 -0700)]
Revert "[ValueTypes] Define MVTs for v128i2/v64i4 as well as i2 and i4."
This reverts commit
430ac5c3029c52e391e584c6d4447e6e361fae99.
Due to failures in Clang tests.
Differential Revision: https://reviews.llvm.org/D125247
Florian Hahn [Wed, 1 Jun 2022 20:19:03 +0000 (21:19 +0100)]
[LV] Add additional tests for pointer select support.
Additional test cases for D114487.
Chris Bieneman [Mon, 2 May 2022 23:09:36 +0000 (18:09 -0500)]
[Object][DX] Parse DXContainer Parts
DXContainer files are structured as parts. This patch adds support for
parsing out the file part offsets and file part headers.
Reviewed By: kuhar
Differential Revision: https://reviews.llvm.org/D124804
Hendrik Greving [Fri, 6 May 2022 23:02:31 +0000 (16:02 -0700)]
[ValueTypes] Define MVTs for v128i2/v64i4 as well as i2 and i4.
Adds MVT::v128i2, MVT::v64i4, and implied MVT::i2, MVT::i4.
Keeps MVT::i2, MVT::i4 lowering actions as `expand`, which should be
removed once targets set this explicitly.
Adjusts 11 lit tests to reflect slightly different behavior during
DAG combine.
Differential Revision: https://reviews.llvm.org/D125247
Adrian Prantl [Wed, 1 Jun 2022 19:10:39 +0000 (12:10 -0700)]
Revert "[Driver] Enable to use C++20 standalne by -fcxx-modules"
This reverts commit
a544710cd43ba9f7729a613c58729f146e792a8e.
See discussion in D120540.
This breaks C++ Clang modules on Darwin and also more than a dozen
tests in the LLDB testsuite. I think we need to be more careful to
separate out the enabling of Clang C++ modules and C++20
modules. Either by having -fmodules-ts control the HaveModules flag,
or by adding a way to explicitly turn them off.
Adrian Prantl [Wed, 1 Jun 2022 19:10:30 +0000 (12:10 -0700)]
Revert "[NFC] Use %clang instead of %clang++ in tests"
This reverts commit
738c20e6df01217b6364c3b75d0ced6b6fb6277e as a dependency of D120540.
Adrian Prantl [Wed, 1 Jun 2022 19:10:12 +0000 (12:10 -0700)]
Revert "[Driver][Modules] Remove dependence on linking support from clang/test/Driver/modules.cpp"
This reverts commit
35b1cfc76f08faabf3f27c0bd054acc7c854a6ca as a dependency of D120540.
Mark de Wever [Sat, 14 May 2022 16:03:42 +0000 (18:03 +0200)]
[NFC][libc++][format] Improves naming.
Based on review comments in D110499.
Depends on D110499
Reviewed By: ldionne, #libc
Differential Revision: https://reviews.llvm.org/D125610
Nico Weber [Wed, 1 Jun 2022 18:53:08 +0000 (14:53 -0400)]
[lld/mac] clang-format after
f5709066e3b
Michael Eisel [Wed, 1 Jun 2022 18:49:19 +0000 (14:49 -0400)]
[lld/mac] Cache file IDs of symbols in emitStabs for faster sorting
This reduces the time emitStabs() takes by about 275ms, or 3% of overall
linking time for the project I'm on. Although the parent function is run in
parallel, it's one of the slowest tasks in that concurrent batch (I have
another optimization for another slow task as well).
Differential Revision: https://reviews.llvm.org/D126785
Rob Suderman [Wed, 1 Jun 2022 18:35:26 +0000 (11:35 -0700)]
[mlir][math] Add math.ctlz expansion to control flow + arith operations
Ctlz is an intrinsic in LLVM but does not have equivalent operations in SPIR-V.
Including a decomposition gives an alternative path for these platforms.
Reviewed By: NatashaKnk
Differential Revision: https://reviews.llvm.org/D126261
Yang Keao [Wed, 1 Jun 2022 18:09:58 +0000 (13:09 -0500)]
[Polly] Migrate -polly-mse to the new pass manager.
This patch implements the `MaximalStaticExpansion` and its printer in NPM.
Reviewed By: Meinersbur
Differential Revision: https://reviews.llvm.org/D125870
Nathaniel McVicar [Wed, 1 Jun 2022 18:33:56 +0000 (11:33 -0700)]
[ccache] Add Windows support
Windows builds can't receive environment variables on the command line or make use of RULE_LAUNCH_COMPILE with ccache.
Reviewed By: stella.stamenova, Ericson2314
Differential Revision: https://reviews.llvm.org/D126575
Stella Laurenzo [Tue, 31 May 2022 20:46:06 +0000 (13:46 -0700)]
[mlir] Add global_load and global_store ops to ml_program.
* Adds simple, non-atomic, non-volatile, non-synchronized direct load/store ops.
Differential Revision: https://reviews.llvm.org/D126230
Aaron Ballman [Wed, 1 Jun 2022 18:22:24 +0000 (14:22 -0400)]
Fix an incorrect bit-width for storing attribute syntax information
This field corresponds to the Syntax enumeration, and that gained
another entry in
1fdf952deeb9a02aa34794af3c1a7d13a30e068e. However,
the bit-field for storing the syntax used was not adjusted to handle
the extra field.
This turns out to be unobservable for HLSL attributes at the moment, so
there is no test coverage. But it's also not really an NFC change
either.
Alexander Belyaev [Wed, 1 Jun 2022 18:12:23 +0000 (20:12 +0200)]
[mlir] Add conversion and tests for complex.[sqrt|atan2] to Arith.
Differential Revision: https://reviews.llvm.org/D126799
Anders Waldenborg [Fri, 27 May 2022 23:21:16 +0000 (01:21 +0200)]
[clang] Add tests for (const) weak variables
This adds tests checking the behavior of const variables declared with
weak attribute.
Both checking that they can not be used in places where a constant
expression is required and that a dynamic initializer is emitted when
used as an initializer expression.
Differential Revision: https://reviews.llvm.org/D126578
bixia1 [Tue, 31 May 2022 23:17:45 +0000 (16:17 -0700)]
[mlir][sparse] Enable the test for operator expm1.
Reviewed By: aartbik
Differential Revision: https://reviews.llvm.org/D126732
Stanislav Mekhanoshin [Wed, 1 Jun 2022 17:44:19 +0000 (10:44 -0700)]
[AMDGPU] Change GISel error handling for TFE on GFX90A
Differential Revision: https://reviews.llvm.org/D126797
Alexey Bataev [Thu, 9 Dec 2021 18:34:08 +0000 (10:34 -0800)]
[SLP]Improve shuffles cost estimation where possible.
Improved/fixed cost modeling for shuffles by providing masks, improved
cost model for non-identity insertelements.
Differential Revision: https://reviews.llvm.org/D115462
Andrew Browne [Wed, 25 May 2022 22:40:01 +0000 (15:40 -0700)]
[DFSan] Remove deprecated flag from build-libc-list.py
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D126429
Siva Chandra Reddy [Fri, 27 May 2022 05:25:36 +0000 (05:25 +0000)]
[libc] Keep all thread state information separate from the thread structure.
The state is now stored on the thread's stack memory. This enables
implementing pthread API like pthread_detach which takes the pthread_t
structure argument by value.
Reviewed By: lntue
Differential Revision: https://reviews.llvm.org/D126716
Adrian Prantl [Wed, 1 Jun 2022 17:33:25 +0000 (10:33 -0700)]
Revert "Adapt LLDB for D120540."
This reverts commit
ca73de43744503a557b1f3709c0ff4751798702f.
That patch was just hiding the problem, instead of fixing it.
Joseph Huber [Mon, 9 May 2022 18:26:01 +0000 (14:26 -0400)]
[Libomptarget] Add basic support for dynamic shared memory on AMDGPU
This patchs adds the arguments necessary to allocate the size of the
dynamic shared memory via the `LIBOMPTARGET_SHARED_MEMORY_SIZE`
environment variable. This patch only allocates the memory, AMDGPU has a
limitation that shared memory can only be accessed from the kernel
directly. So this will currently only work with optimizations to inline
the accessor function.
Reviewed By: JonChesterfield
Differential Revision: https://reviews.llvm.org/D125252
Yi Kong [Wed, 1 Jun 2022 15:53:59 +0000 (23:53 +0800)]
[BOLT] Add `-o` option to merge-fdata
Differential Revision: https://reviews.llvm.org/D126788
Fangrui Song [Wed, 1 Jun 2022 17:28:14 +0000 (10:28 -0700)]
ar_to_bc.sh: Ignore non-bitcode files in archives
The script uses llvm-link to link LLVM bitcode files.
5426da8ffa4a6d55adab21026ce6ebe8f1cc6ef2 used -DLLVM_DISABLE_ASSEMBLY_FILES=ON
to ignore object files compiled from lib/Support/BLAKE3/*.S.
A better approach (which fits Bazel better) is to ignore non-bitcode files.
Reviewed By: akyrtzi
Differential Revision: https://reviews.llvm.org/D126728
Nico Weber [Tue, 31 May 2022 19:46:12 +0000 (15:46 -0400)]
sanitizers: Do not include crypt.h if SANITIZER_INTERCEPT_CRYPT_R is undef
sanitizer_intercept_overriders.h might override SANITIZER_INTERCEPT_CRYPT_R to
be undefined. There's no need to require crypt.h in that case.
(The motivation is that crypt() moved from glibc into its own package at some
point, which makes intercepting it and building with a single sysroot that
supports both pre-bullseye and post-bullseye a bit hairy.)
Differential Revision: https://reviews.llvm.org/D126696
Aart Bik [Thu, 26 May 2022 22:17:31 +0000 (15:17 -0700)]
[mlir][python][ctypes] fix ctype python binding complication for complex
There is no direct ctypes for MLIR's complex (and thus np.complex128
and np.complex64) yet, causing the mlir python binding methods for
memrefs to crash. This revision fixes this by passing complex arrays
as tuples of floats, correcting at the boundaries for the proper view.
NOTE: some of these changes (4 -> 2) were forced by the new "linting"
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D126422
Brooks Davis [Wed, 1 Jun 2022 16:56:37 +0000 (12:56 -0400)]
compiler-rt: Allow build without __c11_atomic_fetch_nand
Don't build atomic fetch nand libcall functions when the required
compiler builtin isn't available. Without this compiler-rt can't be
built with LLVM 13 or earlier.
Not building the libcall functions isn't optimal, but aligns with the
usecase in FreeBSD where compiler-rt from LLVM 14 is built with an LLVM
13 clang and no LLVM 14 clang is built.
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D126710
Balazs Benics [Wed, 1 Jun 2022 16:53:19 +0000 (18:53 +0200)]
[analyzer][NFC] Add test for
3a07280290564e294c957c94c918a6680714b417
I'm adding a test demonstraing that the issue reported by @mikaelholmen
is fixed.
Differential Revision: https://reviews.llvm.org/D126198
Alexey Bataev [Tue, 31 May 2022 20:51:27 +0000 (13:51 -0700)]
[SLP]Fix PR55796: insert point for extractelements from different basic blocks.
Extractelement instructions may come from different basic blocks, need
to take it into account when looking for a last instruction in the
bundle to prevent compiler crash.
Differential Revision: https://reviews.llvm.org/D126777
Stephen Long [Wed, 1 Jun 2022 16:39:32 +0000 (09:39 -0700)]
[MSVC] Fix pragma alloc_text failing for C files
`isExternCContext()` is returning false for functions in C files
Reviewed By: rnk, aaron.ballman
Differential Revision: https://reviews.llvm.org/D126559
Simon Pilgrim [Wed, 1 Jun 2022 16:39:07 +0000 (17:39 +0100)]
[Hexagon] Regenerate store-imm-amode.ll
Simon Pilgrim [Wed, 1 Jun 2022 15:29:05 +0000 (16:29 +0100)]
[AMDGPU] Regenerate fabs.f16.ll tests
Scott Linder [Wed, 25 May 2022 17:17:53 +0000 (17:17 +0000)]
[AMDGPU][NFC] Refactor AMDGPUCallingConv.td
Rename CalleeSavedRegs defs to avoid being overly specific:
* CSR_AMDGPU_AGPRs_32_255 => CSR_AMDGPU_AGPRs
* CSR_AMDGPU_SGPRs_30_31 + CSR_AMDGPU_SGPRs_32_105 => CSR_AMDGPU_SGPRs
* CSR_AMDGPU_SI_Gfx_SGPRs_4_29 + CSR_AMDGPU_SI_Gfx_SGPRs_64_105 =>
CSR_AMDGPU_SI_Gfx_SGPRs
* CSR_AMDGPU_HighRegs => CSR_AMDGPU
* CSR_AMDGPU_HighRegs_With_AGPRs => CSR_AMDGPU_GFX90AInsts
* CSR_AMDGPU_SI_Gfx_With_AGPRs => CSR_AMDGPU_SI_Gfx_GFX90AInsts
Introduce a class RegMask to mark the cases where we use the
CalleeSavedRegs class purely as an expedient way to produce a mask.
Update the names of these masks to not mention "CSR". Other targets also
seem to do this, so a reasonable alternative is to actually update
table-gen to include a new class to do this explicitly, but the current
approach seems harmless so I opted to just make it more explicit.
Reviewed By: arsenm, sebastian-ne
Differential Revision: https://reviews.llvm.org/D109008
Mats Petersson [Mon, 17 Jan 2022 13:54:09 +0000 (13:54 +0000)]
[flang][OpenMP]Make omp.wsloop arguments appear in memory (#1277)
As per issue #1196, the loop induction variable, which is an argument
in the omp.wsloop operation, does not have a memory location, so when
passed to a function or subroutine, the reference to the value is not
a memory location, but the value of the induction variable. The callee
function/subroutine is then trying to dereference memory at address 1
or some other "not a good memory location".
This is fixed by creating a temporary memory location and storing the
value of the induction variable in that.
Test fixes as a consequence of the changed code generated.
Add checking for some of the omp-unstructured.f90 to check for alloca,
store and load operations, to ensure the correct flow. Add a test
for CYCLE inside a omp-do loop.
Also convert to use -emit-fir in the omp-unstructrued, and make
the symbol matching consistent in the omp-wsloop-variable test.
Reviewed By: peixin
Differential Revision: https://reviews.llvm.org/D126711
Matthias Braun [Tue, 31 May 2022 23:49:24 +0000 (16:49 -0700)]
TensorFlowCompile: Add object file to list of sources rather than LINK_LIBS
Differential Revision: https://reviews.llvm.org/D126736
Arjun P [Tue, 31 May 2022 17:17:46 +0000 (18:17 +0100)]
[MLIR][Presburger] Simplex: remove redundant zeroing out of row
This fillRow(..., 0) is redundant because when the size of the tableau is
consistent, the resize always creates a new row, which is zero-initialized.
Also added asserts throughout to ensure the dimensions of the tableau remain
consistent.
Reviewed By: Groverkss
Differential Revision: https://reviews.llvm.org/D126709
Arjun P [Wed, 1 Jun 2022 15:53:51 +0000 (16:53 +0100)]
[MLIR][Presburger] Matrix: inline trivial accessors
This resolves a comment from https://reviews.llvm.org/D126708
that was previously missed.
Arjun P [Tue, 31 May 2022 16:48:05 +0000 (17:48 +0100)]
[MLIR][Presburger] Move Matrix accessors inline
This gives a 1.5x speedup on the Presburger unittests.
Reviewed By: Groverkss
Differential Revision: https://reviews.llvm.org/D126708
Mark de Wever [Mon, 30 May 2022 16:22:00 +0000 (18:22 +0200)]
[libc++][format] Fixes string-literal formatting.
Formatting a string-literal had an off-by-one issue where the NUL
terminator became part of the formatted output.
Reviewed By: #libc, ldionne
Differential Revision: https://reviews.llvm.org/D126665
PeixinQiao [Wed, 1 Jun 2022 15:42:07 +0000 (23:42 +0800)]
[NFC][MLIR] Fix -Wtype-limits warning
Fix the warning: comparison of unsigned expression in ‘>= 0’ is always
true.
Reviewed By: kiranchandramohan, shraiysh
Differential Revision: https://reviews.llvm.org/D126784
Mital Ashok [Wed, 1 Jun 2022 15:34:40 +0000 (11:34 -0400)]
Fix std::has_unique_object_representations for _BitInt types with padding bits
"std::has_unique_object_representations<_BitInt(N)>" was always true,
even if the type has padding bits (since the trait assumes all integer
types have no padding bits). The standard has an explicit note that
this should not hold for types with padding bits.
Differential Revision: https://reviews.llvm.org/D125802
Luke Nihlen [Wed, 1 Jun 2022 15:29:48 +0000 (11:29 -0400)]
Expand definition deprecation warning to include constexpr statements.
Clang currently warns on definitions downgraded to declarations
with a const modifier, but not for a constexpr modifier. This patch
updates the warning logic to warn on both inputs, and adds a test to
check the additional case as well.
See also: https://bugs.chromium.org/p/chromium/issues/detail?id=1284718
Differential Revision: https://reviews.llvm.org/D126664
Craig Topper [Wed, 1 Jun 2022 15:13:49 +0000 (08:13 -0700)]
[RISCV] Fix i64<->f64 and i32<->f32 bitcasts with VLS vectors enabled.
We enable a custom handler to optimize conversions between scalars
and fixed vectors. Unfortunately, the custom handler picks up scalar
to scalar conversions as well. If the scalar types are both legal,
we wouldn't match any of the fixed vector cases and would return SDValue()
causing the LegalizeDAG to expand the bitcast through memory.
This patch fixes this by checking if it's a scalar to scalar conversion
and returns `Op` if both types are legal.
Differential Revision: https://reviews.llvm.org/D126739
PeixinQiao [Wed, 1 Jun 2022 14:40:51 +0000 (22:40 +0800)]
[flang] Add semantic checks for threadprivate and declare target directives
This patch supports the following checks:
```
[5.1] 2.21.2 THREADPRIVATE Directive
The threadprivate directive must appear in the declaration section of
a scoping unit in which the common block or variable is declared.
[5.1] 2.14.7 Declare Target Directive
The directive must appear in the declaration section of a scoping unit
in which the common block or variable is declared.
```
Reviewed By: kiranchandramohan, shraiysh, NimishMishra
Differential Revision: https://reviews.llvm.org/D125767
Denis Antrushin [Wed, 1 Jun 2022 11:58:32 +0000 (18:58 +0700)]
[TwoAddressInstructionPass] Relax assert in statepoint processing.
D124631 added special processing for STATEPOINT instructions.
It appears that assertion added there is too strong. We can get two
tied operands with the same register tied to different defs. If we
hit such case, do not process it in statepoint-specific code and
delegate it to common case.
Simon Pilgrim [Wed, 1 Jun 2022 14:28:11 +0000 (15:28 +0100)]
[ARM] uxtb.ll - adjust armv6 triple so the update_llc_test_checks.py script can be used to regenerate the tests
No need to specify armv6-apple-darwin in these UXTB codegen tests
Simon Pilgrim [Wed, 1 Jun 2022 14:25:58 +0000 (15:25 +0100)]
[ARM][Thumb2] Refresh UXTB16 tests to match optimized IR from instcombine
As discussed on D77804, instcombine will have already performed a similar SimplifyMultipleUseDemandedBits call which will break the UXTB16 pattern that was being match in these DAG tests
I've updated the existing tests so that it match the instcombine IR (with a suitable FIXME) and added an equivalent test pattern suggested by @dmgreen
Balazs Benics [Wed, 1 Jun 2022 14:12:54 +0000 (16:12 +0200)]
[analyzer] Fix wrong annotation of PointerToMemberData
Unfortunately I don't have a reproducer for this.
Reported by @mikaelholmen!
Differential Revision: https://reviews.llvm.org/D126198
Simon Pilgrim [Wed, 1 Jun 2022 14:09:37 +0000 (15:09 +0100)]
[X86] LowerVSETCC - merge getConstant() calls with flipped/unflipped sign masks. NFCI.
Sanjay Patel [Wed, 1 Jun 2022 13:46:29 +0000 (09:46 -0400)]
[x86] fix miscompile from wrongly identified fneg
We may need to peek through a bitcast when identifying an fneg idiom
via its pool constant, but we can't allow a different-sized constant
in that match.
This is noted in issue #55758 with an example that needs fast-math,
but as the test here shows, this has potential to miscompile more
generally (no fast-math required).
Differential Revision: https://reviews.llvm.org/D126775
Guillaume Chatelet [Wed, 1 Jun 2022 13:53:36 +0000 (13:53 +0000)]
[libc] fix typo in BUILD.bazel feature
Matt Arsenault [Wed, 27 Apr 2022 00:35:01 +0000 (20:35 -0400)]
CodeGen: Move getAddressSpaceForPseudoSourceKind into TargetMachine
Avoid the dependency on TargetInstrInfo, which depends on the subtarget
and therefore the individual function.
Currently AMDGPU is constructing PseudoSourceValue instances in MachineFunctionInfo.
In order to facilitate copying MachineFunctionInfo, we need to stop allocating these
there. Alternatively we could allow targets to subclass PseudoSourceValueManager,
and allocate them similarly to MachineFunctionInfo.
Sanjay Patel [Wed, 1 Jun 2022 12:05:35 +0000 (08:05 -0400)]
[x86] add test for mismatched fneg; NFC
issue #55758
Guillaume Chatelet [Wed, 1 Jun 2022 11:57:11 +0000 (11:57 +0000)]
[libc] Apply no-builtin everywhere, remove unnecessary flags
Note, this is a re-submission of D125894 with `features = ["-header_modules"]`
added to the main BUILD.bazel file.
Some functions like `stpncpy` are implemented in terms of `memset` but are not
currently using `-fno-builtin-memset`. This is somewhat hidden by the fact that
we use `-ffreestanding` globally and that `-ffreestanding` implies
`-fno-builtin` for Clang.
This patch also removes `-mllvm -combiner-global-alias-analysis` that is Clang
specific and that does not bring substantial gains on modern processors.
Also we keep `-mllvm --tail-merge-threshold=0` for aarch64 in CMakeLists.txt
but we omit it in the Bazel config. This is because Bazel consumes the source
files directly and so it can use PGO to take optimal decisions locally.
Differential Revision: https://reviews.llvm.org/D126773
Mikhail Goncharov [Wed, 1 Jun 2022 13:30:10 +0000 (15:30 +0200)]
Fix potentially uninitialized memory
For https://github.com/llvm/llvm-project/commit/
7d76d6095880f34914d85d876b260cc4a4ea640d
Alexander Kornienko [Wed, 1 Jun 2022 12:27:14 +0000 (14:27 +0200)]
Revert "[LAA] Initial support for runtime checks with pointer selects."
This reverts commit
5890b30105999a137e72e42f3760bebfd77001ca as per discussion
on the review thread: https://reviews.llvm.org/D114487#3547560.
LLVM GN Syncbot [Wed, 1 Jun 2022 13:19:42 +0000 (13:19 +0000)]
[gn build] Port
a0dcbe45bd83
LLVM GN Syncbot [Wed, 1 Jun 2022 13:19:41 +0000 (13:19 +0000)]
[gn build] Port
2011052150e1
Matt Arsenault [Wed, 20 Apr 2022 15:37:53 +0000 (11:37 -0400)]
llvm-reduce: Add reduction pass to remove regalloc hints
I'm a bit confused by what's actually stored for the allocation
hints. The MIR parser only handles the "simple" case where there's a
single hint. I don't really understand the assertion in
clearSimpleHint, or under what circumstances there are multiple hint
registers.
Matt Arsenault [Tue, 19 Apr 2022 20:42:27 +0000 (16:42 -0400)]
llvm-reduce: Add pass to reduce MIR instruction flags
Florian Hahn [Wed, 1 Jun 2022 12:30:32 +0000 (13:30 +0100)]
[LAA] Remove unused RuntimeCheckingPtrGroup constructor (NFC).
The constructor is not used. Remove it.
Alexander Kornienko [Wed, 1 Jun 2022 10:27:53 +0000 (12:27 +0200)]
Revert "[InstCombine] Combine instructions of type or/and where AND masks can be combined."
This reverts commit
ec4adf1f6c333d3d36663d8f763c0896407f1b61. The commit causes
clang to hang on a certain input:
```
$ cat q.cc
int f(int a, int b) {
int c = ((unsigned char)(a >> 23) & 925);
if (a)
c = (a >> 23 & b) | ((unsigned char)(a >> 23) & 925) | (b >> 23 & 157);
return c;
}
$ time ./clang-15-10515 --target=x86_64--linux-gnu -O1 -c q.cc
^C
real 0m45.072s
user 0m0.025s
sys 0m0.099s
```
Kiran Chandramohan [Wed, 1 Jun 2022 11:48:20 +0000 (11:48 +0000)]
[Flang] Lower the infinite do loop
The basic infinite loop is lowered to a branch to the body of the
loop, and the body containing a back edge as its terminator.
Note: This is part of upstreaming from the fir-dev branch of
https://github.com/flang-compiler/f18-llvm-project.
Reviewed By: rovka
Differential Revision: https://reviews.llvm.org/D126697
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Co-authored-by: V Donaldson <vdonaldson@nvidia.com>
Haojian Wu [Wed, 1 Jun 2022 11:42:46 +0000 (13:42 +0200)]
[pseudo] Build inc files when cxx.bnf changes.
Add the cxx.bnf file as a dependency of custom gen commands, so that the
inc files can be rebuilt when cxx.bnf changes.
Simon Pilgrim [Wed, 1 Jun 2022 11:31:18 +0000 (12:31 +0100)]
[X86] Fix typo in extraction type introduced in rGed0303aa2251e4484a2b4ff7f236c9f7cdfb2092
It doesn't look like we have test coverage for this at the moment :(